Use deduction guides instead of helper functions.
The only non-automatic changes have been:
- ArrayRef(some_uint8_pointer, 0) needs to be changed into ArrayRef(some_uint8_pointer, (size_t)0) to avoid an ambiguous call with ArrayRef((uint8_t*), (uint8_t*))
- CVSymbol sym(makeArrayRef(symStorage)); needed to be rewritten as CVSymbol sym{ArrayRef(symStorage)}; otherwise the compiler is confused and thinks we have a (bad) function prototype. There was a few similar situation across the codebase.
- ADL doesn't seem to work the same for deduction-guides and functions, so at some point the llvm namespace must be explicitly stated.
- The "reference mode" of makeArrayRef(ArrayRef<T> &) that acts as no-op is not supported (a constructor cannot achieve that).
This is a follow-up to https://reviews.llvm.org/D140896 that introduced the deduction guides.
It seems that in such cases we can remove the explicit ArrayRef(...) around Table here right ?
(I wonder if a clang-tidy check could detect this maybe?)