- User Since
- Apr 30 2013, 5:34 PM (293 w, 1 d)
Mon, Nov 26
Sun, Nov 25
(should fix PR39780 https://bugs.llvm.org/show_bug.cgi?id=39780 )
Oct 22 2018
If we go with this document moving forward, I would first purge it so that it reflects the current situation. Otherwise we could also just archive it and start a new one with the actual action plan.
I feel adding more stuff here will be a bit confusing moving forward.
Sep 13 2018
Sep 10 2018
@kristina both bfd and lld are adding the .a extension when you pass a lib through -l. Similarly to -llibfoo won't work, -lfoo.a will lead the linker to look for libfoo.a.a
Aug 20 2018
Aug 16 2018
Aug 8 2018
Jul 31 2018
I'm worried, however, about generating a bunch more code than needed from clang in the hopes that the compiler will clean it up later.
Jul 30 2018
I'm curious: isn't the kind of optimization we should expect LLVM to provide?
Jul 25 2018
but declarations cannot be internal.
Jul 10 2018
std::map is usually fairly slow, have you considered sorting at the time you write to the file instead? That would add a slow step when writing the files but wouldn't affect any in-memory operation.
Feb 19 2018
Feb 16 2018
@hans : this needs to go in LLVM 6.0, is it OK?
Feb 15 2018
I quickly put a patch to change the encoding, may be easier to discuss with code at hand: https://reviews.llvm.org/D43348
(I didn't try to build it, just a quick draft)
Feb 14 2018
Feb 13 2018
Actually if we're making this change, we consider that bitcode generated between the introduction of the new fast-math flags and now isn't supported anymore.
If so then we could instead of bumping a version, change the encoding of the FMF record (or create a new record type), so that the old encoding is upgraded but not the new one.
That would seem to me to be more in line with the usual handling of such situation in the bitcode.
Feb 6 2018
Jan 13 2018
Jan 12 2018
Jan 10 2018
Jan 9 2018
The test still seems complex to me (do you need all the IR types? The code in the functions? And all these metadatas and metadata fields?
Dec 29 2017
Dec 21 2017
Dec 18 2017
Dec 15 2017
However small changes in input, could trigger combined module and shuffle outputs making life of llvm::LTO harder.
I suspect it should be possible to do this after the ThinLink and add notation about the importing decision, promotion, dead-elimination, ... on every edge/nodes.
This patch doesn't seem motivated, the only effect I can see is that a ThinLTO link that don't include any LTO module would create a module while it was lazily created only if needed before.
Dec 14 2017
The commit message does not make much sense to me in the context of this C++ API: there is a non-negligible layer between the build and the build system rules and the LTO implementation, i.e. the linker.
Implementing a contract that makes it convenient for your build system in the implementation of the LTO "engine" behind this API looks like leaking abstractions to me.
Dec 8 2017
I wrote this code in April 2016 ( http://reviews.llvm.org/D19103 ), in the very first approach to internalization, which was inferred in the backend and wasn't bullet proof (especially with respect to assembly by the way).
Since then, we moved all decision in the thin-link and this code is indeed (hopefully) dead.
Nov 14 2017
Did you check clang?
Nov 13 2017
Was this done using clang-tidy (or similar tool) or manually?
Nov 7 2017
Oh ok, this is different than what thought the issue was. There isn't a correctness problem with this - the reference edge ensures correctness. It sounds like the only correctness issue then was due to the ld64 issue. (I thought there was also an issue with getting @f promoted when @ext was imported.) There isn't really a correctness issue with having both a reference and call edge though. Ideally we would have just the call edge and no reference edge, but that goes back to the earlier suggestion you had tried (changing the call site to look through pointer casts which had other issues). So I think this is fine. Sorry for the confusion.
Nov 6 2017
Nov 3 2017
Nov 2 2017
Oct 31 2017
Oct 27 2017
Oct 26 2017
Oct 11 2017
Oct 2 2017
Oct 1 2017
Sep 28 2017
Sep 27 2017
Ideally, I think all the headers would hide the method behind #ifdef LLVM_ENABLE_DUMP , so that it wouldn't be a linker failure but a compile time failure!
Thanks for fixing this :)
Sep 26 2017
Can you elaborate why this script is desirable/needed?
Sep 18 2017
Sep 17 2017
Did you check ld64 in Xcode 9? I think ld64 was fixed to append the suffix as well.
Sep 4 2017
Sep 1 2017
Aug 31 2017