Page MenuHomePhabricator

mehdi_amini (Mehdi AMINI)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2013, 5:34 PM (387 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

mehdi_amini accepted D88587: [mlir][openacc] Remove -allow-unregistred-dialect from ops and invalid tests.

Thanks!

Wed, Sep 30, 9:21 AM · Restricted Project

Tue, Sep 29

mehdi_amini committed rG1c5aa8aeca29: [mlir] Update docs referencing OpTrait::Symbol. (authored by scotttodd).
[mlir] Update docs referencing OpTrait::Symbol.
Tue, Sep 29, 8:56 PM
mehdi_amini closed D88512: [mlir] Update docs referencing OpTrait::Symbol..
Tue, Sep 29, 8:56 PM · Restricted Project
mehdi_amini added a comment to D88512: [mlir] Update docs referencing OpTrait::Symbol..

(you local commit is based of f20918b4b15 apparently)

Tue, Sep 29, 8:41 PM · Restricted Project
mehdi_amini added a comment to D88512: [mlir] Update docs referencing OpTrait::Symbol..

Arc says " INFO Base commit is not in local repository; trying to fetch." ; seems like you have local changes?

Tue, Sep 29, 8:40 PM · Restricted Project
mehdi_amini accepted D88510: [MLIR] Add async.value type to Async dialect.
Tue, Sep 29, 1:47 PM · Restricted Project
mehdi_amini updated the diff for D88362: Implement callee/caller type checking for llvm.call.

Rebase, test is passing so removing XFAIL

Tue, Sep 29, 1:23 PM · Restricted Project
mehdi_amini added inline comments to D88362: Implement callee/caller type checking for llvm.call.
Tue, Sep 29, 1:22 PM · Restricted Project
mehdi_amini committed rGeff9984dca03: Fix TODO in the mlir-cpu-runner/bare_ptr_call_conv.mlir test: call ops in bare… (authored by mehdi_amini).
Fix TODO in the mlir-cpu-runner/bare_ptr_call_conv.mlir test: call ops in bare…
Tue, Sep 29, 1:21 PM
mehdi_amini added inline comments to D88362: Implement callee/caller type checking for llvm.call.
Tue, Sep 29, 1:19 PM · Restricted Project
mehdi_amini added inline comments to D88510: [MLIR] Add async.value type to Async dialect.
Tue, Sep 29, 1:08 PM · Restricted Project
mehdi_amini added inline comments to D88272: [mlir][openacc] Add shutdown operation.
Tue, Sep 29, 12:42 PM · Restricted Project
mehdi_amini added inline comments to D88272: [mlir][openacc] Add shutdown operation.
Tue, Sep 29, 11:53 AM · Restricted Project
mehdi_amini added inline comments to D88426: Adds MLIR C-API for marshaling Python capsules..
Tue, Sep 29, 11:29 AM · Restricted Project
mehdi_amini added inline comments to D88459: [MLIR] Add Async dialect with trivial async.region operation.
Tue, Sep 29, 11:25 AM · Restricted Project
mehdi_amini added inline comments to D87159: Add GDB prettyprinters for a few more MLIR types..
Tue, Sep 29, 11:20 AM · Restricted Project
mehdi_amini added a comment to D88486: [mlir] LLVM dialect: verify that a direct llvm.call refers to a declared function.

Seems like a subset of https://reviews.llvm.org/D88362 ? Seems like you missed it?

Tue, Sep 29, 10:34 AM · Restricted Project
mehdi_amini added a comment to D88484: [mlir] Fix shared libs build.

Thanks for the fix!

Tue, Sep 29, 10:30 AM · Restricted Project

Mon, Sep 28

mehdi_amini added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

I suspect we're getting into "vocabulary" here, but I still call this "assert" even though they aren't technically: I actually write it this way https://github.com/llvm/llvm-project/blob/master/mlir/include/mlir/IR/OpDefinition.h#L1274-L1279

Mon, Sep 28, 8:58 PM · Restricted Project
mehdi_amini abandoned D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.
Mon, Sep 28, 7:27 PM · Restricted Project
mehdi_amini added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

But you mention this is to guard a case in the generated parser, why can't we
insert verification & return there? Parsing returns an error and all, and
so if detected there then we already have error propagation path.

Mon, Sep 28, 7:26 PM · Restricted Project
mehdi_amini added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

Ultimately the only difference between assert vs report_fatal_error is whether it is checked in production and how much it'll be in the path of the runtime execution and binary size, otherwise neither is recoverable.
Some users of LLVM ship clang in production with asserts enabled, if you care about always having checks enabled, that's likely the way to go.

Mon, Sep 28, 6:35 PM · Restricted Project
mehdi_amini committed rG9f9f89d44beb: Remove dependency from LLVM Dialect on the OpenMP dialect (authored by mehdi_amini).
Remove dependency from LLVM Dialect on the OpenMP dialect
Mon, Sep 28, 6:12 PM
mehdi_amini closed D88351: Remove dependency from LLVM Dialect on the OpenMP dialect.
Mon, Sep 28, 6:12 PM · Restricted Project
mehdi_amini accepted D88459: [MLIR] Add Async dialect with trivial async.region operation.

LG but please wait for @herhut to have a look

Mon, Sep 28, 6:11 PM · Restricted Project
mehdi_amini added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

Yes this is more defensive than what is usually done in LLVM, for example we don't re-check everywhere the invariant that are supposed to be enforced by the verifier: even though you can invoke a pass on invalid IR.

Mon, Sep 28, 5:39 PM · Restricted Project
mehdi_amini committed rGe72d792c147e: Guard `find_library(tensorflow_c_api ...)` by checking for… (authored by mehdi_amini).
Guard `find_library(tensorflow_c_api ...)` by checking for…
Mon, Sep 28, 3:16 PM
mehdi_amini closed D88371: Guard `find_library(tensorflow_c_api ...)` by checking for TENSORFLOW_C_LIB_PATH to be set by the user.
Mon, Sep 28, 3:16 PM · Restricted Project
mehdi_amini added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

I have a somewhat growing concern over the inconsistent use of error handling mechanism (assert vs report_fatal_error).

Mon, Sep 28, 3:13 PM · Restricted Project
mehdi_amini updated the diff for D88371: Guard `find_library(tensorflow_c_api ...)` by checking for TENSORFLOW_C_LIB_PATH to be set by the user.

Remove the new option and rely on TENSORFLOW_C_LIB_PATH to be set instead

Mon, Sep 28, 2:04 PM · Restricted Project
mehdi_amini added a comment to D88371: Guard `find_library(tensorflow_c_api ...)` by checking for TENSORFLOW_C_LIB_PATH to be set by the user.

There are 2 types of TF dependencies, orthogonal from each other, controlled by TENSORFLOW_AOT_PATH and TENSORFLOW_C_LIB_PATH, respectively.

The former should already provide the desired behavior.

Mon, Sep 28, 1:46 PM · Restricted Project
mehdi_amini accepted D88426: Adds MLIR C-API for marshaling Python capsules..
Mon, Sep 28, 1:00 PM · Restricted Project

Sun, Sep 27

mehdi_amini accepted D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..

Awesome, thanks!

Sun, Sep 27, 11:47 AM · Restricted Project
mehdi_amini added inline comments to D88376: [MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax.
Sun, Sep 27, 9:44 AM · Restricted Project

Sat, Sep 26

mehdi_amini updated the summary of D88371: Guard `find_library(tensorflow_c_api ...)` by checking for TENSORFLOW_C_LIB_PATH to be set by the user.
Sat, Sep 26, 8:26 PM · Restricted Project
mehdi_amini requested review of D88371: Guard `find_library(tensorflow_c_api ...)` by checking for TENSORFLOW_C_LIB_PATH to be set by the user.
Sat, Sep 26, 8:21 PM · Restricted Project
mehdi_amini updated the diff for D88362: Implement callee/caller type checking for llvm.call.

Replace some auto with explicit types

Sat, Sep 26, 10:24 AM · Restricted Project
mehdi_amini added inline comments to D88362: Implement callee/caller type checking for llvm.call.
Sat, Sep 26, 10:16 AM · Restricted Project
mehdi_amini added a reviewer for D88362: Implement callee/caller type checking for llvm.call: dcaballe.
Sat, Sep 26, 10:16 AM · Restricted Project
mehdi_amini removed a reviewer for D88351: Remove dependency from LLVM Dialect on the OpenMP dialect: dcaballe.
Sat, Sep 26, 10:15 AM · Restricted Project
mehdi_amini added a reviewer for D88351: Remove dependency from LLVM Dialect on the OpenMP dialect: dcaballe.
Sat, Sep 26, 10:15 AM · Restricted Project
mehdi_amini requested review of D88362: Implement callee/caller type checking for llvm.call.
Sat, Sep 26, 10:14 AM · Restricted Project

Fri, Sep 25

mehdi_amini committed rG76419525fba6: Common code preparation for tblgen-types patch (authored by jdd).
Common code preparation for tblgen-types patch
Fri, Sep 25, 7:48 PM
mehdi_amini closed D88267: Common code preparation for tblgen-types patch.
Fri, Sep 25, 7:48 PM · Restricted Project, Restricted Project
mehdi_amini updated the summary of D88351: Remove dependency from LLVM Dialect on the OpenMP dialect.
Fri, Sep 25, 7:15 PM · Restricted Project
mehdi_amini requested review of D88351: Remove dependency from LLVM Dialect on the OpenMP dialect.
Fri, Sep 25, 7:14 PM · Restricted Project
mehdi_amini added a comment to D88341: [mlir][vector] First step of vector distribution transformation.

In general the semantics of this op isn't clear to me. It seems that we "hide" the SIMT aspect by "faking" a scalar computation.
Have you looked into structuring this in a region instead?

Fri, Sep 25, 4:42 PM · Restricted Project
mehdi_amini requested review of D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.
Fri, Sep 25, 3:37 PM · Restricted Project

Thu, Sep 24

mehdi_amini added inline comments to D88251: [MLIR] Move TestDialect to ::test namespace.
Thu, Sep 24, 9:18 PM · Restricted Project
mehdi_amini accepted D88251: [MLIR] Move TestDialect to ::test namespace.

LGTM on the principle, whenever you get it to work :)

Thu, Sep 24, 9:06 PM · Restricted Project
mehdi_amini accepted D88267: Common code preparation for tblgen-types patch.
Thu, Sep 24, 8:57 PM · Restricted Project, Restricted Project
mehdi_amini committed rG960535d65a92: Hint how to get a symbolized stack trace if llvm-symbolizer is not found on… (authored by mehdi_amini).
Hint how to get a symbolized stack trace if llvm-symbolizer is not found on…
Thu, Sep 24, 6:56 PM
mehdi_amini closed D88269: Indicate that we print the non-symbolized stack trace and information about how to get it symbolized.
Thu, Sep 24, 6:56 PM · Restricted Project
mehdi_amini requested review of D88269: Indicate that we print the non-symbolized stack trace and information about how to get it symbolized.
Thu, Sep 24, 4:56 PM · Restricted Project
mehdi_amini accepted D88162: [mlir] Expose Dialect class and registration/loading to C API.
Thu, Sep 24, 4:16 PM · Restricted Project
mehdi_amini added a comment to D88242: [NFC] Fix minor typos in comments and reuse concreteOp..

I'm perfectly fine if you push such trivial fixes without code review FYI

Thu, Sep 24, 4:10 PM · Restricted Project
mehdi_amini accepted D88242: [NFC] Fix minor typos in comments and reuse concreteOp..
Thu, Sep 24, 4:10 PM · Restricted Project
mehdi_amini committed rG55bb1ba0fdd3: Add support for setting the path to llvm-symbolizer through an environment… (authored by mehdi_amini).
Add support for setting the path to llvm-symbolizer through an environment…
Thu, Sep 24, 12:14 PM
mehdi_amini closed D88192: Add support for setting the path to llvm-symbolizer through an environment variable.
Thu, Sep 24, 12:14 PM · Restricted Project
mehdi_amini accepted D88171: [NFC] Fix syntax of ranked memrefs in the MLIR Language Reference..
Thu, Sep 24, 12:13 PM · Restricted Project
mehdi_amini added a comment to D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..

@mehdi_amini , can you take a look? River doesn't seem to be around atm.

Thu, Sep 24, 12:11 PM · Restricted Project

Wed, Sep 23

mehdi_amini updated the diff for D88192: Add support for setting the path to llvm-symbolizer through an environment variable.

Address comments

Wed, Sep 23, 10:44 PM · Restricted Project
mehdi_amini updated the diff for D88192: Add support for setting the path to llvm-symbolizer through an environment variable.

Tweak variable name

Wed, Sep 23, 6:25 PM · Restricted Project
mehdi_amini requested review of D88192: Add support for setting the path to llvm-symbolizer through an environment variable.
Wed, Sep 23, 6:20 PM · Restricted Project
mehdi_amini added inline comments to D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..
Wed, Sep 23, 2:37 PM · Restricted Project
mehdi_amini accepted D88147: [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp..
Wed, Sep 23, 12:02 PM · Restricted Project
mehdi_amini committed rGd14cfe103416: [mlir][OpFormatGen] Update "custom" directives for attributes. (authored by mikeurbach).
[mlir][OpFormatGen] Update "custom" directives for attributes.
Wed, Sep 23, 11:34 AM
mehdi_amini closed D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..
Wed, Sep 23, 11:33 AM · Restricted Project
mehdi_amini committed rG5281ba1994bd: Document the `--verbatim` flag from arc to update the description for a… (authored by mehdi_amini).
Document the `--verbatim` flag from arc to update the description for a…
Wed, Sep 23, 11:01 AM
mehdi_amini committed rG55f5a0137f5b: Update Phabricator doc to remove the warning on "arc land": tags a properly… (authored by mehdi_amini).
Update Phabricator doc to remove the warning on "arc land": tags a properly…
Wed, Sep 23, 11:01 AM
mehdi_amini added inline comments to D88147: [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp..
Wed, Sep 23, 10:04 AM · Restricted Project
mehdi_amini added inline comments to D88162: [mlir] Expose Dialect class and registration/loading to C API.
Wed, Sep 23, 10:01 AM · Restricted Project
mehdi_amini added inline comments to D88135: [MLIR] Avoid adding debuginfo for a function if it contains calls that has no debug info..
Wed, Sep 23, 9:51 AM · Restricted Project
mehdi_amini committed rGf6aceb72d6b2: Update the documentation for the MLIR Dialect class (NFC) (authored by mehdi_amini).
Update the documentation for the MLIR Dialect class (NFC)
Wed, Sep 23, 9:16 AM

Tue, Sep 22

mehdi_amini committed rGfe3c1195cfd0: Add a dump() method on the pass manager for debugging purpose (NFC) (authored by mehdi_amini).
Add a dump() method on the pass manager for debugging purpose (NFC)
Tue, Sep 22, 10:54 PM
mehdi_amini closed D88008: Add a dump() method on the pass manager for debugging purpose (NFC).
Tue, Sep 22, 10:54 PM · Restricted Project
mehdi_amini accepted D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

It wasn't clear from the description that this is actually fixing something that wasn't working, can you update the description in the commit?

Tue, Sep 22, 10:48 PM · Restricted Project
mehdi_amini added inline comments to D88125: [mlir][openacc] Add wait operation.
Tue, Sep 22, 10:41 PM · Restricted Project
mehdi_amini added a comment to D87063: [BitcodeReader] Fix O(N^2) in placeholder replacement algorithm..

I tried to review, but I'm too unfamiliar with this code at this point and won't have enough time to page-in the existing one and review the new one.

Tue, Sep 22, 10:39 PM · Restricted Project
mehdi_amini committed rGaf429cd89bf8: [NFC][docs] Fix link. (authored by antonio-cortes-perez).
[NFC][docs] Fix link.
Tue, Sep 22, 4:40 PM
mehdi_amini closed D88116: [NFC][docs] Fix link..
Tue, Sep 22, 4:40 PM · Restricted Project
mehdi_amini accepted D88116: [NFC][docs] Fix link..
Tue, Sep 22, 4:27 PM · Restricted Project
mehdi_amini committed rGfb1de7ed921c: Implement a new kind of Pass: dynamic pass pipeline (authored by mehdi_amini).
Implement a new kind of Pass: dynamic pass pipeline
Tue, Sep 22, 11:52 AM
mehdi_amini added a comment to D88091: [MLIR][Standard] Add `atan` to standard dialect.

I can't find a discussion and rationale on Discourse, was this discussed?
LLVM does not have intrinsics for atan I believe, it is just a libcall: what is the tradeoff about adding it to standard here?

Tue, Sep 22, 10:19 AM · Restricted Project

Mon, Sep 21

mehdi_amini committed rG385c3f43fceb: Implement a new kind of Pass: dynamic pass pipeline (authored by mehdi_amini).
Implement a new kind of Pass: dynamic pass pipeline
Mon, Sep 21, 6:25 PM
mehdi_amini closed D86392: Implement a new kind of Pass: dynamic pass pipeline.
Mon, Sep 21, 6:24 PM · Restricted Project
mehdi_amini requested changes to D88053: [MLIR] add support for dialect loading in mlir-translate.

This is supposed to be handled in the translate registration themselves: https://github.com/llvm/llvm-project/blob/master/mlir/lib/Dialect/SPIRV/Serialization/TranslateRegistration.cpp#L175

Mon, Sep 21, 4:34 PM · Restricted Project
mehdi_amini requested review of D88008: Add a dump() method on the pass manager for debugging purpose (NFC).
Mon, Sep 21, 2:41 AM · Restricted Project
mehdi_amini committed rG702f06ad14ac: Fix crash in the pass pipeline when local reproducer is enabled (authored by mehdi_amini).
Fix crash in the pass pipeline when local reproducer is enabled
Mon, Sep 21, 1:53 AM
mehdi_amini closed D88000: Fix crash in the pass pipeline when local reproducer is enabled.
Mon, Sep 21, 1:53 AM · Restricted Project

Sun, Sep 20

mehdi_amini requested review of D88000: Fix crash in the pass pipeline when local reproducer is enabled.
Sun, Sep 20, 11:45 PM · Restricted Project
mehdi_amini committed rGdabe67948841: Add missing new line after debug logging in MLIRContext (NFC) (authored by mehdi_amini).
Add missing new line after debug logging in MLIRContext (NFC)
Sun, Sep 20, 10:56 PM
mehdi_amini added a comment to D86779: [MLIR][Shape] Merge `shape` to `std`/`scf` lowerings..
Sun, Sep 20, 9:03 PM · Restricted Project

Sat, Sep 19

mehdi_amini accepted D87969: [mlir] Add tutorial index.md pages.

Thanks!

Sat, Sep 19, 5:29 PM · Restricted Project

Fri, Sep 18

mehdi_amini accepted D87955: [MLIR][NFC] Adopt use of BlockRange in place of ArrayRef<Block *>.

Thanks!

Fri, Sep 18, 5:32 PM · Restricted Project

Thu, Sep 17

mehdi_amini added a comment to Image Macro "pictureofanit".

pictureofanit

Thu, Sep 17, 4:33 PM
mehdi_amini added a comment to Image Macro "pictureofanit".

nit

Thu, Sep 17, 4:33 PM

Tue, Sep 15

mehdi_amini committed rG37c5dbb31a2f: Fully qualify some more namespace in MLIR ODS to be more friendly to dialects… (authored by mehdi_amini).
Fully qualify some more namespace in MLIR ODS to be more friendly to dialects…
Tue, Sep 15, 8:42 PM
mehdi_amini accepted D87670: [MLIR][NFC] Value print update for block arguments.
Tue, Sep 15, 12:49 AM · Restricted Project

Mon, Sep 14

mehdi_amini committed rG1dac073bdd95: Fix MLIR standalone example to properly handle namespace (authored by mehdi_amini).
Fix MLIR standalone example to properly handle namespace
Mon, Sep 14, 2:04 PM