Page MenuHomePhabricator

mehdi_amini (Mehdi AMINI)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2013, 5:34 PM (404 w, 23 h)
Roles
Administrator

Recent Activity

Today

mehdi_amini updated subscribers of D93280: Add a "kind" attribute to ContractionOp and OuterProductOp..
Wed, Jan 27, 2:53 PM · Restricted Project
mehdi_amini added inline comments to D95399: [flang][fir] Upstream FIR dialect changes..
Wed, Jan 27, 2:44 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini accepted D95533: [mlir][NFC] Add missing include guards to MlirOptMain.h.

LG with fixing the wording as Alex suggests (and clang-tidy flags)

Wed, Jan 27, 1:55 PM · Restricted Project
mehdi_amini added a comment to D95418: Introduce a new DialectIdentifier structure, extending Identifier with a Dialect information.

Oh I see what you mean, we'd replace the current llvm::StringSet<llvm::BumpPtrAllocator &> identifiers; in the MLIRContext with something like llvm::StringMap<Dialect*, llvm::BumpPtrAllocator &> identifiers;?
(probably a bit more complex, but that's the rough direction?)

Wed, Jan 27, 1:49 PM · Restricted Project
mehdi_amini added a comment to D95386: Fix namespace for MLIR Async Runtime.

This patch is fine, but I'd still be interested to understand if this could be made to show up during check-mlir with one of the Cmake configuration that can run on Windows?

Wed, Jan 27, 11:04 AM · Restricted Project

Yesterday

mehdi_amini accepted D95493: [mlir][PassManager] Only reinitialize the pass manager if the context registry changes.
Tue, Jan 26, 8:29 PM · Restricted Project
mehdi_amini added a comment to D95418: Introduce a new DialectIdentifier structure, extending Identifier with a Dialect information.

Some Locations may be using Identifier like in FileLineColLocationStorage.
An OperationName would get larger as well I think, which would make Operation larger by one pointer (it'd accelerate Operation::getDialect() for unregistered operations, but I don't think we need to optimize this)

Tue, Jan 26, 6:09 PM · Restricted Project
mehdi_amini added a comment to D95418: Introduce a new DialectIdentifier structure, extending Identifier with a Dialect information.

Isn't it still just an Identifier? The dialect was always there, it was just previously encoded in the string and is now separate

Tue, Jan 26, 5:52 PM · Restricted Project
mehdi_amini added inline comments to D95399: [flang][fir] Upstream FIR dialect changes..
Tue, Jan 26, 1:32 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jan 25

mehdi_amini requested review of D95418: Introduce a new DialectIdentifier structure, extending Identifier with a Dialect information.
Mon, Jan 25, 10:08 PM · Restricted Project
mehdi_amini added a comment to D95394: Add a new Dialect interface to control implicit attribute propagation..

This seems to me like a 'tip of the iceberg' kind of solution. What happens if the attribute needs to be transformed? What happens if there is not a 1:1 correspondance between input operations and output operations in a transformation?

Mon, Jan 25, 8:00 PM · Restricted Project
mehdi_amini accepted D95317: [mlir][Linalg] Drop SliceOp.
Mon, Jan 25, 5:23 PM · Restricted Project
mehdi_amini added a comment to D95317: [mlir][Linalg] Drop SliceOp.

Thanks for the cleanup!

Mon, Jan 25, 5:23 PM · Restricted Project
mehdi_amini added inline comments to D95399: [flang][fir] Upstream FIR dialect changes..
Mon, Jan 25, 5:18 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D95378: [mlir] sret and byval now require a type argument when constructed.

You can search in mlir/test for test that invoke mlir-translate with -mlir-to-llvmir

Mon, Jan 25, 4:23 PM · Restricted Project
mehdi_amini added a comment to D95399: [flang][fir] Upstream FIR dialect changes..

Thanks! It is exciting to start seeing the FIR change coming upstream!

Mon, Jan 25, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D92898: [mlir][OpInterfaces] Add support for generating a DialectInterface fallback for OpInterfaces.

I know there was another prototype in this region, does that subsume this?

Mon, Jan 25, 2:09 PM · Restricted Project
mehdi_amini requested review of D95394: Add a new Dialect interface to control implicit attribute propagation..
Mon, Jan 25, 2:02 PM · Restricted Project

Sun, Jan 24

mehdi_amini accepted D95311: [mlir] Async: add a separate pass to lower from async to async.coro and async.runtime.
Sun, Jan 24, 4:27 PM · Restricted Project
mehdi_amini accepted D95320: [mlir][Python] Roll up of python API fixes..
Sun, Jan 24, 4:17 PM · Restricted Project

Sat, Jan 23

mehdi_amini accepted D94638: [mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites.
Sat, Jan 23, 12:06 PM · Restricted Project

Fri, Jan 22

mehdi_amini accepted D95283: [mlir][CAPI] Add result type inference to the CAPI..
Fri, Jan 22, 7:21 PM · Restricted Project
mehdi_amini accepted D95143: [mlir] Add coro intrinsics operations to LLVM dialect.
Fri, Jan 22, 9:41 AM · Restricted Project

Thu, Jan 21

mehdi_amini accepted D95201: Add more explicit assert for failures.

LGTM
(fix the description before pushing)

Thu, Jan 21, 9:15 PM · Restricted Project
mehdi_amini accepted D94868: [mlir] Enable passing crash reproducer stream factory method.

LGTM with a minor tweak on FileReproducerStream

Thu, Jan 21, 3:20 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method..
Thu, Jan 21, 2:52 PM · Restricted Project
mehdi_amini committed rG922b26cde4d1: Add Python bindings for the builtin dialect (authored by mehdi_amini).
Add Python bindings for the builtin dialect
Thu, Jan 21, 2:50 PM
mehdi_amini closed D95022: Add Python bindings for the builtin dialect.
Thu, Jan 21, 2:50 PM · Restricted Project
mehdi_amini added a comment to D95022: Add Python bindings for the builtin dialect.

Landing now, feel free to add more comments as needed!

Thu, Jan 21, 2:43 PM · Restricted Project

Wed, Jan 20

mehdi_amini updated the diff for D95022: Add Python bindings for the builtin dialect.

Add a body_builder callback

Wed, Jan 20, 8:17 PM · Restricted Project
mehdi_amini committed rG8a7ff7301a6c: [mlir] Make MLIRContext::getOrLoadDialect(StringRef, TypeID, ...) public (authored by math-fehr).
[mlir] Make MLIRContext::getOrLoadDialect(StringRef, TypeID, ...) public
Wed, Jan 20, 4:30 PM
mehdi_amini closed D95091: [mlir] Make MLIRContext::getOrLoadDialect(StringRef, TypeID, ...) public.
Wed, Jan 20, 4:30 PM · Restricted Project
mehdi_amini added a comment to D95105: Implement constant folding for PowFOp.

Can you add a lit test for this?

Wed, Jan 20, 4:29 PM · Restricted Project
mehdi_amini added a comment to D94812: [mlir][python] Swap shape and element_type order for MemRefType..

LGTM

Wed, Jan 20, 3:43 PM · Restricted Project
mehdi_amini added a comment to D95091: [mlir] Make MLIRContext::getOrLoadDialect(StringRef, TypeID, ...) public.

Do you need me to land this for you?

Wed, Jan 20, 3:36 PM · Restricted Project
mehdi_amini accepted D95091: [mlir] Make MLIRContext::getOrLoadDialect(StringRef, TypeID, ...) public.
Wed, Jan 20, 3:04 PM · Restricted Project
mehdi_amini updated the diff for D95022: Add Python bindings for the builtin dialect.

Minor update to add_entry_block + test fix

Wed, Jan 20, 2:24 PM · Restricted Project
mehdi_amini added inline comments to D95022: Add Python bindings for the builtin dialect.
Wed, Jan 20, 2:19 PM · Restricted Project
mehdi_amini updated the diff for D95022: Add Python bindings for the builtin dialect.

Address comment, add more helpers/properties on FuncOp, extend the test

Wed, Jan 20, 2:18 PM · Restricted Project
mehdi_amini accepted D95077: [mlir] Remove complex ops from Standard dialect..

Thanks!

Wed, Jan 20, 1:28 PM · Restricted Project
mehdi_amini added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Wed, Jan 20, 1:27 PM · Restricted Project, Restricted Project
mehdi_amini accepted D95037: [mlir:async] Fix data races in AsyncRuntime.
Wed, Jan 20, 1:19 PM · Restricted Project
mehdi_amini added a comment to D95041: [MLIR][Standard] Add log1p operation to std.

Since the split of the standard dialect has begun, can you create a math dialect and move this kind of operations there?

Wed, Jan 20, 1:17 PM · Restricted Project

Tue, Jan 19

mehdi_amini requested review of D95022: Add Python bindings for the builtin dialect.
Tue, Jan 19, 9:54 PM · Restricted Project
mehdi_amini changed the edit policy for debug-info.
Tue, Jan 19, 8:22 PM
mehdi_amini added a comment to D94368: Enable python bindings for tensor, shape and linalg dialects..

We don't need to test completeness: i.e. no need to test every feature from ODS, just basic plumbing here (import and create / round-trip one or two ops), that's why I mentioned "smoke test".
I guess it'll be more useful with the registration aspect sorted out.

Tue, Jan 19, 7:59 PM · Restricted Project
mehdi_amini added a comment to D94368: Enable python bindings for tensor, shape and linalg dialects..

I think it'd be preferable to write basic smoke tests for the bindings when adding these.

Tue, Jan 19, 6:28 PM · Restricted Project
mehdi_amini added inline comments to D94738: [mlir][python] Factor out standalone OpView._ods_build_default class method..
Tue, Jan 19, 5:52 PM · Restricted Project
mehdi_amini committed rG1bf2b1665b43: Implement constant folding for DivFOp (authored by jacksonfellows).
Implement constant folding for DivFOp
Tue, Jan 19, 3:08 PM
mehdi_amini closed D94939: Implement constant folding for DivFOp.
Tue, Jan 19, 3:08 PM · Restricted Project
mehdi_amini added inline comments to D94966: [mlir][linalg] Define a depthwise 2-D convolution op.
Tue, Jan 19, 2:46 PM · Restricted Project
mehdi_amini added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Tue, Jan 19, 2:38 PM · Restricted Project, Restricted Project

Mon, Jan 18

mehdi_amini committed rG7dadcd02d6ce: Fix a few GCC compiler warnings (NFC) (authored by mehdi_amini).
Fix a few GCC compiler warnings (NFC)
Mon, Jan 18, 10:00 PM
mehdi_amini added a comment to D94918: [MLIR] NFC: simplify PresburgerSet::isEqual.

We generally use code review for everything except build unbreaks, reverts and minor syntactic changes such as typos.

I have a more liberal view here, I've been performing refactoring and other kind of NFC or minor change without pre-commit reviews. In general many people (including me) are just reviewing a few things post-commit.

Mon, Jan 18, 1:31 PM · Restricted Project
mehdi_amini added a comment to D94918: [MLIR] NFC: simplify PresburgerSet::isEqual.

We generally use code review for everything except build unbreaks, reverts and minor syntactic changes such as typos.

Mon, Jan 18, 1:29 PM · Restricted Project

Sat, Jan 16

mehdi_amini added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Sat, Jan 16, 1:04 PM · Restricted Project, Restricted Project

Thu, Jan 14

mehdi_amini closed D94662: [mlir] Remove over specified memory effects.

Phab linked the commit as "added a commit" to this revision, I'm not sure why it didn't close it...

Thu, Jan 14, 8:18 PM · Restricted Project
mehdi_amini committed rGd8113cda782b: Add newline to terminate debug message (NFC) (authored by mehdi_amini).
Add newline to terminate debug message (NFC)
Thu, Jan 14, 11:29 AM
mehdi_amini accepted D94574: [mlir][ODS] Add new RangedTypesMatchWith operation predicate.
Thu, Jan 14, 11:13 AM · Restricted Project

Wed, Jan 13

mehdi_amini accepted D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

LGTM in general.

Wed, Jan 13, 4:14 PM · Restricted Project

Tue, Jan 12

mehdi_amini accepted D94575: [mlir][OpFormatGen] Format enum attribute cases as keywords when possible.

Sweet!

Tue, Jan 12, 8:24 PM · Restricted Project
mehdi_amini accepted D94492: [mlir][Python] Add checking process before create an AffineMap from a permutation..
Tue, Jan 12, 1:28 PM · Restricted Project
mehdi_amini added a comment to D94399: [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers..

If the runners depends on libSupport and we link them statically into the runtime wrapper that are dynamically loaded, aren't we having two copies of libSupport? One in the statically linked runner executable and one in the dynamically loaded shared objects?

Tue, Jan 12, 1:26 PM · Restricted Project
mehdi_amini accepted D94485: [mlir] Update LLVM dialect type documentation.
Tue, Jan 12, 1:24 PM · Restricted Project

Mon, Jan 11

mehdi_amini added a comment to D94399: [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers..

Thanks for adding the description: I still don't quite get how making these static is preventing an ODR issues?

Mon, Jan 11, 5:56 PM · Restricted Project
mehdi_amini accepted D94405: [mlir] use built-in vector types instead of LLVM dialect types when possible.

Thanks Alex!

Mon, Jan 11, 4:21 PM · Restricted Project
mehdi_amini committed rG762ffc95550c: Update syntax for tensor and memref types to match parser. (authored by richard-uhler).
Update syntax for tensor and memref types to match parser.
Mon, Jan 11, 2:57 PM
mehdi_amini closed D94262: Update syntax for tensor and memref types to match parser..
Mon, Jan 11, 2:57 PM · Restricted Project
mehdi_amini added a comment to D94240: [mlir][linalg] Support parsing attributes in named op spec.

Sorry I had to revert in 110775809ad1 as it broke the gcc-5 build (which has been broken for hours by another change that just got reverted, so I didn't want to lose more coverage right now and need to get it back green ASAP).

Mon, Jan 11, 12:45 PM · Restricted Project
mehdi_amini added a reverting change for rGdf86f15f0c53: [mlir][linalg] Support parsing attributes in named op spec: rG110775809ad1: Revert "[mlir][linalg] Support parsing attributes in named op spec".
Mon, Jan 11, 12:44 PM
mehdi_amini committed rG110775809ad1: Revert "[mlir][linalg] Support parsing attributes in named op spec" (authored by mehdi_amini).
Revert "[mlir][linalg] Support parsing attributes in named op spec"
Mon, Jan 11, 12:44 PM
mehdi_amini added a reverting change for D94240: [mlir][linalg] Support parsing attributes in named op spec: rG110775809ad1: Revert "[mlir][linalg] Support parsing attributes in named op spec".
Mon, Jan 11, 12:44 PM · Restricted Project
mehdi_amini accepted D94297: [mlir] More Python bindings for AffineMap.
Mon, Jan 11, 10:01 AM · Restricted Project
mehdi_amini added a comment to D94399: [mlir] Link mlir_runner_utils statically into cuda/rocm-runtime-wrappers..

Can you add a description of the motivation to the commit message?

Mon, Jan 11, 9:36 AM · Restricted Project
mehdi_amini accepted D94262: Update syntax for tensor and memref types to match parser..
Mon, Jan 11, 9:10 AM · Restricted Project
mehdi_amini accepted D94407: [mlir] Fix for LIT tests.

LGTM

Mon, Jan 11, 9:05 AM · Restricted Project

Sat, Jan 9

mehdi_amini added inline comments to D94370: [mlir][CAPI] Introduce standard source layout for mlir-c dialect registration..
Sat, Jan 9, 8:52 PM · Restricted Project
mehdi_amini committed rG03d249396d6b: [mlir] Enhance mlir-opt show-dialects test case (authored by Lewuathe).
[mlir] Enhance mlir-opt show-dialects test case
Sat, Jan 9, 12:44 PM
mehdi_amini closed D93821: [mlir] Enhance mlir-opt show-dialects test case.
Sat, Jan 9, 12:44 PM · Restricted Project

Fri, Jan 8

mehdi_amini added inline comments to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Fri, Jan 8, 6:00 PM · Restricted Project
mehdi_amini added a comment to D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.

LGTM, Thanks!

Fri, Jan 8, 5:27 PM · Restricted Project
mehdi_amini accepted D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.

LGTM, Thanks!

Fri, Jan 8, 5:26 PM · Restricted Project
mehdi_amini accepted D94302: [mlir] Expose MemRef layout in Python bindings.
Fri, Jan 8, 5:26 PM · Restricted Project
mehdi_amini added inline comments to D94262: Update syntax for tensor and memref types to match parser..
Fri, Jan 8, 5:03 PM · Restricted Project
mehdi_amini added inline comments to D94297: [mlir] More Python bindings for AffineMap.
Fri, Jan 8, 4:34 PM · Restricted Project
mehdi_amini accepted D94225: [mlir] Add Python bindings for AffineExpr.
Fri, Jan 8, 4:29 PM · Restricted Project
mehdi_amini accepted D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Fri, Jan 8, 4:15 PM · Restricted Project
mehdi_amini added inline comments to D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.
Fri, Jan 8, 4:12 PM · Restricted Project

Thu, Jan 7

mehdi_amini committed rGf02e61a8b957: Fix MLIR DRR matching when attributes are interleaved with operands (authored by mehdi_amini).
Fix MLIR DRR matching when attributes are interleaved with operands
Thu, Jan 7, 7:34 PM
mehdi_amini closed D94281: Fix MLIR DRR matching when attributes are interleaved with operands.
Thu, Jan 7, 7:34 PM · Restricted Project
mehdi_amini accepted D93821: [mlir] Enhance mlir-opt show-dialects test case.

Still LGTM! Do you have commit access or do you need someone to land it for you?

Thu, Jan 7, 7:17 PM · Restricted Project
mehdi_amini requested review of D94281: Fix MLIR DRR matching when attributes are interleaved with operands.
Thu, Jan 7, 6:44 PM · Restricted Project
mehdi_amini accepted D94275: [mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleType to ODS.

LGTM

Thu, Jan 7, 4:36 PM · Restricted Project
mehdi_amini added a comment to D94275: [mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleType to ODS.

awesome :)

Thu, Jan 7, 4:36 PM · Restricted Project
mehdi_amini accepted D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Thu, Jan 7, 4:27 PM · Restricted Project
mehdi_amini added inline comments to D94262: Update syntax for tensor and memref types to match parser..
Thu, Jan 7, 2:05 PM · Restricted Project
mehdi_amini added a comment to D87159: Add GDB prettyprinters for a few more MLIR types..

Fixed in 476db17dcb64ef3ec6e247f4b1c673b57f61a367 and 9e1aaa9943b814c22ae03f4abb3171dac8062801

Thu, Jan 7, 1:31 PM · Restricted Project
mehdi_amini committed rG9e1aaa9943b8: Fix check-gdb-mlir-support build after MLIR API changed to take Context as… (authored by mehdi_amini).
Fix check-gdb-mlir-support build after MLIR API changed to take Context as…
Thu, Jan 7, 1:31 PM
mehdi_amini committed rG476db17dcb64: Fix include path for check-gdb-mlir-support to include the MLIR binary dir (authored by mehdi_amini).
Fix include path for check-gdb-mlir-support to include the MLIR binary dir
Thu, Jan 7, 1:29 PM
mehdi_amini added a comment to D93270: [mlir][IR] Define the singleton builtin types in ODS instead of C++.

To bisect a build failure, is is more reliable to just build the target that is failing, i.e.: ninja projects/debuginfo-tests/CMakeFiles/check-gdb-mlir-support.dir/llvm-prettyprinters/gdb/mlir-support.cpp.o

Thu, Jan 7, 1:08 PM · Restricted Project