Page MenuHomePhabricator

mehdi_amini (Mehdi AMINI)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2013, 5:34 PM (350 w, 4 d)

Recent Activity

Yesterday

mehdi_amini added a comment to D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.

Also, how does this patch compare to D72554 ?

Sat, Jan 18, 7:48 PM · Restricted Project
mehdi_amini added a comment to D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on.

The changes overall looks fine to me, but this patch does not seem enough to build with ENABLE_SHARED_LIB right? We still have a cyclic dependency to break first I believe.

Sat, Jan 18, 7:48 PM · Restricted Project
mehdi_amini added a comment to D72921: Create a gpu.module operation for the GPU Dialect..

Can you expand on the original reason for the revert? What has been fix in the patch?

Sat, Jan 18, 7:32 PM · Restricted Project
mehdi_amini added inline comments to D72554: [mlir] support building with BUILD_SHARED_LIBS=ON.
Sat, Jan 18, 6:35 PM
mehdi_amini added a comment to D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM.

Do you need someone to land this or do you have commit access now @schweitz ?

Sat, Jan 18, 4:18 PM · Restricted Project, Restricted Project

Fri, Jan 17

mehdi_amini retitled D72933: Adds CastSliceOp to the vector ops dialect. from BEGIN_PUBLIC Adds CastSliceOp to the vector ops dialect. to Adds CastSliceOp to the vector ops dialect..
Fri, Jan 17, 10:15 PM · Restricted Project
mehdi_amini added a comment to D72741: [MLIR] LLVM dialect: Add llvm.atomicrmw.
In D72741#1827039, @jfb wrote:

You're making a new IR, and that's exactly the right time to revisit basic things like this instead of copying LLVM IR.

Fri, Jan 17, 11:39 AM · Restricted Project
mehdi_amini added a comment to D72741: [MLIR] LLVM dialect: Add llvm.atomicrmw.
In D72741#1826956, @jfb wrote:

@ftynse I believe this is ready to go, anything else you'd like?

Also, I don't yet have committer access, so I'll need some help getting it landed.

Please resolve the question I asked, either here or with a follow-up plan. @mehdi_amini's suggestion was good.

Fri, Jan 17, 11:30 AM · Restricted Project
mehdi_amini added a comment to D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library.

Yes I think a libMLIR.so is the right choice, the only reason to go the other way would be if LLVM starts depending on MLIR.

Fri, Jan 17, 8:45 AM · Restricted Project

Thu, Jan 16

Herald added a reviewer for D72141: [mlir][spirv] Fix ADDITIONAL_HEADER_DIRS for SPIR-V libraries: nicolasvasilache.
Thu, Jan 16, 10:44 PM · Restricted Project
Herald added a reviewer for D72559: [mlir] Add trait for staging update of broadcastable trait: nicolasvasilache.
Thu, Jan 16, 10:44 PM · Restricted Project
Herald added a reviewer for D72584: [MLIR] Fix OpDefinition::classof check for shared libraries.: nicolasvasilache.

I think River fixed it already in D72822 ?

Thu, Jan 16, 10:24 PM · Restricted Project
mehdi_amini added inline comments to D72802: [mlir] Introduce bare ptr calling convention for MemRefs in LLVM dialect.
Thu, Jan 16, 9:02 PM · Restricted Project
mehdi_amini added inline comments to D72583: [cmake] Add support for explicit STATIC libraries even when building mostly shared libraries..
Thu, Jan 16, 9:02 PM · Restricted Project
mehdi_amini added a comment to D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library.

Are there other LLVM subproject who inject themselves into the global llvm shared library? Should we have a libMLIR.so instead?

Thu, Jan 16, 8:53 PM · Restricted Project
mehdi_amini added a comment to D72554: [mlir] support building with BUILD_SHARED_LIBS=ON.

Can you rebase the patch?

Thu, Jan 16, 8:35 PM
mehdi_amini retitled D72763: [mlir][spirv] Use symbolize functions in enum attribute predicates from [mlir][spirv] Use sybmolize functions in enum attribute predicates to [mlir][spirv] Use symbolize functions in enum attribute predicates.
Thu, Jan 16, 7:40 PM · Restricted Project
mehdi_amini accepted D72822: [mlir] Replace AbstractOperation::classof with a ClassID instance..
Thu, Jan 16, 6:24 PM · Restricted Project
mehdi_amini committed rG933b4212566b: [mlir] Add missing dependency on LinalgUtils (authored by GMNGeoffrey).
[mlir] Add missing dependency on LinalgUtils
Thu, Jan 16, 3:44 PM
mehdi_amini closed D72821: [mlir] Add missing dependency on LinalgUtils.
Thu, Jan 16, 3:43 PM · Restricted Project
mehdi_amini added inline comments to D72741: [MLIR] LLVM dialect: Add llvm.atomicrmw.
Thu, Jan 16, 8:47 AM · Restricted Project

Wed, Jan 15

mehdi_amini added a comment to D72821: [mlir] Add missing dependency on LinalgUtils.

Can you remove it from the LinalgToSPIRV dependency? It shouldn't be needed there (and this is what masked the issue I believe)

Wed, Jan 15, 7:20 PM · Restricted Project
mehdi_amini added inline comments to D72812: [IR] Module's NamedMD table needn't be 'void *'.
Wed, Jan 15, 4:16 PM · Restricted Project

Tue, Jan 14

mehdi_amini added a comment to D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

What is the status re EDSC discussion?
Were the pointers I sent offline enough to give a good picture / do you see how to followup on this to use (and maybe extend) EDSCs?

Could you keep me in the loop on that? I have an even simpler proposal in mind that could reconcile EDSC with imperative builders.

Tue, Jan 14, 7:42 PM · Restricted Project
mehdi_amini added a comment to D72310: [mlir][VectorOps] Implement strided_slice conversion.

Hi,
This patch fails to build with MSVC (here building with latest Visual Studio 2019 16.4.2).

Tue, Jan 14, 12:02 PM · Restricted Project
mehdi_amini added a comment to D72697: [mlir] fix broken link to Glossary.

I'd rather use relative links if you don't mind, it make it easier to work locally with a copy of the website.

Tue, Jan 14, 11:11 AM · Restricted Project

Mon, Jan 13

mehdi_amini committed rGa7cac2bd4b68: [MLIR] Fix broken link locations after move to monorepo (authored by galv).
[MLIR] Fix broken link locations after move to monorepo
Mon, Jan 13, 11:21 PM
mehdi_amini closed D72244: Fix broken link locations after move to monorepo.
Mon, Jan 13, 11:21 PM · Restricted Project
mehdi_amini added a comment to D72397: [mlir] m_Constant().

Thanks for the contribution.

Mon, Jan 13, 10:53 PM · Restricted Project
mehdi_amini added a comment to D72429: [mlir] Change the syntax of AffineMapAttr and IntegerSetAttr to avoid conflicts with function types..

The type is printed for each use because one'd like to know about the value used by looking at the op locally and without having to search for its definition -- the latter would be a readability killer.

Mon, Jan 13, 10:43 PM · Restricted Project
mehdi_amini accepted D72642: [mlir] Enable printing of FuncOp in the generic form..
Mon, Jan 13, 10:43 PM · Restricted Project
mehdi_amini accepted D72667: [mlir] Use double format when parsing bfloat16 hexadecimal values.
Mon, Jan 13, 5:09 PM · Restricted Project

Sun, Jan 12

mehdi_amini accepted D72044: [mlir] Add support for attaching a visibility to symbols..
Sun, Jan 12, 3:29 PM · Restricted Project
mehdi_amini added a comment to D72554: [mlir] support building with BUILD_SHARED_LIBS=ON.

Currently, MLIR itself cannot be compiled as a shared library because of the cyclic dependency among MLIR components.

Sun, Jan 12, 1:20 PM

Sat, Jan 11

mehdi_amini added a comment to rGe49c3c8f2ef9: Sprinkle some constexpr on default ctors so the compiler can diagnose unused….

Why does clang need constexpr to diagnose the unused here? Can't the lack of side-effects be inferred without?

Sat, Jan 11, 9:26 PM
mehdi_amini added a comment to D72503: [mlir][spirv] Fix typos related to (de)serialization..

@denis13 : can you please join this group https://reviews.llvm.org/project/members/78/ ; this will enable CI builds on your Phabricator revisions.

Sat, Jan 11, 10:35 AM · Restricted Project
mehdi_amini added inline comments to D72559: [mlir] Add trait for staging update of broadcastable trait.
Sat, Jan 11, 10:28 AM · Restricted Project

Thu, Jan 9

mehdi_amini accepted D72468: Update the attribution policy to use the 'Author' property of a git commit.

LGTM, please wait for the others that commented here to approve as well.

Thu, Jan 9, 6:01 PM · Restricted Project

Wed, Jan 8

mehdi_amini added a comment to D72397: [mlir] m_Constant().

Passing-by remark:
Please would it be possible to consistently follow the general trend and prefix patch titles with appropriate [tags]?
This is a MLIR patch, so it would have been awesome to tag it as such.
It makes reading throught llvm-commits, and eventually git log, that much easier.

Wed, Jan 8, 9:15 AM · Restricted Project

Sun, Jan 5

mehdi_amini accepted D72232: [mlir] Update mlir/CMakeLists.txt to install *.def files.
Sun, Jan 5, 2:51 PM · Restricted Project
mehdi_amini added inline comments to D72223: [LLVM] [MLIR] Introduce affine graybox op.
Sun, Jan 5, 2:36 PM · Restricted Project
mehdi_amini requested changes to D72223: [LLVM] [MLIR] Introduce affine graybox op.
Sun, Jan 5, 5:53 AM · Restricted Project

Sat, Dec 28

mehdi_amini added a comment to rGbe775a003856: [MLIR] [NFC] fix unused var warning.

@bondhugula : in general we strip the Phabricator metadata from the commit messages to keep only the last line "Differential Revision: "

Sorry, I didn't fully understand (I'm new to this.) When exactly should I be editing the commit message? In the window of time between approval and landing?

Sat, Dec 28, 9:34 AM

Fri, Dec 27

mehdi_amini accepted D71949: [mlir] Merge the successor operand count into BlockOperand..
Fri, Dec 27, 8:13 PM · Restricted Project
mehdi_amini added a comment to D71930: [mlir][spirv] Add basic definitions for supporting availability.

What is the relationship between this and the RFC?

Fri, Dec 27, 2:19 PM · Restricted Project
mehdi_amini added inline comments to D71926: [MLIR][spirv] Fix links in docs after repo migration.
Fri, Dec 27, 11:21 AM · Restricted Project
mehdi_amini added a comment to rGbe775a003856: [MLIR] [NFC] fix unused var warning.

I don't keep the Reviewed by:, first because not everyone on the line may have approved the revision so it isn't a signal I trust, second because I have yet to see a use for this, and also because we never added this information with the email reviewer.

Fri, Dec 27, 10:53 AM
mehdi_amini added a comment to rGbe775a003856: [MLIR] [NFC] fix unused var warning.

@bondhugula : in general we strip the Phabricator metadata from the commit messages to keep only the last line "Differential Revision: "

Fri, Dec 27, 9:40 AM
mehdi_amini added a comment to D71912: [mlir] Floating constants for import-llvm.

By the way: arc patch honors the commit author when the patch is created with arcanist. This revision was uploaded in the web interface this is why you didn't get it automatically @ftynse

Fri, Dec 27, 9:09 AM · Restricted Project
mehdi_amini added a comment to D71912: [mlir] Floating constants for import-llvm.

It is the responsibility of the person landing the patch to properly include the author in the patch, if necessary asking the author in the reviews for how they want it to appear.

Fri, Dec 27, 9:03 AM · Restricted Project

Thu, Dec 26

mehdi_amini accepted D71916: High-Level Code-Review Documentation Update.
Thu, Dec 26, 9:31 PM · Restricted Project
mehdi_amini added a comment to D71916: High-Level Code-Review Documentation Update.

LGTM (but wait for the others contributors to the email threads, especially during this holidays season).

Thu, Dec 26, 9:31 PM · Restricted Project
mehdi_amini added a comment to D43040: gold-plugin: Do not set codegen opt level based on LTO opt level..

(never mind this is an old revision, it just happen to popup in my inbox because of an unrelated update to it)

Thu, Dec 26, 5:41 PM · Restricted Project
mehdi_amini added inline comments to D71687: Fix full loop unrolling initialization in new pass manager.
Thu, Dec 26, 3:37 PM · Restricted Project, Restricted Project
mehdi_amini accepted D71687: Fix full loop unrolling initialization in new pass manager.
Thu, Dec 26, 3:37 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D43040: gold-plugin: Do not set codegen opt level based on LTO opt level..

Ideally the codegen opt level should be controlled by an IR-level attribute based on the compile-time opt level, but that hasn't been implemented yet.

Thu, Dec 26, 3:19 PM · Restricted Project
mehdi_amini accepted D71912: [mlir] Floating constants for import-llvm.
Thu, Dec 26, 3:09 PM · Restricted Project
mehdi_amini committed rGb52cb5688b61: Add a clang-tidy configuration file for MLIR, it is using camelBack for naming… (authored by mehdi_amini).
Add a clang-tidy configuration file for MLIR, it is using camelBack for naming…
Thu, Dec 26, 1:47 PM
mehdi_amini added inline comments to D71888: [mlir] Added llvm.resume in LLVM IR Dialect.
Thu, Dec 26, 10:42 AM · Restricted Project
mehdi_amini added inline comments to D71904: [mlir] GPU: introduce utilities for promotion to workgroup memory.
Thu, Dec 26, 9:47 AM · Restricted Project

Wed, Dec 25

mehdi_amini committed rGd2a8e14177f0: Fix the MLIR Vim syntax file: the keyword group was missing (authored by chelxom <chelxom@outlook.com>).
Fix the MLIR Vim syntax file: the keyword group was missing
Wed, Dec 25, 8:51 PM
mehdi_amini added a comment to D71881: [mlir] Convert std.and/std.or ops to spv.LogicalAnd/spv.LogicalOr.

Can you please join this group as well: https://reviews.llvm.org/project/members/78/ ; it'll enable CI testing on your revisions

Wed, Dec 25, 5:56 PM · Restricted Project

Tue, Dec 24

mehdi_amini added a comment to D71851: Use the first location in the fused location for diagnostic handler.

@liufengdb : can you join this group: https://reviews.llvm.org/project/members/78/ ; this will enable pre-merge testing on your review here.

Tue, Dec 24, 11:33 AM · Restricted Project
mehdi_amini added a reviewer for D71853: [MLIR][NFC] Insert const_cast to avoid warning: rriddle.
Tue, Dec 24, 9:43 AM · Restricted Project
mehdi_amini added a comment to D71730: Make lazyload_metadata.ll resilient to the addition of new metadata kinds.

Do you need someone to land this for you?

Tue, Dec 24, 12:16 AM · Restricted Project

Mon, Dec 23

A. Unique TensorFlower <gardener@tensorflow.org> committed rG6ebc7318b013: Use a SmallVector instead of an ArrayRef to materialize a temporary local array (authored by mehdi_amini).
Use a SmallVector instead of an ArrayRef to materialize a temporary local array
Mon, Dec 23, 9:09 PM
mehdi_amini committed rG05ab64874023: [spirv] Avoid printing duplicate trailing type (authored by Lei Zhang <antiagainst@google.com>).
[spirv] Avoid printing duplicate trailing type
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG9da6e90e1cc8: Replace bitwiseCast with llvm::bit_cast (authored by Lei Zhang <antiagainst@google.com>).
Replace bitwiseCast with llvm::bit_cast
Mon, Dec 23, 8:40 PM
mehdi_amini committed rGe239f9647ede: Suppress compiler warnings regarding unused variables (authored by Lei Zhang <antiagainst@google.com>).
Suppress compiler warnings regarding unused variables
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG1331c84fe3d5: Wrap op (de)serialization methods in anonymous namespace (authored by Lei Zhang <antiagainst@google.com>).
Wrap op (de)serialization methods in anonymous namespace
Mon, Dec 23, 8:40 PM
mehdi_amini committed rGc253c6eb2fe3: Switch C++14 std::equal usage to for-loop. (authored by jpienaar).
Switch C++14 std::equal usage to for-loop.
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG6fe99662aa6c: Move loop dialect tests into separate files - NFC (authored by Alex Zinenko <zinenko@google.com>).
Move loop dialect tests into separate files - NFC
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG03c8303a12e5: Make SPIR-V spv.EntryPoint and spv.ExecutionMode consistent with SPIR-V spec (authored by mravishankar).
Make SPIR-V spv.EntryPoint and spv.ExecutionMode consistent with SPIR-V spec
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG89a10b73fb73: Add missing MLIRDialect dependency for MLIRDialect (authored by Lei Zhang <antiagainst@google.com>).
Add missing MLIRDialect dependency for MLIRDialect
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG287d111023d5: Generalize implicit terminator into an OpTrait (authored by Alex Zinenko <zinenko@google.com>).
Generalize implicit terminator into an OpTrait
Mon, Dec 23, 8:40 PM
mehdi_amini committed rGd2a872922f10: Refactor stripmineSink for AffineForOp - NFC (authored by nicolasvasilache).
Refactor stripmineSink for AffineForOp - NFC
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG6204acacc79f: Uniformize test name - NFC (authored by nicolasvasilache).
Uniformize test name - NFC
Mon, Dec 23, 8:40 PM
mehdi_amini committed rGdb4cd1c8dc49: Utility function to map a loop on a parametric grid of virtual processors (authored by nicolasvasilache).
Utility function to map a loop on a parametric grid of virtual processors
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG5bc344743c25: Uniformize the API for the mlir::tile functions on AffineForOp and loop::ForOp (authored by nicolasvasilache).
Uniformize the API for the mlir::tile functions on AffineForOp and loop::ForOp
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG28057ff3daa2: Add support for providing a legality callback for dynamic legality in… (authored by rriddle).
Add support for providing a legality callback for dynamic legality in…
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG36a26e003344: [spirv] group methods better and improve comments (authored by Lei Zhang <antiagainst@google.com>).
[spirv] group methods better and improve comments
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG92918689601b: Place generated StandardOps to SPIR-V patterns in anonymous namespace (authored by Lei Zhang <antiagainst@google.com>).
Place generated StandardOps to SPIR-V patterns in anonymous namespace
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG8b447b6cad22: NFC: Expose a ConversionPatternRewriter for use with ConversionPatterns. (authored by rriddle).
NFC: Expose a ConversionPatternRewriter for use with ConversionPatterns.
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG701266c47aba: Add an "is_signed" attribute to the quant_ConstFakeQuant op (authored by liufengdb).
Add an "is_signed" attribute to the quant_ConstFakeQuant op
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG90b5a381ce1a: Minor cleanup to LangRef, MLIR stands for "Multi-Level IR" (authored by joker-eph-DISABLED).
Minor cleanup to LangRef, MLIR stands for "Multi-Level IR"
Mon, Dec 23, 8:40 PM
mehdi_amini committed rGe9c42e355281: Fix script relative path after moving SPIR-V dialect (authored by Lei Zhang <antiagainst@google.com>).
Fix script relative path after moving SPIR-V dialect
Mon, Dec 23, 8:40 PM
mehdi_amini committed rG9f498f921bf6: Print boolean values in ElementsAttr as "true"/"false" (authored by Lei Zhang <antiagainst@google.com>).
Print boolean values in ElementsAttr as "true"/"false"
Mon, Dec 23, 8:39 PM
mehdi_amini committed rGc6cfebf1af5f: Automatically generate (de)serialization methods for SPIR-V ops (authored by mravishankar).
Automatically generate (de)serialization methods for SPIR-V ops
Mon, Dec 23, 8:39 PM
mehdi_amini committed rGe558c040aabc: Add UnitAttr in OpBase.td. (authored by Jing Pu <jingpu@google.com>).
Add UnitAttr in OpBase.td.
Mon, Dec 23, 8:39 PM
mehdi_amini committed rGec66bc57a879: Add helper to get flattened tuple types (authored by Geoffrey Martin-Noble <gcmn@google.com>).
Add helper to get flattened tuple types
Mon, Dec 23, 8:39 PM
mehdi_amini committed rG68c409238e8e: Simplify broadcastable traits (authored by Smit Hinsu <hinsu@google.com>).
Simplify broadcastable traits
Mon, Dec 23, 8:39 PM
mehdi_amini committed rGd097cc6119de: Add support for parsing/printing the trailing type of a dialect attribute. (authored by rriddle).
Add support for parsing/printing the trailing type of a dialect attribute.
Mon, Dec 23, 8:39 PM
mehdi_amini committed rG775daf7c1fa5: Update Contributing.md doc to refer to the developer guide (authored by joker-eph-DISABLED).
Update Contributing.md doc to refer to the developer guide
Mon, Dec 23, 8:39 PM
mehdi_amini committed rGcce2f4c4ed42: Relax Broadcastable trait to only reject instances that are statically… (authored by Smit Hinsu <hinsu@google.com>).
Relax Broadcastable trait to only reject instances that are statically…
Mon, Dec 23, 8:39 PM
mehdi_amini committed rG9e3c2650d20d: Refactor the conversion of block argument types in DialectConversion. (authored by rriddle).
Refactor the conversion of block argument types in DialectConversion.
Mon, Dec 23, 8:39 PM
mehdi_amini committed rGee21bb994441: Add tests for broadcastable trait (authored by Smit Hinsu <hinsu@google.com>).
Add tests for broadcastable trait
Mon, Dec 23, 8:39 PM
mehdi_amini committed rGd81e2376f735: Add an initial TestingGuide document to describe testing in MLIR. (authored by rriddle).
Add an initial TestingGuide document to describe testing in MLIR.
Mon, Dec 23, 8:39 PM
mehdi_amini committed rG491ef84dc445: Add support for explicitly marking dialects and operations as illegal. (authored by rriddle).
Add support for explicitly marking dialects and operations as illegal.
Mon, Dec 23, 8:39 PM
mehdi_amini committed rGa4cbe4ebe1a6: Verify that ReturnOp only appears within the region of a FuncOp. (authored by rriddle).
Verify that ReturnOp only appears within the region of a FuncOp.
Mon, Dec 23, 8:39 PM
mehdi_amini committed rG2b9855b5b4e9: Refactor DialectConversion to support different conversion modes. (authored by rriddle).
Refactor DialectConversion to support different conversion modes.
Mon, Dec 23, 8:39 PM