Page MenuHomePhabricator

mehdi_amini (Mehdi AMINI)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2013, 5:34 PM (516 w, 4 d)
Roles
Administrator

Recent Activity

Yesterday

mehdi_amini added a comment to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

I'm curious about @jpienaar 's thoughts on the overall direction here

Sat, Mar 25, 2:54 AM · Restricted Project, Restricted Project
mehdi_amini added a reviewer for D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl: jpienaar.
Sat, Mar 25, 2:54 AM · Restricted Project, Restricted Project

Thu, Mar 23

mehdi_amini added inline comments to D146555: [mlir][bytecode] Allow client to specify an older version of the bytecode to emit.
Thu, Mar 23, 9:33 AM · Restricted Project, Restricted Project

Wed, Mar 22

mehdi_amini added a comment to D144193: [mlir][IR] Trigger notifyOperationRemoved callback for nested ops.

LGTM, but @rriddle should have another look

Wed, Mar 22, 6:52 AM · Restricted Project, Restricted Project

Tue, Mar 21

mehdi_amini added inline comments to D146456: [MLIR] Address post-commit comments on function deduplication.
Tue, Mar 21, 12:37 AM · Restricted Project, Restricted Project

Mon, Mar 20

mehdi_amini added inline comments to D146456: [MLIR] Address post-commit comments on function deduplication.
Mon, Mar 20, 4:14 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144738: [MLIR] Add pass to deduplicate functions.

I rather not write code that is over-restrictive unnecessarily (if you think about it, the entirety of MLIR exists because we generalize early, otherwise we'd have rebuilt LLVM or XLA ;) )

Mon, Mar 20, 4:07 PM · Restricted Project, Restricted Project
mehdi_amini committed rG46c6166d3391: Fix MLIR build with shared library enabled (authored by mehdi_amini).
Fix MLIR build with shared library enabled
Mon, Mar 20, 6:04 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144738: [MLIR] Add pass to deduplicate functions.

Ping here @frgossen ?

Mon, Mar 20, 5:49 AM · Restricted Project, Restricted Project
mehdi_amini committed rGf406adf134c2: Add capture of "IRUnits" as context for an MLIR Action (authored by mehdi_amini).
Add capture of "IRUnits" as context for an MLIR Action
Mon, Mar 20, 5:47 AM · Restricted Project, Restricted Project
mehdi_amini committed rG5736a8a2dab4: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer (authored by mehdi_amini).
Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer
Mon, Mar 20, 5:47 AM · Restricted Project, Restricted Project
mehdi_amini closed D144814: Add capture of "IRUnits" as context for an MLIR Action.
Mon, Mar 20, 5:47 AM · Restricted Project, Restricted Project
mehdi_amini committed rG930744fcdad7: Add an Observer for logging actions application to a stream (authored by mehdi_amini).
Add an Observer for logging actions application to a stream
Mon, Mar 20, 5:40 AM · Restricted Project, Restricted Project
mehdi_amini closed D144813: Add an Observer for logging actions application to a stream.
Mon, Mar 20, 5:40 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144814: Add capture of "IRUnits" as context for an MLIR Action.

The data-flow analysis framework has a concept very similar to IRUnit its called ProgramPoint maybe this should be shared ?

I'm not sure how to unify it, it feels that somehow the ProgramPoint could inherit from IRUnit but it is declared as a more extensible framework: public PointerUnion<GenericProgramPoint *, Operation *, Value, Block *> so I'm not sure how to unify.

Mon, Mar 20, 5:40 AM · Restricted Project, Restricted Project
mehdi_amini removed reviewers for D145582: [mlir] Argument and result attribute handling during inlining.: mehdi_amini, jpienaar.
Mon, Mar 20, 1:05 AM · Restricted Project, Restricted Project

Wed, Mar 15

mehdi_amini accepted D146126: [mlir][Transforms] OperationFolder: Remove redundant `create` API.
Wed, Mar 15, 4:49 AM · Restricted Project, Restricted Project
mehdi_amini accepted D146107: [MLIR] Fix warnings in AttrTypeSubElements.h.
Wed, Mar 15, 3:42 AM · Restricted Project, Restricted Project

Tue, Mar 14

mehdi_amini added inline comments to D146053: [mlir][tensor/memref] Replace various redundant helpers with `reifyShapeDims`.
Tue, Mar 14, 10:54 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144816: Add tracing for pattern application in a ApplyPatternAction.
Tue, Mar 14, 8:55 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Tue, Mar 14, 8:23 AM · Restricted Project, Restricted Project
mehdi_amini added a reviewer for D120368: [mlir] Add support for "promised" interfaces: springerm.
Tue, Mar 14, 8:21 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D146041: Fix weirdly apologetic diagnostic messages.

You should look into the title and description of the commit: https://cbea.ms/git-commit/

Tue, Mar 14, 6:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D146036: Replace `outs` with `inits` in linalg textual assembly.

if anything, I'd go for dest personally with a doc that the dest may or may not be read.

Tue, Mar 14, 6:26 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D141098: [clang-format][NFC] Set LineEnding to LF in config files.

Can we just fix the buildbot so that it runs git-clang-format with --binary? Using clang-format-15 to format a patch to clang-format-16 source still looks wrong to me.

Tue, Mar 14, 6:24 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D146036: Replace `outs` with `inits` in linalg textual assembly.

I'll wait to hear at least from @mravishankar @nicolasvasilache here.

Tue, Mar 14, 5:58 AM · Restricted Project, Restricted Project
mehdi_amini requested changes to D145582: [mlir] Argument and result attribute handling during inlining..

Please get reviews from @rriddle here.

Tue, Mar 14, 5:20 AM · Restricted Project, Restricted Project
mehdi_amini requested review of D146036: Replace `outs` with `inits` in linalg textual assembly.
Tue, Mar 14, 5:16 AM · Restricted Project, Restricted Project
Herald added a reviewer for D136875: [mlir] Rename `outs` to `inits` for linalg ops.: ftynse.

we can reconsider a name that is more intuitive like outputs

Tue, Mar 14, 5:13 AM · Restricted Project, Restricted Project
mehdi_amini accepted D144692: [mlir] Introduce IRDL dialect.

This LGTM, but River may have thoughts on simplifying getChildOpIndex(), let's wait to hear back from him.

Tue, Mar 14, 2:59 AM · Restricted Project, Restricted Project

Mon, Mar 13

mehdi_amini added a comment to D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.

This assumes less threads than shards overall right?

Yeah, which is effectively always a guarantee (even on my beefy desktop) given the number of parametric builtin attributes/types we have.

Mon, Mar 13, 5:47 PM · Restricted Project, Restricted Project
mehdi_amini accepted D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.
Mon, Mar 13, 5:46 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.

This assumes less threads than shards overall right?

Mon, Mar 13, 5:42 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D145336: [mlir][tosa] Add TOSA f64 type support for const op.

Can you add tests please?

Mon, Mar 13, 5:29 PM · Restricted Project, Restricted Project
mehdi_amini accepted D145956: [mlir] Don't use -z,defs on sanitizer builds.
Mon, Mar 13, 10:24 AM · Restricted Project, Restricted Project
mehdi_amini committed rG5c41a7334db3: Fix a small typo in a comment in MlitOptMain.cpp (NFC) (authored by mehdi_amini).
Fix a small typo in a comment in MlitOptMain.cpp (NFC)
Mon, Mar 13, 10:15 AM · Restricted Project, Restricted Project
mehdi_amini added a reverting change for rG0fe16607a523: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer: rGacab6a70fb40: Revert "Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM….
Mon, Mar 13, 9:50 AM · Restricted Project, Restricted Project
mehdi_amini committed rGacab6a70fb40: Revert "Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM… (authored by mehdi_amini).
Revert "Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM…
Mon, Mar 13, 9:50 AM · Restricted Project, Restricted Project
mehdi_amini added a reverting change for D145889: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer: rGacab6a70fb40: Revert "Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM….
Mon, Mar 13, 9:50 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144815: Add a breakpoint manager that matches based on File/Line/Col Locations.
Mon, Mar 13, 9:13 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144815: Add a breakpoint manager that matches based on File/Line/Col Locations.

Address comments

Mon, Mar 13, 9:13 AM · Restricted Project, Restricted Project
mehdi_amini committed rGd563211f7508: Fix test dialect to avoid using an unregistered dialect (authored by mehdi_amini).
Fix test dialect to avoid using an unregistered dialect
Mon, Mar 13, 8:51 AM · Restricted Project, Restricted Project
mehdi_amini committed rG0fe16607a523: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer (authored by mehdi_amini).
Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer
Mon, Mar 13, 8:51 AM · Restricted Project, Restricted Project
mehdi_amini closed D145889: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer.
Mon, Mar 13, 8:51 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144814: Add capture of "IRUnits" as context for an MLIR Action.

One more comment addressed

Mon, Mar 13, 8:39 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144814: Add capture of "IRUnits" as context for an MLIR Action.

Rebase & address comments

Mon, Mar 13, 8:38 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144813: Add an Observer for logging actions application to a stream.

Minor fix to PAssExecutionAction

Mon, Mar 13, 8:17 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144814: Add capture of "IRUnits" as context for an MLIR Action.
Mon, Mar 13, 8:07 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144813: Add an Observer for logging actions application to a stream.

clang-format

Mon, Mar 13, 7:49 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144813: Add an Observer for logging actions application to a stream.

minor cleanup

Mon, Mar 13, 7:48 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144813: Add an Observer for logging actions application to a stream.

Address comment

Mon, Mar 13, 7:01 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D145889: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer.

Use ... instead of "/*skip region*/" comment

Mon, Mar 13, 6:40 AM · Restricted Project, Restricted Project
mehdi_amini committed rG554e40d6ba1c: Add a message to mlir-opt when reading from stdin to avoid being waiting for… (authored by mehdi_amini).
Add a message to mlir-opt when reading from stdin to avoid being waiting for…
Mon, Mar 13, 6:28 AM · Restricted Project, Restricted Project
mehdi_amini closed D145469: Add a message to mlir-opt when reading from stdin to avoid being waiting for nothing.
Mon, Mar 13, 6:28 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144813: Add an Observer for logging actions application to a stream.
Mon, Mar 13, 6:03 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144818: Refactor the mlir-opt command line options related to debugging in a helper.
Mon, Mar 13, 6:02 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D145889: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer.
Mon, Mar 13, 5:54 AM · Restricted Project, Restricted Project

Sun, Mar 12

mehdi_amini added inline comments to D144817: Add a GDB/LLDB interface for interactive debugging of MLIR Actions.
Sun, Mar 12, 4:32 PM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144816: Add tracing for pattern application in a ApplyPatternAction.

Update with one extra no-inline indirection

Sun, Mar 12, 4:30 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144816: Add tracing for pattern application in a ApplyPatternAction.

LGTM but River mentioned there were some perf issues. Do have a quick capture of the before vs. after time to run a pattern-heavy workload?

Sun, Mar 12, 4:21 PM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144815: Add a breakpoint manager that matches based on File/Line/Col Locations.

address comments

Sun, Mar 12, 4:15 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144815: Add a breakpoint manager that matches based on File/Line/Col Locations.
Sun, Mar 12, 3:56 PM · Restricted Project, Restricted Project
mehdi_amini requested review of D145889: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer.
Sun, Mar 12, 3:45 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144814: Add capture of "IRUnits" as context for an MLIR Action.
Sun, Mar 12, 3:10 PM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144814: Add capture of "IRUnits" as context for an MLIR Action.

address comments

Sun, Mar 12, 3:10 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144814: Add capture of "IRUnits" as context for an MLIR Action.

The data-flow analysis framework has a concept very similar to IRUnit its called ProgramPoint maybe this should be shared ?

Sun, Mar 12, 2:44 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144813: Add an Observer for logging actions application to a stream.
Sun, Mar 12, 2:32 PM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144813: Add an Observer for logging actions application to a stream.

Address comments

Sun, Mar 12, 2:31 PM · Restricted Project, Restricted Project
mehdi_amini committed rGfa51c1753a27: Introduce mlir::tracing::ExecutionContext (authored by mehdi_amini).
Introduce mlir::tracing::ExecutionContext
Sun, Mar 12, 2:21 PM · Restricted Project, Restricted Project
mehdi_amini closed D144812: Introduce mlir::tracing::ExecutionContext.
Sun, Mar 12, 2:21 PM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144812: Introduce mlir::tracing::ExecutionContext.

Address comments

Sun, Mar 12, 2:16 PM · Restricted Project, Restricted Project
mehdi_amini accepted D144693: [mlir][irdl] Add IRDL registration.

This LGTM, but @rriddle and @Mogball had concerned earlier, it would be great if they could take another look here!

Sun, Mar 12, 6:33 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144693: [mlir][irdl] Add IRDL registration.

My feeling is that we explicitly do not want a pass to depend on a specific IRDL dialect. In fact, this is already something that we do not want to have for DynamicDialect.
Having a pass relying on a dynamic dialect would be too dangerous and error-prone, and if you are already paying the cost of recompiling to write your pass, you are willing to pay the cost of compiling your dialect to C++ (in my opinion).
Also, manipulating IRDL dialects in C++ is a bit annoying, since you need to use the generic way of accessing operands/results/attributes, meaning that you have almost no guarantee that those operands/results/attributes exist in the first place.

Sun, Mar 12, 6:17 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Sun, Mar 12, 6:07 AM · Restricted Project, Restricted Project
mehdi_amini accepted D122966: [mlir:Inliner] Emit an error when adding multiple simplification pipelines for the same op.
Sun, Mar 12, 5:53 AM · Restricted Project, Restricted Project

Sat, Mar 11

mehdi_amini added a comment to D144693: [mlir][irdl] Add IRDL registration.

I feel like you're using "register" when it is actually more "loading" here. (I'm not sure IRDL has a concept equivalent to "registering" dialects?)

Coming back to this: how do we differentiate registering from loading in IRDL? Do you see some difference somehow?

In IRDL, there are not really any registration, since the dialects are loaded right away, without going through the `DialectRegistry.
While there may be a way to allow registering without loading, I'm not completely sure what would be the actual benefits, and I'm not sure how easy this would be.

Sat, Mar 11, 9:55 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D145066: [mlir][core] Fix inline pass default pipeline dump.

I'd be fine landing this patch for now to fix the issue. The root of the inliner issues should be fixed when I rebase+land https://reviews.llvm.org/D134480

Will this be enough to solve the entire dump including the members of the InlinerPass class?

Yeah, it should. The callable stuff gets killed, and the list is already specified as an option.

Sat, Mar 11, 8:33 AM · Restricted Project, Restricted Project

Fri, Mar 10

mehdi_amini added a comment to D144693: [mlir][irdl] Add IRDL registration.

I feel like you're using "register" when it is actually more "loading" here. (I'm not sure IRDL has a concept equivalent to "registering" dialects?)

Fri, Mar 10, 3:13 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144692: [mlir] Introduce IRDL dialect.
Fri, Mar 10, 3:10 PM · Restricted Project, Restricted Project
mehdi_amini committed rG0e0b6070fd2a: Implements MLIR Bytecode versioning capability (authored by mfrancio).
Implements MLIR Bytecode versioning capability
Fri, Mar 10, 2:29 PM · Restricted Project, Restricted Project
mehdi_amini closed D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".
Fri, Mar 10, 2:29 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144692: [mlir] Introduce IRDL dialect.
Fri, Mar 10, 1:59 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

Right now you have test failures. On my Mac locally I see:

Fri, Mar 10, 1:48 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

Do you have commit access or do you need help to land this?

Fri, Mar 10, 11:48 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

LGTM, thanks for being so patient through the reviews!

Let's wait for @rriddle to give a final approval.

Fri, Mar 10, 11:48 AM · Restricted Project, Restricted Project
mehdi_amini accepted D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

LGTM, thanks for being so patient through the reviews!

Fri, Mar 10, 11:47 AM · Restricted Project, Restricted Project
mehdi_amini requested changes to D145762: Reduce inlining that had larger binary size impact.

In general I am quite concerned about messing with the optimizer this way, this should be extremely exceptional. This'll be ad-hoc, forces a performance tradeoff specific to a given use case, and couple the "heuristic" to the exact compiler you're using (what does it do on Windows? On Mac?).
Have you tried building your project with -Os? -Oz? PGO? FullLTO?

Fri, Mar 10, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D145762: Reduce inlining that had larger binary size impact.

~3.4 MB reduction in binary in release mode.

Fri, Mar 10, 1:59 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D144692: [mlir] Introduce IRDL dialect.

I don't believe there is any rule like that: I merge my patches as they get approved in general. We mostly need to agree about the overall design, then we can develop incrementally in tree. Stacked patches are mostly a convenient way of streamlining the development and review process.

Approving a patch-set in bulk isn't new or seldom used. We've been doing this in LLVM for at least a decade for all sorts of new features, including all new targets. What you describe is a completely different scenario.

Fri, Mar 10, 1:54 AM · Restricted Project, Restricted Project

Thu, Mar 9

mehdi_amini added inline comments to D144693: [mlir][irdl] Add IRDL registration.
Thu, Mar 9, 4:22 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144693: [mlir][irdl] Add IRDL registration.
Thu, Mar 9, 3:57 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144693: [mlir][irdl] Add IRDL registration.

Is there a way to add a check for this?

Thu, Mar 9, 3:50 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D144692: [mlir] Introduce IRDL dialect.
Thu, Mar 9, 3:44 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144693: [mlir][irdl] Add IRDL registration.

Is it possible to register new dialects during a pass?

Thu, Mar 9, 3:35 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144692: [mlir] Introduce IRDL dialect.

As with other patch series, we review all patches and only when all patches are approved you can merge them all at once. This is to make sure all points are covered, and to make it easier to pre-approve the good ones and focus discussion on the hard ones.

Thu, Mar 9, 3:32 PM · Restricted Project, Restricted Project

Tue, Mar 7

mehdi_amini accepted D145249: [TargetParser] Disallow Global Constructors.
Tue, Mar 7, 5:31 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D145249: [TargetParser] Disallow Global Constructors.

My personal motivation was to be able to ship MLIR without any static ctor.
Fixing all of LLVM seemed too much, but MLIR (when not needing the JIT) does only depends on libSupport, which was very much doable (in particular a key piece was that the command line parsing entry point is part of the lib, so we can lazy load libSupport options)

Tue, Mar 7, 5:31 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144812: Introduce mlir::tracing::ExecutionContext.

Is there a commit in this stack that handles updating/adding documentation?

No not yet, I was waiting because I anticipated API changes during the review.

Tue, Mar 7, 5:09 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D144812: Introduce mlir::tracing::ExecutionContext.

Is there a commit in this stack that handles updating/adding documentation?

Tue, Mar 7, 5:08 PM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D144812: Introduce mlir::tracing::ExecutionContext.

Address more comments

Tue, Mar 7, 5:08 PM · Restricted Project, Restricted Project