Page MenuHomePhabricator

mehdi_amini (Mehdi AMINI)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2013, 5:34 PM (423 w, 4 d)
Roles
Administrator

Recent Activity

Yesterday

mehdi_amini committed rG152c9871e6ac: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks (authored by mehdi_amini).
Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks
Sat, Jun 12, 3:56 PM
mehdi_amini closed D104189: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks.
Sat, Jun 12, 3:55 PM · Restricted Project
mehdi_amini requested review of D104189: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks.
Sat, Jun 12, 2:58 PM · Restricted Project
mehdi_amini committed rG8bc1ce0f61da: Use dyn_cast_or_null instead of dyn_cast in FunctionLike::verifyTrait (NFC) (authored by mehdi_amini).
Use dyn_cast_or_null instead of dyn_cast in FunctionLike::verifyTrait (NFC)
Sat, Jun 12, 2:06 PM

Fri, Jun 11

mehdi_amini added inline comments to D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..
Fri, Jun 11, 7:35 PM · Restricted Project
mehdi_amini accepted D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..

Awesome :)

Fri, Jun 11, 7:34 PM · Restricted Project
mehdi_amini accepted D104160: [mlir:Linalg] Populate LinalgOp patterns on LinalgDialect as opposed to each op.
Fri, Jun 11, 5:08 PM · Restricted Project
mehdi_amini accepted D104132: [mlir][docs] Reorder PassWrapper arguments.

Thanks!

Fri, Jun 11, 11:55 AM · Restricted Project
mehdi_amini accepted D104009: [MLIR] Execution engine python binding support for shared libraries.

Note that the C API user won't typically have an ArrayRef or a higher level structure to map that to the C API. They are using C right? :-)

Fri, Jun 11, 9:00 AM · Restricted Project

Thu, Jun 10

mehdi_amini added a comment to D104009: [MLIR] Execution engine python binding support for shared libraries.

I would have wrote: ..., int numPaths, const MlirStringRef *libPaths).

Thu, Jun 10, 10:50 PM · Restricted Project
mehdi_amini added a comment to D103811: [docs] Set Phabricator as the tool for pre-commit code reviews.

The commercial entity behind Phab is dropping development of new features but they said they'll keep the maintenance for the foreseeable future I believe. Also there is a community currently organizing to fork the project and continue the development: https://docs.google.com/document/d/1YxQ_JGdhWYPSdoaI_m1TLzwbGLZdtOD7ux2SVL263Ow/edit

Thu, Jun 10, 12:27 PM · Restricted Project
mehdi_amini added a comment to D104009: [MLIR] Execution engine python binding support for shared libraries.

+1 to Stella's comment :)

Thu, Jun 10, 9:19 AM · Restricted Project

Wed, Jun 9

mehdi_amini added a comment to D103869: Add a static assertions for custom Op<> to not defined data members (NFC).

@stella.stamenova relanded in 1b21e9c1fa99, the premerge passed on Windows here, but feel free to revert if you see any failure!

Wed, Jun 9, 2:45 PM · Restricted Project
mehdi_amini committed rG1b21e9c1fa99: Add a static assertions for custom Op<> to not defined data members (NFC) (authored by mehdi_amini).
Add a static assertions for custom Op<> to not defined data members (NFC)
Wed, Jun 9, 2:45 PM
mehdi_amini closed D103869: Add a static assertions for custom Op<> to not defined data members (NFC).
Wed, Jun 9, 2:45 PM · Restricted Project
mehdi_amini added inline comments to D103948: [llvm] Make Sequence reverse-iterable.
Wed, Jun 9, 2:41 PM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D103869: Add a static assertions for custom Op<> to not defined data members (NFC).

Fix MSVC

Wed, Jun 9, 11:26 AM · Restricted Project
mehdi_amini committed rGacc3ca3b7a08: Fix typo in Toy tutorial Ch1 (authored by Mokosha).
Fix typo in Toy tutorial Ch1
Wed, Jun 9, 9:10 AM
mehdi_amini closed D84193: Fix typo in Toy tutorial Ch1.
Wed, Jun 9, 9:10 AM · Restricted Project
mehdi_amini accepted D84193: Fix typo in Toy tutorial Ch1.
Wed, Jun 9, 9:07 AM · Restricted Project

Tue, Jun 8

mehdi_amini added a comment to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.

Run ln -sf ../../llvm/utils/git/pre-push.py .git/hooks/pre-push in your local repo: it'll protect you against accidentally pushing two commits by asking confirmation when this happens

Tue, Jun 8, 6:00 PM · Restricted Project
mehdi_amini updated the diff for D103869: Add a static assertions for custom Op<> to not defined data members (NFC).

Reopen

Tue, Jun 8, 5:46 PM · Restricted Project
mehdi_amini added a reverting change for rGc0edcec630eb: Add a static assertions for custom Op<> to not defined data members (NFC): rGa0ac51467697: Revert "Add a static assertions for custom Op<> to not defined data members….
Tue, Jun 8, 5:46 PM
mehdi_amini reopened D103869: Add a static assertions for custom Op<> to not defined data members (NFC).
Tue, Jun 8, 5:46 PM · Restricted Project
mehdi_amini added a reverting change for D103869: Add a static assertions for custom Op<> to not defined data members (NFC): rGa0ac51467697: Revert "Add a static assertions for custom Op<> to not defined data members….
Tue, Jun 8, 5:46 PM · Restricted Project
mehdi_amini committed rGa0ac51467697: Revert "Add a static assertions for custom Op<> to not defined data members… (authored by mehdi_amini).
Revert "Add a static assertions for custom Op<> to not defined data members…
Tue, Jun 8, 5:46 PM
mehdi_amini committed rG2c8115482312: Add llvm_unreacheable to silence warning "not all control paths return a value"… (authored by mehdi_amini).
Add llvm_unreacheable to silence warning "not all control paths return a value"…
Tue, Jun 8, 5:43 PM
mehdi_amini committed rGc0edcec630eb: Add a static assertions for custom Op<> to not defined data members (NFC) (authored by mehdi_amini).
Add a static assertions for custom Op<> to not defined data members (NFC)
Tue, Jun 8, 11:38 AM
mehdi_amini closed D103869: Add a static assertions for custom Op<> to not defined data members (NFC).
Tue, Jun 8, 11:38 AM · Restricted Project
mehdi_amini added a comment to D103827: [mlir] Make MemRef element type extensible.

I did. Arc doesn't seem to pick up amended commit messages, changed it through the web interface as well.

Tue, Jun 8, 11:24 AM · Restricted Project
mehdi_amini added inline comments to D102679: [llvm] Make Sequence reverse-iterable.
Tue, Jun 8, 10:54 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D102679: [llvm] Make Sequence reverse-iterable.

Reverted ; seems like gcc5 didn't like some constructs in this patch, see details here: https://buildkite.com/mlir/mlir-core/builds/14326#2cda617f-aeb8-49d2-833c-b5a734cba86a ; let me know if you can't reproduce.

Tue, Jun 8, 10:23 AM · Restricted Project, Restricted Project
mehdi_amini committed rG30bb5dcb0a5c: Add missing header <atomic> in lib/IR/Verifier.cpp (NFC) (authored by mehdi_amini).
Add missing header <atomic> in lib/IR/Verifier.cpp (NFC)
Tue, Jun 8, 10:09 AM
mehdi_amini added a reverting change for rGe772216e7089: [llvm] Make Sequence reverse-iterable: rGa4e2cf712af3: Revert "[llvm] Make Sequence reverse-iterable".
Tue, Jun 8, 10:03 AM
mehdi_amini committed rGa4e2cf712af3: Revert "[llvm] Make Sequence reverse-iterable" (authored by mehdi_amini).
Revert "[llvm] Make Sequence reverse-iterable"
Tue, Jun 8, 10:03 AM
mehdi_amini added a reverting change for D102679: [llvm] Make Sequence reverse-iterable: rGa4e2cf712af3: Revert "[llvm] Make Sequence reverse-iterable".
Tue, Jun 8, 10:03 AM · Restricted Project, Restricted Project

Mon, Jun 7

mehdi_amini requested review of D103869: Add a static assertions for custom Op<> to not defined data members (NFC).
Mon, Jun 7, 10:32 PM · Restricted Project
mehdi_amini accepted D103842: NFC: .clang-tidy: Inherit configs from parents to improve maintainability.
Mon, Jun 7, 9:27 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added inline comments to D103830: [MLIR][GPU] Simplify memcpy of cast.
Mon, Jun 7, 11:11 AM · Restricted Project
mehdi_amini accepted D103829: [MLIR][MemRef] Only allow fold of cast for the pointer operand, not the value.
Mon, Jun 7, 11:08 AM · Restricted Project

Fri, Jun 4

mehdi_amini added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Fri, Jun 4, 7:35 PM · Restricted Project

Wed, Jun 2

mehdi_amini added a comment to D98005: NFC: Glob all python sources in the MLIR Python bindings..

I think we should restore copy_if_different.

Wed, Jun 2, 5:09 PM · Restricted Project
mehdi_amini committed rG8c948b18e9d8: Fix -Wsign-compare warning (NFC) (authored by mehdi_amini).
Fix -Wsign-compare warning (NFC)
Wed, Jun 2, 10:29 AM
mehdi_amini added a comment to D103394: [mlir][linalg] Update Structured Op Interface (NFC)..

(fixed the warning in 8c948b18e9d8 by the way)

Wed, Jun 2, 10:29 AM · Restricted Project
mehdi_amini added a comment to D103394: [mlir][linalg] Update Structured Op Interface (NFC)..

Changing the return type of a function is not generally considered a NFC.

Wed, Jun 2, 10:26 AM · Restricted Project
mehdi_amini committed rGb532455ac703: [MLIR] Fix Standalone dialect test to work in out-of-tree builds (authored by krzysz00).
[MLIR] Fix Standalone dialect test to work in out-of-tree builds
Wed, Jun 2, 10:25 AM
mehdi_amini closed D103276: [MLIR] Fix Standalone dialect test to work in out-of-tree builds.
Wed, Jun 2, 10:25 AM · Restricted Project
mehdi_amini committed rG90f207a78151: Fix CMake error: TableGen targets must be in the DEPENDS list instead of… (authored by mehdi_amini).
Fix CMake error: TableGen targets must be in the DEPENDS list instead of…
Wed, Jun 2, 10:14 AM
mehdi_amini committed rGe598ab1c06dd: Add missing CMake dependency for mlir/lib/Reducer (NFC) (authored by mehdi_amini).
Add missing CMake dependency for mlir/lib/Reducer (NFC)
Wed, Jun 2, 9:56 AM

Mon, May 31

mehdi_amini committed rG119bf57ab6de: Fix invalid math formulas in quantization doc (authored by Lewuathe).
Fix invalid math formulas in quantization doc
Mon, May 31, 8:51 PM
mehdi_amini closed D101252: Fix invalid math formulas in quantization doc.
Mon, May 31, 8:51 PM · Restricted Project
mehdi_amini added a comment to D103234: [MLIR] Specify namespace for standard dialect using cppNamespace field.

Not sure why some of the unit tests fail. To me this looks unrelated to the patch. Is there any way to trigger re-running the tests?

Mon, May 31, 8:18 AM · Restricted Project

Thu, May 27

mehdi_amini committed rG80e684b19423: Fix comment to reflect what the method is doing (NFC) (authored by mehdi_amini).
Fix comment to reflect what the method is doing (NFC)
Thu, May 27, 5:03 PM
mehdi_amini added a comment to D103278: [mlir:Async] Convert assertions to async errors only inside async functions.

Can you add a test?

Thu, May 27, 12:43 PM · Restricted Project
mehdi_amini accepted D103264: [mlir] Don't elide the last op if there is no terminator.
Thu, May 27, 11:36 AM · Restricted Project
mehdi_amini added a comment to D103264: [mlir] Don't elide the last op if there is no terminator.

Do you have a test for that?

Thu, May 27, 10:22 AM · Restricted Project
mehdi_amini accepted D103248: [MLIR] Add dialect prefix to all operations from Math.
Thu, May 27, 10:10 AM · Restricted Project
mehdi_amini accepted D103266: [MLIR] Enable TensorCore integrations tests on Tesla buildbots.

LG, but I don't know if there is a need to restart the master to pick up the new config when pushing this, @gkistanova would know I think?

Thu, May 27, 10:08 AM
mehdi_amini accepted D103234: [MLIR] Specify namespace for standard dialect using cppNamespace field.
Thu, May 27, 9:08 AM · Restricted Project

Wed, May 26

mehdi_amini accepted D103226: [mlir] Support dialect-wide canonicalization pattern registration.
Wed, May 26, 10:25 PM · Restricted Project
mehdi_amini added a comment to D103226: [mlir] Support dialect-wide canonicalization pattern registration.

LGTM, but please wait for at least a day to give a change to River to have a look as well.

Wed, May 26, 10:25 PM · Restricted Project
mehdi_amini committed rG8d2576272066: Fix non-global-value-max-name-size not considered by LLParser (authored by hasyimibhar).
Fix non-global-value-max-name-size not considered by LLParser
Wed, May 26, 9:21 PM
mehdi_amini closed D102707: Fix non-global-value-max-name-size not considered by LLParser.
Wed, May 26, 9:20 PM · Restricted Project
mehdi_amini accepted D103203: [mlir] Async: Add error propagation support to async groups.
Wed, May 26, 9:10 PM · Restricted Project
mehdi_amini added a comment to D103216: [mlir][Standard] Add unsigned integers to UIToFPOp and FPToUIOp cast-compatibility checks.

I might be misunderstanding the situation, but if the Ops are signless why does SIToFOp exist?

Wed, May 26, 9:09 PM · Restricted Project
mehdi_amini accepted D103102: [mlir] Async reference counting for block successors with divergent reference counted liveness.
Wed, May 26, 8:47 PM · Restricted Project
mehdi_amini accepted D103130: [mlir][python] Provide "all passes" registration module in Python.

Indeed :)

Wed, May 26, 3:09 PM · Restricted Project
mehdi_amini requested changes to D103130: [mlir][python] Provide "all passes" registration module in Python.
Wed, May 26, 1:11 PM · Restricted Project
mehdi_amini added a comment to D103130: [mlir][python] Provide "all passes" registration module in Python.

I'd prefer a method call instead of a package, but I can live with that.

Wed, May 26, 11:14 AM · Restricted Project
mehdi_amini added a comment to D103130: [mlir][python] Provide "all passes" registration module in Python.

The others may expose other content than just registration.

The other pass oriented imports don't expose anything but passes either.

Wed, May 26, 11:05 AM · Restricted Project
mehdi_amini accepted D103187: [mlir] Make StripDebugInfo strip out block arguments locs.
Wed, May 26, 10:47 AM · Restricted Project
mehdi_amini added inline comments to D103152: [MLIR][SPIRV] Use getAsmResultName(...) hook for ConstantOp..
Wed, May 26, 9:16 AM · Restricted Project

Tue, May 25

mehdi_amini added a comment to D103130: [mlir][python] Provide "all passes" registration module in Python.

The others may expose other content than just registration, in particular if/when we develop programmatic API for individual passes. This import is a) top-level which makes it more prominent and b) does not seem like it'll have any other purpose than registration.

Tue, May 25, 8:57 PM · Restricted Project
mehdi_amini added a comment to D103130: [mlir][python] Provide "all passes" registration module in Python.

Can we have "register" somewhere in the name? This submodule won't do anything else right?
I would even consider making it a method instead:

Tue, May 25, 6:00 PM · Restricted Project
mehdi_amini accepted D103109: [mlir] Add error state and error propagation to async runtime values.
Tue, May 25, 2:15 PM · Restricted Project
mehdi_amini accepted D102707: Fix non-global-value-max-name-size not considered by LLParser.
Tue, May 25, 11:20 AM · Restricted Project

Mon, May 24

mehdi_amini accepted D103049: [mlir] Use lower sm version for TensorCore intergration tests.
Mon, May 24, 2:41 PM · Restricted Project
mehdi_amini added inline comments to D102988: [GreedyPatternRewriter] Introduce a config object that allows controlling internal parameters. NFC..
Mon, May 24, 12:48 PM · Restricted Project
mehdi_amini accepted D102987: Surface clone APIs in CAPI.
Mon, May 24, 11:35 AM · Restricted Project
mehdi_amini accepted D103035: Enable MLIR Python bindings for TOSA..
Mon, May 24, 10:00 AM · Restricted Project
mehdi_amini accepted D102988: [GreedyPatternRewriter] Introduce a config object that allows controlling internal parameters. NFC..
Mon, May 24, 9:29 AM · Restricted Project
mehdi_amini accepted D103032: [4/4][mlir][doc] Fix links and references in top level docs directory.
Mon, May 24, 9:17 AM · Restricted Project
mehdi_amini accepted D103031: [mlir] Use unique_function in AbstractOperation fields.
Mon, May 24, 9:16 AM · Restricted Project

Sun, May 23

mehdi_amini added inline comments to D102987: Surface clone APIs in CAPI.
Sun, May 23, 7:10 PM · Restricted Project
mehdi_amini added a comment to D102958: [mlir][tosa] Align tensor rank specifications with current spec.

Can you upload patches with full context please? Right now I can't see which ops are modified here.

Sun, May 23, 7:08 PM · Restricted Project
mehdi_amini added inline comments to D102987: Surface clone APIs in CAPI.
Sun, May 23, 6:36 PM · Restricted Project
mehdi_amini added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
Sun, May 23, 10:04 AM · Restricted Project
mehdi_amini accepted D102983: [mlir][doc] Fix links and indentation of mlir::ModuleOp description.
Sun, May 23, 10:00 AM · Restricted Project

Sat, May 22

mehdi_amini added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
Sat, May 22, 9:32 AM · Restricted Project

Fri, May 21

mehdi_amini added inline comments to D102952: [mlir-opt] Don't enable `printOpOnDiagnostic` if it was explicitly disabled..
Fri, May 21, 4:33 PM · Restricted Project
mehdi_amini accepted D101880: [mlir] Resolve TODO and use the pass argument instead of the TypeID for registration.
Fri, May 21, 12:28 PM · Restricted Project
mehdi_amini accepted D102441: [mlir] Add support for filtering patterns based on debug names and labels.
Fri, May 21, 12:26 PM · Restricted Project
mehdi_amini added a reviewer for D102882: [AMDGPU] Fix module LDS selection: mehdi_amini.
Fri, May 21, 9:32 AM · Restricted Project
mehdi_amini accepted D102922: [mlir][docs] Fix links to index and integer types.

Thanks!

Fri, May 21, 9:18 AM · Restricted Project

Thu, May 20

mehdi_amini added inline comments to D102679: [llvm] Make Sequence reverse-iterable.
Thu, May 20, 4:17 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D102868: [mlir][MemRef] NFC - Drop MemRef EDSC usage.
Thu, May 20, 2:47 PM · Restricted Project
mehdi_amini added a comment to D102827: [mlir][Python][linalg] Fix to limit size of SmallVector..

That seems fairly ad-hoc as a fix: what are the conditions where this is a problem more precisely?

Thu, May 20, 12:05 PM · Restricted Project

Wed, May 19

mehdi_amini added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
Wed, May 19, 3:47 PM · Restricted Project
mehdi_amini accepted D102780: [mlir][SCF] NFC - Drop SCF EDSC usage.
Wed, May 19, 8:46 AM · Restricted Project

Tue, May 18

mehdi_amini added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
Tue, May 18, 9:36 PM · Restricted Project