Page MenuHomePhabricator

mehdi_amini (Mehdi AMINI)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2013, 5:34 PM (473 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

mehdi_amini added a comment to D126512: [Docs] Clarify the guideline on omitting braces.

This makes sense to me. do/while loops are rare, and because the condition comes after the body, they are structurally different than the other loops and conditionals.

Thu, May 26, 11:52 PM · Restricted Project, Restricted Project
mehdi_amini accepted D126504: Summary: [mlir] Fix the misspellings of CHECK-* directives..

Thanks!

Thu, May 26, 3:04 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D120727: [libc++] Overhaul how we select the ABI library.

Forgot to mention, we configure this build with:

cmake -G Ninja ${src_dir}/llvm -DLLVM_TARGETS_TO_BUILD="X86;NVPTX;AMDGPU" -DLLVM_ENABLE_PROJECTS="lld;clang;mlir" -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=Off -DLIBCXX_CXX_ABI=default -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"  -DLLVM_ENABLE_LLD=ON  -DLLVM_DISTRIBUTION_COMPONENTS="clang;runtimes" -DLLVM_CCACHE_BUILD=ON
Thu, May 26, 2:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D120727: [libc++] Overhaul how we select the ABI library.

I hit a config failure after f8c8bda965dd0f622de1ad3863b728661af6eb72

Thu, May 26, 2:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini committed rGc067a9dee5c1: Apply clang-tidy fixes for llvm-else-after-return in OpenMPDialect.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for llvm-else-after-return in OpenMPDialect.cpp (NFC)
Thu, May 26, 2:30 PM · Restricted Project, Restricted Project
mehdi_amini committed rGda3b8200e599: Apply clang-tidy fixes for performance-unnecessary-value-param in Bufferize.cpp… (authored by mehdi_amini).
Apply clang-tidy fixes for performance-unnecessary-value-param in Bufferize.cpp…
Thu, May 26, 2:30 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D126422: [mlir][python][ctypes] fix ctype python binding complication for complex.

Can you add tests for this?

Thu, May 26, 3:24 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D126446: WIP: [mlir] Allow for attaching external configurations to .mlir files.

What about using directly YAML for this section?

Thu, May 26, 1:37 AM · Restricted Project, Restricted Project

Wed, May 25

mehdi_amini added a comment to D125701: [mlir][NFC] Do not convert bool to int when returning from main.

Can you clarify the motivation for this?

Wed, May 25, 9:07 AM · Restricted Project, Restricted Project

Tue, May 24

mehdi_amini added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Can you clarify the revision description? You refer to some "unbound computation" which isn't clear to me. I think the whole motivation and rationale could be better spelled out.

Tue, May 24, 1:57 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D125938: [mlir] Breakdown diagnostic string literals.

I feel like I'm missing some context here, can you show some form of before/after? or is this intended to be an NFC cleanup?

Tue, May 24, 1:39 AM · Restricted Project, Restricted Project

Mon, May 23

mehdi_amini committed rG994a1841eb30: Apply clang-tidy fixes for modernize-use-bool-literals in Parser.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for modernize-use-bool-literals in Parser.cpp (NFC)
Mon, May 23, 4:14 PM · Restricted Project, Restricted Project
mehdi_amini committed rGf38765a813e6: Apply clang-tidy fixes for modernize-use-override in SparseTensorUtils.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for modernize-use-override in SparseTensorUtils.cpp (NFC)
Mon, May 23, 4:14 PM · Restricted Project, Restricted Project
mehdi_amini committed rG63d69a21b7a7: Apply clang-tidy fixes for performance-unnecessary-value-param in Utils.cpp… (authored by mehdi_amini).
Apply clang-tidy fixes for performance-unnecessary-value-param in Utils.cpp…
Mon, May 23, 4:14 PM · Restricted Project, Restricted Project

Fri, May 20

mehdi_amini accepted D126094: [mlir] MemRefToLLVM: convert memref.view operations for empty memrefs.
Fri, May 20, 2:49 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.
Fri, May 20, 1:59 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D126003: [mlir][bufferization] Add bufferization.alloc_tensor op.
Fri, May 20, 8:44 AM · Restricted Project, Restricted Project

Wed, May 18

mehdi_amini committed rG302158df6a69: Apply clang-tidy fixes for llvm-else-after-return in OpenMPDialect.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for llvm-else-after-return in OpenMPDialect.cpp (NFC)
Wed, May 18, 9:17 AM · Restricted Project, Restricted Project
mehdi_amini committed rGe1ff449ec927: Apply clang-tidy fixes for performance-for-range-copy in LinalgOps.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for performance-for-range-copy in LinalgOps.cpp (NFC)
Wed, May 18, 9:17 AM · Restricted Project, Restricted Project

Mon, May 16

mehdi_amini accepted D125063: [mlir][transforms] Add a topological sort utility and pass.
Mon, May 16, 8:13 AM · Restricted Project, Restricted Project
mehdi_amini committed rG08482fa05882: Apply clang-tidy fixes for llvm-qualified-auto in LinalgInterfaces.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for llvm-qualified-auto in LinalgInterfaces.cpp (NFC)
Mon, May 16, 6:59 AM · Restricted Project, Restricted Project
mehdi_amini committed rG59c3be748f89: Apply clang-tidy fixes for performance-move-const-arg in SerializeToHsaco.cpp… (authored by mehdi_amini).
Apply clang-tidy fixes for performance-move-const-arg in SerializeToHsaco.cpp…
Mon, May 16, 6:59 AM · Restricted Project, Restricted Project
mehdi_amini accepted D125501: [mlir] Remove the `type` keyword from type alias definitions.
Mon, May 16, 2:52 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D123481: Do not build with Werror by default (Bazel build).

I rebased, can you check the premerge to see if it does what you expect? (I'm not sure what you want to look at)

Mon, May 16, 2:32 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D123481: Do not build with Werror by default (Bazel build).

rebase

Mon, May 16, 1:52 AM · Restricted Project, Restricted Project

Thu, May 12

mehdi_amini accepted D125387: Rename and fix ValueMap::resize to reserve.

Thanks!

Thu, May 12, 5:07 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D125387: Rename and fix ValueMap::resize to reserve.

Yeah probably best to rename it as the same time here. This won't break anyone considering the current state!
Thanks.

Thu, May 12, 4:59 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D125063: [mlir][transforms] Add a topological sort utility and pass.
Thu, May 12, 1:34 AM · Restricted Project, Restricted Project

Wed, May 11

mehdi_amini added a comment to D125407: Prepare for inlining of SUM intrinsic.

(I didn't make it explicit, but the overall approach makes sense to me)

Wed, May 11, 3:25 PM · Restricted Project, Restricted Project
mehdi_amini accepted D125351: [mlir:Parser] Emit a better diagnostic when a custom operation is unknown.
Wed, May 11, 3:21 PM · Restricted Project, Restricted Project
mehdi_amini accepted D125357: [MLIR] Fix build without native arch.
Wed, May 11, 3:19 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D125387: Rename and fix ValueMap::resize to reserve.

Does it mean that there are no in-tree user for this API?
Are you gonna rename this to reserve as a follow-up patch? I'm not sure I got entirely why not rename it now (that is this API is broken anyway...)?

Wed, May 11, 3:18 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D123481: Do not build with Werror by default (Bazel build).
Wed, May 11, 3:15 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D125407: Prepare for inlining of SUM intrinsic.

Just some quick skimming through, I had a few comments, hope this helps! :)

Wed, May 11, 1:58 PM · Restricted Project, Restricted Project
mehdi_amini accepted D123536: [mlir:Pass] Add support for op-agnostic pass managers.
Wed, May 11, 11:34 AM · Restricted Project, Restricted Project

Tue, May 10

mehdi_amini added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Thanks for improving the doc! Are you moving this to be used in canonicalization next?
I think a first good step would be to make it a pattern and test it with a pass that applies it in the greedy rewriter. I would land this first and then try to enable this in the canonicalized.

Tue, May 10, 3:07 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini committed rG3ffb08844cc4: Remove unused variable (fix -Werror build on MSVC) (authored by mehdi_amini).
Remove unused variable (fix -Werror build on MSVC)
Tue, May 10, 2:05 PM · Restricted Project, Restricted Project
mehdi_amini added a reviewer for D124750: [MLIR] Add a utility to sort the operands of commutative ops: Mogball.
Tue, May 10, 6:29 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

That was the sense of my question about canonicalization indeed :)

Tue, May 10, 1:55 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

You're telling me "what" while I'm actually more interested in the "why" here?

I'm not sure what your question is, with a "why". Let me think about this a bit. I'll get back to you.

Tue, May 10, 1:36 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 9

mehdi_amini added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Seems like this should be added to canonicalization? The "push constants to the right hand side" is there already.

I think this was not added to canonicalization because we wanted it to be an independent utility that can be used if needed and not be used if not needed.

Mon, May 9, 5:07 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added inline comments to D123536: [mlir:Pass] Add support for op-agnostic pass managers.
Mon, May 9, 12:23 PM · Restricted Project, Restricted Project
mehdi_amini accepted D125214: [MLIR] Split off MLIRExecutionEngineUtils to fix libMLIR.so build (PR54242).

LGTM, but please update the title and description.

Mon, May 9, 9:44 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

Seems like this should be added to canonicalization? The "push constants to the right hand side" is there already.

Mon, May 9, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini requested changes to D125214: [MLIR] Split off MLIRExecutionEngineUtils to fix libMLIR.so build (PR54242).

We should resolve the discussion in the tracking bug first I think: https://github.com/llvm/llvm-project/issues/54242#issuecomment-1063520117

Mon, May 9, 7:23 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D125182: [mlir] Experimental, simplified CMake auto-config for Python development..

Does this print how to run the python file in case of CMake failure?

Mon, May 9, 6:12 AM · Restricted Project, Restricted Project

Sun, May 8

mehdi_amini added inline comments to D125122: [mlir] Fix build & test of mlir python bindings on Windows.
Sun, May 8, 3:00 AM · Restricted Project, Restricted Project

Sat, May 7

mehdi_amini added inline comments to D125122: [mlir] Fix build & test of mlir python bindings on Windows.
Sat, May 7, 3:01 AM · Restricted Project, Restricted Project
mehdi_amini requested review of D125161: Remove dead code `PointerLikeTypeTraits<mlir::ModuleOp>` (NFC).
Sat, May 7, 2:54 AM · Restricted Project, Restricted Project
mehdi_amini committed rG25cd6fba983a: Fix MLIR integration test after a8308020 (`func.` prefix is required bythe… (authored by mehdi_amini).
Fix MLIR integration test after a8308020 (`func.` prefix is required bythe…
Sat, May 7, 2:11 AM · Restricted Project, Restricted Project

Fri, May 6

mehdi_amini committed rG6a9c1029f845: Fix build with shared libs: add missing CMake dep to MLIR sparse pipeline (authored by mehdi_amini).
Fix build with shared libs: add missing CMake dep to MLIR sparse pipeline
Fri, May 6, 1:21 PM · Restricted Project, Restricted Project
mehdi_amini committed rGb37d158f71c2: Apply clang-tidy fixes for bugprone-copy-constructor-init in TestPassManager. (authored by mehdi_amini).
Apply clang-tidy fixes for bugprone-copy-constructor-init in TestPassManager.
Fri, May 6, 1:21 PM · Restricted Project, Restricted Project
mehdi_amini committed rG298d2fa1c5f1: Apply clang-tidy fixes for readability-identifier-naming in SparseTensorUtils. (authored by mehdi_amini).
Apply clang-tidy fixes for readability-identifier-naming in SparseTensorUtils.
Fri, May 6, 1:21 PM · Restricted Project, Restricted Project
mehdi_amini committed rG90c2af57afb8: Apply clang-tidy fixes for llvm-include-order in Merger.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for llvm-include-order in Merger.cpp (NFC)
Fri, May 6, 1:21 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D125122: [mlir] Fix build & test of mlir python bindings on Windows.
Fri, May 6, 12:56 PM · Restricted Project, Restricted Project
mehdi_amini committed rG072e0aabbc45: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested… (authored by mehdi_amini).
Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested…
Fri, May 6, 12:41 PM · Restricted Project, Restricted Project
mehdi_amini closed D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.
Fri, May 6, 12:40 PM · Restricted Project, Restricted Project
mehdi_amini committed rGc5ea8d509cf8: Apply clang-tidy fixes for llvm-else-after-return in Merger.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for llvm-else-after-return in Merger.cpp (NFC)
Fri, May 6, 12:39 PM · Restricted Project, Restricted Project
mehdi_amini committed rG061f253e13b5: Apply clang-tidy fixes for llvm-prefer-isa-or-dyn-cast-in-conditionals in… (authored by mehdi_amini).
Apply clang-tidy fixes for llvm-prefer-isa-or-dyn-cast-in-conditionals in…
Fri, May 6, 12:38 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D125063: [mlir][transforms] Add a topological sort utility and pass.
Fri, May 6, 12:33 PM · Restricted Project, Restricted Project

Thu, May 5

mehdi_amini committed rGbe310632d037: Apply clang-tidy fixes for llvm-else-after-return in OpenMPDialect.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for llvm-else-after-return in OpenMPDialect.cpp (NFC)
Thu, May 5, 10:40 PM · Restricted Project, Restricted Project
mehdi_amini committed rG6e32535078b4: Apply clang-tidy fixes for bugprone-argument-comment in AffineOps.cpp (NFC) (authored by mehdi_amini).
Apply clang-tidy fixes for bugprone-argument-comment in AffineOps.cpp (NFC)
Thu, May 5, 10:40 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D125063: [mlir][transforms] Add a topological sort utility and pass.
Thu, May 5, 10:19 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D125063: [mlir][transforms] Add a topological sort utility and pass.
Thu, May 5, 10:19 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D124891: [mlir] Fix the names of exported functions.

Thanks for fixing this!

Thu, May 5, 9:59 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D125051: [mlir] Tighten the verification of SameOperandsAndResultType.

they can get the same behavior by using the SameOperandsAndResultShape and SameOperandsAndResultElementType traits.

Thu, May 5, 9:49 PM · Restricted Project, Restricted Project

Wed, May 4

mehdi_amini added inline comments to D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.
Wed, May 4, 10:04 AM · Restricted Project, Restricted Project
mehdi_amini accepted D124870: [mlir] Add a better error message when failing to parse an attribute.

Thanks! That "expected non-function type" message annoyed me so many times :)
(I suspect it will in other contexts than the one you're fixing)

Wed, May 4, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini updated the diff for D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.

Process one action in the current thread before waiting for the tasksGroup.

Wed, May 4, 7:51 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.
Wed, May 4, 7:49 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.

Adding Chris for visibility, I know he was thinking about our threading model and utilities recently!

Wed, May 4, 7:47 AM · Restricted Project, Restricted Project
mehdi_amini updated subscribers of D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.
Wed, May 4, 7:46 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.

Add a comment on the wait()

Wed, May 4, 12:45 AM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.
Wed, May 4, 12:43 AM · Restricted Project, Restricted Project
mehdi_amini updated the diff for D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.

Remove futures and use taskgroup.wait()

Wed, May 4, 12:42 AM · Restricted Project, Restricted Project

Tue, May 3

mehdi_amini requested review of D124902: Enable the use of ThreadPoolTaskGroup in MLIR threading helper to enable nested parallelism.
Tue, May 3, 9:59 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D124207: [MLIR] introduce and use add_mlir_{tool,executable} variants.

per-project installation directory (useful for standalone)

Tue, May 3, 9:00 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D123225: [ThreadPool] add ability to group tasks into separate groups.

It may be also safe to ignore, it's not this patch that's responsible for this.

Tue, May 3, 9:02 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D123225: [ThreadPool] add ability to group tasks into separate groups.
llvm-lit: /var/lib/buildkite-agent/builds/llvm-project/llvm/utils/lit/lit/discovery.py:247: warning: test suite 'lld-Unit' contained no tests
Tue, May 3, 9:01 AM · Restricted Project, Restricted Project

Sun, May 1

mehdi_amini accepted D124744: [mlir] CRunnerUtils: qualify UnrankedMemRefType to avoid collisions with mlir::UnrankedMemRefType.
Sun, May 1, 8:57 PM · Restricted Project, Restricted Project

Fri, Apr 29

mehdi_amini accepted D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

LGTM, but please wait for others!

Fri, Apr 29, 11:23 AM · Restricted Project, Restricted Project

Thu, Apr 28

mehdi_amini accepted D124619: [llvm] Ignore .rej files in .gitignore.
Thu, Apr 28, 8:26 AM · Restricted Project, Restricted Project

Apr 26 2022

mehdi_amini added a comment to D123576: Support constructing empty function_ref from other callables that can be "empty".

How do you see the list declared?
I mean we can list std::function because we include the header, but would you / could you forward déclaré absl, folly, boost, etc. equivalent here? I feel I missed something?

Apr 26 2022, 4:26 PM · Restricted Project, Restricted Project

Apr 25 2022

mehdi_amini added inline comments to D124188: [AsmParser/Printer] Rework sourceloc support for function arguments..
Apr 25 2022, 11:05 AM · Restricted Project, Restricted Project

Apr 23 2022

mehdi_amini added a comment to D124048: [MLIR] Add option to print users of an operation as comment in the printer.

I don't have commit access, so it would be great if you could land the patch for me. Please use "Christoph Pillmayer cpillmayer@gmail.com" for the commit.

Apr 23 2022, 12:26 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D123876: [mlir][sparse] Expose SparseTensor passes as enums instead of opaque numbers for vectorization and parallelization options..

Sorry, I missed this... Can you please rebase? There is a conflict in a test.

Apr 23 2022, 12:18 AM · Restricted Project, Restricted Project

Apr 22 2022

mehdi_amini accepted D124298: [mlir][NFC] Shift a bunch of dialect includes from the .h to the .cpp.
Apr 22 2022, 5:22 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini committed rG3e8560f890bb: [MLIR] Add option to print users of an operation as comment in the printer (authored by cpillmayer).
[MLIR] Add option to print users of an operation as comment in the printer
Apr 22 2022, 11:58 AM · Restricted Project, Restricted Project
mehdi_amini closed D124048: [MLIR] Add option to print users of an operation as comment in the printer.
Apr 22 2022, 11:58 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

We have some pieces of data though: the number of people who complain about the build filling up their disk and the link taking forever (or OOM). On the other hand the people who "know" are already setting up an explicit value...
That said I tend to think that the audience is heterogeneous enough that I agree it seems hard to make sure we "pick a default that's "right" " in the absolute (hence my proposal to not pick any).

Apr 22 2022, 11:01 AM · Restricted Project, Restricted Project
mehdi_amini accepted D124048: [MLIR] Add option to print users of an operation as comment in the printer.

LGTM!
Do you have commit access?

Apr 22 2022, 10:11 AM · Restricted Project, Restricted Project

Apr 21 2022

mehdi_amini added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

I disagree about erroring out when CMAKE_BUILD_TYPE is undefined. We want to make the build easy for new users, so I think it's important that the default build (cmake with no arguments) just works.

Apr 21 2022, 8:43 PM · Restricted Project, Restricted Project
mehdi_amini added a reviewer for D123576: Support constructing empty function_ref from other callables that can be "empty": dblaikie.
Apr 21 2022, 6:00 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D124146: [mlir] Remove special case parsing/printing of `func` operations.

Can you please include the regex for the update of mlir files in the description?

Apr 21 2022, 5:55 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added a comment to D124048: [MLIR] Add option to print users of an operation as comment in the printer.

LGTM overall!

Apr 21 2022, 5:53 PM · Restricted Project, Restricted Project
mehdi_amini accepted D124205: [MLIR] prefer /bin/sh over /bin/bash for simple test scripts.
Apr 21 2022, 5:40 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D112021: [mlir] Add asserts when changing various MLIRContext configurations.
Apr 21 2022, 1:12 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D123492: [mlir][CSE] Add ability to remove commutative operations.
Apr 21 2022, 9:18 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

I don't understand the rational about turning assertions on. To me changing the default is about making it easier for users who just want to use LLVM to get the right version running, while assertions are targeting developers.

Apr 21 2022, 9:13 AM · Restricted Project, Restricted Project

Apr 20 2022

mehdi_amini added inline comments to D123492: [mlir][CSE] Add ability to remove commutative operations.
Apr 20 2022, 6:47 PM · Restricted Project, Restricted Project