Page MenuHomePhabricator

alexander-shaposhnikov (Alexander Shaposhnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 3:32 PM (261 w, 6 d)

Recent Activity

Thu, Jul 15

alexander-shaposhnikov accepted D106103: [test] Use double pound to denote comments..
Thu, Jul 15, 3:54 PM · Restricted Project

Wed, Jul 14

alexander-shaposhnikov committed rGd21772fa21de: [lld][MachO] Code cleanup (authored by alexander-shaposhnikov).
[lld][MachO] Code cleanup
Wed, Jul 14, 4:34 AM
alexander-shaposhnikov closed D105452: [lld][MachO] Code cleanup.
Wed, Jul 14, 4:33 AM · Restricted Project, Restricted Project

Mon, Jul 5

alexander-shaposhnikov requested review of D105452: [lld][MachO] Code cleanup.
Mon, Jul 5, 7:14 PM · Restricted Project, Restricted Project

Thu, Jul 1

alexander-shaposhnikov removed a reviewer for D104060: Machine IR Profile: alexander-shaposhnikov.
Thu, Jul 1, 5:50 PM · Restricted Project
alexander-shaposhnikov added a reviewer for D105258: [llvm-readobj][MachO] Support option --unwind for __eh_frame: clayborg.
Thu, Jul 1, 11:33 AM · Restricted Project

Wed, Jun 30

alexander-shaposhnikov accepted D105249: [llvm-strip] Support grouped options in llvm-strip.
Wed, Jun 30, 7:16 PM · Restricted Project

Jun 29 2021

alexander-shaposhnikov committed rG6d72845a8517: [llvm-objcopy][MachO] Code cleanup (authored by alexander-shaposhnikov).
[llvm-objcopy][MachO] Code cleanup
Jun 29 2021, 2:08 PM
alexander-shaposhnikov accepted D104967: [llvm-objcopy][MachO] Support ARM64_RELOC_ADDEND.
Jun 29 2021, 1:55 AM · Restricted Project
alexander-shaposhnikov added a reverting change for rGc94cf97b5356: [llvm-objcopy][MachO] Minor code cleanup: rG6229369e5089: Revert "[llvm-objcopy][MachO] Minor code cleanup".
Jun 29 2021, 1:20 AM
alexander-shaposhnikov committed rG6229369e5089: Revert "[llvm-objcopy][MachO] Minor code cleanup" (authored by alexander-shaposhnikov).
Revert "[llvm-objcopy][MachO] Minor code cleanup"
Jun 29 2021, 1:20 AM

Jun 28 2021

alexander-shaposhnikov committed rGc94cf97b5356: [llvm-objcopy][MachO] Minor code cleanup (authored by alexander-shaposhnikov).
[llvm-objcopy][MachO] Minor code cleanup
Jun 28 2021, 10:51 PM
alexander-shaposhnikov added inline comments to D104968: [llvm-objcopy][MachO] Support LC_LINKER_OPTIMIZATION_HINT load command.
Jun 28 2021, 9:52 PM · Restricted Project
alexander-shaposhnikov accepted D104968: [llvm-objcopy][MachO] Support LC_LINKER_OPTIMIZATION_HINT load command.

lg

Jun 28 2021, 9:42 PM · Restricted Project
alexander-shaposhnikov accepted D105080: [lld-macho] Only enable `__DATA_CONST` for newer platforms.
Jun 28 2021, 9:09 PM · Restricted Project, Restricted Project

Jun 27 2021

alexander-shaposhnikov added a comment to D104968: [llvm-objcopy][MachO] Support LC_LINKER_OPTIMIZATION_HINT load command.

Regarding tests:

Jun 27 2021, 12:36 AM · Restricted Project

Jun 26 2021

alexander-shaposhnikov committed rGd8678246fcd9: [docs][llvm-strip] Fix documentation for -s/-S (authored by alexander-shaposhnikov).
[docs][llvm-strip] Fix documentation for -s/-S
Jun 26 2021, 9:27 PM
alexander-shaposhnikov closed D104888: [docs][llvm-strip] Fix documentation for -s/-S.
Jun 26 2021, 9:27 PM · Restricted Project

Jun 25 2021

MaskRay renamed alexander-shaposhnikov from alexshap to alexander-shaposhnikov.
Jun 25 2021, 1:06 AM

Jun 24 2021

alexander-shaposhnikov requested review of D104888: [docs][llvm-strip] Fix documentation for -s/-S.
Jun 24 2021, 5:11 PM · Restricted Project

Jun 14 2021

alexander-shaposhnikov committed rG928394d10918: [lld][MachO] Add support for LC_DATA_IN_CODE (authored by alexander-shaposhnikov).
[lld][MachO] Add support for LC_DATA_IN_CODE
Jun 14 2021, 7:22 PM

Jun 13 2021

alexander-shaposhnikov added a comment to D104164: Remove __llvm_mipmap section in llvm-strip.

my 0.02$ - (the diff lacks tests, isDebugSection has a more specific meaning in this context - but these are minor concerns), the main concern - I'm not sure that putting this logic into llvm-objcopy is a good idea, there are many tools which create extra sections and making llvm-objcopy aware of them doesn't feel right. Btw - llvm-strip has --remove-section as well, so e.g. you can simply add it to the same invocation of the tool, no need to run it as a separate build step. But I'd like to hear what others think, cc @jhenderson, @MaskRay

Jun 13 2021, 1:16 AM · Restricted Project

Jun 12 2021

alexander-shaposhnikov added a comment to D104164: Remove __llvm_mipmap section in llvm-strip.

I'm wondering if you can use llvm-objcopy --remove-section for these purposes instead?

Jun 12 2021, 4:25 PM · Restricted Project

Jun 11 2021

alexander-shaposhnikov committed rGb9095f5e1a7f: [lld][MachO] Fix function starts section (authored by alexander-shaposhnikov).
[lld][MachO] Fix function starts section
Jun 11 2021, 5:53 PM
alexander-shaposhnikov committed rG0276cc742bfc: [llvm-objcopy][MachO] Do not strip symbols with the flag REFERENCED_DYNAMICALLY… (authored by alexander-shaposhnikov).
[llvm-objcopy][MachO] Do not strip symbols with the flag REFERENCED_DYNAMICALLY…
Jun 11 2021, 4:35 PM
alexander-shaposhnikov closed D104092: [llvm-objcopy][MachO] Keep symbols having the flag REFERENCED_DYNAMICALLY set.
Jun 11 2021, 4:35 PM · Restricted Project
alexander-shaposhnikov updated the diff for D104092: [llvm-objcopy][MachO] Keep symbols having the flag REFERENCED_DYNAMICALLY set.
Jun 11 2021, 4:32 PM · Restricted Project

Jun 10 2021

alexander-shaposhnikov updated the summary of D104092: [llvm-objcopy][MachO] Keep symbols having the flag REFERENCED_DYNAMICALLY set.
Jun 10 2021, 7:26 PM · Restricted Project
alexander-shaposhnikov retitled D104092: [llvm-objcopy][MachO] Keep symbols having the flag REFERENCED_DYNAMICALLY set from [llvm-objcopy][MachO] Do not strip symbols having the flag REFERENCED_DYNAMICALLY set to [llvm-objcopy][MachO] Keep symbols having the flag REFERENCED_DYNAMICALLY set.
Jun 10 2021, 7:25 PM · Restricted Project
alexander-shaposhnikov requested review of D104092: [llvm-objcopy][MachO] Keep symbols having the flag REFERENCED_DYNAMICALLY set.
Jun 10 2021, 7:24 PM · Restricted Project

Jun 9 2021

alexander-shaposhnikov added inline comments to D103985: [lld/mac] Print dylib search details with --print-dylib-search or RC_TRACE_DYLIB_SEARCHING.
Jun 9 2021, 1:54 PM · Restricted Project, Restricted Project
alexander-shaposhnikov added inline comments to D103985: [lld/mac] Print dylib search details with --print-dylib-search or RC_TRACE_DYLIB_SEARCHING.
Jun 9 2021, 1:19 PM · Restricted Project, Restricted Project

Jun 7 2021

alexander-shaposhnikov added inline comments to D102964: [lld-macho] Implement cstring deduplication.
Jun 7 2021, 4:03 PM · Restricted Project, Restricted Project
alexander-shaposhnikov added inline comments to D102964: [lld-macho] Implement cstring deduplication.
Jun 7 2021, 3:48 PM · Restricted Project, Restricted Project

Jun 6 2021

alexander-shaposhnikov accepted D103776: [lld/mac] Rename DylibFile::dylibName to DylibFile::installName.

code formatting needs to be fixed (see the lint message above), otherwise lgtm

Jun 6 2021, 3:42 PM · Restricted Project, Restricted Project
alexander-shaposhnikov accepted D103774: [lld/mac] Use fewer magic numbers in magic $ld$ handling code.
Jun 6 2021, 2:41 PM · Restricted Project, Restricted Project
alexander-shaposhnikov added inline comments to D103774: [lld/mac] Use fewer magic numbers in magic $ld$ handling code.
Jun 6 2021, 2:30 PM · Restricted Project, Restricted Project

Jun 5 2021

alexander-shaposhnikov added a reviewer for D103292: [lld-macho] Implement ICF: alexander-shaposhnikov.
Jun 5 2021, 8:26 PM · Restricted Project, Restricted Project
alexander-shaposhnikov committed rG5e49ee87947f: [lld][MachO] Add support for $ld$install_name symbols (authored by alexander-shaposhnikov).
[lld][MachO] Add support for $ld$install_name symbols
Jun 5 2021, 12:59 PM
alexander-shaposhnikov committed rGcf29a92b9026: [lld][MachO] Fix typo in special-symbol-ld-previous.s (authored by alexander-shaposhnikov).
[lld][MachO] Fix typo in special-symbol-ld-previous.s
Jun 5 2021, 1:30 AM
alexander-shaposhnikov committed rG065a9316aa60: [MC] Add getLSDASection interface (authored by Amir).
[MC] Add getLSDASection interface
Jun 5 2021, 12:36 AM
alexander-shaposhnikov closed D102298: [MC] Add getLSDASection interface.
Jun 5 2021, 12:36 AM · Restricted Project

Jun 4 2021

alexander-shaposhnikov committed rG1309c181a852: [lld][MachO] Add first bits to support special symbols (authored by alexander-shaposhnikov).
[lld][MachO] Add first bits to support special symbols
Jun 4 2021, 11:34 PM
alexander-shaposhnikov added a comment to D102298: [MC] Add getLSDASection interface.

sure

Jun 4 2021, 11:04 PM · Restricted Project

May 24 2021

alexander-shaposhnikov accepted D102972: [lld-macho][nfc] Sort OutputSections based on explicit order of command-line inputs.
May 24 2021, 6:40 PM · Restricted Project, Restricted Project
alexander-shaposhnikov added inline comments to D102974: [lld-macho][nfc] Remove unnecessary parameterization of section sort.
May 24 2021, 10:24 AM · Restricted Project, Restricted Project
alexander-shaposhnikov accepted D102974: [lld-macho][nfc] Remove unnecessary parameterization of section sort.
May 24 2021, 10:20 AM · Restricted Project, Restricted Project

May 23 2021

alexander-shaposhnikov committed rG57501e512e86: [lld][MachO] Fix code formatting (authored by alexander-shaposhnikov).
[lld][MachO] Fix code formatting
May 23 2021, 8:50 PM

May 22 2021

alexander-shaposhnikov added inline comments to D102972: [lld-macho][nfc] Sort OutputSections based on explicit order of command-line inputs.
May 22 2021, 7:32 PM · Restricted Project, Restricted Project
alexander-shaposhnikov accepted D102971: [lld-macho][nfc] Rename MergedOutputSection to ConcatOutputSection.
May 22 2021, 7:18 PM · Restricted Project, Restricted Project
alexander-shaposhnikov added inline comments to D102971: [lld-macho][nfc] Rename MergedOutputSection to ConcatOutputSection.
May 22 2021, 6:30 PM · Restricted Project, Restricted Project
alexander-shaposhnikov added inline comments to D102972: [lld-macho][nfc] Sort OutputSections based on explicit order of command-line inputs.
May 22 2021, 6:28 PM · Restricted Project, Restricted Project

May 17 2021

alexander-shaposhnikov committed rGdc2c6cf2749f: [lld][MachO] Adjust isCodeSection signature (authored by alexander-shaposhnikov).
[lld][MachO] Adjust isCodeSection signature
May 17 2021, 10:10 PM
alexander-shaposhnikov closed D102664: [lld][MachO] Adjust isCodeSection signature.
May 17 2021, 10:10 PM · Restricted Project, Restricted Project
alexander-shaposhnikov requested review of D102664: [lld][MachO] Adjust isCodeSection signature.
May 17 2021, 9:16 PM · Restricted Project, Restricted Project

May 12 2021

alexander-shaposhnikov accepted D102298: [MC] Add getLSDASection interface.
May 12 2021, 2:59 PM · Restricted Project

May 9 2021

alexander-shaposhnikov accepted D102114: [llvm-objdump][MachO] Print a newline before lazy bind/bind/weak/exports trie.
May 9 2021, 12:42 PM · Restricted Project, Restricted Project

May 3 2021

alexander-shaposhnikov accepted D101814: [lld-macho] Preliminary support for ARM_RELOC_BR24.
May 3 2021, 11:07 PM · Restricted Project, Restricted Project

Apr 28 2021

alexander-shaposhnikov committed rG86f291ebb2df: [llvm-objcopy][MachO] Add support for LC_THREAD/LC_UNIXTHREAD (authored by alexander-shaposhnikov).
[llvm-objcopy][MachO] Add support for LC_THREAD/LC_UNIXTHREAD
Apr 28 2021, 4:30 PM

Apr 27 2021

alexander-shaposhnikov added a reverting change for rG4dfddf715b94: [llvm-objcopy][MachO] Add support for LC_THREAD/LC_UNIXTHREAD: rG412437aec088: Revert "[llvm-objcopy][MachO] Add support for LC_THREAD/LC_UNIXTHREAD".
Apr 27 2021, 4:20 PM
alexander-shaposhnikov committed rG412437aec088: Revert "[llvm-objcopy][MachO] Add support for LC_THREAD/LC_UNIXTHREAD" (authored by alexander-shaposhnikov).
Revert "[llvm-objcopy][MachO] Add support for LC_THREAD/LC_UNIXTHREAD"
Apr 27 2021, 4:20 PM
alexander-shaposhnikov committed rG4dfddf715b94: [llvm-objcopy][MachO] Add support for LC_THREAD/LC_UNIXTHREAD (authored by alexander-shaposhnikov).
[llvm-objcopy][MachO] Add support for LC_THREAD/LC_UNIXTHREAD
Apr 27 2021, 3:55 PM

Apr 21 2021

alexander-shaposhnikov accepted D100978: [lld-macho][nfc] Add accessors for commonly-used PlatformInfo fields.

thanks!

Apr 21 2021, 10:57 AM · Restricted Project, Restricted Project
alexander-shaposhnikov committed rGb5720354efb6: [lld][MachO] Refactor findCommand (authored by alexander-shaposhnikov).
[lld][MachO] Refactor findCommand
Apr 21 2021, 8:38 AM
alexander-shaposhnikov closed D100954: [lld][MachO] Refactor findCommand.
Apr 21 2021, 8:38 AM · Restricted Project, Restricted Project
alexander-shaposhnikov updated the diff for D100954: [lld][MachO] Refactor findCommand.
Apr 21 2021, 7:56 AM · Restricted Project, Restricted Project
alexander-shaposhnikov requested review of D100954: [lld][MachO] Refactor findCommand.
Apr 21 2021, 6:46 AM · Restricted Project, Restricted Project
alexander-shaposhnikov committed rG5c835e1ae5e1: [lld][MachO] Add support for LC_VERSION_MIN_* load commands (authored by alexander-shaposhnikov).
[lld][MachO] Add support for LC_VERSION_MIN_* load commands
Apr 21 2021, 5:59 AM

Apr 20 2021

alexander-shaposhnikov accepted D100848: [lld-macho] Ensure segments are laid out contiguously.
Apr 20 2021, 10:42 AM · Restricted Project, Restricted Project

Apr 16 2021

alexander-shaposhnikov added a comment to D100583: [llvm-objdump] Add an llvm-otool tool.

Hi! Thanks for working on this, I actually had some similar plans in the past.
One question (I believe that you have already explored it, so I'm asking mostly for the future reference) - did you choose llvm-objdump because it's the closest (from the available options) counterpart to otool featurewise ?
(e.g. closer than llvm-readobj) ?

Apr 16 2021, 10:34 AM · Restricted Project

Apr 6 2021

alexander-shaposhnikov accepted D99972: [lld-macho] Fix & refactor symbol size calculations.

Thanks!

Apr 6 2021, 10:55 AM · Restricted Project, Restricted Project

Apr 2 2021

alexander-shaposhnikov accepted D99783: [lld-macho][NFC] Remove redundant member from class Defined.

LGTM

Apr 2 2021, 1:13 AM · Restricted Project, Restricted Project

Apr 1 2021

alexander-shaposhnikov committed rGf6ad0453665f: [lld][MachO] Make emitEndFunStab independent from .subsections_via_symbols (authored by alexander-shaposhnikov).
[lld][MachO] Make emitEndFunStab independent from .subsections_via_symbols
Apr 1 2021, 5:48 PM

Mar 31 2021

alexander-shaposhnikov committed rGf1e4e2fb204d: [lld][MachO] Refactor handling of subsections (authored by alexander-shaposhnikov).
[lld][MachO] Refactor handling of subsections
Mar 31 2021, 4:53 PM
alexander-shaposhnikov added inline comments to D99399: [elfabi] Prepare llvm-elfabi for elfabi/ifs merging..
Mar 31 2021, 4:20 PM · Restricted Project

Mar 26 2021

alexander-shaposhnikov accepted D99112: [lld-macho] Support -no_function_starts.
Mar 26 2021, 1:05 PM · Restricted Project, Restricted Project
alexander-shaposhnikov added inline comments to D99356: [lld-macho] Support --thinlto-jobs.
Mar 26 2021, 1:01 PM · Restricted Project, Restricted Project
alexander-shaposhnikov accepted D99313: [lld-macho] Fix parsing of --time-trace-{granularity,file}.
Mar 26 2021, 12:49 PM · Restricted Project, Restricted Project

Mar 10 2021

alexander-shaposhnikov accepted D98395: [lld-macho] Avoid requiring shell in tests.
Mar 10 2021, 11:05 PM · Restricted Project, Restricted Project

Mar 9 2021

alexander-shaposhnikov committed rG98f1564b8857: [lld][MachO] Add missing test requirements (authored by alexander-shaposhnikov).
[lld][MachO] Add missing test requirements
Mar 9 2021, 4:07 AM

Mar 8 2021

alexander-shaposhnikov committed rG9afdd3607a03: [lld][MachO] Add support for LC_FUNCTION_STARTS (authored by alexander-shaposhnikov).
[lld][MachO] Add support for LC_FUNCTION_STARTS
Mar 8 2021, 10:09 PM
alexander-shaposhnikov added a reverting change for rGf344dfebdb12: [lld][MachO] Add support for LC_FUNCTION_STARTS: rG1b0819e325b7: Revert "[lld][MachO] Add support for LC_FUNCTION_STARTS".
Mar 8 2021, 9:11 PM
alexander-shaposhnikov committed rG1b0819e325b7: Revert "[lld][MachO] Add support for LC_FUNCTION_STARTS" (authored by alexander-shaposhnikov).
Revert "[lld][MachO] Add support for LC_FUNCTION_STARTS"
Mar 8 2021, 9:11 PM
alexander-shaposhnikov added a reverting change for rG179d72549ea5: [lld][MachO] Fix function starts test: rG0c7c5af1a770: Revert "[lld][MachO] Fix function starts test".
Mar 8 2021, 9:11 PM
alexander-shaposhnikov committed rG0c7c5af1a770: Revert "[lld][MachO] Fix function starts test" (authored by alexander-shaposhnikov).
Revert "[lld][MachO] Fix function starts test"
Mar 8 2021, 9:11 PM
alexander-shaposhnikov committed rG179d72549ea5: [lld][MachO] Fix function starts test (authored by alexander-shaposhnikov).
[lld][MachO] Fix function starts test
Mar 8 2021, 8:57 PM
alexander-shaposhnikov committed rGf344dfebdb12: [lld][MachO] Add support for LC_FUNCTION_STARTS (authored by alexander-shaposhnikov).
[lld][MachO] Add support for LC_FUNCTION_STARTS
Mar 8 2021, 8:43 PM
alexander-shaposhnikov committed rGf2cb3be0f926: [docs] Fix llvm-objcopy.rst (authored by alexander-shaposhnikov).
[docs] Fix llvm-objcopy.rst
Mar 8 2021, 7:09 PM
alexander-shaposhnikov committed rGede56e5127c9: [llvm-objcopy][MachO] Add support for --keep-undefined (authored by alexander-shaposhnikov).
[llvm-objcopy][MachO] Add support for --keep-undefined
Mar 8 2021, 6:58 PM
alexander-shaposhnikov committed rG5f2f84a68a2e: [llvm-objdump][MachO] Add support for dumping function starts (authored by alexander-shaposhnikov).
[llvm-objdump][MachO] Add support for dumping function starts
Mar 8 2021, 6:45 PM

Mar 4 2021

alexander-shaposhnikov accepted D97663: [llvm-objcopy] Fix crash for binary input files with non-ascii names.
Mar 4 2021, 3:21 PM · Restricted Project

Mar 1 2021

alexander-shaposhnikov accepted D97661: [llvm-objcopy/strip] Fix off-by-one error in SYMTAB_SHNDX need check.
Mar 1 2021, 1:46 AM · Restricted Project
alexander-shaposhnikov accepted D97666: [llvm-objcopy][llvm-strip][test] Improve testing.
Mar 1 2021, 1:45 AM · Restricted Project

Feb 23 2021

alexander-shaposhnikov accepted D97031: [lld-macho] Fix semantics & add tests for ARM64 GOT/TLV relocs.
Feb 23 2021, 11:42 AM · Restricted Project, Restricted Project
alexander-shaposhnikov added inline comments to D97104: [lld-macho] Add test for a variety of arm64 relocations.
Feb 23 2021, 11:39 AM · Restricted Project, Restricted Project
alexander-shaposhnikov accepted D97105: [lld-macho] Extract embedded addends for arm64 UNSIGNED relocations.
Feb 23 2021, 11:35 AM · Restricted Project, Restricted Project
alexander-shaposhnikov accepted D97245: [lld-macho] Better deduplication of personality pointers.
Feb 23 2021, 11:34 AM · Restricted Project, Restricted Project
alexander-shaposhnikov accepted D97209: [lld-macho] Check for arch compatibility when loading ObjFiles and TBDs.
Feb 23 2021, 11:33 AM · Restricted Project, Restricted Project

Feb 16 2021

alexander-shaposhnikov committed rGcdcb60a82057: [llvm-libtool] Emit warnings for files without symbols (authored by alexander-shaposhnikov).
[llvm-libtool] Emit warnings for files without symbols
Feb 16 2021, 5:53 PM
alexander-shaposhnikov closed D95843: [tools][llvm-libtool] Emit warnings for files without symbols.
Feb 16 2021, 5:53 PM · Restricted Project