minor nits inline, otherwise looks good to me.

LG

to me LG

fwiw - I can revert https://reviews.llvm.org/D146178 for now till we fix the newly discovered cases (at the moment I'm aware of GH61959 and the one reported by @ilya-biryukov.
Basically let me know what you think - i'm looking into the issue reported by Ilya, but it will take time.

LG

sure, will do! thanks for the review

Thanks for the fix,
if i understand correctly this is yet another place that uses the legacy pass manager and createPrintModulePass(....) - right ?

LG

LG (with minor nit: for consistency with other tests it'd be good to rename export_trie-lc_dyld_info_only.yaml -> export_trie_lc_dyld_info_only.yaml, export_trie-lc_dyld_exports_trie.yaml -> export_trie_lc_dyld_exports_trie.yaml)

LG

@drodriguez - if it's not too hard i'd probably split this diff into two. 1. changes to ObjectYAML (it would be good to have a test that invokes obj2yaml and yaml2obj) 2. changes to ObjCopy

gentle ping. @drodriguez , @smeenai

LG

Thanks!

see a small nit above, otherwise - looks good to me.
p.s. https://reviews.llvm.org/D119671 seems to be relevant, don't know the current status of that effort though.
It would be good to review/land D134250 or D119671, alternatively i think it's reasonable to add a TODO (that we should add a test once ObjectYAML is ready) and commit this fix now.
cc: @thakis , @keith

+1 to what @smeenai said

LGTM

LG