Page MenuHomePhabricator

kito-cheng (Kito Cheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 20 2016, 2:25 AM (296 w, 6 d)

Recent Activity

Yesterday

kito-cheng added reviewers for D128875: [RISCV] Precommit testcase to show wrong result of make-compressible optimization: craigblackmore, asb, craig.topper, luismarques, lewis-revill.
Wed, Jun 29, 10:20 PM · Restricted Project, Restricted Project
kito-cheng added reviewers for D128876: [RISCV] Fix wrong register rename for store value during make-compressible optimization: craig.topper, asb, lewis-revill, luismarques, craigblackmore.
Wed, Jun 29, 10:20 PM · Restricted Project, Restricted Project
kito-cheng requested review of D128876: [RISCV] Fix wrong register rename for store value during make-compressible optimization.
Wed, Jun 29, 10:18 PM · Restricted Project, Restricted Project
kito-cheng requested review of D128875: [RISCV] Precommit testcase to show wrong result of make-compressible optimization.
Wed, Jun 29, 10:17 PM · Restricted Project, Restricted Project
kito-cheng committed rG1b8cde9b6338: [RISCV][NFC] Move static global variables into static variable in function. (authored by kito-cheng).
[RISCV][NFC] Move static global variables into static variable in function.
Wed, Jun 29, 7:30 PM · Restricted Project, Restricted Project
kito-cheng closed D128726: [RISCV][NFC] Move static global variables into static variable in function..
Wed, Jun 29, 7:30 PM · Restricted Project, Restricted Project
kito-cheng accepted D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths.

LGTM, riscv*-unknown-unknown match riscv*-unknown-elf sound make more sense than riscv*-unknown-linux-gnu :)

Wed, Jun 29, 7:26 PM · Restricted Project, Restricted Project
kito-cheng updated the summary of D128726: [RISCV][NFC] Move static global variables into static variable in function..
Wed, Jun 29, 6:55 AM · Restricted Project, Restricted Project
kito-cheng added a comment to D128726: [RISCV][NFC] Move static global variables into static variable in function..

My understanding is the reason why no global variable is because 1. the initialization order and 2. might increase the launch time of programs, moving that into function scope could resolve both issue: 1. initialized in deterministic order[1], 2. Initialized that when the first time used.

Wed, Jun 29, 6:50 AM · Restricted Project, Restricted Project

Tue, Jun 28

kito-cheng added reviewers for D128726: [RISCV][NFC] Move static global variables into static variable in function.: craig.topper, khchen, HsiangKai.
Tue, Jun 28, 6:15 AM · Restricted Project, Restricted Project
kito-cheng requested review of D128726: [RISCV][NFC] Move static global variables into static variable in function..
Tue, Jun 28, 6:15 AM · Restricted Project, Restricted Project
Herald added a project to D113017: [AMDGPU] Avoid copying dead subregisters in copyPhysReg: Restricted Project.
Tue, Jun 28, 3:25 AM · Restricted Project, Restricted Project
Herald added a project to D113016: [CodeGen] Track physical register liveness in ExpandPostRAPseudos: Restricted Project.
Tue, Jun 28, 3:25 AM · Restricted Project, Restricted Project

Wed, Jun 22

kito-cheng added a comment to D127581: [ELF] Relax R_RISCV_ALIGN.

Tested with this patch with LLVM testsuite and internal testsuite, and no failure :)

Wed, Jun 22, 8:48 PM · Restricted Project, Restricted Project

Tue, Jun 21

kito-cheng added inline comments to D127581: [ELF] Relax R_RISCV_ALIGN.
Tue, Jun 21, 4:40 AM · Restricted Project, Restricted Project

Mon, Jun 20

kito-cheng added inline comments to D128235: [RISCV] Add support for the Zawrs extension.
Mon, Jun 20, 11:45 PM · Restricted Project, Restricted Project, Restricted Project
kito-cheng added inline comments to D128187: [RISCV] Add ADDI instr to compute FrameIndex address for RVV.
Mon, Jun 20, 5:42 AM · Restricted Project, Restricted Project

Sun, Jun 19

kito-cheng accepted D128016: Recommit "[RISCV] Enable subregister liveness tracking for RVV.".

LGTM, happy to see this change restored to improve code gen!

Sun, Jun 19, 8:07 PM · Restricted Project, Restricted Project

Thu, Jun 16

kito-cheng accepted D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}.

ld's help message just confused me, that say -X is default, but actually default action is Discard local temporary symbols in SEC_MERGE sections. which is no option can enable that but default.

$ ld.bfd --help
...
  -x, --discard-all           Discard all local symbols
  -X, --discard-locals        Discard temporary local symbols (default)
  --discard-none              Don't discard any local symbols
...
Thu, Jun 16, 9:12 PM · Restricted Project, Restricted Project
kito-cheng added a reverting change for rG7207373e1eb0: Revert "[SplitKit] Handle early clobber + tied to def correctly": rGe9f7263b381e: Reland "[SplitKit] Handle early clobber + tied to def correctly".
Thu, Jun 16, 2:14 AM · Restricted Project, Restricted Project
kito-cheng committed rGe9f7263b381e: Reland "[SplitKit] Handle early clobber + tied to def correctly" (authored by kito-cheng).
Reland "[SplitKit] Handle early clobber + tied to def correctly"
Thu, Jun 16, 2:13 AM · Restricted Project, Restricted Project
kito-cheng added a reverting change for rG6a6f632b93cd: Revert "[RISCV] Testcase to show wrong register allocation result of subreg…: rG8e16c4db571a: Reland "[RISCV] Testcase to show wrong register allocation result of subreg….
Thu, Jun 16, 2:13 AM · Restricted Project, Restricted Project
kito-cheng committed rG8e16c4db571a: Reland "[RISCV] Testcase to show wrong register allocation result of subreg… (authored by kito-cheng).
Reland "[RISCV] Testcase to show wrong register allocation result of subreg…
Thu, Jun 16, 2:13 AM · Restricted Project, Restricted Project

Wed, Jun 15

kito-cheng committed rG687e56614fa0: [RISCV] Fixing undefined physical register issue when subreg liveness tracking… (authored by kito-cheng).
[RISCV] Fixing undefined physical register issue when subreg liveness tracking…
Wed, Jun 15, 1:24 AM · Restricted Project, Restricted Project
kito-cheng closed D127642: [RISCV] Fixing undefined physical register issue when subreg liveness tracking enabled..
Wed, Jun 15, 1:23 AM · Restricted Project, Restricted Project

Tue, Jun 14

kito-cheng added inline comments to D127642: [RISCV] Fixing undefined physical register issue when subreg liveness tracking enabled..
Tue, Jun 14, 10:09 AM · Restricted Project, Restricted Project
kito-cheng updated the diff for D127642: [RISCV] Fixing undefined physical register issue when subreg liveness tracking enabled..
  • Remove unnecessary flags in the testcase.
Tue, Jun 14, 10:07 AM · Restricted Project, Restricted Project
kito-cheng added a comment to D127642: [RISCV] Fixing undefined physical register issue when subreg liveness tracking enabled..

@frasercrmck thanks your suggestion! that made testcase easier to understand what happened, my habit is generating a reduced C testcase and then use that to generating ll or mir test, I guess that habit is come from my GCC development experiences, I guess I should having some new habit about that for LLVM development :P

Tue, Jun 14, 8:24 AM · Restricted Project, Restricted Project
kito-cheng updated the diff for D127642: [RISCV] Fixing undefined physical register issue when subreg liveness tracking enabled..
  • Refine testcase.
Tue, Jun 14, 8:17 AM · Restricted Project, Restricted Project

Mon, Jun 13

kito-cheng updated the diff for D127642: [RISCV] Fixing undefined physical register issue when subreg liveness tracking enabled..
  • Address @craig.topper's commet:
    • Use addReg rather than add(MachineOperand::CreateReg(...)).
    • Tweak comment in the code.
    • Move test case to rvv directory.
Mon, Jun 13, 11:59 PM · Restricted Project, Restricted Project
kito-cheng added a comment to D126048: [SplitKit] Handle early clobber + tied to def correctly.

D127642 will resolved the LLVM_ENABLE_EXPENSIVE_CHECKS=On issue, will reland this patch after that land.

Mon, Jun 13, 7:48 AM · Restricted Project, Restricted Project
kito-cheng added reviewers for D127642: [RISCV] Fixing undefined physical register issue when subreg liveness tracking enabled.: craig.topper, rogfer01, frasercrmck, reames.
Mon, Jun 13, 7:47 AM · Restricted Project, Restricted Project
kito-cheng requested review of D127642: [RISCV] Fixing undefined physical register issue when subreg liveness tracking enabled..
Mon, Jun 13, 7:45 AM · Restricted Project, Restricted Project
kito-cheng added a comment to D126861: [RISCV] Fix missing stack pointer recover.

@efriedma Thanks, that's good catch, created another issue to tracking that[1]!

Mon, Jun 13, 1:27 AM · Restricted Project, Restricted Project

Thu, Jun 9

kito-cheng added a comment to D126861: [RISCV] Fix missing stack pointer recover.

Fixed via this commit, my bad, I didn't upload those testcase update...

Thu, Jun 9, 9:20 AM · Restricted Project, Restricted Project
kito-cheng committed rGcfa463fdc695: [RISCV][NFC] Update testcase for D126861 (authored by kito-cheng).
[RISCV][NFC] Update testcase for D126861
Thu, Jun 9, 9:18 AM · Restricted Project, Restricted Project
kito-cheng committed rG4b11f909030a: [RISCV] Fix missing stack pointer recover (authored by kito-cheng).
[RISCV] Fix missing stack pointer recover
Thu, Jun 9, 8:39 AM · Restricted Project, Restricted Project
kito-cheng closed D126861: [RISCV] Fix missing stack pointer recover.
Thu, Jun 9, 8:38 AM · Restricted Project, Restricted Project
kito-cheng committed rG8b3426569e1f: [RISCV] Pre-commit testcase for PR55442 (authored by kito-cheng).
[RISCV] Pre-commit testcase for PR55442
Thu, Jun 9, 8:36 AM · Restricted Project, Restricted Project
kito-cheng closed D126860: [RISCV] Pre-commit testcase for PR55442.
Thu, Jun 9, 8:35 AM · Restricted Project, Restricted Project

Wed, Jun 8

kito-cheng added inline comments to D126861: [RISCV] Fix missing stack pointer recover.
Wed, Jun 8, 11:29 PM · Restricted Project, Restricted Project
kito-cheng committed rG6a6f632b93cd: Revert "[RISCV] Testcase to show wrong register allocation result of subreg… (authored by kito-cheng).
Revert "[RISCV] Testcase to show wrong register allocation result of subreg…
Wed, Jun 8, 6:20 AM · Restricted Project, Restricted Project
kito-cheng added a reverting change for rGcbe22c794348: [RISCV] Testcase to show wrong register allocation result of subreg liveness: rG6a6f632b93cd: Revert "[RISCV] Testcase to show wrong register allocation result of subreg….
Wed, Jun 8, 6:20 AM · Restricted Project, Restricted Project
kito-cheng added a reverting change for D126047: [RISCV] Testcase to show wrong register allocation result of subreg liveness: rG6a6f632b93cd: Revert "[RISCV] Testcase to show wrong register allocation result of subreg….
Wed, Jun 8, 6:20 AM · Restricted Project, Restricted Project
kito-cheng added a comment to D126921: [RISCV] Untangle instruction properties from VSETVLIInfo [NFC].

I think the real problem is we didn't extra the abstract data from MI, so what do you think if we turn those info into more abstraction level info and still keep in Require?

Wed, Jun 8, 2:35 AM · Restricted Project, Restricted Project

Tue, Jun 7

kito-cheng added a comment to D126048: [SplitKit] Handle early clobber + tied to def correctly.

Revert due to failed on LLVM_ENABLE_EXPENSIVE_CHECKS=On.

Tue, Jun 7, 11:46 PM · Restricted Project, Restricted Project
kito-cheng added a reverting change for rGe14d04909df4: [SplitKit] Handle early clobber + tied to def correctly: rG7207373e1eb0: Revert "[SplitKit] Handle early clobber + tied to def correctly".
Tue, Jun 7, 10:06 PM · Restricted Project, Restricted Project
kito-cheng committed rG7207373e1eb0: Revert "[SplitKit] Handle early clobber + tied to def correctly" (authored by kito-cheng).
Revert "[SplitKit] Handle early clobber + tied to def correctly"
Tue, Jun 7, 10:06 PM · Restricted Project, Restricted Project
kito-cheng added a reverting change for D126048: [SplitKit] Handle early clobber + tied to def correctly: rG7207373e1eb0: Revert "[SplitKit] Handle early clobber + tied to def correctly".
Tue, Jun 7, 10:06 PM · Restricted Project, Restricted Project
kito-cheng committed rGe14d04909df4: [SplitKit] Handle early clobber + tied to def correctly (authored by kito-cheng).
[SplitKit] Handle early clobber + tied to def correctly
Tue, Jun 7, 8:33 PM · Restricted Project, Restricted Project
kito-cheng closed D126048: [SplitKit] Handle early clobber + tied to def correctly.
Tue, Jun 7, 8:33 PM · Restricted Project, Restricted Project
kito-cheng committed rGcbe22c794348: [RISCV] Testcase to show wrong register allocation result of subreg liveness (authored by kito-cheng).
[RISCV] Testcase to show wrong register allocation result of subreg liveness
Tue, Jun 7, 8:27 PM · Restricted Project, Restricted Project
kito-cheng closed D126047: [RISCV] Testcase to show wrong register allocation result of subreg liveness.
Tue, Jun 7, 8:27 PM · Restricted Project, Restricted Project

Mon, Jun 6

kito-cheng added a comment to D126048: [SplitKit] Handle early clobber + tied to def correctly.

ping

Mon, Jun 6, 6:18 PM · Restricted Project, Restricted Project
kito-cheng added a comment to D126861: [RISCV] Fix missing stack pointer recover.

Kito, I don't get your comment. I'd expect the CSR restores to be happening before stack adjustment.

Mon, Jun 6, 8:13 AM · Restricted Project, Restricted Project
kito-cheng added a comment to D126861: [RISCV] Fix missing stack pointer recover.

I'm missing something here.

If we have a frame pointer, shouldn't restoring SP simply be a register move? Why bother with all of the offset adjustments in this case at all? Shouldn't we be able to structure the code as:
if (hasFP) {

copy SP to FP

} else {

do it the hard way

}

Mon, Jun 6, 6:00 AM · Restricted Project, Restricted Project
kito-cheng added a comment to D126854: [RISCV] Define risc-v's own register class to model FP Register..

Sorry I didn't notice. I have submitted it.

Mon, Jun 6, 12:14 AM · Restricted Project, Restricted Project

Sun, Jun 5

kito-cheng accepted D126854: [RISCV] Define risc-v's own register class to model FP Register..

LGTM

Sun, Jun 5, 10:50 PM · Restricted Project, Restricted Project
kito-cheng added inline comments to D126854: [RISCV] Define risc-v's own register class to model FP Register..
Sun, Jun 5, 7:43 PM · Restricted Project, Restricted Project

Thu, Jun 2

kito-cheng added inline comments to D126854: [RISCV] Define risc-v's own register class to model FP Register..
Thu, Jun 2, 2:37 AM · Restricted Project, Restricted Project
kito-cheng added reviewers for D126860: [RISCV] Pre-commit testcase for PR55442: asb, luismarques, craig.topper, reames, frasercrmck, rogfer01, HsiangKai.
Thu, Jun 2, 2:16 AM · Restricted Project, Restricted Project
kito-cheng added reviewers for D126861: [RISCV] Fix missing stack pointer recover: asb, luismarques, craig.topper, reames, frasercrmck, rogfer01, HsiangKai.
Thu, Jun 2, 2:15 AM · Restricted Project, Restricted Project
kito-cheng requested review of D126861: [RISCV] Fix missing stack pointer recover.
Thu, Jun 2, 2:12 AM · Restricted Project, Restricted Project
kito-cheng requested review of D126860: [RISCV] Pre-commit testcase for PR55442.
Thu, Jun 2, 2:04 AM · Restricted Project, Restricted Project
kito-cheng added inline comments to D126854: [RISCV] Define risc-v's own register class to model FP Register..
Thu, Jun 2, 1:05 AM · Restricted Project, Restricted Project
kito-cheng added inline comments to D126854: [RISCV] Define risc-v's own register class to model FP Register..
Thu, Jun 2, 12:35 AM · Restricted Project, Restricted Project

Wed, Jun 1

kito-cheng added inline comments to D126048: [SplitKit] Handle early clobber + tied to def correctly.
Wed, Jun 1, 3:04 AM · Restricted Project, Restricted Project
kito-cheng updated the diff for D126048: [SplitKit] Handle early clobber + tied to def correctly.
Wed, Jun 1, 3:04 AM · Restricted Project, Restricted Project

Tue, May 31

kito-cheng added inline comments to D126048: [SplitKit] Handle early clobber + tied to def correctly.
Tue, May 31, 5:47 AM · Restricted Project, Restricted Project

May 27 2022

kito-cheng added inline comments to D126048: [SplitKit] Handle early clobber + tied to def correctly.
May 27 2022, 2:18 AM · Restricted Project, Restricted Project
kito-cheng updated the diff for D126048: [SplitKit] Handle early clobber + tied to def correctly.
  • Address @MatzeB's commnet
  • Rebase and fix a regression.
May 27 2022, 2:13 AM · Restricted Project, Restricted Project

May 26 2022

kito-cheng committed rGe45087fd53d5: [RISCV] Fix state persistence bugs (PR55548) (authored by kito-cheng).
[RISCV] Fix state persistence bugs (PR55548)
May 26 2022, 1:09 AM · Restricted Project, Restricted Project
kito-cheng closed D125905: [RISCV] Fix state persistence bugs (PR55548).
May 26 2022, 1:09 AM · Restricted Project, Restricted Project
kito-cheng added inline comments to D125905: [RISCV] Fix state persistence bugs (PR55548).
May 26 2022, 1:01 AM · Restricted Project, Restricted Project

May 24 2022

kito-cheng accepted D126278: [RISCV] Replace untested code with assert.

Green light on testing :)

May 24 2022, 6:36 PM · Restricted Project, Restricted Project
kito-cheng added a comment to D126278: [RISCV] Replace untested code with assert.

Pushed to our internal testing system to see what happen, will back to you once I got result :)

May 24 2022, 9:12 AM · Restricted Project, Restricted Project
kito-cheng added inline comments to D111617: [RISCV] Lazily add RVV C intrinsics..
May 24 2022, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
kito-cheng updated the diff for D111617: [RISCV] Lazily add RVV C intrinsics..
  • Split out several NFC changes to individual NFC patchs.
  • Moving most code emission logic into RISCVVIntrinsicUtils to prevent require sync manually.
  • PCH support is WIP, will update soon.
May 24 2022, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
kito-cheng committed rGb166aa833e44: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr (authored by kito-cheng).
[RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr
May 24 2022, 2:24 AM · Restricted Project, Restricted Project
kito-cheng closed D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr.
May 24 2022, 2:24 AM · Restricted Project, Restricted Project

May 20 2022

kito-cheng updated the diff for D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr.
May 20 2022, 1:53 AM · Restricted Project, Restricted Project
kito-cheng updated the summary of D126048: [SplitKit] Handle early clobber + tied to def correctly.
May 20 2022, 1:19 AM · Restricted Project, Restricted Project
kito-cheng requested review of D126048: [SplitKit] Handle early clobber + tied to def correctly.
May 20 2022, 1:15 AM · Restricted Project, Restricted Project
kito-cheng added reviewers for D126047: [RISCV] Testcase to show wrong register allocation result of subreg liveness: craig.topper, rogfer01, frasercrmck, reames.
May 20 2022, 12:52 AM · Restricted Project, Restricted Project
kito-cheng requested review of D126047: [RISCV] Testcase to show wrong register allocation result of subreg liveness.
May 20 2022, 12:47 AM · Restricted Project, Restricted Project

May 19 2022

kito-cheng updated the diff for D125905: [RISCV] Fix state persistence bugs (PR55548).
  • Refine testcase.
May 19 2022, 9:08 PM · Restricted Project, Restricted Project
kito-cheng updated the diff for D125905: [RISCV] Fix state persistence bugs (PR55548).
May 19 2022, 7:48 PM · Restricted Project, Restricted Project

May 18 2022

kito-cheng added reviewers for D125905: [RISCV] Fix state persistence bugs (PR55548): asb, craig.topper, luismarques.
May 18 2022, 9:53 AM · Restricted Project, Restricted Project
kito-cheng requested review of D125905: [RISCV] Fix state persistence bugs (PR55548).
May 18 2022, 9:52 AM · Restricted Project, Restricted Project
kito-cheng added inline comments to D125787: [RISCV] Fix RVV stack frame alignment bugs.
May 18 2022, 9:15 AM · Restricted Project, Restricted Project
kito-cheng updated the diff for D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr.
  • clang-format has applied on unexpected part, remove that.
May 18 2022, 8:30 AM · Restricted Project, Restricted Project
kito-cheng updated the diff for D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr.
  • Fix dumb typo...
May 18 2022, 8:25 AM · Restricted Project, Restricted Project
kito-cheng requested review of D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr.
May 18 2022, 8:21 AM · Restricted Project, Restricted Project
kito-cheng committed rG1467e01f8f69: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp (authored by kito-cheng).
[RISCV][NFC] Rename variable in RISCVVEmitter.cpp
May 18 2022, 8:14 AM · Restricted Project, Restricted Project
kito-cheng closed D125886: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp.
May 18 2022, 8:14 AM · Restricted Project, Restricted Project
kito-cheng updated the summary of D125886: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp.
May 18 2022, 6:45 AM · Restricted Project, Restricted Project
kito-cheng updated the summary of D125886: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp.
May 18 2022, 6:43 AM · Restricted Project, Restricted Project
kito-cheng requested review of D125886: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp.
May 18 2022, 6:42 AM · Restricted Project, Restricted Project

May 16 2022

kito-cheng committed rG5bc469fd9619: [RISCV][NFC] Fix build issue (authored by kito-cheng).
[RISCV][NFC] Fix build issue
May 16 2022, 1:01 AM · Restricted Project, Restricted Project
kito-cheng committed rG7ff0bf576b84: [RISCV][NFC] Refactor RISC-V vector intrinsic utils. (authored by kito-cheng).
[RISCV][NFC] Refactor RISC-V vector intrinsic utils.
May 16 2022, 12:13 AM · Restricted Project, Restricted Project