Page MenuHomePhabricator

echristo (Eric Christopher)
User

Projects

User Details

User Since
Oct 15 2012, 2:12 PM (335 w, 3 d)

Recent Activity

Today

echristo added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Oh, and as far as dwarf aware linking I'd arguably prefer a separate tool ala dsymutil or dwz rather than incorporating it into the linker. I do agree that such a tool is incredibly useful and should be part of our ongoing development plan around debug info.

Thu, Mar 21, 2:20 PM · lld, Restricted Project
echristo added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@jhenderson and I did a prototype of DWARF-unit-per-function last year, and I was not favorably impressed by the numbers. But maybe he still has the actual data kicking around somewhere. We did not solve all the issues to our satisfaction before we ran out of time.
I've also had chats with @bd1976llvm about fragmenting .debug_info per-function without wrapping everything in units; you get into requiring some section-order things but it saves the unit-per-function overhead.

Thu, Mar 21, 2:17 PM · lld, Restricted Project

Yesterday

echristo accepted D59623: [PPC] Refactor PPCBranchSelector.cpp.

LGTM.

Wed, Mar 20, 6:06 PM · Restricted Project
echristo added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

& happy to be wrong here too - if we end up prototyping a "function units" equivalent of type units & seeing what the size overhead is, etc. (it'd be less problematic than type units at least - since there's no need for much/any DWARF to reference a function definition from elsewhere in the DWARF (unlike a type and its members, which all need to be referenced from elsewhere))

Wed, Mar 20, 2:24 PM · lld, Restricted Project
echristo edited reviewers for D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used, added: echristo; removed: espindola.

Per my reply to Paul I don't think this is the right way of approaching this (and neither is the linker parsing the dwarf :)

Wed, Mar 20, 12:58 PM · lld, Restricted Project
echristo added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Does this do the right thing for a 32-bit target? 64-bit is common, but not universal.

Re. the underlying DWARF issues:
I can't remember whether the DWARF committee has ever considered specifying a special value for "address does not exist" but I doubt it, because the DWARF spec states "If an entity has no associated machine code, none of these [address-related] attributes are specified." (DWARF v5 section 2.17, p.51.) So, the current position of the DWARF spec is that the linker is supposed to rewrite the DWARF, I guess.

I can imagine a couple of ways to fix this in the DWARF spec, so that linkers can be allowed to strip entities without rewriting the DWARF, but you won't get that fix until DWARF v6 which has to be years in the future. In the meantime using "-2" is probably the simplest hack.

Wed, Mar 20, 12:58 PM · lld, Restricted Project

Tue, Mar 19

echristo accepted D57940: Refactor RelocVisitor and fix computation of SHT_RELA-typed relocation entries.

This is fine with me, Rui?

Tue, Mar 19, 10:32 AM · Restricted Project

Mon, Mar 18

echristo edited reviewers for D59515: Prevent duplicate files in debug line header in dwarf 5., added: dblaikie, probinson, aprantl; removed: espindola.
Mon, Mar 18, 4:10 PM · debug-info, Restricted Project
echristo added inline comments to D57940: Refactor RelocVisitor and fix computation of SHT_RELA-typed relocation entries.
Mon, Mar 18, 2:52 PM · Restricted Project
echristo accepted D57939: Refactor RelocVisitor and fix computation of SHT_RELA-typed relocation entries.

The duplication is a little sad, but I don't have a lot of ideas on how to remove that in the near term so LGTM. Dave, any other concerns on your end?

Mon, Mar 18, 2:50 PM · Restricted Project

Thu, Mar 14

echristo added inline comments to D57940: Refactor RelocVisitor and fix computation of SHT_RELA-typed relocation entries.
Thu, Mar 14, 1:09 AM · Restricted Project
echristo added inline comments to D57939: Refactor RelocVisitor and fix computation of SHT_RELA-typed relocation entries.
Thu, Mar 14, 1:09 AM · Restricted Project

Tue, Mar 5

echristo accepted D58949: [NFC] Declare the member data of class PostGenericScheduler as "protected" instead of "private".

I'd probably prefer something around giving targets an interface rather than this... but that's a lot more work :)

Tue, Mar 5, 10:29 AM · Restricted Project

Wed, Feb 27

echristo committed rG07944353fcac: Temporarily revert "ArgumentPromotion should copy all metadata to new Function"… (authored by echristo).
Temporarily revert "ArgumentPromotion should copy all metadata to new Function"…
Wed, Feb 27, 5:12 PM
echristo committed rL355060: Temporarily revert "ArgumentPromotion should copy all metadata to new Function"….
Temporarily revert "ArgumentPromotion should copy all metadata to new Function"…
Wed, Feb 27, 5:12 PM

Tue, Feb 26

echristo added inline comments to D53927: [AArch64] Enable libm vectorized functions via SLEEF.
Tue, Feb 26, 3:40 PM · Restricted Project
echristo committed rG721eaeff3a24: Fix a small comment typo. (authored by echristo).
Fix a small comment typo.
Tue, Feb 26, 12:33 PM
echristo committed rL354923: Fix a small comment typo..
Fix a small comment typo.
Tue, Feb 26, 12:32 PM

Mon, Feb 25

echristo added a comment to D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD.

Hi ruiu, very thank you for considering accepting the 2-PLT ABI design in X86 arch, Yes, we really have no real measurable evidence for the benefit of this design, and I also think there must be other problems for the CET here, but it is just the beginning. We will work on improving and refining it.
Your questions and suggestions during the discussion were all very much to the point.
I'll first to implement your first 2 review suggestions above.
Thank you again!

Mon, Feb 25, 11:54 PM · Restricted Project, lld

Wed, Feb 20

echristo added a comment to D58296: [llvm-objcopy] Make removeSectionReferences batched.

One more comment:

Wed, Feb 20, 3:49 PM · Restricted Project
echristo added a comment to D58296: [llvm-objcopy] Make removeSectionReferences batched.

Awesome patch.

Wed, Feb 20, 3:48 PM · Restricted Project

Tue, Feb 19

echristo committed rG2534592b9fe4: Temporarily Revert "[X86][SLP] Enable SLP vectorization for 128-bit horizontal… (authored by echristo).
Temporarily Revert "[X86][SLP] Enable SLP vectorization for 128-bit horizontal…
Tue, Feb 19, 8:42 PM
echristo committed rL354434: Temporarily Revert "[X86][SLP] Enable SLP vectorization for 128-bit horizontal….
Temporarily Revert "[X86][SLP] Enable SLP vectorization for 128-bit horizontal…
Tue, Feb 19, 8:41 PM

Feb 19 2019

echristo accepted D58390: [X86] Don't consider functions ABI compatible for ArgumentPromotion pass if they would legalize 512-bit vectors differently..
Feb 19 2019, 11:39 AM · Restricted Project
echristo added inline comments to D58390: [X86] Don't consider functions ABI compatible for ArgumentPromotion pass if they would legalize 512-bit vectors differently..
Feb 19 2019, 10:05 AM · Restricted Project
echristo added inline comments to D58390: [X86] Don't consider functions ABI compatible for ArgumentPromotion pass if they would legalize 512-bit vectors differently..
Feb 19 2019, 9:52 AM · Restricted Project

Feb 18 2019

echristo accepted D58371: [X86] Filter out tuning feature flags and a few ISA feature flags when checking for function inline compatibility..

LGTM.

Feb 18 2019, 10:54 PM · Restricted Project

Feb 6 2019

echristo committed rG40b1c0746231: Fix a minor grammar thinko. (authored by echristo).
Fix a minor grammar thinko.
Feb 6 2019, 5:22 PM
echristo committed rL353359: Fix a minor grammar thinko..
Fix a minor grammar thinko.
Feb 6 2019, 5:21 PM

Jan 31 2019

echristo added a member for debug-info: echristo.
Jan 31 2019, 3:07 PM

Jan 29 2019

echristo added a comment to D53379: GSYM symbolication format.

Hi Greg,

Jan 29 2019, 6:25 PM

Jan 22 2019

echristo accepted D45784: [DEBUG_INFO, NVPTX] Fix relocation info..

The way this works is feeling pretty awkward, but I think updating that will be small in contrast to getting debug working for nvptx.

Jan 22 2019, 8:52 AM

Jan 14 2019

echristo accepted D56556: [opaque pointer types] Update CallInst creation APIs to consistently accept a callee-type argument..

If whitequark is happy I am :)

Jan 14 2019, 10:56 AM

Jan 2 2019

echristo added a comment to D54674: [llvm-objcopy] First bits for MachO .

@lhames , can we proceed here ?

Jan 2 2019, 11:02 AM · Restricted Project

Jan 1 2019

echristo accepted D56181: [CMake][Fuchsia] Include check-lld in the list of bootstrap targets.

This seems like the sort of thing that you can just commit in the future.

Jan 1 2019, 9:13 PM

Dec 31 2018

echristo accepted D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

That's fine, it's just not the state of the world and we should support compiling appropriately.

I don't want to pick a fight, but there can be used exactly same argument to defend pulling libgcc here.

Dec 31 2018, 7:08 PM · Restricted Project, Restricted Project
echristo accepted D56043: [Driver] Don't pass default value to getCompilerRTArgString.

LGTM, thanks.

Dec 31 2018, 5:33 PM
echristo accepted D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt.

OK, that makes sense. I'm not a huge fan of how this set of code looks, but it also seems unfair to require you to extensively refactor it for this.

Dec 31 2018, 5:27 PM · Restricted Project, Restricted Project
echristo added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

Is there intention to support Clang/LLVM by GLIBC/GNU developers? Unlikely (knowing FSF track of reactions against LLVM projects). There are no gcc/libgcc licensing concerns for software hosted on GLIBC (LGPLv3) with libgcc. There already does exist a functional implementation for this OS. There is no need to treat it as an issue on the Clang/LLVM side (maybe except ambitions).

Dec 31 2018, 5:24 PM · Restricted Project, Restricted Project
echristo added a comment to D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt.

Is something passing compiler-rt in as a -r link output or something?

Dec 31 2018, 12:08 AM · Restricted Project, Restricted Project

Dec 30 2018

echristo accepted D56123: [llvm-objdump] - Print symbol addressed when dumping disassembly output (-d).

Sure.

Dec 30 2018, 10:59 PM

Dec 21 2018

echristo accepted D55968: Add a doc for missing key function and an error message referencing the doc..

LGTM.

Dec 21 2018, 11:25 AM
echristo added inline comments to D55968: Add a doc for missing key function and an error message referencing the doc..
Dec 21 2018, 11:16 AM

Dec 18 2018

echristo accepted D55755: [DebugInfo] Move several private headers to include directory.

Thanks for the split! LGTM.

Dec 18 2018, 2:35 PM · debug-info
echristo accepted D55756: [DebugInfo] Make AsmPrinter struct HandlerInfo and Handlers protected.

Thanks for the split. LGTM!

Dec 18 2018, 2:35 PM · debug-info
echristo accepted D55752: [BPF] Add BTF DebugInfo under BPF target.

Thanks so much for the split!

Dec 18 2018, 2:35 PM · debug-info
echristo added a comment to D54911: [compiler-rt][builtins][PowerPC] Add ___fixunstfti builtin compiler-rt method support for PowerPC .

FWIW once nemanja and Masoud are happy then this can go in.

Dec 18 2018, 10:37 AM

Dec 13 2018

echristo added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

Looks like this stalled with no feedback outside of Chandler and I.

Dec 13 2018, 5:27 PM · Restricted Project, Restricted Project

Dec 11 2018

echristo accepted D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support..

LGTM. I'm quite a bit happier with this now. Thanks for going through the back and forth.

Dec 11 2018, 11:19 PM
echristo accepted D55580: [NVPTX] do not rely on cached subtarget info..

LGTM. Thanks!

Dec 11 2018, 3:37 PM

Dec 5 2018

echristo added inline comments to D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support..
Dec 5 2018, 10:39 PM
echristo accepted D46061: [DEBUGINFO, NVPTX] Disable emission of ',debug' option if only debug directives are allowed..
Dec 5 2018, 10:36 PM
echristo accepted D54320: [DEBUGINFO, NVPTX]Emit last debugging directives..

LGTM.

Dec 5 2018, 10:30 PM
echristo added a comment to D46189: [DEBUGINFO, NVPTX] Enable support for the debug info on NVPTX target..

LGTM still when everything else is approved.

Dec 5 2018, 10:30 PM

Dec 4 2018

echristo added a comment to D54747: Discard debuginfo for object files empty after GC.

But 2GB is perhaps still too big and I guess a large part of it can be for dead sections. If we fix this, I'd like to fix it in a proper way so that we can completely eliminate debug info for dead sections.

Dec 4 2018, 4:18 PM · Restricted Project, lld

Dec 3 2018

echristo accepted D55016: Correctly support -shared-libgcc..

LGTM.

Dec 3 2018, 2:08 PM

Nov 28 2018

echristo added a comment to D54747: Discard debuginfo for object files empty after GC.

Thank you for the patch.

What you are doing in this patch is not too complicated and makes sense to me. That said, if actual size saving is not significant as you said in https://github.com/rust-lang/rust/issues/56068#issuecomment-440160568, it may not be worth doing. It seems to me that if debug info is already 2.4GB, shrinking it to 2GB doesn't make much difference. Do you have more convincing examples?

Nov 28 2018, 10:38 PM · Restricted Project, lld

Nov 26 2018

echristo accepted D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.

LGTM.

Nov 26 2018, 3:20 PM

Nov 13 2018

echristo accepted D54378: Add Hurd triplet to LLVMSupport.

I can sign off on this.

Nov 13 2018, 4:50 PM
echristo accepted D53554: [Argument Promotion] Only promote args when function attributes are compatible.

This looks better to me. I've got an inline request for some elaboration and you might want to let chandlerc comment, but otherwise OK with me.

Nov 13 2018, 4:24 PM
echristo added inline comments to D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent.
Nov 13 2018, 4:22 PM
echristo added a comment to D54492: Notify the linker when a TU compiled with split-stack has a functionwithout a prologue.There is more context here:https://go-review.googlesource.com/c/go/+/148819/.

Test?

Nov 13 2018, 2:38 PM
echristo added a comment to D53379: GSYM symbolication format.

Unfortunately there's nothing else I can do on this since I don't feel enough ownership over the top level lib/DebugInfo folder to approve a new sub-folder. If you still can't get any traction from someone who does have that kind of ownership, one idea might be to make a post on llvm-dev@ pointing them to this review.

Nov 13 2018, 11:45 AM

Nov 12 2018

echristo added inline comments to D53554: [Argument Promotion] Only promote args when function attributes are compatible.
Nov 12 2018, 2:30 PM

Nov 9 2018

echristo added a comment to D54369: [llvm-size][libobject] Add explicit "inTextSegment" methods similar to "isText" section methods to calculate size correctly..

I think this is the right direction, couple comment:

Nov 9 2018, 6:11 PM
echristo added a comment to D54124: [llvm-readelf] Make llvm-readelf more compatible with GNU readelf..

Okay, from my point of view, LGTM (with a nit). However, we should probably get some more buy-in on the RFC before breaking people's builds etc, so you might want to hold off on the commit for now.

Any thoughts on how to drum up some more interest?

I'll ping the thread you started, and I'd like to commit on Monday if there are no objections. I'm hoping this change is not so controversial.

Nov 9 2018, 6:02 PM

Nov 8 2018

echristo added a comment to D45784: [DEBUG_INFO, NVPTX] Fix relocation info..

Rather than testing for isNVPTX in AsmPrinter.cpp I'd rather just make a function "emitPreFunctionDebugInfo" and have it do nothing unless it's NVPTX and then define this in the nvptx backend. Easier to update if nvidia ever fixes this weirdness too.

Seems to me you were looking to the very first patch. The last one looks exactly like you want. Switch to the latest revision.

Nov 8 2018, 9:00 PM
echristo accepted D46189: [DEBUGINFO, NVPTX] Enable support for the debug info on NVPTX target..

Once we get everything else handled this is fine :)

Nov 8 2018, 8:44 PM
echristo added a comment to D53990: [MC] Support labels as offsets in .reloc directive.

It'd be really great if we could handle all of this in the mips backend rather than in general code.

Nov 8 2018, 7:15 PM
echristo added inline comments to D53554: [Argument Promotion] Only promote args when function attributes are compatible.
Nov 8 2018, 7:12 PM
echristo added a comment to D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support..

The llvm backend patch here has discussion around debug info kinds that we should iron out first.

Nov 8 2018, 6:46 PM
echristo added a comment to D46061: [DEBUGINFO, NVPTX] Disable emission of ',debug' option if only debug directives are allowed..

Some inline comments - I'm still not happy with some of how this patch is and would like to see some changes and elaborations of how we split things out. Mostly it's bikeshed naming things, but the current state is a bit more confusing than without.

Nov 8 2018, 6:41 PM
echristo added a comment to D53051: [llvm-tapi] initial commit, supports ELF text stubs.

Some drive by comments again. Be good to get @ributzka to take a final look.

Nov 8 2018, 6:33 PM
echristo added a comment to D54243: DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use..

I have no other bikeshed colors here. :)

Nov 8 2018, 4:46 PM
echristo accepted D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers.

Naming sounds ok to me :)

Nov 8 2018, 4:45 PM

Nov 6 2018

echristo committed rLLDB346294: Add a break to avoid an unannotated fall-through..
Add a break to avoid an unannotated fall-through.
Nov 6 2018, 9:21 PM
echristo committed rL346294: Add a break to avoid an unannotated fall-through..
Add a break to avoid an unannotated fall-through.
Nov 6 2018, 9:20 PM

Nov 5 2018

echristo added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Nice :)
So seems the last unresolved question left is the naming of the new option?
If we do not want to go with -gsingle-file-split-dwarf then what it should be?

What about -fdebug-fission as an alias for -gsplit-dwarf.
And -fsingle-file-debug-fission for the new option?

Or, may be:

-fdebug-fission for the new option and then
-fdebug-fission -fdebug-split-dwo would work together as -gsplit-dwarf?

Only DWARF supports this, correct?

I am not aware of any kind of debug information splitting except DWARF splitting.

So I would suggest: -fdwarf-fission[={split,single}] where the parameter defaults to split. Is there any particular value in having two separate options?

Probably not. -fdwarf-fission[={split,single}] sounds good for me.

Nov 5 2018, 9:45 AM
echristo added a comment to D53919: [X86] Don't allow illegal vector types to return by direct value on x86-64..

With both 3.3 and trunk (I don't have a 7.0 handy; I can build it if it would be helpful):

Please try clang 2.6 on both testcases.

Nov 5 2018, 9:41 AM
echristo added a comment to D53379: GSYM symbolication format.

README.md has complete file details now for anyone wanting to understand the entire file format.

Nov 5 2018, 9:34 AM

Oct 30 2018

echristo added a comment to D53051: [llvm-tapi] initial commit, supports ELF text stubs.

Random drive-by bikeshed:

Oct 30 2018, 6:18 PM
echristo added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

Hi Joerg,

Oct 30 2018, 6:15 PM · Restricted Project, Restricted Project
echristo added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Do we generate the .dwo file directly these days? If not, I can imagine wanting to avoid the overhead of the objcopy hack; as long as the linker is smart enough not to bother with the .debug_*.dwo sections this seems like a build-time win.

We do generate them generically with no objcopy hack.

Eric, could you elaborate for me your position, please

Oct 30 2018, 5:30 PM

Oct 29 2018

echristo updated subscribers of D53652: [PPC64] Handle powerpc64 in OUTPUT_FORMAT.

Go ahead and commit for them.

Oct 29 2018, 10:46 PM
echristo added inline comments to D53545: [DWARF][NFC] NFC patch for reverted r342218 (refactoring rangelist handling).
Oct 29 2018, 3:46 PM
echristo added inline comments to D53545: [DWARF][NFC] NFC patch for reverted r342218 (refactoring rangelist handling).
Oct 29 2018, 3:38 PM

Oct 24 2018

echristo added a comment to D47811: [PATCH] [DWARF] Kotlin language.

I've put a note out to the DWARF committee to see if we can streamline the assignment of language codes. As long as there is a source of truth for these, we shouldn't have to wait for DWARF 6 to be published.
The idea has come up before, and now with a motivating case I think it's likely to happen. So if you could hold off a little longer (probably a few days) I can have an answer for you on that point.

Ok I'll wait as long as required, for now I've updated diff regarding my understanding of our yesterday conversation. Thank you for cooperation.

Out of all the current requests to the DWARF committee for a new language code, Kotlin is the only one to request a particular number, so there's a very high probability that you will actually get the requested number.
That said, the DWARF committee does not currently have a process for guaranteeing a language code, and it may be a little while (more than days, less than years) before that's in place.
Therefore, the current state of the patch LGTM, and sorry the DWARF committee can't be more responsive at this time.

Oct 24 2018, 11:49 PM
echristo committed rL345240: Revert "Fix use of __libcpp_deallocate in dynarray".
Revert "Fix use of __libcpp_deallocate in dynarray"
Oct 24 2018, 11:46 PM
echristo committed rCXX345240: Revert "Fix use of __libcpp_deallocate in dynarray".
Revert "Fix use of __libcpp_deallocate in dynarray"
Oct 24 2018, 11:46 PM
echristo committed rL345239: Temporarily Revert "Implement sized deallocation for std::allocator and friends..
Temporarily Revert "Implement sized deallocation for std::allocator and friends.
Oct 24 2018, 11:22 PM
echristo committed rCXX345239: Temporarily Revert "Implement sized deallocation for std::allocator and friends..
Temporarily Revert "Implement sized deallocation for std::allocator and friends.
Oct 24 2018, 11:22 PM
echristo accepted D53586: Implement Function Multiversioning for Non-ELF Systems..

All of the target specific stuff looks fine to me. I'm going to defer to rnk about the windows side of things and aaron for the attributes.

Oct 24 2018, 2:54 PM

Oct 23 2018

echristo accepted D52441: [CodeGen] Update min-legal-vector width based on function argument and return types.
In D52441#1271545, @rnk wrote:

Address Reid's comments. Add a comment with a list of all things that currently effect the vector width attribute emitted in IR.

For inlining, we update the caller's attribute during merging to ensure it is at least as large as the callee that is being inlined. This is required for always_inline of the intrinsics. We probably want a way to limit inlining, but that would effect the inlining decision. If the decision has been made to inline we have to take the max.

For LTO I don't have an answer. What do we do for things like target features and cpu today?

I think your comments about the behavior w.r.t. inlining are enough to describe what happens during LTO. I don't want to speak for Eric, but I think you've answered his questions.

Oct 23 2018, 5:20 PM
echristo committed rLLDB345086: Remove unused variable..
Remove unused variable.
Oct 23 2018, 2:58 PM
echristo committed rL345086: Remove unused variable..
Remove unused variable.
Oct 23 2018, 2:57 PM
echristo added a comment to D53364: [llvm-dwarfdump] - Add the support of parsing .debug_loclists..

I just wanted to let you know that I am currently working on a patch to refactor some of the rangelists code (see: https://reviews.llvm.org/D51081) with the objective to

  1. fold the pre-v5 functionality (.debug_ranges) into DWARF5 so we can get rid of DebugRangelists.{cpp,.h}
  2. templatize more of the DWARFListTable usage so it could be also used for location lists

    Unfortunately the first submission attempt caused some problems with TSan tests that I don't have access to, so there is still some work to be done. Once I'm past this I would like to suggest basing the location list table handling on the same framework, if you are OK with that.
Oct 23 2018, 12:34 AM

Oct 19 2018

echristo accepted D53364: [llvm-dwarfdump] - Add the support of parsing .debug_loclists..

LGTM. This code needs a lot of cleanup, but that's for another day.

Oct 19 2018, 5:29 PM
echristo accepted D53462: [X86] Add additional CPUs and features to Host.cpp and X86TargetParser.def to match compiler-rt and enable __builtin_cpu_supports/__builtin_cpu_is support in clang.

LGTM.

Oct 19 2018, 5:18 PM
echristo accepted D53461: [X86][compiler-rt] Add additional CPUs and features to the cpu detection to match libgcc.

LGTM.

Oct 19 2018, 5:17 PM
echristo accepted D53460: [X86] When checking the bits in cpu_features for function multiversioning dispatcher in the resolver, make sure all the required bits are set. Not just one of them.
Oct 19 2018, 5:16 PM