Page MenuHomePhabricator

echristo (Eric Christopher)
User

Projects

User Details

User Since
Oct 15 2012, 2:12 PM (389 w, 1 d)

Recent Activity

Today

echristo added a reviewer for D77154: [cmake] Add LLVM_USE_GDB_INDEX option for gold/lld linkers: dblaikie.
Tue, Mar 31, 1:49 PM · Restricted Project

Fri, Mar 27

echristo accepted D71353: Fix denormal-fp-math flag and attribute interaction.

Sure. I'd prefer we remove it from the struct completely, but that can happen later.

Fri, Mar 27, 12:36 PM · Restricted Project

Mon, Mar 23

echristo added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

I am very glad to see that we have made progress by landing D68063 (llvm/CodeGen/CommandFlags.inc) and D73674 (llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp). Basic block sections is agreed to be useful even outside Properller.

There are several optimizations goals:

  • Alignment inserting
  • Automatic cache prefetching
  • Large code model addressing can lower performance quite a bit. A post-link scheme can relax large code model addressting to small code model addressing.
  • ...

    There is a CPU erratum that we want to mitigate.
  • Intel's Jump Condition Code Erratum

    By making this change, we will go the object file level route: annotate object files with metadata so that certain transformations can be performed.

    Whether this scheme can satisfy the goals and avoid the erratum, and the uncertainty about how many stuff we will have to reinvent is my biggest concerns.

    On https://lists.llvm.org/pipermail/llvm-dev/2020-February/139543.html (my brainstorming), I mentioned we may achieve our goals and make it suitable for future optimizations by using a file format with more semantics (rather than an object file). I hope we can think more on this, rather than rush to conclusions "this is redoing full LTO. it can't scale"

    Considering the above points, I re-iterate my "Request Changes". We need a plan to prove that we can achieve our optimization goals while avoiding caveats (erratum).

@echristo @ruiu

If the JCC erratum is the only concern then we are able to show now with experiments that Propeller can produce JCC erratum free binaries with almost no performance impact and only by using the existing assembler mitigations : http://lists.llvm.org/pipermail/llvm-dev/2020-March/140134.html

Let's use that thread to continue to investigate how the linker could potentially do a better job of handling this or other erratums in general. Could we please unblock this?

Mon, Mar 23, 11:28 AM · Restricted Project, lld

Fri, Mar 20

echristo committed rGfc7233d77441: Temporarily Revert "[X86] Reland D71360 Clean up UseInitArray initialization… (authored by echristo).
Temporarily Revert "[X86] Reland D71360 Clean up UseInitArray initialization…
Fri, Mar 20, 5:55 PM
echristo added a reverting change for rG7899fe9da8d8: [X86] Reland D71360 Clean up UseInitArray initialization for…: rGfc7233d77441: Temporarily Revert "[X86] Reland D71360 Clean up UseInitArray initialization….
Fri, Mar 20, 5:55 PM

Tue, Mar 17

echristo added a comment to D68065: Propeller: LLD Support for Basic Block Sections.

In general I think a lot of this looks pretty good. It could use some more comments - in particular to call out what a lot of this code is used for. It's not used on a typical linking path and so could be confusing to people going through the code.

Tue, Mar 17, 11:16 AM · Restricted Project, lld
echristo added inline comments to D76297: [clang][AArch64] readd support for 'p' inline asm constraint.
Tue, Mar 17, 10:44 AM · Restricted Project

Mon, Mar 16

echristo committed rG8b3b04eb4164: Make isValidImmForSVEVecImmAddrMode inline static rather than just static. (authored by echristo).
Make isValidImmForSVEVecImmAddrMode inline static rather than just static.
Mon, Mar 16, 6:03 PM

Fri, Mar 13

echristo updated the diff for D71687: Fix full loop unrolling initialization in new pass manager.

Fix comments around full unroller.

Fri, Mar 13, 9:39 AM · Restricted Project, Restricted Project
echristo updated the diff for D71687: Fix full loop unrolling initialization in new pass manager.

Fixed the clang test.

Fri, Mar 13, 9:39 AM · Restricted Project, Restricted Project
echristo accepted D70720: [llvm-objdump] Display locations of variables alongside disassembly.

Couple of random comments, but feel free to fix and commit. I think anything else can be handled post-review.

Fri, Mar 13, 9:06 AM · debug-info, Restricted Project

Thu, Mar 12

echristo added a comment to D71353: Fix denormal-fp-math flag and attribute interaction.

So I'm still concerned that this is on TargetOptions at all. Ideally for new attributes like this we'd only put them on the IR - at the way you've got it we're making resetTargetOptions even harder to remove. I don't think this is the right path forward (as removing resetTargetOptions is the right path) and this is only making that harder.

Thu, Mar 12, 3:45 PM · Restricted Project
echristo accepted D71354: CodeGen: Add -denormal-fp-math-f32 flag.
Thu, Mar 12, 1:04 PM · Restricted Project

Wed, Mar 11

echristo accepted D68063: Propeller: LLVM support for basic block sections.
Wed, Mar 11, 6:10 PM · Restricted Project

Tue, Mar 10

echristo added a comment to D75795: [libc++abi] Change __cxa_finalize return type to void.

Hi Louis,

Tue, Mar 10, 6:05 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 9

echristo added a comment to D68063: Propeller: LLVM support for basic block sections.

To be clear I think this is close to being acceptable, I'm just asking some questions before hitting the ack and getting things tidied up a bit so the next person doesn't have to ask :)

Mon, Mar 9, 5:17 PM · Restricted Project
echristo added a comment to D75631: [llvm-objdump] Fix reliability of call target disassembling.

The change looks good to me regardless, but i'd like to understand the issue causing the variability in behaviour before giving formal approval, as non-determinism like this is bad, and might indicate something like an unitialised variable somewhere or some other bug.

I will also be nervous to approve this change, without understanding how the test fails.

Mon, Mar 9, 4:45 PM · Restricted Project
echristo added a comment to D68063: Propeller: LLVM support for basic block sections.

Also the commit message is awesome, but would be good to get the commit message represented as comments in lots of the final code if possible :)

Mon, Mar 9, 4:45 PM · Restricted Project
echristo added a comment to D71353: Fix denormal-fp-math flag and attribute interaction.

This is wanting a command line flag rather than setting it on the function, or rather in addition to being able to set it on the function? Also "this" in the commit message isn't quite clear. Having this be a separate set of both global function attributes and different than the other fp-math attributes means it really should be called out fairly explicitly why they need to be different, what the semantics are, etc.

Mon, Mar 9, 4:45 PM · Restricted Project
echristo added a comment to D68063: Propeller: LLVM support for basic block sections.

Couple of inline comments. I'm trying pretty hard to be able to get rid of TargetOptions.h some day if possible. Any thoughts on ways to do this without?

Mon, Mar 9, 4:45 PM · Restricted Project
echristo added a comment to D75836: [MC] Allow Stackmap sections after DWARF in MachO..

Doing it this way should be fine, too.

Mon, Mar 9, 9:41 AM · Restricted Project

Mon, Mar 2

echristo committed rG57397eba7a8a: Revert "[mlir] Add padding to 1-D Vector in CRunnerUtils.h" (authored by echristo).
Revert "[mlir] Add padding to 1-D Vector in CRunnerUtils.h"
Mon, Mar 2, 8:24 PM
echristo added a reverting change for rGa68235d583fc: [mlir] Add padding to 1-D Vector in CRunnerUtils.h: rG57397eba7a8a: Revert "[mlir] Add padding to 1-D Vector in CRunnerUtils.h".
Mon, Mar 2, 8:24 PM
echristo added a reverting change for rGbcee8982a293: [mlir] Hotfix - Fix Windows build: rG57397eba7a8a: Revert "[mlir] Add padding to 1-D Vector in CRunnerUtils.h".
Mon, Mar 2, 8:24 PM
echristo accepted D75480: Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function..

LGTM.

Mon, Mar 2, 2:58 PM · Restricted Project
echristo added a reverting change for rG78f9e5d098af: [mlir] Add padding to 1-D Vector in CRunnerUtils.h: rGe459596917a7: Temporarily Revert "[mlir] Add padding to 1-D Vector in CRunnerUtils.h" as it….
Mon, Mar 2, 2:57 PM
echristo committed rGe459596917a7: Temporarily Revert "[mlir] Add padding to 1-D Vector in CRunnerUtils.h" as it… (authored by echristo).
Temporarily Revert "[mlir] Add padding to 1-D Vector in CRunnerUtils.h" as it…
Mon, Mar 2, 2:57 PM

Feb 27 2020

echristo added a comment to D75329: [MLIR] Added llvm.freeze.

Can you document the semantics somewhere? (I have no idea if other patches have done anything like this, but it does seem like something that should be documented somewhere).

Feb 27 2020, 11:26 PM · Restricted Project
echristo added a comment to D75291: Rename "llvm-gsym" and "llvm-gsymutil" to "gsymutil"..

Most of the other tools are llvm- any reason for the change?

Feb 27 2020, 4:47 PM · debug-info, Restricted Project

Feb 25 2020

echristo accepted D75152: Fix typo.

This probably qualifies as "obvious" :)

Feb 25 2020, 6:07 PM · Restricted Project

Feb 24 2020

echristo accepted D74914: Clean up assembler CFI directives.

I think this is OK. Would you mind splitting out the undefined change from the register name change when committing?

Feb 24 2020, 2:20 PM · Restricted Project

Feb 19 2020

echristo accepted D74862: Add missing word in llc docs.
Feb 19 2020, 1:29 PM · Restricted Project
echristo added a comment to D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Fair enough. The DWARF committee has a different set of write-up requirements. Let me, aprantl, probinson, or others know if you have issues.

Feb 19 2020, 1:29 PM · Restricted Project
echristo added a comment to D70720: [llvm-objdump] Display locations of variables alongside disassembly.

Some nits and style/comment/readability requests. Generally pretty happy with how it looks though. And thanks James for the numerous rounds of reviews already! :)

Feb 19 2020, 11:55 AM · debug-info, Restricted Project

Feb 18 2020

echristo committed rG28728bf06f55: Fix a signed/unsigned warning promoted to error. (authored by echristo).
Fix a signed/unsigned warning promoted to error.
Feb 18 2020, 5:54 PM
echristo added a comment to D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese.

This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build with assertions on (clean build at e8e078c just before this change, broken at this, assert triggering at build fix commit).

https://buildkite.com/mlir/mlir-core/builds/2792#a54fb239-718b-4f0b-a309-f83e46ceb252

Feb 18 2020, 11:21 AM · Restricted Project

Feb 13 2020

echristo committed rGf3b933266a0d: Remove unused lambda argument. (authored by echristo).
Remove unused lambda argument.
Feb 13 2020, 5:25 PM
echristo committed rGe635e48020ad: Reinstate llvm-go to test the go bindings. (authored by echristo).
Reinstate llvm-go to test the go bindings.
Feb 13 2020, 5:25 PM
echristo added a reverting change for rG102814b4d36a: Continue removing llgo.: rGe635e48020ad: Reinstate llvm-go to test the go bindings..
Feb 13 2020, 5:25 PM

Feb 10 2020

echristo added a comment to D74369: [AddressSanitizer] Ensure only AllocaInst is passed to dbg.declare.

This all sounds good to me (other than "hey can we start getting rid of these intrinsics?" :)

Feb 10 2020, 4:57 PM · Restricted Project
echristo committed rG7bba79ba0c0e: Fix you->your typo. (authored by echristo).
Fix you->your typo.
Feb 10 2020, 3:19 PM
echristo committed rG102814b4d36a: Continue removing llgo. (authored by echristo).
Continue removing llgo.
Feb 10 2020, 10:37 AM
echristo committed rG372bfc65deb8: Remove llgo per discussion on llvm-dev: (authored by echristo).
Remove llgo per discussion on llvm-dev:
Feb 10 2020, 10:14 AM

Jan 27 2020

echristo added a comment to D72482: [mlir] Add a DCE pass for dead symbols..

Do we need a full separate pass structure for mlir or is there some sharing we can do here as this (at the IR level) is encompassed by GlobalDCE.

Jan 27 2020, 6:41 PM · Restricted Project

Jan 22 2020

echristo added a comment to D14222: [CodeGenPrepare] Don't call getSubtargetImpl quite as often .

Still looks good to me.

Jan 22 2020, 4:00 PM · Restricted Project

Jan 16 2020

echristo committed rG40ac4221c30f: Move static function to inline function - this fixes a conceivable ODR… (authored by echristo).
Move static function to inline function - this fixes a conceivable ODR…
Jan 16 2020, 4:13 PM
echristo committed rGde022a8824f5: [NFC] Fold isHugeExpression into hasHugeExpression and update callers… (authored by echristo).
[NFC] Fold isHugeExpression into hasHugeExpression and update callers…
Jan 16 2020, 3:34 PM
echristo added a reviewer for D72493: Fix ordering of PassExtension registry and LibraryHandles registry construction: beanz.
Jan 16 2020, 10:51 AM · Restricted Project

Jan 15 2020

echristo accepted D71258: Set some fast math attributes in setFunctionAttributes.

OK.

Jan 15 2020, 4:32 PM · Restricted Project
echristo added a comment to D71258: Set some fast math attributes in setFunctionAttributes.

It'd be much nicer to get rid of resetTargetOptions here? Can we do that yet?

Jan 15 2020, 3:57 PM · Restricted Project

Jan 9 2020

echristo added inline comments to D72468: Update the attribution policy to use the 'Author' property of a git commit.
Jan 9 2020, 12:54 PM · Restricted Project

Jan 8 2020

echristo added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Sadly I'm just noticing this:

Jan 8 2020, 5:47 PM · Restricted Project

Jan 7 2020

echristo committed rGc23c8746d0cb: XFAIL load_extension.ll for all targets currently - it's failing on additional… (authored by echristo).
XFAIL load_extension.ll for all targets currently - it's failing on additional…
Jan 7 2020, 5:05 PM

Dec 27 2019

echristo accepted D71944: Support powerpc and sparc when building without init_array..

Looks ok to me.

Dec 27 2019, 12:56 PM · Restricted Project, Restricted Project

Dec 26 2019

echristo committed rG371038e3ff72: Add an __attribute__((unused)) to populateWithGenerated since it might not be… (authored by echristo).
Add an __attribute__((unused)) to populateWithGenerated since it might not be…
Dec 26 2019, 6:51 PM
echristo committed rG8f9304f559ad: Temporarily Revert "[compiler-rt] [netbsd] Add support for versioned statvfs… (authored by echristo).
Temporarily Revert "[compiler-rt] [netbsd] Add support for versioned statvfs…
Dec 26 2019, 6:47 PM
echristo added a reverting change for rG78f714f824fa: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors: rG8f9304f559ad: Temporarily Revert "[compiler-rt] [netbsd] Add support for versioned statvfs….
Dec 26 2019, 6:47 PM
echristo committed rGe1838a17898a: Fix a -Wcovered-switch-default warning by moving the unreachable out of the… (authored by echristo).
Fix a -Wcovered-switch-default warning by moving the unreachable out of the…
Dec 26 2019, 6:39 PM
echristo committed rG3d18ce71548a: Remove an unused static function. (authored by echristo).
Remove an unused static function.
Dec 26 2019, 6:39 PM
echristo committed rG3009cee75f04: Fix a -Wcovered-switch-default warning by moving the unreachable out of the… (authored by echristo).
Fix a -Wcovered-switch-default warning by moving the unreachable out of the…
Dec 26 2019, 6:33 PM
echristo committed rG30617e4b9c87: Remove unused static function. (authored by echristo).
Remove unused static function.
Dec 26 2019, 6:21 PM
echristo committed rG1584e2f9870f: Remove SrcVT only used in an assert and propagate query. (authored by echristo).
Remove SrcVT only used in an assert and propagate query.
Dec 26 2019, 3:30 PM
echristo committed rG2369560f4a77: Fix -Wunused-lambda-capture warnings. (authored by echristo).
Fix -Wunused-lambda-capture warnings.
Dec 26 2019, 3:30 PM
echristo added a comment to D71687: Fix full loop unrolling initialization in new pass manager.

Ping ping goes the trolley.

Dec 26 2019, 12:05 PM · Restricted Project, Restricted Project

Dec 19 2019

echristo committed rG3075cd5c9fcc: Temporarily Revert "[Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate… (authored by echristo).
Temporarily Revert "[Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate…
Dec 19 2019, 1:32 PM
echristo added a reverting change for rGabc7f6800df8: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part…: rG3075cd5c9fcc: Temporarily Revert "[Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate….
Dec 19 2019, 1:32 PM
echristo committed rGadd710eb23d5: Temporarily Revert "[StackMaps] Be explicit about label formation [NFC]" as it… (authored by echristo).
Temporarily Revert "[StackMaps] Be explicit about label formation [NFC]" as it…
Dec 19 2019, 12:53 PM
echristo added a reverting change for rGbc7595d934b9: [StackMaps] Be explicit about label formation [NFC]: rGadd710eb23d5: Temporarily Revert "[StackMaps] Be explicit about label formation [NFC]" as it….
Dec 19 2019, 12:53 PM

Dec 18 2019

echristo created D71687: Fix full loop unrolling initialization in new pass manager.
Dec 18 2019, 8:21 PM · Restricted Project, Restricted Project
echristo updated the diff for D71687: Fix full loop unrolling initialization in new pass manager.

Formatting and parens changes.

Dec 18 2019, 8:21 PM · Restricted Project, Restricted Project

Dec 17 2019

echristo accepted D71640: [docs] Remove `git llvm push` and `git llvm revert` from GettingStarted.

LGTM.

Dec 17 2019, 5:19 PM · Restricted Project
echristo committed rGe62e760f2956: Temporarily Revert "[gicombiner] Add the MatchDag structure and parse… (authored by echristo).
Temporarily Revert "[gicombiner] Add the MatchDag structure and parse…
Dec 17 2019, 4:29 PM
echristo added a reverting change for rG390c8baa5440: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the…: rGe62e760f2956: Temporarily Revert "[gicombiner] Add the MatchDag structure and parse….
Dec 17 2019, 4:29 PM
echristo added a reverting change for rG520e3d66e725: [gicombiner] Process the MatchDag such that every node is reachable from the…: rGe62e760f2956: Temporarily Revert "[gicombiner] Add the MatchDag structure and parse….
Dec 17 2019, 4:29 PM

Dec 13 2019

echristo committed rG5623bd52acd3: Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction. (authored by echristo).
Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction.
Dec 13 2019, 1:00 PM
echristo closed D71486: [clang-tools-extra] Fix switch coverage warning.
Dec 13 2019, 1:00 PM · Restricted Project, Restricted Project
echristo updated the diff for D71486: [clang-tools-extra] Fix switch coverage warning.

Fix for some slightly better API uses.

Dec 13 2019, 1:00 PM · Restricted Project, Restricted Project
echristo created D71486: [clang-tools-extra] Fix switch coverage warning.
Dec 13 2019, 12:23 PM · Restricted Project, Restricted Project
echristo updated subscribers of D71486: [clang-tools-extra] Fix switch coverage warning.
Dec 13 2019, 12:23 PM · Restricted Project, Restricted Project

Dec 12 2019

echristo committed rGa8154e5e0c83: Temporarily revert "NFC: DebugInfo: Refactor RangeSpanList to be a struct, like… (authored by echristo).
Temporarily revert "NFC: DebugInfo: Refactor RangeSpanList to be a struct, like…
Dec 12 2019, 5:57 PM
echristo added a reverting change for rG8e04896288d2: NFC: DebugInfo: Refactor RangeSpanList to be a struct, like DebugLocStream::List: rGa8154e5e0c83: Temporarily revert "NFC: DebugInfo: Refactor RangeSpanList to be a struct, like….
Dec 12 2019, 5:57 PM
echristo committed rG259a9b103909: Update line number after previous patch added an additional unsupported and… (authored by echristo).
Update line number after previous patch added an additional unsupported and…
Dec 12 2019, 3:57 PM
echristo committed rG3ecfe64fe339: [sanitizers] Redirect stdout and stderr to TASK_LOG (authored by echristo).
[sanitizers] Redirect stdout and stderr to TASK_LOG
Dec 12 2019, 3:56 PM
echristo closed D71402: [sanitizers] Redirect stdout and stderr to TASK_LOG.
Dec 12 2019, 3:56 PM · Restricted Project, Restricted Project
echristo added a comment to D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

It appears that we have multiple things in review here.
See also D71096.
Also, is this in response to https://bugs.llvm.org/show_bug.cgi?id=44145 ? (which was closed as 'works for me')

Dec 12 2019, 1:38 PM · Restricted Project
echristo abandoned D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

Abandoning this one in favor of maskray's revision.

Dec 12 2019, 1:38 PM · Restricted Project
echristo added a reviewer for D71402: [sanitizers] Redirect stdout and stderr to TASK_LOG: pcc.
Dec 12 2019, 12:54 PM · Restricted Project, Restricted Project
echristo created D71402: [sanitizers] Redirect stdout and stderr to TASK_LOG.
Dec 12 2019, 1:39 AM · Restricted Project, Restricted Project
echristo committed rG6c79095576e0: Revert unintentional change to compiler-rt as part of the __bit_reference… (authored by echristo).
Revert unintentional change to compiler-rt as part of the __bit_reference…
Dec 12 2019, 12:35 AM
echristo committed rGfa0fc04a4f95: Temporarily Revert "[libc++] Fix -Wdeprecated-copy warnings in __bit_reference"… (authored by echristo).
Temporarily Revert "[libc++] Fix -Wdeprecated-copy warnings in __bit_reference"…
Dec 12 2019, 12:25 AM
echristo added a reverting change for rG02bb20223bda: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference: rGfa0fc04a4f95: Temporarily Revert "[libc++] Fix -Wdeprecated-copy warnings in __bit_reference"….
Dec 12 2019, 12:25 AM
echristo reopened D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

Reopening this.

Dec 12 2019, 12:25 AM · Restricted Project

Dec 11 2019

echristo committed rG02bb20223bda: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference (authored by echristo).
[libc++] Fix -Wdeprecated-copy warnings in __bit_reference
Dec 11 2019, 11:58 PM
echristo closed D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.
Dec 11 2019, 11:57 PM · Restricted Project
echristo updated the diff for D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

clang-format changed lines.

Dec 11 2019, 11:48 PM · Restricted Project
echristo created D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.
Dec 11 2019, 11:39 PM · Restricted Project
echristo added a comment to D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

The proposal seems interesting, but needs some more review.

Dec 11 2019, 11:30 PM · Restricted Project
echristo added a comment to D71393: Default to -fuse-init-array.

Fan of this change, but let's definitely wait for more reviews :)

Dec 11 2019, 11:30 PM · Restricted Project
echristo accepted D71376: [lldb][dotest] Add `#include <algorithm>` to libc++ detection.
Dec 11 2019, 2:10 PM · Restricted Project

Dec 10 2019

echristo accepted D71318: [TableGen] Remove unused target intrinsic generation logic.

Dead code is dead code :) LGTM.

Dec 10 2019, 8:07 PM · Restricted Project