- User Since
- Oct 15 2012, 2:12 PM (352 w, 6 d)
Mon, Jul 15
Thu, Jul 11
I am following, I've just been out for 3 weeks. I'm catching up now and this is in my queue.
Not a huge fan of boolean parameters like this, perhaps factor out the context as well into the caller and then we don't need it at all? Something else?
Tue, Jun 25
Mon, Jun 24
Jun 14 2019
*points at pcc* :)
Jun 13 2019
Haven't done much of a review, one drive by, but in general I like the idea. Would it make sense to have a general "remarks in object files" tool rather than just a size one? (It can, of course, only do size at the beginning.)
Jun 10 2019
Mostly looks good, some inline comments and questions.
I'm tagging in Roland here since he and I were just discussing this the other day. I'm not entirely sure what we want to document here as I'm torn on whether or not we should be doing more here.
Jun 3 2019
May 28 2019
Some inline comment requests and if you wouldn't mind changing the type allocator separately it'd be great.
May 21 2019
May 16 2019
Be nice to split the predicate change from the short change. No need to re-review though, they're both fine.
May 15 2019
May 14 2019
May 10 2019
May 9 2019
May 8 2019
May 7 2019
This happened here:
May 6 2019
Update comments. Have testcase work for multiple sizes and multiple preferred vector sizes.
Adding Sterling and Chris to this to take a look at the new layout :)
May 3 2019
Arguably this could use some more comments and I'll add those as well.
May 2 2019
LGTM. Sorry I didn't notice this earlier.
Apr 30 2019
Apr 29 2019
Apr 19 2019
Apr 18 2019
Sure. I'd have probably just checked for the function and maybe an instruction or two rather than the whole thing. It's more fragile that way and harder to understand what you're actually checking for since you mostly just said "doesn't crash" :)
Looks ok to me. Are you worried about the correctness of the code? That seems to be a lot of matching?
FWIW they're fine IMO too :)
Apr 17 2019
OK, this code could use some work, but not for you to refactor it more than you already have.
This sounds like people are fine with me doing this...
Apr 16 2019
Update for the new pass manager as well. :)
Apr 15 2019
Kristina has been in here the most, adding.