Page MenuHomePhabricator

echristo (Eric Christopher)
User

Projects

User Details

User Since
Oct 15 2012, 2:12 PM (352 w, 6 d)

Recent Activity

Mon, Jul 15

echristo committed rGbf20b2ace68d: Temporarily revert "add -fthinlto-index= option to clang-cl" (authored by echristo).
Temporarily revert "add -fthinlto-index= option to clang-cl"
Mon, Jul 15, 5:07 PM
echristo committed rL366157: Temporarily revert "add -fthinlto-index= option to clang-cl".
Temporarily revert "add -fthinlto-index= option to clang-cl"
Mon, Jul 15, 5:02 PM
echristo committed rGfdcbd5fa4868: Temporarily Revert "fix unnamed fiefield issue and add tests for… (authored by echristo).
Temporarily Revert "fix unnamed fiefield issue and add tests for…
Mon, Jul 15, 4:50 PM
echristo committed rL366155: Temporarily Revert "fix unnamed fiefield issue and add tests for….
Temporarily Revert "fix unnamed fiefield issue and add tests for…
Mon, Jul 15, 4:50 PM
echristo committed rG93dfb93ad68c: Temporarily Revert "[SLP] Recommit: Look-ahead operand reordering heuristic." (authored by echristo).
Temporarily Revert "[SLP] Recommit: Look-ahead operand reordering heuristic."
Mon, Jul 15, 4:36 PM
echristo committed rL366154: Temporarily Revert "[SLP] Recommit: Look-ahead operand reordering heuristic.".
Temporarily Revert "[SLP] Recommit: Look-ahead operand reordering heuristic."
Mon, Jul 15, 4:36 PM

Thu, Jul 11

echristo added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I am following, I've just been out for 3 weeks. I'm catching up now and this is in my queue.

Thu, Jul 11, 2:22 PM · lld, Restricted Project
echristo added a comment to D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC.

Not a huge fan of boolean parameters like this, perhaps factor out the context as well into the caller and then we don't need it at all? Something else?

Thu, Jul 11, 11:43 AM · Restricted Project

Tue, Jun 25

echristo accepted D63769: [ExpandMemCmp] Honor prefer-vector-width..
Tue, Jun 25, 10:31 AM · Restricted Project

Mon, Jun 24

echristo added a comment to D63306: Add a remarks-based code size diffing tool.

Haven't done much of a review, one drive by, but in general I like the idea. Would it make sense to have a general "remarks in object files" tool rather than just a size one? (It can, of course, only do size at the beginning.)

Thoughts?

Hmmm. That sounds similar to a more detailed version of opt-diff? (With added support for object files)

(I suppose that basically every pass can impact code size though, so I could see basically every remark being correlated with size.)

Do you have anything in particular in mind for what a more general tool would look like?

Mon, Jun 24, 6:56 PM · Restricted Project

Jun 14 2019

echristo added a comment to D63056: [bindings/go] Add debug information accessors.

*points at pcc* :)

Jun 14 2019, 2:05 PM · Restricted Project

Jun 13 2019

echristo added a comment to D63306: Add a remarks-based code size diffing tool.

Haven't done much of a review, one drive by, but in general I like the idea. Would it make sense to have a general "remarks in object files" tool rather than just a size one? (It can, of course, only do size at the beginning.)

Jun 13 2019, 10:49 PM · Restricted Project
echristo committed rG5e83d8fff43c: Move commentary on opcode translation for code16 mov instructions to segment… (authored by echristo).
Move commentary on opcode translation for code16 mov instructions to segment…
Jun 13 2019, 9:49 PM
echristo committed rL363355: Move commentary on opcode translation for code16 mov instructions.
Move commentary on opcode translation for code16 mov instructions
Jun 13 2019, 9:49 PM
echristo accepted D63298: Symbolize: Remove dead code. NFCI..
Jun 13 2019, 3:40 PM · Restricted Project

Jun 10 2019

echristo accepted D63114: Symbolize: Make DWPName a symbolizer option instead of an argument to symbolize{,Inlined}Code..
Jun 10 2019, 7:24 PM · Restricted Project
echristo accepted D63113: Symbolize: Replace the Options constructor with in-class initialization. NFCI..
Jun 10 2019, 7:24 PM · Restricted Project
echristo added a comment to D61767: [llvm-elfabi] Emit ELF header and string table section.

Mostly looks good, some inline comments and questions.

Jun 10 2019, 6:19 PM · Restricted Project
echristo added reviewers for D63083: [DebugInfo][Docs] Document that prologue/epilogue variable location changes are ignored: mcgrathr, echristo.

I'm tagging in Roland here since he and I were just discussing this the other day. I'm not entirely sure what we want to document here as I'm torn on whether or not we should be doing more here.

Jun 10 2019, 11:52 AM · Restricted Project

Jun 3 2019

echristo committed rG6d04fd15b5a2: Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004… (authored by echristo).
Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004…
Jun 3 2019, 4:15 PM
echristo committed rL362462: Remove test/CodeGen/builtin-stackaddress.c as it duplicates.
Remove test/CodeGen/builtin-stackaddress.c as it duplicates
Jun 3 2019, 4:15 PM
echristo closed D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c.
Jun 3 2019, 4:15 PM · Restricted Project, Restricted Project
echristo added a comment to D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c.

done thusly:

Jun 3 2019, 4:15 PM · Restricted Project, Restricted Project

May 28 2019

echristo accepted D60242: Add IR support, ELF section and user documentation for partitioning feature..

Some inline comment requests and if you wouldn't mind changing the type allocator separately it'd be great.

May 28 2019, 6:43 PM · Restricted Project
echristo accepted D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c.

LGTM.

May 28 2019, 4:44 PM · Restricted Project, Restricted Project

May 21 2019

echristo added inline comments to D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
May 21 2019, 5:20 PM · Restricted Project, Restricted Project

May 16 2019

echristo accepted D61990: [X86] Ignore "short" even harder in Intel ASM..

Be nice to split the predicate change from the short change. No need to re-review though, they're both fine.

May 16 2019, 4:03 PM · Restricted Project

May 15 2019

echristo committed rG29ff0f25196a: Fix typo in comment of CSAction -> Action. (authored by echristo).
Fix typo in comment of CSAction -> Action.
May 15 2019, 6:07 PM
echristo committed rL360834: Fix typo in comment of CSAction -> Action..
Fix typo in comment of CSAction -> Action.
May 15 2019, 6:05 PM

May 14 2019

echristo committed rG030b17db665a: Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI… (authored by echristo).
Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI…
May 14 2019, 12:39 PM
echristo added a reverting change for rGbdb21337e6e1: Change -gz and -Wa,--compress-debug-sections to use gABI compression…: rG030b17db665a: Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI….
May 14 2019, 12:39 PM
echristo committed rL360703: Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI….
Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI…
May 14 2019, 12:39 PM
echristo committed rC360703: Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI….
Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI…
May 14 2019, 12:38 PM
echristo added inline comments to D61846: [DAGCombiner] Fix invalid alias analysis..
May 14 2019, 11:50 AM · Restricted Project

May 10 2019

echristo committed rGa2d876c95a88: Remove an unnecessary header from SROA.h. (authored by echristo).
Remove an unnecessary header from SROA.h.
May 10 2019, 12:59 AM
echristo committed rL360410: Remove an unnecessary header from SROA.h..
Remove an unnecessary header from SROA.h.
May 10 2019, 12:59 AM
echristo added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

I would rather not clutter up the lldb command driver's options with gdb command flags. That seems like it will make lldb harder to figure out and reduce our freedom to choose reasonable short names for lldb driver options.

It was reasonable to add lldb aliases for the gdb commands that you use tens to hundreds of times in a give debugging session - those get wired into your hands... But I don't think the same consideration holds for command line options...

If we feel the need to add a driver gdb compatibility mode like this, I like Rafael's suggestion of:

lldb --gdb <everything after this is handled by our gdb emulation parser>

May 10 2019, 12:45 AM · Restricted Project

May 9 2019

echristo accepted D61762: [NFC][compiler-rt][builtins] Tidy and match comments for floating point operations.
May 9 2019, 3:27 PM · Restricted Project, Restricted Project

May 8 2019

echristo committed rGc93f56d39e62: Temporarily Revert "[DebugInfo] Terminate more location-list ranges at the end… (authored by echristo).
Temporarily Revert "[DebugInfo] Terminate more location-list ranges at the end…
May 8 2019, 4:54 PM
echristo committed rL360301: Temporarily Revert "[DebugInfo] Terminate more location-list ranges at the end….
Temporarily Revert "[DebugInfo] Terminate more location-list ranges at the end…
May 8 2019, 4:51 PM

May 7 2019

echristo closed D61546: Stop the DAG combiner from combining vector stores greater than preferred vector width....

This happened here:

May 7 2019, 12:33 PM · Restricted Project
echristo committed rG472722173440: Make sure that the DAG combiner doesn't merge stores that we explicitly asked… (authored by echristo).
Make sure that the DAG combiner doesn't merge stores that we explicitly asked…
May 7 2019, 12:24 PM
echristo committed rL360183: Make sure that the DAG combiner doesn't merge stores that we explicitly.
Make sure that the DAG combiner doesn't merge stores that we explicitly
May 7 2019, 12:23 PM

May 6 2019

echristo updated the diff for D61546: Stop the DAG combiner from combining vector stores greater than preferred vector width....

Update comments. Have testcase work for multiple sizes and multiple preferred vector sizes.

May 6 2019, 10:18 PM · Restricted Project
echristo committed rGe2b7332d2d9f: Fix typo in risc-v register aliases. (authored by echristo).
Fix typo in risc-v register aliases.
May 6 2019, 5:45 PM
echristo committed rC360104: Fix typo in risc-v register aliases..
Fix typo in risc-v register aliases.
May 6 2019, 5:45 PM
echristo committed rL360104: Fix typo in risc-v register aliases..
Fix typo in risc-v register aliases.
May 6 2019, 5:45 PM
echristo closed D61464: [RiscV] Typo in register aliases.
May 6 2019, 5:44 PM · Restricted Project, Restricted Project
echristo added reviewers for D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++: saugustine, cmatthews.

Adding Sterling and Chris to this to take a look at the new layout :)

May 6 2019, 3:16 PM · Restricted Project, Restricted Project, Restricted Project

May 3 2019

echristo added a comment to D61546: Stop the DAG combiner from combining vector stores greater than preferred vector width....

Arguably this could use some more comments and I'll add those as well.

May 3 2019, 8:17 PM · Restricted Project
echristo created D61546: Stop the DAG combiner from combining vector stores greater than preferred vector width....
May 3 2019, 8:16 PM · Restricted Project

May 2 2019

echristo committed rG86e2f169bb7b: Tidy up a comment, fix a typo, remove a comment that's obsolete. (authored by echristo).
Tidy up a comment, fix a typo, remove a comment that's obsolete.
May 2 2019, 5:14 PM
echristo committed rL359852: Tidy up a comment, fix a typo, remove a comment that's obsolete..
Tidy up a comment, fix a typo, remove a comment that's obsolete.
May 2 2019, 5:14 PM
echristo accepted D61464: [RiscV] Typo in register aliases.

LGTM. Sorry I didn't notice this earlier.

May 2 2019, 5:07 PM · Restricted Project, Restricted Project
echristo committed rG88a0f138920d: Typo Functino->Function. (authored by echristo).
Typo Functino->Function.
May 2 2019, 12:51 PM
echristo committed rL359821: Typo Functino->Function..
Typo Functino->Function.
May 2 2019, 12:51 PM

Apr 30 2019

echristo committed rGdb555ab4df0e: Make some comments that were meant to be for public documentation actually… (authored by echristo).
Make some comments that were meant to be for public documentation actually…
Apr 30 2019, 6:27 PM
echristo committed rL359640: Make some comments that were meant to be for public documentation.
Make some comments that were meant to be for public documentation
Apr 30 2019, 6:26 PM
echristo committed rG7a76e2b8cd7f: Add an include of Module since we actually access it now and remove the forward… (authored by echristo).
Add an include of Module since we actually access it now and remove the forward…
Apr 30 2019, 2:54 PM
echristo committed rL359618: Add an include of Module since we actually access it now and remove.
Add an include of Module since we actually access it now and remove
Apr 30 2019, 2:54 PM
echristo committed rG6435102c03e3: Fix a few -Werror warnings: - Remove a variable only used in an assert - Fix… (authored by echristo).
Fix a few -Werror warnings: - Remove a variable only used in an assert - Fix…
Apr 30 2019, 2:45 PM
echristo committed rL359617: Fix a few -Werror warnings:.
Fix a few -Werror warnings:
Apr 30 2019, 2:45 PM

Apr 29 2019

echristo added a reviewer for D61253: DWARF v5: fix directory index in the line table: tamur.
Apr 29 2019, 1:47 PM · Restricted Project

Apr 19 2019

echristo accepted D60931: [builtins] Use aliases for function redirects.
Apr 19 2019, 6:47 PM · Restricted Project, Restricted Project
echristo committed rGdfebd84eb32b: Remove the EnableEarlyCSEMemSSA set of options from the legacy and new pass… (authored by echristo).
Remove the EnableEarlyCSEMemSSA set of options from the legacy and new pass…
Apr 19 2019, 3:17 PM
echristo committed rL358789: Remove the EnableEarlyCSEMemSSA set of options from the legacy.
Remove the EnableEarlyCSEMemSSA set of options from the legacy
Apr 19 2019, 3:17 PM
echristo closed D60747: Remove EnableEarlyCSEMemSSA option.
Apr 19 2019, 3:17 PM · Restricted Project
echristo closed D60745: Remove RunSLPAfterLoopVectorization option....

Committed thusly:

Apr 19 2019, 2:46 PM · Restricted Project

Apr 18 2019

echristo added a comment to D53379: GSYM symbolication format.

We have a use case for this other than Breakpad.

Apr 18 2019, 5:13 PM
echristo added a comment to D60858: AMDGPU: Skip debug instructions in assert.

Sure. I'd have probably just checked for the function and maybe an instruction or two rather than the whole thing. It's more fragile that way and harder to understand what you're actually checking for since you mostly just said "doesn't crash" :)

Apr 18 2019, 2:05 PM
echristo added a comment to D60858: AMDGPU: Skip debug instructions in assert.

Looks ok to me. Are you worried about the correctness of the code? That seems to be a lot of matching?

Apr 18 2019, 1:00 PM
echristo added a comment to D60858: AMDGPU: Skip debug instructions in assert.

FWIW they're fine IMO too :)

Apr 18 2019, 3:52 AM

Apr 17 2019

echristo accepted D60487: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt.

OK, this code could use some work, but not for you to refactor it more than you already have.

Apr 17 2019, 11:43 PM · Restricted Project
echristo added a comment to D60747: Remove EnableEarlyCSEMemSSA option.

This sounds like people are fine with me doing this...

Apr 17 2019, 11:31 PM · Restricted Project
echristo committed rGeff3b6fe7f69: Elaborate why we have an option on by default for enabling chr. (authored by echristo).
Elaborate why we have an option on by default for enabling chr.
Apr 17 2019, 11:17 PM
echristo committed rL358641: Elaborate why we have an option on by default for enabling chr..
Elaborate why we have an option on by default for enabling chr.
Apr 17 2019, 11:15 PM
echristo accepted D60841: [AsmPrinter] hoist %a output template to base class for ARM+Aarch64.

LGTM.

Apr 17 2019, 3:02 PM · Restricted Project

Apr 16 2019

echristo committed rL358552: Revert "Temporarily Revert "Add basic loop fusion pass."".
Revert "Temporarily Revert "Add basic loop fusion pass.""
Apr 16 2019, 9:55 PM
echristo committed rGe29874eaa04d: Revert "Add basic loop fusion pass." Per request. (authored by echristo).
Revert "Add basic loop fusion pass." Per request.
Apr 16 2019, 9:55 PM
echristo committed rL358553: Revert "Add basic loop fusion pass." Per request..
Revert "Add basic loop fusion pass." Per request.
Apr 16 2019, 9:55 PM
echristo committed rGcee313d288a4: Revert "Temporarily Revert "Add basic loop fusion pass."" (authored by echristo).
Revert "Temporarily Revert "Add basic loop fusion pass.""
Apr 16 2019, 9:55 PM
echristo committed rG0ebbf72a6346: Remove the run-slp-after-loop-vectorization option. (authored by echristo).
Remove the run-slp-after-loop-vectorization option.
Apr 16 2019, 7:28 PM
echristo committed rL358548: Remove the run-slp-after-loop-vectorization option..
Remove the run-slp-after-loop-vectorization option.
Apr 16 2019, 7:24 PM
echristo committed rL358546: Temporarily Revert "Add basic loop fusion pass.".
Temporarily Revert "Add basic loop fusion pass."
Apr 16 2019, 7:21 PM
echristo committed rGa86343512845: Temporarily Revert "Add basic loop fusion pass." As it's causing some bot… (authored by echristo).
Temporarily Revert "Add basic loop fusion pass." As it's causing some bot…
Apr 16 2019, 7:15 PM
echristo added a comment to D60745: Remove RunSLPAfterLoopVectorization option....

Do we need to adjust the new pass manager too?

Apr 16 2019, 5:19 PM · Restricted Project
echristo updated the diff for D60747: Remove EnableEarlyCSEMemSSA option.

Update for the new pass manager as well. :)

Apr 16 2019, 5:07 PM · Restricted Project
echristo added a comment to D60747: Remove EnableEarlyCSEMemSSA option.

I can't find any users of this flag, so I'm in favor of s/EnableEarlyCSEMemSSA/true/ if that simplifies things.

Is this still useful for debugging problems with MemSSA and GVNHoist?

If we just have to tweak this one place, IMO it's sufficiently straightforward to just manually flip between true/false in code. I've personally never used it to debug anything, though I can only speak for myself.

That was pretty much my thought. As far as the new pass manager - the flag isn't being used anywhere else other than this location :)

Apr 16 2019, 4:43 PM · Restricted Project
echristo accepted D60803: [AsmPrinter] defer %c to base class for ARM, PPC, and Hexagon. NFC.
Apr 16 2019, 4:34 PM · Restricted Project
echristo added a comment to D60747: Remove EnableEarlyCSEMemSSA option.

I can't find any users of this flag, so I'm in favor of s/EnableEarlyCSEMemSSA/true/ if that simplifies things.

Is this still useful for debugging problems with MemSSA and GVNHoist?

If we just have to tweak this one place, IMO it's sufficiently straightforward to just manually flip between true/false in code. I've personally never used it to debug anything, though I can only speak for myself.

Apr 16 2019, 4:07 PM · Restricted Project

Apr 15 2019

echristo created D60747: Remove EnableEarlyCSEMemSSA option.
Apr 15 2019, 7:21 PM · Restricted Project
echristo created D60745: Remove RunSLPAfterLoopVectorization option....
Apr 15 2019, 6:59 PM · Restricted Project
echristo committed rG3ad162bbebc4: Remove some more unused headers from MachineFunction.h and friends. (authored by echristo).
Remove some more unused headers from MachineFunction.h and friends.
Apr 15 2019, 6:06 PM
echristo committed rL358468: Remove some more unused headers from MachineFunction.h and friends..
Remove some more unused headers from MachineFunction.h and friends.
Apr 15 2019, 6:04 PM
echristo closed D60741: Remove some more unused headers from MachineFunction.h and friends..
Apr 15 2019, 6:04 PM · Restricted Project
echristo added a comment to D60741: Remove some more unused headers from MachineFunction.h and friends..

Sounds good to me.
How'd you test that the MachineMemOperand.h changes were OK? Looks like it doesn't have an implementation file, so I'm not sure it's included first in any file - which means it's harder to tell if removing headers from it is valid/keeps it standalone (since its inclusion context might be allowing it to get away without including necessary headers)

Apr 15 2019, 5:33 PM · Restricted Project
echristo created D60741: Remove some more unused headers from MachineFunction.h and friends..
Apr 15 2019, 5:23 PM · Restricted Project
echristo added a reviewer for D60738: [MSP430AsmPrinter] Refactor special cases out of printOperand. NFC: krisb.

Kristina has been in here the most, adding.

Apr 15 2019, 4:54 PM · Restricted Project
echristo accepted D60727: [NVPTXAsmPrinter] clean up dead code. NFC.

LGTM then.

Apr 15 2019, 1:05 PM · Restricted Project
echristo added a reviewer for D60727: [NVPTXAsmPrinter] clean up dead code. NFC: tra.

Nick: Can you do some archaeology on the original patch and find out if there was supposed to be something supported here?

Apr 15 2019, 10:50 AM · Restricted Project