- User Since
- Oct 15 2012, 2:12 PM (344 w, 17 h)
Thu, May 16
Be nice to split the predicate change from the short change. No need to re-review though, they're both fine.
Wed, May 15
Tue, May 14
Fri, May 10
Thu, May 9
Wed, May 8
Tue, May 7
This happened here:
Mon, May 6
Update comments. Have testcase work for multiple sizes and multiple preferred vector sizes.
Adding Sterling and Chris to this to take a look at the new layout :)
Fri, May 3
Arguably this could use some more comments and I'll add those as well.
Thu, May 2
LGTM. Sorry I didn't notice this earlier.
Tue, Apr 30
Mon, Apr 29
Apr 19 2019
Apr 18 2019
Sure. I'd have probably just checked for the function and maybe an instruction or two rather than the whole thing. It's more fragile that way and harder to understand what you're actually checking for since you mostly just said "doesn't crash" :)
Looks ok to me. Are you worried about the correctness of the code? That seems to be a lot of matching?
FWIW they're fine IMO too :)
Apr 17 2019
OK, this code could use some work, but not for you to refactor it more than you already have.
This sounds like people are fine with me doing this...
Apr 16 2019
Update for the new pass manager as well. :)
Apr 15 2019
Kristina has been in here the most, adding.
Nick: Can you do some archaeology on the original patch and find out if there was supposed to be something supported here?
Apr 12 2019
Apr 11 2019
Apr 10 2019
Apr 9 2019
One inline comment for a future cleanup, otherwise LGTM and thanks!
Apr 8 2019
This went here: