OK.

It'd be much nicer to get rid of resetTargetOptions here? Can we do that yet?

Sadly I'm just noticing this:

Looks ok to me.

Ping ping goes the trolley.

Formatting and parens changes.

LGTM.

Fix for some slightly better API uses.

In D71395#1781896, @mclow.lists wrote:

It appears that we have multiple things in review here.
See also D71096.
Also, is this in response to https://bugs.llvm.org/show_bug.cgi?id=44145 ? (which was closed as 'works for me')

Abandoning this one in favor of maskray's revision.

Reopening this.

clang-format changed lines.

The proposal seems interesting, but needs some more review.

Fan of this change, but let's definitely wait for more reviews :)

Dead code is dead code :) LGTM.

SGTM and thank you :)

Can you split this up?

In D70852#1763946, @uweigand wrote:

But in those cases like funnel shifts, common code (specifically SelectionDAGBuilder::visitIntrinsicCall) will handle the expansion if the target doesn't have an instruction.

So if we do need to do that for minnum/maxnum, that would probably be the better place.

However, this is still a bit different, because minnum/maxnum can also be the result of an explicit call to fmin/fmax in the source, and it would seem surprising to have that translated into a select sequence as well. If we originally had an fmin/fmax call, which was translated into minnum/maxnum that we then couldn't further optimize, the current expansion (back to the fmin/fmax call) seems correct to me.

It's only the case where we originally had a conditional that was translated into minnum/maxnum that expansion into fmin/fmax is incorrect (because those routines are only available when linking with -lm which the user might not do since there's no actual call to a libm routine in the original source).

The problem really is IMO that there's no way to tell these two cases apart at instruction selection time.

First of all: this is awesome.

In D62731#1749916, @mibintc wrote:

Thanks I see it, I'm working on a patch. Previously there was no support for frounding-math (unimplemented). This patch enables the option. In the IR builder, there's a call to a runtime function in the exception handler which is unexpectedly null. I start by adding a null pointer check.

Ping :)

Update to remove comments around SROA addition.

I've gone ahead and enabled SROA here. In the testing I've done so far it's helped execute time quite a bit and compile time/object size as well. It'll be really good for use with the trivial auto var initialization option also. SROA is a bit of a worry right now for debugging, but it's an area that's been improved upon significantly and I'm not worried about it getting a lot better.

LGTM. I know that lhames was in the process of reviewing so wait for an OK there please.