- User Since
- Oct 15 2012, 2:12 PM (326 w, 5 d)
Mon, Jan 14
If whitequark is happy I am :)
Wed, Jan 2
Tue, Jan 1
This seems like the sort of thing that you can just commit in the future.
Mon, Dec 31
That's fine, it's just not the state of the world and we should support compiling appropriately.
I don't want to pick a fight, but there can be used exactly same argument to defend pulling libgcc here.
OK, that makes sense. I'm not a huge fan of how this set of code looks, but it also seems unfair to require you to extensively refactor it for this.
Is something passing compiler-rt in as a -r link output or something?
Sun, Dec 30
Fri, Dec 21
Dec 18 2018
Thanks for the split! LGTM.
Thanks for the split. LGTM!
Thanks so much for the split!
FWIW once nemanja and Masoud are happy then this can go in.
Dec 13 2018
Looks like this stalled with no feedback outside of Chandler and I.
Dec 11 2018
LGTM. I'm quite a bit happier with this now. Thanks for going through the back and forth.
Dec 5 2018
LGTM still when everything else is approved.
Dec 4 2018
Dec 3 2018
Nov 28 2018
Nov 26 2018
Nov 13 2018
I can sign off on this.
This looks better to me. I've got an inline request for some elaboration and you might want to let chandlerc comment, but otherwise OK with me.
Nov 12 2018
Nov 9 2018
I think this is the right direction, couple comment:
Nov 8 2018
Once we get everything else handled this is fine :)
It'd be really great if we could handle all of this in the mips backend rather than in general code.
The llvm backend patch here has discussion around debug info kinds that we should iron out first.
Some inline comments - I'm still not happy with some of how this patch is and would like to see some changes and elaborations of how we split things out. Mostly it's bikeshed naming things, but the current state is a bit more confusing than without.
Some drive by comments again. Be good to get @ributzka to take a final look.
I have no other bikeshed colors here. :)
Naming sounds ok to me :)
Nov 6 2018
Nov 5 2018
Oct 30 2018
Random drive-by bikeshed:
Oct 29 2018
Go ahead and commit for them.
Oct 24 2018
All of the target specific stuff looks fine to me. I'm going to defer to rnk about the windows side of things and aaron for the attributes.
Oct 23 2018
Oct 19 2018
LGTM. This code needs a lot of cleanup, but that's for another day.
Feel free to make any follow on changes you need here.
I think Adrian has looked at this more recently than I have. Adding him here.
The specific use of ENUM_ENT is also somewhat confusing, but you didn't add that so OK.
Oct 18 2018
Oct 13 2018
I'm ok with the "here are a bunch of fuchsia tests" file :)
LGTM as well. Thanks!
Oct 9 2018
Oct 1 2018
Couple of comments/questions:
Sep 24 2018
Sounds like everyone is in favor. Hitting the accept button for Jordan :)
Sep 21 2018
Sep 20 2018
Sep 19 2018
Sep 18 2018
Adding Steve here in case he wants to opine.
Sep 16 2018
Sep 14 2018
Sep 6 2018
Sep 5 2018
I'll get it tomorrow if no one does before.
Meta comment: please split the rename out. I don't mind the rename, but it makes the change much harder to review.