- User Since
- Oct 15 2012, 2:12 PM (232 w, 1 d)
Mon, Mar 27
Couple of small nits, otherwise LGTM.
How does this work on the testcases that hfinkel added in PR32320?
Sat, Mar 25
Given that this is the suggested direction from Hal originally I'm going to take Danny's LGTM as an OK.
Fri, Mar 24
Thu, Mar 23
Oh, sure. :)
Should we delete the function so that no one tries to use it?
Needs more testing. Might want to make sure that you actually are recording some useful command line options and that you're looking at the cc1 command line.
Wed, Mar 22
Tue, Mar 21
Can you add a test for fno-auto-profile?
Why aren't we passing the flags down as a string in the IR?
Mon, Mar 20
No worries at all. Thanks!
Sat, Mar 18
Fri, Mar 17
Thu, Mar 16
(Otherwise I think I'm fine with the patch, just need to do that.)
Can you resend this and add llvm-commits on the initial send out so mail will go to the list as well?
This is OK with me.
In general, I'd prefer not to use the TargetMachine for this. This is already the only point where we use the DataLayout in the TargetMachine and I'd much rather use the values in the module for getting pointer sizes.
Wed, Mar 15
Mon, Mar 13
The boolean parameter threaded through seems a bit unwieldy. Would it be better to either a) add a call that said e.g. TII.numInstrsForCallReturn(), or b) just assume 1?
Fri, Mar 10
Tue, Feb 28
Thanks! Now let's get some performance testing and go from there.
I think this is still outstanding, and unless I've missed something LGTM.
Feb 25 2017
Feb 24 2017
Couple of inline comments while I was reading through. Hope we can use this to clean up some of the reading/writing interfaces in future patches :)
Feb 22 2017
Bunch of inline comments.
Feb 21 2017
One inline request, otherwise I think this is ok. Not sure if we want to use an i2/i8 rather than a pair of i1, but either way.
You marked things done that aren't done. What's going on? :)
Feb 17 2017
LGTM as well. Thanks for the thorough work here both of you. :)
Feb 15 2017
Feb 14 2017
One drive by comment while I'm looking at it.
One inline nit, I'd like to take a closer look at this though. Can you give an example of use case and lowering?