echristo (Eric Christopher)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 15 2012, 2:12 PM (240 w, 4 d)

Recent Activity

Today

echristo added a reviewer for D33562: MachineLICM: Add new condition for hoisting of caller preserved registers: MatzeB.

Looks ok to me too, Matthias?

Fri, May 26, 2:09 PM
echristo added a comment to D33448: [CodeGen] Add thumb-mode to target-features for arm/thumb triples..

I'll hold off merging this patch until D33436 lands, which fixes a problem with mixed ARM/Thumb codegen

Fri, May 26, 2:06 PM

Yesterday

echristo accepted D33448: [CodeGen] Add thumb-mode to target-features for arm/thumb triples..

One minor nit and LGTM.

Thu, May 25, 5:58 PM
echristo added inline comments to D33404: [PowerPC] Fix a performance bug for PPC::XXPERMDI..
Thu, May 25, 5:57 PM
echristo added inline comments to D33225: [PowerPC] Fix a performance bug for PPC::XXSLDWI..
Thu, May 25, 4:35 PM
echristo added a comment to D33574: PPC: Verify that branch fixups fit within the range..

Haven't checked the numbers yet, but perhaps assert?

Thu, May 25, 4:08 PM

Wed, May 24

echristo added a comment to D32653: [InlineCost] Enable the new switch cost heuristic.

FWIW I think the flag "inline-generic-switch-cost" is both misleading (it takes true and not a number) and not helpful (the name of the flag doesn't tell me anything). Changing that would be nice. I'll let others determine whether or not we should turn it on now or not, the patch itself should be fine though.

Wed, May 24, 11:59 AM
echristo added inline comments to D33436: [ARM] Create relocation for Thumb functions calling ARM fns..
Wed, May 24, 11:09 AM
echristo added a comment to D33448: [CodeGen] Add thumb-mode to target-features for arm/thumb triples..

I probably would have added this as a feature in ARMTargetInfo similar to CRC/soft-float/etc.

Thoughts?

Do you mean ARMTargetMachine::getSubtargetImpl (https://github.com/llvm-mirror/llvm/blob/master/lib/Target/ARM/ARMTargetMachine.cpp#L305) ?

It seems like that function is only used by llc (and not llvm-as for example) and at that stage it is too late to add thumb-mode, because llc operates on a single module with a single target triple.

Wed, May 24, 10:47 AM

Tue, May 23

echristo accepted D33225: [PowerPC] Fix a performance bug for PPC::XXSLDWI..

I have one inline comment here, but it can be addressed in a follow up patch.

Tue, May 23, 5:41 PM
echristo accepted D33236: [PowerPC] Implement vec_xxsldwi builtin..

Sadly I think constant checking plus the shift makes it hard to do with just __builtin_shufflevector in altivec.h.

Tue, May 23, 5:34 PM
echristo requested changes to D33448: [CodeGen] Add thumb-mode to target-features for arm/thumb triples..

I probably would have added this as a feature in ARMTargetInfo similar to CRC/soft-float/etc.

Tue, May 23, 12:12 PM
echristo added a comment to D33436: [ARM] Create relocation for Thumb functions calling ARM fns..

One inline question, looks ok to me otherwise.

Tue, May 23, 12:07 PM
echristo accepted D33318: [ARM] Remove ThumbTargetMachines. (NFC).

This works for me. Thanks!

Tue, May 23, 12:04 PM
echristo accepted D33369: [PowerPC] Eliminate compares - add i64 sext/zext handling for equality.

A few cosmetic changes in addition to the notation change that was mentioned (I also like that).

Tue, May 23, 11:53 AM
echristo added inline comments to D31851: [PowerPC] Eliminate compares - add handling for logical operations without the use of condition registers.
Tue, May 23, 11:46 AM
echristo accepted D33053: [PowerPC] Implement vec_xxpermdi builtin..

Couple of small nits and a request to make some of the change separately, but otherwise LGTM. For the split part please don't actually submit another patch, just go ahead and do it :)

Tue, May 23, 11:38 AM

Mon, May 22

echristo added inline comments to D31851: [PowerPC] Eliminate compares - add handling for logical operations without the use of condition registers.
Mon, May 22, 1:50 PM

Wed, May 17

echristo added a comment to D33287: [Linker] Remove warning when linking ARM and Thumb IR modules..

I'm not even really sure that +thumb_mode works in all cases. Why not just have a single TargetMachine at that rate for the ARM back end?

Wed, May 17, 8:10 PM
echristo accepted D33078: CodeGen: BlockPlacement: Add Message strings to asserts. NFC.

Feel free to make any changes like this in the future. :)

Wed, May 17, 4:29 PM
echristo accepted D33222: [LegacyPassManager] Remove TargetMachine constructors.

This LGTM. I'd get one from Chandler as well though.

Wed, May 17, 3:59 PM
echristo added a comment to D31851: [PowerPC] Eliminate compares - add handling for logical operations without the use of condition registers.

A few inline comments, a couple of refactorings and some cleanup, otherwise looks OK.

Wed, May 17, 3:45 PM
echristo accepted D33152: [PowerPC] Fix test case sem_init_glibc.cc for powerpc64be.
Wed, May 17, 3:16 PM

Tue, May 16

echristo added a reviewer for D33248: [Power9] Exploit D-form vector load/store: timshen.
Tue, May 16, 1:11 PM

Mon, May 15

echristo added a comment to D33219: Fix executable stack directive on Linux..

Probably.

Mon, May 15, 4:07 PM
echristo accepted D33211: [builtins] Fix a check from __GNU__ to __GNUC__ for disabling executable stack..

LGTM.

Mon, May 15, 1:47 PM

Wed, May 10

echristo added a comment to D32880: [PPC] Change the register constraint of the first source operand of instruction mtvsrdd to g8rc_nox0.

If you can come up with a .ll testcase for the register class change that would be good. I'd like to get this in so don't spend a huge amount of time trying to reduce something.

Wed, May 10, 3:30 PM
echristo accepted D31847: [PowerPC] Eliminate compares in instruction selection - Vol. 1.

Couple of small comment requests, but that's it.

Wed, May 10, 11:21 AM

Tue, May 9

echristo added a comment to D32880: [PPC] Change the register constraint of the first source operand of instruction mtvsrdd to g8rc_nox0.

Seems useful for a disassembler change (feel free to make it separately as well if there's no visible change here).

Tue, May 9, 3:04 PM
echristo added a comment to D32653: [InlineCost] Enable the new switch cost heuristic.

Is there anything going on here? Should we do this?

Tue, May 9, 2:24 PM

Mon, May 8

echristo added a comment to D31847: [PowerPC] Eliminate compares in instruction selection - Vol. 1.

Few more inline comments :)

Mon, May 8, 2:29 PM

Fri, May 5

echristo added a comment to D32762: [Atomic] Remove IsStore/IsLoad in the interface, and pass the instruction instead. NFC..

Might want to remove the NFC then :)

Fri, May 5, 2:12 PM
echristo added a comment to D27620: [Assembler] Report multiple near misses for invalid instructions.

Catching up on code review. This is one of the next things on my list.

Fri, May 5, 9:11 AM

Thu, May 4

echristo requested changes to D31847: [PowerPC] Eliminate compares in instruction selection - Vol. 1.

Hi Nemanja!

Thu, May 4, 10:10 PM
echristo added a comment to D32201: [RALLOC] Increase CSR cost in RegAllocGreedy to favour splitting over CSR first use.

In general I'm a fan of the change, however, it feels like the heuristic value is somewhat unintelligable on scan. I.e. what's the difference between 1 << 13 and 5 (or any other value)? :)

Thu, May 4, 9:46 PM
echristo added inline comments to D31964: CodeGen: BlockPlacement: Clear ComputedEdges between functions..
Thu, May 4, 9:42 PM
echristo added a reviewer for D32762: [Atomic] Remove IsStore/IsLoad in the interface, and pass the instruction instead. NFC.: t.p.northover.
Thu, May 4, 8:53 PM
echristo added inline comments to D32774: CodeGen: Power: Add lowering for shifts of v1i128..
Thu, May 4, 8:52 PM
echristo requested changes to D32776: Enable branch coalescing on PowerPC.

I can think of three ways to enable this:

Thu, May 4, 8:49 PM
echristo requested changes to D32781: [PowerPC] Implement vec_xxsldwi and vec_xxpermdi builtins - llvm portion..

A quick question:

Thu, May 4, 8:29 PM

Tue, May 2

echristo added a comment to D31847: [PowerPC] Eliminate compares in instruction selection - Vol. 1.

Let's delete any function that just returns false or SDValue() and see what that does to some of the code.

Tue, May 2, 1:54 PM

Thu, Apr 27

echristo added a reviewer for D32527: Generalize flag carrying SDNodes beyond binary ops. NFC.: bogner.

LGTM and cleans up some interactions nicely, I've gone ahead and added Justin here in case he wants to comment.

Thu, Apr 27, 9:45 AM

Wed, Apr 26

echristo added a comment to D28249: Improve scheduling with branch coalescing.

Hi Matthias,

Wed, Apr 26, 9:27 PM
echristo added inline comments to D6052: Avoid short relocation in x86_64 large code model.
Wed, Apr 26, 5:10 PM
echristo added a comment to D31908: [AntiDepBreaker] Don't rename callee saved register restore instruction.

FWIW this is fixing a wrong code case for Power.

Wed, Apr 26, 5:08 PM
echristo added a comment to D31908: [AntiDepBreaker] Don't rename callee saved register restore instruction.

Testcase? Seems reasonable otherwise, but Matthias might have something more here.

Wed, Apr 26, 4:55 PM
echristo added a reviewer for D31908: [AntiDepBreaker] Don't rename callee saved register restore instruction: MatzeB.
Wed, Apr 26, 4:36 PM

Apr 26 2017

echristo accepted D32509: Replace HashString algorithm with xxHash64.

This is fine with me.

Apr 26 2017, 10:01 AM
echristo added a comment to D32509: Replace HashString algorithm with xxHash64.

@echristo: Is there anything besides LLVM tests that depends on llvm-dwarfdump's output ordering for the .gnu_pubnames section?

Apr 26 2017, 9:59 AM

Apr 25 2017

echristo added a comment to D32246: Don't emit CFI instructions at the end of a function.

(I do know the asm printer and this looks ok to me :)

Apr 25 2017, 4:21 PM

Apr 17 2017

echristo added a comment to D32122: Introduce LLVMDIBuilderRef.

One comment:

Apr 17 2017, 9:58 AM

Apr 14 2017

echristo committed rL300395: When we turn on vsx it should also turn on altivec explicitly, same.
When we turn on vsx it should also turn on altivec explicitly, same
Apr 14 2017, 11:27 PM
echristo committed rL300394: Tidy checking for the soft float attribute..
Tidy checking for the soft float attribute.
Apr 14 2017, 11:27 PM
echristo committed rL300393: Cache the DataLayout rather than looking it up frequently..
Cache the DataLayout rather than looking it up frequently.
Apr 14 2017, 11:27 PM
echristo accepted D32031: Add powerpc64 and powerpc64le to build infrastructure..

Seems reasonable to me. Feel free to iterate until happy :)

Apr 14 2017, 12:42 AM

Apr 11 2017

echristo resigned from D31747: [DWARF] - Refactoring of DWARFContextInMemory implementation..

Looks like Adrian has this review, removing myself.

Apr 11 2017, 3:24 PM
echristo requested changes to D31440: PR32382: Adapt to LLVM changes in DIExpression..

Sounds like Dave is asking for changes so I'll put it down as Request Changes to get it out of my queue. :)

Apr 11 2017, 1:48 PM
echristo resigned from D31821: Remove redundant copy in recurrences.

Probably best to have Quentin or Matthias do it.

Apr 11 2017, 1:48 PM
echristo requested changes to D31494: [PowerPC] Pretty-print CR bits the way the binutils disassembler does.
Apr 11 2017, 1:46 PM
echristo added a comment to D31494: [PowerPC] Pretty-print CR bits the way the binutils disassembler does.

Were we going to pick this up again? Still seems useful.

Apr 11 2017, 1:46 PM

Apr 10 2017

echristo accepted D31926: [XRay][compiler-rt] Remove the xray_fdr_log_printer_tool.
Apr 10 2017, 9:56 PM
echristo committed rL299887: Get the TOC save offset off of PPCFrameLowering rather than a separate copy of….
Get the TOC save offset off of PPCFrameLowering rather than a separate copy of…
Apr 10 2017, 3:34 PM

Apr 6 2017

echristo committed rL299726: Remove the default subtarget from the Power port. It's unnecessary and harmful….
Remove the default subtarget from the Power port. It's unnecessary and harmful…
Apr 6 2017, 4:14 PM
echristo accepted D31775: [ARM] Add Kryo to available targets.
Apr 6 2017, 11:14 AM

Apr 4 2017

echristo added a comment to D31188: [AntiDepBreaker] Use liveins as well in StartBlock.

Totally happy to pull it back if you'd like, was just going on what Quentin said to do.

Apr 4 2017, 12:17 PM

Apr 3 2017

echristo added a comment to D31555: [PPC64, Sanitizers] Proper stack frame for the thread spawned in internal_clone.

Couple of inline comments. I think this looks right but I've added Kit and Nemanja on here so one of them can give an ACK if Bill doesn't.

Apr 3 2017, 3:24 PM
echristo added reviewers for D31555: [PPC64, Sanitizers] Proper stack frame for the thread spawned in internal_clone: kbarton, nemanjai.
Apr 3 2017, 3:21 PM

Mar 31 2017

echristo committed rL299278: Reduce the number of times we query the subtarget for the same information..
Reduce the number of times we query the subtarget for the same information.
Mar 31 2017, 4:24 PM
echristo committed rL299277: Small cleanup to remove extraneous cast..
Small cleanup to remove extraneous cast.
Mar 31 2017, 4:24 PM

Mar 30 2017

echristo committed rL299166: Updating branches/google/stable to r298696.
Updating branches/google/stable to r298696
Mar 30 2017, 8:41 PM
echristo committed rL299165: Creating tags/google/stable/2017-03-30 from r298696.
Creating tags/google/stable/2017-03-30 from r298696
Mar 30 2017, 8:41 PM
echristo committed rL299164: Updating branches/google/stable to r298696.
Updating branches/google/stable to r298696
Mar 30 2017, 8:06 PM
echristo committed rL299155: Creating tags/google/stable/2017-03-30 from r298696.
Creating tags/google/stable/2017-03-30 from r298696
Mar 30 2017, 8:05 PM
echristo committed rL299156: Updating branches/google/stable to r298696.
Updating branches/google/stable to r298696
Mar 30 2017, 8:05 PM
echristo committed rL299163: Creating tags/google/stable/2017-03-30 from r298696.
Creating tags/google/stable/2017-03-30 from r298696
Mar 30 2017, 8:04 PM
echristo committed rL299162: Updating branches/google/stable to r298696.
Updating branches/google/stable to r298696
Mar 30 2017, 7:51 PM
echristo committed rL299161: Creating tags/google/stable/2017-03-30 from r298696.
Creating tags/google/stable/2017-03-30 from r298696
Mar 30 2017, 7:48 PM
echristo committed rL299154: Cleaning up stable branch.
Cleaning up stable branch
Mar 30 2017, 7:48 PM
echristo committed rL299160: Updating branches/google/stable to r298696.
Updating branches/google/stable to r298696
Mar 30 2017, 7:44 PM
echristo committed rL299159: Creating tags/google/stable/2017-03-30 from r298696.
Creating tags/google/stable/2017-03-30 from r298696
Mar 30 2017, 7:42 PM
echristo committed rL299158: Updating branches/google/stable to r298696.
Updating branches/google/stable to r298696
Mar 30 2017, 7:40 PM
echristo committed rL299157: Creating tags/google/stable/2017-03-30 from r298696.
Creating tags/google/stable/2017-03-30 from r298696
Mar 30 2017, 7:36 PM
echristo committed rL299153: Temporarily revert "[PPC] In PPCBoolRetToInt change the bool value to i64 if….
Temporarily revert "[PPC] In PPCBoolRetToInt change the bool value to i64 if…
Mar 30 2017, 7:29 PM
echristo commandeered D25482: [PPC] Allow two post RA schedulers to be in the pipeline and select one depending on the Machine Function's subtarget.

Ehsan has left the building so I'm going to take this over and get it committed.

Mar 30 2017, 7:26 PM
echristo committed rL299151: Update x86-64 ABI link with the one from linuxbase.org since the other.
Update x86-64 ABI link with the one from linuxbase.org since the other
Mar 30 2017, 7:12 PM
echristo committed rL299149: Fix typo, defind -> defined..
Fix typo, defind -> defined.
Mar 30 2017, 6:58 PM
echristo committed rL299148: Fix typo, defind -> defined..
Fix typo, defind -> defined.
Mar 30 2017, 6:58 PM
echristo accepted D31188: [AntiDepBreaker] Use liveins as well in StartBlock.
Mar 30 2017, 3:48 PM
echristo added a comment to D31188: [AntiDepBreaker] Use liveins as well in StartBlock.

Committed thusly:

Mar 30 2017, 3:47 PM
echristo committed rL299125: Add testcase for r299124..
Add testcase for r299124.
Mar 30 2017, 3:47 PM
echristo committed rL299124: getPristineRegs is not accurately considering shrink wrapping puts.
getPristineRegs is not accurately considering shrink wrapping puts
Mar 30 2017, 3:46 PM
echristo added a comment to D31240: [PowerPC] Instruction Selection to eliminate compare instructions .

SGTM. Anything you can do to help manage complexity helps :)

Mar 30 2017, 2:19 PM
echristo accepted D31493: [XRay][docs] Examples for how to use XRay.

Awesome!

Mar 30 2017, 2:02 PM
echristo added a comment to D31240: [PowerPC] Instruction Selection to eliminate compare instructions .

Hi Lei,

Mar 30 2017, 11:46 AM
echristo closed D14596: [SROA] Choose more profitable type in findCommonType.

This has been committed for some time.

Mar 30 2017, 12:38 AM

Mar 29 2017

echristo added a comment to D31315: Record command lines in objects built by clang, LLVM part.

Committed thusly:

Mar 29 2017, 4:47 PM
echristo added a comment to D30760: Record command lines in objects built by clang, Clang part.

Committed thusly:
echristo@athyra ~/s/l/t/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
M lib/Driver/ToolChains/Clang.cpp
M test/Driver/debug-options.c
Committed r299037

Mar 29 2017, 4:47 PM
echristo committed rL299038: If the DIUnit has flags passed on it then have DW_AT_producer be a combination….
If the DIUnit has flags passed on it then have DW_AT_producer be a combination…
Mar 29 2017, 4:47 PM
echristo committed rL299037: Add the -grecord-gcc-switches option and pass the flags down on the compile….
Add the -grecord-gcc-switches option and pass the flags down on the compile…
Mar 29 2017, 4:46 PM
echristo accepted D31315: Record command lines in objects built by clang, LLVM part.

LGTM.

Mar 29 2017, 4:37 PM