Page MenuHomePhabricator

echristo (Eric Christopher)
User

Projects

User Details

User Since
Oct 15 2012, 2:12 PM (378 w, 4 d)

Recent Activity

Thu, Jan 16

echristo committed rG40ac4221c30f: Move static function to inline function - this fixes a conceivable ODR… (authored by echristo).
Move static function to inline function - this fixes a conceivable ODR…
Thu, Jan 16, 4:13 PM
echristo committed rGde022a8824f5: [NFC] Fold isHugeExpression into hasHugeExpression and update callers… (authored by echristo).
[NFC] Fold isHugeExpression into hasHugeExpression and update callers…
Thu, Jan 16, 3:34 PM
echristo added a reviewer for D72493: Fix ordering of PassExtension registry and LibraryHandles registry construction: beanz.
Thu, Jan 16, 10:51 AM · Restricted Project

Wed, Jan 15

echristo accepted D71258: Set some fast math attributes in setFunctionAttributes.

OK.

Wed, Jan 15, 4:32 PM · Restricted Project
echristo added a comment to D71258: Set some fast math attributes in setFunctionAttributes.

It'd be much nicer to get rid of resetTargetOptions here? Can we do that yet?

Wed, Jan 15, 3:57 PM · Restricted Project

Thu, Jan 9

echristo added inline comments to D72468: Update the attribution policy to use the 'Author' property of a git commit.
Thu, Jan 9, 12:54 PM · Restricted Project

Wed, Jan 8

echristo added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Sadly I'm just noticing this:

Wed, Jan 8, 5:47 PM · Restricted Project

Tue, Jan 7

echristo committed rGc23c8746d0cb: XFAIL load_extension.ll for all targets currently - it's failing on additional… (authored by echristo).
XFAIL load_extension.ll for all targets currently - it's failing on additional…
Tue, Jan 7, 5:05 PM

Fri, Dec 27

echristo accepted D71944: Support powerpc and sparc when building without init_array..

Looks ok to me.

Fri, Dec 27, 12:56 PM · Restricted Project, Restricted Project

Thu, Dec 26

echristo committed rG371038e3ff72: Add an __attribute__((unused)) to populateWithGenerated since it might not be… (authored by echristo).
Add an __attribute__((unused)) to populateWithGenerated since it might not be…
Thu, Dec 26, 6:51 PM
echristo committed rG8f9304f559ad: Temporarily Revert "[compiler-rt] [netbsd] Add support for versioned statvfs… (authored by echristo).
Temporarily Revert "[compiler-rt] [netbsd] Add support for versioned statvfs…
Thu, Dec 26, 6:47 PM
echristo added a reverting change for rG78f714f824fa: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors: rG8f9304f559ad: Temporarily Revert "[compiler-rt] [netbsd] Add support for versioned statvfs….
Thu, Dec 26, 6:47 PM
echristo committed rGe1838a17898a: Fix a -Wcovered-switch-default warning by moving the unreachable out of the… (authored by echristo).
Fix a -Wcovered-switch-default warning by moving the unreachable out of the…
Thu, Dec 26, 6:39 PM
echristo committed rG3d18ce71548a: Remove an unused static function. (authored by echristo).
Remove an unused static function.
Thu, Dec 26, 6:39 PM
echristo committed rG3009cee75f04: Fix a -Wcovered-switch-default warning by moving the unreachable out of the… (authored by echristo).
Fix a -Wcovered-switch-default warning by moving the unreachable out of the…
Thu, Dec 26, 6:33 PM
echristo committed rG30617e4b9c87: Remove unused static function. (authored by echristo).
Remove unused static function.
Thu, Dec 26, 6:21 PM
echristo committed rG1584e2f9870f: Remove SrcVT only used in an assert and propagate query. (authored by echristo).
Remove SrcVT only used in an assert and propagate query.
Thu, Dec 26, 3:30 PM
echristo committed rG2369560f4a77: Fix -Wunused-lambda-capture warnings. (authored by echristo).
Fix -Wunused-lambda-capture warnings.
Thu, Dec 26, 3:30 PM
echristo added a comment to D71687: Fix full loop unrolling initialization in new pass manager.

Ping ping goes the trolley.

Thu, Dec 26, 12:05 PM · Restricted Project, Restricted Project

Thu, Dec 19

echristo committed rG3075cd5c9fcc: Temporarily Revert "[Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate… (authored by echristo).
Temporarily Revert "[Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate…
Thu, Dec 19, 1:32 PM
echristo added a reverting change for rGabc7f6800df8: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part…: rG3075cd5c9fcc: Temporarily Revert "[Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate….
Thu, Dec 19, 1:32 PM
echristo committed rGadd710eb23d5: Temporarily Revert "[StackMaps] Be explicit about label formation [NFC]" as it… (authored by echristo).
Temporarily Revert "[StackMaps] Be explicit about label formation [NFC]" as it…
Thu, Dec 19, 12:53 PM
echristo added a reverting change for rGbc7595d934b9: [StackMaps] Be explicit about label formation [NFC]: rGadd710eb23d5: Temporarily Revert "[StackMaps] Be explicit about label formation [NFC]" as it….
Thu, Dec 19, 12:53 PM

Dec 18 2019

echristo created D71687: Fix full loop unrolling initialization in new pass manager.
Dec 18 2019, 8:21 PM · Restricted Project, Restricted Project
echristo updated the diff for D71687: Fix full loop unrolling initialization in new pass manager.

Formatting and parens changes.

Dec 18 2019, 8:21 PM · Restricted Project, Restricted Project

Dec 17 2019

echristo accepted D71640: [docs] Remove `git llvm push` and `git llvm revert` from GettingStarted.

LGTM.

Dec 17 2019, 5:19 PM · Restricted Project
echristo committed rGe62e760f2956: Temporarily Revert "[gicombiner] Add the MatchDag structure and parse… (authored by echristo).
Temporarily Revert "[gicombiner] Add the MatchDag structure and parse…
Dec 17 2019, 4:29 PM
echristo added a reverting change for rG390c8baa5440: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the…: rGe62e760f2956: Temporarily Revert "[gicombiner] Add the MatchDag structure and parse….
Dec 17 2019, 4:29 PM
echristo added a reverting change for rG520e3d66e725: [gicombiner] Process the MatchDag such that every node is reachable from the…: rGe62e760f2956: Temporarily Revert "[gicombiner] Add the MatchDag structure and parse….
Dec 17 2019, 4:29 PM

Dec 13 2019

echristo committed rG5623bd52acd3: Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction. (authored by echristo).
Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction.
Dec 13 2019, 1:00 PM
echristo closed D71486: [clang-tools-extra] Fix switch coverage warning.
Dec 13 2019, 1:00 PM · Restricted Project, Restricted Project
echristo updated the diff for D71486: [clang-tools-extra] Fix switch coverage warning.

Fix for some slightly better API uses.

Dec 13 2019, 1:00 PM · Restricted Project, Restricted Project
echristo created D71486: [clang-tools-extra] Fix switch coverage warning.
Dec 13 2019, 12:23 PM · Restricted Project, Restricted Project
echristo updated subscribers of D71486: [clang-tools-extra] Fix switch coverage warning.
Dec 13 2019, 12:23 PM · Restricted Project, Restricted Project

Dec 12 2019

echristo committed rGa8154e5e0c83: Temporarily revert "NFC: DebugInfo: Refactor RangeSpanList to be a struct, like… (authored by echristo).
Temporarily revert "NFC: DebugInfo: Refactor RangeSpanList to be a struct, like…
Dec 12 2019, 5:57 PM
echristo added a reverting change for rG8e04896288d2: NFC: DebugInfo: Refactor RangeSpanList to be a struct, like DebugLocStream::List: rGa8154e5e0c83: Temporarily revert "NFC: DebugInfo: Refactor RangeSpanList to be a struct, like….
Dec 12 2019, 5:57 PM
echristo committed rG259a9b103909: Update line number after previous patch added an additional unsupported and… (authored by echristo).
Update line number after previous patch added an additional unsupported and…
Dec 12 2019, 3:57 PM
echristo committed rG3ecfe64fe339: [sanitizers] Redirect stdout and stderr to TASK_LOG (authored by echristo).
[sanitizers] Redirect stdout and stderr to TASK_LOG
Dec 12 2019, 3:56 PM
echristo closed D71402: [sanitizers] Redirect stdout and stderr to TASK_LOG.
Dec 12 2019, 3:56 PM · Restricted Project, Restricted Project
echristo added a comment to D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

It appears that we have multiple things in review here.
See also D71096.
Also, is this in response to https://bugs.llvm.org/show_bug.cgi?id=44145 ? (which was closed as 'works for me')

Dec 12 2019, 1:38 PM · Restricted Project
echristo abandoned D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

Abandoning this one in favor of maskray's revision.

Dec 12 2019, 1:38 PM · Restricted Project
echristo added a reviewer for D71402: [sanitizers] Redirect stdout and stderr to TASK_LOG: pcc.
Dec 12 2019, 12:54 PM · Restricted Project, Restricted Project
echristo created D71402: [sanitizers] Redirect stdout and stderr to TASK_LOG.
Dec 12 2019, 1:39 AM · Restricted Project, Restricted Project
echristo committed rG6c79095576e0: Revert unintentional change to compiler-rt as part of the __bit_reference… (authored by echristo).
Revert unintentional change to compiler-rt as part of the __bit_reference…
Dec 12 2019, 12:35 AM
echristo committed rGfa0fc04a4f95: Temporarily Revert "[libc++] Fix -Wdeprecated-copy warnings in __bit_reference"… (authored by echristo).
Temporarily Revert "[libc++] Fix -Wdeprecated-copy warnings in __bit_reference"…
Dec 12 2019, 12:25 AM
echristo added a reverting change for rG02bb20223bda: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference: rGfa0fc04a4f95: Temporarily Revert "[libc++] Fix -Wdeprecated-copy warnings in __bit_reference"….
Dec 12 2019, 12:25 AM
echristo reopened D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

Reopening this.

Dec 12 2019, 12:25 AM · Restricted Project

Dec 11 2019

echristo committed rG02bb20223bda: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference (authored by echristo).
[libc++] Fix -Wdeprecated-copy warnings in __bit_reference
Dec 11 2019, 11:58 PM
echristo closed D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.
Dec 11 2019, 11:57 PM · Restricted Project
echristo updated the diff for D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.

clang-format changed lines.

Dec 11 2019, 11:48 PM · Restricted Project
echristo created D71395: [libc++] Fix -Wdeprecated-copy warnings in __bit_reference.
Dec 11 2019, 11:39 PM · Restricted Project
echristo added a comment to D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

The proposal seems interesting, but needs some more review.

Dec 11 2019, 11:30 PM · Restricted Project
echristo added a comment to D71393: Default to -fuse-init-array.

Fan of this change, but let's definitely wait for more reviews :)

Dec 11 2019, 11:30 PM · Restricted Project
echristo accepted D71376: [lldb][dotest] Add `#include <algorithm>` to libc++ detection.
Dec 11 2019, 2:10 PM · Restricted Project

Dec 10 2019

echristo accepted D71318: [TableGen] Remove unused target intrinsic generation logic.

Dead code is dead code :) LGTM.

Dec 10 2019, 8:07 PM · Restricted Project
echristo accepted D71320: [IR] Split out target specific intrinsic enums into separate headers.

SGTM and thank you :)

Dec 10 2019, 7:58 PM · Restricted Project, Restricted Project
echristo committed rG1d41d1bcdfd7: Revert "Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple… (authored by echristo).
Revert "Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple…
Dec 10 2019, 3:09 PM
echristo added a reverting change for rGc9e0b354e274: Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB…: rG1d41d1bcdfd7: Revert "Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple….
Dec 10 2019, 3:09 PM
echristo committed rGf4a7d5659df7: Remove debugging printf and reformat code. (authored by echristo).
Remove debugging printf and reformat code.
Dec 10 2019, 3:09 PM
echristo committed rGc9e0b354e274: Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB… (authored by echristo).
Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB…
Dec 10 2019, 12:38 PM
echristo added a reverting change for rGe81268d03e73: [lldb/Reproducers] Support multiple GDB remotes: rGc9e0b354e274: Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB….
Dec 10 2019, 12:38 PM
echristo committed rG53acf0663f80: Fix a -Wsign-compare error around wchar_t vs unsigned int. (authored by echristo).
Fix a -Wsign-compare error around wchar_t vs unsigned int.
Dec 10 2019, 11:23 AM

Dec 9 2019

echristo committed rG52b1c94a5fe4: Turn off unused variable checking here since we're explicitly adding a command… (authored by echristo).
Turn off unused variable checking here since we're explicitly adding a command…
Dec 9 2019, 7:17 PM
echristo committed rG22d516261a98: Remove unused Unit test directory for xray. (authored by echristo).
Remove unused Unit test directory for xray.
Dec 9 2019, 6:41 PM
echristo committed rG9c6b7f68b807: Revert "[ARM][MVE] Add intrinsics for immediate shifts." and two follow-on… (authored by echristo).
Revert "[ARM][MVE] Add intrinsics for immediate shifts." and two follow-on…
Dec 9 2019, 4:57 PM

Dec 5 2019

echristo committed rGeaf6c22bf411: Add a default copy constructor for -Wdeprecated-copy warnings. (authored by echristo).
Add a default copy constructor for -Wdeprecated-copy warnings.
Dec 5 2019, 2:20 PM

Dec 4 2019

echristo committed rG5312139f779f: Add a default copy-assignment or copy-constructor for -Wdeprecated-copy… (authored by echristo).
Add a default copy-assignment or copy-constructor for -Wdeprecated-copy…
Dec 4 2019, 8:44 PM
echristo added a reviewer for D66822: Hardware cache line size builtins: echristo.
Dec 4 2019, 5:47 PM · Restricted Project
echristo added a comment to D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Can you split this up?

Dec 4 2019, 1:41 PM · Restricted Project

Dec 2 2019

echristo committed rG2e75681b55ab: Temporarily revert "build: avoid hardcoding the libxml2 library name" as it… (authored by echristo).
Temporarily revert "build: avoid hardcoding the libxml2 library name" as it…
Dec 2 2019, 2:35 PM
echristo added a reverting change for rG340e7c0b77a7: build: avoid hardcoding the libxml2 library name: rG2e75681b55ab: Temporarily revert "build: avoid hardcoding the libxml2 library name" as it….
Dec 2 2019, 2:35 PM

Nov 29 2019

echristo added a comment to D70852: [InstCombine] Guard maxnum/minnum conversions with a TTI query.

But in those cases like funnel shifts, common code (specifically SelectionDAGBuilder::visitIntrinsicCall) will handle the expansion if the target doesn't have an instruction.

So if we do need to do that for minnum/maxnum, that would probably be the better place.

However, this is still a bit different, because minnum/maxnum can also be the result of an explicit call to fmin/fmax in the source, and it would seem surprising to have that translated into a select sequence as well. If we originally had an fmin/fmax call, which was translated into minnum/maxnum that we then couldn't further optimize, the current expansion (back to the fmin/fmax call) seems correct to me.

It's only the case where we originally had a conditional that was translated into minnum/maxnum that expansion into fmin/fmax is incorrect (because those routines are only available when linking with -lm which the user might not do since there's no actual call to a libm routine in the original source).

The problem really is IMO that there's no way to tell these two cases apart at instruction selection time.

Nov 29 2019, 2:05 PM · Restricted Project

Nov 27 2019

echristo accepted D70435: Add links to Discord and Discourse to Useful Links.
Nov 27 2019, 11:58 PM · Restricted Project

Nov 26 2019

echristo committed rGfd39b1bb20ce: Revert "Revert "As a follow-up to my initial mail to llvm-dev here's a first… (authored by echristo).
Revert "Revert "As a follow-up to my initial mail to llvm-dev here's a first…
Nov 26 2019, 8:34 PM
echristo added a reverting change for rGc9ddb02659e3: Revert "As a follow-up to my initial mail to llvm-dev here's a first pass at…: rGfd39b1bb20ce: Revert "Revert "As a follow-up to my initial mail to llvm-dev here's a first….
Nov 26 2019, 8:34 PM
echristo closed D65410: [PassManager] First Pass implementation at -O1 pass pipeline.
Nov 26 2019, 8:33 PM · Restricted Project, Restricted Project, Restricted Project
echristo added a comment to D70720: [llvm-objdump] Display locations of variables alongside disassembly.

First of all: this is awesome.

Nov 26 2019, 8:51 AM · debug-info, Restricted Project

Nov 25 2019

echristo committed rG8ff85ed905a7: As a follow-up to my initial mail to llvm-dev here's a first pass at the O1… (authored by echristo).
As a follow-up to my initial mail to llvm-dev here's a first pass at the O1…
Nov 25 2019, 5:22 PM
echristo closed D65410: [PassManager] First Pass implementation at -O1 pass pipeline.
Nov 25 2019, 5:22 PM · Restricted Project, Restricted Project, Restricted Project
echristo committed rGe8075692589d: Fix an unused variable warning where a variable was only used in an assert. (authored by echristo).
Fix an unused variable warning where a variable was only used in an assert.
Nov 25 2019, 3:33 PM

Nov 20 2019

echristo committed rG8259182e51cc: Revert "[AArch64] Add the pipeline model for Exynos M5" as it's causing test… (authored by echristo).
Revert "[AArch64] Add the pipeline model for Exynos M5" as it's causing test…
Nov 20 2019, 4:07 PM
echristo added a reverting change for rG9bdfee2a3bd1: [AArch64] Add the pipeline model for Exynos M5: rG8259182e51cc: Revert "[AArch64] Add the pipeline model for Exynos M5" as it's causing test….
Nov 20 2019, 4:07 PM
echristo committed rG714aabacfb0f: Temporarily Revert "[SLP] allow forming 2-way reduction patterns" and update… (authored by echristo).
Temporarily Revert "[SLP] allow forming 2-way reduction patterns" and update…
Nov 20 2019, 4:07 PM
echristo added a reverting change for rG8a0aa5310bcc: Temporarily Revert "Temporarily Revert "[SLP] allow forming 2-way reduction…: rG714aabacfb0f: Temporarily Revert "[SLP] allow forming 2-way reduction patterns" and update….
Nov 20 2019, 4:07 PM
echristo committed rG8a0aa5310bcc: Temporarily Revert "Temporarily Revert "[SLP] allow forming 2-way reduction… (authored by echristo).
Temporarily Revert "Temporarily Revert "[SLP] allow forming 2-way reduction…
Nov 20 2019, 3:48 PM
echristo added a reverting change for rGcd8748a15f2d: Temporarily Revert "[SLP] allow forming 2-way reduction patterns": rG8a0aa5310bcc: Temporarily Revert "Temporarily Revert "[SLP] allow forming 2-way reduction….
Nov 20 2019, 3:48 PM
echristo committed rGcd8748a15f2d: Temporarily Revert "[SLP] allow forming 2-way reduction patterns" (authored by echristo).
Temporarily Revert "[SLP] allow forming 2-way reduction patterns"
Nov 20 2019, 3:21 PM
echristo added a reverting change for rG7ff57705ba19: [SLP] allow forming 2-way reduction patterns: rGcd8748a15f2d: Temporarily Revert "[SLP] allow forming 2-way reduction patterns".
Nov 20 2019, 3:21 PM

Nov 18 2019

echristo committed rG6f1cc4151a5a: Temporarily revert "[SLP] fix miscompile on min/max reductions with extra uses… (authored by echristo).
Temporarily revert "[SLP] fix miscompile on min/max reductions with extra uses…
Nov 18 2019, 2:46 PM
echristo added a reverting change for rGa3e61946c5bd: [SLP] fix miscompile on min/max reductions with extra uses (PR43948): rG6f1cc4151a5a: Temporarily revert "[SLP] fix miscompile on min/max reductions with extra uses….
Nov 18 2019, 2:46 PM
echristo committed rG30e7ee3c4bac: Temporarily Revert "Add support for options -frounding-math, ftrapping-math… (authored by echristo).
Temporarily Revert "Add support for options -frounding-math, ftrapping-math…
Nov 18 2019, 10:50 AM
echristo added a reverting change for rGe6584b2b7b2d: Move floating point related entities to namespace level: rG30e7ee3c4bac: Temporarily Revert "Add support for options -frounding-math, ftrapping-math….
Nov 18 2019, 10:50 AM
echristo added a reverting change for rGaf57dbf12e54: Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp…: rG30e7ee3c4bac: Temporarily Revert "Add support for options -frounding-math, ftrapping-math….
Nov 18 2019, 10:50 AM
echristo added a comment to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

Thanks I see it, I'm working on a patch. Previously there was no support for frounding-math (unimplemented). This patch enables the option. In the IR builder, there's a call to a runtime function in the exception handler which is unexpectedly null. I start by adding a null pointer check.

Nov 18 2019, 10:49 AM · Restricted Project, Restricted Project

Nov 15 2019

echristo added a comment to D65410: [PassManager] First Pass implementation at -O1 pass pipeline.

Ping :)

Nov 15 2019, 5:10 PM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2019

echristo committed rG7a3ad48d6de0: Temporarily Revert "Reapply [LVI] Normalize pointer behavior" as it's broken… (authored by echristo).
Temporarily Revert "Reapply [LVI] Normalize pointer behavior" as it's broken…
Nov 12 2019, 3:57 PM
echristo added a reverting change for rG885a05f48a5d: Reapply [LVI] Normalize pointer behavior: rG7a3ad48d6de0: Temporarily Revert "Reapply [LVI] Normalize pointer behavior" as it's broken….
Nov 12 2019, 3:57 PM

Nov 7 2019

echristo updated the diff for D65410: [PassManager] First Pass implementation at -O1 pass pipeline.

Update to remove comments around SROA addition.

Nov 7 2019, 4:55 PM · Restricted Project, Restricted Project, Restricted Project
echristo updated the diff for D65410: [PassManager] First Pass implementation at -O1 pass pipeline.

I've gone ahead and enabled SROA here. In the testing I've done so far it's helped execute time quite a bit and compile time/object size as well. It'll be really good for use with the trivial auto var initialization option also. SROA is a bit of a worry right now for debugging, but it's an area that's been improved upon significantly and I'm not worried about it getting a lot better.

Nov 7 2019, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
echristo accepted D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..

LGTM. I know that lhames was in the process of reviewing so wait for an OK there please.

Nov 7 2019, 10:47 AM · Restricted Project