Page MenuHomePhabricator

avl (Alexey Lapshin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 17 2017, 6:34 AM (248 w, 4 d)

Recent Activity

Today

avl added a comment to D125979: [ADT] add LockFreeDataPool class..

The name is not descriptive. It misses the important words about "hash map". ConcurrentHashMap may be a better name.

Mon, May 23, 11:31 AM · Restricted Project, Restricted Project

Sat, May 21

avl added a comment to D126059: [Debuginfo][DWARF][NFC] Add paired methods working with DWARFDebugInfoEntry..

I would actually request that no one can play with DWARFDebugInfoEntry items at all except for the DWARFDie class. The main issue is you can ask the wrong DWARFUnit class to do something with a DWARFDebugInfoEntry object that it doesn't own. We ran into this problem in LLDB and this is why we created the DWARFDie class in LLDB. If you encapsulate everything into the DWARFDie class and control all entry points, then this mistake can not be made since everyone needs to use the DWARFDie class. If you do want it add it, I would suggest adding an assert that verifies that the DWARFDebugInfoEntry belongs to the current DWARFUnit in each new function that takes a "DWARFDebugInfoEntry *", but I would still rather see everyone use DWARFDie if possible for safety reason and to avoid having an assert in each call.

Sat, May 21, 12:12 AM · Restricted Project, Restricted Project

Fri, May 20

avl added a reviewer for D125979: [ADT] add LockFreeDataPool class.: MaskRay.
Fri, May 20, 11:19 PM · Restricted Project, Restricted Project
avl requested review of D126059: [Debuginfo][DWARF][NFC] Add paired methods working with DWARFDebugInfoEntry..
Fri, May 20, 3:52 AM · Restricted Project, Restricted Project

Thu, May 19

avl requested review of D125979: [ADT] add LockFreeDataPool class..
Thu, May 19, 8:15 AM · Restricted Project, Restricted Project

Tue, May 17

avl committed rG4d9c083437f7: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum. (authored by avl).
[DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum.
Tue, May 17, 2:33 AM · Restricted Project, Restricted Project
avl closed D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..
Tue, May 17, 2:33 AM · Restricted Project, Restricted Project
avl added a comment to D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..

Thank you for the review!

Tue, May 17, 2:30 AM · Restricted Project, Restricted Project

Mon, May 16

avl updated the diff for D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..

added 'None' value for 'accelerator' option of dsymutil.

Mon, May 16, 9:06 AM · Restricted Project, Restricted Project
avl added inline comments to D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..
Mon, May 16, 6:26 AM · Restricted Project, Restricted Project

Sun, May 15

avl committed rGfdae8641adbe: [DWARFLinker][NFC] cleanup AddressManager interface. (authored by avl).
[DWARFLinker][NFC] cleanup AddressManager interface.
Sun, May 15, 12:49 PM · Restricted Project, Restricted Project
avl closed D125492: [DWARFLinker][NFC] cleanup AddressManager interface..
Sun, May 15, 12:49 PM · Restricted Project, Restricted Project
avl added a comment to D125492: [DWARFLinker][NFC] cleanup AddressManager interface..

Thank you for the review!

Sun, May 15, 12:48 PM · Restricted Project, Restricted Project

Thu, May 12

avl requested review of D125492: [DWARFLinker][NFC] cleanup AddressManager interface..
Thu, May 12, 12:10 PM · Restricted Project, Restricted Project
avl requested review of D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..
Thu, May 12, 9:46 AM · Restricted Project, Restricted Project
avl updated the summary of D125469: [DWARFLinker] mark odr candidates inside the same object file..
Thu, May 12, 8:01 AM · Restricted Project, Restricted Project
avl requested review of D125469: [DWARFLinker] mark odr candidates inside the same object file..
Thu, May 12, 7:56 AM · Restricted Project, Restricted Project

Wed, May 11

avl added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

How about:

Wed, May 11, 10:32 PM · Restricted Project, Restricted Project
avl added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

Can we name the option something other than "--use-dlnext"? This option name won't mean much to users. Not sure what a good option name would be though but something that doesn't talk about internal classes that will be used would be better IMHO.

Agreed. How about a flag to specify the dwarf linker: --dwarf-linker={dsymutil,dwarfutil}. The respective tools would have the respective linkers as their default and we could add more options later (e.g. dwarfutil with separete type units).

With the flag renames this LGTM.

Wed, May 11, 4:42 AM · Restricted Project, Restricted Project

Mon, May 9

avl added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

It would probably be worthwhile to do a few performance experiments here as well to make sure this doesn't regress debugging performance.

Mon, May 9, 10:12 AM · Restricted Project, Restricted Project

Fri, May 6

avl added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

I'm (still) very excited about this. I'm really happy that this lives behind a flag which addresses most of my original concerns. Making this the default in dsymutil would require a bunch of qualification but this approach allows me to do that gradually. One thing I suggested earlier I think was to run the lldb test suite with the new flag and see if that breaks anything. Did you ever get around to that?

Fri, May 6, 11:30 AM · Restricted Project, Restricted Project
avl added a comment to D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..

When you used this to compare the output of dsymutil changes, what was the input binary? Does this generate meaningful output for bigger programs like dsymutil itself?

Fri, May 6, 6:49 AM · Restricted Project, Restricted Project

Tue, May 3

avl added inline comments to D124350: [llvm-gsymutil][NFC] refactor AddressRange&AddresRanges structures..
Tue, May 3, 10:20 PM · Restricted Project, Restricted Project

Thu, Apr 28

avl added a comment to D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..

@clayborg Could you mind to check changes for AddressRangess class, please?

Thu, Apr 28, 1:25 PM · Restricted Project, Restricted Project
avl updated the diff for D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..

rebased on D124350

Thu, Apr 28, 10:13 AM · Restricted Project, Restricted Project

Tue, Apr 26

avl added a comment to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

@aprantl @JDevlieghere Could you take a look at this patch, since it affects dsymutil, please?

Tue, Apr 26, 3:29 AM · Restricted Project, debug-info, Restricted Project
avl updated the summary of D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..
Tue, Apr 26, 3:00 AM · Restricted Project, Restricted Project
avl committed rG34e2df21fdbc: [llvm-objcopy][NFC] rename variable. (authored by avl).
[llvm-objcopy][NFC] rename variable.
Tue, Apr 26, 2:54 AM · Restricted Project, Restricted Project
avl committed rG854c33946fd4: [llvm-gsymutil][NFC] refactor AddressRange&AddresRanges structures. (authored by avl).
[llvm-gsymutil][NFC] refactor AddressRange&AddresRanges structures.
Tue, Apr 26, 2:01 AM · Restricted Project, Restricted Project
avl closed D124350: [llvm-gsymutil][NFC] refactor AddressRange&AddresRanges structures..
Tue, Apr 26, 2:01 AM · Restricted Project, Restricted Project
avl added a comment to D124350: [llvm-gsymutil][NFC] refactor AddressRange&AddresRanges structures..

Thank you for the review!

Tue, Apr 26, 1:39 AM · Restricted Project, Restricted Project

Mon, Apr 25

avl updated the diff for D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..

renamed option to less specific variant (dsymutil-compat-dump -> type-compat-dump)
added doc description.

Mon, Apr 25, 5:23 AM · Restricted Project, Restricted Project
avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

renamed variable.

Mon, Apr 25, 4:15 AM · Restricted Project, debug-info, Restricted Project

Sun, Apr 24

avl requested review of D124350: [llvm-gsymutil][NFC] refactor AddressRange&AddresRanges structures..
Sun, Apr 24, 1:15 PM · Restricted Project, Restricted Project

Apr 23 2022

avl added a comment to D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..

Instead of doing a dumping thing, it might be a good idea to have a comparison mode build into llvm-dsymutil that can compare the contents of two files maybe?

Apr 23 2022, 8:14 AM · Restricted Project, Restricted Project

Apr 22 2022

avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

rebased on top of D123821.

Apr 22 2022, 1:38 PM · Restricted Project, debug-info, Restricted Project
avl committed rG79c1991010bd: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy. (authored by avl).
[llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy.
Apr 22 2022, 10:08 AM · Restricted Project, Restricted Project
avl closed D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy..
Apr 22 2022, 10:08 AM · Restricted Project, Restricted Project
avl added a comment to D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy..

Thank you for the review.

Apr 22 2022, 3:02 AM · Restricted Project, Restricted Project

Apr 21 2022

avl updated the diff for D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..

addressed comments.

Apr 21 2022, 5:29 AM · Restricted Project, Restricted Project
avl added inline comments to D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..
Apr 21 2022, 4:30 AM · Restricted Project, Restricted Project

Apr 20 2022

avl added a comment to D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..

Do you have a small/standalone lto example of these overlapped ranges - to understand both why they happen, and why they're invalid?

Apr 20 2022, 12:06 PM · Restricted Project, Restricted Project
avl added a comment to D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..

I don't think this would be enough to make dumps very comparable, would it?

Apr 20 2022, 11:57 AM · Restricted Project, Restricted Project
avl added a comment to D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..

@JDevlieghere Jonas, Would you mind to check this review, please?

Apr 20 2022, 5:45 AM · Restricted Project, Restricted Project
avl updated the diff for D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy..

addressed comments.

Apr 20 2022, 4:46 AM · Restricted Project, Restricted Project
avl updated the summary of D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..
Apr 20 2022, 3:22 AM · Restricted Project, Restricted Project
avl requested review of D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..
Apr 20 2022, 3:21 AM · Restricted Project, Restricted Project

Apr 19 2022

avl added inline comments to D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy..
Apr 19 2022, 12:58 AM · Restricted Project, Restricted Project
avl added inline comments to D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy..
Apr 19 2022, 12:51 AM · Restricted Project, Restricted Project

Apr 15 2022

avl updated the diff for D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..

addressed comments.

Apr 15 2022, 8:52 AM · Restricted Project, Restricted Project

Apr 14 2022

avl added a comment to D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy..

Functionality of restoreStatOnFile may be reused.

Do you have an impending usage? The functionality is to emulate in-place update of GNU strip/objcopy where "copy" in "objcopy" assumes some "cp" like behavior. This somewhat makes replacing GNU strip/objcopy easy.

For many utilities, they probably shouldn't do this.

Apr 14 2022, 3:01 PM · Restricted Project, Restricted Project
avl requested review of D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy..
Apr 14 2022, 1:35 PM · Restricted Project, Restricted Project

Apr 13 2022

avl added inline comments to D123623: [Debuginfo][llvm-dwarfutil] Add check for unsupported debug sections..
Apr 13 2022, 3:55 AM · Restricted Project, Restricted Project
avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 13 2022, 1:20 AM · Restricted Project, debug-info, Restricted Project
avl added a comment to D123623: [Debuginfo][llvm-dwarfutil] Add check for unsupported debug sections..

The error would be displayed for critical(such that could not be removed) sections and the source file would be skipped. Other unsupported sections would be removed and warning message should be displayed

I have concerns about this difference in behaviour between "critical" and "non-critical" sections:

  1. I assume this code has a DWARF version check, but if not, the assumption of what is "critical"/"non-critical" is going to fall down the next time a DWARF standard is published (potentially). Even then, developers of this tool will have to remember to update this list when adding DWARFv6 etc support. It feels fragile.
Apr 13 2022, 1:06 AM · Restricted Project, Restricted Project

Apr 12 2022

avl added a comment to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
In D86539#3434454, @avl wrote:

Right now if any DWARF section isn't supported, or if a DW_FORM is not supported, this patch will still emit a file and return a non-zero exit status.

So if this patch isn't going to support any of the DWARF sections that are required, it must exit with a valid error message and return a non zero exit status. The things that come to mind are:

  • anything with an older .debug_types section should return an error stating that debug types support is not supported
  • any newer DWARF with type units in the .debug_info section should return an error stating that debug types support is not supported
  • If fission is not supported, we need to return an error if we find any fission related sections (".debug_addr", etc)
  • if any DWARF section is required for debugging (like ".debug_loclists" or ".debug_rnglists") and not getting re-linked by this tool and if those sections become invalid after the DWARF is changed, then we need to return an error
  • if the line tables are too new and the DWARF linker can't update them return an error

All of this stems from Apple not having to support anything but what the Apple compilers emit. Many compilers that emit ELF files and linkers that link ELF have many other options that can be enabled for DWARF. If we aren't going to support them, we can't just emit some warnings and hope the user knows better, we need to return an error and set the exit status to a non zero value. We will need tests to cover these errors as well.

My intention was to limit first version to functionality presented in current dsymutil/DWARFLinker. And to add improvements incrementally. But If we want to have that extended check in the first version then I will add it.

My own preference is to integrate that first version of the tool and add improvements incrementally. f.e. adding such extended check would require changing interface of DWARFLinker. Use "Error DWARFLinker::link()" instead of "bool DWARFLinker::link()". It would be better to make such change separately.

A little background: I am very interested in this patch and I have been trying to get statistics with the resulting binary from this patch so I can evaluate if we want to use it in production on linked binaries produced by our build system. I'd like to see how long it takes to run and also how much smaller debug info becomes. If I run this currently I have no way to know if we are producing anything valid and wether or not I can log the results since we always produce something and have no exit status. I also can't trust the resulting debug info sizes at all since we might be removing all sorts of extra DWARF sections that the existing DWARF linker doesn't handle, or worse yet we just don't clone an attribute and we are missing inline debug info. So it is hard to evaluate this right now as it is. I do think we should try to return errors for files we can't handle though as it would be great if people trying this out could evaluate it and know if it is working for them or if there are things that aren't handled.

Apr 12 2022, 11:22 AM · Restricted Project, debug-info, Restricted Project
avl requested review of D123623: [Debuginfo][llvm-dwarfutil] Add check for unsupported debug sections..
Apr 12 2022, 11:17 AM · Restricted Project, Restricted Project
avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

addressed comments.

Apr 12 2022, 3:02 AM · Restricted Project, debug-info, Restricted Project
avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 12 2022, 1:47 AM · Restricted Project, debug-info, Restricted Project

Apr 11 2022

avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 11 2022, 1:43 PM · Restricted Project, debug-info, Restricted Project
avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

addressed comments.

Apr 11 2022, 1:39 PM · Restricted Project, debug-info, Restricted Project

Apr 10 2022

avl updated the diff for D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..

corrected test comment.

Apr 10 2022, 1:16 PM · Restricted Project, Restricted Project
avl updated the summary of D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 10 2022, 12:14 PM · Restricted Project, debug-info, Restricted Project
avl requested review of D123469: [DebugInfo][llvm-dwarfutil] Combine overlapped address ranges..
Apr 10 2022, 12:09 PM · Restricted Project, Restricted Project
avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

added comment for overlapping address ranges workaround.

Apr 10 2022, 1:47 AM · Restricted Project, debug-info, Restricted Project

Apr 8 2022

avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

addressed comments.

Apr 8 2022, 12:20 PM · Restricted Project, debug-info, Restricted Project
avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 8 2022, 3:22 AM · Restricted Project, debug-info, Restricted Project

Apr 7 2022

avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 7 2022, 11:46 AM · Restricted Project, debug-info, Restricted Project
avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 7 2022, 8:43 AM · Restricted Project, debug-info, Restricted Project
avl added a comment to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

A little background: I am very interested in this patch and I have been trying to get statistics with the resulting binary from this patch so I can evaluate if we want to use it in production on linked binaries produced by our build system. I'd like to see how long it takes to run and also how much smaller debug info becomes. If I run this currently I have no way to know if we are producing anything valid and wether or not I can log the results since we always produce something and have no exit status. I also can't trust the resulting debug info sizes at all since we might be removing all sorts of extra DWARF sections that the existing DWARF linker doesn't handle, or worse yet we just don't clone an attribute and we are missing inline debug info. So it is hard to evaluate this right now as it is. I do think we should try to return errors for files we can't handle though as it would be great if people trying this out could evaluate it and know if it is working for them or if there are things that aren't handled.

Apr 7 2022, 8:02 AM · Restricted Project, debug-info, Restricted Project

Apr 6 2022

avl added a comment to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

Right now if any DWARF section isn't supported, or if a DW_FORM is not supported, this patch will still emit a file and return a non-zero exit status.

So if this patch isn't going to support any of the DWARF sections that are required, it must exit with a valid error message and return a non zero exit status. The things that come to mind are:

  • anything with an older .debug_types section should return an error stating that debug types support is not supported
  • any newer DWARF with type units in the .debug_info section should return an error stating that debug types support is not supported
  • If fission is not supported, we need to return an error if we find any fission related sections (".debug_addr", etc)
  • if any DWARF section is required for debugging (like ".debug_loclists" or ".debug_rnglists") and not getting re-linked by this tool and if those sections become invalid after the DWARF is changed, then we need to return an error
  • if the line tables are too new and the DWARF linker can't update them return an error

All of this stems from Apple not having to support anything but what the Apple compilers emit. Many compilers that emit ELF files and linkers that link ELF have many other options that can be enabled for DWARF. If we aren't going to support them, we can't just emit some warnings and hope the user knows better, we need to return an error and set the exit status to a non zero value. We will need tests to cover these errors as well.

Apr 6 2022, 2:44 PM · Restricted Project, debug-info, Restricted Project
avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 6 2022, 2:37 PM · Restricted Project, debug-info, Restricted Project
avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

addressed comments.

Apr 6 2022, 2:27 PM · Restricted Project, debug-info, Restricted Project
avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 6 2022, 2:09 AM · Restricted Project, debug-info, Restricted Project

Apr 5 2022

avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

addressed comments(fixed overlapping range problem, added tests for error messages, other issues...)

Apr 5 2022, 2:40 PM · Restricted Project, debug-info, Restricted Project
avl added a comment to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

This can happen when you have LTO mess with the debug info as many functions might end up being combined. I have a command that dumps the ranges of DIEs and the problem looks like this:

DIE OFFSET RANGE                                     NAME
========== ========================================= ====================
0x0000e88e [0x0000000000028454 - 0x0000000000028474) freep
0x0000e8c2 [0x0000000000028454 - 0x0000000000028474) freep_aligned
0x00022cf4 [0x0000000000028454 - 0x0000000000028474) freep
0x00022d5d [0x0000000000028454 - 0x0000000000028474) freep_aligned
Apr 5 2022, 1:43 PM · Restricted Project, debug-info, Restricted Project
avl added a comment to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

Another issue I found when running this on ELF files:

warning: /tmp/a.out: Unsupported attribute form DW_FORM_ref_sig8 in cloneAttribute. Dropping.

We will need to make sure that we can clone all DW_FORM values

Apr 5 2022, 10:55 AM · Restricted Project, debug-info, Restricted Project

Apr 4 2022

avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

addressed comments(added test for copying over itself, formatting issues).

Apr 4 2022, 2:56 PM · Restricted Project, debug-info, Restricted Project
avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

addressed comments(added test for copying over itself, formatting issues).

Apr 4 2022, 2:52 PM · Restricted Project, debug-info, Restricted Project
avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Apr 4 2022, 4:58 AM · Restricted Project, debug-info, Restricted Project

Apr 3 2022

avl updated the summary of D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..
Apr 3 2022, 12:21 PM · Restricted Project, Restricted Project
avl updated the diff for D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

rebased. supported .debug_names.

Apr 3 2022, 12:19 PM · Restricted Project, Restricted Project

Apr 1 2022

avl added a reviewer for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF.: clayborg.
Apr 1 2022, 8:34 AM · Restricted Project, debug-info, Restricted Project
avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

addressed comments(used tablegen for options, added check for .text sections).

Apr 1 2022, 7:46 AM · Restricted Project, debug-info, Restricted Project

Mar 30 2022

avl added a comment to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

Currently if we rely on tombstone values, then we might end up missing relocations that have a non-zero addend where the base address is the tombstone value. The way that llvm-gsymutil (GSYM symbol format that can convert DWARF into GSYM) does it is to check for all executable section ranges and only accept any DW_TAG_subprogram values form these ranges.

Mar 30 2022, 8:38 AM · Restricted Project, debug-info, Restricted Project

Mar 29 2022

avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Mar 29 2022, 3:50 AM · Restricted Project, debug-info, Restricted Project
avl added inline comments to D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Mar 29 2022, 3:27 AM · Restricted Project, debug-info, Restricted Project

Mar 28 2022

avl updated subscribers of D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

Would you mind taking a look at this patch which implements dsymutil-like tool for ELF, previously discussed at https://lists.llvm.org/pipermail/llvm-dev/2020-August/144579.html, please?

Mar 28 2022, 1:49 PM · Restricted Project, debug-info, Restricted Project
avl updated the summary of D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Mar 28 2022, 10:50 AM · Restricted Project, debug-info, Restricted Project
avl updated the summary of D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Mar 28 2022, 10:49 AM · Restricted Project, debug-info, Restricted Project
avl retitled D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF. from [WIP][Debuginfo] dsymutil-like tool for ELF. to [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..
Mar 28 2022, 9:35 AM · Restricted Project, debug-info, Restricted Project
avl updated the diff for D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF..

implemented proposal https://lists.llvm.org/pipermail/llvm-dev/2020-August/144579.html

Mar 28 2022, 9:34 AM · Restricted Project, debug-info, Restricted Project

Mar 9 2022

avl added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

Does the patch in this diff already contain the changes where each type in a separate compile unit that matches the DW_AT_decl_file? I would love to start running some tests, we have some dSYM files that are too large and are exceeding the 4GB boundary that I would like to test this patch on.

Mar 9 2022, 2:00 PM · Restricted Project, Restricted Project
avl committed rGdedf006fa904: Fix for buildbot failure: https://lab.llvm. (authored by avl).
Fix for buildbot failure: https://lab.llvm.
Mar 9 2022, 3:38 AM · Restricted Project
avl committed rG2dc4a80ec026: [objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h (authored by avl).
[objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h
Mar 9 2022, 2:05 AM · Restricted Project
avl closed D121005: [objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h.
Mar 9 2022, 2:04 AM · Restricted Project, Restricted Project
avl added a comment to D121005: [objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h.

Ok. Thanks!

Mar 9 2022, 2:03 AM · Restricted Project, Restricted Project

Mar 8 2022

avl updated the diff for D121005: [objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h.

addressed comments.

Mar 8 2022, 2:36 AM · Restricted Project, Restricted Project
avl added inline comments to D121005: [objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h.
Mar 8 2022, 12:59 AM · Restricted Project, Restricted Project

Mar 7 2022

avl added inline comments to D121005: [objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h.
Mar 7 2022, 4:48 AM · Restricted Project, Restricted Project