Page MenuHomePhabricator

avl (Alexey Lapshin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 17 2017, 6:34 AM (108 w, 6 d)

Recent Activity

Thu, Sep 12

avl updated the summary of D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting..
Thu, Sep 12, 7:37 AM · debug-info, lld, Restricted Project

Wed, Sep 11

avl added projects to D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting.: lld, debug-info.
Wed, Sep 11, 11:15 PM · debug-info, lld, Restricted Project
avl added a comment to D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting..

Please note, this patch is not for integrating. This is for illustrative purpose for the thread on llvm-dev. http://lists.llvm.org/pipermail/llvm-dev/2019-September/135068.html

Wed, Sep 11, 3:34 PM · debug-info, lld, Restricted Project
avl removed a reviewer for D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting.: espindola.
Wed, Sep 11, 2:47 PM · debug-info, lld, Restricted Project
avl created D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting..
Wed, Sep 11, 2:44 PM · debug-info, lld, Restricted Project
avl added inline comments to D67217: [Debuginfo][Instcombiner] Do not clone dbg.declare in TryToSinkInstruction().
Wed, Sep 11, 10:43 AM · Restricted Project, debug-info
avl added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
In D64595#1635864, @rnk wrote:

This more or less gets the behavior of -instcombine-lower-dbg-declare=0 for structs, which is really all I cared about when I added it. The common case this flag improved is cases like the one in your test, simple C++ classes (like std::vector) stored on the stack and passed to some non-inline method call (__push_back_slow). So, I'm in favor of your change as written. In fact, I'd go further and remove the cl::opt if this lands, but let me do that since then I have to go update chromium's build to not pass it. :)

Wed, Sep 11, 7:07 AM · Restricted Project, debug-info
avl added inline comments to D67217: [Debuginfo][Instcombiner] Do not clone dbg.declare in TryToSinkInstruction().
Wed, Sep 11, 7:02 AM · Restricted Project, debug-info

Tue, Sep 10

avl committed rG6b1c6c1287dc: [Debuginfo][Instcombiner] Do not clone dbg.declare. (authored by avl).
[Debuginfo][Instcombiner] Do not clone dbg.declare.
Tue, Sep 10, 11:07 PM
avl committed rL371587: [Debuginfo][Instcombiner] Do not clone dbg.declare..
[Debuginfo][Instcombiner] Do not clone dbg.declare.
Tue, Sep 10, 11:06 PM
avl closed D67217: [Debuginfo][Instcombiner] Do not clone dbg.declare in TryToSinkInstruction().
Tue, Sep 10, 11:06 PM · Restricted Project, debug-info

Thu, Sep 5

avl updated the diff for D67217: [Debuginfo][Instcombiner] Do not clone dbg.declare in TryToSinkInstruction().

addressed comments.

Thu, Sep 5, 9:37 AM · Restricted Project, debug-info
avl created D67217: [Debuginfo][Instcombiner] Do not clone dbg.declare in TryToSinkInstruction().
Thu, Sep 5, 2:32 AM · Restricted Project, debug-info

Wed, Sep 4

avl added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

@jmorse , @aprantl Thanks for helping me with this!

Wed, Sep 4, 1:59 PM · Restricted Project, debug-info
avl committed rGcbf1f3b771c8: [Debuginfo][SROA] Need to handle dbg.value in SROA pass. (authored by avl).
[Debuginfo][SROA] Need to handle dbg.value in SROA pass.
Wed, Sep 4, 7:21 AM
avl committed rL370906: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
[Debuginfo][SROA] Need to handle dbg.value in SROA pass.
Wed, Sep 4, 7:18 AM
avl closed D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Wed, Sep 4, 7:18 AM · Restricted Project, debug-info

Tue, Sep 3

avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Tue, Sep 3, 11:23 AM · Restricted Project, debug-info
avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Tue, Sep 3, 10:53 AM · Restricted Project, debug-info

Sun, Sep 1

avl updated the diff for D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

My apologies for the delay. I was out of the office and I couldn 't finish it sooner.

Sun, Sep 1, 11:11 PM · Restricted Project, debug-info

Wed, Aug 21

avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Wed, Aug 21, 2:24 PM · Restricted Project, debug-info
avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Wed, Aug 21, 1:32 AM · Restricted Project, debug-info

Tue, Aug 20

avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Tue, Aug 20, 1:57 PM · Restricted Project, debug-info
avl added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

So I guess my question is, where are loads for the SROAed allocas generated?

Tue, Aug 20, 7:09 AM · Restricted Project, debug-info
avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Tue, Aug 20, 6:52 AM · Restricted Project, debug-info

Aug 19 2019

avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Aug 19 2019, 2:18 PM · Restricted Project, debug-info
avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Aug 19 2019, 2:08 PM · Restricted Project, debug-info
avl added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

OK, I will modify testcase to be single pass.

Aug 19 2019, 1:49 PM · Restricted Project, debug-info

Aug 16 2019

avl updated the diff for D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

I implemented the solution which avoids lowering dbg.declare for structures. Please check updated patch. Note, I marked two tests as XFAIL since they check for lowering which is not done with this patch. Though it looks to me that it would be better to make dbg.addr to work. I am thinking of changing LowerDbgDeclare in such a way that it would produce dbg.addr and dbg.value instead of dbg.value only. i.e. dbg.addr would be generated for cases when dbg.value with memory operand is generated currently...

Aug 16 2019, 9:58 AM · Restricted Project, debug-info

Aug 13 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Folks, I would like to ask a question related to this review and DWARF standard:

Aug 13 2019, 8:37 AM · lld, Restricted Project

Aug 8 2019

avl added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

NB, I haven't forgotten this (adding self as reviewer to keep track of it), but am out of office for a while. I think this hits a wider LLVM problem of values going in and out of memory (see discussion in [0] for example) and our ability to describe those circumstances.

[0] https://bugs.llvm.org/show_bug.cgi?id=34136

Aug 8 2019, 7:04 AM · Restricted Project, debug-info

Jul 22 2019

avl added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

Converting a dbg.value into a dbg.declare implicitly extends the duration ("lifetime" in the docs [0]) of the variable location from "until the next dbg.value" to "the entire scope". Consider what happens if we make the modifications here [1] to your test case. Imagine an IR producer that wants to temporarily bind some variable to a field of 'result' (the dbg.value added with DW_OP_deref), and later assigns '1' to the variable with the second dbg.value, to cover the rest of the function.

Jul 22 2019, 1:32 AM · Restricted Project, debug-info
avl updated the diff for D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

added check for aggregate dbg.value.

Jul 22 2019, 1:27 AM · Restricted Project, debug-info

Jul 16 2019

avl added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

@jmorse Thank you for this case and explanations. I will evaluate it more and adapt fix accordingly.

Jul 16 2019, 2:29 PM · Restricted Project, debug-info

Jul 15 2019

avl updated the diff for D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

addressed style issues. created empty expression for dbg.value case.

Jul 15 2019, 4:04 AM · Restricted Project, debug-info

Jul 12 2019

avl added inline comments to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Jul 12 2019, 6:15 AM · Restricted Project, debug-info

Jul 11 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Thank you, I apologize for impatience.

Jul 11 2019, 2:32 PM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I'm fine with this patch. We've discussed a lot about what is a desirable value for a "null" for debug info, but looks like as long as it does not appear as a valid address, it should be fine.

Is Eric fine with this?

Jul 11 2019, 2:17 PM · lld, Restricted Project
avl created D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..
Jul 11 2019, 2:02 PM · Restricted Project, debug-info

Jul 8 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Jul 8 2019, 8:06 AM · lld, Restricted Project

Jul 5 2019

avl updated the diff for D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

removed whitespaces, added handling x86 ILP32 case.

Jul 5 2019, 5:37 AM · lld, Restricted Project

Jul 4 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

error: Invalid address range [0xfffffffffffffffe, 0x0000000000000004)

DW_AT_low_pc DW_AT_high_pc pairs like these are less ideal. Before, tools have learned 0 address is special. They may or may not need a special case to handle this. Now, -2 is introduced (whatever value we choose here, GNU linkers still either relocate these to 0 or use their CB_PRETEND logic). They need to learn one more rule. I still believe, teaching the symbolizers (addr2line, llvm-symbolizer D60470) is the way forward.

Jul 4 2019, 11:44 PM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@jhenderson Thank you for pointing this out! Actually --verify complains about errors in both cases(with the fix and without the fix) for the testcase from this review:

Jul 4 2019, 10:43 AM · lld, Restricted Project

Jun 26 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@MaskRay Hi MaskRay, PRETEND is a connected but separate issue. I agree it would be good to implement some kind of the PRETEND/CB_PRETEND logic in lld. But it does not make obsolete this patch. implementing of PRETEND logic answers the question "how to select proper debug info for COMDAT section". That patch answers the question "How to avoid overlapping address ranges in case debug info referenced to deleted code presented". This patch makes sense not only for PRETEND. Thus, I do not agree with "If we have PRETEND, we will not need the -2 hack in relocateNonAlloc". Let`s not mixup issues.

Jun 26 2019, 3:16 AM · lld, Restricted Project

Jun 25 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping @echristo

Jun 25 2019, 2:03 AM · lld, Restricted Project

Jun 14 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@echristo Hi Eric, Could check this revision, please ? Is that patch Ok for you ?

Jun 14 2019, 2:10 PM · lld, Restricted Project

Jun 6 2019

avl committed rGb9f1e7b16ed2: [DebugInfo] Incorrect debug info record generated for loop counter. (authored by avl).
[DebugInfo] Incorrect debug info record generated for loop counter.
Jun 6 2019, 2:19 PM
avl committed rL362750: [DebugInfo] Incorrect debug info record generated for loop counter..
[DebugInfo] Incorrect debug info record generated for loop counter.
Jun 6 2019, 2:19 PM
avl closed D62650: [DebugInfo] DBG_VALUE instruction generated for loop counter is placed incorrectly..
Jun 6 2019, 2:19 PM · debug-info, Restricted Project

Jun 4 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@echristo What is your opinion on this patch ? Is it worth to integrate it ?

Jun 4 2019, 7:31 AM · lld, Restricted Project

Jun 3 2019

avl added a comment to D62650: [DebugInfo] DBG_VALUE instruction generated for loop counter is placed incorrectly..

following performance results with and without this patch. they are equal :

Jun 3 2019, 2:41 PM · debug-info, Restricted Project
avl updated the diff for D62650: [DebugInfo] DBG_VALUE instruction generated for loop counter is placed incorrectly..

restored dbg-addr-dse.ll.

Jun 3 2019, 2:35 PM · debug-info, Restricted Project
avl added a comment to D62650: [DebugInfo] DBG_VALUE instruction generated for loop counter is placed incorrectly..

Have you looked at the performance of the example posted in https://bugs.llvm.org/show_bug.cgi?id=33730 ?

Jun 3 2019, 9:59 AM · debug-info, Restricted Project

Jun 2 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping. @ruiu Do you think it would be useful to integrate this patch ?

Jun 2 2019, 11:59 PM · lld, Restricted Project
avl added inline comments to D62650: [DebugInfo] DBG_VALUE instruction generated for loop counter is placed incorrectly..
Jun 2 2019, 11:52 PM · debug-info, Restricted Project

May 31 2019

avl updated the diff for D62650: [DebugInfo] DBG_VALUE instruction generated for loop counter is placed incorrectly..

cleaned up tests.

May 31 2019, 3:10 AM · debug-info, Restricted Project

May 30 2019

avl created D62650: [DebugInfo] DBG_VALUE instruction generated for loop counter is placed incorrectly..
May 30 2019, 3:07 AM · debug-info, Restricted Project

May 27 2019

avl updated the diff for D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

deleted redundant tests.

May 27 2019, 4:08 AM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping.

May 27 2019, 4:08 AM · lld, Restricted Project
avl closed D62028: [DebugInfo][AArch64] Recognise target specific instruction as mov instr.
May 27 2019, 2:48 AM · Restricted Project

May 22 2019

avl committed rG53726588f672: [DebugInfo][AArch64] Recognise target specific instruction as mov instr (authored by avl).
[DebugInfo][AArch64] Recognise target specific instruction as mov instr
May 22 2019, 11:51 AM
avl committed rL361417: [DebugInfo][AArch64] Recognise target specific instruction as mov instr.
[DebugInfo][AArch64] Recognise target specific instruction as mov instr
May 22 2019, 11:46 AM

May 21 2019

avl updated the diff for D62028: [DebugInfo][AArch64] Recognise target specific instruction as mov instr.

deleted redundant check.

May 21 2019, 2:56 AM · Restricted Project

May 20 2019

avl updated the diff for D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

limit resolving relocations to UINT64_MAX-1 value for only debug sections, as requested.

May 20 2019, 9:47 AM · lld, Restricted Project
avl updated the diff for D62028: [DebugInfo][AArch64] Recognise target specific instruction as mov instr.

addressed comments: added check for WZR/XZR registers, changed test to run only LiveDebugValues pass.

May 20 2019, 8:15 AM · Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

In general it is not possible to handle zero case properly in lldb. It does not have information which address range is correct.
if platform allows section to contain code starting from zero then it is not possible to detect good and bad address range:

May 20 2019, 3:01 AM · lld, Restricted Project

May 17 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I do agree that this patching should be limited to debug sections though.
Other consumer sections might have other rules regarding special values etc, and be working on the assumption of patching to 0 is the best plan.

May 17 2019, 9:30 AM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

actually other DWARF consumers are not happy.

May 17 2019, 9:25 AM · lld, Restricted Project

May 16 2019

avl created D62028: [DebugInfo][AArch64] Recognise target specific instruction as mov instr.
May 16 2019, 1:27 PM · Restricted Project

May 12 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping

May 12 2019, 11:05 PM · lld, Restricted Project

May 7 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

You are the one who propose to change the status quo and use UINT64_MAX-1.
The burden of proof is on your side. You have the obligation to collect evidence from
approaches taken by various DWARF consumers to prove the newly introduced special value wouldn't cause problems

May 7 2019, 1:37 AM · lld, Restricted Project

May 6 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I've some previous discussions PR37212 PR37891 etc. -2 or -1 may be benign to some non-allocated sections like .debug.*, but may not be good to others.

May 6 2019, 9:31 AM · lld, Restricted Project

May 5 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping

May 5 2019, 10:34 PM · lld, Restricted Project

Apr 29 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Excuse me, I did not realize that those were questions. Please check my answers :

Apr 29 2019, 10:57 AM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping

Apr 29 2019, 2:13 AM · lld, Restricted Project

Apr 22 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I find a previous discussion at https://bugs.llvm.org/show_bug.cgi?id=37212 and https://reviews.llvm.org/D46502

Apr 22 2019, 7:25 AM · lld, Restricted Project

Apr 21 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping.

Apr 21 2019, 11:05 PM · lld, Restricted Project

Apr 15 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

Existing tools have learned various heuristics to avoid 0 DW_AT_low_pc collision, but I am not sure what they'd do if those relocations resolve to -1. llvm-symbolizer is certainly good (I have checked a few >examples - I'm learning it recently), but what about other tools?

Apr 15 2019, 11:26 PM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@ruiu What do you think about using UINT64_MAX-1 as address to which relocations for deleted sections would be resolved ? Does it make sense ?

Apr 15 2019, 10:50 PM · lld, Restricted Project
avl requested review of D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Apr 15 2019, 2:01 PM · lld, Restricted Project

Apr 12 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@MaskRay Hi, Since you changed status of review into "Needs Revision" - What changes do you think should be done ?

Apr 12 2019, 12:46 AM · lld, Restricted Project

Apr 10 2019

avl added inline comments to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Apr 10 2019, 3:20 AM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
In D59553#1459554, @avl wrote:
  1. on some platforms 0 is a valid address. i.e. image base starts from 0. In that case no way to differentiate valid address from invalid one just by checking for 0.

But this is also true to UINT64_MAX-2 because you can put your code or data there, no?

Apr 10 2019, 3:12 AM · lld, Restricted Project

Apr 9 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

__libc_csu_init is in libc.a(elf-init.o) and has no debug info. It should symbolize to ?? but not_used.cpp is incorrectly returned. ?? -> not_used.cpp

Apr 9 2019, 12:32 PM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I'm not sure if making zero DW_AT_low_pc special for executable/DSO in DWARFDebugAranges is a good idea.

Apr 9 2019, 4:33 AM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I think the current handling in lld is quite good, no need to special case on if (!Sym.getOutputSection()). The same problem can be reproduced for ld.bfd and gold.

Apr 9 2019, 4:09 AM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

I thought that address 0 is a good candidate to represent an invalid address, as nullptr is usually represented by address 0. I wonder why we want to use UINT64_MAX-2 instead of 0.

Apr 9 2019, 4:00 AM · lld, Restricted Project

Apr 8 2019

avl added inline comments to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Apr 8 2019, 11:55 PM · lld, Restricted Project
avl added inline comments to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Apr 8 2019, 11:42 PM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping

Apr 8 2019, 11:19 PM · lld, Restricted Project

Apr 3 2019

avl added a comment to D54747: Discard debuginfo for object files empty after GC.

@rocallahan Would you mind to share the performance results of that patch, please ? Similar to above table for rusoto test, but with timings ...

Apr 3 2019, 4:46 AM · Restricted Project, lld

Apr 2 2019

avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping.

Apr 2 2019, 11:10 PM · lld, Restricted Project

Mar 29 2019

avl updated the diff for D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

added indentation and corrected sections string.

Mar 29 2019, 4:58 AM · lld, Restricted Project

Mar 28 2019

avl updated the diff for D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

addressed all comments, except indentation one, which I did not understand yet.

Mar 28 2019, 11:35 AM · lld, Restricted Project
avl added inline comments to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Mar 28 2019, 10:27 AM · lld, Restricted Project
avl updated the diff for D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

addressed all comments.

Mar 28 2019, 9:27 AM · lld, Restricted Project
avl added inline comments to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.
Mar 28 2019, 6:35 AM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

@probinson

I think at this point the "debug info cabal" is more in favor of fragmenting the DWARF emitted by the compiler, so that it can be gc'd in tandem with the related functions.

Mar 28 2019, 5:31 AM · lld, Restricted Project
avl added a comment to D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used.

ping.

Mar 28 2019, 3:35 AM · lld, Restricted Project

Mar 25 2019

avl abandoned D58959: [DebugInfo][ExecutionEngine] follow up for "add SectionedAddress to DebugInfo interfaces".

abandon revision because of already integrated duplicated revision https://reviews.llvm.org/D59490

Mar 25 2019, 11:34 AM · Restricted Project