Page MenuHomePhabricator

avl (Alexey Lapshin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 17 2017, 6:34 AM (126 w, 2 d)

Recent Activity

Yesterday

avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

Anyway, it seems like you could do away with a fair amount of the complexity in this patch for handling guarding musttail forwarding by declaring them to be an "explicit FP use", since it is not, in general, possible for a perfectly forwarding thunk to know if XMM arguments have been used.

Fri, Jan 17, 11:49 AM · Restricted Project
avl added a child revision for D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part.: D72915: [Dsymutil][Debuginfo][NFC] #4 Refactor dsymutil to separate DWARF optimizing part..
Fri, Jan 17, 5:03 AM · debug-info, Restricted Project
avl added a parent revision for D72915: [Dsymutil][Debuginfo][NFC] #4 Refactor dsymutil to separate DWARF optimizing part.: D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part..
Fri, Jan 17, 5:03 AM · debug-info, Restricted Project
avl added a comment to D70709: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part..

abandon this revision, since it was split into several revisions : D71068, D71839, D72476, D72915.

Fri, Jan 17, 5:03 AM · Restricted Project, debug-info
avl abandoned D70709: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part..
Fri, Jan 17, 5:03 AM · Restricted Project, debug-info
avl added a project to D72915: [Dsymutil][Debuginfo][NFC] #4 Refactor dsymutil to separate DWARF optimizing part.: debug-info.
Fri, Jan 17, 4:54 AM · debug-info, Restricted Project
avl created D72915: [Dsymutil][Debuginfo][NFC] #4 Refactor dsymutil to separate DWARF optimizing part..
Fri, Jan 17, 4:54 AM · debug-info, Restricted Project

Wed, Jan 15

avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..
In D69372#1820845, @rnk wrote:
In D69372#1820099, @avl wrote:
In D69372#1818166, @rnk wrote:

It should be possible to use musttail thunk with a prototype of void (int, ...) between the call to foo and bar.

if I correctly understood the example - such a situation should not occur.
My understanding is that musttail thunk and it`s target _must_ have identical signatures.

The third point under musttail is meant to create an exception for for perfectly forwarding thunks: https://llvm.org/docs/LangRef.html#id325

If the musttail call appears in a function with the "thunk" attribute and the caller and callee both have varargs, than any unprototyped arguments in register or memory are forwarded to the callee. Similarly, the return value of the callee is returned to the caller’s caller, even if a void return type is in use.

In retrospect, I think it may have been a mistake to repurpose varargs to indicate that all remaining argument registers should be preserved. Maybe we don't need to use a varargs function prototype to implement perfectly forwarding thunks. We ended up needing the "thunk" function attribute, so we could base it on that instead.

Wed, Jan 15, 10:12 AM · Restricted Project

Tue, Jan 14

avl added inline comments to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..
Tue, Jan 14, 10:51 AM · Restricted Project
avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..
In D69372#1818166, @rnk wrote:

For the noimplicitfloat mode, the compiler mustn't generate
floating-point code if it was not asked directly to do so.

I don't think checking AL on function entry will work reliably. In general, musttail is meant to forward all possible register parameters. Normal arguments may be passed in XMM registers without setting AL. Consider this code:

typedef float v4f32 __attribute__((__vector_size__(16), __aligned__(16)));
int gv_i32;
v4f32 gv_v4f32;
void bar(int x, v4f32 v) {
  gv_i32 = x;
  gv_v4f32 = v;
}
void foo() {
  v4f32 v = {};
  bar(42, v);
}

It should be possible to use musttail thunk with a prototype of void (int, ...) between the call to foo and bar.

Tue, Jan 14, 10:42 AM · Restricted Project

Mon, Jan 13

avl committed rGf163755eb0a8: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing… (authored by avl).
[Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing…
Mon, Jan 13, 12:38 PM
avl closed D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part..
Mon, Jan 13, 12:37 PM · debug-info, Restricted Project
avl added a comment to D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part..

Thanks!

Mon, Jan 13, 10:16 AM · debug-info, Restricted Project
avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

ping.

Mon, Jan 13, 6:07 AM · Restricted Project

Sun, Jan 12

avl added a comment to D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part..

style issues reported by clang-tidy this time does not relate to my patch.

Sun, Jan 12, 3:00 AM · debug-info, Restricted Project

Sat, Jan 11

avl updated the diff for D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part..

apply clang-tidy findings.

Sat, Jan 11, 2:05 PM · debug-info, Restricted Project

Thu, Jan 9

avl added a project to D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part.: debug-info.
Thu, Jan 9, 11:01 PM · debug-info, Restricted Project
avl added a child revision for D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2.: D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part..
Thu, Jan 9, 12:54 PM · debug-info, Restricted Project
avl added a parent revision for D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part.: D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..
Thu, Jan 9, 12:54 PM · debug-info, Restricted Project
avl created D72476: [Dsymutil][Debuginfo][NFC] #3 Refactor dsymutil to separate DWARF optimizing part..
Thu, Jan 9, 12:44 PM · debug-info, Restricted Project

Wed, Jan 8

avl committed rG1cf11a4c67a1: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF… (authored by avl).
[Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF…
Wed, Jan 8, 3:21 AM
avl closed D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..
Wed, Jan 8, 3:21 AM · debug-info, Restricted Project

Tue, Jan 7

avl updated the summary of D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..
Tue, Jan 7, 6:18 AM · debug-info, Restricted Project
avl updated the diff for D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..

apply clang-tidy/clang-format changes.

Tue, Jan 7, 5:13 AM · debug-info, Restricted Project

Mon, Jan 6

avl added inline comments to D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..
Mon, Jan 6, 12:05 PM · debug-info, Restricted Project
avl updated the diff for D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..

addressed comments:

Mon, Jan 6, 11:45 AM · debug-info, Restricted Project
avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

Colleagues, any comments on this review?

Mon, Jan 6, 7:32 AM · Restricted Project

Sat, Jan 4

avl committed rG831bfcea4782: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory… (authored by avl).
[Transforms][GlobalSRA] huge array causes long compilation time and huge memory…
Sat, Jan 4, 5:43 AM
avl closed D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage..
Sat, Jan 4, 5:42 AM · Restricted Project

Fri, Jan 3

avl added a comment to D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage..

lgtm with a small suggestion

Fri, Jan 3, 2:08 PM · Restricted Project
avl updated the diff for D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage..

addressed comments(enumerate usages and create replacement variables for only used elements).

Fri, Jan 3, 5:49 AM · Restricted Project
avl added a comment to D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..
My personal preference goes to lib/DWARFLinker.
Fri, Jan 3, 3:18 AM · debug-info, Restricted Project

Mon, Dec 30

avl added a comment to D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage..

I started from the implementation similar to above description. But later I decided to avoid global SRA for big arrays, since big array with small number of usages is kind of artificial case. It is probably not worth to care about it too much. But, since that implementation was requested - I will update this patch with alternative implementation navigating through the usages and not-creating huge number of unused variables...

Mon, Dec 30, 12:15 PM · Restricted Project
avl added inline comments to D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage..
Mon, Dec 30, 6:57 AM · Restricted Project
avl added a comment to D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage..

above two failures do not relate to my fix. Patch which introduced them is already reverted : https://reviews.llvm.org/rG32cc14100e802fddd9f88e7a862250ce3108a583

Mon, Dec 30, 6:20 AM · Restricted Project
avl created D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage..
Mon, Dec 30, 3:48 AM · Restricted Project
avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

ping

Mon, Dec 30, 3:09 AM · Restricted Project
avl added a comment to D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..

ping.

Mon, Dec 30, 3:09 AM · debug-info, Restricted Project

Tue, Dec 24

avl added a comment to D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..

Not sure if this is better/worse off as a subdirectory of lib/CodeGen, rather than as a top level library on its own (lib/DWARFOptimizer). Figured I'd mention it, but mostly leave it up to the other dsymutil folks to make the choices here.

Tue, Dec 24, 3:01 AM · debug-info, Restricted Project

Mon, Dec 23

avl created D71839: [Dsymutil][Debuginfo][NFC] Reland: Refactor dsymutil to separate DWARF optimizing part. #2..
Mon, Dec 23, 6:21 AM · debug-info, Restricted Project

Dec 19 2019

avl committed rGabc7f6800df8: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part… (authored by avl).
[Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part…
Dec 19 2019, 4:50 AM
avl closed D71271: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part. #2..
Dec 19 2019, 4:49 AM · debug-info, Restricted Project

Dec 18 2019

avl updated the diff for D71271: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part. #2..

addressed comments.

Dec 18 2019, 5:08 AM · debug-info, Restricted Project

Dec 17 2019

avl added inline comments to D71271: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part. #2..
Dec 17 2019, 12:54 PM · debug-info, Restricted Project

Dec 16 2019

avl added a comment to D71271: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part. #2..

ping.

Dec 16 2019, 3:06 AM · debug-info, Restricted Project
avl updated the diff for D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

rebased. ping.

Dec 16 2019, 3:06 AM · Restricted Project

Dec 13 2019

avl added a reviewer for D69372: [X86][VARARG] Avoid spilling xmm vararg arguments.: qcolombet.
Dec 13 2019, 2:07 AM · Restricted Project

Dec 12 2019

avl updated the summary of D71271: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part. #2..
Dec 12 2019, 12:53 AM · debug-info, Restricted Project
avl committed rG71aaebc82468: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have… (authored by avl).
[DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have…
Dec 12 2019, 12:07 AM
avl closed D71244: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have children..
Dec 12 2019, 12:07 AM · Restricted Project, debug-info

Dec 11 2019

avl updated the diff for D71244: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have children..

addressed comments(changed test, used an asm test)

Dec 11 2019, 2:00 PM · Restricted Project, debug-info
avl updated the diff for D71244: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have children..

addressed comments(removed clang part, reworked testcase).

Dec 11 2019, 4:55 AM · Restricted Project, debug-info
avl committed rG21bc8958668a: [DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be false. (authored by avl).
[DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be false.
Dec 11 2019, 1:20 AM
avl closed D71304: [DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be false..
Dec 11 2019, 1:20 AM · Restricted Project, debug-info, Restricted Project

Dec 10 2019

avl created D71304: [DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be false..
Dec 10 2019, 2:18 PM · Restricted Project, debug-info, Restricted Project
avl added inline comments to D71244: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have children..
Dec 10 2019, 12:28 PM · Restricted Project, debug-info
avl created D71271: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part. #2..
Dec 10 2019, 7:33 AM · debug-info, Restricted Project
avl created D71244: [DWARF5][DWARFVerifier] Check that Skeleton compilation unit does not have children..
Dec 10 2019, 2:32 AM · Restricted Project, debug-info

Dec 9 2019

avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

ping.

Dec 9 2019, 3:15 AM · Restricted Project

Dec 6 2019

avl added a comment to D71113: Recover shared libs build after 9e8c799e2b0dc3e3b20f5044309fa8e48e8e3e32.

Hi @nemanjai I has recently integrated the fix for that problem https://reviews.llvm.org/rG8c714c93023d7d039a23fb47c8256570ba54b9c7 . I am sorry for inconvenience.

Dec 6 2019, 6:01 AM · Restricted Project
avl added a comment to D71068: [Dsymutil][NFC] Move NonRelocatableStringpool into common CodeGen folder..

I integrated the fix which cures building of shared libraries - https://reviews.llvm.org/rG8c714c93023d7d039a23fb47c8256570ba54b9c7 . I would additionally check whether it is working now for all above settings. Thank you.

Dec 6 2019, 6:01 AM · debug-info, Restricted Project
avl committed rG8c714c93023d: Fix building shared libraries broken by 8e48e8e3e32. (authored by avl).
Fix building shared libraries broken by 8e48e8e3e32.
Dec 6 2019, 5:52 AM
avl added a comment to D71068: [Dsymutil][NFC] Move NonRelocatableStringpool into common CodeGen folder..

@gchatelet This patch seems to break my build:

Dec 6 2019, 3:43 AM · debug-info, Restricted Project

Dec 5 2019

avl committed rG9e8c799e2b0d: [Dsymutil][NFC] Move NonRelocatableStringpool into common CodeGen folder. (authored by avl).
[Dsymutil][NFC] Move NonRelocatableStringpool into common CodeGen folder.
Dec 5 2019, 11:11 PM
avl closed D71068: [Dsymutil][NFC] Move NonRelocatableStringpool into common CodeGen folder..
Dec 5 2019, 11:11 PM · debug-info, Restricted Project
avl created D71068: [Dsymutil][NFC] Move NonRelocatableStringpool into common CodeGen folder..
Dec 5 2019, 8:09 AM · debug-info, Restricted Project

Dec 4 2019

avl committed rG789e257ce0d8: [DWARF5][Debuginfo] Compilation unit type (DW_UT_skeleton) and root DIE… (authored by avl).
[DWARF5][Debuginfo] Compilation unit type (DW_UT_skeleton) and root DIE…
Dec 4 2019, 2:01 PM
avl closed D70880: [DWARF5][Debuginfo] Not matching compilation unit type (DW_UT_skeleton) and root DIE (DW_TAG_compile_unit) .
Dec 4 2019, 2:00 PM · debug-info, Restricted Project
avl added a comment to D70709: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part..

The modules build is good because it's kind of a special case, but I'd like to check a clang without modules as well. I'm a little confused by LLVM_USE_SPLIT_DWARF though, as that's not something that makes sense on macOS unless it's a NO-OP?

Dec 4 2019, 1:22 PM · Restricted Project, debug-info
avl updated the diff for D70880: [DWARF5][Debuginfo] Not matching compilation unit type (DW_UT_skeleton) and root DIE (DW_TAG_compile_unit) .

addressed comments.

Dec 4 2019, 5:57 AM · debug-info, Restricted Project

Dec 3 2019

avl added a comment to D70880: [DWARF5][Debuginfo] Not matching compilation unit type (DW_UT_skeleton) and root DIE (DW_TAG_compile_unit) .

@avl - are you planning to do the DW_TAG_split_compile/DW_TAG_split_type tags required by DWARFv5 too in separate patches?

Dec 3 2019, 2:27 PM · debug-info, Restricted Project
avl added a comment to D70709: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part..

Given that this should NFC, can you please run dsymutil with and without your change on clang and ensure the MD5 hash is identical?

Dec 3 2019, 2:08 PM · Restricted Project, debug-info

Dec 2 2019

avl added a comment to D70879: [DWARF5][Debuginfo] Compilation unit type (DW_UT_skeleton) and root DIE (DW_TAG_compile_unit) do not match..

resubmitted this review - D70880

Dec 2 2019, 1:28 AM · debug-info, Restricted Project

Dec 1 2019

avl created D70880: [DWARF5][Debuginfo] Not matching compilation unit type (DW_UT_skeleton) and root DIE (DW_TAG_compile_unit) .
Dec 1 2019, 2:23 PM · debug-info, Restricted Project
avl abandoned D70879: [DWARF5][Debuginfo] Compilation unit type (DW_UT_skeleton) and root DIE (DW_TAG_compile_unit) do not match..
Dec 1 2019, 1:20 PM · debug-info, Restricted Project
avl created D70879: [DWARF5][Debuginfo] Compilation unit type (DW_UT_skeleton) and root DIE (DW_TAG_compile_unit) do not match..
Dec 1 2019, 11:46 AM · debug-info, Restricted Project

Nov 26 2019

avl added a comment to D36991: [x86] [MC] fixed no error diagnostic for out-of-range jrcxz/jecxz/jcxz (PR24072) .

Hi Konstantin, That review looked stuck for a long time.
I tried to keep all your original authority - ping original review,
waited for response for a week, added link to your review into the new review,
put your authority in the commit message.
Apologies for not waiting longer.

Nov 26 2019, 10:43 PM
avl added a comment to D36991: [x86] [MC] fixed no error diagnostic for out-of-range jrcxz/jecxz/jcxz (PR24072) .

Hi Konstantin, yes, I had in mind something like this. Unfortunately, I noticed your answer after D70652 was integrated : https://reviews.llvm.org/rGe73f78acd34360f7450b81167d9dc858ccddc262

Nov 26 2019, 7:48 AM
avl committed rGe73f78acd343: [X86][MC] no error diagnostic for out-of-range jrcxz/jecxz/jcxz (authored by avl).
[X86][MC] no error diagnostic for out-of-range jrcxz/jecxz/jcxz
Nov 26 2019, 3:39 AM
avl closed D70652: [X86][MC] no error diagnostic for out-of-range jrcxz/jecxz/jcxz.
Nov 26 2019, 3:39 AM · Restricted Project
avl created D70709: [Dsymutil][Debuginfo][NFC] Refactor dsymutil to separate DWARF optimizing part..
Nov 26 2019, 1:57 AM · Restricted Project, debug-info

Nov 25 2019

avl updated the diff for D70652: [X86][MC] no error diagnostic for out-of-range jrcxz/jecxz/jcxz.

addressed comment. applied clang-format. Thanks!

Nov 25 2019, 6:42 AM · Restricted Project

Nov 24 2019

avl created D70652: [X86][MC] no error diagnostic for out-of-range jrcxz/jecxz/jcxz.
Nov 24 2019, 10:18 PM · Restricted Project
avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

ping..

Nov 24 2019, 10:18 PM · Restricted Project
avl added a comment to D70548: [llvm-dwarfdump][Statistics] Unify coverage statistic computation.

@krisb the patch looks good to me. though I would prefer if someone from debuginfo project would approve it. Thank you.

Nov 24 2019, 10:08 PM · debug-info, Restricted Project

Nov 21 2019

avl committed rG7b957ddc981d: [Debuginfo][NFC] removes redundant semicolon. (authored by avl).
[Debuginfo][NFC] removes redundant semicolon.
Nov 21 2019, 5:22 AM

Nov 18 2019

avl added a comment to D36991: [x86] [MC] fixed no error diagnostic for out-of-range jrcxz/jecxz/jcxz (PR24072) .

@kbelochapka Hi Konstantin, I am not sure whether you are still waiting for that review ... But if that is the case, Would you consider following comments, please ?

Nov 18 2019, 3:41 AM

Nov 17 2019

avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

ping.

Nov 17 2019, 10:25 PM · Restricted Project

Nov 11 2019

avl updated the diff for D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

addressed comments(moved expansion of xmm registers code until after register allocator).

Nov 11 2019, 4:52 AM · Restricted Project

Nov 7 2019

avl added a comment to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

Is it possible to avoid expanding VARARG_THUNK_SAVE_XMM_REGS until after register allocation? I would rather not make the liveness rules more complicated just for the sake of working around a limitation of fast regalloc.

Nov 7 2019, 2:04 AM · Restricted Project

Nov 6 2019

avl added a comment to D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition.

I'm not sure the bleakness is as much of a problem (but I didn't implement/don't personally use the statistics at all) - like all the other measures, this would be a relative one, not one where "100%" was a goal/meaningful (& the only reason to view it as a % would be to understand progress in a relative sense, I guess? Though measuring it on exactly the same code as an absolute value would be fine and represent progress too)

Nov 6 2019, 5:48 AM · debug-info, Restricted Project

Nov 5 2019

avl updated the diff for D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

fix small typo introduced by previous update.

Nov 5 2019, 3:16 AM · Restricted Project
avl updated the diff for D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..

removed formatting done by clang-format for X86ISelLowering.h. ping...

Nov 5 2019, 1:42 AM · Restricted Project

Nov 1 2019

avl added a comment to D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition.

What do you think?

Nov 1 2019, 6:01 AM · debug-info, Restricted Project
avl added a comment to D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition.

if you want a % one, "bytes covered by location lists" / "bytes of enclosing scopes" (counting each scope once for each variable within it - or doing the loc-list-intersects-with-enclosing-scope earlier & just tracking the relative numbers from that point).

Nov 1 2019, 5:02 AM · debug-info, Restricted Project

Oct 31 2019

avl added a comment to D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition.

I see the primary value of this statistic to allow us to see change — then a human has to make judgement what that change means.

Oct 31 2019, 5:47 AM · debug-info, Restricted Project

Oct 29 2019

avl added a comment to D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition.

Doesn't the absolute number of covered bytes (i.e. ScopeBytesCovered) suite this purpose? Yes, we will see no change in coverage, but the absolute number will be changed from 14 to 97 bytes, which may be considered as an improvement. Does it make sense to you?

Oct 29 2019, 5:03 PM · debug-info, Restricted Project
avl added a comment to D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition.

I'm not sure this answers the question which was about your statement: "The end of the variable's address ranges should also be encountered."

Oct 29 2019, 4:30 PM · debug-info, Restricted Project

Oct 28 2019

avl added a comment to D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition.

I have my patch based on two assumptions:

We only care about lexically (or statically) scoped languages. Otherwise detecting a variable's scope is very problematic.
In a lexically scoped language the end of a variable's scope should match the end of the enclosing lexical scope.

That's why I a bit confused about why would we need to make some adjustments to the end of a range. Could you kindly clarify what did you mean?

Oct 28 2019, 8:03 AM · debug-info, Restricted Project

Oct 24 2019

avl added inline comments to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..
Oct 24 2019, 10:21 AM · Restricted Project