- User Since
- Dec 17 2012, 10:03 AM (357 w, 9 h)
Thanks for the quick review @arsenm!
Fri, Oct 18
Thu, Oct 17
- Replace some unsigned into Register
This was just a patch to illustrate a possible direction.
Wed, Oct 16
- Remove asserts already covered by the verifier
- Put .getType calls into a variable.
- Replace check with an assertion
- Update comments with pre-conditions
- Use ArrayRef instead of const SmallVectorImpl&
- Add tests with pointer types.
Fri, Oct 11
Mon, Oct 7
Sep 19 2019
Sep 17 2019
Sep 12 2019
Sep 11 2019
Sep 6 2019
The swifterror test change in this patch is one example. Live ranges over function calls can be problematic if under register pressure, which can cause additional moves, if not spills. There are others of course
I don't think this patch is correct in the sense that having statepoints depend on GreedyRegAlloc is a non-starter.
Indeed, that means that now any configuration that doesn't use greedy reg alloc (like fast or basic reg alloc) will generate incorrect code with respect to state point spilling.
Sep 4 2019
Suggestion of a small refactoring below.
Aug 20 2019
Aug 19 2019
Aug 16 2019
Aug 13 2019
LGTM with a test case.
LGTM for the generic part.
Aug 1 2019
Jul 19 2019
Jul 8 2019
It was added by D46315
Remove loop entirely. Ultimately determineCalleeSaves adds everything from MCRegAliasIterator anyway
Jul 5 2019
Let's go with that for now with one caveat. Does the code build without ANDGPU?
I.e., does the callingconv enum get generated?
Jul 3 2019
Jul 2 2019
General direction LGTM but there's a bug in the current patch unless I am mistaken.
Jun 19 2019
I second Daniel's comment, this is RegBankSelect's job to do this choice and the Legalizer shouldn't need to know about f64 vs. s64.
Maybe adding an MCRegister that's nearly identical might be a future improvement? That way it could enforce MCRegister->Register is OK, but Register->MCRegister is not
Jun 18 2019
Thanks for doing this Matt, this is a long due clean-up.
I haven't looked carefully at all the changes, but the general direction LGTM.
Jun 17 2019
Those rules work when there's a load/store for every type but they run into unable-to-legalize if that's not the case.
Jun 14 2019
LGTM modulo want @paquette pointed out.
Jun 13 2019
Jun 12 2019
Agree, the fix is more important than the performance loss at this point.
Jun 5 2019
Jun 3 2019
May 30 2019
What is the use case for this?
May 28 2019
May 27 2019
Nitpicks on the test below.
May 24 2019
May 16 2019
Please provide us with more details about your idea.
May 14 2019
May 13 2019
did anything like this come up in the past?
Looks good to me, modulo the order in which we check the hints.
May 8 2019
May 3 2019
@Quentin: This has the same common-code change as in D58923, with the added VRM to foldMemoryOperand(). You seemed fine with this change, right?
LGTM. Nitpicks below.