Page MenuHomePhabricator

qcolombet (Quentin Colombet)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2012, 10:03 AM (339 w, 3 h)

Recent Activity

Fri, Jun 14

qcolombet accepted D63303: [GlobalISel][Localizer] Rewrite localizer to run in 2 phases, inter & intra block..

LGTM modulo want @paquette pointed out.

Fri, Jun 14, 11:03 AM · Restricted Project

Thu, Jun 13

qcolombet added inline comments to D63162: GlobalISel: Avoid producing Illegal copies in RegBankSelect.
Thu, Jun 13, 12:43 PM
qcolombet accepted D63162: GlobalISel: Avoid producing Illegal copies in RegBankSelect.

Nitpicks below.

Thu, Jun 13, 10:11 AM

Wed, Jun 12

qcolombet accepted D63173: RegBankSelect: Remove checks for invalid mappings.

Nitpicks below.

Wed, Jun 12, 3:35 PM
qcolombet accepted D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.

Agree, the fix is more important than the performance loss at this point.

Wed, Jun 12, 12:57 PM · Restricted Project

Wed, Jun 5

qcolombet added a comment to D60888: [SystemZ] Favor 3-address instructions during instruction selection..

Hi Jonas,

Wed, Jun 5, 1:35 PM
qcolombet accepted D62745: Factor out SelectionDAG's switch analysis and lowering into a separate component.

Hi Amara,

Wed, Jun 5, 1:28 PM · Restricted Project

Mon, Jun 3

qcolombet accepted D62552: Propagate fmf for setcc/select folds.

LGTM.

Mon, Jun 3, 11:25 AM · Restricted Project

Thu, May 30

qcolombet accepted D61702: MISched: Fix -misched-regpressure=0 if subreg liveness enabled.

Looks reasonable!

Thu, May 30, 9:43 AM
qcolombet added a comment to D62411: LiveIntervals: add LiveRange::findIndexesLiveAt function - return a list of SlotIndexes the LiveRange live at..

What is the use case for this?

Thu, May 30, 9:40 AM · Restricted Project
qcolombet requested changes to D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.
Thu, May 30, 9:31 AM · Restricted Project
qcolombet reopened D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.
Thu, May 30, 9:30 AM · Restricted Project

Tue, May 28

qcolombet committed rGa6f57ad2c9dc: [RegUsageInfoCollector] Don't mark as saved registers that don't have… (authored by qcolombet).
[RegUsageInfoCollector] Don't mark as saved registers that don't have…
Tue, May 28, 4:45 PM
qcolombet committed rL361901: [RegUsageInfoCollector] Don't mark as saved registers that don't have….
[RegUsageInfoCollector] Don't mark as saved registers that don't have…
Tue, May 28, 4:40 PM

Mon, May 27

qcolombet accepted D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.

LGTM.
Nitpicks on the test below.

Mon, May 27, 9:13 AM
qcolombet added a comment to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.

Hi Daniel,

Mon, May 27, 9:07 AM · Restricted Project

Fri, May 24

qcolombet added inline comments to D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.
Fri, May 24, 3:26 PM
qcolombet added inline comments to D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.
Fri, May 24, 2:56 PM
qcolombet added inline comments to D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.
Fri, May 24, 2:54 PM

May 16 2019

qcolombet added a comment to D61061: [MachineFunction] Base support for call site info tracking.
Please provide us with more details about your idea.
May 16 2019, 1:19 PM · debug-info

May 14 2019

qcolombet accepted D54367: RegAllocFast: Improve hinting heuristic.

LGTM

May 14 2019, 11:05 AM · Restricted Project

May 13 2019

qcolombet added a comment to D61061: [MachineFunction] Base support for call site info tracking.
did anything like this come up in the past?
May 13 2019, 1:04 PM · debug-info
qcolombet accepted D61852: [IRTranslator] Don't hardcode GEP index type.

LGTM

May 13 2019, 1:01 PM · Restricted Project
qcolombet added a comment to D54367: RegAllocFast: Improve hinting heuristic.

Looks good to me, modulo the order in which we check the hints.

May 13 2019, 8:26 AM · Restricted Project

May 8 2019

qcolombet committed rG157427245a19: [RegAllocFast] Scan physcial reg definitions before assigning virtual reg… (authored by qcolombet).
[RegAllocFast] Scan physcial reg definitions before assigning virtual reg…
May 8 2019, 11:29 AM
qcolombet committed rL360278: [RegAllocFast] Scan physcial reg definitions before assigning virtual reg….
[RegAllocFast] Scan physcial reg definitions before assigning virtual reg…
May 8 2019, 11:28 AM

May 3 2019

qcolombet added a comment to D60888: [SystemZ] Favor 3-address instructions during instruction selection..

@Quentin: This has the same common-code change as in D58923, with the added VRM to foldMemoryOperand(). You seemed fine with this change, right?

May 3 2019, 9:03 AM
qcolombet added inline comments to D61489: RegAlloc: try to fail more gracefully when out of registers.
May 3 2019, 8:57 AM · Restricted Project
qcolombet accepted D54366: RegAllocFast: Add heuristic to detect values not live-out of a block.

LGTM. Nitpicks below.

May 3 2019, 8:50 AM · Restricted Project

May 2 2019

qcolombet committed rGc9256cc6ba93: [IRTranslator] Use the alloc size instead of the store size when translating… (authored by qcolombet).
[IRTranslator] Use the alloc size instead of the store size when translating…
May 2 2019, 6:23 PM
qcolombet committed rL359856: [IRTranslator] Use the alloc size instead of the store size when translating….
[IRTranslator] Use the alloc size instead of the store size when translating…
May 2 2019, 6:23 PM

Apr 29 2019

qcolombet committed rG2d977935a298: [llvm-extract] Expose the group extraction feature of the BlockExtractor (authored by qcolombet).
[llvm-extract] Expose the group extraction feature of the BlockExtractor
Apr 29 2019, 9:15 AM
qcolombet committed rG31ce274207fd: [BlockExtractor] Expose a constructor for the group extraction (authored by qcolombet).
[BlockExtractor] Expose a constructor for the group extraction
Apr 29 2019, 9:15 AM
qcolombet committed rGae2cbb34007d: [BlockExtractor] Change the basic block separator from ',' to ';' (authored by qcolombet).
[BlockExtractor] Change the basic block separator from ',' to ';'
Apr 29 2019, 9:15 AM
qcolombet committed rL359464: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
[llvm-extract] Expose the group extraction feature of the BlockExtractor
Apr 29 2019, 9:14 AM
qcolombet closed D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
Apr 29 2019, 9:14 AM · Restricted Project
qcolombet committed rL359463: [BlockExtractor] Expose a constructor for the group extraction.
[BlockExtractor] Expose a constructor for the group extraction
Apr 29 2019, 9:14 AM
qcolombet closed D60971: [BlockExtractor] Expose a constructor for the group extraction.
Apr 29 2019, 9:14 AM · Restricted Project
qcolombet committed rL359462: [BlockExtractor] Change the basic block separator from ',' to ';'.
[BlockExtractor] Change the basic block separator from ',' to ';'
Apr 29 2019, 9:14 AM
qcolombet closed D60970: [BlockExtractor] Change the basic block separator from ',' to ';'.
Apr 29 2019, 9:14 AM · Restricted Project

Apr 22 2019

qcolombet added a parent revision for D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor: D60970: [BlockExtractor] Change the basic block separator from ',' to ';'.
Apr 22 2019, 11:01 AM · Restricted Project
qcolombet added a child revision for D60970: [BlockExtractor] Change the basic block separator from ',' to ';': D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
Apr 22 2019, 11:01 AM · Restricted Project
qcolombet added a parent revision for D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor: D60971: [BlockExtractor] Expose a constructor for the group extraction.
Apr 22 2019, 10:57 AM · Restricted Project
qcolombet added a child revision for D60971: [BlockExtractor] Expose a constructor for the group extraction: D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
Apr 22 2019, 10:57 AM · Restricted Project
qcolombet created D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
Apr 22 2019, 10:57 AM · Restricted Project
qcolombet created D60971: [BlockExtractor] Expose a constructor for the group extraction.
Apr 22 2019, 10:57 AM · Restricted Project
qcolombet created D60970: [BlockExtractor] Change the basic block separator from ',' to ';'.
Apr 22 2019, 10:57 AM · Restricted Project

Apr 18 2019

qcolombet committed rGea3364bf85ef: [BlockExtractor] Extend the file format to support the grouping of basic blocks (authored by qcolombet).
[BlockExtractor] Extend the file format to support the grouping of basic blocks
Apr 18 2019, 11:27 AM
qcolombet committed rL358701: [BlockExtractor] Extend the file format to support the grouping of basic blocks.
[BlockExtractor] Extend the file format to support the grouping of basic blocks
Apr 18 2019, 11:27 AM
qcolombet closed D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.
Apr 18 2019, 11:26 AM · Restricted Project
qcolombet added a comment to D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.

Could you please update the summary before pushing this?

Apr 18 2019, 10:33 AM · Restricted Project
qcolombet updated the summary of D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.
Apr 18 2019, 10:33 AM · Restricted Project

Apr 16 2019

qcolombet updated the diff for D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.

Update:

  • Use comma separated list instead of group naming.
Apr 16 2019, 12:23 PM · Restricted Project
qcolombet added a comment to D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.

Hi Volkan,

Apr 16 2019, 11:24 AM · Restricted Project

Apr 15 2019

qcolombet committed rG474a9679bdf3: [CodeExtractor] Add a few debug lines to understand why a region is not… (authored by qcolombet).
[CodeExtractor] Add a few debug lines to understand why a region is not…
Apr 15 2019, 7:13 PM
qcolombet committed rL358471: [CodeExtractor] Add a few debug lines to understand why a region is not….
[CodeExtractor] Add a few debug lines to understand why a region is not…
Apr 15 2019, 7:12 PM
qcolombet created D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.
Apr 15 2019, 7:06 PM · Restricted Project
qcolombet committed rGfda042688860: [LSR] Rewrite misses some fixup locations if it splits critical edge (authored by qcolombet).
[LSR] Rewrite misses some fixup locations if it splits critical edge
Apr 15 2019, 3:28 PM
qcolombet committed rL358457: [LSR] Rewrite misses some fixup locations if it splits critical edge.
[LSR] Rewrite misses some fixup locations if it splits critical edge
Apr 15 2019, 3:28 PM
qcolombet closed D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..
Apr 15 2019, 3:28 PM · Restricted Project
qcolombet accepted D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..

Looks good!

Apr 15 2019, 2:23 PM · Restricted Project
qcolombet added a comment to D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..

The source change looks good to me, but I would like a bit more work on the test itself.

Apr 15 2019, 8:26 AM · Restricted Project

Apr 4 2019

qcolombet added a comment to D59626: [AMDGPU] Add MachineDCE pass after RenameIndependentSubregs.

Looks reasonable to me.

Apr 4 2019, 2:21 PM · Restricted Project
qcolombet added inline comments to D59626: [AMDGPU] Add MachineDCE pass after RenameIndependentSubregs.
Apr 4 2019, 10:57 AM · Restricted Project

Apr 3 2019

qcolombet added a comment to D59626: [AMDGPU] Add MachineDCE pass after RenameIndependentSubregs.

Are the dead instructions marked during the detect dead lanes pass or during the rename independent SubReg pass?

Apr 3 2019, 5:59 PM · Restricted Project
qcolombet added a comment to D58923: [SystemZ] Utilize Compare/Add/Sub "High" instructions.

The generic changes look sensible to me.
I would just suggest to add a comment on what VRM is for on the modified methods.

Apr 3 2019, 11:20 AM

Mar 27 2019

qcolombet committed rG89daf49e5c56: [PeepholeOpt] Don't stop simplifying copies on sequence of subregs (authored by qcolombet).
[PeepholeOpt] Don't stop simplifying copies on sequence of subregs
Mar 27 2019, 10:30 AM
qcolombet committed rL357095: [PeepholeOpt] Don't stop simplifying copies on sequence of subregs.
[PeepholeOpt] Don't stop simplifying copies on sequence of subregs
Mar 27 2019, 10:26 AM
qcolombet closed D59891: [PeepholeOpt] Don't stop simplifying copies on sequence of subregs.
Mar 27 2019, 10:26 AM · Restricted Project
qcolombet accepted D59892: [GlobalISel] Fix legalizer artifact combiner from crashing with invalid dead instructions.
Mar 27 2019, 10:25 AM · Restricted Project
qcolombet created D59891: [PeepholeOpt] Don't stop simplifying copies on sequence of subregs.
Mar 27 2019, 10:15 AM · Restricted Project
qcolombet accepted D59144: RegPressure: Fix crash on blocks with only dbg_value.
Mar 27 2019, 10:10 AM

Mar 26 2019

qcolombet committed rGc74271c53764: [LiveRange] Reset the VNIs when splitting subranges (authored by qcolombet).
[LiveRange] Reset the VNIs when splitting subranges
Mar 26 2019, 2:27 PM
qcolombet committed rL357032: [LiveRange] Reset the VNIs when splitting subranges.
[LiveRange] Reset the VNIs when splitting subranges
Mar 26 2019, 2:26 PM
qcolombet closed D59731: [LiveRange] Reset the VNIs when splitting subranges.
Mar 26 2019, 2:26 PM · Restricted Project

Mar 25 2019

qcolombet updated the diff for D59731: [LiveRange] Reset the VNIs when splitting subranges.

Fix seg fault with PHIs

Mar 25 2019, 10:54 AM · Restricted Project

Mar 22 2019

qcolombet created D59731: [LiveRange] Reset the VNIs when splitting subranges.
Mar 22 2019, 6:11 PM · Restricted Project

Mar 21 2019

qcolombet accepted D58758: GlobalISel: Fix RegBankSelect for REG_SEQUENCE.
Mar 21 2019, 11:19 AM

Mar 14 2019

qcolombet added a comment to D58758: GlobalISel: Fix RegBankSelect for REG_SEQUENCE.

All of this logic for reg_sequence and phi is totally broken for AMDGPU, so I might just end up ripping all of this out eventually.

Mar 14 2019, 4:24 PM
qcolombet added a comment to D59339: [GISel][Legalizer][WIP][RFC] Retry legalization for failing instrs when artifacts are around.

Hi Petr,

Mar 14 2019, 10:27 AM · Restricted Project

Mar 13 2019

qcolombet committed rGe77e5f44b871: [GlobalISel][Utils] Add a getConstantVRegVal variant that looks through instrs (authored by qcolombet).
[GlobalISel][Utils] Add a getConstantVRegVal variant that looks through instrs
Mar 13 2019, 6:39 PM
qcolombet committed rL356116: [GlobalISel][Utils] Add a getConstantVRegVal variant that looks through instrs.
[GlobalISel][Utils] Add a getConstantVRegVal variant that looks through instrs
Mar 13 2019, 6:39 PM
qcolombet closed D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.

Landed in r356116.

Mar 13 2019, 6:39 PM · Restricted Project
qcolombet accepted D59271: MIR: Allow targets to serialize MachineFunctionInfo.

Hi Matt,

Mar 13 2019, 4:32 PM
qcolombet added a comment to D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.

Prototyped a retry legalization process in D59339.
The problem is that this patch is still needed to access the constant, because the legalization artifacts combiner inserts copies instead of updating the users.

Mar 13 2019, 4:24 PM · Restricted Project
qcolombet created D59339: [GISel][Legalizer][WIP][RFC] Retry legalization for failing instrs when artifacts are around.
Mar 13 2019, 4:20 PM · Restricted Project
qcolombet added a comment to D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.

For operands that truly need to be constants that shouldn't be legalized, I don't think G_CONSTANT should be used. This is part of the motivation behind D58232 https://reviews.llvm.org/D58232. In SelectionDAG there is the TargetConstant vs. Constant distinction, but I think that makes less sense here, so weird constants should just never be materialized.

Mar 13 2019, 10:43 AM · Restricted Project
qcolombet added a comment to D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.

Disclaimer: this is just my opinion and in particular I haven't talked with anybody about constants being place holders. So just see my comment as what they are: an individual throwing ideas :).

Mar 13 2019, 10:40 AM · Restricted Project
qcolombet updated the diff for D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.

Update a mips test that I forgot.

Mar 13 2019, 10:04 AM · Restricted Project
qcolombet added a comment to D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.

Why wouldn't G_CONSTANT be legalized? This doesn't make any sense to me

Mar 13 2019, 9:55 AM · Restricted Project

Mar 12 2019

qcolombet updated the diff for D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.
  • Introduce a different variant of getConstantVRegVal instead of overriding the existing one (after talking to @aditya_nandakumar we decided we may want to have more control on what happens when we call this function).
  • Add a few comments.
Mar 12 2019, 4:47 PM · Restricted Project
qcolombet added a comment to D58725: GlobalISel: Use multiple returns for intrinsic structs.

Looks reasonable to me but I'd like @volkan and @aditya_nandakumar to see how it impacts us.

Mar 12 2019, 11:03 AM

Mar 11 2019

qcolombet added a comment to D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.

I'm going to hold on that one for a little longer.
I wonder how SDAG handle constant during legalization, because I was not expecting that we would not issue the constant for the new type period.
I suspect it works because constants are just not materialized via instructions and maybe we should just ignore them during legalization. (If a constant is illegal, at the end of the legalization process, it should have any users, right?)

Mar 11 2019, 2:49 PM · Restricted Project
qcolombet added a comment to D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.

Hi Matt,

Mar 11 2019, 12:51 PM · Restricted Project
qcolombet created D59227: [GlobalISel][Utils] Teach getConstantVRegVal how to look through trunc and z|sext.
Mar 11 2019, 12:15 PM · Restricted Project
qcolombet accepted D59201: [RegAllocHints] Avoid compile time regression.

LGTM.

Mar 11 2019, 11:37 AM

Mar 8 2019

qcolombet accepted D59143: [RegisterCoalescer] Limit the number of joins for large live interval with many valnos. .

Looks reasonable to me.

Mar 8 2019, 10:40 AM · Restricted Project

Feb 28 2019

qcolombet added a comment to D58758: GlobalISel: Fix RegBankSelect for REG_SEQUENCE.

Nice catch!

Feb 28 2019, 10:55 AM

Feb 25 2019

qcolombet added inline comments to D55287: VirtRegMap: Support partially allocated virtual registers.
Feb 25 2019, 9:43 AM
qcolombet added a comment to D55287: VirtRegMap: Support partially allocated virtual registers.

The LiveIntervals for the relevant regunits needs to be removed.

Feb 25 2019, 8:54 AM