Page MenuHomePhabricator

qcolombet (Quentin Colombet)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2012, 10:03 AM (545 w, 2 d)

Recent Activity

Today

qcolombet added a comment to D151423: [MachineInstr] Implement new operand accessors all_defs and all_uses.

@qcolombet I was planning to go back to the previous diff which used auto for the return types: https://reviews.llvm.org/D151423?vs=on&id=525565. Do you have a preference?

Thu, Jun 1, 9:16 AM · Restricted Project, Restricted Project
qcolombet added a comment to D145218: PHI-def LIveInterval's LaneMask can be calculated by subranges LaneMask when Reg has SubRanges..

Could you re-upload the patch with the full context please?

Thu, Jun 1, 6:47 AM · Restricted Project, Restricted Project
qcolombet accepted D151424: [CodeGen] Make use of MachineInstr::all_defs and all_uses. NFCI..

I like the improved readability.
Thanks!

Thu, Jun 1, 6:42 AM · Restricted Project, Restricted Project
qcolombet accepted D151423: [MachineInstr] Implement new operand accessors all_defs and all_uses.
Thu, Jun 1, 6:40 AM · Restricted Project, Restricted Project

Yesterday

qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

Ping, @nikic maybe?

Wed, May 31, 10:20 AM · Restricted Project, Restricted Project
qcolombet accepted D151617: A test case for the revision D151616.
Wed, May 31, 4:41 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
Wed, May 31, 3:18 AM · Restricted Project, Restricted Project

Fri, May 26

qcolombet added inline comments to D151338: [mlir][nvvm] Introduce `mbarrier.inval`.
Fri, May 26, 3:06 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D151334: [mlir][nvvm] Implement `mbarrier.init`.
Fri, May 26, 3:05 AM · Restricted Project, Restricted Project

Thu, May 25

qcolombet accepted D151447: [mlir] Enable folding memref alias for`vector.load`.

LGTM

Thu, May 25, 7:23 AM · Restricted Project, Restricted Project

Wed, May 24

qcolombet added a comment to D151227: RFC: LiveIntervalCalc: Always split separate components.

Right, it does complain about the LiveIntervals, but I thought that indicated that the LiveIntervals were not computed correctly, not that the underlying MIR was malformed.

Wed, May 24, 12:21 PM · Restricted Project, Restricted Project
qcolombet added a comment to D151227: RFC: LiveIntervalCalc: Always split separate components.

I need some help understanding the background here. Why does LiveIntervals::computeVirtRegs only call splitSeparateComponents if it detected dead defs in a live interval? Is this some artifact of the way MIR is typically constructed by instruction selection?

Wed, May 24, 5:54 AM · Restricted Project, Restricted Project
qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

I was hoping this patch could address my problem reported here: https://github.com/llvm/llvm-project/issues/62736
Sadly, it isn't. Maybe it's worth to extend it?

Let me take a look. Thanks for the pointer.

Hello @qcolombet

I'd like to kindly ask you whether you had a chance to look at it and to have any conclusions.

Wed, May 24, 1:44 AM · Restricted Project, Restricted Project

Mon, May 22

qcolombet accepted D150994: Bump coalescing limit.

Given what you observed and this limit is pretty much never hit in practice, I'm fine with bumping it.

Mon, May 22, 2:26 AM · Restricted Project, Restricted Project

Wed, May 17

qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

I was hoping this patch could address my problem reported here: https://github.com/llvm/llvm-project/issues/62736
Sadly, it isn't. Maybe it's worth to extend it?

Wed, May 17, 12:31 AM · Restricted Project, Restricted Project

Tue, May 16

qcolombet added a comment to D150605: LLT: Add some stub constructors for FP types.

On a second thought the ABI concerns are probably fine because we can get the information directly from the LLVM IR.

Tue, May 16, 2:24 AM · Restricted Project, Restricted Project
qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

Ping^5

Tue, May 16, 2:12 AM · Restricted Project, Restricted Project
qcolombet added a reviewer for D147457: [Reassociation] Only form CSE expressions for local operands: cameron.mcinally.
Tue, May 16, 2:11 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D148947: [MemRefToLLVM] Add a method in MemRefDescriptor to get the buffer addr.
Tue, May 16, 1:59 AM · Restricted Project, Restricted Project
qcolombet committed rGbba9209f1d19: [MemRefToLLVM][NFC] Use early exit for the getter of the buffer ptr (authored by qcolombet).
[MemRefToLLVM][NFC] Use early exit for the getter of the buffer ptr
Tue, May 16, 1:58 AM · Restricted Project, Restricted Project
qcolombet added a comment to D150605: LLT: Add some stub constructors for FP types.

I'm still wondering if somehow adding more semantic operands to FP operations would be less intrusive.

Tue, May 16, 1:00 AM · Restricted Project, Restricted Project
qcolombet committed rGc4a872badb53: FastRegAlloc: Fix implicit operands not rewritten (authored by gbossu).
FastRegAlloc: Fix implicit operands not rewritten
Tue, May 16, 12:57 AM · Restricted Project, Restricted Project
qcolombet closed D145169: FastRegAlloc: Fix implicit operands not rewritten.
Tue, May 16, 12:56 AM · Restricted Project, Restricted Project

Thu, May 11

qcolombet added a comment to D119916: Add a machine function pass to convert binop(phi(constants), v) to phi(binop) .

I can help get the patch reviewed if it is still relevant.
Just one high-level remark: the changes in the peephole optimizer should be a separate patch, right?

Thu, May 11, 2:53 PM · Restricted Project, Restricted Project
qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

Adding more reviews.

Thu, May 11, 2:41 PM · Restricted Project, Restricted Project
qcolombet added a reviewer for D147457: [Reassociation] Only form CSE expressions for local operands: craig.topper.
Thu, May 11, 2:41 PM · Restricted Project, Restricted Project
qcolombet added a comment to D145169: FastRegAlloc: Fix implicit operands not rewritten.

Sure!
I'll probably do that beginning of next week.

Thu, May 11, 2:39 PM · Restricted Project, Restricted Project
qcolombet added inline comments to D149801: [mlir][linalg] Add support for folding pack(fill) into fill..
Thu, May 11, 2:16 PM · Restricted Project, Restricted Project
qcolombet added inline comments to D149801: [mlir][linalg] Add support for folding pack(fill) into fill..
Thu, May 11, 2:09 PM · Restricted Project, Restricted Project

Mon, May 8

qcolombet committed rGad6700b520c7: [Transform] Support more case for the transform pad operation (authored by qcolombet).
[Transform] Support more case for the transform pad operation
Mon, May 8, 6:47 AM · Restricted Project, Restricted Project
qcolombet closed D150112: [Transform] Support more case for the transform pad operation.
Mon, May 8, 6:47 AM · Restricted Project, Restricted Project
qcolombet requested review of D150112: [Transform] Support more case for the transform pad operation.
Mon, May 8, 5:27 AM · Restricted Project, Restricted Project

Fri, May 5

qcolombet accepted D147079: InlineSpiller: Consider if all subranges are the same when avoiding redundant spills.
Fri, May 5, 7:10 AM · Restricted Project, Restricted Project
qcolombet accepted D145169: FastRegAlloc: Fix implicit operands not rewritten.
Fri, May 5, 7:04 AM · Restricted Project, Restricted Project
qcolombet accepted D149954: [RegisterCoalescer] Fix problem with IMPLICIT_DEF live-in to an invoke.

Thanks for the fix

Fri, May 5, 6:57 AM · Restricted Project, Restricted Project
qcolombet added a comment to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

Given the patch does not modify generic parts anymore, I'm happy with it.
I leave the final decision to @arsenm since AMDGPU is outside my domain of expertise.

Fri, May 5, 2:56 AM · Restricted Project, Restricted Project

May 2 2023

qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

Ping^4

May 2 2023, 2:08 AM · Restricted Project, Restricted Project
qcolombet added a reviewer for D147457: [Reassociation] Only form CSE expressions for local operands: nikic.
May 2 2023, 2:08 AM · Restricted Project, Restricted Project

Apr 25 2023

qcolombet committed rGe02d4142dca4: [MemRefToLLVM] Add a method in MemRefDescriptor to get the buffer addr (authored by qcolombet).
[MemRefToLLVM] Add a method in MemRefDescriptor to get the buffer addr
Apr 25 2023, 9:15 PM · Restricted Project, Restricted Project
qcolombet closed D148947: [MemRefToLLVM] Add a method in MemRefDescriptor to get the buffer addr.
Apr 25 2023, 9:14 PM · Restricted Project, Restricted Project
qcolombet committed rG68e1aef68e40: [MemRefToLLVM] Fix the lowering of memref.assume_alignment (authored by qcolombet).
[MemRefToLLVM] Fix the lowering of memref.assume_alignment
Apr 25 2023, 9:10 PM · Restricted Project, Restricted Project
qcolombet closed D148930: [MemRefToLLVM] Fix the lowering of memref.assume_alignment.
Apr 25 2023, 9:10 PM · Restricted Project, Restricted Project
qcolombet added inline comments to D148930: [MemRefToLLVM] Fix the lowering of memref.assume_alignment.
Apr 25 2023, 9:00 PM · Restricted Project, Restricted Project

Apr 24 2023

qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

Ping^3

Apr 24 2023, 9:16 PM · Restricted Project, Restricted Project

Apr 23 2023

qcolombet accepted D148845: [mlir][linalg] Add support for lowering pack with outer_dims_perm..

LGTM, please add a test for the lowering to "simple" pad.

Apr 23 2023, 5:12 AM · Restricted Project, Restricted Project

Apr 21 2023

qcolombet requested review of D148947: [MemRefToLLVM] Add a method in MemRefDescriptor to get the buffer addr.
Apr 21 2023, 11:30 AM · Restricted Project, Restricted Project
qcolombet accepted D148867: [mlir][linalg] Expose lowerPack and lowerUnPack utils..

LGTM

Apr 21 2023, 11:06 AM · Restricted Project, Restricted Project
qcolombet updated subscribers of D148930: [MemRefToLLVM] Fix the lowering of memref.assume_alignment.
Apr 21 2023, 9:55 AM · Restricted Project, Restricted Project
qcolombet requested review of D148930: [MemRefToLLVM] Fix the lowering of memref.assume_alignment.
Apr 21 2023, 8:41 AM · Restricted Project, Restricted Project

Apr 18 2023

qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

Ping^2

Apr 18 2023, 2:27 AM · Restricted Project, Restricted Project

Apr 13 2023

qcolombet added a comment to D143758: [CodeGen] MRI call back in TargetMachine.

Do we want to support MachineFunction/Info cloning?

This has to work and needs to be serializable.

Apr 13 2023, 10:14 AM · Restricted Project, Restricted Project
qcolombet committed rG0bfbecf52e8f: [mlir][TransformDialect] Simplify the lowering of pack/unpack when these are… (authored by qcolombet).
[mlir][TransformDialect] Simplify the lowering of pack/unpack when these are…
Apr 13 2023, 3:48 AM · Restricted Project, Restricted Project
qcolombet closed D148159: [mlir][TransformDialect] Simplify the lowering of pack/unpack when these are just pad/unpad.
Apr 13 2023, 3:47 AM · Restricted Project, Restricted Project
qcolombet accepted D148207: [mlir][Tensor] Drop SplitPaddingPatterns..
Apr 13 2023, 3:37 AM · Restricted Project, Restricted Project, Restricted Project
qcolombet accepted D148173: [mlir][Linalg] Fix hoist padding through scf.for iter_arg.
Apr 13 2023, 3:33 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D148173: [mlir][Linalg] Fix hoist padding through scf.for iter_arg.
Apr 13 2023, 3:24 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D148159: [mlir][TransformDialect] Simplify the lowering of pack/unpack when these are just pad/unpad.
Apr 13 2023, 2:37 AM · Restricted Project, Restricted Project
qcolombet updated the diff for D148159: [mlir][TransformDialect] Simplify the lowering of pack/unpack when these are just pad/unpad.
  • Use all_of and llvm::seq where appropriate
  • Use getMixedDimensions to future proof the code w.r.t. dynamic dimensions
  • Early-exit to avoid else indentation
Apr 13 2023, 2:35 AM · Restricted Project, Restricted Project
qcolombet added a comment to D148159: [mlir][TransformDialect] Simplify the lowering of pack/unpack when these are just pad/unpad.

Forgot to submit these comments!

Apr 13 2023, 1:12 AM · Restricted Project, Restricted Project
qcolombet accepted D148201: [mlir][Linalg] NFC - Extract an IndexingUtils from Linalg/Utils.
Apr 13 2023, 1:08 AM · Restricted Project, Restricted Project

Apr 12 2023

qcolombet requested review of D148159: [mlir][TransformDialect] Simplify the lowering of pack/unpack when these are just pad/unpad.
Apr 12 2023, 1:21 PM · Restricted Project, Restricted Project
qcolombet accepted D148125: [mlir][SCF] Add an scf.take_assumed_branch transform op..

LGTM

Apr 12 2023, 6:42 AM · Restricted Project, Restricted Project
qcolombet accepted D148095: [mlir][Linalg] Allow linalg.copy to be vectorized with masking.
Apr 12 2023, 4:58 AM · Restricted Project, Restricted Project

Apr 11 2023

qcolombet added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

Ping

Apr 11 2023, 7:50 AM · Restricted Project, Restricted Project

Apr 5 2023

qcolombet added inline comments to D146735: [CodeGen] Don't include aliases in RegisterClassInfo::IgnoreCSRForAllocOrder.
Apr 5 2023, 10:18 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D146735: [CodeGen] Don't include aliases in RegisterClassInfo::IgnoreCSRForAllocOrder.
Apr 5 2023, 9:15 AM · Restricted Project, Restricted Project

Apr 4 2023

qcolombet accepted D145252: RegAllocFast: Fix dropping subreg indexes on unassigned subreg defs.

Nice catch!

Apr 4 2023, 7:06 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D146734: [CodeGen] Use RegUnits in RegisterClassInfo::getLastCalleeSavedAlias.
Apr 4 2023, 6:50 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D146735: [CodeGen] Don't include aliases in RegisterClassInfo::IgnoreCSRForAllocOrder.
Apr 4 2023, 6:37 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D146734: [CodeGen] Use RegUnits in RegisterClassInfo::getLastCalleeSavedAlias.
Apr 4 2023, 6:16 AM · Restricted Project, Restricted Project
qcolombet added a comment to D143758: [CodeGen] MRI call back in TargetMachine.

Sorry for the delay I don't have an answer, but I have a couple of questions:

  1. Would it work to attach the delegate in MachineFunction::initTargetMachineFunctionInfo?
  2. Do we want to support MachineFunction/Info cloning?
Apr 4 2023, 5:52 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D145169: FastRegAlloc: Fix implicit operands not rewritten.
Apr 4 2023, 3:39 AM · Restricted Project, Restricted Project
qcolombet added a comment to D145218: PHI-def LIveInterval's LaneMask can be calculated by subranges LaneMask when Reg has SubRanges..

I don't think this is correct.
Here we are merging the main live-ranges, so if we set the join subrange flag we may not check the right thing. In particular, the LaneBitmask in this call is incorrect, unless I am mistaken, for a subrange check.

Apr 4 2023, 1:20 AM · Restricted Project, Restricted Project
qcolombet accepted D143753: [MachineInstr] Introduce TII buildCopy helper functions (NFC)..
Apr 4 2023, 12:44 AM · Restricted Project, Restricted Project

Apr 3 2023

qcolombet updated the summary of D147457: [Reassociation] Only form CSE expressions for local operands.
Apr 3 2023, 10:25 AM · Restricted Project, Restricted Project
qcolombet requested review of D147457: [Reassociation] Only form CSE expressions for local operands.
Apr 3 2023, 10:24 AM · Restricted Project, Restricted Project
qcolombet accepted D147393: [mlir][MemRef] Add pattern to resolve strided metadata of `memref.get_global` operation..

LGTM but I think we're missing a test for populateResolveExtractStridedMetadataPatterns.
@nicolasvasilache should we use transform dialect for the test?

Apr 3 2023, 5:21 AM · Restricted Project, Restricted Project

Mar 30 2023

qcolombet added a comment to D147060: [MachineSink] Fix an assertion failure in isCycleInvariant.

> I think the break statement cannot be removed, as it would crash if the last instruction is a debug instruction. Please correct me if I am missing something here.

Mar 30 2023, 9:21 AM · Restricted Project, Restricted Project

Mar 29 2023

qcolombet added inline comments to D146859: RegAllocGreedy: Fix detection of lanes read by a bundle.
Mar 29 2023, 2:20 AM · Restricted Project, Restricted Project

Mar 28 2023

qcolombet added inline comments to D146724: [mlir][MemRef] Add patterns to extract address computations.
Mar 28 2023, 6:24 AM · Restricted Project, Restricted Project
qcolombet committed rGfaafd26c4d58: [mlir][MemRef] Move transform related functions in Transforms.h (authored by qcolombet).
[mlir][MemRef] Move transform related functions in Transforms.h
Mar 28 2023, 6:23 AM · Restricted Project, Restricted Project
qcolombet committed rG54cda2ec976a: [mlir][MemRef] Add patterns to extract address computations (authored by qcolombet).
[mlir][MemRef] Add patterns to extract address computations
Mar 28 2023, 5:04 AM · Restricted Project, Restricted Project
qcolombet closed D146724: [mlir][MemRef] Add patterns to extract address computations.
Mar 28 2023, 5:04 AM · Restricted Project, Restricted Project
qcolombet updated the diff for D146724: [mlir][MemRef] Add patterns to extract address computations.
  • Fix bazel build
Mar 28 2023, 3:24 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D42600: [CodeGen][Shrink-wrap]split restore point.
Mar 28 2023, 2:15 AM · Restricted Project, Restricted Project
qcolombet added a comment to D42600: [CodeGen][Shrink-wrap]split restore point.

I only had a cursory look but the overall direction seems good.

Mar 28 2023, 2:11 AM · Restricted Project, Restricted Project

Mar 24 2023

qcolombet added inline comments to D146724: [mlir][MemRef] Add patterns to extract address computations.
Mar 24 2023, 9:12 AM · Restricted Project, Restricted Project
qcolombet updated the diff for D146724: [mlir][MemRef] Add patterns to extract address computations.
  • Remove the test pass
  • Add a tranform op instead
  • Add a comment for strides when creating the subview
  • Add a test for non-1 strides (only for vector.transfer_write, @nicolasvasilache let me know if you want more)
  • Report failures with notifyMatchFailure
Mar 24 2023, 9:10 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D146724: [mlir][MemRef] Add patterns to extract address computations.
Mar 24 2023, 6:20 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D146724: [mlir][MemRef] Add patterns to extract address computations.
Mar 24 2023, 4:00 AM · Restricted Project, Restricted Project
qcolombet updated the diff for D146724: [mlir][MemRef] Add patterns to extract address computations.
  • Add missing vector dialect dependency to the test-extract-address-computations pass
Mar 24 2023, 3:53 AM · Restricted Project, Restricted Project
qcolombet updated the diff for D146724: [mlir][MemRef] Add patterns to extract address computations.
  • Add support for vector.transfer_read/write
  • Move the populate function in its own header (we'll want to move others as well in an NFC patch)
  • Fix the dropping of the nontemporal flag (and add a test for that)
  • Refactor getSrcMemRef to not choke on tensor type
  • Refactor getViewSizeForEachDim to use the same implementation for ldmatrix, vector.transfer_read/write
  • Add tests for vector.transfer_read/write
Mar 24 2023, 3:47 AM · Restricted Project, Restricted Project

Mar 23 2023

qcolombet requested review of D146724: [mlir][MemRef] Add patterns to extract address computations.
Mar 23 2023, 7:52 AM · Restricted Project, Restricted Project
qcolombet committed rG0cbfd68af79f: [mlir] Fix call of overloaded ‘dropResults(<brace-enclosed initializer list>)’… (authored by qcolombet).
[mlir] Fix call of overloaded ‘dropResults(<brace-enclosed initializer list>)’…
Mar 23 2023, 4:46 AM · Restricted Project, Restricted Project

Mar 22 2023

qcolombet accepted D146611: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols.
Mar 22 2023, 2:59 AM · Restricted Project, Restricted Project

Mar 21 2023

qcolombet abandoned D145801: [MemRef][WIP] Rewrite address computation.

Abandoning that one for now. I think it would make sense to introduce some interface for this kind of rewriting.

Mar 21 2023, 4:35 AM · Restricted Project, Restricted Project

Mar 15 2023

qcolombet added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Mar 15 2023, 1:41 AM · Restricted Project, Restricted Project
qcolombet added inline comments to D131587: [CodeGen] Deduplicate restore blocks in branch relaxation.
Mar 15 2023, 1:34 AM · Restricted Project, Restricted Project
qcolombet accepted D146095: [mlir][Transform] NFC - Refactor forall mapping to threads and blocks into one thing.

Nice clean-up!

Mar 15 2023, 1:21 AM · Restricted Project, Restricted Project

Mar 14 2023

qcolombet added a comment to D145685: [mlir][Affine] Add helper functions to allow reordering affine.apply operands and decompose the ops into smaller components.

Food for thoughts:
Since the canonicalization is going to undo the decomposition, should we rewrite the expression (e.g., as part of the canonicalization) to the ordering we want?
The downside is we would still rely on the backend to do the hoisting of the loop invariant stuff.

Mar 14 2023, 3:40 AM · Restricted Project, Restricted Project