qcolombet (Quentin Colombet)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2012, 10:03 AM (239 w, 4 d)

Recent Activity

Yesterday

qcolombet added inline comments to D35730: RA: Remove assert on empty live intervals.
Fri, Jul 21, 6:37 PM
qcolombet added inline comments to D35730: RA: Remove assert on empty live intervals.
Fri, Jul 21, 6:09 PM
qcolombet added inline comments to D35730: RA: Remove assert on empty live intervals.
Fri, Jul 21, 6:06 PM
qcolombet added inline comments to D35730: RA: Remove assert on empty live intervals.
Fri, Jul 21, 6:00 PM
qcolombet added inline comments to D35730: RA: Remove assert on empty live intervals.
Fri, Jul 21, 5:54 PM
qcolombet added a comment to D35749: RA: Remove another assert on empty intervals.

Before removing all those assertions, could we talk that through first?
We started a conversion in D35730.

Fri, Jul 21, 5:54 PM
qcolombet added inline comments to D35730: RA: Remove assert on empty live intervals.
Fri, Jul 21, 5:38 PM
qcolombet added inline comments to D30751: [MachineCopyPropagation] Extend pass to do COPY source forwarding.
Fri, Jul 21, 2:48 PM
qcolombet added inline comments to D35730: RA: Remove assert on empty live intervals.
Fri, Jul 21, 1:51 PM

Thu, Jul 20

qcolombet added a comment to D35049: LSR tunings for SystemZ, with some minor common code changes.

BTW, my review does not include SystemZ changes ;)

Thu, Jul 20, 11:43 AM
qcolombet accepted D35049: LSR tunings for SystemZ, with some minor common code changes.

Hi Jonas,

Thu, Jul 20, 11:43 AM
qcolombet accepted D35446: Add an ID field to StackObjects.

LGTM

Thu, Jul 20, 11:29 AM

Fri, Jul 14

qcolombet added a comment to D30913: [NFC] Feature generic options to setup start/stop-after/before.

Hi Matthias,

Fri, Jul 14, 3:57 PM
qcolombet requested changes to D33935: Allow rematerialization of ARM Thumb MOVi8 instruction in some contexts.

Hi Philip,

Fri, Jul 14, 2:31 PM

Wed, Jul 12

qcolombet added inline comments to D35049: LSR tunings for SystemZ, with some minor common code changes.
Wed, Jul 12, 10:55 AM

Tue, Jul 11

qcolombet added a comment to D35049: LSR tunings for SystemZ, with some minor common code changes.

I see why second batch depends on this patch. I wonder if it should though.
Hence, do we rely guard that check with LSRWithInstrQueries?

Tue, Jul 11, 10:48 AM
qcolombet accepted D35262: Teach isAddressUse() in LoopStrengthReduce.cpp about memory intrinsics.

LGTM

Tue, Jul 11, 10:30 AM

Mon, Jul 10

qcolombet requested changes to D35049: LSR tunings for SystemZ, with some minor common code changes.

Hi Jonas,

Mon, Jul 10, 3:31 PM

Sun, Jul 9

qcolombet committed rL307427: [RegAllocFast] Add the proper initialize method to use the .mir infrastructure.
[RegAllocFast] Add the proper initialize method to use the .mir infrastructure
Sun, Jul 9, 6:17 AM
qcolombet committed rL307428: [RegAllocFast] Don't insert kill flags of super-register for partial kill.
[RegAllocFast] Don't insert kill flags of super-register for partial kill
Sun, Jul 9, 6:16 AM

Thu, Jul 6

qcolombet requested changes to D35055: [InlineSpiller] Only examine defs in BUNDLE instruction.
Thu, Jul 6, 2:04 PM

Wed, Jul 5

qcolombet committed rL307186: [AMDGPU] Move GISel accessor initialization from TargetMachine to Subtarget..
[AMDGPU] Move GISel accessor initialization from TargetMachine to Subtarget.
Wed, Jul 5, 11:41 AM
qcolombet accepted D34391: [RegisterCoalescer] Fix for SubRange join unreachable.

LGTM.

Wed, Jul 5, 10:08 AM
qcolombet accepted D34394: [MachineVerifier] Add check that tied physregs aren't different..
Wed, Jul 5, 10:07 AM

Fri, Jun 30

qcolombet committed rL306921: [X86] Move GISel accessor initialization from TargetMachine to Subtarget..
[X86] Move GISel accessor initialization from TargetMachine to Subtarget.
Fri, Jun 30, 5:46 PM
qcolombet committed rL306920: [ARM] Move GISel accessor initialization from TargetMachine to Subtarget..
[ARM] Move GISel accessor initialization from TargetMachine to Subtarget.
Fri, Jun 30, 5:46 PM
qcolombet added a comment to D34394: [MachineVerifier] Add check that tied physregs aren't different..

Could you add a .mir test case that exposes this verifier diagnostic? (In test/CodeGen/MIR then pick a target)

Fri, Jun 30, 3:41 PM
qcolombet accepted D34902: [RegisterCoalescer] Account for instructions deleted by removePartialredunduncy and in WorkList.

Nice findings!

Fri, Jun 30, 3:37 PM
qcolombet requested changes to D34608: [AArch64] Increase CSR cost when defering use of CSR is preferred.
Fri, Jun 30, 3:15 PM
qcolombet added a comment to D32201: [RALLOC] Increase CSR cost in RegAllocGreedy to favour splitting over CSR first use.

To be concrete here. I'd like to understand why we can have the regalloc to figure out what is the cost of splitting a CSR the first time (which is what it boils down to).

Fri, Jun 30, 2:24 PM
qcolombet requested changes to D32201: [RALLOC] Increase CSR cost in RegAllocGreedy to favour splitting over CSR first use.

I agree with Eric, the whole constant choice seems too magic to me.

Fri, Jun 30, 2:23 PM
qcolombet requested changes to D34458: [TTI] Refine the cost of EXT in getUserCost().
Fri, Jun 30, 2:16 PM

Tue, Jun 27

qcolombet added a comment to D31834: Remove unnecessary bitvector clear.

Although this is correct, I don't think that is useful. We could add functionalities to this pass that would make use of that information (e.g., a dump method that we could call from the debugger anywhere in the program) and having the state being clean, seems like a good thing to me.

Tue, Jun 27, 5:10 PM

Jun 20 2017

qcolombet added inline comments to D34394: [MachineVerifier] Add check that tied physregs aren't different..
Jun 20 2017, 10:08 AM
qcolombet requested changes to D34391: [RegisterCoalescer] Fix for SubRange join unreachable.
Jun 20 2017, 10:02 AM

Jun 12 2017

qcolombet added a comment to D32746: [globalisel][legalizer] G_LOAD/G_STORE NarrowScalar should not emit G_GEP x, 0..

The new helper looks good.
Nitpicks below.

Jun 12 2017, 5:04 PM

Jun 6 2017

qcolombet committed rL304850: [InlineSpiller] Only account for real spills in the hoisting logic.
[InlineSpiller] Only account for real spills in the hoisting logic
Jun 6 2017, 5:22 PM

Jun 5 2017

qcolombet committed rL304752: [InlineSpiller] Don't spill fully undef values.
[InlineSpiller] Don't spill fully undef values
Jun 5 2017, 4:52 PM
qcolombet requested changes to D33665: [GlobalISel][X86] Support vector type G_UNMERGE_VALUES selection..

Hi Igor,

Jun 5 2017, 11:26 AM
qcolombet accepted D33724: [GlobalISel] IRTranslator: Add MachineMemOperand to target memory intrinsics.

LGTM

Jun 5 2017, 11:13 AM
qcolombet accepted D33800: [SelectionDAG] Update the dominator after splitting critical edges.

LGTM.

Jun 5 2017, 11:06 AM
qcolombet accepted D30562: Add Instruction number to LSR cost model (PR23384) part 3 of 3.

Hi Evgeny,

Jun 5 2017, 11:05 AM
qcolombet accepted D33809: CodeGen: Refactor MIR parsing.

LGTM.
Nitpicks below

Jun 5 2017, 10:59 AM

Jun 2 2017

qcolombet added a comment to D33596: [globalisel][tablegen] Add support for EXTRACT_SUBREG..

Could you re-upload the patch without the diffs from https://reviews.llvm.org/D33590?

Jun 2 2017, 7:23 PM
qcolombet added inline comments to D33590: [globalisel][tablegen] Add support for COPY_TO_REGCLASS..
Jun 2 2017, 7:11 PM
qcolombet added a comment to D33590: [globalisel][tablegen] Add support for COPY_TO_REGCLASS..

Hi Daniel,

Jun 2 2017, 7:04 PM
qcolombet committed rL304615: [SystemZ] Simplify test case. NFC.
[SystemZ] Simplify test case. NFC
Jun 2 2017, 4:41 PM
qcolombet committed rL304608: Change code formatting to look like the surrounding code.
Change code formatting to look like the surrounding code
Jun 2 2017, 4:08 PM
qcolombet committed rL304603: [RABasic] Properly update the LiveRegMatrix when LR splitting occur.
[RABasic] Properly update the LiveRegMatrix when LR splitting occur
Jun 2 2017, 3:47 PM
qcolombet committed rL304602: [RABasic] Properly initialize the pass.
[RABasic] Properly initialize the pass
Jun 2 2017, 3:46 PM

Jun 1 2017

qcolombet added inline comments to D33800: [SelectionDAG] Update the dominator after splitting critical edges.
Jun 1 2017, 3:17 PM

May 30 2017

qcolombet accepted D33699: MachineInstr: Don't skip dead reg operands when printing..

LGTM

May 30 2017, 3:45 PM
qcolombet committed rL304244: [Localizer] Don't trick to be smart for the insertion point.
[Localizer] Don't trick to be smart for the insertion point
May 30 2017, 1:53 PM

May 26 2017

qcolombet committed rL304052: [AArch64][GlobalISel] Add the Localizer pass for the O0 pipeline.
[AArch64][GlobalISel] Add the Localizer pass for the O0 pipeline
May 26 2017, 6:34 PM
qcolombet committed rL304051: [GlobalISel] Add a localizer pass for target to use.
[GlobalISel] Add a localizer pass for target to use
May 26 2017, 6:34 PM
qcolombet added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

I like @sanjoy's suggestion.
@scanon Could you do the review? I would prefer if an expert can look at it.
Thanks

May 26 2017, 5:46 PM
qcolombet added inline comments to D30751: [MachineCopyPropagation] Extend pass to do COPY source forwarding.
May 26 2017, 5:45 PM

May 23 2017

qcolombet accepted D33408: MachineCSE: Respect interblock physreg liveness.
May 23 2017, 1:16 PM

May 19 2017

qcolombet added a comment to D31821: Remove redundant copy in recurrences.

Hi Taewook,

May 19 2017, 2:03 PM

May 18 2017

qcolombet added a comment to D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution.

Please follow @scanon recommendation.

May 18 2017, 12:18 PM
qcolombet accepted D32464: LivePhysRegs: Fix addLiveOutsNoPristines() for return blocks past PEI.

LGTM

May 18 2017, 12:03 PM
qcolombet accepted D33317: [GlobalISel] IRTranslator: Translate ConstantStruct.

LGTM with nitpicks

May 18 2017, 10:16 AM

May 17 2017

qcolombet committed rL303313: Revert "[globalisel][tablegen] Import rules containing intrinsic_wo_chain.".
Revert "[globalisel][tablegen] Import rules containing intrinsic_wo_chain."
May 17 2017, 4:31 PM
qcolombet accepted D33294: Only enable LiveRangeShrink for x86..

Thanks Dehao.
LGTM.

May 17 2017, 1:10 PM
qcolombet added a comment to D31821: Remove redundant copy in recurrences.
The problem doesn't appear while we're in SSA [...]
May 17 2017, 8:42 AM

May 16 2017

qcolombet accepted D33181: Don't allow -optimize-regalloc=false with -regalloc given for anything other than 'fast'.
May 16 2017, 1:39 PM

May 15 2017

qcolombet requested changes to D33181: Don't allow -optimize-regalloc=false with -regalloc given for anything other than 'fast'.
May 15 2017, 9:42 AM

May 12 2017

qcolombet accepted D33084: [GISel]: Fix undefined behavior while accessing DefaultAction map.
May 12 2017, 2:31 PM
qcolombet accepted D32746: [globalisel][legalizer] G_LOAD/G_STORE NarrowScalar should not emit G_GEP x, 0..

LGTM modulo a small refactoring to avoid code duplication.

May 12 2017, 2:15 PM
qcolombet accepted D32791: [globalisel][tablegen] Add support for (set $dst, 1) and test X86's OptForSize predicate..

LGTM, nitpick below

May 12 2017, 2:12 PM
qcolombet accepted D32861: [globalisel][tablegen] Demote OptForSize/OptForMinSize/ForCodeSize to per-function predicates..

LGTM

May 12 2017, 2:08 PM
qcolombet accepted D32278: [globalisel][tablegen] Import rules containing intrinsic_wo_chain..

LGTM

May 12 2017, 2:06 PM
qcolombet added inline comments to D32868: [globalisel][tablegen] Fix nullptr dereferences when getVRegDef() is called on a phys reg..
May 12 2017, 1:59 PM
qcolombet accepted D33144: [RegisterBankInfo] Remove overly-agressive asserts.

LGTM, nitpick below

May 12 2017, 12:58 PM
qcolombet accepted D33051: [GISel]: Add a getConstantFPVRegVal utility.

LGTM

May 12 2017, 12:05 PM
qcolombet added a comment to D33084: [GISel]: Fix undefined behavior while accessing DefaultAction map.

Hi Aditya,

May 12 2017, 12:04 PM
qcolombet requested changes to D33144: [RegisterBankInfo] Remove overly-agressive asserts.
May 12 2017, 11:59 AM
qcolombet accepted D32715: shrink-wrap: fix shrink-wrapping for no-return paths.

LGTM

May 12 2017, 11:31 AM

May 11 2017

qcolombet accepted D32869: [globalisel][tablegen] Require that all registers between instructions of a match are virtual..

Thanks for the clarification, now I get it :).

May 11 2017, 5:55 PM
qcolombet added a comment to D32869: [globalisel][tablegen] Require that all registers between instructions of a match are virtual..

Hi Daniel,

May 11 2017, 3:22 PM
qcolombet added a comment to D32868: [globalisel][tablegen] Fix nullptr dereferences when getVRegDef() is called on a phys reg..

Hi Daniel,

May 11 2017, 2:45 PM
qcolombet accepted D32304: Reduce printing values with default in MIR based codegen testing YAML.

LGTM

May 11 2017, 10:48 AM

May 10 2017

qcolombet committed rL302679: [AArch64][RegisterBankInfo] Change the default mapping of fp stores..
[AArch64][RegisterBankInfo] Change the default mapping of fp stores.
May 10 2017, 8:33 AM

May 9 2017

qcolombet added a comment to D32744: [globalisel] Improve legalizer DEBUG_ONLY output..

It does not sound to me like something we can ensure. I wouldn't pursue in that direction IMHO.

May 9 2017, 11:49 AM

May 8 2017

qcolombet committed rL302453: [AArch64][RegisterBankInfo] Change the default mapping of fp loads..
[AArch64][RegisterBankInfo] Change the default mapping of fp loads.
May 8 2017, 11:29 AM
qcolombet committed rL302452: [AArch64][RegisterBankInfo] Fix mapping cost for GPR..
[AArch64][RegisterBankInfo] Fix mapping cost for GPR.
May 8 2017, 11:29 AM
qcolombet added inline comments to D31262: MIParser/MIRPrinter: Compute block successors if not explicitely specified.
May 8 2017, 8:06 AM

May 5 2017

qcolombet committed rL302316: [RegisterBankInfo] Uniquely allocate instruction mapping..
[RegisterBankInfo] Uniquely allocate instruction mapping.
May 5 2017, 4:01 PM

May 4 2017

qcolombet committed rL302202: [RegisterBankInfo] Fix 80-col introduced in r293506..
[RegisterBankInfo] Fix 80-col introduced in r293506.
May 4 2017, 3:56 PM
qcolombet committed rL302201: [GlobalISel] Add missing doxygen keyword for doxygen groups..
[GlobalISel] Add missing doxygen keyword for doxygen groups.
May 4 2017, 3:56 PM
qcolombet added a comment to D32869: [globalisel][tablegen] Require that all registers between instructions of a match are virtual..

If that happens, doesn't that means we need to support it?

May 4 2017, 3:55 PM
qcolombet added inline comments to D32304: Reduce printing values with default in MIR based codegen testing YAML.
May 4 2017, 3:50 PM
qcolombet added a comment to D32744: [globalisel] Improve legalizer DEBUG_ONLY output..

Hi Daniel,

May 4 2017, 2:10 PM
qcolombet accepted D32575: Don't try to legalize Intermediate instructions (with generic types).

LGTM

May 4 2017, 2:04 PM
qcolombet accepted D32814: [GISel]: Add support to translate ConstantVectors.

LGTM

May 4 2017, 1:57 PM
qcolombet accepted D31262: MIParser/MIRPrinter: Compute block successors if not explicitely specified.

Thanks Matthias.

May 4 2017, 10:49 AM

May 1 2017

qcolombet committed rL301841: [AArch64] Move GISel accessor initialization from TargetMachine to Subtarget..
[AArch64] Move GISel accessor initialization from TargetMachine to Subtarget.
May 1 2017, 3:06 PM
qcolombet added inline comments to D32058: Add a section about simplifying .mir tests.
May 1 2017, 10:40 AM
qcolombet added inline comments to D32058: Add a section about simplifying .mir tests.
May 1 2017, 10:15 AM
qcolombet added a comment to D31262: MIParser/MIRPrinter: Compute block successors if not explicitely specified.

In a nutshell, I am saying that we shouldn't conflict two goals: editing and printing. Printing should be full fledged, editing should be minimal.

May 1 2017, 10:10 AM