Page MenuHomePhabricator

qcolombet (Quentin Colombet)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2012, 10:03 AM (348 w, 1 d)

Recent Activity

Today

qcolombet accepted D66438: [llvm-extract] Update the help message for group extraction feature.
Tue, Aug 20, 12:45 PM · Restricted Project

Yesterday

qcolombet added a comment to D66438: [llvm-extract] Update the help message for group extraction feature.

Hi Jinsong,

Mon, Aug 19, 3:47 PM · Restricted Project
qcolombet accepted D66444: [BlockExtractor] Avoid assert with wrong line format.
Mon, Aug 19, 3:47 PM · Restricted Project

Fri, Aug 16

qcolombet accepted D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Fri, Aug 16, 4:22 PM · Restricted Project
qcolombet added inline comments to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Fri, Aug 16, 4:22 PM · Restricted Project
qcolombet added inline comments to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Fri, Aug 16, 12:25 PM · Restricted Project
qcolombet added inline comments to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Fri, Aug 16, 10:49 AM · Restricted Project
qcolombet added inline comments to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.
Fri, Aug 16, 10:49 AM · Restricted Project

Tue, Aug 13

qcolombet added a comment to D65542: [PeepholeOptimizer] Don't assume bitcast def always has input.

LGTM with a test case.

Tue, Aug 13, 10:00 AM · Restricted Project
qcolombet added a comment to D63731: [AMDGPU] Prevent VGPR copies from moving across the EXEC mask definitions.

LGTM for the generic part.

Tue, Aug 13, 9:58 AM · Restricted Project

Thu, Aug 1

qcolombet added inline comments to D63731: [AMDGPU] Prevent VGPR copies from moving across the EXEC mask definitions.
Thu, Aug 1, 7:02 AM · Restricted Project
qcolombet accepted D65466: CodeGen: Allow virtual registers in bundles.
Thu, Aug 1, 2:05 AM

Jul 19 2019

qcolombet accepted D64503: LiveIntervals: Fix handleMove asserting on BUNDLE.
Jul 19 2019, 12:05 PM

Jul 8 2019

qcolombet accepted D64325: RegUsageInfoCollector: Don't iterate all regs for every reg class.
Jul 8 2019, 11:05 AM
qcolombet added a comment to D64325: RegUsageInfoCollector: Don't iterate all regs for every reg class.

It was added by D46315

Jul 8 2019, 11:05 AM
qcolombet added a comment to D64325: RegUsageInfoCollector: Don't iterate all regs for every reg class.

Remove loop entirely. Ultimately determineCalleeSaves adds everything from MCRegAliasIterator anyway

Jul 8 2019, 10:48 AM
qcolombet added inline comments to D64354: [AArch64][GlobalISel] Optimize conditional branches followed by unconditional branches.
Jul 8 2019, 9:59 AM · Restricted Project
qcolombet added inline comments to D64325: RegUsageInfoCollector: Don't iterate all regs for every reg class.
Jul 8 2019, 8:22 AM

Jul 5 2019

qcolombet committed rG0ffe0db6fab4: [RegisterCoalescer] Fix an overzealous assert (authored by qcolombet).
[RegisterCoalescer] Fix an overzealous assert
Jul 5 2019, 5:36 PM
qcolombet committed rL365256: [RegisterCoalescer] Fix an overzealous assert.
[RegisterCoalescer] Fix an overzealous assert
Jul 5 2019, 5:34 PM
qcolombet accepted D64266: RegUsageInfoCollector: Skip AMDGPU entry point functions.

Let's go with that for now with one caveat. Does the code build without ANDGPU?
I.e., does the callingconv enum get generated?

Jul 5 2019, 3:44 PM

Jul 3 2019

qcolombet accepted D64108: [GlobalISel][AArch64] Use getConstantVRegValWithLookThrough for selectArithImmed.
Jul 3 2019, 9:42 AM · Restricted Project

Jul 2 2019

qcolombet requested changes to D64108: [GlobalISel][AArch64] Use getConstantVRegValWithLookThrough for selectArithImmed.

General direction LGTM but there's a bug in the current patch unless I am mistaken.

Jul 2 2019, 4:08 PM · Restricted Project

Jun 19 2019

qcolombet added a comment to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.

I second Daniel's comment, this is RegBankSelect's job to do this choice and the Legalizer shouldn't need to know about f64 vs. s64.

Jun 19 2019, 2:18 PM · Restricted Project
qcolombet accepted D63496: [WIP] CodeGen: Prototype class for registers.

Maybe adding an MCRegister that's nearly identical might be a future improvement? That way it could enforce MCRegister->Register is OK, but Register->MCRegister is not

Jun 19 2019, 10:49 AM

Jun 18 2019

qcolombet added a comment to D63496: [WIP] CodeGen: Prototype class for registers.

Thanks for doing this Matt, this is a long due clean-up.
I haven't looked carefully at all the changes, but the general direction LGTM.

Jun 18 2019, 11:58 AM

Jun 17 2019

qcolombet added a comment to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.

Those rules work when there's a load/store for every type but they run into unable-to-legalize if that's not the case.

Jun 17 2019, 2:34 PM · Restricted Project

Jun 14 2019

qcolombet accepted D63303: [GlobalISel][Localizer] Rewrite localizer to run in 2 phases, inter & intra block..

LGTM modulo want @paquette pointed out.

Jun 14 2019, 11:03 AM · Restricted Project

Jun 13 2019

qcolombet added inline comments to D63162: GlobalISel: Avoid producing Illegal copies in RegBankSelect.
Jun 13 2019, 12:43 PM
qcolombet accepted D63162: GlobalISel: Avoid producing Illegal copies in RegBankSelect.

Nitpicks below.

Jun 13 2019, 10:11 AM

Jun 12 2019

qcolombet accepted D63173: RegBankSelect: Remove checks for invalid mappings.

Nitpicks below.

Jun 12 2019, 3:35 PM
qcolombet accepted D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.

Agree, the fix is more important than the performance loss at this point.

Jun 12 2019, 12:57 PM · Restricted Project

Jun 5 2019

qcolombet added a comment to D60888: [SystemZ] Favor 3-address instructions during instruction selection..

Hi Jonas,

Jun 5 2019, 1:35 PM
qcolombet accepted D62745: Factor out SelectionDAG's switch analysis and lowering into a separate component.

Hi Amara,

Jun 5 2019, 1:28 PM · Restricted Project

Jun 3 2019

qcolombet accepted D62552: Propagate fmf for setcc/select folds.

LGTM.

Jun 3 2019, 11:25 AM · Restricted Project

May 30 2019

qcolombet accepted D61702: MISched: Fix -misched-regpressure=0 if subreg liveness enabled.

Looks reasonable!

May 30 2019, 9:43 AM
qcolombet added a comment to D62411: LiveIntervals: add LiveRange::findIndexesLiveAt function - return a list of SlotIndexes the LiveRange live at..

What is the use case for this?

May 30 2019, 9:40 AM · Restricted Project
qcolombet requested changes to D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.
May 30 2019, 9:31 AM · Restricted Project
qcolombet reopened D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.
May 30 2019, 9:30 AM · Restricted Project

May 28 2019

qcolombet committed rGa6f57ad2c9dc: [RegUsageInfoCollector] Don't mark as saved registers that don't have… (authored by qcolombet).
[RegUsageInfoCollector] Don't mark as saved registers that don't have…
May 28 2019, 4:45 PM
qcolombet committed rL361901: [RegUsageInfoCollector] Don't mark as saved registers that don't have….
[RegUsageInfoCollector] Don't mark as saved registers that don't have…
May 28 2019, 4:40 PM

May 27 2019

qcolombet accepted D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.

LGTM.
Nitpicks on the test below.

May 27 2019, 9:13 AM
qcolombet added a comment to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.

Hi Daniel,

May 27 2019, 9:07 AM · Restricted Project

May 24 2019

qcolombet added inline comments to D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.
May 24 2019, 3:26 PM
qcolombet added inline comments to D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.
May 24 2019, 2:56 PM
qcolombet added inline comments to D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses.
May 24 2019, 2:54 PM

May 16 2019

qcolombet added a comment to D61061: [MachineFunction] Base support for call site info tracking.
Please provide us with more details about your idea.
May 16 2019, 1:19 PM · Restricted Project, debug-info

May 14 2019

qcolombet accepted D54367: RegAllocFast: Improve hinting heuristic.

LGTM

May 14 2019, 11:05 AM · Restricted Project

May 13 2019

qcolombet added a comment to D61061: [MachineFunction] Base support for call site info tracking.
did anything like this come up in the past?
May 13 2019, 1:04 PM · Restricted Project, debug-info
qcolombet accepted D61852: [IRTranslator] Don't hardcode GEP index type.

LGTM

May 13 2019, 1:01 PM · Restricted Project
qcolombet added a comment to D54367: RegAllocFast: Improve hinting heuristic.

Looks good to me, modulo the order in which we check the hints.

May 13 2019, 8:26 AM · Restricted Project

May 8 2019

qcolombet committed rG157427245a19: [RegAllocFast] Scan physcial reg definitions before assigning virtual reg… (authored by qcolombet).
[RegAllocFast] Scan physcial reg definitions before assigning virtual reg…
May 8 2019, 11:29 AM
qcolombet committed rL360278: [RegAllocFast] Scan physcial reg definitions before assigning virtual reg….
[RegAllocFast] Scan physcial reg definitions before assigning virtual reg…
May 8 2019, 11:28 AM

May 3 2019

qcolombet added a comment to D60888: [SystemZ] Favor 3-address instructions during instruction selection..

@Quentin: This has the same common-code change as in D58923, with the added VRM to foldMemoryOperand(). You seemed fine with this change, right?

May 3 2019, 9:03 AM
qcolombet added inline comments to D61489: RegAlloc: try to fail more gracefully when out of registers.
May 3 2019, 8:57 AM · Restricted Project
qcolombet accepted D54366: RegAllocFast: Add heuristic to detect values not live-out of a block.

LGTM. Nitpicks below.

May 3 2019, 8:50 AM · Restricted Project

May 2 2019

qcolombet committed rGc9256cc6ba93: [IRTranslator] Use the alloc size instead of the store size when translating… (authored by qcolombet).
[IRTranslator] Use the alloc size instead of the store size when translating…
May 2 2019, 6:23 PM
qcolombet committed rL359856: [IRTranslator] Use the alloc size instead of the store size when translating….
[IRTranslator] Use the alloc size instead of the store size when translating…
May 2 2019, 6:23 PM

Apr 29 2019

qcolombet committed rG2d977935a298: [llvm-extract] Expose the group extraction feature of the BlockExtractor (authored by qcolombet).
[llvm-extract] Expose the group extraction feature of the BlockExtractor
Apr 29 2019, 9:15 AM
qcolombet committed rG31ce274207fd: [BlockExtractor] Expose a constructor for the group extraction (authored by qcolombet).
[BlockExtractor] Expose a constructor for the group extraction
Apr 29 2019, 9:15 AM
qcolombet committed rGae2cbb34007d: [BlockExtractor] Change the basic block separator from ',' to ';' (authored by qcolombet).
[BlockExtractor] Change the basic block separator from ',' to ';'
Apr 29 2019, 9:15 AM
qcolombet committed rL359464: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
[llvm-extract] Expose the group extraction feature of the BlockExtractor
Apr 29 2019, 9:14 AM
qcolombet closed D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
Apr 29 2019, 9:14 AM · Restricted Project
qcolombet committed rL359463: [BlockExtractor] Expose a constructor for the group extraction.
[BlockExtractor] Expose a constructor for the group extraction
Apr 29 2019, 9:14 AM
qcolombet closed D60971: [BlockExtractor] Expose a constructor for the group extraction.
Apr 29 2019, 9:14 AM · Restricted Project
qcolombet committed rL359462: [BlockExtractor] Change the basic block separator from ',' to ';'.
[BlockExtractor] Change the basic block separator from ',' to ';'
Apr 29 2019, 9:14 AM
qcolombet closed D60970: [BlockExtractor] Change the basic block separator from ',' to ';'.
Apr 29 2019, 9:14 AM · Restricted Project

Apr 22 2019

qcolombet added a parent revision for D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor: D60970: [BlockExtractor] Change the basic block separator from ',' to ';'.
Apr 22 2019, 11:01 AM · Restricted Project
qcolombet added a child revision for D60970: [BlockExtractor] Change the basic block separator from ',' to ';': D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
Apr 22 2019, 11:01 AM · Restricted Project
qcolombet added a parent revision for D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor: D60971: [BlockExtractor] Expose a constructor for the group extraction.
Apr 22 2019, 10:57 AM · Restricted Project
qcolombet added a child revision for D60971: [BlockExtractor] Expose a constructor for the group extraction: D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
Apr 22 2019, 10:57 AM · Restricted Project
qcolombet created D60973: [llvm-extract] Expose the group extraction feature of the BlockExtractor.
Apr 22 2019, 10:57 AM · Restricted Project
qcolombet created D60971: [BlockExtractor] Expose a constructor for the group extraction.
Apr 22 2019, 10:57 AM · Restricted Project
qcolombet created D60970: [BlockExtractor] Change the basic block separator from ',' to ';'.
Apr 22 2019, 10:57 AM · Restricted Project

Apr 18 2019

qcolombet committed rGea3364bf85ef: [BlockExtractor] Extend the file format to support the grouping of basic blocks (authored by qcolombet).
[BlockExtractor] Extend the file format to support the grouping of basic blocks
Apr 18 2019, 11:27 AM
qcolombet committed rL358701: [BlockExtractor] Extend the file format to support the grouping of basic blocks.
[BlockExtractor] Extend the file format to support the grouping of basic blocks
Apr 18 2019, 11:27 AM
qcolombet closed D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.
Apr 18 2019, 11:26 AM · Restricted Project
qcolombet added a comment to D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.

Could you please update the summary before pushing this?

Apr 18 2019, 10:33 AM · Restricted Project
qcolombet updated the summary of D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.
Apr 18 2019, 10:33 AM · Restricted Project

Apr 16 2019

qcolombet updated the diff for D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.

Update:

  • Use comma separated list instead of group naming.
Apr 16 2019, 12:23 PM · Restricted Project
qcolombet added a comment to D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.

Hi Volkan,

Apr 16 2019, 11:24 AM · Restricted Project

Apr 15 2019

qcolombet committed rG474a9679bdf3: [CodeExtractor] Add a few debug lines to understand why a region is not… (authored by qcolombet).
[CodeExtractor] Add a few debug lines to understand why a region is not…
Apr 15 2019, 7:13 PM
qcolombet committed rL358471: [CodeExtractor] Add a few debug lines to understand why a region is not….
[CodeExtractor] Add a few debug lines to understand why a region is not…
Apr 15 2019, 7:12 PM
qcolombet created D60746: [BlockExtractor] Extend the file format to support the grouping of basic blocks.
Apr 15 2019, 7:06 PM · Restricted Project
qcolombet committed rGfda042688860: [LSR] Rewrite misses some fixup locations if it splits critical edge (authored by qcolombet).
[LSR] Rewrite misses some fixup locations if it splits critical edge
Apr 15 2019, 3:28 PM
qcolombet committed rL358457: [LSR] Rewrite misses some fixup locations if it splits critical edge.
[LSR] Rewrite misses some fixup locations if it splits critical edge
Apr 15 2019, 3:28 PM
qcolombet closed D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..
Apr 15 2019, 3:28 PM · Restricted Project
qcolombet accepted D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..

Looks good!

Apr 15 2019, 2:23 PM · Restricted Project
qcolombet added a comment to D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..

The source change looks good to me, but I would like a bit more work on the test itself.

Apr 15 2019, 8:26 AM · Restricted Project

Apr 4 2019

qcolombet added a comment to D59626: [AMDGPU] Add MachineDCE pass after RenameIndependentSubregs.

Looks reasonable to me.

Apr 4 2019, 2:21 PM · Restricted Project
qcolombet added inline comments to D59626: [AMDGPU] Add MachineDCE pass after RenameIndependentSubregs.
Apr 4 2019, 10:57 AM · Restricted Project

Apr 3 2019

qcolombet added a comment to D59626: [AMDGPU] Add MachineDCE pass after RenameIndependentSubregs.

Are the dead instructions marked during the detect dead lanes pass or during the rename independent SubReg pass?

Apr 3 2019, 5:59 PM · Restricted Project
qcolombet added a comment to D58923: [SystemZ] Utilize Compare/Add/Sub "High" instructions.

The generic changes look sensible to me.
I would just suggest to add a comment on what VRM is for on the modified methods.

Apr 3 2019, 11:20 AM

Mar 27 2019

qcolombet committed rG89daf49e5c56: [PeepholeOpt] Don't stop simplifying copies on sequence of subregs (authored by qcolombet).
[PeepholeOpt] Don't stop simplifying copies on sequence of subregs
Mar 27 2019, 10:30 AM
qcolombet committed rL357095: [PeepholeOpt] Don't stop simplifying copies on sequence of subregs.
[PeepholeOpt] Don't stop simplifying copies on sequence of subregs
Mar 27 2019, 10:26 AM
qcolombet closed D59891: [PeepholeOpt] Don't stop simplifying copies on sequence of subregs.
Mar 27 2019, 10:26 AM · Restricted Project
qcolombet accepted D59892: [GlobalISel] Fix legalizer artifact combiner from crashing with invalid dead instructions.
Mar 27 2019, 10:25 AM · Restricted Project
qcolombet created D59891: [PeepholeOpt] Don't stop simplifying copies on sequence of subregs.
Mar 27 2019, 10:15 AM · Restricted Project
qcolombet accepted D59144: RegPressure: Fix crash on blocks with only dbg_value.
Mar 27 2019, 10:10 AM

Mar 26 2019

qcolombet committed rGc74271c53764: [LiveRange] Reset the VNIs when splitting subranges (authored by qcolombet).
[LiveRange] Reset the VNIs when splitting subranges
Mar 26 2019, 2:27 PM