Page MenuHomePhabricator

luismarques (Luís Marques)
Software/hardware engineer at lowRISC

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2018, 7:48 AM (63 w, 23 h)

Mostly LLVM work.

Recent Activity

Wed, Jan 15

luismarques committed rG46e3edcc2c89: [RISCV] Fix test for inline asm z constraint modifier (authored by luismarques).
[RISCV] Fix test for inline asm z constraint modifier
Wed, Jan 15, 5:52 AM
luismarques closed D72134: [RISCV] Fix test for inline asm z constraint modifier.
Wed, Jan 15, 5:52 AM · Restricted Project

Mon, Jan 13

luismarques committed rG043c5eafa878: [RISCV] Handle globals and block addresses in asm operands (authored by luismarques).
[RISCV] Handle globals and block addresses in asm operands
Mon, Jan 13, 7:44 AM
luismarques closed D72275: [RISCV] Handle globals and block addresses in asm operands.
Mon, Jan 13, 7:44 AM · Restricted Project
luismarques accepted D62190: [RISCV] Allow shrink wrapping for RISC-V.

Thanks for the patch Lewis. Overall it LGTM, and it would be great to merge this in time for the LLVM 10.0 release.

Mon, Jan 13, 5:48 AM · Restricted Project

Tue, Jan 7

luismarques committed rG27e6b171e0be: [RISCV][Docs] Add RISC-V asm template argument modifiers (authored by luismarques).
[RISCV][Docs] Add RISC-V asm template argument modifiers
Tue, Jan 7, 3:13 AM

Mon, Jan 6

luismarques created D72275: [RISCV] Handle globals and block addresses in asm operands.
Mon, Jan 6, 8:11 AM · Restricted Project

Fri, Jan 3

luismarques created D72134: [RISCV] Fix test for inline asm z constraint modifier.
Fri, Jan 3, 2:54 AM · Restricted Project

Thu, Jan 2

luismarques accepted D67495: [RISCV] Collect Statistics on Compressed Instructions.

LGTM. My only concern was if it made sense to use the same statistic to count in both places, and if we could end up double counting the instructions emitted (now, or in a future LLVM version). After a quick look I didn't really see other targets using the same approach, but I also can't think of a way where this ends up actually being problematic.

Thu, Jan 2, 2:25 AM · Restricted Project

Mon, Dec 23

luismarques added a comment to D71777: [RISCV][NFC] Deduplicate Atomic Intrinsic Definitions.

I would personally rather this remain unindented, much like we do with namespace llvm etc.

Mon, Dec 23, 12:32 PM · Restricted Project
luismarques accepted D71777: [RISCV][NFC] Deduplicate Atomic Intrinsic Definitions.

LGTM.

Mon, Dec 23, 12:00 PM · Restricted Project
luismarques committed rG5b1d0dc6bf06: [RISCV][NFC] Fix use of missing attribute groups in tests (authored by luismarques).
[RISCV][NFC] Fix use of missing attribute groups in tests
Mon, Dec 23, 7:44 AM

Thu, Dec 19

luismarques committed rGec4f06a77ded: [RISCV] Don't crash on unsupported relocations (authored by luismarques).
[RISCV] Don't crash on unsupported relocations
Thu, Dec 19, 9:23 AM
luismarques closed D71536: [RISCV] Don't crash on unsupported relocations.
Thu, Dec 19, 9:23 AM · Restricted Project
luismarques updated the diff for D71536: [RISCV] Don't crash on unsupported relocations.

Add RUN line for riscv64

Thu, Dec 19, 6:53 AM · Restricted Project

Dec 19 2019

luismarques updated the diff for D71536: [RISCV] Don't crash on unsupported relocations.

Update test CHECKs to check for line number/columns.

Dec 19 2019, 3:07 AM · Restricted Project

Dec 17 2019

luismarques committed rGe332a0961935: [RISCV][NFC] Trivial cleanup (authored by luismarques).
[RISCV][NFC] Trivial cleanup
Dec 17 2019, 3:48 AM

Dec 16 2019

luismarques accepted D68362: [libunwind][RISCV] Add 64-bit RISC-V support.

LGTM.

Dec 16 2019, 4:55 AM · Restricted Project
luismarques created D71536: [RISCV] Don't crash on unsupported relocations.
Dec 16 2019, 3:34 AM · Restricted Project

Dec 11 2019

luismarques added inline comments to D70401: [WIP][RISCV] Implement ilp32e ABI.
Dec 11 2019, 12:09 PM · Restricted Project, Restricted Project
luismarques accepted D67493: [RISCV] Move DebugLoc Copy into CompressInstEmitter.

LGTM

Dec 11 2019, 5:25 AM · Restricted Project

Dec 10 2019

luismarques committed rG707e9707814b: [DWARF][RISCV] Test resolving of RISC-V relocations (authored by luismarques).
[DWARF][RISCV] Test resolving of RISC-V relocations
Dec 10 2019, 6:04 AM
luismarques closed D70541: [DWARF][RISCV] Test resolving of RISC-V relocations.
Dec 10 2019, 6:04 AM · Restricted Project

Dec 5 2019

luismarques added inline comments to D70541: [DWARF][RISCV] Test resolving of RISC-V relocations.
Dec 5 2019, 2:39 AM · Restricted Project

Dec 4 2019

luismarques added inline comments to D70541: [DWARF][RISCV] Test resolving of RISC-V relocations.
Dec 4 2019, 8:55 AM · Restricted Project
luismarques updated the diff for D70541: [DWARF][RISCV] Test resolving of RISC-V relocations.
  • Adds instructions for (re)creating/extending the binary blobs inside .debug_info and .debug_abbrev;
  • Simplifies the content of those sections to have only the fields we are interested in.
Dec 4 2019, 8:55 AM · Restricted Project

Nov 28 2019

luismarques added inline comments to D70541: [DWARF][RISCV] Test resolving of RISC-V relocations.
Nov 28 2019, 2:41 AM · Restricted Project

Nov 27 2019

luismarques added a reviewer for D70541: [DWARF][RISCV] Test resolving of RISC-V relocations: MaskRay.
Nov 27 2019, 7:22 AM · Restricted Project
luismarques abandoned D66725: [DAGCombiner][TargetLowering] Target hook for FCOPYSIGN arg cast folding.

Abandoned in favour of D70679 (and possibly other future patches).

Nov 27 2019, 7:13 AM · Restricted Project

Nov 26 2019

luismarques committed rG6fd4c42fa815: [LegalizeTypes][RISCV] Soften FCOPYSIGN operand (authored by luismarques).
[LegalizeTypes][RISCV] Soften FCOPYSIGN operand
Nov 26 2019, 7:30 AM
luismarques closed D70679: [LegalizeTypes][RISCV] Soften FCOPYSIGN operand.
Nov 26 2019, 7:30 AM · Restricted Project
luismarques committed rGd7be3eab5c0e: [RISCV] Handle fcopysign(f32, f64) and fcopysign(f64, f32) (authored by luismarques).
[RISCV] Handle fcopysign(f32, f64) and fcopysign(f64, f32)
Nov 26 2019, 6:34 AM
luismarques closed D70678: [RISCV] Handle fcopysign(f32, f64) and fcopysign(f64, f32).
Nov 26 2019, 6:33 AM · Restricted Project
luismarques accepted D70666: [RISCV] Machine Operand Flag Serialization.

LGTM.
Thanks for the review suggestions @jrtc27 !

Nov 26 2019, 6:15 AM · Restricted Project
luismarques accepted D70578: [Object][RISCV][test] Improve DebugInfo/RISCV/relax-debug-frame.ll.

LGTM.

Nov 26 2019, 5:46 AM · Restricted Project

Nov 25 2019

luismarques added a parent revision for D70679: [LegalizeTypes][RISCV] Soften FCOPYSIGN operand: D70678: [RISCV] Handle fcopysign(f32, f64) and fcopysign(f64, f32).
Nov 25 2019, 9:57 AM · Restricted Project
luismarques added a child revision for D70678: [RISCV] Handle fcopysign(f32, f64) and fcopysign(f64, f32): D70679: [LegalizeTypes][RISCV] Soften FCOPYSIGN operand.
Nov 25 2019, 9:57 AM · Restricted Project
luismarques created D70679: [LegalizeTypes][RISCV] Soften FCOPYSIGN operand.
Nov 25 2019, 9:57 AM · Restricted Project
luismarques created D70678: [RISCV] Handle fcopysign(f32, f64) and fcopysign(f64, f32).
Nov 25 2019, 9:47 AM · Restricted Project

Nov 22 2019

luismarques added a comment to D70578: [Object][RISCV][test] Improve DebugInfo/RISCV/relax-debug-frame.ll.

@HsiangKai could you please check what you intended those -NOT lines to originally check, and confirm if those changes are OK?

Nov 22 2019, 3:57 AM · Restricted Project
luismarques added a reviewer for D70578: [Object][RISCV][test] Improve DebugInfo/RISCV/relax-debug-frame.ll: HsiangKai.
Nov 22 2019, 3:49 AM · Restricted Project

Nov 21 2019

luismarques updated the diff for D70541: [DWARF][RISCV] Test resolving of RISC-V relocations.

Add R_RISCV_32_PCREL test.
Tweak comment and hex capitalization.

Nov 21 2019, 4:28 PM · Restricted Project
luismarques committed rG7bf721e59c54: [Object][RISCV] Resolve R_RISCV_32_PCREL (authored by luismarques).
[Object][RISCV] Resolve R_RISCV_32_PCREL
Nov 21 2019, 3:43 PM
luismarques closed D70204: [Object][RISCV] Resolve R_RISCV_32_PCREL.
Nov 21 2019, 3:43 PM · Restricted Project
luismarques updated the diff for D70204: [Object][RISCV] Resolve R_RISCV_32_PCREL.

Rebase patch; Tweak enumeration order. Change title [DWARF] to [Object].

Nov 21 2019, 3:33 PM · Restricted Project
luismarques committed rGb8b57087d3a6: [Object][RISCV] Fix R_RISCV_SET6 and R_RISCV_SUB6 relocations resolution (authored by luismarques).
[Object][RISCV] Fix R_RISCV_SET6 and R_RISCV_SUB6 relocations resolution
Nov 21 2019, 2:57 PM
luismarques closed D70396: [Object][RISCV] Fix R_RISCV_SET6 and R_RISCV_SUB6 relocations resolution.
Nov 21 2019, 2:57 PM · Restricted Project
luismarques added a comment to D70396: [Object][RISCV] Fix R_RISCV_SET6 and R_RISCV_SUB6 relocations resolution.

LGTM. Do you have any test case for this patch?

Nov 21 2019, 7:42 AM · Restricted Project
luismarques created D70541: [DWARF][RISCV] Test resolving of RISC-V relocations.
Nov 21 2019, 7:42 AM · Restricted Project

Nov 20 2019

luismarques added inline comments to D70426: [DAGCombiner][RISCV] Avoid FCOPYSIGN folding of legalizing operand casts.
Nov 20 2019, 3:39 AM · Restricted Project

Nov 19 2019

luismarques updated the summary of D70426: [DAGCombiner][RISCV] Avoid FCOPYSIGN folding of legalizing operand casts.
Nov 19 2019, 4:05 AM · Restricted Project
luismarques created D70426: [DAGCombiner][RISCV] Avoid FCOPYSIGN folding of legalizing operand casts.
Nov 19 2019, 2:54 AM · Restricted Project

Nov 18 2019

luismarques added inline comments to D70401: [WIP][RISCV] Implement ilp32e ABI.
Nov 18 2019, 10:31 AM · Restricted Project, Restricted Project
luismarques added a reviewer for D70396: [Object][RISCV] Fix R_RISCV_SET6 and R_RISCV_SUB6 relocations resolution: jrtc27.
Nov 18 2019, 7:33 AM · Restricted Project
luismarques created D70396: [Object][RISCV] Fix R_RISCV_SET6 and R_RISCV_SUB6 relocations resolution.
Nov 18 2019, 7:24 AM · Restricted Project

Nov 14 2019

luismarques committed rGc6b09bff5671: [RISCV] Fix wrong CFI directives (authored by luismarques).
[RISCV] Fix wrong CFI directives
Nov 14 2019, 10:34 AM
luismarques closed D69723: [RISCV] Fix wrong CFI directives.
Nov 14 2019, 10:34 AM · Restricted Project
luismarques added inline comments to D69723: [RISCV] Fix wrong CFI directives.
Nov 14 2019, 9:11 AM · Restricted Project
luismarques accepted D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults.

LGTM.

Nov 14 2019, 7:39 AM · Restricted Project

Nov 13 2019

luismarques created D70204: [Object][RISCV] Resolve R_RISCV_32_PCREL.
Nov 13 2019, 12:38 PM · Restricted Project
luismarques reopened D69723: [RISCV] Fix wrong CFI directives.

Re-opening, to make sure the changes to relax-debug-frame.ll are reasonable.

Nov 13 2019, 7:59 AM · Restricted Project
luismarques updated the diff for D69723: [RISCV] Fix wrong CFI directives.

Update the test DebugInfo/RISCV/relax-debug-frame.ll, which wasn't included in the original patch.
Please re-review the impact of the patch in that test.

Nov 13 2019, 7:51 AM · Restricted Project
luismarques committed rGc5b56caa322b: Revert "[RISCV] Fix wrong CFI directives" (authored by luismarques).
Revert "[RISCV] Fix wrong CFI directives"
Nov 13 2019, 5:30 AM
luismarques committed rGa5ce8bd715ad: [RISCV] Fix wrong CFI directives (authored by luismarques).
[RISCV] Fix wrong CFI directives
Nov 13 2019, 5:12 AM
luismarques closed D69723: [RISCV] Fix wrong CFI directives.
Nov 13 2019, 5:11 AM · Restricted Project
luismarques removed a parent revision for D69723: [RISCV] Fix wrong CFI directives: D69385: [RISCV] Fix CFA when doing split sp adjustment with fp.
Nov 13 2019, 5:02 AM · Restricted Project
luismarques removed a child revision for D69385: [RISCV] Fix CFA when doing split sp adjustment with fp: D69723: [RISCV] Fix wrong CFI directives.
Nov 13 2019, 5:02 AM · Restricted Project

Nov 12 2019

luismarques accepted D70124: [RISCV] Use addi rather than add x0.

LGTM.

Nov 12 2019, 8:00 AM · Restricted Project
luismarques added inline comments to D69723: [RISCV] Fix wrong CFI directives.
Nov 12 2019, 7:31 AM · Restricted Project
luismarques updated the diff for D69723: [RISCV] Fix wrong CFI directives.

Remove remaining CFI directive from epilogue.

Nov 12 2019, 7:22 AM · Restricted Project

Nov 11 2019

luismarques added a comment to D70064: [DAGCombiner][TargetLowering] FCOPYSIGN mixed types legality.
  1. There should be a clear query for whether the operation is legal.
  2. We should allow generating unsupported operations before LegalizeDAG runs.
  3. LegalizeDAG should support transforming illegal operations to legal ones.
Nov 11 2019, 2:56 PM · Restricted Project
luismarques updated the diff for D69723: [RISCV] Fix wrong CFI directives.

Rebase again, after adding nounwind to some tests in master.
Remove outdated summary text.

Nov 11 2019, 2:16 AM · Restricted Project
luismarques committed rG4197a76593a6: [RISCV][NFC] Add nounwind to LKK test functions (authored by luismarques).
[RISCV][NFC] Add nounwind to LKK test functions
Nov 11 2019, 1:53 AM
luismarques closed D70067: [RISCV][NFC] Add nounwind to LKK test functions.
Nov 11 2019, 1:53 AM · Restricted Project
luismarques created D70067: [RISCV][NFC] Add nounwind to LKK test functions.
Nov 11 2019, 1:07 AM · Restricted Project
luismarques updated the diff for D69723: [RISCV] Fix wrong CFI directives.

Rebase patch.
Remove [RFC] From title.

Nov 11 2019, 12:49 AM · Restricted Project

Nov 10 2019

luismarques created D70064: [DAGCombiner][TargetLowering] FCOPYSIGN mixed types legality.
Nov 10 2019, 2:44 PM · Restricted Project
luismarques committed rG1c737f54bee9: [RISCV] Fix CFA when doing split sp adjustment with fp (authored by luismarques).
[RISCV] Fix CFA when doing split sp adjustment with fp
Nov 10 2019, 8:17 AM
luismarques closed D69385: [RISCV] Fix CFA when doing split sp adjustment with fp.
Nov 10 2019, 8:17 AM · Restricted Project
luismarques committed rGbe0fead7bffb: [RISCV][NFC] Add CFI-related tests (authored by luismarques).
[RISCV][NFC] Add CFI-related tests
Nov 10 2019, 8:08 AM
luismarques closed D69721: [RISCV] Add CFI-related tests.
Nov 10 2019, 8:07 AM · Restricted Project
luismarques removed a parent revision for D69385: [RISCV] Fix CFA when doing split sp adjustment with fp: D69721: [RISCV] Add CFI-related tests.
Nov 10 2019, 8:07 AM · Restricted Project
luismarques removed a child revision for D69721: [RISCV] Add CFI-related tests: D69385: [RISCV] Fix CFA when doing split sp adjustment with fp.
Nov 10 2019, 8:07 AM · Restricted Project
luismarques updated the diff for D66725: [DAGCombiner][TargetLowering] Target hook for FCOPYSIGN arg cast folding.

Add nounwind to tests.

Nov 10 2019, 7:14 AM · Restricted Project
luismarques added a comment to D66725: [DAGCombiner][TargetLowering] Target hook for FCOPYSIGN arg cast folding.

For FCOPYSIGN, specifically, LegalizeDAG is going to query the target to ask, "is FCOPYSIGN legal for result type X", using the getOperationAction() API? The target has a few different ways to respond: here, the relevant possibilities are "Legal", "Expand", or "Custom". I guess the issue here is that on RISCV, this query is returning "Legal", when it actually isn't legal for all combinations of legal result/input types?
If this is a problem for a bunch of targets, maybe we need a different API for expressing whether an FCOPYSIGN is legal. I'd prefer to follow existing convention for other operations which involve multiple types, though; for example, see TargetLoweringBase::getLoadExtAction.

Nov 10 2019, 4:39 AM · Restricted Project
luismarques updated the summary of D66725: [DAGCombiner][TargetLowering] Target hook for FCOPYSIGN arg cast folding.
Nov 10 2019, 3:53 AM · Restricted Project
luismarques updated the diff for D66725: [DAGCombiner][TargetLowering] Target hook for FCOPYSIGN arg cast folding.

Rebased and tweaked patch.

Nov 10 2019, 3:53 AM · Restricted Project

Nov 5 2019

luismarques accepted D60657: [RISCV] Fix evaluation of %pcrel_lo.

LGTM.

Nov 5 2019, 3:28 AM · Restricted Project
luismarques added a reviewer for D60657: [RISCV] Fix evaluation of %pcrel_lo: luismarques.
Nov 5 2019, 3:28 AM · Restricted Project
luismarques committed rG0d47c7aba364: [RISCV] Add InstrInfo areMemAccessesTriviallyDisjoint hook (authored by luismarques).
[RISCV] Add InstrInfo areMemAccessesTriviallyDisjoint hook
Nov 5 2019, 1:43 AM
luismarques closed D67046: [RISCV] Add InstrInfo areMemAccessesTriviallyDisjoint hook.
Nov 5 2019, 1:42 AM · Restricted Project

Nov 4 2019

luismarques updated the diff for D67046: [RISCV] Add InstrInfo areMemAccessesTriviallyDisjoint hook.

Rebased on master. Add test comments.

Nov 4 2019, 12:31 PM · Restricted Project
luismarques added inline comments to D67046: [RISCV] Add InstrInfo areMemAccessesTriviallyDisjoint hook.
Nov 4 2019, 12:31 PM · Restricted Project
luismarques updated the diff for D69385: [RISCV] Fix CFA when doing split sp adjustment with fp.

Rebased to match changes to D69721.

Nov 4 2019, 11:35 AM · Restricted Project
luismarques added inline comments to D69721: [RISCV] Add CFI-related tests.
Nov 4 2019, 11:17 AM · Restricted Project
luismarques updated the diff for D69721: [RISCV] Add CFI-related tests.

Address review concerns

Nov 4 2019, 11:17 AM · Restricted Project
luismarques committed rG51b4b17eb7e6: [RISCV] Implement the TargetLowering::getRegisterByName hook (authored by luismarques).
[RISCV] Implement the TargetLowering::getRegisterByName hook
Nov 4 2019, 3:26 AM
luismarques closed D69130: [RISCV] Implement the TargetLowering::getRegisterByName hook.
Nov 4 2019, 3:26 AM · Restricted Project
luismarques removed a parent revision for D69130: [RISCV] Implement the TargetLowering::getRegisterByName hook: D67185: [RISCV] Add support for -ffixed-xX flags.
Nov 4 2019, 3:20 AM · Restricted Project
luismarques removed a child revision for D67185: [RISCV] Add support for -ffixed-xX flags: D69130: [RISCV] Implement the TargetLowering::getRegisterByName hook.
Nov 4 2019, 3:20 AM · Restricted Project, Restricted Project