Mostly LLVM work. Sometimes OpenTitan stuff. Oh, and messing with hardware is fun.
- User Since
- Nov 2 2018, 7:48 AM (191 w, 4 d)
I guess this patch should update the other conventions as well? E.g. error out if nest is used with the GHC CC. There's also the FastCC.
Sun, Jul 3
Sorry, my previous approval comment was meant for D127581.
My tests finally finished running. No issues detected. LGTM.
Wed, Jun 29
Is removing the if (I != MBB.end()) DL = I->getDebugLoc(); actually correct? I'm wondering why do several other targets have that if it can just be removed.
Fri, Jun 24
Nit: tweak comments.
- Handle non-zero offsets in tail load/store instructions
Personally, I would just leave the raw case statements, but I don't really care that much either way.
Make instructions with pre- and post-instructions symbols not duplicable
- Apply suggestion to rename label name
- Set AnalysisUsage CFG preserved
Wed, Jun 22
Tue, Jun 21
Wed, Jun 15
Tue, Jun 14
Mon, Jun 13
(don't forget to update the commit message)
I know that this issue arose in the context of -fprofile-instr-generate but can you please clean up the test to focus on the bug? Something like this:
Wed, Jun 8
Could this interact badly with the medlow upper address space bound of 0x000000007FFFF7FF?
Tue, Jun 7
Mon, Jun 6
May 31 2022
May 30 2022
May 27 2022
Can you please rebase the patch? It fails to apply.
May 26 2022
May 25 2022
May 3 2022
May 2 2022
@craig.topper Have you checked if CombinerHelper::reassociationCanBreakAddressingModePattern (in llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp) is sound?
LGTM. Thanks for the fix!
Apr 30 2022
Apr 29 2022
Apr 24 2022
Apr 22 2022
Apr 21 2022
Apr 20 2022
I think this patch can be abandoned now?
Thanks for providing D123515 as an alternative.
The fix looks fine.
Is this patch still relevant?
LGTM. Don't forget to fix the typo before committing.
Apr 19 2022
This seems in line with what's done for the other archs, so overall seems fine.
Apr 18 2022
Don't mess with isPosition. Create named temp labels. Remove cruft.
Apr 15 2022
Apr 14 2022
This was discussed in the RISC-V sync-up call. As suggested by Alex, I'm sharing in writing here some of the things I mentioned or were discussed in the call:
Apr 12 2022
Don't forget to include the full context in your patches. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
It looks like you also want to use clang-format to reformat the code.
Thanks for the patch. It would be great to finally have linker relaxations for RISC-V in LLD.
Apr 9 2022
We this change we now don't have any tests that show a difference compared with just if (MI.isPosition()) return outliner::InstrType::Illegal;
Please add a test that showcases that new, more fined grained, outlining criteria for position instructions.
Apr 7 2022
At first glance this seemed to make sense. The other targets also exclude these operand types, so I guess it really does :)
Apr 6 2022
Can we get this landed on time for backporting into 14.0.1? (it took me some time to address the review feedback because I was sick).
This patch makes sense to me and I think it is a correct fix.
In LLVM MC, the STI's feature bits is not mutable, it was determined by the command line before parsing the file. And to deal with directives like .option rvc, the Parser maintains an STI and replaces it with a new STI when the subtarget extensions were enabled or disabled. So we need to use MCAlignFragment's STI which is generated using the replaced STI by the parser. Is my understanding correct?