Page MenuHomePhabricator

luismarques (Luís Marques)
Software/hardware engineer at lowRISC

Projects

User does not belong to any projects.

User Details

User Since
Nov 2 2018, 7:48 AM (136 w, 6 d)

Mostly LLVM work.

Recent Activity

Today

luismarques added a comment to D102852: [RISCV] Fix a crash when lowering split float arguments.

The last time I looked at this I had some concerns but I didn't have time to fully investigate them.
To help get this going again, could you please clarify:

Thu, Jun 17, 5:42 AM · Restricted Project

Tue, Jun 15

luismarques added a comment to D102535: [RISCV] -mno-relax: emit .option norelax.

Methinks that the choice of whether to relax or not should be decided outside of the assembler code. This directive sets the choice in stone and counters any choice done at build time, when optimizations are specified. For instance, when building a debug version, the optimizations may be different from when building a release version. This directive blocks such common practices and may create confusion and non expected results.

Tue, Jun 15, 3:43 AM · Restricted Project

Wed, Jun 9

luismarques added a comment to D102535: [RISCV] -mno-relax: emit .option norelax.

@evandro had some good points about this issue that we didn't have time to fully discuss during the call. Evandro, when you find the time please chime in with your points here. Thank you!

Wed, Jun 9, 2:39 PM · Restricted Project
luismarques added a comment to D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options.
  1. there is no tests for mabi=ilp32e, and my patch covers that.
  2. the tests in riscv-abi.c will show default abi changes for special archs, especially for the arch with F but without D extension, in the future.
  3. the tests in riscv-arch.c will show default arch changes for abi=ilp32, which is rv32imacfd now, and it is better to be rv32imac. for abi=ilp32f it is better arch=imacf than current imacfd.
Wed, Jun 9, 2:13 PM · Restricted Project
luismarques accepted D103886: [sanitizer] Fix build on FreeBSD RISC-V.

LGTM.

Wed, Jun 9, 2:07 PM · Restricted Project

Mon, Jun 7

luismarques added a comment to D103743: [RISCV] Optimize bitwise and with constant for the Zbs extension.

Are you planning on extending this to use bclriw on RV64? (Would that clash with the use of tablegen? Personally, I tend to find C++ custom lowering of longer stuff easier to read and more cohesive, not sure how others feel)

Mon, Jun 7, 6:26 AM · Restricted Project
luismarques accepted D103757: [RISCV] Lower i8/i16 bswap/bitreverse to grevi/greviw with Zbp..

LGTM.

Mon, Jun 7, 2:44 AM · Restricted Project

Mon, May 31

luismarques added a comment to D62732: [RISCV] Add SystemV ABI.

That's surprising. I'll see if I can figure out what the issue might be. Thanks.

Mon, May 31, 3:09 PM · Restricted Project
luismarques added a comment to D62732: [RISCV] Add SystemV ABI.

I have tried the patch with llvm12, test case is provide by jade(https://gist.github.com/e2efac2f780ed820277dbaf608805f4e), but it didn't worked for me.
It seems that the unwind didn't succeed, can you figure out the problem?

Mon, May 31, 1:15 PM · Restricted Project

Thu, May 27

luismarques added a comment to D102535: [RISCV] -mno-relax: emit .option norelax.

Oh, sorry for confusing, I should ask that in LLVM sync up meeting before I said it's free to choose, we can discuss this at today's LLVM sync up meeting,
But again, I would prefer to let @asb and @luismarques to do the final judge :)

Thu, May 27, 8:50 AM · Restricted Project
luismarques added a comment to D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

Thanks for mentioning that! Now, I changed the effect of no-div option into choosing a proper extension and implemented the Zmmul subextension. Is this solution acceptable or are there anything need further changes?

Thu, May 27, 3:49 AM · Restricted Project, Restricted Project
luismarques added a comment to D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

So it seems the better way to do this would definitely by adding a subextension as the spec had changed. But I'd like also to ask how will GCC deal with this option, and should we make this option an alias to turn off M extension and turn on ZMMul extension?

Thu, May 27, 3:00 AM · Restricted Project, Restricted Project
luismarques added a comment to D102852: [RISCV] Fix a crash when lowering split float arguments.

I'm going to try to review this soon.

Thu, May 27, 2:04 AM · Restricted Project

Wed, May 26

luismarques added inline comments to D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag..
Wed, May 26, 3:07 PM · Restricted Project, Restricted Project
luismarques added a comment to D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.

We have Zmmul extension in the ISA spec now, that's equivalent to -mno-div , so I suggest we should go forward to implement that extension rather than -mno-div.
https://github.com/riscv/riscv-isa-manual/pull/648

Wed, May 26, 2:06 PM · Restricted Project, Restricted Project
luismarques added reviewers for D102535: [RISCV] -mno-relax: emit .option norelax: asb, luismarques.
Wed, May 26, 1:30 PM · Restricted Project
luismarques added reviewers for D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division: luismarques, jrtc27.
Wed, May 26, 9:57 AM · Restricted Project, Restricted Project
luismarques added inline comments to D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division.
Wed, May 26, 9:56 AM · Restricted Project, Restricted Project
luismarques accepted D103004: [llvm-mc] Add -M to replace -riscv-no-aliases and -riscv-arch-reg-names.

I'm not very happy that we now have to consistently check two variables (error-prone, etc.), but I suppose that's OK if we are going to remove -riscv-no-aliases soon.
Other than that, the patch LGTM.

Wed, May 26, 8:55 AM · Restricted Project

May 13 2021

luismarques added a comment to D102398: [RISCV] Optimize or/xor with immediate in Zbs extension.

We need to optimize integer materialization, both in general and to take advantage of bitmanip. I suppose that the baseline test would be less bad if we had done that, but that this optimization would still be worth it?

May 13 2021, 1:54 PM · Restricted Project
luismarques added a comment to D101919: RISCV: add a few deprecated aliases for CSRs.

I'll put this patch on the agenda for the sync-up call today, but particularly now it emits a warning I'm inclined to think we should accept this in order to provide drop-in compatibility for GNU toolchains.

May 13 2021, 1:33 PM · Restricted Project
luismarques added a comment to D98101: [RISCV] Enable the LocalStackSlotAllocation pass support.

I've benchmarked the impact of this patch with CoreMark and Embench and it looked good. In summary, there were no or minimal performance differences but there were various small improvements to code size, which are probably similar to your test case.
I was going to add other checks like running the llvm test suite but the patch no longer applies. Can you refresh it?

May 13 2021, 7:28 AM · Restricted Project

May 11 2021

luismarques accepted D100924: [test-suite][CSKY] Add Architecture Detection for C-SKY.

I'm not the best person to review test-suite patches, but I also don't see how this could be wrong, so I'm approving it.

May 11 2021, 3:21 PM
luismarques added a comment to D101875: [RISCV] Prefer to lower MC_GlobalAddress operands to .Lfoo$local.

There are also Clang test failures that need to be addressed before committing.

May 11 2021, 5:48 AM · Restricted Project
luismarques added a comment to D101875: [RISCV] Prefer to lower MC_GlobalAddress operands to .Lfoo$local.

There are also Clang test failures that need to be addressed before committing.

May 11 2021, 5:31 AM · Restricted Project

May 10 2021

luismarques accepted D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV.

LGTM.

May 10 2021, 3:10 PM · Restricted Project
luismarques accepted D101875: [RISCV] Prefer to lower MC_GlobalAddress operands to .Lfoo$local.

I assume the update_llc_test_checks.py issue that @aymanmus mentioned in D73228 was fixed a long while ago?

May 10 2021, 2:09 PM · Restricted Project

Apr 29 2021

luismarques added inline comments to D101485: [RISCV] Teach DAG combine to fold (and (select_cc lhs, rhs, cc, -1, c), x) -> (select_cc lhs, rhs, cc, x, (and, x, c)).
Apr 29 2021, 8:56 AM · Restricted Project
luismarques updated the diff for D62732: [RISCV] Add SystemV ABI.

Address review feedback.

Apr 29 2021, 4:42 AM · Restricted Project
luismarques accepted D101485: [RISCV] Teach DAG combine to fold (and (select_cc lhs, rhs, cc, -1, c), x) -> (select_cc lhs, rhs, cc, x, (and, x, c)).

LGTM.

Apr 29 2021, 3:40 AM · Restricted Project

Apr 28 2021

luismarques accepted D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

LGTM. Thank you!

Apr 28 2021, 4:28 PM · Restricted Project
luismarques added a comment to D62732: [RISCV] Add SystemV ABI.

Any update on the testing strategy yet? It seems like that this is actively being used and worked on, so I'm generally supportive of landing this with some elementary coverage.

Apr 28 2021, 3:10 PM · Restricted Project
luismarques updated the diff for D62732: [RISCV] Add SystemV ABI.

Rebase and fix the unwinding issue reported by @jade.

Apr 28 2021, 5:17 AM · Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

Have you had a chance to look over it?

Apr 28 2021, 3:46 AM · Restricted Project

Apr 27 2021

luismarques added a comment to D62732: [RISCV] Add SystemV ABI.

These files are also available as a gist, which can be grabbed with: git clone https://gist.github.com/e2efac2f780ed820277dbaf608805f4e lldb-riscv-repro

Apr 27 2021, 9:58 AM · Restricted Project
luismarques added a comment to D101342: [SelectionDAG][Mips][PowerPC][RISCV][WebAssembly] Teach computeKnownBits/ComputeNumSignBits about atomics.

The SelectionDAG changes LGTM.

Apr 27 2021, 2:30 AM · Restricted Project

Apr 15 2021

luismarques accepted D100532: [RISCV] Don't emit save-restore call if function is a interrupt handler.

Thanks, good catch. LGTM.

Apr 15 2021, 2:31 AM · Restricted Project

Apr 13 2021

luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

No worries. I just noticed my latest "pref" diff mistakenly changed the initial StackAlign from max(align(ArgValueVT), align(Outs[i].ArgVT)) to max(prefalign(ArgValueVT), prefalign(ArgValueVT)). I now think that this is where the diffs came from. The align of the Outs[i].ArgVT type is often likely larger than the split type (like i128 vs. XLEN), so by removing it we reduce the stack size.

Right now I suspect I should revert this back to the preferred alignment of Outs[i].ArgVT so we're at least keeping the same alignment (or safely increasing it to the split type). Any thoughts?

Apr 13 2021, 3:32 AM · Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

Thanks. Also, it seems I was wrong, you do sometimes get smaller stack sizes despite getPrefTypeAlign >= getEVTAlign. Weird.

Yeah it's interesting. Sorry, I haven't had time to investigate yet. I'll do that today. Have you taken a look, by any chance?

Apr 13 2021, 3:07 AM · Restricted Project

Apr 7 2021

luismarques added a comment to D98932: [RISCV] Don't call setHasMultipleConditionRegisters(), so icmp is sunk.

Could you please clean up the test a bit? It contains references to attribute groups that don't actually exist (#0, #1). One attribute you do want to add is nounwind, to avoid the clutter caused by the CFI directives. In manually written tests we also generally don't include some of those dso_local, local_unnamed_addr, etc. In general, it would be nice to make it look less like Clang's output and more like something that can be easily read and reasoned about.

Apr 7 2021, 2:07 PM · Restricted Project
luismarques retitled D97897: [MSan][RISCV] Add RISCV64 support for MSan from [MSan][RISCV] Add RISC-V support for MSan to [MSan][RISCV] Add RISCV64 support for MSan.
Apr 7 2021, 6:27 AM · Restricted Project, Restricted Project
luismarques retitled D97897: [MSan][RISCV] Add RISCV64 support for MSan from [MSan][RISCV][Draft] Draft implementation of MSan RISC-V support to [MSan][RISCV] Add RISC-V support for MSan.
Apr 7 2021, 3:23 AM · Restricted Project, Restricted Project
luismarques updated the diff for D97897: [MSan][RISCV] Add RISCV64 support for MSan.

Optimize address mappings.

Apr 7 2021, 3:16 AM · Restricted Project, Restricted Project

Apr 6 2021

luismarques committed rGb09df246cad9: [lit testing] Fix xfail-cl.py test worker count (authored by luismarques).
[lit testing] Fix xfail-cl.py test worker count
Apr 6 2021, 12:48 PM
luismarques closed D99858: [lit testing] Fix xfail-cl.py test worker count.
Apr 6 2021, 12:48 PM · Restricted Project
luismarques committed rG0c3bc1f3a477: [ASan][RISCV] Fix RISC-V memory mapping (authored by luismarques).
[ASan][RISCV] Fix RISC-V memory mapping
Apr 6 2021, 12:46 PM
luismarques closed D97646: [ASan][RISCV] Fix RISC-V memory mapping.
Apr 6 2021, 12:46 PM · Restricted Project, Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

Yes, fair enough. I've updated the diff to use the preferred type alignment. We can always revert for whatever reason. I'll try and take a look through the diffs later.

Apr 6 2021, 3:19 AM · Restricted Project

Apr 5 2021

luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

Hmm good catch. Shame there's no DAG wrapper for that method; targets don't typically use it. I could look into it before merging, if you like?

Using the preferred type align does produce changes in 7 of our tests. Maybe we should leave it to a follow-up patch? We'd be best verifying that each is correct.

Apr 5 2021, 5:07 AM · Restricted Project
luismarques accepted D95025: [RISCV] Add a test showing incorrect codegen.

Once update_mir_test_checks.py is tweaked we can start using it for this test, but let's merge it as-is for now. Thanks!

Apr 5 2021, 1:51 AM · Restricted Project

Apr 4 2021

luismarques abandoned D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
Apr 4 2021, 9:47 AM · Restricted Project
luismarques added a comment to D97514: [SystemZ] Assign the full space for promoted and split outgoing args.

Just a heads-up about a possible pitfall of this patch, though I'm not sure it actually affects SystemZ.

Apr 4 2021, 9:45 AM · Restricted Project
luismarques updated the diff for D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).

Fixing alignment before truly abandoning, in case it's useful for D97514.

Apr 4 2021, 9:38 AM · Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

BTW, it shouldn't affect correctness but the original CreateStackTemporary would use (as part of that method's implementation) getPrefTypeAlign instead of getEVTAlign. In principle that would allow better alignment choices, although at the moment it probably would never make any difference.

Apr 4 2021, 9:17 AM · Restricted Project
luismarques abandoned D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).

Abandoned in favor of D99087. Thanks @frasercrmck!

Apr 4 2021, 8:33 AM · Restricted Project
luismarques requested review of D99858: [lit testing] Fix xfail-cl.py test worker count.
Apr 4 2021, 3:06 AM · Restricted Project

Apr 1 2021

luismarques accepted D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

LGTM.

Apr 1 2021, 10:10 AM · Restricted Project

Mar 31 2021

luismarques committed rGa8cf32baf57d: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager (authored by luismarques).
[RISCV] Add XFAIL riscv32 for known issue with the old pass manager
Mar 31 2021, 7:19 AM
luismarques closed D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager.
Mar 31 2021, 7:19 AM · Restricted Project

Mar 30 2021

luismarques added a reviewer for D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager: aaronpuchert.
Mar 30 2021, 3:12 PM · Restricted Project
luismarques committed rGeb4967c8bd34: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests (authored by luismarques).
[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests
Mar 30 2021, 1:21 PM
luismarques closed D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.
Mar 30 2021, 1:20 PM · Restricted Project
luismarques updated the diff for D97897: [MSan][RISCV] Add RISCV64 support for MSan.

Address review feedback (thanks @MaskRay!).

Mar 30 2021, 1:12 PM · Restricted Project, Restricted Project
luismarques updated the diff for D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.

Rebased.
Tested with the sanitizer-x86_64-linux-android and sanitizer-windows buildbots, so this time there shouldn't be buildbot failures when committing.

Mar 30 2021, 12:55 PM · Restricted Project
luismarques updated the diff for D97897: [MSan][RISCV] Add RISCV64 support for MSan.
  • Add VarArg handling.
  • Adjust tests.
Mar 30 2021, 8:16 AM · Restricted Project, Restricted Project

Mar 23 2021

luismarques added a comment to D92464: [compiler-rt][builtins][RISCV] Port __clear_cache to RISC-V baremetal.

@sequencer What's the plan for this patch?

Mar 23 2021, 7:36 AM · Restricted Project
luismarques added a comment to D99087: [RISCV] Fix stack slot for argument types (Bug 49500).

There are certainly fewer changes to existing tests, compared with

D99068. But if @luismarques is right in that there is excessive stack
alignment then this patch needs further work.

Mar 23 2021, 5:58 AM · Restricted Project
luismarques accepted D98877: [RISCV] Use selectImm for RV32. NFC.

LGTM.

Mar 23 2021, 3:17 AM · Restricted Project

Mar 22 2021

luismarques updated the summary of D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager.
Mar 22 2021, 2:10 PM · Restricted Project
luismarques requested review of D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager.
Mar 22 2021, 2:08 PM · Restricted Project
luismarques updated the diff for D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
  • Precommitted the original test, to better show the difference caused by the patch.
  • Updated the existing tests. They seem to more broadly show the issue I noted about the excessive alignment/overly conservative stack size.
Mar 22 2021, 8:24 AM · Restricted Project
luismarques committed rG20f845d7c9a6: [RISCV][NFC] Add test of stack slot sizes of large split arguments (authored by luismarques).
[RISCV][NFC] Add test of stack slot sizes of large split arguments
Mar 22 2021, 6:41 AM
luismarques added a comment to D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).

My fix was more direct: I went over ArgValue and all of the SDValue PartValue = OutVals[i + 1]; as in the loop later in this block, and summed up all of the required getStoreSizes of their VTs, and took the maximum required alignment of each. Then created a stack temporary of that summed size and max alignment. I wasn't sufficiently happy with it and since I didn't get much indication that this was an urgent fix I didn't put it up for discussion - sorry about that. I can share my patch with you if you're interested.

Mar 22 2021, 4:57 AM · Restricted Project
luismarques added a comment to D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).

Does this happen to fix D95025? It's certainly in a similar area as my (WIP) fix that I never got round to publishing.

Mar 22 2021, 4:38 AM · Restricted Project
luismarques added inline comments to D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
Mar 22 2021, 4:18 AM · Restricted Project
luismarques updated the summary of D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
Mar 22 2021, 4:09 AM · Restricted Project
luismarques edited reviewers for D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500), added: mundaym; removed: Michael.
Mar 22 2021, 4:06 AM · Restricted Project
luismarques requested review of D99068: [RISCV][WIP][RFC] Fix stack slot for argument type sizes not a multiple of 64 bits (Bug 49500).
Mar 22 2021, 4:06 AM · Restricted Project

Mar 20 2021

luismarques abandoned D91052: [WebAssembly] Fix NaN handling when converting FP types.

Superseded by D77384 and D97490.
I can confirm that the mips* XFAIL now passes (since D77384 landed on Feb 26). If wasm contributors are still interested in reviewing this patch I can update it to include only the immediate.ll test update.

Mar 20 2021, 4:07 AM · Restricted Project

Mar 18 2021

luismarques added a comment to D98113: [Driver] Also search FilePaths for compiler-rt before falling back.

I just looked at this again and I don't have the full context in my mind right now but won't the test just exercise the BareMetal toolchain and not your changes?

Mar 18 2021, 8:50 AM · Restricted Project

Mar 17 2021

luismarques added a comment to D97646: [ASan][RISCV] Fix RISC-V memory mapping.

It's rather recommendation then requirement. Feel free to commit as is.

Mar 17 2021, 2:15 PM · Restricted Project, Restricted Project
luismarques committed rG6b025da443a4: [Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp (authored by luismarques).
[Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp
Mar 17 2021, 8:58 AM
luismarques closed D96956: [Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp.
Mar 17 2021, 8:58 AM · Restricted Project
luismarques added a comment to D96956: [Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp.

That's bad, but I don't see a better easy way to fix that.
Maybe you create some separate sanitizer_common_test_runtime lib.

Mar 17 2021, 8:55 AM · Restricted Project
luismarques updated the diff for D96956: [Sanitizer] Fix debug builds of sanitizer_stacktrace_test.cpp.

Address review feedback.

Mar 17 2021, 8:54 AM · Restricted Project
luismarques added a comment to D97646: [ASan][RISCV] Fix RISC-V memory mapping.

LGTM, but better if someone with RISCV experience checks this too

Mar 17 2021, 8:14 AM · Restricted Project, Restricted Project
luismarques added a comment to D95025: [RISCV] Add a test showing incorrect codegen.

Hm, I guess ideally we'd have an option for update_mir_test_checks.py to emit the stack info. I'll see if I can do that later today.

Mar 17 2021, 7:40 AM · Restricted Project
luismarques reopened D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.

Before relanding, I need to check/fix the SizeClassAllocator64PopulateFreeListOOM test for Android x86, as the respective buildbot failed in the first landing attempt.

Mar 17 2021, 6:49 AM · Restricted Project
luismarques updated the diff for D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests.

Fix silly mistake in the last update.

Mar 17 2021, 6:46 AM · Restricted Project

Mar 16 2021

luismarques added a comment to D97916: [Driver][RISCV] Support parsing multi-lib config from GCC..

This still doesn't report that the multilib configuration came from GCC when it succeeds, does it? I suppose that's not a deal-breaker, but it would be nice to have. Would it be difficult to implement?

Mar 16 2021, 2:00 PM · Restricted Project
luismarques accepted D98669: [RISCV] Make empty name symbols SF_FormatSpecific so that llvm-symbolizer ignores them for symbolization.

LGTM. Thanks!

Mar 16 2021, 1:37 PM · Restricted Project
luismarques added a comment to D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization.

Could you recheck? (I am quite certain it fixes your case)

Mar 16 2021, 1:34 PM · Restricted Project
luismarques added inline comments to D98683: [RISCV] Improve i32 UADDSAT/USUBSAT on RV64..
Mar 16 2021, 7:06 AM · Restricted Project
luismarques added a comment to D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization.

With -g or -fasynchronous-unwind-tables, .debug_frame/.eh_frame has a label below _start. Its address is _start + 2 and its name is empty.
Neither addr2line nor llvm-symbolizer skips such a symbol with empty name.

Mar 16 2021, 5:56 AM · Restricted Project
luismarques accepted D98683: [RISCV] Improve i32 UADDSAT/USUBSAT on RV64..
Mar 16 2021, 5:45 AM · Restricted Project
luismarques added a comment to D98683: [RISCV] Improve i32 UADDSAT/USUBSAT on RV64..

LGTM.

Mar 16 2021, 5:31 AM · Restricted Project

Mar 15 2021

luismarques added a comment to D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization.

This broke debug info for RISC-V. Test case with broken symbolization:

Mar 15 2021, 3:23 PM · Restricted Project
luismarques added a reverting change for rGa00347b56e36: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests: rGa149812d0edf: Revert "[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests".
Mar 15 2021, 6:03 AM
luismarques committed rGa149812d0edf: Revert "[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests" (authored by luismarques).
Revert "[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests"
Mar 15 2021, 6:03 AM
luismarques added a reverting change for D97234: [Sanitizer][RISCV][AArch64][Android] Adjust allocator tests: rGa149812d0edf: Revert "[Sanitizer][RISCV][AArch64][Android] Adjust allocator tests".
Mar 15 2021, 6:03 AM · Restricted Project