Page MenuHomePhabricator

brad (Brad Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 20 2016, 8:58 AM (287 w, 1 d)

Recent Activity

Yesterday

brad committed rG37ccfc55ab4f: [Sparc] Have test use IAS (authored by brad).
[Sparc] Have test use IAS
Sun, May 22, 10:23 PM · Restricted Project, Restricted Project

Fri, May 20

brad added a reviewer for D101694: [SPARC] Fix type for i64 inline asm operands: koakuma.
Fri, May 20, 4:09 PM · Restricted Project, Restricted Project

Thu, May 19

brad added a comment to D101694: [SPARC] Fix type for i64 inline asm operands.

@dcederman ?

Thu, May 19, 9:54 PM · Restricted Project, Restricted Project

Wed, May 18

brad committed rG3d869c88bb91: [Sparc] Make sure that we really don't emit quad-precision unless the "hard… (authored by kettenis).
[Sparc] Make sure that we really don't emit quad-precision unless the "hard…
Wed, May 18, 5:13 PM · Restricted Project, Restricted Project
brad closed D119104: [Sparc] Make sure that we really don't emit quad-precision unless the "hard-quad-float" feature is available.
Wed, May 18, 5:12 PM · Restricted Project, Restricted Project

Sat, May 14

brad updated the diff for D87219: [ELF] Merge .openbsd.randomdata.* sections into a single .openbsd.randomdata section when linking.

Add test.

Sat, May 14, 11:54 PM · Restricted Project, Restricted Project
brad abandoned D125598: [compiler-rt][builtins] {u,}{div,mod}si3 for Sparc64.

For these routines, ISTM the performance is not the critical part but maintainability is probably the most important metric. We should just use the portable C implementation.

Sat, May 14, 9:46 PM · Restricted Project, Restricted Project, Restricted Project

Fri, May 13

brad added a reviewer for D125598: [compiler-rt][builtins] {u,}{div,mod}si3 for Sparc64: MaskRay.
Fri, May 13, 11:28 PM · Restricted Project, Restricted Project, Restricted Project
brad updated subscribers of D125598: [compiler-rt][builtins] {u,}{div,mod}si3 for Sparc64.
Fri, May 13, 9:38 PM · Restricted Project, Restricted Project, Restricted Project
brad updated subscribers of D124600: [compiler-rt][builtins] Add helper functions for uint16/sint16/uint8/sint8 div&mod.
Fri, May 13, 9:37 PM · Restricted Project, Restricted Project
brad updated the diff for D125598: [compiler-rt][builtins] {u,}{div,mod}si3 for Sparc64.

Wrong diff posted.

Fri, May 13, 9:33 PM · Restricted Project, Restricted Project, Restricted Project
brad requested review of D125598: [compiler-rt][builtins] {u,}{div,mod}si3 for Sparc64.
Fri, May 13, 9:32 PM · Restricted Project, Restricted Project, Restricted Project
brad updated the diff for D119104: [Sparc] Make sure that we really don't emit quad-precision unless the "hard-quad-float" feature is available.

Thanks to Koakuma for providing a test.

Fri, May 13, 5:22 PM · Restricted Project, Restricted Project

Fri, May 6

brad committed rG67b0b02ec9f2: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in… (authored by brad).
[libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in…
Fri, May 6, 10:15 PM · Restricted Project, Restricted Project
brad closed D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers.
Fri, May 6, 10:14 PM · Restricted Project, Restricted Project
brad committed rGed85de6db44e: [libcxx] random_device, use arc4random() on Solaris (authored by brad).
[libcxx] random_device, use arc4random() on Solaris
Fri, May 6, 10:01 PM · Restricted Project, Restricted Project
brad closed D125068: [libcxx] random_device, use arc4random() on Solaris.
Fri, May 6, 10:01 PM · Restricted Project, Restricted Project

Thu, May 5

brad requested review of D125068: [libcxx] random_device, use arc4random() on Solaris.
Thu, May 5, 7:57 PM · Restricted Project, Restricted Project
brad added a comment to D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers.

Any guidance as to how I should proceed?

Thu, May 5, 2:32 PM · Restricted Project, Restricted Project

Sun, May 1

brad committed rGa132e527f251: [Driver][Ananas] -r: imply -nostdlib like GCC (authored by brad).
[Driver][Ananas] -r: imply -nostdlib like GCC
Sun, May 1, 9:29 PM · Restricted Project, Restricted Project
brad closed D124729: [Driver][Ananas] -r: imply -nostdlib like GCC.
Sun, May 1, 9:28 PM · Restricted Project, Restricted Project
brad updated the diff for D124729: [Driver][Ananas] -r: imply -nostdlib like GCC.

Updated with feedback.

Sun, May 1, 9:26 PM · Restricted Project, Restricted Project
brad added inline comments to D124729: [Driver][Ananas] -r: imply -nostdlib like GCC.
Sun, May 1, 5:45 PM · Restricted Project, Restricted Project

Sat, Apr 30

brad requested review of D124729: [Driver][Ananas] -r: imply -nostdlib like GCC.
Sat, Apr 30, 11:13 PM · Restricted Project, Restricted Project

Wed, Apr 27

brad committed rG3d7da810e4a6: [Driver][Solaris] -r: imply -nostdlib like GCC (authored by brad).
[Driver][Solaris] -r: imply -nostdlib like GCC
Wed, Apr 27, 9:20 PM · Restricted Project, Restricted Project
brad closed D124356: [Driver][Solaris] -r: imply -nostdlib like GCC.
Wed, Apr 27, 9:20 PM · Restricted Project, Restricted Project

Mon, Apr 25

brad added inline comments to D124356: [Driver][Solaris] -r: imply -nostdlib like GCC.
Mon, Apr 25, 12:58 AM · Restricted Project, Restricted Project
brad updated the diff for D124356: [Driver][Solaris] -r: imply -nostdlib like GCC.

Update test

Mon, Apr 25, 12:48 AM · Restricted Project, Restricted Project

Sun, Apr 24

brad requested review of D124356: [Driver][Solaris] -r: imply -nostdlib like GCC.
Sun, Apr 24, 9:15 PM · Restricted Project, Restricted Project
brad committed rGd13f5023891c: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD (authored by brad).
[libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD
Sun, Apr 24, 6:49 PM · Restricted Project, Restricted Project
brad closed D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD.
Sun, Apr 24, 6:49 PM · Restricted Project, Restricted Project
brad added a reviewer for D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers: ro.
Sun, Apr 24, 11:35 AM · Restricted Project, Restricted Project

Apr 23 2022

brad added a comment to D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers.

but I like to see the feedback of the maintainers of the affected systems before approving.

Apr 23 2022, 11:29 AM · Restricted Project, Restricted Project

Apr 21 2022

brad committed rG7898c79b742f: Fix test for c7ee0b8bda8b32a800bc01e9151b364446a6e1b1 (authored by brad).
Fix test for c7ee0b8bda8b32a800bc01e9151b364446a6e1b1
Apr 21 2022, 11:28 PM · Restricted Project, Restricted Project
brad committed rGc7ee0b8bda8b: [Clang] Fix the guaranteed alignment of memory returned by malloc/new on OpenBSD (authored by kettenis).
[Clang] Fix the guaranteed alignment of memory returned by malloc/new on OpenBSD
Apr 21 2022, 11:04 PM · Restricted Project, Restricted Project
brad added a reviewer for D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD: devnexen.
Apr 21 2022, 9:04 PM · Restricted Project, Restricted Project
brad requested review of D124227: [libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support headers.
Apr 21 2022, 8:57 PM · Restricted Project, Restricted Project
brad added a comment to D123845: [BPF] Enable IAS in backend.

The UseIntegratedAssembler = false is added with the following commit,

commit d2e5157c1f0b1953c5166c1d656ac71e840615a4
Author: Fangrui Song <i@maskray.me>
Date:   Sat Apr 11 10:01:36 2020 -0700

    [MC] Add UseIntegratedAssembler = false. NFC

Do you know what changed to remove UseIntegratedAssembler = false;? Does this change has any real impact on BPF backend?

Apr 21 2022, 8:28 PM · Restricted Project, Restricted Project
brad committed rGa0d40a579a6f: [libcxx] Add some missing xlocale wrapper functions for OpenBSD (authored by brad).
[libcxx] Add some missing xlocale wrapper functions for OpenBSD
Apr 21 2022, 5:16 PM · Restricted Project, Restricted Project
brad closed D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.
Apr 21 2022, 5:16 PM · Restricted Project, Restricted Project

Apr 20 2022

brad added a comment to D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.

ping.

Apr 20 2022, 6:57 PM · Restricted Project, Restricted Project

Apr 15 2022

brad added a reviewer for D123096: [Hexagon] Enable IAS in the Hexagon backend: sidneym.
Apr 15 2022, 1:43 AM · Restricted Project, Restricted Project
brad added a reviewer for D123845: [BPF] Enable IAS in backend: yonghong-song.
Apr 15 2022, 1:40 AM · Restricted Project, Restricted Project
brad requested review of D123845: [BPF] Enable IAS in backend.
Apr 15 2022, 1:37 AM · Restricted Project, Restricted Project
brad committed rGafa7c5ddc6bd: [WebAssembly] Remove TODO comment for IAS, NFC (authored by brad).
[WebAssembly] Remove TODO comment for IAS, NFC
Apr 15 2022, 1:32 AM · Restricted Project, Restricted Project
brad committed rG5206c2c167ed: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault… (authored by brad).
[Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault…
Apr 15 2022, 12:56 AM · Restricted Project, Restricted Project
brad closed D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC.
Apr 15 2022, 12:56 AM · Restricted Project, Restricted Project

Apr 14 2022

brad requested review of D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC.
Apr 14 2022, 11:12 PM · Restricted Project, Restricted Project
brad committed rG8cf83e96591b: [VE][compiler-rt] Correct location of VE support in clear_cache function, NFC (authored by brad).
[VE][compiler-rt] Correct location of VE support in clear_cache function, NFC
Apr 14 2022, 12:51 PM · Restricted Project, Restricted Project
brad closed D123439: [VE][compiler-rt] Correct location of VE support in clear_cache function, NFC.
Apr 14 2022, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
brad added a comment to D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.

ping.

Apr 14 2022, 12:42 PM · Restricted Project, Restricted Project
brad added a comment to D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD.

@mgorny ? @krytarowski ?

Apr 14 2022, 12:35 PM · Restricted Project, Restricted Project
brad added a reviewer for D123439: [VE][compiler-rt] Correct location of VE support in clear_cache function, NFC: MaskRay.
Apr 14 2022, 12:33 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2022

brad committed rG376c2df0baeb: [Driver] Sort Generic_GCC::IsIntegratedAssemblerDefault, NFC (authored by brad).
[Driver] Sort Generic_GCC::IsIntegratedAssemblerDefault, NFC
Apr 13 2022, 11:42 PM · Restricted Project, Restricted Project
brad committed rG71d88b4ba8b0: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC… (authored by brad).
[Clang] Move Hexagon / VE IAS enabling to Generic_GCC…
Apr 13 2022, 8:56 PM · Restricted Project, Restricted Project
brad closed D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC.
Apr 13 2022, 8:56 PM · Restricted Project, Restricted Project

Apr 12 2022

brad retitled D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC from [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault to [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC.
Apr 12 2022, 8:53 PM · Restricted Project, Restricted Project

Apr 11 2022

brad updated the diff for D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC.

Update after CSKy addition.

Apr 11 2022, 10:12 PM · Restricted Project, Restricted Project
brad added reviewers for D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD: mgorny, joerg.
Apr 11 2022, 9:12 PM · Restricted Project, Restricted Project
brad committed rGee4c235386a3: [CSKY] Remove redundant enabling of IAS for Clang, NFC (authored by brad).
[CSKY] Remove redundant enabling of IAS for Clang, NFC
Apr 11 2022, 7:42 PM · Restricted Project, Restricted Project
brad closed D123431: [CSKY] Remove redundant enabling of IAS for Clang, NFC.
Apr 11 2022, 7:42 PM · Restricted Project, Restricted Project

Apr 8 2022

brad requested review of D123439: [VE][compiler-rt] Correct location of VE support in clear_cache function, NFC.
Apr 8 2022, 8:57 PM · Restricted Project, Restricted Project, Restricted Project
brad requested review of D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC.
Apr 8 2022, 8:45 PM · Restricted Project, Restricted Project
brad updated the diff for D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.

Update based on feedback.

Apr 8 2022, 8:38 PM · Restricted Project, Restricted Project
brad updated the diff for D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD.

Add release note.

Apr 8 2022, 7:49 PM · Restricted Project, Restricted Project
brad requested review of D123431: [CSKY] Remove redundant enabling of IAS for Clang, NFC.
Apr 8 2022, 6:45 PM · Restricted Project, Restricted Project

Apr 6 2022

brad added inline comments to D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.
Apr 6 2022, 5:02 PM · Restricted Project, Restricted Project
brad added a comment to D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.

I wonder whether this only affects OpenBSD or other platforms as well. If it also affects other platforms should these functions be here or in _support/xlocale/__strtonum_fallback.h?

Apr 6 2022, 4:57 PM · Restricted Project, Restricted Project

Apr 5 2022

brad added a comment to D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD.

@emaste ? @krytarowski ?

Apr 5 2022, 10:33 PM · Restricted Project, Restricted Project
brad added a comment to D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.

ping.

Apr 5 2022, 10:31 PM · Restricted Project, Restricted Project

Apr 4 2022

brad committed rG4875ff1dc90b: [RISCV] Remove redundant enabling of IAS for Clang, NFC (authored by brad).
[RISCV] Remove redundant enabling of IAS for Clang, NFC
Apr 4 2022, 8:45 PM · Restricted Project, Restricted Project
brad closed D123097: [RISCV] Remove redundant enabling of IAS for Clang, NFC.
Apr 4 2022, 8:45 PM · Restricted Project, Restricted Project
brad retitled D123097: [RISCV] Remove redundant enabling of IAS for Clang, NFC from [RISCV] Remove redundant enabling of IAS for Clang to [RISCV] Remove redundant enabling of IAS for Clang, NFC.
Apr 4 2022, 4:36 PM · Restricted Project, Restricted Project
brad requested review of D123097: [RISCV] Remove redundant enabling of IAS for Clang, NFC.
Apr 4 2022, 4:15 PM · Restricted Project, Restricted Project
brad requested review of D123096: [Hexagon] Enable IAS in the Hexagon backend.
Apr 4 2022, 4:13 PM · Restricted Project, Restricted Project

Apr 1 2022

brad committed rGd369dd1c0660: [clang][Sparc] Enable IAS on the remaining OS's (authored by brad).
[clang][Sparc] Enable IAS on the remaining OS's
Apr 1 2022, 11:23 PM · Restricted Project, Restricted Project

Mar 31 2022

brad updated the diff for D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.

Formatting and style fixes.

Mar 31 2022, 8:54 PM · Restricted Project, Restricted Project
brad requested review of D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD.
Mar 31 2022, 8:27 PM · Restricted Project, Restricted Project

Mar 28 2022

brad requested review of D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD.
Mar 28 2022, 7:59 PM · Restricted Project, Restricted Project
brad added a comment to D122522: [libcxx] random_device, specify optimal entropy properties for all OS's using arc4random().

Thanks for noticing! We should also cherry-pick this to release/14.x, let me know if you want me to do it.

Mar 28 2022, 7:48 PM · Restricted Project, Restricted Project
brad committed rG6e2c6c9def39: [libcxx] random_device, specify optimal entropy properties for all OS's using… (authored by brad).
[libcxx] random_device, specify optimal entropy properties for all OS's using…
Mar 28 2022, 7:44 PM · Restricted Project, Restricted Project
brad closed D122522: [libcxx] random_device, specify optimal entropy properties for all OS's using arc4random().
Mar 28 2022, 7:44 PM · Restricted Project, Restricted Project

Mar 25 2022

brad requested review of D122522: [libcxx] random_device, specify optimal entropy properties for all OS's using arc4random().
Mar 25 2022, 10:01 PM · Restricted Project, Restricted Project

Mar 10 2022

brad added a reviewer for D101694: [SPARC] Fix type for i64 inline asm operands: dcederman.
Mar 10 2022, 1:40 PM · Restricted Project, Restricted Project

Mar 9 2022

brad committed rG9abeb80e80d0: [Driver][OpenBSD] Disable unwind tables on Arm (authored by brad).
[Driver][OpenBSD] Disable unwind tables on Arm
Mar 9 2022, 5:34 PM · Restricted Project
brad set the repository for D101694: [SPARC] Fix type for i64 inline asm operands to rG LLVM Github Monorepo.
Mar 9 2022, 12:56 PM · Restricted Project, Restricted Project

Mar 8 2022

Herald added a project to D102575: [SPARC][MC] Support more relocation types: Restricted Project.

LemonBoy seems to have disappeared for the time being. Anyway of moving this forward?

Mar 8 2022, 2:14 PM · Restricted Project, Restricted Project
Herald added a project to D118450: [RuntimeDyld] Handle SPARC: Restricted Project.

@lhames ?

Mar 8 2022, 2:11 PM · Restricted Project, Restricted Project

Feb 27 2022

brad committed rGbcbb03754ef1: [Driver][OpenBSD] Enable unwind tables on all architectures (authored by mortimer).
[Driver][OpenBSD] Enable unwind tables on all architectures
Feb 27 2022, 4:46 PM

Feb 23 2022

brad added a comment to D120381: [Triple] Add llvm::Triple::isSPARC{,32,64}.

Since sparcv9 is Bi-endianness (https://en.wikipedia.org/wiki/Endianness#Bi-endianness), I add "sparcv9el" like on MIPS. If it is not OK, I can delete it.

Feb 23 2022, 11:34 PM · Restricted Project

Feb 21 2022

brad committed rG8d9eeb03b3e9: [Driver][OpenBSD] Add comments for C++ tests (authored by brad).
[Driver][OpenBSD] Add comments for C++ tests
Feb 21 2022, 9:48 PM
brad committed rG289b725051cf: [Driver][OpenBSD] Test tweaking and clean up (authored by brad).
[Driver][OpenBSD] Test tweaking and clean up
Feb 21 2022, 8:47 PM
brad committed rG95fed2b267ee: [Driver][OpenBSD] Pass sysroot to the linker (authored by brad).
[Driver][OpenBSD] Pass sysroot to the linker
Feb 21 2022, 8:13 PM
brad committed rG3fa2e66c10aa: [libunwind] Further fix for 32-bit PowerPC processors without AltiVec (authored by kernigh).
[libunwind] Further fix for 32-bit PowerPC processors without AltiVec
Feb 21 2022, 12:32 PM
brad closed D120197: [libunwind] Further fix for 32-bit PowerPC processors without AltiVec.
Feb 21 2022, 12:31 PM · Restricted Project, Restricted Project, Restricted Project

Feb 19 2022

brad abandoned D102527: [RISCV] Add missing emulated TLS support.
Feb 19 2022, 7:52 PM · Restricted Project
brad added a comment to D102527: [RISCV] Add missing emulated TLS support.

You should really implement proper TLS. Emulated TLS is a lazy, inefficient hack.

Feb 19 2022, 7:52 PM · Restricted Project
brad updated the summary of D120197: [libunwind] Further fix for 32-bit PowerPC processors without AltiVec.
Feb 19 2022, 4:47 PM · Restricted Project, Restricted Project, Restricted Project
brad requested review of D120197: [libunwind] Further fix for 32-bit PowerPC processors without AltiVec.
Feb 19 2022, 4:40 PM · Restricted Project, Restricted Project, Restricted Project

Feb 17 2022

brad committed rGf374c8ddf2dd: [clangd] Fix building SerializationTests unit test on OpenBSD (authored by brad).
[clangd] Fix building SerializationTests unit test on OpenBSD
Feb 17 2022, 9:18 AM