Page MenuHomePhabricator
People brad

brad (Brad Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 20 2016, 8:58 AM (331 w, 5 h)

Recent Activity
View All

Yesterday

brad updated the diff for D146891: [Driver][NetBSD] Simplify NetBSD version handling.
Sat, Mar 25, 10:08 PM · Restricted Project, Restricted Project
brad updated the diff for D146891: [Driver][NetBSD] Simplify NetBSD version handling.
Sat, Mar 25, 8:49 PM · Restricted Project, Restricted Project
brad requested review of D146891: [Driver][NetBSD] Simplify NetBSD version handling.
Sat, Mar 25, 5:45 PM · Restricted Project, Restricted Project

Fri, Mar 24

brad committed rT6b926a5e2ca0: Remove some whitespace. NFC (authored by brad).
Remove some whitespace. NFC
Fri, Mar 24, 4:46 PM · Restricted Project

Wed, Mar 22

brad added a comment to D144012: [SPARC][MC] Fix encoding of backwards BPr branches.

@jrtc27 Ping?

Wed, Mar 22, 9:56 PM · Restricted Project, Restricted Project
brad committed rT09df1596d63e: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD… (authored by brad).
[test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD…
Wed, Mar 22, 9:54 PM · Restricted Project
brad closed D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX.
Wed, Mar 22, 9:54 PM · Restricted Project
brad added a comment to D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX.
In D146374#4215315, @daltenty wrote:

Thanks, LGTM from the AIX perspective (noting though this benchmark was actually disabled for AIX by https://reviews.llvm.org/D103063 for other source issues)

Wed, Mar 22, 9:52 PM · Restricted Project
brad accepted D146387: [test-suite] Avoid segfault in CLAMR test on non-Linux systems.
Wed, Mar 22, 8:16 PM · Restricted Project
brad added a comment to D146387: [test-suite] Avoid segfault in CLAMR test on non-Linux systems.

BTW, there is some whitespace on 629.

Wed, Mar 22, 8:15 PM · Restricted Project
brad added a comment to D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX.

@daltenty Ping?

Wed, Mar 22, 5:39 PM · Restricted Project

Sun, Mar 19

brad committed rT89253c0847a6: [test-suite] Fix OpenBSD build (authored by brad).
[test-suite] Fix OpenBSD build
Sun, Mar 19, 4:03 AM · Restricted Project
brad closed D146373: [test-suite] Fix OpenBSD build.
Sun, Mar 19, 4:03 AM · Restricted Project
brad updated the summary of D146373: [test-suite] Fix OpenBSD build.
Sun, Mar 19, 4:02 AM · Restricted Project
brad added inline comments to D146373: [test-suite] Fix OpenBSD build.
Sun, Mar 19, 3:57 AM · Restricted Project
brad updated the summary of D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX.
Sun, Mar 19, 3:47 AM · Restricted Project
brad added a reviewer for D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX: emaste.
Sun, Mar 19, 3:38 AM · Restricted Project

Sat, Mar 18

brad added a reviewer for D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX: daltenty.
Sat, Mar 18, 11:16 PM · Restricted Project
brad requested review of D146374: [test-suite] Disable CLAMR fmemopen() substitute function on FreeBSD / OpenBSD and AIX.
Sat, Mar 18, 7:58 PM · Restricted Project
brad requested review of D146373: [test-suite] Fix OpenBSD build.
Sat, Mar 18, 7:55 PM · Restricted Project
brad accepted D146251: [test-suite] Fix FreeBSD and OpenBSD builds.
Sat, Mar 18, 4:58 PM · Restricted Project
brad added a comment to D146251: [test-suite] Fix FreeBSD and OpenBSD builds.
In D146251#4204317, @dim wrote:

Yes, <tgmath.h> is also available on macOS, but it is unnecessary, even on Linux. Using just <math.h> should be sufficient, because the only math function used is hypot(3) which works on doubles by default. There is really no need to pull in the tricky macro machinery from tgmath here.

Sat, Mar 18, 4:49 PM · Restricted Project
brad added a comment to D144012: [SPARC][MC] Fix encoding of backwards BPr branches.

@jrtc27 Ping?

Sat, Mar 18, 3:14 PM · Restricted Project, Restricted Project

Fri, Mar 17

brad added a comment to D146251: [test-suite] Fix FreeBSD and OpenBSD builds.

Looks like all three OS's have tgmath.h as well. Why not just make this

Fri, Mar 17, 12:08 AM · Restricted Project

Sun, Mar 12

brad committed rGeee590ca4ba2: Revert "[SPARC] Lower BR_CC to BPr on 64-bit target whenever possible" (authored by brad).
Revert "[SPARC] Lower BR_CC to BPr on 64-bit target whenever possible"
Sun, Mar 12, 12:21 AM · Restricted Project, Restricted Project
brad added a reverting change for rG6590a372fa3f: [SPARC] Lower BR_CC to BPr on 64-bit target whenever possible: rGeee590ca4ba2: Revert "[SPARC] Lower BR_CC to BPr on 64-bit target whenever possible".
Sun, Mar 12, 12:21 AM · Restricted Project, Restricted Project
brad added a reverting change for D142461: [SPARC] Lower BR_CC to BPr on 64-bit target whenever possible: rGeee590ca4ba2: Revert "[SPARC] Lower BR_CC to BPr on 64-bit target whenever possible".
Sun, Mar 12, 12:20 AM · Restricted Project, Restricted Project

Sat, Mar 11

brad added a comment to D142461: [SPARC] Lower BR_CC to BPr on 64-bit target whenever possible.
In D142461#4186922, @koakuma wrote:

Sorry, just noticed that this was being merged, but can we postpone/revert it at least until D144012 is also merged, @brad?

Sat, Mar 11, 11:11 PM · Restricted Project, Restricted Project
brad committed rG6590a372fa3f: [SPARC] Lower BR_CC to BPr on 64-bit target whenever possible (authored by koakuma).
[SPARC] Lower BR_CC to BPr on 64-bit target whenever possible
Sat, Mar 11, 3:54 PM · Restricted Project, Restricted Project
brad closed D142461: [SPARC] Lower BR_CC to BPr on 64-bit target whenever possible.
Sat, Mar 11, 3:53 PM · Restricted Project, Restricted Project
brad committed rG24e300190a57: [SPARC] Implement hooks for conditional branch relaxation (authored by koakuma).
[SPARC] Implement hooks for conditional branch relaxation
Sat, Mar 11, 2:42 PM · Restricted Project, Restricted Project
brad closed D142458: [SPARC] Implement hooks for conditional branch relaxation.
Sat, Mar 11, 2:42 PM · Restricted Project, Restricted Project
brad added a comment to D143708: [RISCV] Support emulated TLS.

@jrtc27 Ping?

Sat, Mar 11, 1:15 PM · Restricted Project, Restricted Project

Fri, Mar 10

brad added a comment to D142458: [SPARC] Implement hooks for conditional branch relaxation.

@arsenm Ping?

Fri, Mar 10, 2:52 PM · Restricted Project, Restricted Project
brad committed rG13a10e7ec90a: [Driver][FreeBSD] Simplify ARM handling (authored by brad).
[Driver][FreeBSD] Simplify ARM handling
Fri, Mar 10, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
brad closed D144823: [Driver][FreeBSD] Simplify ARM handling.
Fri, Mar 10, 1:13 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 7

brad added a comment to D141189: [Mips] Set setMaxAtomicSizeInBitsSupported.

Just wanted to point out this recent github bug report..

Tue, Mar 7, 11:32 PM · Restricted Project, Restricted Project
brad added a comment to D144823: [Driver][FreeBSD] Simplify ARM handling.

@emaste Ping?

Tue, Mar 7, 12:58 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Mar 4

brad added a comment to D144823: [Driver][FreeBSD] Simplify ARM handling.

ping.

Sat, Mar 4, 3:10 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Feb 27

brad added a comment to D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64.
In D144232#4155966, @adalava wrote:

I agree with D144321, sorry for the late reply. @pkubaj and @brad , thanks for pushing it. I think D144232 can be abandoned, right?

Mon, Feb 27, 12:03 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Feb 26

brad committed rG19f74c911246: [Driver][OpenBSD] Simplify command-line option handling. NFC (authored by brad).
[Driver][OpenBSD] Simplify command-line option handling. NFC
Sun, Feb 26, 7:49 AM · Restricted Project, Restricted Project
brad updated the diff for D144823: [Driver][FreeBSD] Simplify ARM handling.

Missing header part of diff.

Sun, Feb 26, 5:31 AM · Restricted Project, Restricted Project, Restricted Project
brad requested review of D144823: [Driver][FreeBSD] Simplify ARM handling.
Sun, Feb 26, 4:36 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Feb 25

brad committed rG4dd4eb939cae: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD… (authored by brad).
[Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD…
Sat, Feb 25, 5:36 PM · Restricted Project, Restricted Project
brad closed D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases.
Sat, Feb 25, 5:36 PM · Restricted Project, Restricted Project
brad added a comment to D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases.
In D144778#4152443, @dim wrote:

LGTM, are there no test cases which are affected by this?

Sat, Feb 25, 5:32 PM · Restricted Project, Restricted Project

Fri, Feb 24

brad requested review of D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases.
Fri, Feb 24, 10:51 PM · Restricted Project, Restricted Project

Feb 21 2023

brad committed rGcfca5f4d0c36: [Driver][FreeBSD] Fix DWARF test after 2a2c0fd96757871f4e8052624000c208cc574fdf (authored by brad).
[Driver][FreeBSD] Fix DWARF test after 2a2c0fd96757871f4e8052624000c208cc574fdf
Feb 21 2023, 11:54 AM · Restricted Project, Restricted Project
brad committed rGdad3741e3bdc: [PowerPC] clang-format isPPC64ELFv2ABI() function. NFC (authored by brad).
[PowerPC] clang-format isPPC64ELFv2ABI() function. NFC
Feb 21 2023, 11:43 AM · Restricted Project, Restricted Project
brad committed rG2a2c0fd96757: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a… (authored by brad).
[Driver][FreeBSD] Correct driver behavior if a triple is provided without a…
Feb 21 2023, 11:15 AM · Restricted Project, Restricted Project
brad committed rG5d585c9dd07d: [PowerPC] Use member function to determine PowerPC Secure PLT (authored by brad).
[PowerPC] Use member function to determine PowerPC Secure PLT
Feb 21 2023, 11:15 AM · Restricted Project, Restricted Project, Restricted Project
brad closed D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version.
Feb 21 2023, 11:14 AM · Restricted Project, Restricted Project
brad closed D144444: [PowerPC] Use member function to determine PowerPC Secure PLT.
Feb 21 2023, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
brad updated the diff for D144444: [PowerPC] Use member function to determine PowerPC Secure PLT.

rename function and clang-format.

Feb 21 2023, 10:15 AM · Restricted Project, Restricted Project, Restricted Project
brad updated the diff for D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version.
Feb 21 2023, 12:37 AM · Restricted Project, Restricted Project

Feb 20 2023

brad updated the diff for D144444: [PowerPC] Use member function to determine PowerPC Secure PLT.
Feb 20 2023, 7:51 PM · Restricted Project, Restricted Project, Restricted Project
brad added a reviewer for D144444: [PowerPC] Use member function to determine PowerPC Secure PLT: dim.
Feb 20 2023, 6:28 PM · Restricted Project, Restricted Project, Restricted Project
brad requested review of D144444: [PowerPC] Use member function to determine PowerPC Secure PLT.
Feb 20 2023, 6:26 PM · Restricted Project, Restricted Project, Restricted Project
brad retitled D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version from [Driver][FreeBSD] Correct usage of --hash-style=both with triple without version to [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version.
Feb 20 2023, 4:59 PM · Restricted Project, Restricted Project
brad updated the diff for D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version.
Feb 20 2023, 4:55 PM · Restricted Project, Restricted Project
brad committed rG4b09cb2b16eb: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI (authored by brad).
[PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI
Feb 20 2023, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
brad closed D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI.
Feb 20 2023, 3:11 PM · Restricted Project, Restricted Project, Restricted Project
brad updated the diff for D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI.
Feb 20 2023, 12:38 AM · Restricted Project, Restricted Project, Restricted Project

Feb 19 2023

brad added inline comments to D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI.
Feb 19 2023, 4:50 PM · Restricted Project, Restricted Project, Restricted Project

Feb 18 2023

brad added a reviewer for D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version: emaste.
Feb 18 2023, 10:14 PM · Restricted Project, Restricted Project
brad retitled D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version from [Driver][FreeBSD] to [Driver][FreeBSD] Correct usage of --hash-style=both with triple without version.
Feb 18 2023, 10:11 PM · Restricted Project, Restricted Project
brad requested review of D144341: [Driver][FreeBSD] Correct driver behavior if a triple is provided without a version.
Feb 18 2023, 10:10 PM · Restricted Project, Restricted Project
brad added inline comments to D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI.
Feb 18 2023, 5:15 PM · Restricted Project, Restricted Project, Restricted Project
brad updated the diff for D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI.

reformatting.

Feb 18 2023, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
brad updated the diff for D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI.
Feb 18 2023, 4:02 PM · Restricted Project, Restricted Project, Restricted Project

Feb 17 2023

brad added a comment to D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64.

I noticed this review. I have provided a more complete diff for review at D144321.

Feb 17 2023, 10:45 PM · Restricted Project, Restricted Project, Restricted Project
brad requested review of D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI.
Feb 17 2023, 10:44 PM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2023

brad added a comment to D143708: [RISCV] Support emulated TLS.
In D143708#4133064, @MaskRay wrote:

I have a mild objection but I am fine if my opinion is overthrown. I think OpenBSD developers should take on the work to migrate to ELF TLS, not using this definitely.

-femulated-tls can be used for the current *-linux-android* and *-openbsd* target triples, and OpenBSD RISC-V, but not others. The test should be changed to use openbsd, not linux-gnu.

If we ever encounter features using TLS that are difficult to work with emulated TLS, acceptance of this patch doesn't mean that we want to accept additional complexity.

Feb 16 2023, 8:15 PM · Restricted Project, Restricted Project

Feb 10 2023

Herald added a project to D63904: [Android] Use ELF TLS for Android API level 29+: Restricted Project.

I happened to come across. What about revisiting this now that the NDK has had LLD as the default since r22? Which is approaching 2 years old.

Feb 10 2023, 4:51 PM · Restricted Project, Restricted Project
brad added a comment to D143619: [llvm][codegen] Disallow default Emulated TLS for RISCV.
In D143619#4115147, @luismarques wrote:

Does this mean that Android, OpenBSD, and Cygwin have emulated TLS support for all supported architectures other than RISC-V?

Feb 10 2023, 11:51 AM · Restricted Project, Restricted Project

Feb 4 2023

brad added a comment to D142458: [SPARC] Implement hooks for conditional branch relaxation.

@jrtc27 ?

Feb 4 2023, 5:32 PM · Restricted Project, Restricted Project

Feb 3 2023

brad added inline comments to D141189: [Mips] Set setMaxAtomicSizeInBitsSupported.
Feb 3 2023, 12:15 PM · Restricted Project, Restricted Project

Feb 2 2023

brad added a comment to D141189: [Mips] Set setMaxAtomicSizeInBitsSupported.

ping.

Feb 2 2023, 10:34 PM · Restricted Project, Restricted Project

Jan 21 2023

brad added a comment to D141189: [Mips] Set setMaxAtomicSizeInBitsSupported.

ping.

Jan 21 2023, 4:50 PM · Restricted Project, Restricted Project

Jan 17 2023

brad added inline comments to D141189: [Mips] Set setMaxAtomicSizeInBitsSupported.
Jan 17 2023, 1:02 PM · Restricted Project, Restricted Project
brad added a comment to D141189: [Mips] Set setMaxAtomicSizeInBitsSupported.

ping.

Jan 17 2023, 12:40 PM · Restricted Project, Restricted Project

Jan 13 2023

brad added a comment to D140658: [AMDGPU] Enable IAS in the AMDGPU backend.
In D140658#4016867, @arsenm wrote:

I didn't realize this was off. Can you add some object output run lines to the inline asm tests? I don't think we have any of those

Jan 13 2023, 8:04 PM · Restricted Project, Restricted Project
brad added a reviewer for D141189: [Mips] Set setMaxAtomicSizeInBitsSupported: MaskRay.
Jan 13 2023, 3:30 PM · Restricted Project, Restricted Project
brad added a comment to D138135: [lld][ELF] Support LoongArch.

With the backend enabled, it would be good to work on this further.

Jan 13 2023, 9:26 AM · Restricted Project, Restricted Project
brad updated the diff for D141189: [Mips] Set setMaxAtomicSizeInBitsSupported.

Use update_llc_test_checks.py to update test.

Jan 13 2023, 7:52 AM · Restricted Project, Restricted Project

Jan 12 2023

brad committed rWa7911e1a02d0: Also update this for 15.0.7 (authored by brad).
Also update this for 15.0.7
Jan 12 2023, 10:01 PM · Restricted Project
brad committed rW5c23112e60d3: 15.0.7 Release (authored by brad).
15.0.7 Release
Jan 12 2023, 9:52 PM · Restricted Project
brad committed rGa5c9a51bf456: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I (authored by brad).
[mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I
Jan 12 2023, 6:08 AM · Restricted Project, Restricted Project
brad closed D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I.
Jan 12 2023, 6:08 AM · Restricted Project, Restricted Project

Jan 8 2023

brad added a reviewer for D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I: MaskRay.
Jan 8 2023, 11:39 AM · Restricted Project, Restricted Project
brad accepted D141208: libc++: bring back the unsigned in the return type in wcstoull_l.

Sorry about that.

Jan 8 2023, 2:25 AM · Restricted Project, Restricted Project

Jan 7 2023

brad requested review of D141189: [Mips] Set setMaxAtomicSizeInBitsSupported.
Jan 7 2023, 12:56 AM · Restricted Project, Restricted Project
brad requested review of D141187: [SystemZ] Set setMaxAtomicSizeInBitsSupported.
Jan 7 2023, 12:24 AM · Restricted Project, Restricted Project

Jan 6 2023

brad added a reviewer for D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I: sdardis.
Jan 6 2023, 11:52 PM · Restricted Project, Restricted Project
brad requested review of D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I.
Jan 6 2023, 11:31 PM · Restricted Project, Restricted Project

Jan 5 2023

brad committed rG7f5648824667: Fix for tests on Windows buildbot (authored by brad).
Fix for tests on Windows buildbot
Jan 5 2023, 6:26 PM · Restricted Project, Restricted Project
brad committed rG8fd279f7d369: [Driver] move Fuchsia header search path management to the driver (authored by brad).
[Driver] move Fuchsia header search path management to the driver
Jan 5 2023, 6:21 PM · Restricted Project, Restricted Project
brad closed D141073: [Driver] move Fuchsia header search path management to the driver.
Jan 5 2023, 6:21 PM · Restricted Project, Restricted Project
brad committed rGf70d17fc2c10: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros (authored by brad).
[LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros
Jan 5 2023, 5:21 PM · Restricted Project, Restricted Project
brad closed D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.
Jan 5 2023, 5:21 PM · Restricted Project, Restricted Project