ABataev (Alexey Bataev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2013, 4:40 AM (233 w, 4 d)

Recent Activity

Today

ABataev committed rL308883: [OPENMP] Fix the restrictions for in_reduction clause..
[OPENMP] Fix the restrictions for in_reduction clause.
Mon, Jul 24, 7:54 AM

Fri, Jul 21

ABataev committed rL308773: [OPENMP] Fix build problem, NFC..
[OPENMP] Fix build problem, NFC.
Fri, Jul 21, 12:29 PM
ABataev committed rL308771: [OPENMP] Add ast-print tests for in_reduction clause, NFC..
[OPENMP] Add ast-print tests for in_reduction clause, NFC.
Fri, Jul 21, 11:56 AM
ABataev committed rL308768: [OPENMP] Initial support for 'in_reduction' clause..
[OPENMP] Initial support for 'in_reduction' clause.
Fri, Jul 21, 11:49 AM
ABataev committed rL308759: [OPENMP] Simplify analysis of data-sharing attributes..
[OPENMP] Simplify analysis of data-sharing attributes.
Fri, Jul 21, 10:25 AM

Thu, Jul 20

ABataev committed rL308629: [OPENMP] Fix DSA processing for member declaration..
[OPENMP] Fix DSA processing for member declaration.
Thu, Jul 20, 9:49 AM

Tue, Jul 18

ABataev committed rL308352: [OPENMP] Initial support for 'task_reduction' clause..
[OPENMP] Initial support for 'task_reduction' clause.
Tue, Jul 18, 1:18 PM
ABataev committed rL308317: [OPENMP] Generalization of sema analysis of reduction-based clauses,.
[OPENMP] Generalization of sema analysis of reduction-based clauses,
Tue, Jul 18, 8:33 AM

Mon, Jul 17

ABataev committed rL308243: [OPENMP] Pacify windows buildbots, NFC..
[OPENMP] Pacify windows buildbots, NFC.
Mon, Jul 17, 5:43 PM
ABataev committed rL308183: [OPENMP] Fix reduction combiner test.
[OPENMP] Fix reduction combiner test
Mon, Jul 17, 7:53 AM
ABataev committed rL308182: [OPENMP] Further fixes of the reduction codegen tests.
[OPENMP] Further fixes of the reduction codegen tests
Mon, Jul 17, 7:48 AM
ABataev committed rL308178: [OPENMP] Further test fixes..
[OPENMP] Further test fixes.
Mon, Jul 17, 7:23 AM
ABataev committed rL308176: [OPENMP] Rework tests to pacify buildbots..
[OPENMP] Rework tests to pacify buildbots.
Mon, Jul 17, 7:07 AM
ABataev committed rL308174: [OPENMP] Codegen for reduction clauses in 'taskloop' directives..
[OPENMP] Codegen for reduction clauses in 'taskloop' directives.
Mon, Jul 17, 6:31 AM

Thu, Jul 13

ABataev committed rL307916: [OPENMP] Fix reduction tests, NFC..
[OPENMP] Fix reduction tests, NFC.
Thu, Jul 13, 8:15 AM
ABataev committed rL307915: [OPENMP] Fix reduction tests, NFC..
[OPENMP] Fix reduction tests, NFC.
Thu, Jul 13, 8:09 AM
ABataev committed rL307914: [OPENMP] Further reduction test fix, NFC..
[OPENMP] Further reduction test fix, NFC.
Thu, Jul 13, 8:03 AM
ABataev committed rL307912: [OPENMP] Fix reduction tests, NFC..
[OPENMP] Fix reduction tests, NFC.
Thu, Jul 13, 7:55 AM
ABataev committed rL307911: [OPENMP] Fix reduction tests, NFC..
[OPENMP] Fix reduction tests, NFC.
Thu, Jul 13, 7:30 AM
ABataev committed rL307910: [OPENMP] Generalization of codegen for reduction clauses..
[OPENMP] Generalization of codegen for reduction clauses.
Thu, Jul 13, 6:36 AM

Wed, Jul 12

ABataev committed rL307822: [OPENMP] Emit implicit taskgroup block around taskloop directives..
[OPENMP] Emit implicit taskgroup block around taskloop directives.
Wed, Jul 12, 11:09 AM

Tue, Jul 11

ABataev committed rL307697: [OPENMP] Skip BuildMemberExpr() in BuildFieldReferenceExpr(), NFC, by Kai Noda.
[OPENMP] Skip BuildMemberExpr() in BuildFieldReferenceExpr(), NFC, by Kai Noda
Tue, Jul 11, 12:44 PM
ABataev closed D35201: [OPENMP] Skip BuildMemberExpr() in BuildFieldReferenceExpr(). NFC by committing rL307697: [OPENMP] Skip BuildMemberExpr() in BuildFieldReferenceExpr(), NFC, by Kai Noda.
Tue, Jul 11, 12:43 PM · Restricted Project, Restricted Project
ABataev committed rL307693: [OPENMP] Add restriction for reduction clause in taskloop directives..
[OPENMP] Add restriction for reduction clause in taskloop directives.
Tue, Jul 11, 12:17 PM
ABataev accepted D35201: [OPENMP] Skip BuildMemberExpr() in BuildFieldReferenceExpr(). NFC.

LG

Tue, Jul 11, 7:47 AM · Restricted Project, Restricted Project

Fri, Jun 30

ABataev retitled D34881: [SLP] Allow vectorization of the instruction from the same basic blocks only, NFC. from [SLP] Allow vectorization of the instruction from the same basic blocks only. to [SLP] Allow vectorization of the instruction from the same basic blocks only, NFC..
Fri, Jun 30, 10:08 AM
ABataev updated the diff for D34881: [SLP] Allow vectorization of the instruction from the same basic blocks only, NFC..

Update

Fri, Jun 30, 10:07 AM
ABataev added a comment to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..

I'm working on the patch that stops vectorization if the parent basic block of the instruction is not BB or the instruction was processed already, but it's quite hard to add a test for this change. I can publish it as NFC, because we just limiting the number of analyzed instructions if this is acceptable.

Fri, Jun 30, 8:28 AM
ABataev accepted D34888: [OpenMP] Fix mapping of scalars for combined directives.

LG

Fri, Jun 30, 8:25 AM
ABataev committed rL306828: [SLP] A test for limiting vectorization of instructions, NFC..
[SLP] A test for limiting vectorization of instructions, NFC.
Fri, Jun 30, 7:38 AM
ABataev created D34881: [SLP] Allow vectorization of the instruction from the same basic blocks only, NFC..
Fri, Jun 30, 7:21 AM
ABataev committed rL306825: [OPENMP] Initial support for taskloop reductions..
[OPENMP] Initial support for taskloop reductions.
Fri, Jun 30, 6:50 AM
ABataev added a comment to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
In D33320#795834, @anna wrote:

Hi Alexey, Adam,

From what I can see in this algorithm, there is no limit on the actual size of the stack in the loop. The level variable controls just the recursion limit. So, in effect, IIUC, the max total number of operands being processed by the while loop is 2 ^ RecursionLimit (it's to the base 2 because we avoid phi nodes).

Fri, Jun 30, 6:48 AM

Thu, Jun 29

ABataev committed rL306697: [OPENMP][DEBUG] Generate second function with correct arg types..
[OPENMP][DEBUG] Generate second function with correct arg types.
Thu, Jun 29, 9:43 AM

Tue, Jun 27

ABataev committed rL306419: [OPENMP] Use MapVector instead of DenseMap for stable codegen, NFC..
[OPENMP] Use MapVector instead of DenseMap for stable codegen, NFC.
Tue, Jun 27, 8:47 AM

Jun 9 2017

ABataev committed rL305076: [DebugInfo] Fix comment, NFC..
[DebugInfo] Fix comment, NFC.
Jun 9 2017, 6:55 AM
ABataev committed rL305075: [DebugInfo] Add kind of ImplicitParamDecl for emission of FlagObjectPointer..
[DebugInfo] Add kind of ImplicitParamDecl for emission of FlagObjectPointer.
Jun 9 2017, 6:41 AM
ABataev closed D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer. by committing rL305075: [DebugInfo] Add kind of ImplicitParamDecl for emission of FlagObjectPointer..
Jun 9 2017, 6:41 AM

Jun 8 2017

ABataev updated the diff for D29402: [SLP] Initial rework for min/max horizontal reduction vectorization, NFC..

Update to trunk

Jun 8 2017, 9:43 AM
ABataev committed rL304985: [SLP] More comments fix, NFC..
[SLP] More comments fix, NFC.
Jun 8 2017, 9:42 AM
ABataev updated the diff for D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..

Removed FIXMEs and corrected comment

Jun 8 2017, 7:04 AM

Jun 7 2017

ABataev committed rL304940: [SLP] Comment fix, NFC..
[SLP] Comment fix, NFC.
Jun 7 2017, 1:38 PM
ABataev committed rL304938: [SLP] Comment fix, NFC..
[SLP] Comment fix, NFC.
Jun 7 2017, 1:28 PM
ABataev updated the diff for D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..

Update after review

Jun 7 2017, 8:54 AM
ABataev updated the diff for D29402: [SLP] Initial rework for min/max horizontal reduction vectorization, NFC..

Update after review.

Jun 7 2017, 8:53 AM
ABataev added inline comments to D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..
Jun 7 2017, 7:58 AM
ABataev added inline comments to D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..
Jun 7 2017, 7:48 AM
ABataev updated the diff for D33954: [SLP] Fix for PR32164: Improve vectorization of reverse order of extract operations..

Improved reordering criteria.

Jun 7 2017, 6:38 AM

Jun 6 2017

ABataev retitled D33954: [SLP] Fix for PR32164: Improve vectorization of reverse order of extract operations. from [ARM] GlobalISel: Constrain callee register on indirect calls to [SLP] Fix for PR32164: Improve vectorization of reverse order of extract operations..
Jun 6 2017, 2:01 PM
ABataev updated the summary of D33954: [SLP] Fix for PR32164: Improve vectorization of reverse order of extract operations..
Jun 6 2017, 1:43 PM
ABataev created D33954: [SLP] Fix for PR32164: Improve vectorization of reverse order of extract operations..
Jun 6 2017, 1:42 PM
ABataev committed rL304829: [SLP] Change extension of the test, NFC..
[SLP] Change extension of the test, NFC.
Jun 6 2017, 1:28 PM
ABataev committed rL304826: [SLP] Add a test for fix of PR32164, NFC..
[SLP] Add a test for fix of PR32164, NFC.
Jun 6 2017, 1:12 PM
ABataev updated the diff for D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..

Address John comments.

Jun 6 2017, 8:31 AM
ABataev added inline comments to D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..
Jun 6 2017, 7:34 AM

Jun 5 2017

ABataev updated the diff for D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..

Added DeclContext parameter to constructors of ImplicitParamDecl class.

Jun 5 2017, 7:01 AM

Jun 2 2017

ABataev committed rL304616: [SLP] Improve comments and naming of functions/variables/members, NFC..
[SLP] Improve comments and naming of functions/variables/members, NFC.
Jun 2 2017, 5:08 PM
ABataev committed rL304609: Revert "[SLP] Improve comments and naming of functions/variables/members, NFC.".
Revert "[SLP] Improve comments and naming of functions/variables/members, NFC."
Jun 2 2017, 4:09 PM
ABataev committed rL304593: [SLP] Improve comments and naming of functions/variables/members, NFC..
[SLP] Improve comments and naming of functions/variables/members, NFC.
Jun 2 2017, 1:39 PM
ABataev closed D33320: [SLP] Improve comments and naming of functions/variables/members, NFC. by committing rL304593: [SLP] Improve comments and naming of functions/variables/members, NFC..
Jun 2 2017, 1:39 PM
ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
Jun 2 2017, 1:20 PM
ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
Jun 2 2017, 1:08 PM
ABataev updated the diff for D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..

Update after review

Jun 2 2017, 12:49 PM
ABataev updated the diff for D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..

Added different kinds of ImplicitParamDecl.

Jun 2 2017, 12:34 PM
ABataev updated the diff for D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..

Updates after comments.

Jun 2 2017, 8:49 AM
ABataev updated the diff for D29402: [SLP] Initial rework for min/max horizontal reduction vectorization, NFC..

Update after review

Jun 2 2017, 7:37 AM
ABataev added inline comments to D29402: [SLP] Initial rework for min/max horizontal reduction vectorization, NFC..
Jun 2 2017, 7:26 AM
ABataev updated the diff for D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..

Updates after review

Jun 2 2017, 6:23 AM

Jun 1 2017

ABataev added a comment to D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..

Can you help me to understand what problem is being solved with this new attribute? Under what circumstances would the first argument be an ImplicitParamDecl but not an implicit this or self?

For captured regions an outlined function is created, where all parameters are ImplicitParamDecls. And the very first parameter is wrongly treated as 'this' argument of the member function.

Ah, thank you! That makes sense to me, but it begs the question: why an attribute rather than a bit on ImplicitParamDecl?

I agree: it would make more sense for ImplicitParamDecl to store a Kind that would always be provided at construction.

Jun 1 2017, 10:41 AM
ABataev added a comment to D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..

Can you help me to understand what problem is being solved with this new attribute? Under what circumstances would the first argument be an ImplicitParamDecl but not an implicit this or self?

Jun 1 2017, 10:21 AM
ABataev added a comment to D29641: [SLP] Fix for PR31847: Assertion failed: (isLoopInvariant(Operands[i], L) && "SCEVAddRecExpr operand is not loop-invariant!").

Hi,

I would like to understand this better. Could somebody explain what assumptions SCEV makes about its clients? Which assumption(s) is broken by SLP? It seems to me that this issue potentially touches fundamental design decisions/questions and I don't see any verifiers in place.

Thanks
Gerolf

Jun 1 2017, 9:07 AM
ABataev added a comment to D29826: [SLP] General improvements of SLP vectorization process..

Ping

Jun 1 2017, 8:59 AM
ABataev added a comment to D30200: [SLP] Fix for PR31880: shuffle and vectorize repeated scalar ops on extracted elements.

Ping

Jun 1 2017, 8:58 AM
ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
Jun 1 2017, 6:07 AM

May 31 2017

ABataev created D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer..
May 31 2017, 11:44 AM

May 30 2017

ABataev committed rL304229: [OpenMP][Driver] Put target binary for each offload target into a.
[OpenMP][Driver] Put target binary for each offload target into a
May 30 2017, 11:58 AM
ABataev closed D33254: [OpenMP][Driver] Put target binary for each offload target into a separate section by committing rL304229: [OpenMP][Driver] Put target binary for each offload target into a.
May 30 2017, 11:58 AM
ABataev committed rL304216: [OPENMP] Allow 'use_device_ptr' clause in 'target data' alone..
[OPENMP] Allow 'use_device_ptr' clause in 'target data' alone.
May 30 2017, 9:00 AM
ABataev accepted D33254: [OpenMP][Driver] Put target binary for each offload target into a separate section.

LG

May 30 2017, 7:00 AM

May 26 2017

ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
May 26 2017, 12:03 PM
ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
May 26 2017, 10:53 AM
ABataev updated the diff for D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..

Added a comment regarding assigning nullptr value to P

May 26 2017, 6:45 AM
ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
May 26 2017, 6:37 AM
ABataev accepted D33509: [OpenMP] Create COMDAT group for OpenMP offload registration code to avoid multiple copies.

LG

May 26 2017, 6:31 AM
ABataev updated subscribers of D33509: [OpenMP] Create COMDAT group for OpenMP offload registration code to avoid multiple copies.
May 26 2017, 6:30 AM

May 24 2017

ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
May 24 2017, 11:01 AM
ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
May 24 2017, 10:15 AM
ABataev added inline comments to D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
May 24 2017, 10:11 AM
ABataev committed rL303768: [OPENMP] Allow value of thread local variables in target regions..
[OPENMP] Allow value of thread local variables in target regions.
May 24 2017, 9:00 AM
ABataev updated the diff for D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..

Address comments from Adam.

May 24 2017, 7:13 AM

May 18 2017

ABataev created D33320: [SLP] Improve comments and naming of functions/variables/members, NFC..
May 18 2017, 9:33 AM
ABataev abandoned D32093: [InstCombine] PR32078: convert scalar operations to vector..

Need cost analysis for this kind of transformation, moving it back to SLP vectorizer.

May 18 2017, 8:24 AM
ABataev reclaimed D30686: [SLP] PR32078: convert scalar operations to vector..

Michael, tried to implement it in InstCombiner, but we need cost analysis. Later passes are not suitable for this, because we need transformed code in InstCombiner. So, reopened it.

May 18 2017, 8:21 AM

May 15 2017

ABataev committed rL303077: [OPENMP] Check DSA for variables captured by value..
[OPENMP] Check DSA for variables captured by value.
May 15 2017, 9:39 AM

May 11 2017

ABataev added inline comments to D25517: [SLPVectorizer] Improved support of partial tree vectorization..
May 11 2017, 6:18 AM

May 3 2017

ABataev accepted D32807: [OpenMP] Extended parse for 'always' map modifier.

LG

May 3 2017, 8:29 AM

Apr 27 2017

ABataev committed rL301549: [OPENMP] Add a check for iterator not reached the end of stack, NFC..
[OPENMP] Add a check for iterator not reached the end of stack, NFC.
Apr 27 2017, 8:23 AM
ABataev committed rL301547: [OPENMP] Improve performance of the hasDSA() function, NFC..
[OPENMP] Improve performance of the hasDSA() function, NFC.
Apr 27 2017, 7:59 AM

Apr 26 2017

ABataev committed rL301417: [OPENMP] Fix failing test..
[OPENMP] Fix failing test.
Apr 26 2017, 8:43 AM
ABataev committed rL301416: [OPENMP] Fix handling of OpenMP code during template instantiation..
[OPENMP] Fix handling of OpenMP code during template instantiation.
Apr 26 2017, 8:19 AM