Page MenuHomePhabricator

ABataev (Alexey Bataev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2013, 4:40 AM (416 w, 4 d)

Recent Activity

Wed, Jan 20

ABataev added a comment to D95062: [libomptarget][devicertl][nfc] Simplify target_atomic abstraction.

None of the three atomic operations provided by OpenMP, read, write, and update, sound like similar semantics as the four operations here.

Please finish reading the section about atomics (https://www.openmp.org/spec-html/5.1/openmpsu105.html#x138-1480002.19.7). All of the above operations are expressible, as far as I can tell.
add and inc are atomic update, exchange is atomic capture, max and cas are atomic compare, all with appropriate expression statement following them.

Wed, Jan 20, 1:35 PM · Restricted Project

Tue, Jan 19

ABataev committed rGb272698de790: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives. (authored by ABataev).
[OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.
Tue, Jan 19, 12:45 PM
ABataev closed D91261: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives..
Tue, Jan 19, 12:44 PM · Restricted Project
ABataev requested review of D94992: [SLP]Merge reorder and reuse shuffles..
Tue, Jan 19, 12:21 PM · Restricted Project
ABataev added a comment to D94972: [SLP]Need to shrink the load vector after reordering..

Hmm?

Tue, Jan 19, 12:15 PM · Restricted Project
ABataev abandoned D94972: [SLP]Need to shrink the load vector after reordering..
Tue, Jan 19, 12:11 PM · Restricted Project
ABataev added a reverting change for rG438682de6a38: [SLP]Merge reorder and reuse shuffles.: rGe463bd53c03f: Revert "[SLP]Merge reorder and reuse shuffles.".
Tue, Jan 19, 11:52 AM
ABataev committed rGe463bd53c03f: Revert "[SLP]Merge reorder and reuse shuffles." (authored by ABataev).
Revert "[SLP]Merge reorder and reuse shuffles."
Tue, Jan 19, 11:52 AM
ABataev added a reverting change for D92668: [SLP]Merge reorder and reuse shuffles.: rGe463bd53c03f: Revert "[SLP]Merge reorder and reuse shuffles.".
Tue, Jan 19, 11:52 AM · Restricted Project
ABataev added inline comments to D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR.
Tue, Jan 19, 11:39 AM · Restricted Project, Restricted Project
ABataev added a comment to D94972: [SLP]Need to shrink the load vector after reordering..

Hard to tell because there aren't any comments around any of the code that changed in either patch. Can you fix that in a separate change and actually document what everything is doing? :)

Tue, Jan 19, 10:39 AM · Restricted Project
ABataev added a comment to D94972: [SLP]Need to shrink the load vector after reordering..

I think this would be more clear as a combined patch rather than 3 separate and some reverted patches. Would it make more sense to revert the chain and put them all back together in a single review?

Tue, Jan 19, 10:32 AM · Restricted Project
ABataev added a comment to D94972: [SLP]Need to shrink the load vector after reordering..

Is the summary correct? The patch that this is fixing isn't reverted...

It's not clear what this is fixing and why it's fixing it.

Thanks!

-eric

Tue, Jan 19, 9:57 AM · Restricted Project
ABataev added inline comments to D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR.
Tue, Jan 19, 8:19 AM · Restricted Project, Restricted Project
ABataev closed D93967: [SLP]Need shrink the load vector after reordering..

If you changed the existing patch it won't be clear that this is something that needs review. Can you make a new review with the bug fix?

Thanks!

-eric

Tue, Jan 19, 7:39 AM · Restricted Project
ABataev requested review of D94972: [SLP]Need to shrink the load vector after reordering..
Tue, Jan 19, 7:37 AM · Restricted Project
ABataev added a comment to D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.

This patch was written, roughly, by:

  • copying the known-working openmp driver from rocm into the trunk source tree
  • deleting lots of stuff that didn't look necessary
  • deleting some stuff that is broadly necessary, but the specifics are up for debate

The idea is to move language-independent but amdgcn-specific code into ROCMToolChain. Some has already gone in, others (like computeMSVCVersion) will likely move too.

Regarding the rest of the end to end stack:

  • host plugin works, same code in trunk / rocm / aomp
  • device plugin will work once it's building as openmp, modulo printf and malloc
  • compiler backend will work for spmd kernels today, will work for generic kernels after D94648 or equivalent lands

Regarding tests (which need the unimplemented bit filled in with the next patch):

  • Runtime tests (for spmd kernels) are working locally with a jury rigged devicertl
  • Codegen tests are proving awkward to update. Dropping line number would help, but there's still a difference in addrspace cast distribution. I'm hoping the scripts involved in generating the nvptx cases can be adapted.
Tue, Jan 19, 6:59 AM · Restricted Project
ABataev added inline comments to D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR.
Tue, Jan 19, 2:50 AM · Restricted Project, Restricted Project

Mon, Jan 18

ABataev added a comment to D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR.
Mon, Jan 18, 2:20 PM · Restricted Project, Restricted Project
ABataev accepted D94913: [SLP] match maxnum/minnum intrinsics as FP reduction ops.

LGTM

Mon, Jan 18, 11:02 AM · Restricted Project
ABataev added inline comments to D94913: [SLP] match maxnum/minnum intrinsics as FP reduction ops.
Mon, Jan 18, 8:51 AM · Restricted Project
ABataev added inline comments to D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR.
Mon, Jan 18, 4:23 AM · Restricted Project, Restricted Project

Mon, Jan 11

ABataev updated the diff for D93967: [SLP]Need shrink the load vector after reordering..

Bug fix.

Mon, Jan 11, 5:49 AM · Restricted Project

Fri, Jan 8

ABataev accepted D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment.

What we should do, as we move to the OpenMPIRBuilder, is to use runtime interfaces that match OpenMP directives.
Here is the omp parallel one for the host: D94332
The device one should look the same, potentially after extending it, as we want to apply the same logic regardless of the device.
This will also make things like parallel region merging (@ggeorgakoudis) much easier.

I would prefer to fix PR48686 with this patch though until we switch to a new interface. The part where I remove the fn argument
meddling is on it's own valuable. We should not (need to) overwrite the function attributes for performance reasons given that we
have not inserted them. The new noinline will establish the invariant D94332 is going to have as well and which makes OpenMPOpt
much simpler.

Fri, Jan 8, 1:48 PM · Restricted Project
ABataev updated the diff for D76342: [OpenMP] Implement '#pragma omp tile'.

Rework, bug fixes.

Fri, Jan 8, 1:38 PM · Restricted Project, Restricted Project
ABataev added a comment to D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment.

I don't understand where inaccessiblemem_or_argmemonly is coming from. This prevents us from inlining the outlined parallel region.

kmpc_serialized_parallel and kmpc_end_serialized_parallel functions are marked with this attribute and I think OpenMPOpt optimizes read_only functions because of this. I.e. it does not consider kmpc_serialized_parallel and kmpc_end_serialized_paralle function calls as opimization barriers.

Can you provide an example why this is a problem?

Fri, Jan 8, 10:14 AM · Restricted Project
ABataev added a comment to D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment.

I'm guessing we're using the function boundary as a compiler barrier. That seems fragile in the face of improving cross-function optimisation.

Looks like applying inaccessiblemem_or_argmemonly attribute to the OpenMP functions is way too optimistic since we still can access this (inaccessible) memory using other OpenMP functions. Not sure about the semantics of this attribute, though.

I don't understand where inaccessiblemem_or_argmemonly is coming from. This prevents us from inlining the outlined parallel region.

Fri, Jan 8, 10:09 AM · Restricted Project
ABataev added a comment to D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment.

I'm guessing we're using the function boundary as a compiler barrier. That seems fragile in the face of improving cross-function optimisation.

Fri, Jan 8, 9:37 AM · Restricted Project
ABataev updated the diff for D93967: [SLP]Need shrink the load vector after reordering..

Bug fixes

Fri, Jan 8, 6:36 AM · Restricted Project
ABataev reopened D93967: [SLP]Need shrink the load vector after reordering..
Fri, Jan 8, 6:35 AM · Restricted Project
ABataev committed rG0e57084d0efa: [SLP][NFC]Add a test for reused shrink check, NFC. (authored by ABataev).
[SLP][NFC]Add a test for reused shrink check, NFC.
Fri, Jan 8, 6:25 AM
ABataev added a comment to D93967: [SLP]Need shrink the load vector after reordering..

This caused misoptimizations for armv7, where code that previously worked correctly now produce different results. (The code is clean under ubsan, so it shouldn't be relying on anything undefined.)

The issue appears with https://martin.st/temp/interplayvideo-preproc.c, compiled with clang -target armv7-linux-gnueabihf -O2.

The diff in generated code, before/after, looks like this:

        vmov.32 d16[0], lr
        vmov.32 d16[1], r2
 .LBB27_3:                               @ %if.end
                                         @   in Loop: Header=BB27_4 Depth=1
        vmov.32 r2, d16[1]
        add     r3, r3, #1
        vmov.32 r5, d16[0]
        cmp     r3, #8
+       vdup.32 d16, d16[0]
        vmov.16 d17[1], r2
        vmov.16 d18[0], r5
        vdup.16 d21, d17[1]
        vdup.16 d20, d18[0]
        vst1.16 {d20, d21}, [r1], r12
        beq     .LBB27_9
 .LBB27_4:                               @ %for.body
                                         @ =>This Inner Loop Header: Depth=1
        tst     r3, #3
        bne     .LBB27_3

If it loops back to .LBB27_3, the vector element d16[1] no longer has the value it was expected to have.

Fri, Jan 8, 5:18 AM · Restricted Project

Thu, Jan 7

ABataev committed rG4284afdf9432: [SLP]Need shrink the load vector after reordering. (authored by ABataev).
[SLP]Need shrink the load vector after reordering.
Thu, Jan 7, 4:52 AM
ABataev closed D93967: [SLP]Need shrink the load vector after reordering..
Thu, Jan 7, 4:52 AM · Restricted Project

Wed, Jan 6

ABataev accepted D94185: [OpenMP][Docs] Mark finished features as done.

LG

Wed, Jan 6, 11:32 AM · Restricted Project

Mon, Jan 4

ABataev updated the diff for D93967: [SLP]Need shrink the load vector after reordering..

Removed outdated comment.

Mon, Jan 4, 5:40 AM · Restricted Project

Fri, Jan 1

ABataev requested review of D93967: [SLP]Need shrink the load vector after reordering..
Fri, Jan 1, 8:47 AM · Restricted Project
ABataev committed rGbf2a78fd4ae9: [SLP]Add a test for correct use of the reordered loads, NFC. (authored by ABataev).
[SLP]Add a test for correct use of the reordered loads, NFC.
Fri, Jan 1, 8:43 AM

Mon, Dec 28

ABataev added a comment to D92668: [SLP]Merge reorder and reuse shuffles..

I think I'm seeing a miscompile as a result of the patch. The issue is not the transformation itself, but a dependent instruction is reading the wrong value.

Before this patch, we have this:

  %171 = load <2 x i32>, <2 x i32>* %114, align 8
  %reorder_shuffle = shufflevector <2 x i32> %171, <2 x i32> undef, <2 x i32> <i32 1, i32 0>
  %shuffle = shufflevector <2 x i32> %reorder_shuffle, <2 x i32> undef, <4 x i32> <i32 0, i32 1, i32 0, i32 1>
...
  %186 = add nsw <2 x i32> %reorder_shuffle, <i32 -1, i32 -1>

After this patch the same snippet looks like:

  %171 = load <2 x i32>, <2 x i32>* %114, align 8
  %shuffle = shufflevector <2 x i32> %171, <2 x i32> undef, <4 x i32> <i32 1, i32 0, i32 1, i32 0>
...
  %186 = add nsw <2 x i32> %171, <i32 -1, i32 -1>

IIUC, if we suppose %171 loads the values (a, b), then:

  • In the original version, %reorder_shuffle is (b, a), so %186 is (b - 1, a - 1)
  • In the modified version, %186 reads directly from %171, so the result is (a - 1, b - 1), which is swapped

Do you know what the issue might be? I'm trying to reduce the test case so I can share more details.

Mon, Dec 28, 3:23 PM · Restricted Project

Dec 22 2020

ABataev added inline comments to D91944: OpenMP 5.0 metadirective.
Dec 22 2020, 9:35 AM · Restricted Project, Restricted Project, Restricted Project

Dec 18 2020

ABataev added a comment to D93502: DebugInfo: Make -no-dwarf-ranges-section just emit no address range rather than a bogus/partial one.

What I saw with the nvcc that it generated the debug info just like in the tests before. So, I just tried to mimic this behavior, since ptxas is very fragile and can be broken very easily. I would try to test it using ptxas/cuda-gdb to check that it does not break anything.

Oh, huh - interesting. Is it possible for me to reproduce/play around with this behavior in some way? (I've never used nvcc, not sure where to download/install it from, etc)

Dec 18 2020, 1:48 PM · Restricted Project
ABataev added a comment to D93502: DebugInfo: Make -no-dwarf-ranges-section just emit no address range rather than a bogus/partial one.

What I saw with the nvcc that it generated the debug info just like in the tests before. So, I just tried to mimic this behavior, since ptxas is very fragile and can be broken very easily. I would try to test it using ptxas/cuda-gdb to check that it does not break anything.

Dec 18 2020, 9:00 AM · Restricted Project
ABataev added inline comments to D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives.
Dec 18 2020, 8:49 AM · Restricted Project

Dec 16 2020

ABataev added a comment to D93068: [clang-offload-bundler] Add option -allow-missing-bundles.

@ABataev Is this patch OK for OpenMP? It is NFC for OpenMP toolchain but affects using clang-offload-bundler as a standalone tool. Thanks.

Dec 16 2020, 9:50 AM · Restricted Project

Dec 15 2020

ABataev accepted D92427: [OPENMP51] Add present modifier in defaultmap clause.

LG

Dec 15 2020, 10:09 AM · Restricted Project

Dec 10 2020

ABataev added a comment to D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses.

Restore original formatting in test cases that were not directly affected by the patch. Also, I would start with a single kind of expression rather than trying to cover as many kinds of expressions as possible. It makes it easier to understand and to review it.

Dec 10 2020, 9:35 AM · Restricted Project, Restricted Project
ABataev added inline comments to D92427: [OPENMP51] Add present modifier in defaultmap clause.
Dec 10 2020, 8:43 AM · Restricted Project

Dec 9 2020

ABataev added a comment to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Do you mean compile time increasing? With this patch?

no, just compile-time error.

Dec 9 2020, 12:33 PM · Restricted Project
ABataev added a comment to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

While reviewing the latest update, I think I spotted SLP compile-time failure in SingleSource/Benchmarks/Misc/oourafft.c, here is the reduced testcase to reporduce:
source_filename = "/home/dtemirbulatov/llvm/test-suite/SingleSource/Benchmarks/Misc/oourafft.c"
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"

define dso_local fastcc void @cft1st(double* %a) unnamed_addr #0 {
entry:

%0 = or i64 16, 2
%arrayidx107 = getelementptr inbounds double, double* %a, i64 %0
%1 = or i64 16, 3
%arrayidx114 = getelementptr inbounds double, double* %a, i64 %1
%2 = or i64 16, 4
%arrayidx131 = getelementptr inbounds double, double* %a, i64 %2
%3 = or i64 16, 6
%arrayidx134 = getelementptr inbounds double, double* %a, i64 %3
%4 = load double, double* %arrayidx134, align 8
%5 = or i64 16, 5
%arrayidx138 = getelementptr inbounds double, double* %a, i64 %5
%6 = or i64 16, 7
%arrayidx141 = getelementptr inbounds double, double* %a, i64 %6
%7 = load double, double* %arrayidx141, align 8
%sub149 = fsub double undef, %4
%sub156 = fsub double undef, %7
store double undef, double* %arrayidx131, align 8
store double undef, double* %arrayidx138, align 8
%sub178 = fsub double undef, %sub156
%add179 = fadd double undef, %sub149
%mul180 = fmul double undef, %sub178
%sub182 = fsub double %mul180, undef
store double %sub182, double* %arrayidx107, align 8
%mul186 = fmul double undef, %add179
%add188 = fadd double %mul186, undef
store double %add188, double* %arrayidx114, align 8
unreachable

}

attributes #0 = { "target-features"="+avx,+avx2,+bmi,+bmi2,+cx16,+cx8,+f16c,+fma,+fsgsbase,+fxsr,+invpcid,+lzcnt,+mmx,+movbe,+pclmul,+popcnt,+rdrnd,+sahf,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87,+xsave,+xsaveopt" }

!llvm.ident = !{!0}

!0 = !{!"clang version 12.0.0 (https://github.com/llvm/llvm-project.git aaa925795f93c389a96ee01bab73bc2b6b771cbb)"}

Dec 9 2020, 11:51 AM · Restricted Project
ABataev added a comment to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

AFAICT the only outstanding question is whether the compile time increase is acceptable?

I'd agree that geomean = 0.2% is acceptable for the change with such awesome performance impact, just noted that changed time compilation is significant in comparision with other changes. Generally it looks good to me apart from one minor unaddressed comment.

Could the summary of the revision be updated with the performance data? The thread is very long and I didn't spot where the measurements are, so it's hard to say what we're trading off here...

Dec 9 2020, 9:08 AM · Restricted Project

Dec 8 2020

ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Dec 8 2020, 11:03 AM · Restricted Project

Dec 7 2020

ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

General approach to fix the analysis of pointers.

Dec 7 2020, 2:23 PM · Restricted Project, Restricted Project
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Fix analysis for overlapping pointers.

Dec 7 2020, 12:27 PM · Restricted Project, Restricted Project
ABataev added a comment to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Just tried this patch and found that below test abort inside generateInfoCapture.

#include <stdio.h>
#define LEN 100
int buf[LEN];

int main()
{
    int i;
    int *p = buf;

    for (i = 0; i < LEN; i++) {
        p[i] = 0;
    }

#pragma omp target map(p) map(p[:100])
    {
        *(p+5) = 1;
    }

}
Dec 7 2020, 11:17 AM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 7 2020, 11:13 AM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 7 2020, 11:04 AM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 7 2020, 10:38 AM · Restricted Project, Restricted Project
ABataev added a comment to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 7 2020, 10:38 AM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 7 2020, 9:26 AM · Restricted Project, Restricted Project
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Dec 7 2020, 9:16 AM · Restricted Project
ABataev committed rG438682de6a38: [SLP]Merge reorder and reuse shuffles. (authored by ABataev).
[SLP]Merge reorder and reuse shuffles.
Dec 7 2020, 7:51 AM
ABataev closed D92668: [SLP]Merge reorder and reuse shuffles..
Dec 7 2020, 7:51 AM · Restricted Project
ABataev updated the diff for D92668: [SLP]Merge reorder and reuse shuffles..

Replaced += with just =

Dec 7 2020, 6:51 AM · Restricted Project
ABataev updated the diff for D92668: [SLP]Merge reorder and reuse shuffles..

Address comments

Dec 7 2020, 6:41 AM · Restricted Project
ABataev added inline comments to D92668: [SLP]Merge reorder and reuse shuffles..
Dec 7 2020, 6:41 AM · Restricted Project
ABataev updated the diff for D92668: [SLP]Merge reorder and reuse shuffles..

Updated and rebased

Dec 7 2020, 6:32 AM · Restricted Project
ABataev added inline comments to D92668: [SLP]Merge reorder and reuse shuffles..
Dec 7 2020, 6:27 AM · Restricted Project
ABataev committed rG97c08db84e3a: [SLP]Update test checks, NFC. (authored by ABataev).
[SLP]Update test checks, NFC.
Dec 7 2020, 6:20 AM

Dec 4 2020

ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 4 2020, 4:53 PM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 4 2020, 4:05 PM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 4 2020, 4:02 PM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 4 2020, 3:13 PM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 4 2020, 3:03 PM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 4 2020, 3:01 PM · Restricted Project, Restricted Project
ABataev added inline comments to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
Dec 4 2020, 2:40 PM · Restricted Project, Restricted Project
ABataev committed rGd764ad72e5fe: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs. (authored by ABataev).
[OPENMP]Fix PR48394: need to capture variables used in atomic constructs.
Dec 4 2020, 1:40 PM
ABataev closed D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs..
Dec 4 2020, 1:40 PM · Restricted Project
ABataev requested review of D92682: [OPENMP]Fix PR48394: need to capture variables used in atomic constructs..
Dec 4 2020, 1:00 PM · Restricted Project
ABataev updated the diff for D42981: [COST] Fix cost model of load instructions on X86.

Rebased ands reworked. Excluded SLM as its cost model is not quite correct.
Gives perf improvement for cpu2017.511.povray_r ~3% and improves performance up to 8% in some other cases.

Dec 4 2020, 12:04 PM · Restricted Project
ABataev accepted D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`.

LG

Dec 4 2020, 11:18 AM · Restricted Project, Restricted Project
ABataev committed rGe7fc561843ec: [TEST]Autogenerate test checks, NFC. (authored by ABataev).
[TEST]Autogenerate test checks, NFC.
Dec 4 2020, 11:02 AM
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Dec 4 2020, 10:05 AM · Restricted Project
ABataev requested review of D92668: [SLP]Merge reorder and reuse shuffles..
Dec 4 2020, 9:57 AM · Restricted Project
ABataev added inline comments to D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`.
Dec 4 2020, 9:56 AM · Restricted Project, Restricted Project
ABataev committed rG2502f8995431: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions. (authored by ABataev).
[OPENMP]Fix PR48387: disable warning messages caused by internal conversions.
Dec 4 2020, 7:49 AM
ABataev closed D92655: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions..
Dec 4 2020, 7:48 AM · Restricted Project
ABataev requested review of D92655: [OPENMP]Fix PR48387: disable warning messages caused by internal conversions..
Dec 4 2020, 6:55 AM · Restricted Project
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Dec 4 2020, 5:20 AM · Restricted Project

Dec 3 2020

ABataev added inline comments to D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`.
Dec 3 2020, 1:31 PM · Restricted Project, Restricted Project
ABataev added inline comments to D92427: [OPENMP51] Add present modifier in defaultmap clause.
Dec 3 2020, 10:23 AM · Restricted Project
ABataev added inline comments to D91944: OpenMP 5.0 metadirective.
Dec 3 2020, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D91944: OpenMP 5.0 metadirective.
Dec 3 2020, 8:41 AM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2020

ABataev added inline comments to D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`.
Dec 2 2020, 2:17 PM · Restricted Project, Restricted Project
ABataev added inline comments to D92427: [OPENMP51] Add present modifier in defaultmap clause.
Dec 2 2020, 1:51 PM · Restricted Project

Dec 1 2020

ABataev added a comment to D92409: [AST][NFC] Silence GCC warning about multiline comments.

I would just remove this extra symbol.

Dec 1 2020, 10:29 AM · Restricted Project
ABataev accepted D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..

LG

Dec 1 2020, 10:28 AM

Nov 30 2020

ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Nov 30 2020, 9:58 AM · Restricted Project

Nov 26 2020

ABataev requested review of D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers..
Nov 26 2020, 1:56 PM · Restricted Project, Restricted Project
ABataev added inline comments to D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses.
Nov 26 2020, 9:52 AM · Restricted Project, Restricted Project

Nov 25 2020

ABataev added inline comments to D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`.
Nov 25 2020, 2:29 PM · Restricted Project, Restricted Project