Page MenuHomePhabricator

ABataev (Alexey Bataev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2013, 4:40 AM (492 w, 50 m)

Recent Activity

Today

ABataev added a comment to D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument.

cleanup/destructor test missing.

@ABataev WDYT?

Thu, Jul 7, 2:28 AM · Restricted Project, Restricted Project

Fri, Jul 1

ABataev updated the diff for D126877: [SLP]Fix PR55734: SLP vectorizer's reduce_and formation introduces poison..

Reworked addition of the reduction. For logical ops, reduction result is added as a first operand,
it is safe to use it as an LHS in scalar logical ands/ors.
For others, it is added as a last operand.

Fri, Jul 1, 1:39 PM · Restricted Project, Restricted Project
ABataev committed rG34073b5538b9: [SLP][NFC]Rework the test for logical and freeze, need some extra nodes, (authored by ABataev).
[SLP][NFC]Rework the test for logical and freeze, need some extra nodes,
Fri, Jul 1, 12:44 PM · Restricted Project, Restricted Project
ABataev accepted D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

LG

Fri, Jul 1, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
ABataev committed rG48aa787ab3a4: [SLP][NFC]Add a test for logical and operands, requiring extra (authored by ABataev).
[SLP][NFC]Add a test for logical and operands, requiring extra
Fri, Jul 1, 11:54 AM · Restricted Project, Restricted Project
ABataev updated the diff for D127119: [SLP]Fix undef handling in gather function..

Fixes and improvements.

Fri, Jul 1, 9:31 AM · Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Fri, Jul 1, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Fri, Jul 1, 8:36 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 30

ABataev committed rG4be3fc35aa8b: [SLP][NFC]Cleanup up operands of the removed insertelements, NFC. (authored by ABataev).
[SLP][NFC]Cleanup up operands of the removed insertelements, NFC.
Thu, Jun 30, 5:53 PM · Restricted Project, Restricted Project
ABataev accepted D128946: [OpenMP] Initial parsing and semantic support for 'parallel masked taskloop simd' construct.

LG

Thu, Jun 30, 5:01 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..

There is another issue which I tracked down to this patch but it is kind of hidden. In order to reveal the issue please apply attached patch ( that is basically enabling expensive checks and added verifyFunction right after vectorized code generated.

Crash looks like this:
Instruction does not dominate all uses!

%41 = insertelement <4 x i32> %40, i32 %32, i32 1
%39 = insertelement <4 x i32> %41, i32 poison, i32 2

opt: /path/llvm-project/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8404: llvm::Value* llvm::slpvectorizer::BoUpSLP::vectorizeTree(): Assertion `!verifyFunction(*F, &dbgs()) && "Broken after vec"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0. Program arguments: bin/opt -slp-vectorizer -mcpu=skylake -disable-output reduced.ll

Thu, Jun 30, 2:15 PM · Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Thu, Jun 30, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D122255: Meta directive runtime support.
Thu, Jun 30, 11:37 AM · Restricted Project, Restricted Project, Restricted Project
ABataev accepted D128834: [OpenMP] Initial parsing and sema support for 'parallel masked taskloop' construct.

LG

Thu, Jun 30, 10:46 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..

There is another issue which I tracked down to this patch but it is kind of hidden. In order to reveal the issue please apply attached patch ( that is basically enabling expensive checks and added verifyFunction right after vectorized code generated.

Crash looks like this:
Instruction does not dominate all uses!

%41 = insertelement <4 x i32> %40, i32 %32, i32 1
%39 = insertelement <4 x i32> %41, i32 poison, i32 2

opt: /path/llvm-project/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8404: llvm::Value* llvm::slpvectorizer::BoUpSLP::vectorizeTree(): Assertion `!verifyFunction(*F, &dbgs()) && "Broken after vec"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0. Program arguments: bin/opt -slp-vectorizer -mcpu=skylake -disable-output reduced.ll

Thu, Jun 30, 10:43 AM · Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Thu, Jun 30, 4:10 AM · Restricted Project, Restricted Project, Restricted Project
ABataev accepted D128550: [OpenMP] Change OpenMP code generation for target region entries.

LG

Thu, Jun 30, 4:07 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a reviewer for D128834: [OpenMP] Initial parsing and sema support for 'parallel masked taskloop' construct: NoQ.
Thu, Jun 30, 4:06 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 29

ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Wed, Jun 29, 11:59 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D122255: Meta directive runtime support.
Wed, Jun 29, 7:55 AM · Restricted Project, Restricted Project, Restricted Project
ABataev accepted D127604: [SLP][X86] Add 32-bit vector stores to help vectorization opportunities.

LG

Wed, Jun 29, 5:47 AM · Restricted Project, Restricted Project

Tue, Jun 28

ABataev committed rGbf4dcbd2df00: [SLP]Fix PR56251: Do not remove the reordering from the root node, being used… (authored by ABataev).
[SLP]Fix PR56251: Do not remove the reordering from the root node, being used…
Tue, Jun 28, 1:46 PM · Restricted Project, Restricted Project
ABataev closed D128680: [SLP]Fix PR56251: Do not remove the reordering from the root node, being used as an operand..
Tue, Jun 28, 1:46 PM · Restricted Project, Restricted Project
ABataev added a comment to D128680: [SLP]Fix PR56251: Do not remove the reordering from the root node, being used as an operand..

Can you accept the patch?

Tue, Jun 28, 1:18 PM · Restricted Project, Restricted Project
ABataev updated the diff for D127119: [SLP]Fix undef handling in gather function..

Address comments.

Tue, Jun 28, 12:42 PM · Restricted Project, Restricted Project
ABataev accepted D128693: [OpenMP] Initial parsing and sema support for 'masked taskloop simd' construct.

LG

Tue, Jun 28, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D128693: [OpenMP] Initial parsing and sema support for 'masked taskloop simd' construct.
Tue, Jun 28, 8:55 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

I saw another crash on chromium builds - not sure if this is related to the previous mentioned crash but here's a creduced repro:

struct f {
  float g;
  float h;
};
struct j {
  j() = default;
  j(float k, float l) : c(k), d(l) {}
  j operator*(j k) const { return j(k.a + c, b + k.d); }
  float a = 1.0f;
  float b = 0.0f;
  float c = 0.0f;
  float d = 1.0f;
  float e = 0.0f;
};
struct m {
  j n() const;
  f o;
  j p;
};
j m::n() const {
  if (o.g || o.h)
    return j();
  j a;
  return p * a;
}

build with

clang -cc1 -O2 -vectorize-slp -emit-llvm -fno-delete-null-pointer-checks t.cpp
Tue, Jun 28, 8:37 AM · Restricted Project, Restricted Project
ABataev updated the diff for D127119: [SLP]Fix undef handling in gather function..

Address comments

Tue, Jun 28, 7:00 AM · Restricted Project, Restricted Project
ABataev updated the diff for D128680: [SLP]Fix PR56251: Do not remove the reordering from the root node, being used as an operand..

Address comment

Tue, Jun 28, 6:38 AM · Restricted Project, Restricted Project
ABataev updated the diff for D126885: [SLP]Cost for a constant buildvector..

Rebase

Tue, Jun 28, 6:36 AM · Restricted Project, Restricted Project
ABataev updated the diff for D128680: [SLP]Fix PR56251: Do not remove the reordering from the root node, being used as an operand..

Added a fix for gathers reordering

Tue, Jun 28, 5:36 AM · Restricted Project, Restricted Project

Mon, Jun 27

ABataev accepted D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests.

LG

Mon, Jun 27, 4:23 PM · Restricted Project, Restricted Project
ABataev added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

I saw another crash on chromium builds - not sure if this is related to the previous mentioned crash but here's a creduced repro:

struct f {
  float g;
  float h;
};
struct j {
  j() = default;
  j(float k, float l) : c(k), d(l) {}
  j operator*(j k) const { return j(k.a + c, b + k.d); }
  float a = 1.0f;
  float b = 0.0f;
  float c = 0.0f;
  float d = 1.0f;
  float e = 0.0f;
};
struct m {
  j n() const;
  f o;
  j p;
};
j m::n() const {
  if (o.g || o.h)
    return j();
  j a;
  return p * a;
}

build with

clang -cc1 -O2 -vectorize-slp -emit-llvm -fno-delete-null-pointer-checks t.cpp
Mon, Jun 27, 2:40 PM · Restricted Project, Restricted Project
ABataev requested review of D128680: [SLP]Fix PR56251: Do not remove the reordering from the root node, being used as an operand..
Mon, Jun 27, 1:45 PM · Restricted Project, Restricted Project
ABataev accepted D126549: [Clang][OpenMP] Don't overload "extension" in status doc.

LG

Mon, Jun 27, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

Still crashes on trunk.

C-reduce Test case:

typedef __INT64_TYPE__ int64_t;
int sbr_autocorrelate_c_x_i;
void phiautocorr_calc(int64_t );

void sbr_autocorrelate_c_x(void) {
  int(*x)[2] = sbr_autocorrelate_c_x;
  int64_t accu_re , accu_im = 0;
  for (; sbr_autocorrelate_c_x_i; sbr_autocorrelate_c_x_i++) {
    accu_re +=
        x[sbr_autocorrelate_c_x_i][0] * x[sbr_autocorrelate_c_x_i + 2][0];
    accu_re +=
        x[sbr_autocorrelate_c_x_i][1] * x[sbr_autocorrelate_c_x_i + 2][1];
    accu_im +=
        x[sbr_autocorrelate_c_x_i][0] * x[sbr_autocorrelate_c_x_i + 2][1];
    accu_im -=
        x[sbr_autocorrelate_c_x_i][1] * x[sbr_autocorrelate_c_x_i + 2][0];
  }
  phiautocorr_calc(accu_im);
  phiautocorr_calc(accu_re);
}

Crashes with
clang -Os -c test.c --target=armv7a-linux-gnueabihf -mfpu=neon -Wno-error

llvm/llvm-project/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7744: llvm::Value *llvm::slpvectorizer::BoUpSLP::createBuildVector(ArrayRef<llvm::Value *>): Assertion `any_of(VectorizableTree, [VL](const std::unique_ptr<TreeEntry> &TE) { return TE->State == TreeEntry::NeedToGather && TE->isSame(VL); }) && "Non-matching gather node."' failed.

Mon, Jun 27, 1:05 PM · Restricted Project, Restricted Project
ABataev added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

Heads up: I am seeing a clang crash on arm with this commit:

commit 2faacf61a50e7f23fd10927cbbb98c59799bfcd0
Author: Alexey Bataev <a.bataev@outlook.com>
Date: Thu Dec 9 10:34:08 2021 -0800
CommitDate: Fri Jun 24 09:28:01 2022 -0700

[SLP]Improve shuffles cost estimation where possible.

I am trying to create a reduced test case.

Mon, Jun 27, 5:45 AM · Restricted Project, Restricted Project

Fri, Jun 24

ABataev updated the diff for D127119: [SLP]Fix undef handling in gather function..

Address comments

Fri, Jun 24, 12:54 PM · Restricted Project, Restricted Project
ABataev added inline comments to D128550: [OpenMP] Change OpenMP code generation for target region entries.
Fri, Jun 24, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
ABataev updated the diff for D126885: [SLP]Cost for a constant buildvector..

Rebase

Fri, Jun 24, 10:54 AM · Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Fri, Jun 24, 10:23 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Fri, Jun 24, 10:15 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Fri, Jun 24, 9:35 AM · Restricted Project, Restricted Project, Restricted Project
ABataev committed rG2faacf61a50e: [SLP]Improve shuffles cost estimation where possible. (authored by ABataev).
[SLP]Improve shuffles cost estimation where possible.
Fri, Jun 24, 9:30 AM · Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Fri, Jun 24, 8:04 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

I more firmly believe I made a mistake. Sorry for that. You may recommit.

Fri, Jun 24, 6:44 AM · Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Fri, Jun 24, 6:35 AM · Restricted Project, Restricted Project, Restricted Project
ABataev accepted D128478: [OpenMP] Initial parsing and sema support for 'masked taskloop' construct.

LG

Fri, Jun 24, 6:29 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 23

ABataev added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

Here is -mllvm -print-changed -mllvm -print-module-scope output before SLPVectorizer: https://gist.github.com/MaskRay/23f0db50e136127fda1b4f83db2488da

Double checked the patch and the results. The patch itself does not change the vectorization, just adjusts the cost model estimation. Some of the buildvector sequences are not profitable for re-vectorization after this patch, nothing else. Plus, the code after this patch results in the same code, being applied to the compiler without the patch, i.e. the code transformations are the same, just different vectorization.

I have added IR before/after SLPVectorizer, with and without the two commits, and generated assembly to https://gist.github.com/MaskRay/23f0db50e136127fda1b4f83db2488da
Hope they are useful.

Maybe the debug info is corrupted somehow? Or there are other effects?

The codegen is corrupted. I provide debug info just in case it helps analyze the problem.

Thu, Jun 23, 1:20 PM · Restricted Project, Restricted Project
ABataev committed rG3b6edef15d27: [SLP]Fix a crash when reorder masked gather nodes with reused scalars. (authored by ABataev).
[SLP]Fix a crash when reorder masked gather nodes with reused scalars.
Thu, Jun 23, 11:33 AM · Restricted Project, Restricted Project
ABataev closed D128360: [SLP]Fix a crash when reorder masked gather nodes with reused scalars..
Thu, Jun 23, 11:33 AM · Restricted Project, Restricted Project
ABataev added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

Here is -mllvm -print-changed -mllvm -print-module-scope output before SLPVectorizer: https://gist.github.com/MaskRay/23f0db50e136127fda1b4f83db2488da

Thu, Jun 23, 10:54 AM · Restricted Project, Restricted Project
ABataev accepted D125669: Adding support for target in_reduction.

LG

Thu, Jun 23, 8:28 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Thu, Jun 23, 4:08 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D125669: Adding support for target in_reduction.

What about the description? Shall we still emit if(0)?

Can you please elaborate for more clarity?

Thu, Jun 23, 3:59 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

ABataev accepted D128397: Add handling cases when filter(tid) appears with deafult(none).

LG

Wed, Jun 22, 5:01 PM · Restricted Project, Restricted Project
ABataev updated the diff for D126885: [SLP]Cost for a constant buildvector..

Removed getConstantBuildVectorCost, the analysis for constant values already exists in getArithmeticInstrCost. Added support for const operand for stores in getMemoryOpCost function.

Wed, Jun 22, 2:16 PM · Restricted Project, Restricted Project
ABataev requested review of D128360: [SLP]Fix a crash when reorder masked gather nodes with reused scalars..
Wed, Jun 22, 10:18 AM · Restricted Project, Restricted Project
ABataev added a comment to D127531: [SLP]Improve analysis of same/alternate code ops and scheduling..

I'm not sure about how the test case affected supposed to execute the changes.
Could you please consider adding more tests to be clearer about the patch purpose?

It is for compile time mostly, nothing else. Just allows to detect gathered elements before scheduling.

Yes, but the summary also says more vector instructions generated. What specific cases are handled now but failed previously?

Wed, Jun 22, 10:16 AM · Restricted Project, Restricted Project
ABataev added a comment to D127531: [SLP]Improve analysis of same/alternate code ops and scheduling..

I'm not sure about how the test case affected supposed to execute the changes.
Could you please consider adding more tests to be clearer about the patch purpose?

Wed, Jun 22, 10:06 AM · Restricted Project, Restricted Project
ABataev added a comment to D126877: [SLP]Fix PR55734: SLP vectorizer's reduce_and formation introduces poison..

Ping!

Wed, Jun 22, 9:52 AM · Restricted Project, Restricted Project
ABataev added a comment to D126885: [SLP]Cost for a constant buildvector..

Ping!

Wed, Jun 22, 9:51 AM · Restricted Project, Restricted Project
ABataev added a comment to D127119: [SLP]Fix undef handling in gather function..

Ping!

Wed, Jun 22, 9:50 AM · Restricted Project, Restricted Project
ABataev added a comment to D127531: [SLP]Improve analysis of same/alternate code ops and scheduling..

Ping!

Wed, Jun 22, 9:49 AM · Restricted Project, Restricted Project
ABataev added inline comments to D126378: [SLP]Fix crash on reordering of ScatterVectorize nodes..
Wed, Jun 22, 6:55 AM · Restricted Project, Restricted Project
ABataev added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Wed, Jun 22, 6:53 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

ABataev committed rGd4ee43153d37: [SLP][NFC]Fix a warning in a comparison, NFC. (authored by ABataev).
[SLP][NFC]Fix a warning in a comparison, NFC.
Tue, Jun 21, 10:22 AM · Restricted Project, Restricted Project
ABataev added a comment to D125669: Adding support for target in_reduction.

What about the description? Shall we still emit if(0)?

Tue, Jun 21, 7:44 AM · Restricted Project, Restricted Project, Restricted Project
ABataev committed rGf1ee2738b3d7: [SLP]Fix a crash when insert subvector is out of range. (authored by ABataev).
[SLP]Fix a crash when insert subvector is out of range.
Tue, Jun 21, 7:19 AM · Restricted Project, Restricted Project
ABataev closed D128071: [SLP]Fix a crash when insert subvector is out of range..
Tue, Jun 21, 7:19 AM · Restricted Project, Restricted Project

Fri, Jun 17

ABataev updated the diff for D128071: [SLP]Fix a crash when insert subvector is out of range..

Adjust OffsetBeg for better shuffle mask estimation.

Fri, Jun 17, 1:14 PM · Restricted Project, Restricted Project
ABataev requested review of D128071: [SLP]Fix a crash when insert subvector is out of range..
Fri, Jun 17, 10:25 AM · Restricted Project, Restricted Project

Thu, Jun 16

ABataev updated the diff for D126885: [SLP]Cost for a constant buildvector..

Address comments

Thu, Jun 16, 1:03 PM · Restricted Project, Restricted Project
ABataev committed rG76782a65ee86: [SLP]Use original vector if need to shuffle truncated root. (authored by ABataev).
[SLP]Use original vector if need to shuffle truncated root.
Thu, Jun 16, 10:41 AM · Restricted Project, Restricted Project
ABataev closed D127974: [SLP]Use original vector if need to shuffle truncated root..
Thu, Jun 16, 10:41 AM · Restricted Project, Restricted Project
ABataev added inline comments to D126885: [SLP]Cost for a constant buildvector..
Thu, Jun 16, 10:17 AM · Restricted Project, Restricted Project
ABataev added a comment to D127855: [OpenMP] Basic parse and sema support for modifiers in order clause .

provide full context of the changes.

Thu, Jun 16, 8:12 AM · Restricted Project, Restricted Project
ABataev requested review of D127974: [SLP]Use original vector if need to shuffle truncated root..
Thu, Jun 16, 7:56 AM · Restricted Project, Restricted Project
ABataev committed rG7236d49fd5f9: [SLP]Extend vectorization for scatter vectorize nodes. (authored by ABataev).
[SLP]Extend vectorization for scatter vectorize nodes.
Thu, Jun 16, 6:53 AM · Restricted Project, Restricted Project
ABataev closed D127219: [SLP]Extend vectorization for scatter vectorize nodes..
Thu, Jun 16, 6:53 AM · Restricted Project, Restricted Project

Wed, Jun 15

ABataev added inline comments to D125987: [SLP] Account for cost of removing FMA opportunities.
Wed, Jun 15, 7:02 AM · Restricted Project, Restricted Project
ABataev added inline comments to D125987: [SLP] Account for cost of removing FMA opportunities.
Wed, Jun 15, 6:57 AM · Restricted Project, Restricted Project
ABataev committed rGc60c13f7eb71: [SLP] Improve reordering in presence of constant only nodes. (authored by ABataev).
[SLP] Improve reordering in presence of constant only nodes.
Wed, Jun 15, 6:48 AM · Restricted Project, Restricted Project
ABataev closed D127775: [SLP] Improve reordering in presence of constant only nodes..
Wed, Jun 15, 6:48 AM · Restricted Project, Restricted Project
ABataev added inline comments to D125987: [SLP] Account for cost of removing FMA opportunities.
Wed, Jun 15, 6:42 AM · Restricted Project, Restricted Project
ABataev added inline comments to D125987: [SLP] Account for cost of removing FMA opportunities.
Wed, Jun 15, 6:29 AM · Restricted Project, Restricted Project
ABataev added inline comments to D125987: [SLP] Account for cost of removing FMA opportunities.
Wed, Jun 15, 6:21 AM · Restricted Project, Restricted Project
ABataev added inline comments to D125987: [SLP] Account for cost of removing FMA opportunities.
Wed, Jun 15, 6:15 AM · Restricted Project, Restricted Project
ABataev added a comment to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Why do we need to insert new implicit DSA? Only explicit DSAs are expected to be stored, implicit ones can be deduced using the rules.

Wed, Jun 15, 6:14 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D125987: [SLP] Account for cost of removing FMA opportunities.
Wed, Jun 15, 6:10 AM · Restricted Project, Restricted Project
ABataev accepted D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct .

LG

Wed, Jun 15, 5:54 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

ABataev updated the diff for D126885: [SLP]Cost for a constant buildvector..

Rebase

Tue, Jun 14, 1:41 PM · Restricted Project, Restricted Project
ABataev updated the diff for D126877: [SLP]Fix PR55734: SLP vectorizer's reduce_and formation introduces poison..

Rebase

Tue, Jun 14, 1:00 PM · Restricted Project, Restricted Project
ABataev updated the diff for D127775: [SLP] Improve reordering in presence of constant only nodes..

Fixed order of checks.

Tue, Jun 14, 12:57 PM · Restricted Project, Restricted Project
ABataev requested review of D127775: [SLP] Improve reordering in presence of constant only nodes..
Tue, Jun 14, 12:41 PM · Restricted Project, Restricted Project
ABataev updated the diff for D127119: [SLP]Fix undef handling in gather function..

Address comments

Tue, Jun 14, 10:24 AM · Restricted Project, Restricted Project
ABataev updated the summary of D127219: [SLP]Extend vectorization for scatter vectorize nodes..
Tue, Jun 14, 10:02 AM · Restricted Project, Restricted Project
ABataev updated the diff for D127219: [SLP]Extend vectorization for scatter vectorize nodes..

Improve checks to avoid regressions

Tue, Jun 14, 10:01 AM · Restricted Project, Restricted Project
ABataev added inline comments to D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct .
Tue, Jun 14, 7:15 AM · Restricted Project, Restricted Project, Restricted Project