Page MenuHomePhabricator

ABataev (Alexey Bataev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2013, 4:40 AM (316 w, 2 d)

Recent Activity

Yesterday

ABataev added a comment to D56587: Introduce DW_OP_LLVM_convert.

I don't think anyone mentioned it, that's why I was bringing it up - there's always an option to not render any location if it's not possible/worth the work. That's all I was asking - is it worth the complexity? (I wasn't sure anyone needed it - but sounds like Sony does, reckon it's worth the tradeoff in complexity in LLVM compared to the work required to support this in the Sony debugger?)

NVPTX also would need it, because they are stuck on DWARF v2.

Any ideas if NVPTX hit this case? my understanding was that NVPTX has a fairly restrictive set of code or actions that can be used.

Ping on this - still wondering if anyone needs the complicated code or if we could get away with the GNU extension + DWARFv5 standard

Fri, Feb 22, 4:40 PM · debug-info
ABataev committed rGe69f94e02224: [OPENMP] Delayed diagnostics for VLA support. (authored by ABataev).
[OPENMP] Delayed diagnostics for VLA support.
Fri, Feb 22, 12:37 PM
ABataev committed rC354690: [OPENMP] Delayed diagnostics for VLA support..
[OPENMP] Delayed diagnostics for VLA support.
Fri, Feb 22, 12:36 PM
ABataev committed rL354690: [OPENMP] Delayed diagnostics for VLA support..
[OPENMP] Delayed diagnostics for VLA support.
Fri, Feb 22, 12:36 PM
ABataev accepted D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.

LG

Fri, Feb 22, 12:24 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Fri, Feb 22, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
ABataev committed rGbbd5c55c6669: Revert "[OPENMP] Delayed diagnostics for VLA support." (authored by ABataev).
Revert "[OPENMP] Delayed diagnostics for VLA support."
Fri, Feb 22, 9:17 AM
ABataev committed rL354680: Revert "[OPENMP] Delayed diagnostics for VLA support.".
Revert "[OPENMP] Delayed diagnostics for VLA support."
Fri, Feb 22, 9:17 AM
ABataev committed rC354680: Revert "[OPENMP] Delayed diagnostics for VLA support.".
Revert "[OPENMP] Delayed diagnostics for VLA support."
Fri, Feb 22, 9:17 AM
ABataev committed rGb09bcf8efdbd: [OPENMP] Delayed diagnostics for VLA support. (authored by ABataev).
[OPENMP] Delayed diagnostics for VLA support.
Fri, Feb 22, 8:49 AM
ABataev committed rC354679: [OPENMP] Delayed diagnostics for VLA support..
[OPENMP] Delayed diagnostics for VLA support.
Fri, Feb 22, 8:48 AM
ABataev committed rL354679: [OPENMP] Delayed diagnostics for VLA support..
[OPENMP] Delayed diagnostics for VLA support.
Fri, Feb 22, 8:48 AM
ABataev committed rG3167b3035e8a: [CUDA]Delayed diagnostics for the asm instructions. (authored by ABataev).
[CUDA]Delayed diagnostics for the asm instructions.
Fri, Feb 22, 6:42 AM
ABataev committed rC354671: [CUDA]Delayed diagnostics for the asm instructions..
[CUDA]Delayed diagnostics for the asm instructions.
Fri, Feb 22, 6:42 AM
ABataev committed rL354671: [CUDA]Delayed diagnostics for the asm instructions..
[CUDA]Delayed diagnostics for the asm instructions.
Fri, Feb 22, 6:42 AM
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Fri, Feb 22, 6:30 AM
ABataev added inline comments to D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Fri, Feb 22, 6:14 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Feb 21

ABataev added inline comments to D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Thu, Feb 21, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
ABataev committed rG12a21e4b69d4: Revert "[CUDA]Delayed diagnostics for the asm instructions." (authored by ABataev).
Revert "[CUDA]Delayed diagnostics for the asm instructions."
Thu, Feb 21, 8:40 AM
ABataev committed rL354596: Revert "[CUDA]Delayed diagnostics for the asm instructions.".
Revert "[CUDA]Delayed diagnostics for the asm instructions."
Thu, Feb 21, 8:40 AM
ABataev committed rC354596: Revert "[CUDA]Delayed diagnostics for the asm instructions.".
Revert "[CUDA]Delayed diagnostics for the asm instructions."
Thu, Feb 21, 8:40 AM
ABataev committed rG16d3e1a4d20a: [CUDA]Delayed diagnostics for the asm instructions. (authored by ABataev).
[CUDA]Delayed diagnostics for the asm instructions.
Thu, Feb 21, 7:52 AM
ABataev committed rC354593: [CUDA]Delayed diagnostics for the asm instructions..
[CUDA]Delayed diagnostics for the asm instructions.
Thu, Feb 21, 7:52 AM
ABataev committed rL354593: [CUDA]Delayed diagnostics for the asm instructions..
[CUDA]Delayed diagnostics for the asm instructions.
Thu, Feb 21, 7:52 AM
ABataev closed D58463: [CUDA]Delayed diagnostics for the asm instructions..
Thu, Feb 21, 7:52 AM · Restricted Project, Restricted Project
ABataev accepted D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow..

LG

Thu, Feb 21, 6:50 AM · Restricted Project
ABataev added inline comments to D58504: [OpenCL][8.0.0 Release] Notes for OpenCL.
Thu, Feb 21, 6:45 AM
ABataev added inline comments to D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow..
Thu, Feb 21, 6:15 AM · Restricted Project

Wed, Feb 20

ABataev committed rG7feae0585825: [OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC. (authored by ABataev).
[OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC.
Wed, Feb 20, 11:37 AM
ABataev committed rC354509: [OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC..
[OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC.
Wed, Feb 20, 11:36 AM
ABataev committed rL354509: [OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC..
[OPENMP] Use targetDiag for diagnostics of unsupported exceptions, NFC.
Wed, Feb 20, 11:36 AM
ABataev created D58463: [CUDA]Delayed diagnostics for the asm instructions..
Wed, Feb 20, 10:54 AM · Restricted Project, Restricted Project
ABataev committed rG5c96c1c5aa4a: [OPENMP] Delay emission of the asm target-specific error messages. (authored by ABataev).
[OPENMP] Delay emission of the asm target-specific error messages.
Wed, Feb 20, 9:44 AM
ABataev committed rC354486: [OPENMP] Delay emission of the asm target-specific error messages..
[OPENMP] Delay emission of the asm target-specific error messages.
Wed, Feb 20, 9:43 AM
ABataev committed rL354486: [OPENMP] Delay emission of the asm target-specific error messages..
[OPENMP] Delay emission of the asm target-specific error messages.
Wed, Feb 20, 9:43 AM
ABataev closed D58243: [OPENMP] Delay emission of the asm target-specific error messages..
Wed, Feb 20, 9:43 AM · Restricted Project, Restricted Project
ABataev committed rG8061acd501f1: [OPENMP][NVPTX]Use faster teams reduction algorithm. (authored by ABataev).
[OPENMP][NVPTX]Use faster teams reduction algorithm.
Wed, Feb 20, 8:36 AM
ABataev committed rC354479: [OPENMP][NVPTX]Use faster teams reduction algorithm..
[OPENMP][NVPTX]Use faster teams reduction algorithm.
Wed, Feb 20, 8:36 AM
ABataev committed rL354479: [OPENMP][NVPTX]Use faster teams reduction algorithm..
[OPENMP][NVPTX]Use faster teams reduction algorithm.
Wed, Feb 20, 8:35 AM
ABataev accepted D58409: [OpenMP][libomptarget] New reduction scheme for team reductions.

LG

Wed, Feb 20, 6:26 AM · Restricted Project

Tue, Feb 19

ABataev added inline comments to D58243: [OPENMP] Delay emission of the asm target-specific error messages..
Tue, Feb 19, 12:20 PM · Restricted Project, Restricted Project
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Tue, Feb 19, 7:25 AM

Sun, Feb 17

ABataev added a comment to D58243: [OPENMP] Delay emission of the asm target-specific error messages..

Ping!

Sun, Feb 17, 6:16 PM · Restricted Project, Restricted Project

Fri, Feb 15

ABataev accepted D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Thanks for the catch! I also change the name from OMPMappableExprListLocTy to OMPVarListLocTy to be more accurate. We can potentially factorize other varlist clause code with this. But it will be too large for this patch.

Fri, Feb 15, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Fri, Feb 15, 1:08 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Fri, Feb 15, 12:03 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added reviewers for D58243: [OPENMP] Delay emission of the asm target-specific error messages.: rsmith, kkwli0.
Fri, Feb 15, 6:30 AM · Restricted Project, Restricted Project
ABataev added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Fri, Feb 15, 6:25 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Feb 14

ABataev added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Thu, Feb 14, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Hi Alexey,

Again thanks for your review! The codegen completely ignores any mapper related info for now, so it should not crash map clause codegen. It also passed the regression test, so map clause codegen should be fine.

Thu, Feb 14, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
ABataev created D58243: [OPENMP] Delay emission of the asm target-specific error messages..
Thu, Feb 14, 9:36 AM · Restricted Project, Restricted Project
ABataev added a comment to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Check, please, that adding this to the map clause does not crash the codegen. Would be good to ignore this construct in codegen for now, if it is used in the code.

Thu, Feb 14, 9:18 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Feb 13

ABataev added inline comments to D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression..
Wed, Feb 13, 9:34 AM · Restricted Project
ABataev added a comment to D56587: Introduce DW_OP_LLVM_convert.

NVPTX supports only DWARF2 and does not know anything about DWARF5 operations. Also, it does not support any type of the expression in the DWARF sections, except for <section_name>+-<int_offset>.

Isn't the latter a rather restrictive limitation that should be addressed in the NVPTX assembler?

Wed, Feb 13, 8:09 AM · debug-info
ABataev added a comment to D56587: Introduce DW_OP_LLVM_convert.

+ @ABataev re the question whether NVPTX runs into the situation described in this review.

The Sony debugger guys are okay with using the GCC operator in a pre-v5 expression. So, tentatively, for all debugger tunings, we can emit that instead of the more complicated expression. That way we are emitting compliant expressions, and the info doesn't just disappear sometimes (a much worse outcome IMO). The only remaining question is my hypothetical about NVPTX.

Re branch operators, I thought Adrian was throwing that out there as a general concern; yes branch operators exist, and yes we don't use them currently. As David says, the assembler knows how to convert a label difference into a ULEB and it will all Just Work. If/when we ever need it to.

Wed, Feb 13, 6:47 AM · debug-info

Tue, Feb 12

ABataev added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Tue, Feb 12, 10:53 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Tue, Feb 12, 10:25 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Tue, Feb 12, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Hi Alexey,

Thanks very much for your quick review!

For the codegen, currently I'm thinking to do it within declare target codegen functions. So there is not a very clear interface to do mapper codegen (also, there is not a clear interface to do map clause codegen now), and that's why I didn't have a stub left in this patch. Please see other detailed responses inline.

Tue, Feb 12, 9:40 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added a comment to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Also, need some kind of the stubbed codegen for the mapper

Tue, Feb 12, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
ABataev accepted D56082: [X86][SLP] Enable SLP vectorization for 128-bit horizontal X86 instructions (add, sub).

LG

Tue, Feb 12, 3:23 AM
ABataev added a comment to D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression..

@ABataev Is it intentional that we do not propagate Allowed through labels? For example:

void f() {
  #pragma omp barrier // ok

label:
  #pragma omp barrier // error, "cannot be an immediate substatement"

label:
  ;
  #pragma omp barrier // ok
}

?

No, it is a bug.

Great, then I'll unify this new flag with the Allowed mechanism and fix the bug as part of this change. Thanks!

Tue, Feb 12, 1:50 AM · Restricted Project

Mon, Feb 11

ABataev added a comment to D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression..

@ABataev Is it intentional that we do not propagate Allowed through labels? For example:

void f() {
  #pragma omp barrier // ok

label:
  #pragma omp barrier // error, "cannot be an immediate substatement"

label:
  ;
  #pragma omp barrier // ok
}

?

Mon, Feb 11, 5:15 PM · Restricted Project
ABataev added a comment to D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow..

This definitely requires a test.

@ABataev, I tried to find some tests on similar -fcuda-is-device and -fopenmp-is-device options, but I wasn't able to find a dedicated test. Could you suggest some examples testing similar functionality, please?

There are several similar tests:
OpenMP/driver.c, Driver/openmp-offload.c, Driver/openmp-offload-gpu.c. There is no absolutely the same test for OpenMP, since OpenMP has mo similar req for the offloading.

@ABataev thanks for the pointers. The uploaded patch adds two options:

  • fsycl-is-device (front-end option)
  • sycl-device-only (driver option)

    The driver tests you mention validate driver logic enabled by new options, which is not part of this test and I was going to add it later. I can split the patch and remove new driver option and leave only front-end option. Another option is to add driver logic that invokes the front-end compiler in "device only" mode. Which option do you prefer?
Mon, Feb 11, 8:17 AM · Restricted Project

Sun, Feb 10

ABataev added inline comments to D57779: [SLP] Add support for throttling..
Sun, Feb 10, 4:55 PM

Fri, Feb 8

ABataev committed rGc416e64731c8: [OPENMP]Delay emission of the error messages for the exceptions. (authored by ABataev).
[OPENMP]Delay emission of the error messages for the exceptions.
Fri, Feb 8, 10:04 AM
ABataev committed rC353542: [OPENMP]Delay emission of the error messages for the exceptions..
[OPENMP]Delay emission of the error messages for the exceptions.
Fri, Feb 8, 10:04 AM
ABataev committed rL353542: [OPENMP]Delay emission of the error messages for the exceptions..
[OPENMP]Delay emission of the error messages for the exceptions.
Fri, Feb 8, 10:04 AM
ABataev committed rG346fb4bbcd3a: Revert "[OPENMP]Initial support for the delayed diagnostics." (authored by ABataev).
Revert "[OPENMP]Initial support for the delayed diagnostics."
Fri, Feb 8, 9:42 AM
ABataev committed rC353541: Revert "[OPENMP]Initial support for the delayed diagnostics.".
Revert "[OPENMP]Initial support for the delayed diagnostics."
Fri, Feb 8, 9:42 AM
ABataev committed rL353541: Revert "[OPENMP]Initial support for the delayed diagnostics.".
Revert "[OPENMP]Initial support for the delayed diagnostics."
Fri, Feb 8, 9:42 AM
ABataev committed rG5e62adad0d3c: [OPENMP]Initial support for the delayed diagnostics. (authored by ABataev).
[OPENMP]Initial support for the delayed diagnostics.
Fri, Feb 8, 9:38 AM
ABataev committed rC353540: [OPENMP]Initial support for the delayed diagnostics..
[OPENMP]Initial support for the delayed diagnostics.
Fri, Feb 8, 9:38 AM
ABataev committed rL353540: [OPENMP]Initial support for the delayed diagnostics..
[OPENMP]Initial support for the delayed diagnostics.
Fri, Feb 8, 9:38 AM

Thu, Feb 7

ABataev committed rG897213398948: [SEMA]Generalize deferred diagnostic interface, NFC. (authored by ABataev).
[SEMA]Generalize deferred diagnostic interface, NFC.
Thu, Feb 7, 11:49 AM
ABataev committed rC353456: [SEMA]Generalize deferred diagnostic interface, NFC..
[SEMA]Generalize deferred diagnostic interface, NFC.
Thu, Feb 7, 11:48 AM
ABataev committed rL353456: [SEMA]Generalize deferred diagnostic interface, NFC..
[SEMA]Generalize deferred diagnostic interface, NFC.
Thu, Feb 7, 11:48 AM
ABataev closed D57908: [SEMA]Generalize deferred diagnostic interface, NFC..
Thu, Feb 7, 11:48 AM · Restricted Project, Restricted Project
ABataev created D57908: [SEMA]Generalize deferred diagnostic interface, NFC..
Thu, Feb 7, 10:14 AM · Restricted Project, Restricted Project

Wed, Feb 6

ABataev added a comment to D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow..

This definitely requires a test.

@ABataev, I tried to find some tests on similar -fcuda-is-device and -fopenmp-is-device options, but I wasn't able to find a dedicated test. Could you suggest some examples testing similar functionality, please?

Wed, Feb 6, 5:36 AM · Restricted Project
ABataev requested changes to D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow..

This definitely requires a test.

Wed, Feb 6, 5:23 AM · Restricted Project

Tue, Feb 5

ABataev added inline comments to D57779: [SLP] Add support for throttling..
Tue, Feb 5, 1:02 PM
ABataev committed rGc2dc4d4aefba: [DOCS]Support for emission of the debug info for the Cuda devices, NFC. (authored by ABataev).
[DOCS]Support for emission of the debug info for the Cuda devices, NFC.
Tue, Feb 5, 12:39 PM
ABataev committed rC353214: [DOCS]Support for emission of the debug info for the Cuda devices, NFC..
[DOCS]Support for emission of the debug info for the Cuda devices, NFC.
Tue, Feb 5, 12:38 PM
ABataev committed rL353214: [DOCS]Support for emission of the debug info for the Cuda devices, NFC..
[DOCS]Support for emission of the debug info for the Cuda devices, NFC.
Tue, Feb 5, 12:38 PM
ABataev committed rG1a9e05d7da04: [DEBUG_INFO][NVPTX] Generate correct data about variable address class. (authored by ABataev).
[DEBUG_INFO][NVPTX] Generate correct data about variable address class.
Tue, Feb 5, 11:46 AM
ABataev committed rL353204: [DEBUG_INFO][NVPTX] Generate correct data about variable address class..
[DEBUG_INFO][NVPTX] Generate correct data about variable address class.
Tue, Feb 5, 11:46 AM
ABataev committed rC353204: [DEBUG_INFO][NVPTX] Generate correct data about variable address class..
[DEBUG_INFO][NVPTX] Generate correct data about variable address class.
Tue, Feb 5, 11:45 AM
ABataev closed D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class..
Tue, Feb 5, 11:45 AM · Restricted Project
ABataev committed rGf3a9150324c4: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger. (authored by ABataev).
[DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger.
Tue, Feb 5, 11:34 AM
ABataev committed rL353203: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger..
[DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger.
Tue, Feb 5, 11:34 AM
ABataev closed D57157: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger..
Tue, Feb 5, 11:34 AM · Restricted Project
ABataev added inline comments to D57157: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger..
Tue, Feb 5, 11:04 AM · Restricted Project
ABataev added inline comments to D57157: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger..
Tue, Feb 5, 11:03 AM · Restricted Project
ABataev added a comment to D57157: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger..

Adrian, thanks a lot for the review!

Tue, Feb 5, 10:46 AM · Restricted Project
ABataev updated the diff for D57157: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger..

Reworked according to the comments from Adrian Prantl.

Tue, Feb 5, 10:43 AM · Restricted Project
Herald added a project to D57157: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger.: Restricted Project.

Ping!

Tue, Feb 5, 7:46 AM · Restricted Project
Herald added a project to D57250: [DEBUG_INFO][NVPTX]Emit empty .debug_loc section in presence of the debug option.: Restricted Project.

Ping!

Tue, Feb 5, 7:45 AM · Restricted Project

Mon, Feb 4

ABataev accepted D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.

LG

Mon, Feb 4, 12:35 PM
ABataev added inline comments to D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.
Mon, Feb 4, 8:27 AM