Page MenuHomePhabricator

ABataev (Alexey Bataev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2013, 4:40 AM (374 w, 6 d)

Recent Activity

Today

ABataev created D77751: [OPENMP50] Fix PR45469: Consider variable-category of defaultmap clause as optional..
Wed, Apr 8, 1:03 PM · Restricted Project
ABataev created D77731: [OPENMP]Fix capturing of global variables in OpenMP regions..
Wed, Apr 8, 7:34 AM · Restricted Project

Yesterday

ABataev committed rGdbe86786f7f1: [OPENMP]Do not capture global marked as shared in OpenMP region. (authored by ABataev).
[OPENMP]Do not capture global marked as shared in OpenMP region.
Tue, Apr 7, 2:44 PM
ABataev committed rGe0ae907ab5a1: [OPENMP][DOCS]Update status of oimplemented constructs, NFC. (authored by ABataev).
[OPENMP][DOCS]Update status of oimplemented constructs, NFC.
Tue, Apr 7, 1:05 PM
ABataev committed rGbe99c6158841: [OPENMP50]Codegen for iterator construct. (authored by ABataev).
[OPENMP50]Codegen for iterator construct.
Tue, Apr 7, 1:05 PM
ABataev committed rGa010ef8bd88f: Add map-type check for target and target data directive, by Chi Chun Chen (authored by cchen).
Add map-type check for target and target data directive, by Chi Chun Chen
Tue, Apr 7, 4:50 AM
ABataev closed D77581: Add map-type check for target and target data directive.
Tue, Apr 7, 4:50 AM · Restricted Project

Mon, Apr 6

ABataev added a comment to D77581: Add map-type check for target and target data directive.

Sure, will do it later

Mon, Apr 6, 3:49 PM · Restricted Project
ABataev accepted D77581: Add map-type check for target and target data directive.

LG, thanks!

Mon, Apr 6, 2:46 PM · Restricted Project
ABataev added inline comments to D77581: Add map-type check for target and target data directive.
Mon, Apr 6, 2:10 PM · Restricted Project
ABataev committed rG1c9244865644: [OPENMP]Fix PR45439: `omp for collapse(2) ordered(2)` generates invalid IR. (authored by ABataev).
[OPENMP]Fix PR45439: `omp for collapse(2) ordered(2)` generates invalid IR.
Mon, Apr 6, 9:45 AM

Thu, Apr 2

ABataev committed rG13a1504ffb9a: [OPENMP50]Add initial support for OpenMP 5.0 iterator. (authored by ABataev).
[OPENMP50]Add initial support for OpenMP 5.0 iterator.
Thu, Apr 2, 5:56 AM

Wed, Apr 1

ABataev committed rGc028472fa1f0: Revert "[OPENMP50]Add initial support for OpenMP 5.0 iterator." (authored by ABataev).
Revert "[OPENMP50]Add initial support for OpenMP 5.0 iterator."
Wed, Apr 1, 12:05 PM
ABataev added a reverting change for rGf08df464ae89: [OPENMP50]Add initial support for OpenMP 5.0 iterator.: rGc028472fa1f0: Revert "[OPENMP50]Add initial support for OpenMP 5.0 iterator.".
Wed, Apr 1, 12:05 PM
ABataev committed rGf08df464ae89: [OPENMP50]Add initial support for OpenMP 5.0 iterator. (authored by ABataev).
[OPENMP50]Add initial support for OpenMP 5.0 iterator.
Wed, Apr 1, 10:07 AM

Tue, Mar 31

ABataev committed rG39ada4688936: [OPENMP][DOCS]Mark array shaping as done, NFC. (authored by ABataev).
[OPENMP][DOCS]Mark array shaping as done, NFC.
Tue, Mar 31, 4:35 PM
ABataev committed rGc2aa54323784: [OPENMP50]Codegen for array shaping expression in map clauses. (authored by ABataev).
[OPENMP50]Codegen for array shaping expression in map clauses.
Tue, Mar 31, 4:35 PM
ABataev committed rGe094dd5adcbd: [OPENMP50]Fix size calculation for array shaping expression in the codegen. (authored by ABataev).
[OPENMP50]Fix size calculation for array shaping expression in the codegen.
Tue, Mar 31, 4:01 PM
ABataev committed rG9b3bf72a0d79: [OPENMP50]Allow use of array shaping expression in a list. (authored by ABataev).
[OPENMP50]Allow use of array shaping expression in a list.
Tue, Mar 31, 2:20 PM

Mon, Mar 30

ABataev committed rGa4f74f377b7c: [OPENMP50]Do not imply lvalue as base expression in array shaping expression. (authored by ABataev).
[OPENMP50]Do not imply lvalue as base expression in array shaping expression.
Mon, Mar 30, 2:12 PM
ABataev committed rG7842e7ebbf3b: [OPENMP50]Add codegen support for array shaping expression in depend clauses. (authored by ABataev).
[OPENMP50]Add codegen support for array shaping expression in depend clauses.
Mon, Mar 30, 10:51 AM
ABataev committed rG7ac9efb0c322: [OPENMP50]Add basic support for array-shaping operation. (authored by ABataev).
[OPENMP50]Add basic support for array-shaping operation.
Mon, Mar 30, 7:01 AM
ABataev closed D74144: [OPENMP50]Add basic support for array-shaping operation..
Mon, Mar 30, 7:01 AM · Restricted Project

Fri, Mar 27

ABataev committed rG0fca766458da: [OPENMP50]Fix PR45117: Orphaned task reduction should be allowed. (authored by ABataev).
[OPENMP50]Fix PR45117: Orphaned task reduction should be allowed.
Fri, Mar 27, 3:27 PM
ABataev committed rG49764dc30c4c: [OPENMP50]Add basic support for inscan reduction modifier. (authored by ABataev).
[OPENMP50]Add basic support for inscan reduction modifier.
Fri, Mar 27, 11:29 AM
ABataev committed rGee27df5552de: Revert "[OPENMP50]Add basic support for inscan reduction modifier." (authored by ABataev).
Revert "[OPENMP50]Add basic support for inscan reduction modifier."
Fri, Mar 27, 8:31 AM
ABataev added a reverting change for rG36ed0ceec7d3: [OPENMP50]Add basic support for inscan reduction modifier.: rGee27df5552de: Revert "[OPENMP50]Add basic support for inscan reduction modifier.".
Fri, Mar 27, 8:31 AM
ABataev committed rG36ed0ceec7d3: [OPENMP50]Add basic support for inscan reduction modifier. (authored by ABataev).
[OPENMP50]Add basic support for inscan reduction modifier.
Fri, Mar 27, 8:13 AM

Thu, Mar 26

ABataev committed rG2a43a1610db3: [OPENMP50]Fix the checks for the nesting of scan directives. (authored by ABataev).
[OPENMP50]Fix the checks for the nesting of scan directives.
Thu, Mar 26, 2:42 PM
ABataev committed rGf9e71f4d9d39: Revert "[OPENMP50]Add basic support for inscan reduction modifier." (authored by ABataev).
Revert "[OPENMP50]Add basic support for inscan reduction modifier."
Thu, Mar 26, 1:03 PM
ABataev added a reverting change for rG8099e0fe82ce: [OPENMP50]Add basic support for inscan reduction modifier.: rGf9e71f4d9d39: Revert "[OPENMP50]Add basic support for inscan reduction modifier.".
Thu, Mar 26, 1:03 PM
ABataev committed rG8099e0fe82ce: [OPENMP50]Add basic support for inscan reduction modifier. (authored by ABataev).
[OPENMP50]Add basic support for inscan reduction modifier.
Thu, Mar 26, 12:30 PM
ABataev updated the diff for D74144: [OPENMP50]Add basic support for array-shaping operation..

Rebase + fixes.

Thu, Mar 26, 8:38 AM · Restricted Project

Wed, Mar 25

ABataev updated the diff for D74144: [OPENMP50]Add basic support for array-shaping operation..

Rebase + fixes.

Wed, Mar 25, 4:16 PM · Restricted Project
ABataev added inline comments to D74144: [OPENMP50]Add basic support for array-shaping operation..
Wed, Mar 25, 1:32 PM · Restricted Project
ABataev added a comment to D74144: [OPENMP50]Add basic support for array-shaping operation..

Okay, so these array-shaping expressions are only allowed as operands to specific OpenMP directives? That's a plausible interpretation of "The shape-operator can appear only in clauses where it is explicitly allowed" from the spec. If it were a more general l-value expression, we could handle that just fine by building the type using ConstantArrayType/VariableArrayType as appropriate; but if the language intentionally restricts it, the placeholder approach seems fine.

Wed, Mar 25, 1:32 PM · Restricted Project

Tue, Mar 24

ABataev added a comment to D74144: [OPENMP50]Add basic support for array-shaping operation..

Ping 7

Tue, Mar 24, 9:39 AM · Restricted Project

Mon, Mar 23

ABataev committed rG1236eb6c31ff: [OPENMP50]Add 'default' modifier in reduction clauses. (authored by ABataev).
[OPENMP50]Add 'default' modifier in reduction clauses.
Mon, Mar 23, 3:49 PM
ABataev committed rG63828a35da6f: [OPENMP50]Bassic support for exclusive clause. (authored by ABataev).
[OPENMP50]Bassic support for exclusive clause.
Mon, Mar 23, 10:23 AM

Fri, Mar 20

ABataev committed rG9b95929a26e1: [OPENMP50]Do not allow several scan directives in the same parent region. (authored by ABataev).
[OPENMP50]Do not allow several scan directives in the same parent region.
Fri, Mar 20, 1:01 PM
ABataev committed rG06dea73307e7: [OPENMP50]Initial support for inclusive clause. (authored by ABataev).
[OPENMP50]Initial support for inclusive clause.
Fri, Mar 20, 11:56 AM
ABataev committed rGfcba7c3534f9: [OPENMP50]Initial support for scan directive. (authored by ABataev).
[OPENMP50]Initial support for scan directive.
Fri, Mar 20, 5:55 AM

Thu, Mar 19

ABataev committed rGcf1f8f9bec22: [OPENMP][DOCS]Update list of constructs and status, NFC. (authored by ABataev).
[OPENMP][DOCS]Update list of constructs and status, NFC.
Thu, Mar 19, 7:32 AM

Wed, Mar 18

ABataev committed rGf3c857fae297: [OPENMP50]Add basic codegen support for ancestor device modifier. (authored by ABataev).
[OPENMP50]Add basic codegen support for ancestor device modifier.
Wed, Mar 18, 3:14 PM
ABataev committed rG2f8894a5b8b1: [OPENMP50]Add support for extended device clause in target directives. (authored by ABataev).
[OPENMP50]Add support for extended device clause in target directives.
Wed, Mar 18, 12:30 PM
ABataev added a comment to D74144: [OPENMP50]Add basic support for array-shaping operation..

Ping

Wed, Mar 18, 7:02 AM · Restricted Project
ABataev committed rGb09cce07c7eb: [OPENMP50]Codegen for detach clause. (authored by ABataev).
[OPENMP50]Codegen for detach clause.
Wed, Mar 18, 6:30 AM
ABataev added a comment to D62485: New implementation of OpenMP 5.0 detached tasks..

Shall the compiler generate the call of omp_fulfill_event after __kmpc_omp_task call? Or is it a user code?

User code supposed to call the omp_fulfill_event to signal completion of the corresponding detached task.

Three tests provided to cover three cases: user called omp_fulfill_event (1) after task body completed execution, (2) possibly during execution of the task, and (3) before the task was scheduled for execution.

Wed, Mar 18, 3:46 AM · Restricted Project, Restricted Project

Tue, Mar 17

Herald added a reviewer for D62485: New implementation of OpenMP 5.0 detached tasks.: jdoerfert.

Shall the compiler generate the call of omp_fulfill_event after __kmpc_omp_task call? Or is it a user code?

Tue, Mar 17, 3:07 PM · Restricted Project, Restricted Project
ABataev added inline comments to D76211: OpenMP Metadirective with user defined condition.
Tue, Mar 17, 11:49 AM · Restricted Project, Restricted Project
ABataev committed rGb6bcf728507a: [OPENMP50]Mark expression in detach clause as firstprivate. (authored by ABataev).
[OPENMP50]Mark expression in detach clause as firstprivate.
Tue, Mar 17, 11:18 AM
ABataev committed rG0f0564bb9a3c: [OPENMP50]Initial support for detach clause in task directive. (authored by ABataev).
[OPENMP50]Initial support for detach clause in task directive.
Tue, Mar 17, 6:52 AM

Fri, Mar 13

ABataev committed rGb3998a0edb9a: [OPENMP]Fix PR45047: Do not copy firstprivates in tasks twice. (authored by ABataev).
[OPENMP]Fix PR45047: Do not copy firstprivates in tasks twice.
Fri, Mar 13, 3:40 PM
ABataev added a comment to D74144: [OPENMP50]Add basic support for array-shaping operation..

Ping

Fri, Mar 13, 2:03 PM · Restricted Project
ABataev committed rG172f1460ae05: [OPENMP]Reduce number of captured global vars. (authored by ABataev).
[OPENMP]Reduce number of captured global vars.
Fri, Mar 13, 8:01 AM

Wed, Mar 11

ABataev committed rG0d7c8c07d2a5: [OPENMP][DOCS]Mark depobj as implemented, NFC. (authored by ABataev).
[OPENMP][DOCS]Mark depobj as implemented, NFC.
Wed, Mar 11, 10:46 AM
ABataev committed rGc422d69b1ad7: [LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload. (authored by ABataev).
[LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload.
Wed, Mar 11, 6:18 AM
ABataev closed D75946: [LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload..
Wed, Mar 11, 6:18 AM · Restricted Project

Tue, Mar 10

ABataev updated the diff for D75946: [LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload..

Initialize LibraryHandler field.

Tue, Mar 10, 12:33 PM · Restricted Project
ABataev updated the diff for D75946: [LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload..

Initialize all fields by default and use default constructor.

Tue, Mar 10, 12:33 PM · Restricted Project
ABataev retitled D75946: [LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload. from [LIBOMPTARGET][WIP]Fix PR45139: Bug in mixing Python and OpenMP target offload. to [LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload..
Tue, Mar 10, 12:33 PM · Restricted Project
ABataev created D75946: [LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload..
Tue, Mar 10, 10:52 AM · Restricted Project
ABataev abandoned D75926: [LIBOMPTARGET][WIP]Fix PR45139: Bug in mixing Python and OpenMP target offload..
Tue, Mar 10, 10:19 AM · Restricted Project
ABataev added a comment to D75926: [LIBOMPTARGET][WIP]Fix PR45139: Bug in mixing Python and OpenMP target offload..

LGTM.

Tue, Mar 10, 9:48 AM · Restricted Project
ABataev committed rG71ffac21f746: [OPENMP]Fix PR45132: OpenMP doacross loop nest with a decreasing induction… (authored by ABataev).
[OPENMP]Fix PR45132: OpenMP doacross loop nest with a decreasing induction…
Tue, Mar 10, 9:47 AM
ABataev created D75926: [LIBOMPTARGET][WIP]Fix PR45139: Bug in mixing Python and OpenMP target offload..
Tue, Mar 10, 8:39 AM · Restricted Project
ABataev accepted D75878: [SLP] Support vectorizing functions provided by vector libs..

LG

Tue, Mar 10, 5:48 AM · Restricted Project

Mon, Mar 9

ABataev added inline comments to D75878: [SLP] Support vectorizing functions provided by vector libs..
Mon, Mar 9, 3:40 PM · Restricted Project
ABataev committed rG6309334b9574: [OPENMP50]Codegen for depobj dependency kind. (authored by ABataev).
[OPENMP50]Codegen for depobj dependency kind.
Mon, Mar 9, 3:08 PM

Mar 6 2020

ABataev updated the diff for D74144: [OPENMP50]Add basic support for array-shaping operation..

Rebase + fixes

Mar 6 2020, 10:28 AM · Restricted Project
ABataev added a comment to D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions..

I am unsure we need this with the proper math support. Sema patch for that is going for review today. I'll try this out soon.

Mar 6 2020, 10:28 AM · Restricted Project
ABataev added inline comments to D74144: [OPENMP50]Add basic support for array-shaping operation..
Mar 6 2020, 9:54 AM · Restricted Project
ABataev committed rG5dadf577d59b: [OPENMP50]Add 'depobj' modifier in 'depend' clauses. (authored by ABataev).
[OPENMP50]Add 'depobj' modifier in 'depend' clauses.
Mar 6 2020, 9:21 AM
ABataev added a comment to D74144: [OPENMP50]Add basic support for array-shaping operation..

Ping 3

Mar 6 2020, 8:48 AM · Restricted Project
ABataev added a comment to D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions..

Ping

Mar 6 2020, 8:47 AM · Restricted Project

Mar 5 2020

ABataev committed rG8d7b1188751b: [OPENMP50]Add codegen for update clause in depobj directive. (authored by ABataev).
[OPENMP50]Add codegen for update clause in depobj directive.
Mar 5 2020, 12:07 PM
ABataev committed rGea5b3ef5935c: [OPENMP50]Skip the first element when storing the list of dependencies in… (authored by ABataev).
[OPENMP50]Skip the first element when storing the list of dependencies in…
Mar 5 2020, 11:33 AM

Mar 4 2020

ABataev committed rGb27ff4d07ddc: [OPENMP50]Codegen for 'destroy' clause in depobj directive. (authored by ABataev).
[OPENMP50]Codegen for 'destroy' clause in depobj directive.
Mar 4 2020, 2:05 PM
ABataev committed rGe46f0fee3066: [OPENMP50]Codegen for 'depend' clause in depobj directive. (authored by ABataev).
[OPENMP50]Codegen for 'depend' clause in depobj directive.
Mar 4 2020, 12:23 PM
ABataev committed rG4f29d30f7ce1: [OPENMP50]'source' and 'sink' kinds are not allowed in depobj. (authored by ABataev).
[OPENMP50]'source' and 'sink' kinds are not allowed in depobj.
Mar 4 2020, 7:53 AM

Mar 3 2020

ABataev accepted D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires.

LG

Mar 3 2020, 11:59 AM · Restricted Project, Restricted Project
ABataev committed rG82f7c207f51b: [OPENMP50]Support 'update' clause for 'depobj' directive. (authored by ABataev).
[OPENMP50]Support 'update' clause for 'depobj' directive.
Mar 3 2020, 11:18 AM

Mar 2 2020

ABataev committed rGc4a9d976c139: [LIBOMPTARGET]Lower priority of global constructor/destructor to silence the… (authored by ABataev).
[LIBOMPTARGET]Lower priority of global constructor/destructor to silence the…
Mar 2 2020, 12:30 PM
ABataev closed D75458: p[LIBOMPTARGET]Lower priority of global constructor/destructor to silence the warning from gcc..
Mar 2 2020, 12:30 PM · Restricted Project
ABataev committed rG375437ab92a8: [OPENMP50]Support 'destroy' clause on 'depobj' directives. (authored by ABataev).
[OPENMP50]Support 'destroy' clause on 'depobj' directives.
Mar 2 2020, 12:04 PM
ABataev added a comment to D75458: p[LIBOMPTARGET]Lower priority of global constructor/destructor to silence the warning from gcc..

Looks good. Do you think I should also change the priorities in my clang-offload-wrapper patch to be out of the reserved range?
https://reviews.llvm.org/D75223

Mar 2 2020, 11:40 AM · Restricted Project
ABataev committed rGc112e941a0c5: [OPENMP50]Add basic support for depobj construct. (authored by ABataev).
[OPENMP50]Add basic support for depobj construct.
Mar 2 2020, 10:44 AM
ABataev created D75458: p[LIBOMPTARGET]Lower priority of global constructor/destructor to silence the warning from gcc..
Mar 2 2020, 7:39 AM · Restricted Project

Feb 28 2020

ABataev committed rG6ee6fa28a74e: [OpenMP5.0] Allow pointer arithmetic in motion/map clause, by Chi Chun Chen (authored by cchen).
[OpenMP5.0] Allow pointer arithmetic in motion/map clause, by Chi Chun Chen
Feb 28 2020, 12:21 PM
ABataev closed D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause.
Feb 28 2020, 12:20 PM · Restricted Project
ABataev added a comment to D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause.

@ABataev, can you land it for me when you have time?

Thanks,
Chi Chun

Feb 28 2020, 11:41 AM · Restricted Project
ABataev accepted D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause.

LGTM

Feb 28 2020, 11:12 AM · Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Feb 28 2020, 11:01 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Feb 28 2020, 11:01 AM · Restricted Project
ABataev committed rGafa45d23e9d7: [SLP]Update test checks, NFC. (authored by ABataev).
[SLP]Update test checks, NFC.
Feb 28 2020, 10:32 AM
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Feb 28 2020, 10:23 AM · Restricted Project
ABataev added inline comments to D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause.
Feb 28 2020, 9:55 AM · Restricted Project
ABataev added inline comments to D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause.
Feb 28 2020, 9:46 AM · Restricted Project
ABataev added inline comments to D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause.
Feb 28 2020, 9:28 AM · Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + fixes

Feb 28 2020, 8:14 AM · Restricted Project