Page MenuHomePhabricator

ABataev (Alexey Bataev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2013, 4:40 AM (399 w, 1 d)

Recent Activity

Yesterday

ABataev committed rG579c42225ac3: [OPENMP]Fix PR47621: Variable used by task inside a template function is not… (authored by ABataev).
[OPENMP]Fix PR47621: Variable used by task inside a template function is not…
Thu, Sep 24, 1:23 PM
ABataev added a reverting change for rGd1419c9fdab1: [OPENMP]Fix PR47621: Variable used by task inside a template function is not…: rGcde7d90cc7c2: Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function….
Thu, Sep 24, 11:42 AM
ABataev committed rGcde7d90cc7c2: Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function… (authored by ABataev).
Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function…
Thu, Sep 24, 11:42 AM
ABataev added a reverting change for D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default: rGcde7d90cc7c2: Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function….
Thu, Sep 24, 11:42 AM · Restricted Project
ABataev committed rGd1419c9fdab1: [OPENMP]Fix PR47621: Variable used by task inside a template function is not… (authored by ABataev).
[OPENMP]Fix PR47621: Variable used by task inside a template function is not…
Thu, Sep 24, 10:57 AM
ABataev closed D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default.
Thu, Sep 24, 10:57 AM · Restricted Project
ABataev committed rGa9fca98ee4f6: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by… (authored by ABataev).
[OPENMP]PR47606: Do not update the lastprivate item if it was captured by…
Thu, Sep 24, 10:23 AM
ABataev closed D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member..
Thu, Sep 24, 10:22 AM · Restricted Project
ABataev requested review of D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default.
Thu, Sep 24, 9:39 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Thu, Sep 24, 7:19 AM · Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + rename

Thu, Sep 24, 6:33 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Thu, Sep 24, 6:26 AM · Restricted Project
ABataev accepted D88193: [SLP] Remove LHS and RHS from OperationData..

LG

Thu, Sep 24, 6:02 AM · Restricted Project
ABataev added a comment to D88196: [DEBUGINFO, NVPTX] Removed Label Arithmetic from DWARF Pub Sections for NVPTX.

If I do recall it correctly, NVPTX debug info does not support pub sections. You just need to tweak the frontend to disable emission of pub sections (need to add , nameTableKind: None to the DICompileUnit)

Thu, Sep 24, 5:37 AM · Restricted Project

Wed, Sep 23

ABataev requested review of D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member..
Wed, Sep 23, 12:53 PM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Wed, Sep 23, 6:31 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Wed, Sep 23, 5:55 AM · Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + fix

Wed, Sep 23, 5:30 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Wed, Sep 23, 4:30 AM · Restricted Project

Tue, Sep 22

ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Tue, Sep 22, 3:12 PM · Restricted Project
ABataev committed rGd6ac649ccda2: [SLP]Fix coding style, NFC. (authored by ABataev).
[SLP]Fix coding style, NFC.
Tue, Sep 22, 2:45 PM
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Tue, Sep 22, 8:57 AM · Restricted Project
ABataev added a comment to D76342: [OpenMP] Implement '#pragma omp tile'.

Rebase after D83261

Tue, Sep 22, 5:06 AM · Restricted Project, Restricted Project

Mon, Sep 21

ABataev committed rG3ff07fcd542e: [SLP] Allow reordering of vectorization trees with reused instructions. (authored by ABataev).
[SLP] Allow reordering of vectorization trees with reused instructions.
Mon, Sep 21, 7:52 AM
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Rebase

Mon, Sep 21, 6:47 AM · Restricted Project, Restricted Project

Fri, Sep 18

ABataev updated subscribers of D87841: [openmp][libomptarget] Include header from LLVM source tree.

I have no idea if this has been considered before or not, or if there is some technical/organizational difficulties against this option, but I think an option would be to create somewhere in the LLVM umbrella project for common Headers/Def.s between different LLVM subprojects (directory called "common" maybe?), which should help maintain independence between the projects without duplication, package maintainers will know to always include that in any package without having to worry about looking for shared files on a file by file bases, and users should always download that with whichever llvm package they are going to use.

FWIW.

Fri, Sep 18, 10:35 AM · Restricted Project, Restricted Project
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Rebase

Fri, Sep 18, 8:44 AM · Restricted Project, Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + use std::distance instead of count_if

Fri, Sep 18, 8:17 AM · Restricted Project
ABataev committed rG455ca0ebb692: [SLP] Allow reordering of vectorization trees with reused instructions. (authored by ABataev).
[SLP] Allow reordering of vectorization trees with reused instructions.
Fri, Sep 18, 6:39 AM
ABataev closed D45263: [SLP] Allow reordering of vectorization trees with reused instructions..
Fri, Sep 18, 6:38 AM · Restricted Project
ABataev added inline comments to D45263: [SLP] Allow reordering of vectorization trees with reused instructions..
Fri, Sep 18, 6:23 AM · Restricted Project

Thu, Sep 17

ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + fixes

Thu, Sep 17, 2:35 PM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Thu, Sep 17, 2:28 PM · Restricted Project
ABataev updated the diff for D45263: [SLP] Allow reordering of vectorization trees with reused instructions..

Rebase + fixes

Thu, Sep 17, 12:17 PM · Restricted Project
ABataev committed rGd5ce8233bfcf: [OpenMP 5.0] Fix user-defined mapper privatization in tasks (authored by ABataev).
[OpenMP 5.0] Fix user-defined mapper privatization in tasks
Thu, Sep 17, 8:22 AM
ABataev closed D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.
Thu, Sep 17, 8:22 AM · Restricted Project
ABataev added a comment to D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.

The latest patch applied cleanly to our downstream port.
builds fine, tests very nicely as well. All the failing SOLLVE task wait depend tests now pass.

Thu, Sep 17, 6:19 AM · Restricted Project

Wed, Sep 16

ABataev updated the diff for D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.

Updated + added clang test.

Wed, Sep 16, 1:32 PM · Restricted Project
ABataev commandeered D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.
Wed, Sep 16, 1:31 PM · Restricted Project
ABataev accepted D87772: [SLP] sort candidates to increase chance of optimal compare reduction.

LG

Wed, Sep 16, 1:12 PM · Restricted Project
ABataev added inline comments to D87772: [SLP] sort candidates to increase chance of optimal compare reduction.
Wed, Sep 16, 10:42 AM · Restricted Project
ABataev added inline comments to D87772: [SLP] sort candidates to increase chance of optimal compare reduction.
Wed, Sep 16, 10:39 AM · Restricted Project
ABataev added inline comments to D87772: [SLP] sort candidates to increase chance of optimal compare reduction.
Wed, Sep 16, 9:52 AM · Restricted Project
ABataev added inline comments to D87772: [SLP] sort candidates to increase chance of optimal compare reduction.
Wed, Sep 16, 9:12 AM · Restricted Project
ABataev committed rG4341c6618dec: [OPENMP]Do not allow threadprivates as base for array-like reduction. (authored by ABataev).
[OPENMP]Do not allow threadprivates as base for array-like reduction.
Wed, Sep 16, 6:32 AM
ABataev closed D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction..
Wed, Sep 16, 6:32 AM · Restricted Project
ABataev abandoned D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..
Wed, Sep 16, 5:13 AM · Restricted Project
ABataev abandoned D83130: [OPENMP]Fix test for ARM, NFC..
Wed, Sep 16, 5:13 AM · Restricted Project
ABataev abandoned D82881: [DEBUGINFO]Fix debug info for packed bitfields..
Wed, Sep 16, 5:11 AM · debug-info, Restricted Project

Tue, Sep 15

ABataev committed rG9e3842d60351: [OPENMP]Fix codegen for is_device_ptr component, captured by reference. (authored by ABataev).
[OPENMP]Fix codegen for is_device_ptr component, captured by reference.
Tue, Sep 15, 2:40 PM
ABataev closed D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference..
Tue, Sep 15, 2:40 PM · Restricted Project
ABataev added a comment to D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.

Hi Ron, hope to prepare it by the end of this week, maybe earlier, if everything goes well. I have some technical issues, but anyway will update the patch and the tests.

Tue, Sep 15, 12:32 PM · Restricted Project
ABataev committed rG738bab743b5c: [OPENMP]Add support for allocate vars in untied tasks. (authored by ABataev).
[OPENMP]Add support for allocate vars in untied tasks.
Tue, Sep 15, 11:01 AM
ABataev closed D86558: [OPENMP]Add support for allocate vars in untied tasks..
Tue, Sep 15, 11:01 AM · Restricted Project
ABataev added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Please go ahead and commit.

Hi Hans, can you commit it yourself? I have some technical issues and not able to commit it. And I don't know when it is going to be resolved. :(

Sure! 4b23932e230dd48a7bfc6fadb461d0ef81aeba94

Tue, Sep 15, 9:41 AM · Restricted Project
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Tue, Sep 15, 9:30 AM · Restricted Project
ABataev added inline comments to D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN.
Tue, Sep 15, 7:44 AM · Restricted Project
ABataev added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Please go ahead and commit.

Tue, Sep 15, 6:54 AM · Restricted Project

Thu, Sep 10

ABataev added a comment to D57779: [SLP] Add support for throttling..

Good enough for initial implementation?

yes, For me, it looks like ready.

Thu, Sep 10, 1:30 PM · Restricted Project

Tue, Sep 8

ABataev added a comment to D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.

I can update this patch in a week when I'm back from vacation.

Tue, Sep 8, 10:39 AM · Restricted Project

Tue, Sep 1

ABataev committed rG2114f71aaa8d: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl() (authored by nullptr.cpp).
[OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()
Tue, Sep 1, 5:46 AM
ABataev closed D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().
Tue, Sep 1, 5:46 AM · Restricted Project

Mon, Aug 31

ABataev accepted D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

LG

Mon, Aug 31, 9:24 AM · Restricted Project

Sat, Aug 29

ABataev added inline comments to D86781: [LIBOMPTARGET]Do not try to optimize bases for the next parameters..
Sat, Aug 29, 6:13 PM · Restricted Project

Fri, Aug 28

ABataev updated the diff for D86558: [OPENMP]Add support for allocate vars in untied tasks..

Rebase

Fri, Aug 28, 2:52 PM · Restricted Project
ABataev updated the diff for D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction..

Rebase

Fri, Aug 28, 2:10 PM · Restricted Project
ABataev updated the diff for D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference..

Rebase

Fri, Aug 28, 1:58 PM · Restricted Project
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
  1. Generalized interface for all mapping operations.
  2. Fixed compatibility of declare mapper and other mapping operations with OpenMP 5.0 examples.
  3. Simplified declare mapper codegen.
Fri, Aug 28, 1:29 PM · Restricted Project, Restricted Project
ABataev committed rG6aa7228a629d: [LIBOMPTARGET]Do not try to optimize bases for the next parameters. (authored by ABataev).
[LIBOMPTARGET]Do not try to optimize bases for the next parameters.
Fri, Aug 28, 12:51 PM
ABataev closed D86781: [LIBOMPTARGET]Do not try to optimize bases for the next parameters..
Fri, Aug 28, 12:50 PM · Restricted Project
ABataev accepted D86758: [OpenMP] Fixed wrong test command in the test private_mapping.c.

LG

Fri, Aug 28, 8:14 AM · Restricted Project
ABataev requested review of D86781: [LIBOMPTARGET]Do not try to optimize bases for the next parameters..
Fri, Aug 28, 5:57 AM · Restricted Project
ABataev added a comment to D86758: [OpenMP] Fixed wrong test command in the test private_mapping.c.

compilexx is for c++ tests, IIRC, try compile instead

Fri, Aug 28, 3:14 AM · Restricted Project

Thu, Aug 27

ABataev added inline comments to D86307: [OpenMP] Pack first-private arguments to improve efficiency of data transfer.
Thu, Aug 27, 2:24 PM · Restricted Project
ABataev committed rGba1de5f2f7b0: [OPENMP]Do not crash for globals in inner regions with outer target (authored by ABataev).
[OPENMP]Do not crash for globals in inner regions with outer target
Thu, Aug 27, 2:08 PM

Wed, Aug 26

ABataev accepted D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3.

LG

Wed, Aug 26, 8:30 AM · Restricted Project
ABataev accepted D85150: [OpenMP] Ensure testing for versions 4.5 and default - Part 2.

LG

Wed, Aug 26, 8:26 AM · Restricted Project
ABataev added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

but we can merge this right away (IMHO)

It is up to Hans if he has some time. But I think I covered almost all new features (+ complex for NVPTX), so after the update it can be merged with 11.x release.

It's fine by me if you want to wait a day or two for more comments, or go ahead and merge directly.

Wed, Aug 26, 8:24 AM · Restricted Project

Aug 26 2020

ABataev updated the diff for D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Added default(firstprivate)

Aug 26 2020, 3:44 AM · Restricted Project

Aug 25 2020

ABataev added inline comments to D85735: [OpenMP] Context selector extensions for template functions.
Aug 25 2020, 4:39 PM · Restricted Project, Restricted Project
ABataev added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..
Aug 25 2020, 4:36 PM · Restricted Project
ABataev added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

present map type and motion modifier
default(firstprivate)

Aug 25 2020, 3:31 PM · Restricted Project
ABataev updated the diff for D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Misprint fix

Aug 25 2020, 2:25 PM · Restricted Project
ABataev updated the diff for D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

+ complex types for NVPTX

Aug 25 2020, 2:23 PM · Restricted Project
ABataev added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Nit: Maybe we should mention complex support on nvptx devices.

Aug 25 2020, 2:22 PM · Restricted Project
ABataev requested review of D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..
Aug 25 2020, 11:42 AM · Restricted Project
ABataev requested review of D86558: [OPENMP]Add support for allocate vars in untied tasks..
Aug 25 2020, 10:47 AM · Restricted Project
ABataev added a comment to D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN.

Reformat the code

Aug 25 2020, 5:26 AM · Restricted Project

Aug 24 2020

ABataev updated the diff for D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction..

Rebase

Aug 24 2020, 8:29 AM · Restricted Project
ABataev updated the diff for D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference..

Rebase

Aug 24 2020, 7:50 AM · Restricted Project
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Rebase

Aug 24 2020, 7:28 AM · Restricted Project, Restricted Project
ABataev committed rGbedc841a5098: [OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region. (authored by ABataev).
[OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region.
Aug 24 2020, 7:05 AM
ABataev closed D86239: [OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region..
Aug 24 2020, 7:05 AM · Restricted Project

Aug 21 2020

ABataev added inline comments to D57779: [SLP] Add support for throttling..
Aug 21 2020, 3:27 PM · Restricted Project
ABataev updated the diff for D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference..

Rebase

Aug 21 2020, 9:36 AM · Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Aug 21 2020, 8:08 AM · Restricted Project
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Aug 21 2020, 6:51 AM · Restricted Project

Aug 20 2020

ABataev added a reviewer for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.: jdenny.
Aug 20 2020, 6:36 AM · Restricted Project, Restricted Project
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Rebase + fixed implicit mapping of partially mapped structs.

Aug 20 2020, 6:35 AM · Restricted Project, Restricted Project

Aug 19 2020

ABataev updated the diff for D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction..

Rebase

Aug 19 2020, 1:54 PM · Restricted Project