Page MenuHomePhabricator

ABataev (Alexey Bataev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2013, 4:40 AM (324 w, 6 d)

Recent Activity

Today

ABataev updated the diff for D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..

Update to top.

Wed, Apr 24, 1:23 PM · Restricted Project
ABataev committed rGef3c1884ecd4: [SLP] Fix crash after r358519, by V. Porpodas. (authored by ABataev).
[SLP] Fix crash after r358519, by V. Porpodas.
Wed, Apr 24, 1:20 PM
ABataev committed rL359136: [SLP] Fix crash after r358519, by V. Porpodas..
[SLP] Fix crash after r358519, by V. Porpodas.
Wed, Apr 24, 1:19 PM
ABataev closed D61024: [SLP] Fix crash after r358519.
Wed, Apr 24, 1:19 PM · Restricted Project
ABataev committed rG622af1d282a1: [OPENMP]Initial support for non-rectangular loop nest. (authored by ABataev).
[OPENMP]Initial support for non-rectangular loop nest.
Wed, Apr 24, 12:59 PM
ABataev committed rL359132: [OPENMP]Initial support for non-rectangular loop nest..
[OPENMP]Initial support for non-rectangular loop nest.
Wed, Apr 24, 12:58 PM
ABataev committed rC359132: [OPENMP]Initial support for non-rectangular loop nest..
[OPENMP]Initial support for non-rectangular loop nest.
Wed, Apr 24, 12:58 PM
ABataev accepted D61024: [SLP] Fix crash after r358519.

LG

Wed, Apr 24, 12:22 PM · Restricted Project
ABataev added inline comments to D61024: [SLP] Fix crash after r358519.
Wed, Apr 24, 12:12 PM · Restricted Project

Yesterday

ABataev added inline comments to D61024: [SLP] Fix crash after r358519.
Tue, Apr 23, 1:32 PM · Restricted Project
ABataev added inline comments to D61024: [SLP] Fix crash after r358519.
Tue, Apr 23, 10:18 AM · Restricted Project
ABataev updated the diff for D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..

Fixed test checks.

Tue, Apr 23, 7:58 AM · Restricted Project

Mon, Apr 22

ABataev added inline comments to D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..
Mon, Apr 22, 1:11 PM · Restricted Project
ABataev updated the diff for D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..

Fixed the comments for the expected results.

Mon, Apr 22, 1:11 PM · Restricted Project
ABataev added a comment to D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..

Why is it enough to have one counter per warp, what happens if threads within a warp diverge? Before D55773 we had a counter per thread...

Mon, Apr 22, 12:23 PM · Restricted Project
ABataev updated the diff for D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..

Updated the test after the fix + outlined warp/lane id operations into functions.

Mon, Apr 22, 12:05 PM · Restricted Project
ABataev committed rOMP358902: [OPENMP][NVPTX] Fix the test, NFC..
[OPENMP][NVPTX] Fix the test, NFC.
Mon, Apr 22, 10:38 AM
ABataev committed rG5de5d74c8dcc: [OPENMP][NVPTX] Fix the test, NFC. (authored by ABataev).
[OPENMP][NVPTX] Fix the test, NFC.
Mon, Apr 22, 10:25 AM
ABataev committed rL358902: [OPENMP][NVPTX] Fix the test, NFC..
[OPENMP][NVPTX] Fix the test, NFC.
Mon, Apr 22, 10:25 AM

Fri, Apr 19

ABataev created D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..
Fri, Apr 19, 1:48 PM · Restricted Project
ABataev added inline comments to D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading.
Fri, Apr 19, 11:28 AM · Restricted Project
ABataev added inline comments to D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading.
Fri, Apr 19, 11:23 AM · Restricted Project
ABataev added inline comments to D60906: [OpenMP][libomptarget][WIP] Add math functions support in OpenMP offloading.
Fri, Apr 19, 11:22 AM · Restricted Project
ABataev added a reviewer for D60905: [OpenMP][LLVM][WIP] Add math functions support to OpenMP: tra.
Fri, Apr 19, 11:10 AM · Restricted Project
ABataev committed rG1472e32cd732: [OPENMP][NVPTX] target [teams distribute] simd maybe run without runtime. (authored by ABataev).
[OPENMP][NVPTX] target [teams distribute] simd maybe run without runtime.
Fri, Apr 19, 9:50 AM
ABataev committed rL358766: [OPENMP][NVPTX] target [teams distribute] simd maybe run without.
[OPENMP][NVPTX] target [teams distribute] simd maybe run without
Fri, Apr 19, 9:50 AM
ABataev committed rC358766: [OPENMP][NVPTX] target [teams distribute] simd maybe run without.
[OPENMP][NVPTX] target [teams distribute] simd maybe run without
Fri, Apr 19, 9:50 AM

Thu, Apr 18

ABataev added inline comments to D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
Thu, Apr 18, 12:52 PM · Restricted Project
ABataev added inline comments to D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used.
Thu, Apr 18, 12:42 PM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Thu, Apr 18, 12:38 PM · Restricted Project
ABataev accepted D60875: [OpenMP] Add checks for requires and target directives..

LG

Thu, Apr 18, 12:03 PM · Restricted Project
ABataev added inline comments to D60875: [OpenMP] Add checks for requires and target directives..
Thu, Apr 18, 10:04 AM · Restricted Project
ABataev added inline comments to D60875: [OpenMP] Add checks for requires and target directives..
Thu, Apr 18, 9:50 AM · Restricted Project
ABataev added inline comments to D60875: [OpenMP] Add checks for requires and target directives..
Thu, Apr 18, 9:35 AM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Thu, Apr 18, 7:58 AM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Thu, Apr 18, 7:36 AM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Thu, Apr 18, 6:52 AM · Restricted Project

Wed, Apr 17

ABataev added a comment to D60568: [OpenMP] Add support for registering requires directives with the runtime.

Other tests in presence of the requires directive with the clause?

Wed, Apr 17, 12:27 PM · Restricted Project
ABataev committed rGdc9e7dcbb0a5: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode. (authored by ABataev).
[OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.
Wed, Apr 17, 9:54 AM
ABataev committed rL358595: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode..
[OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.
Wed, Apr 17, 9:54 AM
ABataev committed rC358595: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode..
[OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.
Wed, Apr 17, 9:54 AM

Tue, Apr 16

ABataev added a comment to D60403: [CostModel][X86] Add bool anyof/allof reduction costs.

The patch itself looks good, can't say anything about the numbers.

Tue, Apr 16, 2:14 PM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 12:37 PM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 11:53 AM · Restricted Project
ABataev added a comment to D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.

Also, it would be good to try to add the tests for this new functionality

Tue, Apr 16, 11:24 AM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 11:24 AM · Restricted Project
ABataev added inline comments to D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
Tue, Apr 16, 11:03 AM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 9:06 AM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 8:56 AM · Restricted Project
ABataev committed rG5e2879320d91: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode. (authored by ABataev).
[OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.
Tue, Apr 16, 8:38 AM
ABataev committed rC358503: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode..
[OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.
Tue, Apr 16, 8:38 AM
ABataev committed rL358503: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode..
[OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.
Tue, Apr 16, 8:38 AM
ABataev committed rG3e8124631eee: [OPENMP]Require aarch arch for the tests, NFC. (authored by ABataev).
[OPENMP]Require aarch arch for the tests, NFC.
Tue, Apr 16, 7:25 AM
ABataev committed rC358493: [OPENMP]Require aarch arch for the tests, NFC..
[OPENMP]Require aarch arch for the tests, NFC.
Tue, Apr 16, 7:24 AM
ABataev committed rL358493: [OPENMP]Require aarch arch for the tests, NFC..
[OPENMP]Require aarch arch for the tests, NFC.
Tue, Apr 16, 7:24 AM
ABataev committed rGa0a2264ef757: [AArch64] Implement Vector Funtion ABI name mangling. (authored by ABataev).
[AArch64] Implement Vector Funtion ABI name mangling.
Tue, Apr 16, 6:56 AM
ABataev committed rC358490: [AArch64] Implement Vector Funtion ABI name mangling..
[AArch64] Implement Vector Funtion ABI name mangling.
Tue, Apr 16, 6:56 AM
ABataev committed rL358490: [AArch64] Implement Vector Funtion ABI name mangling..
[AArch64] Implement Vector Funtion ABI name mangling.
Tue, Apr 16, 6:56 AM
ABataev closed D60583: [AArch64] Implement Vector Funtion ABI name mangling..
Tue, Apr 16, 6:56 AM · Restricted Project, Restricted Project

Mon, Apr 15

ABataev committed rGe0eb13135f96: [OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD mode. (authored by ABataev).
[OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD mode.
Mon, Apr 15, 1:38 PM
ABataev committed rC358445: [OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD.
[OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD
Mon, Apr 15, 1:38 PM
ABataev committed rL358445: [OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD.
[OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD
Mon, Apr 15, 1:38 PM
ABataev accepted D59973: [SLP] Refactoring of the operand reordering code..
Mon, Apr 15, 1:38 PM · Restricted Project
ABataev added a comment to D59973: [SLP] Refactoring of the operand reordering code..

Seems good with a nit

Mon, Apr 15, 1:38 PM · Restricted Project
ABataev committed rG13532ea62340: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions. (authored by ABataev).
[OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions.
Mon, Apr 15, 1:14 PM
ABataev committed rL358442: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..
[OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions.
Mon, Apr 15, 1:13 PM
ABataev committed rOMP358442: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..
[OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions.
Mon, Apr 15, 1:13 PM
ABataev closed D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..
Mon, Apr 15, 1:13 PM · Restricted Project
ABataev added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

So, the test is good or I should put it into some other directory?

Mon, Apr 15, 12:12 PM · Restricted Project
ABataev accepted D60583: [AArch64] Implement Vector Funtion ABI name mangling..

LG

Mon, Apr 15, 12:06 PM · Restricted Project, Restricted Project
ABataev added inline comments to D59973: [SLP] Refactoring of the operand reordering code..
Mon, Apr 15, 10:02 AM · Restricted Project
ABataev added inline comments to D60583: [AArch64] Implement Vector Funtion ABI name mangling..
Mon, Apr 15, 9:55 AM · Restricted Project, Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Mon, Apr 15, 9:05 AM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Mon, Apr 15, 8:24 AM · Restricted Project
ABataev added inline comments to D60583: [AArch64] Implement Vector Funtion ABI name mangling..
Mon, Apr 15, 8:20 AM · Restricted Project, Restricted Project
ABataev updated the diff for D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

Moved the test to nvptx directory.

Mon, Apr 15, 7:16 AM · Restricted Project

Fri, Apr 12

ABataev added inline comments to D60583: [AArch64] Implement Vector Funtion ABI name mangling..
Fri, Apr 12, 1:33 PM · Restricted Project, Restricted Project
ABataev added inline comments to D59973: [SLP] Refactoring of the operand reordering code..
Fri, Apr 12, 12:59 PM · Restricted Project
ABataev added inline comments to D59973: [SLP] Refactoring of the operand reordering code..
Fri, Apr 12, 12:37 PM · Restricted Project
ABataev added inline comments to D60583: [AArch64] Implement Vector Funtion ABI name mangling..
Fri, Apr 12, 12:35 PM · Restricted Project, Restricted Project
ABataev added inline comments to D40577: Clang support for simd functions.
Fri, Apr 12, 11:56 AM
ABataev added inline comments to D59973: [SLP] Refactoring of the operand reordering code..
Fri, Apr 12, 11:47 AM · Restricted Project
ABataev added inline comments to D22792: VecClone Pass.
Fri, Apr 12, 11:27 AM
ABataev added inline comments to D40577: Clang support for simd functions.
Fri, Apr 12, 11:03 AM
ABataev added inline comments to D59973: [SLP] Refactoring of the operand reordering code..
Fri, Apr 12, 10:57 AM · Restricted Project
ABataev added inline comments to D59973: [SLP] Refactoring of the operand reordering code..
Fri, Apr 12, 9:30 AM · Restricted Project
ABataev updated the diff for D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

Added a test.

Fri, Apr 12, 9:01 AM · Restricted Project
ABataev added a comment to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Passing-by question: will this *only* consider non-power-of-two vectors, or all vectors that are smaller than the vector length?
I.e. is this something that will help with e.g. https://godbolt.org/z/h64TuT ? (from IRC)

Fri, Apr 12, 8:02 AM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Fri, Apr 12, 7:53 AM · Restricted Project
ABataev added inline comments to D60583: [AArch64] Implement Vector Funtion ABI name mangling..
Fri, Apr 12, 7:50 AM · Restricted Project, Restricted Project
ABataev added inline comments to D60583: [AArch64] Implement Vector Funtion ABI name mangling..
Fri, Apr 12, 7:44 AM · Restricted Project, Restricted Project
ABataev added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

...

Why don't we have unit tests here or in the llvm-test suite?

Because this is the library. Do you have an idea how to write the unit tests for it? It can be tested only with the executable tests.

We write google unit tests for various components, maybe something like that works here as well. A test that makes sure the initial output of omp_get_level is now 1 would then be great. It is by far not trivial to determine that omp_get_level, if called with an uninitialized device RT, should return parallelLevel + 1.

I know, that someone worked on the target-based testsuite, but don't know when it is going to be ready.

There is the V&V test suite: https://crpl.cis.udel.edu/ompvvsollve/
We could also add openmp target tests into the LLVM Test Suite and run them if people define CMAKE flags.

Actually, it was the testsuite, which reveals the problems with the runtime. But only after some changes in the compiler I made to run more constructs in SPMD. Before that they all were executed in non-SPMD and the problem was masked. And I don't see a problem here since the exhaustive testing is impossible in principle.
If you have a testsuite and ready to prepare and send an RFC, solve the problems with the license, organize it, setup buildbots, provide support, then go ahead. We can do everything, but it requires a lot of time. I agree that we need target-specific testing.

Our general policy is that all commits that can have tests, should have tests. We have OpenMP target tests in libomptarget/test -- and given that you've added tests there yourself, I assume that you know this ;) -- plus tests in libomptarget/deviceRTLs/nvptx/test - although it sounds like this situation can be triggered using portable code, so I'd prefer we add a test in libomptarget/test. Can you please do that?

Fri, Apr 12, 7:33 AM · Restricted Project

Thu, Apr 11

ABataev added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

LGTM

Is there a way we can test this?

It is tested in the internal testsuite, don't know when it is going to be committed to trunk

There are two problems:

  1. The internal testsuite did run before this patch, right? So it is unclear what that means.

No, the tests ran with this patch.

The internal test suite did run before this commit as well even though it was buggy. It is unclear to me what "the tests" does therefore mean.
Now you might have added some tests which nobody can check but we just see some changes that add "+ 1".
How should one review this? Similarly important, how should one now ensure this doesn't break in the future?

  1. Changes done upstream might break this without us noticing for a while and without being able to know apriory.

We test everything before doing any changes.

The problem is not that you do not test everything, the problem is that the rest cannot.

Why don't we have unit tests here or in the llvm-test suite?

Because this is the library. Do you have an idea how to write the unit tests for it? It can be tested only with the executable tests.

We write google unit tests for various components, maybe something like that works here as well. A test that makes sure the initial output of omp_get_level is now 1 would then be great. It is by far not trivial to determine that omp_get_level, if called with an uninitialized device RT, should return parallelLevel + 1.

I know, that someone worked on the target-based testsuite, but don't know when it is going to be ready.

There is the V&V test suite: https://crpl.cis.udel.edu/ompvvsollve/
We could also add openmp target tests into the LLVM Test Suite and run them if people define CMAKE flags.

Thu, Apr 11, 6:03 PM · Restricted Project
ABataev added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

LGTM

Is there a way we can test this?

It is tested in the internal testsuite, don't know when it is going to be committed to trunk

There are two problems:

  1. The internal testsuite did run before this patch, right? So it is unclear what that means.
Thu, Apr 11, 3:52 PM · Restricted Project
ABataev added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

LGTM

Is there a way we can test this?

Thu, Apr 11, 2:27 PM · Restricted Project
ABataev created D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..
Thu, Apr 11, 1:46 PM · Restricted Project
ABataev added inline comments to D59973: [SLP] Refactoring of the operand reordering code..
Thu, Apr 11, 1:13 PM · Restricted Project
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Thu, Apr 11, 9:21 AM · Restricted Project

Wed, Apr 10

ABataev committed rG5c4273620d80: [OPENMP]Improve detection of number of teams, threads in target regions. (authored by ABataev).
[OPENMP]Improve detection of number of teams, threads in target regions.
Wed, Apr 10, 12:11 PM
ABataev committed rL358126: [OPENMP]Improve detection of number of teams, threads in target.
[OPENMP]Improve detection of number of teams, threads in target
Wed, Apr 10, 12:11 PM