llvm-commits (Mailing List "llvm-commits")Mailing List
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 2 2015, 4:56 AM (111 w, 2 d)
Roles
Mailing List

Recent Activity

Jul 8 2016

llvm-commits added a comment to D22164: WebAssembly: Avoid implicit iterator conversions, NFC.

Committed in r274912.

Jul 8 2016, 12:44 PM

Jul 7 2016

llvm-commits added a comment to D22001: [DSE] Remove dead stores in end blocks containing fence.

anna marked an inline comment as done.
anna added a comment.

In http://reviews.llvm.org/D22001#474590, @dexonsmith wrote:

I don't see a patch on the list. Is this a problem with how you created the Phab review?

Sent patch separately to @dexonsmith. Response on patch:
isa works on references as well as pointers, so this can just be

if (isa<FenceInst>(*BBI))

Agree with Duncan, but the llvm ref states that this implicit conversion comes at a cost, and at some point in time, may be reverted to mean what standard iterators are. So, I'll leave it as-is to avoid any fix-ups required in future.

Jul 7 2016, 1:15 PM
llvm-commits added a comment to D21779: [LTO] Infer EKind/EMachine from Bitcode files.

> From: Rui Ueyama [ruiu@google.com]
> Sent: 06 July 2016 18:24
> To: reviews+D21779+public+dea87c23f5e22381@reviews.llvm.org
> Cc: Davide Italiano; Rafael Ávila de Espíndola; Daniel Sanders; George Rimar; Sean Silva; Peter Collingbourne; llvm-commits; Tim Amini Golling
> Subject: Re: [PATCH] D21779: [LTO] Infer EKind/EMachine from Bitcode files
>
> On Tue, Jul 5, 2016 at 6:33 AM, Daniel Sanders <daniel.sanders@imgtec.com<mailto:daniel.sanders@imgtec.com>> wrote:
> dsanders added a subscriber: dsanders.
>
> ================
> Comment at: lld/trunk/ELF/InputFiles.cpp:559-562
> @@ +558,6 @@
> + Triple TheTriple(TripleStr);
> + bool Is64Bits = TheTriple.isArch64Bit();
> + if (TheTriple.isLittleEndian())
> + return Is64Bits ? ELF64LEKind : ELF32LEKind;
> + return Is64Bits ? ELF64BEKind : ELF32BEKind;
> +}
> ----------------
> Sorry for the late comment but Triple::isArch64Bit() doesn't correspond to ELF64 or ELF32 on MIPS. In particular, the triple used for the
> N32 ABI will return true for isArch64Bit() but this ABI uses ELF32 objects. If lld doesn't support the N32 ABI yet then the current code is
> ok for the remaining two ABI's (O32 and N64).

Ah, interesting. So N32 is a 32-bit ABI on 64-bit MIPS just like x32 ABI is on x86-64. Do you know how to determine whether it is ELF32 or ELF64 for such triple?

Jul 7 2016, 6:23 AM

Jul 6 2016

llvm-commits added a comment to D21395: Fix for Bug 28144.

You can mark the dependency in phabricator explicitly.

Jul 6 2016, 12:53 PM

Jul 1 2016

llvm-commits added a comment to D20907: [IfConversion] Bugfix: don't add Undef flag on use if reg is live..

Hi Jonas,

Jul 1 2016, 4:09 PM

Jun 27 2016

llvm-commits added a comment to D21522: Document multi-line pattern matching in FileCheck.

LGTM.

Jun 27 2016, 2:30 PM

Jun 23 2016

llvm-commits added a comment to D21251: [TTI] The cost model should not assume illegal vector casts get completely scalarized.

If you don't mind, I'll add the test as a separate patch - we don't only want

>this specific test, we need tests for a bunch of sexts/zexts, like ARM has.
>

[Demikhovsky, Elena] yes, you can add tests later. You can look at this revision as a test reference for X86

http://reviews.llvm.org/D15604

Intel Israel (74) Limited

Jun 23 2016, 2:56 PM
llvm-commits added a comment to D21643: Default to using the Unicode version of Win32 APIs.

Should we add overloads of the UTF8 conversion functions that accept
wstrings?

Jun 23 2016, 8:23 AM

Jun 22 2016

llvm-commits added a comment to D21593: test-suite: Remove lemon benchmark.

lemon is mostly stable for me as well, but from time to time it has huge outliers (just speculating but maybe iOS throttles too much forking in some circumstances and that benchmark is at the edge of such throttling...)

Jun 22 2016, 11:19 AM

Jun 13 2016

llvm-commits added a comment to D21125: [llvm-objdump] Support detection of feature bits from the object and implement this for Mips..

Sounds reasonable, but why not return a SubtargetFeatures?
dsanders created this revision.
dsanders added a subscriber: llvm-commits.
Herald added subscribers: sdardis, dsanders.

Jun 13 2016, 1:55 PM
llvm-commits added a comment to D21237: LoopRotation: remove iterative calls to rotateLoops.

Right, my idea was to make loop-rotation more generic, thus enabling it on more complicated loops. It has some interesting corner cases though: for instance you can end up with several nested loops after rotating a single loop, but that's details, which we'll figure out in the process:)

Jun 13 2016, 9:38 AM

Jun 10 2016

llvm-commits added a comment to D20899: Delay dominator updation while cloning loop..

Sorry, though i clicked accept, i'll do so.
please commit.

Jun 10 2016, 7:36 AM

Jun 9 2016

llvm-commits added a comment to D21157: [pdb] Improve StreamInterface to support writing.

On second thought i think i can actually make that work. I was thinking
you'd want a full blown interval tree, but it could be done using the same
walk I'm doing for writing. Since this is still a rare case, I'm fine
adding this, or not adding it, depending on what people prefer

Jun 9 2016, 10:30 AM

Jun 8 2016

llvm-commits added a comment to D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.

llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

Jun 8 2016, 8:02 AM

Jun 6 2016

llvm-commits added a comment to D20560: [new PM] port LoopAccessAnalysis to new pass manager (part-1).

The renaming also makes the diff hard to read which I don't like either. I
will revert the renaming part.

Jun 6 2016, 5:44 PM

Jun 2 2016

llvm-commits added a comment to D20937: [cpu-detection] Naming convention..

To elaborate a bit here: what's happening is that the update the list sees
is that you added the list and some reviewers, rather than an initial email
that contains the patch and your description of it so that people can scan
and look at patches without needing to go to phabricator.

Jun 2 2016, 7:04 PM
llvm-commits added a comment to D20147: [WIP] DebugInfo: New metadata representation for global variables..

I wonder if that's the right long term solution?

Jun 2 2016, 3:40 PM

Jun 1 2016

llvm-commits added a comment to D20831: [Polly][GSoC]Rename ScopInfo to ScopBuilder.

llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

Jun 1 2016, 4:32 PM
llvm-commits added a comment to D19848: DeveloperPolicy: Bugreports should be referenced with an URL.

Although I like the change, I proposed something similar in http://lists.llvm.org/pipermail/llvm-dev/2016-May/099752.html and it was rejected.

Jun 1 2016, 3:01 PM
llvm-commits added a comment to D19664: [MemorySSA] Port to new pass manager.

Yeah, i don't either.
At this point, why don't we just have it own the caching walker and see
what it breaks.

Jun 1 2016, 8:42 AM

May 31 2016

llvm-commits added a comment to D20769: [IPRA] Interprocedural Register Allocation - Analysis Passes.

I know some of the issues are more a matter of personal preference than there being one true way. I just felt I should point out how I feel about them before people start writing them down as the one true way in the coding conventions :) I will of course not block the patches if we end up with a different style here.

May 31 2016, 6:07 PM

May 30 2016

llvm-commits added a comment to D20695: Floating Point SCEV Analysis.
May 30 2016, 11:05 AM

May 24 2016

llvm-commits added a comment to D20612: Analysis: Do not create call graph nodes for intrinsic functions..

You should probably note somewhere that assume is, in fact, readnone, we
just don't model it that way right now because it hasn't been changed to
use a real control dependency instead of a fake memory one.

May 24 2016, 10:23 PM
llvm-commits added a comment to D20423: [Clang][LLVMGold] Passing LLVM arguments to gold plugin.

This seems strange to me. For example, it breaks the otherwise very convenient:

$ clang -flto t.c -mllvm -some-internal-option-for-cc1

May 24 2016, 4:01 PM

May 23 2016

llvm-commits added a comment to D20162: [MSP430] PR27500 CodeGen: Rework branch-select pass.

ping


llvm-commits mailing list
llvm-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

May 23 2016, 5:17 AM

May 20 2016

llvm-commits added a comment to D20470: [llvm-dwarfdump] - Teach dwarfdump to decompress debug sections in zlib style..

Commit message typo: "depricated" should be "deprecated". Probably also
missing a "we" before [or use "it is" instead of] "are" in the last line.

May 20 2016, 8:00 AM

May 14 2016

llvm-commits added a comment to D19271: Change CALL_ONCE_INITIALIZATION implementation to use static initialization.

Can you investigate? So that we can have a correct implementation to propose instead.

May 14 2016, 4:45 PM

May 11 2016

llvm-commits added a comment to D20178: Fix PR26055 - LiveDebugValues is very slow.

Thanks for taking on this work!

May 11 2016, 12:52 PM

May 10 2016

llvm-commits added a comment to D20102: [ScheduleDAG] Make sure to process all def operands before any use operands.

I am fine with the change as is now after realizing that it does not change the behaviour of the subregister def case. So this change is fine!

May 10 2016, 11:46 AM

May 5 2016

llvm-commits added a comment to D19972: [scan-build] fix warnings emitted on LLVM dsymutil code base.

+Fred

May 5 2016, 12:45 PM

May 4 2016

llvm-commits added a comment to D19805: [SelectionDAG] BITREVERSE vector legalization of bit operations.

LGTM.

May 4 2016, 3:02 PM
llvm-commits added a comment to D19805: [SelectionDAG] BITREVERSE vector legalization of bit operations.

Hi Simon,

May 4 2016, 1:47 PM
llvm-commits added a comment to D19848: DeveloperPolicy: Bugreports should be referenced with an URL.

I have no problem with the suggestion for the body, but please leave the
PR# bit in the subject. The PR is the least useful part of any subject
to me and I don't want to devote more space to it.

May 4 2016, 12:01 PM

May 3 2016

llvm-commits added a comment to D19872: Produce cpio files for --reproduce.

The cpio command was dropped, but the format is still documented. The pax
command has to support it.

May 3 2016, 11:00 AM
llvm-commits added a comment to D19872: Produce cpio files for --reproduce.

================
Comment at: ELF/DriverUtils.cpp:130
@@ +129,3 @@
+ OS << "000000"; c_dev
+ OS << "000000";
c_ino FIXME: should be unique
+ OS << "100664";
c_mode: C_ISREG | rw-rw-r--


If you are not going to fix it, it is not a fixme. Please change the comment to say that this should be unique, but since no one cares, we don't bother to set a unique number.

May 3 2016, 9:11 AM

Apr 30 2016

llvm-commits added a comment to D19376: [MC] Create unique .pdata sections for every .text section.

Looking again, sorry for the long delay.

Apr 30 2016, 11:35 AM

Apr 29 2016

llvm-commits added a comment to D19737: Make --reproduce produce more reproducible logs..
Apr 29 2016, 1:25 PM
llvm-commits added a comment to D19711: [Polly] cmake: Set LINK_POLLY_INTO_TOOLS to ON.

I link Polly into my tools anyway, thus I'm in favor of changing the
default.

Apr 29 2016, 2:41 AM

Apr 27 2016

llvm-commits added a comment to D19426: [AArch64] Use the reciprocal estimation machinery.

Hi Evandro,

Apr 27 2016, 11:17 PM

Apr 26 2016

llvm-commits added a comment to D19550: [InstCombine] Determine the result of a select based on a dominating condition..
Apr 26 2016, 7:20 PM
llvm-commits added a comment to D19002: [LazyValueInfo] Fix for a nasty compile-time problem with questions.

Yes, I had already kicked off a build with your patches. Unfortunately it does not (at least no significantly) fix the issue and the test case is still running (for about 30 min now). My fix brings CT down to 2 min on an RA compiler.

Apr 26 2016, 7:08 PM

Apr 25 2016

llvm-commits added a comment to D19002: [LazyValueInfo] Fix for a nasty compile-time problem with questions.

the only code change is

Apr 25 2016, 12:47 PM
llvm-commits added a comment to D19468: Disallow duplication of imported entities (improved implementation).

I'm still vaguely thinking we should be doing this in the frontend instead.

Apr 25 2016, 12:38 PM

Apr 21 2016

llvm-commits added a comment to D19353: [GVN] Replace an inverted comparison with a logical not.

This looks fine to me.

Apr 21 2016, 7:50 AM

Apr 19 2016

llvm-commits added a comment to D19190: [ELF] - Implemented PROVIDE linker script command..

If at all possible my preference would be:

  • Require PRODIVE to be in an unambiguous location: inside an

OutputSection definition.

  • Produce DefinedSynthetic symbols for them so that the section is set

correctly.

Cheers,
Rafael

Apr 19 2016, 7:48 AM

Apr 18 2016

llvm-commits added a comment to D19236: Add DITypeIndex for CodeView and emit it for locals.

I like this. I think you're missing updates to ValueMapper.cpp, so
llvm-link will crash if you leave this as is. For the code there,
it would be best to treat DITypeIndex exactly like MDString.

Apr 18 2016, 2:15 PM

Apr 15 2016

llvm-commits added a comment to D19034: PR27284 - Reverse the ownership between DICompileUnit and DISubprogram.

Hi all,

Apr 15 2016, 1:05 PM

Apr 14 2016

llvm-commits added a comment to D18999: [ELF/LTO] Parallel Codegen for LLD.

What about the subtargets themselves?

Apr 14 2016, 2:20 PM

Apr 12 2016

llvm-commits added a comment to D18883: Add a pass to name anonymous/nameless function.

It should already be fixed with r266151

Apr 12 2016, 4:34 PM

Apr 7 2016

llvm-commits added a comment to D18822: [Polly][FIX] Adjust execution context of hoisted loads wrt. error domains.
Apr 7 2016, 4:44 AM

Apr 4 2016

llvm-commits added a comment to D18593: [PowerPC] Front end improvements for vec_splat.

I'll get to the rest of it, but for this Kit's question about O2: It's
preferred to test such things in the back end.

Apr 4 2016, 11:05 AM

Mar 29 2016

llvm-commits added a comment to D18554: [ELF, PR27016] - Do not keep undefined locals in .symtab.
Mar 29 2016, 9:00 AM

Mar 27 2016

llvm-commits added a comment to D17905: [Polly][DOC] Add fine-grain dependences analysis to release notes..

waiting for some one to accept :) Next time will push when I got a LGTM

Mar 27 2016, 11:47 PM · Restricted Project

Mar 24 2016

llvm-commits added a comment to D15965: Add support for dumping relocations in non-relocatable files.

llvm-objdump wants to print the relocationOffset, so it calls RelocationRef::relocationOffset which calls ELFObjectFile::getRelocationOffset

Mar 24 2016, 1:08 PM
llvm-commits added a comment to D18422: Add Cache Pruning support.

I plan on adding this to sys::fs::file_status indeed, hopefully it is not too hard and this patch can wait for it.

Mar 24 2016, 11:15 AM
llvm-commits added a comment to D18422: Add Cache Pruning support.

This is copy-pasted-adapted from module pruning. I plan to refactor module pruning to use this at some point.

Mar 24 2016, 10:05 AM

Mar 22 2016

llvm-commits added a comment to D16440: [ThinLTO] Link in only necessary DICompileUnit operands.

Hey Teresa,

Mar 22 2016, 4:36 PM
llvm-commits added a comment to D18371: StringMap::operator[] should not default construct the value when the key is in the map.

Ah, this is why. LGTM.

Mar 22 2016, 1:35 PM
llvm-commits added a comment to D18213: Add a module Hash in the bitcode and the combined index..

We can make it conditional (with a clang flag?), but the desired behavior is to be able to decide on enabling/disabling the caching at link time, so any bitcode static archive distributed would need to have a hash embedded. The user friendly choice would be to enabled it by *default* when -flto=thing, and an explicit option to disable it.

Mar 22 2016, 8:29 AM

Mar 21 2016

llvm-commits added a comment to D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations..

I would really ask the reviewers then if they will have a time to take a look on current aarch64 patches.
As updating them in every day lld changing world is really painfull sometimes.

Mar 21 2016, 9:32 AM

Mar 15 2016

llvm-commits added a comment to D18109: Prevent GlobalOpts from dropping ASANitized global variables.

I'm concerned that fixing up GlobalOpt::deleteIfDead isn't enough
to avoid affecting CodeGen. There are other places in the
pipeline that will check Value::use_empty and/or have logic like
(or use directly) Function::isDefTriviallyDead. I think it's
important that the call to GV.removeDeadConstantUsers() has the
same effect on use-lists whether or not there's any debug info.
Moreover, GlobalOpt::deleteIfDead should have the same effect on
the entire module (including use-lists) regardless of debug info.

Mar 15 2016, 1:47 PM

Mar 10 2016

llvm-commits added a comment to D16998: [AMDGPU] llvm-objdump: disassembling amdgcn object file.

In other words, this is a Elf_Rel file? Why do you need a new extension?

Mar 10 2016, 9:28 AM · Restricted Project

Mar 3 2016

llvm-commits added a comment to D17870: [ADT] Add an 'llvm::seq' function which produces an iterator range over a sequence of values. It increments through the values in the half-open range: [Begin, End), producing those values when indirecting the iterator. It should support integers....

Hi Chandler

Mar 3 2016, 2:49 PM

Mar 2 2016

llvm-commits added a comment to D17747: TableGen: Check scheduling models for completeness.

Static checking should be more robust long-term than relying on the dynamic checks with the assert. This however means that instructions not supported by a CPU should be explicitely marked as unsupported. I just pushed a commit which lets you mark InstRW expressions as unsupported (on top of the existing support to mark scheduling resources as unsupported or whole instructions as not appearing in the scheduler). So it should be easy to get the list from tablegen and exclude the missing instructions with something like:

Mar 2 2016, 4:15 PM

Mar 1 2016

llvm-commits added a comment to D17144: [AMDGPU] add AMDGPU target support to ELFObjectFile.h header.

Can you fix it and then add code to LLVM? Adding code to LLVM allows people
to start creating object files in the odd "ELF" format. If a fix is not
made in a timely manner, it can be too late, and there's a chance that you
will have no choice other than supporting the old broken format.

Mar 1 2016, 2:32 PM · Restricted Project

Feb 26 2016

llvm-commits added a comment to D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin.

Sure!

Feb 26 2016, 11:52 AM

Feb 25 2016

llvm-commits added a comment to D17475: MachineCopyPropagation: Catch copies of the form A<-B;A<-B.

That’ll work, though it should be a follow-up patch IMO.

Feb 25 2016, 11:45 AM

Feb 18 2016

llvm-commits added a comment to D16890: Fix PR25339: ARM Constant Island.

Hi Renato,

Feb 18 2016, 12:29 PM
llvm-commits added a comment to D17381: [Polly] [RFC] Fine-grain dependency analysis.

Build dependence information based on tagged access [1], e.g. for access:

MustWriteAccess :=  [Reduction Type: NONE] [Scalar: 0]
    [N] -> { Stmt_for_body[i0] -> MemRef_b[6 + i0] };

we build tag it and get:

  • -> {[Stmt_for_body[i0] -> MemRef_a[]] -> MemRef_b[6 + i0] };

Why does it say MemRef_a and then MemRef_b ?

Feb 18 2016, 8:01 AM
llvm-commits added a comment to D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings..

It is unclear. Without knowing what is an actual gas/ld bug and what
is a reasonable limitation. Why is gas on linux rejecting indirect
pcrel? Is it at least acknowledge as a bug or are they aware of some
reason to reject it that we are not?

Feb 18 2016, 7:29 AM

Feb 15 2016

llvm-commits added a comment to D17241: [Polly] [Refactor] Move isl_ctx into Scop..

And if ScopInfo, DependencyInfo, IslAst are not free in order, it become a total mess ....

The pass manager should free IslAst, DependencyInfo, ... before ScopInfo
because they have a dependence on the ScopInfo results. Am I wrong?

Feb 15 2016, 7:28 AM

Feb 14 2016

llvm-commits added a comment to D16685: [tsan] Add a libc++ and lit testsuite for each ${TSAN_SUPPORTED_ARCH}..

Hi Hans,

Feb 14 2016, 4:45 PM

Feb 13 2016

llvm-commits added a comment to D17090: Fix LLVM's handling and detection of skylake and cannonlake CPUs.

We have
def : CannonlakeProc<"cannonlake">;
def : CannonlakeProc<"cnl">;

Feb 13 2016, 1:08 PM

Feb 9 2016

llvm-commits added a comment to D16885: [mips] Extend MipsAsmParser class to handle %got(sym + const) expressions.

LGTM

Feb 9 2016, 1:50 PM

Feb 2 2016

llvm-commits added a comment to D16835: InstCombine: Restrict computeKnownBits() on everyValue to OptLevel > 2.

Given that I don't have a single file in the whole llvm-testsuite where this transformation kicks in I wouldn't know how to start tuning it, so this patch simply pushes it to -O3 only.

Feb 2 2016, 6:46 PM

Jan 29 2016

llvm-commits added a comment to D16343: [BasicAA] Fix for missing must alias information.

Aside from the suspected UB (which I think Philip was right about,
see my comments inline below), this seems pretty obviously correct.

Jan 29 2016, 3:17 PM

Jan 25 2016

llvm-commits added a comment to D16530: [Polly] Introduce MemAccInst helper class; NFC.

+/ getValueOperand() and getPointerOperand() have different implementations in
+
/ LoadInst and StoreInst, but for most other members the implementation is
+/ identical. Those have been reproduced here to avoid useless branching to
+
/ identical implementations. If those implementations change in
+/// LoadInst/StoreInst, they must be changed here as well.

The last sentence alone guarantees problems. Duplication is (almost)
never a solution, especially not to save a call/jump/branch.

Jan 25 2016, 6:58 AM · Restricted Project

Jan 20 2016

llvm-commits added a comment to D15983: [GlobalISel] Add the proper cmake plumbing..

I believe r258379 should fix the problem.

Jan 20 2016, 5:59 PM

Jan 19 2016

llvm-commits added a comment to D16170: Registry initialization and linkage interactions.

This was already reverted due to those build failures.

Jan 19 2016, 12:00 PM

Jan 14 2016

llvm-commits added a comment to D16196: [test-suite] Add HOME to test env under lit.

We have found that some benchmarks will differ their performance based on the sizes of the environment variables. KS is a good example of this. Is there a better way to do this than populating the environment?

Jan 14 2016, 11:30 AM

Jan 11 2016

llvm-commits added a comment to D15703: [AVR] Add instruction definitions.

Ping.

Jan 11 2016, 12:13 AM

Jan 7 2016

llvm-commits added a comment to D15792: [AArch64] Turn off PredictableSelectIsExpensive on the Cortex-A57.

As far as I know, there is a mixup in reference results (rdar://23577619 rdar://23577619 for apple people). About the state of the LNTBased/—with-spec-ref you best ask Adam (CCed now).

Jan 7 2016, 1:37 PM
llvm-commits added a comment to D15798: Fix for Bug 24852 (crash with -debug -instcombine).

This is what I was fearing, it needs a real metadata attached.
Replacing the setDebugLoc with

Jan 7 2016, 10:00 AM

Jan 5 2016

llvm-commits added a comment to D15564: [ELF] - Optimize .eh_frame section: remove CIE if all FDEs referencing it were removed..

This patch does not particularly seem that it has a negative impact on
performance. It is reasonable to see only noises when comparing
performances before and after this patch. I believe Rafael left the note
for "just in case".

Jan 5 2016, 9:03 AM

Dec 24 2015

llvm-commits added a comment to D15480: [ELF][MIPS] Handle R_MIPS_HI16/LO16 relocations against _gp_disp symbol.

I thinking about that place last time.
May be we should add A argument to Target->relocateOne() ?
That can help to move that calculation to mips target, since it looks like absence of A inside relocateOne() is the only stoppable for doing that.

Currently S+A is a single parameter SA. Are you suggesting split that as two parameters, S and A?

I don't know if that makes code simpler, but it may worth trying.

Dec 24 2015, 3:22 AM · lld

Dec 22 2015

llvm-commits added a comment to D15693: [Polly] Take a PHI's incoming block as value user.
Dec 22 2015, 5:26 PM · Restricted Project

Dec 21 2015

llvm-commits added a comment to D15706: [Polly] Follow uses to create value MemoryAccesses.

+; TODO: Because of the phi with 3 incoming blocks, the loop for => outofscop is
+; not recognized as a loop, but as a non-affine subregion.

My guess would be this is because ScalarEvolution cannot create an
AddRec for %j. PHIs with multiple incoming blocks are generally not a
problem.

Dec 21 2015, 5:39 PM · Restricted Project

Dec 14 2015

llvm-commits added a comment to D14715: [Polly] Loop versioning after code generation (WIP).

Polly has to become a SCC pass anyway in order to make parallelization
valid (and allow inter-procedural analysis), thus this should not be a
concern. However, it seems odd and expensive to create a function only
to inline it again, so we might not want to do that.

Dec 14 2015, 8:23 AM · Restricted Project
llvm-commits added a comment to D14715: [Polly] Loop versioning after code generation (WIP).

To bad, I thought this was a nice solution.

Dec 14 2015, 7:25 AM · Restricted Project

Dec 10 2015

llvm-commits added a comment to D15328: [x86][avx512] more changes in intrinsics to be align with gcc format.

The stance I had always taken was that if clang and gcc both have a builtin
for something we match them. If clang doesn't need a builtin and gcc does
then we just don't match.

Dec 10 2015, 1:41 PM
llvm-commits added a comment to D15328: [x86][avx512] more changes in intrinsics to be align with gcc format.

To be compatible with GCC headers.

Dec 10 2015, 4:14 AM

Dec 2 2015

llvm-commits added a comment to D14687: Macro support in LLVM IR.

Sorry for the delay, was away all last week and haven't made it back
through my inbox yet. I just saw your ping to Alexey.

Dec 2 2015, 10:06 AM
llvm-commits added a comment to D15110: Fixed a bug in FP logic operation lowering on AVX-512.

I can't enable FABS before I fix ANDPS.
I can fix the ANDPS, but I don't know how to test it without FABS.

Dec 2 2015, 1:11 AM

Dec 1 2015

llvm-commits added a comment to D14473: [Verifier] Improve error for cross-module references.

Yup, LGTM.

Dec 1 2015, 9:23 AM

Nov 25 2015

llvm-commits added a comment to D14909: [X86][FMA] Optimize FNEG(FMUL) Patterns.

[I added this to Phab over an hour ago, but it hasn't made it to the list
afaict, so repeating with an email.]

Nov 25 2015, 10:01 AM

Nov 22 2015

llvm-commits added a comment to D14815: AVX-512: INSERT_SUBVECTOR optimization for i1 vectors.

Thank you for the review. I applied your comments.

What are the consequences of removing the HasVLX predicate?

VK legal types cover predicates. (If VK4 of VK2 are legal, the VLX is on)

Nov 22 2015, 11:14 AM

Nov 18 2015

llvm-commits added a comment to D14788: Fix bug 24715.

Looking a related code, it looks like we're failing to consider the
return value of the same function at it's other call site. Any interest
in fixing that too?

Nov 18 2015, 2:22 PM

Nov 17 2015

llvm-commits added a comment to D14480: Improve running time of getAsmSrcLocInfo.

David, did you also have a clang-format issue where it wasn't breaking
short if's? In the end how did you fix it? Yunlian seems to be having a
similar problem.

Nov 17 2015, 7:42 PM · Restricted Project

Nov 16 2015

llvm-commits added a comment to D14699: [GlobalOpt] Allow constant globals to be SRA'd.
Nov 16 2015, 8:08 AM

Nov 11 2015

llvm-commits added a comment to D14477: Remove unnecessary call to getAllocatableRegClass.

Hi Fiona,

Nov 11 2015, 5:08 PM