MaskRay (Fangrui Song)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 30 2016, 3:24 PM (80 w, 6 d)

Recent Activity

Today

MaskRay committed rL337505: [docs] Correct -fvisibility-inlines-hidden description.
[docs] Correct -fvisibility-inlines-hidden description
Thu, Jul 19, 3:51 PM
MaskRay committed rC337505: [docs] Correct -fvisibility-inlines-hidden description.
[docs] Correct -fvisibility-inlines-hidden description
Thu, Jul 19, 3:50 PM

Yesterday

MaskRay abandoned D49506: [ELF] gdb-index: ignore DWARFAddressRange whose SectionIndex=-1.
Wed, Jul 18, 3:30 PM
MaskRay committed rL337427: [ELF] Error if -r --gdb-index are used together.
[ELF] Error if -r --gdb-index are used together
Wed, Jul 18, 3:08 PM
MaskRay committed rLLD337427: [ELF] Error if -r --gdb-index are used together.
[ELF] Error if -r --gdb-index are used together
Wed, Jul 18, 3:08 PM
MaskRay closed D49513: [ELF] Error if -r --gdb-index are used together.
Wed, Jul 18, 3:08 PM
MaskRay retitled D49513: [ELF] Error if -r --gdb-index are used together from [ELF] gdb-index: don't remove .debug_gnu_pub{names,types} in -r mode to [ELF] Error if -r --gdb-index are used together.
Wed, Jul 18, 3:03 PM
MaskRay updated the diff for D49513: [ELF] Error if -r --gdb-index are used together.

.

Wed, Jul 18, 3:03 PM
MaskRay created D49513: [ELF] Error if -r --gdb-index are used together.
Wed, Jul 18, 2:52 PM
MaskRay created D49506: [ELF] gdb-index: ignore DWARFAddressRange whose SectionIndex=-1.
Wed, Jul 18, 1:15 PM

Tue, Jul 17

MaskRay committed rL337318: [Demangle] Add missing header files.
[Demangle] Add missing header files
Tue, Jul 17, 12:55 PM
MaskRay added a comment to D48091: [PPC64] Add TLS initial exec to local exec relaxation.

Just a question. Does this patch support the optimization that fills in the GOT slot when a group of initial-exec relocations are known to be link-time constants?

Tue, Jul 17, 10:54 AM

Mon, Jul 16

MaskRay committed rL337200: [CodeGen] Fix inconsistent declaration parameter name.
[CodeGen] Fix inconsistent declaration parameter name
Mon, Jul 16, 11:57 AM

Sat, Jul 14

MaskRay added a comment to D45805: [libcxx] Remove redundant specializations in type_traits..

Ping :)

Sat, Jul 14, 12:45 PM

Fri, Jul 13

MaskRay committed rL337063: Fix -Wswitch after introduction of clang;:Type::DependentVector in r337036.
Fix -Wswitch after introduction of clang;:Type::DependentVector in r337036
Fri, Jul 13, 3:45 PM
MaskRay committed rL337052: [X86] Correct comment of TEST elimination in BSF/TZCNT.
[X86] Correct comment of TEST elimination in BSF/TZCNT
Fri, Jul 13, 2:45 PM
MaskRay added a comment to rL336768: [X86] The TEST instruction is eliminated when BSF/TZCNT is used.

Not sure if it has been fixed in r337043 ,,,

Fri, Jul 13, 2:01 PM
MaskRay committed rL337043: [X86] Try fixing r336768.
[X86] Try fixing r336768
Fri, Jul 13, 1:59 PM

Thu, Jul 12

MaskRay committed rL336957: [InstCombine] Simplify isKnownNegation.
[InstCombine] Simplify isKnownNegation
Thu, Jul 12, 4:01 PM

Wed, Jul 11

MaskRay committed rL336879: [AsmParser] Fix inconsistent declaration parameter name.
[AsmParser] Fix inconsistent declaration parameter name
Wed, Jul 11, 7:09 PM
MaskRay committed rL336837: [DebugInfo] Fix getPreviousSibling after r336823.
[DebugInfo] Fix getPreviousSibling after r336823
Wed, Jul 11, 12:14 PM

Mon, Jul 9

MaskRay committed rC336606: [Index] Add index::IndexingOptions::IndexImplicitInstantiation.
[Index] Add index::IndexingOptions::IndexImplicitInstantiation
Mon, Jul 9, 2:54 PM
MaskRay committed rL336606: [Index] Add index::IndexingOptions::IndexImplicitInstantiation.
[Index] Add index::IndexingOptions::IndexImplicitInstantiation
Mon, Jul 9, 2:54 PM
MaskRay closed D49002: [Index] Add index::IndexingOptions::IndexImplicitInstantiation.
Mon, Jul 9, 2:54 PM
MaskRay committed rL336605: [AST] Rename some Redeclarable functions to reduce confusion.
[AST] Rename some Redeclarable functions to reduce confusion
Mon, Jul 9, 2:36 PM
MaskRay committed rC336605: [AST] Rename some Redeclarable functions to reduce confusion.
[AST] Rename some Redeclarable functions to reduce confusion
Mon, Jul 9, 2:36 PM
MaskRay closed D48894: [AST] Rename some Redeclarable functions to reduce confusion.
Mon, Jul 9, 2:36 PM · Restricted Project
MaskRay added a comment to D49000: [DebugInfo] Change default value of FDEPointerEncoding.

Just curious, in which case the R (in augment string) is missing?

Mon, Jul 9, 10:56 AM
MaskRay accepted D49000: [DebugInfo] Change default value of FDEPointerEncoding.

The most relevant document about .eh_frame I can find is http://refspecs.linuxbase.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/ehframechpt.html , which does not say what the default encoding for FDE pointers should be.

Mon, Jul 9, 10:53 AM

Fri, Jul 6

MaskRay committed rL336459: [IR] Fix inconsistent declaration parameter name.
[IR] Fix inconsistent declaration parameter name
Fri, Jul 6, 12:30 PM

Thu, Jul 5

MaskRay created D49002: [Index] Add index::IndexingOptions::IndexImplicitInstantiation.
Thu, Jul 5, 5:02 PM

Wed, Jul 4

MaskRay committed rC336300: [Index] Remove unused index::IndexDataConsumer::_anchor().
[Index] Remove unused index::IndexDataConsumer::_anchor()
Wed, Jul 4, 5:38 PM
MaskRay committed rL336300: [Index] Remove unused index::IndexDataConsumer::_anchor().
[Index] Remove unused index::IndexDataConsumer::_anchor()
Wed, Jul 4, 5:37 PM

Tue, Jul 3

MaskRay updated the diff for D48894: [AST] Rename some Redeclarable functions to reduce confusion.

Rename Next to Link as per rsmith

Tue, Jul 3, 8:07 PM · Restricted Project
MaskRay committed rL336237: [Support] Remove SaveOr which is no longer used.
[Support] Remove SaveOr which is no longer used
Tue, Jul 3, 4:36 PM
MaskRay committed rL336232: [X86][AsmParser] Fix inconsistent declaration parameter name in r336218.
[X86][AsmParser] Fix inconsistent declaration parameter name in r336218
Tue, Jul 3, 2:45 PM
MaskRay created D48894: [AST] Rename some Redeclarable functions to reduce confusion.
Tue, Jul 3, 1:29 PM · Restricted Project
MaskRay committed rL336223: [ARM] Fix inconsistent declaration parameter name in r336195.
[ARM] Fix inconsistent declaration parameter name in r336195
Tue, Jul 3, 12:17 PM
MaskRay committed rL336222: [AArch64] Make function parameter names in declarations match those of….
[AArch64] Make function parameter names in declarations match those of…
Tue, Jul 3, 12:12 PM

Mon, Jul 2

MaskRay committed rL336136: [ELF] Fix other tests after r336129.
[ELF] Fix other tests after r336129
Mon, Jul 2, 12:22 PM
MaskRay committed rLLD336136: [ELF] Fix other tests after r336129.
[ELF] Fix other tests after r336129
Mon, Jul 2, 12:22 PM
MaskRay committed rL336135: [ELF] Fix just-symbols*.s after r336129.
[ELF] Fix just-symbols*.s after r336129
Mon, Jul 2, 12:17 PM
MaskRay committed rLLD336135: [ELF] Fix just-symbols*.s after r336129.
[ELF] Fix just-symbols*.s after r336129
Mon, Jul 2, 12:16 PM
MaskRay committed rL336131: Replace unused output filenames with /dev/null in tests.
Replace unused output filenames with /dev/null in tests
Mon, Jul 2, 11:21 AM
MaskRay added inline comments to D46653: Start support for linking object files with split stacks.
Mon, Jul 2, 11:09 AM
MaskRay committed rLLD336129: [ELF] Replace unused output filenames with /dev/null in tests.
[ELF] Replace unused output filenames with /dev/null in tests
Mon, Jul 2, 10:54 AM
MaskRay committed rL336129: [ELF] Replace unused output filenames with /dev/null in tests.
[ELF] Replace unused output filenames with /dev/null in tests
Mon, Jul 2, 10:53 AM

Sun, Jul 1

MaskRay added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

Fixed for FreeBSD? There is still a problem for NetBSD, but I'm still swamped with other things.

Sun, Jul 1, 1:07 PM
MaskRay added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

BTW, how did you figure out it dead locked in __asan_init?

Sun, Jul 1, 11:30 AM
MaskRay committed rCRT336067: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in….
[asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in…
Sun, Jul 1, 10:57 AM
MaskRay committed rL336067: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in….
[asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in…
Sun, Jul 1, 10:57 AM
MaskRay closed D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.
Sun, Jul 1, 10:57 AM
MaskRay added a comment to D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.

The failing tests might depend on FreeBSD version, on 10.4

[100%] Running the XRay tests
Testing Time: 2.81s
  Expected Passes    : 57
  Unsupported Tests  : 1
[100%] Built target check-xray

Also, as an alternative, what if we disable the early init in asan only instead of generalising it ? Works too.

Sun, Jul 1, 9:38 AM
MaskRay updated the diff for D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.

Special case xray to use unsafe .preinit_array

Sun, Jul 1, 9:37 AM

Sat, Jun 30

MaskRay updated the diff for D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.

80 columns rule

Sat, Jun 30, 6:17 PM
MaskRay added a comment to D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.

Hopefully unit tests still passing.

Sat, Jun 30, 6:11 PM
MaskRay added a comment to D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.

Is Xray instrumentation working now ?

Sat, Jun 30, 3:43 PM
MaskRay updated the summary of D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.
Sat, Jun 30, 3:33 PM
MaskRay updated the summary of D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.
Sat, Jun 30, 3:29 PM
MaskRay added a reviewer for D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240: devnexen.
Sat, Jun 30, 1:47 PM
MaskRay added a comment to rL325240: Add Xray instrumentation support to FreeBSD.

FWIW, after this commit, on FreeBSD 12.0-CURRENT, most (if not all) ASan tests hang in 'urdlck' state. I'm still investigating.

Sat, Jun 30, 1:45 PM
MaskRay updated the summary of D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.
Sat, Jun 30, 1:43 PM
MaskRay updated the summary of D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.
Sat, Jun 30, 1:41 PM
MaskRay added reviewers for D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240: khng300, emaste, dim.
Sat, Jun 30, 1:28 PM
MaskRay created D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.
Sat, Jun 30, 1:27 PM
MaskRay committed rCRT336046: [asan] Use MADV_NOCORE for use_madv_dontdump on FreeBSD..
[asan] Use MADV_NOCORE for use_madv_dontdump on FreeBSD.
Sat, Jun 30, 1:33 AM
MaskRay committed rL336046: [asan] Use MADV_NOCORE for use_madv_dontdump on FreeBSD..
[asan] Use MADV_NOCORE for use_madv_dontdump on FreeBSD.
Sat, Jun 30, 1:32 AM
MaskRay closed D48257: [asan] Use MADV_NOCORE for use_madv_dontdump on FreeBSD..
Sat, Jun 30, 1:32 AM

Fri, Jun 29

MaskRay committed rLLD335992: [ELF] Set -o because current directory may not be writable during a test.
[ELF] Set -o because current directory may not be writable during a test
Fri, Jun 29, 10:12 AM
MaskRay committed rL335992: [ELF] Set -o because current directory may not be writable during a test.
[ELF] Set -o because current directory may not be writable during a test
Fri, Jun 29, 10:12 AM

Thu, Jun 28

MaskRay accepted D48554: Handle absolute symbols as branch targets in disassembly..
Thu, Jun 28, 9:51 AM

Wed, Jun 27

MaskRay committed rL335785: [llvm-objdump] Add -x --all-headers options.
[llvm-objdump] Add -x --all-headers options
Wed, Jun 27, 1:50 PM
MaskRay closed D48622: [llvm-objdump] Add -x --all-headers options.
Wed, Jun 27, 1:50 PM
MaskRay committed rLLD335784: [ELF] Use %eiz after disassembler change in r335768.
[ELF] Use %eiz after disassembler change in r335768
Wed, Jun 27, 1:50 PM
MaskRay committed rL335784: [ELF] Use %eiz after disassembler change in r335768.
[ELF] Use %eiz after disassembler change in r335768
Wed, Jun 27, 1:50 PM
MaskRay added a comment to D48622: [llvm-objdump] Add -x --all-headers options.

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

We also lack -a (--archive-headers) and -f (--file-headers) :)

That's right, I will take a look at it when I have more time, thanks a lot ! :)

Wed, Jun 27, 1:41 PM
MaskRay committed rL335771: [WebAssembly] Try fixing test/CodeGen/WebAssembly/vector_sdiv.ll.
[WebAssembly] Try fixing test/CodeGen/WebAssembly/vector_sdiv.ll
Wed, Jun 27, 12:40 PM
MaskRay committed rL335769: [X86] Fix unmatched parenthesis in r335768.
[X86] Fix unmatched parenthesis in r335768
Wed, Jun 27, 12:17 PM
MaskRay added inline comments to D48406: [ELF] Make non-writable non-executable PROGBITS sections closer to .text.
Wed, Jun 27, 9:04 AM
MaskRay committed rL335743: [ELF] Rename RF_PROGBITS_NOT_EXEC_OR_WRITE to RF_RODATA.
[ELF] Rename RF_PROGBITS_NOT_EXEC_OR_WRITE to RF_RODATA
Wed, Jun 27, 9:01 AM
MaskRay committed rLLD335743: [ELF] Rename RF_PROGBITS_NOT_EXEC_OR_WRITE to RF_RODATA.
[ELF] Rename RF_PROGBITS_NOT_EXEC_OR_WRITE to RF_RODATA
Wed, Jun 27, 9:01 AM
MaskRay added a comment to D48622: [llvm-objdump] Add -x --all-headers options.

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

Wed, Jun 27, 8:43 AM

Tue, Jun 26

MaskRay created D48622: [llvm-objdump] Add -x --all-headers options.
Tue, Jun 26, 11:58 PM
MaskRay added a reviewer for D48257: [asan] Use MADV_NOCORE for use_madv_dontdump on FreeBSD.: emaste.
Tue, Jun 26, 4:11 PM
MaskRay committed rLLD335676: [ELF] Move `// REQUIRES:` line to the top.
[ELF] Move `// REQUIRES:` line to the top
Tue, Jun 26, 3:25 PM
MaskRay committed rL335676: [ELF] Move `// REQUIRES:` line to the top.
[ELF] Move `// REQUIRES:` line to the top
Tue, Jun 26, 3:25 PM
MaskRay committed rLLD335674: [ELF] Make non-writable non-executable PROGBITS sections closer to .text.
[ELF] Make non-writable non-executable PROGBITS sections closer to .text
Tue, Jun 26, 3:19 PM
MaskRay committed rL335674: [ELF] Make non-writable non-executable PROGBITS sections closer to .text.
[ELF] Make non-writable non-executable PROGBITS sections closer to .text
Tue, Jun 26, 3:18 PM
MaskRay closed D48406: [ELF] Make non-writable non-executable PROGBITS sections closer to .text.
Tue, Jun 26, 3:18 PM
MaskRay updated the diff for D48406: [ELF] Make non-writable non-executable PROGBITS sections closer to .text.

Update all tests.

Tue, Jun 26, 3:11 PM
MaskRay committed rL335635: Move `REQUIRES:` line to the top.
Move `REQUIRES:` line to the top
Tue, Jun 26, 10:49 AM
MaskRay added inline comments to D48554: Handle absolute symbols as branch targets in disassembly..
Tue, Jun 26, 10:23 AM
MaskRay added reviewers for D48554: Handle absolute symbols as branch targets in disassembly.: enderby, ruiu.
Tue, Jun 26, 10:18 AM
MaskRay committed rL335627: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used.
[ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used
Tue, Jun 26, 10:09 AM
MaskRay committed rLLD335627: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used.
[ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used
Tue, Jun 26, 10:09 AM
MaskRay closed D48405: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used.
Tue, Jun 26, 10:09 AM
MaskRay closed D48405: [ELF] Assign RF_EXEC rank even if --no-rosegment or SECTIONS command is used.
Tue, Jun 26, 10:09 AM
MaskRay committed rL335625: [ELF] Move `# REQUIRES:` line to the top.
[ELF] Move `# REQUIRES:` line to the top
Tue, Jun 26, 10:03 AM
MaskRay committed rLLD335625: [ELF] Move `# REQUIRES:` line to the top.
[ELF] Move `# REQUIRES:` line to the top
Tue, Jun 26, 10:03 AM

Mon, Jun 25

MaskRay added a reviewer for D48554: Handle absolute symbols as branch targets in disassembly.: MaskRay.
Mon, Jun 25, 10:25 PM