- User Since
- Dec 30 2016, 3:24 PM (195 w, 1 d)
In any case I have to do a large run internally because we still use -fcommon :)
Sorry for the churn. On the bright side if this change impacts any internal projects you can use it to help convince them to stop using -fcommon :).
Without the patch
Delete unneeded 'Function' declaration
Fri, Sep 25
Please include a brief message why the change is reverted in the future
Checked lld/test/ELF updates, GNU ar silently allows invalid 'symbolic' files. I think being more rigid in llvm-ar is fine.
Hi @aprantl, this breaks test/Bitcode/DISubprogram-v4.ll
Thu, Sep 24
Thanks for review! I will wait until next week.
Good idea. I only got to know this after I read the source code. Many people probably have the same confusion.
[lld] Add a new known text prefix - ".text.split."
This looks good to me. Please add a test to test/ELF/text-section-prefix.s
[llvm]Add an option to emit cold clusters to a different section.
I probably have asked too much... but it'd be nice if you also add some documentation to llvm/docs/XRay*.rst That helps users :)
@froydnj The committed version rG31a3c5fb45b78bdaa78d94ffcc9258e839002016 appears to be very different from the review. I guess next time your probably can upload the diff again if it is very diffierent
Wed, Sep 23
We usually use x86 for generic feature tests (sorry). I am fine with ppc but the test is probably worth a comment that some FORTRAN libraries on ppc require this behavior (i.e. if you no longer require this behavior and if we need some symbol table refactoring where this behavior gets in the way, we should have the right to revisit the decision. SHN_COMMON will get more and more obsoleted and hope we don't need this particular behavior in the future ;-) )
Hi Sri, a pattern used by others for relands is like:
This caused a -fsanitize=cfi issue in thinltoBackend. I reverted the patch temporarily and shared a detailed reproduce with Teresa
Looks great! Worth getting @sfertile's sign-off.
Tue, Sep 22
When you recommit, consider adding the header to the description. The original message started with "The wrong placement of add pass with optimizations led to -funique-internal-linkage-names being disabled." The header was missing.
API changes may cause problems to other backends. It is a good idea to test -DLLVM_TARGETS_TO_BUILD=ALL
@rahmanl The patch will look better if you can give a more formal approval :)
Hi, please use more descriptive subjects for future commits, e.g. Fix TableGen builds
If base == 0, to_integer can parse the 0x prefix.
FWIW I tested check-msan in a -DCMAKE_BUILD_TYPE=Release build on a
powerpc64le machine. All tests passed. I cannot connect the failure to
the clang patch.
Mon, Sep 21