- User Since
- Dec 30 2016, 3:24 PM (90 w, 4 d)
Update reviewers line with arc diff --verbatim (see if this command works)
Incorporate review suggestions by dblaikie
Update title with arc diff --edit --verbatim
Depends on D52451 (adding LLVM_ATTRIBUTE_REINITIALIZES)
Sun, Sep 23
Quote C89: "If ptr is a null pointer, no action occurs."
Also remove the check for _aligned_free
Sat, Sep 22
Fri, Sep 21
Thu, Sep 20
Tue, Sep 18
Mon, Sep 17
If SyntheticSection::writeTo is guaranteed to be called once (I'm not sure if that is the case), Symbols.clear() in GdbIndexSection::writeTo decrease the maximum RSS by 190MiB, but I'm not sure if it is worthy to do these (freeing resources prematurely at the end of writeTo) for GdbIndexSection and/or other sections..
Sat, Sep 15
Fri, Sep 14
For people who think llvm-readelf is a replacement of readelf, they would like to see -d -r ... listed in llvm-readelf -help.
Great finding! Just a question: do you move the code because the new place fits well?
Thu, Sep 13
Sun, Sep 9
Sat, Sep 8
Fri, Sep 7
Thu, Sep 6
Wed, Sep 5
I made a comment in https://bugs.llvm.org/show_bug.cgi?id=38784
% ninja libLLVMTestingSupport.so ............. -Wl,-z,defs .......... ld.lld: error: undefined symbol: TestMainArgv0 >>> referenced by SupportHelpers.cpp >>> lib/Testing/Support/CMakeFiles/LLVMTestingSupport.dir/SupportHelpers.cpp.o:(llvm::unittest::getInputFileDirectory()) clang-8: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed.
std::unique_ptr -> Optional to save an extra allocation