Page MenuHomePhabricator

MaskRay (Fangrui Song)
UserAdministrator

Projects

User Details

User Since
Dec 30 2016, 3:24 PM (325 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

MaskRay added a comment to D130206: MC: force eager evaluation of relocations in `.debug_info`.

There have been some changes in the relocation area. Is this patch unneeded now?

Sat, Mar 25, 12:49 PM · Restricted Project, Restricted Project

Fri, Mar 24

MaskRay added inline comments to D123515: [RISCV] Support '.option arch' directive.
Fri, Mar 24, 12:13 PM · Restricted Project, Restricted Project
MaskRay accepted D146827: [diagtool] explain that yellow is used to denote disabled-by-default warnings.
Fri, Mar 24, 10:37 AM · Restricted Project, Restricted Project
MaskRay accepted D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp.

(back from a long vacation with little time spending on reviews.llvm.org )

Fri, Mar 24, 10:30 AM · Restricted Project, Restricted Project

Thu, Mar 23

MaskRay accepted D145391: [HIP] Supports env var HIP_PATH.
Thu, Mar 23, 7:04 PM · Restricted Project
MaskRay abandoned D145840: [Docs] Added -fomit-frame-pointer and -fno-omit-frame-pointer flag documentation.
Thu, Mar 23, 7:04 PM · Restricted Project, Restricted Project
MaskRay commandeered D145840: [Docs] Added -fomit-frame-pointer and -fno-omit-frame-pointer flag documentation.
Thu, Mar 23, 7:03 PM · Restricted Project, Restricted Project
MaskRay added a comment to D146776: [llvm] Preliminary fat-lto-objects support.

Thank you for splitting! I am just back from a long vacation to check some emails and will start another long vacation soon (03/29)🤣 It will likely take some time for me to read through this change:)

Thu, Mar 23, 7:03 PM · Restricted Project, Restricted Project
MaskRay added a comment to D142888: [compiler-rt] Fix building GWPASAN on ARM.

Hi I was wondering if we could fast track merge of this patch into LLVM main and 16.0.0 release branch. This patch fixes LLVM 16.0.0 release build for armv7 Linux and release is waiting on this patch to be merged.

Apparently patch looks in good shape so I was wondering if any one of the reviewers can press the accept button if there are no further objections.

Thu, Mar 23, 4:24 PM · Restricted Project, Restricted Project
MaskRay committed rG399f313f2713: [Driver] Remove remnant mips64el-linux-android code after D146565 (authored by MaskRay).
[Driver] Remove remnant mips64el-linux-android code after D146565
Thu, Mar 23, 4:00 PM · Restricted Project, Restricted Project
MaskRay committed rGccc2f362db35: Android.rules: remove mips* rules (authored by MaskRay).
Android.rules: remove mips* rules
Thu, Mar 23, 3:59 PM · Restricted Project
MaskRay committed rGbb0ecb7bf0d0: [Driver][test] Remove remnant mips*-linux-android tests after… (authored by MaskRay).
[Driver][test] Remove remnant mips*-linux-android tests after…
Thu, Mar 23, 3:49 PM · Restricted Project, Restricted Project
MaskRay accepted D146667: [builtins][test] Fix divmodti4_test.c on Windows.
Thu, Mar 23, 1:14 PM · Restricted Project, Restricted Project
MaskRay committed rG5f883cdbfbe2: [docs] Document -fomit-frame-pointer (authored by MaskRay).
[docs] Document -fomit-frame-pointer
Thu, Mar 23, 10:19 AM · Restricted Project, Restricted Project
MaskRay closed D146603: [docs] Document -fomit-frame-pointer.
Thu, Mar 23, 10:19 AM · Restricted Project, Restricted Project
MaskRay updated the diff for D146603: [docs] Document -fomit-frame-pointer.

Adjust some terms.

Thu, Mar 23, 10:16 AM · Restricted Project, Restricted Project
MaskRay added a comment to D146686: [Driver] Fix rpath for compiler-rt.

This change is correct for Linux. llvm/CMakeLists.txt says:

if(CMAKE_SYSTEM_NAME MATCHES "BSD|Linux|OS390")
  set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)

Some rpath using OSes (notably macOS) use LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default=OFF. Is the rpath setting ever usable on macOS?
If not, the change is correct.

How about I try to add both? there is check whether the dir exist then adding it, so only the existing one will be added. then it should work in either case.

Thu, Mar 23, 9:29 AM · Restricted Project
MaskRay added a comment to D146686: [Driver] Fix rpath for compiler-rt.

This change is correct for Linux. llvm/CMakeLists.txt says:

if(CMAKE_SYSTEM_NAME MATCHES "BSD|Linux|OS390")
  set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
Thu, Mar 23, 12:21 AM · Restricted Project

Wed, Mar 22

MaskRay committed rG45a0433b39ff: [-Wunsafe-buffer-usage] Add [[fallthrough]] after D143206 (authored by MaskRay).
[-Wunsafe-buffer-usage] Add [[fallthrough]] after D143206
Wed, Mar 22, 9:02 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D146663: [RISCV] Add .insn support for compressed formats..
Wed, Mar 22, 8:54 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D144190: [AIX][clang] Storage Locations for Constant Pointers.
Wed, Mar 22, 3:12 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D144190: [AIX][clang] Storage Locations for Constant Pointers.
Wed, Mar 22, 3:07 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D146663: [RISCV] Add .insn support for compressed formats..
Wed, Mar 22, 2:54 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11.
Wed, Mar 22, 2:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay added a comment to D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests.

Thank you!

Wed, Mar 22, 2:26 PM · Restricted Project, Restricted Project
MaskRay accepted D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests.
Wed, Mar 22, 2:21 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.
Wed, Mar 22, 12:57 PM · debug-info, Restricted Project, Restricted Project
MaskRay committed rG77ed8311a625: [test] Add tools/llvm-dwarfdump/ARM/lit.local.cfg after D143513 (authored by MaskRay).
[test] Add tools/llvm-dwarfdump/ARM/lit.local.cfg after D143513
Wed, Mar 22, 12:56 PM · Restricted Project, Restricted Project
MaskRay committed rG38d69df5c2da: [Driver][test] Fix avr-ld.c for -DCLANG_DEFAULT_LINKER=lld after D145646 (authored by MaskRay).
[Driver][test] Fix avr-ld.c for -DCLANG_DEFAULT_LINKER=lld after D145646
Wed, Mar 22, 11:36 AM · Restricted Project, Restricted Project
MaskRay added a comment to D145646: [clang][driver] Enable '-flto' on AVR.

We started seeing a test failure in avr-ld.c.

/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr-ld.c:48:11: error: 
// LINKP: {{".*ld.*"}} {{.*}} "--defsym=__DATA_REGION_ORIGIN__=0x800100" "-plugin" {{.*}} "-plugin-opt=mcpu=atmega328"
          ^
<stdin>:1:1: note: scanning from here
Fuchsia clang version 17.0.0 (https://llvm.googlesource.com/llvm-project 0d37efdbc599e61ce2a0418723a66d6b45aea8d7)
^
<stdin>:6:239: note: possible intended match here

https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8785950851645447937/overview

Wed, Mar 22, 11:32 AM · Restricted Project, Restricted Project
MaskRay accepted D144189: [AIX][CodeGen] Storage Locations for Constant Pointers.
Wed, Mar 22, 11:19 AM · Restricted Project, Restricted Project
MaskRay accepted D146114: [RISCV] Allow llvm-objdump to disassemble objects with unrecognised versions of known extensions.

The unknown_ext_version.s case is common (for GCC uses) and will get improved.

Wed, Mar 22, 11:06 AM · Restricted Project, Restricted Project

Tue, Mar 21

MaskRay committed rG792bb70d2985: [MCContext] Use `const Twine &` in symbol creation methods. NFC (authored by paperchalice).
[MCContext] Use `const Twine &` in symbol creation methods. NFC
Tue, Mar 21, 11:14 PM · Restricted Project, Restricted Project
MaskRay closed D145923: [MCContext] Use `const Twine &` in symbol creation methods. NFC.
Tue, Mar 21, 11:14 PM · Restricted Project, Restricted Project
MaskRay accepted D143708: [RISCV] Support emulated TLS.

No objection. LG once @jrtc27 is happy.

Tue, Mar 21, 10:57 PM · Restricted Project, Restricted Project
MaskRay accepted D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.
Tue, Mar 21, 10:45 PM · debug-info, Restricted Project, Restricted Project
MaskRay accepted D145646: [clang][driver] Enable '-flto' on AVR.

"Close" seems more appropriate to me as this isn't a bug (previously not an intended use case).

Tue, Mar 21, 8:42 PM · Restricted Project, Restricted Project
MaskRay updated the diff for D146603: [docs] Document -fomit-frame-pointer.

.

Tue, Mar 21, 8:38 PM · Restricted Project, Restricted Project
MaskRay added a comment to D145840: [Docs] Added -fomit-frame-pointer and -fno-omit-frame-pointer flag documentation.

Sorry for my belated response as I was on a trip for quite a few days.

Tue, Mar 21, 8:37 PM · Restricted Project, Restricted Project
MaskRay requested review of D146603: [docs] Document -fomit-frame-pointer.
Tue, Mar 21, 8:36 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D146560: [PATCH] [PATCH] Enable targeting riscv64-linux-android.
Tue, Mar 21, 8:23 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D146565: [clang] Remove mips target triple for Android.

LG! llvm/test/CodeGen/Mips/ tests are unrelated to the driver change and the part should be committed separately.

Tue, Mar 21, 8:15 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D146459: [clang][PowerPC] Remove remaining Darwin support.
Tue, Mar 21, 5:39 PM · Restricted Project
MaskRay accepted D146459: [clang][PowerPC] Remove remaining Darwin support.
Tue, Mar 21, 5:38 PM · Restricted Project

Mon, Mar 20

MaskRay requested changes to D145923: [MCContext] Use `const Twine &` in symbol creation methods. NFC.
Mon, Mar 20, 8:14 PM · Restricted Project, Restricted Project
MaskRay added a comment to D145923: [MCContext] Use `const Twine &` in symbol creation methods. NFC.

Do you have a use case for the more flexible function signature?

Mon, Mar 20, 8:13 PM · Restricted Project, Restricted Project
MaskRay requested changes to D146054: [RISCV] Add -print-supported-marchs and -march=help support.
Mon, Mar 20, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
MaskRay added a reviewer for D146054: [RISCV] Add -print-supported-marchs and -march=help support: MaskRay.
Mon, Mar 20, 10:25 AM · Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib.
Mon, Mar 20, 9:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sat, Mar 18

MaskRay added inline comments to D146216: [lld][ELF] Relax long jump/call to short jump/call on AVR.
Sat, Mar 18, 11:15 PM · Restricted Project, Restricted Project
MaskRay added a comment to D146109: [libunwind][AArch64] Unbreak building with GNU assembler.

for current GNU Binutils releases.

Sat, Mar 18, 12:32 AM · Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D146316: [compiler-rt] Add missing #else clause to fix the build on NetBSD..

Thanks!

Sat, Mar 18, 12:08 AM · Restricted Project, Restricted Project

Tue, Mar 14

MaskRay added a reviewer for D143463: [X86] Use the CFA when appropriate for better variable locations around calls.: debug-info.
Tue, Mar 14, 8:45 PM · Restricted Project, Restricted Project
MaskRay committed rGef45c12f9e6e: [compiler-rt][builtins] Support builtins for armv8m.base (authored by fdischner).
[compiler-rt][builtins] Support builtins for armv8m.base
Tue, Mar 14, 5:21 PM · Restricted Project, Restricted Project
MaskRay closed D143297: [compiler-rt][builtins] Support builtins for armv8m.base.
Tue, Mar 14, 5:21 PM · Restricted Project, Restricted Project
MaskRay accepted D146061: [ADT] Make llvm::is_contained call member `contains` or `find` when available.

Sure, I agree with that. If I have map with a known type like DenseMap I'd rather call .contains(x) directly too. But this is not possible with C++17 containers std::, so I'd argue that until then is_contained(container, x) is more readable than something like container.find(x) != container.end().

I don't think we should promote usage of is_contained() for anything but the linear scan case. I don't want to be left guessing whether this is_contained() is a linear scan, or just a slightly different way to write container.find().

I can see this being prefered from the perspective of an experience llvm developer, but on the other hand I saw a lot of code that ended up using is_contained and llvm::find with map/set types. I found fixing those inefficiencies and re-explaining this to folks needlessly time consuming. I think defaulting to the more efficient implementation of containment check is the way to go to avoid those non-obvious performance issues, and the member functions we would delegate to are not surprising at all.

Tue, Mar 14, 5:19 PM · Restricted Project, Restricted Project
MaskRay committed rG14a06b0dcc0b: [test] Improve MC/AArch64/elf-reloc-plt32.s to check defined symbol (authored by MaskRay).
[test] Improve MC/AArch64/elf-reloc-plt32.s to check defined symbol
Tue, Mar 14, 3:50 PM · Restricted Project, Restricted Project
MaskRay added a comment to rG35fd37177b9b: llvm-symbolizer: Don't crash when referencing an invalid CU in a dwp file twice.

Is this worth a unit test?

Tue, Mar 14, 3:19 PM · Restricted Project, Restricted Project
MaskRay committed rG2f5fe16e6d29: [RISCV][MC] Adjust conditions to emit R_RISCV_ADD*/R_RISCV_SUB* pairs (authored by MaskRay).
[RISCV][MC] Adjust conditions to emit R_RISCV_ADD*/R_RISCV_SUB* pairs
Tue, Mar 14, 3:18 PM · Restricted Project, Restricted Project
MaskRay closed D145474: [RISCV][MC] Adjust conditions to emit R_RISCV_ADD*/R_RISCV_SUB* pairs.
Tue, Mar 14, 3:17 PM · Restricted Project, Restricted Project
MaskRay committed rG0ddc283a29a7: [RISCV] A@plt-B+C: emit R_RISCV_PLT32 even if A is defined (authored by MaskRay).
[RISCV] A@plt-B+C: emit R_RISCV_PLT32 even if A is defined
Tue, Mar 14, 3:17 PM · Restricted Project, Restricted Project
MaskRay accepted D143587: [Docs] Multilib design.
Tue, Mar 14, 3:06 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D145883: [Flang][RISCV] Emit target features for RISC-V.
Tue, Mar 14, 2:47 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D145999: [RISCV] Reserve X18 by default for Android.
Tue, Mar 14, 2:27 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 13

MaskRay added a comment to D145725: [Driver] Make -X default for baremetal riscv.

LGTM

Mon, Mar 13, 10:22 PM · Restricted Project, Restricted Project
MaskRay accepted D145923: [MCContext] Use `const Twine &` in symbol creation methods. NFC.
Mon, Mar 13, 10:19 PM · Restricted Project, Restricted Project
MaskRay accepted D145849: [Driver][xray] Allow XRay on Apple Silicon.
Mon, Mar 13, 10:18 PM · Restricted Project, Restricted Project
MaskRay accepted D145941: [Clang] Always use --no-undefined when linking AMDGPU images.

While --no-undefined is an alias for -z defs, be consistent in the subject and the body.

Mon, Mar 13, 10:16 PM · Restricted Project, Restricted Project
MaskRay accepted D145848: [Driver] Correct -f(no-)xray-function-index behavior.

Thanks!

Mon, Mar 13, 10:14 PM · Restricted Project, Restricted Project

Sun, Mar 12

MaskRay accepted D145882: [RISCV] Fix gaps in IgnoreUnknown=true for RISCVISAInfo::parseArchString.
Sun, Mar 12, 10:11 PM · Restricted Project, Restricted Project
MaskRay added a comment to D144596: [lld] Support separate native object file path in --thinlto-prefix-replace.

While we're here, let's make two more changes. First, let's use .bc instead of .o for the bitcode file extension name.

I'm not in favor of hardcoding the extension in the compiler, it should be left to the build system, but I don't believe that what you are proposing would require a specific extension anyway. Currently, the object output file extension of the compile action is not a hardcoded requirement and I don't think it should be. Additionally, when we were initially implementing ThinLTO I recall that the Bazel team specifically wanted to keep the .o extension (otherwise the handling gets a bit trickier for them as a compile action will have different extensions depending on the optimization options). But like I said it doesn't appear to me that what you are proposing would require this.

Sun, Mar 12, 10:09 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Mar 11

MaskRay requested changes to D145848: [Driver] Correct -f(no-)xray-function-index behavior.
Sat, Mar 11, 11:05 PM · Restricted Project, Restricted Project

Fri, Mar 10

MaskRay added inline comments to D145474: [RISCV][MC] Adjust conditions to emit R_RISCV_ADD*/R_RISCV_SUB* pairs.
Fri, Mar 10, 9:24 PM · Restricted Project, Restricted Project
MaskRay updated the diff for D145474: [RISCV][MC] Adjust conditions to emit R_RISCV_ADD*/R_RISCV_SUB* pairs.

Fix -gdwarf-aranges

Fri, Mar 10, 9:15 PM · Restricted Project, Restricted Project
MaskRay committed rGc598828b1beb: [test] Add some interesting cases to MC/RISCV/riscv64-64b-pcrel.s (authored by MaskRay).
[test] Add some interesting cases to MC/RISCV/riscv64-64b-pcrel.s
Fri, Mar 10, 9:11 PM · Restricted Project, Restricted Project
MaskRay accepted D145835: [PassManagerBuilder] Remove PassManagerBuilder.
Fri, Mar 10, 5:37 PM · Restricted Project, Restricted Project
MaskRay accepted D145146: [Driver][NFC] Remove some redundant code in Driver.cpp. .

computeTargetTriple has several users. You probably want to check all these code paths do not need if (const Arg *A = Args.getLastArg(options::OPT_target)).
For the uses in BuildCompilation, it seems fine.

Fri, Mar 10, 12:59 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.
Fri, Mar 10, 12:40 PM · debug-info, Restricted Project, Restricted Project
MaskRay added a comment to D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.

(I'm going to be out for 3 weeks in the next 4 weeks. Happy if others are happy. Don't wait on me :) )

Fri, Mar 10, 11:50 AM · Restricted Project, Restricted Project
MaskRay accepted D145792: [X86][MC] Emit instructions into SmallVector.

I have an analysis of the code path: https://reviews.llvm.org/D145791#4185609
There are some if conditions, virtual function calls, SmallVector range append overhead which cannot be eliminated.

Fri, Mar 10, 11:34 AM · Restricted Project, Restricted Project
MaskRay accepted D145791: [MC] Always encode instruction into SmallVector.

LGTM, but make sure @RKSimon is happy as well.

Fri, Mar 10, 11:30 AM · Restricted Project, Restricted Project
MaskRay accepted D145786: [LLD] Increase thunk pass limit.
Fri, Mar 10, 10:22 AM · Restricted Project, Restricted Project

Thu, Mar 9

MaskRay added a comment to D143306: [Driver] Default to -fno-openmp-implicit-rpath.

Should we apply this patch to the release/16.x branch to create a more smooth transition since the option has been removed in main?

Thu, Mar 9, 11:31 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D139092: [LLD][ELF] Cortex-M Security Extensions (CMSE) Support.
Thu, Mar 9, 3:02 PM · Restricted Project, Restricted Project
MaskRay accepted D139092: [LLD][ELF] Cortex-M Security Extensions (CMSE) Support.

Thanks! LGTM from my review. It'd be good to have a review from a domain expert.

Thu, Mar 9, 3:00 PM · Restricted Project, Restricted Project
MaskRay added a comment to D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as..

Due to this we started seeing assembler errors with certain .c and .cpp files -
"Error: file number 1 already allocated"

Thu, Mar 9, 1:51 PM · Restricted Project, Restricted Project
MaskRay added a comment to D118493: Set rpath on openmp executables.

Duplicating a comment from the commit thread so it's easier for me to find later.

You've applied this to the release branches going back as far as 14. It's a user facing breaking change. As in people who have a working openmp toolchain and update to the point release which looks like a semantic versioning thing indicating minor bugfixes will experience immediate cessation of function. I consider that very poor user experience and do not agree with the scope of breakage.

Thu, Mar 9, 1:41 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added a comment to D144596: [lld] Support separate native object file path in --thinlto-prefix-replace.

I find the summary difficult to follow and I believe users will be more confusing than me (as a ThinLTO contributor).

I'll take a stab at suggesting a clearer summary in a little bit.

Thu, Mar 9, 12:53 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added a comment to D144596: [lld] Support separate native object file path in --thinlto-prefix-replace.

(I'll be be out for most of the next 4 weeks and may not have much time to review patches.)

Thu, Mar 9, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay abandoned D143306: [Driver] Default to -fno-openmp-implicit-rpath.

Abandoned by a revert of D118493

Thu, Mar 9, 12:35 PM · Restricted Project, Restricted Project
MaskRay requested changes to D145635: [ELF] Make --discard-locals default on riscv.

Yeah; I wish that we don't do this. IIRC even a RISC-V binutils maintainers said the behavior is strange but perhaps people don't have enough motivation to fix that.
We don't really need to copy the behavior as Clang Driver has passed -X.

Thu, Mar 9, 12:34 AM · Restricted Project

Wed, Mar 8

MaskRay added a comment to D134129: [PATCH] [RISCV] Enable -msave-restore by default when optimizing for size.

At least with that this diff shows, the saving is small. I'd hope that we don't toggle -msave-restore for -Os/-Oz. Users can specify -msave-restore themselves.

Wed, Mar 8, 4:14 PM · Restricted Project, Restricted Project
MaskRay requested changes to D145567: [Driver] Rename multilib flags to tags.
Wed, Mar 8, 4:10 PM · Restricted Project, Restricted Project
MaskRay added a comment to D145567: [Driver] Rename multilib flags to tags.

Since the touched code is still in review, you need to merge the changes into the prior patches.

Wed, Mar 8, 4:10 PM · Restricted Project, Restricted Project
MaskRay accepted D145556: [compiler-rt] Avoid signed shift overflow in __muloXi4 and __mulvXi3.
Wed, Mar 8, 4:02 PM · Restricted Project, Restricted Project
MaskRay accepted D145570: [RISCV][NFCI] Use common MCELFStreamer code for attribute emission.
Wed, Mar 8, 3:53 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.
Wed, Mar 8, 2:19 PM · debug-info, Restricted Project, Restricted Project
MaskRay added inline comments to D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.
Wed, Mar 8, 2:16 PM · debug-info, Restricted Project, Restricted Project
MaskRay requested changes to D144179: [Clang] Added functionality to provide config file name via env variable.

This looks like introducing a footgun (when something behaves differently from an upstream Clang, it would be difficult for toolchain maintainers to know why).
Why can't your user specify CLANG_CONFIG_FILE_SYSTEM_DIR?

hi @MaskRay,
The reason we wanted to suggest use of environment variable is that the CLANG_CONFIG_FILE_SYSTEM_DIR is only defined at compilation time, after discussing it once again we would rather lean towards introducing an environment variable with similar semantics as CLANG_CONFIG_FILE_SYSTEM_DIR or rather `CLANG_CONFIG_FILE_USER_DIR`, the motivation here is that it will allow to specify the directory to search for config files in a dynamic way, without need to recompile the compiler.
It is for user convenience in situations when they are using a system wide installation in a location where they do not have access right, and the `CLANG_CONFIG_FILE_SYSTEM_DIR and CLANG_CONFIG_FILE_USER_DIR` were not defined at build time.

We realised that environment variables are already used in this area, for example CLANG_NO_DEFAULT_CONFIG, so adding another one is not breaking existing convention.

What do you think about it?

Wed, Mar 8, 1:36 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.
Wed, Mar 8, 1:29 PM · debug-info, Restricted Project, Restricted Project