Page MenuHomePhabricator

MaskRay (Fangrui Song)
UserAdministrator

Projects

User Details

User Since
Dec 30 2016, 3:24 PM (281 w, 2 d)
Roles
Administrator

Recent Activity

Today

MaskRay accepted D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface.

Perhaps wait a day or so in case others have opinions.

Mon, May 23, 1:49 PM · Restricted Project, Restricted Project
MaskRay added a comment to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

IIRC there is no built-in way supporting multiple (but fixed number of) values for an option (e.g. -Xoffload-linker-<triple> <arg>). In D105330 (llvm-nm option refactoring) I used a hack to support -s __DATA __data.
The multiple-value support for OptTable does not allow positional arguments after the option.

Mon, May 23, 1:11 PM · Restricted Project, Restricted Project
MaskRay requested changes to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

It's better to avoid JoinedAndSeparate for new options. It is for --xxx val and --xxxval but not intended for the option this patch will add.

Mon, May 23, 12:51 PM · Restricted Project, Restricted Project
MaskRay committed rG224a8653c98e: [llvm-nm][docs] Document -W and -U (authored by MaskRay).
[llvm-nm][docs] Document -W and -U
Mon, May 23, 9:59 AM · Restricted Project, Restricted Project
MaskRay closed D126133: [llvm-nm][docs] Document -W and -U.
Mon, May 23, 9:59 AM · Restricted Project, Restricted Project

Sat, May 21

MaskRay accepted D125604: [FileCheck] Catch missspelled directives..

LGTM. Thanks for pinging the relevant folks on individual tests. You can push the fixes yourself before landing this patch.

Sat, May 21, 4:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay requested review of D126133: [llvm-nm][docs] Document -W and -U.
Sat, May 21, 4:01 PM · Restricted Project, Restricted Project
MaskRay accepted D124306: [UpdateTestChecks] Auto-generate stub bodies for conflicting outputs.
Sat, May 21, 3:03 PM · Restricted Project, Restricted Project
MaskRay added a comment to D124751: [HLSL] Support -E option for HLSL..

Is there a specification or reference implementation stating that -E is used?

Option<["--", "/", "-"], "E",

Do you need the prefix --? You may define something like CLFlag. I have missed previous patches, but if / options are not necessary, removing them will be the best to avoid collision with filenames starting with /.

Unfortunately, '/' is necessary. dxc allow both '-' and '/' like 'CLFlag'.
Remove '/' means existing customers may need to change their command line to compile hlsl.
And add '--' feels not hurt anyone, that's why I choose to add '--' to work-around the conflict.

Sat, May 21, 2:59 PM · Restricted Project, Restricted Project
MaskRay requested changes to D124770: [Sanitizers] Guard FP_XSTATE_MAGIC1 usage by GLIBC version.

FP_XSTATE_MAGIC1 is only available on glibc 2.27 and upwards

Sat, May 21, 2:52 PM · Restricted Project, Restricted Project
MaskRay requested changes to D124779: [Sanitizers] Fix compilation on musl 32bit.
Sat, May 21, 2:47 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D125979: [ADT] add LockFreeDataPool class..
Sat, May 21, 2:46 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125979: [ADT] add LockFreeDataPool class..

The name is not descriptive. It misses the important words about "hash map". ConcurrentHashMap may be a better name.

Sat, May 21, 2:39 PM · Restricted Project, Restricted Project
MaskRay requested changes to D126121: Remove undefined behavior in count.c test program [NFC].
Sat, May 21, 11:11 AM · Restricted Project, Restricted Project
MaskRay added inline comments to D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types.
Sat, May 21, 11:10 AM · Restricted Project, Restricted Project, Restricted Project
MaskRay added 1 blocking reviewer(s) for D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types: MaskRay.
Sat, May 21, 11:10 AM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.
Sat, May 21, 11:08 AM · Restricted Project, Restricted Project, Restricted Project
MaskRay added a comment to D126121: Remove undefined behavior in count.c test program [NFC].

Where is the undefined behavior? size_t is unsigned long long on 32-bit ELF platforms. You need %zu.

Sat, May 21, 10:59 AM · Restricted Project, Restricted Project
MaskRay requested changes to D87219: [ELF] Merge .openbsd.randomdata.* sections into a single .openbsd.randomdata section when linking.
Sat, May 21, 10:35 AM · Restricted Project, Restricted Project
MaskRay added a comment to D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface.

Fix MCSymbolizer::tryAddingSymbolicOperand() interface

Sat, May 21, 10:34 AM · Restricted Project, Restricted Project
MaskRay added inline comments to D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface.
Sat, May 21, 10:33 AM · Restricted Project, Restricted Project
MaskRay added a comment to D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface.

However, for proper symbolic disassembly on X86 we need to know both sizes.

Sat, May 21, 10:31 AM · Restricted Project, Restricted Project
MaskRay added inline comments to D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface.
Sat, May 21, 10:30 AM · Restricted Project, Restricted Project

Fri, May 20

MaskRay accepted D126072: [lld-macho] Stop crash when emitting personalities with -dead_strip.
Fri, May 20, 2:36 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D126072: [lld-macho] Stop crash when emitting personalities with -dead_strip.
Fri, May 20, 1:34 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D125905: [RISCV] Fix state persistence bugs (PR55548).
Fri, May 20, 12:04 PM · Restricted Project, Restricted Project
MaskRay added a comment to D126079: [NFC][LLVM] Merge shouldExpandAtomic*InIR into shouldExpandAtomicInstInIR.

Overloaded virtual functions seem more difficult to read and are more error-prone. Having distinct function names can be useful as people searching code can find the relevant one easily.

Fri, May 20, 11:45 AM · Restricted Project, Restricted Project
MaskRay added a comment to D125979: [ADT] add LockFreeDataPool class..

@MaskRay, can you review this? I think you have been thinking the most about how to parallelize linkers, and what fundamental data structures are most important.

Fri, May 20, 11:21 AM · Restricted Project, Restricted Project
MaskRay accepted D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.
Fri, May 20, 10:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, May 19

MaskRay added a comment to D125036: [RISCV] Alignment relaxation.

While I think there are still significant problems needing to address, it may work with quite a few application. It'd be nice if folks can check how this patch works without -mno-relax.

Thu, May 19, 8:10 PM · Restricted Project, Restricted Project
MaskRay requested changes to D125036: [RISCV] Alignment relaxation.
Thu, May 19, 8:08 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D125036: [RISCV] Alignment relaxation.
Thu, May 19, 8:07 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125036: [RISCV] Alignment relaxation.

On lld/ELF/Relocations.cpp:1439, R_RELAX_HINT should not trigger sym.hasDirectReloc = true;, otherwise an ifunc may unnecessarily be converted to a canonical PLT. You may read *-ifunc-nonpreemptible*.s tests for what they do. I have some notes on https://maskray.me/blog/2021-01-18-gnu-indirect-function#address-significance

Thu, May 19, 8:04 PM · Restricted Project, Restricted Project
MaskRay accepted D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.

Thanks!

Thu, May 19, 6:49 PM · Restricted Project, Restricted Project
MaskRay accepted D125901: [safestack] Fix Mmap on FreeBSD AArch64.

I think placing the OS before && is more common.

Thu, May 19, 6:46 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
Thu, May 19, 4:51 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.
Thu, May 19, 1:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay added a comment to D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.

Seems fine to me for libunwind, but I don't know the build bot setup enough. I will give a LGTM if you still lack an approval to make #libunwind green :)

Thu, May 19, 1:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D124836: [AArch64] Add support for -fzero-call-used-regs.
Thu, May 19, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D125436: [lld][test] Delete empty Unit test directory.
Thu, May 19, 11:56 AM · Restricted Project, Restricted Project
MaskRay added inline comments to D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types.
Thu, May 19, 12:21 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

MaskRay added inline comments to D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.
Wed, May 18, 11:15 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125785: [llvm-ar][test] Add regression test for special case of replace converting a regular to a full archive (issue 55527).

(issue 55527)

Wed, May 18, 3:02 PM · Restricted Project, Restricted Project
MaskRay accepted D125785: [llvm-ar][test] Add regression test for special case of replace converting a regular to a full archive (issue 55527).

We don't attach PR number to test filenames. That's old practice which has been abandoned.
You can add the bug number to the body of the file is necessary. In this case I'd say not necessary.

Wed, May 18, 3:01 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125801: [libc++][CI] fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX.

Reviewers: David Tenty,Mark de Wever

Wed, May 18, 1:52 PM · Restricted Project, Restricted Project
MaskRay added a reviewer for D125773: [Driver] Do not auto-enable header modules with -std=c++20: Restricted Project.
Wed, May 18, 1:24 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.

In addition, if every new GCC release requires addition to /opt/rh/gcc-toolset-$major (if I understand correctly), we probably want to switch to llvm::vfs::directory_iterator iteration and using the largest version.

Wed, May 18, 12:45 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes.

It may be time to add unittests to clang/unittests/Driver/ToolChainTest.cpp for /opt/rh detection. You may use TEST(ToolChainTest, VFSGCCInstallation) as an example creating a pseudo file hierarchy in memory.

Wed, May 18, 12:43 PM · Restricted Project, Restricted Project
MaskRay committed rGd8166e1900c0: [Driver] Refactor /opt/rh detection (authored by MaskRay).
[Driver] Refactor /opt/rh detection
Wed, May 18, 12:40 PM · Restricted Project, Restricted Project
MaskRay accepted D125757: [asan] Add the FreeBSD AArch64 shadow offset.
Wed, May 18, 12:30 PM · Restricted Project, Restricted Project
MaskRay added a comment to D122256: [clang][ABI] New C++20 module mangling scheme.

The differential has the same intention/subject as D118352. In such a case reusing the preexisting differential would have been better. I have left more comments on https://reviews.llvm.org/D125825#3522911

Wed, May 18, 10:25 AM · Restricted Project, Restricted Project
MaskRay added a comment to D125825: [clang][NFC] Augment CoreturnStmt.

I see that a new patch with the same intent/subject has been created: D125880.
Normally the same differential should be used to keep track of all past discussions on a differential.
The "History" tab on the page allows a user to compare two patches to get insights of the evolution of the differential.

Wed, May 18, 10:13 AM · Restricted Project
MaskRay committed rG087ef34fffb2: [ObjCopy][NFC] Remove unneeded zero initialization (authored by MaskRay).
[ObjCopy][NFC] Remove unneeded zero initialization
Wed, May 18, 9:43 AM · Restricted Project, Restricted Project
MaskRay closed D125833: [ObjCopy][NFC] Remove unneeded zero initialization.
Wed, May 18, 9:42 AM · Restricted Project, Restricted Project
MaskRay accepted D116995: [gold] Ignore bitcode from sections inside object files.

-fembed-bitcode was originally added by Apple to enable them to recompile
3rd-party-developers' software with a newer compiler, or for new CPU
targets, without the source code. It uses the normal non-LTO optimization
pipeline, and emits bitcode corresponding to the binary object also
emitted.

For LTO bitcode generation, we use a different pass manager configuration.

That said, various other people seem to have had various other ideas about
how things should work over time. So, I couldn't say conclusively that
nobody will complain if we have gold not try to parse these sections...but
it seems potentially reasonable to me.

Wed, May 18, 12:19 AM · Restricted Project, Restricted Project

Tue, May 17

MaskRay added a comment to D125757: [asan] Add the FreeBSD AArch64 shadow offset.

Please add some description about what tests previously failed now work.

Tue, May 17, 5:12 PM · Restricted Project, Restricted Project
MaskRay requested review of D125833: [ObjCopy][NFC] Remove unneeded zero initialization.
Tue, May 17, 12:59 PM · Restricted Project, Restricted Project
MaskRay accepted D125658: [ifs] Switch to using OptTable.

Looks great! Best to wait for a second opinion.

Tue, May 17, 11:32 AM · Restricted Project, Restricted Project
MaskRay retitled D125544: [lld][ELF] Support BFD name elf32-avr from [lld][ELF] Support elf32-avr BFD name to [lld][ELF] Support BFD name elf32-avr.
Tue, May 17, 11:14 AM · Restricted Project, Restricted Project
MaskRay retitled D125544: [lld][ELF] Support BFD name elf32-avr from [lld][ELF] Support linking 'elf32-avr' with linker scripts to [lld][ELF] Support elf32-avr BFD name.
Tue, May 17, 11:14 AM · Restricted Project, Restricted Project
MaskRay accepted D125544: [lld][ELF] Support BFD name elf32-avr.
Tue, May 17, 11:13 AM · Restricted Project, Restricted Project
MaskRay accepted D125271: [riscv] Enable strict assertions in InsertVSETVLI data flow.

s/riscv/RISCV/

Tue, May 17, 10:26 AM · Restricted Project, Restricted Project

Mon, May 16

MaskRay added inline comments to D125540: [clang] dependent co_return fix.
Mon, May 16, 8:18 PM · Restricted Project
MaskRay added inline comments to D125540: [clang] dependent co_return fix.
Mon, May 16, 8:06 PM · Restricted Project
MaskRay accepted D125699: [StackColoring] Don't merge slots with differing StackIDs.

With sdesmalen's suggestion applied.

Mon, May 16, 3:54 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D125204: [RISCV] Use RISCVISAInfo to parse arch string from ELF build attribute..
Mon, May 16, 12:50 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125624: [gold] Remove an external dependency to GNU binutils' header file.

I haven't checked but for ninja check-llvm-tools-gold, we still hope that the tests are disabled if the system does not provide gold. There may need a toggle for the tests.

Mon, May 16, 12:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D125624: [gold] Remove an external dependency to GNU binutils' header file.
Mon, May 16, 12:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
Mon, May 16, 12:12 PM · Restricted Project, Restricted Project
MaskRay added a comment to D124490: [InstrProf] Minimal Block Coverage.

Special thanks to Julian Mestre for creating this block coverage inference algorithm.

Mon, May 16, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D125036: [RISCV] Alignment relaxation.
Mon, May 16, 11:28 AM · Restricted Project, Restricted Project
MaskRay added a comment to D125572: [sanitizer] Don't use newfstatat for Linux on SPARC.

Could someone land this for me? Thanks!

Mon, May 16, 11:02 AM · Restricted Project, Restricted Project
MaskRay committed rG0b69b8384d9b: [Driver] Change "zlib not installed" diagnostic to "zlib not enabled" (authored by MaskRay).
[Driver] Change "zlib not installed" diagnostic to "zlib not enabled"
Mon, May 16, 10:43 AM · Restricted Project, Restricted Project
MaskRay committed rGbabbd96f23d5: [docs] Re-generate ClangCommandLineReference.rst (authored by MaskRay).
[docs] Re-generate ClangCommandLineReference.rst
Mon, May 16, 10:34 AM · Restricted Project, Restricted Project
MaskRay added a comment to D125658: [ifs] Switch to using OptTable.

Thanks for the patch. User-facing tools are better using llvm::OptTable. I've only spot one thing other than what has been mentioned.

Mon, May 16, 10:19 AM · Restricted Project, Restricted Project
MaskRay added a comment to D87219: [ELF] Merge .openbsd.randomdata.* sections into a single .openbsd.randomdata section when linking.

This seems like work of a default linker script. Nowadays you may use OVERWRITE_SECTIONS to create a new output section description: https://maskray.me/blog/2021-07-04-sections-and-overwrite-sections

Mon, May 16, 10:11 AM · Restricted Project, Restricted Project

Sat, May 14

MaskRay added inline comments to D125544: [lld][ELF] Support BFD name elf32-avr.
Sat, May 14, 6:05 PM · Restricted Project, Restricted Project
MaskRay committed rG59afc4038b10: [LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV (authored by twd2).
[LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV
Sat, May 14, 6:05 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay retitled D106888: [LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV from [LowerTypeTests][clang] Implement cfi-icall and allow -fsanitize=cfi-icall for RISCV to [LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV.
Sat, May 14, 6:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay closed D106888: [LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV.
Sat, May 14, 6:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
Sat, May 14, 6:03 PM · Restricted Project, Restricted Project
MaskRay retitled D106888: [LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV from [LowerTypeTests] Implement cfi-icall for RISCV to [LowerTypeTests][clang] Implement cfi-icall and allow -fsanitize=cfi-icall for RISCV.
Sat, May 14, 5:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay retitled D106888: [LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV from [RISC-V] Implement jump tables for CFI-icall to [LowerTypeTests] Implement cfi-icall for RISCV.
Sat, May 14, 5:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D125036: [RISCV] Alignment relaxation.
Sat, May 14, 5:19 PM · Restricted Project, Restricted Project
MaskRay requested changes to D123427: Reset _unwindInfoMissing when info is found eventually.
Sat, May 14, 5:17 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D125544: [lld][ELF] Support BFD name elf32-avr.
Sat, May 14, 5:12 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125036: [RISCV] Alignment relaxation.

Clone https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git , apply this patch:

--- i/arch/riscv/Makefile
+++ w/arch/riscv/Makefile
@@ -38,9 +38,9 @@ endif
Sat, May 14, 4:39 PM · Restricted Project, Restricted Project
MaskRay accepted D125572: [sanitizer] Don't use newfstatat for Linux on SPARC.
Sat, May 14, 11:37 AM · Restricted Project, Restricted Project
MaskRay updated subscribers of D125604: [FileCheck] Catch missspelled directives..
Sat, May 14, 11:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay committed rG60e5fd00cde3: [RS4GC] Fix -Wunused-function in -DLLVM_ENABLE_ASSERTIONS=off build after… (authored by MaskRay).
[RS4GC] Fix -Wunused-function in -DLLVM_ENABLE_ASSERTIONS=off build after…
Sat, May 14, 10:48 AM · Restricted Project, Restricted Project
MaskRay added inline comments to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
Sat, May 14, 12:34 AM · Restricted Project, Restricted Project
MaskRay added a comment to D124751: [HLSL] Support -E option for HLSL..

Is there a specification or reference implementation stating that -E is used?

Sat, May 14, 12:32 AM · Restricted Project, Restricted Project

Fri, May 13

MaskRay added a comment to D125598: [compiler-rt][builtins] {u,}{div,mod}si3 for Sparc64.

According to a developer at the FreeBSD project, FreeBSD's total compilation time increases by 2.6% when the host system is built against compiler-rt instead of libgcc. This is likely due to the fact that GCC has assembly-written versions of the division and modulo routines, while compiler-rt does not.

Fri, May 13, 11:35 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D125544: [lld][ELF] Support BFD name elf32-avr.
Fri, May 13, 11:13 PM · Restricted Project, Restricted Project
MaskRay added a comment to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

It may be useful to leave a space before the period as many applications may consider . part of the URI.

Fri, May 13, 11:10 PM · Restricted Project, Restricted Project
MaskRay accepted D125542: [clang] co_return cleanup.

LGTM. (I need to learn this stuff but I'm happy since bots are happy:))

Fri, May 13, 11:04 PM · Restricted Project
MaskRay added a comment to D106888: [LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV.

I'll wait a bit before pushing to check whether that further opinions.

Fri, May 13, 4:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D106888: [LowerTypeTests][clang] Implement and allow -fsanitize=cfi-icall for RISCV.

LGTM.

Fri, May 13, 4:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

Looks great! But best to wait for @jhenderson

Fri, May 13, 2:26 PM · Restricted Project, Restricted Project
MaskRay added a comment to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

Mostly looks good to me.

Fri, May 13, 12:42 PM · Restricted Project, Restricted Project