Page MenuHomePhabricator

MaskRay (Fangrui Song)
User

Projects

User Details

User Since
Dec 30 2016, 3:24 PM (132 w, 3 d)

Recent Activity

Today

MaskRay accepted D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.
Mon, Jul 15, 9:11 PM · Restricted Project
MaskRay added inline comments to D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..
Mon, Jul 15, 7:39 PM · Restricted Project
MaskRay added inline comments to D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.
Mon, Jul 15, 7:14 PM · Restricted Project
MaskRay added inline comments to D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..
Mon, Jul 15, 6:54 PM · Restricted Project
MaskRay accepted D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..
Mon, Jul 15, 2:46 AM · Restricted Project
MaskRay added inline comments to D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..
Mon, Jul 15, 1:53 AM · Restricted Project
MaskRay committed rG6bd02a442c0e: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble (authored by MaskRay).
[PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble
Mon, Jul 15, 12:27 AM
MaskRay committed rL366044: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble.
[PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble
Mon, Jul 15, 12:25 AM
MaskRay closed D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble.
Mon, Jul 15, 12:24 AM · Restricted Project, Restricted Project

Yesterday

MaskRay added a comment to D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble.

Woohoo, this is the last :)

Sun, Jul 14, 10:09 PM · Restricted Project, Restricted Project
MaskRay committed rG335f955dc494: [PowerPC] Support fp128 libcalls (authored by MaskRay).
[PowerPC] Support fp128 libcalls
Sun, Jul 14, 10:04 PM
MaskRay committed rL366039: [PowerPC] Support fp128 libcalls.
[PowerPC] Support fp128 libcalls
Sun, Jul 14, 10:03 PM
MaskRay closed D64282: [PowerPC] Support fp128 libcalls.
Sun, Jul 14, 10:03 PM · Restricted Project
MaskRay accepted D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..
Sun, Jul 14, 6:54 PM · Restricted Project
MaskRay added inline comments to D64706: [tools] [llvm-objdump] Default to reading from stdin not a.out.
Sun, Jul 14, 6:42 PM · Restricted Project
MaskRay added inline comments to D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.
Sun, Jul 14, 8:57 AM · Restricted Project
MaskRay added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Sun, Jul 14, 3:51 AM · Restricted Project
MaskRay added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Sun, Jul 14, 3:17 AM · Restricted Project
MaskRay committed rGe9dc9c2bebb1: [Driver] Simplify AddLibgcc (authored by MaskRay).
[Driver] Simplify AddLibgcc
Sun, Jul 14, 12:17 AM
MaskRay committed rL366013: [Driver] Simplify AddLibgcc.
[Driver] Simplify AddLibgcc
Sun, Jul 14, 12:17 AM

Sat, Jul 13

MaskRay committed rGc7f9559d659f: [Driver] Simplify -lgcc & -lgcc_s (authored by MaskRay).
[Driver] Simplify -lgcc & -lgcc_s
Sat, Jul 13, 11:47 PM
MaskRay committed rL366012: [Driver] Simplify -lgcc & -lgcc_s.
[Driver] Simplify -lgcc & -lgcc_s
Sat, Jul 13, 11:47 PM
MaskRay added a comment to D64631: [obj2yaml] - Rework tool's error reporting logic for ELF target..

Happy to see more ErrorOr/std::error_code becoming Error/Expected 😊

Sat, Jul 13, 3:47 AM · Restricted Project
MaskRay committed rG327db23b6642: [Object] isNotObjectErrorInvalidFileType: simplify (authored by MaskRay).
[Object] isNotObjectErrorInvalidFileType: simplify
Sat, Jul 13, 2:33 AM
MaskRay committed rL365997: [Object] isNotObjectErrorInvalidFileType: simplify.
[Object] isNotObjectErrorInvalidFileType: simplify
Sat, Jul 13, 2:28 AM
MaskRay committed rG16ac7a5a27c7: [Object] isNotObjectErrorInvalidFileType: fix use-after-move (authored by MaskRay).
[Object] isNotObjectErrorInvalidFileType: fix use-after-move
Sat, Jul 13, 2:25 AM
MaskRay committed rL365996: [Object] isNotObjectErrorInvalidFileType: fix use-after-move.
[Object] isNotObjectErrorInvalidFileType: fix use-after-move
Sat, Jul 13, 2:24 AM
MaskRay closed D64687: [clang] Revert "Remove __VERSION__".

I went ahead and committed your revert in r365992. Thanks!

Next time, please remove the clang/ from your patch
arc could not apply it:

Sat, Jul 13, 12:41 AM · Restricted Project
MaskRay committed rG36fbd0da5fb7: Simplify with llvm::is_contained. NFC (authored by MaskRay).
Simplify with llvm::is_contained. NFC
Sat, Jul 13, 12:24 AM
MaskRay committed rL365993: Simplify with llvm::is_contained. NFC.
Simplify with llvm::is_contained. NFC
Sat, Jul 13, 12:24 AM

Fri, Jul 12

MaskRay added a comment to rL365979: [COFF] Add null check in case of symbols defined in LTO blobs.

lld-link: error: could not open 'libcmt.lib': No such file or directory

Fri, Jul 12, 7:50 PM
MaskRay added inline comments to D64685: ELF: Add support for remaining R_AARCH64_MOVW* relocations..
Fri, Jul 12, 7:19 PM · Restricted Project
MaskRay added a comment to D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..

Do you find another use case of printDynamicString? If yes, can you name it?

Fri, Jul 12, 6:05 PM · Restricted Project
MaskRay closed D64653: clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target.
Fri, Jul 12, 6:00 PM · Restricted Project
MaskRay added a comment to D64653: clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target.

I committed this for you in rL365981 (it may have broken a Windows build for a long time. I wanted to fix it soon..). Thanks!

Fri, Jul 12, 5:58 PM · Restricted Project
MaskRay committed rGcafb5d24dfa0: clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target (authored by MaskRay).
clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target
Fri, Jul 12, 5:50 PM
MaskRay committed rL365981: clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target.
clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target
Fri, Jul 12, 5:48 PM
MaskRay added a comment to rL365872: test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should….

Looks like the default implementation of getSupportedSanitizers explicitly masks out SanitizerKind::Vptr, which would cause this error for any systems which have a default target that do not support the sanitizer.
If it's just this specific sanitizer, the fix should be to trivially revert the change presented here.

Fri, Jul 12, 5:38 PM
MaskRay accepted D64653: clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target.

Sorry, I accidentally updated this one by mistake. vptr is not always available. Thanks!

Fri, Jul 12, 5:35 PM · Restricted Project
MaskRay added inline comments to D64610: [clang] allow -fthinlto-index= without -x ir.
Fri, Jul 12, 5:09 PM · Restricted Project, Restricted Project
MaskRay committed rGe99dee82b0bd: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM (authored by MaskRay).
[Support] Move the static initializer install_out_memory_new_handler to InitLLVM
Fri, Jul 12, 9:25 AM
MaskRay committed rL365915: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM.
[Support] Move the static initializer install_out_memory_new_handler to InitLLVM
Fri, Jul 12, 9:23 AM
MaskRay closed D64505: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM.
Fri, Jul 12, 9:23 AM · Restricted Project
MaskRay committed rG38cd364007a9: [LegacyPassManager] Small ModuleCount cleanup (authored by MaskRay).
[LegacyPassManager] Small ModuleCount cleanup
Fri, Jul 12, 8:19 AM
MaskRay committed rL365907: [LegacyPassManager] Small ModuleCount cleanup.
[LegacyPassManager] Small ModuleCount cleanup
Fri, Jul 12, 8:19 AM
MaskRay committed rGb251cc0d9136: Delete dead stores (authored by MaskRay).
Delete dead stores
Fri, Jul 12, 8:02 AM
MaskRay committed rL365903: Delete dead stores.
Delete dead stores
Fri, Jul 12, 8:02 AM
MaskRay committed rG90e95bb2891a: Delete dead stores (authored by MaskRay).
Delete dead stores
Fri, Jul 12, 7:05 AM
MaskRay committed rL365901: Delete dead stores.
Delete dead stores
Fri, Jul 12, 7:04 AM
MaskRay committed rGe6e09561698a: [Driver] Delete dead code (authored by MaskRay).
[Driver] Delete dead code
Fri, Jul 12, 6:22 AM
MaskRay committed rL365898: [Driver] Delete dead code.
[Driver] Delete dead code
Fri, Jul 12, 6:21 AM
MaskRay accepted D64297: [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands..

Using ccache and distcc together is a common pattern.

Fri, Jul 12, 2:24 AM · Restricted Project
MaskRay accepted D64470: [Object/ELF] - Improve error reporting for notes..
Fri, Jul 12, 1:49 AM · Restricted Project
MaskRay added inline comments to D64470: [Object/ELF] - Improve error reporting for notes..
Fri, Jul 12, 1:18 AM · Restricted Project

Thu, Jul 11

MaskRay committed rGa499c42414db: [Driver] Delete --no-add-needed for RHEL7 or newer (authored by MaskRay).
[Driver] Delete --no-add-needed for RHEL7 or newer
Thu, Jul 11, 11:48 PM
MaskRay committed rL365877: [Driver] Delete --no-add-needed for RHEL7 or newer.
[Driver] Delete --no-add-needed for RHEL7 or newer
Thu, Jul 11, 11:47 PM
MaskRay committed rGb26f96c601df: [YAMLIO] Wrap explicit specialization in llvm::yaml to appease build bots (authored by MaskRay).
[YAMLIO] Wrap explicit specialization in llvm::yaml to appease build bots
Thu, Jul 11, 11:24 PM
MaskRay committed rL365876: [YAMLIO] Wrap explicit specialization in llvm::yaml to appease build bots.
[YAMLIO] Wrap explicit specialization in llvm::yaml to appease build bots
Thu, Jul 11, 11:23 PM
MaskRay committed rG67ab269e1d7d: [test] Delete trailing spaces from YAML tests after D65566/r365869 (authored by MaskRay).
[test] Delete trailing spaces from YAML tests after D65566/r365869
Thu, Jul 11, 11:03 PM
MaskRay committed rL365874: [test] Delete trailing spaces from YAML tests after D65566/r365869.
[test] Delete trailing spaces from YAML tests after D65566/r365869
Thu, Jul 11, 11:01 PM
MaskRay committed rGff6836f429fe: [test] Delete trailing spaces from YAML tests (authored by MaskRay).
[test] Delete trailing spaces from YAML tests
Thu, Jul 11, 11:01 PM
MaskRay committed rL365873: [test] Delete trailing spaces from YAML tests.
[test] Delete trailing spaces from YAML tests
Thu, Jul 11, 10:59 PM
MaskRay committed rGbd778e8bf926: test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should… (authored by MaskRay).
test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should…
Thu, Jul 11, 10:52 PM
MaskRay committed rL365872: test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should….
test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should…
Thu, Jul 11, 10:51 PM
MaskRay accepted D64290: [tools] [llvm-nm] Default to reading from stdin not a.out.
Thu, Jul 11, 10:51 PM · Restricted Project
MaskRay added inline comments to D64290: [tools] [llvm-nm] Default to reading from stdin not a.out.
Thu, Jul 11, 10:51 PM · Restricted Project
MaskRay committed rG27ed1c5bb80c: [YAMLIO] Remove trailing spaces when outputting maps (authored by MaskRay).
[YAMLIO] Remove trailing spaces when outputting maps
Thu, Jul 11, 9:53 PM
MaskRay committed rL365869: [YAMLIO] Remove trailing spaces when outputting maps.
[YAMLIO] Remove trailing spaces when outputting maps
Thu, Jul 11, 9:53 PM
MaskRay closed D64566: [YAMLIO] Remove trailing spaces when outputting maps.
Thu, Jul 11, 9:52 PM · Restricted Project
MaskRay updated the diff for D64566: [YAMLIO] Remove trailing spaces when outputting maps.

Update tests

Thu, Jul 11, 9:52 PM · Restricted Project
MaskRay added inline comments to D64470: [Object/ELF] - Improve error reporting for notes..
Thu, Jul 11, 9:29 PM · Restricted Project
MaskRay added a comment to D64282: [PowerPC] Support fp128 libcalls.

D64282 + D64283 are the last 2 patches to make ieeelongdouble work.

Thu, Jul 11, 8:35 PM · Restricted Project
MaskRay added a comment to D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.

This should be rebased after D64294.

Thu, Jul 11, 7:41 PM · Restricted Project
MaskRay committed rGc46d78d1b7a0: [X86][PowerPC] Support -mlong-double-128 (authored by MaskRay).
[X86][PowerPC] Support -mlong-double-128
Thu, Jul 11, 7:33 PM
MaskRay committed rL365866: [X86][PowerPC] Support -mlong-double-128.
[X86][PowerPC] Support -mlong-double-128
Thu, Jul 11, 7:33 PM
MaskRay closed D64277: [X86][PowerPC] Support -mlong-double-128.
Thu, Jul 11, 7:32 PM · Restricted Project, Restricted Project
MaskRay updated the diff for D64277: [X86][PowerPC] Support -mlong-double-128.

Use A->render(Args, CmdArgs);

Thu, Jul 11, 7:26 PM · Restricted Project, Restricted Project
MaskRay committed rG8c0b58f759ab: [PowerPC] Default to -fomit-frame-pointer when optimization is enabled (authored by MaskRay).
[PowerPC] Default to -fomit-frame-pointer when optimization is enabled
Thu, Jul 11, 7:18 PM
MaskRay committed rL365862: [PowerPC] Default to -fomit-frame-pointer when optimization is enabled.
[PowerPC] Default to -fomit-frame-pointer when optimization is enabled
Thu, Jul 11, 7:14 PM
MaskRay added a comment to D60335: Use -fomit-frame-pointer when optimizing PowerPC code.

I did this in rC365862 with a test after my refactoring of the interface rC365860.

Thu, Jul 11, 7:14 PM · Restricted Project
MaskRay committed rGdc0396614f84: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)? (authored by MaskRay).
[Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?
Thu, Jul 11, 7:03 PM
MaskRay committed rL365860: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?.
[Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?
Thu, Jul 11, 7:02 PM
MaskRay closed D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer.
Thu, Jul 11, 7:02 PM · Restricted Project, Restricted Project
MaskRay updated the diff for D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer.

Fix title

Thu, Jul 11, 7:01 PM · Restricted Project, Restricted Project
MaskRay updated the diff for D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer.

Update title and description

Thu, Jul 11, 6:59 PM · Restricted Project, Restricted Project
MaskRay added a reviewer for D64505: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM: jfb.
Thu, Jul 11, 6:50 PM · Restricted Project
MaskRay updated the diff for D64505: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM.

Add doc to InitLLVM.h
assert set_new_handler returns nullptr

Thu, Jul 11, 6:50 PM · Restricted Project
MaskRay updated the diff for D64566: [YAMLIO] Remove trailing spaces when outputting maps.

Fix output of empty sequence/map

Thu, Jul 11, 9:08 AM · Restricted Project
MaskRay updated subscribers of rL365619: [ELF] Update test case due to llvm r365618.
Thu, Jul 11, 8:36 AM
MaskRay added inline comments to D64566: [YAMLIO] Remove trailing spaces when outputting maps.
Thu, Jul 11, 7:17 AM · Restricted Project
MaskRay added inline comments to D64555: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup..
Thu, Jul 11, 7:15 AM · Restricted Project
MaskRay added a comment to D64555: [test/Object, obj2yaml] - Move test cases from test/Object and cleanup..

I think there are trailing spaces in these YAML files (e.g. in Object/Inputs/COFF/section-aux-symbol.yaml, header: is followed by 10 spaces). When you commit the patch, it might to good to delete them :) D64566

Thu, Jul 11, 7:03 AM · Restricted Project
MaskRay created D64566: [YAMLIO] Remove trailing spaces when outputting maps.
Thu, Jul 11, 6:54 AM · Restricted Project
MaskRay added inline comments to D64470: [Object/ELF] - Improve error reporting for notes..
Thu, Jul 11, 6:05 AM · Restricted Project
MaskRay accepted D64330: [llvm-ar][test] Add to llvm-ar test coverage .
Thu, Jul 11, 6:04 AM · Restricted Project
MaskRay added inline comments to D64470: [Object/ELF] - Improve error reporting for notes..
Thu, Jul 11, 4:33 AM · Restricted Project
MaskRay committed rGe1ee3837acfe: [ELF] Handle non-glob patterns before glob patterns in version scripts & fix a… (authored by MaskRay).
[ELF] Handle non-glob patterns before glob patterns in version scripts & fix a…
Thu, Jul 11, 4:18 AM
MaskRay committed rGbe8275753fe2: [ELF] Warn rather than error when duplicate version assignments occur (authored by MaskRay).
[ELF] Warn rather than error when duplicate version assignments occur
Thu, Jul 11, 4:18 AM
MaskRay committed rL365760: [ELF] Handle non-glob patterns before glob patterns in version scripts & fix a….
[ELF] Handle non-glob patterns before glob patterns in version scripts & fix a…
Thu, Jul 11, 4:17 AM
MaskRay closed D64550: [ELF] Handle non-glob patterns before glob patterns in version scripts & fix a corner case of --dynamic-list.
Thu, Jul 11, 4:17 AM · Restricted Project