- User Since
- Dec 30 2016, 3:24 PM (116 w, 1 d)
Fri, Mar 22
Oops it is used by unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp but not in library code. Let me see how to update the tests to use the other DWAAARFContext::create.
Fix typo in the title
/*DiscardedSecIdx*/ 0 -> /*DiscardedSecIdx=*/0
0 -> /*DiscardedSecIdx=*/0
Address grimar's comments
It looks Phabricator doesn't have a good diff algorithm... // RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
This gives me more confidence..
Binding != STB_WEAK
generalize to SHF_EXCLUDE and other discarded sections
Thu, Mar 21
Simplify In.GotPlt->HasGotPltOffRel = true; after reading the interaction again...
Update code/tests related to R_GOTPLT R_TLSGD_GOTPLT
Dispatch on RelTy
dispatch using Config->IsRela
Factor out maybeReportDiscardedComdat
Wed, Mar 20
We don't know addresses at this point, and indeed we can't because the layout of the rest of the output file depends on how many program headers there are, which is decided by this function. I would be in favour of the one PT_NOTE per SHT_NOTE as it is simpler and handles more cases.
Update the comment to
Improve 3 tests
If there isn't a convincing reason .got and .got.plt should be adjacent, I think we probably don't need end(.got) == start(.got.plt) (I've changed my mind about that after investigating this more).
Tue, Mar 19
 - Glibc's X86_64 code uses extern long _DYNAMIC attribute((visibility("hidden"))); just like the test in question. However, it refers to only &_DYNAMIC, for which the compiler emits R_X86_64_PC32. Hence, we do not hit the problem with
About "will break some _GLOBAL_OFFSET_TABLE_ use cases", can you elaborate which ones?
I believe the patch in the current form will break some _GLOBAL_OFFSET_TABLE_ use cases (see https://reviews.llvm.org/D48095) so I volunteer to be a reviewer :)
I surveyed ld.bfd's architecture-varying rules:
Mon, Mar 18
Comment S and A
Add a test with spaces around patterns
std::list<int> Sections; -> int Next, Prev;
Sun, Mar 17
@aaron.ballman Does the release note look good now? 😊
As a side note, sh_size%sh_entsize==0 is required and that is tested by test/ELF/invalid/merge-invalid-size.s