MaskRay (Fangrui Song)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 30 2016, 3:24 PM (90 w, 4 d)

Recent Activity

Today

MaskRay committed rL343072: [Frontend] Tidy up -print-decl-contexts conditions.
[Frontend] Tidy up -print-decl-contexts conditions
Tue, Sep 25, 11:29 PM
MaskRay committed rC343072: [Frontend] Tidy up -print-decl-contexts conditions.
[Frontend] Tidy up -print-decl-contexts conditions
Tue, Sep 25, 11:29 PM
MaskRay committed rL343039: [clangd] Remove unused using-declaration testing::AllOf.
[clangd] Remove unused using-declaration testing::AllOf
Tue, Sep 25, 3:35 PM
MaskRay committed rCTE343039: [clangd] Remove unused using-declaration testing::AllOf.
[clangd] Remove unused using-declaration testing::AllOf
Tue, Sep 25, 3:35 PM
MaskRay added inline comments to D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations..
Tue, Sep 25, 1:45 PM
MaskRay committed rL342950: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence….
Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence…
Tue, Sep 25, 1:11 AM
MaskRay committed rC342950: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence….
Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence…
Tue, Sep 25, 1:11 AM
MaskRay closed D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925.
Tue, Sep 25, 1:11 AM
MaskRay committed rL342949: Add macro LLVM_ATTRIBUTE_REINITIALIZES.
Add macro LLVM_ATTRIBUTE_REINITIALIZES
Tue, Sep 25, 1:08 AM
MaskRay closed D52451: Add macro LLVM_ATTRIBUTE_REINITIALIZES.
Tue, Sep 25, 1:08 AM

Yesterday

MaskRay committed rL342945: Use unique_ptr to hold AsmInfo,MRI,MII,STI.
Use unique_ptr to hold AsmInfo,MRI,MII,STI
Mon, Sep 24, 11:21 PM
MaskRay closed D52389: Use unique_ptr to hold AsmInfo,MRI,MII,STI.
Mon, Sep 24, 11:21 PM
MaskRay updated the diff for D52389: Use unique_ptr to hold AsmInfo,MRI,MII,STI.

Update reviewers line with arc diff --verbatim (see if this command works)

Mon, Sep 24, 10:38 PM
MaskRay added inline comments to D52389: Use unique_ptr to hold AsmInfo,MRI,MII,STI.
Mon, Sep 24, 10:37 PM
MaskRay updated the diff for D52389: Use unique_ptr to hold AsmInfo,MRI,MII,STI.

Incorporate review suggestions by dblaikie

Mon, Sep 24, 10:36 PM
MaskRay updated the diff for D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925.

Update title with arc diff --edit --verbatim

Mon, Sep 24, 10:11 PM
MaskRay updated the diff for D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925.

Depends on D52451 (adding LLVM_ATTRIBUTE_REINITIALIZES)

Mon, Sep 24, 10:11 PM
MaskRay created D52451: Add macro LLVM_ATTRIBUTE_REINITIALIZES.
Mon, Sep 24, 9:59 PM
MaskRay added inline comments to D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations..
Mon, Sep 24, 8:35 PM
MaskRay committed rCXX342936: Remove redundant null pointer check in operator delete.
Remove redundant null pointer check in operator delete
Mon, Sep 24, 7:52 PM
MaskRay committed rL342936: Remove redundant null pointer check in operator delete.
Remove redundant null pointer check in operator delete
Mon, Sep 24, 7:52 PM
MaskRay closed D52401: Remove redundant null pointer check in operator delete.
Mon, Sep 24, 7:52 PM
MaskRay added a reviewer for D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925: Restricted Project.
Mon, Sep 24, 6:09 PM
MaskRay created D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925.
Mon, Sep 24, 6:09 PM
MaskRay added a comment to D52401: Remove redundant null pointer check in operator delete.

Ping :)

Mon, Sep 24, 4:41 PM
MaskRay added inline comments to D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations..
Mon, Sep 24, 4:35 PM
MaskRay added inline comments to D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations..
Mon, Sep 24, 4:33 PM
MaskRay created D52445: [Index] Use locations to uniquify function-scope BindingDecl USR.
Mon, Sep 24, 4:22 PM

Sun, Sep 23

MaskRay added a comment to D52401: Remove redundant null pointer check in operator delete.

Was this true pre-C11 too? If not, then this needs to be guarded by #if _LIBCPP_STD_VER >= 17, because C++ is only on top of C11 in C++17 and above (Marshall can double-check this).

Sun, Sep 23, 1:31 AM
MaskRay updated the diff for D52401: Remove redundant null pointer check in operator delete.

Quote C89: "If ptr is a null pointer, no action occurs."

Sun, Sep 23, 1:29 AM
MaskRay committed rC342831: [Index] Report specialization bases as references when….
[Index] Report specialization bases as references when…
Sun, Sep 23, 1:25 AM
MaskRay committed rL342831: [Index] Report specialization bases as references when….
[Index] Report specialization bases as references when…
Sun, Sep 23, 1:25 AM
MaskRay closed D52331: [Index] Report specialization bases as references when IndexImplicitInstantiation is true.
Sun, Sep 23, 1:25 AM
MaskRay updated the diff for D52401: Remove redundant null pointer check in operator delete.

Also remove the check for _aligned_free

Sun, Sep 23, 12:45 AM

Sat, Sep 22

MaskRay updated the diff for D52401: Remove redundant null pointer check in operator delete.

.

Sat, Sep 22, 10:24 PM
MaskRay created D52401: Remove redundant null pointer check in operator delete.
Sat, Sep 22, 10:17 PM
MaskRay committed rC342825: [Index] Fix header guard naming.
[Index] Fix header guard naming
Sat, Sep 22, 3:51 PM
MaskRay committed rL342825: [Index] Fix header guard naming.
[Index] Fix header guard naming
Sat, Sep 22, 3:51 PM
MaskRay added a reviewer for D52331: [Index] Report specialization bases as references when IndexImplicitInstantiation is true: devnexen.
Sat, Sep 22, 2:52 PM

Fri, Sep 21

MaskRay created D52389: Use unique_ptr to hold AsmInfo,MRI,MII,STI.
Fri, Sep 21, 9:08 PM

Thu, Sep 20

MaskRay created D52331: [Index] Report specialization bases as references when IndexImplicitInstantiation is true.
Thu, Sep 20, 4:53 PM

Tue, Sep 18

MaskRay added inline comments to D52231: [PPC64] Add helper for calculating the offset from a functions global entry to its local entry. [NFC].
Tue, Sep 18, 1:40 PM
MaskRay committed rCTE342445: [pp-trace] Remove unused using directives.
[pp-trace] Remove unused using directives
Tue, Sep 18, 12:00 AM
MaskRay committed rL342445: [pp-trace] Remove unused using directives.
[pp-trace] Remove unused using directives
Tue, Sep 18, 12:00 AM

Mon, Sep 17

MaskRay added a comment to D52194: [ELF] Keep GdbIndexSection::Symbols non-flattened to avoid allocating large vector.

If SyntheticSection::writeTo is guaranteed to be called once (I'm not sure if that is the case), Symbols.clear() in GdbIndexSection::writeTo decrease the maximum RSS by 190MiB, but I'm not sure if it is worthy to do these (freeing resources prematurely at the end of writeTo) for GdbIndexSection and/or other sections..

Mon, Sep 17, 3:15 PM
MaskRay created D52194: [ELF] Keep GdbIndexSection::Symbols non-flattened to avoid allocating large vector.
Mon, Sep 17, 3:09 PM
MaskRay committed rCXX342361: Fix typo.
Fix typo
Mon, Sep 17, 12:44 AM
MaskRay committed rL342361: Fix typo.
Fix typo
Mon, Sep 17, 12:44 AM

Sat, Sep 15

MaskRay committed rLLD342342: [ELF] Use llvm::toLower instead of libc call tolower.
[ELF] Use llvm::toLower instead of libc call tolower
Sat, Sep 15, 5:00 PM
MaskRay committed rL342342: [ELF] Use llvm::toLower instead of libc call tolower.
[ELF] Use llvm::toLower instead of libc call tolower
Sat, Sep 15, 5:00 PM
MaskRay closed D52128: [ELF] Use llvm::toLower instead of libc call tolower.
Sat, Sep 15, 5:00 PM
MaskRay added a comment to D52128: [ELF] Use llvm::toLower instead of libc call tolower.

What is the point of doing this?

Sat, Sep 15, 4:30 PM
MaskRay committed rL342339: [llvm-readobj] Make some commonly used short options visibile in -help.
[llvm-readobj] Make some commonly used short options visibile in -help
Sat, Sep 15, 2:31 PM
MaskRay closed D52129: [llvm-readobj] Make some commonly used short options visibile in -help.
Sat, Sep 15, 2:31 PM

Fri, Sep 14

MaskRay added a comment to D52129: [llvm-readobj] Make some commonly used short options visibile in -help.

For people who think llvm-readelf is a replacement of readelf, they would like to see -d -r ... listed in llvm-readelf -help.

Fri, Sep 14, 6:06 PM
MaskRay created D52129: [llvm-readobj] Make some commonly used short options visibile in -help.
Fri, Sep 14, 6:03 PM
MaskRay created D52128: [ELF] Use llvm::toLower instead of libc call tolower.
Fri, Sep 14, 5:38 PM
MaskRay added inline comments to D52126: Discard uncompressed buffer after creating .gdb_index contents..
Fri, Sep 14, 3:47 PM
MaskRay accepted D52126: Discard uncompressed buffer after creating .gdb_index contents..

Great finding! Just a question: do you move the code because the new place fits well?

Fri, Sep 14, 3:44 PM
MaskRay created D52124: [ELF][test] Use llvm-readelf's short option -r instead of -relocations and remove ignored --wide.
Fri, Sep 14, 3:03 PM
MaskRay accepted D52055: [PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation.
Fri, Sep 14, 2:57 PM
MaskRay added inline comments to D52055: [PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation.
Fri, Sep 14, 2:57 PM
MaskRay accepted D52115: [PPC64] Add helpers for read/writing an instruction while relocating a half16 type. [NFC].
Fri, Sep 14, 2:50 PM
MaskRay committed rC342290: test/Driver/output-file-cleanup.c: delete non-readable temporary file.
test/Driver/output-file-cleanup.c: delete non-readable temporary file
Fri, Sep 14, 2:38 PM
MaskRay committed rL342290: test/Driver/output-file-cleanup.c: delete non-readable temporary file.
test/Driver/output-file-cleanup.c: delete non-readable temporary file
Fri, Sep 14, 2:38 PM
MaskRay committed rL342279: test/Other/can-execute.txt: delete %t after the test.
test/Other/can-execute.txt: delete %t after the test
Fri, Sep 14, 1:42 PM
MaskRay added a comment to D52115: [PPC64] Add helpers for read/writing an instruction while relocating a half16 type. [NFC].

Looks better!

Fri, Sep 14, 12:18 PM
MaskRay added inline comments to D52115: [PPC64] Add helpers for read/writing an instruction while relocating a half16 type. [NFC].
Fri, Sep 14, 12:15 PM

Thu, Sep 13

MaskRay committed rCTE342198: [clangd] Fix TUScheduler typos.
[clangd] Fix TUScheduler typos
Thu, Sep 13, 5:57 PM
MaskRay committed rL342198: [clangd] Fix TUScheduler typos.
[clangd] Fix TUScheduler typos
Thu, Sep 13, 5:57 PM

Sun, Sep 9

MaskRay committed rC341763: [Sema] Make typo correction slightly more efficient.
[Sema] Make typo correction slightly more efficient
Sun, Sep 9, 10:21 AM
MaskRay committed rL341763: [Sema] Make typo correction slightly more efficient.
[Sema] Make typo correction slightly more efficient
Sun, Sep 9, 10:21 AM

Sat, Sep 8

MaskRay committed rC341756: [Parser] Remove an unnecessary `mutable`.
[Parser] Remove an unnecessary `mutable`
Sat, Sep 8, 6:55 PM
MaskRay committed rL341756: [Parser] Remove an unnecessary `mutable`.
[Parser] Remove an unnecessary `mutable`
Sat, Sep 8, 6:55 PM

Fri, Sep 7

MaskRay committed rL341740: Fix typos. NFC.
Fix typos. NFC
Fri, Sep 7, 7:07 PM
MaskRay committed rL341702: [PGO] Fix some style issue of ControlHeightReduction.
[PGO] Fix some style issue of ControlHeightReduction
Fri, Sep 7, 1:25 PM
MaskRay closed D51811: [PGO] Fix some style issue of ControlHeightReduction.
Fri, Sep 7, 1:25 PM
MaskRay created D51811: [PGO] Fix some style issue of ControlHeightReduction.
Fri, Sep 7, 12:48 PM
MaskRay committed rL341688: [llvm-dwp] Clean up tests X86/*.test.
[llvm-dwp] Clean up tests X86/*.test
Fri, Sep 7, 11:33 AM

Thu, Sep 6

MaskRay committed rL341611: [ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections.
[ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections
Thu, Sep 6, 5:20 PM
MaskRay committed rLLD341611: [ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections.
[ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections
Thu, Sep 6, 5:20 PM
MaskRay closed D51743: [ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections.
Thu, Sep 6, 5:20 PM
MaskRay added inline comments to D51743: [ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections.
Thu, Sep 6, 4:18 PM
MaskRay updated the diff for D51743: [ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections.

Beautify

Thu, Sep 6, 4:18 PM
MaskRay committed rL341586: Reland rL341509: "[llvm-dwp] Use buffer_stream if output file is not seekable….
Reland rL341509: "[llvm-dwp] Use buffer_stream if output file is not seekable…
Thu, Sep 6, 1:30 PM
MaskRay added a comment to D51707: [llvm-dwp] Use buffer_stream if output file is not seekable (e.g. "-").

Hi,

This commit has caused massive buildbot failures on compilation, see for example http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/5953/steps/build%20stage%201/logs/stdio

I have reverted it as https://reviews.llvm.org/rL341515 to make buildbot green again.

  • Max
Thu, Sep 6, 1:30 PM
MaskRay committed rL341584: [llvm-dwp] Use cl:: instead of using namespace cl.
[llvm-dwp] Use cl:: instead of using namespace cl
Thu, Sep 6, 1:24 PM
MaskRay committed rL341582: Add missing #include for Testing/Support/SupportHelpers.h.
Add missing #include for Testing/Support/SupportHelpers.h
Thu, Sep 6, 1:06 PM
MaskRay added a comment to D51561: [CMake] Add support for unittests that have input files.

I think LLVMTestingSupport should never be a shared lib, what do you think?

Thu, Sep 6, 12:55 PM
MaskRay committed rL341580: Quick fix for -DBUILD_SHARED_LIBS=on build after rL341502.
Quick fix for -DBUILD_SHARED_LIBS=on build after rL341502
Thu, Sep 6, 12:52 PM
MaskRay updated the summary of D51743: [ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections.
Thu, Sep 6, 11:21 AM
MaskRay created D51743: [ELF] Check if LinkSec is nullptr when initializing SHF_LINK_ORDER sections.
Thu, Sep 6, 11:19 AM

Wed, Sep 5

MaskRay added a comment to D51607: [ELF] Fix bugzilla #38748 for option no-rosegment.

I made a comment in https://bugs.llvm.org/show_bug.cgi?id=38784

Wed, Sep 5, 5:59 PM · lld
MaskRay added a comment to D51561: [CMake] Add support for unittests that have input files.
% ninja libLLVMTestingSupport.so
............. -Wl,-z,defs  ..........
ld.lld: error: undefined symbol: TestMainArgv0
>>> referenced by SupportHelpers.cpp
>>>               lib/Testing/Support/CMakeFiles/LLVMTestingSupport.dir/SupportHelpers.cpp.o:(llvm::unittest::getInputFileDirectory())
clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
Wed, Sep 5, 5:55 PM
MaskRay committed rL341510: [llvm-dwp] Fix `UN:` lines (supposed to be `RUN:`) in X86/simple.test and….
[llvm-dwp] Fix `UN:` lines (supposed to be `RUN:`) in X86/simple.test and…
Wed, Sep 5, 5:48 PM
MaskRay closed D51704: [llvm-dwp] Fix `UN:` lines (supposed to be `RUN:`) in X86/simple.test and adjust check lines for TYPES:.
Wed, Sep 5, 5:47 PM
MaskRay committed rL341509: [llvm-dwp] Use buffer_stream if output file is not seekable (e.g. "-").
[llvm-dwp] Use buffer_stream if output file is not seekable (e.g. "-")
Wed, Sep 5, 5:07 PM
MaskRay closed D51707: [llvm-dwp] Use buffer_stream if output file is not seekable (e.g. "-").
Wed, Sep 5, 5:07 PM
MaskRay updated the diff for D51707: [llvm-dwp] Use buffer_stream if output file is not seekable (e.g. "-").

std::unique_ptr -> Optional to save an extra allocation

Wed, Sep 5, 5:04 PM
MaskRay updated the diff for D51707: [llvm-dwp] Use buffer_stream if output file is not seekable (e.g. "-").

Remove comment

Wed, Sep 5, 3:55 PM