MaskRay (Fangrui Song)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 30 2016, 3:24 PM (54 w, 4 d)

Recent Activity

Today

MaskRay added a reviewer for D42144: [utils] Make .cfi_startproc optional for powerpc: spatel.
Tue, Jan 16, 4:08 PM
MaskRay created D42144: [utils] Make .cfi_startproc optional for powerpc.
Tue, Jan 16, 4:07 PM

Mon, Jan 8

MaskRay added a comment to D41575: [index] Return when DC is null in handleReference.

Ah, sorry I mislead you. To test this try using c-index-test -index-file /path/to/file, see other examples in test/Index, e.g. test/Index/index-file.cpp

Mon, Jan 8, 6:28 PM
MaskRay committed rC322017: [index] Return when DC is null in handleReference.
[index] Return when DC is null in handleReference
Mon, Jan 8, 10:59 AM
MaskRay committed rL322017: [index] Return when DC is null in handleReference.
[index] Return when DC is null in handleReference
Mon, Jan 8, 10:58 AM
MaskRay closed D41575: [index] Return when DC is null in handleReference.
Mon, Jan 8, 10:58 AM
MaskRay updated the diff for D41575: [index] Return when DC is null in handleReference.

rebase

Mon, Jan 8, 10:51 AM
MaskRay added a comment to D41575: [index] Return when DC is null in handleReference.

@akyrtzi When I run c-index-test core -print-source-symbols -- a.cc on

Mon, Jan 8, 10:47 AM

Fri, Jan 5

MaskRay added a comment to D41575: [index] Return when DC is null in handleReference.

Ping

Fri, Jan 5, 4:52 PM

Thu, Jan 4

MaskRay added a reviewer for D41575: [index] Return when DC is null in handleReference: yvvan.
Thu, Jan 4, 8:46 AM

Wed, Jan 3

MaskRay added a comment to D41575: [index] Return when DC is null in handleReference.

HighCommander4 narrowed it down https://github.com/jacobdufault/cquery/issues/219#issuecomment-354903152 to a much simpler reproduce:

Wed, Jan 3, 9:38 AM

Mon, Dec 25

MaskRay retitled D41575: [index] Return when DC is null in handleReference from [index] Return when Parent is null in handleReference to [index] Return when DC is null in handleReference.
Mon, Dec 25, 4:05 PM
MaskRay updated the diff for D41575: [index] Return when DC is null in handleReference.

Sorry for changing this back and forth. But I do not have a powerful workstation and have to reverse engineer this.

Mon, Dec 25, 3:53 PM
MaskRay retitled D41575: [index] Return when DC is null in handleReference from [index] Return when DC is null in handleReference to [index] Return when Parent is null in handleReference.
Mon, Dec 25, 3:48 PM
MaskRay updated the diff for D41575: [index] Return when DC is null in handleReference.

DC -> Parent

Mon, Dec 25, 3:48 PM
MaskRay updated the diff for D41575: [index] Return when DC is null in handleReference.

DC -> Parent

Mon, Dec 25, 3:46 PM
MaskRay updated the summary of D41575: [index] Return when DC is null in handleReference.
Mon, Dec 25, 2:50 PM
MaskRay updated the summary of D41575: [index] Return when DC is null in handleReference.
Mon, Dec 25, 2:48 PM
MaskRay created D41575: [index] Return when DC is null in handleReference.
Mon, Dec 25, 2:44 PM

Dec 5 2017

MaskRay committed rL319869: Do not use default arguments of DataLayout::getPointer*. NFC.
Do not use default arguments of DataLayout::getPointer*. NFC
Dec 5 2017, 5:32 PM
MaskRay closed D40064: Do not use default arguments of DataLayout::getPointer*. NFC by committing rL319869: Do not use default arguments of DataLayout::getPointer*. NFC.
Dec 5 2017, 5:32 PM
MaskRay updated the diff for D39942: [PPC] Add additional fnmadd patterns..

Add tests

Dec 5 2017, 4:27 PM
MaskRay added a comment to D40064: Do not use default arguments of DataLayout::getPointer*. NFC.

Friendly ping...

Dec 5 2017, 3:29 PM

Nov 27 2017

MaskRay updated the diff for D40064: Do not use default arguments of DataLayout::getPointer*. NFC.

Remove MallocPointer because it turns out it is not used.

Nov 27 2017, 9:34 PM
MaskRay committed rL319047: [XRay] Fix typo in docs. NFC.
[XRay] Fix typo in docs. NFC
Nov 27 2017, 8:59 AM
MaskRay closed D40461: [XRay] Fix typo in docs. NFC by committing rL319047: [XRay] Fix typo in docs. NFC.
Nov 27 2017, 8:59 AM
MaskRay updated the diff for D40461: [XRay] Fix typo in docs. NFC.

rebase

Nov 27 2017, 8:59 AM

Nov 25 2017

MaskRay created D40461: [XRay] Fix typo in docs. NFC.
Nov 25 2017, 11:28 PM

Nov 24 2017

MaskRay added a reviewer for D40064: Do not use default arguments of DataLayout::getPointer*. NFC: clayborg.
Nov 24 2017, 12:19 PM

Nov 14 2017

MaskRay added a reviewer for D40064: Do not use default arguments of DataLayout::getPointer*. NFC: zturner.
Nov 14 2017, 11:12 PM
MaskRay created D40064: Do not use default arguments of DataLayout::getPointer*. NFC.
Nov 14 2017, 11:12 PM
MaskRay committed rL318272: NFC Remove default argument of DataLayout::getPointerABIAlignment.
NFC Remove default argument of DataLayout::getPointerABIAlignment
Nov 14 2017, 10:17 PM
MaskRay closed D40005: NFC Remove default argument of DataLayout::getPointerABIAlignment by committing rL318272: NFC Remove default argument of DataLayout::getPointerABIAlignment.
Nov 14 2017, 10:17 PM
MaskRay updated the diff for D40005: NFC Remove default argument of DataLayout::getPointerABIAlignment.

Rebase

Nov 14 2017, 10:16 PM
MaskRay added a comment to D40005: NFC Remove default argument of DataLayout::getPointerABIAlignment.

Yes, it is not used by clang. This revision should have covered all users.

Nov 14 2017, 10:06 PM
MaskRay added a reviewer for D40005: NFC Remove default argument of DataLayout::getPointerABIAlignment: chandlerc.
Nov 14 2017, 7:44 PM
MaskRay added a comment to D39942: [PPC] Add additional fnmadd patterns..

@nemanjai I cannot find tests for instructions XVNMSUBASP ... in // Additional fnmsub patterns: -a*c + b == -(a*c - b). It is also unclear to me what roles these FMA test files take and in which file I should add the test.

Nov 14 2017, 7:41 PM

Nov 13 2017

MaskRay added a reviewer for D40005: NFC Remove default argument of DataLayout::getPointerABIAlignment: mehdi_amini.
Nov 13 2017, 11:57 PM
MaskRay created D40005: NFC Remove default argument of DataLayout::getPointerABIAlignment.
Nov 13 2017, 11:56 PM
MaskRay added a comment to D39942: [PPC] Add additional fnmadd patterns..

The current enabled (negative multiply-add, ) optimization // Additional fnmsub patterns: -a*c + b == -(a*c - b), is not safe unless positive zero is treated the same as negative zero

Nov 13 2017, 11:33 AM

Nov 11 2017

MaskRay added reviewers for D39942: [PPC] Add additional fnmadd patterns.: nemanjai, echristo.
Nov 11 2017, 6:36 PM
MaskRay created D39942: [PPC] Add additional fnmadd patterns..
Nov 11 2017, 6:35 PM

Oct 30 2017

MaskRay added a comment to D38962: [test-suite] Update bitreverse benchmark..

While the change itself makes sense:

  • Please give some more descriptions than "update test" in the future.
  • Also give a warning in the commit message as this changes performance and will show up in the LNT numbers.
Oct 30 2017, 10:02 AM
MaskRay committed rL316918: [test-suite] Update bitreverse benchmark..
[test-suite] Update bitreverse benchmark.
Oct 30 2017, 9:15 AM
MaskRay closed D38962: [test-suite] Update bitreverse benchmark. by committing rL316918: [test-suite] Update bitreverse benchmark..
Oct 30 2017, 9:15 AM
MaskRay committed rL316916: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..
[PPC CodeGen] Fix the bitreverse.i64 intrinsic.
Oct 30 2017, 9:04 AM
MaskRay closed D39163: [PPC CodeGen] Fix the bitreverse.i64 intrinsic. by committing rL316916: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..
Oct 30 2017, 9:04 AM
MaskRay added a comment to D39163: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

I reran the test just now. They did not fail.

Oct 30 2017, 9:03 AM

Oct 26 2017

MaskRay added a comment to D39163: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

% build/bin/llvm-lit test

Oct 26 2017, 1:36 PM
MaskRay added a comment to D39163: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

@jtony I have renamed Extend Shift to Bytes0123 Bytes3012 ... because I think the new names are clearer.

Oct 26 2017, 10:54 AM
MaskRay updated the diff for D39163: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

Rename some def to be clearer.

Oct 26 2017, 10:48 AM

Oct 24 2017

MaskRay added a reviewer for D39163: [PPC CodeGen] Fix the bitreverse.i64 intrinsic.: vitalybuka.
Oct 24 2017, 9:05 AM

Oct 22 2017

MaskRay committed rL316297: [utils] Support -mtriple=powerpc64.
[utils] Support -mtriple=powerpc64
Oct 22 2017, 11:46 AM
MaskRay closed D39164: [utils] Support -mtriple=powerpc64 by committing rL316297: [utils] Support -mtriple=powerpc64.
Oct 22 2017, 11:46 AM
MaskRay added reviewers for D39164: [utils] Support -mtriple=powerpc64: spatel, chandlerc.
Oct 22 2017, 12:21 AM
MaskRay updated the diff for D39164: [utils] Support -mtriple=powerpc64.

no

Oct 22 2017, 12:17 AM
MaskRay created D39164: [utils] Support -mtriple=powerpc64.
Oct 22 2017, 12:16 AM
MaskRay added a comment to D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

Created a refix D39163

Oct 22 2017, 12:11 AM
MaskRay created D39163: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..
Oct 22 2017, 12:10 AM

Oct 21 2017

MaskRay committed rL316270: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..
[PPC CodeGen] Fix the bitreverse.i64 intrinsic.
Oct 21 2017, 10:01 AM
MaskRay closed D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic. by committing rL316270: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..
Oct 21 2017, 10:01 AM

Oct 18 2017

MaskRay added inline comments to D38962: [test-suite] Update bitreverse benchmark..
Oct 18 2017, 9:11 AM
MaskRay updated the diff for D38962: [test-suite] Update bitreverse benchmark..

Change int -> unsigned

Oct 18 2017, 9:10 AM
MaskRay added a comment to D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

This patch now LGTM.

Oct 18 2017, 8:54 AM
MaskRay updated the diff for D38962: [test-suite] Update bitreverse benchmark..

Add an easily verifiable functional test.

Oct 18 2017, 8:19 AM

Oct 16 2017

MaskRay added a comment to D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..
Oct 16 2017, 1:53 PM
MaskRay updated the diff for D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

Renamed ExtendHi32.ToLo32 to MoveHi32.ToLo32

Oct 16 2017, 1:53 PM
MaskRay added a comment to D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

The test is changed at https://reviews.llvm.org/D38962

Oct 16 2017, 10:29 AM
MaskRay created D38962: [test-suite] Update bitreverse benchmark..
Oct 16 2017, 10:28 AM
MaskRay added a comment to D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

Added comment suggest by jtony.

Oct 16 2017, 10:24 AM
MaskRay updated the diff for D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

Add comment suggested by jtony

Oct 16 2017, 10:20 AM

Oct 12 2017

MaskRay added a reviewer for D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic.: jtony.
Oct 12 2017, 10:34 AM

Oct 9 2017

MaskRay updated the diff for D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

Name change.

Oct 9 2017, 3:50 PM
MaskRay added a comment to D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

Where to put the test?

Oct 9 2017, 3:41 PM
MaskRay added a reviewer for D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic.: echristo.
Oct 9 2017, 2:14 PM
MaskRay updated the diff for D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..

Update test

Oct 9 2017, 1:59 PM
MaskRay created D38705: [PPC CodeGen] Fix the bitreverse.i64 intrinsic..
Oct 9 2017, 1:38 PM