Page MenuHomePhabricator

kosarev (Ivan Kosarev)
Compiler Engineer

Projects

User does not belong to any projects.

User Details

User Since
Mar 3 2017, 8:19 AM (278 w, 5 d)

Compiler developer with the majority of the experience in static analysis, run-time validation, compiler optimizations, code generation, semantic analysis, simulators, assemblers, linkers and ARM programming.

Recent Activity

Today

kosarev added a reviewer for D129228: [mlir][AMDGPU] Add --chipset option to AMDGPUToROCDL: Restricted Project.
Thu, Jul 7, 3:09 AM · Restricted Project, Restricted Project

Yesterday

kosarev updated the diff for D129095: [AMDGPU][CodeGen] Match complex register SMRD offsets..

Addressed review notes.

Wed, Jul 6, 8:11 AM · Restricted Project, Restricted Project
kosarev added inline comments to D129095: [AMDGPU][CodeGen] Match complex register SMRD offsets..
Wed, Jul 6, 6:51 AM · Restricted Project, Restricted Project

Tue, Jul 5

kosarev added inline comments to D129095: [AMDGPU][CodeGen] Match complex register SMRD offsets..
Tue, Jul 5, 7:57 AM · Restricted Project, Restricted Project
kosarev added inline comments to D129095: [AMDGPU][CodeGen] Match complex register SMRD offsets..
Tue, Jul 5, 7:14 AM · Restricted Project, Restricted Project
kosarev added inline comments to D129095: [AMDGPU][CodeGen] Match complex register SMRD offsets..
Tue, Jul 5, 6:59 AM · Restricted Project, Restricted Project
kosarev updated the diff for D129095: [AMDGPU][CodeGen] Match complex register SMRD offsets..

Rebased on top of D128171 and updated the test to use named values.

Tue, Jul 5, 6:51 AM · Restricted Project, Restricted Project
kosarev committed rG4696a33dfaef: [AMDGPU][NFC] Refine matching SMRD offsets. (authored by kosarev).
[AMDGPU][NFC] Refine matching SMRD offsets.
Tue, Jul 5, 6:17 AM · Restricted Project, Restricted Project
kosarev closed D128171: [AMDGPU][NFC] Refine matching SMRD offsets..
Tue, Jul 5, 6:17 AM · Restricted Project, Restricted Project
kosarev committed rG8cd79bc12c36: [AMDGPU][GlobalISel] Support register offsets for SMRDs. (authored by kosarev).
[AMDGPU][GlobalISel] Support register offsets for SMRDs.
Tue, Jul 5, 5:58 AM · Restricted Project, Restricted Project
kosarev closed D128836: [AMDGPU][GlobalISel] Support register offsets for SMRDs..
Tue, Jul 5, 5:58 AM · Restricted Project, Restricted Project
kosarev added inline comments to D128836: [AMDGPU][GlobalISel] Support register offsets for SMRDs..
Tue, Jul 5, 5:38 AM · Restricted Project, Restricted Project
kosarev updated the diff for D128836: [AMDGPU][GlobalISel] Support register offsets for SMRDs..

Moved the check lines in the test before the function.

Tue, Jul 5, 5:38 AM · Restricted Project, Restricted Project

Mon, Jul 4

kosarev added a comment to D129095: [AMDGPU][CodeGen] Match complex register SMRD offsets..

D128836 covers the case for Global ISel.

Mon, Jul 4, 11:50 AM · Restricted Project, Restricted Project
kosarev requested review of D129095: [AMDGPU][CodeGen] Match complex register SMRD offsets..
Mon, Jul 4, 11:45 AM · Restricted Project, Restricted Project

Thu, Jun 30

kosarev updated the diff for D128836: [AMDGPU][GlobalISel] Support register offsets for SMRDs..

Added an MIR instruction selection test and changed the if () condition
as suggested.

Thu, Jun 30, 8:36 AM · Restricted Project, Restricted Project
kosarev added a comment to D128171: [AMDGPU][NFC] Refine matching SMRD offsets..

Ping.

Thu, Jun 30, 2:54 AM · Restricted Project, Restricted Project
kosarev added inline comments to D128836: [AMDGPU][GlobalISel] Support register offsets for SMRDs..
Thu, Jun 30, 2:53 AM · Restricted Project, Restricted Project
kosarev updated the diff for D128836: [AMDGPU][GlobalISel] Support register offsets for SMRDs..

Updated to use matchZeroExtendFromS32().

Thu, Jun 30, 2:44 AM · Restricted Project, Restricted Project

Wed, Jun 29

kosarev requested review of D128836: [AMDGPU][GlobalISel] Support register offsets for SMRDs..
Wed, Jun 29, 9:59 AM · Restricted Project, Restricted Project

Wed, Jun 22

kosarev added a comment to D128171: [AMDGPU][NFC] Refine matching SMRD offsets..

Does GlobalISel need the equivalent change?

Wed, Jun 22, 8:45 AM · Restricted Project, Restricted Project

Tue, Jun 21

kosarev updated the diff for D128171: [AMDGPU][NFC] Refine matching SMRD offsets..

Added comments.

Tue, Jun 21, 5:20 AM · Restricted Project, Restricted Project
kosarev added a comment to D128241: [AMDGPU] Use AddedComplexity for ret and noret atomic ops selection.

This likely needs some tests?

Tue, Jun 21, 2:27 AM · Restricted Project, Restricted Project

Mon, Jun 20

kosarev requested review of D128171: [AMDGPU][NFC] Refine matching SMRD offsets..
Mon, Jun 20, 2:41 AM · Restricted Project, Restricted Project

Thu, Jun 16

kosarev added a reviewer for D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info: Restricted Project.
Thu, Jun 16, 8:23 AM · Restricted Project, Restricted Project

Fri, Jun 10

kosarev committed rGeccbe6d1226a: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction… (authored by kosarev).
[TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction…
Fri, Jun 10, 6:39 AM · Restricted Project, Restricted Project
kosarev closed D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands..
Fri, Jun 10, 6:39 AM · Restricted Project, Restricted Project
kosarev committed rG60d6fbb62110: [AMDGPU][GFX9][GFX10] Support base+soffset+offset SMEM atomics. (authored by kosarev).
[AMDGPU][GFX9][GFX10] Support base+soffset+offset SMEM atomics.
Fri, Jun 10, 5:23 AM · Restricted Project, Restricted Project
kosarev closed D127314: [AMDGPU][GFX9][GFX10] Support base+soffset+offset SMEM atomics..
Fri, Jun 10, 5:23 AM · Restricted Project, Restricted Project
kosarev added a comment to D126794: [RISCV] Lower VLEFF/VLSEGFF SDNodes to MachineInstrs with VL outputs..

I am sorry for creating the trouble. Should I revert the patch first?

Fri, Jun 10, 4:09 AM · Restricted Project, Restricted Project
kosarev added a comment to D126794: [RISCV] Lower VLEFF/VLSEGFF SDNodes to MachineInstrs with VL outputs..

This seems to break some builds.

$ git checkout f68cad90870590b7b1854828f255070301873347
$ cmake \
    -DBUILD_SHARED_LIBS=ON \
    -DCMAKE_BUILD_TYPE=RELEASE \
    -DCMAKE_INSTALL_PREFIX=./install \
    -DLLVM_ENABLE_ASSERTIONS=ON \
    -DLLVM_ENABLE_PROJECTS="clang" \
    -DLLVM_USE_LINKER=gold \
    -GNinja \
    ../../llvm
$ ninja
FAILED: lib/libLLVMRISCVDesc.so.15git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete -fuse-ld=gold   -Wl,--gc-sections -shared -Wl,-soname,libLLVMRISCVDesc.so.15git -o lib/libLLVMRISCVDesc.so.15git lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVAsmBackend.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVBaseInfo.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVELFObjectWriter.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVInstPrinter.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVMCAsmInfo.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVMCCodeEmitter.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVMCExpr.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVMCObjectFileInfo.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVMCTargetDesc.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVMatInt.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVTargetStreamer.cpp.o lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVELFStreamer.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVMRISCVInfo.so.15git  lib/libLLVMMC.so.15git  lib/libLLVMSupport.so.15git  -Wl,-rpath-link,/home/kosarev/labs/llvm-project/build/debug+asserts/lib && :
lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVBaseInfo.cpp.o:RISCVBaseInfo.cpp:function llvm::isFaultFirstLoad(llvm::MachineInstr const&): error: undefined reference to 'llvm::MachineInstr::getNumExplicitDefs() const'
lib/Target/RISCV/MCTargetDesc/CMakeFiles/LLVMRISCVDesc.dir/RISCVBaseInfo.cpp.o:RISCVBaseInfo.cpp:function llvm::isFaultFirstLoad(llvm::MachineInstr const&): error: undefined reference to 'llvm::MachineInstr::findRegisterDefOperandIdx(llvm::Register, bool, bool, llvm::TargetRegisterInfo const*) const'
collect2: error: ld returned 1 exit status
[18/1384] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangAttrEmitter.cpp.o
ninja: build stopped: subcommand failed.
Fri, Jun 10, 3:28 AM · Restricted Project, Restricted Project
kosarev added inline comments to D127314: [AMDGPU][GFX9][GFX10] Support base+soffset+offset SMEM atomics..
Fri, Jun 10, 1:06 AM · Restricted Project, Restricted Project

Thu, Jun 9

kosarev added a comment to D127198: [AMDGPU][MC][GFX1013] Enable image_msaa_load.

The tests look good to me, thanks.

Thu, Jun 9, 6:27 AM · Restricted Project, Restricted Project
kosarev added inline comments to D127391: [AMDGPU] Update SIInsertHardClauses for GFX11.
Thu, Jun 9, 4:01 AM · Restricted Project, Restricted Project
kosarev added inline comments to D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands..
Thu, Jun 9, 3:54 AM · Restricted Project, Restricted Project

Wed, Jun 8

kosarev added reviewers for D127314: [AMDGPU][GFX9][GFX10] Support base+soffset+offset SMEM atomics.: dp, foad, arsenm, rampitec.
Wed, Jun 8, 8:50 AM · Restricted Project, Restricted Project
kosarev requested review of D127314: [AMDGPU][GFX9][GFX10] Support base+soffset+offset SMEM atomics..
Wed, Jun 8, 8:47 AM · Restricted Project, Restricted Project
kosarev added inline comments to D127198: [AMDGPU][MC][GFX1013] Enable image_msaa_load.
Wed, Jun 8, 6:14 AM · Restricted Project, Restricted Project
kosarev added inline comments to D127198: [AMDGPU][MC][GFX1013] Enable image_msaa_load.
Wed, Jun 8, 5:36 AM · Restricted Project, Restricted Project
kosarev added inline comments to D127198: [AMDGPU][MC][GFX1013] Enable image_msaa_load.
Wed, Jun 8, 4:09 AM · Restricted Project, Restricted Project
kosarev added a reviewer for D126836: [LIBOMPTARGET] Adding AMD to llvm-omp-device-info: Restricted Project.
Wed, Jun 8, 3:31 AM · Restricted Project, Restricted Project
kosarev added inline comments to D127198: [AMDGPU][MC][GFX1013] Enable image_msaa_load.
Wed, Jun 8, 2:58 AM · Restricted Project, Restricted Project

Jun 6 2022

kosarev added a comment to D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands..

Ping.

Jun 6 2022, 8:49 AM · Restricted Project, Restricted Project
kosarev committed rGfacbfb121a5c: [AMDGPU][GFX9+] Support base+soffset+offset s_atc_probe's. (authored by kosarev).
[AMDGPU][GFX9+] Support base+soffset+offset s_atc_probe's.
Jun 6 2022, 8:48 AM · Restricted Project, Restricted Project
kosarev closed D126791: [AMDGPU][GFX9+] Support base+soffset+offset s_atc_probe's..
Jun 6 2022, 8:47 AM · Restricted Project, Restricted Project
kosarev updated the diff for D126791: [AMDGPU][GFX9+] Support base+soffset+offset s_atc_probe's..

Updated as suggested.

Jun 6 2022, 8:45 AM · Restricted Project, Restricted Project
kosarev committed rG79ec1e8fd630: [AMDGPU][GFX9][GFX10] Support base+soffset+offset s_dcache_discard's. (authored by kosarev).
[AMDGPU][GFX9][GFX10] Support base+soffset+offset s_dcache_discard's.
Jun 6 2022, 8:35 AM · Restricted Project, Restricted Project
kosarev closed D126766: [AMDGPU][GFX9][GFX10] Support base+soffset+offset s_dcache_discard's..
Jun 6 2022, 8:34 AM · Restricted Project, Restricted Project
kosarev updated the diff for D126766: [AMDGPU][GFX9][GFX10] Support base+soffset+offset s_dcache_discard's..

Updated as suugested.

Jun 6 2022, 8:31 AM · Restricted Project, Restricted Project

Jun 1 2022

kosarev added reviewers for D126791: [AMDGPU][GFX9+] Support base+soffset+offset s_atc_probe's.: dp, foad, arsenm, rampitec.
Jun 1 2022, 10:05 AM · Restricted Project, Restricted Project
kosarev requested review of D126791: [AMDGPU][GFX9+] Support base+soffset+offset s_atc_probe's..
Jun 1 2022, 9:50 AM · Restricted Project, Restricted Project
kosarev updated the diff for D126766: [AMDGPU][GFX9][GFX10] Support base+soffset+offset s_dcache_discard's..

Removed extra empty line.

Jun 1 2022, 3:20 AM · Restricted Project, Restricted Project
kosarev added reviewers for D126766: [AMDGPU][GFX9][GFX10] Support base+soffset+offset s_dcache_discard's.: dp, foad, arsenm, rampitec.
Jun 1 2022, 3:15 AM · Restricted Project, Restricted Project
kosarev requested review of D126766: [AMDGPU][GFX9][GFX10] Support base+soffset+offset s_dcache_discard's..
Jun 1 2022, 3:13 AM · Restricted Project, Restricted Project

May 31 2022

kosarev committed rGf199b2b00fdb: [AMDGPU][NFC] Refine defining the offset field for GFX10+ SMEM instructions. (authored by kosarev).
[AMDGPU][NFC] Refine defining the offset field for GFX10+ SMEM instructions.
May 31 2022, 1:58 AM · Restricted Project, Restricted Project
kosarev closed D126662: [AMDGPU][NFC] Refine defining the offset field for GFX10+ SMEM instructions..
May 31 2022, 1:58 AM · Restricted Project, Restricted Project

May 30 2022

kosarev added reviewers for D126662: [AMDGPU][NFC] Refine defining the offset field for GFX10+ SMEM instructions.: dp, foad, arsenm, rampitec.
May 30 2022, 9:02 AM · Restricted Project, Restricted Project
kosarev requested review of D126662: [AMDGPU][NFC] Refine defining the offset field for GFX10+ SMEM instructions..
May 30 2022, 9:00 AM · Restricted Project, Restricted Project
kosarev added a comment to D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands..

Adding more reviewers in hope someone may have a chance to take a look.

May 30 2022, 2:39 AM · Restricted Project, Restricted Project
kosarev added reviewers for D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands.: greened, dsanders, craig.topper.
May 30 2022, 2:39 AM · Restricted Project, Restricted Project
kosarev added inline comments to D126388: [AMDGPU][GFX9] Support base+soffset+offset SMEM stores..
May 30 2022, 2:35 AM · Restricted Project, Restricted Project
kosarev committed rGb4dbcba3b7b7: [AMDGPU][GFX9][NFC] Rename the base class for SMEM stores. (authored by kosarev).
[AMDGPU][GFX9][NFC] Rename the base class for SMEM stores.
May 30 2022, 2:34 AM · Restricted Project, Restricted Project
kosarev committed rG082822b381ad: [AMDGPU][GFX9] Support base+soffset+offset SMEM stores. (authored by kosarev).
[AMDGPU][GFX9] Support base+soffset+offset SMEM stores.
May 30 2022, 2:30 AM · Restricted Project, Restricted Project
kosarev closed D126388: [AMDGPU][GFX9] Support base+soffset+offset SMEM stores..
May 30 2022, 2:30 AM · Restricted Project, Restricted Project

May 26 2022

kosarev committed rGb0ccf38b0187: [AMDGPU][GFX9] Support base+soffset+offset SMEM loads. (authored by kosarev).
[AMDGPU][GFX9] Support base+soffset+offset SMEM loads.
May 26 2022, 4:46 AM · Restricted Project, Restricted Project
kosarev closed D125700: [AMDGPU][GFX9] Support base+soffset+offset SMEM loads..
May 26 2022, 4:46 AM · Restricted Project, Restricted Project
kosarev added a comment to D125604: [FileCheck] Catch missspelled directives..

Committing this revealed some more failures, fixed in rG8894c05b0d351f998b1836542ba791247394bd12.

May 26 2022, 4:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kosarev updated subscribers of rG8894c05b0d35: [FileCheck] GetCheckTypeAbbreviation() to handle the misspelled case..

Please take a look, these likely need some proper fixing. Thanks.

May 26 2022, 4:34 AM · Restricted Project, Restricted Project, Restricted Project
kosarev committed rG8894c05b0d35: [FileCheck] GetCheckTypeAbbreviation() to handle the misspelled case. (authored by kosarev).
[FileCheck] GetCheckTypeAbbreviation() to handle the misspelled case.
May 26 2022, 4:23 AM · Restricted Project, Restricted Project, Restricted Project
kosarev committed rGad1d60c3befd: [FileCheck] Catch missspelled directives. (authored by kosarev).
[FileCheck] Catch missspelled directives.
May 26 2022, 3:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kosarev closed D125604: [FileCheck] Catch missspelled directives..
May 26 2022, 3:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kosarev added inline comments to D125700: [AMDGPU][GFX9] Support base+soffset+offset SMEM loads..
May 26 2022, 12:29 AM · Restricted Project, Restricted Project
kosarev updated the diff for D125700: [AMDGPU][GFX9] Support base+soffset+offset SMEM loads..

Cleaned up the soffset field expression.

May 26 2022, 12:26 AM · Restricted Project, Restricted Project

May 25 2022

kosarev added reviewers for D126388: [AMDGPU][GFX9] Support base+soffset+offset SMEM stores.: foad, dp, arsenm, rampitec.
May 25 2022, 9:02 AM · Restricted Project, Restricted Project
kosarev requested review of D126388: [AMDGPU][GFX9] Support base+soffset+offset SMEM stores..
May 25 2022, 9:00 AM · Restricted Project, Restricted Project
kosarev committed rG046f90173567: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend. (authored by kosarev).
[TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend.
May 25 2022, 7:16 AM · Restricted Project, Restricted Project
kosarev closed D126290: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend..
May 25 2022, 7:16 AM · Restricted Project, Restricted Project
kosarev updated the diff for D125604: [FileCheck] Catch missspelled directives..

Rebased on top of fixes for non-trivial cases. Going to submit this
tomorrow, if no objections.

May 25 2022, 7:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kosarev committed rGb3c856d10cee: [MLIR][NFC] Fix the Conversion/MemRefToSPIRV/alloc.mlir test. (authored by kosarev).
[MLIR][NFC] Fix the Conversion/MemRefToSPIRV/alloc.mlir test.
May 25 2022, 6:06 AM · Restricted Project, Restricted Project
kosarev closed D126292: [MLIR][NFC] Fix the Conversion/MemRefToSPIRV/alloc.mlir test..
May 25 2022, 6:05 AM · Restricted Project, Restricted Project
kosarev updated the diff for D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands..

Right, reworked to use TableGen's PrintFatalError(). Thanks.

May 25 2022, 5:18 AM · Restricted Project, Restricted Project

May 24 2022

kosarev added inline comments to D125992: [AMDGPU] gfx11 FLAT Instructions.
May 24 2022, 9:34 AM · Restricted Project, Restricted Project
kosarev added a comment to D126290: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend..

So can this be submitted or we need a formal approval from someone else?

May 24 2022, 7:50 AM · Restricted Project, Restricted Project
kosarev committed rG1586e1dc9576: [AMDGPU][MC][GFX11] Support base+soffset+offset SMEM loads. (authored by kosarev).
[AMDGPU][MC][GFX11] Support base+soffset+offset SMEM loads.
May 24 2022, 7:16 AM · Restricted Project, Restricted Project
kosarev closed D126207: [AMDGPU][MC][GFX11] Support base+soffset+offset SMEM loads..
May 24 2022, 7:15 AM · Restricted Project, Restricted Project
kosarev updated the diff for D126207: [AMDGPU][MC][GFX11] Support base+soffset+offset SMEM loads..

Removed the _COMMON pseudos.

May 24 2022, 5:26 AM · Restricted Project, Restricted Project
kosarev added a reviewer for D126292: [MLIR][NFC] Fix the Conversion/MemRefToSPIRV/alloc.mlir test.: rriddle.
May 24 2022, 5:19 AM · Restricted Project, Restricted Project
kosarev requested review of D126292: [MLIR][NFC] Fix the Conversion/MemRefToSPIRV/alloc.mlir test..
May 24 2022, 5:19 AM · Restricted Project, Restricted Project
kosarev added inline comments to D126290: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend..
May 24 2022, 4:52 AM · Restricted Project, Restricted Project
kosarev updated the diff for D126290: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend..

Fixed spelling.

May 24 2022, 4:52 AM · Restricted Project, Restricted Project
kosarev committed rGbe4eaf10eef7: [Clang][CodeGen] Fix the cmse-clear-return.c test. (authored by kosarev).
[Clang][CodeGen] Fix the cmse-clear-return.c test.
May 24 2022, 4:50 AM · Restricted Project, Restricted Project
kosarev closed D126191: [Clang][CodeGen] Fix the cmse-clear-return.c test..
May 24 2022, 4:50 AM · Restricted Project, Restricted Project
kosarev added inline comments to D85838: New TableGen Programmer's Reference document.
May 24 2022, 4:25 AM · Restricted Project, Restricted Project
kosarev added a reviewer for D126290: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend.: Paul-C-Anagnostopoulos.
May 24 2022, 4:23 AM · Restricted Project, Restricted Project
kosarev added a comment to D126290: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend..

A follow-up from https://reviews.llvm.org/D85838#inline-1209632.

May 24 2022, 4:23 AM · Restricted Project, Restricted Project
kosarev requested review of D126290: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend..
May 24 2022, 4:22 AM · Restricted Project, Restricted Project
kosarev retitled D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands. from [TableGen] Do not crash on insufficient positional instruction operands. to [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands..
May 24 2022, 4:12 AM · Restricted Project, Restricted Project
kosarev added reviewers for D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands.: hfinkel, lattner, grosbach.
May 24 2022, 4:12 AM · Restricted Project, Restricted Project
kosarev requested review of D126288: [TableGen][CodeEmitterGen] Do not crash on insufficient positional instruction operands..
May 24 2022, 4:07 AM · Restricted Project, Restricted Project
kosarev requested review of D125700: [AMDGPU][GFX9] Support base+soffset+offset SMEM loads..

Clearing the approval as this needs another look.

May 24 2022, 1:58 AM · Restricted Project, Restricted Project