Separating the notion of an expression and an expression list seems worthwhile. I did a very high level pass but I'll take a more detailed look tomorrow.

Wed, May 18, 5:11 PM · Restricted Project, Restricted Project, Restricted Project

JDevlieghere accepted D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.

LGTM

Wed, May 18, 2:22 PM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.

Wed, May 18, 2:14 PM · Restricted Project, Restricted Project

JDevlieghere added a comment to D124731: [lldb] Consider binary as module of last resort.

Still a few places where we have a dedicated assert

Wed, May 18, 12:24 PM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D124785: [lldb/Core] Fix "sticky" long progress messages.

Wed, May 18, 12:21 PM · Restricted Project, Restricted Project

JDevlieghere accepted D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper.

LGTM

Wed, May 18, 11:54 AM · Restricted Project, Restricted Project

JDevlieghere accepted D125914: [llvm/Support] Fallback to $TERM if terminfo has no "colors" capability.

LGTM

Wed, May 18, 11:53 AM · Restricted Project, Restricted Project

Tue, May 17

JDevlieghere accepted D111791: [lldb] Add --all option to "memory region".

Minor nit but LGTM

Tue, May 17, 8:55 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 16

JDevlieghere committed rG9defb3b4b4a3: [lldb] Prevent underflow in crashlog.py (authored by JDevlieghere).

[lldb] Prevent underflow in crashlog.py

Mon, May 16, 3:00 PM · Restricted Project

JDevlieghere closed D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py.

Mon, May 16, 3:00 PM · Restricted Project, Restricted Project

JDevlieghere requested review of D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py.

Mon, May 16, 11:47 AM · Restricted Project, Restricted Project

JDevlieghere accepted D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM.

LGTM

Mon, May 16, 11:39 AM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..

Mon, May 16, 8:20 AM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM.

Mon, May 16, 8:19 AM · Restricted Project, Restricted Project

Sat, May 14

JDevlieghere committed rGae016e4f7c85: [lldb] Don't swallow crashlog exceptions (authored by JDevlieghere).

[lldb] Don't swallow crashlog exceptions

Sat, May 14, 8:59 AM · Restricted Project

JDevlieghere committed rG447c920a8adf: [lldb] Remove unused imports from crashlog.py (authored by JDevlieghere).

[lldb] Remove unused imports from crashlog.py

Sat, May 14, 8:59 AM · Restricted Project

JDevlieghere closed D125589: [lldb] Don't swallow crashlog exceptions.

Sat, May 14, 8:59 AM · Restricted Project, Restricted Project

Fri, May 13

JDevlieghere accepted D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC).

LGTM

Fri, May 13, 6:14 PM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125589: [lldb] Don't swallow crashlog exceptions.

Fri, May 13, 3:52 PM · Restricted Project, Restricted Project

JDevlieghere requested review of D125589: [lldb] Don't swallow crashlog exceptions.

Fri, May 13, 3:47 PM · Restricted Project, Restricted Project

JDevlieghere accepted D125219: [lldb][NFC] Simplify GenerateOptionUsage.

LGTM

Fri, May 13, 1:04 PM · Restricted Project, Restricted Project

JDevlieghere accepted D125218: [lldb][NFC] Make cmd a reference in GenerateOptionUsage.

LGTM

Fri, May 13, 1:03 PM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..

Fri, May 13, 1:01 PM · Restricted Project, Restricted Project

JDevlieghere accepted D125492: [DWARFLinker][NFC] cleanup AddressManager interface..

LGTM

Fri, May 13, 12:59 PM · Restricted Project, Restricted Project

JDevlieghere added a comment to D125154: [lldb] Specify aguments of `image list`.

PS: Small typo in your summary: s/abot/about/.

Fri, May 13, 12:57 PM · Restricted Project, Restricted Project

JDevlieghere closed D125107: [lldb] Parallelize fetching symbol files in crashlog.py.

a8abb695859ad4e7fe695b9ee238a2b0cd00af7c

Fri, May 13, 12:53 PM · Restricted Project

JDevlieghere committed rGa8abb695859a: [lldb] Parallelize fetching symbol files in crashlog.py (authored by JDevlieghere).

[lldb] Parallelize fetching symbol files in crashlog.py

Fri, May 13, 12:26 PM · Restricted Project

JDevlieghere added inline comments to D124731: [lldb] Consider binary as module of last resort.

Fri, May 13, 12:14 PM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.

Fri, May 13, 12:08 PM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API.

Fri, May 13, 11:50 AM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API.

Fri, May 13, 11:18 AM · Restricted Project, Restricted Project

Wed, May 11

JDevlieghere accepted D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

In D96035#3504468, @clayborg wrote:

Can we name the option something other than "--use-dlnext"? This option name won't mean much to users. Not sure what a good option name would be though but something that doesn't talk about internal classes that will be used would be better IMHO.

Wed, May 11, 3:41 AM · Restricted Project, Restricted Project

Fri, May 6

JDevlieghere added inline comments to D124785: [lldb/Core] Fix "sticky" long progress messages.

Fri, May 6, 11:41 AM · Restricted Project, Restricted Project

JDevlieghere added inline comments to D125107: [lldb] Parallelize fetching symbol files in crashlog.py.

Fri, May 6, 11:00 AM · Restricted Project

JDevlieghere updated the summary of D125107: [lldb] Parallelize fetching symbol files in crashlog.py.

Fri, May 6, 10:57 AM · Restricted Project

JDevlieghere requested review of D125107: [lldb] Parallelize fetching symbol files in crashlog.py.

Fri, May 6, 10:57 AM · Restricted Project

Thu, May 5

JDevlieghere added a reviewer for D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0: mib.

Thu, May 5, 4:55 PM · Restricted Project, Restricted Project

JDevlieghere added a comment to D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0.

Does that mean that the interactive crashlogs (crashlog -i) do this correctly?

Thu, May 5, 4:55 PM · Restricted Project, Restricted Project

JDevlieghere added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

I'm (still) very excited about this. I'm really happy that this lives behind a flag which addresses most of my original concerns. Making this the default in dsymutil would require a bunch of qualification but this approach allows me to do that gradually. One thing I suggested earlier I think was to run the lldb test suite with the new flag and see if that breaks anything. Did you ever get around to that? That should give us an initial level of confidence. Jim expressed some concerns about trying to squeeze everything in the same compilation unit. Greg, do you share that concern? Do we expect this will negatively impact lldb's performance? It would probably be worthwhile to do a few performance experiments here as well to make sure this doesn't regress debugging performance.

Thu, May 5, 4:51 PM · Restricted Project, Restricted Project

JDevlieghere added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

In D96035#3291217, @dblaikie wrote:

Does anyone cares about single thread execution time? I personally don't.

If we do not then things are easier :-)

I think @JDevlieghere and @aprantl probably care about it just from a regression perspective - but I could be wrong. (I thought they'd expressed some concerns about that in this/other reviews previously).

Apple folks ^ have you got a sense of if/how much of a single threaded regression you'd want to accept in this work, for some multithreaded gains?

Thu, May 5, 4:39 PM · Restricted Project, Restricted Project

JDevlieghere added a comment to D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..

When you used this to compare the output of dsymutil changes, what was the input binary? Does this generate meaningful output for bigger programs like dsymutil itself?

Thu, May 5, 4:29 PM · Restricted Project, Restricted Project

JDevlieghere added a comment to D124731: [lldb] Consider binary as module of last resort.

This looks reasonable to me, but I'm not sure if there's anything special about the executable module that would result in us doing the wrong thing. I'm sure Jim or Pavel will know.

Thu, May 5, 9:34 AM · Restricted Project, Restricted Project