- User Since
- Jan 31 2016, 7:15 AM (111 w, 3 d)
Re-add accidentally removed comment.
Mon, Mar 19
Hey Ilya, is this blocked by something or has this been landed already?
Unless Adrian has any more remarks, this LGTM. Thank you!
I hope the code snippet below helps clarify my original suggestion. Like I said earlier, this might be taking things a step to far and I'm not convinced whether the flexibility outweighs the added complexity.
Sun, Mar 18
Fri, Mar 16
Hi James, thanks for taking the time to come up with an alternative. I very much prefer this approach over the previous differential!
Thu, Mar 15
Wed, Mar 14
Yeah, that's more sensible indeed. I must have had llvm-lit in mind and never gave it a second thought.
Tue, Mar 13
LGTM with Adrian's comments addressed.
LGTM. Thanks Pavel!
Mon, Mar 12
Thanks for the review @labath!
Fri, Mar 9
- Added testcase.
- Followed Jim's advice to use WaitForProcessToStop.
- Should now do the right thing for all types of cores.
Thu, Mar 8
Wed, Mar 7
Thanks! I might as well do the move to Support first, rather than moving the file around twice.
Updated the diff with feedback Zachary & Dave. Thanks for the swift reviews!
I think you can be generous with the levels. I see a note more as a thing that follows a warning or an error with some more context, rather than a statement by itself.
This is looking very good. A few small comment inline but I don't expect this will need a lot of additional work.
Thanks! I was thinking a positive test would be nice but you already tackled that in the summary. LGTM!
Great catch Pavel, I can imagine this preventing quite some confusion in the future. Thanks!
Tue, Mar 6
Alright, sounds good. Thank you both for the help!
Thanks Rafael. This LGTM!
Mon, Mar 5
A few nits but otherwise this LGTM.
Thanks for the feedback everyone! I committed this in r326687.
Fri, Mar 2
- Feedback Adrian
FWIW I've been using this all day and so far it has been nothing but really convenient, even if I say so myself 🙂
Thu, Mar 1
- Full context diff
- Added default argument for Verbose
- Added comment explaining the need for strong types.