♟ JDevlieghere

Add color to the default thread and frame format.

In D62743#1544371, @davide wrote:

Can you add a screenshot of the final result for everybody?

Highlight line and column in different color

Match dwarfdump color scheme

Remove stale comment and disabled code (NFC)

Yep, we should decode all the check_output results, as they may contain unicode.

Fixed typos in Log.h

Let me know if you want me to commit this for you.

Looks like the fallout of reflowing the comments. LGTM, Thanks!

[Reproducers] Remove call to lldb_private::GetVersion()

[Reproducers] Include lldb version in the reproducer root

Rebased to use the nested Info struct instead of the typedef.

[Reproducers] Simplify providers with nested Info struct (NFC)

Have you considered making just AddExceptionPrecondition virtual? Wouldn't that solve the problem too, without the code duplication of making CreateExceptionBreakpoint virtual? Also, I think it's totally reasonable to hoist BreakpointPrecondition out of Breakpoint. After having had to deal with the nuisance of not being able to forward declare nested classes, I try to avoid them in general.

[Path] Set FD to -1 in moved-from TempFile

[dsymutil] Remove stale comment (NFC)

I saw some weird formatting, but I assume you run clang-format before landing anyway. LGTM.

+1 on making -o the canonical argument and the out-file the alias.

[dsymutil] Use the number of threads specified.

[dsymutil] Support more than 4 architectures

[FormatEntity] Ignore ASCII escape sequences when colors are disabled.

LGTM. This seems straightforward. I skipped over the YAML stuff though, as it appears to have been moved.

[SymbolFileDWARF] Remove unused member (NFC)

In D62500#1518815, @labath wrote:

Definitely go for the option of refactoring the DYLD AuxVector class to make it usable from lldb-server.

[DWARFExpression] Remove ctor that takes just a compile unit.

[DWARFExpression] Remove commented-out code (NFC)

[dwarfdump] Add flag to limit the number of parents DIEs

s/SetOpcodeData/UpdateValue/

Looks like a good change. Small comment inline but otherwise LGTM.

Add new flag -parent-recurse-depth.
Add new aliases -limit-children and -limit-parents.

[Utility] Small improvements to the Broadcaster class (NFC)

In D62359#1515107, @dblaikie wrote:

Is this the desired behavior?

Currently, I assume, searching for a particular DIE offset dumps that DIE, its parent, and all its children. (& the recursion limit is entirely ignored?)

Yup.

This patch, if I understand it, dumps from the CU to the target DIE until the recursion limit is reached. So you get some parent DIE of the one you searched for.

I would've probably thought that the entire parent chain would be dumped, and then the recursion limit would limit how deep into the children of the target DIE would be dumped.

Thoughts?

In D62337#1515041, @omjavaid wrote:

Hi

This change breaks arm/aarch64 linux builds.

http://147.75.106.138:32769/builders/lldb-aarch64-ubuntu/builds/47

JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

Recent Activity
View All

Today

Fri, Jun 14

Thu, Jun 13

Wed, Jun 12

Tue, Jun 11

Mon, Jun 10

Fri, Jun 7

Wed, Jun 5

Mon, Jun 3

Sat, Jun 1

Fri, May 31

Thu, May 30

Wed, May 29

Tue, May 28

Fri, May 24

Thu, May 23

JDevlieghere (Jonas Devlieghere)Compiler Engineer