Page MenuHomePhabricator
People JDevlieghere

JDevlieghere (Jonas Devlieghere)
Software Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (373 w, 2 d)

Recent Activity
View All

Today

JDevlieghere committed rGfda53ad9374b: [lldb] Support Universal Mach-O binaries with a fat64 header (authored by JDevlieghere).
[lldb] Support Universal Mach-O binaries with a fat64 header
Tue, Mar 28, 3:46 PM · Restricted Project
JDevlieghere closed D147012: [lldb] Support Universal Mach-O binaries with a fat64 header.
Tue, Mar 28, 3:46 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D147012: [lldb] Support Universal Mach-O binaries with a fat64 header.
Tue, Mar 28, 2:50 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D147012: [lldb] Support Universal Mach-O binaries with a fat64 header.
Tue, Mar 28, 9:24 AM · Restricted Project, Restricted Project

Yesterday

JDevlieghere committed rG568be31c9e50: [dsymutil] Initialize the debug map before loading the main binary (authored by JDevlieghere).
[dsymutil] Initialize the debug map before loading the main binary
Mon, Mar 27, 10:35 PM · Restricted Project, Restricted Project
JDevlieghere requested changes to D146880: Make git ignore core files.

Oops, meant to request changes rather than accept this.

Mon, Mar 27, 6:22 PM · Restricted Project, Restricted Project
JDevlieghere accepted D146880: Make git ignore core files.
Mon, Mar 27, 6:22 PM · Restricted Project, Restricted Project
JDevlieghere committed rG4d683f7fa7d4: [dsymutil] Add the ability to generate universal binaries with a fat64 header (authored by JDevlieghere).
[dsymutil] Add the ability to generate universal binaries with a fat64 header
Mon, Mar 27, 4:23 PM · Restricted Project, Restricted Project
JDevlieghere closed D146879: [dsymutil] Add the ability to generate universal binaries with a fat64 header.
Mon, Mar 27, 4:22 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D147012: [lldb] Support Universal Mach-O binaries with a fat64 header.
Mon, Mar 27, 4:21 PM · Restricted Project, Restricted Project
JDevlieghere accepted D147007: [lldb] Fix double free in python bindings error handling..

LGTM. I think it would be worth adding that information to the top of the file to prevent similar mistakes in the future.

Mon, Mar 27, 3:27 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D146879: [dsymutil] Add the ability to generate universal binaries with a fat64 header.
In D146879#4224622, @aprantl wrote:

I understand that auto-detection can be a double-edged sword, but — should this be autodetected based on the input size? Or this impossible because we only know the sizer after it's too late?

Mon, Mar 27, 9:23 AM · Restricted Project, Restricted Project

Sun, Mar 26

JDevlieghere added reviewers for D146918: [CMake] Don't set absolute paths as install runpaths on ELF platforms in llvm_setup_rpath(): labath, mgorny, DavidSpickett.
Sun, Mar 26, 3:54 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Mar 25

JDevlieghere updated the diff for D146879: [dsymutil] Add the ability to generate universal binaries with a fat64 header.

Limit test to Darwin as it relies on lipo

Sat, Mar 25, 1:51 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D146879: [dsymutil] Add the ability to generate universal binaries with a fat64 header.
Sat, Mar 25, 10:41 AM · Restricted Project, Restricted Project
JDevlieghere closed D146779: Fix handling of backticks in CommandObjectParsed commands.

https://reviews.llvm.org/rG75ca15fcbb2e1b3671e41f971a000c6d59f5e5ae

Sat, Mar 25, 9:52 AM · Restricted Project, Restricted Project

Fri, Mar 24

JDevlieghere committed rG0016f476ab1f: [lldb] Remove errant call to SBReproducer.SetWorkingDirectory (authored by JDevlieghere).
[lldb] Remove errant call to SBReproducer.SetWorkingDirectory
Fri, Mar 24, 5:33 PM · Restricted Project
JDevlieghere added inline comments to D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog.
Fri, Mar 24, 10:16 AM · Restricted Project, Restricted Project

Thu, Mar 23

JDevlieghere accepted D146779: Fix handling of backticks in CommandObjectParsed commands.

LGTM

Thu, Mar 23, 7:11 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names.
Thu, Mar 23, 9:13 AM · Restricted Project, Restricted Project
JDevlieghere accepted D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided.

LGTM

Thu, Mar 23, 8:43 AM · Restricted Project, Restricted Project

Wed, Mar 22

JDevlieghere added inline comments to D143852: [docs] Add Python coding standard to documentation.
Wed, Mar 22, 4:13 PM · Restricted Project, Restricted Project

Tue, Mar 21

JDevlieghere accepted D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs.

LGTM

Tue, Mar 21, 12:17 PM · Restricted Project, Restricted Project
JDevlieghere accepted D145568: [lldb] Add dummy field to RegisterInfo for register flags use later.

LGTM

Tue, Mar 21, 9:35 AM · Restricted Project, Restricted Project
JDevlieghere accepted D145566: [lldb] Add RegisterFlags class.

LGTM

Tue, Mar 21, 9:33 AM · Restricted Project, Restricted Project
JDevlieghere accepted D145574: [lldb] Read register fields from target XML.
Tue, Mar 21, 9:32 AM · Restricted Project, Restricted Project

Mon, Mar 20

JDevlieghere accepted D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery".

LGTM (see https://github.com/llvm/llvm-project/issues/60314)

Mon, Mar 20, 6:43 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs.

Can we do something similar for plugins?

Mon, Mar 20, 6:37 PM · Restricted Project, Restricted Project
JDevlieghere accepted D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs.

LGTM

Mon, Mar 20, 6:36 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145574: [lldb] Read register fields from target XML.
Mon, Mar 20, 2:07 PM · Restricted Project, Restricted Project
JDevlieghere added a reviewer for D145580: [lldb] Show register fields using bitfield struct types: bulbazord.
Mon, Mar 20, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
JDevlieghere updated subscribers of D145580: [lldb] Show register fields using bitfield struct types.
Mon, Mar 20, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
JDevlieghere added inline comments to D145568: [lldb] Add dummy field to RegisterInfo for register flags use later.
Mon, Mar 20, 1:59 PM · Restricted Project, Restricted Project
JDevlieghere accepted D145566: [lldb] Add RegisterFlags class.

LGTM modulo comments

Mon, Mar 20, 1:58 PM · Restricted Project, Restricted Project
JDevlieghere accepted D146263: [lldb] Move UnixSignals creation into Platform plugins.

We're only using the OS part of the triple/ArchSpec so there should be a 1:1 mapping with the platform. I don't see any issue with this. LGTM.

Mon, Mar 20, 12:44 PM · Restricted Project, Restricted Project
JDevlieghere committed rGe4f62da8129d: [lldb] Sidestep -Wformat warning by using LLDB_LOG instead of LLDB_LOGF (authored by JDevlieghere).
[lldb] Sidestep -Wformat warning by using LLDB_LOG instead of LLDB_LOGF
Mon, Mar 20, 10:32 AM · Restricted Project

Fri, Mar 17

JDevlieghere accepted D146337: Partially fix stepping over watchpoints on "watch triggers before" systems.

LGTM

Fri, Mar 17, 6:02 PM · Restricted Project, Restricted Project
JDevlieghere accepted D146335: [lldb] Introduce CMake variable LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS.

Thanks, this is great. LGTM.

Fri, Mar 17, 5:52 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Fri, Mar 17, 10:31 AM · Restricted Project, Restricted Project
JDevlieghere committed rG147b60964064: [lldb] Unify WatchpointSP variable names (NFC) (authored by JDevlieghere).
[lldb] Unify WatchpointSP variable names (NFC)
Fri, Mar 17, 10:10 AM · Restricted Project
JDevlieghere committed rG2a7642977876: [lldb] Set the watchpoint spec for expression watchpoints (authored by JDevlieghere).
[lldb] Set the watchpoint spec for expression watchpoints
Fri, Mar 17, 9:56 AM · Restricted Project
JDevlieghere closed D146262: [lldb] Set the watchpoint spec for expression watchpoints.
Fri, Mar 17, 9:56 AM · Restricted Project, Restricted Project

Thu, Mar 16

JDevlieghere updated the summary of D146262: [lldb] Set the watchpoint spec for expression watchpoints.
Thu, Mar 16, 2:40 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D146262: [lldb] Set the watchpoint spec for expression watchpoints.
Thu, Mar 16, 2:40 PM · Restricted Project, Restricted Project
JDevlieghere accepted D146230: [lldb][test] Replace use of p with expression in Shell tests (NFC).

LGTM. I probably would've gone with expo but as expression is the canonical name of the command, this makes sense.

Thu, Mar 16, 10:26 AM · Restricted Project, Restricted Project

Wed, Mar 15

JDevlieghere accepted D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption.

LGTM

Wed, Mar 15, 4:43 PM · Restricted Project, Restricted Project
JDevlieghere committed rG9dbce774eea5: [lldb] Update PythonDataObjectsTests for new exception formatting (authored by JDevlieghere).
[lldb] Update PythonDataObjectsTests for new exception formatting
Wed, Mar 15, 3:53 PM · Restricted Project
JDevlieghere added inline comments to D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption.
Wed, Mar 15, 11:45 AM · Restricted Project, Restricted Project
JDevlieghere accepted D132455: [ADT] add ConcurrentHashtable class..
In D132455#4106255, @avl wrote:

ping.

@JDevlieghere @aprantl Do you think it is better to move this ConcurrentHashtable into the DWARFLinkerParallel folder?

Wed, Mar 15, 11:38 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target.

Thanks for adding this, Jim. This is one of those things that comes up one in a while when it confuses our users. It's great we'll be able to help them adopt this.

Wed, Mar 15, 10:25 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption.
Wed, Mar 15, 10:14 AM · Restricted Project, Restricted Project

Tue, Mar 14

JDevlieghere accepted D145680: [DWARFLinker][DWARFv5] Support debug_loclists..

LGTM modulo some nits in the comments.

Tue, Mar 14, 9:39 PM · Restricted Project, Restricted Project
JDevlieghere accepted D140791: [DWARFLinkerParallel] Add simple list with thread safe insertions..

LGTM

Tue, Mar 14, 9:34 PM · Restricted Project, Restricted Project
JDevlieghere accepted D140788: [DWARFLinkerParallel] add AddressesMap interface..

LGMT with some wordsmithing

Tue, Mar 14, 9:33 PM · Restricted Project, Restricted Project
JDevlieghere accepted D146045: [LLDB] Show sub type of signals when debugging a core file.

Nice. LGTM.

Tue, Mar 14, 8:57 PM · Restricted Project, Restricted Project, Restricted Project
JDevlieghere accepted D146043: [lldb] Refactor CrashReason.

LGTM

Tue, Mar 14, 11:08 AM · Restricted Project, Restricted Project
JDevlieghere accepted D146044: [lldb] Implement CrashReason using UnixSignals.

LGTM with Pavel's comments.

Tue, Mar 14, 11:07 AM · Restricted Project, Restricted Project

Mon, Mar 13

JDevlieghere accepted D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method.

LGTM

Mon, Mar 13, 5:37 PM · Restricted Project, Restricted Project
JDevlieghere accepted D142260: Actually report an error when `command script add` is passed a non-existent class.

LGTM modulo the else-after-return.

Mon, Mar 13, 4:49 PM · Restricted Project, Restricted Project
JDevlieghere accepted D145624: [lldb] Make MemoryCache::Read more resilient.

LGTM if @clayborg is happy

Mon, Mar 13, 4:44 PM · Restricted Project, Restricted Project
JDevlieghere accepted D145295: [lldb] Move ScriptedProcess private state update to implementation.

LGTM

Mon, Mar 13, 4:41 PM · Restricted Project, Restricted Project
JDevlieghere committed rG9c972a3d82f3: [lldb] Explicitly import json in TestSymbolFileJSON.py (authored by JDevlieghere).
[lldb] Explicitly import json in TestSymbolFileJSON.py
Mon, Mar 13, 2:48 PM · Restricted Project

Thu, Mar 9

JDevlieghere committed rG7c4e6c97fb68: [lldb] Skip TestSymbolFileJSON on Windows (authored by JDevlieghere).
[lldb] Skip TestSymbolFileJSON on Windows
Thu, Mar 9, 11:33 AM · Restricted Project
JDevlieghere committed rGe67460c974e6: [lldb] Add nullptr check to SymbolVendorWasm (authored by JDevlieghere).
[lldb] Add nullptr check to SymbolVendorWasm
Thu, Mar 9, 10:27 AM · Restricted Project
JDevlieghere committed rG244a6acff0b8: [dsymutil] Fix offset calculation for universal binaries (authored by JDevlieghere).
[dsymutil] Fix offset calculation for universal binaries
Thu, Mar 9, 10:27 AM · Restricted Project, Restricted Project
JDevlieghere closed D145637: [dsymutil] Fix offset calculation for fat binaries.
Thu, Mar 9, 10:27 AM · Restricted Project, Restricted Project

Wed, Mar 8

JDevlieghere committed rGf009241ae595: [lldb] Fix -Wdangling-else warning in CommunicationTest (authored by JDevlieghere).
[lldb] Fix -Wdangling-else warning in CommunicationTest
Wed, Mar 8, 10:25 PM · Restricted Project
JDevlieghere committed rG73058e330134: [lldb] Fix typo in SymbolVendorELF (authored by JDevlieghere).
[lldb] Fix typo in SymbolVendorELF
Wed, Mar 8, 10:16 PM · Restricted Project
JDevlieghere committed rG12f709db0d0e: lldb] Re-enable TestSymbolFileJSON on non Darwin platforms (authored by JDevlieghere).
lldb] Re-enable TestSymbolFileJSON on non Darwin platforms
Wed, Mar 8, 10:13 PM · Restricted Project
JDevlieghere committed rG15653dcb62df: [lldb] Temporarily disable TestSymbolFileJSON on non Darwin platforms (authored by JDevlieghere).
[lldb] Temporarily disable TestSymbolFileJSON on non Darwin platforms
Wed, Mar 8, 9:33 PM · Restricted Project
JDevlieghere committed rGcf3524a5746f: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON (authored by JDevlieghere).
[lldb] Introduce new SymbolFileJSON and ObjectFileJSON
Wed, Mar 8, 8:56 PM · Restricted Project
JDevlieghere closed D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Wed, Mar 8, 8:56 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D145637: [dsymutil] Fix offset calculation for fat binaries.
Wed, Mar 8, 6:20 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Wed, Mar 8, 5:10 PM · Restricted Project, Restricted Project
JDevlieghere accepted D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated.

Some code style nits but the change itself LGTM.

Wed, Mar 8, 4:28 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145624: [lldb] Make MemoryCache::Read more resilient.
Wed, Mar 8, 4:17 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Wed, Mar 8, 3:36 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Wed, Mar 8, 3:36 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
  • Add unit tests for JSON deserialization
  • Add unit tests for converting JSONSymbol to Symbol
Wed, Mar 8, 10:09 AM · Restricted Project, Restricted Project

Tue, Mar 7

JDevlieghere committed rG9d311dd6a71b: [lldb] Copy log files into diagnostic directory (authored by JDevlieghere).
[lldb] Copy log files into diagnostic directory
Tue, Mar 7, 4:01 PM · Restricted Project
JDevlieghere closed D135631: [lldb] Copy log files into diagnostic directory .
Tue, Mar 7, 4:00 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
  • Remove section field
  • Support raw value symbols
  • Update test
Tue, Mar 7, 3:16 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Tue, Mar 7, 3:04 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Tue, Mar 7, 2:51 PM · Restricted Project, Restricted Project

Mon, Mar 6

JDevlieghere updated the diff for D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.

Implement Greg's features. I'll add a unit test for the deserialization later today.

Mon, Mar 6, 4:25 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Mon, Mar 6, 3:13 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Mon, Mar 6, 2:47 PM · Restricted Project, Restricted Project

Fri, Mar 3

JDevlieghere updated the diff for D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.

Address Greg's feedback

Fri, Mar 3, 6:15 PM · Restricted Project, Restricted Project
JDevlieghere accepted D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess.

LGTM

Fri, Mar 3, 5:09 PM · Restricted Project, Restricted Project
JDevlieghere accepted D139945: [lldb] Add scripted process launch/attach option to {,platform }process commands.

LGTM modulo inline comments.

Fri, Mar 3, 5:09 PM · Restricted Project, Restricted Project
JDevlieghere accepted D145260: [lldb/swig] Fix ref counting issue in SBProcess::GetScriptedImplementation.

LGTM. Can we turn that crash into a small test case?

Fri, Mar 3, 12:00 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.

Thanks for the feedback Greg, they're all great suggestions.

Fri, Mar 3, 11:01 AM · Restricted Project, Restricted Project

Thu, Mar 2

JDevlieghere added a comment to D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery".

This will break the Xcode build again. It's being discussed here: https://github.com/llvm/llvm-project/issues/60314

Thu, Mar 2, 3:01 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Thu, Mar 2, 2:26 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON.
Thu, Mar 2, 12:57 PM · Restricted Project, Restricted Project

Tue, Feb 28

JDevlieghere accepted D144937: [LLDB] Expose several methods in SBWatchpoint.

LGTM with two small nits.

Tue, Feb 28, 9:29 PM · Restricted Project, Restricted Project
JDevlieghere accepted D145020: Hoist debugserver arch-dep sources out of a side CMakeLists into the debugserver main CMakeLists.

LGTM

Tue, Feb 28, 4:53 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D140791: [DWARFLinkerParallel] Add simple list with thread safe insertions..

The implementation looks good. I left some inline comments with suggestions for names that more closely match that of the STL containers to make the class feel more familiar to those who are used to them.

Tue, Feb 28, 4:50 PM · Restricted Project, Restricted Project
JDevlieghere requested changes to D144937: [LLDB] Expose several methods in SBWatchpoint.
Tue, Feb 28, 12:49 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D144688: [lldb] Fix {break,watch}point command function stopping behaviour.

You're passing is_callback by value so the const is close to redundant. I think there's an "Effective C++" chapter dedicated to this. LLVM is pretty conservative in marking this as const and while LLDB uses it a bit more this isn't common at all. The current code now makes you wonder why this is different than has_extra_args. Even if that does get modified in some of the function's implementation, that's an implementation detail that shouldn't be exposed through the interface.

Tue, Feb 28, 12:43 PM · Restricted Project, Restricted Project