Page MenuHomePhabricator
People JDevlieghere

JDevlieghere (Jonas Devlieghere)
Software Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (194 w, 1 d)

Recent Activity
View All

Today

JDevlieghere committed rG3434472ed741: XFAIL TestLocalVariables.py on Windows (authored by JDevlieghere).
XFAIL TestLocalVariables.py on Windows
Mon, Oct 21, 3:19 PM
JDevlieghere committed rL375459: XFAIL TestLocalVariables.py on Windows.
XFAIL TestLocalVariables.py on Windows
Mon, Oct 21, 3:19 PM
JDevlieghere added inline comments to D69141: [Remarks] Add support for linking remarks.
Mon, Oct 21, 1:36 PM · Restricted Project
JDevlieghere accepted D69213: Avoid appending the source directory to an absolute path.

LGTM modulo the comment.

Mon, Oct 21, 9:20 AM · Restricted Project, debug-info
JDevlieghere added inline comments to D69213: Avoid appending the source directory to an absolute path.
Mon, Oct 21, 9:20 AM · Restricted Project, debug-info

Fri, Oct 18

JDevlieghere committed rG06a2beae92f5: [Reproducer] XFAIL TestWorkingDir on Windows (authored by JDevlieghere).
[Reproducer] XFAIL TestWorkingDir on Windows
Fri, Oct 18, 3:18 PM
JDevlieghere committed rL375294: [Reproducer] XFAIL TestWorkingDir on Windows.
[Reproducer] XFAIL TestWorkingDir on Windows
Fri, Oct 18, 3:18 PM
JDevlieghere committed rG64b7d9556860: [Reproducer] Improve reproducer help (NFC) (authored by JDevlieghere).
[Reproducer] Improve reproducer help (NFC)
Fri, Oct 18, 2:50 PM
JDevlieghere committed rL375292: [Reproducer] Improve reproducer help (NFC).
[Reproducer] Improve reproducer help (NFC)
Fri, Oct 18, 2:50 PM
JDevlieghere committed rGded44e220f6c: [Reproducer] Use ::rtrim() to remove trailing control characters. (authored by JDevlieghere).
[Reproducer] Use ::rtrim() to remove trailing control characters.
Fri, Oct 18, 10:12 AM
JDevlieghere committed rL375259: [Reproducer] Use ::rtrim() to remove trailing control characters..
[Reproducer] Use ::rtrim() to remove trailing control characters.
Fri, Oct 18, 10:11 AM
JDevlieghere accepted D69148: Disable exit-on-SIGPIPE in lldb.

Thanks for fixing this, Vedant!

Fri, Oct 18, 8:38 AM · Restricted Project, Restricted Project

Thu, Oct 17

JDevlieghere committed rGa0f6c6434cc4: [test] Add a .clang-format file for the shell test. (authored by JDevlieghere).
[test] Add a .clang-format file for the shell test.
Thu, Oct 17, 2:28 PM
JDevlieghere closed D69058: [test] Add a .clang-format file for the shell test. .
Thu, Oct 17, 2:27 PM · Restricted Project
JDevlieghere committed rL375172: [test] Add a .clang-format file for the shell test..
[test] Add a .clang-format file for the shell test.
Thu, Oct 17, 2:27 PM
JDevlieghere committed rG2b7899b730b7: [Reproducer] Surface error if setting the cwd fails (authored by JDevlieghere).
[Reproducer] Surface error if setting the cwd fails
Thu, Oct 17, 11:02 AM
JDevlieghere committed rL375146: [Reproducer] Surface error if setting the cwd fails.
[Reproducer] Surface error if setting the cwd fails
Thu, Oct 17, 11:02 AM
JDevlieghere accepted D69119: Modernize the rest of the Find.* API (NFC).
Thu, Oct 17, 11:02 AM · Restricted Project

Wed, Oct 16

JDevlieghere committed rGeb1bbcec08d2: [CMake] Make it possible to set the RPATH in add_lldb_exectable. (authored by JDevlieghere).
[CMake] Make it possible to set the RPATH in add_lldb_exectable.
Wed, Oct 16, 5:49 PM
JDevlieghere committed rL375068: [CMake] Make it possible to set the RPATH in add_lldb_exectable..
[CMake] Make it possible to set the RPATH in add_lldb_exectable.
Wed, Oct 16, 5:49 PM
JDevlieghere committed rGf80f15e38a21: [Reproducer] Set the working directory in the VFS (authored by JDevlieghere).
[Reproducer] Set the working directory in the VFS
Wed, Oct 16, 5:25 PM
JDevlieghere committed rL375064: [Reproducer] Set the working directory in the VFS.
[Reproducer] Set the working directory in the VFS
Wed, Oct 16, 5:24 PM
JDevlieghere committed rGf4f120125ead: [Reproducer] Support dumping the reproducer CWD (authored by JDevlieghere).
[Reproducer] Support dumping the reproducer CWD
Wed, Oct 16, 5:02 PM
JDevlieghere committed rGb2575da9aa3f: [Reproducer] Add LoadBuffer<> helper (NFC) (authored by JDevlieghere).
[Reproducer] Add LoadBuffer<> helper (NFC)
Wed, Oct 16, 5:02 PM
JDevlieghere committed rG27ef81cd484b: [Reproducer] Capture the debugger's working directory (authored by JDevlieghere).
[Reproducer] Capture the debugger's working directory
Wed, Oct 16, 5:02 PM
JDevlieghere committed rL375061: [Reproducer] Support dumping the reproducer CWD.
[Reproducer] Support dumping the reproducer CWD
Wed, Oct 16, 5:01 PM
JDevlieghere committed rL375060: [Reproducer] Add LoadBuffer<> helper (NFC).
[Reproducer] Add LoadBuffer<> helper (NFC)
Wed, Oct 16, 5:01 PM
JDevlieghere committed rL375059: [Reproducer] Capture the debugger's working directory.
[Reproducer] Capture the debugger's working directory
Wed, Oct 16, 5:01 PM
JDevlieghere committed rG8cdc842c5162: [dsymutil] Print warning/error for unknown/missing arguments. (authored by JDevlieghere).
[dsymutil] Print warning/error for unknown/missing arguments.
Wed, Oct 16, 2:49 PM
JDevlieghere committed rL375044: [dsymutil] Print warning/error for unknown/missing arguments..
[dsymutil] Print warning/error for unknown/missing arguments.
Wed, Oct 16, 2:48 PM
JDevlieghere created D69058: [test] Add a .clang-format file for the shell test. .
Wed, Oct 16, 11:05 AM · Restricted Project
JDevlieghere added a comment to D68872: SBCommandReturnObject: change LLDB_RECORD_METHOD(..., FILE *, ...) to use LLDB_RECORD_DUMMY.

Somehow I missed this in my review queue.

Wed, Oct 16, 10:28 AM · Restricted Project
JDevlieghere accepted D68872: SBCommandReturnObject: change LLDB_RECORD_METHOD(..., FILE *, ...) to use LLDB_RECORD_DUMMY.
Wed, Oct 16, 10:28 AM · Restricted Project

Tue, Oct 15

JDevlieghere committed rG20c692a44555: [dsymutil] Support and relocate base address selection entries for debug_loc (authored by JDevlieghere).
[dsymutil] Support and relocate base address selection entries for debug_loc
Tue, Oct 15, 4:50 PM
JDevlieghere closed D69005: [dsymutil] Support and relocate base address selection entries for debug_loc.
Tue, Oct 15, 4:50 PM · Restricted Project
JDevlieghere committed rL374957: [dsymutil] Support and relocate base address selection entries for debug_loc.
[dsymutil] Support and relocate base address selection entries for debug_loc
Tue, Oct 15, 4:41 PM
JDevlieghere committed rG21703543a77d: [Reland][VirtualFileSystem] Support virtual working directory in the… (authored by JDevlieghere).
[Reland][VirtualFileSystem] Support virtual working directory in the…
Tue, Oct 15, 4:14 PM
JDevlieghere committed rL374955: [Reland][VirtualFileSystem] Support virtual working directory in the….
[Reland][VirtualFileSystem] Support virtual working directory in the…
Tue, Oct 15, 4:13 PM
JDevlieghere created D69005: [dsymutil] Support and relocate base address selection entries for debug_loc.
Tue, Oct 15, 1:55 PM · Restricted Project
JDevlieghere committed rG409b4b5fb39e: Revert "[VirtualFileSystem] Support virtual working directory in the… (authored by JDevlieghere).
Revert "[VirtualFileSystem] Support virtual working directory in the…
Tue, Oct 15, 11:36 AM
JDevlieghere committed rL374935: Revert "[VirtualFileSystem] Support virtual working directory in the….
Revert "[VirtualFileSystem] Support virtual working directory in the…
Tue, Oct 15, 11:36 AM
JDevlieghere committed rG621ce3790ba2: [test] Update YAML mapping in VirtualFileSystemTest (authored by JDevlieghere).
[test] Update YAML mapping in VirtualFileSystemTest
Tue, Oct 15, 11:08 AM
JDevlieghere committed rL374930: [test] Update YAML mapping in VirtualFileSystemTest.
[test] Update YAML mapping in VirtualFileSystemTest
Tue, Oct 15, 11:08 AM
JDevlieghere committed rG0b9981b180ef: [VirtualFileSystem] Support virtual working directory in the RedirectingFS (authored by JDevlieghere).
[VirtualFileSystem] Support virtual working directory in the RedirectingFS
Tue, Oct 15, 10:20 AM
JDevlieghere closed D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..
Tue, Oct 15, 10:20 AM · Restricted Project, Restricted Project
JDevlieghere committed rL374917: [VirtualFileSystem] Support virtual working directory in the RedirectingFS.
[VirtualFileSystem] Support virtual working directory in the RedirectingFS
Tue, Oct 15, 10:20 AM

Mon, Oct 14

JDevlieghere added a comment to D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

ping @sammccall

Mon, Oct 14, 4:40 PM · Restricted Project, Restricted Project
JDevlieghere accepted D68868: Fix build under musl.

Given that the FILE struct lives in stdio.h this makes sense.

Mon, Oct 14, 10:06 AM · Restricted Project
JDevlieghere accepted D68918: eliminate virtual methods from PythonDataObjects.
Mon, Oct 14, 9:38 AM · Restricted Project

Thu, Oct 10

JDevlieghere committed rGb9e518d3c69c: [test] Reduce inconsistency between lit configuration files. (authored by JDevlieghere).
[test] Reduce inconsistency between lit configuration files.
Thu, Oct 10, 2:53 PM
JDevlieghere committed rG6cff8648cc84: [Make] Remove spurious line break (authored by JDevlieghere).
[Make] Remove spurious line break
Thu, Oct 10, 2:53 PM
JDevlieghere committed rL374462: [Make] Remove spurious line break.
[Make] Remove spurious line break
Thu, Oct 10, 2:53 PM
JDevlieghere committed rL374461: [test] Reduce inconsistency between lit configuration files..
[test] Reduce inconsistency between lit configuration files.
Thu, Oct 10, 2:53 PM
JDevlieghere committed rG0a186d0f64b6: [test] Add timeout to API tests. (authored by JDevlieghere).
[test] Add timeout to API tests.
Thu, Oct 10, 12:57 PM
JDevlieghere committed rG7cc1fac8c9a1: [test] Cleanup top-level lit.cfg.py (authored by JDevlieghere).
[test] Cleanup top-level lit.cfg.py
Thu, Oct 10, 12:57 PM
JDevlieghere committed rL374435: [test] Add timeout to API tests..
[test] Add timeout to API tests.
Thu, Oct 10, 12:49 PM
JDevlieghere committed rL374434: [test] Cleanup top-level lit.cfg.py.
[test] Cleanup top-level lit.cfg.py
Thu, Oct 10, 12:49 PM
JDevlieghere committed rGff5640caea90: [Docs] Update testing documentaton (authored by JDevlieghere).
[Docs] Update testing documentaton
Thu, Oct 10, 12:37 PM
JDevlieghere committed rL374430: [Docs] Update testing documentaton.
[Docs] Update testing documentaton
Thu, Oct 10, 12:37 PM
JDevlieghere added inline comments to D68678: Speed up accelerator table lookups.
Thu, Oct 10, 10:42 AM · Restricted Project
JDevlieghere committed rG27c23653aec7: [test] Use a different module cache for Shell and API tests. (authored by JDevlieghere).
[test] Use a different module cache for Shell and API tests.
Thu, Oct 10, 10:33 AM
JDevlieghere committed rG2d2cf936ac6c: [test] Pass DSYMUTIL and SDKROOT as part of the Make invocation. (authored by JDevlieghere).
[test] Pass DSYMUTIL and SDKROOT as part of the Make invocation.
Thu, Oct 10, 10:32 AM
JDevlieghere closed D68755: [test] Use a different module cache for Shell and API tests..
Thu, Oct 10, 10:32 AM · Restricted Project
JDevlieghere closed D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation..
Thu, Oct 10, 10:32 AM · Restricted Project
JDevlieghere committed rL374386: [test] Use a different module cache for Shell and API tests..
[test] Use a different module cache for Shell and API tests.
Thu, Oct 10, 10:25 AM
JDevlieghere committed rL374385: [test] Pass DSYMUTIL and SDKROOT as part of the Make invocation..
[test] Pass DSYMUTIL and SDKROOT as part of the Make invocation.
Thu, Oct 10, 10:25 AM
JDevlieghere added a comment to D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation..
In D68812#1704235, @clayborg wrote:

It would be great if we could ensure that if a test fails, that the "dotest" command line text has everything it needs as well, including the options and paths to lldb, framework, shared library and other settings. If I "ninja check-lldb", I have to manually insert many arguments before the command the FAIL file says to run will work.

Thu, Oct 10, 10:15 AM · Restricted Project
JDevlieghere committed rG5c5184be7400: [test] Trim the symbtab test case (NFC) (authored by JDevlieghere).
[test] Trim the symbtab test case (NFC)
Thu, Oct 10, 10:13 AM
JDevlieghere committed rL374382: [test] Trim the symbtab test case (NFC).
[test] Trim the symbtab test case (NFC)
Thu, Oct 10, 10:13 AM
JDevlieghere updated the diff for D68755: [test] Use a different module cache for Shell and API tests..
  • Rebased on top of D68812.
  • Pass the module cache on the command line.
Thu, Oct 10, 9:54 AM · Restricted Project
JDevlieghere added inline comments to D68755: [test] Use a different module cache for Shell and API tests..
Thu, Oct 10, 9:45 AM · Restricted Project
JDevlieghere created D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation..
Thu, Oct 10, 9:45 AM · Restricted Project
JDevlieghere committed rG644abcf09d6b: [dsymutil] Move CommonSymbols.clear() in resetParserState. (authored by JDevlieghere).
[dsymutil] Move CommonSymbols.clear() in resetParserState.
Thu, Oct 10, 9:36 AM
JDevlieghere committed rL374378: [dsymutil] Move CommonSymbols.clear() in resetParserState..
[dsymutil] Move CommonSymbols.clear() in resetParserState.
Thu, Oct 10, 9:36 AM

Wed, Oct 9

JDevlieghere created D68755: [test] Use a different module cache for Shell and API tests..
Wed, Oct 9, 6:22 PM · Restricted Project
JDevlieghere added inline comments to D68755: [test] Use a different module cache for Shell and API tests..
Wed, Oct 9, 6:22 PM · Restricted Project
JDevlieghere added a reviewer for D68755: [test] Use a different module cache for Shell and API tests.: friss.
Wed, Oct 9, 6:22 PM · Restricted Project
JDevlieghere accepted D68731: Remove CC autodetection from Makefile.rules.
Wed, Oct 9, 5:26 PM · Restricted Project
JDevlieghere committed rGf204914feea4: [CMake] Use the correct lit.cfg.py (authored by JDevlieghere).
[CMake] Use the correct lit.cfg.py
Wed, Oct 9, 3:14 PM
JDevlieghere committed rL374244: [CMake] Use the correct lit.cfg.py.
[CMake] Use the correct lit.cfg.py
Wed, Oct 9, 3:14 PM
JDevlieghere committed rG865cd0932f44: [Reproducer] Add convenience methods IsCapturing and IsReplaying. (authored by JDevlieghere).
[Reproducer] Add convenience methods IsCapturing and IsReplaying.
Wed, Oct 9, 2:53 PM
JDevlieghere committed rL374236: [Reproducer] Add convenience methods IsCapturing and IsReplaying..
[Reproducer] Add convenience methods IsCapturing and IsReplaying.
Wed, Oct 9, 2:52 PM
JDevlieghere committed rG988ad4194848: [LLDB] Remove standalone build dep on llvm-strip (authored by JDevlieghere).
[LLDB] Remove standalone build dep on llvm-strip
Wed, Oct 9, 2:07 PM
JDevlieghere committed rL374229: [LLDB] Remove standalone build dep on llvm-strip.
[LLDB] Remove standalone build dep on llvm-strip
Wed, Oct 9, 2:07 PM
JDevlieghere closed D68614: [LLDB] Remove standalone build dep on llvm-strip.
Wed, Oct 9, 2:07 PM · Restricted Project
JDevlieghere added inline comments to D68678: Speed up accelerator table lookups.
Wed, Oct 9, 2:02 PM · Restricted Project
JDevlieghere committed rGd61ef7c46d11: [CMake] Fix add_lldb_test_dependency (authored by JDevlieghere).
[CMake] Fix add_lldb_test_dependency
Wed, Oct 9, 1:38 PM
JDevlieghere committed rL374216: [CMake] Fix add_lldb_test_dependency.
[CMake] Fix add_lldb_test_dependency
Wed, Oct 9, 1:38 PM
JDevlieghere committed rGbe1c2902265e: [utils] Update lldb-dotest for new test layout (authored by JDevlieghere).
[utils] Update lldb-dotest for new test layout
Wed, Oct 9, 1:32 PM
JDevlieghere committed rL374215: [utils] Update lldb-dotest for new test layout.
[utils] Update lldb-dotest for new test layout
Wed, Oct 9, 1:28 PM
JDevlieghere committed rL374201: Re-land "[test] Split LLDB tests into API, Shell & Unit".
Re-land "[test] Split LLDB tests into API, Shell & Unit"
Wed, Oct 9, 12:25 PM
JDevlieghere committed rG87aa9c9e4d41: Re-land "[test] Split LLDB tests into API, Shell & Unit" (authored by JDevlieghere).
Re-land "[test] Split LLDB tests into API, Shell & Unit"
Wed, Oct 9, 12:23 PM
JDevlieghere committed rL374184: [test] Split LLDB tests into API, Shell & Unit.
[test] Split LLDB tests into API, Shell & Unit
Wed, Oct 9, 9:43 AM
JDevlieghere committed rG22314179f066: [test] Split LLDB tests into API, Shell & Unit (authored by JDevlieghere).
[test] Split LLDB tests into API, Shell & Unit
Wed, Oct 9, 9:41 AM
JDevlieghere closed D68606: [test] Split LLDB tests into filecheck, unittest and dotest..
Wed, Oct 9, 9:41 AM · Restricted Project
JDevlieghere committed rGe7affcdbd2ee: Re-land "[dsymutil] Fix handling of common symbols in multiple object files." (authored by JDevlieghere).
Re-land "[dsymutil] Fix handling of common symbols in multiple object files."
Wed, Oct 9, 9:22 AM
JDevlieghere committed rL374178: Re-land "[dsymutil] Fix handling of common symbols in multiple object files.".
Re-land "[dsymutil] Fix handling of common symbols in multiple object files."
Wed, Oct 9, 9:21 AM
JDevlieghere updated the diff for D68606: [test] Split LLDB tests into filecheck, unittest and dotest..

Rename lit to test to decrease the number of renames in the git history.

Wed, Oct 9, 9:03 AM · Restricted Project

Tue, Oct 8

JDevlieghere committed rG4ac388f7cacc: [dsymutil] Fix handling of common symbols in multiple object files. (authored by JDevlieghere).
[dsymutil] Fix handling of common symbols in multiple object files.
Tue, Oct 8, 9:19 PM
JDevlieghere closed D68680: [dsymutil] Fix handling of common symbols in multiple object files..
Tue, Oct 8, 9:19 PM · Restricted Project