- User Since
- Jan 31 2016, 7:15 AM (85 w, 5 d)
- Add comment which explains the zero offset.
Thu, Sep 21
- Remove regex for whitespace
Wed, Sep 20
Thanks David, I appreciate your feedback!
- Remove relative path in test.
- Address review comments from Fred and David.
- Convert test to YAML with instruction on how to reproduce the binary.
Tue, Sep 19
- Upload the correct patch (Thanks Adrian!)
- Moved printing outside switch.
- Un-verbosed test cases.
Mon, Sep 18
Thanks Dave, I've updated the diff with your feedback.
Fri, Sep 15
Thu, Sep 14
Thanks! I've updated the diff and description to make .eh_frame an alias for .debug_frame.
Wed, Sep 13
Add support and test case for nested functions, which should not be contained by their parent.
Tue, Sep 12
Changing the default value uncovered some bugs related to the DIDumpOptions not being properly propagated.
Thanks Dave! There's no logic that deals specifically with nested functions, so I don't think it'll handle this particular case. Before hacking this in, I think it might be good to obtain a real example rather than an artificial one, to ensure we don't make the verification broader than necessary.
Mon, Sep 11
Abandoning in favor of D37696
Fri, Sep 8
Thu, Sep 7
Wed, Sep 6
Use assert instead of unreachable.
Tue, Sep 5
Thanks George, this has been very helpful!
Thanks! I've updated the diff to include the section name.
Mon, Sep 4
Thanks for the review Adrian!
Fri, Sep 1
Thu, Aug 31
David, apologies for missing your e-mail. I really hate that it doesn't automatically show up in Phabricator! 🙁
David: Do you want to discuss this further or is this okay to land as is?
Improved test as suggested by @dblaikie
@dblaikie: I've added the positive tests you mentioned in D36835 as I was changing the file anyway. I also like the idea of omitting the prefixes in brief mode, but that's definitely something for a separate differential.
Thanks @friss, I've updated the diff with your feedback.
Tue, Aug 29
- Feedback David
Thu, Aug 24
Thanks for the review @aprantl! About the comment for the Incomplete member: can this strictly occur for members or has this a broader scope?