Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (176 w, 1 d)

Recent Activity

Today

JDevlieghere committed rGf9626f27c8ea: Add color to the default thread and frame format. (authored by JDevlieghere).
Add color to the default thread and frame format.
Mon, Jun 17, 12:52 PM
JDevlieghere committed rL363608: Add color to the default thread and frame format..
Add color to the default thread and frame format.
Mon, Jun 17, 12:52 PM
JDevlieghere closed D62743: Add color to the default thread and frame format..
Mon, Jun 17, 12:51 PM · Restricted Project, Restricted Project
JDevlieghere accepted D63399: DWARF: Make DIERefs always valid.
Mon, Jun 17, 12:24 PM

Fri, Jun 14

JDevlieghere added a comment to D62743: Add color to the default thread and frame format..

Can you add a screenshot of the final result for everybody?

Fri, Jun 14, 2:54 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D62743: Add color to the default thread and frame format..

Highlight line and column in different color

Fri, Jun 14, 2:52 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D62743: Add color to the default thread and frame format..

Match dwarfdump color scheme

Fri, Jun 14, 1:48 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D62743: Add color to the default thread and frame format..
Fri, Jun 14, 1:48 PM · Restricted Project, Restricted Project
JDevlieghere committed rG28defa70ead3: Remove stale comment and disabled code (NFC) (authored by JDevlieghere).
Remove stale comment and disabled code (NFC)
Fri, Jun 14, 11:11 AM
JDevlieghere committed rL363438: Remove stale comment and disabled code (NFC).
Remove stale comment and disabled code (NFC)
Fri, Jun 14, 11:11 AM
JDevlieghere accepted D63322: DWARF: Avoid storing DIERefs in long-lived containers.

LGTM

Fri, Jun 14, 9:34 AM · Restricted Project
JDevlieghere accepted D63311: Python 3: decode string as utf-8 to avoid type mismatch..

LGTM!

Fri, Jun 14, 8:35 AM · Restricted Project, Restricted Project

Thu, Jun 13

JDevlieghere added inline comments to D63306: Add a remarks-based code size diffing tool.
Thu, Jun 13, 11:23 PM · Restricted Project
JDevlieghere requested changes to D63311: Python 3: decode string as utf-8 to avoid type mismatch..

Yep, we should decode all the check_output results, as they may contain unicode.

Thu, Jun 13, 11:09 PM · Restricted Project, Restricted Project
JDevlieghere committed rG77cc50ff7d54: Fixed typos in Log.h (authored by JDevlieghere).
Fixed typos in Log.h
Thu, Jun 13, 11:04 PM
JDevlieghere committed rL363356: Fixed typos in Log.h.
Fixed typos in Log.h
Thu, Jun 13, 11:04 PM
JDevlieghere closed D63241: Fixed typos in Log.h.
Thu, Jun 13, 11:04 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D63241: Fixed typos in Log.h.

Let me know if you want me to commit this for you.

Thu, Jun 13, 1:53 PM · Restricted Project, Restricted Project
JDevlieghere accepted D63241: Fixed typos in Log.h.

Looks like the fallout of reflowing the comments. LGTM, Thanks!

Thu, Jun 13, 12:46 PM · Restricted Project, Restricted Project
JDevlieghere requested changes to D63104: Add GSYM utility files along with unit tests..
Thu, Jun 13, 12:45 PM · Restricted Project
JDevlieghere added a reviewer for D63104: Add GSYM utility files along with unit tests.: aprantl.
Thu, Jun 13, 12:07 PM · Restricted Project
JDevlieghere accepted D63275: [docs][llvm-dwarfdump] Make the --show-parents and --show-children help text and docs more consistent and correct.

Thanks!

Thu, Jun 13, 11:21 AM · Restricted Project

Wed, Jun 12

JDevlieghere committed rG2bf25681509a: [Reproducers] Remove call to lldb_private::GetVersion() (authored by JDevlieghere).
[Reproducers] Remove call to lldb_private::GetVersion()
Wed, Jun 12, 10:13 PM
JDevlieghere committed rL363228: [Reproducers] Remove call to lldb_private::GetVersion().
[Reproducers] Remove call to lldb_private::GetVersion()
Wed, Jun 12, 10:13 PM
JDevlieghere committed rGc2e2df7f7af1: [Reproducers] Include lldb version in the reproducer root (authored by JDevlieghere).
[Reproducers] Include lldb version in the reproducer root
Wed, Jun 12, 9:34 PM
JDevlieghere committed rL363225: [Reproducers] Include lldb version in the reproducer root.
[Reproducers] Include lldb version in the reproducer root
Wed, Jun 12, 9:32 PM
JDevlieghere closed D63229: [Reproducers] Include lldb version in the reproducer root.
Wed, Jun 12, 9:32 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D63229: [Reproducers] Include lldb version in the reproducer root.

Rebased to use the nested Info struct instead of the typedef.

Wed, Jun 12, 3:22 PM · Restricted Project, Restricted Project
JDevlieghere committed rGef96e985fcce: [Reproducers] Simplify providers with nested Info struct (NFC) (authored by JDevlieghere).
[Reproducers] Simplify providers with nested Info struct (NFC)
Wed, Jun 12, 3:15 PM
JDevlieghere committed rL363211: [Reproducers] Simplify providers with nested Info struct (NFC).
[Reproducers] Simplify providers with nested Info struct (NFC)
Wed, Jun 12, 3:14 PM
JDevlieghere accepted D63228: [llvm] Expose DWARFDebugLine::LineTable::getFileNameEntry.
Wed, Jun 12, 2:58 PM · debug-info, Restricted Project
JDevlieghere updated the diff for D63229: [Reproducers] Include lldb version in the reproducer root.

Adrian's feedback

Wed, Jun 12, 2:50 PM · Restricted Project, Restricted Project
JDevlieghere created D63229: [Reproducers] Include lldb version in the reproducer root.
Wed, Jun 12, 2:30 PM · Restricted Project, Restricted Project
JDevlieghere accepted D63217: [docs][llvm-dwarfdump] Add missing options and behaviour to llvm-dwarfdump documentation.
Wed, Jun 12, 9:41 AM · Restricted Project

Tue, Jun 11

JDevlieghere added a comment to D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime.

Have you considered making just AddExceptionPrecondition virtual? Wouldn't that solve the problem too, without the code duplication of making CreateExceptionBreakpoint virtual? Also, I think it's totally reasonable to hoist BreakpointPrecondition out of Breakpoint. After having had to deal with the nuisance of not being able to forward declare nested classes, I try to avoid them in general.

Tue, Jun 11, 9:39 PM
JDevlieghere accepted D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl.
Tue, Jun 11, 2:20 PM · Restricted Project
JDevlieghere committed rGa6fe345ac961: [Path] Set FD to -1 in moved-from TempFile (authored by JDevlieghere).
[Path] Set FD to -1 in moved-from TempFile
Tue, Jun 11, 9:40 AM
JDevlieghere committed rL363083: [Path] Set FD to -1 in moved-from TempFile.
[Path] Set FD to -1 in moved-from TempFile
Tue, Jun 11, 9:40 AM
JDevlieghere closed D63087: [Path] Set FD to -1 in moved-from TempFile.
Tue, Jun 11, 9:39 AM · Restricted Project
JDevlieghere accepted D63133: [llvm-dwarfdump] Simplify --ignore-case help text and documentation and fix grammar error.
Tue, Jun 11, 6:32 AM · Restricted Project

Mon, Jun 10

JDevlieghere accepted D63110: Fix a crash in option parsing..

LGTM!

Mon, Jun 10, 11:03 PM · Restricted Project, Restricted Project
JDevlieghere committed rG60e52cab86be: [dsymutil] Remove stale comment (NFC) (authored by JDevlieghere).
[dsymutil] Remove stale comment (NFC)
Mon, Jun 10, 4:29 PM
JDevlieghere committed rL363008: [dsymutil] Remove stale comment (NFC).
[dsymutil] Remove stale comment (NFC)
Mon, Jun 10, 4:29 PM
JDevlieghere created D63087: [Path] Set FD to -1 in moved-from TempFile.
Mon, Jun 10, 12:09 PM · Restricted Project
JDevlieghere accepted D62894: DWARF: Share line tables of type units.
Mon, Jun 10, 9:32 AM · Restricted Project
JDevlieghere accepted D62500: Add support to read aux vector values.
Mon, Jun 10, 9:24 AM · Restricted Project, Restricted Project
JDevlieghere accepted D63005: DWARF: Don't create lldb CompileUnits for DWARF type units.

I saw some weird formatting, but I assume you run clang-format before landing anyway. LGTM.

Mon, Jun 10, 9:12 AM · Restricted Project
JDevlieghere added inline comments to D62894: DWARF: Share line tables of type units.
Mon, Jun 10, 8:59 AM · Restricted Project
JDevlieghere added a comment to D63013: [llvm-dwarfdump] Add -o to help text and remove --out-file from documentation.

+1 on making -o the canonical argument and the out-file the alias.

Mon, Jun 10, 8:22 AM · Restricted Project

Fri, Jun 7

JDevlieghere committed rGbb8de35384ad: [dsymutil] Use the number of threads specified. (authored by JDevlieghere).
[dsymutil] Use the number of threads specified.
Fri, Jun 7, 10:33 AM
JDevlieghere committed rL362815: [dsymutil] Use the number of threads specified..
[dsymutil] Use the number of threads specified.
Fri, Jun 7, 10:32 AM
JDevlieghere accepted D62934: [LanguageRuntime] Introdce LLVM-style casts.
Fri, Jun 7, 10:25 AM · Restricted Project

Wed, Jun 5

JDevlieghere committed rG3027a2999c32: [dsymutil] Support more than 4 architectures (authored by JDevlieghere).
[dsymutil] Support more than 4 architectures
Wed, Jun 5, 10:12 AM
JDevlieghere committed rL362621: [dsymutil] Support more than 4 architectures.
[dsymutil] Support more than 4 architectures
Wed, Jun 5, 10:11 AM

Mon, Jun 3

JDevlieghere added inline comments to D62755: [Target] Remove Process::GetCPPLanguageRuntime.
Mon, Jun 3, 6:38 PM · Restricted Project
JDevlieghere added inline comments to D62755: [Target] Remove Process::GetCPPLanguageRuntime.
Mon, Jun 3, 4:56 PM · Restricted Project

Sat, Jun 1

JDevlieghere updated the diff for D62743: Add color to the default thread and frame format..

Adrian's feedback

Sat, Jun 1, 11:54 PM · Restricted Project, Restricted Project

Fri, May 31

JDevlieghere updated the summary of D62743: Add color to the default thread and frame format..
Fri, May 31, 10:32 AM · Restricted Project, Restricted Project
JDevlieghere created D62743: Add color to the default thread and frame format..
Fri, May 31, 10:30 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D62500: Add support to read aux vector values.
Fri, May 31, 9:39 AM · Restricted Project, Restricted Project
JDevlieghere committed rGa33964b57006: [FormatEntity] Ignore ASCII escape sequences when colors are disabled. (authored by JDevlieghere).
[FormatEntity] Ignore ASCII escape sequences when colors are disabled.
Fri, May 31, 9:26 AM
JDevlieghere committed rL362240: [FormatEntity] Ignore ASCII escape sequences when colors are disabled..
[FormatEntity] Ignore ASCII escape sequences when colors are disabled.
Fri, May 31, 9:25 AM
JDevlieghere closed D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled..
Fri, May 31, 9:25 AM · Restricted Project, Restricted Project

Thu, May 30

JDevlieghere added inline comments to D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled..
Thu, May 30, 7:46 PM · Restricted Project, Restricted Project
JDevlieghere created D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled..
Thu, May 30, 7:03 PM · Restricted Project, Restricted Project
JDevlieghere accepted D62632: [Remarks][NFC] Move the serialization to lib/Remarks.

LGTM. This seems straightforward. I skipped over the YAML stuff though, as it appears to have been moved.

Thu, May 30, 1:19 PM · Restricted Project
JDevlieghere accepted D61921: [Target] Generalize language-specific behavior in ThreadPlanStepThrough.
Thu, May 30, 1:14 PM · Restricted Project
JDevlieghere accepted D62654: [Docs] Modernize references to macOS.

LGTM

Thu, May 30, 9:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, May 29

JDevlieghere accepted D62634: Improve DWARF parsing and accessing by 1% to 2%.

Great!

Wed, May 29, 4:35 PM
JDevlieghere accepted D62593: DWARFDebugInfoEntry: delete unused Extract() and rename FastExtract() to Extract().

LGTM

Wed, May 29, 9:18 AM · Restricted Project

Tue, May 28

JDevlieghere created D62570: [WIP] Use LLVM's debug line parser in LLDB.
Tue, May 28, 11:45 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D62562: [Target] Introduce Process::GetLanguageRuntimes.
Tue, May 28, 8:37 PM · Restricted Project
JDevlieghere committed rGd02da8f42c2e: [SymbolFileDWARF] Remove unused member (NFC) (authored by JDevlieghere).
[SymbolFileDWARF] Remove unused member (NFC)
Tue, May 28, 3:31 PM
JDevlieghere committed rL361886: [SymbolFileDWARF] Remove unused member (NFC).
[SymbolFileDWARF] Remove unused member (NFC)
Tue, May 28, 3:31 PM
JDevlieghere committed rLLDB361886: [SymbolFileDWARF] Remove unused member (NFC).
[SymbolFileDWARF] Remove unused member (NFC)
Tue, May 28, 3:31 PM
JDevlieghere accepted D62472: [CMake] LLDB.framework tools handling.
Tue, May 28, 11:23 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D62500: Add support to read aux vector values.

Definitely go for the option of refactoring the DYLD AuxVector class to make it usable from lldb-server.

Tue, May 28, 11:16 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D62472: [CMake] LLDB.framework tools handling.
Tue, May 28, 10:47 AM · Restricted Project, Restricted Project
JDevlieghere accepted D62474: [CMake] Remove lldb-server from LLDB.framework.
Tue, May 28, 10:47 AM · Restricted Project
JDevlieghere committed rG04a087ace786: [DWARFExpression] Remove ctor that takes just a compile unit. (authored by JDevlieghere).
[DWARFExpression] Remove ctor that takes just a compile unit.
Tue, May 28, 10:32 AM
JDevlieghere committed rLLDB361849: [DWARFExpression] Remove ctor that takes just a compile unit..
[DWARFExpression] Remove ctor that takes just a compile unit.
Tue, May 28, 10:31 AM
JDevlieghere committed rL361849: [DWARFExpression] Remove ctor that takes just a compile unit..
[DWARFExpression] Remove ctor that takes just a compile unit.
Tue, May 28, 10:31 AM
JDevlieghere closed D62425: [DWARFExpression] Remove ctor that takes just a compile unit..
Tue, May 28, 10:31 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D62302: DWARF: Fix address range support in mixed 4+5 scenario.
Tue, May 28, 9:11 AM · Restricted Project
JDevlieghere updated the diff for D62425: [DWARFExpression] Remove ctor that takes just a compile unit..

Address CR feedback

Tue, May 28, 9:04 AM · Restricted Project, Restricted Project

Fri, May 24

JDevlieghere committed rG7c67dec9b80a: [DWARFExpression] Remove commented-out code (NFC) (authored by JDevlieghere).
[DWARFExpression] Remove commented-out code (NFC)
Fri, May 24, 2:24 PM
JDevlieghere committed rL361672: [DWARFExpression] Remove commented-out code (NFC).
[DWARFExpression] Remove commented-out code (NFC)
Fri, May 24, 2:24 PM
JDevlieghere committed rLLDB361672: [DWARFExpression] Remove commented-out code (NFC).
[DWARFExpression] Remove commented-out code (NFC)
Fri, May 24, 2:23 PM
JDevlieghere committed rG0da8160df354: [dwarfdump] Add flag to limit the number of parents DIEs (authored by JDevlieghere).
[dwarfdump] Add flag to limit the number of parents DIEs
Fri, May 24, 2:09 PM
JDevlieghere committed rL361671: [dwarfdump] Add flag to limit the number of parents DIEs.
[dwarfdump] Add flag to limit the number of parents DIEs
Fri, May 24, 2:09 PM
JDevlieghere closed D62359: [dwarfdump] Make recursion affect the parent chain.
Fri, May 24, 2:09 PM · Restricted Project
JDevlieghere updated the diff for D62425: [DWARFExpression] Remove ctor that takes just a compile unit..

s/SetOpcodeData/UpdateValue/

Fri, May 24, 2:02 PM · Restricted Project, Restricted Project
JDevlieghere created D62425: [DWARFExpression] Remove ctor that takes just a compile unit..
Fri, May 24, 2:02 PM · Restricted Project, Restricted Project
JDevlieghere accepted D62416: Cleanup fixed form sizes..

Looks like a good change. Small comment inline but otherwise LGTM.

Fri, May 24, 12:45 PM · Restricted Project
JDevlieghere updated the diff for D62359: [dwarfdump] Make recursion affect the parent chain.
  • Add new flag -parent-recurse-depth.
  • Add new aliases -limit-children and -limit-parents.
Fri, May 24, 10:07 AM · Restricted Project

Thu, May 23

JDevlieghere committed rG0ee23c958bbc: [Utility] Small improvements to the Broadcaster class (NFC) (authored by JDevlieghere).
[Utility] Small improvements to the Broadcaster class (NFC)
Thu, May 23, 9:40 PM
JDevlieghere committed rLLDB361597: [Utility] Small improvements to the Broadcaster class (NFC).
[Utility] Small improvements to the Broadcaster class (NFC)
Thu, May 23, 9:39 PM
JDevlieghere committed rL361597: [Utility] Small improvements to the Broadcaster class (NFC).
[Utility] Small improvements to the Broadcaster class (NFC)
Thu, May 23, 9:39 PM
JDevlieghere added a comment to D62359: [dwarfdump] Make recursion affect the parent chain.

Is this the desired behavior?

Currently, I assume, searching for a particular DIE offset dumps that DIE, its parent, and all its children. (& the recursion limit is entirely ignored?)

Yup.

This patch, if I understand it, dumps from the CU to the target DIE until the recursion limit is reached. So you get some parent DIE of the one you searched for.

I would've probably thought that the entire parent chain would be dumped, and then the recursion limit would limit how deep into the children of the target DIE would be dumped.

Thoughts?

Thu, May 23, 8:12 PM · Restricted Project
JDevlieghere added a comment to D62337: [lldb] followup fix for https://reviews.llvm.org/D62305.

Hi

This change breaks arm/aarch64 linux builds.

http://147.75.106.138:32769/builders/lldb-aarch64-ubuntu/builds/47

Thu, May 23, 6:15 PM · Restricted Project