Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (168 w, 3 d)

Recent Activity

Today

JDevlieghere added a comment to D61090: [SBHostOS} Remove getting the python script interpreter path.

It seems weird to be getting the ScriptInterpreter's ScriptModuleDirectory from the CommandInterpreter. I would have expected:

m_debugger.GetScriptInterpreter().GetScriptModuleDirectory()

I don't think there's any reason to have the Command Interpreter know which ScriptInterpreter is being used, so entangling them like this is awkward.

Am I missing some reason why it makes sense to do this on the CommandInterpreter?

Wed, Apr 24, 4:47 PM · Restricted Project
JDevlieghere added a comment to D61090: [SBHostOS} Remove getting the python script interpreter path.

(I didn't yet, but I'll cleanup the references to Python in the driver if people like this approach.)

Wed, Apr 24, 4:32 PM · Restricted Project
JDevlieghere updated the diff for D61090: [SBHostOS} Remove getting the python script interpreter path.

Deprecate the current method in SBHostOS and provide an alternative through SBCommandInterpreter::GetModuleDirectory

Wed, Apr 24, 4:22 PM · Restricted Project
JDevlieghere committed rGc95c08baa1af: [SystemInitializerFull] Fix header sorting (NFC) (authored by JDevlieghere).
[SystemInitializerFull] Fix header sorting (NFC)
Wed, Apr 24, 2:22 PM
JDevlieghere committed rLLDB359141: [SystemInitializerFull] Fix header sorting (NFC).
[SystemInitializerFull] Fix header sorting (NFC)
Wed, Apr 24, 2:22 PM
JDevlieghere committed rL359141: [SystemInitializerFull] Fix header sorting (NFC).
[SystemInitializerFull] Fix header sorting (NFC)
Wed, Apr 24, 2:22 PM
JDevlieghere created D61090: [SBHostOS} Remove getting the python script interpreter path.
Wed, Apr 24, 1:45 PM · Restricted Project
JDevlieghere committed rG10b113e8aa60: [ScriptInterpreterPython] find_first_of -> find (NFC) (authored by JDevlieghere).
[ScriptInterpreterPython] find_first_of -> find (NFC)
Wed, Apr 24, 1:39 PM
JDevlieghere committed rLLDB359138: [ScriptInterpreterPython] find_first_of -> find (NFC).
[ScriptInterpreterPython] find_first_of -> find (NFC)
Wed, Apr 24, 1:38 PM
JDevlieghere committed rL359138: [ScriptInterpreterPython] find_first_of -> find (NFC).
[ScriptInterpreterPython] find_first_of -> find (NFC)
Wed, Apr 24, 1:38 PM

Yesterday

JDevlieghere committed rG196123255e40: [Docs] Add more redirects (authored by JDevlieghere).
[Docs] Add more redirects
Tue, Apr 23, 6:59 PM
JDevlieghere committed rL359063: [Docs] Add more redirects.
[Docs] Add more redirects
Tue, Apr 23, 6:56 PM
JDevlieghere committed rLLDB359063: [Docs] Add more redirects.
[Docs] Add more redirects
Tue, Apr 23, 6:56 PM
JDevlieghere committed rG6d0dc28a32cf: [Docs] Update the CI page (authored by JDevlieghere).
[Docs] Update the CI page
Tue, Apr 23, 6:48 PM
JDevlieghere committed rG6f7759672dcd: [Docs] Move external links up (authored by JDevlieghere).
[Docs] Move external links up
Tue, Apr 23, 6:48 PM
JDevlieghere committed rL359062: [Docs] Update the CI page.
[Docs] Update the CI page
Tue, Apr 23, 6:47 PM
JDevlieghere committed rLLDB359062: [Docs] Update the CI page.
[Docs] Update the CI page
Tue, Apr 23, 6:47 PM
JDevlieghere committed rLLDB359061: [Docs] Move external links up.
[Docs] Move external links up
Tue, Apr 23, 6:47 PM
JDevlieghere committed rL359061: [Docs] Move external links up.
[Docs] Move external links up
Tue, Apr 23, 6:47 PM
JDevlieghere committed rG36371d61ec8d: [Docs] Fix link to C++ docs (authored by JDevlieghere).
[Docs] Fix link to C++ docs
Tue, Apr 23, 5:11 PM
JDevlieghere committed rL359052: [Docs] Fix link to C++ docs.
[Docs] Fix link to C++ docs
Tue, Apr 23, 5:11 PM
JDevlieghere committed rLLDB359052: [Docs] Fix link to C++ docs.
[Docs] Fix link to C++ docs
Tue, Apr 23, 5:11 PM
JDevlieghere added a comment to D60227: [Remarks] Add string deduplication using a string table.

LGTM

Tue, Apr 23, 2:49 PM · Restricted Project
JDevlieghere committed rGdb41fe166a53: [Reproducers] Limit logging to calls that cross the API boundary. (authored by JDevlieghere).
[Reproducers] Limit logging to calls that cross the API boundary.
Tue, Apr 23, 10:44 AM
JDevlieghere committed rL359016: [Reproducers] Limit logging to calls that cross the API boundary..
[Reproducers] Limit logging to calls that cross the API boundary.
Tue, Apr 23, 10:44 AM
JDevlieghere committed rLLDB359016: [Reproducers] Limit logging to calls that cross the API boundary..
[Reproducers] Limit logging to calls that cross the API boundary.
Tue, Apr 23, 10:44 AM
JDevlieghere closed D60984: [Reproducers] Limit logging to calls that cross the API boundary..
Tue, Apr 23, 10:44 AM · Restricted Project
JDevlieghere committed rG3ba5f66177a4: [Docs] Add missing leading slash (authored by JDevlieghere).
[Docs] Add missing leading slash
Tue, Apr 23, 9:00 AM
JDevlieghere committed rLLDB359005: [Docs] Add missing leading slash.
[Docs] Add missing leading slash
Tue, Apr 23, 9:00 AM
JDevlieghere committed rL359005: [Docs] Add missing leading slash.
[Docs] Add missing leading slash
Tue, Apr 23, 9:00 AM
JDevlieghere committed rG056fde75271c: [Docs] Add 301 redirects for old URLs (authored by JDevlieghere).
[Docs] Add 301 redirects for old URLs
Tue, Apr 23, 8:57 AM
JDevlieghere committed rLLDB359004: [Docs] Add 301 redirects for old URLs.
[Docs] Add 301 redirects for old URLs
Tue, Apr 23, 8:57 AM
JDevlieghere committed rL359004: [Docs] Add 301 redirects for old URLs.
[Docs] Add 301 redirects for old URLs
Tue, Apr 23, 8:57 AM

Mon, Apr 22

JDevlieghere committed rGd44a7be17b67: [Docs] Move API docs to the front page (authored by JDevlieghere).
[Docs] Move API docs to the front page
Mon, Apr 22, 3:40 PM
JDevlieghere committed rL358928: [Docs] Move API docs to the front page.
[Docs] Move API docs to the front page
Mon, Apr 22, 3:40 PM
JDevlieghere committed rLLDB358928: [Docs] Move API docs to the front page.
[Docs] Move API docs to the front page
Mon, Apr 22, 3:40 PM
JDevlieghere created D60984: [Reproducers] Limit logging to calls that cross the API boundary..
Mon, Apr 22, 3:20 PM · Restricted Project
JDevlieghere accepted D60642: [dsymutil] Collect parseable Swift interfaces in the .dSYM bundle..
Mon, Apr 22, 2:25 PM · Restricted Project
JDevlieghere committed rG32176baee78d: [Reproducers] Fix lifetime issue (authored by JDevlieghere).
[Reproducers] Fix lifetime issue
Mon, Apr 22, 1:04 PM
JDevlieghere committed rLLDB358916: [Reproducers] Fix lifetime issue.
[Reproducers] Fix lifetime issue
Mon, Apr 22, 1:04 PM
JDevlieghere committed rL358916: [Reproducers] Fix lifetime issue.
[Reproducers] Fix lifetime issue
Mon, Apr 22, 1:03 PM
JDevlieghere added inline comments to D60642: [dsymutil] Collect parseable Swift interfaces in the .dSYM bundle..
Mon, Apr 22, 9:20 AM · Restricted Project

Fri, Apr 19

JDevlieghere committed rGd600e6fa85b5: [Tests] Split float test into float and doubles (authored by JDevlieghere).
[Tests] Split float test into float and doubles
Fri, Apr 19, 3:38 PM
JDevlieghere committed rL358792: [Tests] Split float test into float and doubles.
[Tests] Split float test into float and doubles
Fri, Apr 19, 3:38 PM
JDevlieghere committed rLLDB358792: [Tests] Split float test into float and doubles.
[Tests] Split float test into float and doubles
Fri, Apr 19, 3:38 PM
JDevlieghere committed rGf7f03622eca6: [Docs] Add more info about building the docs (authored by JDevlieghere).
[Docs] Add more info about building the docs
Fri, Apr 19, 12:03 PM
JDevlieghere committed rLLDB358777: [Docs] Add more info about building the docs.
[Docs] Add more info about building the docs
Fri, Apr 19, 12:02 PM
JDevlieghere committed rL358777: [Docs] Add more info about building the docs.
[Docs] Add more info about building the docs
Fri, Apr 19, 12:02 PM
JDevlieghere committed rLLDB358773: [Docs] Make Doxygen functional.
[Docs] Make Doxygen functional
Fri, Apr 19, 11:02 AM
JDevlieghere committed rG52cf94090fcb: [Docs] Make Doxygen functional (authored by JDevlieghere).
[Docs] Make Doxygen functional
Fri, Apr 19, 11:02 AM
JDevlieghere committed rL358773: [Docs] Make Doxygen functional.
[Docs] Make Doxygen functional
Fri, Apr 19, 11:02 AM

Thu, Apr 18

JDevlieghere committed rGf2293a95dee0: [Docs] Add LLDB bots (authored by JDevlieghere).
[Docs] Add LLDB bots
Thu, Apr 18, 10:33 AM
JDevlieghere committed rLLDB358693: [Docs] Add LLDB bots.
[Docs] Add LLDB bots
Thu, Apr 18, 10:33 AM
JDevlieghere committed rL358693: [Docs] Add LLDB bots.
[Docs] Add LLDB bots
Thu, Apr 18, 10:33 AM

Wed, Apr 17

JDevlieghere added inline comments to D60642: [dsymutil] Collect parseable Swift interfaces in the .dSYM bundle..
Wed, Apr 17, 6:53 PM · Restricted Project
JDevlieghere committed rGea6037d84edd: [Shell] Simplify Extracting Python Version (authored by JDevlieghere).
[Shell] Simplify Extracting Python Version
Wed, Apr 17, 6:38 PM
JDevlieghere committed rLLDB358635: [Shell] Simplify Extracting Python Version.
[Shell] Simplify Extracting Python Version
Wed, Apr 17, 6:38 PM
JDevlieghere committed rL358635: [Shell] Simplify Extracting Python Version.
[Shell] Simplify Extracting Python Version
Wed, Apr 17, 6:38 PM

Tue, Apr 16

JDevlieghere accepted D60802: Implement sys::fs::copy_file using the macOS copyfile(3) API to support APFS clones.
Tue, Apr 16, 8:31 PM · Restricted Project
JDevlieghere accepted D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

Thanks!

Tue, Apr 16, 2:05 PM · Restricted Project
JDevlieghere added inline comments to D60780: [tools] Only build lldb-instr and lldb-vscode if asked..
Tue, Apr 16, 1:21 PM · Restricted Project
JDevlieghere added a comment to D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

LLDB_TOOL_$TOOL_BUILD would be a better name for consistency with llvm. In fact, if we started using the llvm cmake macros like add_llvm_subdirectory, it would handle this automatically, including creating the cache variable.

The only difference would be that the variable would default to "On", whereas you seem to want default-off. (I'm a bit torn on whether this is good. On one hand, I understand the desire to not build this stuff, but on the other, this creates an inconsistency with llvm, which builds everything by default, and consistency is a good thing.)

Also, I'd like to nominate lldb-mi as an additional optional feature. :)

Tue, Apr 16, 11:16 AM · Restricted Project
JDevlieghere requested changes to D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

We need to define these variables in the cache and make sure the test suite knows about them.

Tue, Apr 16, 10:23 AM · Restricted Project

Sun, Apr 14

JDevlieghere accepted D60667: Allow direct comparison of ConstString against StringRef.

Thanks for doing this, Raphael!

Sun, Apr 14, 9:55 AM · Restricted Project

Fri, Apr 12

JDevlieghere added a comment to D60599: Move postfix expression code out of the NativePDB plugin.

Makes sense, LGTM

Fri, Apr 12, 2:28 AM · Restricted Project

Thu, Apr 11

JDevlieghere committed rGbb6e3f6be7ed: [test] Fix & re-enable CommandScriptImmediateOutputFile on Windows (authored by JDevlieghere).
[test] Fix & re-enable CommandScriptImmediateOutputFile on Windows
Thu, Apr 11, 12:37 PM
JDevlieghere committed rL358216: [test] Fix & re-enable CommandScriptImmediateOutputFile on Windows.
[test] Fix & re-enable CommandScriptImmediateOutputFile on Windows
Thu, Apr 11, 12:35 PM
JDevlieghere committed rLLDB358216: [test] Fix & re-enable CommandScriptImmediateOutputFile on Windows.
[test] Fix & re-enable CommandScriptImmediateOutputFile on Windows
Thu, Apr 11, 12:35 PM
JDevlieghere committed rG1fefee6a6e77: [test] Disable CommandScriptImmediateOutputFile on Windows (authored by JDevlieghere).
[test] Disable CommandScriptImmediateOutputFile on Windows
Thu, Apr 11, 12:18 PM
JDevlieghere committed rL358213: [test] Disable CommandScriptImmediateOutputFile on Windows.
[test] Disable CommandScriptImmediateOutputFile on Windows
Thu, Apr 11, 12:17 PM
JDevlieghere committed rLLDB358213: [test] Disable CommandScriptImmediateOutputFile on Windows.
[test] Disable CommandScriptImmediateOutputFile on Windows
Thu, Apr 11, 12:17 PM
JDevlieghere committed rGd843da6218d8: [test] Convert CommandScriptImmediateOutput from pexpect to lit (authored by JDevlieghere).
[test] Convert CommandScriptImmediateOutput from pexpect to lit
Thu, Apr 11, 8:02 AM
JDevlieghere committed rLLDB358180: [test] Convert CommandScriptImmediateOutput from pexpect to lit.
[test] Convert CommandScriptImmediateOutput from pexpect to lit
Thu, Apr 11, 8:02 AM
JDevlieghere committed rL358180: [test] Convert CommandScriptImmediateOutput from pexpect to lit.
[test] Convert CommandScriptImmediateOutput from pexpect to lit
Thu, Apr 11, 8:02 AM
JDevlieghere closed D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit.
Thu, Apr 11, 8:01 AM · Restricted Project
JDevlieghere updated the diff for D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit.

Feedback Pavel

Thu, Apr 11, 7:51 AM · Restricted Project
JDevlieghere created D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit.
Thu, Apr 11, 7:15 AM · Restricted Project
JDevlieghere abandoned D60563: [pexepect] Add a small sleep between pexect calls.

Apparently Pavel already investigated and fixed this in r357459. We also discussed a better way to make this work by checking the echo of the command passed to sendline.

Thu, Apr 11, 5:52 AM · Restricted Project
JDevlieghere added a comment to D60563: [pexepect] Add a small sleep between pexect calls.

To give a little more context: the particular issue I was looking at (TestCommandScriptImmediateOutput) occurs with sendline. We send a bunch of commands and always check for the prompt. I can reproduce the error when piping the test commands directly to LLDB.

Thu, Apr 11, 4:41 AM · Restricted Project
JDevlieghere created D60563: [pexepect] Add a small sleep between pexect calls.
Thu, Apr 11, 4:32 AM · Restricted Project

Wed, Apr 10

JDevlieghere committed rL358135: [NFC] Remove ASCII lines from comments.
[NFC] Remove ASCII lines from comments
Wed, Apr 10, 1:53 PM
JDevlieghere committed rLLDB358135: [NFC] Remove ASCII lines from comments.
[NFC] Remove ASCII lines from comments
Wed, Apr 10, 1:51 PM
JDevlieghere committed rG8b3af63b8993: [NFC] Remove ASCII lines from comments (authored by JDevlieghere).
[NFC] Remove ASCII lines from comments
Wed, Apr 10, 1:51 PM
JDevlieghere closed D60508: [NFC] Remove ASCII lines from comments.
Wed, Apr 10, 1:48 PM · Restricted Project
JDevlieghere committed rG6a7412a893da: [testsuite] Split Obj-C foundation test (authored by JDevlieghere).
[testsuite] Split Obj-C foundation test
Wed, Apr 10, 7:30 AM
JDevlieghere committed rL358088: [testsuite] Split Obj-C foundation test.
[testsuite] Split Obj-C foundation test
Wed, Apr 10, 7:28 AM
JDevlieghere committed rLLDB358088: [testsuite] Split Obj-C foundation test.
[testsuite] Split Obj-C foundation test
Wed, Apr 10, 7:28 AM
JDevlieghere created D60508: [NFC] Remove ASCII lines from comments.
Wed, Apr 10, 5:28 AM · Restricted Project
JDevlieghere accepted D60227: [Remarks] Add string deduplication using a string table.

LGTM with the outstanding comments/questions addressed.

Wed, Apr 10, 1:43 AM · Restricted Project

Tue, Apr 9

JDevlieghere added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

Hi, currently we have a private build server that executes the test-suite on ARC. There are failures for now, mostly due to unimplemented features for ARC like expressions support.
I'll take care of a public build-bot, if it is required.

Tue, Apr 9, 8:39 AM · Restricted Project
JDevlieghere committed rG7e01ce2ed15a: Fix doxygen warning about function argument (authored by JDevlieghere).
Fix doxygen warning about function argument
Tue, Apr 9, 2:03 AM
JDevlieghere committed rL357983: Fix doxygen warning about function argument.
Fix doxygen warning about function argument
Tue, Apr 9, 2:02 AM
JDevlieghere committed rLLDB357983: Fix doxygen warning about function argument.
Fix doxygen warning about function argument
Tue, Apr 9, 2:02 AM
JDevlieghere closed D60443: Fix doxygen warning about function argument.
Tue, Apr 9, 2:02 AM · Restricted Project
JDevlieghere accepted D60443: Fix doxygen warning about function argument.

LGTM

Tue, Apr 9, 1:59 AM · Restricted Project
JDevlieghere added a comment to D60442: Add missing space between \btrue.

I think I don't have commit access (yet) and would like if someone can commit this for me. It was my first commit to the LLDB project and I wanted to get familiar with phabricator and the arc tool. Is phabricator here to stay or are there plans to move to github or something else? I'm just a bit confused still about some SVN revisions showing up here and there and why that is. I guess it will clear up in some time.

Tue, Apr 9, 1:35 AM · Restricted Project
JDevlieghere committed rG721b8d1557a1: Add missing space between \btrue (authored by JDevlieghere).
Add missing space between \btrue
Tue, Apr 9, 1:33 AM
JDevlieghere committed rL357980: Add missing space between \btrue.
Add missing space between \btrue
Tue, Apr 9, 1:32 AM
JDevlieghere committed rLLDB357980: Add missing space between \btrue.
Add missing space between \btrue
Tue, Apr 9, 1:32 AM
JDevlieghere closed D60442: Add missing space between \btrue.
Tue, Apr 9, 1:32 AM · Restricted Project