- User Since
- Jan 31 2016, 7:15 AM (149 w, 5 d)
I played around with this today:
Sorry for the late review, I had a look originally but didn't have any comments. LGTM!
Address Adrian's feedback
Wed, Dec 12
When sourcing a file we should also ignore the individual commands otherwise they end up getting executed twice, once as part of the command source and once for every individual command in the file.
Skip driver logic when replaying, otherwise commands are executed or sourced twice, once in the driver and once by replaying the commands.
Address Pavel's comments.
Remove changes that introduced static_cast<bool>
Tue, Dec 11
I'm going to abandon this for now until we have better tooling to address Jim's concerns here. I'm also not super happy with the formatting, which seems to be off in quite a few locations. The problem is that clang-tidy knows to reformat the source range it touched, but in this case the code below is affected. I hacked this up by having clang-format looking one line below the lines that were changed, but looks like that was not sufficient. Also a few case are covered by D55584 so definitely want to land that first.
Mon, Dec 10
Add more pages
- Copy over permissions
- Fix path when launching.
Fri, Dec 7
LGTM with the question answered/addressed. Thanks Stefan, these patches are really great work!
This LGTM if it works on Windows.
Thu, Dec 6
Tue, Dec 4
What happens today with NVPTX for other debug info sections that use label arithmetic? I know for sure that the accelerator tables/debug_names is using this, but maybe they're not used with this target?
I'm in favor of using labels for the reasons you mentioned. It's also consistent with what we do elsewhere.
Mon, Dec 3
Initialize the FS in the unit test.
Fri, Nov 30
Make initialize return an error.
This makes sense to me. I'm don't know if there's a better property but I think this matches the intended use, so I think it is fine.
Thu, Nov 29
- Get the external path with modifying the VFS in LLVM.
- Integrate with the new integration logic.
- Add a test. (that doesn't work yet, still WIP)
Test didn't run. Is there a way to REQUIRE either darwin or linux?
Move RedirectingFileSystem interface into header so we can extend it from LLDB.
Address feedback from Pavel.