Page MenuHomePhabricator
People JDevlieghere

JDevlieghere (Jonas Devlieghere)
Software Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (281 w, 4 d)

Recent Activity
View All

Yesterday

JDevlieghere accepted D104893: Add data formatter support for a missing NSDictionary variant.

LGTM

Thu, Jun 24, 7:44 PM · Restricted Project
JDevlieghere accepted D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT.

Nice, thanks for figuring this one out. LGTM.

Thu, Jun 24, 5:50 PM · Restricted Project

Tue, Jun 22

JDevlieghere accepted D104653: [lldb] Avoid using any shell when calling xcrun..

LGTM

Tue, Jun 22, 11:34 AM · Restricted Project

Mon, Jun 21

JDevlieghere added a comment to D104281: [lldb][docs] Add reference docs for Lua scripting.

I'm a little suspicious about the changes to conf.py. Can you explain why they're necessary and what they're fixing?

Mon, Jun 21, 11:32 AM · Restricted Project
JDevlieghere added inline comments to D104483: Improve error handling in llvm-dwarfdump.
Mon, Jun 21, 9:45 AM · Restricted Project
JDevlieghere accepted D104635: [lldb] Add support for escaping fish arguments.

LGTM

Mon, Jun 21, 8:00 AM · Restricted Project
JDevlieghere accepted D104629: [lldb] Escape semicolons for all shells.

LGTM

Mon, Jun 21, 7:39 AM · Restricted Project
JDevlieghere added inline comments to D104627: [lldb] Add support for escaping zsh arguments.
Mon, Jun 21, 7:38 AM · Restricted Project
JDevlieghere added inline comments to D104635: [lldb] Add support for escaping fish arguments.
Mon, Jun 21, 7:38 AM · Restricted Project
JDevlieghere accepted D104627: [lldb] Add support for escaping zsh arguments.

LGTM.

Mon, Jun 21, 7:33 AM · Restricted Project

Mon, Jun 14

JDevlieghere accepted D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses.

LGTM

Mon, Jun 14, 12:15 PM · Restricted Project

Fri, Jun 11

JDevlieghere requested changes to D101340: Allows for dsymutil crashes to generate reproduceable information.
Fri, Jun 11, 11:06 AM · Restricted Project
JDevlieghere accepted D103391: [lldb] Add missing reproducer instrumentation to some SB classes.

Thanks!

Fri, Jun 11, 10:49 AM · Restricted Project
JDevlieghere accepted D103575: Allow signposts to take advantage of deferred string substitution.

Looks good to me!

Fri, Jun 11, 10:48 AM · Restricted Project, Restricted Project
JDevlieghere committed rGfc71a5c6e8e8: [lldb] Support new objective-c hash table layout (authored by JDevlieghere).
[lldb] Support new objective-c hash table layout
Fri, Jun 11, 10:26 AM
JDevlieghere committed rGc7dee6aefd5b: [lldb] Enable TestRuntimeTypes on Apple Silicon (authored by JDevlieghere).
[lldb] Enable TestRuntimeTypes on Apple Silicon
Fri, Jun 11, 10:25 AM

Thu, Jun 10

JDevlieghere updated the diff for D104041: [lldb] Replace default bodies of special member functions with = default;.
Thu, Jun 10, 10:55 AM
JDevlieghere added inline comments to D104041: [lldb] Replace default bodies of special member functions with = default;.
Thu, Jun 10, 10:52 AM
JDevlieghere updated the diff for D104041: [lldb] Replace default bodies of special member functions with = default;.

Mi traktis la komentojn

Thu, Jun 10, 10:52 AM
JDevlieghere accepted D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs.

LGTM!

Thu, Jun 10, 10:43 AM · Restricted Project
JDevlieghere committed rGcfbf61cd5994: [lldb] Add 9494c510af56 to .git-blame-ignore-revs (authored by JDevlieghere).
[lldb] Add 9494c510af56 to .git-blame-ignore-revs
Thu, Jun 10, 9:30 AM
JDevlieghere updated the diff for D104041: [lldb] Replace default bodies of special member functions with = default;.
Thu, Jun 10, 9:24 AM
JDevlieghere added inline comments to D104041: [lldb] Replace default bodies of special member functions with = default;.
Thu, Jun 10, 9:21 AM
JDevlieghere requested review of D104041: [lldb] Replace default bodies of special member functions with = default;.
Thu, Jun 10, 9:20 AM

Wed, Jun 9

JDevlieghere added a comment to D103575: Allow signposts to take advantage of deferred string substitution.
In D103575#2804151, @aprantl wrote:

I'm not sure I fully understand the suggestion:

I think we should just remove the functionality form the timer class again. I only added it there because of the macro.

... and replace its uses with what?

Wed, Jun 9, 9:54 AM · Restricted Project, Restricted Project
JDevlieghere committed rG9494c510af56: [lldb] Use C++11 default member initializers (authored by JDevlieghere).
[lldb] Use C++11 default member initializers
Wed, Jun 9, 9:43 AM
JDevlieghere closed D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.
Wed, Jun 9, 9:43 AM · Restricted Project
JDevlieghere updated the diff for D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.
  • Rebase
  • Replace nil with nullptr
Wed, Jun 9, 9:03 AM · Restricted Project

Tue, Jun 8

JDevlieghere committed rG1a216fb15a18: [lldb] Don't print script output twice in HandleCommand (authored by JDevlieghere).
[lldb] Don't print script output twice in HandleCommand
Tue, Jun 8, 1:58 PM
JDevlieghere closed D103349: [lldb] Don't print script output twice in HandleCommand.
Tue, Jun 8, 1:57 PM · Restricted Project
JDevlieghere added inline comments to D103500: [trace][intel-pt] Create basic SB API.
Tue, Jun 8, 10:43 AM · Restricted Project

Fri, Jun 4

JDevlieghere added a comment to D103575: Allow signposts to take advantage of deferred string substitution.

I think we should just remove the functionality form the timer class again. I only added it there because of the macro.

Fri, Jun 4, 2:04 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D101340: Allows for dsymutil crashes to generate reproduceable information.
Fri, Jun 4, 9:05 AM · Restricted Project

Thu, Jun 3

JDevlieghere updated the diff for D103349: [lldb] Don't print script output twice in HandleCommand.

Don't try to be cute: s/Hermetic/SuppressImmediateOutput/

Thu, Jun 3, 12:42 PM · Restricted Project

Wed, Jun 2

JDevlieghere updated the diff for D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.

Fix compilation issues

Wed, Jun 2, 4:13 PM · Restricted Project
JDevlieghere accepted D103504: Improve performance when parsing symbol tables in mach-o files..

LGTM

Wed, Jun 2, 9:58 AM · Restricted Project

Tue, Jun 1

JDevlieghere accepted D101835: [llvm] llvm-tapi-diff.

LGTM! Thanks for bearing with me :-)

Tue, Jun 1, 12:19 PM · Restricted Project
JDevlieghere added a comment to D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.

FWIW this is more of an RFC and as always there's some manual fixing up to be done and formatting to be fixed. I wanted to put this up for review before sinking time in that.

Tue, Jun 1, 12:16 PM · Restricted Project
JDevlieghere requested review of D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.
Tue, Jun 1, 12:16 PM · Restricted Project
JDevlieghere updated the diff for D103349: [lldb] Don't print script output twice in HandleCommand.

Use in-class initializers

Tue, Jun 1, 11:29 AM · Restricted Project
JDevlieghere added inline comments to D103349: [lldb] Don't print script output twice in HandleCommand.
Tue, Jun 1, 11:25 AM · Restricted Project
JDevlieghere added a comment to D101835: [llvm] llvm-tapi-diff.

A few small nits and this should be ready to go.

Tue, Jun 1, 11:07 AM · Restricted Project
JDevlieghere accepted D103442: [lldb][NFC] Remove a redundant call to weak_ptr::expired.

LGTM

Tue, Jun 1, 9:52 AM · Restricted Project
JDevlieghere accepted D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit.

LGTM. Are there other places where we check this, either in lldbutil or maybe more generally a pattern in the tests that could be extracted into a helper?

Tue, Jun 1, 9:51 AM · Restricted Project

Fri, May 28

JDevlieghere requested review of D103349: [lldb] Don't print script output twice in HandleCommand.
Fri, May 28, 5:36 PM · Restricted Project
JDevlieghere accepted D103217: Make ignore counts work as "after stop" modifiers so they play nicely with conditions.

LGTM

Fri, May 28, 9:17 AM · Restricted Project

Thu, May 27

JDevlieghere added inline comments to D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().
Thu, May 27, 9:08 AM · Restricted Project

May 25 2021

JDevlieghere committed rG564eb20e0dee: Revert "[lldb] Avoid format string in LLDB_SCOPED_TIMER" (authored by JDevlieghere).
Revert "[lldb] Avoid format string in LLDB_SCOPED_TIMER"
May 25 2021, 5:23 PM
JDevlieghere committed rGbbcb3433d4e8: [lldb] Avoid format string in LLDB_SCOPED_TIMER (authored by JDevlieghere).
[lldb] Avoid format string in LLDB_SCOPED_TIMER
May 25 2021, 5:14 PM
JDevlieghere accepted D103107: [lldb] Remove cache in get_demangled_name_without_arguments.

LGTM

May 25 2021, 12:41 PM · Restricted Project

May 24 2021

JDevlieghere committed rG1ec03f3de5d5: [dsymutil] Emit an error when the Mach-O exceeds the 4GB limit. (authored by JDevlieghere).
[dsymutil] Emit an error when the Mach-O exceeds the 4GB limit.
May 24 2021, 4:30 PM
JDevlieghere committed rG7bf7b80b1958: [dsymutil] Use EXIT_SUCCESS and EXIT_FAILURE (NFC) (authored by JDevlieghere).
[dsymutil] Use EXIT_SUCCESS and EXIT_FAILURE (NFC)
May 24 2021, 4:30 PM
JDevlieghere committed rGaab488ac2a56: [dsymutil] Compute the output location once per input file (NFC) (authored by JDevlieghere).
[dsymutil] Compute the output location once per input file (NFC)
May 24 2021, 4:30 PM
JDevlieghere added inline comments to D101340: Allows for dsymutil crashes to generate reproduceable information.
May 24 2021, 2:13 PM · Restricted Project
JDevlieghere accepted D103020: [lldb] Add missing mutex guards to TargetList::CreateTarget.

LGTM

May 24 2021, 10:12 AM · Restricted Project

May 20 2021

JDevlieghere accepted D102845: [lldb] Fix that LLDB doesn't print NaN's sign on Darwin.

LGTM

May 20 2021, 8:16 PM · Restricted Project
JDevlieghere committed rG8dd106028b15: [debugserver] Add platform cache support to improve performance. (authored by kuperxu).
[debugserver] Add platform cache support to improve performance.
May 20 2021, 7:11 PM
JDevlieghere closed D102833: [debugserver]Add platform cache support to improve performance.Under BigSur 11.3 this function causes a performance loss of 0.68s per execution..
May 20 2021, 7:11 PM · Restricted Project
JDevlieghere accepted D102889: [lldb] Match test dependencies name to other LLVM projects..

LGTM

May 20 2021, 4:54 PM · Restricted Project
JDevlieghere added a comment to D102833: [debugserver]Add platform cache support to improve performance.Under BigSur 11.3 this function causes a performance loss of 0.68s per execution..

Please let me know if you want me to land this for you.

May 20 2021, 10:11 AM · Restricted Project
JDevlieghere accepted D102833: [debugserver]Add platform cache support to improve performance.Under BigSur 11.3 this function causes a performance loss of 0.68s per execution..

LGTM

May 20 2021, 10:10 AM · Restricted Project

May 19 2021

JDevlieghere added a comment to D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target.
In D102811#2769686, @teemperor wrote:

First and foremost: Cool new username. +1 from me.

May 19 2021, 7:22 PM · Restricted Project
JDevlieghere accepted D102677: [lldb][NFC] Remove misleading ModulePass base class for IRForTarget.

LGTM

May 19 2021, 10:19 AM · Restricted Project
JDevlieghere added inline comments to D101835: [llvm] llvm-tapi-diff.
May 19 2021, 9:46 AM · Restricted Project
JDevlieghere accepted D102771: [lldb] Introduce createTestTarget for creating a valid target in API tests.

Great improvement. Could you add this to the TestSampleTest.py as well? I think it's used a lot as a starting point and thus would help with discoverability.

May 19 2021, 9:32 AM · Restricted Project

May 17 2021

JDevlieghere accepted D102658: [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex.

LGTM

May 17 2021, 5:04 PM · Restricted Project
JDevlieghere accepted D102597: [lldb][NFC] Remove all uses of StringRef::withNullAsEmpty in LLDB.

🚢 it

May 17 2021, 10:39 AM · Restricted Project

May 13 2021

JDevlieghere committed rGf93e9c12bf48: [lldb] Fixup indirect symbols as they are signed. (authored by JDevlieghere).
[lldb] Fixup indirect symbols as they are signed.
May 13 2021, 10:27 AM
JDevlieghere committed rGce12b52de2fb: [lldb] Fixup more code addresses (authored by JDevlieghere).
[lldb] Fixup more code addresses
May 13 2021, 10:27 AM

May 11 2021

JDevlieghere committed rGcba508fb6787: [TextAPI] Reformat llvm_unreachable message (authored by spowell).
[TextAPI] Reformat llvm_unreachable message
May 11 2021, 10:00 AM
JDevlieghere closed D102250: [TextAPI] Reformat llvm_unreachable message.
May 11 2021, 10:00 AM · Restricted Project
JDevlieghere accepted D102250: [TextAPI] Reformat llvm_unreachable message.

LGTM

May 11 2021, 9:35 AM · Restricted Project

May 10 2021

JDevlieghere added inline comments to D101835: [llvm] llvm-tapi-diff.
May 10 2021, 3:31 PM · Restricted Project

May 6 2021

JDevlieghere accepted D101933: If an interrupt fails, don't try to fetch any more packets from the server.
May 6 2021, 10:43 AM · Restricted Project

May 5 2021

JDevlieghere requested changes to D101835: [llvm] llvm-tapi-diff.
May 5 2021, 9:42 AM · Restricted Project
JDevlieghere accepted D101903: [LLDB] Don't use the local python to set a default for LLDB_PYTHON_RELATIVE_PATH when cross compiling..
May 5 2021, 8:38 AM · Restricted Project

May 4 2021

JDevlieghere accepted D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match.

LGTM

May 4 2021, 10:04 PM · Restricted Project

May 3 2021

JDevlieghere committed rG2d5d720df0bb: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version (authored by JDevlieghere).
[debugserver] Include LLDB_VERSION_SUFFIX in debugserver version
May 3 2021, 3:06 PM
JDevlieghere closed D101655: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version.
May 3 2021, 3:05 PM · Restricted Project
JDevlieghere accepted D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

LGTM

May 3 2021, 2:34 PM · Restricted Project

Apr 30 2021

JDevlieghere added inline comments to D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match.
Apr 30 2021, 3:12 PM · Restricted Project
JDevlieghere added inline comments to D101655: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version.
Apr 30 2021, 12:06 PM · Restricted Project
JDevlieghere requested review of D101655: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version.
Apr 30 2021, 12:05 PM · Restricted Project

Apr 29 2021

JDevlieghere added a comment to D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

A few nits but overall this looks like a great cleanup!

Apr 29 2021, 11:04 PM · Restricted Project
JDevlieghere added a comment to D100962: [lldb/Core] Add SourceLocationSpec class (NFC).

A few more comments about things I missed in the previous review.

Apr 29 2021, 10:57 PM · Restricted Project
JDevlieghere committed rGb535459d0a1d: [debugserver] Use add_lldb_library instead of add_library (authored by JDevlieghere).
[debugserver] Use add_lldb_library instead of add_library
Apr 29 2021, 10:09 PM
JDevlieghere closed D101596: [debugserver] Use add_lldb_library.
Apr 29 2021, 10:09 PM · Restricted Project
JDevlieghere updated the summary of D101596: [debugserver] Use add_lldb_library.
Apr 29 2021, 9:59 PM · Restricted Project
JDevlieghere requested review of D101596: [debugserver] Use add_lldb_library.
Apr 29 2021, 9:57 PM · Restricted Project
JDevlieghere accepted D101556: [lldb] Move and clean-up the Declaration class (NFC).

LGTM

Apr 29 2021, 8:20 PM · Restricted Project
JDevlieghere added inline comments to D100962: [lldb/Core] Add SourceLocationSpec class (NFC).
Apr 29 2021, 8:17 PM · Restricted Project
JDevlieghere accepted D100962: [lldb/Core] Add SourceLocationSpec class (NFC).

LGTM

Apr 29 2021, 8:09 PM · Restricted Project
JDevlieghere added a comment to D101250: Wrap edit line configuration calls into helper functions.
In D101250#2726592, @nealsid wrote:

Friendly ping - let me know if I misunderstood the comments or if anything else is needed! Thanks again.

Apr 29 2021, 1:52 PM · Restricted Project
JDevlieghere added inline comments to D101556: [lldb] Move and clean-up the Declaration class (NFC).
Apr 29 2021, 12:36 PM · Restricted Project
JDevlieghere added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 29 2021, 9:38 AM · Restricted Project
JDevlieghere accepted D101537: [lldb] Make the NSSet formatter faster and less prone to infinite recursion.

Looks reasonable to me. Barring a good explanation for the dereference -> address of roundtrip, this LGTM.

Apr 29 2021, 9:36 AM · Restricted Project

Apr 28 2021

JDevlieghere added a comment to D62732: [RISCV] Add SystemV ABI.
In D62732#2724078, @luismarques wrote:
In D62732#2724040, @JDevlieghere wrote:

Any update on the testing strategy yet? It seems like that this is actively being used and worked on, so I'm generally supportive of landing this with some elementary coverage.

A while ago I got a skeleton of lldb-server compiling for RISC-V, but it seemed like it would be quite a bit of work to flesh out that implementation. I can only allocate some amount of effort to that right now, so that part might take a while to get finished.

Apr 28 2021, 4:38 PM · Restricted Project
JDevlieghere added a comment to D62732: [RISCV] Add SystemV ABI.

Any update on the testing strategy yet? It seems like that this is actively being used and worked on, so I'm generally supportive of landing this with some elementary coverage.

Apr 28 2021, 2:47 PM · Restricted Project
JDevlieghere accepted D101406: Rename human-readable name for DW_LANG_Mips_Assembler.

LGTM

Apr 28 2021, 2:42 PM · Restricted Project
JDevlieghere committed rG625bd94c6d64: [dsymutil] Add flag to force a static variable to keep its enclosing function (authored by JDevlieghere).
[dsymutil] Add flag to force a static variable to keep its enclosing function
Apr 28 2021, 11:33 AM