JDevlieghere (Jonas Devlieghere)
Compiler Engineer at Apple

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (94 w, 1 d)

Recent Activity

Today

JDevlieghere added a comment to D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record.

This also ensures that if fno_save_optimization_record is specified, you don't overwrite it by setting the file. This is definitely something you'd want to add to your test case.

Mon, Nov 20, 7:16 AM
JDevlieghere added a comment to D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record.

I think you can achieve the same result with less code by checking for the flag's presence higher up, where currently OPT_fsave_optimization_record is handled (Clang.cpp:4329). Something like:

Mon, Nov 20, 7:14 AM
JDevlieghere created D40244: [dsymutil] Upstream getBundleInfo implementation.
Mon, Nov 20, 6:13 AM

Yesterday

JDevlieghere added inline comments to D40200: [DWARF] Fix handling of extended line-number opcodes.
Sun, Nov 19, 11:22 AM · debug-info

Fri, Nov 17

JDevlieghere accepted D40110: Use TempFile in dsymutil.

Thanks Rafael, LGTM!

Fri, Nov 17, 1:36 AM
JDevlieghere added a project to D40156: Fix recursive attribute fetching in DWARFDie: debug-info.
Fri, Nov 17, 1:35 AM · debug-info

Thu, Nov 16

JDevlieghere added inline comments to D40110: Use TempFile in dsymutil.
Thu, Nov 16, 11:54 AM
JDevlieghere added a comment to D40114: [DebugInfo] Dump a .debug_line section, with line-number program, without a compile unit..

Thanks for accepting, Jonas! FWIW accepting by itself does not cause Phab to send email, there still needs to be a comment.

Thu, Nov 16, 11:18 AM · debug-info
JDevlieghere accepted D40135: Make exitDsymutil static.

Thanks Rafael!

Thu, Nov 16, 9:13 AM
JDevlieghere accepted D40114: [DebugInfo] Dump a .debug_line section, with line-number program, without a compile unit..
Thu, Nov 16, 3:34 AM · debug-info
JDevlieghere accepted D40104: [SelectionDAG] Consolidate (t|T)ransferDbgValues methods, NFC..

Great!

Thu, Nov 16, 3:26 AM · debug-info
JDevlieghere added inline comments to D40110: Use TempFile in dsymutil.
Thu, Nov 16, 2:53 AM

Wed, Nov 15

JDevlieghere added a project to D39982: [IRBuilder] Set the insert point and debug location together: debug-info.
Wed, Nov 15, 9:36 AM · debug-info
JDevlieghere added a project to D39950: [DebugInfo] Stable sort symbols to remove non-deterministic ordering: debug-info.
Wed, Nov 15, 9:34 AM · debug-info
JDevlieghere added a project to D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo: debug-info.
Wed, Nov 15, 9:34 AM · debug-info
JDevlieghere accepted D40057: Simplify file handling in dsymutil.
Wed, Nov 15, 9:32 AM
JDevlieghere added a project to D38719: [llvm-dwarfdump] Verify compatible TAG for attributes.: debug-info.
Wed, Nov 15, 8:34 AM · debug-info
JDevlieghere created debug-info.
Wed, Nov 15, 8:33 AM
JDevlieghere committed rL318289: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs..
[DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs.
Wed, Nov 15, 2:58 AM
JDevlieghere closed D39981: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs. by committing rL318289: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs..
Wed, Nov 15, 2:58 AM
JDevlieghere added a comment to D40057: Simplify file handling in dsymutil.

Thanks Rafael! I added the ToolOutputFile when implementing the threading option because I wanted to make sure files were removed if some thread were to exist dsymutil. Because we only use threads when there are multiple architectures which in turn implies we use temp files, we would indeed end up removing the file twice.

Wed, Nov 15, 2:52 AM

Tue, Nov 14

JDevlieghere updated the diff for D39981: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs..
  • Further reduced testcase
  • Use %llc_dwarf
Tue, Nov 14, 9:32 AM
JDevlieghere added inline comments to D39981: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs..
Tue, Nov 14, 9:32 AM
JDevlieghere updated the diff for D39981: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs..
  • Add source and description to test case
Tue, Nov 14, 2:02 AM

Mon, Nov 13

JDevlieghere created D39981: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs..
Mon, Nov 13, 2:26 PM
JDevlieghere added a comment to D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo.

Oh, head-smack! You don't need a unit to know the address size; the line table has always had that info, although indirectly.
DW_LNE_set_address (the only opcode that specifies an actual address) is an extended opcode, which has a ULEB telling you how long the operands are. Which is, one byte for the opcode, and.... the size of the address. Doh!

That means, DWARF v5 is the first time we actually *do* (sometimes) need a unit to parse the .debug_line section, instead of the first time we *don't* need it.

This patch is about one of the cases where we do need a DWARFUnit, so I think it's not particularly affected by this revelation, but there is likely to be some simplification that can be done as a follow-up.

Mon, Nov 13, 3:41 AM · debug-info

Fri, Nov 10

JDevlieghere added inline comments to D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo.
Fri, Nov 10, 6:45 AM · debug-info

Wed, Nov 8

JDevlieghere accepted D39503: Let replaceVTableHolder accept any type.

Looks good to me, but let's wait for Adrian's approval before landing.

Wed, Nov 8, 2:19 AM

Mon, Nov 6

JDevlieghere committed rL317472: [docs] Update code block for compatibility with Sphinx 1.5.1.
[docs] Update code block for compatibility with Sphinx 1.5.1
Mon, Nov 6, 3:48 AM

Thu, Nov 2

JDevlieghere committed rL317226: [dsymutil][doc] Improve wording in manpage and rename file..
[dsymutil][doc] Improve wording in manpage and rename file.
Thu, Nov 2, 11:45 AM
JDevlieghere closed D39561: [dsymutil][doc] Improve wording and rename file. by committing rL317226: [dsymutil][doc] Improve wording in manpage and rename file..
Thu, Nov 2, 11:45 AM
JDevlieghere created D39561: [dsymutil][doc] Improve wording and rename file..
Thu, Nov 2, 11:28 AM
JDevlieghere committed rL317221: [dsymutil] Add a manpage for dsymutil.
[dsymutil] Add a manpage for dsymutil
Thu, Nov 2, 10:13 AM

Wed, Nov 1

JDevlieghere added inline comments to D39503: Let replaceVTableHolder accept any type.
Wed, Nov 1, 1:58 PM
JDevlieghere added reviewers for D39503: Let replaceVTableHolder accept any type: aprantl, dblaikie.
Wed, Nov 1, 1:51 PM
JDevlieghere committed rL317104: [dsymutil][NFC} Rename thread related command line options.
[dsymutil][NFC} Rename thread related command line options
Wed, Nov 1, 10:16 AM
JDevlieghere closed D39496: [dsymutil][NFC} Rename thread related command line options by committing rL317104: [dsymutil][NFC} Rename thread related command line options.
Wed, Nov 1, 10:15 AM
JDevlieghere added a dependency for D39496: [dsymutil][NFC} Rename thread related command line options: D39355: [dsymutil] Implement the --threads option.
Wed, Nov 1, 9:36 AM
JDevlieghere added a dependent revision for D39355: [dsymutil] Implement the --threads option: D39496: [dsymutil][NFC} Rename thread related command line options.
Wed, Nov 1, 9:36 AM
JDevlieghere created D39496: [dsymutil][NFC} Rename thread related command line options.
Wed, Nov 1, 9:34 AM
JDevlieghere added a comment to D39355: [dsymutil] Implement the --threads option.

How does the conflict manifest? The option registry shouldn't conflict because dsymutil's option is in a separate category. Or is it the alias that is conflicting? It would be good to understand this. Renaming the option would break compatibility for existing users of dsymutil, so we should avoid that.

Wed, Nov 1, 9:18 AM
JDevlieghere added a comment to D39355: [dsymutil] Implement the --threads option.

The conflicting option is defined in lib/LTO/ThinLTOCodeGenerator.cpp. I'm thinking we should just make llvm-dsymutil consistent with llvm-cov and llvm-profdata and rename the option to -num-threads and -j?

Wed, Nov 1, 5:33 AM

Tue, Oct 31

JDevlieghere added a comment to D39355: [dsymutil] Implement the --threads option.

Thanks Jacob for reporting this. I can indeed reproduce the problem locally by passing those flags to cmake. I'll have a look tomorrow and see what I can find out.

Tue, Oct 31, 4:56 PM
JDevlieghere committed rL317001: [test] Fix dsymutil/cmdline.test.
[test] Fix dsymutil/cmdline.test
Tue, Oct 31, 7:19 AM
JDevlieghere committed rL316999: [dsymutil] Implement the --threads option.
[dsymutil] Implement the --threads option
Tue, Oct 31, 6:54 AM
JDevlieghere closed D39355: [dsymutil] Implement the --threads option by committing rL316999: [dsymutil] Implement the --threads option.
Tue, Oct 31, 6:54 AM

Fri, Oct 27

JDevlieghere added inline comments to D39355: [dsymutil] Implement the --threads option.
Fri, Oct 27, 11:15 AM
JDevlieghere updated the diff for D39355: [dsymutil] Implement the --threads option.
Fri, Oct 27, 11:15 AM
JDevlieghere planned changes to D39355: [dsymutil] Implement the --threads option.
Fri, Oct 27, 9:23 AM

Thu, Oct 26

JDevlieghere created D39355: [dsymutil] Implement the --threads option.
Thu, Oct 26, 6:08 PM
JDevlieghere set the repository for D39343: Do not add discriminator encoding for debug intrinsics. to rL LLVM.
Thu, Oct 26, 1:59 PM
JDevlieghere added inline comments to D39310: [CGBlocks] Improve line info in backtraces containing *_helper_block.
Thu, Oct 26, 9:13 AM
JDevlieghere accepted D39294: [llvm-dwarfdump] - Teach verifier to report broken DWARF expressions..

Thanks, George! LGTM

Thu, Oct 26, 9:08 AM

Wed, Oct 25

JDevlieghere added inline comments to D39310: [CGBlocks] Improve line info in backtraces containing *_helper_block.
Wed, Oct 25, 6:04 PM
JDevlieghere committed rL316619: Re-land "[dwarfdump] Add -lookup option".
Re-land "[dwarfdump] Add -lookup option"
Wed, Oct 25, 2:57 PM
JDevlieghere added inline comments to D39294: [llvm-dwarfdump] - Teach verifier to report broken DWARF expressions..
Wed, Oct 25, 2:00 PM
JDevlieghere added inline comments to D39294: [llvm-dwarfdump] - Teach verifier to report broken DWARF expressions..
Wed, Oct 25, 1:52 PM

Tue, Oct 24

JDevlieghere added a comment to D39119: [llvm-dwarfdump] - Teach tool about few GNU call_sites constants..

@JDevlieghere: could you perhaps help @grimar to figure out what is missing here?

Tue, Oct 24, 9:05 AM

Mon, Oct 23

JDevlieghere added inline comments to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Mon, Oct 23, 6:11 PM · Unknown Object (Project)

Oct 20 2017

JDevlieghere accepted D38777: [wasm] readSection: Avoid reading past eof (fixes oss-fuzz #3219).
Oct 20 2017, 3:52 PM

Oct 16 2017

JDevlieghere added inline comments to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Oct 16 2017, 8:18 AM · Unknown Object (Project)

Oct 13 2017

JDevlieghere added inline comments to D38777: [wasm] readSection: Avoid reading past eof (fixes oss-fuzz #3219).
Oct 13 2017, 3:15 PM
JDevlieghere added inline comments to D38777: [wasm] readSection: Avoid reading past eof (fixes oss-fuzz #3219).
Oct 13 2017, 3:00 PM
JDevlieghere added inline comments to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.
Oct 13 2017, 10:58 AM · Unknown Object (Project)
JDevlieghere accepted D38879: [llvm-dwarfdump] - Teach tool to parse DW_CFA_GNU_args_size..
Oct 13 2017, 9:32 AM
JDevlieghere added a comment to D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches.

I very much like this check. I only have a few minor comments, but maybe this encourages others to have a look too!

Oct 13 2017, 8:32 AM · Unknown Object (Project)
JDevlieghere added a comment to D38879: [llvm-dwarfdump] - Teach tool to parse DW_CFA_GNU_args_size..

Currently llvm-dwarfdump runs into llvm_unreachable when faces DW_CFA_GNU_args_size.

+Jonas: That seems like a serious bug, by the way. The DWARF parser should never assert on invalid input, it should only assert when internal consistency checks fail. The end goal is to integrate libDebugInfo into LLDB.

Oct 13 2017, 7:58 AM
JDevlieghere committed rL315684: Re-land "[dsymutil] Timestmap verification for __swift_ast".
Re-land "[dsymutil] Timestmap verification for __swift_ast"
Oct 13 2017, 7:41 AM

Oct 11 2017

JDevlieghere committed rL315458: Revert "[dsymutil] Timestmap verification for __swift_ast".
Revert "[dsymutil] Timestmap verification for __swift_ast"
Oct 11 2017, 6:51 AM
JDevlieghere committed rL315456: [dsymutil] Timestmap verification for __swift_ast.
[dsymutil] Timestmap verification for __swift_ast
Oct 11 2017, 6:35 AM
JDevlieghere closed D38686: [dsymutil] Timestmap verification for __swift_ast by committing rL315456: [dsymutil] Timestmap verification for __swift_ast.
Oct 11 2017, 6:35 AM

Oct 10 2017

JDevlieghere updated the diff for D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
  • Feedback Adrian
Oct 10 2017, 10:12 AM · debug-info
JDevlieghere added inline comments to D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
Oct 10 2017, 10:06 AM · debug-info
JDevlieghere updated the diff for D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
  • Better error message
Oct 10 2017, 10:02 AM · debug-info
JDevlieghere committed rL315316: Re-land "[llvm-dwarfdump] Print type names in DW_AT_type DIEs".
Re-land "[llvm-dwarfdump] Print type names in DW_AT_type DIEs"
Oct 10 2017, 7:15 AM
JDevlieghere committed rL315299: Revert "[llvm-dwarfdump] Print type names in DW_AT_type DIEs".
Revert "[llvm-dwarfdump] Print type names in DW_AT_type DIEs"
Oct 10 2017, 4:50 AM
JDevlieghere committed rL315297: [llvm-dwarfdump] Print type names in DW_AT_type DIEs.
[llvm-dwarfdump] Print type names in DW_AT_type DIEs
Oct 10 2017, 4:25 AM
JDevlieghere closed D36993: [llvm-dwarfdump] Print type names in DW_AT_type DIEs by committing rL315297: [llvm-dwarfdump] Print type names in DW_AT_type DIEs.
Oct 10 2017, 4:24 AM
JDevlieghere created D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
Oct 10 2017, 3:49 AM · debug-info
JDevlieghere updated the diff for D38686: [dsymutil] Timestmap verification for __swift_ast.
  • Update tests to check for warnings
Oct 10 2017, 2:14 AM

Oct 9 2017

JDevlieghere added inline comments to D38686: [dsymutil] Timestmap verification for __swift_ast.
Oct 9 2017, 4:33 PM
JDevlieghere added inline comments to D38453: [dwarfdump] Verify that unit type matches root DIE.
Oct 9 2017, 3:34 PM
JDevlieghere committed rL315244: [DWARF] DW_TAG_imported_unit is not a unit type..
[DWARF] DW_TAG_imported_unit is not a unit type.
Oct 9 2017, 3:34 PM
JDevlieghere updated the diff for D38686: [dsymutil] Timestmap verification for __swift_ast.
  • Format changes
Oct 9 2017, 11:47 AM
JDevlieghere created D38686: [dsymutil] Timestmap verification for __swift_ast.
Oct 9 2017, 4:41 AM

Oct 6 2017

JDevlieghere committed rL315121: [dwarfdump] Verify that unit type matches root DIE.
[dwarfdump] Verify that unit type matches root DIE
Oct 6 2017, 3:29 PM
JDevlieghere closed D38453: [dwarfdump] Verify that unit type matches root DIE by committing rL315121: [dwarfdump] Verify that unit type matches root DIE.
Oct 6 2017, 3:29 PM
JDevlieghere added inline comments to D38453: [dwarfdump] Verify that unit type matches root DIE.
Oct 6 2017, 11:55 AM
JDevlieghere updated the diff for D36993: [llvm-dwarfdump] Print type names in DW_AT_type DIEs.
  • Rebase on master
  • Add FIXME regarding pretty printers
Oct 6 2017, 8:06 AM
JDevlieghere added a comment to D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.

Moving your test to the X86 subfolder will solve this. They are automatically disabled (see lit.local.cfg) when there's no X86 backend, which is what's causing some bots to fail.

Oct 6 2017, 2:28 AM

Oct 5 2017

JDevlieghere accepted D38587: [dsymutil] Emit valid debug locations when no symbol flags are set.

Looks good with Adrian's comments addressed.

Oct 5 2017, 10:09 AM
JDevlieghere accepted D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.

Thanks Francis, LGTM!

Oct 5 2017, 10:05 AM

Oct 4 2017

JDevlieghere added inline comments to D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.
Oct 4 2017, 1:54 PM

Oct 3 2017

JDevlieghere committed rL314818: [test] Fix llvm-dwarfdump/cmdline.test.
[test] Fix llvm-dwarfdump/cmdline.test
Oct 3 2017, 10:30 AM
JDevlieghere committed rL314817: [dwarfdump] Add -lookup option.
[dwarfdump] Add -lookup option
Oct 3 2017, 10:12 AM
JDevlieghere closed D38409: [dwarfdump] Add -lookup option by committing rL314817: [dwarfdump] Add -lookup option.
Oct 3 2017, 10:12 AM
JDevlieghere added a comment to D38504: [llvm-dsymutil] Add support for __swift_ast MachO DWARF section.

This LGTM. We should probably also have a test for this. Committing a swift binary upstream might not be the best idea but I don't see an alternative.

Oct 3 2017, 10:09 AM
JDevlieghere abandoned D38462: [DebugInfo] Replace unreachable with ReportError in debug frame parser..
Oct 3 2017, 8:49 AM

Oct 2 2017

JDevlieghere added a comment to D38462: [DebugInfo] Replace unreachable with ReportError in debug frame parser..

Thanks guys, I should've given this more thought!

Oct 2 2017, 9:28 AM
JDevlieghere added inline comments to D38453: [dwarfdump] Verify that unit type matches root DIE.
Oct 2 2017, 9:24 AM