JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (133 w, 1 d)

Recent Activity

Sat, Aug 18

JDevlieghere accepted D50639: Change how finalizeBundle selects debug location for the BUNDLE instruction.

This LGTM!

Sat, Aug 18, 9:19 AM

Mon, Aug 13

JDevlieghere accepted D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium.

Looks good to me.

Mon, Aug 13, 6:46 AM
JDevlieghere added inline comments to D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium.
Mon, Aug 13, 12:54 AM

Thu, Aug 9

JDevlieghere accepted D49549: Change 'clang-test' to 'check-clang' on the hacking webpage.

Looks good, thanks!

Thu, Aug 9, 8:16 AM
JDevlieghere accepted D50490: Restore correct x86_64 EH encodings in kernel code model.
  • I guess a possible alternative would have been to set LargeCodeModel to true for kernel case? Regardless, I'd prefer being explicit to prevent confusion.
  • I'm slightly worried about the default value being CodeModel::Small in case other parts in MCObjectFileInfo start relying on this, but it's definitely the most sensible.
Thu, Aug 9, 3:19 AM

Wed, Aug 8

JDevlieghere added a comment to D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections..

Few nits

Wed, Aug 8, 2:49 PM
JDevlieghere accepted D50466: [DWARF] Verifier now handles .debug_types sections..

Thanks Paul! One nit, otherwise this LGTM.

Wed, Aug 8, 2:35 PM
JDevlieghere committed rL339288: [DWARF] Unclamp line table version on Darwin for v5 and later..
[DWARF] Unclamp line table version on Darwin for v5 and later.
Wed, Aug 8, 2:17 PM
JDevlieghere closed D49381: [DWARF] Unclamp line table version on Darwin for v5 and later..
Wed, Aug 8, 2:17 PM · debug-info
JDevlieghere committed rL339269: [WASM] Fix overflow when reading custom section.
[WASM] Fix overflow when reading custom section
Wed, Aug 8, 9:34 AM
JDevlieghere closed D50387: [WASM] Fix overflow when reading custom section.
Wed, Aug 8, 9:34 AM
JDevlieghere committed rL339268: [DebugInfo] Fine tune emitting flags as part of the producer.
[DebugInfo] Fine tune emitting flags as part of the producer
Wed, Aug 8, 9:33 AM
JDevlieghere closed D50453: [DebugInfo] Fine tune emitting flags as part of the producer.
Wed, Aug 8, 9:33 AM
JDevlieghere added a comment to D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol.

This looks really cool :-)

Wed, Aug 8, 9:02 AM
JDevlieghere retitled D50453: [DebugInfo] Fine tune emitting flags as part of the producer from [DebugInfo] Fine tune emittign flags as part of the producer to [DebugInfo] Fine tune emitting flags as part of the producer.
Wed, Aug 8, 8:23 AM
JDevlieghere created D50453: [DebugInfo] Fine tune emitting flags as part of the producer.
Wed, Aug 8, 8:22 AM
JDevlieghere updated the diff for D49381: [DWARF] Unclamp line table version on Darwin for v5 and later..

Add comment to tests explaining why this works on Darwin.

Wed, Aug 8, 5:38 AM · debug-info
JDevlieghere updated the diff for D50254: [WIP] Add GDB remote packet reproducer..

Thanks for the review Stefan!

Wed, Aug 8, 5:11 AM
JDevlieghere updated the diff for D50387: [WASM] Fix overflow when reading custom section.

Updated to use the ReadContext. If the error message doesn't matter that much then I agree this is better.

Wed, Aug 8, 4:56 AM

Tue, Aug 7

JDevlieghere added inline comments to D50387: [WASM] Fix overflow when reading custom section.
Tue, Aug 7, 11:48 AM
JDevlieghere added inline comments to D50387: [WASM] Fix overflow when reading custom section.
Tue, Aug 7, 7:54 AM
JDevlieghere created D50387: [WASM] Fix overflow when reading custom section.
Tue, Aug 7, 7:36 AM
JDevlieghere added reviewers for D50254: [WIP] Add GDB remote packet reproducer.: vsk, jingham, jasonmolenda, sgraenitz, shafik, aprantl, friss, davide.
Tue, Aug 7, 5:34 AM
JDevlieghere added inline comments to D50055: Update the coding standard about NFC changes and whitespace.
Tue, Aug 7, 5:28 AM
JDevlieghere committed rL339129: Fix inconsistency with/without debug information (-g).
Fix inconsistency with/without debug information (-g)
Tue, Aug 7, 5:14 AM
JDevlieghere closed D49467: Fix inconsistency with/without debug information (-g).
Tue, Aug 7, 5:14 AM

Fri, Aug 3

JDevlieghere added a comment to D50213: DebugInfo: Add metadata support for disabling DWARF pub sections.

Regarding the naming: I like PubnameKind because of the aforementioned consistency (we also have AccelTableKind. Can't we use an enum class to prevent collisions?

Fri, Aug 3, 8:21 AM
JDevlieghere added a comment to D50213: DebugInfo: Add metadata support for disabling DWARF pub sections.

Regarding the naming: I like PubnameKind because of the aforementioned consistency (we also have AccelTableKind. Can't we use an enum class to prevent collisions?

Fri, Aug 3, 8:15 AM
JDevlieghere created D50254: [WIP] Add GDB remote packet reproducer..
Fri, Aug 3, 7:10 AM
JDevlieghere committed rL338878: [DebugInfo/Verifier] Don't emit error for missing module in index.
[DebugInfo/Verifier] Don't emit error for missing module in index
Fri, Aug 3, 5:02 AM
JDevlieghere closed D50237: [DebugInfo/Verifier] Don't emit error for missing module in index.
Fri, Aug 3, 5:02 AM · debug-info
JDevlieghere created D50237: [DebugInfo/Verifier] Don't emit error for missing module in index.
Fri, Aug 3, 3:43 AM · debug-info

Thu, Aug 2

JDevlieghere accepted D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..

In the differential you linked we agreed to have the API include an error code as an argument. That still leaves us the option to pass an inconvertibleErrorCode() as the first argument.

Thu, Aug 2, 2:46 AM · debug-info
JDevlieghere added inline comments to D50159: Add byte counting mechanism to LLDB's Stream class..
Thu, Aug 2, 2:33 AM

Wed, Aug 1

JDevlieghere abandoned D49234: [DebugInfo] Refactor DWARFDie::iterator to prevent UB.

Landed alternative from D49679

Wed, Aug 1, 6:26 AM
JDevlieghere committed rL338536: [dsymutil] Convert recursion in lookForDIEsToKeep into worklist..
[dsymutil] Convert recursion in lookForDIEsToKeep into worklist.
Wed, Aug 1, 6:25 AM
JDevlieghere closed D48899: [dsymutil] Convert recursion in lookForDIEsToKeep into worklist. .
Wed, Aug 1, 6:25 AM
JDevlieghere committed rL338527: [MC] Report fatal error for DWARF types for non-ELF object files.
[MC] Report fatal error for DWARF types for non-ELF object files
Wed, Aug 1, 5:53 AM
JDevlieghere closed D50057: [MC] Report fatal error for DWARF types for non-ELF object files.
Wed, Aug 1, 5:53 AM · debug-info
JDevlieghere committed rL338511: [DebugInfo] Remove ambiguity to fix Windows bots.
[DebugInfo] Remove ambiguity to fix Windows bots
Wed, Aug 1, 3:40 AM
JDevlieghere committed rL338509: [DebugInfo] Improve consistency in DWARFDie.h (NFC).
[DebugInfo] Improve consistency in DWARFDie.h (NFC)
Wed, Aug 1, 3:31 AM
JDevlieghere committed rL338506: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
[DebugInfo] Have custom std::reverse_iterator<DWARFDie>
Wed, Aug 1, 3:25 AM
JDevlieghere closed D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
Wed, Aug 1, 3:24 AM

Tue, Jul 31

JDevlieghere added inline comments to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Tue, Jul 31, 7:47 AM · debug-info
JDevlieghere added inline comments to D49676: [DWARF] support for .debug_addr (consumer).
Tue, Jul 31, 7:42 AM · debug-info
JDevlieghere updated the diff for D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
  • Address Dave's feedback
Tue, Jul 31, 7:18 AM
JDevlieghere created D50057: [MC] Report fatal error for DWARF types for non-ELF object files.
Tue, Jul 31, 5:53 AM · debug-info
JDevlieghere added inline comments to D49381: [DWARF] Unclamp line table version on Darwin for v5 and later..
Tue, Jul 31, 5:48 AM · debug-info
JDevlieghere abandoned D49472: [WIP] Always create a MCFragment for Mach-O section..

The consensus is that we won't support this, at least for now.

Tue, Jul 31, 5:05 AM
JDevlieghere accepted D50048: [Windows FS] Allow moving files in TempFile::keep.

LGTM, Thanks for catching this!

Tue, Jul 31, 3:46 AM
JDevlieghere added inline comments to D49744: [DebugInfo/DWARF] [4/4] De-segregate type units and compile units. NFC.
Tue, Jul 31, 3:37 AM · debug-info
JDevlieghere accepted D49909: Unit test for Symtab::InitNameIndexes.

I agree with Pavel, but I also don't mind having this test in the meantime. LGTM if you add a FIXME with the direction we want to go.

Tue, Jul 31, 3:24 AM

Sun, Jul 29

JDevlieghere accepted D49467: Fix inconsistency with/without debug information (-g).
Sun, Jul 29, 10:06 AM
JDevlieghere added inline comments to D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC..
Sun, Jul 29, 8:20 AM · debug-info
JDevlieghere committed rL338216: [dsymutil] Simplify temporary file handling..
[dsymutil] Simplify temporary file handling.
Sun, Jul 29, 7:56 AM
JDevlieghere closed D49860: [dsymutil] Simplify temporary file handling..
Sun, Jul 29, 7:56 AM

Thu, Jul 26

JDevlieghere added inline comments to D49860: [dsymutil] Simplify temporary file handling..
Thu, Jul 26, 8:44 AM
JDevlieghere created D49860: [dsymutil] Simplify temporary file handling..
Thu, Jul 26, 8:35 AM
JDevlieghere added a comment to rL338031: dwarfgen: Add support for generating the debug_str_offsets section, take 3.

Third time's the charm!

Thu, Jul 26, 7:37 AM
JDevlieghere committed rL338030: [test] Disable dsymutil update test on windows.
[test] Disable dsymutil update test on windows
Thu, Jul 26, 7:16 AM
JDevlieghere committed rL338014: [test] Do dsymutil update in place.
[test] Do dsymutil update in place
Thu, Jul 26, 2:23 AM
JDevlieghere added a comment to D49824: [Support] Introduce createStringError helper function.

Lang's suggestion was indeed what I had in mind. Thanks!

Thu, Jul 26, 1:16 AM

Wed, Jul 25

JDevlieghere added a comment to D49467: Fix inconsistency with/without debug information (-g).

Please run the test through llvm-as | llvm-dis, this will fix the numbering of the DI nodes.

Wed, Jul 25, 4:22 PM
JDevlieghere added a reviewer for D49824: [Support] Introduce createStringError helper function: lhames.
Wed, Jul 25, 4:16 PM
JDevlieghere added a comment to D49824: [Support] Introduce createStringError helper function.

Can you add a test for the case where no Vals are provided? I remember something about that requiring an overload without the variadic template arguments.

Wed, Jul 25, 4:15 PM
JDevlieghere added a comment to D49819: [bcanalyzer] Update MODULE_CODE values.

Thanks for the comments, Jonas. I grepped through the tests and saw that none of them were checking against the UnknownCode string that would have been produced. It looks like I'll need to create a bitcode file that contains the codes and create a new test based on that.

Wed, Jul 25, 4:12 PM
JDevlieghere committed rL337980: [dsymutil] Add support for generating DWARF5 accelerator tables..
[dsymutil] Add support for generating DWARF5 accelerator tables.
Wed, Jul 25, 4:02 PM
JDevlieghere closed D49137: [dsymutil] Implement DWARF5 accelerator tables..
Wed, Jul 25, 4:01 PM
JDevlieghere accepted D49815: [DWARF v5] Don't report an error when the .debug_rnglists section is empty or non-existent (PR 38297).

LGTM.

Wed, Jul 25, 3:36 PM
JDevlieghere added a comment to D49819: [bcanalyzer] Update MODULE_CODE values.

Thanks Adam, the change looks good but would need a test indeed. Currently the codes are not printed if they are not known, so maybe by adding them they are now printed in one of the existing tests? It would be fine to add a new test if we can't reuse an existing one.

Wed, Jul 25, 3:34 PM
JDevlieghere committed rL337932: [ProcessGDBRemote] handle result from ConnectToDebugserver.
[ProcessGDBRemote] handle result from ConnectToDebugserver
Wed, Jul 25, 8:20 AM
JDevlieghere accepted D49612: Use LLVM's new ItaniumPartialDemangler in LLDB.

Given these numbers I think we can land this patch as is and figure out the IDP stuff on the mailing list and/or a future patch. LGTM. Thanks Stefan!

Wed, Jul 25, 6:57 AM
JDevlieghere updated the diff for D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
  • Address Dave's feedback
Wed, Jul 25, 5:41 AM

Tue, Jul 24

JDevlieghere retitled D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie> from [DebugInfo] Have custom DWARFDie:: reverse_iterator to [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
Tue, Jul 24, 7:46 AM
JDevlieghere updated the diff for D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.

Address Pavel's feedback:

Tue, Jul 24, 7:45 AM
JDevlieghere updated the diff for D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
  • Specialize std::reverse_iterator for llvm::DWARFDie as suggested by Pavel.
Tue, Jul 24, 7:11 AM
JDevlieghere set the repository for D49676: [DWARF] support for .debug_addr (consumer) to rL LLVM.
Tue, Jul 24, 3:31 AM · debug-info
JDevlieghere added a comment to D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.

Sorry I wrote the reply without looking at the patch in detail. I did not notice you demoted the iterator back to "forward". In case this is not a bidirectional operator, but a collection of two forward iterators that happen to iterate in the reverse order, the specializing std::reverse_iterator is not the right approach.

I have to admit I haven't thought about the specifics of how the reverse iterator would work until now. However, now that I think about it, I think it could be implemented as a pair of DWARFDie + bool flag. The trick would be that we store the element that we really dereference to, instead of its successor. The bool flag would be used denote the before_begin state, as we cannot represent rend() this way. The implementation would do something like:

operator++() {
  assert(!AtEnd && "Incrementing rend");
  DWARFDie D = Die.getPreviousSibling();
  if (D)
    Die = D;
  else
    AtEnd = true;
}

operator--() {
  if (AtEnd) {
    AtEnd = false;
    return;
  }
  Die = Die.getNextSibling();
  assert(!Die.isNULL() && "Decrementing rbegin");
}
Tue, Jul 24, 3:30 AM
JDevlieghere added inline comments to D49612: Use LLVM's new ItaniumPartialDemangler in LLDB.
Tue, Jul 24, 3:20 AM
JDevlieghere added a comment to D49670: dwarfgen: Add support for generating the debug_str_offsets section.

Looks good to me but I'll defer to Greg and Dave who had actual feedback.

Tue, Jul 24, 3:07 AM
JDevlieghere updated the diff for D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
  • Feedback Pavel
Tue, Jul 24, 3:01 AM

Mon, Jul 23

JDevlieghere added a comment to D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.

What's the reason for not specializing std::reverse_iterator? AFAIK, that is officially permitted by the standard.

Mon, Jul 23, 2:02 PM
JDevlieghere accepted D49500: [DWARF v5] Refactor range lists dumping (NFC except for spelling changes in dump output)..

Other than the DIDumpOptions comment (which I think you might have missed) this LGTM.

Mon, Jul 23, 11:35 AM
JDevlieghere updated the diff for D49137: [dsymutil] Implement DWARF5 accelerator tables..
  • Ignore modules for now as discussed offline.
  • Document this decision.
Mon, Jul 23, 11:32 AM
JDevlieghere committed rC337717: [DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target..
[DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target.
Mon, Jul 23, 10:50 AM
JDevlieghere committed rL337717: [DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target..
[DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target.
Mon, Jul 23, 10:50 AM
JDevlieghere closed D49594: [DebugInfo] Emit diagnostics when enabling -fdebug-types-section on non-linux target..
Mon, Jul 23, 10:50 AM · debug-info
JDevlieghere updated the diff for D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
Mon, Jul 23, 10:40 AM
JDevlieghere added a comment to D49234: [DebugInfo] Refactor DWARFDie::iterator to prevent UB.

I've put up https://reviews.llvm.org/D49679 as an alternative to this patch. Personally I don't like the caveat that you can't store the DWARFDie the iterators point to, but on the other hand I don't like returning by value either. Please let me know which you prefer.

Mon, Jul 23, 10:23 AM
JDevlieghere created D49679: [DebugInfo] Have custom std::reverse_iterator<DWARFDie>.
Mon, Jul 23, 10:22 AM
JDevlieghere committed rL337695: [Docs] Fix LLVM_YAML_IS_DOCUMENT_LIST_VECTOR.
[Docs] Fix LLVM_YAML_IS_DOCUMENT_LIST_VECTOR
Mon, Jul 23, 7:17 AM

Jul 20 2018

JDevlieghere added a project to D49381: [DWARF] Unclamp line table version on Darwin for v5 and later.: debug-info.
Jul 20 2018, 9:32 AM · debug-info
JDevlieghere added a comment to D49594: [DebugInfo] Emit diagnostics when enabling -fdebug-types-section on non-linux target..

Is this because type units depend on COMDAT support? I had a vague idea that COFF also supports COMDAT.

Jul 20 2018, 9:32 AM · debug-info
JDevlieghere added a comment to D49467: Fix inconsistency with/without debug information (-g).

Looks good to me, but I'll defer to Paul

Jul 20 2018, 9:16 AM
JDevlieghere updated the diff for D49594: [DebugInfo] Emit diagnostics when enabling -fdebug-types-section on non-linux target..

Thanks, I meant to use isOSBinFormatELF but I think it got lost in an accidental undo. The test didn't capture that because it's using a linux target triple.

Jul 20 2018, 5:56 AM · debug-info
JDevlieghere added a comment to D49594: [DebugInfo] Emit diagnostics when enabling -fdebug-types-section on non-linux target..

Please see PR38190 for more details.

Jul 20 2018, 3:01 AM · debug-info
JDevlieghere added inline comments to D49472: [WIP] Always create a MCFragment for Mach-O section..
Jul 20 2018, 2:57 AM
JDevlieghere created D49594: [DebugInfo] Emit diagnostics when enabling -fdebug-types-section on non-linux target..
Jul 20 2018, 2:55 AM · debug-info

Jul 19 2018

JDevlieghere accepted D49493: [DebugInfo] Reduce debug_str_offsets section size.

I'm happy with this, LGTM!

Jul 19 2018, 9:57 AM
JDevlieghere accepted D49542: DwarfDebug: Reduce duplication in addAccel*** methods.

LGTM. This is definitely much better!

Jul 19 2018, 6:54 AM