Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (159 w, 5 d)

Recent Activity

Yesterday

JDevlieghere added a parent revision for D58566: [Reproducers] Add more logging capabilities to reproducer instrumentation: D57475: [Reproducers] Add SBReproducer macros.
Fri, Feb 22, 5:40 PM · Restricted Project
JDevlieghere added a child revision for D57475: [Reproducers] Add SBReproducer macros: D58566: [Reproducers] Add more logging capabilities to reproducer instrumentation.
Fri, Feb 22, 5:40 PM · Restricted Project
JDevlieghere created D58566: [Reproducers] Add more logging capabilities to reproducer instrumentation.
Fri, Feb 22, 5:36 PM · Restricted Project
JDevlieghere retitled D58565: [Reproducers] Enable replay from SBRepro from Enable replay from SBRepro to [Reproducers] Enable replay from SBRepro.
Fri, Feb 22, 5:32 PM · Restricted Project
JDevlieghere added a parent revision for D58565: [Reproducers] Enable replay from SBRepro: D57475: [Reproducers] Add SBReproducer macros.
Fri, Feb 22, 5:32 PM · Restricted Project
JDevlieghere added a child revision for D57475: [Reproducers] Add SBReproducer macros: D58565: [Reproducers] Enable replay from SBRepro.
Fri, Feb 22, 5:32 PM · Restricted Project
JDevlieghere created D58565: [Reproducers] Enable replay from SBRepro.
Fri, Feb 22, 5:32 PM · Restricted Project
JDevlieghere added a child revision for D58564: [Reproducers] Add command provider: D57475: [Reproducers] Add SBReproducer macros.
Fri, Feb 22, 5:30 PM · Restricted Project
JDevlieghere added a parent revision for D57475: [Reproducers] Add SBReproducer macros: D58564: [Reproducers] Add command provider.
Fri, Feb 22, 5:30 PM · Restricted Project
JDevlieghere updated the diff for D57475: [Reproducers] Add SBReproducer macros.
Fri, Feb 22, 5:30 PM · Restricted Project
JDevlieghere created D58564: [Reproducers] Add command provider.
Fri, Feb 22, 5:29 PM · Restricted Project
JDevlieghere added inline comments to D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks.
Fri, Feb 22, 10:49 AM · Restricted Project

Thu, Feb 21

JDevlieghere committed rGda9059aa6620: Revert "[xcodeproj] Add SBReproducer to LLDB.framework" (authored by JDevlieghere).
Revert "[xcodeproj] Add SBReproducer to LLDB.framework"
Thu, Feb 21, 4:04 PM
JDevlieghere committed rLLDB354639: Revert "[xcodeproj] Add SBReproducer to LLDB.framework".
Revert "[xcodeproj] Add SBReproducer to LLDB.framework"
Thu, Feb 21, 4:04 PM
JDevlieghere committed rL354639: Revert "[xcodeproj] Add SBReproducer to LLDB.framework".
Revert "[xcodeproj] Add SBReproducer to LLDB.framework"
Thu, Feb 21, 4:04 PM
JDevlieghere committed rG1877e275d2cb: [xcodeproj] Add SBReproducer to LLDB.framework (authored by JDevlieghere).
[xcodeproj] Add SBReproducer to LLDB.framework
Thu, Feb 21, 3:59 PM
JDevlieghere committed rL354637: [xcodeproj] Add SBReproducer to LLDB.framework.
[xcodeproj] Add SBReproducer to LLDB.framework
Thu, Feb 21, 3:58 PM
JDevlieghere committed rLLDB354637: [xcodeproj] Add SBReproducer to LLDB.framework.
[xcodeproj] Add SBReproducer to LLDB.framework
Thu, Feb 21, 3:58 PM
JDevlieghere committed rG936c62422f5d: [Reproducers] Initialize reproducers before initializing the debugger. (authored by JDevlieghere).
[Reproducers] Initialize reproducers before initializing the debugger.
Thu, Feb 21, 2:26 PM
JDevlieghere committed rLLDB354631: [Reproducers] Initialize reproducers before initializing the debugger..
[Reproducers] Initialize reproducers before initializing the debugger.
Thu, Feb 21, 2:26 PM
JDevlieghere committed rL354631: [Reproducers] Initialize reproducers before initializing the debugger..
[Reproducers] Initialize reproducers before initializing the debugger.
Thu, Feb 21, 2:26 PM
JDevlieghere closed D58410: [Reproducers] Initialize reproducers before initializing the debugger..
Thu, Feb 21, 2:25 PM · Restricted Project, Restricted Project
JDevlieghere committed rGe0ccb403c2e2: [unittest] Fix missing user-provided default constructor (authored by JDevlieghere).
[unittest] Fix missing user-provided default constructor
Thu, Feb 21, 9:19 AM
JDevlieghere committed rLLDB354602: [unittest] Fix missing user-provided default constructor.
[unittest] Fix missing user-provided default constructor
Thu, Feb 21, 9:19 AM
JDevlieghere committed rL354602: [unittest] Fix missing user-provided default constructor.
[unittest] Fix missing user-provided default constructor
Thu, Feb 21, 9:19 AM

Wed, Feb 20

JDevlieghere accepted D58459: [lldb-mi] Remove a test that uses pexpect()..

LGTM

Wed, Feb 20, 10:26 AM · Restricted Project, Restricted Project
JDevlieghere committed rG4e9b02b0da24: [TestModuleCXX] Make this test Darwin-only. (authored by JDevlieghere).
[TestModuleCXX] Make this test Darwin-only.
Wed, Feb 20, 9:44 AM
JDevlieghere committed rLLDB354487: [TestModuleCXX] Make this test Darwin-only..
[TestModuleCXX] Make this test Darwin-only.
Wed, Feb 20, 9:43 AM
JDevlieghere committed rL354487: [TestModuleCXX] Make this test Darwin-only..
[TestModuleCXX] Make this test Darwin-only.
Wed, Feb 20, 9:43 AM
JDevlieghere updated the diff for D58410: [Reproducers] Initialize reproducers before initializing the debugger..
  • Add comment to SBReproducer.h explaining we cannot use any SB objects in the interface or implementation.
Wed, Feb 20, 9:38 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D58410: [Reproducers] Initialize reproducers before initializing the debugger..

I think this looks mostly fine. See my comment about not using SB classes in the reproducer api. I still kind of like the idea of naming the reproducer class in some special way, to make it more obvious that it is not "just another" SB class, but I'm not sure if that would be just more confusing.

Wed, Feb 20, 9:34 AM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D58410: [Reproducers] Initialize reproducers before initializing the debugger..
  • Return a string instead of an SBError
  • Make InitializeReplay perform the actual replay.
Wed, Feb 20, 9:32 AM · Restricted Project, Restricted Project

Tue, Feb 19

JDevlieghere added inline comments to D58410: [Reproducers] Initialize reproducers before initializing the debugger..
Tue, Feb 19, 10:57 PM · Restricted Project, Restricted Project
JDevlieghere committed rG78750a51d98b: [TestModuleCXX] Use UNSUPPORTED instead of REQUIRES (authored by JDevlieghere).
[TestModuleCXX] Use UNSUPPORTED instead of REQUIRES
Tue, Feb 19, 5:50 PM
JDevlieghere committed rG9b23e9ba8d1b: [Instrumentation] Make API logging unconditional (authored by JDevlieghere).
[Instrumentation] Make API logging unconditional
Tue, Feb 19, 5:50 PM
JDevlieghere committed rGb7c22314c37b: [lldb-instr] Group RECORD macros (authored by JDevlieghere).
[lldb-instr] Group RECORD macros
Tue, Feb 19, 5:50 PM
JDevlieghere committed rLLDB354425: [TestModuleCXX] Use UNSUPPORTED instead of REQUIRES.
[TestModuleCXX] Use UNSUPPORTED instead of REQUIRES
Tue, Feb 19, 5:49 PM
JDevlieghere committed rLLDB354424: [Instrumentation] Make API logging unconditional.
[Instrumentation] Make API logging unconditional
Tue, Feb 19, 5:49 PM
JDevlieghere committed rL354425: [TestModuleCXX] Use UNSUPPORTED instead of REQUIRES.
[TestModuleCXX] Use UNSUPPORTED instead of REQUIRES
Tue, Feb 19, 5:49 PM
JDevlieghere committed rL354424: [Instrumentation] Make API logging unconditional.
[Instrumentation] Make API logging unconditional
Tue, Feb 19, 5:49 PM
JDevlieghere committed rL354423: [lldb-instr] Group RECORD macros.
[lldb-instr] Group RECORD macros
Tue, Feb 19, 5:49 PM
JDevlieghere committed rLLDB354423: [lldb-instr] Group RECORD macros.
[lldb-instr] Group RECORD macros
Tue, Feb 19, 5:49 PM
JDevlieghere committed rGee04d4d84037: [lldb-instr] Don't print REGISTER macro when RECORD is already present (authored by JDevlieghere).
[lldb-instr] Don't print REGISTER macro when RECORD is already present
Tue, Feb 19, 3:14 PM
JDevlieghere committed rL354400: [lldb-instr] Don't print REGISTER macro when RECORD is already present.
[lldb-instr] Don't print REGISTER macro when RECORD is already present
Tue, Feb 19, 3:14 PM
JDevlieghere committed rLLDB354400: [lldb-instr] Don't print REGISTER macro when RECORD is already present.
[lldb-instr] Don't print REGISTER macro when RECORD is already present
Tue, Feb 19, 3:14 PM
JDevlieghere added inline comments to D58410: [Reproducers] Initialize reproducers before initializing the debugger..
Tue, Feb 19, 3:05 PM · Restricted Project, Restricted Project
JDevlieghere created D58410: [Reproducers] Initialize reproducers before initializing the debugger..
Tue, Feb 19, 3:03 PM · Restricted Project, Restricted Project
JDevlieghere committed rL354396: Checkout clang for lldb in SphinxDocsBuilder.
Checkout clang for lldb in SphinxDocsBuilder
Tue, Feb 19, 2:51 PM
JDevlieghere added inline comments to D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation).
Tue, Feb 19, 2:31 PM · Restricted Project
JDevlieghere requested changes to D51578: 02/03: Contiguous sections (.debug_info+.debug_types) for D54670==D32167 (.debug_types).

Few comments inline.

Tue, Feb 19, 2:21 PM · Restricted Project
JDevlieghere added a comment to D54670: 03/03: .debug_types: Update of D32167 (.debug_types) on top of D51578 (section concatenation).

Few style nits

Tue, Feb 19, 2:11 PM · Restricted Project

Mon, Feb 18

JDevlieghere updated the diff for D57475: [Reproducers] Add SBReproducer macros.
  • Rebase
  • Re-ran the latest version of the tool to insert LLDB_RECORD_RESULT
Mon, Feb 18, 6:03 PM · Restricted Project
JDevlieghere committed rGcd2e6c75f6df: [lldb-instr] Test that we ignore existing macros. (authored by JDevlieghere).
[lldb-instr] Test that we ignore existing macros.
Mon, Feb 18, 5:22 PM
JDevlieghere committed rL354303: [lldb-instr] Test that we ignore existing macros..
[lldb-instr] Test that we ignore existing macros.
Mon, Feb 18, 5:22 PM
JDevlieghere committed rLLDB354303: [lldb-instr] Test that we ignore existing macros..
[lldb-instr] Test that we ignore existing macros.
Mon, Feb 18, 5:22 PM
JDevlieghere committed rG091b925284ab: [lldb-instr] Wrap returns of struct/classes in LLDB_RECORD_RESULT (authored by JDevlieghere).
[lldb-instr] Wrap returns of struct/classes in LLDB_RECORD_RESULT
Mon, Feb 18, 5:04 PM
JDevlieghere committed rL354301: [lldb-instr] Wrap returns of struct/classes in LLDB_RECORD_RESULT.
[lldb-instr] Wrap returns of struct/classes in LLDB_RECORD_RESULT
Mon, Feb 18, 5:04 PM
JDevlieghere committed rLLDB354301: [lldb-instr] Wrap returns of struct/classes in LLDB_RECORD_RESULT.
[lldb-instr] Wrap returns of struct/classes in LLDB_RECORD_RESULT
Mon, Feb 18, 5:04 PM
JDevlieghere committed rG292a53308588: Disable TestModuleCXX.test on Windows (authored by JDevlieghere).
Disable TestModuleCXX.test on Windows
Mon, Feb 18, 4:11 PM
JDevlieghere committed rLLDB354300: Disable TestModuleCXX.test on Windows.
Disable TestModuleCXX.test on Windows
Mon, Feb 18, 4:10 PM
JDevlieghere committed rL354300: Disable TestModuleCXX.test on Windows.
Disable TestModuleCXX.test on Windows
Mon, Feb 18, 4:10 PM
JDevlieghere committed rGd1511a4bc734: [lldb-instr] Add constructor and move test into lit/tools (authored by JDevlieghere).
[lldb-instr] Add constructor and move test into lit/tools
Mon, Feb 18, 3:01 PM
JDevlieghere committed rLLDB354294: [lldb-instr] Add constructor and move test into lit/tools.
[lldb-instr] Add constructor and move test into lit/tools
Mon, Feb 18, 2:59 PM
JDevlieghere committed rL354294: [lldb-instr] Add constructor and move test into lit/tools.
[lldb-instr] Add constructor and move test into lit/tools
Mon, Feb 18, 2:59 PM
JDevlieghere committed rG9764b65c8233: [Reproducers] Make clang use lldb's VFS. (authored by JDevlieghere).
[Reproducers] Make clang use lldb's VFS.
Mon, Feb 18, 12:32 PM
JDevlieghere committed rLLDB354283: [Reproducers] Make clang use lldb's VFS..
[Reproducers] Make clang use lldb's VFS.
Mon, Feb 18, 12:31 PM
JDevlieghere committed rL354283: [Reproducers] Make clang use lldb's VFS..
[Reproducers] Make clang use lldb's VFS.
Mon, Feb 18, 12:31 PM
JDevlieghere closed D58309: [Reproducers] Have clang make use of lldb's VFS..
Mon, Feb 18, 12:31 PM · Restricted Project, Restricted Project

Fri, Feb 15

JDevlieghere updated the diff for D58309: [Reproducers] Have clang make use of lldb's VFS..
  • Have lldb use a custom module cache and remove it before replaying the reproducer.
  • Remove the cocoa test now that we have a capture and replay test.
Fri, Feb 15, 5:00 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D58309: [Reproducers] Have clang make use of lldb's VFS..
  • Code review feedback Adrian
Fri, Feb 15, 3:34 PM · Restricted Project, Restricted Project
JDevlieghere created D58309: [Reproducers] Have clang make use of lldb's VFS..
Fri, Feb 15, 3:06 PM · Restricted Project, Restricted Project

Thu, Feb 14

JDevlieghere added a comment to D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

In the future please include context with the diff (-U9999 should do the trick), it makes reviewing a lot easier.

Thu, Feb 14, 3:05 PM
JDevlieghere committed rGff04b3d4d72f: [ExpressionParser] Reuse the FileManager from the compiler instance. (authored by JDevlieghere).
[ExpressionParser] Reuse the FileManager from the compiler instance.
Thu, Feb 14, 10:06 AM
JDevlieghere committed rL354041: [ExpressionParser] Reuse the FileManager from the compiler instance..
[ExpressionParser] Reuse the FileManager from the compiler instance.
Thu, Feb 14, 10:05 AM
JDevlieghere committed rLLDB354041: [ExpressionParser] Reuse the FileManager from the compiler instance..
[ExpressionParser] Reuse the FileManager from the compiler instance.
Thu, Feb 14, 10:05 AM
JDevlieghere closed D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance..
Thu, Feb 14, 10:05 AM · Restricted Project

Wed, Feb 13

JDevlieghere updated the diff for D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance..

Keep/move the comment in the right place.

Wed, Feb 13, 8:53 PM · Restricted Project
JDevlieghere created D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance..
Wed, Feb 13, 8:52 PM · Restricted Project
JDevlieghere committed rG201a40c5680c: [CMake] Make lldb-test-deps a dependency of check-lldb (authored by JDevlieghere).
[CMake] Make lldb-test-deps a dependency of check-lldb
Wed, Feb 13, 12:51 PM
JDevlieghere committed rLLDB353978: [CMake] Make lldb-test-deps a dependency of check-lldb.
[CMake] Make lldb-test-deps a dependency of check-lldb
Wed, Feb 13, 12:51 PM
JDevlieghere committed rL353978: [CMake] Make lldb-test-deps a dependency of check-lldb.
[CMake] Make lldb-test-deps a dependency of check-lldb
Wed, Feb 13, 12:51 PM

Tue, Feb 12

JDevlieghere committed rGf989e585987d: [monorepo] Remove accidentally added top-level monorepo directory (authored by JDevlieghere).
[monorepo] Remove accidentally added top-level monorepo directory
Tue, Feb 12, 10:47 PM
JDevlieghere committed rL353913: [monorepo] Remove accidentally added top-level monorepo directory.
[monorepo] Remove accidentally added top-level monorepo directory
Tue, Feb 12, 10:47 PM
JDevlieghere committed rGd5b440369dbb: Replace 'ap' with 'up' suffix in variable names. (NFC) (authored by JDevlieghere).
Replace 'ap' with 'up' suffix in variable names. (NFC)
Tue, Feb 12, 10:26 PM
JDevlieghere committed rLLDB353912: Replace 'ap' with 'up' suffix in variable names. (NFC).
Replace 'ap' with 'up' suffix in variable names. (NFC)
Tue, Feb 12, 10:26 PM
JDevlieghere committed rL353912: Replace 'ap' with 'up' suffix in variable names. (NFC).
Replace 'ap' with 'up' suffix in variable names. (NFC)
Tue, Feb 12, 10:26 PM
JDevlieghere committed rG63e2e59b89f0: [Reproducers] Integrate FileProvider with clang (authored by JDevlieghere).
[Reproducers] Integrate FileProvider with clang
Tue, Feb 12, 5:31 PM
JDevlieghere committed rL353906: [Reproducers] Integrate FileProvider with clang.
[Reproducers] Integrate FileProvider with clang
Tue, Feb 12, 5:30 PM
JDevlieghere committed rLLDB353906: [Reproducers] Integrate FileProvider with clang.
[Reproducers] Integrate FileProvider with clang
Tue, Feb 12, 5:30 PM
JDevlieghere closed D58076: [Reproducers] Integrate FileProvider with clang.
Tue, Feb 12, 5:30 PM · Restricted Project
JDevlieghere committed rG9ea90acfeb52: [dsymutil] Improve readability of cloneAllCompileUnits (NFC) (authored by JDevlieghere).
[dsymutil] Improve readability of cloneAllCompileUnits (NFC)
Tue, Feb 12, 4:34 PM
JDevlieghere committed rG1bf1b9857f87: [dsymutil] Don't clone empty CUs (authored by JDevlieghere).
[dsymutil] Don't clone empty CUs
Tue, Feb 12, 4:34 PM
JDevlieghere committed rL353904: [dsymutil] Improve readability of cloneAllCompileUnits (NFC).
[dsymutil] Improve readability of cloneAllCompileUnits (NFC)
Tue, Feb 12, 4:34 PM
JDevlieghere committed rL353903: [dsymutil] Don't clone empty CUs.
[dsymutil] Don't clone empty CUs
Tue, Feb 12, 4:34 PM
JDevlieghere closed D57979: [dsymutil] Don't clone empty CUs.
Tue, Feb 12, 4:34 PM · Restricted Project
JDevlieghere committed rG75b44d75f667: Make ModuleDependencyCollector's method virtual (NFC) (authored by JDevlieghere).
Make ModuleDependencyCollector's method virtual (NFC)
Tue, Feb 12, 1:45 PM
JDevlieghere committed rC353882: Make ModuleDependencyCollector's method virtual (NFC).
Make ModuleDependencyCollector's method virtual (NFC)
Tue, Feb 12, 1:45 PM
JDevlieghere committed rL353882: Make ModuleDependencyCollector's method virtual (NFC).
Make ModuleDependencyCollector's method virtual (NFC)
Tue, Feb 12, 1:45 PM
JDevlieghere closed D58072: Make ModuleDependencyCollector's method virtual (NFC).
Tue, Feb 12, 1:44 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D58072: Make ModuleDependencyCollector's method virtual (NFC).

Alright, I'll split this up in two patches

Tue, Feb 12, 12:56 PM · Restricted Project, Restricted Project