- User Since
- Jan 31 2016, 7:15 AM (176 w, 1 d)
Fri, Jun 14
Highlight line and column in different color
Match dwarfdump color scheme
Thu, Jun 13
Yep, we should decode all the check_output results, as they may contain unicode.
Let me know if you want me to commit this for you.
Looks like the fallout of reflowing the comments. LGTM, Thanks!
Wed, Jun 12
Rebased to use the nested Info struct instead of the typedef.
Tue, Jun 11
Have you considered making just AddExceptionPrecondition virtual? Wouldn't that solve the problem too, without the code duplication of making CreateExceptionBreakpoint virtual? Also, I think it's totally reasonable to hoist BreakpointPrecondition out of Breakpoint. After having had to deal with the nuisance of not being able to forward declare nested classes, I try to avoid them in general.
Mon, Jun 10
I saw some weird formatting, but I assume you run clang-format before landing anyway. LGTM.
+1 on making -o the canonical argument and the out-file the alias.
Fri, Jun 7
Wed, Jun 5
Mon, Jun 3
Sat, Jun 1
Fri, May 31
Thu, May 30
LGTM. This seems straightforward. I skipped over the YAML stuff though, as it appears to have been moved.
Wed, May 29
Tue, May 28
Address CR feedback
Fri, May 24
Looks like a good change. Small comment inline but otherwise LGTM.
- Add new flag -parent-recurse-depth.
- Add new aliases -limit-children and -limit-parents.
Thu, May 23
This patch, if I understand it, dumps from the CU to the target DIE until the recursion limit is reached. So you get some parent DIE of the one you searched for.
I would've probably thought that the entire parent chain would be dumped, and then the recursion limit would limit how deep into the children of the target DIE would be dumped.