- User Since
- Jan 31 2016, 7:15 AM (243 w, 4 h)
Fri, Sep 25
Thanks for the thorough explanation. LGTM.
Thu, Sep 24
I don't mind keeping it around, but I also haven't used the manual steps since the script's inception, so LGTM. We can always reinstate it if someone complains.
I meant to accept this, we can land this and deal with my suggestion as a follow up. LGTM.
Good catch, thank you! I wanted to suggest making the SBAddress constructor take the Address by const-reference but wanted to see how much work that'd be which resulted in D88249.
Wed, Sep 23
Based on the signature of the call below this LGTM.
I'm very excited about this feature. Great job on the documentation, both in the help output as for the website. Do you have a potential use case in mind that we could add to the examples?
This is the same change as we did on Github, right? If so this LGTM.
Tue, Sep 22
Mon, Sep 21
The change to use the configuration looks good, but I think Pavel raised a good point. Which tests are affected by this? How much work would it be to convert them as suggested?
What's the scenario where you run the DWARF linker with already-linked binaries?
Wed, Sep 16
I think this will be very useful. LGTM!
Tue, Sep 15
Mon, Sep 14
Fri, Sep 11
Remove spurious change
The reproducer instrumentation part LGTM.
Thu, Sep 10
LGTM. This must've been broken for a while. I'll re-enable running the API tests on http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ so we can catch this earlier.
Thanks! I'll land it for you.
Wed, Sep 9
Tue, Sep 8
Sounds reasonable to me. I'll split it up in two patches. I'll update this one to use the double dashes so we can land the functionality and keep things consistent with the rest of LLDB. I'll create another patch to do the handling of raw commands to use a heuristic.
You need to add LLVM_ENABLE_WARNINGS to LLVMConfig.cmake.in so that the standalone builds know what value was set in the LLVM build. I think with the current patch the other projects won't inherit the value and just default to ON?
Wed, Sep 2
Thanks, should be fixed by 426fa35b655ffb8647d9d69580a69627c0d19024
- Remove custom parsing and use the command options insofar possible.
- Require -- as a delimiter when language and code are specified together.
Tue, Sep 1
This is great, thanks for taking the time to fix all this.
Other than a small style nit this LGTM
Mon, Aug 31
Fri, Aug 28
- Fix LLDB.framework path
- Don't try to guess the LLDB.framework location