JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (141 w, 5 d)

Recent Activity

Today

JDevlieghere updated the diff for D52651: Add functionality to export settings.

Only clear setting when the force flag is set (as suggested offline by @jingham).

Fri, Oct 19, 2:25 PM · Restricted Project
JDevlieghere updated the diff for D52543: [DWARFSymbolFile] Add the module lock where necessary and assert that we own it..
Fri, Oct 19, 1:02 PM · Restricted Project
JDevlieghere committed rL344794: [dwarfdump] Hide ranges in diff-mode..
[dwarfdump] Hide ranges in diff-mode.
Fri, Oct 19, 11:00 AM
JDevlieghere closed D53353: llvm-dwarfdump --diff should not print DW_AT_ranges.
Fri, Oct 19, 11:00 AM
JDevlieghere accepted D53419: [SourceMgr][FileCheck] Obey -color by extending WithColor.

LGTM.

Fri, Oct 19, 9:07 AM

Yesterday

JDevlieghere added a comment to D53409: Add support for GNU Hurd in Path.inc and other places.

Can you provide some more information about why this is needed?

Thu, Oct 18, 3:24 PM

Tue, Oct 16

JDevlieghere created D53353: llvm-dwarfdump --diff should not print DW_AT_ranges.
Tue, Oct 16, 6:48 PM
JDevlieghere added a comment to D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls.

The patch looks fine but since I don't know much about opencl I'll leave the LGTM to someone that actually knows this code.

Tue, Oct 16, 2:55 PM

Mon, Oct 15

JDevlieghere added a comment to D53193: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists).

The code and test look correct, so this LGTM but I'll leave it open for now in case someone else wants to have a look too.

Mon, Oct 15, 6:51 PM
JDevlieghere added a comment to D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls.

Can you add a test case please?

Mon, Oct 15, 10:28 AM

Wed, Oct 10

JDevlieghere committed rCTE344140: Lift VFS from clang to llvm (NFC).
Lift VFS from clang to llvm (NFC)
Wed, Oct 10, 6:31 AM
JDevlieghere committed rC344140: Lift VFS from clang to llvm (NFC).
Lift VFS from clang to llvm (NFC)
Wed, Oct 10, 6:31 AM
JDevlieghere committed rL344140: Lift VFS from clang to llvm (NFC).
Lift VFS from clang to llvm (NFC)
Wed, Oct 10, 6:30 AM
JDevlieghere closed D52783: Lift VFS from clang to llvm.
Wed, Oct 10, 6:29 AM
JDevlieghere accepted D52963: [DwarfVerifier] Fixed -Wimplicit-fallthrough warning.

LGTM, Thx!

Wed, Oct 10, 5:19 AM

Wed, Oct 3

JDevlieghere added a comment to D52783: Lift VFS from clang to llvm.

Are you sure the diff is okay? I see only a move on VirtualFileSystem.cpp but I really think there were namespace clang { lines in it too.

Wed, Oct 3, 8:38 AM
JDevlieghere updated the diff for D52783: Lift VFS from clang to llvm.
  • Fix a few formatting issues.
Wed, Oct 3, 8:36 AM
JDevlieghere accepted D52058: Add template type and value parameter metadata nodes to template variable specializations.

LGTM

Wed, Oct 3, 7:03 AM · debug-info
JDevlieghere added a comment to D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings..

Thanks for working on this Stefan, I'm really excited about this feature!

Wed, Oct 3, 6:54 AM
JDevlieghere added inline comments to D52776: [OptRemarks] Add library for parsing optimization remarks.
Wed, Oct 3, 6:35 AM
JDevlieghere added a comment to D52772: [Settings] Make "settings set" without a value equivalent to "settings clear".

Would it be possible for the exporter to notice empty settings and write "settings clear" instead?

Wed, Oct 3, 5:50 AM
JDevlieghere updated the summary of D52783: Lift VFS from clang to llvm.
Wed, Oct 3, 5:20 AM
JDevlieghere added a comment to D52783: Lift VFS from clang to llvm.

Seems there are a lot of changes caused by clang-formatting. I suggest to not mix the cosmetic and functionality changes and either revert them (remove from this patch) or commit as NFC separately at first.

Wed, Oct 3, 4:28 AM

Tue, Oct 2

JDevlieghere created D52783: Lift VFS from clang to llvm.
Tue, Oct 2, 7:59 AM
JDevlieghere added inline comments to D52776: [OptRemarks] Add library for parsing optimization remarks.
Tue, Oct 2, 5:52 AM
JDevlieghere updated the diff for D52651: Add functionality to export settings.

Split off settings set change into separate review: D52772

Tue, Oct 2, 2:02 AM · Restricted Project
JDevlieghere added a dependent revision for D52772: [Settings] Make "settings set" without a value equivalent to "settings clear": D52651: Add functionality to export settings.
Tue, Oct 2, 1:58 AM
JDevlieghere added a dependency for D52651: Add functionality to export settings: D52772: [Settings] Make "settings set" without a value equivalent to "settings clear".
Tue, Oct 2, 1:58 AM · Restricted Project
JDevlieghere created D52772: [Settings] Make "settings set" without a value equivalent to "settings clear".
Tue, Oct 2, 1:58 AM
JDevlieghere updated the diff for D52651: Add functionality to export settings.

Thanks a lot for the feedback! I clearly overlooked some stuff when inspiring myself on the other CommandObject code.

Tue, Oct 2, 1:37 AM · Restricted Project

Mon, Oct 1

JDevlieghere committed rLLDB343502: Fix tests affected by printing change..
Fix tests affected by printing change.
Mon, Oct 1, 10:22 AM
JDevlieghere committed rL343502: Fix tests affected by printing change..
Fix tests affected by printing change.
Mon, Oct 1, 10:22 AM
JDevlieghere updated the diff for D52651: Add functionality to export settings.
  • Rebase
Mon, Oct 1, 6:35 AM · Restricted Project
JDevlieghere committed rL343471: [Interpreter] Escape backticks when dumping format entities..
[Interpreter] Escape backticks when dumping format entities.
Mon, Oct 1, 6:24 AM
JDevlieghere committed rLLDB343471: [Interpreter] Escape backticks when dumping format entities..
[Interpreter] Escape backticks when dumping format entities.
Mon, Oct 1, 6:24 AM
JDevlieghere committed rLLDB343470: Escape newlines in default disassembly format..
Escape newlines in default disassembly format.
Mon, Oct 1, 6:23 AM
JDevlieghere committed rL343470: Escape newlines in default disassembly format..
Escape newlines in default disassembly format.
Mon, Oct 1, 6:22 AM

Fri, Sep 28

JDevlieghere created D52651: Add functionality to export settings.
Fri, Sep 28, 8:00 AM · Restricted Project
JDevlieghere committed rL343313: Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC).
Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC)
Fri, Sep 28, 5:10 AM
JDevlieghere closed D52603: Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC).
Fri, Sep 28, 5:10 AM

Thu, Sep 27

JDevlieghere updated the diff for D52603: Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC).
  • Make the different tests standalone.
Thu, Sep 27, 7:34 AM
JDevlieghere updated the diff for D52603: Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC).
  • Rename file
Thu, Sep 27, 6:49 AM
JDevlieghere added a comment to D52603: Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC).

Use .ll file extension not .test

Thu, Sep 27, 6:44 AM
JDevlieghere created D52603: Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC).
Thu, Sep 27, 4:32 AM
JDevlieghere retitled D52603: Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC) from [test] Split invocations in CodeGen/X86/cpus.ll among multiple tests. to Split invocations in CodeGen/X86/cpus.ll among multiple tests. (NFC).
Thu, Sep 27, 4:32 AM
JDevlieghere updated the diff for D52543: [DWARFSymbolFile] Add the module lock where necessary and assert that we own it..
  • Add assertions per Greg's suggestion.
Thu, Sep 27, 1:58 AM · Restricted Project
JDevlieghere added a comment to D52543: [DWARFSymbolFile] Add the module lock where necessary and assert that we own it..

My first observations:

Thu, Sep 27, 1:52 AM · Restricted Project
JDevlieghere committed rLLDB343180: [target] Fix typo and give bool a default value.
[target] Fix typo and give bool a default value
Thu, Sep 27, 12:01 AM
JDevlieghere committed rL343180: [target] Fix typo and give bool a default value.
[target] Fix typo and give bool a default value
Thu, Sep 27, 12:01 AM

Wed, Sep 26

JDevlieghere accepted D52507: Fix FreeBSD build after r342633..

Thanks!

Wed, Sep 26, 11:55 AM
JDevlieghere added a comment to D52543: [DWARFSymbolFile] Add the module lock where necessary and assert that we own it..

It is the SymbolVendor's job to do the locking. And in many cases it already is. I stopped with inlined comments after a few comments as it would apply to this entire patch.

Wed, Sep 26, 11:53 AM · Restricted Project
JDevlieghere created D52543: [DWARFSymbolFile] Add the module lock where necessary and assert that we own it..
Wed, Sep 26, 4:30 AM · Restricted Project
JDevlieghere committed rL343087: [unittest] Fix NativeProcessProtocolTest.cpp (NFC).
[unittest] Fix NativeProcessProtocolTest.cpp (NFC)
Wed, Sep 26, 3:13 AM
JDevlieghere committed rLLDB343087: [unittest] Fix NativeProcessProtocolTest.cpp (NFC).
[unittest] Fix NativeProcessProtocolTest.cpp (NFC)
Wed, Sep 26, 3:12 AM
JDevlieghere abandoned D52406: Make DIE_IS_BEING_PARSED local to the current thread..
Wed, Sep 26, 2:05 AM

Tue, Sep 25

JDevlieghere added a comment to D48393: Make DWARFParsing more thread-safe.

Thanks for the information, Greg!

Tue, Sep 25, 1:11 AM

Mon, Sep 24

JDevlieghere committed rL342881: [dsymutil] Set LSan blacklist whenever sanitizers are enabled..
[dsymutil] Set LSan blacklist whenever sanitizers are enabled.
Mon, Sep 24, 7:25 AM
JDevlieghere added inline comments to D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap.
Mon, Sep 24, 7:20 AM
JDevlieghere created D52406: Make DIE_IS_BEING_PARSED local to the current thread..
Mon, Sep 24, 7:19 AM
JDevlieghere added a comment to D48393: Make DWARFParsing more thread-safe.

It's even more complicated than that, in case you really have reference cycles, you can have multiple threads starting parsing from different points in that cycle, and getting deadlocked waiting for the DIE_IS_BEING_PARSED results from each other.

The only sane algorithm I can come up right now is to make the list of parsed dies local to each thread/parsing entity (e.g. via a "visited" list), and only update the global map once the parsing has completed (successfully or not). This can potentially duplicate some effort where one thread parses a type only to find out that it has already been parsed, but hopefully that is not going to be the common case. The alternative is some complicated resource cycle detection scheme.

Mon, Sep 24, 7:19 AM
JDevlieghere updated the summary of D52406: Make DIE_IS_BEING_PARSED local to the current thread..
Mon, Sep 24, 7:19 AM

Fri, Sep 21

JDevlieghere committed rL342727: [test] Fix Assembler/debug-info.ll.
[test] Fix Assembler/debug-info.ll
Fri, Sep 21, 5:30 AM
JDevlieghere committed rL342725: Ensure that variant part discriminator is read by MetadataLoader.
Ensure that variant part discriminator is read by MetadataLoader
Fri, Sep 21, 5:04 AM
JDevlieghere closed D52340: Ensure that variant part discriminator is read by MetadataLoader.
Fri, Sep 21, 5:04 AM
JDevlieghere committed rL342724: [dsymutil] Suppress CoreFoundation leaks in tests..
[dsymutil] Suppress CoreFoundation leaks in tests.
Fri, Sep 21, 4:57 AM
JDevlieghere added inline comments to D50254: [RFC] Add GDB remote packet reproducer..
Fri, Sep 21, 3:25 AM
JDevlieghere updated the diff for D50254: [RFC] Add GDB remote packet reproducer..

Thanks a lot for the review feedback everyone!

Fri, Sep 21, 3:24 AM
JDevlieghere committed rL342713: [dwarfdump] Verify DW_AT_type is set and points to a compatible DIE..
[dwarfdump] Verify DW_AT_type is set and points to a compatible DIE.
Fri, Sep 21, 12:54 AM
JDevlieghere closed D52223: [dwarfdump] Verify DW_AT_type..
Fri, Sep 21, 12:54 AM · debug-info
JDevlieghere committed rL342712: [dwarfdump] Verify compatibility of attribute TAGs..
[dwarfdump] Verify compatibility of attribute TAGs.
Fri, Sep 21, 12:51 AM
JDevlieghere closed D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
Fri, Sep 21, 12:51 AM · debug-info

Thu, Sep 20

JDevlieghere added a reviewer for D50254: [RFC] Add GDB remote packet reproducer.: clayborg.
Thu, Sep 20, 11:56 PM
JDevlieghere accepted D52340: Ensure that variant part discriminator is read by MetadataLoader.

LGTM, Thanks!

Thu, Sep 20, 11:45 PM
JDevlieghere committed rLLDB342633: [NFC] Turn "load dependent files" boolean into an enum.
[NFC] Turn "load dependent files" boolean into an enum
Thu, Sep 20, 2:14 AM
JDevlieghere committed rLLDB342634: [target] Change target create's behavior wrt loading dependent files..
[target] Change target create's behavior wrt loading dependent files.
Thu, Sep 20, 2:14 AM
JDevlieghere closed D51934: [target] Change target create's behavior wrt loading dependent files..
Thu, Sep 20, 2:14 AM
JDevlieghere committed rL342634: [target] Change target create's behavior wrt loading dependent files..
[target] Change target create's behavior wrt loading dependent files.
Thu, Sep 20, 2:14 AM
JDevlieghere committed rL342633: [NFC] Turn "load dependent files" boolean into an enum.
[NFC] Turn "load dependent files" boolean into an enum
Thu, Sep 20, 2:14 AM
JDevlieghere closed D51934: [target] Change target create's behavior wrt loading dependent files..
Thu, Sep 20, 2:14 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Sep 20, 2:13 AM
JDevlieghere added inline comments to D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
Thu, Sep 20, 12:45 AM · debug-info
JDevlieghere updated the diff for D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
  • Add check for equal tags to cover case where both are subprograms, both are formal params.
  • Ran verifier over clang, no errors.
  • Ran verifier over GCC generated binary I had laying around, also no errors.
Thu, Sep 20, 12:40 AM · debug-info

Sep 19 2018

JDevlieghere updated the summary of D50254: [RFC] Add GDB remote packet reproducer..
Sep 19 2018, 7:04 AM
JDevlieghere added a comment to D50254: [RFC] Add GDB remote packet reproducer..

I'm having some trouble with the test case. Based on the initialization code I assume I'm not supposed to destroy the SBDebugger singleton shared by the LLDB test suite. If I do it anyway the test crashes with the an exception:

Sep 19 2018, 6:01 AM
JDevlieghere retitled D50254: [RFC] Add GDB remote packet reproducer. from [WIP] Add GDB remote packet reproducer. to [RFC] Add GDB remote packet reproducer..
Sep 19 2018, 5:23 AM
JDevlieghere added a comment to D51934: [target] Change target create's behavior wrt loading dependent files..

ping

Sep 19 2018, 1:30 AM
JDevlieghere updated the diff for D52223: [dwarfdump] Verify DW_AT_type..
  • Use the new dump method that passes the correct DI dump options.
  • Update test to expect verbose output.
Sep 19 2018, 1:20 AM · debug-info
JDevlieghere committed rL342526: [DWARF Verifier] Add helper function to dump DIEs. [NFC].
[DWARF Verifier] Add helper function to dump DIEs. [NFC]
Sep 19 2018, 1:10 AM
JDevlieghere added inline comments to D52223: [dwarfdump] Verify DW_AT_type..
Sep 19 2018, 1:10 AM · debug-info
JDevlieghere added inline comments to D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
Sep 19 2018, 12:35 AM · debug-info
JDevlieghere updated the diff for D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..

Make sure addUnit keeps the DWARFUnitVector sorted.

Sep 19 2018, 12:28 AM · debug-info

Sep 18 2018

JDevlieghere added a dependency for D52223: [dwarfdump] Verify DW_AT_type.: D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
Sep 18 2018, 2:16 AM · debug-info
JDevlieghere added a dependent revision for D38719: [llvm-dwarfdump] Verify compatible TAG for attributes.: D52223: [dwarfdump] Verify DW_AT_type..
Sep 18 2018, 2:16 AM · debug-info
JDevlieghere created D52223: [dwarfdump] Verify DW_AT_type..
Sep 18 2018, 2:16 AM · debug-info
JDevlieghere accepted D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect).

Thanks Vedant, this looks very useful!

Sep 18 2018, 12:27 AM · Restricted Project
JDevlieghere added a comment to D52058: Add template type and value parameter metadata nodes to template variable specializations.

Generally this looks good, but I'd like for the other to have a look first (at this and the other patch) before accepting.

Sep 18 2018, 12:07 AM · debug-info

Sep 17 2018

JDevlieghere added a comment to D49549: Change 'clang-test' to 'check-clang' on the hacking webpage.

Hey Arnaud, let me know if you want me to commit this for you.

Sep 17 2018, 9:11 AM
JDevlieghere updated the diff for D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..

Rebase

Sep 17 2018, 8:08 AM · debug-info
JDevlieghere committed rL342396: [DebugInfo] Remove redundant argument. [NFC].
[DebugInfo] Remove redundant argument. [NFC]
Sep 17 2018, 7:25 AM
JDevlieghere updated the diff for D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..

Use separate vectors for compile and type units.

Sep 17 2018, 7:13 AM · debug-info