Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (149 w, 5 d)

Recent Activity

Today

JDevlieghere committed rL349215: Simplify Boolean expressions.
Simplify Boolean expressions
Fri, Dec 14, 4:20 PM
JDevlieghere committed rLLDB349215: Simplify Boolean expressions.
Simplify Boolean expressions
Fri, Dec 14, 4:20 PM
JDevlieghere closed D55584: [LLDB] Simplify Boolean expressions.
Fri, Dec 14, 4:19 PM · Restricted Project
JDevlieghere added a comment to D55582: [Reproducers] Add command reproducer.

Hm.. so the way, I'd imagine this working is that -o and friends (as well as pretty much every other command line argument) would be captured by the SB recorder, once they cross the SB boundary. For the -o commands that would be the moment the driver calls m_debugger.SetInputFileHandle https://github.com/llvm-mirror/lldb/blob/master/tools/driver/Driver.cpp#L697 , followed by m_debugger.RunCommandInterpreter a couple of lines lower. So, the SB recorder would notice that we're changing what the debugger considers as it's stdin, and direct the "stdin" recorder (or create a new instance of it, or whatever), to capture it.

Then, during replay, the SB replayer would notice that the driver called SBDebugger::SetInputFileHandle, so it would create a fake FILE* object (or maybe just open the file containing the captured commands from the disk?), and pass *that* as the stdin handle. Then it could just call SBDebugger::RunCommandInterperer the same way as the driver did. And I am hoping that pretty much everything below RunCommandInterpreter could run oblivious to the fact that replay is taking place.

Fri, Dec 14, 9:39 AM · Restricted Project

Yesterday

JDevlieghere added a comment to D55582: [Reproducers] Add command reproducer.

I played around with this today:

Thu, Dec 13, 6:40 PM · Restricted Project
JDevlieghere accepted D55332: [CMake] Python bindings generation polishing.
Thu, Dec 13, 11:35 AM
JDevlieghere accepted D55328: [CMake] Revised LLDB.framework builds.

Sorry for the late review, I had a look originally but didn't have any comments. LGTM!

Thu, Dec 13, 11:33 AM
JDevlieghere added a comment to D55582: [Reproducers] Add command reproducer.

I am very sorry about this, but I am having some second thoughts about the RunReplay thingy. I don't think I've correctly expressed what is bothering me about it (and that's probably because I wasn't clear with myself about what is bothering me). I'll try to formulate it better this time

Thu, Dec 13, 9:12 AM · Restricted Project
JDevlieghere added inline comments to D55626: [Reproducers] Add tests for functionality.
Thu, Dec 13, 8:52 AM · Restricted Project
JDevlieghere updated the diff for D55626: [Reproducers] Add tests for functionality.

Address Adrian's feedback

Thu, Dec 13, 8:52 AM · Restricted Project

Wed, Dec 12

JDevlieghere committed rLLDB348996: [NFC] Small code cleanups in utility..
[NFC] Small code cleanups in utility.
Wed, Dec 12, 4:20 PM
JDevlieghere committed rL348996: [NFC] Small code cleanups in utility..
[NFC] Small code cleanups in utility.
Wed, Dec 12, 4:20 PM
JDevlieghere created D55626: [Reproducers] Add tests for functionality.
Wed, Dec 12, 3:46 PM · Restricted Project
JDevlieghere updated the diff for D55582: [Reproducers] Add command reproducer.

When sourcing a file we should also ignore the individual commands otherwise they end up getting executed twice, once as part of the command source and once for every individual command in the file.

Wed, Dec 12, 3:14 PM · Restricted Project
JDevlieghere updated the diff for D55582: [Reproducers] Add command reproducer.

Skip driver logic when replaying, otherwise commands are executed or sourced twice, once in the driver and once by replaying the commands.

Wed, Dec 12, 1:40 PM · Restricted Project
JDevlieghere updated the diff for D55582: [Reproducers] Add command reproducer.

Address Pavel's comments.

Wed, Dec 12, 10:15 AM · Restricted Project
JDevlieghere updated the diff for D55584: [LLDB] Simplify Boolean expressions.

Remove changes that introduced static_cast<bool>

Wed, Dec 12, 9:38 AM · Restricted Project
JDevlieghere added a comment to D55584: [LLDB] Simplify Boolean expressions.

I also find the static_cast<bool> thingy weird. The rest of the changes seem to be towards the better (based on a pseudo-random sample), but the change is a quite big.

Wed, Dec 12, 9:22 AM · Restricted Project

Tue, Dec 11

JDevlieghere abandoned D55574: Remove else statements after returns.

I'm going to abandon this for now until we have better tooling to address Jim's concerns here. I'm also not super happy with the formatting, which seems to be off in quite a few locations. The problem is that clang-tidy knows to reformat the source range it touched, but in this case the code below is affected. I hacked this up by having clang-format looking one line below the lines that were changed, but looks like that was not sufficient. Also a few case are covered by D55584 so definitely want to land that first.

Tue, Dec 11, 6:51 PM
JDevlieghere updated the diff for D55584: [LLDB] Simplify Boolean expressions.

Feedback Adrian

Tue, Dec 11, 6:47 PM · Restricted Project
JDevlieghere committed rLLDB348901: Remove unused file.
Remove unused file
Tue, Dec 11, 2:50 PM
JDevlieghere committed rL348901: Remove unused file.
Remove unused file
Tue, Dec 11, 2:50 PM
JDevlieghere added a reviewer for D55574: Remove else statements after returns: aprantl.
Tue, Dec 11, 2:42 PM
JDevlieghere created D55584: [LLDB] Simplify Boolean expressions.
Tue, Dec 11, 2:42 PM · Restricted Project
JDevlieghere created D55582: [Reproducers] Add command reproducer.
Tue, Dec 11, 2:26 PM · Restricted Project
JDevlieghere created D55574: Remove else statements after returns.
Tue, Dec 11, 1:08 PM
JDevlieghere committed rLLDB348894: [Driver] Simplify OptionData. NFC.
[Driver] Simplify OptionData. NFC
Tue, Dec 11, 12:23 PM
JDevlieghere committed rL348894: [Driver] Simplify OptionData. NFC.
[Driver] Simplify OptionData. NFC
Tue, Dec 11, 12:23 PM

Mon, Dec 10

JDevlieghere updated the diff for D55376: Generate LLDB website/documentation from rst with Sphinx.

Add more pages

Mon, Dec 10, 10:14 PM
JDevlieghere retitled D54617: [Reproducers] Add file provider from [wip][Reproducers] Add file provider to [Reproducers] Add file provider.
Mon, Dec 10, 5:16 PM · Restricted Project
JDevlieghere updated the diff for D54617: [Reproducers] Add file provider.
  • Rebase
  • Copy over permissions
  • Fix path when launching.
Mon, Dec 10, 2:46 PM · Restricted Project
JDevlieghere committed rL348779: [Host] Use FileSystem wrapper.
[Host] Use FileSystem wrapper
Mon, Dec 10, 10:21 AM
JDevlieghere committed rLLDB348779: [Host] Use FileSystem wrapper.
[Host] Use FileSystem wrapper
Mon, Dec 10, 10:20 AM
JDevlieghere added a comment to D54277: Move RedirectingFileSystem interface into header..

ping

Mon, Dec 10, 9:21 AM

Fri, Dec 7

JDevlieghere accepted D55317: [CMake] Aggregate options for LLDB in LLDBConfig.cmake.
Fri, Dec 7, 9:20 AM
JDevlieghere accepted D55330: [CMake] Revised RPATH handling.

LGTM with the question answered/addressed. Thanks Stefan, these patches are really great work!

Fri, Dec 7, 8:59 AM
JDevlieghere added a comment to D55332: [CMake] Python bindings generation polishing.

This LGTM if it works on Windows.

Fri, Dec 7, 8:55 AM

Thu, Dec 6

JDevlieghere created D55376: Generate LLDB website/documentation from rst with Sphinx.
Thu, Dec 6, 9:00 AM

Tue, Dec 4

JDevlieghere added a comment to D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing.

What happens today with NVPTX for other debug info sections that use label arithmetic? I know for sure that the accelerator tables/debug_names is using this, but maybe they're not used with this target?

Tue, Dec 4, 10:22 AM
JDevlieghere committed rLLDB348289: [Reproducers] Only creaate the bottom-most dir.
[Reproducers] Only creaate the bottom-most dir
Tue, Dec 4, 10:20 AM
JDevlieghere committed rL348289: [Reproducers] Only creaate the bottom-most dir.
[Reproducers] Only creaate the bottom-most dir
Tue, Dec 4, 10:20 AM
JDevlieghere accepted D55013: [CMake] Streamline code signing for debugserver #2.

LGTM. Thanks!

Tue, Dec 4, 10:08 AM
JDevlieghere committed rLLDB348287: [FileSystem] Migrate CommandCompletions.
[FileSystem] Migrate CommandCompletions
Tue, Dec 4, 10:01 AM
JDevlieghere committed rL348287: [FileSystem] Migrate CommandCompletions.
[FileSystem] Migrate CommandCompletions
Tue, Dec 4, 10:01 AM
JDevlieghere closed D55240: [FileSystem] Migrate CommandCompletions.
Tue, Dec 4, 10:01 AM · Restricted Project
JDevlieghere added a comment to D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing.

I'm in favor of using labels for the reasons you mentioned. It's also consistent with what we do elsewhere.

Tue, Dec 4, 10:01 AM
JDevlieghere added inline comments to D55240: [FileSystem] Migrate CommandCompletions.
Tue, Dec 4, 9:34 AM · Restricted Project
JDevlieghere committed rL348283: [dsymutil] Ensure we're comparing time stamps with the same precision..
[dsymutil] Ensure we're comparing time stamps with the same precision.
Tue, Dec 4, 9:18 AM

Mon, Dec 3

JDevlieghere committed rL348232: [PlatformDarwin] Simplify logic and use FileSystem.
[PlatformDarwin] Simplify logic and use FileSystem
Mon, Dec 3, 6:26 PM
JDevlieghere committed rLLDB348232: [PlatformDarwin] Simplify logic and use FileSystem.
[PlatformDarwin] Simplify logic and use FileSystem
Mon, Dec 3, 6:26 PM
JDevlieghere updated the diff for D55240: [FileSystem] Migrate CommandCompletions.

Initialize the FS in the unit test.

Mon, Dec 3, 5:53 PM · Restricted Project
JDevlieghere created D55240: [FileSystem] Migrate CommandCompletions.
Mon, Dec 3, 3:39 PM · Restricted Project
JDevlieghere committed rLLDB348207: [FileSystem] Migrate MonitoringProcessLauncher.
[FileSystem] Migrate MonitoringProcessLauncher
Mon, Dec 3, 2:44 PM
JDevlieghere committed rL348207: [FileSystem] Migrate MonitoringProcessLauncher.
[FileSystem] Migrate MonitoringProcessLauncher
Mon, Dec 3, 2:44 PM
JDevlieghere added a comment to D55038: [Reproducers] Change how reproducers are initialized..
Mon, Dec 3, 12:42 PM · Restricted Project
JDevlieghere committed rLLDB348186: Skip TestDriverOptions on Windows.
Skip TestDriverOptions on Windows
Mon, Dec 3, 12:39 PM
JDevlieghere committed rL348186: Skip TestDriverOptions on Windows.
Skip TestDriverOptions on Windows
Mon, Dec 3, 12:39 PM
JDevlieghere committed rLLDB348152: [Reproducers] Change how reproducers are initialized..
[Reproducers] Change how reproducers are initialized.
Mon, Dec 3, 9:32 AM
JDevlieghere committed rL348152: [Reproducers] Change how reproducers are initialized..
[Reproducers] Change how reproducers are initialized.
Mon, Dec 3, 9:31 AM
JDevlieghere closed D55038: [Reproducers] Change how reproducers are initialized..
Mon, Dec 3, 9:31 AM · Restricted Project

Fri, Nov 30

JDevlieghere committed rL348021: [dsymutil] Gather global and local symbol addresses in the main executable..
[dsymutil] Gather global and local symbol addresses in the main executable.
Fri, Nov 30, 10:59 AM
JDevlieghere closed D54922: [dsymutil] Gather local symbol addresses in addition to global in the main executable..
Fri, Nov 30, 10:59 AM
JDevlieghere added a comment to D55038: [Reproducers] Change how reproducers are initialized..

Test didn't run. Is there a way to REQUIRE either darwin or linux?

I think the canonical way to do that would be to define a new feature in lit, which gets set when the target supports remote debugging and then use that feature in the REQUIRES directive.

Fri, Nov 30, 10:44 AM · Restricted Project
JDevlieghere updated the diff for D55038: [Reproducers] Change how reproducers are initialized..

Make initialize return an error.

Fri, Nov 30, 10:43 AM · Restricted Project
JDevlieghere committed rL348010: Skip TestRequireHWBreakpoints on Windows.
Skip TestRequireHWBreakpoints on Windows
Fri, Nov 30, 9:34 AM
JDevlieghere committed rLLDB348010: Skip TestRequireHWBreakpoints on Windows.
Skip TestRequireHWBreakpoints on Windows
Fri, Nov 30, 9:34 AM
JDevlieghere accepted D55128: [CMake] Store path to vendor-specific headers in clang-headers target property.

This makes sense to me. I'm don't know if there's a better property but I think this matches the intended use, so I think it is fine.

Fri, Nov 30, 8:24 AM

Thu, Nov 29

JDevlieghere added a comment to D54922: [dsymutil] Gather local symbol addresses in addition to global in the main executable..

ping

Thu, Nov 29, 9:34 PM
JDevlieghere added a parent revision for D54617: [Reproducers] Add file provider: D54277: Move RedirectingFileSystem interface into header..
Thu, Nov 29, 9:34 PM · Restricted Project
JDevlieghere added a child revision for D54277: Move RedirectingFileSystem interface into header.: D54617: [Reproducers] Add file provider.
Thu, Nov 29, 9:34 PM
JDevlieghere updated the diff for D54617: [Reproducers] Add file provider.
  • Get the external path with modifying the VFS in LLVM.
  • Integrate with the new integration logic.
  • Add a test. (that doesn't work yet, still WIP)
Thu, Nov 29, 9:34 PM · Restricted Project
JDevlieghere updated the diff for D55038: [Reproducers] Change how reproducers are initialized..

Test didn't run. Is there a way to REQUIRE either darwin or linux?

Thu, Nov 29, 8:51 PM · Restricted Project
JDevlieghere updated the diff for D54277: Move RedirectingFileSystem interface into header..

Move RedirectingFileSystem interface into header so we can extend it from LLDB.

Thu, Nov 29, 8:21 PM
JDevlieghere committed rL347952: Fix the Xcode project (pt. 2).
Fix the Xcode project (pt. 2)
Thu, Nov 29, 6:47 PM
JDevlieghere committed rLLDB347952: Fix the Xcode project (pt. 2).
Fix the Xcode project (pt. 2)
Thu, Nov 29, 6:47 PM
JDevlieghere updated the diff for D55038: [Reproducers] Change how reproducers are initialized..

Address feedback from Pavel.

Thu, Nov 29, 4:37 PM · Restricted Project
JDevlieghere added inline comments to D55038: [Reproducers] Change how reproducers are initialized..
Thu, Nov 29, 4:37 PM · Restricted Project
JDevlieghere committed rLLDB347936: Fix the Xcode project.
Fix the Xcode project
Thu, Nov 29, 4:12 PM
JDevlieghere committed rL347936: Fix the Xcode project.
Fix the Xcode project
Thu, Nov 29, 4:12 PM
JDevlieghere committed rL347922: Produce an error on non-encodable offsets for darwin ARM scattered relocations..
Produce an error on non-encodable offsets for darwin ARM scattered relocations.
Thu, Nov 29, 2:01 PM
JDevlieghere closed D54776: Produce an error on non-encodable offsets for darwin ARM scattered relocations..
Thu, Nov 29, 2:01 PM

Wed, Nov 28

JDevlieghere created D55038: [Reproducers] Change how reproducers are initialized..
Wed, Nov 28, 5:08 PM · Restricted Project
JDevlieghere committed rLLDB347821: [driver] Fix --core/-c and add test.
[driver] Fix --core/-c and add test
Wed, Nov 28, 4:25 PM
JDevlieghere committed rL347821: [driver] Fix --core/-c and add test.
[driver] Fix --core/-c and add test
Wed, Nov 28, 4:25 PM
JDevlieghere added inline comments to D55013: [CMake] Streamline code signing for debugserver #2.
Wed, Nov 28, 4:05 PM
JDevlieghere committed rL347817: [driver] Some NFC cleanup.
[driver] Some NFC cleanup
Wed, Nov 28, 2:42 PM
JDevlieghere committed rLLDB347817: [driver] Some NFC cleanup.
[driver] Some NFC cleanup
Wed, Nov 28, 2:42 PM
JDevlieghere committed rL347814: Make standalone build find tabelgen.
Make standalone build find tabelgen
Wed, Nov 28, 2:13 PM
JDevlieghere committed rLLDB347814: Make standalone build find tabelgen.
Make standalone build find tabelgen
Wed, Nov 28, 2:12 PM
JDevlieghere added inline comments to D55013: [CMake] Streamline code signing for debugserver #2.
Wed, Nov 28, 1:40 PM

Tue, Nov 27

JDevlieghere committed rL347725: [unittest] Fix the FileSystem test on Windows. (Attempt #2).
[unittest] Fix the FileSystem test on Windows. (Attempt #2)
Tue, Nov 27, 5:21 PM
JDevlieghere committed rLLDB347725: [unittest] Fix the FileSystem test on Windows. (Attempt #2).
[unittest] Fix the FileSystem test on Windows. (Attempt #2)
Tue, Nov 27, 5:21 PM
JDevlieghere committed rLLDB347716: [Reproducers] Improve reproducer API and add unit tests..
[Reproducers] Improve reproducer API and add unit tests.
Tue, Nov 27, 2:14 PM
JDevlieghere committed rL347716: [Reproducers] Improve reproducer API and add unit tests..
[Reproducers] Improve reproducer API and add unit tests.
Tue, Nov 27, 2:14 PM
JDevlieghere closed D54616: [Reproducers] Improve reproducer API and add unit tests..
Tue, Nov 27, 2:14 PM · Restricted Project
JDevlieghere committed rLLDB347712: [unittest] Fix the FileSystem test on Windows..
[unittest] Fix the FileSystem test on Windows.
Tue, Nov 27, 1:23 PM
JDevlieghere committed rL347712: [unittest] Fix the FileSystem test on Windows..
[unittest] Fix the FileSystem test on Windows.
Tue, Nov 27, 1:23 PM
JDevlieghere committed rLLDB347709: [Driver] Use libOption with tablegen..
[Driver] Use libOption with tablegen.
Tue, Nov 27, 1:03 PM
JDevlieghere committed rL347709: [Driver] Use libOption with tablegen..
[Driver] Use libOption with tablegen.
Tue, Nov 27, 1:03 PM
JDevlieghere closed D54692: [Driver] Use libOption with tablegen..
Tue, Nov 27, 1:03 PM · Restricted Project