Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (185 w, 2 d)

jonas@devlieghere.com
jdevlieghere@apple.com

Recent Activity

Today

JDevlieghere committed rG4b3c0fd5da2e: [NFC] Remove lldb_utility namespace. (authored by JDevlieghere).
[NFC] Remove lldb_utility namespace.
Tue, Aug 20, 5:51 PM
JDevlieghere committed rL369485: [NFC] Remove lldb_utility namespace..
[NFC] Remove lldb_utility namespace.
Tue, Aug 20, 5:50 PM
JDevlieghere committed rGd979a2993561: [Doxygen] Document private class members. (authored by JDevlieghere).
[Doxygen] Document private class members.
Tue, Aug 20, 5:16 PM
JDevlieghere committed rL369479: [Doxygen] Document private class members..
[Doxygen] Document private class members.
Tue, Aug 20, 5:16 PM
JDevlieghere committed rG625ab43318a9: [dotest] Don't set the DWARF version override in CFLAGS_EXTRA. (authored by JDevlieghere).
[dotest] Don't set the DWARF version override in CFLAGS_EXTRA.
Tue, Aug 20, 4:57 PM
JDevlieghere committed rL369477: [dotest] Don't set the DWARF version override in CFLAGS_EXTRA..
[dotest] Don't set the DWARF version override in CFLAGS_EXTRA.
Tue, Aug 20, 4:56 PM
JDevlieghere committed rG0dcd186b0d18: [NFC] Fix -Wdocumentation warnings in Utility. (authored by JDevlieghere).
[NFC] Fix -Wdocumentation warnings in Utility.
Tue, Aug 20, 3:24 PM
JDevlieghere committed rL369461: [NFC] Fix -Wdocumentation warnings in Utility..
[NFC] Fix -Wdocumentation warnings in Utility.
Tue, Aug 20, 3:19 PM
JDevlieghere committed rGc569d4af4c65: [NFC] Update RegularExpression documentation (authored by JDevlieghere).
[NFC] Update RegularExpression documentation
Tue, Aug 20, 2:58 PM
JDevlieghere committed rL369452: [NFC] Update RegularExpression documentation.
[NFC] Update RegularExpression documentation
Tue, Aug 20, 2:57 PM
JDevlieghere committed rL369446: Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER.
Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER
Tue, Aug 20, 2:21 PM
JDevlieghere committed rG8509b0a7788a: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER (authored by JDevlieghere).
[CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER
Tue, Aug 20, 1:21 PM
JDevlieghere committed rL369435: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER.
[CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER
Tue, Aug 20, 1:19 PM
JDevlieghere closed D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER.
Tue, Aug 20, 1:19 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D66447: Add char8_t support (C++20).

This looks good to me, but why are we using a nul character to test utf8 support? Shouldn't we insert some funnier characters too? I mean, one of the advantages of unicode is that it should not be affected by the system code pages and such, so hopefully this would not cause problems even on some more exotic setups. (And I am pretty sure I remember already seeing some chinese chars in some of our data formatter tests)

Tue, Aug 20, 1:10 PM · Restricted Project
JDevlieghere updated the diff for D66447: Add char8_t support (C++20).
  • Remove clean rule
  • Use more readable names
Tue, Aug 20, 1:09 PM · Restricted Project
JDevlieghere added inline comments to D66248: [JIT][Command] Add "inject-condition" flag to conditional breakpoints.
Tue, Aug 20, 9:33 AM · Restricted Project
JDevlieghere added inline comments to D66453: Make the FindTypes(std::vector<CompilerContext>, ...) API testable in lldb-test.
Tue, Aug 20, 9:24 AM · Restricted Project
JDevlieghere added a comment to D66447: Add char8_t support (C++20).

Thank you for creating a revision and reviewing this.

I made inline comments on the test harness and Dlang types / qualifiers.

With removal of the Dlang types, where is the appropriate place to put them?
It is not clear to me whether language plugins can replace the functionality in ClangASTContext::GetBuiltinTypeForDWARFEncodingAndBitSize.

Thanks again

Tue, Aug 20, 9:24 AM · Restricted Project
JDevlieghere updated the diff for D66447: Add char8_t support (C++20).
  • Address Pavel's comments.
Tue, Aug 20, 9:15 AM · Restricted Project
JDevlieghere accepted D66398: 2/2: Fix `TestDataFormatterStdList` regression.
Tue, Aug 20, 8:38 AM · Restricted Project
JDevlieghere accepted D66463: Regex: +isValid() with no parameter.

LGTM

Tue, Aug 20, 8:34 AM · Restricted Project
JDevlieghere added a reviewer for D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER: stella.stamenova.
Tue, Aug 20, 8:33 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER.

That said, I'm not a fan of force-overwriting cache variables specified by the user, particularly when the same effect can be achieved by *deleting* the cache variable instead of setting it to an empty string. I think you should be able to reset the default value of LLDB_TEST_C_COMPILER (just like any other cmake variable) by running cmake -ULLDB_TEST_C_COMPILER. You can even delete both variables at once with -ULLDB_TEST_*_COMPILER.

Tue, Aug 20, 8:33 AM · Restricted Project, Restricted Project

Yesterday

JDevlieghere committed rL369322: [lldb] Fix type in matrix pipeline.
[lldb] Fix type in matrix pipeline
Mon, Aug 19, 8:54 PM
JDevlieghere committed rL369323: [lldb-cmake] Add emailext.
[lldb-cmake] Add emailext
Mon, Aug 19, 8:54 PM
JDevlieghere added inline comments to D66453: Make the FindTypes(std::vector<CompilerContext>, ...) API testable in lldb-test.
Mon, Aug 19, 5:48 PM · Restricted Project
JDevlieghere added inline comments to D66451: [ClangExpressionParser] Add ClangDeclVendor.
Mon, Aug 19, 5:33 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D66453: Make the FindTypes(std::vector<CompilerContext>, ...) API testable in lldb-test.
Mon, Aug 19, 5:25 PM · Restricted Project
JDevlieghere added inline comments to D66451: [ClangExpressionParser] Add ClangDeclVendor.
Mon, Aug 19, 4:33 PM · Restricted Project, Restricted Project
JDevlieghere accepted D66452: [lldb] Fix typo on the BreakpointLocation header and the lldbtest.py (NFC).

Thanks, Ismail. LGTM!

Mon, Aug 19, 4:18 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D66447: Add char8_t support (C++20).
  • Feedback Greg.
  • Remove dlang types.
Mon, Aug 19, 3:47 PM · Restricted Project
JDevlieghere updated the summary of D66447: Add char8_t support (C++20).
Mon, Aug 19, 3:47 PM · Restricted Project
JDevlieghere added inline comments to D66447: Add char8_t support (C++20).
Mon, Aug 19, 3:19 PM · Restricted Project
JDevlieghere updated the summary of D66447: Add char8_t support (C++20).
Mon, Aug 19, 3:16 PM · Restricted Project
JDevlieghere created D66447: Add char8_t support (C++20).
Mon, Aug 19, 3:13 PM · Restricted Project
JDevlieghere committed rL369302: [lldb] Set timeout to 90 and 60 min for build and testing respectively..
[lldb] Set timeout to 90 and 60 min for build and testing respectively.
Mon, Aug 19, 2:28 PM
JDevlieghere accepted D66442: Fix use-after-free.
Mon, Aug 19, 2:28 PM · Restricted Project, Restricted Project
JDevlieghere resigned from D54731: [lit] Enable the use of custom user-defined lit commands.
Mon, Aug 19, 12:37 PM · Restricted Project
JDevlieghere created D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER.
Mon, Aug 19, 10:36 AM · Restricted Project, Restricted Project
JDevlieghere committed rL369278: [lldb] Add DWARF variants to the matrix bot.
[lldb] Add DWARF variants to the matrix bot
Mon, Aug 19, 10:03 AM
JDevlieghere committed rL369274: [lldb] Remove old pipeline scripts.
[lldb] Remove old pipeline scripts
Mon, Aug 19, 9:17 AM
JDevlieghere committed rL369273: [lldb] Checking LLDB pipelines.
[lldb] Checking LLDB pipelines
Mon, Aug 19, 9:09 AM
JDevlieghere committed rG8880ac648ceb: [dotest] Add --dwarf-version to override the tested DWARF version. (authored by JDevlieghere).
[dotest] Add --dwarf-version to override the tested DWARF version.
Mon, Aug 19, 9:05 AM
JDevlieghere committed rL369272: [dotest] Add --dwarf-version to override the tested DWARF version..
[dotest] Add --dwarf-version to override the tested DWARF version.
Mon, Aug 19, 9:05 AM
JDevlieghere closed D66370: [dotest] Add a dotest flag `--force-dwarf` to override the tested DWARF version..
Mon, Aug 19, 9:05 AM · Restricted Project, Restricted Project
JDevlieghere accepted D66392: 1/2: D66174 `RegularExpression` cleanup.

Thanks, Jan. This LGTM with Pavel's comments addressed.

Mon, Aug 19, 8:54 AM · Restricted Project, Restricted Project

Sun, Aug 18

JDevlieghere committed rG45e598d1357c: [CMake] Update CMAKE_OSX_DEPLOYMENT_TARGET to 10.12. (authored by JDevlieghere).
[CMake] Update CMAKE_OSX_DEPLOYMENT_TARGET to 10.12.
Sun, Aug 18, 2:55 PM
JDevlieghere committed rL369220: [CMake] Update CMAKE_OSX_DEPLOYMENT_TARGET to 10.12..
[CMake] Update CMAKE_OSX_DEPLOYMENT_TARGET to 10.12.
Sun, Aug 18, 2:53 PM
JDevlieghere added a comment to D66392: 1/2: D66174 `RegularExpression` cleanup.

This code review seems to address a few things. I think it might have been easier to discuss if they were separate patches, but here are my comments:

Sun, Aug 18, 2:21 PM · Restricted Project, Restricted Project

Fri, Aug 16

JDevlieghere created D66370: [dotest] Add a dotest flag `--force-dwarf` to override the tested DWARF version..
Fri, Aug 16, 4:13 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D65983: Autogenerate the shebang lines for tools/opt-viewer.

Chris is correct, PYTHON_EXECUTABLE will be an absolute path. For this to work you'll need to remove /usr/bin/env.

Fri, Aug 16, 3:10 PM · Restricted Project
JDevlieghere committed rGf4bdbea02ff5: [RWMutex] Simplify availability check (authored by JDevlieghere).
[RWMutex] Simplify availability check
Fri, Aug 16, 2:32 PM
JDevlieghere committed rG3af3f1e8e253: [Utility] Reimplement RegularExpression on top of llvm::Regex (authored by JDevlieghere).
[Utility] Reimplement RegularExpression on top of llvm::Regex
Fri, Aug 16, 2:32 PM
JDevlieghere committed rL369153: [Utility] Reimplement RegularExpression on top of llvm::Regex.
[Utility] Reimplement RegularExpression on top of llvm::Regex
Fri, Aug 16, 2:32 PM
JDevlieghere committed rL369154: [RWMutex] Simplify availability check.
[RWMutex] Simplify availability check
Fri, Aug 16, 2:32 PM
JDevlieghere closed D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex.
Fri, Aug 16, 2:32 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex.

Make RegularExpression POSIX compliant.

Fri, Aug 16, 11:25 AM · Restricted Project, Restricted Project
JDevlieghere committed rG7e106445efdd: [ADT] Remove llvm::make_unique utility. (authored by JDevlieghere).
[ADT] Remove llvm::make_unique utility.
Fri, Aug 16, 10:26 AM
JDevlieghere committed rL369130: [ADT] Remove llvm::make_unique utility..
[ADT] Remove llvm::make_unique utility.
Fri, Aug 16, 10:19 AM
JDevlieghere accepted D66345: [lldb][NFC] Allow for-range iterating over StringList.

LGTM with the inline comment.

Fri, Aug 16, 9:11 AM · Restricted Project

Thu, Aug 15

JDevlieghere committed rGde0ce98abec0: [DebugLine] Don't try to guess the path style (authored by JDevlieghere).
[DebugLine] Don't try to guess the path style
Thu, Aug 15, 4:55 PM
JDevlieghere committed rL369072: [DebugLine] Don't try to guess the path style.
[DebugLine] Don't try to guess the path style
Thu, Aug 15, 4:55 PM
JDevlieghere committed rG6d6babf7457c: [Support] Re-introduce the RWMutexImpl for macOS < 10.12 (authored by JDevlieghere).
[Support] Re-introduce the RWMutexImpl for macOS < 10.12
Thu, Aug 15, 4:09 PM
JDevlieghere committed rL369064: [Support] Re-introduce the RWMutexImpl for macOS < 10.12.
[Support] Re-introduce the RWMutexImpl for macOS < 10.12
Thu, Aug 15, 4:06 PM
JDevlieghere closed D66313: Re-introduce the RWMutexImpl for macOS < 10.12.
Thu, Aug 15, 4:06 PM · Restricted Project
JDevlieghere committed rGf64dcdea6da4: Revert "[Support] Re-introduce the RWMutexImpl for macOS < 10.12" (authored by JDevlieghere).
Revert "[Support] Re-introduce the RWMutexImpl for macOS < 10.12"
Thu, Aug 15, 3:25 PM
JDevlieghere committed rL369059: Revert "[Support] Re-introduce the RWMutexImpl for macOS < 10.12".
Revert "[Support] Re-introduce the RWMutexImpl for macOS < 10.12"
Thu, Aug 15, 3:25 PM
JDevlieghere committed rG563e25f33877: [Support] Re-introduce the RWMutexImpl for macOS < 10.12 (authored by JDevlieghere).
[Support] Re-introduce the RWMutexImpl for macOS < 10.12
Thu, Aug 15, 3:25 PM
JDevlieghere committed rL369056: [Support] Re-introduce the RWMutexImpl for macOS < 10.12.
[Support] Re-introduce the RWMutexImpl for macOS < 10.12
Thu, Aug 15, 3:18 PM
JDevlieghere updated the summary of D66313: Re-introduce the RWMutexImpl for macOS < 10.12.
Thu, Aug 15, 3:12 PM · Restricted Project
JDevlieghere added a reviewer for D66313: Re-introduce the RWMutexImpl for macOS < 10.12: arphaman.
Thu, Aug 15, 3:08 PM · Restricted Project
JDevlieghere created D66313: Re-introduce the RWMutexImpl for macOS < 10.12.
Thu, Aug 15, 3:08 PM · Restricted Project
JDevlieghere committed rL369013: [llvm] Migrate llvm::make_unique to std::make_unique.
[llvm] Migrate llvm::make_unique to std::make_unique
Thu, Aug 15, 8:59 AM
JDevlieghere committed rG0eaee545eef4: [llvm] Migrate llvm::make_unique to std::make_unique (authored by JDevlieghere).
[llvm] Migrate llvm::make_unique to std::make_unique
Thu, Aug 15, 8:57 AM
JDevlieghere added a comment to D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex.

I was unhappy with the () workaround, so I did some investigation. Now, I am even more unhappy, but at least better educated. :P

Basically, what I've learned is that according to POSIX https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html an empty string is not a valid regular expression. Most tools seem to ignore that, and treat it as if it matches everything (and I can't say I blame them). However, the BSD implementation (that the llvm stuff is based on) tried to do a strict implementation and it rejects that as an invalid expression.

Funnily enough, () is not valid according to POSIX either, but the BSD implementation accepts it. So does (linux) grep and python. However, perl rejects it (it still considers it a valid expression, but one that doesn't match anything).

a||b (a OR empty pattern OR b) is also not valid. grep, python and perl accept that, but the BSD regexes don't.

So, overall, it seems to me that there is a lot of confusion about what should empty (sub-)patterns do. I don't think special-casing "" in lldb_private::RegularExpression would help alleviate any of that confusion as we would be still left with all of the other inconsistencies. So, if we want to go through with this (and I still think we should), I guess we'll just have to bite the bullet and say that our expressions are now (more or less) POSIX conformant, and repeat that to anyone who comes complaining that lldb regexes behave differently than grep, python or older versions of lldb...

Thu, Aug 15, 8:01 AM · Restricted Project, Restricted Project
JDevlieghere committed rG8903433bb285: Re-land "[compiler-rt] Migrate llvm::make_unique to std::make_unique" (authored by JDevlieghere).
Re-land "[compiler-rt] Migrate llvm::make_unique to std::make_unique"
Thu, Aug 15, 7:58 AM
JDevlieghere committed rL369009: Re-land "[compiler-rt] Migrate llvm::make_unique to std::make_unique".
Re-land "[compiler-rt] Migrate llvm::make_unique to std::make_unique"
Thu, Aug 15, 7:56 AM

Wed, Aug 14

JDevlieghere committed rG706cd705690b: Fix variable mismatch between signature and body (authored by JDevlieghere).
Fix variable mismatch between signature and body
Wed, Aug 14, 10:09 PM
JDevlieghere committed rL368962: Fix variable mismatch between signature and body.
Fix variable mismatch between signature and body
Wed, Aug 14, 10:09 PM
JDevlieghere committed rG4d474e078ac7: [CMake] Check for C++14 instead of C++11 (authored by JDevlieghere).
[CMake] Check for C++14 instead of C++11
Wed, Aug 14, 9:47 PM
JDevlieghere committed rL368960: [CMake] Check for C++14 instead of C++11.
[CMake] Check for C++14 instead of C++11
Wed, Aug 14, 9:46 PM
JDevlieghere closed D66271: [CMake] Check for C++14 instead of C++11.
Wed, Aug 14, 9:46 PM · Restricted Project, Restricted Project
JDevlieghere committed rGa7d4cec43724: [NFC] Fix documentation for some utility classes. (authored by JDevlieghere).
[NFC] Fix documentation for some utility classes.
Wed, Aug 14, 9:37 PM
JDevlieghere committed rL368959: [NFC] Fix documentation for some utility classes..
[NFC] Fix documentation for some utility classes.
Wed, Aug 14, 9:35 PM
JDevlieghere committed rG10e3fa28d0df: [NFC] Remove documentation comment to fix warning. (authored by JDevlieghere).
[NFC] Remove documentation comment to fix warning.
Wed, Aug 14, 9:13 PM
JDevlieghere committed rL368957: [NFC] Remove documentation comment to fix warning..
[NFC] Remove documentation comment to fix warning.
Wed, Aug 14, 9:08 PM
JDevlieghere committed rL368955: [LLDB] Honor extra compiler flags.
[LLDB] Honor extra compiler flags
Wed, Aug 14, 9:04 PM
JDevlieghere committed rGd24e9eb9d2a6: [NFC] Update doc comment to fix warning. (authored by JDevlieghere).
[NFC] Update doc comment to fix warning.
Wed, Aug 14, 9:00 PM
JDevlieghere committed rL368954: [NFC] Update doc comment to fix warning..
[NFC] Update doc comment to fix warning.
Wed, Aug 14, 8:58 PM
JDevlieghere committed rGed3b6d1bb227: Revert "Expose TailCallKind via the LLVM C API" (authored by JDevlieghere).
Revert "Expose TailCallKind via the LLVM C API"
Wed, Aug 14, 8:50 PM
JDevlieghere committed rL368953: Revert "Expose TailCallKind via the LLVM C API".
Revert "Expose TailCallKind via the LLVM C API"
Wed, Aug 14, 8:50 PM
JDevlieghere added a comment to D66061: Expose TailCallKind via the LLVM C API.

Y’all can revert it. I’ll resubmit the patch with updated tests tomorrow.

Wed, Aug 14, 8:47 PM · Restricted Project
JDevlieghere added a comment to D66061: Expose TailCallKind via the LLVM C API.

This test seems to be failing pretty much everywhere. Can you please have a look or should we revert it?

Wed, Aug 14, 8:46 PM · Restricted Project
JDevlieghere created D66271: [CMake] Check for C++14 instead of C++11.
Wed, Aug 14, 8:13 PM · Restricted Project, Restricted Project
JDevlieghere committed rGd65f37dbcc10: Revert "[compiler-rt] Migrate llvm::make_unique to std::make_unique" (authored by JDevlieghere).
Revert "[compiler-rt] Migrate llvm::make_unique to std::make_unique"
Wed, Aug 14, 8:04 PM
JDevlieghere committed rL368952: Revert "[compiler-rt] Migrate llvm::make_unique to std::make_unique".
Revert "[compiler-rt] Migrate llvm::make_unique to std::make_unique"
Wed, Aug 14, 8:03 PM
JDevlieghere committed rL368948: Add configure target.
Add configure target
Wed, Aug 14, 5:19 PM
JDevlieghere committed rG5edd6843fa14: [compiler-rt] Migrate llvm::make_unique to std::make_unique (authored by JDevlieghere).
[compiler-rt] Migrate llvm::make_unique to std::make_unique
Wed, Aug 14, 5:07 PM
JDevlieghere committed rL368946: [compiler-rt] Migrate llvm::make_unique to std::make_unique.
[compiler-rt] Migrate llvm::make_unique to std::make_unique
Wed, Aug 14, 5:05 PM