Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Software Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (328 w, 6 d)

Recent Activity

Yesterday

JDevlieghere accepted D126103: Remove `friend` classes from TypeCategoryMap.

LGTM

Fri, May 20, 5:48 PM · Restricted Project, Restricted Project
JDevlieghere committed rGd252d9231c4a: [lldb] Fix spurious assertion in PrintCommandOutput (authored by JDevlieghere).
[lldb] Fix spurious assertion in PrintCommandOutput
Fri, May 20, 2:16 PM · Restricted Project
JDevlieghere closed D126081: [lldb] Fix spurious lldb_assert in PrintCommandOutput.
Fri, May 20, 2:15 PM · Restricted Project, Restricted Project
JDevlieghere committed rGa3c3482ceb52: [lldb] Consider binary as module of last resort (authored by hawkinsw).
[lldb] Consider binary as module of last resort
Fri, May 20, 2:01 PM · Restricted Project
JDevlieghere closed D124731: [lldb] Consider binary as module of last resort.
Fri, May 20, 2:01 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D124731: [lldb] Consider binary as module of last resort.

Please let me know if you need someone to land this on your behalf.

Fri, May 20, 12:09 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D126080: Adapt C++ std::string dataformatter for D125496.

Thanks!

Fri, May 20, 12:07 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D126081: [lldb] Fix spurious lldb_assert in PrintCommandOutput.
Fri, May 20, 11:46 AM · Restricted Project, Restricted Project
JDevlieghere accepted D126078: [lldb] Improve formatting of dlopen error messages (NFC).

LGTM

Fri, May 20, 10:28 AM · Restricted Project, Restricted Project
JDevlieghere committed rGa1cf154dd476: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS) (authored by JDevlieghere).
[lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)
Fri, May 20, 9:37 AM · Restricted Project
JDevlieghere closed D126076: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS).
Fri, May 20, 9:37 AM · Restricted Project, Restricted Project
JDevlieghere requested review of D126076: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS).
Fri, May 20, 9:31 AM · Restricted Project, Restricted Project
JDevlieghere accepted D124731: [lldb] Consider binary as module of last resort.

No worries, thank you for your patience. This LGTM.

Fri, May 20, 9:13 AM · Restricted Project, Restricted Project
JDevlieghere accepted D126057: [lldb] Fix that empty target.run-args are not actually used when launching process.

LGTM. Passes the test suite on macOS.

Fri, May 20, 9:12 AM · Restricted Project, Restricted Project
JDevlieghere committed rG80c836ec557a: [lldb] Disable scripted_crashlog_json.test on Apple Silicon (authored by JDevlieghere).
[lldb] Disable scripted_crashlog_json.test on Apple Silicon
Fri, May 20, 8:26 AM · Restricted Project

Thu, May 19

JDevlieghere committed rGb9a30b69d814: [lldb] Update test_software_breakpoint_set_and_remove_work for AS (authored by JDevlieghere).
[lldb] Update test_software_breakpoint_set_and_remove_work for AS
Thu, May 19, 9:40 PM · Restricted Project
JDevlieghere committed rGea4864007c72: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer (authored by JDevlieghere).
[lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer
Thu, May 19, 9:40 PM · Restricted Project
JDevlieghere closed D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer .
Thu, May 19, 9:40 PM · Restricted Project, Restricted Project
JDevlieghere accepted D126021: [lldb/test] Fix PExpect.launch issue when disabling color support.
Thu, May 19, 2:46 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer .
Thu, May 19, 11:26 AM · Restricted Project, Restricted Project
JDevlieghere committed rZORG66fc9ebe9008: [lldb] Enable libcxx(abi) and compiler-rt as runtimes (authored by JDevlieghere).
[lldb] Enable libcxx(abi) and compiler-rt as runtimes
Thu, May 19, 10:18 AM · Restricted Project

Wed, May 18

JDevlieghere accepted D124785: [lldb/Core] Fix "sticky" long progress messages.

LGTM with the decorator

Wed, May 18, 6:15 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D124785: [lldb/Core] Fix "sticky" long progress messages.
Wed, May 18, 6:15 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression..

Separating the notion of an expression and an expression list seems worthwhile. I did a very high level pass but I'll take a more detailed look tomorrow.

Wed, May 18, 5:11 PM · Restricted Project, Restricted Project, Restricted Project
JDevlieghere accepted D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.

LGTM

Wed, May 18, 2:22 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125928: [lldb/crashlog] Fix line entries resolution in interactive mode.
Wed, May 18, 2:14 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D124731: [lldb] Consider binary as module of last resort.

Still a few places where we have a dedicated assert

Wed, May 18, 12:24 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D124785: [lldb/Core] Fix "sticky" long progress messages.
Wed, May 18, 12:21 PM · Restricted Project, Restricted Project
JDevlieghere accepted D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper.

LGTM

Wed, May 18, 11:54 AM · Restricted Project, Restricted Project
JDevlieghere accepted D125914: [llvm/Support] Fallback to $TERM if terminfo has no "colors" capability.

LGTM

Wed, May 18, 11:53 AM · Restricted Project, Restricted Project

Tue, May 17

JDevlieghere accepted D111791: [lldb] Add --all option to "memory region".

Minor nit but LGTM

Tue, May 17, 8:55 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 16

JDevlieghere committed rG9defb3b4b4a3: [lldb] Prevent underflow in crashlog.py (authored by JDevlieghere).
[lldb] Prevent underflow in crashlog.py
Mon, May 16, 3:00 PM · Restricted Project
JDevlieghere closed D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py.
Mon, May 16, 3:00 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py.
Mon, May 16, 11:47 AM · Restricted Project, Restricted Project
JDevlieghere accepted D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM.

LGTM

Mon, May 16, 11:39 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..
Mon, May 16, 8:20 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM.
Mon, May 16, 8:19 AM · Restricted Project, Restricted Project

Sat, May 14

JDevlieghere committed rGae016e4f7c85: [lldb] Don't swallow crashlog exceptions (authored by JDevlieghere).
[lldb] Don't swallow crashlog exceptions
Sat, May 14, 8:59 AM · Restricted Project
JDevlieghere committed rG447c920a8adf: [lldb] Remove unused imports from crashlog.py (authored by JDevlieghere).
[lldb] Remove unused imports from crashlog.py
Sat, May 14, 8:59 AM · Restricted Project
JDevlieghere closed D125589: [lldb] Don't swallow crashlog exceptions.
Sat, May 14, 8:59 AM · Restricted Project, Restricted Project

Fri, May 13

JDevlieghere accepted D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC).

LGTM

Fri, May 13, 6:14 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125589: [lldb] Don't swallow crashlog exceptions.
Fri, May 13, 3:52 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D125589: [lldb] Don't swallow crashlog exceptions.
Fri, May 13, 3:47 PM · Restricted Project, Restricted Project
JDevlieghere accepted D125219: [lldb][NFC] Simplify GenerateOptionUsage.

LGTM

Fri, May 13, 1:04 PM · Restricted Project, Restricted Project
JDevlieghere accepted D125218: [lldb][NFC] Make cmd a reference in GenerateOptionUsage.

LGTM

Fri, May 13, 1:03 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125474: [DWARFLinker][NFC] Add None value to the DwarfLinkerAccelTableKind enum..
Fri, May 13, 1:01 PM · Restricted Project, Restricted Project
JDevlieghere accepted D125492: [DWARFLinker][NFC] cleanup AddressManager interface..

LGTM

Fri, May 13, 12:59 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D125154: [lldb] Specify aguments of `image list`.

PS: Small typo in your summary: s/abot/about/.

Fri, May 13, 12:57 PM · Restricted Project, Restricted Project
JDevlieghere closed D125107: [lldb] Parallelize fetching symbol files in crashlog.py.

a8abb695859ad4e7fe695b9ee238a2b0cd00af7c

Fri, May 13, 12:53 PM · Restricted Project
JDevlieghere committed rGa8abb695859a: [lldb] Parallelize fetching symbol files in crashlog.py (authored by JDevlieghere).
[lldb] Parallelize fetching symbol files in crashlog.py
Fri, May 13, 12:26 PM · Restricted Project
JDevlieghere added inline comments to D124731: [lldb] Consider binary as module of last resort.
Fri, May 13, 12:14 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.
Fri, May 13, 12:08 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API.
Fri, May 13, 11:50 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API.
Fri, May 13, 11:18 AM · Restricted Project, Restricted Project

Wed, May 11

JDevlieghere accepted D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

Can we name the option something other than "--use-dlnext"? This option name won't mean much to users. Not sure what a good option name would be though but something that doesn't talk about internal classes that will be used would be better IMHO.

Wed, May 11, 3:41 AM · Restricted Project, Restricted Project

Fri, May 6

JDevlieghere added inline comments to D124785: [lldb/Core] Fix "sticky" long progress messages.
Fri, May 6, 11:41 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D125107: [lldb] Parallelize fetching symbol files in crashlog.py.
Fri, May 6, 11:00 AM · Restricted Project
JDevlieghere updated the summary of D125107: [lldb] Parallelize fetching symbol files in crashlog.py.
Fri, May 6, 10:57 AM · Restricted Project
JDevlieghere requested review of D125107: [lldb] Parallelize fetching symbol files in crashlog.py.
Fri, May 6, 10:57 AM · Restricted Project

Thu, May 5

JDevlieghere added a reviewer for D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0: mib.
Thu, May 5, 4:55 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0.

Does that mean that the interactive crashlogs (crashlog -i) do this correctly?

Thu, May 5, 4:55 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

I'm (still) very excited about this. I'm really happy that this lives behind a flag which addresses most of my original concerns. Making this the default in dsymutil would require a bunch of qualification but this approach allows me to do that gradually. One thing I suggested earlier I think was to run the lldb test suite with the new flag and see if that breaks anything. Did you ever get around to that? That should give us an initial level of confidence. Jim expressed some concerns about trying to squeeze everything in the same compilation unit. Greg, do you share that concern? Do we expect this will negatively impact lldb's performance? It would probably be worthwhile to do a few performance experiments here as well to make sure this doesn't regress debugging performance.

Thu, May 5, 4:51 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D96035: [dsymutil][DWARFlinker] implement separate multi-thread processing for compile units..

Does anyone cares about single thread execution time? I personally don't.

If we do not then things are easier :-)

I think @JDevlieghere and @aprantl probably care about it just from a regression perspective - but I could be wrong. (I thought they'd expressed some concerns about that in this/other reviews previously).

Apple folks ^ have you got a sense of if/how much of a single threaded regression you'd want to accept in this work, for some multithreaded gains?

Thu, May 5, 4:39 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..

When you used this to compare the output of dsymutil changes, what was the input binary? Does this generate meaningful output for bigger programs like dsymutil itself?

Thu, May 5, 4:29 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D124731: [lldb] Consider binary as module of last resort.

This looks reasonable to me, but I'm not sure if there's anything special about the executable module that would result in us doing the wrong thing. I'm sure Jim or Pavel will know.

Thu, May 5, 9:34 AM · Restricted Project, Restricted Project

Wed, May 4

JDevlieghere accepted D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64.

I'm far from an expert on this but the change makes sense to me and has good test coverage. LGTM.

Wed, May 4, 1:11 PM · Restricted Project, Restricted Project
JDevlieghere accepted D124947: Allow `target create` with no local file.

LGTM

Wed, May 4, 10:45 AM · Restricted Project, Restricted Project

Tue, May 3

JDevlieghere committed rGb945b62cf35e: [lldb] Add a function to check if lldb is running in an interactive session (authored by JDevlieghere).
[lldb] Add a function to check if lldb is running in an interactive session
Tue, May 3, 3:12 PM · Restricted Project
JDevlieghere committed rG3d08c778c01e: [lldb] Session transcript should use the async debugger streams (authored by JDevlieghere).
[lldb] Session transcript should use the async debugger streams
Tue, May 3, 3:12 PM · Restricted Project
JDevlieghere closed D124872: [lldb] Add a function to check if lldb is running in an interactive session.
Tue, May 3, 3:12 PM · Restricted Project, Restricted Project
JDevlieghere closed D124873: [lldb] Session transcript should use the async debugger streams.
Tue, May 3, 3:12 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D124872: [lldb] Add a function to check if lldb is running in an interactive session.

IsInteractiveSession -> IsInteractiveGraphicSession

Tue, May 3, 1:43 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D124873: [lldb] Session transcript should use the async debugger streams.

Typo

Tue, May 3, 1:35 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D124873: [lldb] Session transcript should use the async debugger streams.
Tue, May 3, 1:34 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D124872: [lldb] Add a function to check if lldb is running in an interactive session.
Tue, May 3, 1:22 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D124673: [llvm][lldb] use FindLibEdit.cmake everywhere.
Tue, May 3, 12:42 PM · Restricted Project, Restricted Project, Restricted Project

Mon, May 2

JDevlieghere committed rGe53019a8ff77: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory (authored by JDevlieghere).
[lldb] Make GetSharedModuleWithLocalCache consider the device support directory
Mon, May 2, 9:07 PM · Restricted Project
JDevlieghere closed D124801: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory.
Mon, May 2, 9:07 PM · Restricted Project, Restricted Project
JDevlieghere committed rG322b4130415a: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC) (authored by JDevlieghere).
[lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC)
Mon, May 2, 5:35 PM · Restricted Project
JDevlieghere committed rG41c0ff1e740b: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC) (authored by JDevlieghere).
[lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC)
Mon, May 2, 5:35 PM · Restricted Project
JDevlieghere committed rGd0067738e0cf: [lldb] Remove unused PlatformRemoteDarwinDevice::FindFileInAllSDKs (authored by JDevlieghere).
[lldb] Remove unused PlatformRemoteDarwinDevice::FindFileInAllSDKs
Mon, May 2, 5:35 PM · Restricted Project
JDevlieghere committed rGd75cc0859391: [lldb] Remove PlatformRemoteMacOSX::GetFileWithUUID overload (NFC) (authored by JDevlieghere).
[lldb] Remove PlatformRemoteMacOSX::GetFileWithUUID overload (NFC)
Mon, May 2, 5:35 PM · Restricted Project
JDevlieghere closed D124800: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC).
Mon, May 2, 5:35 PM · Restricted Project, Restricted Project
JDevlieghere closed D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC).
Mon, May 2, 5:35 PM · Restricted Project, Restricted Project
JDevlieghere updated the summary of D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC).
Mon, May 2, 1:18 PM · Restricted Project, Restricted Project
JDevlieghere updated the summary of D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC).
Mon, May 2, 1:18 PM · Restricted Project, Restricted Project
JDevlieghere updated the summary of D124800: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC).
Mon, May 2, 1:17 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D124801: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory.
Mon, May 2, 1:17 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D124800: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC).
Mon, May 2, 1:11 PM · Restricted Project, Restricted Project
JDevlieghere requested review of D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC).
Mon, May 2, 1:08 PM · Restricted Project, Restricted Project
JDevlieghere added a comment to D124785: [lldb/Core] Fix "sticky" long progress messages.

Can we add a pexpect test for this?

Mon, May 2, 11:46 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D124673: [llvm][lldb] use FindLibEdit.cmake everywhere.

I vaguely recall that some lldb bots use a stand-alone build.

Mon, May 2, 8:11 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Apr 29

JDevlieghere added a comment to D124314: lldb: Disable unittests if llvm_gtest target does not exist.

Could this go in LLDBStandalone.cmake?

Fri, Apr 29, 3:45 PM · Restricted Project, Restricted Project
JDevlieghere closed D119997: Add a little test for simple breaking on overloaded functions by name.
Fri, Apr 29, 3:44 PM · Restricted Project, Restricted Project
JDevlieghere accepted D124672: [lldb] Define LLDB_VERSION_PATCH correctly.

Good catch. Seems like there's another reference to this in llvm/utils/gn/secondary/lldb/include/lldb/Version/BUILD.gn but otherwise LGTM.

Fri, Apr 29, 8:22 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Apr 28

JDevlieghere committed rG02c2b472b510: [lldb] Remove ConnectionFileDescriptorTest.Connectv(4|6) (authored by JDevlieghere).
[lldb] Remove ConnectionFileDescriptorTest.Connectv(4|6)
Thu, Apr 28, 3:40 PM · Restricted Project
JDevlieghere committed rG9aa6a479738c: [lldb] Fix crash when launching in terminal (authored by JDevlieghere).
[lldb] Fix crash when launching in terminal
Thu, Apr 28, 2:40 PM · Restricted Project
JDevlieghere closed D124535: [lldb] Fix crash when launching in terminal.
Thu, Apr 28, 2:39 PM · Restricted Project, Restricted Project
JDevlieghere accepted D124604: [lldb] Use shutil.which in Shell tests find_executable.

LGTM

Thu, Apr 28, 10:07 AM · Restricted Project, Restricted Project
JDevlieghere committed rG0fe9a5f71a64: [llvm] Ignore .rej files in .gitignore (authored by JDevlieghere).
[llvm] Ignore .rej files in .gitignore
Thu, Apr 28, 8:45 AM · Restricted Project