JDevlieghere (Jonas Devlieghere)
Compiler Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (102 w, 3 d)

Recent Activity

Tue, Jan 16

JDevlieghere committed rL322543: [DebugInfo] Unify dumping of address ranges.
[DebugInfo] Unify dumping of address ranges
Tue, Jan 16, 3:19 AM
JDevlieghere closed D42056: [DebugInfo] Unify dumping of address ranges.
Tue, Jan 16, 3:19 AM · debug-info

Mon, Jan 15

JDevlieghere accepted D42021: [DWARF] v5 implementation of string offsets tables - producer side.

LGTM

Mon, Jan 15, 2:29 AM
JDevlieghere added a project to D42056: [DebugInfo] Unify dumping of address ranges: debug-info.
Mon, Jan 15, 2:28 AM · debug-info
JDevlieghere created D42056: [DebugInfo] Unify dumping of address ranges.
Mon, Jan 15, 2:27 AM · debug-info

Thu, Jan 11

JDevlieghere accepted D41961: Specify compiler host server through environment variable for bisection tool.
Thu, Jan 11, 2:39 PM

Tue, Jan 9

JDevlieghere updated subscribers of D41864: DBG_VALUE insertion for spills breaks bundles.

I don't know if this makes any sense, but could we maybe test this by constructing a bundled spill in a MIR file for an in-tree target?

Tue, Jan 9, 10:04 AM · debug-info

Fri, Jan 5

JDevlieghere committed rL321863: [DebugInfo] Don't crash when given invalid DWARFv5 line table prologue..
[DebugInfo] Don't crash when given invalid DWARFv5 line table prologue.
Fri, Jan 5, 2:04 AM
JDevlieghere closed D41615: [DebugInfo] Don't crash when given invalid DWARFv5 line table prologue..
Fri, Jan 5, 2:04 AM · debug-info

Thu, Dec 28

JDevlieghere added a comment to D41615: [DebugInfo] Don't crash when given invalid DWARFv5 line table prologue..

In a real object file it should never be zero. There are a bunch of places in the unittests where I construct one with version and addrsize both zero; those would have to be fixed if we wanted to have a check somewhere other than for a form that actually cares about that stuff.

Thu, Dec 28, 12:19 PM · debug-info
JDevlieghere added a comment to D41615: [DebugInfo] Don't crash when given invalid DWARFv5 line table prologue..

Paul, Adrian, if you guys think there's a better place to check this, please let me know. This solution felt the most generic, but maybe we can warn about this earlier (& with a more informative message). Does it ever make sense for the address size to be zero?

Thu, Dec 28, 9:00 AM · debug-info
JDevlieghere created D41615: [DebugInfo] Don't crash when given invalid DWARFv5 line table prologue..
Thu, Dec 28, 8:56 AM · debug-info
JDevlieghere committed rL321522: [dsymutil][NFC] Replace calls to CoreFoundation with LLVM equivalent..
[dsymutil][NFC] Replace calls to CoreFoundation with LLVM equivalent.
Thu, Dec 28, 6:06 AM
JDevlieghere added a project to D41531: [DebugInfo/DWARF] generate aranges for CU even if it has .debug_aranges entry: debug-info.
Thu, Dec 28, 2:21 AM · debug-info

Mon, Dec 25

JDevlieghere committed rL321444: [docs] Use dbgs() instead of errs() for DEBUG().
[docs] Use dbgs() instead of errs() for DEBUG()
Mon, Dec 25, 6:17 AM
JDevlieghere closed D41170: Use dbgs() instead of errs() in docs for DEBUG().
Mon, Dec 25, 6:17 AM

Thu, Dec 21

JDevlieghere added a comment to D41170: Use dbgs() instead of errs() in docs for DEBUG().

PS: Let me know if you need me to commit this for you.

Thu, Dec 21, 9:28 AM
JDevlieghere added inline comments to D41490: [YAML] Fix UTF-8 handling.
Thu, Dec 21, 8:52 AM
JDevlieghere accepted D41490: [YAML] Fix UTF-8 handling.

Makes sense to me. LGTM!

Thu, Dec 21, 8:24 AM
JDevlieghere accepted D41146: [DWARF] DWARF v5: Rework of string offsets table reader.

Thanks, Wolfgang. With these few nits addressed this LGTM.

Thu, Dec 21, 3:05 AM

Tue, Dec 19

JDevlieghere added a comment to rL321064: [dwarfdump] Lookup needs to be an unsigned long long parameter..

Test case?

Tue, Dec 19, 11:45 AM
JDevlieghere committed rL321101: [dwarfdump][test] Add test case for r321064.
[dwarfdump][test] Add test case for r321064
Tue, Dec 19, 11:43 AM
JDevlieghere committed rL321090: [clang] -foptimization-record-file= should imply -fsave-optimization-record.
[clang] -foptimization-record-file= should imply -fsave-optimization-record
Tue, Dec 19, 9:17 AM
JDevlieghere committed rC321090: [clang] -foptimization-record-file= should imply -fsave-optimization-record.
[clang] -foptimization-record-file= should imply -fsave-optimization-record
Tue, Dec 19, 9:17 AM
JDevlieghere closed D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record.
Tue, Dec 19, 9:17 AM
JDevlieghere added a comment to D40914: [NFC] Change the DWARF v5 string offsets table tests to generate the test object as part of the test..

This will likely not work on Darwin until we undo @davide's change in rL319995. I'm guessing that is the reason you didn't land this yet?

Tue, Dec 19, 8:13 AM
JDevlieghere updated subscribers of D40914: [NFC] Change the DWARF v5 string offsets table tests to generate the test object as part of the test..

This will likely not work on Darwin until we undo @davide's change in rL319995. I'm guessing that is the reason you didn't land this yet?

Tue, Dec 19, 8:04 AM
JDevlieghere accepted D41170: Use dbgs() instead of errs() in docs for DEBUG().

Thanks, Moritz!

Tue, Dec 19, 7:40 AM
JDevlieghere added a project to D41264: Fix faulty assertion for void type in debug info: debug-info.
Tue, Dec 19, 7:34 AM · debug-info
JDevlieghere accepted D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record.

Thanks Dmitry, this LGTM!

Tue, Dec 19, 7:26 AM

Dec 19 2017

JDevlieghere committed rL321064: [dwarfdump] Lookup needs to be an unsigned long long parameter..
[dwarfdump] Lookup needs to be an unsigned long long parameter.
Dec 19 2017, 1:46 AM

Dec 16 2017

JDevlieghere added inline comments to D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 16 2017, 4:00 AM

Dec 15 2017

JDevlieghere added a comment to D41290: [YAML] Add support for non-printable characters.

LGTM!

Dec 15 2017, 7:18 AM

Dec 14 2017

JDevlieghere added inline comments to D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 14 2017, 8:14 AM
JDevlieghere added a comment to D41102: Setup clang-doc frontend framework.

I don't know what basis is used to differentiate between the two, but should this be part of clang tools or clang-tools-extra?

Dec 14 2017, 6:12 AM · Restricted Project
JDevlieghere added inline comments to D41102: Setup clang-doc frontend framework.
Dec 14 2017, 6:11 AM · Restricted Project
JDevlieghere edited reviewers for D41102: Setup clang-doc frontend framework, added: klimek, alexfh; removed: JDevlieghere.
Dec 14 2017, 5:44 AM · Restricted Project

Dec 13 2017

JDevlieghere committed rL320605: [dsymutil][test] Fix failing test when no lipo binary available.
[dsymutil][test] Fix failing test when no lipo binary available
Dec 13 2017, 10:36 AM
JDevlieghere added a comment to D41180: [dsymutil] Re-enable threading.

I didn't see you had requested changes between seeing Adrian's accept and actually landing it. I'm happy to address this in a follow-up commit!

Dec 13 2017, 10:11 AM
JDevlieghere committed rL320601: [dsymutil] Re-enable threading.
[dsymutil] Re-enable threading
Dec 13 2017, 10:03 AM
This revision was not accepted when it landed; it landed in state Needs Revision.
Dec 13 2017, 10:03 AM
JDevlieghere added a comment to D36827: Changed createTemporaryFile without FD to actually create a file..

Rafael made some changes to have dsymutil use the new TempFile class in r318534 so I think it's no longer relevant there. Is this used anywhere else?

Dec 13 2017, 9:43 AM
JDevlieghere updated the diff for D41180: [dsymutil] Re-enable threading.
  • Improve explanation for using std::shared_ptr
Dec 13 2017, 7:37 AM
JDevlieghere created D41180: [dsymutil] Re-enable threading.
Dec 13 2017, 5:58 AM

Dec 12 2017

JDevlieghere requested changes to D41102: Setup clang-doc frontend framework.
Dec 12 2017, 4:44 AM · Restricted Project
JDevlieghere committed rL320469: [dsymutil] Accept line tables up to DWARFv5..
[dsymutil] Accept line tables up to DWARFv5.
Dec 12 2017, 3:33 AM
JDevlieghere closed D41084: [dsymutil] Accept DWARF4 line tables..
Dec 12 2017, 3:32 AM · debug-info

Dec 11 2017

JDevlieghere updated the diff for D41084: [dsymutil] Accept DWARF4 line tables..
  • Fix calculation and add test for DWARFv5
Dec 11 2017, 2:30 PM · debug-info
JDevlieghere added inline comments to D41084: [dsymutil] Accept DWARF4 line tables..
Dec 11 2017, 12:55 PM · debug-info
JDevlieghere created D41084: [dsymutil] Accept DWARF4 line tables..
Dec 11 2017, 11:59 AM · debug-info
JDevlieghere committed rL320399: [dwarfdump] Fix off-by-one bug in accelerator table extractor..
[dwarfdump] Fix off-by-one bug in accelerator table extractor.
Dec 11 2017, 10:23 AM
JDevlieghere closed D41063: [dwarfdump] Fix off-by-one bug in accelerator table extractor. by committing rL320399: [dwarfdump] Fix off-by-one bug in accelerator table extractor..
Dec 11 2017, 10:23 AM · debug-info
JDevlieghere updated the diff for D41063: [dwarfdump] Fix off-by-one bug in accelerator table extractor..
Dec 11 2017, 7:27 AM · debug-info
JDevlieghere added inline comments to D40987: Rewrite the cached map used for locating the most precise DIE among inlined subroutines for a given address..
Dec 11 2017, 3:38 AM
JDevlieghere created D41063: [dwarfdump] Fix off-by-one bug in accelerator table extractor..
Dec 11 2017, 3:37 AM · debug-info

Dec 8 2017

JDevlieghere added a comment to D40987: Rewrite the cached map used for locating the most precise DIE among inlined subroutines for a given address..

Thanks for working on this Chandler! It took me a while to fully grasp why you needed the parent interval in the second layer but it makes sense to me. I was considering a slightly different approach approach where you would do a depth first traversal and add the address ranges as you encounter them, but that would presumably just complicate getting the LowPC mapped to the most nested (most precise) inlined subroutine.

Dec 8 2017, 6:57 AM

Dec 7 2017

JDevlieghere committed rL320033: [dsymutil] Add -verify option to run DWARF verifier after linking..
[dsymutil] Add -verify option to run DWARF verifier after linking.
Dec 7 2017, 3:18 AM
JDevlieghere closed D40777: [dsymutil] Add -verify option to run DWARF verifier after linking. by committing rL320033: [dsymutil] Add -verify option to run DWARF verifier after linking..
Dec 7 2017, 3:18 AM

Dec 6 2017

JDevlieghere updated the diff for D40777: [dsymutil] Add -verify option to run DWARF verifier after linking..
Dec 6 2017, 3:39 AM

Dec 5 2017

JDevlieghere updated the diff for D40777: [dsymutil] Add -verify option to run DWARF verifier after linking..
Dec 5 2017, 8:27 AM
JDevlieghere added inline comments to D40777: [dsymutil] Add -verify option to run DWARF verifier after linking..
Dec 5 2017, 8:24 AM

Dec 4 2017

JDevlieghere committed rL319656: [NFC][lit] Use proper semantic versioning names for variables.
[NFC][lit] Use proper semantic versioning names for variables
Dec 4 2017, 6:02 AM

Dec 3 2017

JDevlieghere created D40777: [dsymutil] Add -verify option to run DWARF verifier after linking..
Dec 3 2017, 12:57 PM

Dec 1 2017

JDevlieghere committed rL319530: [lit] Don't enable LSan on Darwin for Apple clang 9.0.0.
[lit] Don't enable LSan on Darwin for Apple clang 9.0.0
Dec 1 2017, 2:50 AM
JDevlieghere closed D40672: [lit] Don't enable LSan on darwin for clang 900 by committing rL319530: [lit] Don't enable LSan on Darwin for Apple clang 9.0.0.
Dec 1 2017, 2:50 AM

Nov 30 2017

JDevlieghere created D40672: [lit] Don't enable LSan on darwin for clang 900.
Nov 30 2017, 1:25 PM
JDevlieghere committed rL319417: [dsymutil] Exclude namespace from ifdef in CFBundle.
[dsymutil] Exclude namespace from ifdef in CFBundle
Nov 30 2017, 2:42 AM
JDevlieghere committed rL319416: [dsymutil] Upstream getBundleInfo implementation.
[dsymutil] Upstream getBundleInfo implementation
Nov 30 2017, 2:25 AM
JDevlieghere closed D40244: [dsymutil] Upstream getBundleInfo implementation by committing rL319416: [dsymutil] Upstream getBundleInfo implementation.
Nov 30 2017, 2:25 AM

Nov 29 2017

JDevlieghere updated the diff for D40244: [dsymutil] Upstream getBundleInfo implementation.
  • Feedback Adrian
  • Remove dead code
Nov 29 2017, 10:31 AM
JDevlieghere added inline comments to D40244: [dsymutil] Upstream getBundleInfo implementation.
Nov 29 2017, 5:54 AM
JDevlieghere updated the diff for D40244: [dsymutil] Upstream getBundleInfo implementation.
  • Use std::unique_ptr with customer deleter.
  • Add ASCII art for license.
  • Conform CF code to LLVM's coding standards.
Nov 29 2017, 5:51 AM

Nov 28 2017

JDevlieghere added a project to D38002: Re-submit r289925 (Update .debug_line section version to match DWARF version): debug-info.
Nov 28 2017, 7:35 AM · debug-info

Nov 27 2017

JDevlieghere committed rL319044: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value.
[llvm-dwarfdump] Display DW_AT_high_pc as absolute value
Nov 27 2017, 8:41 AM
JDevlieghere closed D40317: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value by committing rL319044: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value.
Nov 27 2017, 8:41 AM · debug-info

Nov 24 2017

JDevlieghere set the repository for D40440: [TailRecursionElimination] Skip debug intrinsics. to rL LLVM.
Nov 24 2017, 7:23 AM · debug-info

Nov 23 2017

JDevlieghere updated the diff for D40317: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value.
  • Update form.test to check we don't print the address in verbose and show-form mode.
Nov 23 2017, 2:13 AM · debug-info

Nov 22 2017

JDevlieghere added inline comments to D40317: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value.
Nov 22 2017, 5:44 AM · debug-info
JDevlieghere updated the diff for D40317: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value.
  • Don't print address with -verbose
Nov 22 2017, 5:42 AM · debug-info

Nov 21 2017

JDevlieghere accepted D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo.

Looks good to me!

Nov 21 2017, 12:18 PM · debug-info
JDevlieghere created D40317: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value.
Nov 21 2017, 9:59 AM · debug-info
JDevlieghere accepted D40200: [DWARF] Fix handling of extended line-number opcodes.

LGTM!

Nov 21 2017, 7:39 AM · debug-info

Nov 20 2017

JDevlieghere added a comment to D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record.

This also ensures that if fno_save_optimization_record is specified, you don't overwrite it by setting the file. This is definitely something you'd want to add to your test case.

Nov 20 2017, 7:16 AM
JDevlieghere added a comment to D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record.

I think you can achieve the same result with less code by checking for the flag's presence higher up, where currently OPT_fsave_optimization_record is handled (Clang.cpp:4329). Something like:

Nov 20 2017, 7:14 AM
JDevlieghere created D40244: [dsymutil] Upstream getBundleInfo implementation.
Nov 20 2017, 6:13 AM

Nov 19 2017

JDevlieghere added inline comments to D40200: [DWARF] Fix handling of extended line-number opcodes.
Nov 19 2017, 11:22 AM · debug-info

Nov 17 2017

JDevlieghere accepted D40110: Use TempFile in dsymutil.

Thanks Rafael, LGTM!

Nov 17 2017, 1:36 AM
JDevlieghere added a project to D40156: Fix recursive attribute fetching in DWARFDie: debug-info.
Nov 17 2017, 1:35 AM · debug-info

Nov 16 2017

JDevlieghere added inline comments to D40110: Use TempFile in dsymutil.
Nov 16 2017, 11:54 AM
JDevlieghere added a comment to D40114: [DebugInfo] Dump a .debug_line section, with line-number program, without a compile unit..

Thanks for accepting, Jonas! FWIW accepting by itself does not cause Phab to send email, there still needs to be a comment.

Nov 16 2017, 11:18 AM · debug-info
JDevlieghere accepted D40135: Make exitDsymutil static.

Thanks Rafael!

Nov 16 2017, 9:13 AM
JDevlieghere accepted D40114: [DebugInfo] Dump a .debug_line section, with line-number program, without a compile unit..
Nov 16 2017, 3:34 AM · debug-info
JDevlieghere accepted D40104: [SelectionDAG] Consolidate (t|T)ransferDbgValues methods, NFC..

Great!

Nov 16 2017, 3:26 AM · debug-info
JDevlieghere added inline comments to D40110: Use TempFile in dsymutil.
Nov 16 2017, 2:53 AM

Nov 15 2017

JDevlieghere added a project to D39982: [IRBuilder] Set the insert point and debug location together: debug-info.
Nov 15 2017, 9:36 AM · debug-info
JDevlieghere added a project to D39950: [DebugInfo] Stable sort symbols to remove non-deterministic ordering: debug-info.
Nov 15 2017, 9:34 AM · debug-info
JDevlieghere added a project to D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo: debug-info.
Nov 15 2017, 9:34 AM · debug-info
JDevlieghere accepted D40057: Simplify file handling in dsymutil.
Nov 15 2017, 9:32 AM
JDevlieghere added a project to D38719: [llvm-dwarfdump] Verify compatible TAG for attributes.: debug-info.
Nov 15 2017, 8:34 AM · debug-info
JDevlieghere created debug-info.
Nov 15 2017, 8:33 AM