Page MenuHomePhabricator

JDevlieghere (Jonas Devlieghere)
Software Engineer

Projects

User Details

User Since
Jan 31 2016, 7:15 AM (208 w, 20 h)

Recent Activity

Fri, Jan 24

JDevlieghere committed rG1c90ce0c7617: [lldb/Test] Disable hardware check on arm/aarch64 (authored by JDevlieghere).
[lldb/Test] Disable hardware check on arm/aarch64
Fri, Jan 24, 8:56 PM
JDevlieghere committed rG1ed561aa4bdc: [lldb/Test] Update minidebuginfo-set-and-hit-breakpoint.test (authored by JDevlieghere).
[lldb/Test] Update minidebuginfo-set-and-hit-breakpoint.test
Fri, Jan 24, 8:48 PM
JDevlieghere committed rGd8e0f4fae7a2: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP (authored by JDevlieghere).
[lldb/Breakpoint] Include whether or not a breakpoint is a HW BP
Fri, Jan 24, 7:27 PM
JDevlieghere committed rG2bc38ab3d038: [lldb/Breakpoint] Recogize hardware breakpoints as such (authored by JDevlieghere).
[lldb/Breakpoint] Recogize hardware breakpoints as such
Fri, Jan 24, 7:27 PM
JDevlieghere closed D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP.
Fri, Jan 24, 7:27 PM · Restricted Project
JDevlieghere closed D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions..
Fri, Jan 24, 7:27 PM · Restricted Project
JDevlieghere added a parent revision for D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP: D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions..
Fri, Jan 24, 7:00 PM · Restricted Project
JDevlieghere updated the diff for D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP.
Fri, Jan 24, 7:00 PM · Restricted Project
JDevlieghere added a child revision for D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions.: D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP.
Fri, Jan 24, 7:00 PM · Restricted Project
JDevlieghere created D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions..
Fri, Jan 24, 6:52 PM · Restricted Project
JDevlieghere committed rGe3a7c7713cd8: [lldb/Lit] Change the lldbtest format to behave more like shell test. (authored by JDevlieghere).
[lldb/Lit] Change the lldbtest format to behave more like shell test.
Fri, Jan 24, 4:27 PM
JDevlieghere closed D73384: [lldb/Lit] Change the lldbtest format to behave more like shell test..
Fri, Jan 24, 4:27 PM · Restricted Project
JDevlieghere created D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP.
Fri, Jan 24, 4:09 PM · Restricted Project
JDevlieghere committed rG96f3ea0d21b4: [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386 (authored by JDevlieghere).
[lldb/debugserver] Implement hardware breakpoints for x86_64 and i386
Fri, Jan 24, 3:14 PM
JDevlieghere closed D72985: [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386.
Fri, Jan 24, 3:14 PM · Restricted Project
JDevlieghere committed rG9902c8e3c661: [lldb/debugserver] Unify the breakpoint/watchpoint interface (NFCI) (authored by JDevlieghere).
[lldb/debugserver] Unify the breakpoint/watchpoint interface (NFCI)
Fri, Jan 24, 3:14 PM
JDevlieghere closed D72981: [debugserver] Unify the breakpoint/watchpoint interface (NFCI).
Fri, Jan 24, 3:14 PM · Restricted Project
JDevlieghere created D73384: [lldb/Lit] Change the lldbtest format to behave more like shell test..
Fri, Jan 24, 3:05 PM · Restricted Project
JDevlieghere added a reviewer for D73314: [lldb/Commands] Make column available through _regexp-break: clayborg.
Fri, Jan 24, 12:45 PM · Restricted Project
JDevlieghere created D73332: [llvm][TextAPI/MachO] Extract common code into unittest helper (NFC).
Fri, Jan 24, 12:12 AM · Restricted Project

Thu, Jan 23

JDevlieghere retitled D73325: [llvm][TextAPI/MachO] Support writing single macCatalyst platform from [TAPI] Support writing single macCatalyst platform to [llvm][TextAPI/MachO] Support writing single macCatalyst platform.
Thu, Jan 23, 11:54 PM · Restricted Project
JDevlieghere added a child revision for D73330: [llvm][TextAPI/MachO] Extend TBD_V4 unittest to verify writing: D73331: [llvm][TextAPI/MachO] Emit swift ABI version as an un integer in TBD_V4.
Thu, Jan 23, 11:54 PM · Restricted Project
JDevlieghere added a parent revision for D73331: [llvm][TextAPI/MachO] Emit swift ABI version as an un integer in TBD_V4: D73330: [llvm][TextAPI/MachO] Extend TBD_V4 unittest to verify writing.
Thu, Jan 23, 11:54 PM · Restricted Project
JDevlieghere created D73331: [llvm][TextAPI/MachO] Emit swift ABI version as an un integer in TBD_V4.
Thu, Jan 23, 11:54 PM · Restricted Project
JDevlieghere created D73330: [llvm][TextAPI/MachO] Extend TBD_V4 unittest to verify writing.
Thu, Jan 23, 11:36 PM · Restricted Project
JDevlieghere committed rG4274a610b3c2: [llvm][TextAPI/MachO] Extend TBD_V3 unittest to verify writing (authored by JDevlieghere).
[llvm][TextAPI/MachO] Extend TBD_V3 unittest to verify writing
Thu, Jan 23, 11:20 PM
JDevlieghere closed D73328: [llvm][TextAPI/MachO] Extend TBD_V3 unittest to verify writing.
Thu, Jan 23, 11:20 PM · Restricted Project
JDevlieghere added a comment to D73328: [llvm][TextAPI/MachO] Extend TBD_V3 unittest to verify writing.

small comment, otherwise LGTM

Thu, Jan 23, 11:19 PM · Restricted Project
JDevlieghere committed rGb14937cd1acc: [llvm][TextAPI/MachO] Update variable names in unit tests. (NFC) (authored by JDevlieghere).
[llvm][TextAPI/MachO] Update variable names in unit tests. (NFC)
Thu, Jan 23, 11:19 PM
JDevlieghere closed D73326: [TAPI] Update variable names to match TAPI version in unit tests. (NFC).
Thu, Jan 23, 11:19 PM · Restricted Project
JDevlieghere updated the diff for D73328: [llvm][TextAPI/MachO] Extend TBD_V3 unittest to verify writing.

Format patch

Thu, Jan 23, 11:19 PM · Restricted Project
JDevlieghere retitled D73325: [llvm][TextAPI/MachO] Support writing single macCatalyst platform from [TAPI] Support macCatalyst in TBD_V4 to [TAPI] Support writing single macCatalyst platform.
Thu, Jan 23, 11:19 PM · Restricted Project
JDevlieghere created D73328: [llvm][TextAPI/MachO] Extend TBD_V3 unittest to verify writing.
Thu, Jan 23, 11:10 PM · Restricted Project
JDevlieghere created D73326: [TAPI] Update variable names to match TAPI version in unit tests. (NFC).
Thu, Jan 23, 10:52 PM · Restricted Project
JDevlieghere committed rGbe2bc6b1d0f6: [lldb/Util] Remove reproducers after replay (authored by JDevlieghere).
[lldb/Util] Remove reproducers after replay
Thu, Jan 23, 9:53 PM
JDevlieghere created D73325: [llvm][TextAPI/MachO] Support writing single macCatalyst platform.
Thu, Jan 23, 9:53 PM · Restricted Project
JDevlieghere committed rGd92f77606aa6: [lldb/Util] Fix Python 3 incompatibility in lldb-repro (authored by JDevlieghere).
[lldb/Util] Fix Python 3 incompatibility in lldb-repro
Thu, Jan 23, 9:44 PM
JDevlieghere added inline comments to D73303: [lldb/Target] Add Abort StackFrame Recognizer.
Thu, Jan 23, 8:44 PM · Restricted Project
JDevlieghere accepted D73316: [ADT] Remove more llvm::make_unique.

LGTM!

Thu, Jan 23, 7:16 PM · Restricted Project
JDevlieghere created D73314: [lldb/Commands] Make column available through _regexp-break.
Thu, Jan 23, 5:01 PM · Restricted Project
JDevlieghere committed rG47d7a81ba4bb: [lldb/Util] Use md5 instead of python's hash function. (authored by JDevlieghere).
[lldb/Util] Use md5 instead of python's hash function.
Thu, Jan 23, 4:41 PM
JDevlieghere committed rG8d508c597aaf: [lldb/Test] Disallow using substituted binaries in shell test. (authored by JDevlieghere).
[lldb/Test] Disallow using substituted binaries in shell test.
Thu, Jan 23, 2:41 PM
JDevlieghere closed D73289: [lldb/Test] Disallow using substituted binaries in shell test..
Thu, Jan 23, 2:40 PM · Restricted Project
JDevlieghere added inline comments to D73289: [lldb/Test] Disallow using substituted binaries in shell test..
Thu, Jan 23, 2:22 PM · Restricted Project
JDevlieghere committed rGd8acf8852dbf: [lldb/Test] Disable command-breakpoint-col.test on Windows (authored by JDevlieghere).
[lldb/Test] Disable command-breakpoint-col.test on Windows
Thu, Jan 23, 2:22 PM
JDevlieghere updated the summary of D73289: [lldb/Test] Disallow using substituted binaries in shell test..
Thu, Jan 23, 12:57 PM · Restricted Project
JDevlieghere created D73289: [lldb/Test] Disallow using substituted binaries in shell test..
Thu, Jan 23, 12:57 PM · Restricted Project
JDevlieghere committed rG6672a4f5b64f: [lldb/Commands] Fix, rename and document column number arg to breakpoint set. (authored by JDevlieghere).
[lldb/Commands] Fix, rename and document column number arg to breakpoint set.
Thu, Jan 23, 12:37 PM
JDevlieghere closed D73284: [lldb/Commands] Fix, rename and document column number argument to breakpoint set..
Thu, Jan 23, 12:37 PM · Restricted Project
JDevlieghere committed rG794b8a0329d1: [lldb] s/lldb/%lldb in another test (authored by JDevlieghere).
[lldb] s/lldb/%lldb in another test
Thu, Jan 23, 11:17 AM
JDevlieghere created D73284: [lldb/Commands] Fix, rename and document column number argument to breakpoint set..
Thu, Jan 23, 11:05 AM · Restricted Project
JDevlieghere accepted D73258: [lldb][NFC] Fix all formatting errors in .cpp file headers.
Thu, Jan 23, 8:34 AM · Restricted Project

Wed, Jan 22

JDevlieghere added inline comments to D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods.
Wed, Jan 22, 6:27 PM · Restricted Project
JDevlieghere committed rGcf2b498d2840: [llvm/Transforms] Fix warning: private field 'MSSA' is not used (authored by JDevlieghere).
[llvm/Transforms] Fix warning: private field 'MSSA' is not used
Wed, Jan 22, 6:18 PM
JDevlieghere committed rZORGa286f239d954: Fix missing '\' in pipeline (authored by JDevlieghere).
Fix missing '\' in pipeline
Wed, Jan 22, 6:18 PM
JDevlieghere committed rG48490e3247af: [lldb/Docs] Document testing strategies for the reproducers (authored by JDevlieghere).
[lldb/Docs] Document testing strategies for the reproducers
Wed, Jan 22, 6:09 PM
JDevlieghere committed rG9b5a9f2fab17: [lldb/Test] Fix type in add_lit_testsuite (authored by JDevlieghere).
[lldb/Test] Fix type in add_lit_testsuite
Wed, Jan 22, 5:59 PM
JDevlieghere committed rZORG9adbdf08e137: [lldb] Add lldb reproducer test stage (authored by JDevlieghere).
[lldb] Add lldb reproducer test stage
Wed, Jan 22, 5:41 PM
JDevlieghere committed rG9be5c1353889: [lldb/Test] Add check-lldb-repro target (authored by JDevlieghere).
[lldb/Test] Add check-lldb-repro target
Wed, Jan 22, 5:41 PM
JDevlieghere committed rG83a093b8ecc8: [lldb/Reproducer] Mark some driver tests as unsupported for lldb-repro (authored by JDevlieghere).
[lldb/Reproducer] Mark some driver tests as unsupported for lldb-repro
Wed, Jan 22, 5:23 PM
JDevlieghere committed rGc4144caf9b86: [lldb/Reproducer] Disable buffering of stdout during replay (authored by JDevlieghere).
[lldb/Reproducer] Disable buffering of stdout during replay
Wed, Jan 22, 4:19 PM
JDevlieghere committed rG6ae61f7675d6: [lldb/Test] Skip script interpreter tests reading from stdin for lldb-repro (authored by JDevlieghere).
[lldb/Test] Skip script interpreter tests reading from stdin for lldb-repro
Wed, Jan 22, 3:25 PM
JDevlieghere committed rG4c2b0a636615: [lldb/Utility] Don't forward directories to the file collector (authored by JDevlieghere).
[lldb/Utility] Don't forward directories to the file collector
Wed, Jan 22, 3:03 PM
JDevlieghere added inline comments to D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods.
Wed, Jan 22, 2:04 PM · Restricted Project
JDevlieghere committed rG8401698fb57e: [lldb/Reproducer] Correctly instrument enum values (authored by JDevlieghere).
[lldb/Reproducer] Correctly instrument enum values
Wed, Jan 22, 1:28 PM
JDevlieghere committed rG31662e67e089: [lldb/Util] Fix lldb-repro now it doesn't take a path to lldb (authored by JDevlieghere).
[lldb/Util] Fix lldb-repro now it doesn't take a path to lldb
Wed, Jan 22, 1:28 PM
JDevlieghere committed rG536612df4b49: [lldb/Test] Use lit's capabilities to skip lldb-repro tests. (authored by JDevlieghere).
[lldb/Test] Use lit's capabilities to skip lldb-repro tests.
Wed, Jan 22, 1:28 PM
JDevlieghere added a comment to D73119: [lldb/Initializers] Rename plugins to match their entry points.

As for AppleObjCRuntime, I'm not insisting on changing that, though I am wondering if that won't get it your way when autogenerating the initalizers. I'm not fully sure what are your plans for that. If you're going to generate the #include lines then it looks like this discrepancy will matter. If you're going the "extern" route, then generating #include is not needed and you headers can be called anything. With the global constructor approach (my favourite :P) we wouldn't need to autogenerate anything at all...

Wed, Jan 22, 9:55 AM · Restricted Project

Tue, Jan 21

JDevlieghere committed rG1d1ebb9e592b: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime (authored by JDevlieghere).
[lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime
Tue, Jan 21, 10:34 PM
JDevlieghere closed D73121: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime.
Tue, Jan 21, 10:34 PM · Restricted Project
JDevlieghere added a comment to D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses.

I'm seeing some really weird behavior for the following two tests and I'm honestly kind of puzzled.

ObjectFile/ELF/PT_LOAD-overlap-PT_TLS.yaml
ObjectFile/ELF/PT_TLS-overlap-PT_LOAD.yaml
Tue, Jan 21, 9:36 PM · Restricted Project
JDevlieghere committed rG62e4b501ab3b: Revert "[Concepts] Placeholder constraints and abbreviated templates" (authored by JDevlieghere).
Revert "[Concepts] Placeholder constraints and abbreviated templates"
Tue, Jan 21, 7:14 PM
JDevlieghere added a reverting change for rGe03ead6771fc: [Concepts] Placeholder constraints and abbreviated templates: rG62e4b501ab3b: Revert "[Concepts] Placeholder constraints and abbreviated templates".
Tue, Jan 21, 7:14 PM
JDevlieghere added a comment to D65042: [Concept] Placeholder constraints and abbreviated templates.

Hey Saar, I have temporarily reverted this because it broke the LLDB bots. Please run the LLDB test suite when you make changes to the AST importer & keep an eye on the bots when you re-land this. Thanks!

Tue, Jan 21, 7:13 PM · Restricted Project
JDevlieghere added a comment to D72552: [Concepts] Constraint Satisfaction Caching.

It looks like the concept changes broke the debugger (quite spectacularly actually):

http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/3356
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12872
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/6407/

I'm rebuilding locally to see if I can reproduce

Tue, Jan 21, 7:04 PM · Restricted Project
JDevlieghere added a comment to D72552: [Concepts] Constraint Satisfaction Caching.

It looks like the concept changes broke the debugger (quite spectacularly actually):

Tue, Jan 21, 6:55 PM · Restricted Project
JDevlieghere added a comment to D73119: [lldb/Initializers] Rename plugins to match their entry points.

I think the remaining discrepancies between the plugin name and the directory make sense. For example, I don't really see the benefit of renaming AppleObjCRuntime to LanguageRuntimeAppleObjeC. The ClangASTContext is the exception, but I really don't want to rename that class :-)

Tue, Jan 21, 4:39 PM · Restricted Project
JDevlieghere updated the diff for D73119: [lldb/Initializers] Rename plugins to match their entry points.
Tue, Jan 21, 4:13 PM · Restricted Project
JDevlieghere committed rGbe9604247e33: [lldb/Plugin] Move DisassemblerLLVMC for consistency with plugin (NFC) (authored by JDevlieghere).
[lldb/Plugin] Move DisassemblerLLVMC for consistency with plugin (NFC)
Tue, Jan 21, 3:18 PM
JDevlieghere committed rGfc1e85511241: [lldb/Plugin] Rename MainThreadCheckerRuntime for consistency with plugin (NFC) (authored by JDevlieghere).
[lldb/Plugin] Rename MainThreadCheckerRuntime for consistency with plugin (NFC)
Tue, Jan 21, 3:09 PM
JDevlieghere committed rG623c3c4cf96b: [lldb/Plugin] Rename UBSanRuntime for consistency with plugin (NFC) (authored by JDevlieghere).
[lldb/Plugin] Rename UBSanRuntime for consistency with plugin (NFC)
Tue, Jan 21, 3:09 PM
JDevlieghere committed rG0feedebf4f4b: [lldb/Plugin] Rename AddressSanitizerRuntime for consistency with plugin (NFC) (authored by JDevlieghere).
[lldb/Plugin] Rename AddressSanitizerRuntime for consistency with plugin (NFC)
Tue, Jan 21, 3:09 PM
JDevlieghere committed rG7745990dd932: [lldb/Plugin] Rename TSanRuntime for consistency with plugin (NFC) (authored by JDevlieghere).
[lldb/Plugin] Rename TSanRuntime for consistency with plugin (NFC)
Tue, Jan 21, 3:09 PM
JDevlieghere committed rZORGf54354cb3888: [lldb] Only run the shell test for the Xcode standalone build (authored by JDevlieghere).
[lldb] Only run the shell test for the Xcode standalone build
Tue, Jan 21, 1:37 PM
JDevlieghere accepted D73112: [lldb/DWARF] Remove one more auto-dwo method.

LGTM

Tue, Jan 21, 1:37 PM · Restricted Project
JDevlieghere committed rGaa91ce3e1dd5: [lldb/CMake] Add check-lldb-shell and check-lldb-api targets for Xcode (authored by JDevlieghere).
[lldb/CMake] Add check-lldb-shell and check-lldb-api targets for Xcode
Tue, Jan 21, 1:29 PM
JDevlieghere accepted D72915: [Dsymutil][Debuginfo][NFC] #4 Refactor dsymutil to separate DWARF optimizing part..
Tue, Jan 21, 1:10 PM · debug-info, Restricted Project
JDevlieghere added a comment to D73040: [DWARF] Get rid of DWARFDebugNames::HeaderPOD. NFC..

Is there any way we can test this?

Tue, Jan 21, 12:42 PM · Restricted Project, debug-info
JDevlieghere committed rGb6c62ef08715: [lldb/Platform] Re-add ifdef's to guard macOS-only code. (authored by JDevlieghere).
[lldb/Platform] Re-add ifdef's to guard macOS-only code.
Tue, Jan 21, 12:33 PM
JDevlieghere added inline comments to D73121: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime.
Tue, Jan 21, 11:55 AM · Restricted Project
JDevlieghere created D73125: [lldb/Plugins] Move entry points out of plugin namespace.
Tue, Jan 21, 10:29 AM · Restricted Project
JDevlieghere committed rGcf263807a6c0: [lldb/tools] Update lldb-test's system initializer (authored by JDevlieghere).
[lldb/tools] Update lldb-test's system initializer
Tue, Jan 21, 10:00 AM
JDevlieghere committed rG72b8bad1505b: [lldb/Hexagon] Include <mutex> (authored by JDevlieghere).
[lldb/Hexagon] Include <mutex>
Tue, Jan 21, 9:59 AM
JDevlieghere created D73121: [lldb/Initializers] Move all ObjC initializers into AppleObjCRuntime.
Tue, Jan 21, 9:48 AM · Restricted Project
JDevlieghere committed rGa731c6ba94d0: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX (authored by JDevlieghere).
[lldb/Initializers] Move all macOS initializers into PlatformMacOSX
Tue, Jan 21, 9:42 AM
JDevlieghere closed D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX.
Tue, Jan 21, 9:42 AM · Restricted Project
JDevlieghere created D73119: [lldb/Initializers] Rename plugins to match their entry points.
Tue, Jan 21, 9:38 AM · Restricted Project
JDevlieghere added a child revision for D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX: D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins (WIP).
Tue, Jan 21, 9:13 AM · Restricted Project
JDevlieghere added a parent revision for D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins (WIP): D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX.
Tue, Jan 21, 9:13 AM · Restricted Project
JDevlieghere created D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX.
Tue, Jan 21, 9:13 AM · Restricted Project