Page MenuHomePhabricator

Today

trixirt added a comment to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

Latest change addresses most of issues.
Outstanding is adding a test when garbage GuardStyle value is fed into config.
The trial testcase used only CHECK-*-NOT which caused complaining from test harness looking for the CHECK- cases.
Looking for something similar in the other checker tests did not turn up anything.
In general it seems like clang-tidy assumes developers get the string names of the options and their values correct and does not provide a lot of (any?) checking.

Mon, May 20, 5:45 PM · Restricted Project, Restricted Project
clayborg accepted D62159: LLGS: support 32-bit on 64-bit hosts.
Mon, May 20, 5:36 PM · Restricted Project
smeenai updated subscribers of D62063: CMake changes to get Windows self-host with PGO working.
In D62063#1509321, @rnk wrote:

Seems reasonable to me. I'm surprised CMake doesn't have a general facility for escaping paths used in cflags. I suppose users generally don't add paths, just flags.

Mon, May 20, 5:35 PM · Restricted Project
trixirt updated the diff for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.

Change the GuardStyle data type from a string to an enum.
Add test cases for explicitly setting valid style.
Document valid style values.
Reduce llvm-header-guard doc to point to bugprone-header-guard.

Mon, May 20, 5:35 PM · Restricted Project, Restricted Project
thakis committed rG4522e2669643: Try to fix build with older gccs after r361152 (authored by thakis).
Try to fix build with older gccs after r361152
Mon, May 20, 5:27 PM
nico committed rL361209: Try to fix build with older gccs after r361152.
Try to fix build with older gccs after r361152
Mon, May 20, 5:24 PM
nico committed rC361209: Try to fix build with older gccs after r361152.
Try to fix build with older gccs after r361152
Mon, May 20, 5:24 PM
smeenai added inline comments to D62155: [CMake] Copy C++ headers before configuring runtimes build.
Mon, May 20, 5:23 PM · Restricted Project, Restricted Project
rampitec updated the diff for D62162: Fix register coalescer failure to prune value.

Reduced test.

Mon, May 20, 5:23 PM
rampitec accepted D62134: MC: Allow getMaxInstLength to depend on the subtarget.

LGTM

Mon, May 20, 5:23 PM
akhuang created D62167: CodeView - add static data members to global variable debug info..
Mon, May 20, 5:23 PM · Restricted Project, Restricted Project
dtemirbulatov added inline comments to D57779: [SLP] Add support for throttling..
Mon, May 20, 5:11 PM
dtemirbulatov added inline comments to D57779: [SLP] Add support for throttling..
Mon, May 20, 5:08 PM
GitHub <noreply@github.com> committed rGfa4afbdfd7af: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
Mon, May 20, 5:02 PM
EricWF added a comment to D62155: [CMake] Copy C++ headers before configuring runtimes build.

I dont see any problems with this change. But I'm not sure I have any interesting insight either.

Mon, May 20, 5:02 PM · Restricted Project, Restricted Project
kees updated the diff for D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.

Rebasing to monorepo...

Mon, May 20, 5:02 PM · Restricted Project
arphaman updated the diff for D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.

Remove some outdated commented out code.

Mon, May 20, 4:54 PM · Restricted Project
JDevlieghere added inline comments to D62061: Add AST logging.
Mon, May 20, 4:54 PM · Restricted Project
hintonda added a comment to D61697: [lit] Disable test on darwin when building shared libs..

ping...

Mon, May 20, 4:54 PM · Restricted Project, Restricted Project
jcai19 added a reviewer for D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.: chh.
Mon, May 20, 4:53 PM · Restricted Project, Restricted Project
charukcs added inline comments to rL361166: [SDAG] Vector op legalization for overflow ops.
Mon, May 20, 4:51 PM
phosek added a comment to D62090: [libcxx][libunwind] Support ELF dependent libraries feature on Linux.

Would it be possible to take a look? I believe this is a better alternative to both D54724 and D54726 which doesn't require any changes to the driver or special linker scripts.

Mon, May 20, 4:40 PM · Restricted Project
rnk added a comment to D62063: CMake changes to get Windows self-host with PGO working.

Seems reasonable to me. I'm surprised CMake doesn't have a general facility for escaping paths used in cflags. I suppose users generally don't add paths, just flags.

Mon, May 20, 4:40 PM · Restricted Project
Richard Smith <richard-llvm@metafoo.co.uk> committed rGf1b29723ce91: Give 'fixit-cxx0x.cpp' a more modern name. (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Give 'fixit-cxx0x.cpp' a more modern name.
Mon, May 20, 4:35 PM
rsmith committed rC361208: Give 'fixit-cxx0x.cpp' a more modern name..
Give 'fixit-cxx0x.cpp' a more modern name.
Mon, May 20, 4:34 PM
rsmith committed rL361208: Give 'fixit-cxx0x.cpp' a more modern name..
Give 'fixit-cxx0x.cpp' a more modern name.
Mon, May 20, 4:34 PM
seiya added a comment to D61993: [llvm-objcopy] Add file names to error messages.

Awesome. LGTM. Tell me if you want me or someone else to land it. You can also email Chris Latner to get access yourself.

Mon, May 20, 4:34 PM · Restricted Project
seiya added a comment to D61993: [llvm-objcopy] Add file names to error messages.

LGTM, but I'd like a second pair of eyes on it from someone like @MaskRay, @rupprecht, or @jakehehrlich before this goes in. I assume you'll need somebody to commit it for you?

Mon, May 20, 4:34 PM · Restricted Project
phosek committed rG48140db79732: [builtins] Deduplicate __eqsf2 and __gtsf2 via macro (authored by phosek).
[builtins] Deduplicate __eqsf2 and __gtsf2 via macro
Mon, May 20, 4:32 PM
phosek committed rCRT361207: [builtins] Deduplicate __eqsf2 and __gtsf2 via macro.
[builtins] Deduplicate __eqsf2 and __gtsf2 via macro
Mon, May 20, 4:32 PM
phosek committed rL361207: [builtins] Deduplicate __eqsf2 and __gtsf2 via macro.
[builtins] Deduplicate __eqsf2 and __gtsf2 via macro
Mon, May 20, 4:32 PM
phosek closed D61919: [builtins] Deduplicate __eqsf2 and __gtsf2.
Mon, May 20, 4:32 PM · Restricted Project, Restricted Project
compnerd added a comment to D62155: [CMake] Copy C++ headers before configuring runtimes build.

The only thing that Im worried about is cross-compilation accidentally picking up the libc++ headers that are built here (e.g. building on Linux for Linux with the host libc++ headers and building libc++ as a runtime). The rest looks pretty much a substitution and addition of runtime-libcxx-headers target to the runtimes build which is fine.

Mon, May 20, 4:29 PM · Restricted Project, Restricted Project
rsmith added a comment to D62009: [clang] perform semantic checking in constant context.

Interesting. I think all of the new warnings in the test cases here are undesirable (they duplicate errors produced by the constant evaluator), but the removed warnings all look like improvements.

Mon, May 20, 4:18 PM · Restricted Project
hintonda added a comment to D62157: Remove explicit header-filter in run_clang_tidy.py.

@hintonda Aha so it is :)

Mon, May 20, 4:18 PM · Restricted Project
efriedma added a comment to D62024: [InstCombine] fold shuffles of insert_subvectors.

We use "alignTo(7, 3)":

Mon, May 20, 4:12 PM · Restricted Project
beanz retitled D62155: [CMake] Copy C++ headers before configuring runtimes build from [CMake] Copy C++ headers during config on Darwin to [CMake] Copy C++ headers before configuring runtimes build.
Mon, May 20, 4:12 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • cleanup
Mon, May 20, 4:12 PM · Restricted Project
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • feedback
Mon, May 20, 4:12 PM · Restricted Project
beanz added a reviewer for D62155: [CMake] Copy C++ headers before configuring runtimes build: EricWF.

Looping in @EricWF.

Mon, May 20, 4:12 PM · Restricted Project, Restricted Project