I'm missing some documentation to understand the corner cases. How does this check behave with suppressed warnings for checks which ain't currently checked. (Using -no-... on a code base or suppressing the warnings via the pragmas)
Review comments applied.
Review comments were applied.
I guess no one cares. Oh well, at least the gcc folks respond to reviews/bugs in a <6 month timeframe.
lgtm, if you have some time in the future for further improvements Greg's suggestion would be a good way to make this better.
A few minor coding style fixes.
I'd much rather provide no implementation than one that lies. Broken builds are much safer than problems at runtime.
V2: Always add the s_and. We should add a later pass to remove it when it is not needed.
Fix the estimate of number of registers to spill, adjust it to make sure it won't underestimate the amount of stack used.
The motivation for stack probing here is different to the Windows case, although the mechanism is the same. For Darwin this is a security feature to protect against stack clash based attacks.
This changes SymbolFilePDB::FindTypesByRegex () to take an lldb_private::RegularExpression as the argument and removes the use of the STL regex.