Page MenuHomePhabricator

Today

RKSimon updated the diff for D63326: [X86] Replace any_extend* vector extensions with zero_extend* equivalents.

fix cut+paste typo

Mon, Jun 17, 12:01 PM · Restricted Project
regehr added a comment to D63423: [Diagnostics] Diagnose misused xor as pow.

Just wanted to say that I think I agree with the design choices here!

Mon, Jun 17, 12:01 PM · Restricted Project
bogner added a comment to D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).

How terrible would it be to use APInt as the interface type, but then store it as int64_t?

That seems like a good compromise to me.

Mon, Jun 17, 12:01 PM · Restricted Project
aaronpuchert added inline comments to D62750: Show note for -Wmissing-prototypes for functions with parameters.
Mon, Jun 17, 12:01 PM · Restricted Project
xbolva00 added inline comments to D63423: [Diagnostics] Diagnose misused xor as pow.
Mon, Jun 17, 11:58 AM · Restricted Project
asbirlea committed rG7a0098aa6e36: [MemorySSA] Don't use template when the clone is a simplified instruction. (authored by asbirlea).
[MemorySSA] Don't use template when the clone is a simplified instruction.
Mon, Jun 17, 11:57 AM
asbirlea committed rL363597: [MemorySSA] Don't use template when the clone is a simplified instruction..
[MemorySSA] Don't use template when the clone is a simplified instruction.
Mon, Jun 17, 11:57 AM
asbirlea closed D63355: [MemorySSA] Don't use template when the clone is a simplified instruction..
Mon, Jun 17, 11:57 AM · Restricted Project
arsenm added inline comments to D63452: AMDGPU: Support some GDS atomics.
Mon, Jun 17, 11:55 AM · Restricted Project
arsenm added inline comments to D63452: AMDGPU: Support some GDS atomics.
Mon, Jun 17, 11:55 AM · Restricted Project
rsmith accepted D63376: [clang] Small improvments after Adding APValue to ConstantExpr.

Nice cleanup!

Mon, Jun 17, 11:53 AM · Restricted Project
rnk created D63453: [Support] Move llvm::MemoryBuffer to sys::fs::file_t.
Mon, Jun 17, 11:51 AM · Restricted Project
nhaehnle created D63452: AMDGPU: Support some GDS atomics.
Mon, Jun 17, 11:51 AM · Restricted Project
rupprecht accepted D62838: [Object] add isExecutableObject member function.

LGTM just with the naming nit from James (header_t&->const HeaderType&)

Mon, Jun 17, 11:51 AM · Restricted Project
xbolva00 updated the diff for D63423: [Diagnostics] Diagnose misused xor as pow.

Removed useless else block with return.

Mon, Jun 17, 11:48 AM · Restricted Project
lebedev.ri updated the diff for D63391: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case) (try 2).

Address review notes - just use isOperationLegalOrCustom(), entirety of check-llvm-codegen still passes at least.

Mon, Jun 17, 11:48 AM · Restricted Project
tlwilmar added a reviewer for D63009: [OpenMP] Add target task alloc function with device ID: hbae.
Mon, Jun 17, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
arsenm updated the diff for D63225: AMDGPU: Fold readlane from copy of SGPR or imm.

Add a few more examples of physical registers not folding

Mon, Jun 17, 11:48 AM
alan-baker updated the diff for D63097: [cmake] Don't add Support/Testing library if tests are not included.

Changed to use the top level LLVM build option.

Mon, Jun 17, 11:48 AM · Restricted Project
arsenm added inline comments to D63225: AMDGPU: Fold readlane from copy of SGPR or imm.
Mon, Jun 17, 11:48 AM
rjmccall added a comment to D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants..

Isn't [[no_unique_address]] only significant for empty members? I'm not sure why they need significant support from constant-building, since they expand to no meaningful initializer.

It also permits reuse of tail padding for non-static data members, which is the complexity that this patch is dealing with (in addition to improving and generalizing the support for non-trivial designated initializers).

Mon, Jun 17, 11:44 AM · Restricted Project
rupprecht accepted D63122: [llvm-strip] Error when using stdin twice .
Mon, Jun 17, 11:41 AM · Restricted Project
xbolva00 updated the diff for D63423: [Diagnostics] Diagnose misused xor as pow.

Updated.

Mon, Jun 17, 11:41 AM · Restricted Project
asbirlea updated the diff for D63355: [MemorySSA] Don't use template when the clone is a simplified instruction..

Address comments.

Mon, Jun 17, 11:40 AM · Restricted Project
abrachet added inline comments to D62838: [Object] add isExecutableObject member function.
Mon, Jun 17, 11:40 AM · Restricted Project
paquette committed rG49537bbf74a6: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so (authored by paquette).
[GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so
Mon, Jun 17, 11:39 AM
probinson added inline comments to D58033: Add option for emitting dbg info for call site parameters.
Mon, Jun 17, 11:39 AM · debug-info
lebedev.ri added a comment to D63390: [Codegen] TargetLowering::SimplifySetCC(): omit urem when possible.

:]

Mon, Jun 17, 11:39 AM · Restricted Project
rsmith created D63451: P0840R2: support for [[no_unique_address]] attribute.
Mon, Jun 17, 11:39 AM · Restricted Project
rsmith added a child revision for D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.: D63451: P0840R2: support for [[no_unique_address]] attribute.
Mon, Jun 17, 11:39 AM · Restricted Project
RKSimon added inline comments to D63326: [X86] Replace any_extend* vector extensions with zero_extend* equivalents.
Mon, Jun 17, 11:39 AM · Restricted Project
xbolva00 added inline comments to D63423: [Diagnostics] Diagnose misused xor as pow.
Mon, Jun 17, 11:39 AM · Restricted Project
paquette committed rL363596: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so.
[GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so
Mon, Jun 17, 11:36 AM
paquette closed D63163: [GlobalISel][AArch64] Fold G_SUB into G_ICMP when it's safe to do so.
Mon, Jun 17, 11:36 AM · Restricted Project
bogner added a comment to D63205: Virtualize TargetInstrInfo::getRegClass().

Maybe I'm missing something, but the override implemented in D63204 looks like a subset of the default TII::getRegClass that falls through to TRI::getRegClass, just like the default does. Is this change actually necessary?

Mon, Jun 17, 11:36 AM
craig.topper committed rGf3f968adcd59: [X86] Add TB_NO_REVERSE to some memory folding table entries where the register… (authored by craig.topper).
[X86] Add TB_NO_REVERSE to some memory folding table entries where the register…
Mon, Jun 17, 11:36 AM
ctopper committed rL363595: [X86] Add TB_NO_REVERSE to some memory folding table entries where the register….
[X86] Add TB_NO_REVERSE to some memory folding table entries where the register…
Mon, Jun 17, 11:36 AM
spatel added a comment to D63390: [Codegen] TargetLowering::SimplifySetCC(): omit urem when possible.

Thank you for the reviews.

LGTM. I have no idea if it's worth the trade-off, but we could do this sooner in IR (instcombine) instead of or in addition to SDAG?

Indeed, this fold is missed in middle-end too, but the regression at hand is in back-end test,
so i'm not sure if we should just hand-wave and only fix it in middle-end.
Also, where should the middle-end fix be? Again InstCombine?

Mon, Jun 17, 11:36 AM · Restricted Project
craig.topper added inline comments to D63326: [X86] Replace any_extend* vector extensions with zero_extend* equivalents.
Mon, Jun 17, 11:33 AM · Restricted Project
aditya_nandakumar added a comment to D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).

How terrible would it be to use APInt as the interface type, but then store it as int64_t?

Mon, Jun 17, 11:33 AM · Restricted Project