LGTM, thanks
Active Repositories
Active Repositories
- rZORG LLVM Github Zorg
- 3,386 Commits
- ·
- Restricted Project
- Fri, Aug 14, 11:20 AM
- Git
Recent Activity
Recent Activity
Today
Today
Fri, Aug 14, 4:29 PM · Restricted Project
efriedma accepted D86004: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C <= 128 only.
Fri, Aug 14, 4:28 PM · Restricted Project
vsk added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Fri, Aug 14, 4:16 PM · Restricted Project
smeenai added inline comments to D85992: [lld-macho] Fall back to raw path if we don't find anything under syslibroot.
Fri, Aug 14, 4:13 PM · Restricted Project
xbolva00 requested review of D86004: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C <= 128 only.
Fri, Aug 14, 4:10 PM · Restricted Project
int3 added inline comments to D85992: [lld-macho] Fall back to raw path if we don't find anything under syslibroot.
Fri, Aug 14, 4:09 PM · Restricted Project
reames committed rGa96fc4638b73: Remove deopt and gc transition arguments from gc.statepoint intrinsic (authored by reames).
Remove deopt and gc transition arguments from gc.statepoint intrinsic
Fri, Aug 14, 4:08 PM · Restricted Project
klausler accepted D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..
In D85937#2219318, @Meinersbur wrote:In D85937#2219266, @klausler wrote:But are there other workarounds? Would adding "static" to the original "constexpr" suffice to avoid the bug?
No.
[test][LoopUnroll] Cleanup FullUnroll.ll
Fri, Aug 14, 4:06 PM · Restricted Project
In D86000#2219288, @vsk wrote:It'd be nice to fold the new check into an existing sanitizer group to bring this to a wider audience. Do you foresee adoption issues for existing -fsanitize=integer adopters? Fwiw some recently-added implicit conversion checks were folded in without much/any pushback.
Meinersbur added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..
In D85937#2219266, @klausler wrote:But are there other workarounds? Would adding "static" to the original "constexpr" suffice to avoid the bug?
tejohnson updated the diff for D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation.
address comments
tejohnson added a comment to D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation.
Addressed everyone's comments as well as the clang tidy warnings.
Fri, Aug 14, 3:54 PM · Restricted Project
aeubanks committed rGe6ea8779c2e0: [NewPM][optnone] Mark various passes as required (authored by aeubanks).
[NewPM][optnone] Mark various passes as required
MaskRay committed rG58f5966d5bc1: Fix TargetSubtargetInfo derivatives after D85165 (authored by MaskRay).
Fix TargetSubtargetInfo derivatives after D85165
Thanks for working on this. I think making lldMain "reentrancy safe" is useful.
klausler added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..
In D85937#2219151, @DavidTruby wrote:In D85937#2219052, @Meinersbur wrote:In D85937#2219028, @klausler wrote:You might have to use conditional preprocessing to make this workaround specific to MSVC.
The workaround is valid C++ and works fine with every compiler. So why add a #if maze?
I also believe it will generate exactly the same code. There's no functional difference between the new proposal and the old code as far as the standard is concerned. I agree that preprocessor changes aren't necessary here.
It'd be nice to fold the new check into an existing sanitizer group to bring this to a wider audience. Do you foresee adoption issues for existing -fsanitize=integer adopters? Fwiw some recently-added implicit conversion checks were folded in without much/any pushback.
Fri, Aug 14, 3:42 PM · Restricted Project
MaskRay committed rGb358daddea04: [ELF] Re-initialize InputFile::isInGroup so that elf::link can be called more… (authored by MaskRay).
[ELF] Re-initialize InputFile::isInGroup so that elf::link can be called more…
This adds future implementation complexity.
Fri, Aug 14, 3:34 PM · Restricted Project
Fix clang-(format|tidy)
craig.topper committed rGc7a0b2684f74: [X86][MC][Target] Initial backend support a tune CPU to support -mtune (authored by craig.topper).
[X86][MC][Target] Initial backend support a tune CPU to support -mtune
Fri, Aug 14, 3:32 PM · Restricted Project
klausler added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..
In D85937#2219052, @Meinersbur wrote:In D85937#2219028, @klausler wrote:You might have to use conditional preprocessing to make this workaround specific to MSVC.
The workaround is valid C++ and works fine with every compiler. So why add a #if maze?
davide committed rG0cceb54366b4: [TestPtrRefsObjC] Prefer `command script import`. (authored by davide).
[TestPtrRefsObjC] Prefer `command script import`.
davide committed rG8fcfe2862fd4: [TestPtrRefs] Prefer `command script import`. (authored by davide).
[TestPtrRefs] Prefer `command script import`.
Fri, Aug 14, 3:26 PM · Restricted Project
Fri, Aug 14, 3:23 PM · Restricted Project
Fri, Aug 14, 3:21 PM · Restricted Project