Page MenuHomePhabricator

Today

sdmitriev accepted D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy.

Looks good.

Sun, Oct 13, 8:32 PM
pengfei updated the diff for D68757: [X86] Add strict fp support for instructions fadd/fsub/fmul/fdiv.

Add the missing attributes #0 = { strictfp }

Sun, Oct 13, 8:23 PM · Restricted Project
thakis committed rG282b36c1ce93: convert another test to unix line endings (authored by thakis).
convert another test to unix line endings
Sun, Oct 13, 7:29 PM
thakis committed rG61d26556907c: convert a test to unix line endings (authored by thakis).
convert a test to unix line endings
Sun, Oct 13, 7:19 PM
nico committed rL374752: convert another test to unix line endings.
convert another test to unix line endings
Sun, Oct 13, 7:19 PM
nico committed rL374751: convert a test to unix line endings.
convert a test to unix line endings
Sun, Oct 13, 7:19 PM
nathanchance accepted D68726: [libc] Do not add unittests LLVM_INCLUDE_TESTS is OFF..
Sun, Oct 13, 7:01 PM · Restricted Project
thakis committed rGa05d254b82ca: fix typo in 374747 (authored by thakis).
fix typo in 374747
Sun, Oct 13, 6:51 PM
thakis committed rG1f1703f5c7a2: Prefer 'env not' over 'not env' in tests. (authored by thakis).
Prefer 'env not' over 'not env' in tests.
Sun, Oct 13, 6:42 PM
craig.topper committed rGd0bfedf8e503: [X86] Autogenerate complete checks. NFC (authored by craig.topper).
[X86] Autogenerate complete checks. NFC
Sun, Oct 13, 6:42 PM
nico committed rL374750: fix typo in 374747.
fix typo in 374747
Sun, Oct 13, 6:42 PM
nico committed rL374749: Prefer 'env not' over 'not env' in tests..
Prefer 'env not' over 'not env' in tests.
Sun, Oct 13, 6:42 PM
ctopper committed rL374748: [X86] Autogenerate complete checks. NFC.
[X86] Autogenerate complete checks. NFC
Sun, Oct 13, 6:42 PM
dblaikie added a comment to D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions..

We really do want to pack the four mutually exclusive cases into two bits. I have tried to give more explicit comments inline to explain how you would do this. It really should work fine, recognizing that the "not defaulted" case is not explicitly represented in the textual IR because it uses a zero value in the defaulted/deleted subfield of SPFlags.

Thanks Paul, for suggesting this. Your approach works fine. But as I was working on some lvm-dwarfdump test cases. We seems to miss one corner case --
Consider this test case;
class foo{

foo() = default;
~foo() = default;
 void not_special() {}

};
void not_a_member_of_foo(){}

Now I'm getting DW_AT_defaulted getting emitted with value DW_DEFAULTED_no, for functions "not_special" and "not_a_member_of_foo". This behavior is undesirable since, DW_AT_defaulted attributes is only valid for C++ special member functions{Constructors/Destructors, ...}.

Please correct me if I'm wrong -- Now This attributes to- implicitly defined "0" NotDefaulted bit. which is getting checked{that's fine as long as we have a dedicated bits for distinguishing} and true for every subprogram or function in a CU.
void DwarfUnit::applySubprogramAttributes( ...
...
else if (SP->isNotDefaulted())

addUInt(SPDie, dwarf::DW_AT_defaulted, dwarf::DW_FORM_data1,
        dwarf::DW_DEFAULTED_no);

...

Sun, Oct 13, 6:41 PM · debug-info, Restricted Project, Restricted Project
thakis committed rG9f1bb5b9a8ed: Make symbols.test pass on Windows. (authored by thakis).
Make symbols.test pass on Windows.
Sun, Oct 13, 6:24 PM
nico committed rL374747: Make symbols.test pass on Windows..
Make symbols.test pass on Windows.
Sun, Oct 13, 6:23 PM
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • ...and fix namespace...
Sun, Oct 13, 6:23 PM · Restricted Project, Restricted Project
luismarques added a comment to D68393: [RISCV] Add riscv{32,64} to ALL_CRT_SUPPORTED_ARCH list.

@edward-jones: what LLVM cmake options are you using to test this?

Sun, Oct 13, 6:14 PM · Restricted Project, Restricted Project
luismarques added a comment to D67698: [RISCV] Remove RA from reserved register to use as callee saved register.

In CoreMark-Pro, when the execution model is 1 instr == 1 cycle, with this patch the results I get is that sha-test improves by +1.43% in RV64 (GC, LP64D). For all other sub-benchmarks the performance differences round to 0.00%. There's no change to sha-test in RV32 before and after the patch.

Sun, Oct 13, 6:14 PM · Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Fix Expected<> types
Sun, Oct 13, 6:14 PM · Restricted Project, Restricted Project
thakis committed rG3e54997e777f: Make code-action-request.test and request-reply.test pass on Windows. (authored by thakis).
Make code-action-request.test and request-reply.test pass on Windows.
Sun, Oct 13, 6:05 PM
nico committed rL374746: Make code-action-request.test and request-reply.test pass on Windows..
Make code-action-request.test and request-reply.test pass on Windows.
Sun, Oct 13, 6:04 PM
thakis added inline comments to D62855: [clangd] Implementation of auto type expansion..
Sun, Oct 13, 6:04 PM · Restricted Project, Restricted Project
thakis added inline comments to D65387: [clangd] Add a callback mechanism for handling responses from client..
Sun, Oct 13, 6:04 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Apply review feedback (-auto, -memset, +comments)
Sun, Oct 13, 5:54 PM · Restricted Project, Restricted Project
thakis committed rGc445c0cb0aba: Don't run background-index.test on Windows. (authored by thakis).
Don't run background-index.test on Windows.
Sun, Oct 13, 5:47 PM
nico committed rL374745: Don't run background-index.test on Windows..
Don't run background-index.test on Windows.
Sun, Oct 13, 5:46 PM
fhahn committed rGdf4fd3112862: [NewGVN] Use m_Br to simplify code a bit. (NFC) (authored by fhahn).
[NewGVN] Use m_Br to simplify code a bit. (NFC)
Sun, Oct 13, 4:33 PM
fhahn committed rL374744: [NewGVN] Use m_Br to simplify code a bit. (NFC).
[NewGVN] Use m_Br to simplify code a bit. (NFC)
Sun, Oct 13, 4:33 PM
luismarques added a comment to D68391: [RISCV] Improve sysroot computation if no GCC install detected.

This is indeed an issue that would be nice to fix, I've often been annoyed by clang just defaulting to the root when some misconfiguration occurs. I have to wonder though, this patch only changes the clang RISC-V toolchain driver, but the problem isn't specific to RISC-V. Couldn't this tweak be generalized and made to apply to multiple/all target drivers?

Sun, Oct 13, 4:33 PM · Restricted Project
hiraditya abandoned D66614: Add inline to uflow and underflow.
Sun, Oct 13, 4:27 PM
luismarques updated the diff for D67397: [RISCV] Add MachineInstr immediate verification.

Rebase and address iteration issue (hat tip to both commenters!).

Sun, Oct 13, 4:15 PM · Restricted Project
joerg committed rGe4300c392de2: Add a pass to lower is.constant and objectsize intrinsics (authored by joerg).
Add a pass to lower is.constant and objectsize intrinsics
Sun, Oct 13, 3:59 PM
joerg closed D65280: Add a pass to lower is.constant and objectsize intrinsics.
Sun, Oct 13, 3:59 PM · Restricted Project
joerg committed rL374743: Add a pass to lower is.constant and objectsize intrinsics.
Add a pass to lower is.constant and objectsize intrinsics
Sun, Oct 13, 3:59 PM
joerg committed rG529f4ed401ea: Improve __builtin_constant_p lowering (authored by joerg).
Improve __builtin_constant_p lowering
Sun, Oct 13, 3:39 PM
joerg committed rL374742: Improve __builtin_constant_p lowering.
Improve __builtin_constant_p lowering
Sun, Oct 13, 3:38 PM
joerg closed D67638: Improve __builtin_constant_p lowering.
Sun, Oct 13, 3:38 PM · Restricted Project
atanasyan committed rGf79716774a03: merge-request.sh: Update 9.0 metabug for 9.0.1 (authored by atanasyan).
merge-request.sh: Update 9.0 metabug for 9.0.1
Sun, Oct 13, 3:11 PM
atanasyan committed rL374741: merge-request.sh: Update 9.0 metabug for 9.0.1.
merge-request.sh: Update 9.0 metabug for 9.0.1
Sun, Oct 13, 3:11 PM