Today

toddlipcon added a comment to D34415: Allow passing a regex for headers to exclude from clang-tidy.

Anyone able to review this?

Fri, Jun 23, 5:17 PM
vitalybuka updated the diff for D34311: [InstCombine] Don't replace allocas with smaller globals.

Use isDereferenceableAndAlignedPointer to check global size

Fri, Jun 23, 5:15 PM
matze committed rL306187: fix docu comment.
fix docu comment
Fri, Jun 23, 5:15 PM
vitalybuka added a reviewer for D34585: Make visible isDereferenceableAndAlignedPointer(..., const APInt &Size, ...): inouehrs.
Fri, Jun 23, 5:14 PM
vitalybuka created D34585: Make visible isDereferenceableAndAlignedPointer(..., const APInt &Size, ...).
Fri, Jun 23, 5:13 PM
MatzeB updated the diff for D34584: Introduce new JSON import format.

Add missing file

Fri, Jun 23, 5:12 PM
MatzeB created D34584: Introduce new JSON import format.
Fri, Jun 23, 5:10 PM
rampitec added inline comments to D34579: Fold fneg and fabs like multiplications.
Fri, Jun 23, 5:10 PM
efriedma added inline comments to D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode..
Fri, Jun 23, 5:09 PM
arsenm added inline comments to D34579: Fold fneg and fabs like multiplications.
Fri, Jun 23, 5:07 PM
vitalybuka retitled D34311: [InstCombine] Don't replace allocas with smaller globals from [InstCombine] Don't replace allocas with globals if we can't prove that it's large enough. to [InstCombine] Don't replace allocas with smaller globals.
Fri, Jun 23, 5:05 PM
wmi created D34583: [LSR] Narrow search space by filtering non-optimal formulae with the same ScaledReg and Scale..
Fri, Jun 23, 5:02 PM
eugenis added inline comments to D34451: [RFC] Add KMSAN instrumentation to MSan pass.
Fri, Jun 23, 5:00 PM · Restricted Project
zturner committed rL306186: Fix LLDB build..
Fix LLDB build.
Fri, Jun 23, 4:56 PM
rampitec updated the diff for D34579: Fold fneg and fabs like multiplications.

Fixed (fneg (fabs X)) case.

Fri, Jun 23, 4:54 PM
arsenm created D34582: AMDGPU: Fix emitting encoded calls.
Fri, Jun 23, 4:45 PM
MatzeB created D34581: Fix missing/mismatched html tags.
Fri, Jun 23, 4:45 PM
majnemer added inline comments to D34523: AST: mangle BlockDecls under MS ABI.
Fri, Jun 23, 4:45 PM · Restricted Project
rampitec planned changes to D34579: Fold fneg and fabs like multiplications.

(fmul X, (select (fcmp X > 0.0), -1.0, 1.0)) -> (fneg X)

Is not correct.

It should be:
(fmul X, (select (fcmp X > 0.0), -1.0, 1.0)) -> (fneg (fabs X))

If X was -2.0, (fmul X, (select (fcmp X > 0.0), -1.0, 1.0)) is (fmul -2.0, (select false, -1.0, 1.0) ) =>(fmul -2.0, 1.0 ) => -2.0. Which is different from (fneg -2.0) => 2.0.

Fri, Jun 23, 4:44 PM
compnerd added a comment to D34523: AST: mangle BlockDecls under MS ABI.

Ah, thanks for the explanation @efriedma.

Fri, Jun 23, 4:43 PM · Restricted Project
ahatanak added a comment to D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library.

The motivation for this change was to silence linker errors I saw when compiling and linking programs in which operator new was called to allocate over-aligned types (similar to the code in cxx1z-aligned-allocation.cpp). Linkage failed because clang would emit the calls to the operator with alignment which were not implemented in the library.

Fri, Jun 23, 4:43 PM
matze committed rL306185: Print result URL for `lnt submit`.
Print result URL for `lnt submit`
Fri, Jun 23, 4:43 PM
Diffusion closed D34572: Let lnt submit print the URL of the resulting run by committing rL306185: Print result URL for `lnt submit`.
Fri, Jun 23, 4:43 PM
majnemer added inline comments to D34523: AST: mangle BlockDecls under MS ABI.
Fri, Jun 23, 4:41 PM · Restricted Project
apinski-cavium added a comment to D34579: Fold fneg and fabs like multiplications.

(fmul X, (select (fcmp X > 0.0), -1.0, 1.0)) -> (fneg X)

Is not correct.

Fri, Jun 23, 4:39 PM
eugenis committed rL306184: [asan] Add support for Android debug message..
[asan] Add support for Android debug message.
Fri, Jun 23, 4:39 PM
rampitec updated the diff for D34579: Fold fneg and fabs like multiplications.

Addressed review comments.

Fri, Jun 23, 4:35 PM
vedantk committed rL306183: Add a warning to a group.
Add a warning to a group
Fri, Jun 23, 4:35 PM
mkuper added a comment to D34473: [LV] Changing the interface of ValueMap.

Michael, do you have any issues with moving to this new interface for the ValueMap?

Makes sense to me, modulo a couple of nits.

Fri, Jun 23, 4:32 PM
kastiglione created D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog.
Fri, Jun 23, 4:31 PM
lhames committed rL306182: [ORC] Re-apply r306166 and r306168 with fix for regression test..
[ORC] Re-apply r306166 and r306168 with fix for regression test.
Fri, Jun 23, 4:26 PM
yawanng updated the diff for D33747: [clang-tidy][Part3] Add a new module Android and three new checks..

url format fix in doc.rst

Fri, Jun 23, 4:20 PM · Restricted Project
hfinkel added inline comments to D34579: Fold fneg and fabs like multiplications.
Fri, Jun 23, 4:18 PM
vedantk committed rL306181: [ubsan] Disable the object size check at -O0.
[ubsan] Disable the object size check at -O0
Fri, Jun 23, 4:16 PM
Diffusion closed D34563: [ubsan] Disable the object-size check at -O0 by committing rL306181: [ubsan] Disable the object size check at -O0.
Fri, Jun 23, 4:16 PM
spyffe committed rL306180: Updated the NSArray and NSDictionary formatters to support new storage formats..
Updated the NSArray and NSDictionary formatters to support new storage formats.
Fri, Jun 23, 4:16 PM
compnerd updated the diff for D34523: AST: mangle BlockDecls under MS ABI.

This is a step in the right direction. Although the NSDMI cases and default parameter value cases are not yet handled, they break due to tracking of the global mangling number tracking, not due to the scheme.

Fri, Jun 23, 4:13 PM · Restricted Project
zturner committed rL306179: [llvm-pdbutil] Dump raw bytes of module symbols and debug chunks..
[llvm-pdbutil] Dump raw bytes of module symbols and debug chunks.
Fri, Jun 23, 4:09 PM
rampitec created D34579: Fold fneg and fabs like multiplications.
Fri, Jun 23, 4:06 PM
rafael committed rL306178: Move Value adjustment to applyFixup. NFC..
Move Value adjustment to applyFixup. NFC.
Fri, Jun 23, 4:06 PM