Page MenuHomePhabricator

Recent Activity

Today

stellaraccident updated the diff for D128614: [mlir] Generalize SCF passes to not have to run on FuncOp..

Rebase

Sun, Jun 26, 10:56 AM · Restricted Project, Restricted Project
nlopes committed rGb79575d45662: PHINode::removeIncomingValue: use poison as a placeholder instead of undef when… (authored by nlopes).
PHINode::removeIncomingValue: use poison as a placeholder instead of undef when…
Sun, Jun 26, 10:51 AM · Restricted Project, Restricted Project
craig.topper committed rG44b456e5f0b3: [CodeGenPrepare] Avoid double map lookup. NFCI (authored by craig.topper).
[CodeGenPrepare] Avoid double map lookup. NFCI
Sun, Jun 26, 10:48 AM · Restricted Project, Restricted Project
jpienaar accepted D128594: [MLIR] NFC. Fix doc comment for AliasResult::isNo.
Sun, Jun 26, 10:45 AM · Restricted Project, Restricted Project
Mogball added a comment to D128614: [mlir] Generalize SCF passes to not have to run on FuncOp..

Hah! Beat you

Sun, Jun 26, 10:44 AM · Restricted Project, Restricted Project
jpienaar accepted D128614: [mlir] Generalize SCF passes to not have to run on FuncOp..

Thanks, yes, seems like oversight/nothing func.func specific here.

Sun, Jun 26, 10:43 AM · Restricted Project, Restricted Project
Mogball accepted D128614: [mlir] Generalize SCF passes to not have to run on FuncOp..
Sun, Jun 26, 10:43 AM · Restricted Project, Restricted Project
stellaraccident added a reviewer for D128614: [mlir] Generalize SCF passes to not have to run on FuncOp.: jpienaar.
Sun, Jun 26, 10:40 AM · Restricted Project, Restricted Project
stellaraccident requested review of D128614: [mlir] Generalize SCF passes to not have to run on FuncOp..
Sun, Jun 26, 10:40 AM · Restricted Project, Restricted Project
craig.topper added inline comments to D128612: RISC-V big-endian support implementation.
Sun, Jun 26, 10:37 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
isuckatcs updated the diff for D127973: [Static Analyzer] Eval construction of non POD type arrays..

Addressed comments.

Sun, Jun 26, 10:27 AM · Restricted Project, Restricted Project
cjdb updated the diff for D116280: [clang] adds unary type trait checks as compiler built-ins.

rebases

Sun, Jun 26, 10:25 AM · Restricted Project, Restricted Project
cjdb updated the diff for D116203: [clang] adds unary type transformations as compiler built-ins.

rebases

Sun, Jun 26, 10:25 AM · Restricted Project, Restricted Project
ksyx updated the diff for D103313: [RISCV][Clang] Add support for Zmmul extension.

Make Zmmul extension independent instead of implied by M extension for backward ELF attribute compatibility.

Sun, Jun 26, 10:07 AM · Restricted Project, Restricted Project, Restricted Project
dmgreen added a comment to D125588: [MachineCombiner] Improve MachineCombiner's cost model.

It sounds to me like the MADD is decoded into two uops, mul and add. Then the mul can be immediately executable once the two multipliers are available. Is this correct?

Sun, Jun 26, 10:04 AM · Restricted Project, Restricted Project
philnik requested changes to D128611: [libc++] Implement `std::ranges::merge`.

The implementation looks good, but the tests need some work.

Sun, Jun 26, 9:29 AM · Restricted Project, Restricted Project
hzq updated hzq.
Sun, Jun 26, 9:20 AM
dmgreen added a comment to D124564: [MachineCombiner, AArch64] Add a new pattern A-(B+C) => (A-B)-C to reduce latency.

I think there are more similar useful patterns, but I encountered this pattern only. We can add other patterns when we have tests.

This pattern does look like existing reassociate. The difference is its operations are not commutable, so it can't be handled by existing reassociate logic.

Sun, Jun 26, 8:47 AM · Restricted Project, Restricted Project
ishaangandhi updated the diff for D128402: [clang-tidy] Don't treat invalid branches as identical.
Sun, Jun 26, 8:41 AM · Restricted Project, Restricted Project
liaolucy added a comment to D128613: Add explicit index type for llvm.vector.extract.

The patch : fix crash for rv32 vget intrinsics

Sun, Jun 26, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
liaolucy requested review of D128613: Add explicit index type for llvm.vector.extract.
Sun, Jun 26, 8:31 AM · Restricted Project, Restricted Project, Restricted Project
peixin accepted D128609: [MLIR][OpenMP] Add a constraint to the Threadprivate Op.

Nice.

Sun, Jun 26, 8:25 AM · Restricted Project, Restricted Project
peixin updated the diff for D128597: [flang] Fix one corner case in reshape intrinsic.

Rebase to fix the CI fail.

Sun, Jun 26, 8:23 AM · Restricted Project, Restricted Project
gbenyei requested review of D128612: RISC-V big-endian support implementation.
Sun, Jun 26, 8:20 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
huixie90 requested review of D128611: [libc++] Implement `std::ranges::merge`.
Sun, Jun 26, 8:15 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D128574: [clang-format] Quit analyzing solution space for large state count.
Sun, Jun 26, 7:55 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D128607: [clang-format] NFC Fix uninitialized memory problem.
Sun, Jun 26, 7:53 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

LGTM

Sun, Jun 26, 7:52 AM · Restricted Project, Restricted Project, Restricted Project
philnik updated the diff for D127919: [libc++] Disentangle _If, _Or and _And.

Rebased

Sun, Jun 26, 7:38 AM · Restricted Project, Restricted Project
kaz7 requested review of D128610: [VE] Support load/store vm regsiters.
Sun, Jun 26, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
nlopes committed rG6ef9a2ad01c0: [LICM] Use poison to replace unreachable values instead of undef [NFC] (authored by nlopes).
[LICM] Use poison to replace unreachable values instead of undef [NFC]
Sun, Jun 26, 6:56 AM · Restricted Project, Restricted Project
phyBrackets retitled D128608: [NFC][LLDB] remove the unnecessary condition checks in ASTImporter.cpp from [NFC][AST] remove the unnecessary condition checks in ASTImporter.cpp to [NFC][LLDB] remove the unnecessary condition checks in ASTImporter.cpp.
Sun, Jun 26, 6:56 AM · Restricted Project, Restricted Project
cor3ntin updated the diff for D108469: Improve handling of static assert messages..

Formatting

Sun, Jun 26, 6:54 AM · Restricted Project, Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rG282059b44d00: Update LibASTImporter.rst (authored by Shivam <75530356+phyBrackets@users.noreply.github.com>).
Update LibASTImporter.rst
Sun, Jun 26, 6:53 AM · Restricted Project, Restricted Project
cor3ntin updated the diff for D108469: Improve handling of static assert messages..
  • Rebase
  • Address Aaron's comments.
  • Fix tests
  • Keep dumping wide/utf16/utf32 strings escaped until we can ensure these things cannot appear in static_assert and other compile time constructs
Sun, Jun 26, 6:52 AM · Restricted Project, Restricted Project, Restricted Project
v.g.vassilev committed rGb5eaf500f244: [clang] Add missing Interpreter -> ClangDriverOptions dependency (authored by v.g.vassilev).
[clang] Add missing Interpreter -> ClangDriverOptions dependency
Sun, Jun 26, 6:51 AM · Restricted Project, Restricted Project
v.g.vassilev closed D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency.
Sun, Jun 26, 6:51 AM · Restricted Project, Restricted Project
v.g.vassilev committed rGe881d85371bf: Allow interfaces to operate on in-memory buffers with no source location info. (authored by tapaswenipathak).
Allow interfaces to operate on in-memory buffers with no source location info.
Sun, Jun 26, 6:47 AM · Restricted Project, Restricted Project
v.g.vassilev closed D88780: Allow interfaces to operate on in-memory buffers with no source location info..
Sun, Jun 26, 6:46 AM · Restricted Project, Restricted Project
kiranchandramohan requested review of D128609: [MLIR][OpenMP] Add a constraint to the Threadprivate Op.
Sun, Jun 26, 6:45 AM · Restricted Project, Restricted Project