Added further tests.
And patch lgtm. I don't see any reason why it would interact with the re-licensing really.
I don't know this code very well so I did an attempt to remove the undef removal, and then I ran a bunch of tests to see what
would go wrong. I then ended up in failed assertions when trying to find the undef value in "locations" and "LocNoMap" so
I gurded that with !isUndef() checks.
Spitted the patch into 3 parts, and added further tests.
I did not review this yet, but it is Nice!
The other utils really need to improve in this regard (PR37752)
Fixing cmpxchg implementation of load to return correct value.
- Comment for RETHROW_TO_CALLER
Sorry I take so long replying to this each time. I really need to plan my time better.
None of this makes sense. If OMPT is not enabled, there should be no call to the ompt_initializer. For that reason, no tool should get pointers to OMPT runtime entry points if OMPT is not enabled. Therefore, the OMPT runtime entry points don’t need to check if OMPT is enabled.
Add a testcase that calls the runtime entry points when OMPT is not enabled.