Page MenuHomePhabricator

Today

mstorsjo updated the diff for D57006: [llvm-objcopy] [COFF] Update symbol indices in weak externals.

Applied the suggested changes.

Mon, Jan 21, 3:47 AM
Anastasia added a comment to D54472: Disable invalid isPodLike<> specialization.

The same here! I don't think we should break builds of compiler versions that are still officially supported.

Mon, Jan 21, 3:45 AM
loskutov retitled D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept from Mark lambda-to-function-pointer conversion as noexcept to [clang] Mark lambda-to-function-pointer conversion as noexcept.
Mon, Jan 21, 3:42 AM
sammccall accepted D56917: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers.
Mon, Jan 21, 3:41 AM
sammccall accepted D55256: [clangd] Support clang-tidy configuration in clangd..
Mon, Jan 21, 3:39 AM
mstorsjo added a comment to D56873: [llvm-objcopy] [COFF] Implement --only-section.

By the way, @jakehehrlich may remember exactly what the intended behaviour is in llvm-objcopy for ELF and combining rules. We discussed it a while back, but I can't remember them exactly, but it was something like explicit section keeps trump implicit section strips, and two explicits are an error. You might want to double-check with him.

Mon, Jan 21, 3:39 AM
RKSimon committed rL351741: [CostModel][X86] Add XOP icmp cost tests (PR40376).
[CostModel][X86] Add XOP icmp cost tests (PR40376)
Mon, Jan 21, 3:34 AM
mstorsjo added inline comments to D57006: [llvm-objcopy] [COFF] Update symbol indices in weak externals.
Mon, Jan 21, 3:32 AM
marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
In D56485#1364241, @pcc wrote:

This change would only impact the "diagnostic" (non-production) mode of CFI. In production builds we do not link the runtime library at all. So from a CFI perspective this is fine.

Well, that makes sense. CFI was my biggest problem with this, so I'm tempted to accept the patch (The * doesn't seem to be a valid character for Itanium C++ ABI names, so I think having the test there should only trigger on gcc code).
Please wait 1 or 2 days (to see if there are objections), and then you can consider the patch LGTMed. I'll try to poke it on tuesday/wednesday.

Thank you,

Filipe
Mon, Jan 21, 3:28 AM
hokein added inline comments to D55256: [clangd] Support clang-tidy configuration in clangd..
Mon, Jan 21, 3:26 AM
hokein updated the diff for D55256: [clangd] Support clang-tidy configuration in clangd..

Address review comments.

Mon, Jan 21, 3:24 AM
fedor.sergeev added a comment to D54472: Disable invalid isPodLike<> specialization.

I'm sorry to bring bad news, but this fails for our gcc 4.9.2 build, when building llvm/tools/llvm-xray/xray-converter.cpp.
Failures looks like this:

Mon, Jan 21, 3:20 AM
markus created D57010: Fix sign/zero extension in Dwarf expressions (with pseudo ops).
Mon, Jan 21, 3:17 AM
mgorny added a comment to D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.

LGTM to unbreak the tests on *BSD, but could you please leave a comment?
It would probably be best to take argv[0] into account on *BSD systems as well (possibly only if clang could not be found).

At least if that's the behaviour on all other systems.

Mon, Jan 21, 3:04 AM
teemperor resigned from D55424: [analyzer] Supply all checkers with a shouldRegister function.
Mon, Jan 21, 3:02 AM
sam_parker committed rC351740: [AArch64] Use LL for 64-bit intrinsic arguments.
[AArch64] Use LL for 64-bit intrinsic arguments
Mon, Jan 21, 3:01 AM
sam_parker committed rL351740: [AArch64] Use LL for 64-bit intrinsic arguments.
[AArch64] Use LL for 64-bit intrinsic arguments
Mon, Jan 21, 3:01 AM
Diffusion closed D56852: [AArch64] Use LL for 64-bit arguments.
Mon, Jan 21, 3:01 AM
RKSimon added inline comments to D56987: [Intrinsic] Expand vector SMULFIX to MUL on zero scale.
Mon, Jan 21, 2:52 AM
jhenderson added inline comments to D57006: [llvm-objcopy] [COFF] Update symbol indices in weak externals.
Mon, Jan 21, 2:50 AM
jhenderson added a comment to D56873: [llvm-objcopy] [COFF] Implement --only-section.

-EMPTY essentially implies -NEXT, it requires the next line to either be empty, or there to be EOF here. I haven't intended to use them combined but apparently I did do that in the paragraph above this. I'll change that one for consistency with the rest (that's the only one I have with NEXT-EMPTY at all).

For the record, you can't combine FileCheck suffixes (e.g. CHECK-NEXT-NOT is a NOT using a check prefix of CHECK-NEXT). There are some error checks to catch this, but I don't know how comprehensive they are.

Mon, Jan 21, 2:42 AM
jhenderson added a comment to D56840: [llvm-objcopy] [COFF] Implement --only-keep-debug.

Oops, yeah, I forgot for a moment that GNU output style is (currently) ELF-specific.

Mon, Jan 21, 2:35 AM
jhenderson added a comment to D56683: [llvm-objcopy] [COFF] Add support for removing sections.

@jakehehrlich , @jhenderson, @rupprecht - maybe you have some other thoughts / I'm missing something ?

Just a quick drive-by comment to add to what @rupprecht said. Conceptually to me, the Object should be "final" when all of its details are consistent to represent a valid Object. Section indices are a good example, since there are sections within the Object, but until finalize is called, they don't have valid index values. As a result, a finalize method on the Object probably makes sense to achieve this. Writer meanwhile wants to handle the extra information that is specific to the file format, and not really generic in any meaningful sense (e.g. program headers). I agree that it's going to be hard to have a hard-and-fast rule though.

Mon, Jan 21, 2:34 AM
kadircet added inline comments to D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB..
Mon, Jan 21, 2:29 AM
kadircet updated the diff for D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB..

Address comments

Mon, Jan 21, 2:29 AM
abeserminji updated the diff for D52878: [test-suite] Add flags for stdthreadbug.cpp when building static.

Updated the patch, so that the extra flags are added only when -static option is used.
Used @atanasyan 's solution for CMakeLists.txt from D56836#1362293.
Made equivalent for the Makefile.

Mon, Jan 21, 2:29 AM
critson added a comment to D56496: [AMDGPU] Fix CS scratch setup on pre-GCN3 ASICs.

Ping

Mon, Jan 21, 2:26 AM
filcab added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
In D56485#1364241, @pcc wrote:

This change would only impact the "diagnostic" (non-production) mode of CFI. In production builds we do not link the runtime library at all. So from a CFI perspective this is fine.

Mon, Jan 21, 2:26 AM
jhenderson accepted D56930: [llvm-objcopy] Return Error from Buffer::allocate(), [ELF]Writer::finalize(), and [ELF]Writer::commit().

LGTM.

Mon, Jan 21, 2:23 AM
RKSimon added reviewers for D57000: [llvm-exegesis] Add throughput mode.: RKSimon, andreadb.
Mon, Jan 21, 2:21 AM
mstorsjo created D57009: [llvm-objcopy] [COFF] Fix handling of aux symbols for big objects.
Mon, Jan 21, 2:18 AM
jhenderson added inline comments to D55839: [elfabi] Add support for writing ELF header for binary stubs.
Mon, Jan 21, 2:17 AM
teemperor committed rL351739: [ASTImporter] Add test for importing anonymous namespaces..
[ASTImporter] Add test for importing anonymous namespaces.
Mon, Jan 21, 2:17 AM
teemperor committed rC351739: [ASTImporter] Add test for importing anonymous namespaces..
[ASTImporter] Add test for importing anonymous namespaces.
Mon, Jan 21, 2:16 AM
teemperor closed D51178: [ASTImporter] Add test for importing anonymous namespaces..
Mon, Jan 21, 2:16 AM
tpr added reviewers for D57008: [AMDGPU] With XNACK, cannot clause a load with result coalesced with operand: rampitec, vpykhtin.
Mon, Jan 21, 2:12 AM
kadircet committed rCTE351738: [clang-tidy] Use getStripPluginsAdjuster.
[clang-tidy] Use getStripPluginsAdjuster
Mon, Jan 21, 2:10 AM
kadircet committed rL351738: [clang-tidy] Use getStripPluginsAdjuster.
[clang-tidy] Use getStripPluginsAdjuster
Mon, Jan 21, 2:10 AM
kadircet closed D56902: [clang-tidy] Use getStripPluginsAdjuster.
Mon, Jan 21, 2:10 AM
aadg committed rL351737: [EuroLLVM'19] Fix PC members list..
[EuroLLVM'19] Fix PC members list.
Mon, Jan 21, 2:10 AM