Page MenuHomePhabricator

Today

MaskRay added a comment to D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption.

Actually, the way we tag options recognized by GCC is wrong. We should use a more specific group instead of DriverOption.

Sun, Jul 12, 11:05 PM · Restricted Project
MaskRay added inline comments to D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption.
Sun, Jul 12, 11:02 PM · Restricted Project
Harbormaster failed remote builds in B63909: Diff 277326 for D83655: [AsmPrinter] Split up .gcc_except_table!
Sun, Jul 12, 11:00 PM · Restricted Project
MaskRay added a comment to D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption.

Actually, this patch won't change --help because it just reduced some duplication by extracting the common part (" the integrated assembler") of the help message into the "help" of "OptOutFFlag". Sorry for the confusion.

The real fix here is to restore "integrated_as" as a DriverOption. Without this, when we have -fintegrated-as on a link line, it will be passed to the linker and cause the linker to fail because it is not a valid linker flag.

Sun, Jul 12, 10:59 PM · Restricted Project
Harbormaster failed remote builds in B63908: Diff 277325 for D83276: [PowerPC] Generate CFI directives when probing in prologue!
Sun, Jul 12, 10:54 PM · Restricted Project
Harbormaster failed remote builds in B63907: Diff 277324 for D83654: [PowerPC] Support constrained vector fp/int conversion!
Sun, Jul 12, 10:51 PM · Restricted Project
mkazantsev updated the diff for D81375: [InstCombine] Simplify boolean Phis with const inputs using CFG.

At last!

Sun, Jul 12, 10:39 PM · Restricted Project
bondhugula added inline comments to D83627: [mlir] Support operations with multiple results in slicing.
Sun, Jul 12, 10:35 PM · Restricted Project
ThomasRaoux updated the diff for D83627: [mlir] Support operations with multiple results in slicing.
Sun, Jul 12, 10:25 PM · Restricted Project
ThomasRaoux added inline comments to D83627: [mlir] Support operations with multiple results in slicing.
Sun, Jul 12, 10:24 PM · Restricted Project
ThomasRaoux updated the diff for D83627: [mlir] Support operations with multiple results in slicing.

Address review comments.

Sun, Jul 12, 10:21 PM · Restricted Project
lkail updated the diff for D83276: [PowerPC] Generate CFI directives when probing in prologue.
Sun, Jul 12, 10:20 PM · Restricted Project
MaskRay added inline comments to D83655: [AsmPrinter] Split up .gcc_except_table.
Sun, Jul 12, 10:12 PM · Restricted Project
Herald added a project to D83655: [AsmPrinter] Split up .gcc_except_table: Restricted Project.
Sun, Jul 12, 10:02 PM · Restricted Project
lkail updated the diff for D83276: [PowerPC] Generate CFI directives when probing in prologue.

Address @jsji 's comments.

Sun, Jul 12, 9:59 PM · Restricted Project
qiucf added a child revision for D81669: [PowerPC] Support constrained fp operation for scalar sitofp/uitofp: D83654: [PowerPC] Support constrained vector fp/int conversion.
Sun, Jul 12, 9:56 PM · Restricted Project
qiucf added a parent revision for D83654: [PowerPC] Support constrained vector fp/int conversion: D81669: [PowerPC] Support constrained fp operation for scalar sitofp/uitofp.
Sun, Jul 12, 9:56 PM · Restricted Project
Herald added a project to D83654: [PowerPC] Support constrained vector fp/int conversion: Restricted Project.
Sun, Jul 12, 9:56 PM · Restricted Project
mkazantsev committed rGe808cab82448: [InstCombine] Improve select -> phi canonicalization: consider more blocks (authored by mkazantsev).
[InstCombine] Improve select -> phi canonicalization: consider more blocks
Sun, Jul 12, 9:41 PM
mkazantsev closed D83284: [InstCombine] Improve select -> phi canonicalization: consider more blocks.
Sun, Jul 12, 9:41 PM · Restricted Project
lkail committed rGac8dc526c471: [PowerPC] Enhance tests for D83276. NFC. (authored by lkail).
[PowerPC] Enhance tests for D83276. NFC.
Sun, Jul 12, 9:37 PM
qiucf committed rGb6912c879ed8: [PowerPC] Support constrained conversion in SPE target (authored by qiucf).
[PowerPC] Support constrained conversion in SPE target
Sun, Jul 12, 9:34 PM
qiucf closed D82747: [PowerPC] Support constrained int/fp conversion in SPE targets.
Sun, Jul 12, 9:34 PM · Restricted Project
phosek added inline comments to D82702: [libc++] Use a proper CMake target to represent libc++ headers.
Sun, Jul 12, 9:06 PM · Restricted Project
MaskRay committed rG4d5fd0ee5ebd: [MC][RISCV] Set UseIntegratedAssembler to true (authored by MaskRay).
[MC][RISCV] Set UseIntegratedAssembler to true
Sun, Jul 12, 9:05 PM
jdoerfert committed rG78443666bc18: [OpenMP] Add firstprivate as a default data-sharing attribute to clang (authored by atmnpatel).
[OpenMP] Add firstprivate as a default data-sharing attribute to clang
Sun, Jul 12, 9:04 PM
jdoerfert closed D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang.
Sun, Jul 12, 9:04 PM · Restricted Project, Restricted Project
phosek added a comment to D82702: [libc++] Use a proper CMake target to represent libc++ headers.

One more thing I've noticed is that both of those invocations include __config_site which is added by the cxx-headers interface library, so that library must be used, it's just as if target_include_directories(${CXX_HEADER_TARGET} INTERFACE ${output_dir}) was ignored when building the instrumented version.

Sun, Jul 12, 8:59 PM · Restricted Project
jdenny added a comment to D83650: [FileCheck] Extend -dump-input with substitutions.

I agree that I'd like to have more info inline and this is going in the right direction, but what seems missing is still the check line itself.

Have you looked into localizing it as well?

Sun, Jul 12, 8:41 PM · Restricted Project
mehdi_amini added inline comments to D83653: Create ReductionTree and ReductionNode classes.
Sun, Jul 12, 8:34 PM · Restricted Project
dblaikie committed rGc94332919bd9: Revert "Rename/refactor isIntegerConstantExpression to… (authored by dblaikie).
Revert "Rename/refactor isIntegerConstantExpression to…
Sun, Jul 12, 8:31 PM
dblaikie added a reverting change for rG49e5f603d400: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression: rGc94332919bd9: Revert "Rename/refactor isIntegerConstantExpression to….
Sun, Jul 12, 8:31 PM
aqjune added a comment to D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X.

(renaming variables for readability)

%a = select i1 %s, i1 undef, i1 %t
%b = xor i1 %s, 1
%c = and i1 %a, %b
Sun, Jul 12, 8:23 PM · Restricted Project, Restricted Project
Harbormaster failed remote builds in B63906: Diff 277320 for D83653: Create ReductionTree and ReductionNode classes!
Sun, Jul 12, 8:21 PM · Restricted Project
phosek added a comment to D82702: [libc++] Use a proper CMake target to represent libc++ headers.

I spent some time debugging this, and to be honest, I don't know what's going on. The problem is that in the multilib variant case, the header includes are missing. So normally, the generated Ninja entries would look like this:

build libcxx/src/CMakeFiles/cxx_static.dir/filesystem/operations.cpp.obj: CXX_COMPILER__cxx_static /src/clang-llvm/llvm-project/libcxx/src/filesystem/operations.cpp || cmake_object_order_depends_target_cxx_static
  DEFINES = -DNDEBUG -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
  DEP_FILE = libcxx/src/CMakeFiles/cxx_static.dir/filesystem/operations.cpp.obj.d
  FLAGS = --target=x86_64-unknown-fuchsia -I/usr/local/google/home/phosek/clang-llvm/sdk/pkg/fdio/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -ffunction-sections -fdata-sections -ffile-prefix-map=/src/clang-llvm/llvm-build/fuchsia/runtimes/runtimes-x86_64-unknown-fuchsia-bins=../llvm-build/fuchsia/runtimes/runtimes-x86_64-unknown-fuchsia-bins -ffile-prefix-map=/src/clang-llvm/llvm-project/= -no-canonical-prefixes -O2 -g -DNDEBUG   -DLIBCXX_BUILDING_LIBCXXABI -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wno-user-defined-literals -Wno-covered-switch-default -Wno-ignored-attributes -Wno-error -fvisibility-global-new-delete-hidden -include /src/clang-llvm/llvm-build/fuchsia/runtimes/runtimes-x86_64-unknown-fuchsia-bins/libcxx/__config_site -std=c++14
  INCLUDES = -Ilibcxx/include/c++build -I/src/clang-llvm/llvm-build/fuchsia/include/c++/v1
  OBJECT_DIR = libcxx/src/CMakeFiles/cxx_static.dir
  OBJECT_FILE_DIR = libcxx/src/CMakeFiles/cxx_static.dir/filesystem

but with this patch, we would end up with this:

build libcxx/src/CMakeFiles/cxx_static.dir/filesystem/operations.cpp.obj: CXX_COMPILER__cxx_static /src/clang-llvm/llvm-project/libcxx/src/filesystem/operations.cpp || cmake_object_order_depends_target_cxx_static
  DEFINES = -DNDEBUG -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
  DEP_FILE = libcxx/src/CMakeFiles/cxx_static.dir/filesystem/operations.cpp.obj.d
  FLAGS = --target=x86_64-unknown-fuchsia -I/usr/local/google/home/phosek/clang-llvm/sdk/pkg/fdio/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fno-omit-frame-pointer -fsanitize=address -fsanitize-address-use-after-scope -ffunction-sections -fdata-sections -ffile-prefix-map=/src/clang-llvm/llvm-build/fuchsia/runtimes/runtimes-x86_64-unknown-fuchsia+asan+noexcept-bins=../llvm-build/fuchsia/runtimes/runtimes-x86_64-unknown-fuchsia+asan+noexcept-bins -ffile-prefix-map=/src/clang-llvm/llvm-project/= -no-canonical-prefixes -O2 -g -DNDEBUG   -DLIBCXX_BUILDING_LIBCXXABI -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=address -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wno-user-defined-literals -Wno-covered-switch-default -Wno-ignored-attributes -Wno-error -fno-exceptions -include /src/clang-llvm/llvm-build/fuchsia/runtimes/runtimes-x86_64-unknown-fuchsia+asan+noexcept-bins/libcxx/__config_site -std=c++14
  INCLUDES = -Ilibcxx/include/c++build
  OBJECT_DIR = libcxx/src/CMakeFiles/cxx_static.dir
  OBJECT_FILE_DIR = libcxx/src/CMakeFiles/cxx_static.dir/filesystem

See the INCLUDES variable, in the latter case, -I/src/clang-llvm/llvm-build/fuchsia/include/c++/v1 is missing so compiler fails to find libc++ headers.

I have no idea why that happens. I inserted debugging prints into various places and I haven't seen any obvious issue. The only difference between the two runtime builds is (aside from ASan instrumentation) that in the latter case, compiler-rt isn't being built as part of runtimes, but I still don't see why that would should matter here.

Sun, Jul 12, 8:13 PM · Restricted Project
Harbormaster failed remote builds in B63903: Diff 277316 for D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption!
Sun, Jul 12, 8:13 PM · Restricted Project
mehdi_amini added a comment to D83650: [FileCheck] Extend -dump-input with substitutions.

I agree that I'd like to have more info inline and this is going in the right direction, but what seems missing is still the check line itself.

Sun, Jul 12, 8:13 PM · Restricted Project
Harbormaster failed remote builds in B63904: Diff 277318 for D83653: Create ReductionTree and ReductionNode classes!
Sun, Jul 12, 8:12 PM · Restricted Project
msifontes updated the diff for D83653: Create ReductionTree and ReductionNode classes.

Formatting changes

Sun, Jul 12, 8:03 PM · Restricted Project
void added a comment to D83523: MachineSink: permit sinking into INLINEASM_BR indirect targets.

Here are a few other places to contemplate similar changes:

Sun, Jul 12, 8:03 PM · Restricted Project