Page MenuHomePhabricator

Recent Activity

Today

kiranchandramohan accepted D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.
Fri, Aug 14, 4:29 PM · Restricted Project
efriedma accepted D86004: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C <= 128 only.

LGTM, thanks

Fri, Aug 14, 4:28 PM · Restricted Project
xbolva00 added a reviewer for D86000: Add an unsigned shift base sanitizer: lebedev.ri.
Fri, Aug 14, 4:26 PM · Restricted Project, Restricted Project
vsk added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Fri, Aug 14, 4:21 PM · Restricted Project, Restricted Project
aeubanks requested review of D86005: [NewPM][LoopFullUnroll] Make LoopFullUnrollPass required.
Fri, Aug 14, 4:16 PM · Restricted Project
smeenai added inline comments to D85992: [lld-macho] Fall back to raw path if we don't find anything under syslibroot.
Fri, Aug 14, 4:13 PM · Restricted Project
xbolva00 requested review of D86004: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C <= 128 only.
Fri, Aug 14, 4:10 PM · Restricted Project
int3 added inline comments to D85992: [lld-macho] Fall back to raw path if we don't find anything under syslibroot.
Fri, Aug 14, 4:09 PM · Restricted Project
reames committed rGa96fc4638b73: Remove deopt and gc transition arguments from gc.statepoint intrinsic (authored by reames).
Remove deopt and gc transition arguments from gc.statepoint intrinsic
Fri, Aug 14, 4:08 PM
reames closed D80892: Remove deopt and gc transition arguments from gc.statepoint intrinsic.
Fri, Aug 14, 4:08 PM · Restricted Project
klausler accepted D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

But are there other workarounds? Would adding "static" to the original "constexpr" suffice to avoid the bug?

No.

Fri, Aug 14, 4:06 PM · Restricted Project, Restricted Project
aeubanks committed rG72effd8d5b08: [test][LoopUnroll] Cleanup FullUnroll.ll (authored by aeubanks).
[test][LoopUnroll] Cleanup FullUnroll.ll
Fri, Aug 14, 4:06 PM
aeubanks closed D85578: [test][LoopUnroll] Cleanup FullUnroll.ll.
Fri, Aug 14, 4:06 PM · Restricted Project
jfb added a comment to D86000: Add an unsigned shift base sanitizer.
In D86000#2219288, @vsk wrote:

It'd be nice to fold the new check into an existing sanitizer group to bring this to a wider audience. Do you foresee adoption issues for existing -fsanitize=integer adopters? Fwiw some recently-added implicit conversion checks were folded in without much/any pushback.

Fri, Aug 14, 4:05 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

But are there other workarounds? Would adding "static" to the original "constexpr" suffice to avoid the bug?

Fri, Aug 14, 4:04 PM · Restricted Project, Restricted Project
MaskRay added reviewers for D70378: [LLD][COFF] Cover usage of LLD as a library: grimar, psmith.
Fri, Aug 14, 4:02 PM · lld, Restricted Project
tejohnson updated the diff for D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation.

address comments

Fri, Aug 14, 4:01 PM · Restricted Project, Restricted Project
tejohnson added a comment to D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation.

Addressed everyone's comments as well as the clang tidy warnings.

Fri, Aug 14, 4:01 PM · Restricted Project, Restricted Project
reames abandoned D84964: [WIP] Demo a functional problem from D81647 with a fix and test case.
Fri, Aug 14, 3:54 PM · Restricted Project
plotfi abandoned D11244: New ADT: SortedVector .
Fri, Aug 14, 3:53 PM
plotfi commandeered D11244: New ADT: SortedVector .
Fri, Aug 14, 3:53 PM
aeubanks committed rGe6ea8779c2e0: [NewPM][optnone] Mark various passes as required (authored by aeubanks).
[NewPM][optnone] Mark various passes as required
Fri, Aug 14, 3:52 PM
aeubanks closed D85457: [NewPM][optnone] Mark various passes as required.
Fri, Aug 14, 3:52 PM · Restricted Project, Restricted Project
MaskRay committed rG58f5966d5bc1: Fix TargetSubtargetInfo derivatives after D85165 (authored by MaskRay).
Fix TargetSubtargetInfo derivatives after D85165
Fri, Aug 14, 3:52 PM
asbirlea accepted D85457: [NewPM][optnone] Mark various passes as required.
Fri, Aug 14, 3:47 PM · Restricted Project, Restricted Project
MaskRay added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Thanks for working on this. I think making lldMain "reentrancy safe" is useful.

Fri, Aug 14, 3:43 PM · lld, Restricted Project
klausler added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

You might have to use conditional preprocessing to make this workaround specific to MSVC.

The workaround is valid C++ and works fine with every compiler. So why add a #if maze?

I also believe it will generate exactly the same code. There's no functional difference between the new proposal and the old code as far as the standard is concerned. I agree that preprocessor changes aren't necessary here.

Fri, Aug 14, 3:42 PM · Restricted Project, Restricted Project
vsk added a comment to D86000: Add an unsigned shift base sanitizer.

It'd be nice to fold the new check into an existing sanitizer group to bring this to a wider audience. Do you foresee adoption issues for existing -fsanitize=integer adopters? Fwiw some recently-added implicit conversion checks were folded in without much/any pushback.

Fri, Aug 14, 3:42 PM · Restricted Project, Restricted Project
rampitec requested review of D86003: [AMDGPU] Fix MAI ld/st hazard handling.
Fri, Aug 14, 3:42 PM · Restricted Project
MaskRay committed rGb358daddea04: [ELF] Re-initialize InputFile::isInGroup so that elf::link can be called more… (authored by MaskRay).
[ELF] Re-initialize InputFile::isInGroup so that elf::link can be called more…
Fri, Aug 14, 3:39 PM
eugenis added a comment to D86001: [MSAN] Avoid dangling ActualFnStart when replacing instruction.

This adds future implementation complexity.

Fri, Aug 14, 3:34 PM · Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Fix clang-(format|tidy)

Fri, Aug 14, 3:32 PM · lld, Restricted Project
craig.topper committed rGc7a0b2684f74: [X86][MC][Target] Initial backend support a tune CPU to support -mtune (authored by craig.topper).
[X86][MC][Target] Initial backend support a tune CPU to support -mtune
Fri, Aug 14, 3:32 PM
craig.topper closed D85165: [X86][MC][Target] Initial backend support a tune CPU to support -mtune.
Fri, Aug 14, 3:32 PM · Restricted Project
klausler added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

You might have to use conditional preprocessing to make this workaround specific to MSVC.

The workaround is valid C++ and works fine with every compiler. So why add a #if maze?

Fri, Aug 14, 3:31 PM · Restricted Project, Restricted Project
davide committed rG0cceb54366b4: [TestPtrRefsObjC] Prefer `command script import`. (authored by davide).
[TestPtrRefsObjC] Prefer `command script import`.
Fri, Aug 14, 3:31 PM
davide committed rG8fcfe2862fd4: [TestPtrRefs] Prefer `command script import`. (authored by davide).
[TestPtrRefs] Prefer `command script import`.
Fri, Aug 14, 3:31 PM
rampitec accepted D85997: AMDGPU: Remove slc from flat offset complex patterns.
Fri, Aug 14, 3:26 PM · Restricted Project
guiand added a comment to D86001: [MSAN] Avoid dangling ActualFnStart when replacing instruction.

Caught by http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/41009/steps/ninja%20check%201/logs/FAIL%3A%20MemorySanitizer-POWERPC64%3A%3A%20chained_origin_memcpy.cpp

Fri, Aug 14, 3:23 PM · Restricted Project
guiand requested review of D86001: [MSAN] Avoid dangling ActualFnStart when replacing instruction.
Fri, Aug 14, 3:21 PM · Restricted Project