Page MenuHomePhabricator

Recent Activity
View All

Today

jdoerfert committed rGd13daa4018fa: [Attributor] Finalize the CGUpdater after each SCC (authored by jdoerfert).
[Attributor] Finalize the CGUpdater after each SCC
Tue, Oct 27, 8:09 PM
jdoerfert committed rG50d34958df7b: [Attributor][NFC] Introduce a debug counter for `AA::manifest` (authored by jdoerfert).
[Attributor][NFC] Introduce a debug counter for `AA::manifest`
Tue, Oct 27, 8:09 PM
jdoerfert committed rG1d57b7f5039a: [Attributor][NFC] Print the right value in debug output (authored by jdoerfert).
[Attributor][NFC] Print the right value in debug output
Tue, Oct 27, 8:09 PM
jdoerfert committed rG1c2531c9e164: [Attributor][FIX] Delete all unreachable static functions (authored by jdoerfert).
[Attributor][FIX] Delete all unreachable static functions
Tue, Oct 27, 8:09 PM
jdoerfert committed rGbfe05b1aff1b: [Attributor][FIX] Do not attach range metadata to the wrong Instruction (authored by jdoerfert).
[Attributor][FIX] Do not attach range metadata to the wrong Instruction
Tue, Oct 27, 8:09 PM
jdoerfert committed rG724fcce1092d: [Attributor][NFC] Clang-format (authored by jdoerfert).
[Attributor][NFC] Clang-format
Tue, Oct 27, 8:08 PM
jdoerfert committed rGd504f7b91a93: [Attributor][NFC] Hoist call out of a lambda (authored by jdoerfert).
[Attributor][NFC] Hoist call out of a lambda
Tue, Oct 27, 8:08 PM
jdoerfert committed rG30e5a1f0be02: [Attributor][FIX] Properly check uses in the call not uses of the call (authored by jdoerfert).
[Attributor][FIX] Properly check uses in the call not uses of the call
Tue, Oct 27, 8:08 PM
jdoerfert committed rGcb813ab66a17: [Attributor][NFC] Improve time trace output (authored by jdoerfert).
[Attributor][NFC] Improve time trace output
Tue, Oct 27, 8:08 PM
jhuber6 updated the diff for D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.

Updating after D90172 and D89802 landed. I don't see it failing the tests anymore but I'll look into it more. I should probably make a test for the source location stuff now that it will all be implemenated.

Tue, Oct 27, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D89486: [ADT] Fix for ImmutableMapRef.

Looks like this caused a regression on the sanitizer buildbots. In particular, running check-llvm under ASan produces the following error:

Tue, Oct 27, 8:05 PM · Restricted Project
MaskRay added a comment to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..
In D87011#2357977, @ayermolo wrote:

@ikudrin To clarify this will emit R_X86_64_64 bit relocations for .debug_info on 64 bit platform, correct?

Tue, Oct 27, 7:46 PM · debug-info, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Avoid warning in assert().

Tue, Oct 27, 7:45 PM · Restricted Project, Restricted Project
craig.topper added inline comments to D74729: [FPEnv] Intrinsic for setting rounding mode.
Tue, Oct 27, 7:45 PM · Restricted Project
smhc requested review of D90282: Add IgnoreShortNames config to identifier naming checks.
Tue, Oct 27, 7:31 PM
junparser added inline comments to D89768: [Coroutine] Properly determine whether an alloca should live on the frame.
Tue, Oct 27, 7:27 PM · Restricted Project
junparser added a comment to D89768: [Coroutine] Properly determine whether an alloca should live on the frame.

Thank you for the explanation!

Tue, Oct 27, 7:25 PM · Restricted Project
phosek accepted D90279: [Support] Make Support/SwapByteOrder.h compile on Fuchsia.

LGTM

Tue, Oct 27, 7:21 PM · Restricted Project
mtrofin added a comment to D90281: [FileCheck] Report missing prefixes when more than one is provided..

Please note: this patch isn't ready to land as-is. There are about 1500 tests failing, for the reason covered here. The goal of the patch is to start the discussion as to how we want to proceed - assuming we believe that we shouldn't have tests with prefixes that aren't exercised - so I suppose that's the first question.

Tue, Oct 27, 7:07 PM · Restricted Project
tianshilei1992 updated the diff for D90099: [Clang][OpenMP][WIP] Added the support for target data nowait.

Fixed a rebase issue

Tue, Oct 27, 7:05 PM · Restricted Project
aprantl accepted D88894: [DebugInfo][InstrRef][2/4] Interpret subregister substitutions during LiveDebugValues.
Tue, Oct 27, 7:03 PM · Restricted Project
mtrofin requested review of D90281: [FileCheck] Report missing prefixes when more than one is provided..
Tue, Oct 27, 7:03 PM · Restricted Project
aprantl accepted D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.
Tue, Oct 27, 7:01 PM · debug-info
aprantl added inline comments to D84113: [Debuginfo] (1/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Tue, Oct 27, 7:00 PM · Restricted Project, debug-info
mtrofin added a comment to D89206: [MemCpyOpt] Add test scaffolding for MSSA based MemCpyOpt.

In tests, what is the purpose of the the NO_MSSA and MSSA prefixes?

Tue, Oct 27, 6:58 PM · Restricted Project
clementval requested review of D90280: [flang][openacc] Enforce no modifier on enter data and exit data clauses.
Tue, Oct 27, 6:51 PM · Restricted Project
aprantl added a comment to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.

Also, I'm sorry for being so slow at reviewing these days...

Tue, Oct 27, 6:48 PM · Restricted Project, debug-info
aprantl added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Tue, Oct 27, 6:47 PM · Restricted Project, debug-info
aprantl accepted D89838: [DebugInfo] Fix legacy ZExt emission when FromBits >= 64 (PR47927).
Tue, Oct 27, 6:45 PM · Restricted Project
aprantl added a comment to D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information..

Not an expert either, but at a high level this seems reasonable.

Tue, Oct 27, 6:44 PM · Restricted Project
stella.stamenova added a comment to D88977: Reapply [ADT] function_ref's constructor is unavailable if the argument is not callable..
In D88977#2356948, @sammccall wrote:

Oh wow, I think those are different pointers to the same string, and MSVC+Debug is the only configuration that doesn't fold them together.

So this is just a dumb bug in the test. I just pushed 1a1aad9156407bc891e2738e9877c03bd594e67f which should fix it, please let me know if it doesn't!

Tue, Oct 27, 6:39 PM · Restricted Project
aaronpuchert retitled D90129: Better source location for -Wignored-qualifiers on trailing return types from Source location for -Wignored-qualifiers on lambda trailing return type to Better source location for -Wignored-qualifiers on trailing return types.
Tue, Oct 27, 6:38 PM · Restricted Project
aaronpuchert updated the diff for D90129: Better source location for -Wignored-qualifiers on trailing return types.

Collect location of a trailing return type in the parser, use that for the warning.

Tue, Oct 27, 6:35 PM · Restricted Project
mcgrathr requested review of D90279: [Support] Make Support/SwapByteOrder.h compile on Fuchsia.
Tue, Oct 27, 6:31 PM · Restricted Project
ckennelly updated the diff for D90111: Partially implement C++20's P1020/P1973..

Restrict verify tests to C++20

Tue, Oct 27, 6:31 PM · Restricted Project
ychen added inline comments to D89158: [NewPM] Run all EP callbacks under -O0.
Tue, Oct 27, 6:27 PM · Restricted Project, Restricted Project
vsk added a comment to D90276: [lldb/utils] Add the lldb-env tool.
In D90276#2357978, @JDevlieghere wrote:

Can you explain the added value of the tool a bit more. I can see how it's nice to be able to run export $(lldb-env); path/to/lldb but I wonder how often you'd end up doing that. When I invoke lldb directly, it's mostly to debug a test case, in which case I'd need to run lldb under lldb and set the environment variables myself. It also means we have to configure an additional file which goes against my effort of making the lit.site.cfg file self contained (to be able to run the test suite against a different toolchain).

Tue, Oct 27, 6:26 PM · Restricted Project
jdd committed rG035e12e66449: [MLIR] [ODS] Allowing attr-dict in custom directive (authored by jdd).
[MLIR] [ODS] Allowing attr-dict in custom directive
Tue, Oct 27, 6:26 PM
jdd closed D89772: [MLIR] [ODS] Allowing attr-dict in custom directive.
Tue, Oct 27, 6:25 PM · Restricted Project
mtrofin requested review of D90278: [ThinLTO] Fix .llvmcmd emission.
Tue, Oct 27, 6:21 PM · Restricted Project, Restricted Project