The buildbots broke because of the miscalculation of the buffer array size.
Filter out synthetic integers (such as _LINE_) from the report.
Revised by John's comments.
I'm worried about some extreme template stuff (function templates are not considered for back-referencing but other templates and normal functions are OK) but you are gonna work thru the rest of mangle-ms-* so you'll get there ;)
Add a (presently failing) test for not tripping up on LINE through several layers of macro expansion (as in GoogleTest library). This creates a lot of false positives in the unit tests and needs to be fixed.
Addressed review comments wrt correctly adding DW_AT_rnglists_base and associated test cases. More details inline.
Sorry, the mentioned idea with the copy is not quite clear to me. Could you please explain it a bit more for me?
Oh, this FIXME, i almost forgot about that. Not sure if we should focus on this now because it's kinda premature optimization, especially after @george.karpenkov has fixed a large performance problem that caused VisitNode to be called like ~30 times more often than necessary (D47856), so now our visitors are very fast. But i totally agree that it is aesthetically unpleasant to leave this code in that shape.
@lebedev.ri Hi Roman, thanks very much for your comments. I wrongly assumed we only need the cases which are truly transformed by code patch. I will add the cases you point out.
Thanks. A couple tiny things and then LGTM.