Today

michel.daenzer added a comment to D52221: [AMDGPU] lower-switch in preISel as a workaround for legacy DA.

This broke glamor with the radeonsi driver, hits unreachable():

Fri, Sep 21, 8:50 AM
matze committed rL342742: AArch64FastISel: Abort if we failed to select operand of intrinsic.
AArch64FastISel: Abort if we failed to select operand of intrinsic
Fri, Sep 21, 8:49 AM
Diffusion closed D52335: AArch64FastISel: Abort intrinsic selection if the left operand didn't select.
Fri, Sep 21, 8:49 AM
cryptoad accepted D52361: [XRay][compiler-rt] Update use of internal_mmap.
Fri, Sep 21, 8:47 AM
hfinkel added inline comments to D49281: [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes..
Fri, Sep 21, 8:44 AM
sbc100 added a comment to rL342707: [WebAssembly] Revert r342701, "Add WebAssembly to LLVM_ALL_TARGTS.".

Do you have a link the broken builder? I'm happy to take a look at fixing this.

Fri, Sep 21, 8:43 AM
dberris added inline comments to D52361: [XRay][compiler-rt] Update use of internal_mmap.
Fri, Sep 21, 8:35 AM
dberris updated the diff for D52361: [XRay][compiler-rt] Update use of internal_mmap.

Remove another check for MAP_FAILED.

Fri, Sep 21, 8:35 AM
sammccall requested changes to D52047: [clangd] Add building benchmark and memory consumption tracking.

This change does several things, and I think most of them need further thought. Can we discuss Monday?

Fri, Sep 21, 8:34 AM · Restricted Project
cryptoad created D52363: [sanitizer] Move __sanitizer_set_death_callback to a more appropriate file.
Fri, Sep 21, 8:34 AM
dexonsmith added inline comments to D52322: Pass code-model through Module IR to LTO which will use is.
Fri, Sep 21, 8:34 AM
tejohnson added a comment to D52323: Add necessary support for storing code-model to module IR..

Note that if you add a line like:

Fri, Sep 21, 8:29 AM
sammccall added a comment to D52300: [clangd] Implement VByte PostingList compression.

I addressed the easiest issues. I'll try to implement separate storage structure for Heads and Payloads which would potentially make the implementation cleaner and easier to understand (and also more maintainable since that would be way easier to go for SIMD instructions speedups and other encoding schemes if we do that).

That doesn't sound more maintainable, that sounds like a performance hack that will hurt the layering.
Which is ok :-) but please don't do that until you measure a nontrivial performance improvement from it.

Fri, Sep 21, 8:28 AM · Restricted Project
cryptoad added inline comments to D52361: [XRay][compiler-rt] Update use of internal_mmap.
Fri, Sep 21, 8:28 AM
anna created D52362: [CloneFunction] Simplify previously unsimplifiable instructions.
Fri, Sep 21, 8:24 AM
tejohnson added inline comments to D52322: Pass code-model through Module IR to LTO which will use is.
Fri, Sep 21, 8:23 AM
dberris updated the diff for D52361: [XRay][compiler-rt] Update use of internal_mmap.

Update error reporting in one path.

Fri, Sep 21, 8:23 AM
dberris created D52361: [XRay][compiler-rt] Update use of internal_mmap.
Fri, Sep 21, 8:21 AM
kubamracek accepted D52350: When running the ios/iossim prepare script show the script output when it returns with a non-zero exit code..
Fri, Sep 21, 8:16 AM
ioeric added inline comments to D52047: [clangd] Add building benchmark and memory consumption tracking.
Fri, Sep 21, 8:12 AM · Restricted Project
ncw added a comment to D43675: [WebAssembly] Rename imported/exported memory symbol to __linear_memory.

Renaming them all will take a bit more work (for everyone) - I'm not sure it's especially urgent. Personally I'm happy as long as they all have underscores, and aren't wildly inconsistent.

Fri, Sep 21, 8:09 AM
hermord added a comment to D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).

@RKSimon should I make any other changes to this?

Fri, Sep 21, 8:09 AM
ABataev committed rOMP342737: [OPENMP][NVPTX] Add support for lastprivates/reductions handling in SPMD….
[OPENMP][NVPTX] Add support for lastprivates/reductions handling in SPMD…
Fri, Sep 21, 8:03 AM
lebedev.ri added a comment to D52324: [ValueTracking] Allow select patterns to work on vectors in more places.

You can always write an unit-test, too.

Fri, Sep 21, 8:03 AM
aaron.ballman requested changes to D52339: Support enums with a fixed underlying type in all language modes.

Whoops, that acceptance was accidental. Pretending I want changes just to make it clear in Phab. :-)

Fri, Sep 21, 7:59 AM
aaron.ballman accepted D52339: Support enums with a fixed underlying type in all language modes.

I really like this idea in general, thank you for proposing this patch!

Fri, Sep 21, 7:58 AM
ABataev committed rC342741: [OPENMP] Disable emission of the class with vptr if they are not used in.
[OPENMP] Disable emission of the class with vptr if they are not used in
Fri, Sep 21, 7:57 AM
ABataev committed rL342741: [OPENMP] Disable emission of the class with vptr if they are not used in.
[OPENMP] Disable emission of the class with vptr if they are not used in
Fri, Sep 21, 7:57 AM
spatel committed rL342740: [InstCombine] add tests for extractelement; NFC.
[InstCombine] add tests for extractelement; NFC
Fri, Sep 21, 7:45 AM
SjoerdMeijer updated the diff for D52289: [ARM] Do not fuse VADD and VMUL on the Cortex-M4 and Cortex-M33.

Thanks for the reviews.
Now take code size into account, and removed outdated comment.

Fri, Sep 21, 7:45 AM
cameron.mcinally added a comment to D50913: [FPEnv] Don't need copysign/fabs/fneg constrained intrinsics.

It looks like an explicit FNEG operation isn't going to fly. I propose we drop that pursuit and continue forward with a constrained FNEG intrinsic.

Fri, Sep 21, 7:43 AM
RKSimon added a comment to D52318: [x86] avoid 256-bit andnp that requires insert/extract with AVX1 (PR37449).

Unfortunately, I also found this regression:

define <8 x i32> @bar(<8 x i32> %A, <8 x i32> %B, <8 x i32> %Mask) {
  %1 = and <8 x i32> %A, %Mask
  %2 = xor <8 x i32> %1, %Mask
  %3 = add <8 x i32> %2, %B
  ret <8 x i32> %3
}
Fri, Sep 21, 7:43 AM
kbobyrev added inline comments to D52300: [clangd] Implement VByte PostingList compression.
Fri, Sep 21, 7:39 AM · Restricted Project
kbobyrev closed D52084: [clangd] Improve PostingList iterator string representation.

I think this one is addressed in the VByte patch, so I'm closing this revision in order to prevent conflicts between these two.

Fri, Sep 21, 7:39 AM · Restricted Project
kbobyrev updated the diff for D52357: [clangd] Force Dex to respect symbol collector flags.
Fri, Sep 21, 7:38 AM · Restricted Project
andreadb added a comment to D52318: [x86] avoid 256-bit andnp that requires insert/extract with AVX1 (PR37449).

Hi Sanjay,

Fri, Sep 21, 7:37 AM
kbobyrev updated the diff for D52047: [clangd] Add building benchmark and memory consumption tracking.
  • Be more explicit about the nature of "benchmarks" with memory tracking logic via State::SetLabel(...).
  • Force single iteration for "benchmarks" with memory usage tracking
  • Add another "benchmark" with Dex memory overhead over plain SymbolSlab
Fri, Sep 21, 7:37 AM · Restricted Project
ioeric accepted D52357: [clangd] Force Dex to respect symbol collector flags.
Fri, Sep 21, 7:34 AM · Restricted Project
jfb added a comment to D52332: [ADT] restrict bit_cast to trivially-constructible To.

Re-landed as r342739.

Fri, Sep 21, 7:33 AM
jfb committed rL342739: [ADT] restrict bit_cast to trivially-constructible To.
[ADT] restrict bit_cast to trivially-constructible To
Fri, Sep 21, 7:32 AM