Page MenuHomePhabricator

Recent Activity

Today

ldionne added a comment to D117332: [libc++] Make sure basic_string::reserve never shrinks in all standard modes.

Everything here makes sense except the decision to make s.reserve() nonequivalent to s.shrink_to_fit(). I don't see any ABI issue with that, so that part of the patch is orthogonal to the rest — and it seems to be altering behavior that is both useful and cppreference-documented. I suggest doing everything else you're doing, but not that specific one-line diff, because I don't see its upside.

Thu, Jan 20, 3:57 PM · Restricted Project
JonChesterfield added inline comments to D117806: [OpenMP] Change default visibility to protected for device declarations.
Thu, Jan 20, 3:56 PM · Restricted Project
cfang requested review of D117845: [AMDGPU][NFC] Update to AMDGPUUsage for default Code Object Version.
Thu, Jan 20, 3:56 PM · Restricted Project
rampitec requested review of D117844: [AMDGPU] Prevent aliasing of SrcC and Dst in MAI.
Thu, Jan 20, 3:54 PM · Restricted Project
aartbik accepted D117260: Upstream MLIR PyTACO implementation..

Well done Bixia!

Thu, Jan 20, 3:54 PM · Restricted Project
majnemer added a comment to D117569: Constexpr not supported with __declspec(dllimport)..

Your example is different from mine as it nests the constexpr variable inside the function rather than having it at translation-unit scope.

Thu, Jan 20, 3:54 PM · Restricted Project
gkistanova committed rZORG548e2995baa3: Added thinlto-x86-64-bot2 worker; fixed emain notifier for clang-with-thin-lto… (authored by gkistanova).
Added thinlto-x86-64-bot2 worker; fixed emain notifier for clang-with-thin-lto…
Thu, Jan 20, 3:52 PM
airlied committed rGe1b7bd911d9e: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images (authored by airlied).
[OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images
Thu, Jan 20, 3:51 PM
airlied closed D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images.
Thu, Jan 20, 3:51 PM · Restricted Project
chfast updated the diff for D117680: [InstCombine] Simplify bswap -> shift.

Trigger rebuild.

Thu, Jan 20, 3:47 PM · Restricted Project
mehdi_amini accepted D117260: Upstream MLIR PyTACO implementation..
Thu, Jan 20, 3:43 PM · Restricted Project
klausler requested review of D117843: [flang] Extension: skip over NAMELIST groups.
Thu, Jan 20, 3:40 PM · Restricted Project
klausler committed rG9ddd07922f65: [flang] Handle FLUSH(unknown unit) (authored by klausler).
[flang] Handle FLUSH(unknown unit)
Thu, Jan 20, 3:38 PM
klausler closed D117819: [flang] Handle FLUSH(unknown unit).
Thu, Jan 20, 3:38 PM · Restricted Project, Restricted Project
bixia requested review of D117842: [mlir][sparse] Add createMLIRSparseTensor to the supporting C library..
Thu, Jan 20, 3:38 PM · Restricted Project
tyb0807 added inline comments to D117753: [AArch64] Support for memset tagged intrinsic.
Thu, Jan 20, 3:35 PM · Restricted Project, Restricted Project
tyb0807 added inline comments to D117764: [AArch64][SelectionDAG] CodeGen for Armv8.8/9.3 MOPS.
Thu, Jan 20, 3:35 PM · Restricted Project
klausler committed rG5501c16edf0f: [flang] Fix OPEN/WRITE(SIGN='SUPPRESS') (authored by klausler).
[flang] Fix OPEN/WRITE(SIGN='SUPPRESS')
Thu, Jan 20, 3:35 PM
klausler closed D117816: [flang] Fix OPEN/WRITE(SIGN='SUPPRESS').
Thu, Jan 20, 3:34 PM · Restricted Project, Restricted Project
mehdi_amini accepted D117839: [mlir] Move the Buffer related source files out of Transforms/.

It's great that we have now the bufferization dialect to host these, right? :)

Thu, Jan 20, 3:33 PM · Restricted Project
sivachandra committed rGd92e5412ea57: [libc] Use __builtin_clz to find leading 1 in hypot (authored by cratonica).
[libc] Use __builtin_clz to find leading 1 in hypot
Thu, Jan 20, 3:33 PM
sivachandra closed D117684: [libc] Use __builtin_clz to find leading 1 in hypot.
Thu, Jan 20, 3:33 PM · Restricted Project
leonardchan added a comment to D117537: [cmake] Duplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Hi, I suspect that this patch (or D117815) led to the build failure we're seeing on our builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8824480583333895809):

Thu, Jan 20, 3:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
mehdi_amini accepted D117841: [mlir:Transforms] Move NormalizeMemRefs to MemRef/Transforms/.

Makes sense, thanks!

Thu, Jan 20, 3:31 PM · Restricted Project
lamb-j added a comment to D117801: [AMDGPU] Move const qualifier placement in AsmParser.

If I'm understanding correctly, moving const to the left of "MCSymbol *"' declares the object as const instead of the pointer. In this case, we get a compilation error on the following line:

Thu, Jan 20, 3:28 PM · Restricted Project
jloser added inline comments to D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base.
Thu, Jan 20, 3:24 PM · Restricted Project
dschuff added inline comments to D117747: llvm-readobj: support globals in initializer expressions.
Thu, Jan 20, 3:24 PM · Restricted Project
sbc100 committed rGac2f3df8396a: [lld][WebAssembly] Remove redundant config setting (authored by sbc100).
[lld][WebAssembly] Remove redundant config setting
Thu, Jan 20, 3:22 PM
sbc100 closed D117737: [lld][WebAssembly] Remove redundant config setting.
Thu, Jan 20, 3:22 PM · Restricted Project
chfast committed rG8457b61699e8: [test] Add tests for bswap combining. NFC (authored by chfast).
[test] Add tests for bswap combining. NFC
Thu, Jan 20, 3:21 PM
jloser updated the diff for D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base.

enable_view<void> test

Thu, Jan 20, 3:20 PM · Restricted Project
jloser updated the diff for D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base.

Remove const and const ref tests for enable_view. The standard expects cv-unqual types.

Thu, Jan 20, 3:19 PM · Restricted Project
rriddle added a reviewer for D117841: [mlir:Transforms] Move NormalizeMemRefs to MemRef/Transforms/: mehdi_amini.
Thu, Jan 20, 3:17 PM · Restricted Project
kaz7 accepted D117683: [VE][NFC] Factor out helper functions.

LGTM.

Thu, Jan 20, 3:17 PM · Restricted Project, Restricted Project
rriddle requested review of D117841: [mlir:Transforms] Move NormalizeMemRefs to MemRef/Transforms/.
Thu, Jan 20, 3:16 PM · Restricted Project
rriddle updated the diff for D117839: [mlir] Move the Buffer related source files out of Transforms/.
Thu, Jan 20, 3:16 PM · Restricted Project
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..

I have a question regarding how this work with respect to the dllimport semantics known by the linker.
IIUC, we will now allow a program like:

extern int __declspec(dllimport) dll_import_int;
constexpr int& dll_import_constexpr_ref = dll_import_int;
int& get() {
    return dll_import_constexpr_ref;
}

Here, get will load dll_import_constexpr_ref. However, what will dll_import_constexpr_ref hold? It ought to hold the contents of __imp_?dll_import_int@@3HA. However, we can't dereference __imp_?dll_import_int@@3HA to get to its contents.

@majnemer Thanks for the review.

This test case doesn't link with MSVC. It will generate this error:
Microsoft (R) Incremental Linker Version 14.29.30133.0
Copyright (C) Microsoft Corporation. All rights reserved.

/out:test1.exe
test1.obj
test1.obj : error LNK2001: unresolved external symbol "int dll_import_int" (?dll_import_int@@3HA)
test1.exe : fatal error LNK1120: 1 unresolved externals

The symbols generated with MSVC are:
07 00000000 UNDEF notype External | ?dll_import_int@@3HA (int dll_import_int)
015 00000000 SECT6 notype Static | ?dll_import_constexpr_ref@@3AEAHEA (int & dll_import_constexpr_ref)

Without this patch this test case errors. With this patch clang will generate these symbols:

010 00000000 UNDEF notype External | imp_?dll_import_int@@3HA (declspec(dllimport) int dll_import_int)
012 00000000 SECT5 notype External | ?dll_import_constexpr_ref@@3AEAHEA (int & dll_import_constexpr_ref)
013 00000000 UNDEF notype External | ?dll_import_int@@3HA (int dll_import_int)

and will error at link time with this error:
test1-f1f63b.o : error LNK2019: unresolved external symbol "declspec(dllimport) int dll_import_int" (imp_?dll_import_int@@3HA) referenced in function "int & __cdecl get(void)" (?get@@YAAEAHXZ)
test1-f1f63b.o : error LNK2001: unresolved external symbol "int dll_import_int" (?dll_import_int@@3HA)
a.exe : fatal error LNK1120: 2 unresolved externals

I think that's the behavior expected, right?

My interpretation is that MSVC has a bug: it is forming a reference to ?dll_import_int@@3HA and not __imp_?dll_import_int@@3HA. Could you run a more complete experiment where you have a dll which exports the symbol and you try to import it?

Thu, Jan 20, 3:13 PM · Restricted Project
dschuff accepted D117737: [lld][WebAssembly] Remove redundant config setting.
Thu, Jan 20, 3:12 PM · Restricted Project
bnbarham added a comment to D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems.

Also have bug up at https://github.com/llvm/llvm-project/issues/53306.

Thu, Jan 20, 3:10 PM · Restricted Project, Restricted Project
bnbarham added a comment to D113832: reland: [VFS] Use original path when falling back to external FS.

@keith This patch causes some issues when nesting/chaining RedirectingFileSystems. I have a few tests in https://reviews.llvm.org/D117730 for more details.

Thu, Jan 20, 3:10 PM · Restricted Project, Restricted Project