Today

malaperle added a comment to D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation.

I hadn't marked it as done because without symbols in main files I found it quite lacking.

Ah, I see, thank you for spotting it! I was under the impression that it's feature-complete. Should I mark it "Partial" until this is fixed then?

Sat, Aug 18, 10:17 AM · Restricted Project
elsteveogrande added a comment to D42043: c-index: CXString: fix MSAN read-past-end bug.

hi @vsk + @arphaman , it's been a while -- I brought this old diff up to date, wondering if you could take a look again. Thanks!

Sat, Aug 18, 9:53 AM
JDevlieghere accepted D50639: Change how finalizeBundle selects debug location for the BUNDLE instruction.

This LGTM!

Sat, Aug 18, 9:19 AM
RKSimon committed rL340123: [X86] Merge shift/rotate schedule class instregexs.
[X86] Merge shift/rotate schedule class instregexs
Sat, Aug 18, 8:59 AM
xbolva00 added a reviewer for D50039: [LibCalls] Added nonnull atribute to libc function args: rsmith.
Sat, Aug 18, 8:56 AM
xbolva00 added inline comments to D50714: [InstCombine] Fold Select with binary op - FP opcodes.
Sat, Aug 18, 8:55 AM
JonasToth added inline comments to D50862: [clang-tidy] Abseil: faster strsplit delimiter check.
Sat, Aug 18, 8:36 AM · Restricted Project
HsiangKai committed rL340122: [DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI..
[DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI.
Sat, Aug 18, 7:57 AM
HsiangKai closed D50622: [DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI..
Sat, Aug 18, 7:56 AM
ABataev updated subscribers of D50939: [WIP][OpenMP] Propagate 'declare target' information to device.

D38798 does not work correctly and there is no stable Sema-based solution to do this absolutely correctly. We need to adapt the codegen so that it emits metadata for the implicit declare target functions.

Sat, Aug 18, 7:50 AM
Hahnfeld added a comment to D50939: [WIP][OpenMP] Propagate 'declare target' information to device.

This doesn't work the way I hoped :-(

Sat, Aug 18, 7:25 AM
Hahnfeld planned changes to D50938: [WIP][OpenMP] Move reading of OpenMPHostIR to ASTContext.

I'm pretty sure we don't want to do it like this. ASTContext was just the first data structure I found to be available during both Sema and CodeGen.

Sat, Aug 18, 7:13 AM
Hahnfeld added a dependent revision for D50938: [WIP][OpenMP] Move reading of OpenMPHostIR to ASTContext: D50939: [WIP][OpenMP] Propagate 'declare target' information to device.
Sat, Aug 18, 7:11 AM
Hahnfeld added a dependency for D50939: [WIP][OpenMP] Propagate 'declare target' information to device: D50938: [WIP][OpenMP] Move reading of OpenMPHostIR to ASTContext.
Sat, Aug 18, 7:11 AM
Hahnfeld created D50939: [WIP][OpenMP] Propagate 'declare target' information to device.
Sat, Aug 18, 7:11 AM
Hahnfeld created D50938: [WIP][OpenMP] Move reading of OpenMPHostIR to ASTContext.
Sat, Aug 18, 7:11 AM
RKSimon added a comment to D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..

Thanks @craig.topper !

Sat, Aug 18, 5:48 AM
saar.raz updated the diff for D41217: [Concepts] Concept Specialization Expressions.
  • Address CR comments - add FoundDecl tracking, instantiationdependent calculation, display non-constant expression diagnostic notes
Sat, Aug 18, 5:39 AM
kbobyrev updated the summary of D50894: Pull google/benchmark library to the LLVM tree.
Sat, Aug 18, 4:45 AM
JonasToth added a comment to D50883: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer.

I see, thank you :)

Sat, Aug 18, 4:29 AM
saar.raz added inline comments to D41284: [Concepts] Associated constraints infrastructure..
Sat, Aug 18, 2:30 AM
saar.raz added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Sat, Aug 18, 1:31 AM
saar.raz added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Sat, Aug 18, 1:18 AM
kbobyrev added a comment to D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation.

I hadn't marked it as done because without symbols in main files I found it quite lacking.

Sat, Aug 18, 1:09 AM · Restricted Project

Yesterday

ctopper committed rL340121: [X86] Add a signed test case for PR38622. Use nounwind to reduce the output on….
[X86] Add a signed test case for PR38622. Use nounwind to reduce the output on…
Fri, Aug 17, 11:01 PM
ctopper committed rL340120: [DAGCombiner] Allow divide by constant optimization on opaque constants..
[DAGCombiner] Allow divide by constant optimization on opaque constants.
Fri, Aug 17, 10:53 PM
Diffusion closed D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..
Fri, Aug 17, 10:53 PM
elsteveogrande updated the diff for D42043: c-index: CXString: fix MSAN read-past-end bug.

Rebase + fix conflicts for very old diff. Works again.

Fri, Aug 17, 10:35 PM
xbolva00 added inline comments to D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..
Fri, Aug 17, 10:29 PM
chandlerc accepted D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..

This time actually marking it as LGTM.

Fri, Aug 17, 10:05 PM
chandlerc added a comment to D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..

Nice! I like it when the fix is simple.

Fri, Aug 17, 10:01 PM
craig.topper created D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..
Fri, Aug 17, 9:49 PM
bruno committed rL340119: Revert "Add a basic integration test for C++ smart pointers".
Revert "Add a basic integration test for C++ smart pointers"
Fri, Aug 17, 9:17 PM
zturner committed rL340118: Add the extended XMM registers mappings for AVX-512..
Add the extended XMM registers mappings for AVX-512.
Fri, Aug 17, 8:55 PM
bruno committed rL340117: Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker".
Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"
Fri, Aug 17, 8:23 PM
bruno committed rC340117: Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker".
Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"
Fri, Aug 17, 8:22 PM
lhames committed rL340116: [ORC] Fix some parameter names. NFC..
[ORC] Fix some parameter names. NFC.
Fri, Aug 17, 7:48 PM
rsmith added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Fri, Aug 17, 7:40 PM
lhames committed rL340115: [ORC] Rename 'finalize' to 'emit' to avoid potential confusion..
[ORC] Rename 'finalize' to 'emit' to avoid potential confusion.
Fri, Aug 17, 7:07 PM
rsmith added a comment to D50875: Move lib/Demangle under lib/Support. No functionality change intended..

I'm putting this on hold for now.

Fri, Aug 17, 7:02 PM