Page MenuHomePhabricator

Recent Activity

Today

keith committed rG50f2e4992456: [clang][cmake] Fixed typo in hmaptool CMakeLists.txt (authored by danielh2942).
[clang][cmake] Fixed typo in hmaptool CMakeLists.txt
Sat, May 28, 10:15 AM · Restricted Project, Restricted Project
keith closed D126598: Fixed typo in hmaptool CMakeLists.txt.
Sat, May 28, 10:15 AM · Restricted Project, Restricted Project
klausler committed rG0c190575ebfc: [flang] Make generic resolution conform to 15.5.5.2 w/r/t host association (authored by klausler).
[flang] Make generic resolution conform to 15.5.5.2 w/r/t host association
Sat, May 28, 10:06 AM · Restricted Project, Restricted Project
klausler closed D126587: [flang] Make generic resolution conform to 15.5.5.2 w/r/t host association.
Sat, May 28, 10:06 AM · Restricted Project, Restricted Project
JohnTitor added a reviewer for D126599: [docs][clang] Fix a broken link on the APINotes doc: compnerd.
Sat, May 28, 10:01 AM · Restricted Project, Restricted Project
JohnTitor updated the summary of D126599: [docs][clang] Fix a broken link on the APINotes doc.
Sat, May 28, 10:01 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126599: [docs][clang] Fix a broken link on the APINotes doc.
Sat, May 28, 10:00 AM · Restricted Project, Restricted Project
Mordante updated the diff for D121530: [libc++][format] Implement format-string..

Fixes due to upstream changes.

Sat, May 28, 9:56 AM · Restricted Project, Restricted Project
bcl5980 added a comment to D126591: [InstCombine] Optimise shift+and+boolean conversion pattern to simple comparison.

I'm also worry if we should canonicalize shift+and to icmp+select

I'm not sure what impact this will have in IR, but you could try to write transforms like this in instcombine and see if that exposes other problems:
https://alive2.llvm.org/ce/z/jA_tNb

Sat, May 28, 9:56 AM · Restricted Project, Restricted Project
keith accepted D126598: Fixed typo in hmaptool CMakeLists.txt.
Sat, May 28, 9:52 AM · Restricted Project, Restricted Project
klausler committed rG3142c761da97: [nfc][flang] Fix spelling errors and usage in an error message (authored by klausler).
[nfc][flang] Fix spelling errors and usage in an error message
Sat, May 28, 9:33 AM · Restricted Project, Restricted Project
klausler closed D126490: [nfc][flang] Fix spelling errors and usage in an error message.
Sat, May 28, 9:33 AM · Restricted Project, Restricted Project
danielh2942 retitled D126598: Fixed typo in hmaptool CMakeLists.txt from # Enter a commit message. # # Changes: # # clang/utils/hmaptool/CMakeLists.txt Fixed typo in hmaptool CMakeLists.txt to Fixed typo in hmaptool CMakeLists.txt.
Sat, May 28, 9:31 AM · Restricted Project, Restricted Project
danielh2942 requested review of D126598: Fixed typo in hmaptool CMakeLists.txt.
Sat, May 28, 9:30 AM · Restricted Project, Restricted Project
JohnTitor added a reviewer for D126597: [clang] Remove `rm` script which is no longer necessary: thakis.
Sat, May 28, 9:27 AM · Restricted Project, Restricted Project
JohnTitor requested review of D126597: [clang] Remove `rm` script which is no longer necessary.
Sat, May 28, 9:27 AM · Restricted Project, Restricted Project
JohnTitor committed rGbc08a16d828b: Remove `deplibs` keyword completely (authored by JohnTitor).
Remove `deplibs` keyword completely
Sat, May 28, 9:17 AM · Restricted Project, Restricted Project
JohnTitor closed D126527: Remove `deplibs` keyword completely.
Sat, May 28, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman added a comment to D126578: [clang] Add tests for (const) weak variables.

Thanks for looking to improve our test coverage here! However, precommit CI looks to be failing:

********************
Failed Tests (1):
  Clang :: CodeGenCXX/weak-init.cpp
Sat, May 28, 9:01 AM · Restricted Project, Restricted Project
klausler committed rG73506256bff6: [flang] Avoid spurious warnings from reading module files (authored by klausler).
[flang] Avoid spurious warnings from reading module files
Sat, May 28, 8:56 AM · Restricted Project, Restricted Project
klausler closed D126584: [flang] Avoid spurious warnings from reading module files.
Sat, May 28, 8:56 AM · Restricted Project, Restricted Project
tapaswenipathak updated the diff for D126183: Implement soft reset of the diagnostics engine..

I pasted the wrong diff. sorry!

Sat, May 28, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
sgatev added inline comments to D120495: [clang][dataflow] Add transfer functions for structured bindings.
Sat, May 28, 8:51 AM · Restricted Project, Restricted Project
sgatev updated the diff for D120495: [clang][dataflow] Add transfer functions for structured bindings.

Address comments.

Sat, May 28, 8:48 AM · Restricted Project, Restricted Project
RamNalamothu requested review of D126596: [lldb, test] Fix typos in the lldb tests.
Sat, May 28, 8:40 AM · Restricted Project, Restricted Project
peixin accepted D126195: [mlir][OpenMP] Add memory_order clause tests.

I have one doubt about the memory_order? It's not related to this patch. Are they implemented in codegen? I can be sure the codegen of the hint clause for atomic construct is not implemented. There was one list in clang to track the openmp status. They marked hint clause for atomic construct as done, but the link PR only has frontend support.

Sat, May 28, 8:23 AM · Restricted Project, Restricted Project
reames added a comment to D126563: [RISCV] Allow PRE of vsetvli involving non-1 LMUL.

Seems like there's no fractional LMULs tested by this patch? Does this suggest we should add some more test coverage?

Well, I would, but I could not find an example in tree of what a fractional LMUL looks like in IR. (Probably just because I don't know what syntax looks like). If you give me an example, I can take it from there.

Sat, May 28, 8:19 AM · Restricted Project, Restricted Project
peixin added a comment to D126404: [mlir][OpenMP] Add recursive side effect information and tests for canonicalize pass.

I am not an expect in MLIR attributes, so I will leave the review for other expects. The results by this patch LG. @shraiysh Where can I get the information of RecursiveSideEffects? Can you share one link?

Sat, May 28, 8:15 AM · Restricted Project, Restricted Project, Restricted Project
peixin added a comment to D126164: [flang] Enable the color set for diag messages.

ping. Do we have plans to support the colorful keyword for the diag messages for LLVM Flang?

Sat, May 28, 8:10 AM · Restricted Project, Restricted Project
peixin added inline comments to D126595: [flang] Add one missed semantic check for derived type accessbility.
Sat, May 28, 8:02 AM · Restricted Project, Restricted Project
philnik added a comment to D126249: [libc++] Remove _LIBCPP_ALIGNOF.
  • If the compiler ever wants to support alignof as an extension in C++03, we'll need coordination between the library and the compiler.

That could be avoided by checking for #if defined(_LIBCPP_CXX03_LANG) && !__has_keyword(alignof) instead of just #ifdef _LIBCPP_CXX03_LANG.

  • This is technically a breaking change for C++03 users because they are allowed to use alignof as a name, and we're not allowed to define identifiers outside of our namespace. Concretely, I do suspect this may break some C-first codebases that try to be clever.

C++03 in libc++ is more a crutch than anything else at this point. Users are also allowed to #define a lot of names in C++03 that we use in the library and are only part of C++11.

Sat, May 28, 8:01 AM · Restricted Project, Restricted Project
sgatev updated the diff for D120495: [clang][dataflow] Add transfer functions for structured bindings.

Rebase main.

Sat, May 28, 8:00 AM · Restricted Project, Restricted Project
peixin added a comment to D125632: [flang] Move TODO for elemental call with parentheses on argument.

@jeanPerier @schweitz Sorry to bother you again for this issue.

Sat, May 28, 7:58 AM · Restricted Project, Restricted Project
peixin requested review of D126595: [flang] Add one missed semantic check for derived type accessbility.
Sat, May 28, 7:49 AM · Restricted Project, Restricted Project
peixin added a comment to D126473: [flang] Fix semantic analysis for PDT component init.

@klausler Is there any possibility that these init can be folded elsewhere to skip these complicated checks?

Sat, May 28, 7:43 AM · Restricted Project, Restricted Project
peixin updated the diff for D126473: [flang] Fix semantic analysis for PDT component init.

Address all the comments.

Sat, May 28, 7:41 AM · Restricted Project, Restricted Project
alvinhochun updated the diff for D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF.

Changed GetPluginNameStatic to "PE-COFF", and rebased onto main.

Sat, May 28, 7:32 AM · Restricted Project, Restricted Project
kparzysz abandoned D125899: [ADT] Add copy constructor to IntervalMap.

Closing in favor of https://reviews.llvm.org/D125611.

Sat, May 28, 7:27 AM · Restricted Project, Restricted Project
alexbatashev added a comment to D126594: [mlir][cf] Implement missing SwitchOp::build function.

This patch probably requires a proper test case, but I'm not sure where to put it. Some guidance from reviewers would be really helpful.

Sat, May 28, 7:21 AM · Restricted Project, Restricted Project
tapaswenipathak updated the diff for D126183: Implement soft reset of the diagnostics engine..

Fixes

.

Sat, May 28, 7:20 AM · Restricted Project, Restricted Project, Restricted Project