Page MenuHomePhabricator

Today

hubert.reinterpretcast accepted D67878: [LNT] Python 3 support: use Python 3 urllib.

LGTM.

Sat, Sep 21, 3:50 PM
hubert.reinterpretcast added inline comments to D67818: [LNT] Python 3 support: adapt to renaming of raw_input to input.
Sat, Sep 21, 3:47 PM
jyknight committed rGc2ca003baffb: NFC: Change ObjCQualified*TypesAreCompatible to take ObjCObjectPointerType… (authored by jyknight).
NFC: Change ObjCQualified*TypesAreCompatible to take ObjCObjectPointerType…
Sat, Sep 21, 3:34 PM
jyknight committed rL372492: NFC: Change ObjCQualified*TypesAreCompatible to take.
NFC: Change ObjCQualified*TypesAreCompatible to take
Sat, Sep 21, 3:34 PM
lebedev.ri committed rGbaf809811b06: [InstSimplify] simplifyUnsignedRangeCheck(): X >= Y && Y == 0 --> Y == 0 (authored by lebedev.ri).
[InstSimplify] simplifyUnsignedRangeCheck(): X >= Y && Y == 0 --> Y == 0
Sat, Sep 21, 3:29 PM
lebedev.ri committed rGe94f156f778c: [InstSimplify][NFC] Reorganize simplifyUnsignedRangeCheck() to emphasize and/or… (authored by lebedev.ri).
[InstSimplify][NFC] Reorganize simplifyUnsignedRangeCheck() to emphasize and/or…
Sat, Sep 21, 3:27 PM
lebedev.ri committed rGac4dda805217: [NFC][InstSimplify] Add exhaustive test coverage for simplifyUnsignedRangeCheck… (authored by lebedev.ri).
[NFC][InstSimplify] Add exhaustive test coverage for simplifyUnsignedRangeCheck…
Sat, Sep 21, 3:27 PM
lebedevri committed rL372491: [InstSimplify] simplifyUnsignedRangeCheck(): X >= Y && Y == 0 --> Y == 0.
[InstSimplify] simplifyUnsignedRangeCheck(): X >= Y && Y == 0 --> Y == 0
Sat, Sep 21, 3:27 PM
lebedevri committed rL372490: [InstSimplify][NFC] Reorganize simplifyUnsignedRangeCheck() to emphasize and/or….
[InstSimplify][NFC] Reorganize simplifyUnsignedRangeCheck() to emphasize and/or…
Sat, Sep 21, 3:26 PM
lebedevri committed rL372489: [NFC][InstSimplify] Add exhaustive test coverage for simplifyUnsignedRangeCheck….
[NFC][InstSimplify] Add exhaustive test coverage for simplifyUnsignedRangeCheck…
Sat, Sep 21, 3:25 PM
sstefan1 updated the diff for D66844: getArgOperandNo helper function.

small refactoring to use getArgOperandNo

Sat, Sep 21, 3:25 PM · Restricted Project
SjoerdMeijer updated the diff for D67764: [LV] Forced vectorization with runtime checks and OptForSize.
Sat, Sep 21, 3:10 PM · Restricted Project
SjoerdMeijer added a comment to D67764: [LV] Forced vectorization with runtime checks and OptForSize.

Ah, I had completely missed that this is about the interaction of OptForSize and the loop.vectorize loop hint!
Vectorization is forced, which means that we vectorize even though OptForSize is set and we need to emit runtime checks.

Sat, Sep 21, 3:07 PM · Restricted Project
sstefan1 added a comment to D67886: NoFree argument attribute..

There should be other test changes, will update tomorrow.

Sat, Sep 21, 2:59 PM · Restricted Project
sstefan1 added a reviewer for D67886: NoFree argument attribute.: uenoku.
Sat, Sep 21, 2:58 PM · Restricted Project
thopre updated the diff for D67878: [LNT] Python 3 support: use Python 3 urllib.

Encode URL in ascii for real compability with Python2

Sat, Sep 21, 2:57 PM
sstefan1 created D67886: NoFree argument attribute..
Sat, Sep 21, 2:57 PM · Restricted Project
thopre updated the summary of D67818: [LNT] Python 3 support: adapt to renaming of raw_input to input.
Sat, Sep 21, 2:34 PM
thopre added a comment to D67818: [LNT] Python 3 support: adapt to renaming of raw_input to input.

I believe adding this to the files should work:

try:
    from builtins import input as raw_input
except ImportError:
    pass
Sat, Sep 21, 2:34 PM
thopre updated the diff for D67818: [LNT] Python 3 support: adapt to renaming of raw_input to input.

Import input from builtins for input to behave like raw_input in Python 2

Sat, Sep 21, 2:31 PM
andwar added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Sat, Sep 21, 2:30 PM · Restricted Project, Restricted Project
mstorsjo created D67885: [LLDB] Add a missing specification of linking against dbghelp.
Sat, Sep 21, 2:23 PM · Restricted Project
atanasyan accepted D67756: [MIPS GlobalISel] VarArg argument lowering, select G_VASTART and vacopy.

LGTM wit a few nits

Sat, Sep 21, 2:06 PM · Restricted Project
DeForest Richards <d4m1887@gmail.com> committed rG4f86528fc1ce: [Docs] Updates sidebar links (authored by DeForest Richards <d4m1887@gmail.com>).
[Docs] Updates sidebar links
Sat, Sep 21, 2:05 PM
dr87 committed rL372488: [Docs] Updates sidebar links.
[Docs] Updates sidebar links
Sat, Sep 21, 2:05 PM
thopre added a comment to D67884: [LNT] Sort machines by ID as expected by test case.

Alternatively the test could use -DAG directives. But I do think sorting is nicer as it's easier to find a machine in a long list and doing it on the server side sounds sensible to me. I'll let Chris have the last word though.

Sat, Sep 21, 1:58 PM
DeForest Richards <d4m1887@gmail.com> committed rGc1b0873d4218: [Docs] Adds new page for Getting Involved articles (authored by DeForest Richards <d4m1887@gmail.com>).
[Docs] Adds new page for Getting Involved articles
Sat, Sep 21, 1:56 PM
dr87 committed rL372487: [Docs] Adds new page for Getting Involved articles.
[Docs] Adds new page for Getting Involved articles
Sat, Sep 21, 1:55 PM
aaronpuchert added a reviewer for D67112: [Sema] Add implicit cast for conversion of function references: riccibruno.

Perhaps I should mention that this fixes an assertion failure.

Sat, Sep 21, 1:32 PM · Restricted Project
SjoerdMeijer added a comment to D67764: [LV] Forced vectorization with runtime checks and OptForSize.

Which commit does this trace back to, D65197?

Sat, Sep 21, 1:28 PM · Restricted Project
hubert.reinterpretcast created D67884: [LNT] Sort machines by ID as expected by test case.
Sat, Sep 21, 1:04 PM
aaronpuchert updated the diff for D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Pass correct Clang triple as argument to --target.

Sat, Sep 21, 12:56 PM · Restricted Project
davezarzycki added a comment to D67874: Prefer AVX512 memcpy when applicable.

Do we have a similar test for memset that should be updated?

Sat, Sep 21, 12:30 PM · Restricted Project
lawrence_danna added a comment to D67793: new api class: SBFile.

@labath So what do you think?
Update all the lldb_private::File clients to use shared_ptr<File> instead?
Or do it this way, with sharing handled inside of File?

Sat, Sep 21, 12:16 PM · Restricted Project
mstorsjo committed rG5534a6750087: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing (authored by mstorsjo).
[LLDB] Cast -1 (as invalid socket) to the socket type before comparing
Sat, Sep 21, 12:10 PM
mstorsjo committed rGed78dc8e4371: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format… (authored by mstorsjo).
[LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format…
Sat, Sep 21, 12:10 PM
mstorsjo committed rG5c38730dbd00: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment (authored by mstorsjo).
[LLDB] Use LLVM_FALLTHROUGH instead of a custom comment
Sat, Sep 21, 12:10 PM
mstorsjo committed rG2e25c44dc3fa: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition… (authored by mstorsjo).
[LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition…
Sat, Sep 21, 12:09 PM
mstorsjo committed rGf4deacf995c7: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member (authored by mstorsjo).
[LLDB] Fix compilation for MinGW, remove redundant class name on inline member
Sat, Sep 21, 12:09 PM
mstorsjo committed rG1bfdab52a76b: [CodeView] Add pragma push/pop_macro for ARM64_FPSR to enum header (authored by mstorsjo).
[CodeView] Add pragma push/pop_macro for ARM64_FPSR to enum header
Sat, Sep 21, 12:09 PM