Page MenuHomePhabricator

Recent Activity
View All

Today

fhahn requested review of D94783: [LTO] Remove options to disable inlining and GVNLoadPRE..
Fri, Jan 15, 7:49 AM · Restricted Project
samtebbs committed rG1a497ae9b836: [ARM][Block placement] Check the predecessor exists before processing it (authored by samtebbs).
[ARM][Block placement] Check the predecessor exists before processing it
Fri, Jan 15, 7:45 AM
samtebbs closed D94780: [ARM][Block placement] Check the predecessor exists before processing it.
Fri, Jan 15, 7:45 AM · Restricted Project
jansvoboda11 committed rG1744f4c67641: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members (authored by jansvoboda11).
[clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members
Fri, Jan 15, 7:42 AM
gchatelet updated the diff for D94760: [libc][NFC] remove dependency on non standard ssize_t.
  • buffer values are never modified so we can use char instead of unsigned char.
Fri, Jan 15, 7:42 AM · Restricted Project
lenary accepted rGbf1aa5db5c76: [RISCV][NFC] Fix order of parameters in cmov ge/le tests.

Sorry, I meant to accept this before it landed.

Fri, Jan 15, 7:42 AM
jansvoboda11 committed rGa7dcd3aeb0fb: [clang][cli] NFC: Parse some LangOpts after the defaults are set (authored by jansvoboda11).
[clang][cli] NFC: Parse some LangOpts after the defaults are set
Fri, Jan 15, 7:42 AM
jansvoboda11 committed rG383262933045: [clang][cli] NFC: Add PIE parsing for precompiled input and IR (authored by jansvoboda11).
[clang][cli] NFC: Add PIE parsing for precompiled input and IR
Fri, Jan 15, 7:42 AM
jansvoboda11 closed D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members.
Fri, Jan 15, 7:42 AM · Restricted Project
jansvoboda11 closed D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set.
Fri, Jan 15, 7:42 AM · Restricted Project
jansvoboda11 closed D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR.
Fri, Jan 15, 7:42 AM · Restricted Project
awarzynski added reviewers for D94782: [flang][driver] Make the driver report diagnostics from the prescanner: tskeith, FarisRehman, CarolineConcatto, sameeranjoshi, SouraVX, AMDChirag, kiranktp.
Fri, Jan 15, 7:41 AM · Restricted Project, Restricted Project
awarzynski requested review of D94782: [flang][driver] Make the driver report diagnostics from the prescanner.
Fri, Jan 15, 7:40 AM · Restricted Project, Restricted Project
lenary committed rGbf1aa5db5c76: [RISCV][NFC] Fix order of parameters in cmov ge/le tests (authored by mundaym).
[RISCV][NFC] Fix order of parameters in cmov ge/le tests
Fri, Jan 15, 7:37 AM
lenary closed D94729: [RISCV][NFC] Fix order of parameters in cmov ge/le tests.
Fri, Jan 15, 7:37 AM · Restricted Project
hubert.reinterpretcast added a comment to D94670: [DebugInfo][NFC] add a new DIE type to represent label + offset.
In D94670#2500677, @shchenz wrote:

2: On AIX, the assembler does not need the assembly file contains the dwarf sections length info in the dwarf section header(if the dwarf section has header.) Instead, the assembler will insert the calculated length into dwarf sections header of the final object according to DWARF type. Namely AIX assembler will insert 4 bytes in each section header for DWARF32 and 12 bytes for DWARF64.

Fri, Jan 15, 7:36 AM · Restricted Project
SjoerdMeijer accepted D94687: [AArch64] Make target intrinsics DefaultAttrIntrinsics..

Looks like we get a lot of happiness from using these attributes. ;-)
I had a look at it before and the general direction also looked okay to me too, which I was happy to see confirmed. Therefore I am happy to accept this, even though I haven't checked all intrinsics because this is a lot of changes. So perhaps wait a day with committing in case anyone wants to have one more look.

Fri, Jan 15, 7:35 AM · Restricted Project
malharJ added inline comments to D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1..
Fri, Jan 15, 7:34 AM · Restricted Project
gchatelet committed rG5bf47e142b6e: [libc] CopyAlignedBlocks can now specify alignment on top of block size (authored by gchatelet).
[libc] CopyAlignedBlocks can now specify alignment on top of block size
Fri, Jan 15, 7:32 AM
gchatelet closed D94770: [libc] CopyAlignedBlocks can now specify alignment on top of block size.
Fri, Jan 15, 7:32 AM · Restricted Project
malharJ added a reviewer for D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.: aaron.ballman.
Fri, Jan 15, 7:30 AM · Restricted Project
gchatelet added a comment to D94770: [libc] CopyAlignedBlocks can now specify alignment on top of block size.
In D94770#2501005, @avieira wrote:

Eh you beat me to it. Had a similar patch I've been measuring and testing. Your's is more complete though :)

LGTM.

Fri, Jan 15, 7:30 AM · Restricted Project
clementval committed rGcf0173de69a7: [mlir] Add better support for f80 and f128 (authored by clementval).
[mlir] Add better support for f80 and f128
Fri, Jan 15, 7:30 AM
clementval closed D94737: [mlir] Add better support for f80 and f128.
Fri, Jan 15, 7:30 AM · Restricted Project
SjoerdMeijer added inline comments to D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1..
Fri, Jan 15, 7:26 AM · Restricted Project
frasercrmck accepted D94580: [RISCV] Swap encodings of max and minu to match 0.93 bitmanip spec..

LGTM

Fri, Jan 15, 7:24 AM · Restricted Project
foad added inline comments to D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking.
Fri, Jan 15, 7:24 AM · Restricted Project
frasercrmck added inline comments to D94577: [RISCV] Remove addiwu, addwu, subwu, subuw, clmulw, clmulrw, clmulhw to match 0.93 bitmanip spec..
Fri, Jan 15, 7:23 AM · Restricted Project
PeteSteinfeld added a project to D94781: [flang] Disallow INTENT attribute on procedure dummy arguments: Restricted Project.
Fri, Jan 15, 7:21 AM · Restricted Project, Restricted Project
herhut added inline comments to D94421: [mlir] Add gpu async integration test..
Fri, Jan 15, 7:20 AM · Restricted Project
SjoerdMeijer added inline comments to D93694: [MachineLICM][MachineSink] Move SinkIntoLoop from MachineLICM to MachineSink.
Fri, Jan 15, 7:20 AM · Restricted Project
tbaeder updated the diff for D84846: [MC] Add support for generating missing GNU build notes.

Sorry about the last change, that was the wrong patch.

Fri, Jan 15, 7:19 AM · Restricted Project, Restricted Project
tbaeder updated the diff for D84846: [MC] Add support for generating missing GNU build notes.
Fri, Jan 15, 7:18 AM · Restricted Project, Restricted Project
frasercrmck accepted D94568: [RISCV] Rename pcnt->cpop to match 0.93 bitmanip spec..

LGTM from a change point of view. I can't really add to the discussion about how/when to switch from 0.92 to 0.93 so I'm not saying "merge right away" :)

Fri, Jan 15, 7:16 AM · Restricted Project
frasercrmck accepted D94751: [RISCV] Correct alignment settings for vector registers..

Makes sense to me. I think we'll have to handle "misaligned" vectors at some point too, since the DataLayout can only represent the alignment of vectors based on their overall size.

Fri, Jan 15, 7:15 AM · Restricted Project
khchen added a comment to D94566: [RISCV] Use tail agnostic policy for instructions with tied defs if the use operand is IMPLICIT_DEF..

LGTM!

Fri, Jan 15, 7:12 AM · Restricted Project
herhut added inline comments to D94495: [mlir] Set CUDA/ROCm context before creating resources..
Fri, Jan 15, 7:11 AM · Restricted Project
khchen added inline comments to D94589: [RISCV] Add intrinsics for vector AMO instructions.
Fri, Jan 15, 7:10 AM · Restricted Project
jdoerfert added a comment to D94687: [AArch64] Make target intrinsics DefaultAttrIntrinsics..

(Some ARM-aware ppl should review/accept)

Fri, Jan 15, 7:10 AM · Restricted Project
dmgreen accepted D94780: [ARM][Block placement] Check the predecessor exists before processing it.

Thanks. LGTM

Fri, Jan 15, 7:10 AM · Restricted Project