Page MenuHomePhabricator

Recent Activity
View All

Today

AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Updating diff to reflect memory leak fixes, using strategy from D86968 to use SpecificBumpPtrAllocator rather than BumpPtrAllocatotr.

Fri, Nov 27, 9:45 PM · Restricted Project
zoecarver added inline comments to D92255: [libc++] [P0202] constexpr set_union, set_difference, set_symmetric_difference, merge.
Fri, Nov 27, 9:36 PM · Restricted Project
MaskRay requested review of D92259: [ELF] Make foo@@v1 resolved undefined foo@v1.
Fri, Nov 27, 9:31 PM · Restricted Project
MaskRay requested review of D92258: [ELF][test] Add some tests for versioned symbols in object files.
Fri, Nov 27, 9:30 PM · Restricted Project
HazardyKnusperkeks requested review of D92257: [clang-format] Add option to control the space at the front of a line comment.
Fri, Nov 27, 9:24 PM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D91996: [clang-format] Remove double trim.

Formatted and now superfluous comment removed.

Fri, Nov 27, 9:02 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D91996: [clang-format] Remove double trim.
In D91996#2417892, @klimek wrote:

Isn't the comment incorrect after this patch?

Fri, Nov 27, 8:56 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D91507: [clang-format] Add option for case sensitive regexes for sorted includes.

than someone needs to commit it.

Fri, Nov 27, 8:54 PM · Restricted Project, Restricted Project
• thakis added a comment to D91936: [BasicAA] Fix BatchAA results for phi-phi assumptions.

We also found an infinite loop triggered by this. Our repro is at https://bugs.chromium.org/p/chromium/issues/detail?id=1153398#c3

Fri, Nov 27, 8:54 PM · Restricted Project
mehdi_amini added a comment to D92193: Use bool in place of int for boolean things in the C API.
In D92193#2420724, @GeorgeLyon wrote:

I'm guessing it is safe to ignore the unused function warnings?

Fri, Nov 27, 7:53 PM · Restricted Project
mehdi_amini accepted D92252: Use `const` for array pointers in `StandardTypes.h`.
Fri, Nov 27, 7:52 PM · Restricted Project
mehdi_amini added a comment to D92216: [mlir] Add InlineAsmOp to standard.
In D92216#2420755, @nicolasvasilache wrote:

Also, please respond to this:

Happy to restrict to not using or defining any symbol and global variables and that everything else is UB.
Would that be reasonable?

Do you still foresee the problematic behaviors you mentioned with these restrictions ?

Fri, Nov 27, 7:49 PM · Restricted Project
kaz7 requested review of D92256: [VE] Specify vector alignments.
Fri, Nov 27, 7:41 PM · Restricted Project, Restricted Project, Restricted Project
xndcn added a comment to D92041: [clangd] Add hover info for `this` expr.
In D92041#2420251, @kadircet wrote:

Do you have commit access or should I commit this for you?

Fri, Nov 27, 7:20 PM · Restricted Project, Restricted Project
Quuxplusone requested review of D92255: [libc++] [P0202] constexpr set_union, set_difference, set_symmetric_difference, merge.
Fri, Nov 27, 7:17 PM · Restricted Project
Meinersbur added a comment to D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function.

Looking at CodeGenFunction::GenerateOpenMPCapturedVars, the condition if (!CurField->getType()->isAnyPointerType()) seems to match what is done here, but I wonder whether it is always necessary. Is the additional indirection necessary for pointer-sized data types (e.g. intptr_t, or smaller)?

Fri, Nov 27, 6:56 PM · Restricted Project
kaz7 requested review of D92254: [VE] Clean check routines of branch types.
Fri, Nov 27, 6:51 PM · Restricted Project, Restricted Project
craig.topper requested review of D92253: [RISCV] Custom legalize bswap/bitreverse to GREVI with Zbp extension to enable them to combine with other GREVI instructions.
Fri, Nov 27, 6:32 PM · Restricted Project
ijsung added a comment to D92075: Don't count attributes when addressing operands..

Thanks & PTAL

Fri, Nov 27, 6:30 PM · Restricted Project
Quuxplusone updated subscribers of D92239: [libc++] Support simply `std::iterator_traits` in the iterator_traits test..

Turns out this is a duplicate of @vvereschaka's D92142, but @ldionne, I'd still like to land this spelling of it, for consistency with https://github.com/llvm/llvm-project/commit/66e6e37447b183b1c8bac9330a4658530d2d49e6 .

Fri, Nov 27, 6:26 PM · Restricted Project
ijsung updated the diff for D92075: Don't count attributes when addressing operands..

Addressed more comments on the test.

Fri, Nov 27, 6:26 PM · Restricted Project
Meinersbur added a comment to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.

So why not creating a OpenMPIRBuilder::createWorksharingLoop that can be used by clang as well?

Fri, Nov 27, 6:26 PM · Restricted Project
craig.topper committed rG6ee22ca6ceb7: [RISCV] Add tests for existing (rotr (bswap X), (i32 16))->grevi pattern for… (authored by craig.topper).
[RISCV] Add tests for existing (rotr (bswap X), (i32 16))->grevi pattern for…
Fri, Nov 27, 6:09 PM
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rG88974e829ec3: [gn build] Port a8a43b63388 (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port a8a43b63388
Fri, Nov 27, 6:01 PM
AndrewLitteken added a reverting change for rGbf899e891387: [IRSim][IROutliner] Adding the extraction basics for the IROutliner.: rGa8a43b63388f: Revert "[IRSim][IROutliner] Adding the extraction basics for the IROutliner.".
Fri, Nov 27, 5:56 PM
AndrewLitteken committed rGa8a43b63388f: Revert "[IRSim][IROutliner] Adding the extraction basics for the IROutliner." (authored by AndrewLitteken).
Revert "[IRSim][IROutliner] Adding the extraction basics for the IROutliner."
Fri, Nov 27, 5:56 PM
AndrewLitteken added a reverting change for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner.: rGa8a43b63388f: Revert "[IRSim][IROutliner] Adding the extraction basics for the IROutliner.".
Fri, Nov 27, 5:56 PM · Restricted Project
jpark37 abandoned D85266: Include math header early to avoid HUGE_VALF redefinition.

Looks like the issue was fixed by 9124fa592098d3794d7b31f83a58e40cc469ff0c.

Fri, Nov 27, 5:43 PM · Restricted Project
jpark37 added a comment to D85264: Avoid redundant inline with LLVM_ATTRIBUTE_ALWAYS_INLINE.

Is there something I need to do to land this? I'm new to LLVM.

Fri, Nov 27, 5:39 PM · Restricted Project
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rGcbc8c1eb48c5: [gn build] Port bf899e89138 (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port bf899e89138
Fri, Nov 27, 5:15 PM
vchuravy updated subscribers of D86837: Allow specifying AA info when constructing certain libcalls.
Fri, Nov 27, 5:13 PM · Restricted Project
yuyichao added a comment to D86837: Allow specifying AA info when constructing certain libcalls.

Any review?

Fri, Nov 27, 5:11 PM · Restricted Project
AndrewLitteken committed rGbf899e891387: [IRSim][IROutliner] Adding the extraction basics for the IROutliner. (authored by AndrewLitteken).
[IRSim][IROutliner] Adding the extraction basics for the IROutliner.
Fri, Nov 27, 5:09 PM
AndrewLitteken closed D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Fri, Nov 27, 5:09 PM · Restricted Project
GeorgeLyon updated the diff for D92252: Use `const` for array pointers in `StandardTypes.h`.

Try again after rebase

Fri, Nov 27, 4:57 PM · Restricted Project
kaz7 added inline comments to D91416: [VE] LVLGen sets VL before vector insts.
Fri, Nov 27, 4:55 PM · Restricted Project, Restricted Project
GeorgeLyon updated the diff for D92252: Use `const` for array pointers in `StandardTypes.h`.

Fix diff

Fri, Nov 27, 4:55 PM · Restricted Project
GeorgeLyon retitled D92252: Use `const` for array pointers in `StandardTypes.h` from More const pointers to Use `const` for array pointers in `StandardTypes.h` .
Fri, Nov 27, 4:52 PM · Restricted Project
GeorgeLyon requested review of D92252: Use `const` for array pointers in `StandardTypes.h`.
Fri, Nov 27, 4:51 PM · Restricted Project
arthur.j.odwyer committed rG530c69e90964: [libc++] s/constpexr/constexpr/ in some comments. NFC. (authored by arthur.j.odwyer).
[libc++] s/constpexr/constexpr/ in some comments. NFC.
Fri, Nov 27, 3:53 PM