Page MenuHomePhabricator

Recent Activity

Today

efriedma requested review of D129164: [AsmPrinter] Fix bit pattern for i1 vectors..
Tue, Jul 5, 3:30 PM · Restricted Project, Restricted Project
jlpeyton committed rG43d5c4d5394e: [OpenMP] add 4 custom APIs supporting MSVC OMP codegen (authored by vadikp-intel).
[OpenMP] add 4 custom APIs supporting MSVC OMP codegen
Tue, Jul 5, 3:27 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D129163: [mlir] Support cmake 3.15+ in the python mlir configuration.

Oof... thank you for looking into this, but this is also pretty gross/fragile. Are we *sure* we want to do this? This is the only project I work on that treats CMake as an LTS-like thing, and I would be utterly shocked if this was the only optional feature that found itself needing a newer CMake for basic things. Do you happen to know which CMake version this workaround is not needed for (I knew at one time but have forgotten)?

Tue, Jul 5, 3:26 PM · Restricted Project, Restricted Project
jlpeyton closed D128403: [OpenMP] add 4 custom APIs supporting MSVC OMP codegen.
Tue, Jul 5, 3:26 PM · Restricted Project, Restricted Project
lhames accepted D128601: [ORC][ORC_RT][AArch64] Implement TLS descriptor in ELFNixPlatform..

Otherwise LGTM. Thank you again! :)

Tue, Jul 5, 3:25 PM · Restricted Project, Restricted Project, Restricted Project
aemerson committed rGb97013fd6097: [AArch64][GlobalISel] Add support for sret demotion. (authored by aemerson).
[AArch64][GlobalISel] Add support for sret demotion.
Tue, Jul 5, 3:24 PM · Restricted Project, Restricted Project
aemerson closed D129098: [AArch64][GlobalISel] Add support for sret demotion..
Tue, Jul 5, 3:24 PM · Restricted Project, Restricted Project
lhames committed rG9b1cf2e2b2a8: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT (again). (authored by lhames).
Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT (again).
Tue, Jul 5, 3:20 PM · Restricted Project, Restricted Project
stella.stamenova added inline comments to D129163: [mlir] Support cmake 3.15+ in the python mlir configuration.
Tue, Jul 5, 3:19 PM · Restricted Project, Restricted Project
stella.stamenova requested review of D129163: [mlir] Support cmake 3.15+ in the python mlir configuration.
Tue, Jul 5, 3:16 PM · Restricted Project, Restricted Project
ychen added a comment to D129025: [SimplifyCFG] Skip hoisting common instructions that return token type.

I think we need to clarify LangRef if this is illegal in general for tokens in general. If it is, we need to explain why. If it isn't, we need an attribute the express the right semantics here.

All LangRef really says at the moment is that a token can't be put behind a phi or select; it doesn't really describe if/when it's legal to merge instructions that produce tokens.

Tue, Jul 5, 3:14 PM · Restricted Project, Restricted Project
Mogball added inline comments to D129038: [mlir] Define proper DenseMapInfo for Interfaces.
Tue, Jul 5, 3:00 PM · Restricted Project, Restricted Project
klausler added a comment to D129018: [flang] Establish a single source of target information for semantics.

ping now that MSVC build succeeds

Tue, Jul 5, 2:56 PM · Restricted Project, Restricted Project
maksfb accepted D128971: [BOLT] Avoid implicit memset in hugify.

Thanks for the fix.

Tue, Jul 5, 2:56 PM · Restricted Project, Restricted Project
anton-afanasyev committed rGf553287b5889: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++ (authored by anton-afanasyev).
[RISCV][Driver] Add libm linking to `RISCVToolchain` for C++
Tue, Jul 5, 2:55 PM · Restricted Project, Restricted Project
anton-afanasyev closed D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++.
Tue, Jul 5, 2:54 PM · Restricted Project, Restricted Project
yota9 accepted D129162: [BOLT] Change mutex implementation.

LGTM
@maksfb Please take a look :)

Tue, Jul 5, 2:54 PM · Restricted Project, Restricted Project
JDevlieghere accepted D128768: [lldb/Core] Fix finite progress event reporting.

LGTM

Tue, Jul 5, 2:50 PM · Restricted Project, Restricted Project
Elvina updated the summary of D129162: [BOLT] Change mutex implementation.
Tue, Jul 5, 2:45 PM · Restricted Project, Restricted Project
Elvina added a comment to D129089: [BOLT] Fix concurrency bugs in the instrumentation runtime.

@michoecho, thank you for the investigation and the patch. Both changes look good to me.

@yota9, @Elvina, great. Could you submit a patch with __atomic_test_and_set()?

Tue, Jul 5, 2:44 PM · Restricted Project, Restricted Project
omjavaid committed rGbb9b30ffbe7c: [LLDB] Remove TestLoadUnload.py Arm/Linux Xfail decorator (authored by omjavaid).
[LLDB] Remove TestLoadUnload.py Arm/Linux Xfail decorator
Tue, Jul 5, 2:44 PM · Restricted Project
Elvina updated the diff for D129162: [BOLT] Change mutex implementation.
Tue, Jul 5, 2:42 PM · Restricted Project, Restricted Project
arsenm accepted D129098: [AArch64][GlobalISel] Add support for sret demotion..
Tue, Jul 5, 2:41 PM · Restricted Project, Restricted Project
anton-afanasyev added a comment to D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++.

Commit subject/body should say C++ in it

Tue, Jul 5, 2:41 PM · Restricted Project, Restricted Project
anton-afanasyev retitled D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++ from [RISCV][Driver] Add libm linking to `RISCVToolchain` to [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++.
Tue, Jul 5, 2:40 PM · Restricted Project, Restricted Project
Elvina updated the summary of D129162: [BOLT] Change mutex implementation.
Tue, Jul 5, 2:37 PM · Restricted Project, Restricted Project
Elvina removed a reviewer for D129162: [BOLT] Change mutex implementation: rafaelauler.
Tue, Jul 5, 2:35 PM · Restricted Project, Restricted Project
Elvina requested review of D129162: [BOLT] Change mutex implementation.
Tue, Jul 5, 2:35 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D128927: [libc++] Always build c++experimental.a.

@mstorsjo I might need some assistance figuring out what to do with the Windows parts of this change.

Tue, Jul 5, 2:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
beanz added a comment to D128012: [HLSL] Add ExternalSemaSource & vector alias.

Posted an update in rGa6e63e35ede4, which removes the not-fully-implemented RTTI bits, and adds an extra test case to cover instantiation errors.

Tue, Jul 5, 2:34 PM · Restricted Project, Restricted Project
Herald added a reviewer for D108469: Improve handling of static assert messages.: NoQ.

I missed my opportunity to review while being on vacation last week. I reviewed to keep myself informed; spotted a typo.

Tue, Jul 5, 2:33 PM · Restricted Project, Restricted Project, Restricted Project
beanz committed rGa6e63e35ede4: [NFC][HLSL] Add tests for vector alias. Remove dead code. (authored by beanz).
[NFC][HLSL] Add tests for vector alias. Remove dead code.
Tue, Jul 5, 2:33 PM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D111978: [lldb] Improve the error message in run_to_breakpoint_do_run.
Tue, Jul 5, 2:26 PM · Restricted Project, Restricted Project
JDevlieghere updated the diff for D111978: [lldb] Improve the error message in run_to_breakpoint_do_run.
  • Use Process::GetSTD{OUT,ERR}
Tue, Jul 5, 2:23 PM · Restricted Project, Restricted Project
fcloutier updated the diff for D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`.

There was a merge conflict on the release notes, updating the differential to get a CI build.

Tue, Jul 5, 2:23 PM · Restricted Project, Restricted Project
JDevlieghere commandeered D111978: [lldb] Improve the error message in run_to_breakpoint_do_run.
Tue, Jul 5, 2:22 PM · Restricted Project, Restricted Project
rafauler added a comment to D129089: [BOLT] Fix concurrency bugs in the instrumentation runtime.

Thanks!

Tue, Jul 5, 2:22 PM · Restricted Project, Restricted Project
owenpan added inline comments to D129064: [clang-format] Avoid crash in LevelIndentTracker..
Tue, Jul 5, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
tstellar added a comment to D109621: [clang][Driver] Default to loading clang.cfg if config file not specified.

I similar RFC for this was proposed here: https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606

Tue, Jul 5, 2:19 PM · Restricted Project, Restricted Project
JamesNagurne requested review of D129161: [MachinePipeliner] Consider only direct path successors when calculating circuit latency.
Tue, Jul 5, 2:18 PM · Restricted Project, Restricted Project