Would it be possible to implement this without modifying Operation, i.e. as a simple trait rather than a trait based on a core operation property? Unlike "IsTerminator" and "IsolatedFromAbove", we don't have core mechanisms (which are the block verifier and the symbol resolver in the mentioned cases) that would mandate exposing this trait in Operation APIs.

Thanks for the response!

I'm sorry about the delay in review, this did fall off my radar. Thank you for bringing it to my attention!

Ok thanks, LGTM

Thanks!

Can you also add some unit tests to the dynamic matcher tests?

In D77371#1971651, @zero9178 wrote:

This patch breaks building LLVM with BUILD_SHARED_LIBS due to a linker error. UseRegsitersForDeoptValues is declared as extern in TargetPassConfig while the definition of the value is in SelectionDAG/StatepointLower.cpp. As the LLVMCodegen target does not link against LLVMSelectionDAG it causes undefined reference errors when linking LLVMCodegen

In D77786#1971519, @danielkiss wrote:

Please help me how to add a test for it, in the current state this patch won't do anything because the standard build for libunwind does not add -mbranch-protection=standard (or bti).

Refine error message

Fixed up documentation for CastKind matcher.

Would like to try to draw attention to this patch again, since it seems to have gone under the radar. Can someone review this/help get it integrated? We are still having to work around _Atomic types because we can't get to the underlying value type. Thanks

Introduced ArgKind::Indirect.

This patch breaks building LLVM with BUILD_SHARED_LIBS due to a linker error. UseRegsitersForDeoptValues is declared as extern in TargetPassConfig while the definition of the value is in SelectionDAG/StatepointLower.cpp. As the LLVMCodegen target does not link against LLVMSelectionDAG it causes undefined reference errors when linking LLVMCodegen

Please take a look: D77789.

Address review feedback