Page MenuHomePhabricator

Today

lebedev.ri added a comment to D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3.

That is a valid transformation: https://rise4fun.com/Alive/bxq

I see, because of the truncs back into an i16. That makes sense.

Ok, and that one is done too:

$ ./bin/clang -target arm-none-eabi -mcpu=cortex-m0plus -O3 -mllvm -phi-node-folding-threshold=2 -S -o old.s /tmp/test.c 
$ ./bin/clang -target arm-none-eabi -mcpu=cortex-m0plus -O3 -mllvm -phi-node-folding-threshold=3 -S -o new.s /tmp/test.c 
$ diff old.s new.s 
$ <no diff>
$ sha512sum *.s
9332ab2169151fa21ab03e1fb218178aa16bed2c0dfdd0a40b178a75dbd4a865ba7a7b1b4b37f252928ea794e38776260f84f6c1ae3684d5a445118f518351e2  new.s
9332ab2169151fa21ab03e1fb218178aa16bed2c0dfdd0a40b178a75dbd4a865ba7a7b1b4b37f252928ea794e38776260f84f6c1ae3684d5a445118f518351e2  old.s
Sat, Aug 24, 12:23 AM · Restricted Project

Yesterday

lebedev.ri committed rG9cf08c6de1da: [Constant] Add 'isElementWiseEqual()' method (authored by lebedev.ri).
[Constant] Add 'isElementWiseEqual()' method
Fri, Aug 23, 11:51 PM
lebedev.ri committed rGde19f749e0e6: [InstCombine] matchThreeWayIntCompare(): commutativity awareness (authored by lebedev.ri).
[InstCombine] matchThreeWayIntCompare(): commutativity awareness
Fri, Aug 23, 11:51 PM
lebedev.ri committed rG2c75fe7f2a8b: [InstCombine] Try to reuse constant from select in leading comparison (authored by lebedev.ri).
[InstCombine] Try to reuse constant from select in leading comparison
Fri, Aug 23, 11:51 PM
lebedev.ri committed rGb3eccc7f0b7f: [InstCombine][NFC] reuse-constant-from-select-in-icmp.ll - revisit tests (authored by lebedev.ri).
[InstCombine][NFC] reuse-constant-from-select-in-icmp.ll - revisit tests
Fri, Aug 23, 11:51 PM
lebedevri committed rL369842: [Constant] Add 'isElementWiseEqual()' method.
[Constant] Add 'isElementWiseEqual()' method
Fri, Aug 23, 11:48 PM
lebedevri committed rL369840: [InstCombine] Try to reuse constant from select in leading comparison.
[InstCombine] Try to reuse constant from select in leading comparison
Fri, Aug 23, 11:48 PM
lebedevri committed rL369841: [InstCombine] matchThreeWayIntCompare(): commutativity awareness.
[InstCombine] matchThreeWayIntCompare(): commutativity awareness
Fri, Aug 23, 11:48 PM
Diffusion closed D66232: [InstCombine] Try to reuse constant from select in leading comparison.
Fri, Aug 23, 11:48 PM · Restricted Project
Diffusion closed D66607: [InstCombine] matchThreeWayIntCompare(): commutativity awareness.
Fri, Aug 23, 11:48 PM · Restricted Project
lebedevri committed rL369839: [InstCombine][NFC] reuse-constant-from-select-in-icmp.ll - revisit tests.
[InstCombine][NFC] reuse-constant-from-select-in-icmp.ll - revisit tests
Fri, Aug 23, 11:48 PM
MaskRay committed rG62083ec15741: [ELF] Make member function Writer<ELFT>::removeEmptyPTLoad non-member. NFC (authored by MaskRay).
[ELF] Make member function Writer<ELFT>::removeEmptyPTLoad non-member. NFC
Fri, Aug 23, 11:34 PM
uenoku updated the diff for D66645: [Attributor] Add helper class to compose two structured deduction..

Minor update.

Fri, Aug 23, 11:34 PM · Restricted Project
MaskRay committed rL369838: [ELF] Make member function Writer<ELFT>::removeEmptyPTLoad non-member. NFC.
[ELF] Make member function Writer<ELFT>::removeEmptyPTLoad non-member. NFC
Fri, Aug 23, 11:30 PM
uenoku added a child revision for D66635: [Attributor] Clamp operator to extend known state: D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.
Fri, Aug 23, 11:19 PM · Restricted Project
uenoku edited parent revisions for D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer, added: 2; removed: 1.
Fri, Aug 23, 11:19 PM · Restricted Project
uenoku added a child revision for D66645: [Attributor] Add helper class to compose two structured deduction.: D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.
Fri, Aug 23, 11:19 PM · Restricted Project
uenoku removed a child revision for D65186: [MustExec] Add a generic "must-be-executed-context" explorer: D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.
Fri, Aug 23, 11:19 PM · Restricted Project
lebedev.ri added a comment to D66687: [x86] try to form more bt/test + set out of shift+mask patterns.

I would think this should go into DAGCombiner under hasBitTest() hook.

Fri, Aug 23, 11:12 PM · Restricted Project
lebedev.ri added inline comments to D66688: [LoopVectorize] Leverage speculation safety to avoid masked.loads.
Fri, Aug 23, 11:12 PM · Restricted Project
lebedev.ri added inline comments to D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan.
Fri, Aug 23, 11:05 PM · Restricted Project, Restricted Project, Restricted Project
craig.topper committed rGdd2cf7838114: [X86] Add an assert to mark more code that needs to be removed when the vector… (authored by craig.topper).
[X86] Add an assert to mark more code that needs to be removed when the vector…
Fri, Aug 23, 11:03 PM
ctopper committed rL369837: [X86] Add an assert to mark more code that needs to be removed when the vector….
[X86] Add an assert to mark more code that needs to be removed when the vector…
Fri, Aug 23, 11:02 PM
cvenegas added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I'm testing this patch on our codebase and it is working pretty well. We use the Allman style and the lambda problem has been an issue for many years. One thing to note in this patch is that some of the files have CRLF line endings but should be LF endings, which is why they're showing so many edits. I'm also seeing a clang tidy test failing with this patch. The readability-braces-around-statements tests seem to fail because the indent width is appending double of what it should.
void test() {

   if (cond("if0") /*comment*/) {
      do_something("same-line");
}
Fri, Aug 23, 10:18 PM · Restricted Project
logan-5 updated the diff for D66621: [clang] Devirtualization for classes with destructors marked as 'final'.

Add a missing null check.

Fri, Aug 23, 10:17 PM · Restricted Project
gchatelet updated the diff for D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
  • Add missing renames
Fri, Aug 23, 9:58 PM · Restricted Project
jsji created D66699: [PowerPC][Altivec] Fix constant argument for vec_dss.
Fri, Aug 23, 9:17 PM · Restricted Project
jsji added a reviewer for D66699: [PowerPC][Altivec] Fix constant argument for vec_dss: Restricted Project.
Fri, Aug 23, 9:17 PM · Restricted Project
owenpan added inline comments to D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren.
Fri, Aug 23, 8:28 PM · Restricted Project
MaskRay committed rGeb70ac024931: [LoopFusion] Fix -Wunused-function in -DLLVM_ENABLE_ASSERTIONS=off build (authored by MaskRay).
[LoopFusion] Fix -Wunused-function in -DLLVM_ENABLE_ASSERTIONS=off build
Fri, Aug 23, 7:51 PM
MaskRay committed rL369836: [LoopFusion] Fix -Wunused-function in -DLLVM_ENABLE_ASSERTIONS=off build.
[LoopFusion] Fix -Wunused-function in -DLLVM_ENABLE_ASSERTIONS=off build
Fri, Aug 23, 7:51 PM
bin.narwal created D66698: [ScopBuilder]Remove redundant while loop in ScopBuilder::buildDomains.
Fri, Aug 23, 7:45 PM · Restricted Project, Restricted Project
aemerson committed rGcc25dabe2385: Remove unnecessary REQUIRES from a test. (authored by aemerson).
Remove unnecessary REQUIRES from a test.
Fri, Aug 23, 7:42 PM
aemerson committed rL369835: Remove unnecessary REQUIRES from a test..
Remove unnecessary REQUIRES from a test.
Fri, Aug 23, 7:42 PM
Richard Smith <richard-llvm@metafoo.co.uk> committed rGcb167c85b468: PR42513: Enter the proper DeclContext before substituting into an default… (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
PR42513: Enter the proper DeclContext before substituting into an default…
Fri, Aug 23, 7:37 PM
rsmith committed rL369834: PR42513: Enter the proper DeclContext before substituting into an.
PR42513: Enter the proper DeclContext before substituting into an
Fri, Aug 23, 7:29 PM
aemerson committed rG3f6dd0c58872: [GlobalISel] Introduce a G_DYN_STACKALLOC opcode to represent dynamic allocas. (authored by aemerson).
[GlobalISel] Introduce a G_DYN_STACKALLOC opcode to represent dynamic allocas.
Fri, Aug 23, 7:28 PM
aemerson committed rL369833: [GlobalISel] Introduce a G_DYN_STACKALLOC opcode to represent dynamic allocas..
[GlobalISel] Introduce a G_DYN_STACKALLOC opcode to represent dynamic allocas.
Fri, Aug 23, 7:28 PM
aemerson closed D66677: [GlobalISel] Introduce a G_DYN_STACKALLOC opcode to represent dynamic allocas.
Fri, Aug 23, 7:28 PM · Restricted Project
vitalybuka added a parent revision for D66697: hwasan, codegen: Keep more lifetime markers used for hwasan: D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan.
Fri, Aug 23, 7:18 PM · Restricted Project