Page MenuHomePhabricator

Recent Activity

Today

cjdb added a comment to D106703: [libunwind] adds a way to synthesise libgcc.

Oh, wait, I am missing something: you're installing a symlink, and dlopen determines whether a shared library is the same based on inode, not the path. So I guess this works out in its current form.

Err, no, that's not right; the CMake steps in the patch create a symlink in the build directory, then install() copies the whole library to the install directory, so it isn't symlinked anymore.

Fri, Jul 23, 7:34 PM · Restricted Project, Restricted Project
mehdi_amini added inline comments to D106508: Optionally eliminate blocking runtime.await calls by converting functions to coroutines..
Fri, Jul 23, 7:29 PM · Restricted Project
rnk added inline comments to D106585: Fix clang debug info irgen of i128 enums.
Fri, Jul 23, 7:28 PM · Restricted Project, Restricted Project
Quuxplusone updated the diff for D106735: [libc++] Fix signed overflow inside ranges::advance..

whoops, didn't commit --amend before diffing

Fri, Jul 23, 7:21 PM · Restricted Project
Quuxplusone requested review of D106735: [libc++] Fix signed overflow inside ranges::advance..
Fri, Jul 23, 7:20 PM · Restricted Project
nathanchance added a comment to D104581: [RISCV] Add DAG combine to detect opportunities to replace (i64 (any_extend (i32 X)) with sign_extend..

This patch causes an infinite loop while compiling the RISC-V Linux kernel's allmodconfig target. A simplified reproducer:

Fri, Jul 23, 7:18 PM · Restricted Project
MaskRay accepted D106585: Fix clang debug info irgen of i128 enums.
Fri, Jul 23, 7:12 PM · Restricted Project, Restricted Project
efriedma added a comment to D106703: [libunwind] adds a way to synthesise libgcc.

I'd rather not be in a situation where a program built with a normal production toolchain appears to work, but then randomly crashes because the unwinder clashes with libgcc. Unless Chrome OS actually refuses to load binaries built with a normal Linux toolchain, we should ensure those binaries work.

Yes, Chrome OS actually requires compiling everything using the Chrome OS toolchain/SDK. Using binaries built using any other toolchain or Linux distros is not allowed so we are mostly fine in this regard.

Fri, Jul 23, 6:55 PM · Restricted Project, Restricted Project
t-tye updated the diff for D106339: Add support to generate Sphinx DOCX documentation.

Split change for clang makefile to elimnate Sphinx warnings of missing .rst fies when building man pages into D106734.

Fri, Jul 23, 6:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye requested review of D106734: Eliminate clang man page generation warning for missing .rst files.
Fri, Jul 23, 6:51 PM · Restricted Project, Restricted Project
klausler committed rG4d42e16eb8f7: [flang] runtime: fix problems with I/O around EOF & delimited characters (authored by klausler).
[flang] runtime: fix problems with I/O around EOF & delimited characters
Fri, Jul 23, 6:48 PM
klausler closed D106695: [flang] runtime: fix problems with I/O around EOF & delimited characters.
Fri, Jul 23, 6:48 PM · Restricted Project, Restricted Project
thakis added a comment to D106733: [clang/darwin] Pass libclang_rt.profile last on linker command.

Whoops, I'm so used to sending lld changes that I put the wrong reviewers and subscribers at first. Fixed now.

Fri, Jul 23, 6:27 PM
thakis edited reviewers for D106733: [clang/darwin] Pass libclang_rt.profile last on linker command, added: ributzka, vsk; removed: Restricted Project.
Fri, Jul 23, 6:27 PM
thakis requested review of D106733: [clang/darwin] Pass libclang_rt.profile last on linker command.
Fri, Jul 23, 6:26 PM
klausler updated the diff for D106727: [flang] Produce proper "preprocessor output" for -E option.

Update code to match commit comments.

Fri, Jul 23, 6:26 PM · Restricted Project
manojgupta added a comment to D106703: [libunwind] adds a way to synthesise libgcc.

I'd rather not be in a situation where a program built with a normal production toolchain appears to work, but then randomly crashes because the unwinder clashes with libgcc. Unless Chrome OS actually refuses to load binaries built with a normal Linux toolchain, we should ensure those binaries work.

Fri, Jul 23, 6:25 PM · Restricted Project, Restricted Project
klausler committed rGe093cbb7ae14: [flang] Runtime: Reset list-directed input state for each NAMELIST item (authored by klausler).
[flang] Runtime: Reset list-directed input state for each NAMELIST item
Fri, Jul 23, 6:22 PM
klausler closed D106694: [flang] Runtime: Reset list-directed input state for each NAMELIST item.
Fri, Jul 23, 6:21 PM · Restricted Project, Restricted Project
yinghuitan added inline comments to D105166: Fix expression evaluation result expansion in lldb-vscode.
Fri, Jul 23, 6:18 PM · Restricted Project
tianshilei1992 updated the summary of D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1.
Fri, Jul 23, 6:12 PM · Restricted Project
tianshilei1992 updated the summary of D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1.
Fri, Jul 23, 6:11 PM · Restricted Project
tianshilei1992 updated the summary of D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1.
Fri, Jul 23, 6:09 PM · Restricted Project
clayborg requested changes to D106553: [LLDB][GUI] Resolve paths in file/directory fields.
Fri, Jul 23, 6:06 PM · Restricted Project
beanz requested review of D106732: Support macro deprecation #pragma clang deprecated.
Fri, Jul 23, 6:03 PM · Restricted Project
clayborg committed rG80ac12b70b16: [LLDB][GUI] Check fields validity in actions (authored by OmarEmaraDev).
[LLDB][GUI] Check fields validity in actions
Fri, Jul 23, 6:03 PM
clayborg closed D106459: [LLDB][GUI] Check fields validity in actions.
Fri, Jul 23, 6:03 PM · Restricted Project
clayborg accepted D106459: [LLDB][GUI] Check fields validity in actions.
Fri, Jul 23, 6:03 PM · Restricted Project
clayborg committed rGe160b3987e73: [LLDB][GUI] Add Platform Plugin Field (authored by OmarEmaraDev).
[LLDB][GUI] Add Platform Plugin Field
Fri, Jul 23, 6:00 PM
clayborg closed D106483: [LLDB][GUI] Add Platform Plugin Field.
Fri, Jul 23, 6:00 PM · Restricted Project
clayborg accepted D106483: [LLDB][GUI] Add Platform Plugin Field.
Fri, Jul 23, 5:59 PM · Restricted Project
ABataev accepted D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1.

LG

Fri, Jul 23, 5:58 PM · Restricted Project
bakhtiyarneyman requested review of D106731: Refactor AsyncToAsyncRuntime pass to boost understandability..
Fri, Jul 23, 5:56 PM · Restricted Project
bakhtiyarneyman requested review of D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..
Fri, Jul 23, 5:55 PM · Restricted Project
Walter Erquinigo <wallace@fb.com> committed rGef8c6849a235: [source maps] fix source mapping when there are multiple matching rules (authored by Walter Erquinigo <wallace@fb.com>).
[source maps] fix source mapping when there are multiple matching rules
Fri, Jul 23, 5:53 PM
Walter Erquinigo <wallace@fb.com> closed D106723: [source maps] fix source mapping when there are multiple matching rules.
Fri, Jul 23, 5:53 PM · Restricted Project
wallace updated the diff for D106723: [source maps] fix source mapping when there are multiple matching rules.

last nit

Fri, Jul 23, 5:52 PM · Restricted Project
wallace added a reviewer for D106723: [source maps] fix source mapping when there are multiple matching rules: aprantl.
Fri, Jul 23, 5:51 PM · Restricted Project
clayborg accepted D106723: [source maps] fix source mapping when there are multiple matching rules.
Fri, Jul 23, 5:50 PM · Restricted Project
t-tye added a reviewer for D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer: efriedma.
Fri, Jul 23, 5:49 PM · Restricted Project