Page MenuHomePhabricator

Recent Activity

Today

tschuett added a comment to D151739: [flang] Fix interpretations of x87 80-bit Inf/NaN.

There is again no context. Do you want support such an old compute facility or just say no we don't support x87? 80 bits is a precise indicator for x87?

Tue, May 30, 11:10 AM · Restricted Project, Restricted Project
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rG520362b28db5: [gn build] Port 06ff9770477d (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port 06ff9770477d
Tue, May 30, 11:08 AM · Restricted Project, Restricted Project
yronglin retitled D151629: [libc++][ranges] Implement P2494R2 (Relaxing range adaptors to allow for move only types) from [libc++] Implement P2494R2 (Relaxing range adaptors to allow for move only types) to [libc++][ranges] Implement P2494R2 (Relaxing range adaptors to allow for move only types).
Tue, May 30, 11:07 AM · Restricted Project, Restricted Project
klausler updated the diff for D150159: [flang] CUDA Fortran - part 1/5: parsing.

Rebase to current llvm-project/main in preparation for merging.

Tue, May 30, 11:06 AM · Restricted Project, Restricted Project
MatzeB added a comment to D151276: Weaken MFI Max Call Frame Size Assertion.

In this case AdjustsStack on line 352 should be initialized to false and MFI.adjustsStack() == AdjustsStack should also be removed making this assertion kind of useless.

If @MatzeB is happy with this, I'm too.

Tue, May 30, 11:05 AM · Restricted Project, Restricted Project
hliao updated the diff for D151602: [TableGen] Add !getdagarg and !getdagname.

More tests

Tue, May 30, 11:04 AM · Restricted Project, Restricted Project
SlaterLatiao updated the summary of D151575: [clang][diagnostics] Always show include stacks on errors.
Tue, May 30, 11:03 AM · Restricted Project, Restricted Project
klausler requested review of D151739: [flang] Fix interpretations of x87 80-bit Inf/NaN.
Tue, May 30, 11:03 AM · Restricted Project, Restricted Project
dang committed rG06ff9770477d: [clang][ExtractAPI] Refactor serializer to the CRTP (authored by evelez7).
[clang][ExtractAPI] Refactor serializer to the CRTP
Tue, May 30, 11:02 AM · Restricted Project, Restricted Project
dang closed D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.
Tue, May 30, 11:02 AM · Restricted Project, Restricted Project
jhuber6 added a comment to D151735: [libc] Implement basic `malloc` and `free` support on the GPU.

IIRC it is CUDA 11.2.

Tue, May 30, 11:02 AM · Restricted Project, Restricted Project
SlaterLatiao updated the diff for D151575: [clang][diagnostics] Always show include stacks on errors.
  • Added release note.
Tue, May 30, 11:01 AM · Restricted Project, Restricted Project
mysterymath updated the diff for D150987: [llvm-nm] Add --line-numbers flag.

Fix test on Windows.

Tue, May 30, 10:59 AM · Restricted Project, Restricted Project
cjdb added a comment to D151575: [clang][diagnostics] Always show include stacks on errors.

Thanks for working on this. Would you mind adding more context to the commit description please?

Tue, May 30, 10:59 AM · Restricted Project, Restricted Project
aeubanks added inline comments to D146776: [llvm] Preliminary fat-lto-objects support.
Tue, May 30, 10:59 AM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D151735: [libc] Implement basic `malloc` and `free` support on the GPU.

CUDA's async malloc is really a new thing. It's gonna depend on what version of CUDA we are supporting here.

Do you know which version it was introduced in? It would probably explain why I couldn't built it on the only system I have access to with an Nvidia GPU since it runs CUDA 10.0.

Tue, May 30, 10:58 AM · Restricted Project, Restricted Project
MaskRay committed rGbd9940a809e3: [Driver][test] Properly test -mdefault-visibility-export-mapping= (authored by MaskRay).
[Driver][test] Properly test -mdefault-visibility-export-mapping=
Tue, May 30, 10:58 AM · Restricted Project, Restricted Project
jsjodin added inline comments to D147172: [OpenMP][Flang][MLIR] Add lowering of TargetOp for host codegen.
Tue, May 30, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
mizvekov accepted D150212: [clang][Sema] Improve diagnostics for auto return type.

LGTM

Tue, May 30, 10:58 AM · Restricted Project
klausler requested review of D151738: [flang] Detect output field width overflow for Inf/NaN.
Tue, May 30, 10:57 AM · Restricted Project, Restricted Project
jhuber6 added a comment to D151735: [libc] Implement basic `malloc` and `free` support on the GPU.

CUDA's async malloc is really a new thing. It's gonna depend on what version of CUDA we are supporting here.

Tue, May 30, 10:56 AM · Restricted Project, Restricted Project
klausler requested review of D151737: [flang] Don't fold SIZE()/SHAPE() into expression referencing optional dummy arguments.
Tue, May 30, 10:55 AM · Restricted Project, Restricted Project
mehdi_amini added a comment to D151670: Fix crash in X86 ISelLowering: ConstantDataSequential can contain float as well.

Here is the bug: https://github.com/llvm/llvm-project/issues/63017
I extracted the IR from the JIT test so you don't have to build MLIR (and bugpointed it) :)

Tue, May 30, 10:55 AM · Restricted Project, Restricted Project
MatsPetersson committed rGb75f9ce3fe86: [FLANG] Support all arrays for LoopVersioning (authored by MatsPetersson).
[FLANG] Support all arrays for LoopVersioning
Tue, May 30, 10:55 AM · Restricted Project, Restricted Project
rastogishubham updated the diff for D151579: Fix -u option in dsymutil, to not emit an extra DW_LNE_set_address if the original line table was empty.

clear the line table rows, if the update flag is set, and the line table just has a DW_LNE_end_sequence in DWARFLinker.cpp

Tue, May 30, 10:55 AM · Restricted Project, Restricted Project, debug-info
MatsPetersson closed D151140: [FLANG] Support all arrays for LoopVersioning.
Tue, May 30, 10:54 AM · Restricted Project, Restricted Project
reames committed rGb07d08bb8590: [RISCV] Add additional vslide1up test coverage (authored by reames).
[RISCV] Add additional vslide1up test coverage
Tue, May 30, 10:54 AM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D151735: [libc] Implement basic `malloc` and `free` support on the GPU.

CUDA's async malloc is really a new thing. It's gonna depend on what version of CUDA we are supporting here.

Tue, May 30, 10:54 AM · Restricted Project, Restricted Project
aeubanks added a comment to D144660: [compiler-rt][CMake] Properly set COMPILER_RT_HAS_LLD.

ping

Tue, May 30, 10:54 AM · Restricted Project, Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D151290: [scudo] Release pages of larger block more frequently.

Fix typo

Tue, May 30, 10:50 AM · Restricted Project, Restricted Project
bulbazord added a comment to D151353: [DebugInfo] Add error-handling to DWARFAbbreviationDeclarationSet.

Ok, the pre-submission checks failing are actually due to this change. Specifically, parsing the debug_abbrev section of the objects produced by these tests leads to an infinite loop. It goes as follows:

  • We fail to get an ULEB128 value for the code because the contents of the debug_abbrev are invalid. The DataExtractor thus returns 0, signaling to the DWARFAbbreviationDeclaration parsing code that were done with this DWARFAbbreviationDeclaration.
  • The DWARFAbbreviationDeclarationSet sees it's done and returns an empty Set to the DWARFDebugAbbrev parsing code. The offset is still at 0, so it's still technically a valid offset for the DataExtractor. So we continue on...
Tue, May 30, 10:49 AM · debug-info, Restricted Project, Restricted Project
JDevlieghere accepted D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions.

LGTM

Tue, May 30, 10:49 AM · Restricted Project, Restricted Project
PiotrZSL committed rG6219b7c61a94: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines (authored by denizevrenci).
[clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines
Tue, May 30, 10:49 AM · Restricted Project, Restricted Project, Restricted Project
PiotrZSL closed D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines.
Tue, May 30, 10:48 AM · Restricted Project, Restricted Project, Restricted Project
JDevlieghere accepted D151598: Small typo in the instruction comments of WithColor header.

Thank you, LGTM! Please let me know if you need someone to land this for you.

Tue, May 30, 10:48 AM · Restricted Project, Restricted Project
JDevlieghere accepted D151353: [DebugInfo] Add error-handling to DWARFAbbreviationDeclarationSet.
Tue, May 30, 10:47 AM · debug-info, Restricted Project, Restricted Project
tra committed rG6cdc07a701ee: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h (authored by tra).
[CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h
Tue, May 30, 10:46 AM · Restricted Project, Restricted Project
JDevlieghere accepted D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix.

LGTM

Tue, May 30, 10:45 AM · Restricted Project, Restricted Project
tra closed D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h.
Tue, May 30, 10:45 AM · Restricted Project, Restricted Project
barannikov88 added a comment to D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8].

ping

Tue, May 30, 10:43 AM · Restricted Project, Restricted Project, Restricted Project