Page MenuHomePhabricator

Recent Activity

Today

arthur.j.odwyer committed rG2f16b87b4b1d: [libc++] Remove space-alignment of trailing braces in module.modulemap. NFC. (authored by arthur.j.odwyer).
[libc++] Remove space-alignment of trailing braces in module.modulemap. NFC.
Sun, Dec 5, 4:00 PM
Quuxplusone requested changes to D115125: [libc++] Avoid rejection sampling in `uniform_int_distribution` if possible.

My initial reaction is that this change slows down the common case to cater to a really super pathological case; I don't think we should do it (but a benchmark could probably change my mind).
The new test needs to move from libcxx/test/std to libcxx/test/libcxx if it's testing non-mandated, libcxx-specific behavior.

Sun, Dec 5, 3:49 PM · Restricted Project
overdrivenpotato updated the diff for D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.

Fixed requested nits

Sun, Dec 5, 3:44 PM · Restricted Project
Jaysonyan updated the diff for D114225: Add JSONScopedPrinter to llvm-readelf.

Add pretty-print test.

Sun, Dec 5, 3:13 PM · Restricted Project
thakis added a comment to D115049: Fall back on Android triple w/o API level for runtimes search.

Looks like this breaks tests on Windows: https://buildkite.com/llvm-project/premerge-checks/builds/68330#746376c2-ce48-4ffc-b60f-515619dee28c

Sun, Dec 5, 3:04 PM · Restricted Project
atanasyan accepted D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.

LGTM with some nits.

Sun, Dec 5, 2:57 PM · Restricted Project
Jaysonyan updated the diff for D114225: Add JSONScopedPrinter to llvm-readelf.

Add JSON FileSummary tests.
Add pretty-print option to llvm-readelf.

Sun, Dec 5, 2:50 PM · Restricted Project
fhahn accepted D108763: Use type sizes when determining dependence.

LGTM with additional comments for the tests addressed. Please also add something like [LAA] to the beginning of the title, so it is easier to categorise the change when reading the commit log.

Sun, Dec 5, 2:30 PM · Restricted Project
overdrivenpotato requested review of D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.
Sun, Dec 5, 2:24 PM · Restricted Project
owenpan accepted D114583: [clang-format] Adjust braced list detection.
Sun, Dec 5, 2:10 PM · Restricted Project, Restricted Project
nealsid retitled D115126: [LLDB] Add unit tests for Editline keyboard shortcuts from [LLDB} Add unit tests for Editline keyboard shortcuts to [LLDB] Add unit tests for Editline keyboard shortcuts.
Sun, Dec 5, 2:08 PM · Restricted Project
nealsid requested review of D115126: [LLDB] Add unit tests for Editline keyboard shortcuts.
Sun, Dec 5, 2:08 PM · Restricted Project
rjmccall added a comment to D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks.

That's not an unreasonable idea, and we did consider it, and in fact it's still on the table as something we could do. However, it's a significantly more complex change, and we're not committed to doing it, and so we wanted to at least put this warning in place to help people avoid a relatively common bug.

Sun, Dec 5, 1:53 PM
CJ-Johnson added inline comments to D115121: Add support for return values in bugprone-stringview-nullptr.
Sun, Dec 5, 1:49 PM · Restricted Project
CJ-Johnson updated the summary of D115121: Add support for return values in bugprone-stringview-nullptr.
Sun, Dec 5, 1:48 PM · Restricted Project
CJ-Johnson added inline comments to D115121: Add support for return values in bugprone-stringview-nullptr.
Sun, Dec 5, 1:46 PM · Restricted Project
CJ-Johnson updated the diff for D115121: Add support for return values in bugprone-stringview-nullptr.

Add missing tests for function arguments and fix incorrect warning message for static_cast cases

Sun, Dec 5, 1:45 PM · Restricted Project
fwolff requested review of D115125: [libc++] Avoid rejection sampling in `uniform_int_distribution` if possible.
Sun, Dec 5, 1:41 PM · Restricted Project
hero2002 abandoned D115117: Update KaleidoscopeJIT.h.
Sun, Dec 5, 1:41 PM · Restricted Project
ekieri added a comment to D113086: [flang] Add a semantics test for co_reduce.

Thanks for addressing my comments! I noted an oversight inline, and wonder about the intended test coverage, otherwise this looks good I think.

Sun, Dec 5, 1:18 PM · Restricted Project, Restricted Project
hero2002 changed the visibility for D115117: Update KaleidoscopeJIT.h.
Sun, Dec 5, 1:03 PM · Restricted Project
hero2002 updated the summary of D115117: Update KaleidoscopeJIT.h.
Sun, Dec 5, 1:00 PM · Restricted Project
jackoalan committed rGf108c7f59dfa: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues. (authored by jackoalan).
[GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Sun, Dec 5, 12:57 PM
jackoalan closed D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Sun, Dec 5, 12:56 PM · Restricted Project
hero2002 changed the edit policy for D115117: Update KaleidoscopeJIT.h.
Sun, Dec 5, 12:54 PM · Restricted Project
hero2002 changed the visibility for D115117: Update KaleidoscopeJIT.h.
Sun, Dec 5, 12:54 PM · Restricted Project
hero2002 changed the visibility for D115117: Update KaleidoscopeJIT.h.
Sun, Dec 5, 12:53 PM · Restricted Project
fwolff requested review of D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers.
Sun, Dec 5, 12:41 PM · Restricted Project
salman-javed-nz added a comment to D115115: [doc] Fix namespace comment style in Coding Guidelines.

The ~6700 instances of // end namespace - do you observe any trend, e.g. are they concentrated in one of the LLVM sub-projects? Is it similar to the situation we have with the readability-identifier-naming check, where a number of sub-projects have disabled it in their sub-directory's .clang-tidy file?

Sun, Dec 5, 12:40 PM · Restricted Project
fhahn updated the diff for D113223: [VPlan] Add VPCanonicalIVRecipe, partly retire createInductionVariable (WIP)..

Rebased, fixed remaining test failures.

Sun, Dec 5, 12:36 PM · Restricted Project
hero2002 updated the diff for D115117: Update KaleidoscopeJIT.h.

fixed it not compiling due to a change in the lastest commits

Sun, Dec 5, 12:35 PM · Restricted Project
jrtc27 added a comment to D104830: AST: Create __va_list in the std namespace even in C..

Any luck with this?

Sun, Dec 5, 12:32 PM · Restricted Project
fhahn requested review of D115123: [VPlan] Add Debugloc to VPInstruction (NFC)..
Sun, Dec 5, 12:30 PM · Restricted Project
int3 committed rG1b4436471498: [lld-macho] Unreferenced weak dylib symbols shouldn't fetch archive symbols (authored by int3).
[lld-macho] Unreferenced weak dylib symbols shouldn't fetch archive symbols
Sun, Dec 5, 12:12 PM
int3 closed D115092: [lld-macho] Unreferenced weak dylib symbols shouldn't fetch archive symbols.
Sun, Dec 5, 12:12 PM · Restricted Project, Restricted Project
hero2002 updated the diff for D115117: Update KaleidoscopeJIT.h.

another formatting fix

Sun, Dec 5, 12:10 PM · Restricted Project
Quuxplusone requested review of D115122: [libc++] [ranges] Implement views::take, views::drop, ranges::equal. [WIP, needs tests].
Sun, Dec 5, 12:06 PM · Restricted Project
hero2002 updated the diff for D115117: Update KaleidoscopeJIT.h.

fixed problems with formatting

Sun, Dec 5, 12:03 PM · Restricted Project
jackoalan committed rGb66339575a9b: [CMake] Installable find modules for terminfo and libffi (authored by jackoalan).
[CMake] Installable find modules for terminfo and libffi
Sun, Dec 5, 11:48 AM
jackoalan closed D114327: [CMake] Installable find modules for terminfo and libffi.
Sun, Dec 5, 11:48 AM · Restricted Project