Today

myatsina added a comment to D35816: [Greedy RegAlloc] Add logic to greedy reg alloc to avoid bad eviction chains.

Have you had a chance to look at it yet?

Wed, Aug 23, 6:30 AM
grimar added a comment to D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript..

I was wrong, if all inputs are BC and we have foo = 1 script then I do not see it in output and link succeeds.
I'll take a look closer on this case.

Wed, Aug 23, 6:30 AM
lebedev.ri added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 23, 6:30 AM
nandini12396 updated the diff for D36402: [Polly][WIP] Introduce metadata for splitting of scop statement..
Wed, Aug 23, 6:25 AM · Restricted Project
lebedev.ri added a comment to D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons.

Please add the following test: (and make sure that it does the right thing :))

bool f_with_preproc_condition() {
  auto test = 42;
  assert(test == 42);
  return test;
}

I.e. if -DNDEBUG is present, variable is not needed, but if -DNDEBUG is *NOT* present...

Shouldn't we ignore these cases whether or not -DNDEBUG is present?

That's *exactly* what i was talking about.

Wed, Aug 23, 6:22 AM · Restricted Project
nandini12396 updated the diff for D36402: [Polly][WIP] Introduce metadata for splitting of scop statement..

Addressed @Meinersbur's comments.

Wed, Aug 23, 6:21 AM · Restricted Project
JonasToth added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 23, 6:20 AM
JonasToth updated the diff for D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
  • remove duplicated release note
Wed, Aug 23, 6:19 AM
grimar added a comment to D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript..

What happens if foo is specified in the linker script but actually doesn't appear in any bitcode file?
IIRC we should error in that case.

Wed, Aug 23, 6:18 AM
asl accepted D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets.

Given that this is regression from 3.9 and it's release-critical, I'd would suggest to commit it now. After all, the patch was in review for more than a week.

Wed, Aug 23, 6:15 AM
grimar added a comment to D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript..
Wed, Aug 23, 6:15 AM
davide added a comment to D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript..

What happens if foo is specified in the linker script but actually doesn't appear in any bitcode file?
IIRC we should error in that case.

Wed, Aug 23, 6:09 AM
danielmarjamaki added a comment to D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width.

ping

Wed, Aug 23, 6:09 AM
Meinersbur committed rL311550: [ScopInliner] Fix hidden overload warning. NFC..
[ScopInliner] Fix hidden overload warning. NFC.
Wed, Aug 23, 6:08 AM
Siddharth created D37061: [Polly] Third Updated translating the function Scop::foldSizeConstantsToRight() to isl C++.
Wed, Aug 23, 6:08 AM
tbourvon added a comment to D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons.

Please add the following test: (and make sure that it does the right thing :))

bool f_with_preproc_condition() {
  auto test = 42;
  assert(test == 42);
  return test;
}

I.e. if -DNDEBUG is present, variable is not needed, but if -DNDEBUG is *NOT* present...

Wed, Aug 23, 6:07 AM · Restricted Project
ncharlie updated the diff for D36311: [ThinLTO] Add GraphTraits for FunctionSummaries.

Updated according to comments
Added test.

Wed, Aug 23, 6:07 AM
grimar added a comment to D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript..

Looks phab ate my first reply. Duplicating again for history:

Wed, Aug 23, 6:07 AM
grimar added a comment to D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript..

Out of curiosity, where did you hit this?

Wed, Aug 23, 6:04 AM
Meinersbur committed rL311549: [MaximumStaticExpansion] Avoid warning in release builds..
[MaximumStaticExpansion] Avoid warning in release builds.
Wed, Aug 23, 5:54 AM
asb added a comment to D33574: PPC: Verify that branch fixups fit within the range..

I think that the test here is: is this something that a user could hit, (including with inline assembly, etc.), or does this indicate an internal problem only? For internal errors, we have lots of checks that we optimize out for release builds (and there's always the option of building release+asserts, and I deploy those builds on more experimental platforms as a general rule). If it is something that a user could hit, then it should be an error that the user will always get.

Wed, Aug 23, 5:54 AM
emankov added a comment to D36877: [Support][CommandLine] Add cl::Option::setDefault().
Wed, Aug 23, 5:54 AM
Meinersbur committed rL311548: [PPCGCodeGen] Fix compiler warning: '<': signed/unsigned mismatch. NFC..
[PPCGCodeGen] Fix compiler warning: '<': signed/unsigned mismatch. NFC.
Wed, Aug 23, 5:46 AM
davide added a comment to D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript..

Out of curiosity, where did you hit this?
Is there any way to test that the assignment updates the value of foo to be 1 ?

Wed, Aug 23, 5:43 AM
dylanmckay updated the summary of D37057: [clang] Require address space to be specified when creating functions (4/4).
Wed, Aug 23, 5:40 AM
dylanmckay updated the summary of D37054: Require address space to be specified when creating functions (3/4).
Wed, Aug 23, 5:40 AM
dylanmckay updated the summary of D37053: Insert switch tables into the program memory address space (2/4).
Wed, Aug 23, 5:40 AM
dylanmckay updated the summary of D37052: Add default address space for functions to the data layout (1/4).
Wed, Aug 23, 5:40 AM
dylanmckay updated the summary of D37052: Add default address space for functions to the data layout (1/4).
Wed, Aug 23, 5:39 AM
dylanmckay updated the diff for D37052: Add default address space for functions to the data layout (1/4).

Uploaded the wrong diff, here's the right one

Wed, Aug 23, 5:39 AM
dylanmckay updated the diff for D37052: Add default address space for functions to the data layout (1/4).

Add tests

Wed, Aug 23, 5:39 AM
Meinersbur committed rL311547: [ScopInfo] Remove stray semicolon. NFC..
[ScopInfo] Remove stray semicolon. NFC.
Wed, Aug 23, 5:36 AM
emankov updated the diff for D36877: [Support][CommandLine] Add cl::Option::setDefault().

formatting

Wed, Aug 23, 5:36 AM
dylanmckay updated the diff for D37054: Require address space to be specified when creating functions (3/4).

Don't check address space when looking up global values by name

Wed, Aug 23, 5:33 AM
hfinkel added a comment to D33574: PPC: Verify that branch fixups fit within the range..
In D33574#849770, @asb wrote:

Hi folks, I think llvm_unreachable is really the wrong error handling strategy here. It _won't_ necessarily cause the process to exit on a release build. This is actually one of the cases where it is possible to report a nice error without too much hassle. In rL299529 I added an MCContext parameter to MCAsmBackend::applyFixup in order to make it easy to use MCContext::reportError for effort reporting in helper functions like adjustFixupValue. Due to later upstream changes, you now get hold of your MCContext via the MCAssembler argument. You can see an example of this approach in action in D23568.

Wed, Aug 23, 5:29 AM
bollu updated the diff for D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
  • [Test] upadte tests to refect state of exp, powi in PPCGCodeGen
Wed, Aug 23, 5:21 AM
lebedev.ri added inline comments to D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better.
Wed, Aug 23, 5:20 AM
JonasToth updated the diff for D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
  • test case fixed expected warning
  • address review comments from aaron
Wed, Aug 23, 5:19 AM
JonasToth added a comment to D36354: [clang-tidy] Implement type-based check for `gsl::owner`.
Wed, Aug 23, 5:18 AM
dsanders committed rL311546: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.
[globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm
Wed, Aug 23, 5:16 AM