Page MenuHomePhabricator

Today

lewis-revill updated the diff for D54295: [WIP, RISCV] Add inline asm constraint A for RISC-V.

Correct test.

Tue, Feb 19, 2:55 AM · Restricted Project, Restricted Project
lewis-revill updated the diff for D54093: [RISCV] Lower inline asm constraints I, J & K for RISC-V.

Don't use zero register for 'J' constraint.

Tue, Feb 19, 2:55 AM · Restricted Project
Anastasia added inline comments to D58346: [Sema] Change addr space diagnostics in casts to follow C++ style.
Tue, Feb 19, 2:55 AM
krytarowski added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Tue, Feb 19, 2:47 AM · Restricted Project, Restricted Project
atanasyan committed rGfae2a509fa5a: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps (authored by atanasyan).
[MIPS] Handle cross-mode (regular <-> microMIPS) jumps
Tue, Feb 19, 2:39 AM
atanasyan committed rLLD354311: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
[MIPS] Handle cross-mode (regular <-> microMIPS) jumps
Tue, Feb 19, 2:38 AM
atanasyan committed rL354311: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
[MIPS] Handle cross-mode (regular <-> microMIPS) jumps
Tue, Feb 19, 2:37 AM
atanasyan closed D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.
Tue, Feb 19, 2:36 AM · Restricted Project, lld
markus added inline comments to D56587: Introduce DW_OP_LLVM_convert.
Tue, Feb 19, 2:30 AM · debug-info
rovka committed rG19dbc6245fd9: [ARM GlobalISel] Support G_PHI for Thumb2 (authored by rovka).
[ARM GlobalISel] Support G_PHI for Thumb2
Tue, Feb 19, 2:27 AM
rovka committed rL354310: [ARM GlobalISel] Support G_PHI for Thumb2.
[ARM GlobalISel] Support G_PHI for Thumb2
Tue, Feb 19, 2:27 AM
evgeny777 added a comment to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

--adjust-start causes an underflow. I think this should be an error.

Tue, Feb 19, 2:27 AM
evgeny777 updated the diff for D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Addressed

Tue, Feb 19, 2:27 AM
evgeny777 added a comment to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

I don't personally have a use case for this, but I could imagine a program with multiple possible start locations, and these switches allow switching between them. I'd like to here the concrete use case though.

Tue, Feb 19, 2:23 AM
baloghadamsoftware added a reviewer for D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept: baloghadamsoftware.
Tue, Feb 19, 2:23 AM · Restricted Project, Restricted Project
RKSimon added a comment to D57375: X86AsmParser AVX-512: Return error instead of hitting assert.

@craig.topper Any comments?

Tue, Feb 19, 2:20 AM · Restricted Project
baloghadamsoftware accepted D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

It's for D57108, i'we guessed that such ternary answer will be required there.

Tue, Feb 19, 2:20 AM · Restricted Project
jhenderson added inline comments to D58280: [yaml2obj][obj2yaml] - Support SHT_GNU_versym (.gnu.version) section..
Tue, Feb 19, 2:17 AM
Herald added a project to D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept: Restricted Project.
Tue, Feb 19, 2:17 AM · Restricted Project, Restricted Project
lebedev.ri accepted D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

Sorry for the reviews, i'm really stalling it seems..

Tue, Feb 19, 2:16 AM · Restricted Project
jhenderson accepted D58119: [obj2yaml][yaml2obj] - Add support of parsing/dumping of the .gnu.version_r section..

LGTM.

Tue, Feb 19, 2:15 AM
grimar added inline comments to D58280: [yaml2obj][obj2yaml] - Support SHT_GNU_versym (.gnu.version) section..
Tue, Feb 19, 2:15 AM
jhenderson accepted D58280: [yaml2obj][obj2yaml] - Support SHT_GNU_versym (.gnu.version) section..

LGTM, with two small comments.

Tue, Feb 19, 2:08 AM
grimar added inline comments to D58119: [obj2yaml][yaml2obj] - Add support of parsing/dumping of the .gnu.version_r section..
Tue, Feb 19, 2:06 AM
grimar updated the diff for D58119: [obj2yaml][yaml2obj] - Add support of parsing/dumping of the .gnu.version_r section..
  • Addressed review comments.
Tue, Feb 19, 2:06 AM
jhenderson accepted D58168: [yaml2obj] - Do not ignore explicit addresses for .dynsym and .dynstr.

LGTM.

Tue, Feb 19, 2:04 AM
MaskRay added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Tue, Feb 19, 2:04 AM · Restricted Project, Restricted Project
baloghadamsoftware added a comment to D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer.

If I understand it correctly, this is more of an infrastructure improvement than check enhancement. It looks like a nice and clean code. Where do we expect to use this new behavior? In the current check or in the upcoming "modernize" check?

Tue, Feb 19, 2:04 AM · Restricted Project
jhenderson accepted D58174: [yaml2obj] - Do not skip zeroes blocks if there are relocations against them..

LGTM.

Tue, Feb 19, 1:56 AM
jhenderson added inline comments to D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options..
Tue, Feb 19, 1:54 AM · Restricted Project
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • guard with NetBSD
Tue, Feb 19, 1:52 AM · Restricted Project, Restricted Project
courbet added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Tue, Feb 19, 1:45 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

<strings.h> should be included unconditionally.

Tue, Feb 19, 1:44 AM · Restricted Project, Restricted Project
BrandonTJones added a comment to D57375: X86AsmParser AVX-512: Return error instead of hitting assert.

ping

Tue, Feb 19, 1:44 AM · Restricted Project
courbet added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

Please enable the tests for NetBSD as well.

<strings.h> should be included unconditionally.

Tue, Feb 19, 1:39 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D58119: [obj2yaml][yaml2obj] - Add support of parsing/dumping of the .gnu.version_r section..
Tue, Feb 19, 1:39 AM
krytarowski added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Tue, Feb 19, 1:38 AM · Restricted Project, Restricted Project
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • Unconditionally test bcmp() in weak_hook_test
Tue, Feb 19, 1:38 AM · Restricted Project, Restricted Project
markus added inline comments to D56587: Introduce DW_OP_LLVM_convert.
Tue, Feb 19, 1:38 AM · debug-info
jhenderson added a comment to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
  1. What's the use case for this?
  2. What's the interaction for program headers?

    For relocatable files I'd expect addresses to be ignored and for program headers I'd like to put more thought into this. In general, I'd like to take a stance that we not implement flags that we don't have a use case for.
Tue, Feb 19, 1:38 AM