Today

scott.linder updated the diff for D53445: [AMDGPU] Update code object metadata format documentation.

Update note type value

Tue, Oct 23, 7:08 AM
scott.linder added a comment to D53445: [AMDGPU] Update code object metadata format documentation.

In v2 asm, we had the following:

.option.machine_version_major
.option.machine_version_minor
.option.machine_version_stepping

What are the equivalents for v3 asm? The updates you made do not seem to describe those... Unless I missed it.

Tue, Oct 23, 7:07 AM
ldionne accepted D53486: [libcxx] Only define __libcpp_is_floating_point<_Float16> for Clang.

Thinking about this more, I'm fine with either this patch or one that does not define __libcpp_is_floating_point<_Float16> at all. This patch provides the best level of support that we seem to be able to provide, but is inconsistent across compilers and does not follow the standard perfectly. Not providing the definition at all decreases the level of support but increases consistency and simplicity. I'm fine with either.

Tue, Oct 23, 7:06 AM
john.brawn added inline comments to D52653: [CodeGen, AArch64] Combine Interleaved Loads which are not covered by the Vectorizer.
Tue, Oct 23, 7:00 AM
thegameg added inline comments to D53333: [SystemZ] Make sure that SystemZAddressingMode::dump() does not crash..
Tue, Oct 23, 7:00 AM
kadircet updated the diff for D53192: [clangd] Do not query index for new name completions..
  • Address comments.
Tue, Oct 23, 6:58 AM
grimar added a comment to D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists).

Ping.

Tue, Oct 23, 6:58 AM
MTC added inline comments to D53543: [analyzer] MallocChecker: pr39348: Realize that sized delete isn't a custom delete..
Tue, Oct 23, 6:53 AM
kadircet committed rC345029: [clang] Fix a null pointer dereference..
[clang] Fix a null pointer dereference.
Tue, Oct 23, 6:51 AM
kadircet committed rL345029: [clang] Fix a null pointer dereference..
[clang] Fix a null pointer dereference.
Tue, Oct 23, 6:51 AM
kadircet closed D53561: [clang] Fix a null pointer dereference..
Tue, Oct 23, 6:51 AM
sammccall created D53571: [clangd] Don't show base class versions of members as completions..
Tue, Oct 23, 6:51 AM
spatel committed rL345028: [SLSR] auto-generate full test assertions; NFC.
[SLSR] auto-generate full test assertions; NFC
Tue, Oct 23, 6:42 AM
kadircet updated the diff for D53191: [clang] Introduce new completion context types.
  • Add comments.
Tue, Oct 23, 6:38 AM
AlexeySachkov updated the diff for D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types.

Rebase to the ToT

Tue, Oct 23, 6:38 AM
RKSimon created D53570: [TTI] Add generic SK_Broadcast shuffle costs.
Tue, Oct 23, 6:36 AM
kadircet added a comment to D53191: [clang] Introduce new completion context types.

There are still some contexts where both a new name and an existing name is permissible, going to add a comment on those to leave some traces for the next person who cares

Tue, Oct 23, 6:31 AM
eklepilkina added a dependency for D53568: [LNT] Setting CMake variable to support test-suite feature from D53565 : D53565: Configure only needed part of test-suite during running subtests.
Tue, Oct 23, 6:31 AM
eklepilkina added a dependent revision for D53565: Configure only needed part of test-suite during running subtests: D53568: [LNT] Setting CMake variable to support test-suite feature from D53565 .
Tue, Oct 23, 6:31 AM
kadircet retitled D53191: [clang] Introduce new completion context types from [clang] Use Statement and Namespace instead of Name and PotentiallyQualifiedName to [clang] Introduce new completion context types.
Tue, Oct 23, 6:30 AM
fedor.sergeev added inline comments to D53414: Add instructions for migrating branches from one git repository to another..
Tue, Oct 23, 6:29 AM
kadircet updated the diff for D53191: [clang] Introduce new completion context types.
  • Use new types
  • Rebase
Tue, Oct 23, 6:28 AM
SquallATF created D53569: [MinGW] Enable large file for mingw-w64.
Tue, Oct 23, 6:28 AM
kadircet updated the diff for D53192: [clangd] Do not query index for new name completions..
  • Rebase and take in new changes.
Tue, Oct 23, 6:27 AM
eklepilkina created D53568: [LNT] Setting CMake variable to support test-suite feature from D53565 .
Tue, Oct 23, 6:27 AM
SquallATF created D53567: [Support] Enable color diagnostics for mintty.
Tue, Oct 23, 6:23 AM
lebedevri committed rL345027: Experimental re-land of [X86][BMI1] X86DAGToDAGISel: select BEXTR from x << (32….
Experimental re-land of [X86][BMI1] X86DAGToDAGISel: select BEXTR from x << (32…
Tue, Oct 23, 6:21 AM
Diffusion closed D53521: [X86][BMI1] X86DAGToDAGISel: select BEXTR from x << (32 - y) >> (32 - y) pattern.
Tue, Oct 23, 6:21 AM
hans committed rL345026: Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix….
Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix…
Tue, Oct 23, 6:19 AM
hans committed rC345026: Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix….
Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix…
Tue, Oct 23, 6:19 AM
jhenderson updated the diff for D53509: Fix llvm-strings crash for negative char values.

Add quotes to echo string in test.

Tue, Oct 23, 6:17 AM
RKSimon committed rL345025: Add BROADCAST shuffle cost tests..
Add BROADCAST shuffle cost tests.
Tue, Oct 23, 6:17 AM
sammccall committed rCTE345024: [clangd] Remove caching of compilation database commands..
[clangd] Remove caching of compilation database commands.
Tue, Oct 23, 6:16 AM
sammccall committed rL345024: [clangd] Remove caching of compilation database commands..
[clangd] Remove caching of compilation database commands.
Tue, Oct 23, 6:16 AM
sammccall closed D53439: [clangd] Remove caching of compilation database commands..
Tue, Oct 23, 6:16 AM
philip.pfaffe accepted D53376: Fix generation of exported targets in build directory.

LGTM, thanks!

Tue, Oct 23, 6:15 AM
aleksandr.urakov added a reviewer for D53506: [ClangASTContext] Extract VTable pointers from C++ objects: zturner.

So, the point is, just because we don't have access to the info via DIA doesn't mean we won't have access to the info once the native pdb plugin is complete. Just something to think about.

Tue, Oct 23, 6:12 AM · Restricted Project
aaron.ballman added a comment to D52857: [clang-query] Add non-exclusive output API.

I prefer the API from Peter. I think it's a good additional step from where Aaron and I reached in IRC discussion (this patch currently).

I can change the patch to use that later if you agree Aaron?

Tue, Oct 23, 6:11 AM
hokein added a comment to D53488: [clang-tidy] Catching narrowing from double to float..

Could you also update the check documentation clang-tidy/checks/cppcoreguidelines-narrowing-conversions.rst?

Tue, Oct 23, 6:07 AM · Restricted Project
DennisL created D53566: Fix warning: extra ‘;’ [-Wpedantic].
Tue, Oct 23, 6:06 AM