Today

sthibaul added a comment to D54379: Add Hurd toolchain support to Clang.

In general when structuring your code, the performance penalty for other targets when the conditions that can be easily tested are not met should pretty much be close to nonexistent. I would suggest keeping that in mind when submitting revisions.

Sat, Nov 17, 11:07 AM
ctopper committed rL347143: [X86] Add support for matching PACKUSWB from a v64i8 shuffle..
[X86] Add support for matching PACKUSWB from a v64i8 shuffle.
Sat, Nov 17, 10:58 AM
ctopper committed rL347142: [X86] Add test case to show missed opportunity to use PACKUSWB in v64i8 shuffle….
[X86] Add test case to show missed opportunity to use PACKUSWB in v64i8 shuffle…
Sat, Nov 17, 10:58 AM
sthibaul added inline comments to D54379: Add Hurd toolchain support to Clang.
Sat, Nov 17, 10:57 AM
dblaikie committed rC347141: Sink BuryPointer from Clang into LLVM for reuse there.
Sink BuryPointer from Clang into LLVM for reuse there
Sat, Nov 17, 10:07 AM
dblaikie committed rL347141: Sink BuryPointer from Clang into LLVM for reuse there.
Sink BuryPointer from Clang into LLVM for reuse there
Sat, Nov 17, 10:07 AM
dblaikie committed rL347140: Move BuryPointer from Clang to LLVM for use in other LLVM tools.
Move BuryPointer from Clang to LLVM for use in other LLVM tools
Sat, Nov 17, 10:06 AM
sbc100 accepted D54662: [WebAssembly] Add equality comparison operators for WasmEventType.
Sat, Nov 17, 10:03 AM
zturner updated the diff for D54667: [CodeView] Emit proper debug info for ref-qualified member functions.

Uploaded the wrong patch last time. This time I actually have the change for marking the pointers const.

Sat, Nov 17, 9:57 AM
zturner updated the diff for D54667: [CodeView] Emit proper debug info for ref-qualified member functions.

In my original output, you could still see one bit different on our this pointer records and MSVC's. Specifically, they mark them as const. I went ahead and did the same thing in this update.

Sat, Nov 17, 9:55 AM
Quuxplusone added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Sat, Nov 17, 9:51 AM · Restricted Project
aaron.ballman added a comment to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.

@aaron.ballman I don't actually have the commit bit, can you commit this, or are we waiting for further review?

Sat, Nov 17, 9:31 AM · Restricted Project
dvyukov added inline comments to D54664: [tsan] Add __cxa_guard_acquire hooks to support cooperative scheduling.
Sat, Nov 17, 9:29 AM
dvyukov added inline comments to D54664: [tsan] Add __cxa_guard_acquire hooks to support cooperative scheduling.
Sat, Nov 17, 9:28 AM
zturner created D54667: [CodeView] Emit proper debug info for ref-qualified member functions.
Sat, Nov 17, 8:57 AM
calixte updated the diff for D54599: [Profile] Avoid race condition when dumping GCDA files..
  • Update code to take into account what's wrong when fd==-1
  • Add a test for GCOV_PREFIX
Sat, Nov 17, 8:52 AM
nagisa added inline comments to D54666: [InstCombine] Simplify funnel shifts based on demanded bits.
Sat, Nov 17, 8:18 AM
krytarowski accepted D54339: Fix threads detection on GNU/Hurd.
Sat, Nov 17, 8:07 AM
sthibaul added reviewers for D54339: Fix threads detection on GNU/Hurd: ldionne, mclow.lists.
Sat, Nov 17, 7:53 AM
joerg added a comment to D54657: [clang] Add -MJJ for appending to compilation databases..

I don't understand the point here. Why would you want to include pre-processing-only commands in the compilation database?

Sat, Nov 17, 7:09 AM
nikic created D54666: [InstCombine] Simplify funnel shifts based on demanded bits.
Sat, Nov 17, 6:38 AM
RKSimon committed rL347139: [X86][SSE] Add shuffle demanded elts test case for PR39549.
[X86][SSE] Add shuffle demanded elts test case for PR39549
Sat, Nov 17, 6:08 AM
xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Addressed comments, fixed tests

Sat, Nov 17, 5:30 AM
krytarowski added a comment to D54664: [tsan] Add __cxa_guard_acquire hooks to support cooperative scheduling.

Is this Linux-only?

Sat, Nov 17, 5:23 AM
brunoricci committed rC347138: [AST][NFC] Pack CXXDefaultInitExpr.
[AST][NFC] Pack CXXDefaultInitExpr
Sat, Nov 17, 5:05 AM
brunoricci committed rL347138: [AST][NFC] Pack CXXDefaultInitExpr.
[AST][NFC] Pack CXXDefaultInitExpr
Sat, Nov 17, 5:05 AM
brunoricci committed rC347137: [AST][NFC] Pack CXXDefaultArgExpr.
[AST][NFC] Pack CXXDefaultArgExpr
Sat, Nov 17, 4:59 AM
brunoricci committed rL347137: [AST][NFC] Pack CXXDefaultArgExpr.
[AST][NFC] Pack CXXDefaultArgExpr
Sat, Nov 17, 4:59 AM
brunoricci committed rL347136: [AST][NFC] Pack CXXThrowExpr.
[AST][NFC] Pack CXXThrowExpr
Sat, Nov 17, 4:56 AM
brunoricci committed rC347136: [AST][NFC] Pack CXXThrowExpr.
[AST][NFC] Pack CXXThrowExpr
Sat, Nov 17, 4:56 AM
calixte abandoned D54213: [Profile] Mark gcov-fork test as failinf for i386 target.
Sat, Nov 17, 3:52 AM
Higuoxing added a comment to D54665: [llvm-objdump] Print a blank row at the end of sections.

I'm implementing the Version Reference for #30241 and find that some info emitted from option -x are crowded. If this not ok, I will revert this change.

Sat, Nov 17, 3:35 AM
xazax.hun added a comment to D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals..
In D54557#1300654, @NoQ wrote:

It would be great to have a way to extend the list of (possibly non-stl) types to check. But I do understand that the analyzer does not have a great way to set such configuration options right now.

Do you envision room for another attribute here? I.e., a class attribute that says "this object is always unsafe to use after move, unless a method annotated with reinitializes is called"?

Sat, Nov 17, 2:31 AM
RKSimon added a comment to D54658: [X86] Add an AND with 255 to the v16i8 LowerMUL path with AVX2, but not AVX512.

It looks OK, but wouldn't we be better off trying to improve the truncation lowering?

Sat, Nov 17, 1:29 AM
krisb updated the diff for D54623: [MSP430] Optimize srl/sra in case of A >> (8 + N).

Applied comments and extended condition with 'ShiftAmount == 8'

Sat, Nov 17, 1:28 AM
Higuoxing committed rL347135: [llvm-objdump] Print a blank row at the end of sections.
[llvm-objdump] Print a blank row at the end of sections
Sat, Nov 17, 12:15 AM
Higuoxing closed D54665: [llvm-objdump] Print a blank row at the end of sections.
Sat, Nov 17, 12:15 AM
Higuoxing accepted D54665: [llvm-objdump] Print a blank row at the end of sections.
Sat, Nov 17, 12:14 AM
Higuoxing created D54665: [llvm-objdump] Print a blank row at the end of sections.
Sat, Nov 17, 12:14 AM

Yesterday

MTC added a comment to D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit..

The "moved-from" terminology we adopt here still feels a bit weird to me, but i don't have a better suggestion, so i just removed the single-quotes so that to at least feel proud about what we have.

I am personally fine with this terminology, this checker corresponds to the cert rule EXP63-CPP. Do not rely on the value of a moved-from object, and moved from is also used in many places in CppCoreGuidelines.

Fri, Nov 16, 11:44 PM