Page MenuHomePhabricator

Recent Activity

Today

pifon2a added a comment to D135348: [mlir] Simplify DestinationStyleOpInterface..

Yep, OperandRange does not, but OpOperandVector does and it is used for DPS interface right now.

why is that needed ? Why cant you have an interface method that is just OpOperandVector getOutputOperands().

I was trying to avoid copying the OpOperands* all the time. In the pack/unpack ops, we can also move destination args to the and of the arg list. On the other hand, the same would need to be done for the already existing tensor.insert_slice. Which is also possible, but probably painful.

If we have $inits not at a fixed position, we have to construct SmallVector<OpOperand*> every time we call getOutputOperands. Also, does it mean that getNumOutputs would need to be expressed as getOutputOperands().size()? Would it make sense to have an interface method std::pair<unsigned, unsigned> getOutputsPositionsRange or smth like that that would return the interval of positions in the operand list that correspond to outputs? In that case, the users would need to override only this method.

@mravishankar

Yeah having an getOutputsPositionRange would work. AFAIK OperandRange doesnt own its data. The OpOperands are owned by the operation.

Fri, Oct 7, 12:22 PM · Restricted Project, Restricted Project
jcranmer-intel accepted D134369: [Clang] Support constexpr builtin fmax.
Fri, Oct 7, 12:21 PM · Restricted Project, Restricted Project
aaron.ballman accepted D135370: Narrow inline namespace filtration for unqualified friend declarations.

LGTM! Should we also add a release note or do we think this isn't enough of a compile-time performance improvement to warrant that?

Fri, Oct 7, 12:20 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D135433: [clang][Interp] Implement while and do-while loops.
Fri, Oct 7, 12:17 PM · Restricted Project, Restricted Project
fhahn added a reverting change for rG92f698f01fa0: Revert "[SCEV] Support clearing Block/LoopDispositions for a single value.": rG19ad1cd5cea1: Recommit "[SCEV] Support clearing Block/LoopDispositions for a single value.".
Fri, Oct 7, 12:16 PM · Restricted Project, Restricted Project
fhahn committed rG19ad1cd5cea1: Recommit "[SCEV] Support clearing Block/LoopDispositions for a single value." (authored by fhahn).
Recommit "[SCEV] Support clearing Block/LoopDispositions for a single value."
Fri, Oct 7, 12:16 PM · Restricted Project, Restricted Project
bixia added a reviewer for D135480: [mlir][sparse] Add MLIR interface for sparse tensor file input and output.: wrengr.
Fri, Oct 7, 12:15 PM · Restricted Project, Restricted Project
bixia updated the diff for D135480: [mlir][sparse] Add MLIR interface for sparse tensor file input and output..

Format the test.

Fri, Oct 7, 12:14 PM · Restricted Project, Restricted Project
mravishankar added a comment to D135348: [mlir] Simplify DestinationStyleOpInterface..

why is that needed ? Why cant you have an interface method that is just OpOperandVector getOutputOperands().

I was trying to avoid copying the OpOperands* all the time. In the pack/unpack ops, we can also move destination args to the and of the arg list. On the other hand, the same would need to be done for the already existing tensor.insert_slice. Which is also possible, but probably painful.

If we have $inits not at a fixed position, we have to construct SmallVector<OpOperand*> every time we call getOutputOperands. Also, does it mean that getNumOutputs would need to be expressed as getOutputOperands().size()? Would it make sense to have an interface method std::pair<unsigned, unsigned> getOutputsPositionsRange or smth like that that would return the interval of positions in the operand list that correspond to outputs? In that case, the users would need to override only this method.

@mravishankar

Fri, Oct 7, 12:11 PM · Restricted Project, Restricted Project
bixia requested review of D135480: [mlir][sparse] Add MLIR interface for sparse tensor file input and output..
Fri, Oct 7, 12:09 PM · Restricted Project, Restricted Project
antiagainst added a reviewer for D135479: [mlir][arith] Expose dedicated API for expanding ceil/floor division: kuhar.
Fri, Oct 7, 12:09 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D135479: [mlir][arith] Expose dedicated API for expanding ceil/floor division.

Fix comments

Fri, Oct 7, 12:09 PM · Restricted Project, Restricted Project
Izaron updated the diff for D134369: [Clang] Support constexpr builtin fmax.

Add TODO comment about sNaN. Thanks to @jcranmer-intel!

Fri, Oct 7, 12:08 PM · Restricted Project, Restricted Project
antiagainst requested review of D135479: [mlir][arith] Expose dedicated API for expanding ceil/floor division.
Fri, Oct 7, 12:08 PM · Restricted Project, Restricted Project
arichardson planned changes to D134282: [CGP] Add generic TargetLowering::shouldAlignPointerArgs() implementation.
Fri, Oct 7, 12:08 PM · Restricted Project, Restricted Project
Joe_Nash added a reviewer for D135478: [AMDGPU] Make V_SAT_PK_U8_I16 a True16 Instruction: arsenm.
Fri, Oct 7, 12:08 PM · Restricted Project, Restricted Project
Joe_Nash added a comment to D135478: [AMDGPU] Make V_SAT_PK_U8_I16 a True16 Instruction.

It's not clear to me if this instruction was ever selected. I don't see any ISel pattern or reference in tablegen or c++. In the synthesized tablgen defs, I see list<dag> Pattern = [(set i32:$vdst, (null_frag (i32 (VOP3Mods0 i32:$src0))))]; which I think doesn't get used because of the null_frag? Anyway, if it is being selected, do I need to update the pattern for the type change?

Fri, Oct 7, 12:08 PM · Restricted Project, Restricted Project
pifon2a added a comment to D135348: [mlir] Simplify DestinationStyleOpInterface..

OperandRange does not own the data, does it? I was trying to avoid constructing SmallVector every time.

Fri, Oct 7, 12:06 PM · Restricted Project, Restricted Project
Joe_Nash requested review of D135478: [AMDGPU] Make V_SAT_PK_U8_I16 a True16 Instruction.
Fri, Oct 7, 12:06 PM · Restricted Project, Restricted Project
ormris committed rGfe50eac85c06: [llvm-reduce] Fix di-metadata pass test failures (authored by ormris).
[llvm-reduce] Fix di-metadata pass test failures
Fri, Oct 7, 12:05 PM · Restricted Project, Restricted Project
ormris closed D135473: [llvm-reduce] Fix di-metadata pass test failures.
Fri, Oct 7, 12:05 PM · Restricted Project, Restricted Project
efriedma added a comment to D135441: [AArch64][SelectionDAG] Lower multiplication by a constant to shl+add+shl+add.

This is getting into the territory of actually being slower than a "mul", depending on the latency of "mul" and "add-with-shift" on the target CPU... we probably need CPU-specific modeling if you want to go this direction.

Fri, Oct 7, 12:05 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`.
Fri, Oct 7, 12:03 PM · Restricted Project, Restricted Project
aaron.ballman updated the diff for D134813: Properly print unnamed TagDecl objects in diagnostics.

Fixes the failing AST unit test in Clang found by precommit CI.

Fri, Oct 7, 12:03 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
fhahn committed rGec86e9a99bca: [LoopUnroll] Add test for crash exposed by 9e931439. (authored by fhahn).
[LoopUnroll] Add test for crash exposed by 9e931439.
Fri, Oct 7, 12:03 PM · Restricted Project, Restricted Project
Izaron updated the diff for D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`.

Fixes https://github.com/llvm/llvm-project/issues/58230

Fri, Oct 7, 12:03 PM · Restricted Project, Restricted Project
bixia added a reviewer for D135477: [mlir][sparse] Rename SparseTensorFile to SparseTensorReader.: wrengr.
Fri, Oct 7, 12:03 PM · Restricted Project, Restricted Project
bixia requested review of D135477: [mlir][sparse] Rename SparseTensorFile to SparseTensorReader..
Fri, Oct 7, 12:02 PM · Restricted Project, Restricted Project
Izaron requested review of D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`.
Fri, Oct 7, 12:01 PM · Restricted Project, Restricted Project
pifon2a added a comment to D135348: [mlir] Simplify DestinationStyleOpInterface..

why is that needed ? Why cant you have an interface method that is just OpOperandVector getOutputOperands().

Fri, Oct 7, 12:00 PM · Restricted Project, Restricted Project
maksfb requested review of D135475: [BOLT][TEST] Fix section order test.
Fri, Oct 7, 11:59 AM · Restricted Project, Restricted Project
jcranmer-intel added inline comments to D134369: [Clang] Support constexpr builtin fmax.
Fri, Oct 7, 11:57 AM · Restricted Project, Restricted Project
ormris added a comment to D135473: [llvm-reduce] Fix di-metadata pass test failures.

Thanks for the review @aeubanks!

Fri, Oct 7, 11:57 AM · Restricted Project, Restricted Project
aeubanks committed rG37122c722bae: [opt] Remove -passes=asan-pipeline (authored by aeubanks).
[opt] Remove -passes=asan-pipeline
Fri, Oct 7, 11:56 AM · Restricted Project, Restricted Project
lahwaacz added inline comments to D135466: [clang-format] Add support to remove unnecessary semicolons after function definition .
Fri, Oct 7, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
aeubanks accepted D135473: [llvm-reduce] Fix di-metadata pass test failures.
Fri, Oct 7, 11:54 AM · Restricted Project, Restricted Project
reames accepted D135418: [VP][RISCV] Add vp.smax/smin/umax/umin intrinsics.

LGTM

Fri, Oct 7, 11:54 AM · Restricted Project, Restricted Project
reames committed rGcb66e123c6bc: Remove PlaceSafepoints pass (authored by reames).
Remove PlaceSafepoints pass
Fri, Oct 7, 11:51 AM · Restricted Project, Restricted Project
reames closed D135371: Remove PlaceSafepoints pass.
Fri, Oct 7, 11:51 AM · Restricted Project, Restricted Project
aeubanks committed rGd3d84654467e: [opt] Stop treating alias analysis specially when translating legacy opt syntax (authored by aeubanks).
[opt] Stop treating alias analysis specially when translating legacy opt syntax
Fri, Oct 7, 11:51 AM · Restricted Project, Restricted Project