In D50703#1205109, @kbobyrev wrote:In D50703#1205049, @malaperle wrote:I hadn't marked it as done because without symbols in main files I found it quite lacking.
Ah, I see, thank you for spotting it! I was under the impression that it's feature-complete. Should I mark it "Partial" until this is fixed then?
- rC Clang
- 73,956 Commits
- ·
- Restricted Project
- Restricted Project
- Fri, Aug 17, 8:22 PM
- Subversion
- rLLDB LLDB
- Fri, Aug 17, 5:33 PM
- Subversion
- rCTE Clang Tools Extra
- 3,592 Commits
- ·
- Restricted Project
- Restricted Project
- Restricted Project
- Fri, Aug 17, 12:50 PM
- Subversion
Today
Today
malaperle added a comment to D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation.
Sat, Aug 18, 10:17 AM · Restricted Project
JDevlieghere accepted D50639: Change how finalizeBundle selects debug location for the BUNDLE instruction.
This LGTM!
[X86] Merge shift/rotate schedule class instregexs
xbolva00 added a reviewer for D50039: [LibCalls] Added nonnull atribute to libc function args: rsmith.
Sat, Aug 18, 8:36 AM · Restricted Project
[DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI.
ABataev updated subscribers of D50939: [WIP][OpenMP] Propagate 'declare target' information to device.
D38798 does not work correctly and there is no stable Sema-based solution to do this absolutely correctly. We need to adapt the codegen so that it emits metadata for the implicit declare target functions.
This doesn't work the way I hoped :-(
I'm pretty sure we don't want to do it like this. ASTContext was just the first data structure I found to be available during both Sema and CodeGen.
RKSimon added a comment to D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..
Thanks @craig.topper !
- Address CR comments - add FoundDecl tracking, instantiationdependent calculation, display non-constant expression diagnostic notes
JonasToth added a comment to D50883: [clang-tidy] Handle unique owning smart pointers in ExprMutationAnalyzer.
I see, thank you :)
kbobyrev added a comment to D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation.
In D50703#1205049, @malaperle wrote:I hadn't marked it as done because without symbols in main files I found it quite lacking.
Sat, Aug 18, 1:09 AM · Restricted Project
Yesterday
Yesterday
ctopper committed rL340121: [X86] Add a signed test case for PR38622. Use nounwind to reduce the output on….
[X86] Add a signed test case for PR38622. Use nounwind to reduce the output on…
ctopper committed rL340120: [DAGCombiner] Allow divide by constant optimization on opaque constants..
[DAGCombiner] Allow divide by constant optimization on opaque constants.
Rebase + fix conflicts for very old diff. Works again.
xbolva00 added inline comments to D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..
chandlerc accepted D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..
This time actually marking it as LGTM.
chandlerc added a comment to D50936: [DAGCombiner] Allow divide by constant optimization on opaque constants..
Nice! I like it when the fix is simple.
Revert "Add a basic integration test for C++ smart pointers"
Add the extended XMM registers mappings for AVX-512.
bruno committed rL340117: Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker".
Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"
bruno committed rC340117: Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker".
Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"
[ORC] Fix some parameter names. NFC.
[ORC] Rename 'finalize' to 'emit' to avoid potential confusion.
rsmith added a comment to D50875: Move lib/Demangle under lib/Support. No functionality change intended..
I'm putting this on hold for now.