Wrote a new per-function comment as suggested by Rui, hopefully explaining better what is done now.
Remove test code. Sorry for the noise.
Remove test code.
Merged the test input data into the test itself, as suggested by Rui.
Add STAGE2_ prefix to pass stage2 variables. Add ANDROID_RUNTIMES_BUILD_TYPE, ANDROID_RUNTIMES_ENABLE_ASSERTIONS, and ANDROID_BUILTINS_BUILD_TYPE.
Added checking of the IsResolved variable, as suggested by Rafael.
See D35700 where pr33784 is handled a bit differently.
Looks good! Thanks!
Please rebase with master before committing since we've been touching the same lines in UnwrappedLineParser.cpp.
LGTM. We recently encountered the "fixup out of range" for temporary symbols. We worked around this by turning off temporary symbols for COFF. Thanks for fixing this!
Ping 2 for reviews please!
Remove debug if condition.
Take into account remarks from Michael.
Updated based on feedback.
Weekly ping! (@rsmith)
@dsanders - the main goal was to avoid the compiler warning of having to create a zero sized array.