Today

davide committed rL318580: [ABI] Remove dead code that was copy-pasted all around. NFCI..
[ABI] Remove dead code that was copy-pasted all around. NFCI.
Fri, Nov 17, 4:54 PM
efriedma accepted D40130: [InstSimplify] fold and/or of fcmp ord/uno when operand is known nnan.

That said, this transform seems straightforward enough. LGTM.

Fri, Nov 17, 4:53 PM
rampitec added inline comments to D40113: AMDGPU: Fix crash when scheduling DBG_VALUE.
Fri, Nov 17, 4:52 PM
davide committed rL318579: [Module] Throw away some more commented code. NFCI..
[Module] Throw away some more commented code. NFCI.
Fri, Nov 17, 4:52 PM
efriedma added a comment to D40130: [InstSimplify] fold and/or of fcmp ord/uno when operand is known nnan.

From the perspective of canonicalization, it seems kind of weird to have "%x uno %y" rather than "(%x uno 0) | (%y uno 0)". I mean, the former is probably cheaper to lower, but it leads to a lot of special-case logic to handle the equivalency.

Fri, Nov 17, 4:49 PM
hans committed rL318578: Fix some -Wunused-variable warnings.
Fix some -Wunused-variable warnings
Fri, Nov 17, 4:49 PM
arsenm added inline comments to D39897: AMDGPU: Partial ILP scheduler port from SelectionDAG to SchedulingDAG (experimental).
Fri, Nov 17, 4:46 PM
arsenm added inline comments to D40113: AMDGPU: Fix crash when scheduling DBG_VALUE.
Fri, Nov 17, 4:45 PM
davide committed rL318577: [ABI/SysV] Remove more dead code. NFCI..
[ABI/SysV] Remove more dead code. NFCI.
Fri, Nov 17, 4:35 PM
davide committed rL318576: [Core] Garbage collect dead code untouched in years. NFCI..
[Core] Garbage collect dead code untouched in years. NFCI.
Fri, Nov 17, 4:34 PM
eugenis committed rL318575: Revert "[asan] Use dynamic shadow on 32-bit Android" and 3 more..
Revert "[asan] Use dynamic shadow on 32-bit Android" and 3 more.
Fri, Nov 17, 4:24 PM
juliehockett added a comment to D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy.
Fri, Nov 17, 4:18 PM · Restricted Project
juliehockett updated the diff for D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy.

Updated docs and added tests to check class methods.

Fri, Nov 17, 4:18 PM · Restricted Project
dsanders committed rL318574: [globalisel][tablegen] Generalize pointer-type inference by introducing ptypeN..
[globalisel][tablegen] Generalize pointer-type inference by introducing ptypeN.
Fri, Nov 17, 4:17 PM
smeenai added a comment to D40197: Merge .xdata into .rdata by default.

Ah all right, that makes sense then.

Fri, Nov 17, 4:04 PM
davide added a comment to D40177: performance improvements for ThunderX2 T99.

I'm under the impression this is not NFC.
Presumably, the changes in the scheduler reflect in a different schedule being produced.
You can then check the IR (or MIR) with the new schedule.
If you feel motivated, you can check the test before (standalone), so that the commit will highlight the differences pre/post & will make the changeset more readable.
If no change in the schedule is produced, I'm confused.

Fri, Nov 17, 4:01 PM
mcgrathr accepted D40201: [llvm-objcopy] Add --strip-all-gnu and change --strip-all.

LGTM. I wonder if it's really worth keeping --strip-non-alloc.

Fri, Nov 17, 4:01 PM
syzaara retitled D40196: Add hooks to MachineLICM to hoist invariant stores. from [PowerPC] Add hooks to MachineLICM to hoist invariant stores. to Add hooks to MachineLICM to hoist invariant stores..
Fri, Nov 17, 3:57 PM
rnk added a comment to D40197: Merge .xdata into .rdata by default.

What are the advantages to the section merging, apart from matching link's ouput? I personally prefer LLD keeping the separate sections, since it's easier to examine them that way.

Fri, Nov 17, 3:55 PM
eugenis committed rL318573: [asan] Fix asan_device_setup on KitKat..
[asan] Fix asan_device_setup on KitKat.
Fri, Nov 17, 3:52 PM
rnk committed rL318572: [lit] Try to improve Ctrl-C behavior on Windows.
[lit] Try to improve Ctrl-C behavior on Windows
Fri, Nov 17, 3:52 PM
phosek committed rL318571: [CMake][runtimes] Don't passthrough prefixes for non-default targets.
[CMake][runtimes] Don't passthrough prefixes for non-default targets
Fri, Nov 17, 3:52 PM
phosek closed D39988: [CMake][runtimes] Don't passthrough prefixes for non-default targets by committing rL318571: [CMake][runtimes] Don't passthrough prefixes for non-default targets.
Fri, Nov 17, 3:51 PM
phosek updated the diff for D39988: [CMake][runtimes] Don't passthrough prefixes for non-default targets.
Fri, Nov 17, 3:51 PM
smeenai added a comment to D40197: Merge .xdata into .rdata by default.

What are the advantages to the section merging, apart from matching link's ouput? I personally prefer LLD keeping the separate sections, since it's easier to examine them that way.

Fri, Nov 17, 3:48 PM
eugenezelenko committed rL318570: [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other….
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other…
Fri, Nov 17, 3:44 PM
probinson added a comment to D40199: llvm-dwarfdump --verify is incorrectly saying all DW_AT_location attributes with locations lists are invalid..

The FORM that's appropriate for DW_AT_location to use as a reference varies with the DWARF version. In v2 and v3, it's FORM_data4 or FORM_data8, in v4 it's FORM_sec_offset. I haven't looked at the verifier much but it seems like using the correct FORM is something that ought to be verifiable.

Fri, Nov 17, 3:36 PM · debug-info
aprantl added a comment to D40199: llvm-dwarfdump --verify is incorrectly saying all DW_AT_location attributes with locations lists are invalid..

Do you happen to have a minimal reproducer that we could check in as an assembler testcase?

Fri, Nov 17, 3:36 PM · debug-info
flowerhack retitled D38595: [fuchsia] Update Fuchsia with a new mmap implementation. from DO NOT MERGE, WIP: Update Fuchsia with new mmap API implementation. to [fuchsia] Update Fuchsia with a new mmap implementation..
Fri, Nov 17, 3:36 PM
flowerhack updated the diff for D38595: [fuchsia] Update Fuchsia with a new mmap implementation..

Real patch; updated with changes from patches 1-3, and ofc responded to initial comments/feedback.

Fri, Nov 17, 3:36 PM
phosek committed rL318569: [libunwind][CMake] Provide option to disable instalation of the library.
[libunwind][CMake] Provide option to disable instalation of the library
Fri, Nov 17, 3:29 PM
phosek closed D40195: [libunwind][CMake] Provide option to disable instalation of the library by committing rL318569: [libunwind][CMake] Provide option to disable instalation of the library.
Fri, Nov 17, 3:29 PM
jakehehrlich created D40201: [llvm-objcopy] Add --strip-all-gnu and change --strip-all.
Fri, Nov 17, 3:29 PM
phosek committed rL318568: [libcxxabi][CMake] Provide option to disable installing of the library.
[libcxxabi][CMake] Provide option to disable installing of the library
Fri, Nov 17, 3:26 PM
phosek closed D40194: [libcxxabi][CMake] Provide option to disable installing of the library by committing rL318568: [libcxxabi][CMake] Provide option to disable installing of the library.
Fri, Nov 17, 3:26 PM
zaks committed rL318567: Change code owner for Clang Static Analyzer to Devin Coughlin..
Change code owner for Clang Static Analyzer to Devin Coughlin.
Fri, Nov 17, 3:19 PM
Diffusion closed D39964: Change code owner for Clang Static Analyzer to Devin Coughlin. by committing rL318567: Change code owner for Clang Static Analyzer to Devin Coughlin..
Fri, Nov 17, 3:19 PM
rnk added a comment to D40197: Merge .xdata into .rdata by default.

Do you think we should merge .idata, .edata, and .didata into .rdata as well? That will be more involved than this.

Fri, Nov 17, 3:19 PM
probinson added a project to D40199: llvm-dwarfdump --verify is incorrectly saying all DW_AT_location attributes with locations lists are invalid.: debug-info.
Fri, Nov 17, 3:16 PM · debug-info
probinson added inline comments to D40199: llvm-dwarfdump --verify is incorrectly saying all DW_AT_location attributes with locations lists are invalid..
Fri, Nov 17, 3:15 PM · debug-info