Today

ruiu accepted D39172: [ELF] When placing orphans, handle case when last section is dead.

LGTM

Sun, Oct 22, 5:36 PM
ruiu added inline comments to D39139: LLD/ELF: Allow targets to set e_flags.
Sun, Oct 22, 5:31 PM
ruiu added inline comments to D39148: [COFF] Add support for /WX.
Sun, Oct 22, 5:15 PM
joerg added a comment to D38554: Fixed ppc32 function relocations in non-pic mode.

A working linker is certainly expected to use the most efficient binding. The assembler (and by extension the compiler) can't tell. This applies in both directions -- in your example, the linker might need to translate the direct call into a PLT call, depending on the target. It all goes back to "use a working linker". So yes, at this point in time the existance of two different relocations for call instructions can be clearly seen as a historic artifact. This doesn't change anything of what I have been saying since the beginning. The PowerPC ABIs are heavily biases towards position independent code and this is just adding complications for no good reason.

Sun, Oct 22, 5:11 PM
lichray updated the diff for D39162: [test] Fix clang-test for FreeBSD and NetBSD.

Changed to an warning given @zturner 's comments and experiments.

Sun, Oct 22, 5:11 PM
erichkeane added inline comments to D39127: Fix template parameter default args missed if redecled.
Sun, Oct 22, 5:08 PM
ruiu updated the diff for D38972: Add the /v option which prints out the LLD version string..

Instead of including version information to the --help message, add the --version option.

Sun, Oct 22, 5:05 PM
ruiu committed rL316306: Add R_PPC_ADDR16_HI relocation support.
Add R_PPC_ADDR16_HI relocation support
Sun, Oct 22, 4:34 PM
vit9696 added a comment to D38554: Fixed ppc32 function relocations in non-pic mode.

@joerg, this is nonsense in general, and possibly implementation dependent. A simple example as follows:

Sun, Oct 22, 4:08 PM
ruiu committed rL316305: Remove a fast lookup table from MergeInputSection..
Remove a fast lookup table from MergeInputSection.
Sun, Oct 22, 4:03 PM
faisalv committed rL316304: [c++2a] Update cxx_status w __VA_OPT__ marked as completed in SVN..
[c++2a] Update cxx_status w __VA_OPT__ marked as completed in SVN.
Sun, Oct 22, 3:30 PM
phosek updated the summary of D39172: [ELF] When placing orphans, handle case when last section is dead.
Sun, Oct 22, 3:16 PM
phosek created D39172: [ELF] When placing orphans, handle case when last section is dead.
Sun, Oct 22, 3:16 PM
mstorsjo added inline comments to D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64.
Sun, Oct 22, 2:32 PM
compnerd added inline comments to D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64.
Sun, Oct 22, 2:23 PM
krytarowski added a comment to D39162: [test] Fix clang-test for FreeBSD and NetBSD.

I think we should special case Darwin and Windows and fall-back to LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like platform left where it doesn't work.

SHLIB_PATH in HP/UX

Sun, Oct 22, 2:21 PM
joerg added a comment to D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.

I've looked at this in some detail now. I'm not exactly sure yet why it is broken. The patch seems quite wrong to me. DW_CFA_GNU_args_size should be applied only when unwinding a call instruction and that regard, the commit message of the original change is quite correct. What I am still trying to understand is how the precise unwind frame disagrees with the unwinder.

Sun, Oct 22, 2:18 PM
lichray updated the summary of D39162: [test] Fix clang-test for FreeBSD and NetBSD.
Sun, Oct 22, 2:16 PM
lichray updated the diff for D39162: [test] Fix clang-test for FreeBSD and NetBSD.
Sun, Oct 22, 2:15 PM
mareko created D39171: AMDGPU: Handle s_buffer_load_dword hazard on SI.
Sun, Oct 22, 2:13 PM
krytarowski added a comment to D39162: [test] Fix clang-test for FreeBSD and NetBSD.

I think we should special case Darwin and Windows and fall-back to LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like platform left where it doesn't work.

Sun, Oct 22, 2:13 PM
lichray added a comment to D39162: [test] Fix clang-test for FreeBSD and NetBSD.

I think we should special case Darwin and Windows and fall-back to LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like platform left where it doesn't work.

Sun, Oct 22, 2:06 PM
mstorsjo added a comment to D38513: [LLD] [RFC] [COFF] Add support for GNU binutils import libraries.

FWIW, I noticed this detail when linking to a GNU import library using link.exe; if linking with -verbose, link.exe prints a list of object files at the end:

Sun, Oct 22, 2:00 PM
joerg added a comment to D39162: [test] Fix clang-test for FreeBSD and NetBSD.

I think we should special case Darwin and Windows and fall-back to LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like platform left where it doesn't work.

Sun, Oct 22, 1:56 PM
lichray added a comment to D39162: [test] Fix clang-test for FreeBSD and NetBSD.

Please don't throw an exception here. Instead, write this as:

lit_config.warning('Unable to determine shared library path variable for platform {}'.format(platform.system()))
Sun, Oct 22, 1:56 PM
compnerd committed rL316303: ExecutionEngine: make COFF Thumb2 assertions non-tautological.
ExecutionEngine: make COFF Thumb2 assertions non-tautological
Sun, Oct 22, 1:52 PM
compnerd closed D39102: [ExecutionEngine] Adjust some COFF Thumb tautological asserts.

SVN r316303

Sun, Oct 22, 1:51 PM
zturner requested changes to D39162: [test] Fix clang-test for FreeBSD and NetBSD.

Please don't throw an exception here. Instead, write this as:

Sun, Oct 22, 1:51 PM
compnerd added inline comments to D39148: [COFF] Add support for /WX.
Sun, Oct 22, 1:49 PM
RKSimon abandoned D39134: [X86][SSE] Add MOVHPSrm to domain tables.

I'm going to abandon this and instead investigate adding custom domain switching (PR34873) - I'm concerned that MOVPS only references 64-bits on a load but PUNPCKLPD/PUNPCKLQDQ reference 128-bits.

Sun, Oct 22, 1:44 PM
ruiu accepted D39167: [LLD] [MinGW] Omit libc++/libc++abi/libunwind from autoexporting.

LGTM

Sun, Oct 22, 1:43 PM
mstorsjo created D39170: [LLD] [COFF] Fix exporting of functions starting with underscores, etc.
Sun, Oct 22, 1:41 PM
mstorsjo created D39168: [COFF] Improve the check for functions that should get an extra underscore.
Sun, Oct 22, 1:41 PM
RKSimon created D39169: [X86][SSE] Remove AssertZext stage from PEXTRW/PEXTRB lowering. NFCI..
Sun, Oct 22, 1:41 PM
faisalv added a comment to D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?.

Isn't it already an UB if someone set WillHaveBody and but later IsCopyDeductionCandidate being read, vice versa?

Sun, Oct 22, 1:38 PM ยท Restricted Project
krytarowski updated subscribers of D39162: [test] Fix clang-test for FreeBSD and NetBSD.
Sun, Oct 22, 1:31 PM
yuyichao committed rL316302: Fix invalid ptrtoint in InstCombine.
Fix invalid ptrtoint in InstCombine
Sun, Oct 22, 1:31 PM
yuyichao closed D34335: Fix invalid ptrtoint in InstCombine by committing rL316302: Fix invalid ptrtoint in InstCombine.
Sun, Oct 22, 1:31 PM
mstorsjo created D39167: [LLD] [MinGW] Omit libc++/libc++abi/libunwind from autoexporting.
Sun, Oct 22, 1:31 PM
joerg added a comment to D38554: Fixed ppc32 function relocations in non-pic mode.

There is no layer of indirection here. The call gets resolved to the local symbol by a working linker.

Sun, Oct 22, 1:31 PM