Today

ctopper committed rL325949: [X86] Add DAG combine to remove (and X, 1) from in front of a v1i1 scalar to….
[X86] Add DAG combine to remove (and X, 1) from in front of a v1i1 scalar to…
Fri, Feb 23, 12:16 PM
ruiu committed rLLD325948: Inline a trivial ctor..
Inline a trivial ctor.
Fri, Feb 23, 12:16 PM
ruiu committed rL325948: Inline a trivial ctor..
Inline a trivial ctor.
Fri, Feb 23, 12:16 PM
ruiu closed D43525: Inline a trivial ctor..
Fri, Feb 23, 12:16 PM
d0k committed rL325947: [WebAssembly] Fix macro metaprogram to not duplicate code as much..
[WebAssembly] Fix macro metaprogram to not duplicate code as much.
Fri, Feb 23, 12:16 PM
echristo committed rL325946: Because of CVE-2018-6574, some compiler options and linker options are….
Because of CVE-2018-6574, some compiler options and linker options are…
Fri, Feb 23, 12:15 PM
echristo added a comment to D43070: Add an instruction to avoid cgo compilation error from Go 1.9.4.

Committed thusly:

Fri, Feb 23, 12:15 PM
echristo closed D43070: Add an instruction to avoid cgo compilation error from Go 1.9.4.
Fri, Feb 23, 12:15 PM
phosek committed rC325945: [Driver] Make -fno-common default for Fuchsia.
[Driver] Make -fno-common default for Fuchsia
Fri, Feb 23, 12:12 PM
phosek committed rL325945: [Driver] Make -fno-common default for Fuchsia.
[Driver] Make -fno-common default for Fuchsia
Fri, Feb 23, 12:12 PM
phosek closed D43545: [Driver] Make -fno-common default for Fuchsia.
Fri, Feb 23, 12:12 PM
rob.lougher added a comment to D43643: [RFC] Sceptre a Spectre variant 1 detector.

This is cut and pasted from an email reply as it's not showing up after over 2 hours...

Fri, Feb 23, 12:10 PM
efriedma added a comment to D41949: [RISCV] implement li pseudo instruction.

Missing testcase for "li a0, foo".

Fri, Feb 23, 12:10 PM
ruiu added inline comments to D42176: [WebAssembly] Optimise relocation iteration to remove n^2 loop. NFC..
Fri, Feb 23, 12:10 PM
codeman.consulting accepted rL325924: [InstCombine] refactor fmul with negated op folds; NFCI.

I'm not seeing any problems with this.

Fri, Feb 23, 12:04 PM
hfinkel accepted D43677: [PowerPC] Disable shrink-wrapping when PC address is acquired through the link register.

LGTM

Fri, Feb 23, 12:03 PM
RKSimon committed rL325944: [X86][SSE] Generalize x > C-1 ? x+-C : 0 --> subus x, C combine for non-uniform….
[X86][SSE] Generalize x > C-1 ? x+-C : 0 --> subus x, C combine for non-uniform…
Fri, Feb 23, 12:03 PM
clayborg added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

If any of our lldb_private::Process subclasses handle this already, then we need a new virtual function on lldb_private::Process like:

Fri, Feb 23, 11:58 AM
clayborg added a comment to D39967: Disable breakpoints before writing memory and re-enable after..

So the question still remains: does this need to be done when debugging with debugserver or lldb-server? I can't remember if memory write works around breakpoint opcodes in debugserver and/or lldb-server. If it does, then this code is only needed for targets that don't work around software breakpoints.

Fri, Feb 23, 11:52 AM
lei added a comment to rL325888: [MIPS GlobalISel] Adding GlobalISel.

All good now. Thanks

Fri, Feb 23, 11:52 AM
weimingz added a comment to D41316: [libcxx] Allow random_device to be built optionally.

ping?

Fri, Feb 23, 11:48 AM
vsk accepted D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it.

I like that we can customize the command substitutions and the way we dump internal state in this test mode. This offers some added flexibility over the batch mode, IMO. LGTM, thanks!

Fri, Feb 23, 11:48 AM
tatyana-krasnukha updated the diff for D39967: Disable breakpoints before writing memory and re-enable after..

Change ForEach return type (bool -> void)

Fri, Feb 23, 11:48 AM
Hahnfeld added a comment to D41942: [OMPT] Add interoperability testcase.

This test doesn't work if threads are not scheduled as expected: http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/58
I think in that case a worker thread started before the second master which makes sense as there is no synchronization between the two initial threads. We should be able to fix this by either starting a serialized region or calling an API function and putting an OMPT_WAIT before the real parallel region. Thoughts?

Fri, Feb 23, 11:48 AM
amccarth added a comment to D43688: Partial fix for TestConflictingSymbol.py on Windows.

This test deliberately compiles without -g, so the variable should not be in the debug info.

Fri, Feb 23, 11:42 AM
rafael committed rL325943: Really fix test on windows..
Really fix test on windows.
Fri, Feb 23, 11:41 AM
rafael committed rC325943: Really fix test on windows..
Really fix test on windows.
Fri, Feb 23, 11:41 AM
rafael committed rL325942: Fix one last test on a windows host..
Fix one last test on a windows host.
Fri, Feb 23, 11:41 AM
rafael committed rC325942: Fix one last test on a windows host..
Fix one last test on a windows host.
Fri, Feb 23, 11:40 AM
d0k committed rL325941: Shrink various scheduling tables by using narrower types..
Shrink various scheduling tables by using narrower types.
Fri, Feb 23, 11:35 AM
probinson added a comment to D42765: [DebugInfo] Support DWARFv5 source code embedding extension.

It seems a little counter-intuitive for embedded source to have a filename, but I guess that's so the debugger has a familiar-looking handle to refer to it?

Fri, Feb 23, 11:34 AM
rafael committed rC325940: Bring r325915 back..
Bring r325915 back.
Fri, Feb 23, 11:33 AM
rafael committed rL325940: Bring r325915 back..
Bring r325915 back.
Fri, Feb 23, 11:33 AM
evandro committed rL325939: [PATCH] [AArch64] Add new target feature to fuse conditional select.
[PATCH] [AArch64] Add new target feature to fuse conditional select
Fri, Feb 23, 11:32 AM
evandro closed D42392: [AArch64] Add new target feature to fuse conditional select.
Fri, Feb 23, 11:32 AM
aaron.ballman added inline comments to D41880: Adding nocf_check attribute for cf-protection fine tuning .
Fri, Feb 23, 11:32 AM
labath added a comment to D43688: Partial fix for TestConflictingSymbol.py on Windows.

This test deliberately compiles without -g, so the variable should not be in the debug info. On non-windows systems we're expected to pick up the name from the symbol table. Is there such a thing on windows as well? Maybe you need to lookup the symbol as _conflicting_symbol ?

Fri, Feb 23, 11:32 AM
eugenis added a comment to D43669: [cfi] Lazy CFI initialization.

A constructor would also mitigate the dlopen issue (see the comment before the interceptor). Not that we've seen this issue in the wild.

Fri, Feb 23, 11:28 AM
eugenis added inline comments to D43669: [cfi] Lazy CFI initialization.
Fri, Feb 23, 11:28 AM
vsk updated the diff for D43662: [Utility] Simplify and generalize the CleanUp helper, NFC.

Thanks for the feedback.

Fri, Feb 23, 11:27 AM