Page MenuHomePhabricator

Recent Activity

Yesterday

NoQ added a comment to D130737: [analyzer] Process non-POD array element destructors.

Oh damn, I too forgot that they could be multi-dimensional. Nice!!

Sat, Aug 13, 11:52 PM · Restricted Project, Restricted Project
dcaballe added a comment to D130092: [mlir] Remove types from attributes.

I see your point. It makes sense to me. It looks like we had some code that was resilient to null types and I assumed operands should be converted to TypedAttr, which doesn't seem to be the case. Thanks for clarifying!

Sat, Aug 13, 11:50 PM · Restricted Project, Restricted Project
Herald added a reviewer for D130157: [mlir][OpenMP] Translation to LLVM IR for omp.taskgroup: dcaballe.

Ping for review.

Sat, Aug 13, 11:47 PM · Restricted Project, Restricted Project
craig.topper updated the diff for D130862: [LegalizeTypes][WIP] Improve splitting for urem/udiv by constant for some constants..

Rebase on new tests

Sat, Aug 13, 11:45 PM · Restricted Project, Restricted Project
craig.topper retitled D131442: [X86][RISCV] Pre-commit tests for D130862. NFC from [X86][RISCV][WIP] Pre-commit tests for D130862. NFC to [X86][RISCV] Pre-commit tests for D130862. NFC.
Sat, Aug 13, 11:44 PM · Restricted Project, Restricted Project
craig.topper updated the diff for D131442: [X86][RISCV] Pre-commit tests for D130862. NFC.

Add more tests.

Sat, Aug 13, 11:44 PM · Restricted Project, Restricted Project
dcaballe updated the diff for D131604: [mlir] Minor fixes after removing types from attributes.

Addressed feedback

Sat, Aug 13, 11:05 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D131045: [NFC][AArch64] Precommit test for a tablegen pattern for aarch64_neon_pmull64.

DO NOT SEND

Sat, Aug 13, 10:59 PM · Restricted Project, Restricted Project
MaskRay added a comment to D131808: [clang,flang] Add missing options fsyntax-only in help.

To be clear, some issues should be addressed before someone lands this.

Sat, Aug 13, 10:53 PM · Restricted Project, Restricted Project, Restricted Project
alexiprof added a comment to D131808: [clang,flang] Add missing options fsyntax-only in help.

I do not have commit access, i do not have merge :-(

Sat, Aug 13, 10:50 PM · Restricted Project, Restricted Project, Restricted Project
alexiprof updated the summary of D131808: [clang,flang] Add missing options fsyntax-only in help.
Sat, Aug 13, 10:37 PM · Restricted Project, Restricted Project, Restricted Project
alexiprof updated the summary of D131808: [clang,flang] Add missing options fsyntax-only in help.
Sat, Aug 13, 10:36 PM · Restricted Project, Restricted Project, Restricted Project
snowjon061996 updated snowjon061996.
Sat, Aug 13, 10:05 PM
MaskRay added a comment to D131808: [clang,flang] Add missing options fsyntax-only in help.

Use Fix https://github.com/llvm/llvm-project/issues/57033 or Fixes https://github.com/llvm/llvm-project/issues/57033 or (I usually prefer this for non-bugs but still some issues worth addressing) Close ..., then the issue will be automatically closed when you push the commit to origin/main

Sat, Aug 13, 9:34 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay accepted D131808: [clang,flang] Add missing options fsyntax-only in help.

Subject: [clang,flang] Add missing options fsyntax-only in help

Sat, Aug 13, 9:33 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added a comment to D128998: [libunwind] Handle G in personality string.

libunwind/src/libunwind_ext.h provides a bunch of API which are not implemented by https://github.com/libunwind/libunwind .
Before we settle on an API there, it's worth raising an issue on https://github.com/libunwind/libunwind and giving them some time for the API design.

Sat, Aug 13, 9:28 PM · Restricted Project, Restricted Project, Restricted Project
lhames accepted D131347: Set up basic infrastructure for ELF/i386 backend support in JITLink ..

@tschuett's suggestion is a good one.

Sat, Aug 13, 9:27 PM · Restricted Project, Restricted Project
jloser requested review of D131847: [llvm] Replace uses of llvm::Any with std::any.
Sat, Aug 13, 9:01 PM · Restricted Project, Restricted Project
lhames accepted D131831: [Orc] Use IntervalMap to store free memory regions in MapperJITLinkMemoryManager.

LGTM -- Thanks @argentite!

Sat, Aug 13, 8:40 PM · Restricted Project, Restricted Project
junaire added a comment to D130831: [CodeGen] Track DeferredDecls that have been emitted.

gentle ping :)

Sat, Aug 13, 7:56 PM · Restricted Project, Restricted Project
benshi001 accepted D131844: [AVR] Use @earlyclobber instead of register scavenging.

LGTM

Sat, Aug 13, 7:46 PM · Restricted Project, Restricted Project
loladiro requested review of D131846: [MSAN] Handle array alloca with non-i64 size specification.
Sat, Aug 13, 7:28 PM · Restricted Project, Restricted Project
benshi001 added a comment to D117426: [AVR] Only push and clear R1 in interrupts when necessary.

@avkevl, please commit this ASAP.

Sat, Aug 13, 7:23 PM · Restricted Project, Restricted Project
benshi001 added a comment to D128483: [AVR] Support unaligned store.

@avkevl, please commit this ASAP.

Sat, Aug 13, 7:23 PM · Restricted Project, Restricted Project
benshi001 committed rG2a4625530fb6: [NFC] Combine test cases of verifier (authored by Miss_Grape).
[NFC] Combine test cases of verifier
Sat, Aug 13, 7:19 PM · Restricted Project, Restricted Project
benshi001 closed D126443: [NFC] Modify the test case.
Sat, Aug 13, 7:19 PM · Restricted Project, Restricted Project
loladiro updated the diff for D131845: [MSAN] Correct shadow type for atomicrmw instrumentation.

fixup CHECKs

Sat, Aug 13, 7:11 PM · Restricted Project, Restricted Project
MaskRay added inline comments to D128998: [libunwind] Handle G in personality string.
Sat, Aug 13, 7:07 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added a comment to D128998: [libunwind] Handle G in personality string.

Without this change, we crash on cxa_get_globals when trying to catch the exception (because the stack frame hadn't been cleared up).

Sat, Aug 13, 7:02 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay committed rGb2f31cac28c8: [Triple] Add llvm::Triple::isRISCV{32,64} (authored by smd).
[Triple] Add llvm::Triple::isRISCV{32,64}
Sat, Aug 13, 6:52 PM · Restricted Project, Restricted Project
MaskRay closed D131339: [Triple] Add llvm::Triple::isRISCV{32,64}.
Sat, Aug 13, 6:51 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D131290: [llvm-objdump] Create name for fake sections.
Sat, Aug 13, 6:44 PM · Restricted Project, Restricted Project
pengfei committed rG8b69549dc5c5: [X86][FP16] Promote FP16->[U]INT to FP16->FP32->[U]INT (authored by pengfei).
[X86][FP16] Promote FP16->[U]INT to FP16->FP32->[U]INT
Sat, Aug 13, 6:38 PM · Restricted Project, Restricted Project
pengfei closed D131828: [X86][FP16] Promote FP16->[U]INT to FP16->FP32->[U]INT.
Sat, Aug 13, 6:37 PM · Restricted Project, Restricted Project
MaskRay accepted D131816: [InstrProf] Add option to avoid instrumenting small functions.

LGTM. Please wait a bit for others' opinions.

Sat, Aug 13, 6:24 PM · Restricted Project, Restricted Project
benlangmuir committed rGcf1521e8cc71: [llvm] Update FileSystem test that failed spuriously (authored by benlangmuir).
[llvm] Update FileSystem test that failed spuriously
Sat, Aug 13, 6:17 PM · Restricted Project, Restricted Project
regehr committed rGdf308cab28bd: fix some bad logic that was removing all successor phi nodes, not just (authored by regehr).
fix some bad logic that was removing all successor phi nodes, not just
Sat, Aug 13, 6:16 PM · Restricted Project, Restricted Project
regehr closed D131843: llvm-reduce: remove a crash in the basic block reducing pass.
Sat, Aug 13, 6:15 PM · Restricted Project, Restricted Project
MaskRay committed rG83aa91bda0fa: [llvm-readobj] Remove unused member variable. NFC (authored by MaskRay).
[llvm-readobj] Remove unused member variable. NFC
Sat, Aug 13, 6:14 PM · Restricted Project, Restricted Project
regehr updated the diff for D131843: llvm-reduce: remove a crash in the basic block reducing pass.
Sat, Aug 13, 6:12 PM · Restricted Project, Restricted Project