Page MenuHomePhabricator

Recent Activity

Today

spatel committed rG240acb0cff3f: [InstCombine] avoid infinite loops with select folds of constant expressions (authored by spatel).
[InstCombine] avoid infinite loops with select folds of constant expressions
Sun, Jun 20, 6:53 AM
vitaut accepted D103357: [libc++][format] Add __format_arg_store..

LGTM but this will need to be reviewed by someone familiar with libc++ of course =).

Sun, Jun 20, 6:44 AM · Restricted Project
xbolva00 added a reviewer for D104597: [SimplifyCFG] Tail-merging all blocks with `ret` terminator: dmgreen.
Sun, Jun 20, 5:02 AM · Restricted Project
kuter updated the diff for D104599: [WIP][Attributor] Derive AAFunctionReachability attribute..
  • Implement getAsStr()
  • Naming Changes.
Sun, Jun 20, 4:59 AM · Restricted Project
lebedev.ri updated the diff for D104597: [SimplifyCFG] Tail-merging all blocks with `ret` terminator.

Autogenerate more, but still not all, affected codegen tests.

Sun, Jun 20, 4:19 AM · Restricted Project
lebedev.ri committed rGe497b12a6960: [NFC][AArch64][ARM][Thumb][Hexagon] Autogenerate some tests (authored by lebedev.ri).
[NFC][AArch64][ARM][Thumb][Hexagon] Autogenerate some tests
Sun, Jun 20, 4:13 AM
lebedev.ri committed rGb1f55c33d435: [UpdateTestUtils] Print test filename when complaining about conflicting prefix (authored by lebedev.ri).
[UpdateTestUtils] Print test filename when complaining about conflicting prefix
Sun, Jun 20, 4:13 AM
LuoYuanke added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

I think because I use the

Sun, Jun 20, 3:21 AM · Restricted Project
fhahn requested review of D104603: [LV] Fix crash when target instruction for sinking is dead..
Sun, Jun 20, 3:17 AM · Restricted Project
uint256_t added a comment to D104180: [NFC] [LICM] Create LoopNest Invariant Code Motion (LNICM) pass.

I'm sorry to be late to reply.
I'm making small tests and some code changes to demonstrate the following:

Sun, Jun 20, 3:10 AM · Restricted Project
lebedev.ri updated the summary of D104598: [NFCI-ish][SimplifyCFGPass] Rework and generalize `ret` block tail-merging.
Sun, Jun 20, 2:47 AM · Restricted Project
lebedev.ri updated the diff for D104598: [NFCI-ish][SimplifyCFGPass] Rework and generalize `ret` block tail-merging.

Split off addresstaken fixes.

Sun, Jun 20, 2:46 AM · Restricted Project
lebedev.ri committed rGc5b7335dc8eb: [SimplifyCFG] FoldTwoEntryPHINode(): don't fold if either block has it's… (authored by lebedev.ri).
[SimplifyCFG] FoldTwoEntryPHINode(): don't fold if either block has it's…
Sun, Jun 20, 2:38 AM
nikic accepted D104602: [InstCombine] Use poison constant to represent the result of unreachable instrs.

LGTM, but please drop the "use poison instead of undef" comments -- I don't think using poison instead of undef for dead code requires any explicit justification.

Sun, Jun 20, 2:28 AM · Restricted Project
lebedev.ri committed rGad87761925c2: [SimplifyCFG] HoistThenElseCodeToIf(): don't hoist if either block has it's… (authored by lebedev.ri).
[SimplifyCFG] HoistThenElseCodeToIf(): don't hoist if either block has it's…
Sun, Jun 20, 2:23 AM
jasonmolenda updated the diff for D88387: Create "skinny corefiles" for Mach-O with process save-core / reading.

Update patch to:

Sun, Jun 20, 2:17 AM · Restricted Project
aheejin updated the summary of D104571: [WebAssembly] Make tag attribute's encoding uint8.
Sun, Jun 20, 1:39 AM · Restricted Project
sylvestre.ledru added a comment to D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it.

I think this change broke apt.llvm.org

Sun, Jun 20, 12:17 AM · Restricted Project, Restricted Project
ggouaillardet raised a concern with rG546449938a39: [libcxx][optional] adds missing constexpr operations.

Since this commit, llvm (main branch) cannot be built with some GNU compilers such as 8.3.1 (provided by RHEL8), 9.3.0 (provided by OpenHPC).
It works fine with 10.2.0 and higher though.

Sun, Jun 20, 12:01 AM

Yesterday

aqjune updated the diff for D104602: [InstCombine] Use poison constant to represent the result of unreachable instrs.

rebase

Sat, Jun 19, 11:47 PM · Restricted Project
aqjune committed rG09e8c0d5aaef: [InstSimplify] icmp poison, X -> poison (authored by aqjune).
[InstSimplify] icmp poison, X -> poison
Sat, Jun 19, 11:41 PM
chh added inline comments to D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope).
Sat, Jun 19, 11:29 PM · Restricted Project
chh updated the diff for D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope).

Sync up; moved DeclFilter to ClangTidy.cpp.

Sat, Jun 19, 11:27 PM · Restricted Project
craig.topper added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

With -O0, the small case can also generate "IMPLICIT_DEF" and "CHS_Fp80". I think we are near to the root cause. Stay tuned.

Sat, Jun 19, 11:17 PM · Restricted Project
LuoYuanke added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

With -O0, the small case can also generate "IMPLICIT_DEF" and "CHS_Fp80". I think we are near to the root cause. Stay tuned.

Sat, Jun 19, 11:15 PM · Restricted Project
aqjune updated the summary of D104602: [InstCombine] Use poison constant to represent the result of unreachable instrs.
Sat, Jun 19, 11:10 PM · Restricted Project
aqjune updated the diff for D104602: [InstCombine] Use poison constant to represent the result of unreachable instrs.

Remove the update at createOverflowTuple

Sat, Jun 19, 11:08 PM · Restricted Project
aqjune added inline comments to D104602: [InstCombine] Use poison constant to represent the result of unreachable instrs.
Sat, Jun 19, 11:05 PM · Restricted Project
aqjune requested review of D104602: [InstCombine] Use poison constant to represent the result of unreachable instrs.
Sat, Jun 19, 11:02 PM · Restricted Project
LuoYuanke added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

Are you running the large and small cases the same way? Have looked at the SelectionDAG debug logs for the affected basic block in the large case?

I was able to trigger the error with llc -O2 -fast-isel on a simple test. So that is a path to create this but you haven’t answered if fast isel is being used in your case.

Sat, Jun 19, 10:53 PM · Restricted Project
MaskRay committed rG0873016ceff3: [llvm-cov gcov] Support GCC 12 format (authored by MaskRay).
[llvm-cov gcov] Support GCC 12 format
Sat, Jun 19, 10:51 PM
MaskRay committed rGe85eecff3068: [llvm-cov gcov] Change case to match the prevailing style && replace getString… (authored by MaskRay).
[llvm-cov gcov] Change case to match the prevailing style && replace getString…
Sat, Jun 19, 10:51 PM
craig.topper added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

I don’t know what llvm-extract —recursive does. I’ve only used -func to extract a single function I knew caused a compiler crash.

Converting IMPLICIT_DEF to undef flag is correct.

IMPLICIT_DEF can get created from ISD::UNDEF but as far I could see ISD::UNDEF for fp80 is supposed to Expand to ConstantFP 0.

I also think fneg of undef should be folded by getNode when it is created in SelectionDAGBuilder. Is this going through fast isel or something?

In my small test case that is extracted by llvm-extract, the "fneg contract x86_fp80 undef" is lowered to "LD_Fp080". But in the big case which cause crash, it is lowered to "IMPLICIT_DEF" and "CHS_Fp80".

76:                                               ; preds = %74
  %77 = call contract x86_fp80 @_ZN5boost4math8policies20raise_overflow_errorIeNS1_6policyINS1_13promote_floatILb0EEENS1_14promote_doubleILb0EEENS1_14default_policyES8_S8_S8_S8_S8_S8_S8_S8_S8_S8_EEEET_PKcSC_RKT0_(i8* getelementptr inbounds ([29 x i8], [29 x i8]* @.str.3.16422, i64 0, i64 0), i8* null, %"struct.std::__atomic_flag_base"* nonnull align 1 dereferenceable(1) %9)
  %78 = fneg contract x86_fp80 undef
  br label %121
CALL64pcrel32 @_ZN5boost4math8policies20raise_overflow_errorIeNS1_6policyINS1_13promote_floatILb0EEENS1_14promote_doubleILb0EEENS1_14default_policyES8_S8_S8_S8_S8_S8_S8_S8_S8_S8_EEEET_PKcSC_RKT0_, <regmask $bh $bl $bp $bph $bpl $bx $ebp $ebx $hbp $hbx $rbp $rbx $r12 $r13 $r14 $r15 $r12b $r13b $r14b $r15b $r12bh $r13bh $r14bh $r15bh $r12d $r13d $r14d $r15d $r12w $r13w $r14w $r15w $r12wh and 3 more...>, implicit $rsp, implicit $ssp, implicit $rdi, implicit $rsi, implicit $rdx, implicit-def $rsp, implicit-def $ssp, implicit-def $fp0
ADJCALLSTACKUP64 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp
%118:rfp80 = COPY $fp0
%13:rfp80 = nofpexcept LD_Fp080 implicit-def dead $fpsw, implicit $fpcw
Sat, Jun 19, 10:48 PM · Restricted Project
LuoYuanke added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

BTW, do you think the patch to handle undef case in stackify pass reasonable?

No I do not. I have no reason to believe fneg or one arg instructions are the only things that could be effected. We need to understand why this is happening because isel was trying to prevent this.

Sat, Jun 19, 10:47 PM · Restricted Project
craig.topper added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

BTW, do you think the patch to handle undef case in stackify pass reasonable?

Sat, Jun 19, 10:44 PM · Restricted Project
cjdb abandoned D104171: Revert "Revert "[libcxx][gardening] Move all algorithms into their own headers."".

Complex hierarchy caused this to be merged by @ldionne on behalf of @cjdb and @zoecarver.

Sat, Jun 19, 10:42 PM · Restricted Project
LuoYuanke added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

BTW, do you think the patch to handle undef case in stackify pass reasonable?

Sat, Jun 19, 10:39 PM · Restricted Project
LuoYuanke added a comment to D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW..

I don’t know what llvm-extract —recursive does. I’ve only used -func to extract a single function I knew caused a compiler crash.

Converting IMPLICIT_DEF to undef flag is correct.

IMPLICIT_DEF can get created from ISD::UNDEF but as far I could see ISD::UNDEF for fp80 is supposed to Expand to ConstantFP 0.

I also think fneg of undef should be folded by getNode when it is created in SelectionDAGBuilder. Is this going through fast isel or something?

Sat, Jun 19, 10:37 PM · Restricted Project
cjdb added inline comments to D102121: [libcxx][ranges] adds _`non-propagating-cache`_.
Sat, Jun 19, 10:26 PM · Restricted Project
upinsmoke7229 added a project to rGe1adf90826a5: [LLD] [COFF] Avoid doing repeated fuzzy symbol lookup for each iteration. NFC.: Restricted Project.
Sat, Jun 19, 10:23 PM · Restricted Project