Today

aprantl added inline comments to D41135: EmitFuncArgumentDbgValue: Prefer stack slots over registers for stack arguments.
Tue, Dec 12, 5:48 PM
lodato added a comment to D15465: [git-clang-format]: New option to perform formatting against staged changes only.

Oh, and I meant to start with: I'm so sorry for the extremely long delay. I was swamped with work before then I forgot about this. Please know that I appreciate your effort here and that I didn't mean to blow you off.

Tue, Dec 12, 5:47 PM
aprantl updated subscribers of D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Tue, Dec 12, 5:47 PM
aprantl added inline comments to D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Tue, Dec 12, 5:46 PM
shiva0217 updated the diff for D40003: [RISCV] MC layer support for the rest instructions of standard compress instruction set.
Tue, Dec 12, 5:45 PM
lodato added a comment to D15465: [git-clang-format]: New option to perform formatting against staged changes only.

I think the simplest solution to those problems is to require --diff. An alternative is to write the changes directly to the index without touching the working directory, but that would require some flag because the behavior is unintuitive, and the implementation would be complicated enough to warrant its own patch.

Tue, Dec 12, 5:43 PM
davide committed rL320541: [IRExecutionUnit] Initialize uninititialized member variable..
[IRExecutionUnit] Initialize uninititialized member variable.
Tue, Dec 12, 5:42 PM
davide committed rL320540: [DataEncoder] Replace buggy versions of write functions..
[DataEncoder] Replace buggy versions of write functions.
Tue, Dec 12, 5:42 PM
timshen created D41148: [libcxx] implement <experimental/simd> declarations based on P0214R7..
Tue, Dec 12, 5:41 PM
lodato created D41147: git-clang-format: Add new --staged option..
Tue, Dec 12, 5:41 PM
rafael committed rLLD320539: Fix the type of the Discared section..
Fix the type of the Discared section.
Tue, Dec 12, 5:40 PM
rafael committed rL320539: Fix the type of the Discared section..
Fix the type of the Discared section.
Tue, Dec 12, 5:40 PM
ruiu accepted D41143: Fix the type of the Discared section.

LGTM

Tue, Dec 12, 5:38 PM
pcc added inline comments to D40478: Added Instrument Control Flow Flag.
Tue, Dec 12, 5:38 PM
rafael updated the diff for D41143: Fix the type of the Discared section.

Use existing constructor.

Tue, Dec 12, 5:37 PM
lodato added a dependent revision for D41130: git-clang-format: cleanup: Use run() when possible.: D41145: git-clang-format: refactor to support upcoming --staged flag.
Tue, Dec 12, 5:31 PM
lodato added a dependency for D41145: git-clang-format: refactor to support upcoming --staged flag: D41130: git-clang-format: cleanup: Use run() when possible..
Tue, Dec 12, 5:31 PM
lodato updated the summary of D41145: git-clang-format: refactor to support upcoming --staged flag.
Tue, Dec 12, 5:31 PM
ruiu added inline comments to D40989: [WebAssembly] De-dup indirect function table.
Tue, Dec 12, 5:30 PM
rnk added inline comments to D41135: EmitFuncArgumentDbgValue: Prefer stack slots over registers for stack arguments.
Tue, Dec 12, 5:29 PM
wolfgangp created D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Tue, Dec 12, 5:22 PM
eugenis committed rCRT320538: [hwasan] Inline instrumentation & fixed shadow..
[hwasan] Inline instrumentation & fixed shadow.
Tue, Dec 12, 5:17 PM
eugenis committed rL320538: [hwasan] Inline instrumentation & fixed shadow..
[hwasan] Inline instrumentation & fixed shadow.
Tue, Dec 12, 5:17 PM
eugenis closed D41137: [hwasan] Inline instrumentation & fixed shadow..
Tue, Dec 12, 5:17 PM
eugenis updated the diff for D41137: [hwasan] Inline instrumentation & fixed shadow..

update hwasan tests

Tue, Dec 12, 5:16 PM
juliehockett updated the diff for D41102: Setup clang-doc frontend framework.

Updating formatting

Tue, Dec 12, 5:16 PM · Restricted Project
lodato created D41145: git-clang-format: refactor to support upcoming --staged flag.
Tue, Dec 12, 5:16 PM
phosek committed rL320537: [lldb] Set component when invoking add_llvm_install_targets.
[lldb] Set component when invoking add_llvm_install_targets
Tue, Dec 12, 5:15 PM
phosek closed D41144: [lldb] Set component when invoking add_llvm_install_targets.
Tue, Dec 12, 5:15 PM
smeenai accepted D41144: [lldb] Set component when invoking add_llvm_install_targets.

Argh sorry, I'm an idiot.

Tue, Dec 12, 5:13 PM
phosek created D41144: [lldb] Set component when invoking add_llvm_install_targets.
Tue, Dec 12, 5:12 PM
ruiu added inline comments to D41143: Fix the type of the Discared section.
Tue, Dec 12, 5:12 PM
rafael created D41143: Fix the type of the Discared section.
Tue, Dec 12, 5:09 PM
eugenis added inline comments to D41137: [hwasan] Inline instrumentation & fixed shadow..
Tue, Dec 12, 5:01 PM
eugenis updated the diff for D41137: [hwasan] Inline instrumentation & fixed shadow..

Removed unused variable.

Tue, Dec 12, 5:00 PM
hfinkel added a comment to D41096: [X86] Initial support for prefer-vector-width function attribute.

I really do want to make sure that I understand the problem (before I continue suggesting solutions). To summarize:

  • AVX-512 is twice the length of AVX2, and so using AVX-512 over AVX2 should give a 2x speedup, but...

I want to avoid using the term AVX-512 and AVX2 here and use ZMM and YMM or vector width. There are new instructions introduced after AVX512F as part of the AVX512VL instruction set that use only XMM and YMM registers and are not subject to this frequency issue. Our documentation really doesn't make that clear as it uses "AVX2".

Tue, Dec 12, 4:54 PM
STL_MSFT closed D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
Tue, Dec 12, 4:54 PM
STL_MSFT accepted D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..

Thanks, I've checked this in without the changes to TODO.TXT. Please let me know if you still want them, otherwise I consider this to be complete.

Tue, Dec 12, 4:54 PM
STL_MSFT closed D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref..
Tue, Dec 12, 4:53 PM
STL_MSFT committed rCXX320536: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
Tue, Dec 12, 4:52 PM