Today

kcc added a comment to D33393: [PATCH] Libcxxabi Demangler PR32890.

I don't know this code and can't properly comment, but having a constant like this ("7") sounds wrong.
Why not 6, or 8, or 42?

Tue, May 23, 11:35 AM
niravd committed rL303668: [DAG] Add canMergeStoresTo predicate checks. NFCI..
[DAG] Add canMergeStoresTo predicate checks. NFCI.
Tue, May 23, 11:33 AM
rampitec created D33455: [AMDGPU] Combine and (srl) into shl (bfe).
Tue, May 23, 11:32 AM
efriedma added a comment to D33442: [ARM] Fix lowering of misaligned memcpy/memset.

Please regenerate the tests in a separate commit, to make it clear what this patch is actually changing. Please change the description to make it clear what this is actually fixing; as far as I can tell, we aren't generating "wrong code", just inlining memcpy and memset calls too aggressively.

Tue, May 23, 11:31 AM
cryptoad created D33454: [sanitizer] Change the 32-bit Primary AllocateRegion to reduce fragmentation.
Tue, May 23, 11:29 AM
rnk committed rL303667: Speculative build fix for non-Windows.
Speculative build fix for non-Windows
Tue, May 23, 11:28 AM
xiaobai created D33453: Change RenderScriptx86ABIFixups.cpp to use llvm::AttributeList iterator.
Tue, May 23, 11:27 AM
dblaikie committed rL303666: Refactor DWARF hashing to use a .def file to avoid repetition.
Refactor DWARF hashing to use a .def file to avoid repetition
Tue, May 23, 11:27 AM
pftbest created D33452: [MSP430] Fix PR33050: Don't use ADD16ri to lower FrameIndex..
Tue, May 23, 11:24 AM
rnk committed rL303665: [PDB] Hash types up front when merging types instead of using StringMap.
[PDB] Hash types up front when merging types instead of using StringMap
Tue, May 23, 11:24 AM
rnk closed D33428: [PDB] Hash types up front when merging types instead of using StringMap by committing rL303665: [PDB] Hash types up front when merging types instead of using StringMap.
Tue, May 23, 11:24 AM
zturner accepted D33428: [PDB] Hash types up front when merging types instead of using StringMap.
Tue, May 23, 11:22 AM
tstellar accepted D33451: [AMDGPU] Add INDIRECT_BASE_ADDR to R600_Reg32 class (PR33045).
Tue, May 23, 11:22 AM
jmolloy added a comment to D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.

+1 from me.

Tue, May 23, 11:19 AM
rnk updated subscribers of D33428: [PDB] Hash types up front when merging types instead of using StringMap.
Tue, May 23, 11:19 AM
jtony added inline comments to D33053: [PowerPC] Implement vec_xxpermdi builtin..
Tue, May 23, 11:18 AM
jtony updated the diff for D33053: [PowerPC] Implement vec_xxpermdi builtin..

Address more comments from Nemanja and Hiroshi.

Tue, May 23, 11:17 AM
RKSimon created D33451: [AMDGPU] Add INDIRECT_BASE_ADDR to R600_Reg32 class (PR33045).
Tue, May 23, 11:11 AM
efriedma added a comment to D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.

Do you confirm that such behavior is acceptable?

Tue, May 23, 11:11 AM
vsk added a comment to D32724: [Modules] Handle sanitizer feature mismatches when importing modules.

Ping.

Tue, May 23, 11:08 AM
vsk updated subscribers of D32842: Specify which sanitizers are covered by a sanitizer blacklist.

Ping. (@george.karpenkov, do you have the time to take a look?)

Tue, May 23, 11:07 AM
efriedma added inline comments to D33391: [DAGCombine] fold (add/uaddo (xor a, -1), 1) -> (sub 0, a).
Tue, May 23, 11:06 AM
yaxunl added a comment to D33307: [AMDGPU] Fix kernel arg segment size for amdgizcl.

ping

Tue, May 23, 11:06 AM
iid_iunknown added a comment to D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.

I would suggest switching the option (arm-promote-constant) to default to false rather than commenting out the code, so we don't have to XFAIL the unit-tests.

Thanks for your comment, Eli.

Tue, May 23, 11:05 AM
ctopper committed rL303664: [InstSimplify] auto-generate test checks. NFC.
[InstSimplify] auto-generate test checks. NFC
Tue, May 23, 10:57 AM
arsenm added a comment to D33064: AMDGPU: Start adding offset fields to flat instructions.

ping

Tue, May 23, 10:53 AM
arsenm added a comment to D33065: AMDGPU: Verify that flat offsets aren't used pre-GFX9.

ping

Tue, May 23, 10:53 AM
tstellar accepted D33066: AMDGPU: Start selecting flat instruction offsets.
Tue, May 23, 10:52 AM
clayborg added a comment to D32585: Implementation of remote packets for Trace data..

Looks like we are down to just running clang format on the code so the R"( strings don't go over 80 chars and this is good to go from me.

Tue, May 23, 10:52 AM
spatel committed rL303663: [InstCombine] auto-generate test checks; NFC.
[InstCombine] auto-generate test checks; NFC
Tue, May 23, 10:51 AM
anemet committed rL303662: Disable flaky ASan tests temporarily on darwin.
Disable flaky ASan tests temporarily on darwin
Tue, May 23, 10:51 AM
erik.pilkington added inline comments to D33450: Warn about uses of `@available` that can't suppress the -Wunguarded-availability warnings.
Tue, May 23, 10:50 AM
arsenm added a comment to D33066: AMDGPU: Start selecting flat instruction offsets.

ping

Tue, May 23, 10:48 AM
clayborg requested changes to D33434: Added new API to SBStructuredData class.

Very close and overall very nice, just a few implementation details to take care of.

Tue, May 23, 10:47 AM
dneilson added inline comments to D33355: [IR] Add additional addParamAttr/removeParamAttr to AttributeList API.
Tue, May 23, 10:46 AM
jroelofs updated the diff for D33259: Don't defer to the GCC driver for linking arm-baremetal.
Tue, May 23, 10:43 AM
srhines added inline comments to D33205: ARM] Fix Neon vector type alignment to 64-bit.
Tue, May 23, 10:37 AM
efriedma added a comment to D33446: [ARM] Temporarily disable globals promotion to constant pools to prevent miscompilation.

I would suggest switching the option (arm-promote-constant) to default to false rather than commenting out the code, so we don't have to XFAIL the unit-tests.

Tue, May 23, 10:36 AM
arphaman created D33450: Warn about uses of `@available` that can't suppress the -Wunguarded-availability warnings.
Tue, May 23, 10:34 AM
tstellar committed rL303661: Merging r302137:.
Merging r302137:
Tue, May 23, 10:31 AM