Page MenuHomePhabricator

Recent Activity

Today

phosek added a comment to D109593: WIP: [libcxx] Add a CI configuration for standalone building in llvm-project/runtimes.

That is fine with me.

I want to standardize around exactly two types of supported builds:

  1. Using <root>/runtimes as a CMake root.
  2. Using <root>/llvm as a CMake root and mentioning LLVM_ENABLE_RUNTIMES=..... That is effectively bootstrapping Clang and building the runtimes with the just-built compiler.

In particular, I want to remove the ability to use <root>/llvm as a CMake root and say LLVM_ENABLE_PROJECTS=libcxx,libcxxabi,libunwind as a way of building, since that has a bunch of problems.

Are we on the same page? If so, we'll also want to improve on the terrible terminology we have today. (2) is currently called a "runtimes build", and (1) has no name. I would suggest we call (1) a "build of the runtimes", or just a "normal build", and that we rename (2) to a "bootstrapping build" or something like that.

That sounds like a good general direction. Distributors of llvm and the runtimes are going to need a decent sized transition period though.

For people using LLVM_ENABLE_PROJECTS, I would believe it should be straightforward for them to migrate. The bigger disruption is going to be when/if we stop allowing building the runtime projects entirely on their own by pointing cmake directly at e.g. libcxx. Judging from last weeks LLVM Distributors Conference, I would say that's the way a majority of distributors build it today, and transitioning that into e.g. 1. above will take some effort in the more complex cases. And some of them build this way with standalone source dirs without the surrounding monorepo, e.g. cc @tstellar.

Tue, Sep 21, 11:27 PM · Restricted Project, Restricted Project
sivachandra requested review of D110222: [libc] Add an implementation of bsearch..
Tue, Sep 21, 11:23 PM · Restricted Project
phosek added a comment to D109593: WIP: [libcxx] Add a CI configuration for standalone building in llvm-project/runtimes.

@phosek - What do you think of the rest of the changes left here in this patch now - do they seem sensible? Should I split them out to one to three more individual changes for the runtimes build (moving setting LLVM_RUNTIMES_BUILD to llvm/runtimes, including llvm-lit when necessary, making sure LLVM_INCLUDE_TESTS is on by default)?

Tue, Sep 21, 11:14 PM · Restricted Project, Restricted Project
JDevlieghere committed rG47f79c605776: [lldb] Add --stack option to `target symbols add` command (authored by JDevlieghere).
[lldb] Add --stack option to `target symbols add` command
Tue, Sep 21, 11:08 PM
hoy updated the diff for D110209: [CSSPGO] Set PseudoProbeInserter as a default pass..

Updating D110209: [CSSPGO] Set PseudoProbeInserter as a default pass.

Tue, Sep 21, 11:08 PM · Restricted Project, Restricted Project
JDevlieghere closed D110011: [lldb] Add --stack option to `target symbols add` command.
Tue, Sep 21, 11:08 PM · Restricted Project
hoy added a comment to D110209: [CSSPGO] Set PseudoProbeInserter as a default pass..

lld/test/ELF/lto/pseudo-probe-lto.ll needs update

Tue, Sep 21, 11:07 PM · Restricted Project, Restricted Project
aartbik added reviewers for D110221: [mlir][sparse] replace ad-hoc MemRef struct with CRunnerUtils definition: mehdi_amini, jsetoain, wrengr, bixia.
Tue, Sep 21, 11:06 PM · Restricted Project
zixuan-wu added a comment to D107658: [RISCV] Teach isel to select ADDW/SUBW/MULW/SLLIW when only the lower 32-bits are used..
Tue, Sep 21, 11:03 PM · Restricted Project
aartbik requested review of D110221: [mlir][sparse] replace ad-hoc MemRef struct with CRunnerUtils definition.
Tue, Sep 21, 11:02 PM · Restricted Project
mstorsjo updated subscribers of D109593: WIP: [libcxx] Add a CI configuration for standalone building in llvm-project/runtimes.

That is fine with me.

I want to standardize around exactly two types of supported builds:

  1. Using <root>/runtimes as a CMake root.
  2. Using <root>/llvm as a CMake root and mentioning LLVM_ENABLE_RUNTIMES=..... That is effectively bootstrapping Clang and building the runtimes with the just-built compiler.

In particular, I want to remove the ability to use <root>/llvm as a CMake root and say LLVM_ENABLE_PROJECTS=libcxx,libcxxabi,libunwind as a way of building, since that has a bunch of problems.

Are we on the same page? If so, we'll also want to improve on the terrible terminology we have today. (2) is currently called a "runtimes build", and (1) has no name. I would suggest we call (1) a "build of the runtimes", or just a "normal build", and that we rename (2) to a "bootstrapping build" or something like that.

Tue, Sep 21, 11:01 PM · Restricted Project, Restricted Project
ChuanqiXu planned changes to D108697: [libcxx] [coroutine] Remove <experimental/coroutine>.

According @ldionne's plan, this patch would sleep 2 releases.

Tue, Sep 21, 10:55 PM · Restricted Project
MaskRay added a comment to D110209: [CSSPGO] Set PseudoProbeInserter as a default pass..

lld/test/ELF/lto/pseudo-probe-lto.ll needs update

Tue, Sep 21, 10:54 PM · Restricted Project, Restricted Project
ChuanqiXu updated the diff for D108697: [libcxx] [coroutine] Remove <experimental/coroutine>.

Address @ldionne 's comments.

Tue, Sep 21, 10:54 PM · Restricted Project
springerm requested review of D110220: [mlir][linalg] Support tile+peel with TiledLoopOp.
Tue, Sep 21, 10:44 PM · Restricted Project
linjamaki added inline comments to D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels.
Tue, Sep 21, 10:44 PM · Restricted Project
bondhugula added inline comments to D110085: [mlir] Unroll-and-jam loops with iter_args..
Tue, Sep 21, 10:41 PM · Restricted Project
bondhugula added a comment to D110085: [mlir] Unroll-and-jam loops with iter_args..

Thanks for creating this more comprehensive revision. Comments below.

Tue, Sep 21, 10:36 PM · Restricted Project
dvyukov committed rG4986959eb214: tsan: prepare for trace mapping removal (authored by dvyukov).
tsan: prepare for trace mapping removal
Tue, Sep 21, 10:26 PM
dvyukov closed D110194: tsan: prepare for trace mapping removal.
Tue, Sep 21, 10:26 PM · Restricted Project
dvyukov committed rG82e593cf900d: tsan: uninline Enable/DisableIgnores (authored by dvyukov).
tsan: uninline Enable/DisableIgnores
Tue, Sep 21, 10:25 PM
dvyukov closed D110157: tsan: uninline Enable/DisableIgnores.
Tue, Sep 21, 10:25 PM · Restricted Project
phosek added a comment to D110188: [WIP][compiler-rt][profile] Fixes for failing profile tests.

Is this ready for review?

Tue, Sep 21, 10:25 PM · Restricted Project, Restricted Project
ChuanqiXu updated the diff for D109433: [libcxx] [coroutine] Conform coroutine implementation.

Remove the issue about [coroutine.handle.compare] in SpaceshipProjects.csv.

Tue, Sep 21, 10:25 PM
dvyukov committed rGdb2f870fe3dc: tsan: reset destination range in Java heap move (authored by dvyukov).
tsan: reset destination range in Java heap move
Tue, Sep 21, 10:23 PM
dvyukov closed D110190: tsan: reset destination range in Java heap move.
Tue, Sep 21, 10:23 PM · Restricted Project
ChuanqiXu updated the diff for D109433: [libcxx] [coroutine] Conform coroutine implementation.
Tue, Sep 21, 10:22 PM
dvyukov updated the diff for D110190: tsan: reset destination range in Java heap move.

change for loop to internal_memset

Tue, Sep 21, 10:22 PM · Restricted Project
ChuanqiXu updated the diff for D109433: [libcxx] [coroutine] Conform coroutine implementation.

Address comments:

  • copy <experimental/coroutine> to <coroutine> and apply the change before.
  • Move the components in <coroutine> out of std::experimental namespace. This requires D108696.
  • Duplicate all the tests for <coroutine> to test the non-experimental version.
Tue, Sep 21, 10:19 PM
Meinersbur committed rGced20c667297: [Polly] Add -polly-reschedule and -polly-postopts options. (authored by Meinersbur).
[Polly] Add -polly-reschedule and -polly-postopts options.
Tue, Sep 21, 10:18 PM
dvyukov committed rG41f8ef3e3183: tsan: enable sse4.2 in tests (authored by dvyukov).
tsan: enable sse4.2 in tests
Tue, Sep 21, 10:14 PM
dvyukov closed D110192: tsan: enable sse4.2 in tests.
Tue, Sep 21, 10:13 PM · Restricted Project
dvyukov committed rGcf93f7677de3: tsan: move errno spoiling reporting into a separate function (NFC) (authored by dvyukov).
tsan: move errno spoiling reporting into a separate function (NFC)
Tue, Sep 21, 10:13 PM
dvyukov closed D110159: tsan: move errno spoiling reporting into a separate function (NFC).
Tue, Sep 21, 10:13 PM · Restricted Project
dvyukov committed rG20ee72d4ccb1: tsan: don't call dlsym during exit (authored by dvyukov).
tsan: don't call dlsym during exit
Tue, Sep 21, 10:12 PM
dvyukov closed D110166: tsan: don't call dlsym during exit.
Tue, Sep 21, 10:12 PM · Restricted Project
dvyukov updated the diff for D110166: tsan: don't call dlsym during exit.

remove unnecessary parent revision

Tue, Sep 21, 10:10 PM · Restricted Project
shchenz committed rG957514eb9e71: [PowerPC] add testcase for chain commoning; nfc (authored by shchenz).
[PowerPC] add testcase for chain commoning; nfc
Tue, Sep 21, 10:08 PM
dvyukov updated the diff for D110166: tsan: don't call dlsym during exit.

use real types for the callbacks

Tue, Sep 21, 10:08 PM · Restricted Project
dvyukov added inline comments to D110166: tsan: don't call dlsym during exit.
Tue, Sep 21, 10:07 PM · Restricted Project