Page MenuHomePhabricator

Recent Activity

Today

fsb4000 abandoned D142841: [libc++] Implement P2520R0: `move_iterator<T*>` should be a random access iterator.
Sun, Jan 29, 3:07 PM · Restricted Project, Restricted Project
kevinsala requested review of D142850: [OpenMP][libomptarget] Do not rely on AsyncInfoWrapperTy's destructor to synchronize queue.
Sun, Jan 29, 3:02 PM · Restricted Project, Restricted Project
klausler committed rG88f7b4d5b6f4: [flang][MSVC] Change XFAIL to UNSUPPORTED for disabled test (authored by klausler).
[flang][MSVC] Change XFAIL to UNSUPPORTED for disabled test
Sun, Jan 29, 2:55 PM · Restricted Project, Restricted Project
rkayaith added a comment to D142821: [mlir][Pass] Handle spaces in pipeline strings.

There's still some cases where whitespace causes the parsing to fail:

" builtin.module()" - error: can't run ' builtin.module' pass manager on 'builtin.module' op
"builtin.module ()" - error: can't run 'builtin.module ' pass manager on 'builtin.module' op
"builtin.module() " - error: expected pass pipeline to be wrapped with the anchor operation type, e.g. 'builtin.module(...)'
Sun, Jan 29, 2:48 PM · Restricted Project, Restricted Project
fhahn committed rGdde3194876bf: [VPlan] Add sideffect/read or write test for VPPredInstPHIRecipe. (NFC) (authored by fhahn).
[VPlan] Add sideffect/read or write test for VPPredInstPHIRecipe. (NFC)
Sun, Jan 29, 2:46 PM · Restricted Project, Restricted Project
lhames accepted D142846: [JITLink] Adds support for PLT based relocations to the ELF/i386 JITLink backend.

Looks great! Thanks very much @jain98!

Sun, Jan 29, 2:44 PM · Restricted Project, Restricted Project
klausler committed rG2725499221c9: [flang] Check that DO index variables are definable (authored by klausler).
[flang] Check that DO index variables are definable
Sun, Jan 29, 2:27 PM · Restricted Project, Restricted Project
klausler closed D142767: [flang] Check that DO index variables are definable.
Sun, Jan 29, 2:27 PM · Restricted Project, Restricted Project
luismarques added a comment to D139996: [RISCV] Disable callee-saved register when the register is written by llvm.write_register intrinsic.

Nope, it's not enough. Before this patch, for example

Sun, Jan 29, 2:27 PM · Restricted Project, Restricted Project
python3kgae added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Sun, Jan 29, 2:13 PM · Restricted Project, Restricted Project
goldstein.w.n added reviewers for D142849: [ValueTracking] Add helper for handling `computeKnownBits` for and/xor/or; NFC: nikic, spatel, majnemer.
Sun, Jan 29, 2:13 PM · Restricted Project, Restricted Project
python3kgae updated the diff for D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

add space for warning message.

Sun, Jan 29, 2:12 PM · Restricted Project, Restricted Project
goldstein.w.n added a comment to D142427: [ValueTracking] Add logic for tracking lowbit of (and/xor/or X, (add/sub X, Odd)).

Can you please split this into an NFC patch that splits off analyzeKnownBitsFromAndXorOr() without changing logic, and then one that implements the new folds? (D142429 could be based on either one.)

Sun, Jan 29, 2:12 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142429: [InstCombine] Use `analyzeKnownBitsFromAndXorOr` in `SimplifyDemandedUseBits` for and/xor/or.

Rebase

Sun, Jan 29, 2:09 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142428: [InstCombine] Add tests that patterns for knownbits of and/or/xor apply in `SimplifyDemandedUseBits`; NFC.

Rebase

Sun, Jan 29, 2:09 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142427: [ValueTracking] Add logic for tracking lowbit of (and/xor/or X, (add/sub X, Odd)).

Rebase after splitting

Sun, Jan 29, 2:09 PM · Restricted Project, Restricted Project
goldstein.w.n requested review of D142849: [ValueTracking] Add helper for handling `computeKnownBits` for and/xor/or; NFC.
Sun, Jan 29, 2:09 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142426: [ValueTracking] Add tests for KnownBits of (and/xor/or X, (add/sub X, OddV)); NFC.

Rebase

Sun, Jan 29, 2:08 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142271: [ValueTracking] Add KnownBits patterns `xor(x, x - 1)` and `and(x, -x)` for knowing upper bits to be zero.

Rebase

Sun, Jan 29, 2:08 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142270: [ValueTracking] Add tests for known bits after common BMI pattern (blsmsk/blsi); NFC.

Rebase

Sun, Jan 29, 2:08 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142519: [KnownBits] Add blsi and blsmsk.

Rebase

Sun, Jan 29, 2:08 PM · Restricted Project, Restricted Project
nikic added inline comments to D142832: [ValueTracking] Add support in `isKnownNonZero` for dominating condition from `X > C1 && X < C2`.
Sun, Jan 29, 2:06 PM · Restricted Project, Restricted Project
mravishankar requested review of D142848: [mlir][Linalg] Make Elementwise op fusion return a map from existing values to values in the fused op..
Sun, Jan 29, 1:59 PM · Restricted Project, Restricted Project
mkazantsev updated the diff for D136233: [SimpleLoopUnswitch] Inject loop-invariant conditions and unswitch them when it's profitable.

Added test file (lost on last update)

Sun, Jan 29, 1:50 PM · Restricted Project, Restricted Project
barannikov88 committed rGfd9f42fad22c: [PowerPC] Convert some tests to opaque pointers (NFC) (authored by barannikov88).
[PowerPC] Convert some tests to opaque pointers (NFC)
Sun, Jan 29, 1:42 PM · Restricted Project, Restricted Project
goldstein.w.n added inline comments to D142832: [ValueTracking] Add support in `isKnownNonZero` for dominating condition from `X > C1 && X < C2`.
Sun, Jan 29, 1:37 PM · Restricted Project, Restricted Project
goldstein.w.n added inline comments to D142847: [InstCombine] reduce icmp_eq0-of-and-of-select-of-constants.
Sun, Jan 29, 1:34 PM · Restricted Project, Restricted Project
nikic added inline comments to D142832: [ValueTracking] Add support in `isKnownNonZero` for dominating condition from `X > C1 && X < C2`.
Sun, Jan 29, 1:33 PM · Restricted Project, Restricted Project
luismarques added a comment to D142777: [RISCV] Add asserts that we don't increase codesize during pseudo expansion.

Overall seems a reasonable implementation, despite the limitations pointed out in the patch description.

Sun, Jan 29, 1:32 PM · Restricted Project, Restricted Project
goldstein.w.n added inline comments to D142270: [ValueTracking] Add tests for known bits after common BMI pattern (blsmsk/blsi); NFC.
Sun, Jan 29, 1:30 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142797: [X86] Make `prefetchit{0/1}` emit an assembler warning if the operand is not rip-rel.

Use X86::AddrBaseReg instead of looping

Sun, Jan 29, 1:28 PM · Restricted Project, Restricted Project
goldstein.w.n added inline comments to D142832: [ValueTracking] Add support in `isKnownNonZero` for dominating condition from `X > C1 && X < C2`.
Sun, Jan 29, 1:22 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142832: [ValueTracking] Add support in `isKnownNonZero` for dominating condition from `X > C1 && X < C2`.

Rebase

Sun, Jan 29, 1:22 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142831: [ValueTracking] Add tests cases for `isKnownNonZero` for `X < C1 && X > C2`; NFC.

Add 1 more test to highlight need of isAssumedTrue

Sun, Jan 29, 1:22 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142830: [ValueTracking] Improve non-zero tracking of `X` by also searching through `Use(X)` that imply non-zero.

Updated tests, fixed some nits, rebase

Sun, Jan 29, 1:21 PM · Restricted Project, Restricted Project
goldstein.w.n added a comment to D142830: [ValueTracking] Improve non-zero tracking of `X` by also searching through `Use(X)` that imply non-zero.

We should be testing canonical IR here (use -passes=instcombine), at which point many of these should already be handled. E.g. if you have a condition abs(X) != 0, that should get canonicalized to X != 0 first, and then handled by existing code.

Sun, Jan 29, 1:21 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142829: [ValueTracking] Add tests cases for `isKnownNonZero` provable indirectly; NFC.

Move tests to instcombine + small updates to conditions

Sun, Jan 29, 1:20 PM · Restricted Project, Restricted Project
goldstein.w.n added inline comments to D142828: [ValueTracking] Add cases for additional ops in `isKnownNonZero`.
Sun, Jan 29, 1:20 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142828: [ValueTracking] Add cases for additional ops in `isKnownNonZero`.

Remove invoke/ rebase

Sun, Jan 29, 1:20 PM · Restricted Project, Restricted Project
goldstein.w.n updated the diff for D142827: [ValueTracking] Add tests for additional `isKnownNonZero` cases; NFC.

Remove use1

Sun, Jan 29, 1:19 PM · Restricted Project, Restricted Project