Update note type value
In v2 asm, we had the following:.option.machine_version_major .option.machine_version_minor .option.machine_version_stepping
What are the equivalents for v3 asm? The updates you made do not seem to describe those... Unless I missed it.
Thinking about this more, I'm fine with either this patch or one that does not define __libcpp_is_floating_point<_Float16> at all. This patch provides the best level of support that we seem to be able to provide, but is inconsistent across compilers and does not follow the standard perfectly. Not providing the definition at all decreases the level of support but increases consistency and simplicity. I'm fine with either.
- Address comments.
- Add comments.
Rebase to the ToT
There are still some contexts where both a new name and an existing name is permissible, going to add a comment on those to leave some traces for the next person who cares
- Use new types
- Rebase and take in new changes.
Add quotes to echo string in test.
So, the point is, just because we don't have access to the info via DIA doesn't mean we won't have access to the info once the native pdb plugin is complete. Just something to think about.
I prefer the API from Peter. I think it's a good additional step from where Aaron and I reached in IRC discussion (this patch currently).
I can change the patch to use that later if you agree Aaron?
Could you also update the check documentation clang-tidy/checks/cppcoreguidelines-narrowing-conversions.rst?