Latest change addresses most of issues.
Outstanding is adding a test when garbage GuardStyle value is fed into config.
The trial testcase used only CHECK-*-NOT which caused complaining from test harness looking for the CHECK- cases.
Looking for something similar in the other checker tests did not turn up anything.
In general it seems like clang-tidy assumes developers get the string names of the options and their values correct and does not provide a lot of (any?) checking.
- rC Clang
- 77,514 Commits
- ·
- Restricted Project
- Restricted Project
- Mon, May 20, 5:27 PM
- Subversion
Today
Today
trixirt added a comment to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.
Mon, May 20, 5:36 PM · Restricted Project
In D62063#1509321, @rnk wrote:Seems reasonable to me. I'm surprised CMake doesn't have a general facility for escaping paths used in cflags. I suppose users generally don't add paths, just flags.
Mon, May 20, 5:35 PM · Restricted Project
trixirt updated the diff for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.
Change the GuardStyle data type from a string to an enum.
Add test cases for explicitly setting valid style.
Document valid style values.
Reduce llvm-header-guard doc to point to bugprone-header-guard.
• thakis committed rG4522e2669643: Try to fix build with older gccs after r361152 (authored by • thakis).
Try to fix build with older gccs after r361152
nico committed rL361209: Try to fix build with older gccs after r361152.
Try to fix build with older gccs after r361152
nico committed rC361209: Try to fix build with older gccs after r361152.
Try to fix build with older gccs after r361152
smeenai added inline comments to D62155: [CMake] Copy C++ headers before configuring runtimes build.
Reduced test.
LGTM
GitHub <noreply@github.com> committed rGfa4afbdfd7af: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
I dont see any problems with this change. But I'm not sure I have any interesting insight either.
kees updated the diff for D60224: [TargetLowering] Extend bool args to inline-asm according to getBooleanType.
Rebasing to monorepo...
Mon, May 20, 5:02 PM · Restricted Project
arphaman updated the diff for D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.
Remove some outdated commented out code.
Mon, May 20, 4:54 PM · Restricted Project
Mon, May 20, 4:54 PM · Restricted Project
ping...
jcai19 added a reviewer for D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.: chh.
phosek added a comment to D62090: [libcxx][libunwind] Support ELF dependent libraries feature on Linux.
Would it be possible to take a look? I believe this is a better alternative to both D54724 and D54726 which doesn't require any changes to the driver or special linker scripts.
Mon, May 20, 4:40 PM · Restricted Project
Seems reasonable to me. I'm surprised CMake doesn't have a general facility for escaping paths used in cflags. I suppose users generally don't add paths, just flags.
Mon, May 20, 4:40 PM · Restricted Project
Richard Smith <richard-llvm@metafoo.co.uk> committed rGf1b29723ce91: Give 'fixit-cxx0x.cpp' a more modern name. (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Give 'fixit-cxx0x.cpp' a more modern name.
Give 'fixit-cxx0x.cpp' a more modern name.
Give 'fixit-cxx0x.cpp' a more modern name.
In D61993#1509025, @jakehehrlich wrote:Awesome. LGTM. Tell me if you want me or someone else to land it. You can also email Chris Latner to get access yourself.
Mon, May 20, 4:34 PM · Restricted Project
In D61993#1508403, @jhenderson wrote:LGTM, but I'd like a second pair of eyes on it from someone like @MaskRay, @rupprecht, or @jakehehrlich before this goes in. I assume you'll need somebody to commit it for you?
Mon, May 20, 4:34 PM · Restricted Project
phosek committed rG48140db79732: [builtins] Deduplicate __eqsf2 and __gtsf2 via macro (authored by phosek).
[builtins] Deduplicate __eqsf2 and __gtsf2 via macro
[builtins] Deduplicate __eqsf2 and __gtsf2 via macro
[builtins] Deduplicate __eqsf2 and __gtsf2 via macro
The only thing that Im worried about is cross-compilation accidentally picking up the libc++ headers that are built here (e.g. building on Linux for Linux with the host libc++ headers and building libc++ as a runtime). The rest looks pretty much a substitution and addition of runtime-libcxx-headers target to the runtimes build which is fine.
Interesting. I think all of the new warnings in the test cases here are undesirable (they duplicate errors produced by the constant evaluator), but the removed warnings all look like improvements.
Mon, May 20, 4:18 PM · Restricted Project
In D62157#1509289, @juliehockett wrote:@hintonda Aha so it is :)
Mon, May 20, 4:18 PM · Restricted Project
We use "alignTo(7, 3)":
Mon, May 20, 4:12 PM · Restricted Project
beanz retitled D62155: [CMake] Copy C++ headers before configuring runtimes build from [CMake] Copy C++ headers during config on Darwin to [CMake] Copy C++ headers before configuring runtimes build.
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
- cleanup
Mon, May 20, 4:12 PM · Restricted Project
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
- feedback
Mon, May 20, 4:12 PM · Restricted Project
beanz added a reviewer for D62155: [CMake] Copy C++ headers before configuring runtimes build: EricWF.
Looping in @EricWF.