Today

efriedma accepted D45535: [DSE] Teach the pass that atomic memory intrinsics are stores..

LGTM

Mon, Apr 23, 12:06 PM
timshen committed rCXX330627: [libcxx] implement <experimental/simd> declarations based on P0214R7..
[libcxx] implement <experimental/simd> declarations based on P0214R7.
Mon, Apr 23, 12:05 PM
craig.topper added a comment to D45976: [InstCombine] Simplify Add with remainder expressions as operands..

I'm not sure I see anything that ensures C1*C2 doesn't overflow. And in particular if C1*C2 overflows and produces 0, the resulting remainder instruction is UB.

Mon, Apr 23, 12:04 PM
dneilson updated the diff for D45535: [DSE] Teach the pass that atomic memory intrinsics are stores..
  • Deleted memtransferinst case in handleEndBlock.
Mon, Apr 23, 12:03 PM
efriedma added a comment to D45970: [LoopInterchange] Do not change LI for BBs in child loops..

Needs testcase.

Mon, Apr 23, 12:03 PM
NoQ added inline comments to D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header..
Mon, Apr 23, 12:03 PM
efriedma added inline comments to D45535: [DSE] Teach the pass that atomic memory intrinsics are stores..
Mon, Apr 23, 12:00 PM
NoQ added a comment to D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call.

Guys, what do you think about a checker that warns on uninitialized fields only when at least one field is initialized? I'd be much more confident about turning such check on by default. We can still keep a pedantic version.

Mon, Apr 23, 11:56 AM
efriedma added inline comments to D45279: [LoopInterchange] Use getExitBlock()/getExitingBlock instead of manual impl..
Mon, Apr 23, 11:55 AM
chandlerc added a comment to D45945: [LoopRotate] Fix incorrect SCEV invalidation in loop rotation.

We've fixed a bunch of bugs of this sort, so I think it's fine to go with.

Mon, Apr 23, 11:55 AM
mgrang added a comment to D45858: [DivRemPairs] Fix non-determinism in use list order..

If there is a unit test for this then it should have been uncovered in the reverse iteration bot: http://lab.llvm.org:8011/builders/reverse-iteration

Mon, Apr 23, 11:53 AM
danalbert added a comment to D45597: [Driver] Android triples are not aliases for other triples..

Ping.

Mon, Apr 23, 11:51 AM
danalbert added a comment to D45291: [Driver] Infer Android sysroot location..

Ping.

Mon, Apr 23, 11:50 AM
danalbert added a comment to D45292: [Driver] Obey computed sysroot when finding libc++ headers..

Ping.

Mon, Apr 23, 11:50 AM
timshen committed rL330627: [libcxx] implement <experimental/simd> declarations based on P0214R7..
[libcxx] implement <experimental/simd> declarations based on P0214R7.
Mon, Apr 23, 11:50 AM
joerg added a comment to D41240: [Solaris] __float128 is supported on Solaris/x86.

Things are different for a libgcc-based toolchain and a compiler-rt based toolchain.

Mon, Apr 23, 11:50 AM
timshen closed D41148: [libcxx] implement <experimental/simd> declarations based on P0214R7..
Mon, Apr 23, 11:50 AM
sanjoy requested changes to D45976: [InstCombine] Simplify Add with remainder expressions as operands..

Some style nits -- will review the content of the patch once these are fixed. You might want to skim through these: https://llvm.org/docs/CodingStandards.html http://llvm.org/docs/ProgrammersManual.html

Mon, Apr 23, 11:49 AM
aprantl added inline comments to D45975: [DebugInfo] Invalidate debug info in ReassociatePass::RewriteExprTree.
Mon, Apr 23, 11:49 AM · debug-info
timshen updated the diff for D41148: [libcxx] implement <experimental/simd> declarations based on P0214R7..

Update formatting on static_asserts.

Mon, Apr 23, 11:49 AM
zahiraam created D45978: dllexport const variables must have external linkage..
Mon, Apr 23, 11:48 AM
aprantl added inline comments to D45977: Always normalize FileSpec paths..
Mon, Apr 23, 11:47 AM
dexonsmith added a comment to D45772: [Minor patch] Fix IR Module Printing.

Another high-level note (besides adding tests): please resubmit the patch with full context (e.g., git diff -U9999999 HEAD^..).

Mon, Apr 23, 11:47 AM
craig.topper added inline comments to D45976: [InstCombine] Simplify Add with remainder expressions as operands..
Mon, Apr 23, 11:47 AM
clayborg updated the diff for D45977: Always normalize FileSpec paths..

Remove commented out code.

Mon, Apr 23, 11:47 AM
arsenm added inline comments to D45228: AMDGPU/SI: Handle BitCast of GEP in promoting alloca to vector.
Mon, Apr 23, 11:43 AM
efriedma accepted D45889: [MemCpyOpt] Skip optimizing basic blocks not reachable from entry.

LGTM

Mon, Apr 23, 11:43 AM
rsmith committed rL330626: DR727: remove wrong assertion for use of class-scope explicit.
DR727: remove wrong assertion for use of class-scope explicit
Mon, Apr 23, 11:41 AM
rsmith committed rC330626: DR727: remove wrong assertion for use of class-scope explicit.
DR727: remove wrong assertion for use of class-scope explicit
Mon, Apr 23, 11:41 AM
aprantl added inline comments to D45977: Always normalize FileSpec paths..
Mon, Apr 23, 11:41 AM
bjope added inline comments to D45975: [DebugInfo] Invalidate debug info in ReassociatePass::RewriteExprTree.
Mon, Apr 23, 11:41 AM · debug-info
clayborg updated the diff for D45977: Always normalize FileSpec paths..

Remove unwanted file changes.

Mon, Apr 23, 11:40 AM
remexre updated the diff for D45938: Improves x86 interrupt error message on argument type error.
Mon, Apr 23, 11:38 AM
clayborg edited reviewers for D45977: Always normalize FileSpec paths., added: aprantl; removed: pranavb.
Mon, Apr 23, 11:38 AM
clayborg created D45977: Always normalize FileSpec paths..
Mon, Apr 23, 11:38 AM
remexre added a comment to D45938: Improves x86 interrupt error message on argument type error.

I see no changes between Diff 143597 and Diff 143602.

Mon, Apr 23, 11:37 AM
BillyONeal added a comment to D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests.
  • if there are similar tests in the filesystem test suite, and you haven't tripped over them because you spelled your error message the same as we did.
Mon, Apr 23, 11:34 AM
arsenm added inline comments to D45781: MachineInst support mapping SDNode fast math flags for support in Back End code generation.
Mon, Apr 23, 11:32 AM
aaron.ballman added a reviewer for D45865: [Sema] Emit -Warray-bounds for multiple levels of subscript expressions.: rsmith.
Mon, Apr 23, 11:32 AM
lebedev.ri added inline comments to D45976: [InstCombine] Simplify Add with remainder expressions as operands..
Mon, Apr 23, 11:28 AM