Updating after D90172 and D89802 landed. I don't see it failing the tests anymore but I'll look into it more. I should probably make a test for the source location stuff now that it will all be implemenated.
Looks like this caused a regression on the sanitizer buildbots. In particular, running check-llvm under ASan produces the following error:
@ikudrin To clarify this will emit R_X86_64_64 bit relocations for .debug_info on 64 bit platform, correct?
Avoid warning in assert().
Thank you for the explanation!
Please note: this patch isn't ready to land as-is. There are about 1500 tests failing, for the reason covered here. The goal of the patch is to start the discussion as to how we want to proceed - assuming we believe that we shouldn't have tests with prefixes that aren't exercised - so I suppose that's the first question.
Fixed a rebase issue
In tests, what is the purpose of the the NO_MSSA and MSSA prefixes?
Also, I'm sorry for being so slow at reviewing these days...
Not an expert either, but at a high level this seems reasonable.
Oh wow, I think those are different pointers to the same string, and MSVC+Debug is the only configuration that doesn't fold them together.
So this is just a dumb bug in the test. I just pushed 1a1aad9156407bc891e2738e9877c03bd594e67f which should fix it, please let me know if it doesn't!
Collect location of a trailing return type in the parser, use that for the warning.
Restrict verify tests to C++20
Can you explain the added value of the tool a bit more. I can see how it's nice to be able to run export $(lldb-env); path/to/lldb but I wonder how often you'd end up doing that. When I invoke lldb directly, it's mostly to debug a test case, in which case I'd need to run lldb under lldb and set the environment variables myself. It also means we have to configure an additional file which goes against my effort of making the lit.site.cfg file self contained (to be able to run the test suite against a different toolchain).