Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Recent Activity

Today

smeenai added a comment to D156346: CodeGen: Disable isCopyInstrImpl if there are implicit operands.

Were the changes to arm-pcsections.ll in https://reviews.llvm.org/rGbc7d88faf1a595ab59952a2054418cdd0d9eeee8#change-knDnIXP6oBYw intended? We're seeing basically every single one of those fail when running the test locally. I'm also seeing bots failing, e.g. https://lab.llvm.org/buildbot/#/builders/119/builds/15375

Mon, Oct 2, 12:14 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D158540: Improve error message for constexpr constructors of virtual base classes.
Mon, Oct 2, 11:55 AM · Restricted Project, Restricted Project
aaron.ballman added a comment to D148381: [Clang] Implement the 'counted_by' attribute.

FINALLY! found out how to do suggestions for typos.

Mon, Oct 2, 11:45 AM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rG0b07b06effe5: [Sema] Use underlying type of scoped enum for -Wformat diagnostics (#67378) (authored by smeenai).
[Sema] Use underlying type of scoped enum for -Wformat diagnostics (#67378)
Mon, Oct 2, 11:33 AM · Restricted Project, Restricted Project
kstoimenov added a reverting change for rG414ff812d624: RegisterCoalescer: Add implicit-def of super register when coalescing…: rGe0f86ca2004b: Revert "RegisterCoalescer: Add implicit-def of super register when coalescing….
Mon, Oct 2, 11:22 AM · Restricted Project, Restricted Project
kstoimenov committed rGe0f86ca2004b: Revert "RegisterCoalescer: Add implicit-def of super register when coalescing… (authored by kstoimenov).
Revert "RegisterCoalescer: Add implicit-def of super register when coalescing…
Mon, Oct 2, 11:22 AM · Restricted Project, Restricted Project
zequanwu added a comment to D140828: [C++] Implement "Deducing this" (P0847R7).
Mon, Oct 2, 11:16 AM · Restricted Project, Restricted Project, Restricted Project
jmorse updated the diff for D153990: [DebugInfo][RemoveDIs] Add prototype storage classes for non-instruction variable debug-info.

Implement review feedback from Orlando.

Mon, Oct 2, 11:08 AM · debug-info, Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rGe0cb340f8ef7: [clang] Bump latest release to 17 for C++ DR Status page (#67996) (authored by Endill).
[clang] Bump latest release to 17 for C++ DR Status page (#67996)
Mon, Oct 2, 11:05 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D153664: [sanitizer] Relax the restriction on SizeClassAllocator64::kAllocatorSize.

static_assert with no message requires --std=c++17 which is not present for this test object. Otherwise we could add that here. The build command for that object is currently:

COMMAND = cmd.exe /C "cd /D C:\git\llvm-project\stage1_msvc\projects\compiler-rt\lib\asan\tests && C:\git\llvm-project\stage1_msvc\.\bin\clang.exe -DGTEST_NO_LLVM_SUPPORT=1 -DGTEST_HAS_RTTI=0 -IC:/git/llvm-project/llvm/../third-party/unittest/googletest/include -IC:/git/llvm-project/llvm/../third-party/unittest/googletest -Wno-deprecated-declarations -IC:/git/llvm-project/compiler-rt/include -IC:/git/llvm-project/compiler-rt/lib -IC:/git/llvm-project/compiler-rt/lib/asan -IC:/git/llvm-project/compiler-rt/lib/sanitizer_common/tests -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -fno-rtti -O2 -Wno-format -Werror=sign-compare -gline-tables-only -gcodeview -DASAN_HAS_IGNORELIST=1 -DASAN_HAS_EXCEPTIONS=1 -DASAN_UAR=0 -c -o ASAN_NOINST_TEST_OBJECTS.asan_noinst_test.cpp.x86_64-inline.o C:/git/llvm-project/compiler-rt/lib/asan/tests/asan_noinst_test.cpp"
Mon, Oct 2, 11:02 AM · Restricted Project, Restricted Project
aganea added a comment to D153664: [sanitizer] Relax the restriction on SizeClassAllocator64::kAllocatorSize.
Mon, Oct 2, 10:59 AM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rG01797dad8686: Fix mechanism propagating mangled names for TLI function mappings (#66656) (authored by JolantaJensen <107627027+JolantaJensen@users.noreply.github.com>).
Fix mechanism propagating mangled names for TLI function mappings (#66656)
Mon, Oct 2, 10:59 AM · Restricted Project, Restricted Project
arsenm requested changes to D159271: [AMDGPU][GlobalISel] Custom lowering for G_FNEARBYINT.
Mon, Oct 2, 10:52 AM · Restricted Project, Restricted Project
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rG2db8540a71ef: [gn build] Port cdd3e964f229 (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port cdd3e964f229
Mon, Oct 2, 10:47 AM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rGcdd3e964f229: [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (#67841) (authored by bulbazord).
[lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (#67841)
Mon, Oct 2, 10:46 AM · Restricted Project
vitalybuka updated subscribers of D153664: [sanitizer] Relax the restriction on SizeClassAllocator64::kAllocatorSize.

Looks unnececary
https://llvm.org/docs/CodingStandards.html#id3

Mon, Oct 2, 10:42 AM · Restricted Project, Restricted Project
fhahn added a comment to D156345: RegisterCoalescer: Add implicit-def of super register when coalescing SUBREG_TO_REG.

FYI it looks like this is causing crashes on ARM64.

Mon, Oct 2, 10:38 AM · Restricted Project, Restricted Project
aeubanks added a comment to D156345: RegisterCoalescer: Add implicit-def of super register when coalescing SUBREG_TO_REG.

we're seeing crashes around RegisterCoalescer. I haven't bisected exactly which patch yet but I figured it's one of these patches

Mon, Oct 2, 10:37 AM · Restricted Project, Restricted Project
d-smirnov added a comment to D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP.

@nikic Amended.

Mon, Oct 2, 10:34 AM · Restricted Project, Restricted Project, Restricted Project
d-smirnov updated the diff for D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP.

amended

Mon, Oct 2, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D113366: [InstCombine] Canonicalize range test idiom: Restricted Project.

This change is problematic, as something like
if (x >= '0' && x <= '9')
before this change is "if (x - '0‘ <u 10)", and now it becomes "if (245 <u x - '9')".
The later one is more expensive, as the ZExt followed by ADD(of type i32) is not removable, say, if the ISA does not have native i8-ADD instruction. While the former form is just OK, and the ZExt is removable.
So at least, if the type does not have native addition instruction, we should not do this. Or maybe, just don't do this in general, as no cannonicalization in that sense is possible.

Mon, Oct 2, 10:17 AM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rG9c89b29555a7: -fsanitize=function: fix MSVC hashing to sugared type (#66816) (authored by mizvekov).
-fsanitize=function: fix MSVC hashing to sugared type (#66816)
Mon, Oct 2, 10:09 AM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rGf776e0b6df61: [AArch64][Win] Work around an MSVC arm64 compiler bug (#67865) (authored by hjyamauchi).
[AArch64][Win] Work around an MSVC arm64 compiler bug (#67865)
Mon, Oct 2, 10:00 AM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D158069: [clang][Interp] Fix getIndex() for composite array elements.
Mon, Oct 2, 9:59 AM · Restricted Project, Restricted Project
aganea added inline comments to D153664: [sanitizer] Relax the restriction on SizeClassAllocator64::kAllocatorSize.
Mon, Oct 2, 9:51 AM · Restricted Project, Restricted Project
d-smirnov updated the diff for D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP.

amended

Mon, Oct 2, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rG959e69ab4640: [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (#67981) (authored by jhuber6).
[Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (#67981)
Mon, Oct 2, 9:43 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Addressed the comments so far.

Mon, Oct 2, 9:35 AM · Restricted Project, Restricted Project
atrosinenko added a comment to D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Updated the patch, thank you.

Mon, Oct 2, 9:34 AM · Restricted Project, Restricted Project
aganea committed rG82694d9c6045: [compiler-rt][asan] Silence MSVC warning (authored by aganea).
[compiler-rt][asan] Silence MSVC warning
Mon, Oct 2, 9:29 AM · Restricted Project, Restricted Project
aganea committed rGd58fb40670ea: [compiler-rt][asan] Silence warning (authored by aganea).
[compiler-rt][asan] Silence warning
Mon, Oct 2, 9:29 AM · Restricted Project, Restricted Project
aganea committed rG6f2358ee7750: [compiler-rt][asan] Silence MSVC warning (authored by aganea).
[compiler-rt][asan] Silence MSVC warning
Mon, Oct 2, 9:29 AM · Restricted Project, Restricted Project
aganea committed rG2385cf66e275: [compiler-rt] Fix "interception" file name (authored by aganea).
[compiler-rt] Fix "interception" file name
Mon, Oct 2, 9:29 AM · Restricted Project, Restricted Project
aganea committed rG262e2886b842: [compiler-rt] Fix MSVC `/external` detection in cmake scripts (authored by aganea).
[compiler-rt] Fix MSVC `/external` detection in cmake scripts
Mon, Oct 2, 9:29 AM · Restricted Project, Restricted Project
aganea closed D116872: [compiler-rt] Silence warnings when building with MSVC.
Mon, Oct 2, 9:29 AM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rGacb6e855a807: [workflow] Fix abi checker in llvm-tests. Same fix as in… (authored by thieta).
[workflow] Fix abi checker in llvm-tests. Same fix as in…
Mon, Oct 2, 9:14 AM · Restricted Project
jmorse added inline comments to D153990: [DebugInfo][RemoveDIs] Add prototype storage classes for non-instruction variable debug-info.
Mon, Oct 2, 9:14 AM · debug-info, Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rG8f4ffbbaf7ba: [RISCV] Create new build vector instead of relying on getNode constan… (#67944) (authored by craig.topper).
[RISCV] Create new build vector instead of relying on getNode constan… (#67944)
Mon, Oct 2, 9:13 AM · Restricted Project, Restricted Project
JDevlieghere added inline comments to D158124: [dsymutil] Add support for mergeable libraries.
Mon, Oct 2, 9:02 AM · Restricted Project, Restricted Project
dtemirbulatov added inline comments to D152205: [Aarch64][SVE]SVE2] Enable tbl, tbl2 for shuffle lowering for fixed vector types..
Mon, Oct 2, 9:02 AM · Restricted Project, Restricted Project