Page MenuHomePhabricator

Today

mtrofin committed rGab326ac96ecb: [llvm][NFC] Cache FAM in InlineAdvisor (authored by mtrofin).
[llvm][NFC] Cache FAM in InlineAdvisor
Mon, Jun 1, 1:02 PM
ABataev added a comment to D80925: Fix compiler crash when trying to parse alignment argument as a constant expression..

Narrowly this seems to fix the immediate problem, but I feel like we're in trouble if tentative parsing is changing the semantic context in ways that persist. In particular, I'm concerned that we could end up tentatively parsing an ODR use as part of an expression and then completely discarding it, causing Sema to think that there's an ODR use later because it never sees an L2R conversion (because the expression is not actually used). Probably the most architectural thing would be for tentative expression parsing to push a possibly-unevaluated context, and then when we claim an expression annotation token we can do the retroactive work necessary to make it an expression in the proper context. We already have most of the logic to support that because of C99 sizeof, which is usually not evaluated but can be in the narrow circumstance of a VLA.

If we do decide to solve this more narrowly, then we should audit our use of the tentative-parsing queries to make sure that we're pushing contexts consistently, and we should leave comments in places like this to make sure that maintainers understand the subtleties.

So, you suggest to not create annot_primary_expr during tentative parsing and revert parsing completely, right?

Not creating the annotation doesn't help if we're still making Sema calls. Also, I assume we're making the annotation token intentionally, probably to avoid re-doing the lookup. But I do think we could recognize that we're doing this, push an unevaluated context in tentative parsing, and then call TransformToPotentiallyEvaluated when we see the token in expression parsing.

Mon, Jun 1, 1:01 PM · Restricted Project
PaulkaToast committed rG1ab092b75859: [libc] Expose APIGenerator. (authored by PaulkaToast).
[libc] Expose APIGenerator.
Mon, Jun 1, 1:01 PM
rnk committed rG8f0a66003064: [PDB] Use inlinee file checksum offsets directly (authored by rnk).
[PDB] Use inlinee file checksum offsets directly
Mon, Jun 1, 1:00 PM
PaulkaToast closed D80832: [libc] Expose APIGenerator..
Mon, Jun 1, 1:00 PM · Restricted Project
JDevlieghere committed rZORGd2cf26cb9778: [lldb] Make triggering downstream jobs a stage (authored by JDevlieghere).
[lldb] Make triggering downstream jobs a stage
Mon, Jun 1, 1:00 PM
JDevlieghere committed rZORG97d547b8145c: [lldb] Trigger reproducer job on success (authored by JDevlieghere).
[lldb] Trigger reproducer job on success
Mon, Jun 1, 1:00 PM
Harbormaster failed remote builds in B58652: Diff 267686 for D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop!
Mon, Jun 1, 1:00 PM · Restricted Project
Harbormaster failed remote builds in B58650: Diff 267684 for D77836: [Attribute] Fix noderef attribute false-negatives!
Mon, Jun 1, 1:00 PM · Restricted Project
hubert.reinterpretcast requested changes to D80947: Add to the Coding Standard our that single-line bodies omit braces.
Mon, Jun 1, 12:59 PM · Restricted Project
hubert.reinterpretcast added inline comments to D80947: Add to the Coding Standard our that single-line bodies omit braces.
Mon, Jun 1, 12:59 PM · Restricted Project
rjmccall added a comment to D80925: Fix compiler crash when trying to parse alignment argument as a constant expression..

Narrowly this seems to fix the immediate problem, but I feel like we're in trouble if tentative parsing is changing the semantic context in ways that persist. In particular, I'm concerned that we could end up tentatively parsing an ODR use as part of an expression and then completely discarding it, causing Sema to think that there's an ODR use later because it never sees an L2R conversion (because the expression is not actually used). Probably the most architectural thing would be for tentative expression parsing to push a possibly-unevaluated context, and then when we claim an expression annotation token we can do the retroactive work necessary to make it an expression in the proper context. We already have most of the logic to support that because of C99 sizeof, which is usually not evaluated but can be in the narrow circumstance of a VLA.

If we do decide to solve this more narrowly, then we should audit our use of the tentative-parsing queries to make sure that we're pushing contexts consistently, and we should leave comments in places like this to make sure that maintainers understand the subtleties.

So, you suggest to not create annot_primary_expr during tentative parsing and revert parsing completely, right?

Mon, Jun 1, 12:59 PM · Restricted Project
dblaikie added a comment to D80945: [DebugInfo] Fix a fatal error originating from split-macro support.

I don't think this field (debug_line_offset) is optional if the debug_macro.dwo section contains DW_MACRO_start_file: "If a DW_MACRO_start_file entry is present, the header contains a reference to the .debug_line section of the compilation."

Mon, Jun 1, 12:59 PM · debug-info, Restricted Project
PaulkaToast updated the diff for D79192: [libc] Add integration tests..
Mon, Jun 1, 12:59 PM · Restricted Project
delcypher requested changes to D80761: [Darwin] Add tests for OS version checking.
Mon, Jun 1, 12:59 PM · Restricted Project
fhahn updated subscribers of D80870: [LV] Make sure smallest/widest type sizes are powers-of-2..

Also added a couple of unrelated comments.

Mon, Jun 1, 12:59 PM · Restricted Project
jroelofs accepted D80947: Add to the Coding Standard our that single-line bodies omit braces.

LGTM

Mon, Jun 1, 12:59 PM · Restricted Project
tra added a comment to D60620: [HIP] Support target id by --offload-arch.

It means HIP will create two compilation passes: one for gfx908 and one for gfx908:xnack+:sramecc+.

Mon, Jun 1, 12:59 PM
Anastasia accepted D80574: [ExtVector] Support ExtVectorType conditional operator.

LGTM! Thanks! Please address small documentation nitpick before committing...

Mon, Jun 1, 12:59 PM · Restricted Project
delcypher requested changes to D79970: [Darwin] Improve runtime OS version checks.

LGTM other than the use of uint32_t.

Mon, Jun 1, 12:59 PM · Restricted Project
fhahn updated the diff for D80870: [LV] Make sure smallest/widest type sizes are powers-of-2..

Updated to round down in computeFeasibleMaxVF.

Mon, Jun 1, 12:59 PM · Restricted Project
lebedev.ri added a comment to D80947: Add to the Coding Standard our that single-line bodies omit braces.

SGTM

Mon, Jun 1, 12:59 PM · Restricted Project
MaskRay accepted D68049: Propeller: Clang options for basic block sections .
Mon, Jun 1, 12:59 PM · Restricted Project, Restricted Project
probinson added a comment to D80876: [clang] Default to windows response files when running on windows.

Re testing, you could copy clang/test/Driver/at_file_win.c, which has an explicit --rsp-quoting=windows; remove that option and make it REQUIRES: system-windows. That should do it.

Mon, Jun 1, 12:59 PM · Restricted Project
MaskRay accepted D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer.

(You can change [Clang] to [Driver] as [Clang] may carry less information. [Driver] emphasizes this is related to clangDriver. Nothing in sema/codegen/analyzer/etc is affected.)

Mon, Jun 1, 12:59 PM · Restricted Project, Restricted Project
dsanders added a comment to D80390: [WIP][mips] Support 64-bit relative relocations.

LGTM once all other reviewers are happy with this patch.

You don't really need to wait for all of us but you should probably wait for @MaskRay and @atanasyan as they had comments.

Mon, Jun 1, 12:59 PM · Restricted Project
pcc updated subscribers of D80186: [Inliner] Update !associated metadata during inlining.

In this case you might consider replacing the global reference with null and implementing my proposal in https://bugs.llvm.org/show_bug.cgi?id=41734#c2 to make the section SHF_LINK_ORDER with a zero-length .init_array section.

Mon, Jun 1, 12:59 PM · Restricted Project
davidxl accepted D80578: [PGO] Enable memcmp/bcmp size value profiling..

lgtm

Mon, Jun 1, 12:59 PM · Restricted Project
kmclaughlin added a comment to D79587: [CodeGen][SVE] Legalisation of extends with scalable types.

Thanks for taking another look at this, @efriedma!

Mon, Jun 1, 12:59 PM · Restricted Project
serge-sans-paille updated the diff for D80641: Use Pseudo Instruction to carry stack probing information.

Use llvm::find_if

Mon, Jun 1, 12:59 PM · Restricted Project
kmclaughlin updated the diff for D79587: [CodeGen][SVE] Legalisation of extends with scalable types.
  • Restricted the illegal types which should be lowered for EXTRACT_SUBVECTOR to those handled in this patch (nxv8i8, nxv4i16 & nxv2i32)
  • Removed unnecessary changes in ReplaceExtractSubVectorResults
  • Updated the tests with update_llc_test_checks.py
  • Added a check on expected types in performSignExtendInRegCombine & PromoteIntRes_EXTRACT_SUBVECTOR
Mon, Jun 1, 12:59 PM · Restricted Project
fhahn committed rG8f3f88d2f50d: [Matrix] Implement matrix index expressions ([][]). (authored by fhahn).
[Matrix] Implement matrix index expressions ([][]).
Mon, Jun 1, 12:28 PM
fhahn closed D76791: [Matrix] Implement matrix index expressions ([][])..
Mon, Jun 1, 12:27 PM · Restricted Project, Restricted Project
tra added a comment to D80897: [OpenMP] Initial support for std::complex in target regions.
In D80897#2066723, @tra wrote:

Hmm. I'm pretty sure tensorflow is using std::complex for various types. I'm surprised that we haven't seen these functions missing.

Which functions and missing from where? In CUDA-mode we did provide __XXXXc3 already.

Mon, Jun 1, 12:27 PM · Restricted Project
probinson added a comment to D80876: [clang] Default to windows response files when running on windows.

It looks like your patch will allow us to remove a private patch that has a similar effect.
Incidentally if I apply this to an upstream checkout on Windows, I see clang/test/Driver/at_file.c fails, so you'd at least need to do something for that.
(UNSUPPORTED: system-windows at a minimum.)

Mon, Jun 1, 12:27 PM · Restricted Project
marxin committed rGb638b63b99d6: Move internal_uname to #if SANITIZER_LINUX scope. (authored by marxin).
Move internal_uname to #if SANITIZER_LINUX scope.
Mon, Jun 1, 12:27 PM
ashi1 added a comment to D78759: HIP - Add Statically Linked Libraries.

ping - is this refactored version ready for submission? Thanks.

Mon, Jun 1, 12:27 PM · Restricted Project, Restricted Project
Harbormaster failed remote builds in B58651: Diff 267681 for D80943: [X86] Add a flag to guard the wide load!
Mon, Jun 1, 12:26 PM · Restricted Project
Harbormaster failed remote builds in B58644: Diff 267676 for D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins in LLVM/Clang!
Mon, Jun 1, 12:26 PM · Restricted Project, Restricted Project, Restricted Project
Harbormaster failed remote builds in B58645: Diff 267677 for D80942: [openmp] Fixed nonmonotonic schedule implementation.!
Mon, Jun 1, 12:26 PM · Restricted Project