Page MenuHomePhabricator

Today

lebedev.ri added inline comments to D29121: [Docs] Add LangRef documention for freeze instruction.
Mon, Sep 16, 5:33 AM · Restricted Project
SjoerdMeijer accepted D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.

We're not generating any TP loops yet, so we're okay!

Mon, Sep 16, 5:33 AM · Restricted Project
samparker updated the diff for D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.

Improved error message.

Mon, Sep 16, 5:33 AM · Restricted Project
nlopes added inline comments to D29121: [Docs] Add LangRef documention for freeze instruction.
Mon, Sep 16, 5:25 AM · Restricted Project
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

While we're there, could you please see whether the included test case (note how condition tracking is turned off) fails on your platform without the rest of the patch applied (it definitely does on mine, which is why I was surprised to see this bug report pop up only now)? If not, I can just push a small commit with the llvm::isa_and_nonnull change to get some breathing room.

Mon, Sep 16, 5:23 AM · Restricted Project
fhahn added inline comments to D67594: [LoopUnroll] Use LoopSize+1 as threshold, to allow unrolling loops matching LoopSize..
Mon, Sep 16, 5:23 AM · Restricted Project
bjope abandoned D52092: [ValueTracking] Generalize isBytewiseValue into isSplatValue.

Not pursuing this. Should have been abandoned a long time ago.

Mon, Sep 16, 5:21 AM · Restricted Project
spatel committed rG14ce3fde046a: [InstCombine] add icmp tests with extra uses; NFC (authored by spatel).
[InstCombine] add icmp tests with extra uses; NFC
Mon, Sep 16, 5:20 AM
spatel committed rL371979: [InstCombine] add icmp tests with extra uses; NFC.
[InstCombine] add icmp tests with extra uses; NFC
Mon, Sep 16, 5:20 AM
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

Hi there,

just checking in, is this patch still going ahead?

thanks
Tom W

Mon, Sep 16, 5:20 AM · Restricted Project
samparker added inline comments to D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.
Mon, Sep 16, 5:20 AM · Restricted Project
grimar added inline comments to D67547: [llvm-readobj/llvm-objdump] - Improve how tool locate the dynamic table and report warnings about that..
Mon, Sep 16, 5:20 AM
fhahn created D67612: [UnrolledInstAnalyzer] Use MSSA to find stored values outside of loop..
Mon, Sep 16, 5:20 AM · Restricted Project
SouraVX created D67613: [DWARF-5] Support for DWARF-5 C++ language tags.
Mon, Sep 16, 5:20 AM · Restricted Project, debug-info
fhahn created D67611: [LoopUnrollAnalyzer] Try to simplify address computation outside of loop..
Mon, Sep 16, 5:16 AM · Restricted Project
spatel committed rG91c2cd0691d1: [InstCombine] fix comments to match code; NFC (authored by spatel).
[InstCombine] fix comments to match code; NFC
Mon, Sep 16, 5:14 AM
spatel committed rL371978: [InstCombine] fix comments to match code; NFC.
[InstCombine] fix comments to match code; NFC
Mon, Sep 16, 5:14 AM
fhahn updated the diff for D67594: [LoopUnroll] Use LoopSize+1 as threshold, to allow unrolling loops matching LoopSize..

Adjust comment and test case.

Mon, Sep 16, 5:14 AM · Restricted Project
MaskRay accepted D67555: [docs][llvm-size] Write llvm-size documentation.
Mon, Sep 16, 5:14 AM · Restricted Project
jhenderson updated the diff for D67555: [docs][llvm-size] Write llvm-size documentation.

Fix formatting of code blocks, so that the text following them are not considered part of the block.

Mon, Sep 16, 5:07 AM · Restricted Project
jhenderson updated the diff for D67555: [docs][llvm-size] Write llvm-size documentation.

Address some review comments. Specifically, reworded the --totals description, added a note about archive inputs, and replaced "object files" with "binaries" etc, to be more correct.

Mon, Sep 16, 5:03 AM · Restricted Project
SjoerdMeijer added a comment to D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.

They are different things. I actually don't think that the specification prevents any instructions from being in a TP loop, we just need to be careful of these. We should be able to allow most (all?) of these once we implement some better checks in the backend to look at the operands.

Mon, Sep 16, 5:03 AM · Restricted Project
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
In D67390#1667270, @kwk wrote:

@labath how shall we go about this? We do have the situation that when you lookup a symbol you might find it twice if it is in .dynsym and in .symtab. Shall I adjust the test expectation to that or change my implementation?

That's a good question (and another reason why I wanted this to be a separate patch). Since only two tests broke it does not seem like having some symbols twice does much harm. OTOH, having an identical symbol twice does seem like asking for trouble down the line. One possibility would be to restrict this merging to the gnu_debugdata case only. Another option would be to make the merging code smarter and avoid adding the symbol a second time if it has the same name and address. That would have the advantage of having the symbol just once in the common case, while still preserving the full information (in case the symbol tables were munged independently of the gnu_debugdata thingy).

Overall, I guess I would prefer the last solution (inserting only different symbols) unless that turns out to be difficult. In that case, I think just restricting this to gnu_debugdata is fine.

Mon, Sep 16, 4:58 AM · Restricted Project, Restricted Project
jdoerfert accepted D67603: [Attributor] Create helper struct for handling analysis getters.

I like this version a lot better, thx. LGTM.

Mon, Sep 16, 4:45 AM · Restricted Project
lewis-revill planned changes to D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

There is an option to Clang for '-msave-restore' which should be utilized to enable this.

Mon, Sep 16, 4:45 AM · Restricted Project
jdoerfert added a comment to D67604: [Attributor] Use Alias Analysis in noalias callsite argument deduction.

I like this, two comments though.

Mon, Sep 16, 4:45 AM · Restricted Project
thakis committed rGeded79b0d4bd: gn build: Merge r371976 (authored by thakis).
gn build: Merge r371976
Mon, Sep 16, 4:36 AM
nico committed rL371977: gn build: Merge r371976.
gn build: Merge r371976
Mon, Sep 16, 4:36 AM
jdoerfert added a comment to D29121: [Docs] Add LangRef documention for freeze instruction.

Two comments on the diff, the freeze part looks good to me.

Mon, Sep 16, 4:36 AM · Restricted Project
usaxena95 committed rG73c09eb7344e: Implement semantic selections. (authored by usaxena95).
Implement semantic selections.
Mon, Sep 16, 4:29 AM
lebedev.ri added inline comments to D29121: [Docs] Add LangRef documention for freeze instruction.
Mon, Sep 16, 4:29 AM · Restricted Project
usaxena95 committed rL371976: Implement semantic selections..
Implement semantic selections.
Mon, Sep 16, 4:28 AM
usaxena95 closed D67358: [clangd] Implement semantic selections..
Mon, Sep 16, 4:28 AM · Restricted Project, Restricted Project
RKSimon committed rG1aaefbca24ab: [VPlanSLP] Don't dereference a cast_or_null<VPInstruction> result. NFCI. (authored by RKSimon).
[VPlanSLP] Don't dereference a cast_or_null<VPInstruction> result. NFCI.
Mon, Sep 16, 4:23 AM
RKSimon committed rL371975: [VPlanSLP] Don't dereference a cast_or_null<VPInstruction> result. NFCI..
[VPlanSLP] Don't dereference a cast_or_null<VPInstruction> result. NFCI.
Mon, Sep 16, 4:23 AM
nlopes updated the diff for D29121: [Docs] Add LangRef documention for freeze instruction.

Updated with an example with vectors and add more references to freeze section.

Mon, Sep 16, 4:18 AM · Restricted Project
MaskRay added inline comments to D67547: [llvm-readobj/llvm-objdump] - Improve how tool locate the dynamic table and report warnings about that..
Mon, Sep 16, 4:16 AM
samparker added a comment to D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.

They are different things. I actually don't think that the specification prevents any instructions from being in a TP loop, we just need to be careful of these. We should be able to allow most (all?) of these once we implement some better checks in the backend to look at the operands.

Mon, Sep 16, 4:07 AM · Restricted Project
TWeaver added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

Hi there,

Mon, Sep 16, 4:06 AM · Restricted Project
jhenderson accepted D67547: [llvm-readobj/llvm-objdump] - Improve how tool locate the dynamic table and report warnings about that..

LGTM. Probably check with @MaskRay though before committing.

Mon, Sep 16, 4:01 AM