Page MenuHomePhabricator

Recent Activity
View All

Today

pengfei accepted D138486: X86: relax EFLAGS liveness check when generating stack probes..

LGTM.

Tue, Nov 29, 1:01 AM · Restricted Project, Restricted Project
jhenderson added a comment to D89049: [AIX][XCOFF] print out the traceback info .

I don't feel confident enough to be able to say whether various cases have been tested or not. I'd like to leave that to someone with more XCOFF knowledge.

Tue, Nov 29, 1:01 AM · Restricted Project, Restricted Project
kristof.beyls accepted D138898: [Nomination] Adding Mozilla representative to security group.
Tue, Nov 29, 12:59 AM · Restricted Project, Restricted Project
nilanjana_basu added inline comments to D138059: [MicroBenchmarks,AArch64] Added correctness test for truncate or zero-extend vector operations.
Tue, Nov 29, 12:58 AM · Restricted Project
VitaNuo updated the diff for D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support..

Fix formatting.

Tue, Nov 29, 12:54 AM · Restricted Project, Restricted Project
simon_tatham committed rGe45cbf9923e9: [ARM,MVE] Update MVE_VMLA_qr for architecture change. (authored by simon_tatham).
[ARM,MVE] Update MVE_VMLA_qr for architecture change.
Tue, Nov 29, 12:47 AM · Restricted Project, Restricted Project
simon_tatham closed D138827: [ARM,MVE] Update MVE_VMLA_qr for architecture change..
Tue, Nov 29, 12:47 AM · Restricted Project, Restricted Project
nilanjana_basu updated the diff for D138059: [MicroBenchmarks,AArch64] Added correctness test for truncate or zero-extend vector operations.

Ran clang-format

Tue, Nov 29, 12:46 AM · Restricted Project
tbaeder added inline comments to D137415: [clang][Interp] Implement switch statements.
Tue, Nov 29, 12:45 AM · Restricted Project, Restricted Project
springerm requested review of D138902: [mlir][bufferize] Improve error message when returning allocs.
Tue, Nov 29, 12:44 AM · Restricted Project, Restricted Project
nilanjana_basu updated the diff for D138059: [MicroBenchmarks,AArch64] Added correctness test for truncate or zero-extend vector operations.

Variable name changes

Tue, Nov 29, 12:39 AM · Restricted Project
jacquesguan added a comment to D131551: [RISCV] Fold vector binary operatrion into select with identity constant..

ping.

Tue, Nov 29, 12:39 AM · Restricted Project, Restricted Project
jacquesguan added a comment to D133829: [RISCV] Add cost model for insertelement/extractelement of vector type that should be splitted..

ping.

Tue, Nov 29, 12:38 AM · Restricted Project, Restricted Project
jacquesguan abandoned D133552: [RISCV] Add cost model for integer and float vector arithmetic instructions..

Close as most part of this revision was landed by reames.

Tue, Nov 29, 12:37 AM · Restricted Project, Restricted Project
tbaeder added a comment to D138270: [clang][Sema] Skip checking int expressions for overflow in constexpr functions.

Output for that test case is:

Tue, Nov 29, 12:36 AM · Restricted Project, Restricted Project
nilanjana_basu updated the diff for D138059: [MicroBenchmarks,AArch64] Added correctness test for truncate or zero-extend vector operations.

Addressed reviewer comments

Tue, Nov 29, 12:36 AM · Restricted Project
steakhal added inline comments to D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation..
Tue, Nov 29, 12:33 AM · Restricted Project
massberg updated the diff for D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant..

Fixed comments and removed unnecessary includes.

Tue, Nov 29, 12:26 AM · Restricted Project, Restricted Project
dhruvachak updated the diff for D123974: [OpenMP] [OMPT] [3/8] Implemented callback registration in libomptarget.

Rebased. Please review.

Tue, Nov 29, 12:24 AM · Restricted Project, Restricted Project
sameerds added inline comments to D138645: [AAPointerInfo] rearrange code in preparation for further changes.
Tue, Nov 29, 12:22 AM · Restricted Project, Restricted Project
Endill requested review of D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status.
Tue, Nov 29, 12:21 AM · Restricted Project, Restricted Project
dmakogon added inline comments to D137632: [LoopPredication] Widen checks if condition operands constant ranges are known.
Tue, Nov 29, 12:21 AM · Restricted Project, Restricted Project
jeanPerier accepted D138848: [flang][doc] Remove DCMPLX intrinsic from the Intrinsic Procedures Lacking Support list.

thanks

Tue, Nov 29, 12:19 AM · Restricted Project, Restricted Project
gysit added inline comments to D138405: [mlir][llvm] Import debug intrinsics from LLVMIR..
Tue, Nov 29, 12:19 AM · Restricted Project, Restricted Project
sameerds added a comment to D138646: [AAPointerInfo] track multiple constant offsets for each use.
In D138646#3954187, @jdoerfert wrote:

Is this patch, and the ones prior in the stack, ready for review?

Tue, Nov 29, 12:17 AM · Restricted Project, Restricted Project
dmakogon updated the diff for D137632: [LoopPredication] Widen checks if condition operands constant ranges are known.

Addressed comments

Tue, Nov 29, 12:12 AM · Restricted Project, Restricted Project
sameerds added a comment to D138841: AMDGPU: Fix not emitting code for exotic constructor types.

The change description says "should" in a couple of places. If we should error out on unexpected entries, then can it be handled in this change itself? The ctor/dtor bodies in the test look well-formed, but do they actually produce the correct code in the ISA? Should we have an llc test for the same or similar input?

Tue, Nov 29, 12:11 AM · Restricted Project, Restricted Project
dmakogon committed rGa580d2e43040: [Test] Update tests for LoopPredication constant ranges widening (authored by dmakogon).
[Test] Update tests for LoopPredication constant ranges widening
Tue, Nov 29, 12:09 AM · Restricted Project, Restricted Project
rriddle accepted D138437: [mlir][llvm] Make additional int debug attribute parameters optional..
Tue, Nov 29, 12:03 AM · Restricted Project, Restricted Project
dblaikie accepted D138858: [ADT] Clarify `zip` behavior with iteratees of different lengths.
Tue, Nov 29, 12:02 AM · Restricted Project, Restricted Project
rriddle accepted D138405: [mlir][llvm] Import debug intrinsics from LLVMIR..
Tue, Nov 29, 12:02 AM · Restricted Project, Restricted Project

Yesterday

gysit added a reviewer for D138437: [mlir][llvm] Make additional int debug attribute parameters optional.: rriddle.
Mon, Nov 28, 11:58 PM · Restricted Project, Restricted Project
gysit added a reviewer for D138405: [mlir][llvm] Import debug intrinsics from LLVMIR.: rriddle.
Mon, Nov 28, 11:57 PM · Restricted Project, Restricted Project
sameerds accepted D138842: AMDGPU: Port AMDGPUCtorDtorLowering to new PM.
Mon, Nov 28, 11:54 PM · Restricted Project, Restricted Project
shchenz updated the diff for D134792: [PowerPC][GISel] support 64 bit load/store.

address comments

Mon, Nov 28, 11:54 PM · Restricted Project, Restricted Project
t.p.northover accepted D138889: [Verifier]Remove API declaration that has never been implemented.

Yep, looks dangling to me.

Mon, Nov 28, 11:53 PM · Restricted Project, Restricted Project
shchenz added inline comments to D134792: [PowerPC][GISel] support 64 bit load/store.
Mon, Nov 28, 11:53 PM · Restricted Project, Restricted Project
xur updated the diff for D138893: [llvm-profdata] Use flattening sample profile in profile supplementation.

Removed lambda updateSampleMap() -- it was from the early version and now it was no longer needed as we just had one caller.

Mon, Nov 28, 11:45 PM · Restricted Project, Restricted Project
chelini added a comment to D138860: [mlir][tensor] Add a custom builder for pack op..

Thanks!

Mon, Nov 28, 11:41 PM · Restricted Project, Restricted Project
shchenz added inline comments to D137785: [PowerPC][GISel] Add initial GlobalISel support for vector functions. .
Mon, Nov 28, 11:36 PM · Restricted Project, Restricted Project, Restricted Project