Today

JVApen added a comment to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

I'm missing some documentation to understand the corner cases. How does this check behave with suppressed warnings for checks which ain't currently checked. (Using -no-... on a code base or suppressing the warnings via the pragmas)

Sun, Dec 17, 12:57 AM · Restricted Project
xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Review comments applied.

Sun, Dec 17, 12:21 AM · Restricted Project
xgsa added inline comments to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Sun, Dec 17, 12:12 AM · Restricted Project
xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

Review comments were applied.

Sun, Dec 17, 12:00 AM · Restricted Project

Yesterday

xgsa added inline comments to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Sat, Dec 16, 11:58 PM · Restricted Project
gadi.haber created D41328: [X86][RD]: Adding full coverage of MC encoding for RD isa sets.<NFC>.
Sat, Dec 16, 11:49 PM
craig.topper added inline comments to D41294: [X86][SSE] Use (V)PHMINPOSUW for vXi8 SMAX/SMIN/UMAX/UMIN horizontal reductions (PR32841).
Sat, Dec 16, 10:50 PM
craig.topper created D41327: [X86] Refactor DomainReassignment pass to make the Closure class not stores references to the main data structures of the pass itself.
Sat, Dec 16, 7:26 PM
ctopper committed rL320940: [X86DomainReassignment] Store legal domains in a std::bitset instead of using a….
[X86DomainReassignment] Store legal domains in a std::bitset instead of using a…
Sat, Dec 16, 7:17 PM
faisalv added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Sat, Dec 16, 6:48 PM
bsteinbr committed rL320939: Properly handle byval arguments in getPointerDereferenceableBytes().
Properly handle byval arguments in getPointerDereferenceableBytes()
Sat, Dec 16, 6:38 PM
Diffusion closed D41305: Properly handle byval arguments in getPointerDereferenceableBytes().
Sat, Dec 16, 6:38 PM
bsteinbr committed rL320938: Properly handle multi-element and dynamically sized allocas in….
Properly handle multi-element and dynamically sized allocas in…
Sat, Dec 16, 5:55 PM
Diffusion closed D41288: Properly handle multi-element and dynamically sized allocas in getPointerDereferenceableBytes().
Sat, Dec 16, 5:55 PM
Eugene.Zelenko added inline comments to D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Sat, Dec 16, 5:37 PM · Restricted Project
ctopper committed rL320937: [X86] Use extract_vector_elt instead of X86ISD::VEXTRACT for isel of vXi1….
[X86] Use extract_vector_elt instead of X86ISD::VEXTRACT for isel of vXi1…
Sat, Dec 16, 5:36 PM
ctopper committed rL320936: [X86] Canonicalize extract_vector_elt from vXi1 to always return MVT::i32..
[X86] Canonicalize extract_vector_elt from vXi1 to always return MVT::i32.
Sat, Dec 16, 5:36 PM
ctopper committed rL320935: [X86] Don't create X86ISD::VEXTRACT nodes directly. Use EXTRACT_VECTOR_ELT and….
[X86] Don't create X86ISD::VEXTRACT nodes directly. Use EXTRACT_VECTOR_ELT and…
Sat, Dec 16, 5:36 PM
ngie abandoned D34499: Expose __gcov_flush for parity with libgcov in the gcc project.

I guess no one cares. Oh well, at least the gcc folks respond to reviews/bugs in a <6 month timeframe.

Sat, Dec 16, 5:14 PM
zturner accepted D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb..

lgtm, if you have some time in the future for further improvements Greg's suggestion would be a good way to make this better.

Sat, Dec 16, 4:18 PM
RKSimon committed rL320934: Fix unused variable warning..
Fix unused variable warning.
Sat, Dec 16, 3:38 PM
RKSimon committed rL320933: [X86][AVX] lowerVectorShuffleAsBroadcast - aggressively peek through BITCASTs.
[X86][AVX] lowerVectorShuffleAsBroadcast - aggressively peek through BITCASTs
Sat, Dec 16, 3:33 PM
RKSimon committed rL320932: [X86][AVX] Use extract128BitVector helper. NFCI..
[X86][AVX] Use extract128BitVector helper. NFCI.
Sat, Dec 16, 3:10 PM
cryptoad committed rL320931: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.
[sanitizer] Define __sanitizer_clockid_t on FreeBSD
Sat, Dec 16, 3:02 PM
cryptoad committed rCRT320931: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.
[sanitizer] Define __sanitizer_clockid_t on FreeBSD
Sat, Dec 16, 3:02 PM
cryptoad closed D41325: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.
Sat, Dec 16, 3:01 PM
RKSimon committed rL320930: [X86][AVX] Fix failed broadcast fold.
[X86][AVX] Fix failed broadcast fold
Sat, Dec 16, 2:58 PM
xgsa updated the diff for D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.

A few minor coding style fixes.

Sat, Dec 16, 2:55 PM · Restricted Project
kparzysz accepted D41325: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.

It works.

Sat, Dec 16, 2:48 PM
sfertile committed rL320929: [Memcpy Loop Lowering] Only calculate residual size/bytes copied when needed..
[Memcpy Loop Lowering] Only calculate residual size/bytes copied when needed.
Sat, Dec 16, 2:42 PM
xgsa created D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment.
Sat, Dec 16, 2:38 PM · Restricted Project
bcain added a comment to D41316: [libcxx] Allow random_device to be built optionally.

I'd much rather provide no implementation than one that lies. Broken builds are much safer than problems at runtime.

Sat, Dec 16, 2:37 PM
tpr updated the diff for D41292: [AMDGPU] Fixed incorrect uniform branch condition.

V2: Always add the s_and. We should add a later pass to remove it when it is not needed.

Sat, Dec 16, 2:14 PM
ctopper committed rL320928: [X86] Don't pass a zero input to the passthru operand of….
[X86] Don't pass a zero input to the passthru operand of…
Sat, Dec 16, 1:13 PM
ctopper committed rL320927: [X86] Have getVectorMaskingNode return an ISD::AND for X86ISD::VPSHUFBITQMB….
[X86] Have getVectorMaskingNode return an ISD::AND for X86ISD::VPSHUFBITQMB…
Sat, Dec 16, 1:13 PM
cryptoad created D41325: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.
Sat, Dec 16, 12:53 PM
mstorsjo updated the diff for D41131: [AArch64] Implement stack probing for windows.

Fix the estimate of number of registers to spill, adjust it to make sure it won't underestimate the amount of stack used.

Sat, Dec 16, 12:53 PM
mstorsjo added a comment to D40863: [AArch64][Darwin] Implement stack probing for static and dynamic stack objects.

The motivation for stack probing here is different to the Windows case, although the mechanism is the same. For Darwin this is a security feature to protect against stack clash based attacks.

Sat, Dec 16, 12:50 PM
asmith updated the diff for D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb..

This changes SymbolFilePDB::FindTypesByRegex () to take an lldb_private::RegularExpression as the argument and removes the use of the STL regex.

Sat, Dec 16, 12:23 PM
sbc100 updated the diff for D41315: [WebAssembly] Output functions individually.
  • feedback
Sat, Dec 16, 11:53 AM