Page MenuHomePhabricator

clayborg (Greg Clayton)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 23 2014, 10:11 AM (312 w, 5 d)

Recent Activity

Fri, Sep 18

clayborg added a comment to D87335: [json] Create some llvm::Expected-based accessors.

Right now all users of this code end up creating little extra functions that must work around this. lldb-vscode has it's own methods, the new IntelPT will do its own thing.

Fri, Sep 18, 2:50 PM · Restricted Project

Tue, Sep 15

clayborg committed rG79f22b1f99fd: Fix .debug_aranges parsing. (authored by clayborg).
Fix .debug_aranges parsing.
Tue, Sep 15, 11:51 AM
clayborg closed D87626: Fix .debug_aranges parsing..
Tue, Sep 15, 11:51 AM · Restricted Project

Mon, Sep 14

clayborg accepted D87173: Ignores functions that have a range starting outside of a code section.
Mon, Sep 14, 3:40 PM · Restricted Project
clayborg accepted D87172: Check if debug line sequences are starting after the first code segment.
Mon, Sep 14, 3:38 PM · Restricted Project
clayborg requested review of D87626: Fix .debug_aranges parsing..
Mon, Sep 14, 12:27 PM · Restricted Project

Wed, Sep 9

clayborg added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

Thanks for the extra work arounds! LGTM. Pavel?

Wed, Sep 9, 2:03 PM · Restricted Project

Tue, Sep 8

clayborg accepted D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

This looks good to me. We will need to wait until the JSON changes from https://reviews.llvm.org/D87335 to make it in though in case there are any modifications to that patch.

Tue, Sep 8, 5:01 PM · Restricted Project, Restricted Project
clayborg added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder.

I assume you mean people *not* having a "localhost" entry?

Tue, Sep 8, 4:29 PM · Restricted Project
clayborg added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder.

Tue, Sep 8, 4:08 PM · Restricted Project

Fri, Sep 4

clayborg added inline comments to D87173: Ignores functions that have a range starting outside of a code section.
Fri, Sep 4, 5:27 PM · Restricted Project
clayborg requested changes to D87172: Check if debug line sequences are starting after the first code segment.
Fri, Sep 4, 5:22 PM · Restricted Project

Wed, Sep 2

clayborg added a comment to D86899: [trace][RFC] create skeleton for thread decoder.

I am not sure we need any of the classes in Trace.h: TraceInstruction, TraceDecodedThread, or TraceThread.

Wed, Sep 2, 6:45 PM · Restricted Project
clayborg requested changes to D86670: [intel-pt] Add a basic implementation of the dump command.

I think we should remove the "Stream *s;" from the TraceDumpOptions struct since we have a "Stream &s" as an argument already. We can't use a reference in the TraceDumpOptions without jumping through a lot of hoops.

Wed, Sep 2, 5:27 PM · Restricted Project
clayborg added inline comments to D86825: [lldb/Gui] zero-initialize children_stop_id.
Wed, Sep 2, 5:06 PM · Restricted Project
clayborg accepted D86825: [lldb/Gui] zero-initialize children_stop_id.
Wed, Sep 2, 5:03 PM · Restricted Project
clayborg accepted D84974: Enable Launching the Debugee in VSCode Terminal.
Wed, Sep 2, 2:34 PM · Restricted Project

Mon, Aug 31

clayborg accepted D86106: [lldb] avoid assert in threadsanitizer tests on linux.
Mon, Aug 31, 3:22 PM · Restricted Project
clayborg requested changes to D86670: [intel-pt] Add a basic implementation of the dump command.

I think we should probably make a TraceDumpOptions class to contain all of the dumping options and use that in the Target.h, Trace.h and all plug-ins. We will no doubt expand the number of options in the future and add more. We current have "tid" and "verbose". See inlined comments for details!

Mon, Aug 31, 3:11 PM · Restricted Project
clayborg accepted D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

LGTM now. Probably should get an ok from one more person.

Mon, Aug 31, 2:48 PM · Restricted Project, Restricted Project

Fri, Aug 28

clayborg added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

A few simple changes from inlined comments. Other than that looks good. Should get another OK from others. Also not sure if the JSON stuff in llvm needs to be done separately?

Fri, Aug 28, 8:14 PM · Restricted Project, Restricted Project
clayborg added a comment to D86670: [intel-pt] Add a basic implementation of the dump command.

I think it would be appropriate to discuss the design of this feature on lldb-dev before going over the individual patches. One of the fundamental aspects of this patchset that I think should not be overlooked is that it essentially adds a new level of structure ( a "Target Group") lldb. One of the questions I'd have is whether this concept shouldn't be formalized somewhere instead of it existing just virtually as the group of threads that happen to share the same trace object.

Fri, Aug 28, 11:21 AM · Restricted Project

Thu, Aug 27

clayborg added a comment to D86662: Simplify Symbol Status Message to Only Debug Info Size.

So we are adding a custom new "debugInfoSize" field to the "module" JSON dictionary? What happens in the release VS code? Does this information not get displayed, but it will get displayed in our custom modified VS Code IDE?

Thu, Aug 27, 3:29 PM · Restricted Project
clayborg requested changes to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

If the format is going to be json, why not use llvm::json from llvm/Support/JSON.h? That's what we been migrating most of the existing stuff to already, so going using that for new code makes perfect sense.

Thu, Aug 27, 12:50 PM · Restricted Project, Restricted Project
clayborg requested changes to D86670: [intel-pt] Add a basic implementation of the dump command.
Thu, Aug 27, 12:38 PM · Restricted Project

Wed, Aug 26

clayborg committed rGc55db4600b4b: Load correct module for linux and android when duplicates exist in minidump. (authored by clayborg).
Load correct module for linux and android when duplicates exist in minidump.
Wed, Aug 26, 3:48 PM
clayborg closed D86375: Load correct module for linux and android when duplicates exist in minidump..
Wed, Aug 26, 3:48 PM · Restricted Project
clayborg updated the diff for D86375: Load correct module for linux and android when duplicates exist in minidump..

Added a better algorithm for detecting if an address from the module list for linux processes with valid /proc/<pid>/maps file is executable. We now search consective addresses that match the path to the module for any that are marked as executable. Added tests to test if the mmap'ed file comes first or second, and also a test for "-z separate-code" when the first mapping for an executable isn't executable, but a subsequent mapping with a matching path is.

Wed, Aug 26, 12:57 AM · Restricted Project

Tue, Aug 25

clayborg added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

A large part of this patch is concerned with parsing which worries me from a maintenance perspective. Did you consider using Yaml I/O? While I'm not a particularly big fan of the format, the benefits of being able to (de)serialize any class by implementing the appropriate traits are quite significant. We already have traits implemented for a bunch of utility classes, such as ArchSpec and FileSpec which we could reuse for this. I know changing the format would be invasive, but I think it might be worth it in the long term.

Tue, Aug 25, 4:38 PM · Restricted Project, Restricted Project
clayborg added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

After speaking with Walter a bit, key names in the JSON should be camel case. Many languages (Swift and JavaScript) can auto import JSON and create objects and use the key names as member variable names, and if they are camelCase, then no name conversion needs to happen.

Tue, Aug 25, 4:35 PM · Restricted Project, Restricted Project
clayborg requested changes to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

Looking better. The main thing we need to do it modify StructuredData classes a bit by moving a lot of the static functions we are using here into the appropriate classes. See inlined comments.

Tue, Aug 25, 3:55 PM · Restricted Project, Restricted Project

Mon, Aug 24

clayborg added a comment to D86375: Load correct module for linux and android when duplicates exist in minidump..

If I correctly understand what this is doing, then I don't think it's a good idea. The base of an (elf) shared library does not have to be mapped executable. These are the mappings I get for a trivial hello world program (no mmapping of libraries or anything) on my linux machine:

00400000-00401000 r--p 00000000 fd:01 2838574                            /tmp/l/a.out
00401000-00402000 r-xp 00001000 fd:01 2838574                            /tmp/l/a.out
00402000-00403000 r--p 00002000 fd:01 2838574                            /tmp/l/a.out
00403000-00404000 r--p 00002000 fd:01 2838574                            /tmp/l/a.out
00404000-00405000 rw-p 00003000 fd:01 2838574                            /tmp/l/a.out
020fb000-0211c000 rw-p 00000000 00:00 0                                  [heap]
7fe4f5d87000-7fe4f5da9000 r--p 00000000 fd:01 2738932                    /lib64/libc-2.31.so
7fe4f5da9000-7fe4f5ef3000 r-xp 00022000 fd:01 2738932                    /lib64/libc-2.31.so
7fe4f5ef3000-7fe4f5f3d000 r--p 0016c000 fd:01 2738932                    /lib64/libc-2.31.so
7fe4f5f3d000-7fe4f5f41000 r--p 001b5000 fd:01 2738932                    /lib64/libc-2.31.so
7fe4f5f41000-7fe4f5f43000 rw-p 001b9000 fd:01 2738932                    /lib64/libc-2.31.so
...

Here, the correct base of a.out is 0x00400000 and the libc base is 0x7fe4f5d87000. But this patch would make them be detected as 0x00401000 and 0x7fe4f5da9000, respectively.

Mon, Aug 24, 11:54 AM · Restricted Project
clayborg committed rG0e6c9a6e7940: Add hashing of the .text section to ProcessMinidump. (authored by clayborg).
Add hashing of the .text section to ProcessMinidump.
Mon, Aug 24, 11:44 AM
clayborg closed D86261: Add hashing of the .text section to ProcessMinidump..
Mon, Aug 24, 11:44 AM · Restricted Project

Aug 21 2020

clayborg requested review of D86375: Load correct module for linux and android when duplicates exist in minidump..
Aug 21 2020, 2:51 PM · Restricted Project
clayborg requested changes to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

Lots of little things regarding the encoding and format of the JSON.

Aug 21 2020, 1:02 PM · Restricted Project, Restricted Project
clayborg updated the diff for D86261: Add hashing of the .text section to ProcessMinidump..

Added a test case with a 1 byte .text section that will overflow into the 15 bytes of the .data section that follows. This will test the overflow case that was requested.

Aug 21 2020, 12:05 PM · Restricted Project
clayborg accepted D86292: [LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class.
Aug 21 2020, 10:46 AM · Restricted Project

Aug 20 2020

clayborg requested changes to D86292: [LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class.

Patch looks good. Just need to test 32 bit RISC as well with a "lldb/test/Shell/ObjectFile/ELF/riscv32-arch.yaml" to verify 32 bit is working.

Aug 20 2020, 2:46 PM · Restricted Project
clayborg added a comment to D86261: Add hashing of the .text section to ProcessMinidump..

Hopefully this should be good to go, let me know if anyone has any issues.

Aug 20 2020, 2:30 PM · Restricted Project
clayborg updated the diff for D86261: Add hashing of the .text section to ProcessMinidump..

Fixed:

  • Use a safer method to read the data we need for the .text section in case we need and extra 15 bytes.
  • Rephrase confusing comment
Aug 20 2020, 2:28 PM · Restricted Project
clayborg added inline comments to D86261: Add hashing of the .text section to ProcessMinidump..
Aug 20 2020, 2:12 PM · Restricted Project
clayborg added inline comments to D86261: Add hashing of the .text section to ProcessMinidump..
Aug 20 2020, 2:10 PM · Restricted Project

Aug 19 2020

clayborg requested review of D86261: Add hashing of the .text section to ProcessMinidump..
Aug 19 2020, 8:56 PM · Restricted Project
clayborg added a comment to D85988: Fix the ability to list iOS simulator processes..

Adrian: is there something I need to do to enable simulator tests? I added a test to TestSimulatorPlatform.py but if I run:

$ ../debug/bin/llvm-lit -sv lldb/test/API/macosx/simulator
llvm-lit: /Users/gclayton/Documents/src/lldb/mono/llvm-project/lldb/test/API/lit.cfg.py:147: warning: Could not set a default per-test timeout. Requires the Python psutil module but it could not be found. Try installing it via pip or via your operating system's package manager.

Testing Time: 19.61s
  Unsupported: 1

1 warning(s) in tests

It is unsupported? I am running this on a mac. Do I need to launch a simulator first? Extra arguments to the test suite?

No, the tests are supposed to run. Green dragon (which is running a consumer macOS + consumer Xcode) is running this test. I know because it sometimes fails because it couldn't launch the simulator :-(
The test was XFAILed a few weeks ago — is your LLVM up-to-date?

It was up to date. Can you run my invocation on your lldb?:

../debug/bin/llvm-lit -sv lldb/test/API/macosx/simulator

That works for me, but it looks like you're using the standalone/Xcode build, so maybe that's borked somehow :(

Aug 19 2020, 12:45 PM · Restricted Project
clayborg added a comment to D85988: Fix the ability to list iOS simulator processes..

Adrian: is there something I need to do to enable simulator tests? I added a test to TestSimulatorPlatform.py but if I run:

$ ../debug/bin/llvm-lit -sv lldb/test/API/macosx/simulator
llvm-lit: /Users/gclayton/Documents/src/lldb/mono/llvm-project/lldb/test/API/lit.cfg.py:147: warning: Could not set a default per-test timeout. Requires the Python psutil module but it could not be found. Try installing it via pip or via your operating system's package manager.

Testing Time: 19.61s
  Unsupported: 1

1 warning(s) in tests

It is unsupported? I am running this on a mac. Do I need to launch a simulator first? Extra arguments to the test suite?

No, the tests are supposed to run. Green dragon (which is running a consumer macOS + consumer Xcode) is running this test. I know because it sometimes fails because it couldn't launch the simulator :-(
The test was XFAILed a few weeks ago — is your LLVM up-to-date?

Aug 19 2020, 12:30 PM · Restricted Project
clayborg requested changes to D84974: Enable Launching the Debugee in VSCode Terminal.

All of the code looks good now and we need to add a test. This means we will need to modify vscode.py in the test suite to be able to received the reverse request and just launch the process. We don't need to launch the program in a terminal, just spawn the process using subprocess.

Aug 19 2020, 11:46 AM · Restricted Project

Aug 18 2020

clayborg added inline comments to D84974: Enable Launching the Debugee in VSCode Terminal.
Aug 18 2020, 1:41 PM · Restricted Project
clayborg added inline comments to D84974: Enable Launching the Debugee in VSCode Terminal.
Aug 18 2020, 1:30 PM · Restricted Project
clayborg committed rG08748d15b8d6: Fix a check that was attempting to see if an object file was in memory. (authored by clayborg).
Fix a check that was attempting to see if an object file was in memory.
Aug 18 2020, 1:24 PM
clayborg closed D86122: Fix a check that was attempting to see if an object file was in memory..
Aug 18 2020, 1:24 PM · Restricted Project
clayborg added inline comments to D84974: Enable Launching the Debugee in VSCode Terminal.
Aug 18 2020, 1:05 PM · Restricted Project

Aug 17 2020

clayborg requested review of D86122: Fix a check that was attempting to see if an object file was in memory..
Aug 17 2020, 5:34 PM · Restricted Project
clayborg added a comment to D85988: Fix the ability to list iOS simulator processes..

Adrian: is there something I need to do to enable simulator tests? I added a test to TestSimulatorPlatform.py but if I run:

Aug 17 2020, 2:38 PM · Restricted Project
clayborg updated the diff for D85988: Fix the ability to list iOS simulator processes..

Added a "platform process list" test to each simulator test to test this functionality.

Aug 17 2020, 2:36 PM · Restricted Project
clayborg added a comment to D86106: [lldb] avoid assert in threadsanitizer tests on linux.

LGTM, but Kuba should ok this one since he does more ASAN and TSAN stuff.

Aug 17 2020, 2:09 PM · Restricted Project
clayborg accepted D85290: [lldb][gui] use left/right in the source view to scroll.

Sorry for the delay! LGTM.

Aug 17 2020, 2:07 PM · Restricted Project

Aug 14 2020

clayborg requested changes to D84974: Enable Launching the Debugee in VSCode Terminal.

So there is a lot of noise in this patch that is just reformatting on code that hasn't changed. It would be nice to get rid of any changes that are whitespace/indentation/formatting only. Also see inlined comments for needed changes.

Aug 14 2020, 4:32 PM · Restricted Project
clayborg requested review of D85988: Fix the ability to list iOS simulator processes..
Aug 14 2020, 11:53 AM · Restricted Project

Aug 12 2020

clayborg updated the diff for D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

Fix inline comment issues from vsk.

Aug 12 2020, 1:50 PM · Restricted Project, Restricted Project

Aug 11 2020

clayborg added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..
In D85705#2211073, @vsk wrote:

This looks very cool, thanks @clayborg! I think using JSON to describe the trace data (what kind of trace is this, what's in it, etc.) sounds reasonable.

For "trace load", I get the plugin for the JSON file by matching it up with the "name" field in the JSON, but I don't store the "trace_sp" anywhere. We will need to store it with the target that we create, or for later commands add it to a target that is stopped when the trace data is loaded via the process interface (through lldb-server is the current thinking for this).

Have you considered what might happen if there are multiple targets covered by a single trace? Strawman proposal: would it make sense to register the trace with a Debugger instance? This can be a list of traces if it makes sense to support debugging more than one trace at a time.

Aug 11 2020, 2:31 PM · Restricted Project, Restricted Project
clayborg added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

The idea for the JSON file is that it must have a "name" (or maybe "plug-in"?) to identify which trace plug-in and a "trace-file" at the very least:

Aug 11 2020, 11:29 AM · Restricted Project, Restricted Project

Aug 10 2020

clayborg retitled D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages. from First patch that adds processor trace. to Add a "Trace" plug-in to LLDB to add process trace support in stages..
Aug 10 2020, 9:37 PM · Restricted Project, Restricted Project
clayborg added a comment to D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..

Unresolved issues in this patch:

  • For "trace load", I get the plugin for the JSON file by matching it up with the "name" field in the JSON, but I don't store the "trace_sp" anywhere. We will need to store it with the target that we create, or for later commands add it to a target that is stopped when the trace data is loaded via the process interface (through lldb-server is the current thinking for this).
  • "trace dump" does nothing for now, but this is what we can use to test that "trace load" worked and was able to create a target.
Aug 10 2020, 9:36 PM · Restricted Project, Restricted Project
clayborg requested review of D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages..
Aug 10 2020, 9:32 PM · Restricted Project, Restricted Project

Aug 5 2020

clayborg accepted D85286: [lldb][gui] use names for color pairs, instead of magic numbers.
Aug 5 2020, 3:50 PM · Restricted Project
clayborg added a comment to D85145: Use syntax highlighting also in gui mode.

LGTM. Raphael? You have any more comments?

Aug 5 2020, 3:50 PM · Restricted Project
clayborg accepted D85123: Truncate long lines/names if needed in lldb gui.
Aug 5 2020, 3:48 PM · Restricted Project
clayborg committed rGe1de85f9f4da: Add verification for DW_AT_decl_file and DW_AT_call_file. (authored by clayborg).
Add verification for DW_AT_decl_file and DW_AT_call_file.
Aug 5 2020, 3:30 PM
clayborg closed D84817: Add verification for DW_AT_decl_file and DW_AT_call_file..
Aug 5 2020, 3:30 PM · Restricted Project

Aug 4 2020

clayborg added inline comments to D84817: Add verification for DW_AT_decl_file and DW_AT_call_file..
Aug 4 2020, 10:00 PM · Restricted Project
clayborg updated the diff for D84817: Add verification for DW_AT_decl_file and DW_AT_call_file..

Made DWARFDebugLine::Prologue::getLastValidFileIndex() and DWARFDebugLine::getLastValidFileIndex() return an Optional<uint64_t> and modified the error message for when a file index is out of range to specify the valid range, or specify that there are no files in the prologue file table. Added a test to cover this case as well.

Aug 4 2020, 9:59 PM · Restricted Project
clayborg accepted D85107: Add a test for 'b' (toggle breakpoint).

Sounds like it is ok for tests to be here, looks good.

Aug 4 2020, 5:24 PM · Restricted Project
clayborg accepted D85106: Move TestGuiBasicDebug.py to lldb/test and update it.

Ok, if other tests are in there, I am fine with this move.

Aug 4 2020, 5:22 PM · Restricted Project
clayborg added inline comments to D85123: Truncate long lines/names if needed in lldb gui.
Aug 4 2020, 4:17 PM · Restricted Project
clayborg added a comment to D85107: Add a test for 'b' (toggle breakpoint).

lldb/test/API is for testing the public LLDB API functions that are exported as lldb::SB*. Not sure this belongs here. There was another patch that was moving things around as well where I commented with the same issue.

Aug 4 2020, 4:10 PM · Restricted Project
clayborg added a comment to D85106: Move TestGuiBasicDebug.py to lldb/test and update it.

lldb/test/API is usually for testing the lldb::SB* interfaces IIRC. So not sure this move makes sense?

Aug 4 2020, 4:08 PM · Restricted Project
clayborg accepted D85098: Implement breakpoint removal on breakpoint toggling in lldb gui.
Aug 4 2020, 4:05 PM · Restricted Project
clayborg accepted D85089: Implement shift+tab for going back in lldb gui views.

A few nits inlined.

Aug 4 2020, 4:02 PM · Restricted Project
clayborg accepted D85088: Implement TerminalSizeChanged() for lldb ncurses GUI.
Aug 4 2020, 3:59 PM · Restricted Project
clayborg added a comment to D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/.

I am not a cmake expert. Might be a good idea to check the git log for people with more cmake expertise?

Aug 4 2020, 2:42 PM · Restricted Project
clayborg added inline comments to D85145: Use syntax highlighting also in gui mode.
Aug 4 2020, 2:38 PM · Restricted Project
clayborg accepted D84966: Remove special Hexagon packet traversal code.
Aug 4 2020, 2:28 PM · Restricted Project

Aug 3 2020

clayborg accepted D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View.
Aug 3 2020, 5:36 PM · Restricted Project, Restricted Project
clayborg added a comment to D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View.

Looks better. Can we test this?

Aug 3 2020, 3:26 PM · Restricted Project, Restricted Project

Jul 31 2020

clayborg added a comment to D84817: Add verification for DW_AT_decl_file and DW_AT_call_file..

Anymore issues with this patch?

Jul 31 2020, 1:10 PM · Restricted Project

Jul 30 2020

clayborg added inline comments to D84974: Enable Launching the Debugee in VSCode Terminal.
Jul 30 2020, 4:51 PM · Restricted Project
clayborg requested changes to D84974: Enable Launching the Debugee in VSCode Terminal.

So there is a fundamental change needed for this patch to work. I tried to fully detail this in the inline comments. Let me know if you have any questions.

Jul 30 2020, 4:46 PM · Restricted Project
clayborg updated the diff for D84817: Add verification for DW_AT_decl_file and DW_AT_call_file..

Added else braces back.

Jul 30 2020, 12:45 PM · Restricted Project
clayborg accepted D84972: Force full gui redraw on Ctrl+L.
Jul 30 2020, 12:37 PM · Restricted Project
clayborg added a comment to D84966: Remove special Hexagon packet traversal code.

LGTM after fixing clang format related changes seen in "Lint: Pre-merge checks"

Jul 30 2020, 12:35 PM · Restricted Project

Jul 29 2020

clayborg added a comment to D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View.

This seems very x86 centric. I forwarded a few examples of ARM and ARM64 disassembly to Yifan so we can improve some of the regexes.

Jul 29 2020, 1:24 PM · Restricted Project, Restricted Project
clayborg accepted D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Thanks again for working on this. I will review any subsequent patches as they come in if you have any more contributions. Sorry for the long delay again, I had 3 months that I was out due to the head injury, hopefully this won't happen again!

Jul 29 2020, 1:02 PM · Restricted Project
clayborg accepted D68909: change shortcut for 'step out' from 'o' to 'f'.
Jul 29 2020, 1:00 PM · Restricted Project
clayborg accepted D68908: remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts.
Jul 29 2020, 1:00 PM · Restricted Project
clayborg added a comment to D84817: Add verification for DW_AT_decl_file and DW_AT_call_file..

Marked things as done.

Jul 29 2020, 12:57 PM · Restricted Project
clayborg updated the diff for D84817: Add verification for DW_AT_decl_file and DW_AT_call_file..

Fixed inline comments:

  • switched yaml files over to use ELF
  • remove unneeded brackets
  • renamed some variables
Jul 29 2020, 12:56 PM · Restricted Project

Jul 28 2020

clayborg requested review of D84817: Add verification for DW_AT_decl_file and DW_AT_call_file..
Jul 28 2020, 6:32 PM · Restricted Project

Jul 27 2020

clayborg added a comment to D84402: [lldb/DWARF] Add more line table validation.

I really like the idea of coming up with a low PC that is the first valid .text address. This will filter out many of the zeroed out dead stripped DWARF and will make a cheap way for us to check addresses when parsing debug info and line tables. Checking for -1 and -2 of course is great to do as well.

Jul 27 2020, 12:52 PM · Restricted Project

Jul 25 2020

clayborg added a comment to D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Yikes, sorry for not responding for so long. In the fall I was out on medical leave due to a head injury. Please feel free to ping more often if I do this again. I commented in the other patches (one accepted, and questions in the other). Let me know your thoughts.

Jul 25 2020, 3:54 PM · Restricted Project