Page MenuHomePhabricator

bjope (Bjorn Pettersson)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 26 2016, 7:58 AM (151 w, 1 d)

Recent Activity

Today

bjope updated subscribers of D66396: [TableGen] Correct comments for end of namespace. NFC.

Basically I assume that nobody really cares about formatting and comments in generated code (so in one sense this is stupd, and in another sense it won't hurt much either).

Tue, Aug 20, 12:18 PM · Restricted Project

Yesterday

bjope added inline comments to rL369159: [Attributor] Fix: Make sure we set the changed flag.
Mon, Aug 19, 10:52 PM
bjope added inline comments to rL369159: [Attributor] Fix: Make sure we set the changed flag.
Mon, Aug 19, 9:45 AM

Sun, Aug 18

bjope created D66396: [TableGen] Correct comments for end of namespace. NFC.
Sun, Aug 18, 12:07 PM · Restricted Project

Sat, Aug 17

bjope added a comment to D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.

Code changes basically looks good to me, but I have no idea about:

  • the expected gain
  • if this is handled elsewhere (or if it should be)
  • if there is a (high) cost related to "not preserving the CFG"
Sat, Aug 17, 1:57 PM · Restricted Project

Fri, Aug 16

bjope committed rG9dddd26e31ae: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT (authored by bjope).
[DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT
Fri, Aug 16, 6:17 AM
bjope committed rG6a75061e36fe: [X86] Add test case for future MULFIX DAG combine folds. NFC (authored by bjope).
[X86] Add test case for future MULFIX DAG combine folds. NFC
Fri, Aug 16, 6:17 AM
bjope committed rL369103: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.
[DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT
Fri, Aug 16, 6:17 AM
bjope closed D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.
Fri, Aug 16, 6:17 AM · Restricted Project
bjope committed rL369102: [X86] Add test case for future MULFIX DAG combine folds. NFC.
[X86] Add test case for future MULFIX DAG combine folds. NFC
Fri, Aug 16, 6:17 AM
bjope added a comment to D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.

LGTM - do we have constant folding coverage btw?

Fri, Aug 16, 4:41 AM · Restricted Project

Thu, Aug 15

bjope added inline comments to D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.
Thu, Aug 15, 2:42 PM · Restricted Project
bjope added inline comments to D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.
Thu, Aug 15, 11:48 AM · Restricted Project
bjope added a comment to D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.

It seems like widening vector legalization for X86 can introduce fixed point multiplication of undef values. So that is one way that such operations could appear during ISel.

Thu, Aug 15, 11:46 AM · Restricted Project
bjope updated the diff for D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.

Update mulfix_combine.ll test case to show diffs compared to trunk.

Thu, Aug 15, 11:44 AM · Restricted Project

Tue, Aug 13

bjope added a reviewer for D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT: spatel.
Tue, Aug 13, 11:16 PM · Restricted Project

Sun, Aug 11

bjope updated the diff for D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.

Corrected a code comment typo.

Sun, Aug 11, 12:35 PM · Restricted Project
bjope committed rG27038a378060: [SelectionDAG] Widen vector results of SMULFIX/UMULFIX/SMULFIXSAT (authored by bjope).
[SelectionDAG] Widen vector results of SMULFIX/UMULFIX/SMULFIXSAT
Sun, Aug 11, 12:29 PM
bjope committed rGcf9fa0b382d5: [X86] Remove redundant ';' chars ending IR lines in lit tests. NFC (authored by bjope).
[X86] Remove redundant ';' chars ending IR lines in lit tests. NFC
Sun, Aug 11, 12:29 PM
bjope committed rL368541: [X86] Remove redundant ';' chars ending IR lines in lit tests. NFC.
[X86] Remove redundant ';' chars ending IR lines in lit tests. NFC
Sun, Aug 11, 12:29 PM
bjope committed rL368540: [SelectionDAG] Widen vector results of SMULFIX/UMULFIX/SMULFIXSAT.
[SelectionDAG] Widen vector results of SMULFIX/UMULFIX/SMULFIXSAT
Sun, Aug 11, 12:29 PM
bjope closed D66053: [X86] Remove redundant ';' chars ending IR lines in lit tests. NFC.
Sun, Aug 11, 12:29 PM · Restricted Project
bjope closed D66051: [SelectionDAG] Widen vector results of SMULFIX/UMULFIX/SMULFIXSAT.
Sun, Aug 11, 12:29 PM · Restricted Project

Sat, Aug 10

bjope added inline comments to D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.
Sat, Aug 10, 5:58 AM · Restricted Project
bjope created D66053: [X86] Remove redundant ';' chars ending IR lines in lit tests. NFC.
Sat, Aug 10, 5:34 AM · Restricted Project
bjope created D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.
Sat, Aug 10, 5:33 AM · Restricted Project
bjope created D66051: [SelectionDAG] Widen vector results of SMULFIX/UMULFIX/SMULFIXSAT.
Sat, Aug 10, 5:33 AM · Restricted Project

Fri, Aug 9

bjope committed rGd218a3326e71: [InstSimplify] Report "Changed" also when only deleting dead instructions (authored by bjope).
[InstSimplify] Report "Changed" also when only deleting dead instructions
Fri, Aug 9, 12:09 AM
bjope committed rL368401: [InstSimplify] Report "Changed" also when only deleting dead instructions.
[InstSimplify] Report "Changed" also when only deleting dead instructions
Fri, Aug 9, 12:09 AM
bjope closed D65973: [InstSimplify] Report "Changed" also when only deleting dead instructions.
Fri, Aug 9, 12:09 AM · Restricted Project

Thu, Aug 8

bjope added inline comments to D65336: [InstSimplify] remove quadratic time looping (PR42771).
Thu, Aug 8, 2:16 PM · Restricted Project
bjope created D65973: [InstSimplify] Report "Changed" also when only deleting dead instructions.
Thu, Aug 8, 2:12 PM · Restricted Project
bjope added inline comments to D65336: [InstSimplify] remove quadratic time looping (PR42771).
Thu, Aug 8, 1:42 PM · Restricted Project
bjope committed rG4dbbb734848b: Fix check in tools/gold/X86/strip_names.ll regarding unnamed args (authored by bjope).
Fix check in tools/gold/X86/strip_names.ll regarding unnamed args
Thu, Aug 8, 5:12 AM
bjope committed rL368281: Fix check in tools/gold/X86/strip_names.ll regarding unnamed args.
Fix check in tools/gold/X86/strip_names.ll regarding unnamed args
Thu, Aug 8, 5:12 AM

Sun, Jul 28

bjope added a comment to D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach.

I made another fixup (similar to https://reviews.llvm.org/rL367176) here https://reviews.llvm.org/rL367182.

Can someone please take a look (a post-commit review) of https://reviews.llvm.org/rL367182 to verify that I did not misunderstand the intention with the test somehow?

Looks good. Thanks much for the fix!

Sun, Jul 28, 11:07 AM · Restricted Project

Sat, Jul 27

bjope added a comment to D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach.

I made another fixup (similar to https://reviews.llvm.org/rL367176) here https://reviews.llvm.org/rL367182.

Sat, Jul 27, 1:27 PM · Restricted Project
bjope committed rG197c08d64ee5: [Driver] Additional fixup of NOWARN test case from r367165 (authored by bjope).
[Driver] Additional fixup of NOWARN test case from r367165
Sat, Jul 27, 1:24 PM
bjope committed rL367182: [Driver] Additional fixup of NOWARN test case from r367165.
[Driver] Additional fixup of NOWARN test case from r367165
Sat, Jul 27, 1:22 PM
bjope added a comment to rL367176: Attempt to make test in r367165 more robust..

I think the problem is related to the RUN line at line 76.

Sat, Jul 27, 10:50 AM
bjope committed rGf0f63cab7f5b: [clangd] Fix NDEBUG build problem introduced by rL366698 (authored by bjope).
[clangd] Fix NDEBUG build problem introduced by rL366698
Sat, Jul 27, 10:11 AM
bjope committed rG60c1ee23ffbc: [Driver] Fix "unannotated fall-through between switch labels". NFC (authored by bjope).
[Driver] Fix "unannotated fall-through between switch labels". NFC
Sat, Jul 27, 10:11 AM
bjope added a comment to D65073: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp.

Since this patch we get

../../clang-tools-extra/clangd/Selection.cpp:80:13: error: unused function 'printNodeToString' [-Werror,-Wunused-function]
std::string printNodeToString(const DynTypedNode &N, const PrintingPolicy &PP) {
            ^
../../clang-tools-extra/clangd/Selection.cpp:351:25: error: private field 'PrintPolicy' is not used [-Werror,-Wunused-private-field]
  const PrintingPolicy &PrintPolicy;
                        ^
2 errors generated.

When building with -DNDEBUG and -Werror.

I guess we can sprinkle some ifndef NDEBUG in this file, but I'm not sure how these dlog statements normally are handled in clang-tools-extra. Should for example LLVM_ENABLE_DUMP also be used for clang-tools-extra?

Sat, Jul 27, 10:10 AM · Restricted Project
bjope committed rL367178: [clangd] Fix NDEBUG build problem introduced by rL366698.
[clangd] Fix NDEBUG build problem introduced by rL366698
Sat, Jul 27, 10:09 AM
bjope committed rL367177: [Driver] Fix "unannotated fall-through between switch labels". NFC.
[Driver] Fix "unannotated fall-through between switch labels". NFC
Sat, Jul 27, 10:09 AM
bjope added a comment to D65073: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp.

Since this patch we get

Sat, Jul 27, 1:40 AM · Restricted Project

Jul 9 2019

bjope committed rG051a6a1c33e1: [SelectionDAG] Simplify some calls to getSetCCResultType. NFC (authored by bjope).
[SelectionDAG] Simplify some calls to getSetCCResultType. NFC
Jul 9 2019, 3:29 AM
bjope committed rL365456: [SelectionDAG] Simplify some calls to getSetCCResultType. NFC.
[SelectionDAG] Simplify some calls to getSetCCResultType. NFC
Jul 9 2019, 3:29 AM
bjope committed rG59029017a665: [LegalizeTypes] Fix saturation bug for smul.fix.sat (authored by bjope).
[LegalizeTypes] Fix saturation bug for smul.fix.sat
Jul 9 2019, 3:26 AM
bjope committed rL365455: [LegalizeTypes] Fix saturation bug for smul.fix.sat.
[LegalizeTypes] Fix saturation bug for smul.fix.sat
Jul 9 2019, 3:25 AM
bjope closed D64331: [LegalizeTypes] Fix saturation bug for smul.fix.sat.
Jul 9 2019, 3:25 AM · Restricted Project

Jul 8 2019

bjope created D64331: [LegalizeTypes] Fix saturation bug for smul.fix.sat.
Jul 8 2019, 7:03 AM · Restricted Project

Jul 5 2019

bjope committed rG009225374a41: Bitstream reader: Fix undefined behavior seen after rL364464 (authored by bjope).
Bitstream reader: Fix undefined behavior seen after rL364464
Jul 5 2019, 1:26 PM
bjope committed rL365239: Bitstream reader: Fix undefined behavior seen after rL364464.
Bitstream reader: Fix undefined behavior seen after rL364464
Jul 5 2019, 1:25 PM
bjope closed D64262: Bitstream reader: Fix undefined behavior seen after rL364464.
Jul 5 2019, 1:25 PM · Restricted Project, Restricted Project
bjope added inline comments to D63518: BitStream reader: propagate errors.
Jul 5 2019, 1:13 PM · Restricted Project, Restricted Project
bjope created D64262: Bitstream reader: Fix undefined behavior seen after rL364464.
Jul 5 2019, 1:09 PM · Restricted Project, Restricted Project
bjope added inline comments to D63518: BitStream reader: propagate errors.
Jul 5 2019, 8:26 AM · Restricted Project, Restricted Project

Jul 3 2019

bjope added inline comments to D64084: [AArch64][GlobalISel] Teach tryOptSelect to handle G_ICMP.
Jul 3 2019, 11:19 AM · Restricted Project
bjope added a comment to D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.

What is the idea here? Just a refactoring to get rid of recursive calls? Or are you going to use the histogram for some other purposes?
(the patch is lacking description, but perhaps it's just a temporary hack an not something that is subject for submitting?)

Added comment into description, I hope to upload the patch which is going to use new function today.

FWIW, downstream we have 16-bit addressable units and we are tweaking isBytewiseValue to also support "16-bit bytes" in our fork. So far it has been quite simple to do such adjustments, and maybe it will be doable by using a 65536+1 entries large histogram as well.
I just got curious to what the plan is here (to understand if it is worth spending time on continuing to adapt to the upstream changes or if we simply should keep our current version that should be working for 16-bit splats).

I don't plan other changes in this code after this patch stack.

Jul 3 2019, 10:06 AM · Restricted Project
bjope added inline comments to D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Jul 3 2019, 10:04 AM · Restricted Project
bjope added a comment to D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.

What is the idea here? Just a refactoring to get rid of recursive calls? Or are you going to use the histogram for some other purposes?
(the patch is lacking description, but perhaps it's just a temporary hack an not something that is subject for submitting?)

Jul 3 2019, 9:50 AM · Restricted Project

Jun 27 2019

bjope added a comment to D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations.

LGTM as well.

Jun 27 2019, 2:35 AM · Restricted Project

Jun 24 2019

bjope updated subscribers of D63699: [llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI.
Jun 24 2019, 2:28 PM · Restricted Project
bjope committed rG3260ef16bbde: [AMDGPU] Remove unused variable AllSGPRSpilledToVGPRs. NFC (authored by bjope).
[AMDGPU] Remove unused variable AllSGPRSpilledToVGPRs. NFC
Jun 24 2019, 8:51 AM
bjope committed rL364190: [AMDGPU] Remove unused variable AllSGPRSpilledToVGPRs. NFC.
[AMDGPU] Remove unused variable AllSGPRSpilledToVGPRs. NFC
Jun 24 2019, 8:50 AM
bjope closed D63721: [AMDGPU] Remove unused variable AllSGPRSpilledToVGPRs. NFC.
Jun 24 2019, 8:50 AM · Restricted Project
bjope created D63721: [AMDGPU] Remove unused variable AllSGPRSpilledToVGPRs. NFC.
Jun 24 2019, 8:42 AM · Restricted Project
bjope committed rG485a421876d7: [ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC (authored by bjope).
[ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC
Jun 24 2019, 5:08 AM
bjope committed rG512b1187794d: [Scalarizer] Add scalarizer support for smul.fix.sat (authored by bjope).
[Scalarizer] Add scalarizer support for smul.fix.sat
Jun 24 2019, 5:08 AM
bjope committed rL364178: [ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC.
[ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC
Jun 24 2019, 5:07 AM
bjope closed D63705: [ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC.
Jun 24 2019, 5:07 AM · Restricted Project
bjope committed rL364177: [Scalarizer] Add scalarizer support for smul.fix.sat.
[Scalarizer] Add scalarizer support for smul.fix.sat
Jun 24 2019, 5:07 AM
bjope closed D63704: [Scalarizer] Add scalarizer support for smul.fix.sat.
Jun 24 2019, 5:07 AM · Restricted Project
bjope updated the diff for D63704: [Scalarizer] Add scalarizer support for smul.fix.sat.

Fixup in description of llvm::isTriviallyVectorizable.

Jun 24 2019, 4:30 AM · Restricted Project
bjope added reviewers for D63705: [ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC: RKSimon, dblaikie.
Jun 24 2019, 2:15 AM · Restricted Project
bjope added reviewers for D63704: [Scalarizer] Add scalarizer support for smul.fix.sat: RKSimon, dblaikie.
Jun 24 2019, 2:15 AM · Restricted Project
bjope added a parent revision for D63705: [ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC: D63704: [Scalarizer] Add scalarizer support for smul.fix.sat.
Jun 24 2019, 2:13 AM · Restricted Project
bjope added a child revision for D63704: [Scalarizer] Add scalarizer support for smul.fix.sat: D63705: [ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC.
Jun 24 2019, 2:13 AM · Restricted Project
bjope created D63705: [ConstantFolding] Use hasVectorInstrinsicScalarOpd. NFC.
Jun 24 2019, 1:54 AM · Restricted Project
bjope created D63704: [Scalarizer] Add scalarizer support for smul.fix.sat.
Jun 24 2019, 1:54 AM · Restricted Project

Jun 19 2019

bjope committed rG16ff5fea87ab: [ConstantFolding] Add constant folding for smul.fix and smul.fix.sat (authored by bjope).
[ConstantFolding] Add constant folding for smul.fix and smul.fix.sat
Jun 19 2019, 7:28 AM
bjope committed rGb81b9a4e7bf0: [ConstantFolding] Refactor ConstantFoldScalarCall. NFC (authored by bjope).
[ConstantFolding] Refactor ConstantFoldScalarCall. NFC
Jun 19 2019, 7:28 AM
bjope committed rL363811: [ConstantFolding] Add constant folding for smul.fix and smul.fix.sat.
[ConstantFolding] Add constant folding for smul.fix and smul.fix.sat
Jun 19 2019, 7:27 AM
bjope closed D63385: [ConstantFolding] Add constant folding for smul.fix and smul.fix.sat.
Jun 19 2019, 7:27 AM · Restricted Project
bjope committed rL363810: [ConstantFolding] Refactor ConstantFoldScalarCall. NFC.
[ConstantFolding] Refactor ConstantFoldScalarCall. NFC
Jun 19 2019, 7:27 AM

Jun 18 2019

bjope added inline comments to D63509: DAG: Use getStoreSize when expanding dynamic vector indexing.
Jun 18 2019, 1:30 PM
bjope added inline comments to D63509: DAG: Use getStoreSize when expanding dynamic vector indexing.
Jun 18 2019, 12:59 PM

Jun 17 2019

bjope committed rG83773b77a5a4: [LV] Deny irregular types in interleavedAccessCanBeWidened (authored by bjope).
[LV] Deny irregular types in interleavedAccessCanBeWidened
Jun 17 2019, 5:00 AM
bjope committed rL363547: [LV] Deny irregular types in interleavedAccessCanBeWidened.
[LV] Deny irregular types in interleavedAccessCanBeWidened
Jun 17 2019, 4:59 AM
bjope closed D63386: [LV] Deny irregular types in interleavedAccessCanBeWidened.
Jun 17 2019, 4:59 AM · Restricted Project

Jun 16 2019

bjope added a reviewer for D63386: [LV] Deny irregular types in interleavedAccessCanBeWidened: craig.topper.
Jun 16 2019, 8:36 AM · Restricted Project
bjope created D63386: [LV] Deny irregular types in interleavedAccessCanBeWidened.
Jun 16 2019, 8:35 AM · Restricted Project
bjope added a reviewer for D63385: [ConstantFolding] Add constant folding for smul.fix and smul.fix.sat: leonardchan.
Jun 16 2019, 8:26 AM · Restricted Project
bjope added a child revision for D63384: [ConstantFolding] Refactor ConstantFoldScalarCall. NFC: D63385: [ConstantFolding] Add constant folding for smul.fix and smul.fix.sat.
Jun 16 2019, 8:26 AM · Restricted Project
bjope created D63385: [ConstantFolding] Add constant folding for smul.fix and smul.fix.sat.
Jun 16 2019, 8:26 AM · Restricted Project
bjope added a parent revision for D63385: [ConstantFolding] Add constant folding for smul.fix and smul.fix.sat: D63384: [ConstantFolding] Refactor ConstantFoldScalarCall. NFC.
Jun 16 2019, 8:26 AM · Restricted Project
bjope created D63384: [ConstantFolding] Refactor ConstantFoldScalarCall. NFC.
Jun 16 2019, 8:26 AM · Restricted Project

Jun 10 2019

bjope added a comment to D62088: [compiler-rt][builtins] Scaled Integer log10().

Please add test cases for scale=0 and scale=width as I assume those need special handling (UB right now?).
And if scale=0 and scale=width needs special handling, then I guess scale=1 and scale=width-1 are new boundary values so I maybe it would be nice to have tests for those scales as well.

Jun 10 2019, 10:40 PM · Restricted Project, Restricted Project
bjope accepted D63083: [DebugInfo][Docs] Document that prologue/epilogue variable location changes are ignored.

Looks good to me (matching my assumptions about why prolog/epilog is special).
Just a minor nit inline.

Jun 10 2019, 10:38 AM · Restricted Project