Page MenuHomePhabricator

bjope (Bjorn Pettersson)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 26 2016, 7:58 AM (172 w, 5 d)

Recent Activity

Yesterday

bjope added inline comments to D72938: Fix an assertion failure in DwarfExpression's subregister composition.
Sat, Jan 18, 4:23 AM · Restricted Project, debug-info

Wed, Jan 15

bjope added a comment to D72733: [InstCombine] allow more narrowing of casted select.

Thanks for looking into this. I did not know about shouldChangeType but that seems like a useful function here.

Wed, Jan 15, 9:45 AM · Restricted Project

Tue, Jan 14

bjope added inline comments to D71550: [Intrinsic] Add fixed point saturating division intrinsics..
Tue, Jan 14, 12:17 AM · Restricted Project

Mon, Dec 30

bjope added a comment to D71657: [SDAG] Handle BUILD_PAIR in ComputeNumSignBits.

@danilaml for your original case, why isn't CodeGenPrepare helping by sinking the sext?

Mon, Dec 30, 3:20 PM · Restricted Project

Dec 19 2019

bjope committed rG89e3bb450263: [ConstantHoisting] Ignore unreachable bb:s when collecting candidates (authored by bjope).
[ConstantHoisting] Ignore unreachable bb:s when collecting candidates
Dec 19 2019, 6:15 AM
bjope closed D71678: [ConstantHoisting] Ignore unreachable bb:s when collecting candidates.
Dec 19 2019, 6:15 AM · Restricted Project
bjope added inline comments to D71678: [ConstantHoisting] Ignore unreachable bb:s when collecting candidates.
Dec 19 2019, 5:56 AM · Restricted Project

Dec 18 2019

bjope added inline comments to D71678: [ConstantHoisting] Ignore unreachable bb:s when collecting candidates.
Dec 18 2019, 3:07 PM · Restricted Project
bjope created D71678: [ConstantHoisting] Ignore unreachable bb:s when collecting candidates.
Dec 18 2019, 2:00 PM · Restricted Project
bjope added inline comments to D71389: [ConstantFold][SVE] Fix constant folding for bitcast..
Dec 18 2019, 6:52 AM · Restricted Project

Dec 16 2019

bjope committed rGe5f07080b8ac: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor (authored by bjope).
[BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor
Dec 16 2019, 2:49 AM
bjope committed rG632deb6bd040: [LoopRotate] Add test case to show dbg value problem (authored by bjope).
[LoopRotate] Add test case to show dbg value problem
Dec 16 2019, 2:49 AM
bjope closed D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor.
Dec 16 2019, 2:49 AM · Restricted Project
bjope closed D71479: [LoopRotate] Add test case to show dbg value problem.
Dec 16 2019, 2:49 AM · Restricted Project
bjope committed rG1c49553c19a7: [BasicBlockUtils] Add utility to remove redundant dbg.value instrs (authored by bjope).
[BasicBlockUtils] Add utility to remove redundant dbg.value instrs
Dec 16 2019, 2:49 AM
bjope closed D71478: [BasicBlockUtils] Add utility to remove redundant dbg.value instrs.
Dec 16 2019, 2:48 AM · Restricted Project

Dec 15 2019

bjope added inline comments to D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor.
Dec 15 2019, 6:27 AM · Restricted Project
bjope added inline comments to D71478: [BasicBlockUtils] Add utility to remove redundant dbg.value instrs.
Dec 15 2019, 6:20 AM · Restricted Project
bjope updated the diff for D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor.

Fix typo in code comments.

Dec 15 2019, 6:18 AM · Restricted Project
bjope updated the diff for D71478: [BasicBlockUtils] Add utility to remove redundant dbg.value instrs.

Update code comments.

Dec 15 2019, 6:18 AM · Restricted Project

Dec 13 2019

bjope created D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor.
Dec 13 2019, 10:24 AM · Restricted Project
bjope added inline comments to D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor.
Dec 13 2019, 10:24 AM · Restricted Project
bjope added a child revision for D71479: [LoopRotate] Add test case to show dbg value problem: D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor.
Dec 13 2019, 10:24 AM · Restricted Project
bjope added parent revisions for D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor: D71479: [LoopRotate] Add test case to show dbg value problem, D71478: [BasicBlockUtils] Add utility to remove redundant dbg.value instrs.
Dec 13 2019, 10:24 AM · Restricted Project
bjope added a child revision for D71478: [BasicBlockUtils] Add utility to remove redundant dbg.value instrs: D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor.
Dec 13 2019, 10:24 AM · Restricted Project
bjope created D71479: [LoopRotate] Add test case to show dbg value problem.
Dec 13 2019, 10:15 AM · Restricted Project
bjope created D71478: [BasicBlockUtils] Add utility to remove redundant dbg.value instrs.
Dec 13 2019, 10:15 AM · Restricted Project

Dec 12 2019

bjope added a comment to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

LGTM!
(if removing the unused VarInstPair/InstsToSink)

Dec 12 2019, 2:37 AM · Restricted Project
bjope added a comment to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.

Don't fully understand. This revision is closed, but latest diff is showing a new diff (not the one closed/reverted, right?). If I understand it correctly revision should be re-opened for review again, right?

Dec 12 2019, 2:07 AM · Restricted Project
bjope added a comment to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.

There are several other passes between isel and phi elimination. So if we now have a rule that there must not be any dbg instructions between PHI-nodes and labels that should be at the beginning of the MBB, then perhaps we need to add a check in MachineVerfier that the new rule is followed by all those passes.

Dec 12 2019, 12:53 AM · Restricted Project

Dec 11 2019

Herald updated subscribers of D71359: Fix assertion failure in getMemOperandWithOffsetWidth.
Dec 11 2019, 11:48 PM · Restricted Project

Dec 8 2019

bjope added a comment to D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.

LGTM!

Dec 8 2019, 5:13 AM · Restricted Project

Dec 3 2019

bjope added a comment to D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics.

Is it possible to do the WebAssembly updates in a separate patch, or is those changes dependent on also changing how CodeGenPrepare works?

Dec 3 2019, 2:10 AM · Restricted Project

Dec 2 2019

bjope added inline comments to D70676: [DebugInfo] Don't repeatedly created undef DBG_VALUEs during machine-sinking.
Dec 2 2019, 12:43 PM · Restricted Project
bjope committed rGa9d6b0e54447: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast))) (authored by bjope).
[InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast)))
Dec 2 2019, 2:14 AM
bjope closed D70844: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast))).
Dec 2 2019, 2:14 AM · Restricted Project

Nov 29 2019

bjope updated the diff for D70844: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast))).

Some more refactoring, very much inspired by the ideas from Roman.

Nov 29 2019, 2:59 PM · Restricted Project
bjope updated the diff for D70844: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast))).

Realized it was stupid to use a temporary vector when it is possible to simply use append. So a yet another minor refactoring.

Nov 29 2019, 8:35 AM · Restricted Project
bjope updated the diff for D70844: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast))).

Minor refactoring and added some more code comments.

Nov 29 2019, 8:17 AM · Restricted Project
bjope updated the diff for D70844: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast))).

Rebase after update to run cast.ll for both big and little endian.

Nov 29 2019, 5:04 AM · Restricted Project
bjope committed rG363cbcc59040: [InstCombine] Run the cast.ll test a twice, now also testing little endian. NFC (authored by bjope).
[InstCombine] Run the cast.ll test a twice, now also testing little endian. NFC
Nov 29 2019, 4:29 AM
bjope added inline comments to D70844: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast))).
Nov 29 2019, 4:17 AM · Restricted Project
bjope created D70844: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast))).
Nov 29 2019, 1:44 AM · Restricted Project

Nov 28 2019

bjope updated subscribers of D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.
Nov 28 2019, 12:21 AM · Restricted Project

Nov 26 2019

bjope added a comment to D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A..

Hi @sammccall .
Just a heads up. Looks like this might have caused: https://bugs.llvm.org/show_bug.cgi?id=44143 .

Nov 26 2019, 8:27 AM · Restricted Project

Nov 24 2019

bjope added inline comments to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.
Nov 24 2019, 3:08 PM · Restricted Project
bjope added inline comments to D70597: [PHIEliminate] skip dbg instruction when LowerPHINode.
Nov 24 2019, 2:50 PM · Restricted Project

Nov 21 2019

bjope committed rG898de302919b: [BranchFolding] Fix PR43964 about branch folder not being debug invariant (authored by bjope).
[BranchFolding] Fix PR43964 about branch folder not being debug invariant
Nov 21 2019, 9:16 AM
bjope closed D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.
Nov 21 2019, 9:16 AM · Restricted Project
bjope added a comment to D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.

Thanks for the LGTM, and the earlier review comments. Your idea about using skipDebugInstructionsForward simplified things even more! :-)

Nov 21 2019, 8:57 AM · Restricted Project
bjope added a comment to D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.

This looks good to me and great refactor. To make sure I understand what's going on: by keeping a temporary iterator in ComputeCommonTailLength, and only "committing" the advance to I1/I2 when we're sure we've found some additional identical tail, this avoids all the concerns about I1/I2 ending up pointing at pseudo instructions?

Nov 21 2019, 8:52 AM · Restricted Project
bjope added inline comments to D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.
Nov 21 2019, 8:47 AM · Restricted Project
bjope updated the diff for D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.

Update based on review comments.

Nov 21 2019, 8:43 AM · Restricted Project

Nov 15 2019

bjope added inline comments to D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.
Nov 15 2019, 9:21 AM · Restricted Project
bjope updated the summary of D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.
Nov 15 2019, 8:27 AM · Restricted Project
bjope added reviewers for D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant: probinson, yechunliang, jmorse.
Nov 15 2019, 8:27 AM · Restricted Project
bjope retitled D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant from WIP: BlockFolding not debug invariant (PR43964) to [BranchFolding] Fix PR43964 about branch folder not being debug invariant.
Nov 15 2019, 8:27 AM · Restricted Project
bjope updated the diff for D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.

Cleaned up. No longer WIP. Ready for review.

Nov 15 2019, 8:27 AM · Restricted Project

Nov 14 2019

bjope accepted D70171: [Scalarizer] Treat values from unreachable blocks as undef.

LGTM!

Nov 14 2019, 10:56 PM · Restricted Project

Nov 11 2019

bjope created D70091: [BranchFolding] Fix PR43964 about branch folder not being debug invariant.
Nov 11 2019, 9:36 AM · Restricted Project
bjope added a comment to D66467: [Codegen] skip debug instr to avoid code change.

name: test3
body: |
bb.0:

TEST8rr killed renamable $al, renamable $al, implicit-def $eflags
JCC_1 %bb.1, 5, implicit killed $eflags

from the test case, the JCC should be bb.2, as below, right?

JCC_1 %bb.2, 5, implicit killed $eflags

Nov 11 2019, 9:17 AM · Restricted Project

Nov 9 2019

bjope added inline comments to D64630: [DebugInfo] Address performance regression with r364515.
Nov 9 2019, 6:08 AM · Restricted Project

Nov 7 2019

bjope added a comment to D66467: [Codegen] skip debug instr to avoid code change.

Here is an test case that currently fail. The test1, test2 and test3 functions only differ by DBG_VALUE and CFI_INSTRUCTION instructions. So I guess we want to see the same real instructions being generated for all three functions.

Nov 7 2019, 7:32 AM · Restricted Project
bjope added a comment to D66467: [Codegen] skip debug instr to avoid code change.

Unfortunately I see a lot more test cases failing due to codegen not being debug invariant after having merged this patch, compared to the past.

Nov 7 2019, 7:23 AM · Restricted Project

Nov 3 2019

bjope committed rGe2549a0a2517: [DebugInfo] Fix for DW_OP_LLVM_fragment in DIExpression::isImplicit() (authored by bjope).
[DebugInfo] Fix for DW_OP_LLVM_fragment in DIExpression::isImplicit()
Nov 3 2019, 9:04 AM

Nov 1 2019

bjope committed rG56c22931bdfa: [LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by InlineSpiller (authored by bjope).
[LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by InlineSpiller
Nov 1 2019, 8:45 AM
bjope closed D69584: [LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by InlineSpiller.
Nov 1 2019, 8:44 AM · Restricted Project

Oct 31 2019

bjope added a comment to D69656: [IPCP] Bail on extractvalue's with more than 1 index..

Besides the point: I didn't know anyone was still using this pass. Actually I was going to propose to delete it soon. Is there a desire to keep it or would people switch to IP-SCCP and/or the Attributor (assuming they subsume the functionality)? The one reason to keep this pass is that it is simple and "fast" but it's questionable if that is useful if we run either of the other ones anyway.

The patch LGTM.

Oct 31 2019, 11:40 AM · Restricted Project

Oct 30 2019

bjope added a comment to D69584: [LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by InlineSpiller.

LGTM; I wonder whether there are other places in the register allocator that need to notify LDV of what's happening, but I don't know enough about allocators.

Oct 30 2019, 12:10 PM · Restricted Project
bjope added a comment to D69028: [DebugInfo] Correctly place DW_OP_derefs for arguments passed on stack.

Ah blast, I mentally filed this under "things to push upwards when there's spare time" as opposed to "a regression that needs fixing". Sorry for the delay, I'll give it a kick now.

Oct 30 2019, 11:31 AM · Restricted Project
bjope updated the diff for D69584: [LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by InlineSpiller.

Addressed review comments.

Oct 30 2019, 10:51 AM · Restricted Project
bjope added inline comments to D64630: [DebugInfo] Address performance regression with r364515.
Oct 30 2019, 10:51 AM · Restricted Project
bjope added a comment to D69028: [DebugInfo] Correctly place DW_OP_derefs for arguments passed on stack.

(Reverse ping!) Any reason why this hasn't landed yet?

Oct 30 2019, 10:26 AM · Restricted Project
bjope added inline comments to D69584: [LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by InlineSpiller.
Oct 30 2019, 8:52 AM · Restricted Project

Oct 29 2019

bjope created D69584: [LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by InlineSpiller.
Oct 29 2019, 1:32 PM · Restricted Project
bjope updated subscribers of D68816: [NFC] Replace a linked list in LiveDebugVariables pass with a DenseMap.
Oct 29 2019, 3:19 AM · Restricted Project, debug-info

Oct 28 2019

bjope committed rG80cb2cecc657: [utils] InlineFunction: fix for debug info affecting optimizations (authored by bjope).
[utils] InlineFunction: fix for debug info affecting optimizations
Oct 28 2019, 10:19 AM
bjope closed D68633: [utils] InlineFunction: fix for debug info affecting optimizations.
Oct 28 2019, 10:19 AM · Restricted Project
bjope added a comment to D68633: [utils] InlineFunction: fix for debug info affecting optimizations.

@bjope thanks for help, to be honest, I don't know the process or execution of commit, I thought I have no commit permission right now.

Oct 28 2019, 8:33 AM · Restricted Project
bjope added a comment to D68633: [utils] InlineFunction: fix for debug info affecting optimizations.

Not sure why this isn't in "Accepted" state. I know @aprantl and @vsk asked for a new revision on an earlier diff. So is it perhaps because not all comments have been marked as "Done"?

Oct 28 2019, 5:59 AM · Restricted Project
bjope added a comment to D66467: [Codegen] skip debug instr to avoid code change.

Looks like this one was accepted a long time ago. But I can't see that it has been committed yet. So what is the status?

Oct 28 2019, 5:54 AM · Restricted Project

Oct 23 2019

bjope added inline comments to D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement..
Oct 23 2019, 4:10 PM · Restricted Project

Oct 22 2019

bjope added inline comments to D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement..
Oct 22 2019, 12:58 PM · Restricted Project
bjope added inline comments to D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement..
Oct 22 2019, 12:49 PM · Restricted Project

Oct 21 2019

bjope committed rG78424e5f8417: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC (authored by bjope).
Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC
Oct 21 2019, 11:05 AM
bjope closed D69262: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC.
Oct 21 2019, 11:05 AM · Restricted Project
bjope committed rL375438: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC.
Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC
Oct 21 2019, 10:56 AM
bjope committed rG1f43ea41c330: Prune Pass.h include from DataLayout.h. NFCI (authored by bjope).
Prune Pass.h include from DataLayout.h. NFCI
Oct 21 2019, 10:56 AM
bjope committed rL375436: Prune Pass.h include from DataLayout.h. NFCI.
Prune Pass.h include from DataLayout.h. NFCI
Oct 21 2019, 10:56 AM
bjope closed D69261: Prune Pass.h include from DataLayout.h. NFCI.
Oct 21 2019, 10:55 AM · Restricted Project, Restricted Project
bjope created D69262: Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC.
Oct 21 2019, 7:58 AM · Restricted Project
bjope created D69261: Prune Pass.h include from DataLayout.h. NFCI.
Oct 21 2019, 7:53 AM · Restricted Project, Restricted Project
bjope accepted D68633: [utils] InlineFunction: fix for debug info affecting optimizations.

Thanks for the patience with all my remarks, turning this around completely compared to the original patch.

Oct 21 2019, 5:57 AM · Restricted Project

Oct 18 2019

bjope added a comment to D68633: [utils] InlineFunction: fix for debug info affecting optimizations.

Thanks! I like this solution.

Oct 18 2019, 5:08 AM · Restricted Project
bjope committed rG6456252dbf67: [InstCombine] Fix miscompile bug in canEvaluateShuffled (authored by bjope).
[InstCombine] Fix miscompile bug in canEvaluateShuffled
Oct 18 2019, 12:46 AM
bjope committed rG459134064dae: [InstCombine] Pre-commit of test case showing miscompile bug in… (authored by bjope).
[InstCombine] Pre-commit of test case showing miscompile bug in…
Oct 18 2019, 12:46 AM
bjope committed rL375208: [InstCombine] Fix miscompile bug in canEvaluateShuffled.
[InstCombine] Fix miscompile bug in canEvaluateShuffled
Oct 18 2019, 12:46 AM
bjope closed D69038: [InstCombine] Fix miscompile bug in canEvaluateShuffled.
Oct 18 2019, 12:45 AM · Restricted Project
bjope committed rL375207: [InstCombine] Pre-commit of test case showing miscompile bug in….
[InstCombine] Pre-commit of test case showing miscompile bug in…
Oct 18 2019, 12:45 AM

Oct 16 2019

bjope updated the diff for D69038: [InstCombine] Fix miscompile bug in canEvaluateShuffled.
  • Fixup mistake regarding FDiv (it was not supposed to be included in the new restriction).
  • Added test cases for sdiv/urem/udiv (showing that the new restriction works).
  • Added test cases for fdiv/frem (showing that we can eliminate the shufflevector).
Oct 16 2019, 10:37 AM · Restricted Project