Page MenuHomePhabricator

bjope (Bjorn Pettersson)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 26 2016, 7:58 AM (295 w, 4 d)

Recent Activity

Yesterday

bjope added inline comments to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..
Thu, May 26, 12:02 PM · Restricted Project, Restricted Project
bjope added inline comments to D126257: Round up zero-sized symbols to 1 byte in `.debug_aranges`..
Thu, May 26, 9:26 AM · Restricted Project, Restricted Project
bjope added inline comments to D119078: [LAA,LV] Add initial support for pointer-diff memory checks..
Thu, May 26, 4:09 AM · Restricted Project, Restricted Project

Fri, May 13

bjope added inline comments to D125102: [RegAllocGreedy] New hook regClassPriorityTrumpsGlobalness.
Fri, May 13, 2:17 AM · Restricted Project, Restricted Project

Thu, May 12

bjope added inline comments to D125102: [RegAllocGreedy] New hook regClassPriorityTrumpsGlobalness.
Thu, May 12, 8:20 AM · Restricted Project, Restricted Project

Mon, May 9

bjope added inline comments to D125102: [RegAllocGreedy] New hook regClassPriorityTrumpsGlobalness.
Mon, May 9, 9:03 AM · Restricted Project, Restricted Project
bjope added inline comments to D125102: [RegAllocGreedy] New hook regClassPriorityTrumpsGlobalness.
Mon, May 9, 8:23 AM · Restricted Project, Restricted Project
bjope added a comment to D125102: [RegAllocGreedy] New hook regClassPriorityTrumpsGlobalness.

Drive-by-nit: Just happened to notice that the commit msg says "RagAlloc...".

Mon, May 9, 7:51 AM · Restricted Project, Restricted Project

Tue, May 3

bjope accepted D124754: Minimal refactor of TargetTransformInfoImpl.h to avoid Clang Static Analyser's core.CallAndMessage (NFC).

This seem to help out avoiding complaints from clangsa that the OpTy passed on to getCastInstrCost could be a nullptr (implementations of getCastInstrCost doesn't seem to check that the Src/Dst Type pointers are non-null. One could perhaps question the API (if those pointers must not be null then I guess one could have passed the Type arguments by reference instead of passing the pointer). This patch in itself seem good anyway.

Tue, May 3, 1:12 AM · Restricted Project, Restricted Project

Thu, Apr 28

bjope committed rG3a39bb96ca81: [SelectionDAG] Use correct boolean representation in FoldConstantArithmetic (authored by bjope).
[SelectionDAG] Use correct boolean representation in FoldConstantArithmetic
Thu, Apr 28, 9:42 AM · Restricted Project, Restricted Project
bjope closed D124618: [SelectionDAG] Use correct boolean representation in FoldConstantArithmetic.
Thu, Apr 28, 9:42 AM · Restricted Project, Restricted Project
bjope updated the diff for D124618: [SelectionDAG] Use correct boolean representation in FoldConstantArithmetic.

Calculate the ExtendCode outside the loop (also no longer needing the extra bool
to determine how we extend inside the loop).

Thu, Apr 28, 9:08 AM · Restricted Project, Restricted Project
bjope updated the diff for D124618: [SelectionDAG] Use correct boolean representation in FoldConstantArithmetic.

Shorten a variable name according to review feedback.

Thu, Apr 28, 8:24 AM · Restricted Project, Restricted Project
bjope added inline comments to D124618: [SelectionDAG] Use correct boolean representation in FoldConstantArithmetic.
Thu, Apr 28, 8:23 AM · Restricted Project, Restricted Project
bjope requested review of D124618: [SelectionDAG] Use correct boolean representation in FoldConstantArithmetic.
Thu, Apr 28, 8:06 AM · Restricted Project, Restricted Project
bjope committed rG2e14900db9a8: [test][NewPM] Use -passes=loop-vectorize instead of -loop-vectorize (authored by bjope).
[test][NewPM] Use -passes=loop-vectorize instead of -loop-vectorize
Thu, Apr 28, 7:46 AM · Restricted Project, Restricted Project

Apr 26 2022

bjope added inline comments to D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction.
Apr 26 2022, 4:06 AM · Restricted Project, debug-info, Restricted Project
bjope added inline comments to D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction.
Apr 26 2022, 3:03 AM · Restricted Project, debug-info, Restricted Project
bjope added inline comments to D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction.
Apr 26 2022, 2:16 AM · Restricted Project, debug-info, Restricted Project

Apr 17 2022

bjope added a comment to D123903: [IRSim] Ignore Debug instructions with constructing canonical numbering for basic blocks.

Thanks for the patch. I've verified that it solves the problem I found.

Apr 17 2022, 2:22 AM · Restricted Project, Restricted Project

Apr 16 2022

bjope added a comment to D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation..

Seen assertion failures downstream with this patch. Here is a reproducer:

Apr 16 2022, 10:49 AM · Restricted Project, Restricted Project

Apr 4 2022

bjope added a comment to D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra.

Have had problems with failing stage 2 builds since this patch:

Should be fixed in 72ae6cc3a689869dcc15cfa8d0abcdd35a35a484, please let me know if not.

Apr 4 2022, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
bjope added a comment to D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra.

Have had problems with failing stage 2 builds since this patch:

Apr 4 2022, 2:51 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

bjope added a comment to D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..

Looked around a bit.

Mar 23 2022, 8:06 AM · Restricted Project, Restricted Project
bjope updated subscribers of D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
Mar 23 2022, 6:19 AM · Restricted Project, Restricted Project
bjope added a comment to D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..

Hello. We've got some problem in our downstream tests after this patch and I'm trying to figure out how things are supposed to work. Maybe someone being part of this review knows.

Mar 23 2022, 6:18 AM · Restricted Project, Restricted Project

Mar 22 2022

bjope accepted D122221: [Bundle][Codegen] Ignore bundle for meta-instruction.

LGTM! Thanks!

Mar 22 2022, 5:38 AM · Restricted Project, Restricted Project
bjope added inline comments to D121600: [Codegen][tablgen][NFC] Allow meta instruction to be target dependent.
Mar 22 2022, 4:14 AM · Restricted Project, Restricted Project

Mar 14 2022

bjope added a comment to D121182: Expose ScalarizerPass options to C++ (not just commandline).

I don't have write access. Can someone please push this for me?

Mar 14 2022, 4:01 AM · Restricted Project, Restricted Project
bjope committed rG9879c555f210: Expose ScalarizerPass options to C++ (not just commandline) (authored by Benoit).
Expose ScalarizerPass options to C++ (not just commandline)
Mar 14 2022, 4:01 AM · Restricted Project
bjope closed D121182: Expose ScalarizerPass options to C++ (not just commandline).
Mar 14 2022, 4:01 AM · Restricted Project, Restricted Project

Mar 10 2022

bjope added a comment to D120580: [bugpoint] construct a plausible TargetMachine for simplifyCFG.

Sorry, I don't know much about bugpoint to understand if this is feasible or not. I doubt that the CFG simplification done by bugpoint really need to take target specific costs etc into account? We just want to simplify the flow, but not optimize it for a given target, right?
I don't find the motivation that strong and there are no test cases etc included that show any gains.

Mar 10 2022, 1:55 AM · Restricted Project, Restricted Project
bjope accepted D121182: Expose ScalarizerPass options to C++ (not just commandline).

Just a few nits. But otherwise this LGTM.

Mar 10 2022, 1:22 AM · Restricted Project, Restricted Project

Mar 9 2022

bjope added inline comments to D121182: Expose ScalarizerPass options to C++ (not just commandline).
Mar 9 2022, 12:05 AM · Restricted Project, Restricted Project

Feb 17 2022

bjope committed rG1a8bdf95a336: [DAG] Fix in ReplaceAllUsesOfValuesWith (authored by bjope).
[DAG] Fix in ReplaceAllUsesOfValuesWith
Feb 17 2022, 5:31 AM
bjope closed D119088: [DAG] Fix in ReplaceAllUsesOfValuesWith.
Feb 17 2022, 5:31 AM · Restricted Project

Feb 16 2022

bjope updated the diff for D119088: [DAG] Fix in ReplaceAllUsesOfValuesWith.

Fixed clang-format failures.

Feb 16 2022, 1:44 PM · Restricted Project
bjope added a comment to D117174: [libc++][test] Run clang-tidy during CI.

HI,

No idea what's happening but I get this error on trunk

FAIL: libc++ :: libcxx/clang_tidy.sh.cpp (600 of 7776)
******************** TEST 'libc++ :: libcxx/clang_tidy.sh.cpp' FAILED ********************
Script:
--
: 'RUN: at line 11';   clang-tidy /repo/uabelho/master-github/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option -nostdinc++ -isystem /repo/uabelho/master-github/llvm/build-all-builtins/include/x86_64-unknown-linux-gnu/c++/v1 -isystem /repo/uabelho/master-github/llvm/build-all-builtins/include/c++/v1 -I/repo/uabelho/master-github/llvm/build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/repo/uabelho/master-github/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
--
Exit Code: 1

Command Output (stdout):
--
$ ":" "RUN: at line 11"
note: command had no output on stdout or stderr
$ "clang-tidy" "/repo/uabelho/master-github/libcxx/test/libcxx/clang_tidy.sh.cpp" "--warnings-as-errors=*" "-header-filter=.*" "--" "-Wno-unknown-warning-option" "-nostdinc++" "-isystem" "/repo/uabelho/master-github/llvm/build-all-builtins/include/x86_64-unknown-linux-gnu/c++/v1" "-isystem" "/repo/uabelho/master-github/llvm/build-all-builtins/include/c++/v1" "-I/repo/uabelho/master-github/llvm/build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/libcxx/include/c++build" "-D__STDC_FORMAT_MACROS" "-D__STDC_LIMIT_MACROS" "-D__STDC_CONSTANT_MACROS" "-I/repo/uabelho/master-github/libcxx/test/support" "-std=c++2b" "-Werror" "-Wall" "-Wextra" "-Wshadow" "-Wundef" "-Wno-unused-command-line-argument" "-Wno-attributes" "-Wno-pessimizing-move" "-Wno-c++11-extensions" "-Wno-user-defined-literals" "-Wno-noexcept-type" "-Wno-atomic-alignment" "-Wsign-compare" "-Wunused-variable" "-Wunused-parameter" "-Wunreachable-code" "-Wno-unused-local-typedef" "-D_LIBCPP_DISABLE_AVAILABILITY" "-fcoroutines-ts" "-Werror=thread-safety" "-Wuser-defined-warnings" "-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER"
# command output:
error: invalid value 'c++2b' in '-std=c++2b' [clang-diagnostic-error]
note: use 'c++98' or 'c++03' for 'ISO C++ 1998 with amendments' standard
note: use 'gnu++98' or 'gnu++03' for 'ISO C++ 1998 with amendments and GNU extensions' standard
note: use 'c++11' for 'ISO C++ 2011 with amendments' standard
note: use 'gnu++11' for 'ISO C++ 2011 with amendments and GNU extensions' standard
note: use 'c++14' for 'ISO C++ 2014 with amendments' standard
note: use 'gnu++14' for 'ISO C++ 2014 with amendments and GNU extensions' standard
note: use 'c++17' for 'ISO C++ 2017 with amendments' standard
note: use 'gnu++17' for 'ISO C++ 2017 with amendments and GNU extensions' standard
note: use 'c++2a' for 'Working draft for ISO C++ 2020' standard
note: use 'gnu++2a' for 'Working draft for ISO C++ 2020 with GNU extensions' standard
/repo/uabelho/master-github/llvm/build-all-builtins/include/c++/v1/type_traits:4092:58: error: use of undeclared identifier '__builtin_is_constant_evaluated'; did you mean '__libcpp_is_constant_evaluated'? [clang-diagnostic-error]
bool __libcpp_is_constant_evaluated() _NOEXCEPT { return __builtin_is_constant_evaluated(); }
                                                         ^
/repo/uabelho/master-github/llvm/build-all-builtins/include/c++/v1/type_traits:4092:6: note: '__libcpp_is_constant_evaluated' declared here
bool __libcpp_is_constant_evaluated() _NOEXCEPT { return __builtin_is_constant_evaluated(); }
     ^

# command stderr:
YAML:1:22: error: unknown key 'InheritParentConfig'
InheritParentConfig: true
                     ^~~~
Error parsing /repo/uabelho/master-github/libcxx/.clang-tidy: Invalid argument
YAML:1:22: error: unknown key 'InheritParentConfig'
InheritParentConfig: true
                     ^~~~
Error parsing /repo/uabelho/master-github/llvm/.clang-tidy: Invalid argument
25374 warnings and 2 errors generated.
Error while processing /repo/uabelho/master-github/libcxx/test/libcxx/clang_tidy.sh.cpp.
Suppressed 25374 warnings (25374 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).

error: command failed with exit status: 1

Any idea?

Feb 16 2022, 3:09 AM · Restricted Project
bjope added a comment to D119088: [DAG] Fix in ReplaceAllUsesOfValuesWith.

(let me know if I should try to find alternative reviewers)

Feb 16 2022, 12:17 AM · Restricted Project

Feb 7 2022

bjope added a comment to D118877: [DagCombine] Increase depth by number of operands to avoid a pathological compile time..

I'm far from an expert at this (I don't know that much about TokenFactors and the DAGCombiner worklist).
But one thing that caught my attention was the code that https://github.com/llvm/llvm-project/issues/52858 is talking about in visitTokenFactor:

Feb 7 2022, 10:53 AM · Restricted Project
bjope updated the diff for D119088: [DAG] Fix in ReplaceAllUsesOfValuesWith.

Rename the new test case.

Feb 7 2022, 5:31 AM · Restricted Project
bjope abandoned D119084: [test] Use -passes=instcombine instead of -instcombine in some tests (4/4). NFC.

This was squashed into D119081.

Feb 7 2022, 5:29 AM · Restricted Project
bjope abandoned D119083: [test] Use -passes=instcombine instead of -instcombine in some tests (3/4). NFC.

This was squashed into D119081.

Feb 7 2022, 5:29 AM · Restricted Project
bjope abandoned D119082: [test] Use -passes=instcombine instead of -instcombine in some tests (2/4). NFC.

This was squashed into D119081.

Feb 7 2022, 5:28 AM · Restricted Project
bjope committed rGacdc419c897f: [test] Use -passes=instcombine instead of -instcombine in lots of tests. NFC (authored by bjope).
[test] Use -passes=instcombine instead of -instcombine in lots of tests. NFC
Feb 7 2022, 5:27 AM
bjope committed rGb280ee1dd7e9: [test] Use -passes=instsimplify instead of -instsimplify in a number of tests. (authored by bjope).
[test] Use -passes=instsimplify instead of -instsimplify in a number of tests.
Feb 7 2022, 5:27 AM
bjope closed D119081: [test] Use -passes=instcombine instead of -instcombine in some tests (1/4). NFC.
Feb 7 2022, 5:27 AM · Restricted Project
bjope closed D119080: [test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC.
Feb 7 2022, 5:27 AM · Restricted Project
bjope added a comment to D119080: [test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC.

I think trivial changes like this one don't need a review and should be good to go

Feb 7 2022, 1:49 AM · Restricted Project

Feb 6 2022

bjope added inline comments to D119088: [DAG] Fix in ReplaceAllUsesOfValuesWith.
Feb 6 2022, 11:50 AM · Restricted Project
bjope requested review of D119088: [DAG] Fix in ReplaceAllUsesOfValuesWith.
Feb 6 2022, 11:04 AM · Restricted Project
bjope committed rGcecf11c31544: [DAGCombiner] Fold SSHLSAT/USHLSAT to SHL when no saturation will occur (authored by bjope).
[DAGCombiner] Fold SSHLSAT/USHLSAT to SHL when no saturation will occur
Feb 6 2022, 10:00 AM
bjope committed rG0f685976057e: Pre-commit test cases for DAG combine folds of SSHLSAT/USHLSAT -> SHL (authored by bjope).
Pre-commit test cases for DAG combine folds of SSHLSAT/USHLSAT -> SHL
Feb 6 2022, 10:00 AM
bjope closed D118765: [DAGCombiner] Fold SSHLSAT/USHLSAT to SHL when no saturation will occur.
Feb 6 2022, 10:00 AM · Restricted Project
bjope closed D118764: Pre-commit test cases for DAG combine folds of SSHLSAT/USHLSAT -> SHL.
Feb 6 2022, 10:00 AM · Restricted Project
bjope requested review of D119084: [test] Use -passes=instcombine instead of -instcombine in some tests (4/4). NFC.
Feb 6 2022, 7:27 AM · Restricted Project
bjope requested review of D119083: [test] Use -passes=instcombine instead of -instcombine in some tests (3/4). NFC.
Feb 6 2022, 7:26 AM · Restricted Project
bjope requested review of D119082: [test] Use -passes=instcombine instead of -instcombine in some tests (2/4). NFC.
Feb 6 2022, 7:26 AM · Restricted Project
bjope requested review of D119081: [test] Use -passes=instcombine instead of -instcombine in some tests (1/4). NFC.
Feb 6 2022, 7:25 AM · Restricted Project
bjope requested review of D119080: [test] Use -passes=instsimplify instead of -instsimplify in a number of tests. NFC.
Feb 6 2022, 7:25 AM · Restricted Project
bjope updated the diff for D118765: [DAGCombiner] Fold SSHLSAT/USHLSAT to SHL when no saturation will occur.

Updated after review feedback:

  • Now using APInt for comparisons.
  • For USHLSAT we now compare minimum number of known leading zeroes to the shift amount when checking if all shifted out bits are zero. That is hopefully easier to read/understand compared to using MaskedValueIsZero.
Feb 6 2022, 7:05 AM · Restricted Project

Feb 4 2022

bjope committed rG3db39e74792d: [DAGCombiner] Fix dependency analysis in… (authored by bjope).
[DAGCombiner] Fix dependency analysis in…
Feb 4 2022, 12:09 AM
bjope closed D118943: [DAGCombiner] Fix dependency analysis in checkMergeStoreCandidatesForDependencies.
Feb 4 2022, 12:09 AM · Restricted Project

Feb 3 2022

bjope added a comment to D116895: Fix a missed opportunity to optimize consecutive stores..

Hi Björn. Thank you for looking into this bug and reproducing the problem on aarch64. It sounds like you found the underlying issue in checkMergeStoreCandidatesForDependencies. Do you need help with anything?

Feb 3 2022, 1:22 PM · Restricted Project
bjope requested review of D118943: [DAGCombiner] Fix dependency analysis in checkMergeStoreCandidatesForDependencies.
Feb 3 2022, 1:20 PM · Restricted Project
bjope committed rG0352ee1a225a: [CodeGenPrepare] Avoid out-of-bounds shift (authored by bjope).
[CodeGenPrepare] Avoid out-of-bounds shift
Feb 3 2022, 12:14 PM
bjope closed D118602: [CodeGenPrepare] Avoid out-of-bounds shift.
Feb 3 2022, 12:14 PM · Restricted Project
bjope added a comment to D118602: [CodeGenPrepare] Avoid out-of-bounds shift.

This seems fine, but check my understanding: there's no difference in the test output with this fix if opt is not built with ubsan enabled?

Feb 3 2022, 8:12 AM · Restricted Project
bjope added a comment to D116895: Fix a missed opportunity to optimize consecutive stores..

Hi,

Anyone seen problems with this patch?
I have a case for my out-of-tree target where this patch causes two stores to be merged leading to a cycle in the DAG.
So in the initial DAG we have the following dependencies

store2 <- load1 <- load2 <- load3 <- store1

and then store2 and store1 are merged to store21 and we end up with dependencies like this:

store12 <- load1 <- load2 <- load3
                          <- store12

ie. load2 depends on both load3 and store12 so we have a broken DAG with a cycle in it.
So then we end up with

Operand not processed?0x882a240
t9: i16,ch = load<(load (s16) from %ir.next1.i)> t26, t8, undef:i16

UNREACHABLE executed at ../lib/CodeGen/SelectionDAG/LegalizeTypes.cpp:503!

I haven't been able to reproduce this for any in-tree targets yet so it might very well be something we've broken for our target but I thought I'd mention here that we see problems in case anyone else does too.

Feb 3 2022, 7:13 AM · Restricted Project
bjope updated the diff for D118602: [CodeGenPrepare] Avoid out-of-bounds shift.

Fix typo (there was an extra "Scale =" that wasn't supposed to be there).

Feb 3 2022, 5:27 AM · Restricted Project

Feb 2 2022

bjope added a reviewer for D118602: [CodeGenPrepare] Avoid out-of-bounds shift: spatel.
Feb 2 2022, 9:51 AM · Restricted Project
bjope updated the diff for D118765: [DAGCombiner] Fold SSHLSAT/USHLSAT to SHL when no saturation will occur.

Added check that it is "legal" to use SHL.

Feb 2 2022, 9:48 AM · Restricted Project
bjope added inline comments to D118765: [DAGCombiner] Fold SSHLSAT/USHLSAT to SHL when no saturation will occur.
Feb 2 2022, 5:08 AM · Restricted Project
bjope requested review of D118765: [DAGCombiner] Fold SSHLSAT/USHLSAT to SHL when no saturation will occur.
Feb 2 2022, 2:37 AM · Restricted Project
bjope requested review of D118764: Pre-commit test cases for DAG combine folds of SSHLSAT/USHLSAT -> SHL.
Feb 2 2022, 2:32 AM · Restricted Project

Feb 1 2022

bjope added a comment to D118603: [DAGCombine] Add simple folds for SSHLSAT/USHLSAT.

LGTM - please can you pre-commit the tests and then rebase so that the patch commit shows the codegen diffs

Feb 1 2022, 1:53 AM · Restricted Project
bjope committed rG38858790467e: [DAGCombine] Add simple folds for SSHLSAT/USHLSAT (authored by bjope).
[DAGCombine] Add simple folds for SSHLSAT/USHLSAT
Feb 1 2022, 1:52 AM
bjope committed rG06105f2ef1a9: Pre-commit test cases missing SSHLSAT/USHLSAT folds. NFC (authored by bjope).
Pre-commit test cases missing SSHLSAT/USHLSAT folds. NFC
Feb 1 2022, 1:52 AM
bjope closed D118603: [DAGCombine] Add simple folds for SSHLSAT/USHLSAT.
Feb 1 2022, 1:52 AM · Restricted Project

Jan 31 2022

bjope updated the diff for D118603: [DAGCombine] Add simple folds for SSHLSAT/USHLSAT.

Added test cases for undef/poison/out-of-bounds-shamt:

(shlsat undef/poison, x) -> 0
(shlsat x, undef/poison) -> undef
(shlsat x, too_large_shamt) -> undef
Jan 31 2022, 11:52 AM · Restricted Project
bjope added reviewers for D118602: [CodeGenPrepare] Avoid out-of-bounds shift: reames, t.p.northover.
Jan 31 2022, 9:09 AM · Restricted Project
bjope added a reviewer for D118603: [DAGCombine] Add simple folds for SSHLSAT/USHLSAT: RKSimon.
Jan 31 2022, 9:03 AM · Restricted Project
bjope requested review of D118603: [DAGCombine] Add simple folds for SSHLSAT/USHLSAT.
Jan 31 2022, 5:42 AM · Restricted Project
bjope requested review of D118602: [CodeGenPrepare] Avoid out-of-bounds shift.
Jan 31 2022, 5:37 AM · Restricted Project

Jan 28 2022

bjope committed rGbcdcf984cc42: [test][NewGVN] Use '-passes=newgvn' instead of '-basic-aa -newgvn' (authored by bjope).
[test][NewGVN] Use '-passes=newgvn' instead of '-basic-aa -newgvn'
Jan 28 2022, 4:59 AM
bjope committed rG4f7352840394: [test][NewGVN] Use -passes=newgvn instead of -newgvn (authored by bjope).
[test][NewGVN] Use -passes=newgvn instead of -newgvn
Jan 28 2022, 4:59 AM
bjope closed D118340: [test][NewGVN] Use '-passes=newgvn' instead of 'basic-aa -newgvn'.
Jan 28 2022, 4:58 AM · Restricted Project
bjope closed D118341: [test][NewGVN] Use -passes=newgvn instead of -newgvn.
Jan 28 2022, 4:58 AM · Restricted Project

Jan 27 2022

bjope committed rGbf06bc1a6d6e: [test] Use -passes syntax in SROA test cases (authored by bjope).
[test] Use -passes syntax in SROA test cases
Jan 27 2022, 10:26 AM
bjope closed D118339: [test] Use -passes syntax in SROA test cases.
Jan 27 2022, 10:26 AM · Restricted Project
bjope committed rG464be7af2859: [NewPM] Add debugify and check-debugify to the PassRegistry (authored by bjope).
[NewPM] Add debugify and check-debugify to the PassRegistry
Jan 27 2022, 10:26 AM
bjope closed D118369: [NewPM] Add debugify and check-debugify to the PassRegistry.
Jan 27 2022, 10:26 AM · Restricted Project
bjope abandoned D118338: [Debugify] Override printPipeline for NewPM debugify passes.

Abandoned in favor of D118369 which adds the passes to the registry instead. That seems like a nicer solution.

Jan 27 2022, 7:32 AM · Restricted Project
bjope requested review of D118369: [NewPM] Add debugify and check-debugify to the PassRegistry.
Jan 27 2022, 7:30 AM · Restricted Project
bjope requested review of D118340: [test][NewGVN] Use '-passes=newgvn' instead of 'basic-aa -newgvn'.
Jan 27 2022, 5:07 AM · Restricted Project
bjope retitled D118340: [test][NewGVN] Use '-passes=newgvn' instead of 'basic-aa -newgvn' from [test][NewGVN] Use '-aa-pipeline=basic-aa -passes=newgvn' instead of '-basic-aa -newgvn' to [test][NewGVN] Use '-passes=newgvn' instead of 'basic-aa -newgvn'.
Jan 27 2022, 5:06 AM · Restricted Project
bjope updated the diff for D118340: [test][NewGVN] Use '-passes=newgvn' instead of 'basic-aa -newgvn'.

Updated based on the suggestion to drop -aa-pipeline=basic-aa in test cases for which the output would be the same when using the default aa-pipeline (that was the case for all but one file, so that one was left out from this patch).

Jan 27 2022, 5:01 AM · Restricted Project
bjope updated the diff for D118341: [test][NewGVN] Use -passes=newgvn instead of -newgvn.

Updated based on review feedback.

Jan 27 2022, 4:59 AM · Restricted Project
bjope added a comment to D118338: [Debugify] Override printPipeline for NewPM debugify passes.

Thanks for this @bjope.

Should we add Debugify Passes in the PassRegistry?

Jan 27 2022, 3:16 AM · Restricted Project
bjope added a comment to D118340: [test][NewGVN] Use '-passes=newgvn' instead of 'basic-aa -newgvn'.

Can you please omit -aa-pipeline entirely where it makes no difference to test output? Especially for basic-aa, it should not be necessary to explicitly specify it.

Jan 27 2022, 3:10 AM · Restricted Project