Page MenuHomePhabricator

aprantl (Adrian Prantl)
User

Projects

User Details

User Since
Mar 2 2013, 8:12 AM (524 w, 5 d)

Recent Activity

Today

aprantl added a comment to D145609: [lldb] Change dwim-print to default to disabled persistent results.

breaks basically anything that examines debugger output

Thu, Mar 23, 10:33 AM · Restricted Project, Restricted Project

Yesterday

aprantl added a comment to D146595: [clang] Add clang trampoline_mangled_target attribute.

If it's the latter, then, yeah, some "transparent to debugger" source attribute might be appropriate - that lowers to a bit on the DISubprogram and instructs LLVM to, if the function definition ends up lowering to a trampoline, mark that for the debugger so it's transparent - and if it lowers to a trampoline but doesn't have the source attribute, you can then still step into the function separately from stepping into the subsequent function?

Wed, Mar 22, 4:39 PM · debug-info, Restricted Project, Restricted Project, Restricted Project
aprantl added inline comments to D145580: [lldb] Show register fields using bitfield struct types.
Wed, Mar 22, 9:40 AM · Restricted Project, Restricted Project, Restricted Project
aprantl added inline comments to D145580: [lldb] Show register fields using bitfield struct types.
Wed, Mar 22, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
aprantl added inline comments to D145580: [lldb] Show register fields using bitfield struct types.
Wed, Mar 22, 9:18 AM · Restricted Project, Restricted Project, Restricted Project
aprantl added a reviewer for D146595: [clang] Add clang trampoline_mangled_target attribute: dblaikie.
Wed, Mar 22, 9:15 AM · debug-info, Restricted Project, Restricted Project, Restricted Project
aprantl added a reviewer for D146595: [clang] Add clang trampoline_mangled_target attribute: rsmith.
Wed, Mar 22, 9:15 AM · debug-info, Restricted Project, Restricted Project, Restricted Project
aprantl accepted D146595: [clang] Add clang trampoline_mangled_target attribute.

So this attribute will lower into a DW_AT_trampoline("target_func_name") attribute on the DW_TAG_subprogram of the function definition?

Wed, Mar 22, 9:13 AM · debug-info, Restricted Project, Restricted Project, Restricted Project
aprantl added a project to D146595: [clang] Add clang trampoline_mangled_target attribute: debug-info.
Wed, Mar 22, 9:07 AM · debug-info, Restricted Project, Restricted Project, Restricted Project

Tue, Mar 21

aprantl added inline comments to D145580: [lldb] Show register fields using bitfield struct types.
Tue, Mar 21, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
aprantl accepted D146548: [lldb] Refactor deduction of the instance variable's name (NFC).
Tue, Mar 21, 12:32 PM · Restricted Project, Restricted Project
aprantl committed rZORG496428e94562: Also skip downloading the just-built-compiler on other LLDB jobs (authored by aprantl).
Also skip downloading the just-built-compiler on other LLDB jobs
Tue, Mar 21, 10:23 AM · Restricted Project
aprantl committed rZORG46faabee647b: Also delete the host compiler to conf.CC() doesn't pick it up (authored by aprantl).
Also delete the host compiler to conf.CC() doesn't pick it up
Tue, Mar 21, 10:16 AM · Restricted Project
aprantl committed rZORG0491434906b4: Skip downloading the host compiler on lldb incremental job (authored by aprantl).
Skip downloading the host compiler on lldb incremental job
Tue, Mar 21, 10:12 AM · Restricted Project
aprantl accepted D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms.

Thanks for adding the check!

Tue, Mar 21, 9:44 AM · Restricted Project, Restricted Project
aprantl added inline comments to D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available.
Tue, Mar 21, 9:15 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 20

aprantl updated subscribers of D146340: [ADT] Work around `enumerate` compilation error with modules enabled.
Mon, Mar 20, 1:43 PM · Restricted Project, Restricted Project
aprantl added a comment to D146340: [ADT] Work around `enumerate` compilation error with modules enabled.

Thanks! It works.

Mon, Mar 20, 1:42 PM · Restricted Project, Restricted Project
aprantl accepted D146340: [ADT] Work around `enumerate` compilation error with modules enabled.
Mon, Mar 20, 11:20 AM · Restricted Project, Restricted Project
aprantl added a comment to D146340: [ADT] Work around `enumerate` compilation error with modules enabled.

Oh wait, I didn't realize you haven't landed it yet :-)

Mon, Mar 20, 11:20 AM · Restricted Project, Restricted Project
aprantl added a comment to D146340: [ADT] Work around `enumerate` compilation error with modules enabled.

Thanks, but this does not seem to have worked: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52610/consoleText

Mon, Mar 20, 11:19 AM · Restricted Project, Restricted Project

Fri, Mar 17

aprantl accepted D146265: [lldb] Introduce SymbolFile::ParseAllLanguages.

You could add a test similar to lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp

Fri, Mar 17, 3:45 PM · Restricted Project, Restricted Project
aprantl accepted D146320: [lldb] Test direct ivar access in objc++ (NFC).

Otherwise LGTM

Fri, Mar 17, 3:04 PM · Restricted Project, Restricted Project
aprantl added inline comments to D146320: [lldb] Test direct ivar access in objc++ (NFC).
Fri, Mar 17, 3:04 PM · Restricted Project, Restricted Project
aprantl added a comment to D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms.

Here is an example of how the Swift Runtime plugin detects both itself and whether ObjC interop is enabled. Basically all I'm asking is to not accidentally break this mechanism.
https://github.com/apple/llvm-project/blob/7750ffa35111df6d38a5c73ab7e78ccebc9b43c3/lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.cpp#L124
If you want to make 100% sure, you could checkout the Swift compiler on Linux (or I suppose Windows) from github.com/apple/swift run swift/utils/update-checkout --clone apply your patch to llvm-project and run swift/utils/build-script --lldb --test -- --skip-build-benchmarks --skip-test-cmark --skip-test-swift and make sure the lldb tests still pass after applying you patch. But if you check for the symbol that would be sufficient for me.

Fri, Mar 17, 2:43 PM · Restricted Project, Restricted Project
aprantl added a comment to D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms.

One thing I just realized — we need to make sure that we don't accidentally create a GNUstep ObjC runtime in a Swift process that was built without ObjC support on Linux.

Yes, thanks for bringing this up. The goal definitely is to avoid any accidental conflicts with existing use cases that don't need or expect a GNUstep runtime. I really want to get my focus to the Windows side and PDB parsing. It's useful to have Linux working as well, so that we have a testable feature set to match. Otherwise, we don't want to invest a lot of effort here yet.

How can we ensure this works for both cases?

Shouldn't the Swift processes report eLanguageTypeSwift? Then GNUstepObjCRuntime::CreateInstance() rejects it reliably.

Fri, Mar 17, 2:37 PM · Restricted Project, Restricted Project
aprantl updated subscribers of D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges.
Fri, Mar 17, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
aprantl added a comment to D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges.
In module 'LLVM_Utils' imported from /Users/buildslave/jenkins/workspace/lldb-cmake@2/llvm-project/llvm/tools/llvm-pdbutil/StreamUtil.h:12:
/Users/buildslave/jenkins/workspace/lldb-cmake@2/llvm-project/llvm/include/llvm/ADT/STLExtras.h:2389:11: error: no matching function for call to 'all_equal'
          all_equal({std::distance(adl_begin(First), adl_end(First)),
          ^~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
/Users/buildslave/jenkins/workspace/lldb-cmake@2/llvm-project/llvm/tools/llvm-pdbutil/ExplainOutputStyle.cpp:129:28: note: in instantiation of function template specialization 'llvm::enumerate<const std::__1::vector<llvm::ArrayRef<llvm::support::detail::packed_endian_specific_integral<unsigned int, llvm::support::little, 1, 1>>> &>' requested here
  for (const auto &Entry : enumerate(Layout.StreamMap)) {
                           ^
/Users/buildslave/jenkins/workspace/lldb-cmake@2/llvm-project/llvm/include/llvm/ADT/STLExtras.h:2056:28: note: candidate template ignored: couldn't infer template argument 'R'
template <typename R> bool all_equal(R &&Range) {
                           ^
/Users/buildslave/jenkins/workspace/lldb-cmake@2/llvm-project/llvm/include/llvm/ADT/STLExtras.h:2064:28: note: candidate template ignored: couldn't infer template argument 'T'
template <typename T> bool all_equal(std::initializer_list<T> Values) {
                           ^
1 error generated.
Fri, Mar 17, 2:29 PM · Restricted Project, Restricted Project, Restricted Project
aprantl added a comment to D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges.

This somehow broke the -DLLVM_ENABLE_MODULES=1 build:

Fri, Mar 17, 2:29 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 15

aprantl added a comment to D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms.

I.e., can you detect based on the presence of a symbol or shared object that an GNUstep runtime is present?

Wed, Mar 15, 12:37 PM · Restricted Project, Restricted Project
aprantl requested changes to D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms.

One thing I just realized — we need to make sure that we don't accidentally create a GNUstep ObjC runtime in a Swift process that was built without ObjC support on Linux. How can we ensure this works for both cases?

Wed, Mar 15, 12:36 PM · Restricted Project, Restricted Project
aprantl accepted D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms.

In general I don't think I have a problem with adding this, especially since Clang also supports the runtime as a compilation target, and LLDB is tightly integrated with Clang.

Wed, Mar 15, 12:32 PM · Restricted Project, Restricted Project
aprantl added a comment to D144008: [DebugMetadata][DwarfDebug] Support function-local static variables in lexical block scopes (7/7).

I don't /think/ that's the case - I know Apple used to have a pretty significant dependence on IR upgrading at least invalidating the IR metadata & dropping it (so maybe all you need to do is update the debug info IR verifier so that old IR gets deemed invalid and dropped - not necessarily upgraded).

Wed, Mar 15, 12:28 PM · debug-info, Restricted Project, Restricted Project
aprantl added a comment to D144008: [DebugMetadata][DwarfDebug] Support function-local static variables in lexical block scopes (7/7).

@aprantl

Since this changes what IR goes where - are there concerns you folks have for auto-upgrade/cross compatibility?

@krisb - how's this handle cases of old IR being used in a newer compiler/linker?

Wed, Mar 15, 12:25 PM · debug-info, Restricted Project, Restricted Project

Tue, Mar 14

aprantl accepted D145680: [DWARFLinker][DWARFv5] Support debug_loclists..

Mechanically, this patch looks great to me. @JDevlieghere, do you have any high-level concerns?

Tue, Mar 14, 5:39 PM · Restricted Project, Restricted Project
aprantl accepted D145607: [Inliner] Assign dummy debug location to the memcpy for byval argument.
Tue, Mar 14, 4:59 PM · debug-info, Restricted Project, Restricted Project
aprantl added a comment to D140788: [DWARFLinkerParallel] add AddressesMap interface..

I'll defer to @JDevlieghere

Tue, Mar 14, 4:58 PM · Restricted Project, Restricted Project
aprantl accepted D138992: [DebugInfo][SROA] Correct debug info for global variables spanning multiple fragments in case of SROA.

We should consider factoring this function out and writing a unit test for it. The current tests are very indirect.

Tue, Mar 14, 4:57 PM · Restricted Project, Restricted Project, debug-info
aprantl accepted D145609: [lldb] Change dwim-print to default to disabled persistent results.
Tue, Mar 14, 2:11 PM · Restricted Project, Restricted Project
aprantl accepted D146047: [DWARFLinker][DWARFv5] add support for DW_FORM_implicit_const form..
Tue, Mar 14, 1:03 PM · Restricted Project, Restricted Project

Mon, Mar 13

aprantl accepted D145943: [AArchExpandPseudo] Preserve instruction debug number in expansions.
Mon, Mar 13, 11:56 AM · Restricted Project, Restricted Project

Fri, Mar 10

aprantl accepted D145693: [llvm][Demangle][NFC] Sync latest libcxxabi/demangle.
Fri, Mar 10, 4:46 PM · Restricted Project, Restricted Project

Tue, Mar 7

aprantl accepted D145493: [llvm][Demangle] Sync with libcxxabi.
Tue, Mar 7, 5:59 PM · Restricted Project, Restricted Project
aprantl added inline comments to D143229: [AutoUpgrade] Add flag to disable autoupgrading debug info.
Tue, Mar 7, 5:57 PM · Restricted Project, Restricted Project
aprantl accepted D145529: [lldb] Change default value of dwim-print-verbosity setting.

This doesn't affect any tests?

Tue, Mar 7, 5:56 PM · Restricted Project, Restricted Project
aprantl accepted D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this.
Tue, Mar 7, 4:52 PM · Restricted Project, Restricted Project
aprantl accepted D145478: [ADCE] Preserve MemorySSA if only debug instructions are removed.
Tue, Mar 7, 9:19 AM · Restricted Project, Restricted Project, debug-info

Mon, Mar 6

aprantl added inline comments to D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7).
Mon, Mar 6, 5:36 PM · Restricted Project, debug-info, Restricted Project, Restricted Project
aprantl added a comment to D145437: [lldb-vscode] Use `expression` command for completion.

We might consider using dwim-print here in the future?

Mon, Mar 6, 5:29 PM · Restricted Project, Restricted Project
aprantl accepted D145437: [lldb-vscode] Use `expression` command for completion.

That seems to be clearly better, since p could be aliased to anything.

Mon, Mar 6, 5:28 PM · Restricted Project, Restricted Project
aprantl added a reviewer for D145437: [lldb-vscode] Use `expression` command for completion: clayborg.
Mon, Mar 6, 5:27 PM · Restricted Project, Restricted Project
aprantl added a comment to D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this.

From an end-user perspective, I like this.

Mon, Mar 6, 5:26 PM · Restricted Project, Restricted Project
aprantl accepted D144472: [InstCombine][debuginfo] Update valueCoversEntireFragment for fixed size fragment and scalable value..
Mon, Mar 6, 5:19 PM · Restricted Project, Restricted Project

Fri, Mar 3

aprantl added a project to D145168: Move DBG_VALUE's that depend on loads to after a load if the load is moved due to the pre register allocation ld/st optimization pass: debug-info.
Fri, Mar 3, 10:15 AM · debug-info, Restricted Project, Restricted Project
aprantl added a comment to D145168: Move DBG_VALUE's that depend on loads to after a load if the load is moved due to the pre register allocation ld/st optimization pass.

Nice! I appreciate the detailed explanation of the algorithm. I have some suggestions for how to streamline it a bit and potentially make it easier to read inside.

Fri, Mar 3, 10:15 AM · debug-info, Restricted Project, Restricted Project
aprantl accepted D145239: [StripDebugInfo] Reuse DebugInfoFinder for findind Live CUs.

Deleting specialized code while improving correctness? That's always welcome!

Fri, Mar 3, 8:44 AM · Restricted Project, Restricted Project
aprantl accepted D145240: [lldb][TypeSystemClang][NFC] Factor out l/r-value reference logic for IsXXXType APIs.
Fri, Mar 3, 8:42 AM · Restricted Project, Restricted Project
aprantl accepted D145241: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex.
Fri, Mar 3, 8:41 AM · Restricted Project, Restricted Project
aprantl accepted D142556: [DebugInfo] Merge partially matching chains of inlined locations.
Fri, Mar 3, 8:39 AM · Restricted Project, Restricted Project, debug-info
aprantl added a comment to D142556: [DebugInfo] Merge partially matching chains of inlined locations.

I'm fine with taking this, thanks!

Fri, Mar 3, 8:39 AM · Restricted Project, Restricted Project, debug-info
aprantl accepted D145245: [lldb] Ignore libcxx std::ranges global variables in frame var.

I think this is fine. It's concise, adds useful plugin functionality and we're already hardcoding all sorts of special knowledge about libc++.

Fri, Mar 3, 8:34 AM · Restricted Project, Restricted Project
aprantl accepted D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers.

Nice.

Fri, Mar 3, 8:30 AM · Restricted Project, Restricted Project
aprantl accepted D145076: [llvm][DebugInfo] Introduce new DW_AT_LLVM_preferred_name attribute.

Looking good!

Fri, Mar 3, 8:25 AM · Restricted Project, Restricted Project

Thu, Mar 2

aprantl accepted D145124: [lldb] Add variable completion to dwim-print.
Thu, Mar 2, 5:23 PM · Restricted Project, Restricted Project
aprantl accepted D145189: [lldb] Redefine p alias to dwim-print command.

So from my point of view, this is a good path forward, so assuming that the other reviewers agree, this LGTM.

Thu, Mar 2, 2:17 PM · Restricted Project, Restricted Project
aprantl added a comment to D145189: [lldb] Redefine p alias to dwim-print command.

So, one could say that (right now) this patch is NFC for end-users, because dwim-print supports all use-cases that the old p alias supported?

Thu, Mar 2, 2:14 PM · Restricted Project, Restricted Project

Wed, Mar 1

aprantl requested changes to D145076: [llvm][DebugInfo] Introduce new DW_AT_LLVM_preferred_name attribute.

Looks pretty good, some nitpicks inside.

Wed, Mar 1, 11:17 AM · Restricted Project, Restricted Project
aprantl accepted D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute.

I originally was hoping we wouldn't have to introduce a new attribute for this, but it looks like there are legitimate concerns about the alternatives, so in that sense this looks good!

Wed, Mar 1, 10:12 AM · Restricted Project, Restricted Project

Tue, Feb 28

aprantl added a comment to D144839: Add support to symbolize backtraces on crashes on Macho platforms.

How is this related to https://reviews.llvm.org/D142283?

Tue, Feb 28, 9:33 AM · Restricted Project, Restricted Project
aprantl added inline comments to D144472: [InstCombine][debuginfo] Update valueCoversEntireFragment for fixed size fragment and scalable value..
Tue, Feb 28, 9:03 AM · Restricted Project, Restricted Project

Thu, Feb 23

aprantl accepted D143903: [DWARFLinker][DWARFv5] Add support for .debug_rnglists..

I think this SGTM.

Thu, Feb 23, 11:03 AM · Restricted Project, Restricted Project

Wed, Feb 22

aprantl added inline comments to D142283: [Support] Make llvm-symbolizer runs for stack traces work on Apple platforms.
Wed, Feb 22, 11:11 AM · Restricted Project, Restricted Project

Feb 20 2023

aprantl accepted D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations.
Feb 20 2023, 2:26 PM · debug-info, Restricted Project, Restricted Project

Feb 17 2023

aprantl added inline comments to D142283: [Support] Make llvm-symbolizer runs for stack traces work on Apple platforms.
Feb 17 2023, 6:54 PM · Restricted Project, Restricted Project
aprantl added inline comments to D142283: [Support] Make llvm-symbolizer runs for stack traces work on Apple platforms.
Feb 17 2023, 6:44 PM · Restricted Project, Restricted Project
aprantl accepted D144230: [lldb] Make persisting result variables configurable.
Feb 17 2023, 12:21 PM · Restricted Project, Restricted Project
aprantl added inline comments to D144230: [lldb] Make persisting result variables configurable.
Feb 17 2023, 10:49 AM · Restricted Project, Restricted Project

Feb 16 2023

aprantl added a comment to D144230: [lldb] Make persisting result variables configurable.

Did you forget to git-add the test?

Feb 16 2023, 7:43 PM · Restricted Project, Restricted Project
aprantl added inline comments to D144230: [lldb] Make persisting result variables configurable.
Feb 16 2023, 7:43 PM · Restricted Project, Restricted Project
aprantl accepted D144114: [lldb] Add expression command options in dwim-print.

Yeah, this is better.

Feb 16 2023, 1:51 PM · Restricted Project, Restricted Project
aprantl added a comment to D143229: [AutoUpgrade] Add flag to disable autoupgrading debug info.

So your build system guarantees that all bitcode that is being consumed was generated by compilers linked against the same version of LLVM that is used in the LTO plugin and if that version were to serialize malformed metadata, you wouldn't be any worse off than a non-LTO build, which also doesn't verify between passes.

Feb 16 2023, 9:44 AM · Restricted Project, Restricted Project
aprantl added a comment to D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations.

Size-wise this looks like an acceptable increase. If we created a new DW_AT_LLVM_abi_tag, we could save an extra 4 bytes (assuming DW_FORM_strp) per DIE. That might be worth it?

Feb 16 2023, 9:40 AM · debug-info, Restricted Project, Restricted Project
aprantl added a project to D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations: debug-info.
Feb 16 2023, 8:35 AM · debug-info, Restricted Project, Restricted Project

Feb 15 2023

aprantl accepted D144114: [lldb] Add expression command options in dwim-print.

Conceptually, I think this looks good to me.

Feb 15 2023, 4:00 PM · Restricted Project, Restricted Project
aprantl accepted D144138: [lldb] Remove pydoc import during script interpreter init.
Feb 15 2023, 2:13 PM · Restricted Project, Restricted Project

Feb 14 2023

aprantl added inline comments to D142283: [Support] Make llvm-symbolizer runs for stack traces work on Apple platforms.
Feb 14 2023, 1:00 PM · Restricted Project, Restricted Project
aprantl added a comment to D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names.

Alternatively, I suppose, the DWARF emission could just look at the preferred name and use that as the DW_AT_type in all cases anyway? Avoids needing a new attribute, etc, though would be a bit quirky in its own way.

Feb 14 2023, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
aprantl added a comment to D143229: [AutoUpgrade] Add flag to disable autoupgrading debug info.

It seems reasonable to me to provide a way to skip this for situations where the build system guarantees that the bitcode is always generated by the same compiler, e.g. in a distributed ThinLTO build where any change in compiler will force a rebuild anyway, which is the case @aeubanks is looking at.

Feb 14 2023, 8:58 AM · Restricted Project, Restricted Project
aprantl accepted D143921: [debug-info][codegen] Prevent creation of self-referential SP node.

Test looks good!

Feb 14 2023, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2023

aprantl added a comment to D143921: [debug-info][codegen] Prevent creation of self-referential SP node.

Any testing suggestions here? I can use what we have on GH (cpp -> codegen test), but I'm not sure if there's a finer grained test we could use.

Feb 13 2023, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
aprantl accepted D143921: [debug-info][codegen] Prevent creation of self-referential SP node.
Feb 13 2023, 1:03 PM · Restricted Project, Restricted Project, Restricted Project
aprantl added a comment to D143842: [lldb][test] Add check for Xcode binutils version to test-runner.

Should we put something like

Feb 13 2023, 11:54 AM · Restricted Project, Restricted Project
aprantl accepted D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation.
Feb 13 2023, 8:51 AM · Restricted Project, Restricted Project

Feb 10 2023

aprantl added a comment to D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN.

Why are only these two tests affected? Should this be something we set globally for all the tests? The API tests already have support for forwarding ASAN_OPTIONS and lit has a similar concept.

Feb 10 2023, 12:31 PM · Restricted Project, Restricted Project
aprantl added a comment to D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN.

Generally LGTM, with one possible improvement inline!

Feb 10 2023, 12:30 PM · Restricted Project, Restricted Project

Feb 9 2023

aprantl accepted D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation.
Feb 9 2023, 1:33 PM · Restricted Project, Restricted Project
aprantl accepted D143656: [lldb][Test] Check compiler in data formatter compiler version checks.
Feb 9 2023, 11:26 AM · Restricted Project, Restricted Project
aprantl accepted D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing.

Nice!

Feb 9 2023, 11:24 AM · Restricted Project, Restricted Project
aprantl accepted D143397: [llvm][DebugInfo] Add DW_TAG_imported_declaration to accelerator tables.
Feb 9 2023, 11:19 AM · Restricted Project, Restricted Project
aprantl added a comment to D138415: add LLVMGetDINodeTag.

Looks like this was fixed in

commit 2700d66a054327c2dbb90d8b44b1d5cf3b0043b8
Author: Kazu Hirata <kazu@google.com>
Date:   Wed Feb 8 21:00:45 2023 -0800
Feb 9 2023, 11:19 AM · Restricted Project, Restricted Project