Page MenuHomePhabricator

aprantl (Adrian Prantl)
User

Projects

User Details

User Since
Mar 2 2013, 8:12 AM (315 w, 2 d)

Recent Activity

Yesterday

aprantl added a comment to D59518: [DwarfDebug] Skip entries to big for 16 bit size field in Dwarf < 5..

Would generating the testcase on-the-fly inside the RUN: line or perhaps via python be an option? Otherwise I guess this is fine, too.

Mon, Mar 18, 6:26 PM · Restricted Project
aprantl updated the summary of D59524: Improve error handling for Clang module imports.
Mon, Mar 18, 5:13 PM · Restricted Project
aprantl created D59524: Improve error handling for Clang module imports.
Mon, Mar 18, 5:13 PM · Restricted Project
aprantl added a project to D59515: Prevent duplicate files in debug line header in dwarf 5.: debug-info.
Mon, Mar 18, 3:24 PM · debug-info, Restricted Project
aprantl added a reviewer for D59276: Delete dead code: JDevlieghere.
Mon, Mar 18, 9:42 AM
aprantl accepted D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected.
Mon, Mar 18, 9:40 AM
aprantl accepted D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.
Mon, Mar 18, 9:38 AM · Restricted Project

Fri, Mar 15

aprantl added a comment to D59431: [DebugInfo] Terminate constant-value location-list ranges at the end of basic blocks.

As documented in comment 8 of the PR, the range that a constant-value DBG_VALUE defines a variable location over does not currently terminate at the end of the basic block the DBG_VALUE is in. Instead, its range is valid across all basic blocks (as finally laid out) until another DBG_VALUE for the variable is seen. This often covers many instructions where the variable didn't actually have a location, and even down code paths where the variable was never assigned the constant value.

Fri, Mar 15, 1:37 PM · Restricted Project
aprantl added inline comments to D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected.
Fri, Mar 15, 1:29 PM
aprantl committed rG2ebbb889605a: Implement a better way of not passing the sanitizer environment on to tests. (authored by aprantl).
Implement a better way of not passing the sanitizer environment on to tests.
Fri, Mar 15, 10:24 AM
aprantl added a comment to D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

IIUC this upgrade is sweeping the variant of DISubprograms that have SPflags and do not yet have this patch under the rug? The way the Swift compiler branches work out I can live with that but other downstream users may have a problem with that as it could break LTO builds that include object files versions of clang between 347239 and this patch.

Fri, Mar 15, 9:28 AM · Restricted Project
aprantl added inline comments to D59417: [GVN] Add default debug location when constructing PHI nodes.
Fri, Mar 15, 8:53 AM · Restricted Project

Thu, Mar 14

aprantl committed rG07b97492d43e: Add test I forgot to git-add in r356163. (authored by aprantl).
Add test I forgot to git-add in r356163.
Thu, Mar 14, 2:23 PM
aprantl accepted D59291: [Object] Add basic minidump support.
Thu, Mar 14, 9:48 AM · Restricted Project
aprantl added inline comments to D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions.
Thu, Mar 14, 9:44 AM · Restricted Project
aprantl requested changes to D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

We don't typically require autoupgrade functionality in the IR parser, as there are no compatibility guarantees for textual LLVM IR. Implementing bitcode support is all that is required. Sometimes it can be convenient to support older formats in LLParser to avoid updating hundreds of tests, but it's definitely not required.

Thu, Mar 14, 9:37 AM · Restricted Project
aprantl accepted D59359: Safer casting in ClangExpressionParser code completion.
Thu, Mar 14, 9:31 AM · Restricted Project
aprantl accepted D59358: [CodeGenPrepare] avoid crashing from replacing a phi twice.
Thu, Mar 14, 9:30 AM · Restricted Project
aprantl committed rGe69917f16624: Add IR debug info support for Elemental, Pure, and Recursive Procedures. (authored by aprantl).
Add IR debug info support for Elemental, Pure, and Recursive Procedures.
Thu, Mar 14, 9:30 AM
aprantl committed rGac093d61c468: Fix a double-overrelease in the TestDataFormatterObjC test program. (authored by aprantl).
Fix a double-overrelease in the TestDataFormatterObjC test program.
Thu, Mar 14, 8:59 AM

Wed, Mar 13

aprantl committed rG23b37bf3628e: Make sure that a sanitizer LLDB's environment doesn't get passed on to test… (authored by aprantl).
Make sure that a sanitizer LLDB's environment doesn't get passed on to test…
Wed, Mar 13, 5:46 PM
aprantl committed rG7e34d78da1a0: Fix an invalid static cast in ClangExpressionParser.cpp (authored by aprantl).
Fix an invalid static cast in ClangExpressionParser.cpp
Wed, Mar 13, 12:46 PM
aprantl added a comment to D59314: Fix an invalid static cast in ClangExpressionParser.cpp.

Renamed enumerators.

Wed, Mar 13, 12:37 PM · Restricted Project
aprantl updated the diff for D59314: Fix an invalid static cast in ClangExpressionParser.cpp.
Wed, Mar 13, 12:37 PM · Restricted Project
aprantl added a comment to D59314: Fix an invalid static cast in ClangExpressionParser.cpp.

I was following http://www.llvm.org/docs/HowToSetUpLLVMStyleRTTI.html I will rename it to eKind...

Wed, Mar 13, 12:35 PM · Restricted Project
aprantl updated the diff for D59314: Fix an invalid static cast in ClangExpressionParser.cpp.

Excellent point!

Wed, Mar 13, 12:22 PM · Restricted Project
aprantl updated the diff for D59314: Fix an invalid static cast in ClangExpressionParser.cpp.
Wed, Mar 13, 11:34 AM · Restricted Project
aprantl created D59314: Fix an invalid static cast in ClangExpressionParser.cpp.
Wed, Mar 13, 11:33 AM · Restricted Project
aprantl added a comment to D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

Yes. Can you please add upgrade functionality into MetadataLoader and add a bitcode upgrade test into test/Bitcode?

Wed, Mar 13, 9:14 AM · Restricted Project
aprantl added inline comments to D59291: [Object] Add basic minidump support.
Wed, Mar 13, 9:02 AM · Restricted Project
aprantl committed rG81d03f3a8fe5: Make sure FileSystem::Resolve preserves the path/file distinction. (authored by aprantl).
Make sure FileSystem::Resolve preserves the path/file distinction.
Wed, Mar 13, 8:54 AM

Tue, Mar 12

aprantl committed rG22c660cc131c: Update the macOS implementation of ComputeClangResourceDirectory to comply with… (authored by aprantl).
Update the macOS implementation of ComputeClangResourceDirectory to comply with…
Tue, Mar 12, 4:59 PM
aprantl added a comment to D59276: Delete dead code.

One one hand this seems fine to remove, but on the other hand — won't these functions come in handy to compare and debug differences between the LLDB and LLVM DWARF parsers, while we are switching over?

Tue, Mar 12, 4:18 PM
aprantl added a comment to D59272: [DebugInfo] Select debug intrinsic line-numbers more carefully when promoting dbg.declare.
In D59272#1426904, @rnk wrote:

This makes me nervous. The pair of the DIVariable and DILocation is used to uniquely identify the variable that a dbg.value applies to. In practice, inlining is usually what creates multiple instances of the same variable that get updated by dbg.values. You can see how the location is used in DwarfDebug::collectVariableInfoFromMFTable.

Tue, Mar 12, 4:17 PM · Restricted Project
aprantl committed rG97f51c95db1b: Fix the broken Batch test by passing a custom module cache to the inferior lldb. (authored by aprantl).
Fix the broken Batch test by passing a custom module cache to the inferior lldb.
Tue, Mar 12, 3:20 PM
aprantl committed rGdf8514770779: Revert "Temporarily add more logging to TestBatchMode" (authored by aprantl).
Revert "Temporarily add more logging to TestBatchMode"
Tue, Mar 12, 3:20 PM
aprantl committed rG8ef3da494c8e: Temporarily add more logging to TestBatchMode (authored by aprantl).
Temporarily add more logging to TestBatchMode
Tue, Mar 12, 2:55 PM
aprantl committed rG3552b86cbc36: Add more logging to ClangModulesDeclVendor.cpp (authored by aprantl).
Add more logging to ClangModulesDeclVendor.cpp
Tue, Mar 12, 2:54 PM
aprantl accepted D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code.
Tue, Mar 12, 2:54 PM · Restricted Project
aprantl added a comment to D54043: Adding debug info to support Fortran (part 1).

If you update the patch with the documentation, I'd be happy to commit it for you!

Tue, Mar 12, 2:51 PM · Restricted Project, debug-info
aprantl accepted D54043: Adding debug info to support Fortran (part 1).

LGTM, however it would be important to also document the new flags in docs/SourceLevelDebugging.rst or LangRef.rst.

Tue, Mar 12, 1:32 PM · Restricted Project, debug-info
aprantl added a comment to D59235: Remove Support for DWARF64.

Agreed, and we've been doing this for new patches for a while now. However, I very strongly prefer having asserts over "returning a default value", which only hides real bugs.

Tue, Mar 12, 1:24 PM · Restricted Project
aprantl added inline comments to D59235: Remove Support for DWARF64.
Tue, Mar 12, 10:13 AM · Restricted Project

Mon, Mar 11

aprantl accepted D59235: Remove Support for DWARF64.

LGTM, perhaps let's give this a day for others to chime in in case they missed the thread on lldb-dev.

Mon, Mar 11, 4:06 PM · Restricted Project
aprantl added a comment to D54327: Adding debug info to support Fortran (part 3).

I am curious how debug info for common blocks plays with LTO. I think we would not want different common-block descriptions to be de-duplicated just because the global name was the same.

Our existing compilers do not make use of LLVM's LTO. Is there a suggestion on how to correctly deal with LTO's de-duplication?

Mon, Mar 11, 12:30 PM · Restricted Project, debug-info
aprantl accepted D58125: Add ability to import std module into expression parser to improve C++ debugging.
Mon, Mar 11, 12:29 PM · Restricted Project, Restricted Project, Restricted Project
aprantl added inline comments to D54043: Adding debug info to support Fortran (part 1).
Mon, Mar 11, 12:25 PM · Restricted Project, debug-info
aprantl added inline comments to D54043: Adding debug info to support Fortran (part 1).
Mon, Mar 11, 12:24 PM · Restricted Project, debug-info
aprantl added inline comments to D54043: Adding debug info to support Fortran (part 1).
Mon, Mar 11, 10:28 AM · Restricted Project, debug-info
aprantl committed rG5cc2790410b5: Makefile.rules: Upstream SDKROOT handling code for Darwin. (authored by aprantl).
Makefile.rules: Upstream SDKROOT handling code for Darwin.
Mon, Mar 11, 10:26 AM
aprantl added a comment to D59217: Fix/unify SBType comparison.

Interesting find. Thanks!

Mon, Mar 11, 10:14 AM · Restricted Project
aprantl committed rGf05b42e960a9: Bring Doxygen comment syntax in sync with LLVM coding style. This changes '@'… (authored by aprantl).
Bring Doxygen comment syntax in sync with LLVM coding style. This changes '@'…
Mon, Mar 11, 10:11 AM
aprantl accepted D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath().
Mon, Mar 11, 10:10 AM · Restricted Project
aprantl added a comment to D58125: Add ability to import std module into expression parser to improve C++ debugging.

This looks mostly good now.

Mon, Mar 11, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
aprantl added inline comments to D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath().
Mon, Mar 11, 9:04 AM · Restricted Project
aprantl added inline comments to D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath().
Mon, Mar 11, 8:59 AM · Restricted Project
aprantl accepted D59198: Correctly look up declarations in inline namespaces.
Mon, Mar 11, 8:58 AM · Restricted Project, Restricted Project
aprantl added a reviewer for D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);`: jordan_rose.
Mon, Mar 11, 8:52 AM · Restricted Project
aprantl added a comment to D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);`.

How can this change be NFC?

Mon, Mar 11, 8:52 AM · Restricted Project

Fri, Mar 8

aprantl added a comment to D59165: Remove DWARFDIECollection.

Whenever I see a GetFooAtIndex() method I expect this to be exposed via the SBAPI, but I assume this isn't the case here?

Fri, Mar 8, 4:53 PM · Restricted Project

Thu, Mar 7

aprantl committed rGde04a8c15000: Temporarily diasble debug output in GenericDomTreeConstruction.h to get the… (authored by aprantl).
Temporarily diasble debug output in GenericDomTreeConstruction.h to get the…
Thu, Mar 7, 3:32 PM
aprantl committed rG1d1ff88b727b: Make GenericDomTreeConstruction textual instead. (authored by aprantl).
Make GenericDomTreeConstruction textual instead.
Thu, Mar 7, 3:18 PM
aprantl committed rGd61c80b89e3e: Work around a module build error on the LLDB incremental green dragon bot. (authored by aprantl).
Work around a module build error on the LLDB incremental green dragon bot.
Thu, Mar 7, 2:25 PM
aprantl committed rG0c72a42a8f4a: Add an LLVM-style dump method to CompilerType for extra convenience during… (authored by aprantl).
Add an LLVM-style dump method to CompilerType for extra convenience during…
Thu, Mar 7, 12:20 PM
aprantl added a reviewer for D59102: Add an LLVM-style dump method to CompilerType for extra convenience during debugging: shafik.
Thu, Mar 7, 10:46 AM · Restricted Project, Restricted Project
aprantl created D59102: Add an LLVM-style dump method to CompilerType for extra convenience during debugging.
Thu, Mar 7, 10:45 AM · Restricted Project, Restricted Project
aprantl accepted D59004: [lldb] Fix DW_OP_addrx uses..
Thu, Mar 7, 9:30 AM · Restricted Project, Restricted Project

Wed, Mar 6

aprantl added a comment to D58952: [llvm] Skip over empty line table entries..

So just for the record, I'm fine with making this kind of change in case this got lost in the noise :-)

Wed, Mar 6, 4:50 PM · debug-info, Restricted Project
aprantl committed rGdb5a779f2fcb: Avoid using -S in combination with "script"; it's unreliable. (authored by aprantl).
Avoid using -S in combination with "script"; it's unreliable.
Wed, Mar 6, 4:46 PM
aprantl committed rGf4d2fa3fa088: crashlog.py: Catch exception from subprocess. (authored by aprantl).
crashlog.py: Catch exception from subprocess.
Wed, Mar 6, 4:42 PM
aprantl committed rG59a94225c9ca: Relax testcase. (authored by aprantl).
Relax testcase.
Wed, Mar 6, 4:34 PM
aprantl accepted D55626: [Reproducers] Add tests for functionality.
Wed, Mar 6, 4:22 PM · Restricted Project, Restricted Project
aprantl committed rG28f7466f4ef7: Promote more debug-only assertions to regular assertions. (authored by aprantl).
Promote more debug-only assertions to regular assertions.
Wed, Mar 6, 4:14 PM
aprantl committed rG1dfba3cfba94: Promote more debug-only assertions to regular assertions. (authored by aprantl).
Promote more debug-only assertions to regular assertions.
Wed, Mar 6, 4:11 PM
aprantl added inline comments to D55626: [Reproducers] Add tests for functionality.
Wed, Mar 6, 3:37 PM · Restricted Project, Restricted Project
aprantl added inline comments to D55626: [Reproducers] Add tests for functionality.
Wed, Mar 6, 2:58 PM · Restricted Project, Restricted Project
aprantl requested changes to D55626: [Reproducers] Add tests for functionality.
Wed, Mar 6, 2:58 PM · Restricted Project, Restricted Project
aprantl added inline comments to D58952: [llvm] Skip over empty line table entries..
Wed, Mar 6, 2:38 PM · debug-info, Restricted Project
aprantl committed rG0e4c482124f0: Pass ConstString by value (NFC) (authored by aprantl).
Pass ConstString by value (NFC)
Wed, Mar 6, 1:24 PM
aprantl accepted D58992: [CUDA][HIP][DebugInfo] Skip reference device function.
Wed, Mar 6, 1:09 PM · Restricted Project, debug-info, Restricted Project
aprantl added a comment to D58952: [llvm] Skip over empty line table entries..

@JDevlieghere since this is in general code: Could this affect dsymutil at all?

Wed, Mar 6, 1:00 PM · debug-info, Restricted Project
aprantl added a comment to D58952: [llvm] Skip over empty line table entries..

@JDevlieghere since this is in general code: Could this affect dsymutil at all?

Wed, Mar 6, 12:55 PM · debug-info, Restricted Project
aprantl added reviewers for D58952: [llvm] Skip over empty line table entries.: friss, JDevlieghere.
Wed, Mar 6, 12:54 PM · debug-info, Restricted Project
aprantl added inline comments to D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp.
Wed, Mar 6, 12:53 PM · Restricted Project
aprantl updated the summary of D59030: Pass ConstString by value.
Wed, Mar 6, 9:33 AM · Restricted Project, Restricted Project
aprantl created D59030: Pass ConstString by value.
Wed, Mar 6, 9:29 AM · Restricted Project, Restricted Project
aprantl added inline comments to D58992: [CUDA][HIP][DebugInfo] Skip reference device function.
Wed, Mar 6, 8:38 AM · Restricted Project, debug-info, Restricted Project

Tue, Mar 5

aprantl committed rG61f1b70a78fb: Replace debug-only assert with a plain old assert. (authored by aprantl).
Replace debug-only assert with a plain old assert.
Tue, Mar 5, 5:08 PM
aprantl added a comment to D59004: [lldb] Fix DW_OP_addrx uses..

Is there a way to force clang to generate this and/or are existing tests failing because this support is missing?

Tue, Mar 5, 4:03 PM · Restricted Project, Restricted Project
aprantl added a comment to D59004: [lldb] Fix DW_OP_addrx uses..

The code looks fine, but this needs a testcase.

Tue, Mar 5, 4:01 PM · Restricted Project, Restricted Project
aprantl added a reviewer for D59004: [lldb] Fix DW_OP_addrx uses.: clayborg.
Tue, Mar 5, 4:01 PM · Restricted Project, Restricted Project
aprantl committed rGd823020bacb1: Remove tautological #ifdefs (NFC) (authored by aprantl).
Remove tautological #ifdefs (NFC)
Tue, Mar 5, 3:53 PM
aprantl added a comment to D58698: [DWARFFormValue] Don't consider DW_FORM_data4/8 to be section offsets..

Is there a way to make the DWARF unit non-optional in this function?

Tue, Mar 5, 3:09 PM · Restricted Project
aprantl added a reviewer for D58992: [CUDA][HIP][DebugInfo] Skip reference device function: dblaikie.
Tue, Mar 5, 3:08 PM · Restricted Project, debug-info, Restricted Project
aprantl accepted D58698: [DWARFFormValue] Don't consider DW_FORM_data4/8 to be section offsets..
Tue, Mar 5, 3:08 PM · Restricted Project
aprantl accepted D58748: [ExpressionParser] Test GetClangResourceDir.
Tue, Mar 5, 3:08 PM · Restricted Project
aprantl added a comment to D58748: [ExpressionParser] Test GetClangResourceDir.

Looks mostly good!

Tue, Mar 5, 12:23 PM · Restricted Project

Mon, Mar 4

aprantl added a comment to D58838: Remove tautological #ifdefs.

Ping. As far as I can tell, now this patch should be entirely NFC.

Mon, Mar 4, 3:55 PM · Restricted Project
aprantl added inline comments to D58125: Add ability to import std module into expression parser to improve C++ debugging.
Mon, Mar 4, 1:43 PM · Restricted Project, Restricted Project, Restricted Project
aprantl added inline comments to D58125: Add ability to import std module into expression parser to improve C++ debugging.
Mon, Mar 4, 10:59 AM · Restricted Project, Restricted Project, Restricted Project