Page MenuHomePhabricator

aprantl (Adrian Prantl)
User

Projects

User Details

User Since
Mar 2 2013, 8:12 AM (432 w, 5 d)

Recent Activity

Today

aprantl requested review of D104483: Improve error handling in llvm-dwarfdump.
Thu, Jun 17, 12:52 PM · Restricted Project

Yesterday

aprantl committed rG42e2a9068419: Relax language comparison when matching up C++ forward decls with definitions (authored by aprantl).
Relax language comparison when matching up C++ forward decls with definitions
Wed, Jun 16, 6:22 PM
aprantl committed rGf9aba9a5afe0: Move the definition of LLVM_SUPPORT_XCODE_SIGNPOSTS into llvm-config.h (authored by aprantl).
Move the definition of LLVM_SUPPORT_XCODE_SIGNPOSTS into llvm-config.h
Wed, Jun 16, 2:41 PM
aprantl requested review of D104407: Improve path remapping in cross-debugging scenarios.
Wed, Jun 16, 11:48 AM
aprantl requested review of D104406: Express PathMappingList::FindFile() in terms of PathMappingList.h::RemapPath() (NFC).
Wed, Jun 16, 11:34 AM
aprantl requested review of D104405: Change PathMappingList::FindFile to return an optional result (NFC).
Wed, Jun 16, 11:32 AM
aprantl requested review of D104404: Change PathMappingList::RemapPath to return an optional result (NFC).
Wed, Jun 16, 11:30 AM

Tue, Jun 15

aprantl committed rG073e7a08e83a: Work around MSVC compiler intricacies. (authored by aprantl).
Work around MSVC compiler intricacies.
Tue, Jun 15, 8:18 AM
aprantl added a comment to D103575: Allow signposts to take advantage of deferred string substitution.

I tried to work around it.

Tue, Jun 15, 8:18 AM · Restricted Project, Restricted Project
aprantl added a comment to D103575: Allow signposts to take advantage of deferred string substitution.

which is weird because I didn't actually change that.

Tue, Jun 15, 8:08 AM · Restricted Project, Restricted Project
aprantl added a comment to D103575: Allow signposts to take advantage of deferred string substitution.

The Windows buildbot does not like signposts:

https://lab.llvm.org/buildbot/#/builders/83/builds/7271

Tue, Jun 15, 8:07 AM · Restricted Project, Restricted Project

Mon, Jun 14

aprantl committed rG035217ff515b: Allow signposts to take advantage of deferred string substitution (authored by aprantl).
Allow signposts to take advantage of deferred string substitution
Mon, Jun 14, 4:54 PM
aprantl added a reverting change for rG03841edde7ee: Allow signposts to take advantage of deferred string substitution: rG7a7c00761f62: Revert "Allow signposts to take advantage of deferred string substitution".
Mon, Jun 14, 4:09 PM
aprantl committed rG7a7c00761f62: Revert "Allow signposts to take advantage of deferred string substitution" (authored by aprantl).
Revert "Allow signposts to take advantage of deferred string substitution"
Mon, Jun 14, 4:09 PM
aprantl added a reverting change for D103575: Allow signposts to take advantage of deferred string substitution: rG7a7c00761f62: Revert "Allow signposts to take advantage of deferred string substitution".
Mon, Jun 14, 4:09 PM · Restricted Project, Restricted Project
aprantl committed rG03841edde7ee: Allow signposts to take advantage of deferred string substitution (authored by aprantl).
Allow signposts to take advantage of deferred string substitution
Mon, Jun 14, 2:20 PM

Fri, Jun 11

aprantl committed rG8fb53dca2f61: Improve materializer error messages to include type names. (authored by aprantl).
Improve materializer error messages to include type names.
Fri, Jun 11, 5:59 PM
aprantl committed rG4fc93a3a1f95: Allow signposts to take advantage of deferred string substitution (authored by aprantl).
Allow signposts to take advantage of deferred string substitution
Fri, Jun 11, 4:52 PM
aprantl added a reverting change for rG541ccd1c1bb2: Allow signposts to take advantage of deferred string substitution: rGb90f9bea9673: Revert "Allow signposts to take advantage of deferred string substitution".
Fri, Jun 11, 4:47 PM
aprantl committed rGb90f9bea9673: Revert "Allow signposts to take advantage of deferred string substitution" (authored by aprantl).
Revert "Allow signposts to take advantage of deferred string substitution"
Fri, Jun 11, 4:47 PM
aprantl added a reverting change for D103575: Allow signposts to take advantage of deferred string substitution: rGb90f9bea9673: Revert "Allow signposts to take advantage of deferred string substitution".
Fri, Jun 11, 4:47 PM · Restricted Project, Restricted Project
aprantl committed rG635b72136e95: Disambiguate usage of struct mach_header and other MachO definitions. (authored by aprantl).
Disambiguate usage of struct mach_header and other MachO definitions.
Fri, Jun 11, 4:36 PM
aprantl committed rG541ccd1c1bb2: Allow signposts to take advantage of deferred string substitution (authored by aprantl).
Allow signposts to take advantage of deferred string substitution
Fri, Jun 11, 4:36 PM
aprantl closed D103575: Allow signposts to take advantage of deferred string substitution.
Fri, Jun 11, 4:35 PM · Restricted Project, Restricted Project

Thu, Jun 10

aprantl added a comment to D103575: Allow signposts to take advantage of deferred string substitution.

Let me know if this goes into the right direction.

Thu, Jun 10, 7:04 PM · Restricted Project, Restricted Project
aprantl updated the diff for D103575: Allow signposts to take advantage of deferred string substitution.

Address review feedback from @JDevlieghere.

Thu, Jun 10, 7:03 PM · Restricted Project, Restricted Project

Tue, Jun 8

aprantl accepted D103910: [llvm] Sync DebugInfo.h with DebugInfoFlags.def.
Tue, Jun 8, 3:25 PM · Restricted Project

Mon, Jun 7

aprantl added a comment to D103575: Allow signposts to take advantage of deferred string substitution.

I'm not sure I fully understand the suggestion:

Mon, Jun 7, 4:36 PM · Restricted Project, Restricted Project

Thu, Jun 3

aprantl added a comment to D101340: Allows for dsymutil crashes to generate reproduceable information.

I think I have addressed the review comments but I'd be happy to fix anything I missed

Thu, Jun 3, 4:16 PM · Restricted Project
aprantl added inline comments to D103502: Bug 41152 - [DebugInfo] Better dumping of empty location expression .
Thu, Jun 3, 4:13 PM · debug-info, Restricted Project
aprantl added a comment to D86813: [DebugInstrRef][2/3] Track PHI values through register coalescing.

lgtm

Cheers,

@jmorse @aprantl Sorry for the divergence, but regarding this tests reduction in terms of DI Metadata -- do you think that we can automate this process? I've written a small write-up/proposal for a utility for that purpose: https://github.com/djolertrk/llvm-metadataburn -- please let me know what you think.

Highly relevant to my interests, this'd save 5-10 minutes frequently fiddling with metadata, and it eases newcomers preparation / revision of patches. Yes please!

Thu, Jun 3, 4:10 PM · Restricted Project
aprantl committed rGa8099b477832: Remove redundant Begin/End form signpost format strings. (authored by aprantl).
Remove redundant Begin/End form signpost format strings.
Thu, Jun 3, 11:24 AM
aprantl closed D103577: RFC: Remove redundant Begin/End form signpost format strings..
Thu, Jun 3, 11:24 AM · Restricted Project
aprantl updated the diff for D103577: RFC: Remove redundant Begin/End form signpost format strings..

I just confirmed that passing an empty string for the end event looks even better in Instruments.

Thu, Jun 3, 9:30 AM · Restricted Project

Wed, Jun 2

aprantl requested review of D103577: RFC: Remove redundant Begin/End form signpost format strings..
Wed, Jun 2, 5:32 PM · Restricted Project
aprantl requested review of D103575: Allow signposts to take advantage of deferred string substitution.
Wed, Jun 2, 5:29 PM · Restricted Project, Restricted Project
aprantl added inline comments to D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.
Wed, Jun 2, 3:33 PM · Restricted Project
aprantl accepted D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.

Impressive. I spot-checked a few instances and this generally looks great. Let's hope the test suite agrees!

Wed, Jun 2, 3:31 PM · Restricted Project
aprantl added a comment to D102412: [coro] Preserve scope line for compiler generated functions.

Thanks! LGTM

Wed, Jun 2, 3:21 PM · Restricted Project
aprantl added inline comments to D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().
Wed, Jun 2, 9:53 AM · Restricted Project
aprantl committed rGfcfaed4ae6d7: Remove redundant comparisons (NFC) (authored by aprantl).
Remove redundant comparisons (NFC)
Wed, Jun 2, 9:53 AM

Tue, Jun 1

aprantl added inline comments to D103349: [lldb] Don't print script output twice in HandleCommand.
Tue, Jun 1, 8:59 AM · Restricted Project

Fri, May 28

aprantl accepted D96510: [cross-project-tests] Add lld as a dependency, if in LLVM_ENABLE_PROJECTS - part 3.

Seems plausible.

Fri, May 28, 11:41 AM · Restricted Project
aprantl added inline comments to D86813: [DebugInstrRef][2/3] Track PHI values through register coalescing.
Fri, May 28, 11:39 AM · Restricted Project

Thu, May 27

aprantl added a comment to D102412: [coro] Preserve scope line for compiler generated functions.

Could you attach new debug info to one of the other functions in this file? Or is there only a single .resume function being generated for the entire test?

Thu, May 27, 3:29 PM · Restricted Project
aprantl committed rGf3869a5c32b7: Support stripping indirectly referenced DILocations from !llvm.loop metadata (authored by aprantl).
Support stripping indirectly referenced DILocations from !llvm.loop metadata
Thu, May 27, 1:24 PM
aprantl closed D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().
Thu, May 27, 1:24 PM · Restricted Project
aprantl updated the diff for D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().

Add more comments

Thu, May 27, 11:20 AM · Restricted Project
aprantl added a reviewer for D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo(): shafik.
Thu, May 27, 11:06 AM · Restricted Project
aprantl updated the diff for D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().

Add another comment and explicitly mark lambda captures.

Thu, May 27, 11:06 AM · Restricted Project
aprantl updated the diff for D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().

Address review feedback.

Thu, May 27, 9:44 AM · Restricted Project
aprantl added inline comments to D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().
Thu, May 27, 9:44 AM · Restricted Project
aprantl added inline comments to D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().
Thu, May 27, 9:37 AM · Restricted Project

Wed, May 26

aprantl requested review of D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().
Wed, May 26, 7:10 PM · Restricted Project

Mon, May 24

aprantl committed rG4cba0a4f11e4: CoroSplit: Replace ad-hoc implementation of reachability with API from CFG.h (authored by aprantl).
CoroSplit: Replace ad-hoc implementation of reachability with API from CFG.h
Mon, May 24, 9:19 AM
aprantl closed D102963: CoroSplit: Replace ad-hoc implementation of reachability with API from CFG.h.
Mon, May 24, 9:18 AM · Restricted Project
aprantl accepted D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls.
Mon, May 24, 9:03 AM · Restricted Project

Fri, May 21

aprantl added a comment to D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4.

If gracefully lowering rvalue references to references needs knowledge about the Clang typesystem (or depends on LLVM IR type uniquing to be efficient, as @dblaikie points out) then we should do it in the Clang frontend. As much as we can we should avoid encoding debug info format specific knowledge in the Clang frontend, but that's not always possible. I'm fine with taking this patch.

Fri, May 21, 7:35 PM · Restricted Project, Restricted Project, debug-info
aprantl accepted D102680: [debuginfo-tests] Stop using installed LLDB and remove redundancy.

If the intended effect is that we run the debuginfo-tests against the just-built LLDB this change makes sense to me in a monorepo world. Conditional LGTM from me.

Fri, May 21, 7:25 PM · Restricted Project
aprantl added inline comments to D102412: [coro] Preserve scope line for compiler generated functions.
Fri, May 21, 7:21 PM · Restricted Project
aprantl accepted D102412: [coro] Preserve scope line for compiler generated functions.

Looks good (with a testcase). It should be easy to adapt an existing testcase for this by artificially changing a suspend point's !dbg location to use a different file name.

Fri, May 21, 7:19 PM · Restricted Project
aprantl requested review of D102963: CoroSplit: Replace ad-hoc implementation of reachability with API from CFG.h.
Fri, May 21, 7:09 PM · Restricted Project

May 17 2021

aprantl added a comment to D102412: [coro] Preserve scope line for compiler generated functions.

This is good, but we should add a test for this. There are already one or two tests that are affected by this, so you can probably just modify one of them to use line 0.

May 17 2021, 4:55 PM · Restricted Project

May 14 2021

aprantl requested changes to D102412: [coro] Preserve scope line for compiler generated functions.

<compiler-generated> is just something the Swift frontend picks as filename but LLVM shouldn't treat it as special.

May 14 2021, 1:01 PM · Restricted Project

May 13 2021

aprantl added a comment to D102445: Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember.

I guess we could add least add a comment like this?

// By calling member_type instead of member_clang_type, the size comes from DWARF, which avoids premature record layout.
May 13 2021, 6:48 PM · Restricted Project
aprantl accepted D102445: Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember.

The change itself seems good to me, I wonder what we can do to prevent a similar mistake in the future.

May 13 2021, 6:46 PM · Restricted Project

May 12 2021

aprantl added a comment to D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4.

Doing this in the backend SGTM, assuming all of @dblaikie's comments are addressed.

May 12 2021, 7:34 PM · Restricted Project, Restricted Project, debug-info
aprantl accepted D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4.
May 12 2021, 7:33 PM · Restricted Project, Restricted Project, debug-info
aprantl added a comment to D102158: [DebugInfo][Docs] Add corrected docs for how InstrRefBasedLDV works.

I only had time for a few superficial comments so far and this deserves an in-depth read, but I greatly appreciate the time and effert that went into putting this to paper!

May 12 2021, 7:26 PM · Restricted Project
aprantl accepted D96513: [cross-project-tests] Add/update check-* targets for cross-project-tests - part 5.

I think this looks reasonable?

May 12 2021, 7:15 PM · Restricted Project
aprantl committed rG017d7a9e1424: Rename human-readable name for DW_LANG_Mips_Assembler (authored by aprantl).
Rename human-readable name for DW_LANG_Mips_Assembler
May 12 2021, 7:14 PM
aprantl closed D101406: Rename human-readable name for DW_LANG_Mips_Assembler.
May 12 2021, 7:14 PM · Restricted Project
aprantl accepted D96509: [cross-project-tests] Rename variables to make sense for new top-level directory name - part 2.
May 12 2021, 7:08 PM · Restricted Project
aprantl accepted D99179: [RFC] [Coroutines] Enable printing coroutine frame in debugger if program is compiled with -g.

Sorry for the delay. LGTM assuming @dblaikie is happy too.

May 12 2021, 7:07 PM · debug-info, Restricted Project
aprantl accepted D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.values.
May 12 2021, 7:05 PM · debug-info, Restricted Project
aprantl accepted D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement.
May 12 2021, 6:29 PM · Restricted Project, debug-info

May 7 2021

aprantl committed rGc6ddf669dcf3: Fix the module-enabled build by removing a redundant type definition. (authored by aprantl).
Fix the module-enabled build by removing a redundant type definition.
May 7 2021, 2:45 PM

May 4 2021

aprantl committed rG6c3a10760da3: Mark Basic/TargetCXXABI.def as textual in the module map. (authored by aprantl).
Mark Basic/TargetCXXABI.def as textual in the module map.
May 4 2021, 12:53 PM

May 3 2021

aprantl accepted D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.
May 3 2021, 2:37 PM · Restricted Project
aprantl added a comment to D78203: [VP,Integer,#2] ExpandVectorPredication pass.

Since it's already late on Friday I took the liberty to revert the commit so the bots can recover and you can investigate the failure at your own pace. Let me know if I can help with the fix!

Thanks for taking action! I'll look into how include/llvm/CodeGen/MachinePassRegistry.def actually works.. i suppose moving the entry from DUMMY_FUNCTION_PASS to FUNCTION_PASS should fix this (will reproduce and fix locally). Never had a revert, what is the usual procedure to recommit after revert? (update/new diff, review, or just commit with the fix?)

May 3 2021, 10:54 AM · Restricted Project, Restricted Project

Apr 30 2021

aprantl added a comment to D78203: [VP,Integer,#2] ExpandVectorPredication pass.

Since it's already late on Friday I took the liberty to revert the commit so the bots can recover and you can investigate the failure at your own pace. Let me know if I can help with the fix!

Apr 30 2021, 5:04 PM · Restricted Project, Restricted Project
aprantl added a reverting change for rG43bc584dc05e: [VP,Integer,#2] ExpandVectorPredication pass: rG02c5ba867987: Revert "[VP,Integer,#2] ExpandVectorPredication pass".
Apr 30 2021, 5:03 PM
aprantl committed rG02c5ba867987: Revert "[VP,Integer,#2] ExpandVectorPredication pass" (authored by aprantl).
Revert "[VP,Integer,#2] ExpandVectorPredication pass"
Apr 30 2021, 5:03 PM
aprantl added a reverting change for D78203: [VP,Integer,#2] ExpandVectorPredication pass: rG02c5ba867987: Revert "[VP,Integer,#2] ExpandVectorPredication pass".
Apr 30 2021, 5:03 PM · Restricted Project, Restricted Project
aprantl added a comment to D78203: [VP,Integer,#2] ExpandVectorPredication pass.

This commit may have broken the -DLLVM_ENABLE_MODULES=1 build. See http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31603/consoleFull#2136199809a1ca8a51-895e-46c6-af87-ce24fa4cd561

FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandVectorPredication.cpp.o 
/Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/clang++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/CodeGen -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/CodeGen -Iinclude -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include -Wdocumentation -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -fmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/module.cache -fcxx-modules -Xclang -fmodules-local-submodule-visibility -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -fdiagnostics-color -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk    -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandVectorPredication.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandVectorPredication.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandVectorPredication.cpp.o -c /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/CodeGen/ExpandVectorPredication.cpp
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/CodeGen/ExpandVectorPredication.cpp:461:30: error: redefinition of 'run'
ExpandVectorPredicationPass::run(Function &F, FunctionAnalysisManager &AM) {
                             ^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/MachinePassRegistry.def:106:1: note: previous definition is here
DUMMY_FUNCTION_PASS("expandvp", ExpandVectorPredicationPass, ())
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:68:23: note: expanded from macro 'DUMMY_FUNCTION_PASS'
    PreservedAnalyses run(Function &, FunctionAnalysisManager &) {             \
                      ^
1 error generated.
Apr 30 2021, 2:10 PM · Restricted Project, Restricted Project

Apr 29 2021

aprantl added a comment to D101537: [lldb] Make the NSSet formatter faster and less prone to infinite recursion.

Functionally this LGTM. Would be curious to do git archeology to understand why the old code used this pattern.

Apr 29 2021, 10:16 AM · Restricted Project

Apr 28 2021

aprantl added inline comments to D62732: [RISCV] Add SystemV ABI.
Apr 28 2021, 5:58 PM · Restricted Project

Apr 27 2021

aprantl requested review of D101406: Rename human-readable name for DW_LANG_Mips_Assembler.
Apr 27 2021, 3:36 PM · Restricted Project
aprantl committed rG711a473cd9e3: Update testcase for D101333. (authored by aprantl).
Update testcase for D101333.
Apr 27 2021, 1:24 PM
aprantl committed rG25bf137b1ea3: Also display the underlying error message when displaying a fixit (authored by aprantl).
Also display the underlying error message when displaying a fixit
Apr 27 2021, 10:41 AM
aprantl closed D101333: Also display the underlying error message when displaying a fixit.
Apr 27 2021, 10:41 AM · Restricted Project

Apr 26 2021

aprantl requested review of D101333: Also display the underlying error message when displaying a fixit.
Apr 26 2021, 4:49 PM · Restricted Project

Apr 23 2021

aprantl added inline comments to D100628: [Debug-Info][DBX] DW_AT_noreturn should not be generated when dwarf version is not 5.
Apr 23 2021, 9:58 AM · debug-info, Restricted Project

Apr 22 2021

aprantl added a comment to D99693: Update the linkage name of coro-split functions where applicable.

I believe that this is purely a limitation of AsmPrinter and that we could probably change its behavior to emit different linkage names in different instances, but I have not looked at what various debuggers expect here and DWARF GCC emits for C++ coroutines. I was mostly focussed on getting the Swift case right, while not disturbing C++.

Apr 22 2021, 12:49 PM · Restricted Project
aprantl added a comment to D99693: Update the linkage name of coro-split functions where applicable.

Ah, so that's more about whether the name was demangleable - but I thought there was also an issue when the DW_AT_linkage_name differed from the real mangled name of the symbol, even if both names could be demangled?

Apr 22 2021, 12:47 PM · Restricted Project
aprantl committed rG007158ac42c7: Skip unreliable LLDB tests when running under asan (authored by aprantl).
Skip unreliable LLDB tests when running under asan
Apr 22 2021, 11:56 AM

Apr 21 2021

aprantl added a comment to D99693: Update the linkage name of coro-split functions where applicable.

What's this claim ^ about/based on? What happens if it doesn't hold the original linkage name?

Apr 21 2021, 4:22 PM · Restricted Project
aprantl added a comment to D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.values.

@lxfind wrote:

Why doesn't replaceUsesOfWith work? Could you double check that replaceUsesOfWith doesn't work for DbgValueInst?

Apr 21 2021, 2:46 PM · debug-info, Restricted Project
aprantl added a comment to D99693: Update the linkage name of coro-split functions where applicable.

This patch does not affect C++ coroutines, since the DW_AT_specification is expected to hold the (original) linkage name.

So does this mean that for C++ we'll have a DW_TAG_subprogram with a DW_AT_linkage_name that doesn't match the symbol for that code in the object's symbol table?

Apr 21 2021, 2:05 PM · Restricted Project
aprantl added a comment to D100632: [DebugInfo] Move the findDbg* functions into DebugInfo.cpp.

Thanks!

Apr 21 2021, 2:03 PM · Restricted Project, debug-info