aprantl (Adrian Prantl)
User

Projects

User Details

User Since
Mar 2 2013, 8:12 AM (285 w, 4 h)

Recent Activity

Yesterday

aprantl added inline comments to D50887: [DWARF] Missing location debug information with -O2..
Fri, Aug 17, 8:44 AM
aprantl added inline comments to D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Fri, Aug 17, 8:34 AM

Thu, Aug 16

aprantl added a comment to D50870: Close FileEntries of cached files in ModuleManager::addModule()..

@bruno: When we last discussed this my plan was to avoid the stat() in lookupModuleFile() for files that were just added to the PCMCache by WriteAST() entirely, but ModuleManager::Modules is a DenseMap<FileEntry, ModuleFile *> and lookupModuleFile() is the easiest way to create a new FileEntry. It would be nice to find a way to avoid the stat() for a file that we just wrote, but it wasn't immediately obvious to me how to do that.

Thu, Aug 16, 3:06 PM
aprantl created D50870: Close FileEntries of cached files in ModuleManager::addModule()..
Thu, Aug 16, 2:56 PM
aprantl added a comment to D50213: DebugInfo: Add metadata support for disabling DWARF pub sections.

Looks good from my point of view.

Thu, Aug 16, 2:27 PM
aprantl added a comment to D50213: DebugInfo: Add metadata support for disabling DWARF pub sections.

Sorry, my mistake. I saw that you added a new field in the IR assembler and sloppily assumed that there is also a new bitcode record for it, but there isn't, so the whole point is moot.

Thu, Aug 16, 8:32 AM

Wed, Aug 15

aprantl added a comment to D50213: DebugInfo: Add metadata support for disabling DWARF pub sections.

Can you add a bitcode upgrade test?

I could - but I'm not sure it would test anything. The format has in some sense remained the same - this field is still zero/one before/after the change, but now new values are also valid.
Reckon it's still worth testing? What do you reckon that testing would cover?

Wed, Aug 15, 1:27 PM
aprantl added a comment to D50213: DebugInfo: Add metadata support for disabling DWARF pub sections.

Currently has no effect, but see above ^ - I reckon it probably should. Maybe we can generalize the name of the property? "nameTable: " {None, Default (v4 or v5 based on DWARF version), GNU (only makes sense for v4 though - ignored if you end up building v5? seems reasonable to me)}

Wed, Aug 15, 10:08 AM
aprantl added inline comments to D50213: DebugInfo: Add metadata support for disabling DWARF pub sections.
Wed, Aug 15, 10:06 AM

Tue, Aug 14

aprantl added a comment to D50734: Add proper headers in CFGUpdate.h and add CFGDiff.h in the list of delayed headers for LLVM_intrinsic_gen..

That looks good!

Tue, Aug 14, 3:02 PM
aprantl accepted D50722: Stability improvements for CompletionTest.

Thanks, let's just give it try!

Tue, Aug 14, 11:39 AM

Mon, Aug 13

aprantl added inline comments to D49887: [DebugInfo] Add support for DWARF5 call site-related attributes.
Mon, Aug 13, 10:18 AM · debug-info
aprantl added inline comments to D49887: [DebugInfo] Add support for DWARF5 call site-related attributes.
Mon, Aug 13, 10:17 AM · debug-info
aprantl added a comment to D50621: [DebugInfo] Fix bug in LiveDebugVariables..

Do you have a testcase for this? You should be able to construct an artificial MIR testcase.

Mon, Aug 13, 9:31 AM
aprantl accepted D50622: [DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI..
Mon, Aug 13, 9:29 AM
aprantl accepted D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

Thanks!

Mon, Aug 13, 9:28 AM
aprantl added inline comments to D49887: [DebugInfo] Add support for DWARF5 call site-related attributes.
Mon, Aug 13, 9:25 AM · debug-info

Fri, Aug 10

aprantl added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Fri, Aug 10, 4:06 PM
aprantl added inline comments to D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..
Fri, Aug 10, 4:01 PM

Thu, Aug 9

aprantl added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Thu, Aug 9, 5:56 PM
aprantl added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Thu, Aug 9, 2:19 PM

Wed, Aug 8

aprantl accepted D49381: [DWARF] Unclamp line table version on Darwin for v5 and later..

Looks right.

Wed, Aug 8, 8:44 AM · debug-info
aprantl accepted D50453: [DebugInfo] Fine tune emitting flags as part of the producer.

Thanks!

Wed, Aug 8, 8:43 AM

Tue, Aug 7

aprantl added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Tue, Aug 7, 12:45 PM
aprantl added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Tue, Aug 7, 10:44 AM

Mon, Aug 6

aprantl added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Mon, Aug 6, 9:00 AM

Fri, Aug 3

aprantl added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

It would be cleanest to create a new, minimal test that only contains one global variable with a basic type. The resulting bitcode should only be a few bytes and then it would be obvious what the tests tests.

Fri, Aug 3, 8:23 AM
aprantl accepted D50226: [DebugInfo] Use DbgVariableIntrinsic as the base class of variables..
Fri, Aug 3, 8:21 AM
aprantl accepted D50220: [DebugInfo] Refactor DbgInfoIntrinsic class hierarchy..

I think this is reasonable. Let's maybe give this another day to see if anyone sees a problem with this before landing it.

Fri, Aug 3, 8:20 AM

Thu, Aug 2

aprantl accepted D50197: [DebugInfo/DWARF] Try to make a loop more readable. NFC.

Thanks!

Thu, Aug 2, 1:19 PM · debug-info
aprantl accepted D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended..

Hmm.. yeah, this looks more like a side-channel than a proper part of the MI protocol. That said, this is also what the original code was doing, so we can investigate the proper protocol separately.

Thu, Aug 2, 1:09 PM
aprantl added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

The last thing that is missing is a bitcode upgrade test (unless you can show that one of the existing checked in .bc files in the testsuite also covers the upgrade path for the old, shorter DIBasicType).

Thu, Aug 2, 9:11 AM
aprantl added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Thu, Aug 2, 9:09 AM
aprantl added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Thu, Aug 2, 7:33 AM
aprantl added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Thu, Aug 2, 7:31 AM

Wed, Aug 1

aprantl added a comment to D50155: Delete MacOSXFrameBackchain unwind logic (NFC).

Deleting dead code is always good; I'll let Jason sign this off though.

Wed, Aug 1, 1:32 PM
aprantl added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

for the time being the basicType that maps to DW_TAG_base_type, but in future the variables created using that basictype or any other type with DW_TAG_variable and DW_TAG_formal_parameters tags.

Is it a property of the type or a property of the variable? I.e.: Can you have a struct with one LE member and one BE member?

Wed, Aug 1, 11:03 AM
aprantl added a comment to D49676: [DWARF] support for .debug_addr (consumer).

It looks like my request wasn't addressed either. Can you please fix this soon?

Wed, Aug 1, 7:54 AM · debug-info
aprantl added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

Do you need to support endinaness attributes just on basic types or eventually on any type?
This is still missing an assembler round-trip test.

Wed, Aug 1, 7:53 AM
aprantl added a comment to D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.

DILocation isn't only used for coverage, I think this should probably be a more general purpose flag, like "isImplicitCode", to indicate that the code was generated as part of a destructor cleanup, an epilogue, or something else that requires the compiler to generate IR that isn't obviously attributed to user source code. Then GCOV can decide for itself how it wants to generate coverage.

Wed, Aug 1, 7:48 AM · debug-info
aprantl added a comment to D43860: [AArch64] DWARF: do not generate AT_location for thread local.

@aprantl @JDevlieghere - This looks good to me, but could you take a glance & see if it's reasonable for AArch64 (though this is for ELF, not MachO - but figure it might cut close enough you might want to check it)

Wed, Aug 1, 7:45 AM
aprantl added inline comments to D50122: Complex Variable defined in InitCapture Crash fix .
Wed, Aug 1, 7:30 AM

Tue, Jul 31

aprantl accepted D49676: [DWARF] support for .debug_addr (consumer).

lgtm with the two parameters moved from DIDumpOptions into explict arguments of dumpAddrSection.

Tue, Jul 31, 3:02 PM · debug-info
aprantl accepted D49739: Add new API to SBTarget class.

sgtm.

Tue, Jul 31, 2:04 PM
aprantl added inline comments to D49739: Add new API to SBTarget class.
Tue, Jul 31, 1:20 PM
aprantl added inline comments to D49739: Add new API to SBTarget class.
Tue, Jul 31, 12:47 PM
aprantl accepted D50089: [DWARF v4] Suppressing the __debug_ranges section when there are no ranges.
Tue, Jul 31, 12:30 PM
aprantl added inline comments to D49739: Add new API to SBTarget class.
Tue, Jul 31, 12:29 PM
aprantl accepted D49741: [DebugInfo/DWARF] [1/4] De-segregate type units and compile units. NFC.

Thanks!

Tue, Jul 31, 10:00 AM · debug-info
aprantl added inline comments to D49739: Add new API to SBTarget class.
Tue, Jul 31, 9:59 AM
aprantl accepted D49744: [DebugInfo/DWARF] [4/4] De-segregate type units and compile units. NFC.
Tue, Jul 31, 9:59 AM · debug-info
aprantl added a comment to D49739: Add new API to SBTarget class.

Seems good otherwise.

Tue, Jul 31, 9:47 AM
aprantl added a comment to D49676: [DWARF] support for .debug_addr (consumer).

Sorry about the late reply, I've been on vacation.

Tue, Jul 31, 9:42 AM · debug-info

Mon, Jul 30

aprantl accepted D49741: [DebugInfo/DWARF] [1/4] De-segregate type units and compile units. NFC.
Mon, Jul 30, 11:50 AM · debug-info
aprantl accepted D48500: [DWARFASTParser] Remove special cases for `llvm-gcc`.
Mon, Jul 30, 8:17 AM
aprantl added inline comments to D49381: [DWARF] Unclamp line table version on Darwin for v5 and later..
Mon, Jul 30, 8:15 AM · debug-info
aprantl accepted D49520: Add integration test for ASan + -O1 + std::deque.
Mon, Jul 30, 8:14 AM · debug-info
aprantl added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

May I ask what the context of this is? Do you have a machine where some (but not all) basic types have a different endianity than the one specified by the ABI?

Mon, Jul 30, 8:13 AM
aprantl added a reviewer for D49744: [DebugInfo/DWARF] [4/4] De-segregate type units and compile units. NFC: JDevlieghere.
Mon, Jul 30, 7:55 AM · debug-info
aprantl added inline comments to D49744: [DebugInfo/DWARF] [4/4] De-segregate type units and compile units. NFC.
Mon, Jul 30, 7:54 AM · debug-info
aprantl accepted D49743: [DebugInfo/DWARF] [3/4] De-segregate type units and compile units. NFC.
Mon, Jul 30, 7:50 AM · debug-info
aprantl accepted D49742: [DebugInfo/DWARF] [2/4] De-segregate type units and compile units. NFC.

SGTM.

Mon, Jul 30, 7:50 AM · debug-info
aprantl added a comment to D49741: [DebugInfo/DWARF] [1/4] De-segregate type units and compile units. NFC.

The de-templatization will reduce the code size and I doubt that the virtual method overhead will be measurable. Looks like a good direction to me.

Mon, Jul 30, 7:47 AM · debug-info
aprantl added inline comments to D49887: [DebugInfo] Add support for DWARF5 call site-related attributes.
Mon, Jul 30, 7:41 AM · debug-info

Mon, Jul 23

aprantl added a comment to D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties..

@jingham: do you have any opinion about the right SBAPI for manipulating settings like Alexander outlined?

Mon, Jul 23, 1:49 AM

Jul 17 2018

aprantl added a comment to D49454: [DebugInfo] LowerDbgDeclare: Add derefs when handling CallInst users.

This looks like the right change as it makes the IR more regular.
Note that in the past this worked because allocas were implicitly indirect since they caused AsmPrinter to emit a what DWARF calls a "memory location". It's possible that that code path no longer exists or isn't triggered any more.

Jul 17 2018, 10:49 PM · debug-info

Jul 14 2018

aprantl accepted D49062: [lldb-mi] Re-implement data-info-line command..
Jul 14 2018, 12:35 AM

Jul 11 2018

aprantl accepted D49214: [DWARF v5] emit DWARF v5 range lists (no support for fission yet).

Thanks, I think this looks good!

Jul 11 2018, 11:22 PM
aprantl accepted D44016: [LiveDebugValues] Track transferring variable's value from one register to another.

Thanks!

Jul 11 2018, 11:14 PM · debug-info
aprantl added inline comments to D49062: [lldb-mi] Re-implement data-info-line command..
Jul 11 2018, 11:12 PM

Jul 9 2018

aprantl added inline comments to D49062: [lldb-mi] Re-implement data-info-line command..
Jul 9 2018, 11:15 AM
aprantl added a reviewer for D49062: [lldb-mi] Re-implement data-info-line command.: jingham.
Jul 9 2018, 11:12 AM
aprantl added inline comments to D49062: [lldb-mi] Re-implement data-info-line command..
Jul 9 2018, 9:05 AM

Jul 6 2018

aprantl accepted D49031: [AccelTable] Extract EmitterInfo.
Jul 6 2018, 1:22 PM
aprantl added inline comments to D49031: [AccelTable] Extract EmitterInfo.
Jul 6 2018, 9:36 AM

Jul 5 2018

aprantl accepted D45556: [DebugInfo] Generate DWARF debug information for labels..

A couple of cosmetic changes in line, but otherwise this LGTM.

Jul 5 2018, 6:44 PM
aprantl added a comment to D49003: [Debugify] Export per-pass debug info loss statistics.

This is definitely going to be very useful! It's not very large, but generally I wonder if llvm-developer-centric features like this should be made #ifndef NDEBUG-only to not weigh down clang releases' binary size?

Jul 5 2018, 5:33 PM
aprantl accepted D48676: [Local] replaceAllDbgUsesWith: Update debug values before RAUW.

Thanks, I think this looks good now!

Jul 5 2018, 1:17 PM
aprantl added inline comments to D48676: [Local] replaceAllDbgUsesWith: Update debug values before RAUW.
Jul 5 2018, 1:17 PM
aprantl added inline comments to D48676: [Local] replaceAllDbgUsesWith: Update debug values before RAUW.
Jul 5 2018, 11:00 AM
aprantl accepted D48977: Fixed redefinition warnings with LLVM_ENABLE_MODULES.

That looks like a safe change to make.

Jul 5 2018, 9:38 AM
aprantl added inline comments to D48676: [Local] replaceAllDbgUsesWith: Update debug values before RAUW.
Jul 5 2018, 8:25 AM

Jul 3 2018

aprantl accepted D48802: [lldb-mi] Re-implement symbol-list-lines command..
Jul 3 2018, 8:16 AM

Jul 2 2018

aprantl added a comment to D48775: Add new SBTarget::IsDummy method..

Okay then let's not do this for now. It's fine to revisit this later if there turns out to be a good use-case for it, but every SBAPI call we introduce has to be supported indefinitely and can therefore be quite expensive to maintain.

Jul 2 2018, 6:04 PM
aprantl added a comment to D48775: Add new SBTarget::IsDummy method..

Have you seen my earlier question:

Jul 2 2018, 5:33 PM
aprantl added a comment to D48801: Add new API to SBTarget and SBModule classes..

Fre

Jul 2 2018, 4:13 PM
aprantl accepted D48801: Add new API to SBTarget and SBModule classes..
Jul 2 2018, 3:44 PM
aprantl accepted D48520: [lldb-mi] Re-implement a few MI commands..
Jul 2 2018, 2:43 PM
aprantl accepted D48837: [DebugInfo] Corrections for salvageDebugInfo.

Thanks. This is an obvious improvement. It begs the question whether there is a better / more principled condition rather than "the expression is empty" to decide whether the stack_value should be added or not. Let me know if you have any ideas.

Jul 2 2018, 9:36 AM
aprantl added a comment to D44016: [LiveDebugValues] Track transferring variable's value from one register to another.

I think we're almost there now!

Jul 2 2018, 8:45 AM · debug-info
aprantl added inline comments to D44016: [LiveDebugValues] Track transferring variable's value from one register to another.
Jul 2 2018, 8:45 AM · debug-info
aprantl added a comment to D45556: [DebugInfo] Generate DWARF debug information for labels..

I think this is starting to look good. I have a few more comments inline.

Jul 2 2018, 8:35 AM
aprantl accepted D48802: [lldb-mi] Re-implement symbol-list-lines command..

LGTM with the inline keyword removed.

Jul 2 2018, 8:21 AM

Jun 30 2018

aprantl added a comment to D48802: [lldb-mi] Re-implement symbol-list-lines command..

This is going to be really nice!

Jun 30 2018, 9:48 AM
aprantl added a comment to D48801: Add new API to SBTarget and SBModule classes..

This seems like a reasonable addition. Could you also add documentation for the new API?

Jun 30 2018, 9:43 AM

Jun 29 2018

aprantl added inline comments to D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP). .
Jun 29 2018, 11:11 AM
aprantl added a comment to D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP). .

Is your plan to add dwp as another dimension in the test matrix (an equal citizen of DWARF, dSYM, DWO) or something that would be on or off for an entire run of the suite, or something only exercised by few specialized testcases?

Jun 29 2018, 11:09 AM
aprantl added a reviewer for D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP). : labath.
Jun 29 2018, 11:07 AM
aprantl added a comment to D48468: [SelectionDAG] Remove debug locations from ConstantSD(FP)Nodes.

In other words, the mov lr, #2 is the *materialization* of the constant and is no longer associated with a specific source location.

Jun 29 2018, 10:57 AM
aprantl added a comment to D48775: Add new SBTarget::IsDummy method..

Is the dummy target something we need to expose over the SBAPI?
I see that other places in lldb-mi query if (sbTarget == rSessionInfo.GetDebugger().GetDummyTarget()). Would that be sufficient?

Jun 29 2018, 10:14 AM