Page MenuHomePhabricator

aprantl (Adrian Prantl)
User

Projects

User Details

User Since
Mar 2 2013, 8:12 AM (324 w, 1 d)

Recent Activity

Fri, May 17

aprantl added inline comments to D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info.
Fri, May 17, 12:45 PM
aprantl added a comment to D62073: Introduce DWARFUnitHeader and use it to parse type units out of .debug_info.

Nice! FYI, we have a bot that runs the LLDB dotests against DWARF5 (the last stage http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/) to track the progress.

Fri, May 17, 12:44 PM
aprantl committed rG5d95b11b6b60: Update list of supported architectures. (authored by aprantl).
Update list of supported architectures.
Fri, May 17, 10:04 AM
aprantl added inline comments to D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Fri, May 17, 9:57 AM · debug-info
aprantl added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Fri, May 17, 9:55 AM · debug-info
aprantl added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Fri, May 17, 9:46 AM · debug-info
aprantl added inline comments to D60866: [DWARF] Handle DW_OP_entry_value operand.
Fri, May 17, 9:38 AM · debug-info
aprantl added inline comments to D62002: [DwarfExpression] Refactor dwarf expression kind (NFC).
Fri, May 17, 9:33 AM · debug-info
aprantl added a comment to D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).

LGTM.

Fri, May 17, 9:27 AM · debug-info
aprantl accepted D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).
Fri, May 17, 9:27 AM · debug-info

Thu, May 16

aprantl committed rG2b9a3ea13f4e: Slightly update the macOS part of status.rst to be less out-of-date. (authored by aprantl).
Slightly update the macOS part of status.rst to be less out-of-date.
Thu, May 16, 4:39 PM
aprantl accepted D62012: Make DWARFContext dwo-aware and port debug_info sections over.
Thu, May 16, 3:52 PM · Restricted Project
aprantl added inline comments to D60716: [DwarfDebug] Dump call site debug info into DWARF.
Thu, May 16, 3:46 PM · debug-info
aprantl added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, May 16, 3:41 PM · debug-info
aprantl added inline comments to D60866: [DWARF] Handle DW_OP_entry_value operand.
Thu, May 16, 3:38 PM · debug-info
aprantl added inline comments to D60866: [DWARF] Handle DW_OP_entry_value operand.
Thu, May 16, 3:38 PM · debug-info
aprantl accepted D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Thu, May 16, 3:34 PM · debug-info
aprantl added inline comments to D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Thu, May 16, 3:33 PM · debug-info
aprantl accepted D60714: [clang] Add DISuprogram and DIE for func decl of an external .

LGTM with three nitpicks inside.

Thu, May 16, 3:25 PM
aprantl updated subscribers of D61940: [DebugInfo] Don't always extend variable locations when the reg location is unchanging.

My understanding is that we deliberately don't terminate stack-based variable locations during frame destruction, because the debugger should understand that those become invalid as the frame is destroyed.

Thu, May 16, 3:19 PM · Restricted Project
aprantl added inline comments to D62002: [DwarfExpression] Refactor dwarf expression kind (NFC).
Thu, May 16, 3:11 PM · debug-info
aprantl accepted D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).

Thanks! One bonus cleanup inline :-)

Thu, May 16, 3:08 PM · debug-info
aprantl accepted D61933: [DebugInfo] Update loop metadata for inlined loops.
Thu, May 16, 3:03 PM · Restricted Project, debug-info
aprantl committed rGde2cc01286e4: Factor out switch statement into a helper function (NFC) (authored by aprantl).
Factor out switch statement into a helper function (NFC)
Thu, May 16, 1:01 PM
aprantl committed rG431dd943a1aa: Make sure GetObjectDescription falls back to the Objective-C runtime. (authored by aprantl).
Make sure GetObjectDescription falls back to the Objective-C runtime.
Thu, May 16, 12:20 PM
aprantl updated the diff for D62015: Make sure GetObjectDescription falls back to the Objective-C runtime..

Added test for raw pointer values.

Thu, May 16, 11:24 AM · Restricted Project
aprantl updated the diff for D62015: Make sure GetObjectDescription falls back to the Objective-C runtime..
Thu, May 16, 11:05 AM · Restricted Project
aprantl updated the diff for D62015: Make sure GetObjectDescription falls back to the Objective-C runtime..

Address review feedback.

Thu, May 16, 11:03 AM · Restricted Project
aprantl added inline comments to D62015: Make sure GetObjectDescription falls back to the Objective-C runtime..
Thu, May 16, 10:01 AM · Restricted Project
aprantl created D62015: Make sure GetObjectDescription falls back to the Objective-C runtime..
Thu, May 16, 10:01 AM · Restricted Project

Wed, May 15

aprantl committed rG8b92bb359eb4: Update LLDB license on the LLDB home page to Apache+LLVM. (authored by aprantl).
Update LLDB license on the LLDB home page to Apache+LLVM.
Wed, May 15, 2:57 PM
aprantl committed rG0d11505c7391: Get back the navigation sidebar on the LLDB website. (authored by aprantl).
Get back the navigation sidebar on the LLDB website.
Wed, May 15, 2:47 PM
aprantl accepted D61913: Get back the navigation sidebar on the LLDB website.
Wed, May 15, 2:36 PM · Restricted Project
aprantl updated the diff for D61913: Get back the navigation sidebar on the LLDB website.

More tweaks from Jonas & me.

Wed, May 15, 2:01 PM · Restricted Project
aprantl added inline comments to D61956: [CMake] Add first CMake cache files.
Wed, May 15, 11:41 AM · Restricted Project, Restricted Project
aprantl updated the diff for D61913: Get back the navigation sidebar on the LLDB website.

Add more context to the diff.

Wed, May 15, 10:52 AM · Restricted Project
aprantl updated the diff for D61913: Get back the navigation sidebar on the LLDB website.

I think I addressed most/all of the outstanding bugs.

Wed, May 15, 10:52 AM · Restricted Project
aprantl added a comment to D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).

Thanks a lot, this is going to be a far less error-prone API!

Wed, May 15, 9:14 AM · debug-info
aprantl accepted D61942: DWARFContext: Return empty data extractors instead of null pointers.
Wed, May 15, 9:01 AM · Restricted Project
aprantl added inline comments to D61940: [DebugInfo] Don't always extend variable locations when the reg location is unchanging.
Wed, May 15, 8:58 AM · Restricted Project
aprantl added inline comments to D61600: [DebugInfo] More precise variable range for stack locations.
Wed, May 15, 8:55 AM · debug-info
aprantl added a reviewer for D61933: [DebugInfo] Update loop metadata for inlined loops: anemet.
Wed, May 15, 8:52 AM · Restricted Project, debug-info
aprantl added a comment to D61933: [DebugInfo] Update loop metadata for inlined loops.

Seems reasonable, nitpicks inside.

Wed, May 15, 8:49 AM · Restricted Project, debug-info

Tue, May 14

aprantl added a comment to D61913: Get back the navigation sidebar on the LLDB website.

Do you think the fact that sphinx doesn't update the css will be a problem on lldb.llvm.org with the way the script is run? (ninja clean does not delete the html directory either).

Tue, May 14, 2:10 PM · Restricted Project
aprantl retitled D61913: Get back the navigation sidebar on the LLDB website from [WIP] Get back the navigation sidebar on the LLDB website to Get back the navigation sidebar on the LLDB website.
Tue, May 14, 2:09 PM · Restricted Project
aprantl updated the diff for D61913: Get back the navigation sidebar on the LLDB website.

Make Doxygen links in sidebar work.

Tue, May 14, 2:08 PM · Restricted Project
aprantl added inline comments to D61913: Get back the navigation sidebar on the LLDB website.
Tue, May 14, 12:52 PM · Restricted Project
aprantl added inline comments to D61913: Get back the navigation sidebar on the LLDB website.
Tue, May 14, 12:49 PM · Restricted Project
aprantl updated the summary of D61913: Get back the navigation sidebar on the LLDB website.
Tue, May 14, 12:48 PM · Restricted Project
aprantl created D61913: Get back the navigation sidebar on the LLDB website.
Tue, May 14, 12:48 PM · Restricted Project
aprantl committed rG19ae9d010dcf: Rename MacOS X -> macOS where applicable. (authored by aprantl).
Rename MacOS X -> macOS where applicable.
Tue, May 14, 9:36 AM
aprantl added inline comments to D61890: [LiveDebugValues] End variable's range with multiple locations at block entry.
Tue, May 14, 8:48 AM · debug-info
aprantl added a reviewer for D61890: [LiveDebugValues] End variable's range with multiple locations at block entry: wolfgangp.
Tue, May 14, 8:48 AM · debug-info
aprantl accepted D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.

Alright, thanks for taking the time to walk me through the thought process!

Tue, May 14, 8:35 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 13

aprantl committed rG39084ce3ce3d: LLDB website: Change the title back to "The LLDB Debugger" (authored by aprantl).
LLDB website: Change the title back to "The LLDB Debugger"
Mon, May 13, 7:30 PM
aprantl added inline comments to D60715: [ISEL][X86] Tracking of registers that forward call arguments.
Mon, May 13, 11:57 AM · debug-info
aprantl added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

I think we're getting there!

Mon, May 13, 11:56 AM · debug-info
aprantl added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, May 13, 11:49 AM · debug-info
aprantl added inline comments to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.
Mon, May 13, 11:41 AM · Restricted Project, Restricted Project, Restricted Project
aprantl added inline comments to D60866: [DWARF] Handle DW_OP_entry_value operand.
Mon, May 13, 10:29 AM · debug-info
aprantl added inline comments to D61061: [MachineFunction] Base support for call site info tracking.
Mon, May 13, 10:23 AM · debug-info
aprantl updated subscribers of D61061: [MachineFunction] Base support for call site info tracking.
Mon, May 13, 10:22 AM · debug-info
aprantl added inline comments to D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Mon, May 13, 10:22 AM
aprantl added inline comments to D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Mon, May 13, 10:16 AM · debug-info
aprantl added inline comments to D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo().
Mon, May 13, 10:12 AM

Thu, May 9

aprantl added inline comments to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.
Thu, May 9, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 8

aprantl added inline comments to D61680: [X86] Avoid SFB - Fix inconsistent codegen with/without debug info .
Wed, May 8, 9:41 AM · Restricted Project
aprantl accepted D59272: [DebugInfo] Select debug intrinsic line-numbers more carefully when promoting dbg.declare.
Wed, May 8, 9:39 AM · Restricted Project
aprantl added inline comments to D61181: [WIP][DebugInfo] Avoid SelectionDAG un-necessarily debug-referring to dead VRegs.
Wed, May 8, 9:30 AM · Restricted Project
aprantl added inline comments to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.
Wed, May 8, 9:27 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 7

aprantl accepted D61579: Propagate command interpreter errors from lldlbinit.

Seems plausible.

Tue, May 7, 3:12 PM · Restricted Project
aprantl committed rGe6e8db5e9bc5: Debug Info: Support address space attributes on rvalue references. (authored by aprantl).
Debug Info: Support address space attributes on rvalue references.
Tue, May 7, 10:42 AM
aprantl added a comment to D61625: Debug Info: Support address space attributes on rvalue references..

+1 to Bjorn's comment.
The DWARF spec says address class is also allowed on a "subroutine or subroutine type" do we allow generating code into nonzero address spaces?

Tue, May 7, 10:16 AM · Restricted Project, debug-info
aprantl committed rGccdefb24adaa: Guard __builtin_available() with __has_builtin to support older host compilers. (authored by aprantl).
Guard __builtin_available() with __has_builtin to support older host compilers.
Tue, May 7, 10:09 AM
aprantl added inline comments to D61606: Add support for importing general C++ modules into the LLDB expression evaluator.
Tue, May 7, 9:54 AM · Restricted Project, Restricted Project
aprantl added inline comments to D60866: [DWARF] Handle DW_OP_entry_value operand.
Tue, May 7, 9:47 AM · debug-info
aprantl added inline comments to D60961: [TargetOption] Add option for enabling param entry val tracking dbg info.
Tue, May 7, 9:44 AM · debug-info
aprantl accepted D60961: [TargetOption] Add option for enabling param entry val tracking dbg info.
Tue, May 7, 9:44 AM · debug-info
aprantl added a reviewer for D61565: Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS: jingham.
Tue, May 7, 9:23 AM · Restricted Project, Restricted Project
aprantl added a comment to D61565: Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS.

To clarify:

Tue, May 7, 9:23 AM · Restricted Project, Restricted Project
aprantl added a comment to D61565: Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS.

A slightly more elegant solution might be to inject a #line directive that changes to a different source file for the code that the user entered. I've been long wanting to make expr -g more palatable to end users by hiding the LLDB-injected code in a separate source file by default. If that turns out to be too much work, feel free to land this version.

Tue, May 7, 9:16 AM · Restricted Project, Restricted Project

Mon, May 6

aprantl updated subscribers of D61625: Debug Info: Support address space attributes on rvalue references..
Mon, May 6, 5:29 PM · Restricted Project, debug-info
aprantl created D61625: Debug Info: Support address space attributes on rvalue references..
Mon, May 6, 5:26 PM · Restricted Project, debug-info

Fri, May 3

aprantl committed rG80b047ef6614: Supply a default implementation of IsRuntimeSupportValue. (authored by aprantl).
Supply a default implementation of IsRuntimeSupportValue.
Fri, May 3, 1:28 PM
aprantl added a comment to D61451: Hide runtime support values such as clang's __vla_expr from frame variable.

I think there is a problem with this patch. I don't believe the TestVLA part would work on any non-darwin platform (it doesn't on linux: http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/923), and it works on darwin only accidentally.

The reason the fails on linux is that we don't have a "language runtime" plugin for the "C" language, so there is noone to ask if the variable is a runtime support value, and so we return false from ValueObject::IsRuntimeSupportValue. I believe the reason this works on darwin is because ValueObject::IsRuntimeSupportValue has a fallback (not sure why) which explicitly asks for the ObjC runtime if the desired language is not present. On linux, we don't have an ObjC runtime..

I can think of a couple of solutions here (adding a C language runtime, defaulting to return IsArtificial in ValueObject if no language runtime is present) but none of them seemed too obvious to commit straight-away, so I've disabled a part of that test for the time being (r359867). Nonetheless, could you please take a look at this problem?

Fri, May 3, 1:27 PM · Restricted Project, Restricted Project

Thu, May 2

aprantl committed rGa0ac5afb0a83: Fix tests on non-Darwin platforms. (authored by aprantl).
Fix tests on non-Darwin platforms.
Thu, May 2, 4:51 PM
aprantl committed rG1db0f0ca988f: Hide runtime support values such as clang's __vla_expr from frame variable (authored by aprantl).
Hide runtime support values such as clang's __vla_expr from frame variable
Thu, May 2, 4:07 PM
aprantl updated the diff for D61451: Hide runtime support values such as clang's __vla_expr from frame variable.

Thanks you! There was indeed a bug that prevented us from recognizing the correct runtime for the C++ this pointer.

Thu, May 2, 2:39 PM · Restricted Project, Restricted Project
aprantl updated the diff for D61451: Hide runtime support values such as clang's __vla_expr from frame variable.
Thu, May 2, 12:22 PM · Restricted Project, Restricted Project
aprantl added a comment to D61451: Hide runtime support values such as clang's __vla_expr from frame variable.

Could you add a comment (probably best in LanguageRuntime.h) saying what a RuntimeSupportValue is?

Thu, May 2, 12:22 PM · Restricted Project, Restricted Project
aprantl added inline comments to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Thu, May 2, 11:29 AM · Restricted Project
aprantl accepted D61394: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules.

True.

Thu, May 2, 11:23 AM · Restricted Project, Restricted Project
aprantl created D61451: Hide runtime support values such as clang's __vla_expr from frame variable.
Thu, May 2, 10:10 AM · Restricted Project, Restricted Project

Tue, Apr 30

aprantl accepted D61305: Add std::stack and std::queue support to CxxModuleHandler.
Tue, Apr 30, 9:11 AM · Restricted Project, Restricted Project, Restricted Project
aprantl accepted D61299: Rename Minion to ASTImporterDelegate.
Tue, Apr 30, 8:43 AM · Restricted Project, Restricted Project

Mon, Apr 29

aprantl added inline comments to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
Mon, Apr 29, 3:33 PM · Restricted Project
aprantl added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Mon, Apr 29, 1:34 PM · Restricted Project, Restricted Project, Restricted Project
aprantl added a reviewer for D61266: Skip TestClassTemplateParameterPack.py on all platforms: friss.
Mon, Apr 29, 12:40 PM
aprantl added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Mon, Apr 29, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
aprantl added a comment to D59687: [DebugInfo] Prologue inserter need to insert DW_OP_deref_size.

There's no hard and fast rules about this, but usually, tiny adjustments to fix issues found by bots can be landed without requiring a separate review.

Mon, Apr 29, 12:37 PM · Restricted Project, debug-info