Page MenuHomePhabricator

aprantl (Adrian Prantl)
User

Projects

User Details

User Since
Mar 2 2013, 8:12 AM (369 w, 3 d)

Recent Activity

Today

aprantl committed rG00efcd6fffa5: Add a Type::Payload typedef. (NFC) (authored by aprantl).
Add a Type::Payload typedef. (NFC)
Tue, Mar 31, 2:56 PM
aprantl committed rG7b06cb452308: Add an opque payload field to lldb::Type (NFC). (authored by aprantl).
Add an opque payload field to lldb::Type (NFC).
Tue, Mar 31, 11:29 AM
aprantl closed D75562: Add an opque payload field to lldb::Type (NFC)..
Tue, Mar 31, 11:28 AM · Restricted Project
aprantl updated subscribers of D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack.
Tue, Mar 31, 9:57 AM · debug-info, Restricted Project
aprantl added a comment to D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack.

CC'ing the DWARF cabal.

Tue, Mar 31, 9:57 AM · debug-info, Restricted Project
aprantl added a project to D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack: debug-info.
Tue, Mar 31, 9:57 AM · debug-info, Restricted Project
aprantl added a comment to D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack.

For the future, a clean solution would be extending the macros in Dwarf.def to list the stack effects in the definitions of the DW_OP_*, for example

Tue, Mar 31, 9:57 AM · debug-info, Restricted Project
aprantl added a comment to D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

@jhenderson @aprantl Thanks for the review.

Tue, Mar 31, 9:57 AM · Restricted Project, debug-info

Yesterday

aprantl accepted D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack.

This is obviously good! Do you think that a similar error handling bug might exist in other cases that depend top-of-stack?

Mon, Mar 30, 8:46 PM · debug-info, Restricted Project
aprantl added a comment to D76471: Remap the target SDK directory to the host SDK directory.

In case of Apple platforms, this won't make a difference in practice, since the support for that is implemented in PlatformDarwin (which all of these inherit from), but it sounds like this will be a problem for the "linux" sdk (assuming this is what I think it is), as there the selected platform will be PlatformLinux, which has no clue about these sdk thingies.

Mon, Mar 30, 2:11 PM
aprantl added a comment to D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

I'm not at all familiar with Mach-O, so how do fat archives get generated (i.e. with what tool?)? Is there an LLVM equivalent we can use here?

Mon, Mar 30, 9:46 AM · Restricted Project, debug-info
aprantl added inline comments to D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class..
Mon, Mar 30, 9:44 AM · Restricted Project

Fri, Mar 27

aprantl updated the diff for D76471: Remap the target SDK directory to the host SDK directory.

I've reworked this a little based on your feedback.

Fri, Mar 27, 5:39 PM
aprantl committed rG22d5bd0e3b32: Allow remapping Clang module include paths (authored by aprantl).
Allow remapping Clang module include paths
Fri, Mar 27, 2:54 PM
aprantl committed rG974fbd9b8145: Unbreak LLDB tests after 96023917e6f (authored by aprantl).
Unbreak LLDB tests after 96023917e6f
Fri, Mar 27, 2:53 PM
aprantl closed D76385: Allow remapping Clang module include paths.
Fri, Mar 27, 2:53 PM · Restricted Project
aprantl added a comment to D75562: Add an opque payload field to lldb::Type (NFC)..

Ping.

Fri, Mar 27, 2:52 PM · Restricted Project
aprantl updated the diff for D75562: Add an opque payload field to lldb::Type (NFC)..

Remove the obsolete setter in lldb::Type.

Fri, Mar 27, 2:52 PM · Restricted Project
aprantl updated the diff for D75562: Add an opque payload field to lldb::Type (NFC)..

Rebase and update based on https://reviews.llvm.org/D75488. It no longer takes a reference, but is a value type instead.

Fri, Mar 27, 2:52 PM · Restricted Project
aprantl added a comment to D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC).

Pinging @teemperor

Fri, Mar 27, 2:52 PM
aprantl added a comment to D76385: Allow remapping Clang module include paths.

LLDB didn't apply DW_AT_comp_dir to DW_AT_LLVM_include_path. I fixed that now.

Fri, Mar 27, 2:52 PM · Restricted Project
aprantl accepted D76168: CPlusPlusNameParser does not handles templated operator< properly.
Fri, Mar 27, 1:43 PM · Restricted Project
aprantl accepted D76930: [DebugInfo] Ensure dead store elimination can mark an operand value as undefined.

LGTM!

Fri, Mar 27, 8:45 AM
aprantl added a comment to D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

I think that @aprantl wanted a test for Mach-O and archives, back then. I've added a test for mach-o and archive, in one shot (by using pre-existing fat mach-o archive from dsymutil).

Fri, Mar 27, 8:45 AM · Restricted Project, debug-info
aprantl added inline comments to D76878: Implement new DW_OP_LLVM_* operations.
Fri, Mar 27, 8:45 AM · debug-info, Restricted Project

Thu, Mar 26

aprantl resigned from D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

I don't really know enough about this to give a meaningful review.

Thu, Mar 26, 7:02 PM · Restricted Project
aprantl added inline comments to D76808: Fix handling of bit-fields when there is a base class when parsing DWARF.
Thu, Mar 26, 7:02 PM · Restricted Project
aprantl added inline comments to D76808: Fix handling of bit-fields when there is a base class when parsing DWARF.
Thu, Mar 26, 7:02 PM · Restricted Project
aprantl added inline comments to D76168: CPlusPlusNameParser does not handles templated operator< properly.
Thu, Mar 26, 7:02 PM · Restricted Project
aprantl accepted D76854: [DebugInfo] Ensure that a demanded bits optimisation in InstCombine does not result in an incorrect debuginfo variable value.

LGTM but since we're on the same team (now, woot!) I'd like to give others a chance to have a look.

Thu, Mar 26, 10:18 AM · Restricted Project, debug-info
aprantl accepted D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie.
Thu, Mar 26, 9:45 AM · Restricted Project

Wed, Mar 25

aprantl accepted D76808: Fix handling of bit-fields when there is a base class when parsing DWARF.

Couple of minor suggestions inside.

Wed, Mar 25, 4:16 PM · Restricted Project
aprantl added a comment to D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC).

I added a comment to D75488. It's in getOrCreateModule().

Wed, Mar 25, 10:48 AM
aprantl added inline comments to D75488: Preserve the owning module information from DWARF in the synthesized AST.
Wed, Mar 25, 10:48 AM
aprantl added a comment to D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie.

I only have a bunch of superficial comments but this seems reasonable as far as I can tell.

Wed, Mar 25, 10:47 AM · Restricted Project

Tue, Mar 24

aprantl committed rGc025235e962e: Revert "Allow remapping Clang module include paths" (authored by aprantl).
Revert "Allow remapping Clang module include paths"
Tue, Mar 24, 6:04 PM
aprantl added a reverting change for rGdca920a904c2: Allow remapping Clang module include paths: rGc025235e962e: Revert "Allow remapping Clang module include paths".
Tue, Mar 24, 6:04 PM
aprantl reopened D76385: Allow remapping Clang module include paths.
Tue, Mar 24, 6:03 PM · Restricted Project
aprantl added a reviewer for D76385: Allow remapping Clang module include paths: teemperor.
Tue, Mar 24, 6:03 PM · Restricted Project
aprantl added a comment to D76385: Allow remapping Clang module include paths.

I'll update this with either a fix in clang or a patch to lldb once I figured out what happened.

Tue, Mar 24, 6:03 PM · Restricted Project
aprantl added a comment to D76385: Allow remapping Clang module include paths.

I had to revert this because it unexpectedly broke the "expr -- @import Module" test in LLDB.

Tue, Mar 24, 6:03 PM · Restricted Project
aprantl committed rGdca920a904c2: Allow remapping Clang module include paths (authored by aprantl).
Allow remapping Clang module include paths
Tue, Mar 24, 5:31 PM
aprantl closed D76385: Allow remapping Clang module include paths.
Tue, Mar 24, 5:30 PM · Restricted Project
aprantl committed rGed8ad6ec1562: Add an -object-path-prefix option to dsymutil (authored by aprantl).
Add an -object-path-prefix option to dsymutil
Tue, Mar 24, 5:30 PM
aprantl closed D76391: Add an -object-path-prefix option to dsymutil.
Tue, Mar 24, 5:30 PM · Restricted Project, debug-info
aprantl added a comment to D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer.

It's not clear to me why this is needed.

I mean, if lldb touches any of the files inside the dsym bundle, then they should be automatically recorded already, right? And if it doesn't then it does not need them...

The dSYM can contain other resources than just the Mach-O companion file, such as script for the OS plugins or opt remarks, which might not be used by the reproducers or even LLDB at all. Once you have the reproducer on your system, tools will find and use it because spotlight indexed it. Having only a partial dSYM is really undesirable as it can break LLDB and other tools in really unexpected ways.

Interesting. Could that be fixed by adding the funny .noindex suffix to the reproducer name (or some subdirectory of it)?

Tue, Mar 24, 12:21 PM · Restricted Project
aprantl added inline comments to D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer.
Tue, Mar 24, 9:40 AM · Restricted Project

Mon, Mar 23

aprantl added a comment to D76115: Add debug support for set types.

In your example you're encoding set as a derived type over an enum. That seems like a fine approach to me, but I think the interface should enforce this. Perhaps the Verifier should reject set derived typed from anything but an enum and the DIBuilder should only accept DICompositeTypes as the base type? Are there non-enum set types that you also want to encode?
Does this also need dwarfdump support, or does this work already?

Mon, Mar 23, 2:43 PM · debug-info, Restricted Project
aprantl added a comment to D76569: Convert CommandObjectCommands functions to return StringRefs.

run by hand ASAN-built LLDB for the code modified by this patch.

How do I do that? This is my first PR to llvm, so I am not aware of the tools. Please bear with me.

Mon, Mar 23, 9:48 AM · Restricted Project

Fri, Mar 20

aprantl added a comment to D76393: Allow remapping the sysroot with -fdebug-prefix-map..

Yeah, screwed up during rebasing and accidentally committed an extra file from a different review I reverted and relanded the patch now and the bots are running again. Sorry for the noise.

Fri, Mar 20, 5:22 PM · Restricted Project, debug-info
aprantl committed rG0a5fbf30937a: Temporarily Revert "Create basic SBEnvironment class" (authored by aprantl).
Temporarily Revert "Create basic SBEnvironment class"
Fri, Mar 20, 4:51 PM
aprantl added a reverting change for rG2dec82652e4b: Create basic SBEnvironment class: rG0a5fbf30937a: Temporarily Revert "Create basic SBEnvironment class".
Fri, Mar 20, 4:51 PM
aprantl committed rG0e916bf9f5e4: Driver: Improve performance of getSDKName() (authored by aprantl).
Driver: Improve performance of getSDKName()
Fri, Mar 20, 4:51 PM
aprantl closed D76097: improve performance of getSDKName().
Fri, Mar 20, 4:51 PM · Restricted Project
aprantl committed rGceae47143b1d: Allow remapping the sysroot with -fdebug-prefix-map. (authored by aprantl).
Allow remapping the sysroot with -fdebug-prefix-map.
Fri, Mar 20, 4:51 PM
aprantl committed rGbde15de3cabf: Revert "Allow remapping the sysroot with -fdebug-prefix-map." (authored by aprantl).
Revert "Allow remapping the sysroot with -fdebug-prefix-map."
Fri, Mar 20, 4:50 PM
aprantl added a reverting change for rG6725c4836a5b: Allow remapping the sysroot with -fdebug-prefix-map.: rGbde15de3cabf: Revert "Allow remapping the sysroot with -fdebug-prefix-map.".
Fri, Mar 20, 4:50 PM
aprantl added a comment to D76111: Create basic SBEnvironment class.

Since it's late on Friday afternoon I'm taking the liberty to revert the patch to get the bots running again. Feel free to re-land with a fix or ask for another round of review if you have more questions.

Fri, Mar 20, 4:50 PM · Restricted Project
aprantl added a comment to D76111: Create basic SBEnvironment class.

It looks like this test doesn't work on the bots: http://green.lab.llvm.org/green//view/LLDB/job/lldb-cmake/lastCompletedBuild//testReport/junit/lldb-api/python_api_sbenvironment/TestSBEnvironment_py/

Fri, Mar 20, 4:50 PM · Restricted Project
aprantl added a reviewer for D76111: Create basic SBEnvironment class: JDevlieghere.
Fri, Mar 20, 4:50 PM · Restricted Project
aprantl accepted D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

Looks like a great start! (From my side)

Fri, Mar 20, 4:50 PM · Restricted Project, debug-info
aprantl committed rG6725c4836a5b: Allow remapping the sysroot with -fdebug-prefix-map. (authored by aprantl).
Allow remapping the sysroot with -fdebug-prefix-map.
Fri, Mar 20, 4:18 PM
aprantl closed D76393: Allow remapping the sysroot with -fdebug-prefix-map..
Fri, Mar 20, 4:18 PM · Restricted Project, debug-info
aprantl committed rG43580a5c5afc: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map (authored by aprantl).
Allow remapping Clang module skeleton CU references with -fdebug-prefix-map
Fri, Mar 20, 3:45 PM
aprantl closed D76383: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map.
Fri, Mar 20, 3:45 PM · Restricted Project, debug-info
aprantl updated the diff for D76385: Allow remapping Clang module include paths.

Rebased and addressed review comments.

Fri, Mar 20, 3:45 PM · Restricted Project
aprantl committed rG079c6ddaf534: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs (authored by aprantl).
Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs
Fri, Mar 20, 2:40 PM
aprantl committed rG97f490d87b22: Don't set the isOptimized flag in module skeleton DICompileUnits. (authored by aprantl).
Don't set the isOptimized flag in module skeleton DICompileUnits.
Fri, Mar 20, 2:40 PM
aprantl closed D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs.
Fri, Mar 20, 2:40 PM · Restricted Project
aprantl committed rG18e8f27ad87e: Add missing module map entry (authored by aprantl).
Add missing module map entry
Fri, Mar 20, 11:23 AM
aprantl added inline comments to D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs.
Fri, Mar 20, 10:49 AM · Restricted Project
aprantl added a comment to D76471: Remap the target SDK directory to the host SDK directory.

Thanks, Pavel, these are all very valid concerns and in retrospect I should have at least slapped an RFC label on this before dumping into phabricator last night. The goal of this (and I should have mentioned that in the description) is to make the Xcode SDK something that behaves more like the compiler's resource directory, as in that it ships with LLDB rather than with the debugged program. This important primarily for importing Swift and Clang modules in the expression evaluator, and getting at the APINotes from the SDK in Swift.

Fri, Mar 20, 10:17 AM
aprantl added inline comments to D76168: CPlusPlusNameParser does not handles templated operator< properly.
Fri, Mar 20, 9:44 AM · Restricted Project
aprantl added inline comments to D76466: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation.
Fri, Mar 20, 9:11 AM · Restricted Project
aprantl added inline comments to D76466: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation.
Fri, Mar 20, 9:11 AM · Restricted Project
aprantl accepted D76465: [ADT] CoalescingBitVector: Avoid initial heap allocation, NFC.

Should we then call it SmallCoalescingBitVector? Probably not :-)

Fri, Mar 20, 9:10 AM · Restricted Project, debug-info
aprantl accepted D76467: [LiveDebugValues] Speed up collectIDsForRegs, NFC.
Fri, Mar 20, 9:10 AM · Restricted Project, debug-info

Thu, Mar 19

aprantl updated the diff for D76471: Remap the target SDK directory to the host SDK directory.
Thu, Mar 19, 7:12 PM
aprantl created D76471: Remap the target SDK directory to the host SDK directory.
Thu, Mar 19, 7:12 PM
aprantl added inline comments to D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP).
Thu, Mar 19, 2:49 PM · Restricted Project
aprantl updated the diff for D76393: Allow remapping the sysroot with -fdebug-prefix-map..

Don't try to be too clever with the strings.

Thu, Mar 19, 10:52 AM · Restricted Project, debug-info
aprantl updated the diff for D76385: Allow remapping Clang module include paths.

Don't try to be too clever.

Thu, Mar 19, 10:20 AM · Restricted Project

Wed, Mar 18

aprantl created D76393: Allow remapping the sysroot with -fdebug-prefix-map..
Wed, Mar 18, 4:19 PM · Restricted Project, debug-info
aprantl added parent revisions for D76391: Add an -object-path-prefix option to dsymutil: D76385: Allow remapping Clang module include paths, D76383: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map, D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs.
Wed, Mar 18, 3:46 PM · Restricted Project, debug-info
aprantl added a child revision for D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs: D76391: Add an -object-path-prefix option to dsymutil.
Wed, Mar 18, 3:46 PM · Restricted Project
aprantl added a child revision for D76383: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map: D76391: Add an -object-path-prefix option to dsymutil.
Wed, Mar 18, 3:46 PM · Restricted Project, debug-info
aprantl created D76391: Add an -object-path-prefix option to dsymutil.
Wed, Mar 18, 3:46 PM · Restricted Project, debug-info
aprantl added a child revision for D76385: Allow remapping Clang module include paths: D76391: Add an -object-path-prefix option to dsymutil.
Wed, Mar 18, 3:46 PM · Restricted Project
aprantl added a reviewer for D76385: Allow remapping Clang module include paths: shafik.
Wed, Mar 18, 3:13 PM · Restricted Project
aprantl added inline comments to D76385: Allow remapping Clang module include paths.
Wed, Mar 18, 3:13 PM · Restricted Project
aprantl created D76385: Allow remapping Clang module include paths.
Wed, Mar 18, 2:07 PM · Restricted Project
aprantl created D76383: Allow remapping Clang module skeleton CU references with -fdebug-prefix-map.
Wed, Mar 18, 1:35 PM · Restricted Project, debug-info
aprantl created D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs.
Wed, Mar 18, 11:57 AM · Restricted Project
aprantl committed rG1cc09dcefcce: Add missing module map entry. (authored by aprantl).
Add missing module map entry.
Wed, Mar 18, 10:53 AM
aprantl updated the diff for D75488: Preserve the owning module information from DWARF in the synthesized AST.

Rolled https://reviews.llvm.org/D75626 back into this patch, addressed more review feedback.

Wed, Mar 18, 9:47 AM
aprantl added a comment to D75626: Add support for owning module information to TypeSystemClang..

And then there's ClangModulesDeclVendor::ModuleID -- I have no idea what's the relationship of this to that..

Wed, Mar 18, 9:14 AM
aprantl abandoned D75626: Add support for owning module information to TypeSystemClang..
Wed, Mar 18, 9:14 AM
aprantl added a comment to D75626: Add support for owning module information to TypeSystemClang..

I'm merging this back into https://reviews.llvm.org/D75488 for easier reviewing.

Wed, Mar 18, 9:14 AM
aprantl added a comment to D74205: [llvm-dwarfdump] Add the --show-sections-sizes option.

I think this is starting to look good now. I found two more opportunities for improving the output... sorry about finding these piecemeal.

Wed, Mar 18, 9:14 AM · Restricted Project, debug-info
aprantl accepted D76276: [Object] Add the method for checking if a section is a debug section.

You could add a unit test for this, but it would effectively be a reimplementation of the function. I'm fine either way.

Wed, Mar 18, 9:14 AM · debug-info