Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (336 w, 2 d)

Recent Activity

Today

serge-sans-paille accepted D144189: [AIX][CodeGen] Storage Locations for Constant Pointers.

No comment, thanks for the patch!

Wed, Mar 22, 12:15 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D137707: Move "auto-init" instructions to the dominator of their users.

Extra round of tests on my side: current version leads to 550 instruction moved when compiling cpython with -ftrivial-auto-var-init=pattern. @nikic I think the patch is ready for you to look at it again :-)

Wed, Mar 22, 3:05 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D137707: Move "auto-init" instructions to the dominator of their users.

Update test case according to @nikic review.

Wed, Mar 22, 3:04 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D145982: [libc++] Implement std::gcd using the binary version.
Wed, Mar 22, 2:12 AM · Restricted Project
serge-sans-paille updated the diff for D145982: [libc++] Implement std::gcd using the binary version.

Fix variable naming.

Wed, Mar 22, 1:56 AM · Restricted Project

Mon, Mar 20

serge-sans-paille added inline comments to D137707: Move "auto-init" instructions to the dominator of their users.
Mon, Mar 20, 4:33 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D137707: Move "auto-init" instructions to the dominator of their users.

Take into account all @nikic comments.

Mon, Mar 20, 4:33 AM · Restricted Project, Restricted Project

Thu, Mar 16

serge-sans-paille added a comment to D145982: [libc++] Implement std::gcd using the binary version.

@cjdb : should be good now :-)

Thu, Mar 16, 1:21 PM · Restricted Project
serge-sans-paille updated the diff for D145982: [libc++] Implement std::gcd using the binary version.

Fix ADL

Thu, Mar 16, 1:20 PM · Restricted Project

Wed, Mar 15

serge-sans-paille updated the diff for D145982: [libc++] Implement std::gcd using the binary version.

Fix test

Wed, Mar 15, 1:54 PM · Restricted Project

Mon, Mar 13

serge-sans-paille updated the diff for D145982: [libc++] Implement std::gcd using the binary version.

Take review into account.

Mon, Mar 13, 11:40 PM · Restricted Project
serge-sans-paille added a comment to D145982: [libc++] Implement std::gcd using the binary version.

Still get a

Mon, Mar 13, 2:22 PM · Restricted Project
serge-sans-paille updated the diff for D145982: [libc++] Implement std::gcd using the binary version.

+ constexpr version
+ check for ub in bitwise shift.

Mon, Mar 13, 2:21 PM · Restricted Project
serge-sans-paille added a comment to D145982: [libc++] Implement std::gcd using the binary version.

First time contribution to libc++, I apologize in advance if the style / conformance is not correct.

Mon, Mar 13, 1:09 PM · Restricted Project
serge-sans-paille requested review of D145982: [libc++] Implement std::gcd using the binary version.
Mon, Mar 13, 1:09 PM · Restricted Project

Wed, Mar 8

serge-sans-paille added a comment to D137707: Move "auto-init" instructions to the dominator of their users.

@nikic : I've not addressed your inline comments yet, but I've improved the approach through alias analysis, this indeed looks better now, at least to me. What do you think?

Wed, Mar 8, 1:02 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D137707: Move "auto-init" instructions to the dominator of their users.

Use Alias Analysis to filter-out non clobbering memory accesses, as suggested by @nikic . Also added a test case (clobber.ll) to ensure this works as expected.

Wed, Mar 8, 1:00 AM · Restricted Project, Restricted Project

Thu, Mar 2

serge-sans-paille added a comment to D137707: Move "auto-init" instructions to the dominator of their users.

High level notes:

  • I'm not sure I fully understand the motivation for using MemorySSA here. Unless I'm missing something, It seems like when it comes to optimizing allocas, it would be sufficient to look at non-transparent users of the alloca (by which I mean, in first approximation, look through bitcast, gep, count everything else). The review mentions fences, but wouldn't these be covered as long as you consider pointer captures as "uses"?
Thu, Mar 2, 8:23 AM · Restricted Project, Restricted Project

Tue, Feb 28

serge-sans-paille added inline comments to D140075: [libclang] Expose using shadow types and declarations in libclang..
Tue, Feb 28, 10:33 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG5c943e368818: [libclang] Remove redundant return statements in CXType.cpp (authored by emilio).
[libclang] Remove redundant return statements in CXType.cpp
Tue, Feb 28, 10:30 PM · Restricted Project, Restricted Project
serge-sans-paille closed D140074: [libclang] Remove redundant return statements in CXType.cpp.
Tue, Feb 28, 10:29 PM · Restricted Project, Restricted Project
serge-sans-paille accepted D140074: [libclang] Remove redundant return statements in CXType.cpp.

The cleanup looks good to me, thanks! Out of curiosity, did just stumble on this, or did an automatic tool gave you an hint?

Tue, Feb 28, 12:56 PM · Restricted Project, Restricted Project
serge-sans-paille accepted D144945: [Doc][NFC] Add template type when use MachinePassRegistry..
Tue, Feb 28, 12:41 AM · Restricted Project, Restricted Project

Thu, Feb 23

serge-sans-paille accepted D144662: [MC][nfc] Don't use a value after it has been std::move()'d.

LGTM (I assume that most of the time, we're just copying pointers and it's fine either way).

Thu, Feb 23, 11:59 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D137707: Move "auto-init" instructions to the dominator of their users.

I'd like to move forward with this, and try to implement a more general approach that considers any instruction, and not only the instruction generated for auto init. But I need to unlock that review first :-)

Thu, Feb 23, 6:50 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D137707: Move "auto-init" instructions to the dominator of their users.

No need to check if getMemoryInst returns nullptr or not.

Thu, Feb 23, 6:44 AM · Restricted Project, Restricted Project

Feb 17 2023

serge-sans-paille added a comment to D143702: [NFC] Convert openmp/runtime/tools/summarizeStats.py to python 3 syntax.

@thieta ACK once you fix the issue spotted by@jlpeyton.

Feb 17 2023, 2:29 PM · Restricted Project, Restricted Project

Feb 14 2023

serge-sans-paille added inline comments to D137707: Move "auto-init" instructions to the dominator of their users.
Feb 14 2023, 2:30 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D137707: Move "auto-init" instructions to the dominator of their users.

Fix MemoryPhi handling

Feb 14 2023, 2:30 PM · Restricted Project, Restricted Project
serge-sans-paille abandoned D144020: [lld] Estimate think slope size instead of using a magic constant.

Superseded by https://reviews.llvm.org/D144029

Feb 14 2023, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille accepted D144029: [lld-macho] Account for alignment in thunk insertion algorithm.

Thanks for providing a much more satisfying approach than the one I proposed in https://reviews.llvm.org/D144020 !

Feb 14 2023, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille requested review of D144020: [lld] Estimate think slope size instead of using a magic constant.
Feb 14 2023, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2023

serge-sans-paille added a comment to D143702: [NFC] Convert openmp/runtime/tools/summarizeStats.py to python 3 syntax.

Some extra call to list are correct wrt py2/py3 compat but are actually not needed, let's not introduce them at all.

Feb 13 2023, 8:45 AM · Restricted Project, Restricted Project

Feb 9 2023

serge-sans-paille added a comment to D137707: Move "auto-init" instructions to the dominator of their users.

@efriedma : gentle ping :-) Any thoughts on this version, now based on MemorySSA?

Feb 9 2023, 7:20 AM · Restricted Project, Restricted Project

Feb 6 2023

serge-sans-paille committed rG0ffaffcaac97: Reapply 6fa2abf90886f18472c87bc9bffbcdf4f73c465e (authored by serge-sans-paille).
Reapply 6fa2abf90886f18472c87bc9bffbcdf4f73c465e
Feb 6 2023, 7:44 AM · Restricted Project, Restricted Project
serge-sans-paille closed D142606: Lazyly initialize uncommon toolchain detector.
Feb 6 2023, 7:44 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG77910ac37465: [clang] Reorder output of rocm-detect.hip test (authored by serge-sans-paille).
[clang] Reorder output of rocm-detect.hip test
Feb 6 2023, 7:04 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG6fa2abf90886: Lazyly initialize uncommon toolchain detector (authored by serge-sans-paille).
Lazyly initialize uncommon toolchain detector
Feb 6 2023, 3:06 AM · Restricted Project, Restricted Project
serge-sans-paille closed D142606: Lazyly initialize uncommon toolchain detector.
Feb 6 2023, 3:05 AM · Restricted Project, Restricted Project

Feb 5 2023

serge-sans-paille updated the diff for D142606: Lazyly initialize uncommon toolchain detector.

Address @tbader's comment

Feb 5 2023, 9:00 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D142606: Lazyly initialize uncommon toolchain detector.
Feb 5 2023, 2:05 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D142606: Lazyly initialize uncommon toolchain detector.

remove mutable qualifier

Feb 5 2023, 2:04 AM · Restricted Project, Restricted Project

Feb 2 2023

serge-sans-paille added inline comments to D137707: Move "auto-init" instructions to the dominator of their users.
Feb 2 2023, 4:28 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D137707: Move "auto-init" instructions to the dominator of their users.

@efriedma : any comment / opinion on this now that it's based on MemorySSA?

Feb 2 2023, 6:03 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D137707: Move "auto-init" instructions to the dominator of their users.

Take into account @nickdesaulniers review.

Feb 2 2023, 6:00 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap.

Gentle ping :-)

Feb 2 2023, 2:46 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added inline comments to D142606: Lazyly initialize uncommon toolchain detector.
Feb 2 2023, 2:46 AM · Restricted Project, Restricted Project

Feb 1 2023

serge-sans-paille added a comment to D142862: [Support] change StringMap hash function from djbHash to xxHash.

looks good to me!

Feb 1 2023, 11:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 30 2023

serge-sans-paille added a comment to D142862: [Support] change StringMap hash function from djbHash to xxHash.

Do you intend to (optionnaly) provide XXH3 as described in https://github.com/Cyan4973/xxHash ?

Jan 30 2023, 12:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D142862: [Support] change StringMap hash function from djbHash to xxHash.

Can you take a shot against https://llvm-compile-time-tracker.com/ so that we get an hint of the practical speedup?

Jan 30 2023, 12:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 26 2023

serge-sans-paille added a comment to D142606: Lazyly initialize uncommon toolchain detector.

Does this mean that clang will no longer search for the ROCM and CUDA library paths for every C compile?

Jan 26 2023, 7:19 AM · Restricted Project, Restricted Project
serge-sans-paille added reviewers for D142606: Lazyly initialize uncommon toolchain detector: aaron.ballman, tstellar, mehdi_amini.
Jan 26 2023, 12:48 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D142606: Lazyly initialize uncommon toolchain detector.
Jan 26 2023, 12:48 AM · Restricted Project, Restricted Project

Jan 25 2023

serge-sans-paille committed rG3ab51fff3c2a: [llvm] Replace array allocation pattern by SmallVector in… (authored by serge-sans-paille).
[llvm] Replace array allocation pattern by SmallVector in…
Jan 25 2023, 11:00 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG8f79b0fe0047: [llvm] Do not zero out write_unsigned_impl internal buffer (authored by serge-sans-paille).
[llvm] Do not zero out write_unsigned_impl internal buffer
Jan 25 2023, 11:00 PM · Restricted Project, Restricted Project
serge-sans-paille closed D142574: [llvm] Replace array allocation pattern by SmallVector in ComputeMappedEditDistance.
Jan 25 2023, 10:59 PM · Restricted Project, Restricted Project
serge-sans-paille closed D142464: [llvm] Do not zero out write_unsigned_impl internal buffer.
Jan 25 2023, 10:59 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D142464: [llvm] Do not zero out write_unsigned_impl internal buffer.

How did you find this? Just random audit of the code?

Jan 25 2023, 10:34 PM · Restricted Project, Restricted Project
serge-sans-paille added a reviewer for D142464: [llvm] Do not zero out write_unsigned_impl internal buffer: mehdi_amini.
Jan 25 2023, 1:37 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D142574: [llvm] Replace array allocation pattern by SmallVector in ComputeMappedEditDistance.

I did a quick check and it was indeed tuned

Jan 25 2023, 1:36 PM · Restricted Project, Restricted Project
serge-sans-paille requested review of D142574: [llvm] Replace array allocation pattern by SmallVector in ComputeMappedEditDistance.
Jan 25 2023, 11:48 AM · Restricted Project, Restricted Project

Jan 24 2023

serge-sans-paille updated the diff for D137707: Move "auto-init" instructions to the dominator of their users.

Address review + rebase patch

Jan 24 2023, 12:46 PM · Restricted Project, Restricted Project
serge-sans-paille added a reviewer for D142464: [llvm] Do not zero out write_unsigned_impl internal buffer: tstellar.
Jan 24 2023, 6:16 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D142464: [llvm] Do not zero out write_unsigned_impl internal buffer.
Jan 24 2023, 6:08 AM · Restricted Project, Restricted Project

Jan 23 2023

serge-sans-paille committed rG35912ad39d8a: [clang] Fix unused variable warning in isBuiltinSupported (authored by serge-sans-paille).
[clang] Fix unused variable warning in isBuiltinSupported
Jan 23 2023, 2:17 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D142024: [clang] Optimize clang::Builtin::Info density.

This got fixed in d1f313e73a1b33d662dbab54be76720b9c875645.

Jan 23 2023, 2:08 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap.

Do not enfore StringLiteral parameter. This is too invasive on the code base.

Jan 23 2023, 8:42 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille committed rG5a7f47cc021b: [clang] Optimize clang::Builtin::Info density (authored by serge-sans-paille).
[clang] Optimize clang::Builtin::Info density
Jan 23 2023, 5:28 AM · Restricted Project, Restricted Project
serge-sans-paille closed D142024: [clang] Optimize clang::Builtin::Info density.
Jan 23 2023, 5:28 AM · Restricted Project, Restricted Project

Jan 21 2023

serge-sans-paille added a comment to D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap.

@nikic : I thought I fixed that with e8a163dc03e6913360beb305620104ba129c081c ... is it included in your build?

Oh yeah, I missed that fix. Sorry for the noise.

Jan 21 2023, 1:54 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D142026: Optimize OptTable::findNearest implementation and usage.

Plausibly caused by this change -- I'm thinking that MaximumDistance is initialized to UINT_MAX - 1, but then we cast that to a signed integer and compare that, so it wraps to a large negative number.

Jan 21 2023, 1:53 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap.

@nikic : I thought I fixed that with e8a163dc03e6913360beb305620104ba129c081c ... is it included in your build?

Jan 21 2023, 12:10 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2023

serge-sans-paille committed rGcf1756146d38: [NFC] Reformat isBuiltinSupported with early exit (authored by serge-sans-paille).
[NFC] Reformat isBuiltinSupported with early exit
Jan 20 2023, 8:20 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap.

Fix build + make StringLiteral initialization constexpr.

Jan 20 2023, 6:14 AM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2023

serge-sans-paille requested review of D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap.
Jan 19 2023, 10:52 PM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille committed rGe8a163dc03e6: [llvm] Cleanup edit_distance short circuiting (authored by serge-sans-paille).
[llvm] Cleanup edit_distance short circuiting
Jan 19 2023, 2:21 PM · Restricted Project, Restricted Project
serge-sans-paille added a reviewer for D142024: [clang] Optimize clang::Builtin::Info density: nikic.
Jan 19 2023, 8:51 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG6ad1b4095172: Optimize OptTable::findNearest implementation and usage (authored by serge-sans-paille).
Optimize OptTable::findNearest implementation and usage
Jan 19 2023, 5:17 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille closed D142026: Optimize OptTable::findNearest implementation and usage.
Jan 19 2023, 5:16 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille updated the diff for D142026: Optimize OptTable::findNearest implementation and usage.

Thanks @nikic for the review. Remarks taken into account.

Jan 19 2023, 1:30 AM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2023

serge-sans-paille requested review of D142026: Optimize OptTable::findNearest implementation and usage.
Jan 18 2023, 8:14 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added reviewers for D142024: [clang] Optimize clang::Builtin::Info density: aaron.ballman, fhahn.
Jan 18 2023, 7:56 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D142024: [clang] Optimize clang::Builtin::Info density.
Jan 18 2023, 7:54 AM · Restricted Project, Restricted Project

Jan 16 2023

serge-sans-paille committed rGc512eda38ebe: [lld][COFF] Provide unwinding information for Chunk injected by /delayloaded (authored by serge-sans-paille).
[lld][COFF] Provide unwinding information for Chunk injected by /delayloaded
Jan 16 2023, 9:40 AM · Restricted Project
serge-sans-paille closed D141691: [lld][COFF] Provide unwinding information for Chunk injected by /delayloaded.
Jan 16 2023, 9:40 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D141691: [lld][COFF] Provide unwinding information for Chunk injected by /delayloaded.

Fix and document alignment requirements

Jan 16 2023, 2:22 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D141691: [lld][COFF] Provide unwinding information for Chunk injected by /delayloaded.

remove FIXME

Jan 16 2023, 1:24 AM · Restricted Project, Restricted Project
serge-sans-paille added a reviewer for D141691: [lld][COFF] Provide unwinding information for Chunk injected by /delayloaded: mstorsjo.
Jan 16 2023, 1:11 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D141691: [lld][COFF] Provide unwinding information for Chunk injected by /delayloaded.

Add alignment requirements

Jan 16 2023, 1:10 AM · Restricted Project, Restricted Project

Jan 15 2023

serge-sans-paille accepted D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides.
Jan 15 2023, 11:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides.

LGTM

Jan 15 2023, 11:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 13 2023

serge-sans-paille added a reviewer for D141691: [lld][COFF] Provide unwinding information for Chunk injected by /delayloaded: ruiu.
Jan 13 2023, 7:06 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D141691: [lld][COFF] Provide unwinding information for Chunk injected by /delayloaded.
Jan 13 2023, 7:05 AM · Restricted Project, Restricted Project

Jan 12 2023

serge-sans-paille committed rG07bb29d8ffc3: [OptTable] Precompute OptTable prefixes union table through tablegen (authored by serge-sans-paille).
[OptTable] Precompute OptTable prefixes union table through tablegen
Jan 12 2023, 3:08 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille committed rGbbe463d6ba26: [OptTable] Make ValuesCode initialisation of Options constexpr (authored by serge-sans-paille).
[OptTable] Make ValuesCode initialisation of Options constexpr
Jan 12 2023, 3:08 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille closed D140800: [OptTable] Precompute OptTable prefixes union table through tablegen.
Jan 12 2023, 3:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
serge-sans-paille closed D140699: [OptTable] Make ValuesCode initialisation of Options constexpr.
Jan 12 2023, 3:08 AM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

serge-sans-paille updated the diff for D140699: [OptTable] Make ValuesCode initialisation of Options constexpr.

nits + rebased on main

Jan 11 2023, 12:49 PM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D140800: [OptTable] Precompute OptTable prefixes union table through tablegen.

Just to check, this isn't going to cause some warning spew about all those OptTable implementations being non-final?

Jan 11 2023, 12:48 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
serge-sans-paille updated the diff for D140800: [OptTable] Precompute OptTable prefixes union table through tablegen.

Nits + rebase on main branch

Jan 11 2023, 12:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project