Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (135 w, 6 d)

Recent Activity

Fri, May 17

serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
Fri, May 17, 2:14 PM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
Fri, May 17, 10:28 AM · Restricted Project
serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

Therefore, I recommend removing the SubCommand parameter from this API and always using cl::TopLevelSubCommand.

Fri, May 17, 9:55 AM · Restricted Project
serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda / @beanz : I've been thinking about this, and I'm now convinced that this review is probably not the good approach. What we need is a good way to track which options are actually important for a given binary, correctly set the categories of each option and *reallyhide* the others. So I'll pause this review and start working on sanitizing the output of several tools until I get a better understanding of the actual API needs.

Fri, May 17, 8:40 AM · Restricted Project

Thu, May 16

serge-sans-paille committed rGab155469835a: Fix isInSystemMacro in presence of macro and pasted token (authored by serge-sans-paille).
Fix isInSystemMacro in presence of macro and pasted token
Thu, May 16, 5:40 AM

Wed, May 15

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@beanz

I expect that we will want to use cl::HideUnrelatedOptions in a lot more places to clean up other tool help messages.

That's indeed the plan.

Wed, May 15, 12:46 PM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.

@lebedev.ri doc updated.

Wed, May 15, 6:26 AM · Restricted Project
serge-sans-paille updated the diff for D59413: Fix isInSystemMacro in presence of macro and pasted token.

Updated with clang-formated diff

Wed, May 15, 5:17 AM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda I've updated the patch taking your advices into account. I took a step ahead and applied the non-conservative signature change for cl::HideUnrelatedOptions

Wed, May 15, 5:04 AM · Restricted Project

Tue, May 14

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda this looks better that way, for sure.

Tue, May 14, 6:45 AM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
Tue, May 14, 6:44 AM · Restricted Project

Mon, May 13

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

It was added in D7100, and I think the rational was to hide implementation details.

Mon, May 13, 10:13 PM · Restricted Project
serge-sans-paille created D61870: Make cl::HideUnrelatedOptionsless error-prone.
Mon, May 13, 1:23 PM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur I'll be happy to read your feedback on windows compilation!

Mon, May 13, 11:34 AM · Restricted Project
serge-sans-paille committed rG2cabb4dc5baa: Simplify llvm-cat help (authored by serge-sans-paille).
Simplify llvm-cat help
Mon, May 13, 4:30 AM
serge-sans-paille closed D61740: Simplify llvm-cat -help.
Mon, May 13, 4:30 AM · Restricted Project
serge-sans-paille added a comment to D61740: Simplify llvm-cat -help.

For reference, and following the idea that we should not filter out relevant options, her eis the original output:

Mon, May 13, 3:47 AM · Restricted Project

Fri, May 10

serge-sans-paille updated the diff for D61740: Simplify llvm-cat -help.

Include full context

Fri, May 10, 3:17 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

I will have to try out the patch, e.g. on Windows. Please ping me if it takes to long.

Thanks @Meinersbur

Fri, May 10, 1:21 AM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Fri, May 10, 1:11 AM · Restricted Project

Thu, May 9

serge-sans-paille added a comment to D59948: Support providing pass schedule to new passmanager as a YAML input.

Up!

Thu, May 9, 10:39 AM · Restricted Project
serge-sans-paille added a comment to D60603: Make llvm-as --help great again.

Up!

Thu, May 9, 10:37 AM · Restricted Project
serge-sans-paille created D61740: Simplify llvm-cat -help.
Thu, May 9, 9:09 AM · Restricted Project
serge-sans-paille created D61738: Provide basic LTO extension points.
Thu, May 9, 8:51 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@mehdi_amini I've updated the .tgz sample so that one could see that the expected CMakelists.txt for third-party compiler extensions is now super-simple.

Thu, May 9, 1:07 AM · Restricted Project

Wed, May 8

serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Wed, May 8, 12:17 AM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Update diff to make it less intrusive: using a declarative approach, each compiler extension registers itself as an extension, and thanks to cmake-generator-expression, it's possible to delay the evaluation of linked extensions until all extensions registered.

Wed, May 8, 12:13 AM · Restricted Project

Tue, May 7

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur, I've tested and reviewed this patch, I'm curious about Polly's team opinion on the changes in current state?
@mehdi_amini, Did I correctly capture your remarks on llvm-projects?

Tue, May 7, 9:34 AM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Tested withe the following dummy project: https://sergesanspaille.fedorapeople.org/bye.tgz

Tue, May 7, 6:52 AM · Restricted Project

Mon, May 6

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Mon, May 6, 5:40 AM · Restricted Project
serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Mon, May 6, 4:42 AM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Update diff to make it compatible with llvm projects.

Mon, May 6, 4:42 AM · Restricted Project

Fri, May 3

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Fri, May 3, 8:15 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Do you intent to use this interface for a specific external project, or is it to avoid direct references to Polly?

Fri, May 3, 1:40 AM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Patch update:

  • make it possible for extension to register extra tool dependency
  • accept the all target to automatically detect official extensions (namely Polly as of now)
  • ship clang patch
Fri, May 3, 1:25 AM · Restricted Project

Thu, May 2

serge-sans-paille added a reviewer for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool: Meinersbur.
Thu, May 2, 9:18 AM · Restricted Project
serge-sans-paille created D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Thu, May 2, 9:11 AM · Restricted Project

Tue, Apr 30

serge-sans-paille added a comment to D59413: Fix isInSystemMacro in presence of macro and pasted token.

@rsmith : up :-)

Tue, Apr 30, 1:55 AM · Restricted Project

Apr 12 2019

serge-sans-paille added a comment to D60603: Make llvm-as --help great again.

@jhenderson I've added a few potential reviewers based on the file history.

Apr 12 2019, 3:26 AM · Restricted Project
serge-sans-paille added reviewers for D60603: Make llvm-as --help great again: tejohnson, ddunbar.
Apr 12 2019, 3:26 AM · Restricted Project
serge-sans-paille updated the diff for D60603: Make llvm-as --help great again.

Including test case

Apr 12 2019, 2:50 AM · Restricted Project
serge-sans-paille created D60603: Make llvm-as --help great again.
Apr 12 2019, 2:46 AM · Restricted Project
serge-sans-paille added a comment to D60603: Make llvm-as --help great again.

Without category filtered:

Apr 12 2019, 2:46 AM · Restricted Project

Apr 11 2019

serge-sans-paille committed rG3742bb89f83f: Make llvm-nm -help great again (authored by serge-sans-paille).
Make llvm-nm -help great again
Apr 11 2019, 8:22 AM
serge-sans-paille updated the diff for D60411: Filter out irrelevant llvm-nm option.

Fun fact: when --help is active, no error is reported for invalid options :-) Fixed.

Apr 11 2019, 6:14 AM · Restricted Project
serge-sans-paille added a comment to D60411: Filter out irrelevant llvm-nm option.

Splitting on a character would make a lot of sense. Most tools use '=' or similar for multi-string arguments.

Apr 11 2019, 5:14 AM · Restricted Project
serge-sans-paille updated the diff for D60411: Filter out irrelevant llvm-nm option.

Update test

Apr 11 2019, 5:12 AM · Restricted Project

Apr 10 2019

serge-sans-paille updated the diff for D60411: Filter out irrelevant llvm-nm option.

alias don"t need to be marked as part of a category, this makes the diff shorter. Same for positional argument. New output:

Apr 10 2019, 1:19 PM · Restricted Project
serge-sans-paille added inline comments to D60411: Filter out irrelevant llvm-nm option.
Apr 10 2019, 4:59 AM · Restricted Project
serge-sans-paille added a comment to D60411: Filter out irrelevant llvm-nm option.
% ./bin/llvm-nm --help
OVERVIEW: llvm symbol table dumper
Apr 10 2019, 4:59 AM · Restricted Project

Apr 8 2019

serge-sans-paille created D60411: Filter out irrelevant llvm-nm option.
Apr 8 2019, 8:52 AM · Restricted Project

Apr 5 2019

serge-sans-paille added a comment to D59948: Support providing pass schedule to new passmanager as a YAML input.

@chandlerc up!

Apr 5 2019, 1:55 AM · Restricted Project

Apr 3 2019

serge-sans-paille abandoned D59810: Always support masm syntax when intel dialect is active.

GNU as compatibility totally makes sense, dropping the patch, and thanks for the detailed answer!

Apr 3 2019, 12:19 AM · Restricted Project

Apr 2 2019

serge-sans-paille abandoned D60127: Declare library dependency introduced by https://reviews.llvm.org/D59634.

Obsoleted by r357471

Apr 2 2019, 7:21 AM · Restricted Project
serge-sans-paille retitled D60127: Declare library dependency introduced by https://reviews.llvm.org/D59634 from Declare library dependency introduced by https://reviews.llvm.org/D59482 to Declare library dependency introduced by https://reviews.llvm.org/D59634.
Apr 2 2019, 7:21 AM · Restricted Project
serge-sans-paille created D60127: Declare library dependency introduced by https://reviews.llvm.org/D59634.
Apr 2 2019, 6:29 AM · Restricted Project
serge-sans-paille added a comment to D59413: Fix isInSystemMacro in presence of macro and pasted token.

@rsmith : up :-)

Apr 2 2019, 2:38 AM · Restricted Project
serge-sans-paille added a comment to D59810: Always support masm syntax when intel dialect is active.

@rnk, @mcrosier : up :-)

Apr 2 2019, 2:38 AM · Restricted Project

Mar 28 2019

serge-sans-paille created D59948: Support providing pass schedule to new passmanager as a YAML input.
Mar 28 2019, 10:41 AM · Restricted Project
serge-sans-paille abandoned D59581: Python 2/3 compat: urllib.

Yep, that's clearly a duplicate that was hanging around in my patch list, sorry for the noise.

Mar 28 2019, 2:05 AM · Restricted Project, Restricted Project

Mar 26 2019

serge-sans-paille added a reviewer for D59581: Python 2/3 compat: urllib: psmith.
Mar 26 2019, 1:31 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG1a12dd70c00a: python 2/3 compat: commands vs subprocess (authored by serge-sans-paille).
python 2/3 compat: commands vs subprocess
Mar 26 2019, 7:45 AM
serge-sans-paille retitled D59810: Always support masm syntax when intel dialect is active from Always support masm syntax when inte dialect is active to Always support masm syntax when intel dialect is active.
Mar 26 2019, 2:31 AM · Restricted Project
serge-sans-paille created D59810: Always support masm syntax when intel dialect is active.
Mar 26 2019, 2:31 AM · Restricted Project

Mar 25 2019

serge-sans-paille added a comment to D59413: Fix isInSystemMacro in presence of macro and pasted token.

@rsmith up!

Mar 25 2019, 9:07 AM · Restricted Project
serge-sans-paille added a comment to D59581: Python 2/3 compat: urllib.

@michaelplatings up!

Mar 25 2019, 9:07 AM · Restricted Project, Restricted Project
serge-sans-paille added reviewers for D59584: python 2/3 compat: commands vs subprocess: labath, davide.
Mar 25 2019, 9:06 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG3a22c3cc2b06: Python 2/3 compat: StringIO (authored by serge-sans-paille).
Python 2/3 compat: StringIO
Mar 25 2019, 8:23 AM
serge-sans-paille committed rG6ee3804613b7: Python 2/3 compat: tkinter (authored by serge-sans-paille).
Python 2/3 compat: tkinter
Mar 25 2019, 8:22 AM
serge-sans-paille committed rG0bc1447845a2: Python 2/3 compat: str vs basestring (authored by serge-sans-paille).
Python 2/3 compat: str vs basestring
Mar 25 2019, 8:20 AM
serge-sans-paille closed D59591: Python 2/3 compat: unichr vs chr.

Closed by https://reviews.llvm.org/rL356904

Mar 25 2019, 8:18 AM · Restricted Project
serge-sans-paille committed rGdcb128f73b8d: Revert 356905 (authored by serge-sans-paille).
Revert 356905
Mar 25 2019, 8:18 AM
serge-sans-paille committed rGb833c6af5911: Python 2/3 compat: queue vs Queue (authored by serge-sans-paille).
Python 2/3 compat: queue vs Queue
Mar 25 2019, 8:14 AM
serge-sans-paille committed rG2dea7c4113dd: Python 2/3 compat: queue vs Queue (authored by serge-sans-paille).
Python 2/3 compat: queue vs Queue
Mar 25 2019, 8:13 AM
serge-sans-paille committed rGcdfcbbd34866: Python 2/3 compat: unichr vs chr (authored by serge-sans-paille).
Python 2/3 compat: unichr vs chr
Mar 25 2019, 8:12 AM
serge-sans-paille added inline comments to D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Mar 25 2019, 5:13 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added inline comments to D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py.
Mar 25 2019, 5:08 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2019

serge-sans-paille added a reviewer for D59582: Python 2/3 compat: StringIO: labath.
Mar 23 2019, 3:39 AM · Restricted Project, Restricted Project
serge-sans-paille added a reviewer for D59581: Python 2/3 compat: urllib: labath.
Mar 23 2019, 3:39 AM · Restricted Project, Restricted Project
serge-sans-paille added a reviewer for D59589: Python 2/3 compat: str vs basestring: labath.
Mar 23 2019, 3:39 AM · Restricted Project
serge-sans-paille added a reviewer for D59590: Python 2/3 compat: queue vs Queue: labath.
Mar 23 2019, 3:39 AM · Restricted Project, Restricted Project
serge-sans-paille added a reviewer for D59586: Python 2/3 compat: tkinter: labath.
Mar 23 2019, 3:39 AM · Restricted Project
serge-sans-paille added a reviewer for D59591: Python 2/3 compat: unichr vs chr: labath.
Mar 23 2019, 3:39 AM · Restricted Project

Mar 21 2019

serge-sans-paille committed rG525cd59f5a12: Python 2/3 compatibility: from __future__ import print_function (authored by serge-sans-paille).
Python 2/3 compatibility: from __future__ import print_function
Mar 21 2019, 11:29 AM
serge-sans-paille added a comment to D59580: Use compatible print statements for Python2/3.

@davide : is that ok if I add you to a few other python compat related reviews?

Mar 21 2019, 11:27 AM · Restricted Project
serge-sans-paille added a comment to D59580: Use compatible print statements for Python2/3.

validates fine on my side with py3

Mar 21 2019, 10:53 AM · Restricted Project
serge-sans-paille committed rGce54fa1855be: Workaround items/iteritems difference between Python2 and Python3 (authored by serge-sans-paille).
Workaround items/iteritems difference between Python2 and Python3
Mar 21 2019, 7:51 AM
serge-sans-paille added a comment to D59580: Use compatible print statements for Python2/3.

I didn't run the check-lldb target though, I'm doing that right now.

Mar 21 2019, 7:51 AM · Restricted Project
serge-sans-paille added a comment to D59580: Use compatible print statements for Python2/3.

@davide I first applied 2to3 systematically, then manually edited the diff so that it remains backward compatible with python2.

Mar 21 2019, 7:50 AM · Restricted Project
serge-sans-paille committed rG468219b387af: Workaround Python's map difference between Python2/3 (authored by serge-sans-paille).
Workaround Python's map difference between Python2/3
Mar 21 2019, 7:45 AM
serge-sans-paille committed rGbfb779188ff0: Portable int/long conversion across Python 2 / Python 3 (authored by serge-sans-paille).
Portable int/long conversion across Python 2 / Python 3
Mar 21 2019, 7:41 AM
serge-sans-paille committed rG3577da766719: Portable exception value access across Python 2 / Python 3 (authored by serge-sans-paille).
Portable exception value access across Python 2 / Python 3
Mar 21 2019, 7:39 AM
serge-sans-paille committed rG32cffcf1aba9: Use list comprehension instead of map/filter to prepare Python2/3 compat (authored by serge-sans-paille).
Use list comprehension instead of map/filter to prepare Python2/3 compat
Mar 21 2019, 12:19 AM

Mar 20 2019

serge-sans-paille committed rGa1aa7a4054e7: Python 2/3 compatibility (authored by serge-sans-paille).
Python 2/3 compatibility
Mar 20 2019, 12:43 AM
serge-sans-paille added a comment to D59538: Python 2/3 compatibility.

Thanks for the review! I've started to work on lldb python code base, and with that we should have all Python files for llvm, clang, lld and lldb compatible with Python2 and Python3.

Mar 20 2019, 12:42 AM · Restricted Project
serge-sans-paille created D59591: Python 2/3 compat: unichr vs chr.
Mar 20 2019, 12:36 AM · Restricted Project
serge-sans-paille created D59590: Python 2/3 compat: queue vs Queue.
Mar 20 2019, 12:36 AM · Restricted Project, Restricted Project
serge-sans-paille created D59589: Python 2/3 compat: str vs basestring.
Mar 20 2019, 12:36 AM · Restricted Project
serge-sans-paille created D59588: Python 2/3 compat: iteritems vs items.
Mar 20 2019, 12:31 AM · Restricted Project
serge-sans-paille created D59587: Use explicit loop instead of map for Python 2/3 compat.
Mar 20 2019, 12:28 AM · Restricted Project, Restricted Project