Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (170 w, 4 d)

Recent Activity

Yesterday

serge-sans-paille updated the diff for D71566: New checks for fortified sprintf.

Update size computation + test case involving null byte inside the format string.

Fri, Jan 17, 1:07 PM · Restricted Project
serge-sans-paille updated the diff for D68720: Support -fstack-clash-protection for x86.

Take into account some of the reviews

Fri, Jan 17, 5:51 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D68720: Support -fstack-clash-protection for x86.
Fri, Jan 17, 5:51 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGcd4c65f91d5a: Add __warn_memset_zero_len builtin as a workaround for glibc issue (authored by serge-sans-paille).
Add __warn_memset_zero_len builtin as a workaround for glibc issue
Fri, Jan 17, 1:05 AM
serge-sans-paille committed rGd293417931d3: Add __warn_memset_zero_len builtin as a workaround for glibc issue (authored by serge-sans-paille).
Add __warn_memset_zero_len builtin as a workaround for glibc issue
Fri, Jan 17, 1:00 AM
serge-sans-paille closed D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue.
Fri, Jan 17, 1:00 AM · Restricted Project
serge-sans-paille committed rGd437fba8ef62: Reapply Allow system header to provide their own implementation of some builtin (authored by serge-sans-paille).
Reapply Allow system header to provide their own implementation of some builtin
Fri, Jan 17, 1:00 AM
serge-sans-paille added a reverting change for rG3d210ed3d188: Revert "Allow system header to provide their own implementation of some builtin": rGd437fba8ef62: Reapply Allow system header to provide their own implementation of some builtin.
Fri, Jan 17, 1:00 AM

Thu, Jan 16

serge-sans-paille updated the diff for D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue.

Add test case

Thu, Jan 16, 2:06 PM · Restricted Project
serge-sans-paille added a comment to D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue.

This is very hacky,

Thu, Jan 16, 2:06 PM · Restricted Project
serge-sans-paille created D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue.
Thu, Jan 16, 1:07 PM · Restricted Project
serge-sans-paille added a comment to D71082: Allow system header to provide their own implementation of some builtin.

The simplest one I can think of is to make __warn_memset_zero_len a recognized builtin that generates no code.

+1, simple and easy.

Thu, Jan 16, 1:07 PM · Restricted Project
serge-sans-paille added a comment to D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue.

@akhuang can you confirm this fixes your issue? I've tested locally and it works fine on my side.

Thu, Jan 16, 1:07 PM · Restricted Project
serge-sans-paille added a comment to D71082: Allow system header to provide their own implementation of some builtin.
In D71082#1824563, @rnk wrote:

The simplest one I can think of is to make __warn_memset_zero_len a recognized builtin that generates no code.

Thu, Jan 16, 10:51 AM · Restricted Project
serge-sans-paille added a comment to D71566: New checks for fortified sprintf.

@erik.pilkington up?

Thu, Jan 16, 3:13 AM · Restricted Project
serge-sans-paille added a comment to D72829: Implement -fsemantic-interposition.

@MaskRay no example yet, I'd like your opinion on the approach first. It has the advantage of being non intrusive to the code base...

Thu, Jan 16, 3:13 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D68720: Support -fstack-clash-protection for x86.

@craig.topper up?

Thu, Jan 16, 3:13 AM · Restricted Project, Restricted Project
serge-sans-paille created D72829: Implement -fsemantic-interposition.
Thu, Jan 16, 3:13 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D71082: Allow system header to provide their own implementation of some builtin.

@akhuang : I've reported https://sourceware.org/bugzilla/show_bug.cgi?id=25399 to glibc. According to me this is more of a glibc problem than this patch, and as we have a workaround with -fgnuc-version=5.0 I think we could apply the patch back.

Thu, Jan 16, 2:47 AM · Restricted Project
serge-sans-paille added a comment to D71082: Allow system header to provide their own implementation of some builtin.

This caused a linker error in chromium:

ld.lld: error: undefined symbol: __warn_memset_zero_len

Apparently now that the glibc memset is being used, __warn_memset_zero_len gets called from libc++ code (https://github.com/llvm/llvm-project/blob/b72a8c65e4e34779b6bc9e466203f553f5294486/libcxx/include/__bit_reference#L371).

Thu, Jan 16, 1:40 AM · Restricted Project

Tue, Jan 14

serge-sans-paille added a comment to D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility.

Obsoleted by https://reviews.llvm.org/D72724, closing. Thanks @Romain-Geissler-1A for triggering that patch!

Tue, Jan 14, 12:21 PM · Restricted Project
serge-sans-paille added a comment to D72724: [Driver] Ignore -fno-semantic-interposition.

@MaskRay: is that okay with you if I start implementing -fsemantic-interposition based on dso_preemptable?

Tue, Jan 14, 12:12 PM · Restricted Project
serge-sans-paille accepted D72724: [Driver] Ignore -fno-semantic-interposition.

LGTM

Tue, Jan 14, 12:02 PM · Restricted Project
serge-sans-paille added a comment to D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility.

(back on that one) The default in clang is implicitly -fno-semantic-interposition. I think we can safely support it, and either warn or error on -fsemantic-interposition. @hfinkel does that seem correct to you?

Tue, Jan 14, 7:05 AM · Restricted Project
serge-sans-paille added a comment to D72493: Fix ordering of PassExtension registry and LibraryHandles registry construction.

@lebedev.ri description updated.

Tue, Jan 14, 3:50 AM · Restricted Project
serge-sans-paille updated the summary of D72493: Fix ordering of PassExtension registry and LibraryHandles registry construction.
Tue, Jan 14, 1:42 AM · Restricted Project

Sat, Jan 11

serge-sans-paille updated the diff for D68720: Support -fstack-clash-protection for x86.
  • update warn_fe_stack_clash_protection_inline_asm location.
Sat, Jan 11, 12:15 AM · Restricted Project, Restricted Project

Fri, Jan 10

serge-sans-paille added inline comments to D68720: Support -fstack-clash-protection for x86.
Fri, Jan 10, 9:53 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D68720: Support -fstack-clash-protection for x86.
Fri, Jan 10, 6:07 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D68720: Support -fstack-clash-protection for x86.

Take review into account.

Fri, Jan 10, 5:57 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D71566: New checks for fortified sprintf.

@erik.pilkington up?

Fri, Jan 10, 5:57 AM · Restricted Project
serge-sans-paille committed rGa1cc19b58144: XFAIL load_extension.ll test on macOS only (authored by serge-sans-paille).
XFAIL load_extension.ll test on macOS only
Fri, Jan 10, 2:12 AM
serge-sans-paille added a comment to D72493: Fix ordering of PassExtension registry and LibraryHandles registry construction.

With this patch applied, I've validated on OSX and Linux that load_extension.ll passes the validation with Polly linked both statically and dynamically.

Fri, Jan 10, 1:24 AM · Restricted Project
serge-sans-paille created D72493: Fix ordering of PassExtension registry and LibraryHandles registry construction.
Fri, Jan 10, 1:24 AM · Restricted Project
serge-sans-paille committed rG346de9b67228: Fix several issues with compiler extensions (authored by serge-sans-paille).
Fix several issues with compiler extensions
Fri, Jan 10, 1:12 AM
serge-sans-paille closed D72327: Fix compiler extension builds.
Fri, Jan 10, 1:12 AM · Restricted Project
serge-sans-paille committed rG921f871ac438: Allow system header to provide their own implementation of some builtin (authored by serge-sans-paille).
Allow system header to provide their own implementation of some builtin
Fri, Jan 10, 12:49 AM
serge-sans-paille closed D71082: Allow system header to provide their own implementation of some builtin.
Fri, Jan 10, 12:48 AM · Restricted Project

Thu, Jan 9

serge-sans-paille updated the diff for D72327: Fix compiler extension builds.
  • Fix OSX build.
Thu, Jan 9, 12:44 PM · Restricted Project
serge-sans-paille committed rGb35f5d4914c9: [clang] Enforce triple in mempcpy test (authored by serge-sans-paille).
[clang] Enforce triple in mempcpy test
Thu, Jan 9, 12:16 PM
serge-sans-paille committed rGcee4a1c95742: Improve support of GNU mempcpy (authored by serge-sans-paille).
Improve support of GNU mempcpy
Thu, Jan 9, 8:31 AM
serge-sans-paille closed D71374: Improve support of GNU mempcpy.
Thu, Jan 9, 8:31 AM · Restricted Project
serge-sans-paille added a comment to D71082: Allow system header to provide their own implementation of some builtin.

@sylvestre.ledru : I'd like a confirmation from @efriedma first!

Thu, Jan 9, 7:34 AM · Restricted Project
serge-sans-paille added a comment to D71374: Improve support of GNU mempcpy.

@xbolva00 : gentle reminder :-)

Thu, Jan 9, 7:34 AM · Restricted Project

Wed, Jan 8

serge-sans-paille added a comment to D72372: [CMake] Force static linking for registered plugins on Windows..

I like the idea but

Wed, Jan 8, 10:03 PM · Restricted Project

Tue, Jan 7

serge-sans-paille added a comment to D72327: Fix compiler extension builds.

Does this fix llvm/test/Feature/load_extension.ll on macOS by any chance?

Tue, Jan 7, 12:58 PM · Restricted Project
serge-sans-paille updated the diff for D72327: Fix compiler extension builds.
Tue, Jan 7, 12:58 PM · Restricted Project
serge-sans-paille updated the diff for D72327: Fix compiler extension builds.
  • Test and handle the combination of LLVM_BUILD_EXAMPLE=OFF + LLVM_BYE_LINK_INTO_TOOLS=ON
Tue, Jan 7, 6:46 AM · Restricted Project
serge-sans-paille added a comment to D72327: Fix compiler extension builds.

I've tested that with LLVM_BYE_LINK_INTO_TOOLS ON/OFF, LLVM_BUILD_EXAMPLES ON/OFF LLVM_POLLY_LINK_INTO_TOOLS ON/OFF and it seems okay.

Tue, Jan 7, 5:51 AM · Restricted Project
serge-sans-paille added a reviewer for D72327: Fix compiler extension builds: Meinersbur.
Tue, Jan 7, 5:50 AM · Restricted Project
serge-sans-paille created D72327: Fix compiler extension builds.
Tue, Jan 7, 5:50 AM · Restricted Project
serge-sans-paille committed rG5a9c24b5721b: Fix compiler extension example cmake integration (authored by serge-sans-paille).
Fix compiler extension example cmake integration
Tue, Jan 7, 12:36 AM
serge-sans-paille closed D72255: Fix compiler extension example cmake integration.
Tue, Jan 7, 12:36 AM · Restricted Project

Mon, Jan 6

serge-sans-paille committed rG61a3af9eb507: extra github validation (authored by serge-sans-paille).
extra github validation
Mon, Jan 6, 6:52 AM
serge-sans-paille committed rG03309944ff93: Setup default build action for llvm (authored by serge-sans-paille).
Setup default build action for llvm
Mon, Jan 6, 6:51 AM
serge-sans-paille committed rG7b240e4d5ebd: Fix compiler extension example cmake integration (authored by serge-sans-paille).
Fix compiler extension example cmake integration
Mon, Jan 6, 6:51 AM
serge-sans-paille added a reviewer for D72255: Fix compiler extension example cmake integration: fhahn.
Mon, Jan 6, 5:32 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

This change seems to be causing a problem with the nightly packages from apt.llvm.org.

Mon, Jan 6, 5:31 AM · Restricted Project, Restricted Project
serge-sans-paille created D72255: Fix compiler extension example cmake integration.
Mon, Jan 6, 5:31 AM · Restricted Project

Fri, Jan 3

serge-sans-paille committed rGb2be259fa987: Fix compiler extension testing (authored by serge-sans-paille).
Fix compiler extension testing
Fri, Jan 3, 6:48 AM
serge-sans-paille committed rG61aea827df6d: Fix typo in compiler extension testing (authored by serge-sans-paille).
Fix typo in compiler extension testing
Fri, Jan 3, 6:48 AM
serge-sans-paille committed rGdfadb74f2516: Use llvm_canonicalize_cmake_booleans where intended (authored by serge-sans-paille).
Use llvm_canonicalize_cmake_booleans where intended
Fri, Jan 3, 6:48 AM
serge-sans-paille closed D72130: Compiler extension: Fix typo and cosmetic changes.
Fri, Jan 3, 6:47 AM · Restricted Project
serge-sans-paille added a comment to rG0d275431a3ab: Add intrinsics_gen *dependency* on Bye example.

Correct, there's a missing dependency, working on it.

Fri, Jan 3, 4:37 AM
serge-sans-paille updated the diff for D72130: Compiler extension: Fix typo and cosmetic changes.
  • correctly declare example dependency
Fri, Jan 3, 4:37 AM · Restricted Project
serge-sans-paille added a comment to rG0d275431a3ab: Add intrinsics_gen *dependency* on Bye example.
Fri, Jan 3, 3:14 AM
serge-sans-paille created D72130: Compiler extension: Fix typo and cosmetic changes.
Fri, Jan 3, 1:32 AM · Restricted Project

Thu, Jan 2

serge-sans-paille added inline comments to D72109: [cmake] Use relative cmake binary dir for processing pass plugins.
Thu, Jan 2, 11:49 PM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Thu, Jan 2, 8:42 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG0d275431a3ab: Add intrinsics_gen *dependency* on Bye example (authored by serge-sans-paille).
Add intrinsics_gen *dependency* on Bye example
Thu, Jan 2, 8:24 AM
serge-sans-paille committed rGa0334b3b9425: Add intrinsics_gen dependency on Bye example (authored by serge-sans-paille).
Add intrinsics_gen dependency on Bye example
Thu, Jan 2, 8:14 AM
serge-sans-paille committed rG24ab9b537e61: Generalize the pass registration mechanism used by Polly to any third-party tool (authored by serge-sans-paille).
Generalize the pass registration mechanism used by Polly to any third-party tool
Thu, Jan 2, 7:55 AM
serge-sans-paille closed D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Thu, Jan 2, 7:54 AM · Restricted Project, Restricted Project

Dec 18 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Patch rebased, validation ongoing. I'll merge that once I'm back from holidays, don't feel like commiting that 3h before holidays.

Dec 18 2019, 4:02 AM · Restricted Project, Restricted Project

Dec 17 2019

serge-sans-paille updated the diff for D71566: New checks for fortified sprintf.

Support %% and %c

Dec 17 2019, 9:26 AM · Restricted Project
serge-sans-paille added inline comments to D71566: New checks for fortified sprintf.
Dec 17 2019, 5:42 AM · Restricted Project
serge-sans-paille updated the diff for D71566: New checks for fortified sprintf.
  • Prevent assert upon wide string format
  • More test cases
Dec 17 2019, 5:42 AM · Restricted Project
serge-sans-paille updated the diff for D71566: New checks for fortified sprintf.

Take remarks into account:

  • support sprintf when the buffer has a known static size
  • use llvm::Optional
  • some extra minor tweaks.
Dec 17 2019, 3:47 AM · Restricted Project
serge-sans-paille added inline comments to D71566: New checks for fortified sprintf.
Dec 17 2019, 3:47 AM · Restricted Project

Dec 16 2019

serge-sans-paille created D71566: New checks for fortified sprintf.
Dec 16 2019, 1:21 PM · Restricted Project
serge-sans-paille added a comment to D71082: Allow system header to provide their own implementation of some builtin.

@efriedma validation passes without the checks you were pointed out, see https://github.com/serge-sans-paille/llvm-project/pull/4/checks
Thanks for making the code simpler!

Dec 16 2019, 7:11 AM · Restricted Project

Dec 14 2019

serge-sans-paille updated the diff for D71082: Allow system header to provide their own implementation of some builtin.
Dec 14 2019, 1:15 AM · Restricted Project
serge-sans-paille updated the diff for D71082: Allow system header to provide their own implementation of some builtin.

Take comment into account.

Dec 14 2019, 1:15 AM · Restricted Project
serge-sans-paille added a comment to D71374: Improve support of GNU mempcpy.

@xbolva00 : validation is ok: https://github.com/serge-sans-paille/llvm-project/pull/5/checks

Dec 14 2019, 12:57 AM · Restricted Project

Dec 13 2019

serge-sans-paille added inline comments to D71082: Allow system header to provide their own implementation of some builtin.
Dec 13 2019, 1:36 PM · Restricted Project
serge-sans-paille updated the diff for D71374: Improve support of GNU mempcpy.

Added test cases

Dec 13 2019, 7:02 AM · Restricted Project
serge-sans-paille added a comment to D71374: Improve support of GNU mempcpy.

[[edited the example to reflect actual state]]

Dec 13 2019, 4:27 AM · Restricted Project
serge-sans-paille added a comment to D71374: Improve support of GNU mempcpy.

LLVM already converts mempcpy to memcpy..

Dec 13 2019, 4:17 AM · Restricted Project
serge-sans-paille added a comment to D71374: Improve support of GNU mempcpy.
In D71374#1783032, @Jim wrote:

I am curious what is difference of code generation after applying your changes?

Dec 13 2019, 3:03 AM · Restricted Project
serge-sans-paille updated the diff for D71082: Allow system header to provide their own implementation of some builtin.
Dec 13 2019, 2:02 AM · Restricted Project
serge-sans-paille updated the diff for D71082: Allow system header to provide their own implementation of some builtin.

Handle comments.

Dec 13 2019, 12:50 AM · Restricted Project

Dec 12 2019

serge-sans-paille updated the diff for D71082: Allow system header to provide their own implementation of some builtin.

Improve test case portability.

Dec 12 2019, 10:32 AM · Restricted Project
serge-sans-paille updated the diff for D71374: Improve support of GNU mempcpy.

@Jim obviously :-) Thanks for spotting that.

Dec 12 2019, 5:10 AM · Restricted Project
serge-sans-paille updated the diff for D71082: Allow system header to provide their own implementation of some builtin.

@george.burgess.iv : take into account reviews, extra testing and function renaming.

Dec 12 2019, 5:03 AM · Restricted Project
serge-sans-paille added a comment to D71374: Improve support of GNU mempcpy.
Dec 12 2019, 1:03 AM · Restricted Project

Dec 11 2019

serge-sans-paille added a reviewer for D71374: Improve support of GNU mempcpy: rsmith.
Dec 11 2019, 1:14 PM · Restricted Project
serge-sans-paille added a reviewer for D71374: Improve support of GNU mempcpy: jedilyn.
Dec 11 2019, 1:05 PM · Restricted Project
serge-sans-paille added a comment to D71374: Improve support of GNU mempcpy.

On going validation: https://github.com/serge-sans-paille/llvm-project/pull/5/checks

Dec 11 2019, 1:05 PM · Restricted Project
serge-sans-paille added inline comments to D71082: Allow system header to provide their own implementation of some builtin.
Dec 11 2019, 12:55 PM · Restricted Project
serge-sans-paille created D71374: Improve support of GNU mempcpy.
Dec 11 2019, 12:46 PM · Restricted Project