Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (181 w, 1 d)

Recent Activity

Thu, Mar 26

serge-sans-paille added inline comments to D76642: Make static linking for LLVM plugins more reliable..
Thu, Mar 26, 2:07 AM · Restricted Project

Sat, Mar 21

serge-sans-paille committed rG49ccb32fd41b: Update ConversionToLLVMDialect.md (authored by Baden Hughes <badenh@gmail.com>).
Update ConversionToLLVMDialect.md
Sat, Mar 21, 5:21 AM

Wed, Mar 18

serge-sans-paille committed rG8d019cda851a: Fix ac1d23ed7de01fb3 interaction with gold plugin (authored by serge-sans-paille).
Fix ac1d23ed7de01fb3 interaction with gold plugin
Wed, Mar 18, 3:46 AM
serge-sans-paille added a comment to D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

@modocache: fixed by 8d019cda851a1031fbce3c50be0975438147f11d

Wed, Mar 18, 3:46 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

@modocache : thanks for the heads up, I'm investigating the issue.

Wed, Mar 18, 1:04 AM · Restricted Project, Restricted Project

Tue, Mar 17

serge-sans-paille committed rGac1d23ed7de0: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime… (authored by serge-sans-paille).
Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime…
Tue, Mar 17, 6:18 AM
serge-sans-paille closed D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.
Tue, Mar 17, 6:18 AM · Restricted Project, Restricted Project

Mon, Mar 16

serge-sans-paille updated the diff for D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

Renamed registration constructor to use a more llvm-ish name.

Mon, Mar 16, 2:46 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

@MaskRay no longer a WIP ;-)

Mon, Mar 16, 2:46 PM · Restricted Project, Restricted Project
serge-sans-paille updated the summary of D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.
Mon, Mar 16, 2:12 PM · Restricted Project, Restricted Project
serge-sans-paille retitled D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration from [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries to Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries.
Mon, Mar 16, 2:12 PM · Restricted Project, Restricted Project
serge-sans-paille retitled D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration from Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries to Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.
Mon, Mar 16, 2:12 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

@MaskRay gentle up :-)

Mon, Mar 16, 12:01 PM · Restricted Project, Restricted Project

Fri, Mar 13

serge-sans-paille accepted D76126: Convert old python3 cgi method into the new html one.
Help on function escape in cgi:
Fri, Mar 13, 6:22 AM · Restricted Project

Wed, Mar 11

serge-sans-paille added a comment to D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

@MaskRay are you ok with that version?

Wed, Mar 11, 11:18 AM · Restricted Project, Restricted Project

Tue, Mar 10

serge-sans-paille added a comment to D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

@MaskRay

because that will cause duplicate registration of llvm::cl::opt flags.
Tue, Mar 10, 8:06 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

Cleaned up code, using a few macros to avoid duplication.

Tue, Mar 10, 8:06 AM · Restricted Project, Restricted Project

Mon, Mar 9

serge-sans-paille updated the diff for D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

@MaskRay The library version prooved to be a bad path: we wanted clang-cpp to always link to a shared library, which interacts in ungraceful ways with BUILD_SHARED_LIBS.

Mon, Mar 9, 8:35 AM · Restricted Project, Restricted Project

Thu, Mar 5

serge-sans-paille committed rGcb06571a441c: Avoid dangling reference on SectionList (authored by serge-sans-paille).
Avoid dangling reference on SectionList
Thu, Mar 5, 1:09 AM
serge-sans-paille closed D75110: Avoid dangling reference when indexing sections.
Thu, Mar 5, 1:09 AM · Restricted Project
serge-sans-paille added a comment to D75110: Avoid dangling reference when indexing sections.

@grimar ok, change added to the commit.

Thu, Mar 5, 1:08 AM · Restricted Project

Wed, Mar 4

serge-sans-paille updated the diff for D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

This passes the following configurations:

Wed, Mar 4, 3:11 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.

Fix lto-test bugs + convert more files, still not ready for review.

Wed, Mar 4, 2:52 AM · Restricted Project, Restricted Project

Tue, Mar 3

serge-sans-paille created D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration.
Tue, Mar 3, 4:07 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to rG5a1958f2673f: Syndicate, test and fix base64 implementation.

Recommited as of 1454c27b60447d969d0c1ecaf20b2186fe9d85ec

Tue, Mar 3, 9:40 AM
serge-sans-paille committed rG292ab49d43a2: Fix UB in compiler-rt base64 implementation (authored by serge-sans-paille).
Fix UB in compiler-rt base64 implementation
Tue, Mar 3, 4:36 AM
serge-sans-paille committed rG1454c27b6044: Syndicate, test and fix base64 implementation (authored by serge-sans-paille).
Syndicate, test and fix base64 implementation
Tue, Mar 3, 4:12 AM

Mon, Mar 2

serge-sans-paille accepted D75199: Build fix: Turn off _GLIBCXX_DEBUG on gcc 9.

LGTM

Mon, Mar 2, 6:52 AM · Restricted Project
serge-sans-paille added a comment to rG5a1958f2673f: Syndicate, test and fix base64 implementation.

For the record: test patched by b52355f8a196b5040dc2e42870bf8c459306cfaa

Mon, Mar 2, 6:44 AM
serge-sans-paille committed rGb52355f8a196: Fix Base64Test - for StringRef size (authored by serge-sans-paille).
Fix Base64Test - for StringRef size
Mon, Mar 2, 2:19 AM
serge-sans-paille committed rG5a1958f2673f: Syndicate, test and fix base64 implementation (authored by serge-sans-paille).
Syndicate, test and fix base64 implementation
Mon, Mar 2, 1:06 AM
serge-sans-paille closed D75057: Syndicate, test and fix base64 implementation.
Mon, Mar 2, 1:06 AM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2020

serge-sans-paille committed rG6d15c4deab51: No longer generate calls to *_finite (authored by serge-sans-paille).
No longer generate calls to *_finite
Feb 28 2020, 1:21 AM
serge-sans-paille closed D74712: Remove *_finite library support, following upstream.
Feb 28 2020, 1:21 AM · Restricted Project

Feb 27 2020

serge-sans-paille updated the diff for D74712: Remove *_finite library support, following upstream.

Update test case, according to @efriedma suggestion.

Feb 27 2020, 12:24 PM · Restricted Project
serge-sans-paille added inline comments to D75057: Syndicate, test and fix base64 implementation.
Feb 27 2020, 11:34 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille updated the diff for D75057: Syndicate, test and fix base64 implementation.

Add a test case that exhibits the overflow in previous implementation + minor nits from @hokein

Feb 27 2020, 11:34 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D75057: Syndicate, test and fix base64 implementation.

thanks for doing this! didn't look into details yet. Could you explain what was the bug in the previous code?

Feb 27 2020, 10:25 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D75199: Build fix: Turn off _GLIBCXX_DEBUG on gcc 9.

@nhaehnle : something like

Feb 27 2020, 6:56 AM · Restricted Project
serge-sans-paille added reviewers for D75057: Syndicate, test and fix base64 implementation: kadircet, hokein.
Feb 27 2020, 6:39 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D75057: Syndicate, test and fix base64 implementation.

Up?

Feb 27 2020, 6:38 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille updated the diff for D74712: Remove *_finite library support, following upstream.
Feb 27 2020, 3:47 AM · Restricted Project
serge-sans-paille added a comment to D74712: Remove *_finite library support, following upstream.

@andrew.w.kaylor / @efriedma : comments taken into account.

Feb 27 2020, 1:19 AM · Restricted Project
serge-sans-paille updated the diff for D74712: Remove *_finite library support, following upstream.
Feb 27 2020, 1:18 AM · Restricted Project
serge-sans-paille added a comment to D75110: Avoid dangling reference when indexing sections.

@lhames is that okay like this?

Feb 27 2020, 1:07 AM · Restricted Project

Feb 26 2020

serge-sans-paille added a comment to rGd2cbaf1755ff: Fix for the test failues introduced in https://reviews.llvm.org/D74704..

Thanks @leonardchan

Feb 26 2020, 12:37 PM
serge-sans-paille added a comment to D75199: Build fix: Turn off _GLIBCXX_DEBUG on gcc 9.

Thanks for working on this! I ran into this once and manually undefined the macro, so the workaround looks decent. However, I share @hans concerns about the detection part. You most likely want to compile minimal C++ program using std::min (and maybe other functions) to detect if the actual standard library used matches our requirements.

Feb 26 2020, 12:20 PM · Restricted Project
serge-sans-paille committed rG19c664f71e88: Fix typo in clang lit config (authored by serge-sans-paille).
Fix typo in clang lit config
Feb 26 2020, 2:00 AM
serge-sans-paille added a comment to D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded.

@serge-sans-paille The test was still failing on macOS.

Feb 26 2020, 1:33 AM · Restricted Project
serge-sans-paille abandoned D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode.

Obsoleted by https://reviews.llvm.org/D74878

Feb 26 2020, 1:33 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGe058667a2e01: Support -fuse-ld=lld for riscv (authored by serge-sans-paille).
Support -fuse-ld=lld for riscv
Feb 26 2020, 1:21 AM
serge-sans-paille closed D74704: Support -fuse-ld=lld for riscv.
Feb 26 2020, 1:21 AM · Restricted Project
serge-sans-paille abandoned D74540: Rework go bindings so that binding tests work fine.

llvm-go is still a thing, this patch is no longer needed

Feb 26 2020, 1:18 AM · Restricted Project

Feb 25 2020

serge-sans-paille committed rGd00900801aae: Remove no un-necessary require for load_extension.ll (authored by serge-sans-paille).
Remove no un-necessary require for load_extension.ll
Feb 25 2020, 11:30 PM
serge-sans-paille updated the diff for D75110: Avoid dangling reference when indexing sections.

Fix include order

Feb 25 2020, 11:30 PM · Restricted Project
serge-sans-paille updated the diff for D75110: Avoid dangling reference when indexing sections.

Use the <deque> approach

Feb 25 2020, 11:21 PM · Restricted Project
serge-sans-paille added a comment to D75110: Avoid dangling reference when indexing sections.

Thanks very much for this Serge!

Is the std::deque fix a one-liner? This shouldn't be very performance sensitive, so I'd be inclined to go with that.

Feb 25 2020, 2:45 PM · Restricted Project
serge-sans-paille added a comment to D74878: [remark][diagnostics] [codegen] Fix PR44896.

Nice work, LGTM too.

Feb 25 2020, 5:59 AM · Restricted Project
serge-sans-paille created D75110: Avoid dangling reference when indexing sections.
Feb 25 2020, 4:15 AM · Restricted Project

Feb 24 2020

serge-sans-paille updated the diff for D75057: Syndicate, test and fix base64 implementation.
Feb 24 2020, 1:34 PM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille updated the diff for D75057: Syndicate, test and fix base64 implementation.
Feb 24 2020, 12:29 PM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille updated the diff for D75057: Syndicate, test and fix base64 implementation.

Other copy/paste typo.

Feb 24 2020, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille removed a reviewer for D75057: Syndicate, test and fix base64 implementation: lebedev.ri.

As a side note, pre-reserving the buffer size gives interesting speedup, see http://quick-bench.com/Lp6OwO2etW1YEmJayVWn3U8JDiY

Feb 24 2020, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille updated the diff for D75057: Syndicate, test and fix base64 implementation.

Fix typo

Feb 24 2020, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille updated the diff for D75057: Syndicate, test and fix base64 implementation.

Restore duplication, fix the bug in two separate locations.

Feb 24 2020, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
serge-sans-paille added a comment to D74878: [remark][diagnostics] [codegen] Fix PR44896.

Will this also give a warning when passing a .ll file to a release clang, without explicitly passing the '-fdiscard-value-names' ? Is this what we want it to be ?

Feb 24 2020, 9:44 AM · Restricted Project
serge-sans-paille accepted D72372: [CMake] Default to static linking for subprojects..

@Meinersbur LGTM, thanks

Feb 24 2020, 9:35 AM · Restricted Project
serge-sans-paille committed rG400b6c083f84: [NFC] Fix typo in error message (authored by serge-sans-paille).
[NFC] Fix typo in error message
Feb 24 2020, 9:26 AM
serge-sans-paille created D75057: Syndicate, test and fix base64 implementation.
Feb 24 2020, 8:31 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2020

serge-sans-paille committed rG453cd2dbe57b: Update ShapeInference.md (authored by Baden Hughes <580499+badenh@users.noreply.github.com>).
Update ShapeInference.md
Feb 22 2020, 2:02 AM
serge-sans-paille committed rGd192a4ab2b8c: Update Quantization.md (authored by Baden Hughes <580499+badenh@users.noreply.github.com>).
Update Quantization.md
Feb 22 2020, 1:58 AM

Feb 21 2020

serge-sans-paille updated the diff for D74712: Remove *_finite library support, following upstream.

As hinted by @efriedma , only remove lowering to *_finite calls in Codegen.

Feb 21 2020, 7:09 AM · Restricted Project
serge-sans-paille committed rG99b03c1c18de: Detect and disable openmp tests that require multiple hardware processor to run (authored by serge-sans-paille).
Detect and disable openmp tests that require multiple hardware processor to run
Feb 21 2020, 5:12 AM
serge-sans-paille closed D74921: Detect and disable openmp tests that require multiple hardware processor to run when only one core is available..
Feb 21 2020, 5:11 AM · Restricted Project
serge-sans-paille committed rGa24d46318f66: [NFC] Corrected a minor typo in a comment (authored by Swiftfuchs <github@t-no.de>).
[NFC] Corrected a minor typo in a comment
Feb 21 2020, 5:03 AM
serge-sans-paille added a comment to D74878: [remark][diagnostics] [codegen] Fix PR44896.

Let's go that way then. @xur I leave it to you to add the appropriate warning at least on the clang side? Feel free to just use the code from https://reviews.llvm.org/D74871?id=245594.

Feb 21 2020, 1:53 AM · Restricted Project
serge-sans-paille updated the diff for D74704: Support -fuse-ld=lld for riscv.

Add a configure feature test to filter out tests that depend on platform linker, as hinted by @MaskRay

Feb 21 2020, 1:44 AM · Restricted Project

Feb 20 2020

serge-sans-paille created D74921: Detect and disable openmp tests that require multiple hardware processor to run when only one core is available..
Feb 20 2020, 11:42 AM · Restricted Project
serge-sans-paille added a comment to D74704: Support -fuse-ld=lld for riscv.

For the record: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Ariscv64-toolchain.c fails

Feb 20 2020, 11:15 AM · Restricted Project
serge-sans-paille added a comment to D74878: [remark][diagnostics] [codegen] Fix PR44896.

@lebedev.ri maybe we should at least warn the user if there was a flag at clang level to force discarding? That's what I've been doing in https://reviews.llvm.org/D74871?id=245594

Feb 20 2020, 8:48 AM · Restricted Project
serge-sans-paille committed rGdef62c7f6548: [NFC] Remove ar/ranlib test noise during cmake step (authored by serge-sans-paille).
[NFC] Remove ar/ranlib test noise during cmake step
Feb 20 2020, 2:26 AM
serge-sans-paille updated the diff for D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode.

Other approach to the problem: modify Value::SetNameImpl

Feb 20 2020, 2:16 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode.

Finally, the test case :-)

Feb 20 2020, 12:30 AM · Restricted Project, Restricted Project

Feb 19 2020

serge-sans-paille committed rG3a0f6e699bb6: Fix compiler extension in standalone mode (authored by serge-sans-paille).
Fix compiler extension in standalone mode
Feb 19 2020, 10:25 PM
serge-sans-paille closed D74757: Fix compiler extension in standalone mode.
Feb 19 2020, 10:25 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode.

Added test case.

Feb 19 2020, 10:18 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode.

Why is this not a bug in w/e is handling the IR?

Feb 19 2020, 10:18 PM · Restricted Project, Restricted Project
serge-sans-paille created D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode.
Feb 19 2020, 1:48 PM · Restricted Project, Restricted Project

Feb 18 2020

serge-sans-paille updated the diff for D74757: Fix compiler extension in standalone mode.

Take @Meinersbur review into account.

Feb 18 2020, 11:10 PM · Restricted Project, Restricted Project
serge-sans-paille committed rGb8bea9346af4: Revert "Support -fuse-ld=lld for riscv" (authored by serge-sans-paille).
Revert "Support -fuse-ld=lld for riscv"
Feb 18 2020, 11:58 AM
serge-sans-paille added a reverting change for rGdd230142d8a0: Support -fuse-ld=lld for riscv: rGb8bea9346af4: Revert "Support -fuse-ld=lld for riscv".
Feb 18 2020, 11:58 AM
serge-sans-paille added a comment to D74704: Support -fuse-ld=lld for riscv.

I'll revert and propose an updated patch then.

Feb 18 2020, 11:58 AM · Restricted Project
serge-sans-paille added a comment to D74704: Support -fuse-ld=lld for riscv.

Reverted through b8bea9346af4f2644c9a1bd29710c5e3efbbd7d3

Feb 18 2020, 11:58 AM · Restricted Project
serge-sans-paille updated subscribers of D74757: Fix compiler extension in standalone mode.
Feb 18 2020, 9:02 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D74757: Fix compiler extension in standalone mode.

Tested without standalone build with polly linked statically and dynamically with success.

Feb 18 2020, 9:02 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG498a6136a271: Prevent gcc from issuing a warning upon coffnamecpy (authored by serge-sans-paille).
Prevent gcc from issuing a warning upon coffnamecpy
Feb 18 2020, 7:21 AM
serge-sans-paille closed D74666: Prevent gcc from issuing a warning upon coffnamecpy.
Feb 18 2020, 7:21 AM · Restricted Project
serge-sans-paille committed rGcc7a197f9f10: Fix riscv/lld test interaction (authored by serge-sans-paille).
Fix riscv/lld test interaction
Feb 18 2020, 3:35 AM
serge-sans-paille committed rGdd230142d8a0: Support -fuse-ld=lld for riscv (authored by serge-sans-paille).
Support -fuse-ld=lld for riscv
Feb 18 2020, 2:24 AM
serge-sans-paille closed D74704: Support -fuse-ld=lld for riscv.
Feb 18 2020, 2:24 AM · Restricted Project