Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (299 w, 1 d)

Recent Activity

Yesterday

serge-sans-paille added a comment to D129061: [Lex] Diagnose macro in command lines.

great addition. Missing a test case though, which would probably trigger @aaron.ballman scenario

Tue, Jul 5, 6:34 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG3897d3cf71ef: [clang-tidy] By-pass portability issues in confusable-identifiers test (authored by serge-sans-paille).
[clang-tidy] By-pass portability issues in confusable-identifiers test
Tue, Jul 5, 3:36 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext.

Looks like this breaks tests on windows: http://45.33.8.238/win/61559/step_8.txt

Tue, Jul 5, 2:13 AM · Restricted Project, Restricted Project

Mon, Jul 4

serge-sans-paille committed rG7a550212e8ff: [clang-tidy] Fix confusable identifiers interaction with DeclContext (authored by serge-sans-paille).
[clang-tidy] Fix confusable identifiers interaction with DeclContext
Mon, Jul 4, 11:57 PM · Restricted Project, Restricted Project
serge-sans-paille closed D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext.
Mon, Jul 4, 11:56 PM · Restricted Project, Restricted Project
serge-sans-paille accepted D128783: [test] Check for more -fsanitize=array-bounds regressions.

I'm fine with these tests has they reflect current implementation. But beware that ubsan and -Warray-bounds don't behave the same wrt. FAM, which I find disturbing. I'll discuss that in another review.

Mon, Jul 4, 9:21 AM · Restricted Project, Restricted Project
serge-sans-paille closed D128341: [iwyu] Handle regressions in libLLVM header include.
Mon, Jul 4, 9:17 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D128449: [clang] Introduce -Warray-parameter.

Fix handling of ConstantArrayType, thanks @aaron.ballman for the hint.

Mon, Jul 4, 6:42 AM · Restricted Project, Restricted Project

Fri, Jul 1

serge-sans-paille requested review of D128992: [sanitizer] Don't lookup swift_demangle through dlsym.
Fri, Jul 1, 7:05 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D128119: [clang] enforce instantiation of constexpr template functions.

gentle ping o/

Fri, Jul 1, 1:25 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D128783: [test] Check for more -fsanitize=array-bounds regressions.
Fri, Jul 1, 12:27 AM · Restricted Project, Restricted Project

Thu, Jun 30

serge-sans-paille updated the diff for D128449: [clang] Introduce -Warray-parameter.

Extra test

Thu, Jun 30, 2:58 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext.

Update test case to take into accounts reviewers suggestions.

Thu, Jun 30, 1:44 PM · Restricted Project, Restricted Project

Wed, Jun 29

serge-sans-paille added a comment to D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext.

@aaron.ballman : I agree with most of your suggestion except the one below that I annotated accordingly

Wed, Jun 29, 10:21 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D128783: [test] Check for more -fsanitize=array-bounds regressions.

And note that with current clang, the behavior I describe here is not uniform across clang code base :-/

Wed, Jun 29, 6:28 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D128783: [test] Check for more -fsanitize=array-bounds regressions.

Do we need a C test (just add a -x c RUN line)? @serge-sans-paille Do you think we may likely make C++ stricter than C?

Wed, Jun 29, 6:27 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Code updated to take into account two situations:

Wed, Jun 29, 5:49 AM · Restricted Project, Restricted Project

Tue, Jun 28

serge-sans-paille added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

GCC and Clang don't have the same behavior wrt. macros-as-abound and standard-layout-requirement, see https://godbolt.org/z/3vc4TcTYz
I'm fine with keeping the CLang behavior, but do we want to keep it only for level=0, and drop it for higher level (this would look odd to me).

Tue, Jun 28, 12:29 PM · Restricted Project, Restricted Project
serge-sans-paille requested review of D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext.
Tue, Jun 28, 1:37 AM · Restricted Project, Restricted Project

Mon, Jun 27

serge-sans-paille added inline comments to D128449: [clang] Introduce -Warray-parameter.
Mon, Jun 27, 12:21 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D128449: [clang] Introduce -Warray-parameter.

Take review into account + add C++ test file.

Mon, Jun 27, 12:20 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D128341: [iwyu] Handle regressions in libLLVM header include.

oh, and I landed that one while forgetting to link it to phabricator, this patch landed as 27fd01d3f88c1996fc000b6e139b50a600879fde

Mon, Jun 27, 8:19 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D128341: [iwyu] Handle regressions in libLLVM header include.

@RKSimon: I don't track the origin of the change, I can't tell...

Mon, Jun 27, 8:19 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D128560: An upcoming patch to LLDB will require the ability to decode base64. This patch adds support for decoding base64 and adds tests..
Mon, Jun 27, 8:15 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D128643: [clang] -fsanitize=array-bounds: treat all trailing size-1 arrays as flexible.
Mon, Jun 27, 8:04 AM · Restricted Project, Restricted Project

Fri, Jun 24

serge-sans-paille added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Thanks @MaskRay for the quick patch!

Fri, Jun 24, 10:57 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG886715af962d: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible… (authored by serge-sans-paille).
[clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible…
Fri, Jun 24, 7:14 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D128449: [clang] Introduce -Warray-parameter.

Take review into account : rework indentation, style cleaning and be more accurate about bounds reporting

Fri, Jun 24, 6:04 AM · Restricted Project, Restricted Project

Thu, Jun 23

serge-sans-paille updated the diff for D128449: [clang] Introduce -Warray-parameter.

Activate -Warray-parameter on -Wmost but disable it by default

Thu, Jun 23, 9:32 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D128449: [clang] Introduce -Warray-parameter.
Thu, Jun 23, 8:11 AM · Restricted Project, Restricted Project

Wed, Jun 22

serge-sans-paille committed rG27fd01d3f88c: [iwyu] Handle regressions in libLLVM header include (authored by serge-sans-paille).
[iwyu] Handle regressions in libLLVM header include
Wed, Jun 22, 9:51 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D128119: [clang] enforce instantiation of constexpr template functions.
Wed, Jun 22, 7:40 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D128341: [iwyu] Handle regressions in libLLVM header include.
Wed, Jun 22, 7:23 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGc3574ef739fb: [clang-tidy] Confusable identifiers detection (authored by serge-sans-paille).
[clang-tidy] Confusable identifiers detection
Wed, Jun 22, 7:19 AM · Restricted Project, Restricted Project
serge-sans-paille closed D112916: [clang-tidy] Confusable identifiers detection.
Wed, Jun 22, 7:19 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D122677: [prototype] include-cleaner library.

Hey Sam, any update on this one? How can I help?

Wed, Jun 22, 6:18 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

serge-sans-paille committed rGaaf1630ac38c: [Scalarizer] No need to gather a scattered extracted element (authored by serge-sans-paille).
[Scalarizer] No need to gather a scattered extracted element
Tue, Jun 21, 9:46 AM · Restricted Project, Restricted Project
serge-sans-paille closed D126012: [Scalarizer] No need to gather a scattered extracted element.
Tue, Jun 21, 9:46 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D126012: [Scalarizer] No need to gather a scattered extracted element.

Follow @nikic approach there, it's clean and simple. Just fix a little edge case in the finish routine. Note that I could have checked the size of the cleanup vector, but I felt like a more explicit approach would be better.

Tue, Jun 21, 5:57 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

@kees does the new version looks good to you?

Tue, Jun 21, 1:53 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D112916: [clang-tidy] Confusable identifiers detection.

Address most reviewers comment:

  • formatting style
  • reduced memory consumption
  • be clear about TR39 divergence
  • class and option renaming
  • getName() usage
Tue, Jun 21, 1:23 AM · Restricted Project, Restricted Project

Mon, Jun 20

serge-sans-paille added a comment to D128119: [clang] enforce instantiation of constexpr template functions.

This also seems to fix https://github.com/llvm/llvm-project/issues/37522 and https://github.com/llvm/llvm-project/issues/55315

Mon, Jun 20, 6:29 AM · Restricted Project, Restricted Project

Sat, Jun 18

serge-sans-paille updated the diff for D128119: [clang] enforce instantiation of constexpr template functions.

(rebased on main branch)

Sat, Jun 18, 4:58 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D128119: [clang] enforce instantiation of constexpr template functions.

I"m not 100% sure of the fix but it fixes bug #55560 and does not introduce regression :-/

Sat, Jun 18, 4:52 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D128119: [clang] enforce instantiation of constexpr template functions.
Sat, Jun 18, 4:51 AM · Restricted Project, Restricted Project

Thu, Jun 16

serge-sans-paille updated the diff for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Update option and code to handle several level of conformance

Thu, Jun 16, 9:52 AM · Restricted Project, Restricted Project

Wed, Jun 15

serge-sans-paille added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 does toward -fstrict-flex-arrays=<n> with

Wed, Jun 15, 1:27 AM · Restricted Project, Restricted Project

Tue, Jun 14

serge-sans-paille updated the diff for D112916: [clang-tidy] Confusable identifiers detection.

Take into account @aaron.ballman review

Tue, Jun 14, 5:16 AM · Restricted Project, Restricted Project

Mon, Jun 13

serge-sans-paille updated the diff for D112916: [clang-tidy] Confusable identifiers detection.

Address reviews

Mon, Jun 13, 12:09 PM · Restricted Project, Restricted Project
serge-sans-paille requested review of D112916: [clang-tidy] Confusable identifiers detection.
Mon, Jun 13, 8:27 AM · Restricted Project, Restricted Project
serge-sans-paille reopened D112916: [clang-tidy] Confusable identifiers detection.

cc @thakis

Mon, Jun 13, 8:15 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D112916: [clang-tidy] Confusable identifiers detection.
  • quiet output of the table conversion program when everything goes well
  • cross-compilation support (untested)
  • fix identifier retrieving
Mon, Jun 13, 8:15 AM · Restricted Project, Restricted Project
serge-sans-paille abandoned D113991: Support using sha256 as --build-id kind.

Blake3 adopted instead

Mon, Jun 13, 12:28 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Looks good on my side, waiting for feedback ;-)

Mon, Jun 13, 12:27 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.
Mon, Jun 13, 12:25 AM · Restricted Project, Restricted Project

Fri, Jun 10

serge-sans-paille updated the diff for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Cleanup testcase

Fri, Jun 10, 1:12 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Update changelog entry

Fri, Jun 10, 6:51 AM · Restricted Project, Restricted Project

Thu, Jun 9

serge-sans-paille updated the diff for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Take into account @efriedma and @kees review, plus adding a bunch of extra test case

Thu, Jun 9, 6:10 AM · Restricted Project, Restricted Project

Jun 3 2022

serge-sans-paille added a comment to D112916: [clang-tidy] Confusable identifiers detection.

Thanks @thakis for the post-commit review. I'll give it another try next week.

Jun 3 2022, 9:07 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Fix typo

Jun 3 2022, 8:57 AM · Restricted Project, Restricted Project
serge-sans-paille added a reviewer for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays: efriedma.
Jun 3 2022, 6:19 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGb94db7ed7eaf: [clang-tidy] Confusable identifiers detection (authored by serge-sans-paille).
[clang-tidy] Confusable identifiers detection
Jun 3 2022, 3:20 AM · Restricted Project, Restricted Project
serge-sans-paille closed D112916: [clang-tidy] Confusable identifiers detection.
Jun 3 2022, 3:20 AM · Restricted Project, Restricted Project

Jun 2 2022

serge-sans-paille committed rG4d73c46ccf86: [MCParser] Set default alignment value when meeting invalid align (authored by serge-sans-paille).
[MCParser] Set default alignment value when meeting invalid align
Jun 2 2022, 7:23 AM · Restricted Project, Restricted Project
serge-sans-paille closed D125688: [MCParser] Set default alignment value when meeting invalid align.
Jun 2 2022, 7:23 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D125688: [MCParser] Set default alignment value when meeting invalid align.

Address reviewer comment and add an extra test case to capture the issue.

Jun 2 2022, 5:23 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Note: I named the option -fstrict-flex-arrays and not -fstrict-flex-array because we already have -fstrict-enums.

Jun 2 2022, 2:35 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.
Jun 2 2022, 2:34 AM · Restricted Project, Restricted Project

Jun 1 2022

serge-sans-paille added a reviewer for D125688: [MCParser] Set default alignment value when meeting invalid align: eliben.
Jun 1 2022, 5:32 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D126254: Add support for decoding base64..

Sorry for the back and forth: I find the logic difficult to follow. What would you think of something along these lines (untested) https://godbolt.org/z/vh356fhaP

Jun 1 2022, 5:24 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGb1b86b639433: [Clang][Driver] More explicit message when failing to find sanitizer resource… (authored by serge-sans-paille).
[Clang][Driver] More explicit message when failing to find sanitizer resource…
Jun 1 2022, 1:55 AM · Restricted Project, Restricted Project
serge-sans-paille closed D120484: More explicit message when failing to find a mandatory cfi ressource file.
Jun 1 2022, 1:54 AM · Restricted Project, Restricted Project

May 31 2022

serge-sans-paille updated the diff for D120484: More explicit message when failing to find a mandatory cfi ressource file.

Updating test case / sorry for the delay

May 31 2022, 6:07 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D126012: [Scalarizer] No need to gather a scattered extracted element.

Gentle ping :-)

May 31 2022, 5:43 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D126254: Add support for decoding base64..
May 31 2022, 5:41 AM · Restricted Project, Restricted Project

May 25 2022

serge-sans-paille committed rGfb67d683db46: [iwyu] Handle regressions in libLLVM header include (authored by serge-sans-paille).
[iwyu] Handle regressions in libLLVM header include
May 25 2022, 11:13 PM · Restricted Project, Restricted Project
serge-sans-paille closed D126417: [iwyu] Handle regressions in libLLVM header include.
May 25 2022, 11:12 PM · Restricted Project, Restricted Project
serge-sans-paille requested review of D126417: [iwyu] Handle regressions in libLLVM header include.
May 25 2022, 1:39 PM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D126254: Add support for decoding base64..
May 25 2022, 2:04 AM · Restricted Project, Restricted Project

May 23 2022

serge-sans-paille added inline comments to D126254: Add support for decoding base64..
May 23 2022, 10:45 PM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D126254: Add support for decoding base64..
May 23 2022, 10:38 PM · Restricted Project, Restricted Project

May 19 2022

serge-sans-paille requested review of D126012: [Scalarizer] No need to gather a scattered extracted element.
May 19 2022, 1:23 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D125688: [MCParser] Set default alignment value when meeting invalid align.

Gentle ping :-) I'm a little unsure on the value change upon error, but that's also a bit strange to issue an error but still generate some output.

May 19 2022, 6:17 AM · Restricted Project, Restricted Project

May 16 2022

serge-sans-paille updated the diff for D125688: [MCParser] Set default alignment value when meeting invalid align.

Update existing test case

May 16 2022, 12:35 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D125688: [MCParser] Set default alignment value when meeting invalid align.

Fix test case

May 16 2022, 11:34 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D125688: [MCParser] Set default alignment value when meeting invalid align.

+ test case

May 16 2022, 9:36 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D125688: [MCParser] Set default alignment value when meeting invalid align.

Is it possible to add a test for this?

May 16 2022, 7:56 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D125688: [MCParser] Set default alignment value when meeting invalid align.
May 16 2022, 7:07 AM · Restricted Project, Restricted Project

May 15 2022

serge-sans-paille committed rG924acb624f58: [clang] Prevent folding of non-const compound expr (authored by serge-sans-paille).
[clang] Prevent folding of non-const compound expr
May 15 2022, 10:53 PM · Restricted Project, Restricted Project
serge-sans-paille closed D124038: [clang] Prevent folding of non-const compound expr.
May 15 2022, 10:53 PM · Restricted Project, Restricted Project

May 13 2022

serge-sans-paille updated the diff for D124038: [clang] Prevent folding of non-const compound expr.

Update messed up format

May 13 2022, 12:59 AM · Restricted Project, Restricted Project

May 12 2022

serge-sans-paille committed rG40d3a0ba4d9e: [openmp] Fix strict aliasing issue in cmpxchg routine (authored by serge-sans-paille).
[openmp] Fix strict aliasing issue in cmpxchg routine
May 12 2022, 7:17 AM · Restricted Project, Restricted Project
serge-sans-paille closed D125467: [openmp] Fix strict aliasing issue in cmpxchg routine.
May 12 2022, 7:17 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D125467: [openmp] Fix strict aliasing issue in cmpxchg routine.
May 12 2022, 6:40 AM · Restricted Project, Restricted Project
serge-sans-paille requested review of D125467: [openmp] Fix strict aliasing issue in cmpxchg routine.
May 12 2022, 6:39 AM · Restricted Project, Restricted Project

May 10 2022

serge-sans-paille updated the diff for D124038: [clang] Prevent folding of non-const compound expr.

Update GCC manual quote

May 10 2022, 9:44 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D124038: [clang] Prevent folding of non-const compound expr.

I think you're looking at old documentation? Here's what the current page (https://gcc.gnu.org/onlinedocs/gcc/Compound-Literals.html) has to say:

May 10 2022, 1:50 PM · Restricted Project, Restricted Project
serge-sans-paille accepted D125005: Make standalone-build-x86_64 a standalone builder.

Looks good to me. Please wait for confirmation by @tstellar though.

May 10 2022, 2:19 AM · Restricted Project
serge-sans-paille added inline comments to D124038: [clang] Prevent folding of non-const compound expr.
May 10 2022, 2:15 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D124038: [clang] Prevent folding of non-const compound expr.

Added reg to GCC info page to explain current behavior, and make the test more explicit with respect to that quote.

May 10 2022, 2:14 AM · Restricted Project, Restricted Project