Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (144 w, 6 d)

Recent Activity

Sat, Jul 20

serge-sans-paille committed rGa30a4a35ecbd: Fix asan infinite loop on undefined symbol (authored by serge-sans-paille).
Fix asan infinite loop on undefined symbol
Sat, Jul 20, 10:45 AM
serge-sans-paille committed rG7a3d4c15a7fc: Revert "Fix asan infinite loop on undefined symbol" (authored by serge-sans-paille).
Revert "Fix asan infinite loop on undefined symbol"
Sat, Jul 20, 6:01 AM
serge-sans-paille added a reverting change for rGcbd28cd05bb1: Fix asan infinite loop on undefined symbol: rG7a3d4c15a7fc: Revert "Fix asan infinite loop on undefined symbol".
Sat, Jul 20, 6:01 AM
serge-sans-paille committed rGcbd28cd05bb1: Fix asan infinite loop on undefined symbol (authored by serge-sans-paille).
Fix asan infinite loop on undefined symbol
Sat, Jul 20, 5:02 AM

Fri, Jul 19

serge-sans-paille committed rG8e46275488ca: Fix asan infinite loop on undefined symbol (authored by serge-sans-paille).
Fix asan infinite loop on undefined symbol
Fri, Jul 19, 8:24 AM

Thu, Jul 18

serge-sans-paille committed rGec2a7c463e60: Restrict asan + dlopen testcase to x86 (authored by serge-sans-paille).
Restrict asan + dlopen testcase to x86
Thu, Jul 18, 6:52 AM
serge-sans-paille committed rG6a61bea4d652: Relax regexp to detect failed interception by asan (authored by serge-sans-paille).
Relax regexp to detect failed interception by asan
Thu, Jul 18, 6:14 AM
serge-sans-paille committed rG63719119c78c: Fix asan infinite loop on undefined symbol (authored by serge-sans-paille).
Fix asan infinite loop on undefined symbol
Thu, Jul 18, 1:10 AM

Wed, Jul 17

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Added a Bye project in examples/
Fixed linking of plugins into core tools
Fixed dependency issue

Wed, Jul 17, 2:15 AM · Restricted Project, Restricted Project

Tue, Jul 16

serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.

Fix test requires + asan calls

Tue, Jul 16, 2:17 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Tue, Jul 16, 2:17 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGa3077526277c: [clang-scan-view] Force utf-8 when handling report (python2 only) (authored by serge-sans-paille).
[clang-scan-view] Force utf-8 when handling report (python2 only)
Tue, Jul 16, 1:57 AM

Fri, Jul 5

serge-sans-paille added a comment to D59948: Support providing pass schedule to new passmanager as a YAML input.

@chandlerc any chance you could have a look at this?

Fri, Jul 5, 5:53 AM · Restricted Project

Thu, Jul 4

serge-sans-paille committed rG85fc597f26c8: Document legacy pass manager extension points (authored by serge-sans-paille).
Document legacy pass manager extension points
Thu, Jul 4, 7:06 AM

Wed, Jul 3

serge-sans-paille created D64129: [clang-scan-view] Force utf-8 when handling report (python2 only).
Wed, Jul 3, 4:07 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Wed, Jul 3, 2:20 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.
Wed, Jul 3, 2:20 AM · Restricted Project, Restricted Project

Tue, Jul 2

serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.

Update test according to @kcc remark.

Tue, Jul 2, 2:38 PM · Restricted Project, Restricted Project
serge-sans-paille created D64093: Document legacy pass manager extension points.
Tue, Jul 2, 12:28 PM · Restricted Project
serge-sans-paille committed rG4137aeb4bf3a: Provide basic Full LTO extension points (authored by serge-sans-paille).
Provide basic Full LTO extension points
Tue, Jul 2, 8:53 AM
serge-sans-paille added a comment to D64065: Skip test earlier if metric is not found in compare.py.

LGTM then, please get another feedback though, I'm not comfortable with that code area

Tue, Jul 2, 8:42 AM · Restricted Project
serge-sans-paille added inline comments to D64065: Skip test earlier if metric is not found in compare.py.
Tue, Jul 2, 5:48 AM · Restricted Project

Mon, Jul 1

serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

@vitalybuka / @kcc : up?

Mon, Jul 1, 3:13 PM · Restricted Project, Restricted Project

Fri, Jun 28

serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Fri, Jun 28, 2:21 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.

Following @yln question, improve the CHECK of the associated test case

Fri, Jun 28, 1:34 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Fri, Jun 28, 1:11 AM · Restricted Project, Restricted Project

Thu, Jun 27

serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Thu, Jun 27, 10:34 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.
  • Test added
  • Comment added
  • make the change more localized, closer to the origin of the issue
Thu, Jun 27, 2:28 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.
Thu, Jun 27, 2:28 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

check-asan works just fine

Thu, Jun 27, 9:32 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

@kcc tested on the bug test case and it now raises a decent error, not tested on compiler-rt test suite (yet)

Thu, Jun 27, 6:43 AM · Restricted Project, Restricted Project
serge-sans-paille created D63877: Avoid infinite loop with asan interception.
Thu, Jun 27, 6:43 AM · Restricted Project, Restricted Project

Wed, Jun 26

serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Wed, Jun 26, 6:39 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur your comment and my devs crossed, but this should be fine. This update enables new PM static plugin support for clang, something that was lacking to polly previously. I've tested it a bit and it builds fine with static setup, still need to test it with more config.

Wed, Jun 26, 6:30 AM · Restricted Project, Restricted Project

Jun 21 2019

serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

@mehdi_amini up ;-)

Jun 21 2019, 10:55 PM · Restricted Project

Jun 20 2019

serge-sans-paille committed rG60ca31a7ddab: [clang-tidy] Fail gracefully upon empty database fields (authored by serge-sans-paille).
[clang-tidy] Fail gracefully upon empty database fields
Jun 20 2019, 1:24 PM
serge-sans-paille added a comment to D63613: [clang-tidy] Fail gracefully upon empty database fields.

Thanks @jkorous for the fast review o/

Jun 20 2019, 1:23 PM · Restricted Project, Restricted Project
serge-sans-paille created D63613: [clang-tidy] Fail gracefully upon empty database fields.
Jun 20 2019, 10:11 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGdad50a745874: [NFC] Update documentation for AtomicCmpXchgInst (authored by serge-sans-paille).
[NFC] Update documentation for AtomicCmpXchgInst
Jun 20 2019, 2:36 AM

Jun 18 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Mostly documentation update + helper function renaming.

Jun 18 2019, 4:24 AM · Restricted Project, Restricted Project

Jun 17 2019

serge-sans-paille added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
Jun 17 2019, 9:39 AM · Restricted Project, Restricted Project

Jun 13 2019

serge-sans-paille added a comment to D63254: [lit] Fix UnicodeEncodeError when test commands contain non-ASCII chars.

LGTM. Can you add a test case in lit/tests for that?

Jun 13 2019, 6:18 AM · Restricted Project

Jun 12 2019

serge-sans-paille committed rG4548c1cfca45: Sanitize llvm-extract -help output (authored by serge-sans-paille).
Sanitize llvm-extract -help output
Jun 12 2019, 2:06 PM

Jun 11 2019

serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Jun 11 2019, 8:14 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@beanz : In addition to your suggested changes, I've renamed the cmake utility into add_llvm_pass_plugin to match other functions from AddLLVM.cmake

Jun 11 2019, 8:14 AM · Restricted Project, Restricted Project

Jun 8 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Using @beanz idea, provide an option to add_llvm_executable to declare it as receiving plugins, which provides lower coupling with actual plugins

Jun 8 2019, 8:54 AM · Restricted Project, Restricted Project

Jun 6 2019

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Just an idea: We could avoid the explicit calls to 'initializeXYZPass' in opt/bugpoint/clang by adding Polly.cpp as a source file or object library to the executables. This would guarantee that its static initializer is called without dynamic library.

Jun 6 2019, 1:35 PM · Restricted Project, Restricted Project

Jun 5 2019

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur Itested with the following configuration

Jun 5 2019, 12:05 PM · Restricted Project, Restricted Project
serge-sans-paille committed rGdaeeb33f8601: Sanitize llvm-size help (authored by serge-sans-paille).
Sanitize llvm-size help
Jun 5 2019, 3:30 AM
serge-sans-paille updated the diff for D62482: Sanitize llvm-size help.
  • do not set category for positional argument
Jun 5 2019, 1:09 AM · Restricted Project
serge-sans-paille updated the diff for D62511: Sanitize llvm-extract -help output.

remove category of positional argument

Jun 5 2019, 12:47 AM · Restricted Project
serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

@mehdi_amini up :-)

Jun 5 2019, 12:33 AM · Restricted Project
serge-sans-paille added inline comments to D62511: Sanitize llvm-extract -help output.
Jun 5 2019, 12:21 AM · Restricted Project

Jun 4 2019

serge-sans-paille committed rG4cd07dbeec98: Reduce memory consumption of coverage dumps (authored by serge-sans-paille).
Reduce memory consumption of coverage dumps
Jun 4 2019, 11:34 PM
serge-sans-paille closed D62623: Reduce memory consumption of coverage dumps.
Jun 4 2019, 11:34 PM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
  • get Rid of the constraint on initializePasses : it can be registered suing a static constructor, no need to clutter the API with it
Jun 4 2019, 11:33 PM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D62623: Reduce memory consumption of coverage dumps.
Jun 4 2019, 2:46 PM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
  • make it possible for client code to speicify the registration function for new PM, thanks @philip.pfaffe for the hint. @Meinersbur this should be ok now.
Jun 4 2019, 2:46 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Take into account @philip.pfaffe remarks and improve support for new PM.

Jun 4 2019, 8:43 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@beanz turns out the depdendency problem was just a matter of moving the register_llvm_extension call at the top of the file.

Jun 4 2019, 4:57 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@philip.pfaffe : NewPM integeration actually works thanks to `Register${Name}Passes(llvm::PassBuilder &PB)`. It's already used by Polly for NewPM integration and we mimic that.

Jun 4 2019, 4:55 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
  • reorder registration to make sure options are correctly taken into account
  • make LINK_POLLY_INTO_TOOLS obsolete in favor of just using LLVM_LINK_POLLY_INTO_TOOLS
Jun 4 2019, 4:47 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D62623: Reduce memory consumption of coverage dumps.

Update comment + force reduced memory consumption.

Jun 4 2019, 3:35 AM · Restricted Project

Jun 3 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Jun 3 2019, 2:01 PM · Restricted Project, Restricted Project

May 31 2019

serge-sans-paille accepted D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..

LGTM

May 31 2019, 9:59 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

I wonder if the LTO pass pipeline shouldn't honor the existing EP_EarlyAsPossible extension point?

May 31 2019, 12:51 AM · Restricted Project
serge-sans-paille updated the diff for D61738: Provide basic LTO extension points.

Diff updated with context

May 31 2019, 12:50 AM · Restricted Project

May 30 2019

serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

@mehdi_amini up :-)

May 30 2019, 11:34 PM · Restricted Project
serge-sans-paille added a comment to D62623: Reduce memory consumption of coverage dumps.

@kwk: looks like you're still compiling with clang-7, this patch is to be applied on the master version of LLVM/clang, then you can install it and use it to recompile llvm/lld with coverage info.

May 30 2019, 1:18 AM · Restricted Project

May 29 2019

serge-sans-paille updated the summary of D62623: Reduce memory consumption of coverage dumps.
May 29 2019, 1:15 PM · Restricted Project
serge-sans-paille created D62623: Reduce memory consumption of coverage dumps.
May 29 2019, 1:15 PM · Restricted Project

May 28 2019

serge-sans-paille added a comment to D62511: Sanitize llvm-extract -help output.

For reference, the output before filtering (but after categorization)

May 28 2019, 1:37 AM · Restricted Project
serge-sans-paille created D62511: Sanitize llvm-extract -help output.
May 28 2019, 1:27 AM · Restricted Project

May 27 2019

serge-sans-paille added a comment to D62482: Sanitize llvm-size help.

For reference, unfiltered output:

May 27 2019, 5:17 AM · Restricted Project
serge-sans-paille created D62482: Sanitize llvm-size help.
May 27 2019, 5:17 AM · Restricted Project
serge-sans-paille added a comment to D57830: Add functionality to trace a function within lldb.

LGTM with respect to Python 2/3 compat, can't tell for the functionality though.

May 27 2019, 1:27 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur up!

May 27 2019, 1:27 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG6e379e2b68a0: Make llvm-as --help great again (authored by serge-sans-paille).
Make llvm-as --help great again
May 27 2019, 1:22 AM

May 23 2019

serge-sans-paille added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
May 23 2019, 10:55 AM · Restricted Project, Restricted Project

May 22 2019

serge-sans-paille added a comment to D60603: Make llvm-as --help great again.

@jhenderson , @ddunbar : I've checked the callgraph of llvm-as, and none of theses flags are actually reachable:

May 22 2019, 5:48 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur thanks a lot for the feedback. I was only testing with the new project layout, so it's nice you tested with the legacy layout.
I've updated the diff accordingly, it now compiles fine on my Linux box with both old-style and new-style layout.

May 22 2019, 1:45 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
May 22 2019, 1:45 AM · Restricted Project, Restricted Project

May 21 2019

serge-sans-paille added inline comments to D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
May 21 2019, 11:35 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG94c36fa15ba3: Properly categorize llvm-objdump options (authored by serge-sans-paille).
Properly categorize llvm-objdump options
May 21 2019, 11:30 PM
serge-sans-paille added a comment to D62195: Properly categorize llvm-objdump options.

Following a remark from @jhenderson , and in order to make sure the options filtered out are not relevant, I've been running a clang-based script to compute the application callgraph, registering all calls to `llvm::cl` commands and their parent.

May 21 2019, 7:12 AM · Restricted Project
serge-sans-paille added a comment to D62195: Properly categorize llvm-objdump options.

For reference, toe output of -help with and without filtering:

May 21 2019, 7:09 AM · Restricted Project
serge-sans-paille created D62195: Properly categorize llvm-objdump options.
May 21 2019, 7:07 AM · Restricted Project

May 17 2019

serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
May 17 2019, 2:14 PM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
May 17 2019, 10:28 AM · Restricted Project
serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

Therefore, I recommend removing the SubCommand parameter from this API and always using cl::TopLevelSubCommand.

May 17 2019, 9:55 AM · Restricted Project
serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda / @beanz : I've been thinking about this, and I'm now convinced that this review is probably not the good approach. What we need is a good way to track which options are actually important for a given binary, correctly set the categories of each option and *reallyhide* the others. So I'll pause this review and start working on sanitizing the output of several tools until I get a better understanding of the actual API needs.

May 17 2019, 8:40 AM · Restricted Project

May 16 2019

serge-sans-paille committed rGab155469835a: Fix isInSystemMacro in presence of macro and pasted token (authored by serge-sans-paille).
Fix isInSystemMacro in presence of macro and pasted token
May 16 2019, 5:40 AM

May 15 2019

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@beanz

I expect that we will want to use cl::HideUnrelatedOptions in a lot more places to clean up other tool help messages.

That's indeed the plan.

May 15 2019, 12:46 PM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.

@lebedev.ri doc updated.

May 15 2019, 6:26 AM · Restricted Project
serge-sans-paille updated the diff for D59413: Fix isInSystemMacro in presence of macro and pasted token.

Updated with clang-formated diff

May 15 2019, 5:17 AM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda I've updated the patch taking your advices into account. I took a step ahead and applied the non-conservative signature change for cl::HideUnrelatedOptions

May 15 2019, 5:04 AM · Restricted Project

May 14 2019

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda this looks better that way, for sure.

May 14 2019, 6:45 AM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
May 14 2019, 6:44 AM · Restricted Project

May 13 2019

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

It was added in D7100, and I think the rational was to hide implementation details.

May 13 2019, 10:13 PM · Restricted Project
serge-sans-paille created D61870: Make cl::HideUnrelatedOptionsless error-prone.
May 13 2019, 1:23 PM · Restricted Project