- User Since
- Oct 10 2016, 10:44 AM (336 w, 2 d)
No comment, thanks for the patch!
Extra round of tests on my side: current version leads to 550 instruction moved when compiling cpython with -ftrivial-auto-var-init=pattern. @nikic I think the patch is ready for you to look at it again :-)
Update test case according to @nikic review.
Fix variable naming.
Mon, Mar 20
Take into account all @nikic comments.
Thu, Mar 16
@cjdb : should be good now :-)
Wed, Mar 15
Mon, Mar 13
Take review into account.
Still get a
+ constexpr version
+ check for ub in bitwise shift.
First time contribution to libc++, I apologize in advance if the style / conformance is not correct.
Wed, Mar 8
@nikic : I've not addressed your inline comments yet, but I've improved the approach through alias analysis, this indeed looks better now, at least to me. What do you think?
Use Alias Analysis to filter-out non clobbering memory accesses, as suggested by @nikic . Also added a test case (clobber.ll) to ensure this works as expected.
Thu, Mar 2
Tue, Feb 28
The cleanup looks good to me, thanks! Out of curiosity, did just stumble on this, or did an automatic tool gave you an hint?
Thu, Feb 23
LGTM (I assume that most of the time, we're just copying pointers and it's fine either way).
I'd like to move forward with this, and try to implement a more general approach that considers any instruction, and not only the instruction generated for auto init. But I need to unlock that review first :-)
No need to check if getMemoryInst returns nullptr or not.
Feb 17 2023
@thieta ACK once you fix the issue spotted by@jlpeyton.
Feb 14 2023
Fix MemoryPhi handling
Superseded by https://reviews.llvm.org/D144029
Thanks for providing a much more satisfying approach than the one I proposed in https://reviews.llvm.org/D144020 !
Feb 13 2023
Some extra call to list are correct wrt py2/py3 compat but are actually not needed, let's not introduce them at all.
Feb 9 2023
@efriedma : gentle ping :-) Any thoughts on this version, now based on MemorySSA?
Feb 6 2023
Feb 5 2023
Address @tbader's comment
remove mutable qualifier
Feb 2 2023
@efriedma : any comment / opinion on this now that it's based on MemorySSA?
Take into account @nickdesaulniers review.
Gentle ping :-)
Feb 1 2023
looks good to me!
Jan 30 2023
Do you intend to (optionnaly) provide XXH3 as described in https://github.com/Cyan4973/xxHash ?
Can you take a shot against https://llvm-compile-time-tracker.com/ so that we get an hint of the practical speedup?
Jan 26 2023
Jan 25 2023
I did a quick check and it was indeed tuned
Jan 24 2023
Address review + rebase patch
Jan 23 2023
This got fixed in d1f313e73a1b33d662dbab54be76720b9c875645.
Do not enfore StringLiteral parameter. This is too invasive on the code base.
Jan 21 2023
Plausibly caused by this change -- I'm thinking that MaximumDistance is initialized to UINT_MAX - 1, but then we cast that to a signed integer and compare that, so it wraps to a large negative number.
@nikic : I thought I fixed that with e8a163dc03e6913360beb305620104ba129c081c ... is it included in your build?
Jan 20 2023
Fix build + make StringLiteral initialization constexpr.
Jan 19 2023
Thanks @nikic for the review. Remarks taken into account.
Jan 18 2023
Jan 16 2023
Fix and document alignment requirements
Add alignment requirements
Jan 15 2023
Jan 13 2023
Jan 12 2023
Jan 11 2023
nits + rebased on main
Nits + rebase on main branch