Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (153 w, 6 d)

Recent Activity

Wed, Sep 18

serge-sans-paille committed rGe93aded7f02d: Initialize all fields in ABIArgInfo. (authored by serge-sans-paille).
Initialize all fields in ABIArgInfo.
Wed, Sep 18, 5:55 PM
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur any feedback on this update?

Wed, Sep 18, 8:16 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D66790: Fix SROA in presence of incompatible vector types in the same partition.

@chandlerc / @bkramer any thought on this fix?

Wed, Sep 18, 8:16 AM · Restricted Project

Fri, Sep 13

serge-sans-paille accepted D67555: [docs][llvm-size] Write llvm-size documentation.
Fri, Sep 13, 1:04 PM · Restricted Project
serge-sans-paille added a comment to D67555: [docs][llvm-size] Write llvm-size documentation.

LGTM, that's super nice!

Fri, Sep 13, 1:04 PM · Restricted Project

Thu, Sep 12

serge-sans-paille updated the diff for D66790: Fix SROA in presence of incompatible vector types in the same partition.

Updated test case.

Thu, Sep 12, 2:12 AM · Restricted Project

Wed, Sep 11

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Up :-)

Wed, Sep 11, 9:53 AM · Restricted Project, Restricted Project

Mon, Sep 9

serge-sans-paille added a comment to D66790: Fix SROA in presence of incompatible vector types in the same partition.

Up?

Mon, Sep 9, 4:59 AM · Restricted Project

Sun, Sep 8

serge-sans-paille accepted D67298: [ASan] Only run dlopen-mixed-c-cxx.c with static runtime.

We should keep tests as broad as possible to maximize the likelihood that it fails if someone breaks this (or a similar) case in the future.

Sun, Sep 8, 6:42 AM · Restricted Project, Restricted Project

Sat, Sep 7

serge-sans-paille added a comment to D67298: [ASan] Only run dlopen-mixed-c-cxx.c with static runtime.

Successfully tested on my box! I'd just use

Sat, Sep 7, 12:12 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D67298: [ASan] Only run dlopen-mixed-c-cxx.c with static runtime.

@Hahnfeld I missed your previous answer, sorry about that

Sat, Sep 7, 9:03 AM · Restricted Project, Restricted Project
serge-sans-paille abandoned D67319: Fix dlopen-mixed-c-cxx test case when libstdc++ is not available.
Sat, Sep 7, 9:01 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D67298: [ASan] Only run dlopen-mixed-c-cxx.c with static runtime.

@Hahnfeld https://reviews.llvm.org/D67319 contains a potential fix. Can you give it a try?

Sat, Sep 7, 8:57 AM · Restricted Project, Restricted Project
serge-sans-paille created D67319: Fix dlopen-mixed-c-cxx test case when libstdc++ is not available.
Sat, Sep 7, 8:57 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D67298: [ASan] Only run dlopen-mixed-c-cxx.c with static runtime.

And that's what I don't understand

Sat, Sep 7, 5:31 AM · Restricted Project, Restricted Project

Fri, Sep 6

serge-sans-paille added a comment to D67298: [ASan] Only run dlopen-mixed-c-cxx.c with static runtime.

Mmmmh the whole point of the test is to test how asan behaves when meeting a symbol like __cxa_throw in a dlopened library when the calling compilation unit is not linked against libstdc++. Previous behavior was a segfault, we should now get a reasonable error. By defining __cxa_throw in the c file, you remove the origin of the bug, so sure it works, but it no longer tests the faulty situation. Maybe tehre's a symbol defined in both libcxx and libstdc++ the same way?

Fri, Sep 6, 2:58 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D67230: Remove call to obsolete gethostbyname, using getaddrinfo.

@davezarzycki I tend to agree with you. We can just remove 35:44 and just keep the hostname.

Fri, Sep 6, 9:34 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG90d32df7db51: Remove call to obsolete gethostbyname, using getaddrinfo (authored by serge-sans-paille).
Remove call to obsolete gethostbyname, using getaddrinfo
Fri, Sep 6, 4:07 AM
serge-sans-paille added a comment to D67258: Out-of-tree machine IR passes.

Could you add some documentation, probably in docs/MIRLangRef.rst? Also you lack a test case, probably in ./CodeGen/MIR/Generic/

Fri, Sep 6, 12:15 AM · Restricted Project

Thu, Sep 5

serge-sans-paille created D67230: Remove call to obsolete gethostbyname, using getaddrinfo.
Thu, Sep 5, 10:00 AM · Restricted Project, Restricted Project

Tue, Sep 3

serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

Is that summary correct?

Tue, Sep 3, 11:43 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

@Hahnfeld : I understand your concern. However this test case is meant to test handling of stdlib exceptions, so it doesn't look strange to disable it if stdlib is not used, right? Do you know of another feature we could use?

Tue, Sep 3, 11:29 AM · Restricted Project, Restricted Project

Wed, Aug 28

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur patch rebased. I removed the linker trick (which only work for global variables, not function, anyway), as it's no longer needed:

Wed, Aug 28, 4:40 AM · Restricted Project, Restricted Project

Tue, Aug 27

serge-sans-paille updated the summary of D66790: Fix SROA in presence of incompatible vector types in the same partition.
Tue, Aug 27, 2:31 AM · Restricted Project
serge-sans-paille created D66790: Fix SROA in presence of incompatible vector types in the same partition.
Tue, Aug 27, 2:19 AM · Restricted Project

Aug 22 2019

serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

@Hahnfeld : I failed to reproduce the issue locally, but I assume the following patch may solve your issue:

Aug 22 2019, 7:00 AM · Restricted Project, Restricted Project

Aug 21 2019

serge-sans-paille committed rGd1262a6e91d5: Be explicit about Windows coff name trailing character policy (authored by serge-sans-paille).
Be explicit about Windows coff name trailing character policy
Aug 21 2019, 12:59 AM
serge-sans-paille closed D66420: Be explicit about Windows coff name trailing character policy.
Aug 21 2019, 12:59 AM · Restricted Project
serge-sans-paille added a comment to D66420: Be explicit about Windows coff name trailing character policy.

I guess we're suppressing the warning by rinsing the string literals through StringRef, so GCC can't see the source string size.

Aug 21 2019, 12:59 AM · Restricted Project

Aug 20 2019

serge-sans-paille updated the diff for D66420: Be explicit about Windows coff name trailing character policy.

Take into account @rnk's review.

Aug 20 2019, 2:13 PM · Restricted Project
serge-sans-paille added a comment to D66420: Be explicit about Windows coff name trailing character policy.

The gcc analysis is not interprocedural.

Aug 20 2019, 1:17 PM · Restricted Project

Aug 19 2019

serge-sans-paille updated the diff for D66420: Be explicit about Windows coff name trailing character policy.
Aug 19 2019, 11:51 AM · Restricted Project
serge-sans-paille created D66420: Be explicit about Windows coff name trailing character policy.
Aug 19 2019, 8:54 AM · Restricted Project
serge-sans-paille committed rGa023d6b7de78: [nfc] Silent gcc warning (authored by serge-sans-paille).
[nfc] Silent gcc warning
Aug 19 2019, 7:42 AM
serge-sans-paille accepted D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py.

Sorry for the long delay, this LGTM

Aug 19 2019, 6:33 AM · Restricted Project
serge-sans-paille added a reviewer for D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility: hfinkel.

Adding @hfinkel to the thread to confirm it's okay to add this behavior, as he authored an RFC on the subject (see https://lists.llvm.org/pipermail/llvm-dev/2016-November/107625.html)

Aug 19 2019, 3:32 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur up!

Aug 19 2019, 3:20 AM · Restricted Project, Restricted Project

Aug 10 2019

serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

ok, it's probably a regex issue for the test, I'll check that.

Aug 10 2019, 12:07 PM · Restricted Project, Restricted Project

Aug 2 2019

serge-sans-paille accepted D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility.

LGTM

Aug 2 2019, 10:46 PM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Also fix symbol redefinition during static builds on Windows

Aug 2 2019, 10:44 PM · Restricted Project, Restricted Project

Jul 31 2019

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur nop, forgot that one, I'll have a look, thanks for pointing that out.

Jul 31 2019, 10:04 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Make validation more resilient depending on shared/static build.

Jul 31 2019, 6:48 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur I've updated the test case to test extension point if the extension is linked in, this is not so intrusive, I'm happy with the solution.

Jul 31 2019, 12:35 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
  • Test extension point registration when extension is built-in
  • Correctly handle -DLLVM_LINK_LLVM_DYLIB=0
  • Fix a few details
Jul 31 2019, 12:04 AM · Restricted Project, Restricted Project

Jul 26 2019

serge-sans-paille added a comment to D65295: [opt] Ensure the IR-Linker is available to plugins..

@Meinersbur what about linking with LLVM-IR linker in your shared module?

Jul 26 2019, 2:05 AM · Restricted Project

Jul 20 2019

serge-sans-paille committed rGa30a4a35ecbd: Fix asan infinite loop on undefined symbol (authored by serge-sans-paille).
Fix asan infinite loop on undefined symbol
Jul 20 2019, 10:45 AM
serge-sans-paille committed rG7a3d4c15a7fc: Revert "Fix asan infinite loop on undefined symbol" (authored by serge-sans-paille).
Revert "Fix asan infinite loop on undefined symbol"
Jul 20 2019, 6:01 AM
serge-sans-paille added a reverting change for rGcbd28cd05bb1: Fix asan infinite loop on undefined symbol: rG7a3d4c15a7fc: Revert "Fix asan infinite loop on undefined symbol".
Jul 20 2019, 6:01 AM
serge-sans-paille committed rGcbd28cd05bb1: Fix asan infinite loop on undefined symbol (authored by serge-sans-paille).
Fix asan infinite loop on undefined symbol
Jul 20 2019, 5:02 AM

Jul 19 2019

serge-sans-paille committed rG8e46275488ca: Fix asan infinite loop on undefined symbol (authored by serge-sans-paille).
Fix asan infinite loop on undefined symbol
Jul 19 2019, 8:24 AM

Jul 18 2019

serge-sans-paille committed rGec2a7c463e60: Restrict asan + dlopen testcase to x86 (authored by serge-sans-paille).
Restrict asan + dlopen testcase to x86
Jul 18 2019, 6:52 AM
serge-sans-paille committed rG6a61bea4d652: Relax regexp to detect failed interception by asan (authored by serge-sans-paille).
Relax regexp to detect failed interception by asan
Jul 18 2019, 6:14 AM
serge-sans-paille committed rG63719119c78c: Fix asan infinite loop on undefined symbol (authored by serge-sans-paille).
Fix asan infinite loop on undefined symbol
Jul 18 2019, 1:10 AM

Jul 17 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Added a Bye project in examples/
Fixed linking of plugins into core tools
Fixed dependency issue

Jul 17 2019, 2:15 AM · Restricted Project, Restricted Project

Jul 16 2019

serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.

Fix test requires + asan calls

Jul 16 2019, 2:17 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Jul 16 2019, 2:17 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGa3077526277c: [clang-scan-view] Force utf-8 when handling report (python2 only) (authored by serge-sans-paille).
[clang-scan-view] Force utf-8 when handling report (python2 only)
Jul 16 2019, 1:57 AM

Jul 5 2019

serge-sans-paille added a comment to D59948: Support providing pass schedule to new passmanager as a YAML input.

@chandlerc any chance you could have a look at this?

Jul 5 2019, 5:53 AM · Restricted Project

Jul 4 2019

serge-sans-paille committed rG85fc597f26c8: Document legacy pass manager extension points (authored by serge-sans-paille).
Document legacy pass manager extension points
Jul 4 2019, 7:06 AM

Jul 3 2019

serge-sans-paille created D64129: [clang-scan-view] Force utf-8 when handling report (python2 only).
Jul 3 2019, 4:07 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Jul 3 2019, 2:20 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.
Jul 3 2019, 2:20 AM · Restricted Project, Restricted Project

Jul 2 2019

serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.

Update test according to @kcc remark.

Jul 2 2019, 2:38 PM · Restricted Project, Restricted Project
serge-sans-paille created D64093: Document legacy pass manager extension points.
Jul 2 2019, 12:28 PM · Restricted Project
serge-sans-paille committed rG4137aeb4bf3a: Provide basic Full LTO extension points (authored by serge-sans-paille).
Provide basic Full LTO extension points
Jul 2 2019, 8:53 AM
serge-sans-paille added a comment to D64065: Skip test earlier if metric is not found in compare.py.

LGTM then, please get another feedback though, I'm not comfortable with that code area

Jul 2 2019, 8:42 AM · Restricted Project
serge-sans-paille added inline comments to D64065: Skip test earlier if metric is not found in compare.py.
Jul 2 2019, 5:48 AM · Restricted Project

Jul 1 2019

serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

@vitalybuka / @kcc : up?

Jul 1 2019, 3:13 PM · Restricted Project, Restricted Project

Jun 28 2019

serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Jun 28 2019, 2:21 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.

Following @yln question, improve the CHECK of the associated test case

Jun 28 2019, 1:34 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Jun 28 2019, 1:11 AM · Restricted Project, Restricted Project

Jun 27 2019

serge-sans-paille added inline comments to D63877: Avoid infinite loop with asan interception.
Jun 27 2019, 10:34 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.
  • Test added
  • Comment added
  • make the change more localized, closer to the origin of the issue
Jun 27 2019, 2:28 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D63877: Avoid infinite loop with asan interception.
Jun 27 2019, 2:28 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

check-asan works just fine

Jun 27 2019, 9:32 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D63877: Avoid infinite loop with asan interception.

@kcc tested on the bug test case and it now raises a decent error, not tested on compiler-rt test suite (yet)

Jun 27 2019, 6:43 AM · Restricted Project, Restricted Project
serge-sans-paille created D63877: Avoid infinite loop with asan interception.
Jun 27 2019, 6:43 AM · Restricted Project, Restricted Project

Jun 26 2019

serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Jun 26 2019, 6:39 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur your comment and my devs crossed, but this should be fine. This update enables new PM static plugin support for clang, something that was lacking to polly previously. I've tested it a bit and it builds fine with static setup, still need to test it with more config.

Jun 26 2019, 6:30 AM · Restricted Project, Restricted Project

Jun 21 2019

serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

@mehdi_amini up ;-)

Jun 21 2019, 10:55 PM · Restricted Project

Jun 20 2019

serge-sans-paille committed rG60ca31a7ddab: [clang-tidy] Fail gracefully upon empty database fields (authored by serge-sans-paille).
[clang-tidy] Fail gracefully upon empty database fields
Jun 20 2019, 1:24 PM
serge-sans-paille added a comment to D63613: [clang-tidy] Fail gracefully upon empty database fields.

Thanks @jkorous for the fast review o/

Jun 20 2019, 1:23 PM · Restricted Project, Restricted Project
serge-sans-paille created D63613: [clang-tidy] Fail gracefully upon empty database fields.
Jun 20 2019, 10:11 AM · Restricted Project, Restricted Project
serge-sans-paille committed rGdad50a745874: [NFC] Update documentation for AtomicCmpXchgInst (authored by serge-sans-paille).
[NFC] Update documentation for AtomicCmpXchgInst
Jun 20 2019, 2:36 AM

Jun 18 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Mostly documentation update + helper function renaming.

Jun 18 2019, 4:24 AM · Restricted Project, Restricted Project

Jun 17 2019

serge-sans-paille added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
Jun 17 2019, 9:39 AM · Restricted Project, Restricted Project

Jun 13 2019

serge-sans-paille added a comment to D63254: [lit] Fix UnicodeEncodeError when test commands contain non-ASCII chars.

LGTM. Can you add a test case in lit/tests for that?

Jun 13 2019, 6:18 AM · Restricted Project

Jun 12 2019

serge-sans-paille committed rG4548c1cfca45: Sanitize llvm-extract -help output (authored by serge-sans-paille).
Sanitize llvm-extract -help output
Jun 12 2019, 2:06 PM

Jun 11 2019

serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Jun 11 2019, 8:14 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@beanz : In addition to your suggested changes, I've renamed the cmake utility into add_llvm_pass_plugin to match other functions from AddLLVM.cmake

Jun 11 2019, 8:14 AM · Restricted Project, Restricted Project

Jun 8 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Using @beanz idea, provide an option to add_llvm_executable to declare it as receiving plugins, which provides lower coupling with actual plugins

Jun 8 2019, 8:54 AM · Restricted Project, Restricted Project

Jun 6 2019

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Just an idea: We could avoid the explicit calls to 'initializeXYZPass' in opt/bugpoint/clang by adding Polly.cpp as a source file or object library to the executables. This would guarantee that its static initializer is called without dynamic library.

Jun 6 2019, 1:35 PM · Restricted Project, Restricted Project

Jun 5 2019

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur Itested with the following configuration

Jun 5 2019, 12:05 PM · Restricted Project, Restricted Project
serge-sans-paille committed rGdaeeb33f8601: Sanitize llvm-size help (authored by serge-sans-paille).
Sanitize llvm-size help
Jun 5 2019, 3:30 AM
serge-sans-paille updated the diff for D62482: Sanitize llvm-size help.
  • do not set category for positional argument
Jun 5 2019, 1:09 AM · Restricted Project
serge-sans-paille updated the diff for D62511: Sanitize llvm-extract -help output.

remove category of positional argument

Jun 5 2019, 12:47 AM · Restricted Project
serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

@mehdi_amini up :-)

Jun 5 2019, 12:33 AM · Restricted Project
serge-sans-paille added inline comments to D62511: Sanitize llvm-extract -help output.
Jun 5 2019, 12:21 AM · Restricted Project

Jun 4 2019

serge-sans-paille committed rG4cd07dbeec98: Reduce memory consumption of coverage dumps (authored by serge-sans-paille).
Reduce memory consumption of coverage dumps
Jun 4 2019, 11:34 PM
serge-sans-paille closed D62623: Reduce memory consumption of coverage dumps.
Jun 4 2019, 11:34 PM · Restricted Project