- User Since
- Oct 10 2016, 10:44 AM (170 w, 4 d)
Update size computation + test case involving null byte inside the format string.
Take into account some of the reviews
Thu, Jan 16
Add test case
The simplest one I can think of is to make __warn_memset_zero_len a recognized builtin that generates no code.
+1, simple and easy.
@akhuang can you confirm this fixes your issue? I've tested locally and it works fine on my side.
@MaskRay no example yet, I'd like your opinion on the approach first. It has the advantage of being non intrusive to the code base...
@akhuang : I've reported https://sourceware.org/bugzilla/show_bug.cgi?id=25399 to glibc. According to me this is more of a glibc problem than this patch, and as we have a workaround with -fgnuc-version=5.0 I think we could apply the patch back.
Tue, Jan 14
@MaskRay: is that okay with you if I start implementing -fsemantic-interposition based on dso_preemptable?
(back on that one) The default in clang is implicitly -fno-semantic-interposition. I think we can safely support it, and either warn or error on -fsemantic-interposition. @hfinkel does that seem correct to you?
@lebedev.ri description updated.
Sat, Jan 11
- update warn_fe_stack_clash_protection_inline_asm location.
Fri, Jan 10
Take review into account.
With this patch applied, I've validated on OSX and Linux that load_extension.ll passes the validation with Polly linked both statically and dynamically.
Thu, Jan 9
- Fix OSX build.
@xbolva00 : gentle reminder :-)
Wed, Jan 8
I like the idea but
Tue, Jan 7
- Test and handle the combination of LLVM_BUILD_EXAMPLE=OFF + LLVM_BYE_LINK_INTO_TOOLS=ON
I've tested that with LLVM_BYE_LINK_INTO_TOOLS ON/OFF, LLVM_BUILD_EXAMPLES ON/OFF LLVM_POLLY_LINK_INTO_TOOLS ON/OFF and it seems okay.
Mon, Jan 6
Fri, Jan 3
Correct, there's a missing dependency, working on it.
- correctly declare example dependency
Thu, Jan 2
Dec 18 2019
Patch rebased, validation ongoing. I'll merge that once I'm back from holidays, don't feel like commiting that 3h before holidays.
Dec 17 2019
Support %% and %c
- Prevent assert upon wide string format
- More test cases
Take remarks into account:
- support sprintf when the buffer has a known static size
- use llvm::Optional
- some extra minor tweaks.
Dec 16 2019
@efriedma validation passes without the checks you were pointed out, see https://github.com/serge-sans-paille/llvm-project/pull/4/checks
Thanks for making the code simpler!
Dec 14 2019
Take comment into account.
@xbolva00 : validation is ok: https://github.com/serge-sans-paille/llvm-project/pull/5/checks
Dec 13 2019
Added test cases
[[edited the example to reflect actual state]]
Dec 12 2019
Improve test case portability.
@Jim obviously :-) Thanks for spotting that.
@george.burgess.iv : take into account reviews, extra testing and function renaming.
Dec 11 2019
On going validation: https://github.com/serge-sans-paille/llvm-project/pull/5/checks