Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (244 w, 3 d)

Recent Activity

Yesterday

serge-sans-paille updated the diff for D104299: Handle interactions between reserved identifier and user-defined suffixes.

Tried another not-so-intrusive approach. @rsmith?

Wed, Jun 16, 6:51 AM · Restricted Project

Tue, Jun 15

serge-sans-paille updated the diff for D104299: Handle interactions between reserved identifier and user-defined suffixes.
Tue, Jun 15, 8:08 AM · Restricted Project
serge-sans-paille requested review of D104299: Handle interactions between reserved identifier and user-defined suffixes.
Tue, Jun 15, 8:05 AM · Restricted Project

Mon, Jun 14

serge-sans-paille added a comment to D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+.

This leaves the question - what hardware should we align each of the CK_x86_64_v* targets with?

Mon, Jun 14, 6:41 AM · Restricted Project

Sun, Jun 13

serge-sans-paille committed rG092c303955cd: AMD k8 family does not support SSE4.x which are required by x86-64-v2+ (authored by serge-sans-paille).
AMD k8 family does not support SSE4.x which are required by x86-64-v2+
Sun, Jun 13, 10:18 PM
serge-sans-paille closed D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+.
Sun, Jun 13, 10:18 PM · Restricted Project
serge-sans-paille added a comment to D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+.

Thanks for the fast review!

Sun, Jun 13, 10:17 PM · Restricted Project

Fri, Jun 11

serge-sans-paille updated the summary of D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+.
Fri, Jun 11, 6:47 AM · Restricted Project
serge-sans-paille requested review of D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+.
Fri, Jun 11, 6:45 AM · Restricted Project

Thu, Jun 10

serge-sans-paille updated the diff for D103849: Fix undeduced type when instanciating template member.

Added test + fix suggested by @aaron.ballman

Thu, Jun 10, 9:01 AM

Wed, Jun 9

serge-sans-paille accepted D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables.

LGTM, sorry for the late review.

Wed, Jun 9, 1:43 AM
serge-sans-paille committed rG414482751452: Prevent generation of dependency on _cxa_guard for static initialization (authored by serge-sans-paille).
Prevent generation of dependency on _cxa_guard for static initialization
Wed, Jun 9, 12:40 AM
serge-sans-paille closed D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
Wed, Jun 9, 12:40 AM · Restricted Project

Tue, Jun 8

serge-sans-paille updated the diff for D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

Do not cache the (potential) function call.

Tue, Jun 8, 1:59 AM · Restricted Project

Mon, Jun 7

serge-sans-paille requested review of D103849: Fix undeduced type when instanciating template member.
Mon, Jun 7, 3:23 PM

Thu, Jun 3

serge-sans-paille added a comment to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

@kcc @eugenis : up ? I applied the patch to the Fedora package because it ruins the user experience otherwise. I think it's worth considering applying it to main too.

Thu, Jun 3, 10:16 PM · Restricted Project

Tue, May 25

serge-sans-paille added a comment to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

@kcc any thoughts on that one?

Tue, May 25, 2:56 AM · Restricted Project
serge-sans-paille updated the diff for D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
Tue, May 25, 2:46 AM · Restricted Project

Mon, May 24

serge-sans-paille added a reverting change for rGbda6e5bee04c: [NFC] remove explicit default value for strboolattr attribute in tests: rG4ab3041acbdc: Revert "[NFC] remove explicit default value for strboolattr attribute in tests".
Mon, May 24, 10:45 AM
serge-sans-paille committed rG4ab3041acbdc: Revert "[NFC] remove explicit default value for strboolattr attribute in tests" (authored by serge-sans-paille).
Revert "[NFC] remove explicit default value for strboolattr attribute in tests"
Mon, May 24, 10:45 AM
serge-sans-paille committed rGbda6e5bee04c: [NFC] remove explicit default value for strboolattr attribute in tests (authored by serge-sans-paille).
[NFC] remove explicit default value for strboolattr attribute in tests
Mon, May 24, 10:31 AM

Sat, May 22

serge-sans-paille added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
Sat, May 22, 6:06 AM · Restricted Project

Fri, May 21

serge-sans-paille added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
Fri, May 21, 12:39 AM · Restricted Project
serge-sans-paille added a reviewer for D102475: Prevent introduction of a dependency of libasan.a on libstdc++: kcc.
Fri, May 21, 12:15 AM · Restricted Project
serge-sans-paille added a comment to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

@eugenis any thought on that one? Without this patch, clang -fsanitize=address main.c fails because it needs C++ symbol.

Fri, May 21, 12:10 AM · Restricted Project

Thu, May 20

serge-sans-paille committed rG3d3abc22b3ef: Force visibility of llvm::Any to external (authored by serge-sans-paille).
Force visibility of llvm::Any to external
Thu, May 20, 1:06 AM
serge-sans-paille closed D101972: Force visibility of llvm::Any to external.
Thu, May 20, 1:06 AM · Restricted Project
serge-sans-paille updated the diff for D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

Remove clang-formatted noise

Thu, May 20, 12:52 AM · Restricted Project

Wed, May 19

serge-sans-paille added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
Wed, May 19, 4:30 AM · Restricted Project
serge-sans-paille added inline comments to D60380: Also document -arch as -arch is mac specific.
Wed, May 19, 2:27 AM · Restricted Project
serge-sans-paille added inline comments to D102707: Fix non-global-value-max-name-size not considered by LLParser.
Wed, May 19, 2:20 AM · Restricted Project

Tue, May 18

serge-sans-paille updated the diff for D101972: Force visibility of llvm::Any to external.

Patch updated with the advised comment.

Tue, May 18, 10:47 PM · Restricted Project

May 18 2021

serge-sans-paille added a comment to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

@eugenis are you fine with that change? the maintenance cost seems low, and the benefit for the end user seems valuable enough (?)

May 18 2021, 8:56 AM · Restricted Project
serge-sans-paille updated the diff for D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
May 18 2021, 8:55 AM · Restricted Project
serge-sans-paille added a comment to D99080: Normalize usage of StrBoolAttr.

@nikic here is the follow-up you were looking for

May 18 2021, 8:16 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D99080: Normalize usage of StrBoolAttr.

This change introduces a behavior change: when an attribute is not set, it used to mean `use the default value''. It now means `attribute unset''.

May 18 2021, 8:15 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D101972: Force visibility of llvm::Any to external.

@rnk: does that look like an acceptable solution to you now?

May 18 2021, 2:30 AM · Restricted Project

May 14 2021

serge-sans-paille added a comment to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

This is certainly wrong. It will happily return 1 when some other thread is changing it, and the store is non-atomic.

May 14 2021, 5:27 AM · Restricted Project
serge-sans-paille retitled D102475: Prevent introduction of a dependency of libasan.a on libstdc++ from Prevent introduction of a dependecy of libasan.a on libstdc++ to Prevent introduction of a dependency of libasan.a on libstdc++.
May 14 2021, 5:23 AM · Restricted Project
serge-sans-paille requested review of D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
May 14 2021, 2:59 AM · Restricted Project
serge-sans-paille added a comment to D99080: Normalize usage of StrBoolAttr.

It would be ideal to drop these llc flags completely, and adjust the tests that use them to use FMF flags. I don't think they serve any purpose apart from making bad tests simpler to write.

Agree. IIUC, we can do that part now without waiting for the next question to be resolved...

May 14 2021, 2:34 AM · Restricted Project, Restricted Project

May 13 2021

serge-sans-paille committed rG6045cb89e5e8: Use an allow list on reserved macro identifiers (authored by serge-sans-paille).
Use an allow list on reserved macro identifiers
May 13 2021, 12:24 AM
serge-sans-paille closed D102168: Use an allow list on reserved macro identifiers.
May 13 2021, 12:24 AM · Restricted Project

May 12 2021

serge-sans-paille updated the diff for D101972: Force visibility of llvm::Any to external.
May 12 2021, 1:57 PM · Restricted Project
serge-sans-paille updated the diff for D101972: Force visibility of llvm::Any to external.

I've successfully tested that one and it works fine.

May 12 2021, 1:56 PM · Restricted Project
serge-sans-paille added a comment to D101972: Force visibility of llvm::Any to external.

cc @tstellar I went ahead and ran a validation : these three symbols seems to be enough.

May 12 2021, 12:11 PM · Restricted Project
serge-sans-paille added a comment to D101972: Force visibility of llvm::Any to external.

@rnk, let me double check that.

May 12 2021, 10:56 AM · Restricted Project
serge-sans-paille added a comment to D101972: Force visibility of llvm::Any to external.

@dcavalca can you confirm this fixes your issue?

May 12 2021, 10:41 AM · Restricted Project
serge-sans-paille updated the diff for D102168: Use an allow list on reserved macro identifiers.
May 12 2021, 8:44 AM · Restricted Project
serge-sans-paille updated the diff for D102168: Use an allow list on reserved macro identifiers.

Minor nits as suggested by reviewers + extend the list.

May 12 2021, 7:59 AM · Restricted Project
serge-sans-paille added a comment to D101972: Force visibility of llvm::Any to external.

@dcavalca can you confirm this fixes your issue?

May 12 2021, 5:48 AM · Restricted Project
serge-sans-paille updated the diff for D101972: Force visibility of llvm::Any to external.

Force external visibilty on a limited set of symbols

May 12 2021, 5:47 AM · Restricted Project

May 11 2021

serge-sans-paille added a comment to D101972: Force visibility of llvm::Any to external.

@rnk setting the whole class as external is the less intrusive patch and I've tested it successfully. Maybe it's enough to set the default visibility to id() and template <typename T> const char Any::TypeId<T>::Id = 0 ?

May 11 2021, 11:53 AM · Restricted Project
serge-sans-paille updated the diff for D101972: Force visibility of llvm::Any to external.
May 11 2021, 11:49 AM · Restricted Project

May 10 2021

serge-sans-paille added inline comments to D100645: Sanitizer built against glibc 2.34 doesn't work.
May 10 2021, 1:31 PM · Restricted Project
serge-sans-paille committed rG91a919e8994a: [NFC] Synchronize reserved identifier code between macro and variables / symbols (authored by serge-sans-paille).
[NFC] Synchronize reserved identifier code between macro and variables / symbols
May 10 2021, 8:47 AM
serge-sans-paille closed D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols.
May 10 2021, 8:47 AM · Restricted Project
serge-sans-paille requested review of D102168: Use an allow list on reserved macro identifiers.
May 10 2021, 7:10 AM · Restricted Project
serge-sans-paille requested review of D102164: [NFC] Syndicate reserved identifier code between macro and variables / symbols.
May 10 2021, 6:00 AM · Restricted Project

May 6 2021

serge-sans-paille added a comment to D101972: Force visibility of llvm::Any to external.

This is what libcxx does for std::any when rti is not available.

May 6 2021, 10:08 PM · Restricted Project
serge-sans-paille added a comment to D101972: Force visibility of llvm::Any to external.

@rnk it's used in the newPassManager. forcing the visibility of llvm::Any indeed fixes the bug I met (that was my original patch), but I also understand the concern of @tstellar concerning the possibility of having similar issue across the code base. A possible way to solve the issue the hard way would be to design a clang warning / a static analysis that spots this kind of issues. Thinking of it, maybe the check could be done at link time to, or on the final shared library?

May 6 2021, 12:40 PM · Restricted Project

May 5 2021

serge-sans-paille added reviewers for D101972: Force visibility of llvm::Any to external: tstellar, sylvestre.ledru.
May 5 2021, 10:16 PM · Restricted Project
serge-sans-paille requested review of D101972: Force visibility of llvm::Any to external.
May 5 2021, 10:15 PM · Restricted Project

May 4 2021

serge-sans-paille committed rGb83b23275b74: Introduce -Wreserved-identifier (authored by serge-sans-paille).
Introduce -Wreserved-identifier
May 4 2021, 2:21 AM
serge-sans-paille closed D93095: Introduce -Wreserved-identifier.
May 4 2021, 2:20 AM · Restricted Project

Apr 30 2021

serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Take into account latest reviews

Apr 30 2021, 5:28 AM · Restricted Project

Apr 29 2021

serge-sans-paille added a comment to D99080: Normalize usage of StrBoolAttr.

Should this one be abandoned now?

Apr 29 2021, 12:41 AM · Restricted Project, Restricted Project

Apr 22 2021

serge-sans-paille added inline comments to D99299: Normalize interaction with boolean attributes.
Apr 22 2021, 1:16 AM · Restricted Project, Restricted Project

Apr 20 2021

serge-sans-paille committed rGd9806334d1a4: Use SmallVector instead of std::vector to manage storage of llvm::BitVector (authored by serge-sans-paille).
Use SmallVector instead of std::vector to manage storage of llvm::BitVector
Apr 20 2021, 10:33 PM
serge-sans-paille closed D100744: Use SmallVector instead of std::vector to manage storage of llvm::BitVector.
Apr 20 2021, 10:33 PM · Restricted Project

Apr 19 2021

serge-sans-paille added a comment to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

@rnk I don't want that patch to bitrot , as it addresses a defect in _FORTIFY_SOURCE, i.e. it fills an (arguably small) security defect. Can you please have a look?

Apr 19 2021, 1:56 AM · Restricted Project
serge-sans-paille requested review of D100744: Use SmallVector instead of std::vector to manage storage of llvm::BitVector.
Apr 19 2021, 1:46 AM · Restricted Project

Apr 16 2021

serge-sans-paille committed rGd6de1e1a7140: Normalize interaction with boolean attributes (authored by serge-sans-paille).
Normalize interaction with boolean attributes
Apr 16 2021, 11:18 PM
serge-sans-paille closed D99299: Normalize interaction with boolean attributes.
Apr 16 2021, 11:17 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG550ed575cbbd: Simplify BitVector code (authored by serge-sans-paille).
Simplify BitVector code
Apr 16 2021, 1:49 PM

Apr 15 2021

serge-sans-paille added a comment to D100387: Simplify BitVector code.

@saugustine thanks for the revert. I'll investigate that.
@thakis I checked the instruction count and overall execution time and didn't notice much change.
@dexonsmith Yeah that was the plan: switch to SmallVector once that one, hum, validates ;-)

Apr 15 2021, 4:46 AM · Restricted Project

Apr 14 2021

serge-sans-paille committed rG82f0e3d3ea6b: Simplify BitVector code (authored by serge-sans-paille).
Simplify BitVector code
Apr 14 2021, 12:29 PM
serge-sans-paille closed D100387: Simplify BitVector code.
Apr 14 2021, 12:29 PM · Restricted Project

Apr 13 2021

serge-sans-paille updated the diff for D100387: Simplify BitVector code.

Take review into account.

Apr 13 2021, 2:03 PM · Restricted Project
serge-sans-paille added inline comments to D99299: Normalize interaction with boolean attributes.
Apr 13 2021, 1:22 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D99299: Normalize interaction with boolean attributes.

Fix and test verifier

Apr 13 2021, 1:17 PM · Restricted Project, Restricted Project
serge-sans-paille requested review of D100387: Simplify BitVector code.
Apr 13 2021, 7:34 AM · Restricted Project

Apr 8 2021

serge-sans-paille updated the diff for D99299: Normalize interaction with boolean attributes.

Add verifier step

Apr 8 2021, 12:39 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG9229465bad85: [NFC] Fix warning introduced in 20105b6b4874a85813f7a4a3d8ad2a0f023dda14 (authored by serge-sans-paille).
[NFC] Fix warning introduced in 20105b6b4874a85813f7a4a3d8ad2a0f023dda14
Apr 8 2021, 7:11 AM
serge-sans-paille added a comment to D99299: Normalize interaction with boolean attributes.

As you are now asserting that only certain values are allowed, I believe you also need to add a verifier check that checks this. It should not be possible to assert using a valid module.

Apr 8 2021, 1:50 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG20105b6b4874: [clang] Speedup line offset mapping computation (authored by serge-sans-paille).
[clang] Speedup line offset mapping computation
Apr 8 2021, 1:12 AM

Apr 7 2021

serge-sans-paille added inline comments to D99409: [clang] Speedup line offset mapping computation.
Apr 7 2021, 9:48 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D99409: [clang] Speedup line offset mapping computation.

Thanks @thakis, inestigating the issue is likely to take some time as it seems to be arch or system dependent

Apr 7 2021, 7:19 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG6951b72334bb: [clang] Speedup line offset mapping computation (authored by serge-sans-paille).
[clang] Speedup line offset mapping computation
Apr 7 2021, 5:10 AM
serge-sans-paille closed D99409: [clang] Speedup line offset mapping computation.
Apr 7 2021, 5:10 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D98405: [cmake] Link to libnetwork on Haiku in llvm-jitlink.

You may need to do the same change in llvm/tools/llvm-jitlink/CMakeLists.txt, which makes me think it may valuable to implement a decent check à la autoconf to check for the actual symbol you're looking for, probably based on a sequence of CHECK_LIBRARY_EXISTS. Would you be ok to do that change?

Apr 7 2021, 2:38 AM · Restricted Project
serge-sans-paille added a comment to D60380: Also document -arch as -arch is mac specific.

Reading through the source, it's relatively clear that -arch is specific to the Mach0 format, but -target seems applicable to OSX too, see https://godbolt.org/z/j8jvjbo84

Apr 7 2021, 2:28 AM · Restricted Project
serge-sans-paille added a comment to D99299: Normalize interaction with boolean attributes.

@nikic gentle ping ;-)

Apr 7 2021, 2:18 AM · Restricted Project, Restricted Project
serge-sans-paille accepted D100021: cmake: Remove unused property on some targets: LLVM_LINK_LIBS.

git grep confirmed!

Apr 7 2021, 1:41 AM · Restricted Project

Apr 6 2021

serge-sans-paille updated the diff for D99409: [clang] Speedup line offset mapping computation.

Take @MaskRay comments into account

Apr 6 2021, 11:39 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D99409: [clang] Speedup line offset mapping computation.

Fix handling of final character

Apr 6 2021, 8:49 AM · Restricted Project, Restricted Project
serge-sans-paille accepted D99715: [CMake] Fix Python 3 lookup when building LLVM with tests.

LGTM, thanks!

Apr 6 2021, 2:48 AM · Restricted Project

Apr 5 2021

serge-sans-paille updated the diff for D99409: [clang] Speedup line offset mapping computation.

After a great deal of benchmarking on different architectures, I finally settled for the bithack version, as advised by @lattner . The usage of llvm::countTrailingZeros makes the implementation faster than the previous version and it's easier to read.

Apr 5 2021, 11:33 PM · Restricted Project, Restricted Project

Apr 3 2021

serge-sans-paille added a comment to D99409: [clang] Speedup line offset mapping computation.

For complentess, I must mention another optimization: run a first memchr(Buf, BufLen, '\r') and if it finds nothing, use a fast path. That brings interesting speedup for the ref and seq version, but not for the SSE one. And it makes the code more difficult to read.

Apr 3 2021, 1:57 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D99409: [clang] Speedup line offset mapping computation.

Thanks @lattner for the feedback. I wasn't super happy with the stability of the performance, so I isolated the function in a standalone file, and benchmarked several implementations. All the sources are available there: https://github.com/serge-sans-paille/mapping-line-to-offset

Apr 3 2021, 12:56 PM · Restricted Project, Restricted Project