Page MenuHomePhabricator

serge-sans-paille (serge)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2016, 10:44 AM (205 w, 6 d)

Recent Activity

Fri, Sep 18

serge-sans-paille added a comment to D84419: Fix interaction between stack alignment and inline-asm stack clash protection.

Gentle ping :-)

Fri, Sep 18, 11:11 PM · Restricted Project
serge-sans-paille updated the diff for D87758: Provide a hook to customize missing library error handling.

Minor review update

Fri, Sep 18, 11:09 PM
serge-sans-paille updated the diff for D87758: Provide a hook to customize missing library error handling.

Address reviews, taking the « extend error function » path.

Fri, Sep 18, 11:08 PM
serge-sans-paille requested review of D87893: [flang] Make flang build compatible with LLVM dylib.
Fri, Sep 18, 2:14 AM
serge-sans-paille requested review of D87892: [flang] Do not dereference an array out of bound just to take its address.
Fri, Sep 18, 2:06 AM

Thu, Sep 17

serge-sans-paille updated the diff for D87758: Provide a hook to customize missing library error handling.

Add an extra argument to the script call, to allow for future extensions, as suggested in https://sourceware.org/bugzilla/show_bug.cgi?id=26626

Thu, Sep 17, 5:27 AM

Wed, Sep 16

serge-sans-paille added a comment to D87758: Provide a hook to customize missing library error handling.

For reference, cross posted to https://sourceware.org/bugzilla/show_bug.cgi?id=26626

Wed, Sep 16, 6:10 AM
serge-sans-paille requested review of D87758: Provide a hook to customize missing library error handling.
Wed, Sep 16, 6:09 AM

Tue, Sep 15

serge-sans-paille committed rGe15996b5c6e9: [doc] Fix broken link (authored by Han Seoul-Oh <laughinghan@gmail.com>).
[doc] Fix broken link
Tue, Sep 15, 12:58 AM

Thu, Sep 10

serge-sans-paille committed rG875b8537eea0: [clang-tidy] Fix reST syntax (authored by serge-sans-paille).
[clang-tidy] Fix reST syntax
Thu, Sep 10, 4:57 AM

Wed, Sep 9

serge-sans-paille accepted D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.

LGTM

Wed, Sep 9, 1:52 AM · Restricted Project

Tue, Sep 8

serge-sans-paille added a comment to D85011: Correctly report error when interceptor points at an unlinked symbol.

Thanks for the recap, that's a very clarifying one.

Tue, Sep 8, 12:58 PM
serge-sans-paille committed rG38778e1087b2: Provide anchor for compiler extensions (authored by serge-sans-paille).
Provide anchor for compiler extensions
Tue, Sep 8, 1:35 AM

Mon, Sep 7

serge-sans-paille added a comment to D83984: Explicitly use utf-8 in send_string.

Commited on your behalf using what I expect to be your official email address :-)

Mon, Sep 7, 12:43 AM · Restricted Project
serge-sans-paille committed rGb3205e2ace43: [scan-view] Explicitly use utf-8 in send_string (authored by Tomas Rix <trix@juniper.net>).
[scan-view] Explicitly use utf-8 in send_string
Mon, Sep 7, 12:31 AM
serge-sans-paille closed D83984: Explicitly use utf-8 in send_string.
Mon, Sep 7, 12:31 AM · Restricted Project
serge-sans-paille added a comment to D85011: Correctly report error when interceptor points at an unlinked symbol.

Thanks for the rely!

Mon, Sep 7, 12:09 AM

Fri, Sep 4

serge-sans-paille committed rG3a6f3fc16039: Fix return status of SimplifyCFG (authored by serge-sans-paille).
Fix return status of SimplifyCFG
Fri, Sep 4, 10:55 PM
serge-sans-paille closed D87142: Fix return status of SimplifyCFG.
Fri, Sep 4, 10:54 PM · Restricted Project
serge-sans-paille updated the diff for D87142: Fix return status of SimplifyCFG.

Test case added

Fri, Sep 4, 1:24 PM · Restricted Project
serge-sans-paille added a comment to D87142: Fix return status of SimplifyCFG.

This fixes this build: https://firefox-ci-tc.services.mozilla.com/tasks/HwRa82dySq2_04Qth6nPQQ/runs/0/logs/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FHwRa82dySq2_04Qth6nPQQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log

Fri, Sep 4, 6:43 AM · Restricted Project
serge-sans-paille requested review of D87142: Fix return status of SimplifyCFG.
Fri, Sep 4, 6:42 AM · Restricted Project

Wed, Sep 2

serge-sans-paille updated the diff for D84419: Fix interaction between stack alignment and inline-asm stack clash protection.

Perform masking and probing in the same location to nicely handle all combination of small/large alloc and small/large align

Wed, Sep 2, 11:17 AM · Restricted Project
serge-sans-paille updated the diff for D84419: Fix interaction between stack alignment and inline-asm stack clash protection.

Take into account @cuviper review, split handling of alignment between three cases:

Wed, Sep 2, 7:12 AM · Restricted Project

Tue, Sep 1

serge-sans-paille added a reviewer for D85011: Correctly report error when interceptor points at an unlinked symbol: guiand.
Tue, Sep 1, 6:33 AM
serge-sans-paille updated subscribers of D67258: Out-of-tree machine IR passes.

This all LGTM, but I'd like an other eye on it. Maybe @Meinersbur ?

Tue, Sep 1, 1:09 AM · Restricted Project

Mon, Aug 31

serge-sans-paille accepted D83984: Explicitly use utf-8 in send_string.

LGTM then :-)

Mon, Aug 31, 11:10 PM · Restricted Project

Fri, Aug 28

serge-sans-paille committed rG229618218152: Skip analysis re-computation when no changes are reported (authored by serge-sans-paille).
Skip analysis re-computation when no changes are reported
Fri, Aug 28, 12:41 PM
serge-sans-paille closed D86442: Skip analysis re-computation when no changes are reported.
Fri, Aug 28, 12:41 PM · Restricted Project
serge-sans-paille updated the diff for D86442: Skip analysis re-computation when no changes are reported.

Rebase

Fri, Aug 28, 1:30 AM · Restricted Project

Thu, Aug 27

serge-sans-paille committed rGb1f4e5979b74: (Expensive) Check for Loop, SCC and Region pass return status (authored by serge-sans-paille).
(Expensive) Check for Loop, SCC and Region pass return status
Thu, Aug 27, 10:57 PM
serge-sans-paille closed D86589: (Expensive) Check for Loop, SCC and Region pass return status.
Thu, Aug 27, 10:56 PM · Restricted Project
serge-sans-paille updated the diff for D86589: (Expensive) Check for Loop, SCC and Region pass return status.

Take into account @nikic review.

Thu, Aug 27, 1:38 PM · Restricted Project
serge-sans-paille updated the diff for D86589: (Expensive) Check for Loop, SCC and Region pass return status.

Take review into account

Thu, Aug 27, 9:00 AM · Restricted Project
serge-sans-paille committed rG4e29d2566941: Fix OpenMP deduplicateRuntimeCalls return status (authored by serge-sans-paille).
Fix OpenMP deduplicateRuntimeCalls return status
Thu, Aug 27, 6:01 AM
serge-sans-paille committed rG5621571fc7fc: Fix Attributor return status (authored by serge-sans-paille).
Fix Attributor return status
Thu, Aug 27, 6:01 AM
serge-sans-paille closed D86705: Fix OpenMP deduplicateRuntimeCalls return status.
Thu, Aug 27, 6:01 AM · Restricted Project
serge-sans-paille closed D86703: Fix Attributor return status.
Thu, Aug 27, 6:01 AM · Restricted Project
serge-sans-paille requested review of D86705: Fix OpenMP deduplicateRuntimeCalls return status.
Thu, Aug 27, 5:40 AM · Restricted Project
serge-sans-paille requested review of D86703: Fix Attributor return status.
Thu, Aug 27, 5:39 AM · Restricted Project

Wed, Aug 26

serge-sans-paille committed rG294e1900f281: Fix quiet mode in git-clang-format (authored by Gvald).
Fix quiet mode in git-clang-format
Wed, Aug 26, 9:17 AM
serge-sans-paille closed D85485: Fix quiet mode in git-clang-format.
Wed, Aug 26, 9:17 AM · Restricted Project, Restricted Project

Tue, Aug 25

serge-sans-paille requested review of D86589: (Expensive) Check for Loop, SCC and Region pass return status.
Tue, Aug 25, 10:44 PM · Restricted Project
serge-sans-paille added a comment to D86442: Skip analysis re-computation when no changes are reported.

Looks good, but do we also need an equivalent of D80916 to check that passes are reporting "changed" correctly?

Tue, Aug 25, 10:39 PM · Restricted Project
serge-sans-paille added a comment to D85485: Fix quiet mode in git-clang-format.

I'll need a contact email to preserve authorship information, can you send me one at sguelton@redhat.com? Thanks!

Tue, Aug 25, 1:40 PM · Restricted Project, Restricted Project
serge-sans-paille accepted D85485: Fix quiet mode in git-clang-format.

Sure, thanks for your patience!

Tue, Aug 25, 1:25 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D86442: Skip analysis re-computation when no changes are reported.

Take review into account.

Tue, Aug 25, 12:31 AM · Restricted Project

Mon, Aug 24

serge-sans-paille added a comment to D86442: Skip analysis re-computation when no changes are reported.

@nikic I'm curious about any binary/compilation time change?

Mon, Aug 24, 3:28 AM · Restricted Project
serge-sans-paille requested review of D86442: Skip analysis re-computation when no changes are reported.
Mon, Aug 24, 3:28 AM · Restricted Project
serge-sans-paille added inline comments to D80707: [legacyPM] Do not compute preserved analysis if there's no local change.
Mon, Aug 24, 1:35 AM · Restricted Project

Aug 8 2020

serge-sans-paille added a comment to D85299: [llvm] Support autoloading vendor-defined plugins.

I have some difficulties to understand the exact scenario: if one knows at compile-time that polly is needed, why no just build it as a linked-in plugin, as suggested by @Meinersbur?
If one wants to specify a list of auto-loaded plugins at runtime, there's already several ways to do so, either through the C++ API or through CLI.

Aug 8 2020, 5:48 AM · Restricted Project

Aug 7 2020

serge-sans-paille accepted D85485: Fix quiet mode in git-clang-format.
Aug 7 2020, 1:55 AM · Restricted Project, Restricted Project

Jul 31 2020

serge-sans-paille accepted D83411: Use md5 -q for HashProgramOutput.sh, to show only the checksum..
Jul 31 2020, 9:02 AM
serge-sans-paille updated the diff for D84419: Fix interaction between stack alignment and inline-asm stack clash protection.

Added test case for large stack align

Jul 31 2020, 9:02 AM · Restricted Project
serge-sans-paille added inline comments to D83411: Use md5 -q for HashProgramOutput.sh, to show only the checksum..
Jul 31 2020, 5:45 AM
serge-sans-paille requested review of D85011: Correctly report error when interceptor points at an unlinked symbol.
Jul 31 2020, 2:04 AM
serge-sans-paille added inline comments to D83411: Use md5 -q for HashProgramOutput.sh, to show only the checksum..
Jul 31 2020, 1:57 AM
serge-sans-paille added a comment to D83984: Explicitly use utf-8 in send_string.

According to the doc, 'utf-8' is already the default encoding, at least on py3, but not on py2. i guess that the problem you're trying to fix?

Jul 31 2020, 1:53 AM · Restricted Project

Jul 28 2020

serge-sans-paille committed rG3218c064d6d8: [legacyPM] Do not compute preserved analysis if there's no local change (authored by serge-sans-paille).
[legacyPM] Do not compute preserved analysis if there's no local change
Jul 28 2020, 2:03 AM
serge-sans-paille closed D80707: [legacyPM] Do not compute preserved analysis if there's no local change.
Jul 28 2020, 2:02 AM · Restricted Project

Jul 27 2020

serge-sans-paille accepted D84686: [OldPM] Print out a bit more when passes lie about changing IR.

LGTM, that's indeed a more helpful message. Thanks!

Jul 27 2020, 1:25 PM · Restricted Project
serge-sans-paille added inline comments to D80707: [legacyPM] Do not compute preserved analysis if there's no local change.
Jul 27 2020, 8:31 AM · Restricted Project

Jul 24 2020

serge-sans-paille added a comment to D80707: [legacyPM] Do not compute preserved analysis if there's no local change.

Are you planning to pick this up again now D80916 has landed? It LGTM modulo the comments that have already been made.

Jul 24 2020, 7:13 AM · Restricted Project
serge-sans-paille added inline comments to D84419: Fix interaction between stack alignment and inline-asm stack clash protection.
Jul 24 2020, 5:00 AM · Restricted Project

Jul 23 2020

Herald added a project to D84419: Fix interaction between stack alignment and inline-asm stack clash protection: Restricted Project.
Jul 23 2020, 8:12 AM · Restricted Project

Jul 21 2020

serge-sans-paille committed rG28da5759bd5a: Fix typo in tutorial (authored by Chris Morin <chris.morin2@gmail.com>).
Fix typo in tutorial
Jul 21 2020, 8:28 AM

Jul 17 2020

serge-sans-paille accepted D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush.

LGTM, I still would appreciate @calixte feedback here.

Jul 17 2020, 1:55 AM · Restricted Project, Restricted Project, Restricted Project

Jul 16 2020

serge-sans-paille committed rG515bc8c1554f: Harmonize Python shebang (authored by serge-sans-paille).
Harmonize Python shebang
Jul 16 2020, 12:54 PM
serge-sans-paille closed D83857: Harmonize python shebang.
Jul 16 2020, 12:53 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 15 2020

serge-sans-paille added a comment to D82767: clang-format: Explicitly use python3.

My understanding is that explicitly requiring python3 may make sense if the script is not backward-compatible with python2, while requiring python means the version is not important.
At the end-of-year, we should be able to harmonize shebangs to #!/usr/bin/env python3 or #!/usr/bin/env python

Fixing this to be consistent would be an improvement

Jul 15 2020, 12:37 AM · Restricted Project
Herald added a project to D83857: Harmonize python shebang: Restricted Project.
Jul 15 2020, 12:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 14 2020

serge-sans-paille added inline comments to D80975: [SCEV][IndVarSimplify] insert point should not be block front if the front instruction is a PHI.
Jul 14 2020, 5:35 AM · Restricted Project
serge-sans-paille committed rG1cd1c1d62edc: Revert "[SCEV][IndVarSimplify] insert point should not be block front." (authored by serge-sans-paille).
Revert "[SCEV][IndVarSimplify] insert point should not be block front."
Jul 14 2020, 5:26 AM
serge-sans-paille added a reverting change for rGf1efb8bb4ba0: [SCEV][IndVarSimplify] insert point should not be block front.: rG1cd1c1d62edc: Revert "[SCEV][IndVarSimplify] insert point should not be block front.".
Jul 14 2020, 5:26 AM
serge-sans-paille committed rG3667d87a33d3: Double check that passes correctly set their Modified status (authored by serge-sans-paille).
Double check that passes correctly set their Modified status
Jul 14 2020, 1:00 AM

Jul 13 2020

serge-sans-paille committed rGb3270956e97c: Double check that passes correctly set their Modified status (authored by serge-sans-paille).
Double check that passes correctly set their Modified status
Jul 13 2020, 12:31 PM
serge-sans-paille committed rG62881fda5852: Fix HexagonGenExtract return status (authored by serge-sans-paille).
Fix HexagonGenExtract return status
Jul 13 2020, 11:43 AM
serge-sans-paille closed D83460: Fix HexagonGenExtract return statu.
Jul 13 2020, 11:42 AM · Restricted Project
serge-sans-paille added a comment to D83460: Fix HexagonGenExtract return statu.

Thanks!

Jul 13 2020, 11:40 AM · Restricted Project
serge-sans-paille added a comment to D83460: Fix HexagonGenExtract return statu.

In order to land the pass return status check before branching for LLVM-11, and given the trivial nature of that patch, I'll merge it in a day or so if there's no more activity there.

Jul 13 2020, 1:39 AM · Restricted Project

Jul 10 2020

serge-sans-paille added a comment to D83580: [lldb] on s390x fix override issue.

Possible followup: shouldn't all the other Get* be flagged as const too?

Jul 10 2020, 12:08 PM · Restricted Project
serge-sans-paille accepted D83580: [lldb] on s390x fix override issue.

Looks obviously good to me.

Jul 10 2020, 12:07 PM · Restricted Project
serge-sans-paille added a comment to D83460: Fix HexagonGenExtract return statu.

ping @kparzysz for the final review then :-)

Jul 10 2020, 9:59 AM · Restricted Project

Jul 9 2020

serge-sans-paille added a comment to D82767: clang-format: Explicitly use python3.

We may not be consistent across all of LLVM

$ find . -name '*.py' -print -exec /usr/bin/head -2 {} \; | grep "#!" | sort | uniq -c
      6 #! /usr/bin/env python
      2 #! /usr/bin/env python3
      2 #! /usr/bin/python
      1 #!/bin/env python
    133 #!/usr/bin/env python
     13 #!/usr/bin/env python3
     49 #!/usr/bin/python
Jul 9 2020, 9:15 AM · Restricted Project
serge-sans-paille added a reviewer for D82767: clang-format: Explicitly use python3: serge-sans-paille.
Jul 9 2020, 9:11 AM · Restricted Project
serge-sans-paille added a comment to D80916: [LegacyPM] Double check that passes correctly set their Modified status.

Sounds good. I can try a build on AArch64 in a bit.

Cross-compiling the test-suite for example should be relatively straight-forward, if you have a linker & libraries for the target architecture (e.g. on linux it should be easy to get the required toolchains for platforms like ARM and AArch64) https://llvm.org/docs/lnt/tests.html#cross-compiling

Jul 9 2020, 3:26 AM · Restricted Project
serge-sans-paille added a comment to D80916: [LegacyPM] Double check that passes correctly set their Modified status.

Hmm, where do other targets suffer from those errors? In the various backend pipelines/passes?

Jul 9 2020, 2:20 AM · Restricted Project
serge-sans-paille committed rGe4ec6d0afe14: Correctly update return status for MVEGatherScatterLowering (authored by serge-sans-paille).
Correctly update return status for MVEGatherScatterLowering
Jul 9 2020, 2:19 AM
serge-sans-paille closed D83459: Correctly update return status for MVEGatherScatterLowering.
Jul 9 2020, 2:19 AM · Restricted Project
serge-sans-paille committed rGa60c31fd6229: Fix return status of AtomicExpandPass (authored by serge-sans-paille).
Fix return status of AtomicExpandPass
Jul 9 2020, 1:29 AM
serge-sans-paille closed D83457: Fix return status of AtomicExpandPass.
Jul 9 2020, 1:29 AM · Restricted Project
Herald added a project to D83460: Fix HexagonGenExtract return statu: Restricted Project.
Jul 9 2020, 1:11 AM · Restricted Project
Herald added a project to D83459: Correctly update return status for MVEGatherScatterLowering: Restricted Project.
Jul 9 2020, 12:48 AM · Restricted Project
Herald added a project to D83457: Fix return status of AtomicExpandPass: Restricted Project.
Jul 9 2020, 12:39 AM · Restricted Project

Jul 8 2020

serge-sans-paille updated subscribers of D80916: [LegacyPM] Double check that passes correctly set their Modified status.

Note: I had to revert this becasue I only tested X86 targe, and other targets suffer from a lot of « don't update return status » error. cc @fhahn

Jul 8 2020, 11:50 PM · Restricted Project
serge-sans-paille committed rGbf9a940c3f1b: Revert "Double check that passes correctly set their Modified status" (authored by serge-sans-paille).
Revert "Double check that passes correctly set their Modified status"
Jul 8 2020, 9:16 AM
serge-sans-paille added a reverting change for rG37afd99c768b: Double check that passes correctly set their Modified status: rGbf9a940c3f1b: Revert "Double check that passes correctly set their Modified status".
Jul 8 2020, 9:16 AM
serge-sans-paille committed rG37afd99c768b: Double check that passes correctly set their Modified status (authored by serge-sans-paille).
Double check that passes correctly set their Modified status
Jul 8 2020, 8:36 AM
serge-sans-paille closed D80916: [LegacyPM] Double check that passes correctly set their Modified status.
Jul 8 2020, 8:36 AM · Restricted Project
serge-sans-paille updated the diff for D80916: [LegacyPM] Double check that passes correctly set their Modified status.

Take final review into account

Jul 8 2020, 5:26 AM · Restricted Project