Page MenuHomePhabricator

zixuan-wu (Zixuan Wu)
Alibaba T-HEAD LLVM Dev

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2020, 9:04 PM (43 w, 5 d)

Recent Activity

May 7 2021

zixuan-wu retitled D101027: [CSKY] Add more basic instructions including some privilege instructions from [CSKY 7/n] Add more basic instructions including some privilege instructions to [CSKY] Add more basic instructions including some privilege instructions.
May 7 2021, 7:08 PM · Restricted Project

Apr 25 2021

zixuan-wu added inline comments to D101027: [CSKY] Add more basic instructions including some privilege instructions.
Apr 25 2021, 2:49 AM · Restricted Project

Apr 22 2021

zixuan-wu added a comment to D101027: [CSKY] Add more basic instructions including some privilege instructions.

The old 7 is now 9 and there's no 8? This is confusing.

Given that we have already merged the initial part, I think you can stop numbering the patches unless they're meant as a set, which then you start from one again (ex: 1/3, 2/3, 3/3).

Normally we would have gone all the way down small programs being generated (including ALU), but we started wrong, so let's not make it more confusing. :)

However, it's still important to know which patch depends on which, so make sure to still mark the parent/child dependencies correctly.

Apr 22 2021, 11:27 PM · Restricted Project
zixuan-wu retitled D95030: [CSKY 9/n] Initial codegen support for ALU operations from [CSKY 7/n] Initial codegen support for ALU operations to [CSKY 9/n] Initial codegen support for ALU operations.
Apr 22 2021, 1:23 AM · Restricted Project
zixuan-wu requested review of D101027: [CSKY] Add more basic instructions including some privilege instructions.
Apr 22 2021, 1:23 AM · Restricted Project

Apr 20 2021

zixuan-wu requested review of D100926: [test-suite] Add C-SKY Support in benchmark 1.3.0.
Apr 20 2021, 11:48 PM
zixuan-wu added a reviewer for D100924: [test-suite][CSKY] Add Architecture Detection for C-SKY: jmolloy.
Apr 20 2021, 11:34 PM
zixuan-wu updated the diff for D100924: [test-suite][CSKY] Add Architecture Detection for C-SKY.
Apr 20 2021, 11:34 PM
zixuan-wu requested review of D100924: [test-suite][CSKY] Add Architecture Detection for C-SKY.
Apr 20 2021, 11:33 PM
zixuan-wu committed rGca31b43ae8df: [NFC][CSKY] Resort the instruction description in td (authored by zixuan-wu).
[NFC][CSKY] Resort the instruction description in td
Apr 20 2021, 9:37 PM
zixuan-wu committed rG4bb60c285cb3: [CSKY 6/n] Add support branch and symbol series instruction (authored by zixuan-wu).
[CSKY 6/n] Add support branch and symbol series instruction
Apr 20 2021, 12:39 AM
zixuan-wu committed rG4216389c2653: [CSKY 5/n] Add support for all CSKY basic integer instructions except for… (authored by zixuan-wu).
[CSKY 5/n] Add support for all CSKY basic integer instructions except for…
Apr 20 2021, 12:39 AM
zixuan-wu committed rG8ba622bae114: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter (authored by zixuan-wu).
[CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter
Apr 20 2021, 12:39 AM
zixuan-wu closed D95029: [CSKY 6/n] Add support branch and symbol series instruction.
Apr 20 2021, 12:38 AM · Restricted Project
zixuan-wu closed D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series.
Apr 20 2021, 12:38 AM · Restricted Project
zixuan-wu closed D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.
Apr 20 2021, 12:38 AM · Restricted Project

Apr 19 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Hi, it seems you have addressed all review comments, so this looks good to me. Thanks for all the work, and sorry it took so long.

Apr 19 2021, 11:00 PM · Restricted Project

Apr 18 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Could you please also accept this revision and D95029?

Hadn't noticed you had updated, sorry. Approved now.

Apr 18 2021, 7:39 PM · Restricted Project
zixuan-wu added a comment to D95029: [CSKY 6/n] Add support branch and symbol series instruction.

Sorry, you haven't said anything about the comments, I didn't know you had updated the patch to address them.

Phab isn't great at communication, so when you do address all comments, a simple line saying "addressing all comments" helps us know that we should look at it again.

Anyway, LGTM, thanks!

Apr 18 2021, 7:37 PM · Restricted Project

Apr 15 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Yep, but I was gonna make D95030 as next set of patches to handle dag codegen.

Fair enough, though that patch is probably good to go, too, with a few nits sorted.

Apr 15 2021, 11:20 PM · Restricted Project

Apr 14 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.
Apr 14 2021, 7:31 PM · Restricted Project
zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

D93798, D94007 and D95029 are the first set of patches to review and commit together. Please have a review together, thanks.

Apr 14 2021, 2:02 AM · Restricted Project
zixuan-wu updated the diff for D95029: [CSKY 6/n] Add support branch and symbol series instruction.
Apr 14 2021, 1:59 AM · Restricted Project

Apr 13 2021

zixuan-wu updated the diff for D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series.
Apr 13 2021, 11:39 PM · Restricted Project
zixuan-wu updated the diff for D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series.
Apr 13 2021, 11:01 PM · Restricted Project
zixuan-wu added inline comments to D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series.
Apr 13 2021, 10:31 PM · Restricted Project

Apr 12 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

ping..

Apr 12 2021, 6:55 PM · Restricted Project

Apr 1 2021

zixuan-wu updated the diff for D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.
Apr 1 2021, 11:13 PM · Restricted Project
zixuan-wu added inline comments to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.
Apr 1 2021, 10:22 PM · Restricted Project
zixuan-wu abandoned D86269: [RFC][Target] Add a new backend target called CSKY.
Apr 1 2021, 8:08 PM · Restricted Project

Jan 24 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

anymore comments or LGTM?

Jan 24 2021, 6:28 PM · Restricted Project

Jan 21 2021

zixuan-wu added inline comments to D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series.
Jan 21 2021, 1:08 AM · Restricted Project
zixuan-wu updated the diff for D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Address comments.

Jan 21 2021, 1:05 AM · Restricted Project

Jan 20 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Hi Zixuan,

I'm still worried about the n in 4/n and 5/n. I know these are not the final patches of the back-end, but we need a minimal structure of the first batch, just like we have for m68k at the moment.

Can you isolate a first batch of patches that'd make the CSKY back-end generate ASM code for some basic code generation example (like foo(a, b) { return a+b })?

Those would be a first import, and will give reviewers the chance to understand your whole approach, not only one step into the future.

I think this is what's keeping people from reviewing your patches...

cheers,
--renato

Jan 20 2021, 2:54 AM · Restricted Project
zixuan-wu requested review of D95030: [CSKY 9/n] Initial codegen support for ALU operations.
Jan 20 2021, 2:49 AM · Restricted Project
zixuan-wu requested review of D95029: [CSKY 6/n] Add support branch and symbol series instruction.
Jan 20 2021, 2:46 AM · Restricted Project

Jan 19 2021

zixuan-wu updated the diff for D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.
Jan 19 2021, 2:06 AM · Restricted Project

Jan 18 2021

zixuan-wu added a comment to D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series.

ping...

Jan 18 2021, 1:12 AM · Restricted Project

Jan 11 2021

zixuan-wu added inline comments to D88466: [CSKY 1/n] Add basic stub or infra of csky backend.
Jan 11 2021, 12:27 AM · Restricted Project
zixuan-wu committed rGcddd3faf5deb: [CSKY] Add visibility macro to fix link error (authored by zixuan-wu).
[CSKY] Add visibility macro to fix link error
Jan 11 2021, 12:25 AM

Jan 10 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

ping..

Jan 10 2021, 6:22 PM · Restricted Project

Jan 4 2021

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

could anybody review this patch and https://reviews.llvm.org/D94007? Gentle ping..

Jan 4 2021, 7:55 PM · Restricted Project
zixuan-wu requested review of D94007: [CSKY 5/n] Add support for all CSKY basic integer instructions except for branch series.
Jan 4 2021, 12:17 AM · Restricted Project

Dec 30 2020

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Yes, I agree with it's not a right vs wrong problem.

Dec 30 2020, 7:14 PM · Restricted Project

Dec 29 2020

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

I don't think too many patches on the fly is good to upstream because they influence each other and need change on the way of review.

@MaskRay is right. Even though they do affect each other and you have to do a bit more work in refactoring them, it's a lot easier to see he effect of the early decisions on your patches on the later stages.

So far in CSKY, I have been looking at stubs and they don't look "wrong" but they also don't tell me anything about the future decisions.

You could probably compare the amount of work you do initially on a multi-patch approach with a similar amount with post-merge fixes and local refactoring.

The m64k is a good example on the benefits of having such approach, as we have already avoided some mistakes from happening in the first place.

Dec 29 2020, 7:16 PM · Restricted Project

Dec 28 2020

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

I think the M68k has a lot which can be learned by other experimental targets. The author posted the patch series all together (1) so reviewers can review each individual patch separately and suggest code motion among patches. (2) The author shared updates on llvm-dev.

For example, if this patch were in part of a patch series, the back-and-forth style change def : ProcessorModel<"generic-csky", NoSchedModel, []>; (generic-csky->generic) could be caught earlier.

Dec 28 2020, 6:28 PM · Restricted Project

Dec 27 2020

zixuan-wu added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Gentle pin..

Dec 27 2020, 8:31 PM · Restricted Project

Dec 24 2020

zixuan-wu requested review of D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.
Dec 24 2020, 1:40 AM · Restricted Project

Dec 21 2020

zixuan-wu committed rGec17c4f0755b: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc (authored by zixuan-wu).
[CSKY 3/n] Add bare-bones C-SKY MCTargetDesc
Dec 21 2020, 7:44 PM
zixuan-wu closed D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.
Dec 21 2020, 7:44 PM · Restricted Project
zixuan-wu added inline comments to D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.
Dec 21 2020, 6:49 PM · Restricted Project
zixuan-wu updated the diff for D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.

Address comments.

Dec 21 2020, 6:48 PM · Restricted Project

Dec 20 2020

zixuan-wu added a comment to D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.

Is it good to anybody to LGTM?

Dec 20 2020, 6:46 PM · Restricted Project

Dec 17 2020

zixuan-wu updated the diff for D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.

Address comments.

Dec 17 2020, 7:27 PM · Restricted Project
zixuan-wu added inline comments to D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.
Dec 17 2020, 7:25 PM · Restricted Project
zixuan-wu added inline comments to D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.
Dec 17 2020, 12:10 AM · Restricted Project

Dec 16 2020

zixuan-wu added a reviewer for D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc: MaskRay.
Dec 16 2020, 6:25 PM · Restricted Project

Dec 15 2020

zixuan-wu requested review of D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.
Dec 15 2020, 10:50 PM · Restricted Project

Dec 8 2020

zixuan-wu added a comment to D88391: [M68k] (Patch 5/8) Target lowering.

It would be so nice if we could start all new targets with support for Global ISel instead...

Yeah GlobalISel is definitely in our backlog/TODOs :-) And I think @RKSimon is right, GlobalISel doesn't support big-endian at this time point.

Dec 8 2020, 11:46 PM · Restricted Project

Dec 6 2020

zixuan-wu committed rG365c40541146: [CSKY 2/n] Add basic tablegen infra for CSKY (authored by zixuan-wu).
[CSKY 2/n] Add basic tablegen infra for CSKY
Dec 6 2020, 8:03 PM
zixuan-wu closed D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.
Dec 6 2020, 8:02 PM · Restricted Project

Nov 30 2020

zixuan-wu added a comment to D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

I can't possibly comment on the ISA implementation, but this looks like a standard table-gen set of files to me. They also don't affect anything else outside of CSKY, so LGTM.

It would be nice to have more reviews for the CSKY back-end. Feel free to add me as a reviewer on others and I'll do my best to help.

Nov 30 2020, 8:04 PM · Restricted Project

Nov 29 2020

zixuan-wu added a comment to D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

Gentle ping.

Nov 29 2020, 7:14 PM · Restricted Project

Nov 19 2020

zixuan-wu added a comment to D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

Thank you for your review. @myhsu

Nov 19 2020, 1:11 AM · Restricted Project
zixuan-wu updated the diff for D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

Address comments

Nov 19 2020, 1:09 AM · Restricted Project

Nov 16 2020

zixuan-wu added reviewers for D89180: [CSKY 2/n] Add basic tablegen infra for CSKY: glaubitz, rengolin, myhsu.
Nov 16 2020, 10:42 PM · Restricted Project

Nov 9 2020

zixuan-wu added a comment to D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

Gentle ping..

Nov 9 2020, 12:26 AM · Restricted Project

Nov 8 2020

zixuan-wu added reviewers for D89180: [CSKY 2/n] Add basic tablegen infra for CSKY: reames, asb.
Nov 8 2020, 11:25 PM · Restricted Project

Nov 2 2020

zixuan-wu added a comment to D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

@theraven Would you like to review it as following?

Nov 2 2020, 2:09 AM · Restricted Project

Oct 27 2020

zixuan-wu updated the diff for D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.
Oct 27 2020, 9:33 PM · Restricted Project

Oct 26 2020

zixuan-wu added a comment to D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

Gentle ping.

Oct 26 2020, 7:53 PM · Restricted Project
zixuan-wu updated the diff for D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.
Oct 26 2020, 7:53 PM · Restricted Project

Oct 12 2020

zixuan-wu added a comment to D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

Ping...

Oct 12 2020, 7:12 PM · Restricted Project

Oct 10 2020

zixuan-wu requested review of D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.
Oct 10 2020, 12:08 AM · Restricted Project

Oct 9 2020

zixuan-wu committed rGe1c38dd55d9d: [CSKY 1/n] Add basic stub or infra of csky backend (authored by zixuan-wu).
[CSKY 1/n] Add basic stub or infra of csky backend
Oct 9 2020, 7:46 PM
zixuan-wu closed D88466: [CSKY 1/n] Add basic stub or infra of csky backend.
Oct 9 2020, 7:46 PM · Restricted Project
zixuan-wu updated the summary of D88466: [CSKY 1/n] Add basic stub or infra of csky backend.
Oct 9 2020, 7:44 PM · Restricted Project
zixuan-wu added a comment to D88466: [CSKY 1/n] Add basic stub or infra of csky backend.

I lost track of the mailing list discussions, but assuming that there is consensus to accept this back end I am happy with the structure of the initial code, the size of the contributed diffs, and the engagement from the maintainer.

Oct 9 2020, 7:11 PM · Restricted Project

Oct 8 2020

zixuan-wu updated the diff for D88466: [CSKY 1/n] Add basic stub or infra of csky backend.

Address comments.

Oct 8 2020, 8:57 PM · Restricted Project
zixuan-wu added a comment to D88466: [CSKY 1/n] Add basic stub or infra of csky backend.

The general process is here: https://llvm.org/docs/DeveloperPolicy.html#adding-a-new-target

I'm sorry that I'm preoccupied with the devmtg this week, but please ping me next week if you're not getting traction, thanks!

Oct 8 2020, 7:35 PM · Restricted Project

Oct 7 2020

zixuan-wu updated subscribers of D88466: [CSKY 1/n] Add basic stub or infra of csky backend.

Gentle ping...
BTW, @lattner would you know who is the decision maker that can approve a new target and review related commit?

Oct 7 2020, 9:35 PM · Restricted Project

Sep 28 2020

zixuan-wu added a comment to D86269: [RFC][Target] Add a new backend target called CSKY.

This patch is too big to review. I will imitate the RISCV upstream process like D23560 to split this patch.

Sep 28 2020, 10:06 PM · Restricted Project
zixuan-wu updated the diff for D88466: [CSKY 1/n] Add basic stub or infra of csky backend.
Sep 28 2020, 10:03 PM · Restricted Project
zixuan-wu requested review of D88466: [CSKY 1/n] Add basic stub or infra of csky backend.
Sep 28 2020, 9:52 PM · Restricted Project
zixuan-wu added a comment to D86269: [RFC][Target] Add a new backend target called CSKY.

Ping... :)

Sep 28 2020, 2:09 AM · Restricted Project

Sep 25 2020

zixuan-wu updated the diff for D86269: [RFC][Target] Add a new backend target called CSKY.
Sep 25 2020, 1:53 AM · Restricted Project
zixuan-wu added a comment to D86269: [RFC][Target] Add a new backend target called CSKY.

Thank you so much @craig.topper for your detail review comments.

Sep 25 2020, 12:54 AM · Restricted Project
zixuan-wu updated the diff for D86269: [RFC][Target] Add a new backend target called CSKY.

Address comments.

Sep 25 2020, 12:22 AM · Restricted Project

Sep 8 2020

zixuan-wu added a comment to D86269: [RFC][Target] Add a new backend target called CSKY.

gentle ping...

Sep 8 2020, 7:17 PM · Restricted Project

Sep 6 2020

zixuan-wu committed rG69f2c79f2ad2: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types (authored by zixuan-wu).
[ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types
Sep 6 2020, 8:03 PM
zixuan-wu closed D86610: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types.
Sep 6 2020, 8:02 PM · Restricted Project

Sep 3 2020

zixuan-wu added a comment to D86269: [RFC][Target] Add a new backend target called CSKY.

gentle ping...

Sep 3 2020, 7:23 PM · Restricted Project
zixuan-wu updated the diff for D86610: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types.

Address comments.

Sep 3 2020, 1:10 AM · Restricted Project

Sep 2 2020

zixuan-wu added inline comments to D86610: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types.
Sep 2 2020, 7:30 PM · Restricted Project
zixuan-wu updated the diff for D86610: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types.

Address comments.

Sep 2 2020, 3:33 AM · Restricted Project

Sep 1 2020

zixuan-wu retitled D86610: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types from [ELF] Add new EM called EM_CSKY to [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types.
Sep 1 2020, 11:22 PM · Restricted Project
zixuan-wu committed rGb21ddded8f04: [RFC][Target] Add a new triple called Triple::csky (authored by zixuan-wu).
[RFC][Target] Add a new triple called Triple::csky
Sep 1 2020, 9:47 PM
zixuan-wu closed D86505: [RFC][Target] Add a new triple called Triple::csky.
Sep 1 2020, 9:47 PM · Restricted Project
zixuan-wu retitled D86505: [RFC][Target] Add a new triple called Triple::csky from [RFC][Target] Add a new triple called CSKY to [RFC][Target] Add a new triple called Triple::csky.
Sep 1 2020, 8:37 PM · Restricted Project

Aug 30 2020

zixuan-wu added a comment to D86610: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types.

This looks good to me, but I guess the target may need an official approval (from LLVM Foundation Board of Directors?) first.

I don't think it's necessary to hold up this patch on anything like that. It would be reasonable to define the reserved enum values independently of the target

Aug 30 2020, 7:48 PM · Restricted Project