Page MenuHomePhabricator

craig.topper (Craig Topper)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2013, 7:58 PM (294 w, 1 d)

Recent Activity

Today

craig.topper committed rGb3bad3dce396: [X86] Use LoadInst->getType() instead of LoadInst->getPointerOperandType()… (authored by craig.topper).
[X86] Use LoadInst->getType() instead of LoadInst->getPointerOperandType()…
Thu, Mar 21, 2:37 PM
craig.topper committed rG7339e61b8914: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus (authored by craig.topper).
[X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus
Thu, Mar 21, 1:35 PM
craig.topper committed rG3205dbb3f1f9: [Driver] Pass -malign-double from the driver to the cc1 command line (authored by craig.topper).
[Driver] Pass -malign-double from the driver to the cc1 command line
Thu, Mar 21, 1:07 PM
craig.topper added a reviewer for D59662: [X86] Use xmm registers to implement 64-bit popcnt on 32-bit targets if possible if popcnt instruction is not available: andreadb.
Thu, Mar 21, 1:00 PM · Restricted Project
craig.topper created D59662: [X86] Use xmm registers to implement 64-bit popcnt on 32-bit targets if possible if popcnt instruction is not available.
Thu, Mar 21, 12:13 PM · Restricted Project
craig.topper committed rG16dc165046c3: [InstCombine] Don't transform ((C1 OP zext(X)) & C2) -> zext((C1 OP X) & C2) if… (authored by craig.topper).
[InstCombine] Don't transform ((C1 OP zext(X)) & C2) -> zext((C1 OP X) & C2) if…
Thu, Mar 21, 10:50 AM
craig.topper committed rG1383340422aa: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove… (authored by craig.topper).
[X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove…
Thu, Mar 21, 10:44 AM
craig.topper committed rGc14f3e42220e: [X86] Don't avoid folding multiple use sign extended 8-bit immediate into… (authored by craig.topper).
[X86] Don't avoid folding multiple use sign extended 8-bit immediate into…
Thu, Mar 21, 10:42 AM
craig.topper committed rG9f0b17a248c5: [ScalarizeMaskedMemIntrin] Add support for scalarizing expandload and… (authored by craig.topper).
[ScalarizeMaskedMemIntrin] Add support for scalarizing expandload and…
Thu, Mar 21, 10:41 AM
craig.topper committed rGf2f139e9efe5: [X86] Use the CPUKind enum from PROC_ALIAS to directly get the CPUKind in… (authored by craig.topper).
[X86] Use the CPUKind enum from PROC_ALIAS to directly get the CPUKind in…
Thu, Mar 21, 10:34 AM
craig.topper updated the diff for D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus.

Rewrite to use a "cx8" feature flag that is set for all i586 and greater CPUs as well as generic. This assumes generic is never passed in a run of clang through the driver. And anyone using -cc1 directly is unlikely to be using an i486.

Thu, Mar 21, 12:24 AM · Restricted Project, Restricted Project

Yesterday

craig.topper updated the diff for D59180: [ScalarizeMaskedMemIntrin] Add support for scalarizing expandload and compressstore intrinsics..

Rebase after precommit of NFC change. Add llc tests for existing PRs.

Wed, Mar 20, 11:13 PM · Restricted Project
craig.topper committed rG8de7bc0bff05: [ScalarizeMaskedMemIntrinsics] Reverse some if conditions to reduce… (authored by craig.topper).
[ScalarizeMaskedMemIntrinsics] Reverse some if conditions to reduce…
Wed, Mar 20, 10:54 PM
craig.topper committed rG72d888ba9f63: [InstCombine] Add test case for PR41164. NFC (authored by craig.topper).
[InstCombine] Add test case for PR41164. NFC
Wed, Mar 20, 10:32 PM
craig.topper created D59630: [InstCombine] Don't transform ((C1 OP zext(X)) & C2) -> zext((C1 OP X) & C2) if either zext or OP has another use..
Wed, Mar 20, 10:21 PM · Restricted Project
craig.topper added a comment to D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc.

IIRC we don't use libcalls for popcnt - we just expand

Wed, Mar 20, 7:45 PM · Restricted Project
craig.topper updated the diff for D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc.

Update doxygen comments

Wed, Mar 20, 7:36 PM · Restricted Project
craig.topper created D59624: [Driver] Pass -malign-double from the driver to the cc1 command line.
Wed, Mar 20, 5:47 PM · Restricted Project
craig.topper committed rG8d46403b8e13: [X86] Add CMPXCHG8B feature flag. Set it for all CPUs except i386/i486… (authored by craig.topper).
[X86] Add CMPXCHG8B feature flag. Set it for all CPUs except i386/i486…
Wed, Mar 20, 4:38 PM
craig.topper closed D59576: [X86] Add CMPXCHG8B feature flag. Set it for all CPUs except i386/i486 including 'generic'. Disable use of CMPXCHG8B when this flag isn't set..
Wed, Mar 20, 4:37 PM · Restricted Project
craig.topper added a comment to D59576: [X86] Add CMPXCHG8B feature flag. Set it for all CPUs except i386/i486 including 'generic'. Disable use of CMPXCHG8B when this flag isn't set..

Does this affect the assembler? If so, should we also have an assembler testcase?

Wed, Mar 20, 3:52 PM · Restricted Project
craig.topper committed rG03675533043d: [X86] Call lowerShuffleAsBitMask for 512-bit vectors in lowerShuffleAsBlend. (authored by craig.topper).
[X86] Call lowerShuffleAsBitMask for 512-bit vectors in lowerShuffleAsBlend.
Wed, Mar 20, 2:30 PM
craig.topper updated the diff for D59576: [X86] Add CMPXCHG8B feature flag. Set it for all CPUs except i386/i486 including 'generic'. Disable use of CMPXCHG8B when this flag isn't set..

Remove commented out code

Wed, Mar 20, 2:24 PM · Restricted Project
craig.topper committed rGe0941cb32650: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc. (authored by craig.topper).
[X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc.
Wed, Mar 20, 1:25 PM
craig.topper added inline comments to D59576: [X86] Add CMPXCHG8B feature flag. Set it for all CPUs except i386/i486 including 'generic'. Disable use of CMPXCHG8B when this flag isn't set..
Wed, Mar 20, 1:05 PM · Restricted Project
craig.topper committed rG140f766f1446: [X86] Remove getCPUKindCanonicalName which is unused. (authored by craig.topper).
[X86] Remove getCPUKindCanonicalName which is unused.
Wed, Mar 20, 10:27 AM
craig.topper committed rGdfa0fdbde0da: [X86] Separate PentiumPro and i686. They aren't aliases in the backend. (authored by craig.topper).
[X86] Separate PentiumPro and i686. They aren't aliases in the backend.
Wed, Mar 20, 12:31 AM
craig.topper created D59578: [X86] Remove getCPUKindCanonicalName which seems to be unused..
Wed, Mar 20, 12:14 AM · Restricted Project, Restricted Project

Tue, Mar 19

craig.topper created D59576: [X86] Add CMPXCHG8B feature flag. Set it for all CPUs except i386/i486 including 'generic'. Disable use of CMPXCHG8B when this flag isn't set..
Tue, Mar 19, 11:06 PM · Restricted Project
craig.topper committed rGfda1f96d28bc: [X86] Remove X32 check lines from a test that doesn't have an X32 FileCheck… (authored by craig.topper).
[X86] Remove X32 check lines from a test that doesn't have an X32 FileCheck…
Tue, Mar 19, 8:14 PM
craig.topper committed rG97d104cbeef2: [X86] Re-disable cmpxchg16b for 32-bit mode assembly parsing. (authored by craig.topper).
[X86] Re-disable cmpxchg16b for 32-bit mode assembly parsing.
Tue, Mar 19, 4:57 PM
craig.topper created D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc.
Tue, Mar 19, 3:54 PM · Restricted Project
craig.topper added a comment to D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.

Patch here https://reviews.llvm.org/D59566

Tue, Mar 19, 2:54 PM · Restricted Project
craig.topper updated subscribers of D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus.
Tue, Mar 19, 2:54 PM · Restricted Project, Restricted Project
craig.topper created D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus.
Tue, Mar 19, 2:54 PM · Restricted Project, Restricted Project
craig.topper accepted D59547: [X86] Remove X86 specific dag nodes for RDTSC/RDTSCP/RDPMC. NFCI.

LGTM

Tue, Mar 19, 2:44 PM · Restricted Project
craig.topper added a comment to D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.

It's kind of awkward to use ">=" on a CPU enum, but yes, that's the right idea.

Tue, Mar 19, 2:32 PM · Restricted Project
craig.topper added a comment to D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.

It's still wrong. I think this might fix it?

Tue, Mar 19, 2:15 PM · Restricted Project
craig.topper added inline comments to D59547: [X86] Remove X86 specific dag nodes for RDTSC/RDTSCP/RDPMC. NFCI.
Tue, Mar 19, 1:59 PM · Restricted Project
craig.topper updated the diff for D59479: [X86] Call lowerShuffleAsBitMask for 512-bit vectors in lowerShuffleAsBlend..

Add optsize qualification. Copied one of the test cases in avx512-mask-op.ll and add the optsize attribute to test.

Tue, Mar 19, 12:51 PM · Restricted Project
craig.topper added inline comments to D59547: [X86] Remove X86 specific dag nodes for RDTSC/RDTSCP/RDPMC. NFCI.
Tue, Mar 19, 12:45 PM · Restricted Project
craig.topper added inline comments to D59547: [X86] Remove X86 specific dag nodes for RDTSC/RDTSCP/RDPMC. NFCI.
Tue, Mar 19, 10:40 AM · Restricted Project
craig.topper added inline comments to D59547: [X86] Remove X86 specific dag nodes for RDTSC/RDTSCP/RDPMC. NFCI.
Tue, Mar 19, 10:36 AM · Restricted Project
craig.topper updated the diff for D59533: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc..

Add the test file that I forgot to git add before running arcanist

Tue, Mar 19, 12:00 AM · Restricted Project, Restricted Project
craig.topper created D59533: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc..
Tue, Mar 19, 12:00 AM · Restricted Project, Restricted Project

Mon, Mar 18

craig.topper added inline comments to D59522: [X86] Don't avoid folding multiple use sign extended 8-bit immediate into instructions under optsize..
Mon, Mar 18, 5:03 PM · Restricted Project
craig.topper created D59522: [X86] Don't avoid folding multiple use sign extended 8-bit immediate into instructions under optsize..
Mon, Mar 18, 4:58 PM · Restricted Project
craig.topper committed rG8b653d0308cf: [X86] Add gcc rotate intrinsics to ia32intrin.h (authored by craig.topper).
[X86] Add gcc rotate intrinsics to ia32intrin.h
Mon, Mar 18, 3:25 PM
craig.topper committed rG1dd518da7d25: [X86] Add coverage for 16-bit and 64-bit versions of bsf/bsr/bt/btc/btr/bts in… (authored by craig.topper).
[X86] Add coverage for 16-bit and 64-bit versions of bsf/bsr/bt/btc/btr/bts in…
Mon, Mar 18, 3:06 PM
craig.topper committed rGb24bdf626ab9: [X86] Disable CQTO and CLTQ instructions in the assembly parser outside 64-bit… (authored by craig.topper).
[X86] Disable CQTO and CLTQ instructions in the assembly parser outside 64-bit…
Mon, Mar 18, 3:06 PM
craig.topper committed rGe732bc6bead7: [X86] Allow any 8-bit immediate to be used with BT/BTC/BTR/BTS not just sign… (authored by craig.topper).
[X86] Allow any 8-bit immediate to be used with BT/BTC/BTR/BTS not just sign…
Mon, Mar 18, 2:34 PM
craig.topper committed rGf086e562f940: [X86] Use relocImm in the ROL8ri/ROL16ri/ROL32ri/ROL64ri patterns to be… (authored by craig.topper).
[X86] Use relocImm in the ROL8ri/ROL16ri/ROL32ri/ROL64ri patterns to be…
Mon, Mar 18, 1:43 PM
craig.topper committed rG0b9c640fe079: [X86] Replace uses of i64immSExt32_su with i64relocImmSExt32_su. (authored by craig.topper).
[X86] Replace uses of i64immSExt32_su with i64relocImmSExt32_su.
Mon, Mar 18, 1:43 PM
craig.topper added a comment to D59448: [WebAssembly] Change wasm.throw's first argument to an immediate.

Shouldn't the definition in BuiltinsWebAssembly.def be updated to include an 'I' in the type string so that this will be properly diagnosed in the frontend?

Mon, Mar 18, 1:05 PM · Restricted Project
craig.topper committed rGf07062a7984c: [X86] Rename imm8_su/imm16_su/imm32_su to… (authored by craig.topper).
[X86] Rename imm8_su/imm16_su/imm32_su to…
Mon, Mar 18, 11:54 AM
craig.topper committed rGc2b35ebc1da5: [X86] Remove the _alt forms of (V)CMP instructions. Use a combination of custom… (authored by craig.topper).
[X86] Remove the _alt forms of (V)CMP instructions. Use a combination of custom…
Mon, Mar 18, 11:00 AM
craig.topper committed rGba898da132d4: [X86] Hopefully fix a tautological compare warning in printVecCompareInstr. (authored by craig.topper).
[X86] Hopefully fix a tautological compare warning in printVecCompareInstr.
Mon, Mar 18, 12:05 AM

Sun, Mar 17

craig.topper committed rGd94db9364dac: [X86] Add ADD8ri_DB and ADD8rr_DB to the autogenerated load folding table. (authored by craig.topper).
[X86] Add ADD8ri_DB and ADD8rr_DB to the autogenerated load folding table.
Sun, Mar 17, 10:49 PM
craig.topper committed rGb4c49255aa8f: [X86] Make ADD*_DB post-RA pseudos and expand them in expandPostRAPseudo. (authored by craig.topper).
[X86] Make ADD*_DB post-RA pseudos and expand them in expandPostRAPseudo.
Sun, Mar 17, 10:49 PM
craig.topper created D59479: [X86] Call lowerShuffleAsBitMask for 512-bit vectors in lowerShuffleAsBlend..
Sun, Mar 17, 9:11 PM · Restricted Project
craig.topper committed rG860a27208ecd: [X86] Add tab character to the custom printing of VPCMP and VPCOM instructions. (authored by craig.topper).
[X86] Add tab character to the custom printing of VPCMP and VPCOM instructions.
Sun, Mar 17, 7:54 PM
craig.topper committed rG04cc28fe1330: [X86] Merge printf32mem/printi32mem into a single printdwordmem. Do the same… (authored by craig.topper).
[X86] Merge printf32mem/printi32mem into a single printdwordmem. Do the same…
Sun, Mar 17, 3:57 PM
craig.topper updated the diff for D59468: [X86] Remove the _alt forms of (V)CMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more.

Switch back to using endswith

Sun, Mar 17, 2:35 PM · Restricted Project
craig.topper committed rG12509d87f3a1: [X86] Remove the _alt forms of XOP VPCOM instructions. Use a combination of… (authored by craig.topper).
[X86] Remove the _alt forms of XOP VPCOM instructions. Use a combination of…
Sun, Mar 17, 2:21 PM
craig.topper committed rGaffead9ad0a0: [X86] Remove the _alt forms of AVX512 VPCMP instructions. Use a combination of… (authored by craig.topper).
[X86] Remove the _alt forms of AVX512 VPCMP instructions. Use a combination of…
Sun, Mar 17, 2:21 PM
craig.topper added inline comments to D59468: [X86] Remove the _alt forms of (V)CMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more.
Sun, Mar 17, 1:23 AM · Restricted Project
craig.topper created D59468: [X86] Remove the _alt forms of (V)CMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more.
Sun, Mar 17, 1:20 AM · Restricted Project
craig.topper retitled D59398: [X86] Remove the _alt forms of XOP VPCOM and AVX512 VPCMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more from [X86] Remove the _alt forms of XOP VPCOM instructions. Use a combination of custom printing and custom parsing to achieve the same result and more to [X86] Remove the _alt forms of XOP VPCOM and AVX512 VPCMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more.
Sun, Mar 17, 1:15 AM · Restricted Project

Sat, Mar 16

craig.topper updated the diff for D59398: [X86] Remove the _alt forms of XOP VPCOM and AVX512 VPCMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more.

Extend to cover VPCMP as well. Use TSFlags to make some of the printing decisions rather than switching on the enum. I think this should be better than the jump tables that switching on the enum would require.

Sat, Mar 16, 4:02 PM · Restricted Project

Fri, Mar 15

craig.topper updated the diff for D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h.

Add comments based on rnk's review

Fri, Mar 15, 9:44 PM · Restricted Project
craig.topper accepted D59035: [X86] Promote i8 CMOV's (PR40965).

LGTM

Fri, Mar 15, 1:37 PM · Restricted Project, Restricted Project
craig.topper accepted D59412: [X86] X86ISelLowering::combineSextInRegCmov(): also handle i8 CMOV's.

LGTM

Fri, Mar 15, 1:04 PM · Restricted Project
craig.topper committed rGaf856db96193: [X86] Strip the SAE bit from the rounding mode passed to the _RND opcodes. Use… (authored by craig.topper).
[X86] Strip the SAE bit from the rounding mode passed to the _RND opcodes. Use…
Fri, Mar 15, 1:00 PM
craig.topper added inline comments to D59412: [X86] X86ISelLowering::combineSextInRegCmov(): also handle i8 CMOV's.
Fri, Mar 15, 11:59 AM · Restricted Project
craig.topper added inline comments to D59398: [X86] Remove the _alt forms of XOP VPCOM and AVX512 VPCMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more.
Fri, Mar 15, 9:52 AM · Restricted Project

Thu, Mar 14

craig.topper created D59398: [X86] Remove the _alt forms of XOP VPCOM and AVX512 VPCMP instructions. Use a combination of custom printing and custom parsing to achieve the same result and more.
Thu, Mar 14, 5:04 PM · Restricted Project
craig.topper created D59391: [X86] Add post-isel pseudos for rotate by immediate using SHLD/SHRD.
Thu, Mar 14, 3:11 PM
craig.topper added inline comments to D59035: [X86] Promote i8 CMOV's (PR40965).
Thu, Mar 14, 2:42 PM · Restricted Project, Restricted Project
craig.topper committed rGc747ac3f936a: [X86] Fix the pattern changes from r356121 so that the ROR*r1/ROR*m1 pattern… (authored by craig.topper).
[X86] Fix the pattern changes from r356121 so that the ROR*r1/ROR*m1 pattern…
Thu, Mar 14, 9:54 AM
craig.topper committed rG54a0b5330882: [X86] Add patterns for rotr by immediate to fix PR41057. (authored by craig.topper).
[X86] Add patterns for rotr by immediate to fix PR41057.
Thu, Mar 14, 12:07 AM
craig.topper committed rGc86784701652: [X86] Add various test cases for PR41057. NFC (authored by craig.topper).
[X86] Add various test cases for PR41057. NFC
Thu, Mar 14, 12:07 AM

Wed, Mar 13

craig.topper committed rGbee966d16316: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode. (authored by craig.topper).
[X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode.
Wed, Mar 13, 10:46 PM
craig.topper updated the diff for D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h.

Fix bad comment copy/paste

Wed, Mar 13, 10:13 PM · Restricted Project
craig.topper updated the diff for D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h.

Add the test file

Wed, Mar 13, 10:12 PM · Restricted Project
craig.topper created D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h.
Wed, Mar 13, 10:12 PM · Restricted Project
craig.topper committed rG66df7361fff7: [ResetMachineFunctionPass] Add visited functions statistics info (authored by craig.topper).
[ResetMachineFunctionPass] Add visited functions statistics info
Wed, Mar 13, 6:15 PM
craig.topper committed rGfad96a158888: [X86] Add 64-bit mode command lines to rot32.ll so that it will demonstrate… (authored by craig.topper).
[X86] Add 64-bit mode command lines to rot32.ll so that it will demonstrate…
Wed, Mar 13, 5:23 PM
craig.topper added a comment to D59266: [X86] Add support for {vex2}, {vex3}, and {evex} to the assembler to match gas. Use {evex} to improve the one our 32-bit AVX512 tests..

I forgot about another issue I know about. Currently the EVEX form of instruction like "vcvtss2si (%rax), %ebx" are removed from the assembly matcher table. Since none of the operands are xmm/ymm/zmm registers when the source is memory there was never a reason to use EVEX. And the sorting criteria in the AsmMatcherTable can't order it correctly to put VEX first since the operands are identical. Normally the fact that VR128 is a subclass of VR128X is what give VEX preference over EVEX in the table. But that doesn't apply here so they get sorted by the enum value from X86GenInstrInfo.inc which puts EVEX first.

Wed, Mar 13, 2:29 PM
craig.topper added a comment to D59266: [X86] Add support for {vex2}, {vex3}, and {evex} to the assembler to match gas. Use {evex} to improve the one our 32-bit AVX512 tests..

Might need to skip use of the _REV MOV instructions for this too, but I haven't done that yet.

Can you elaborate?

Wed, Mar 13, 2:20 PM
craig.topper added a comment to D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode..

I think the only error we have for X86 is trying to use a -march for a cpu that only supports 32 bit but compiling 64 bit code.

Wed, Mar 13, 2:02 PM · Restricted Project
craig.topper added a comment to D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode..

Is this ok with the backend fixed? Or do you want me factor this into HasCX16 which I think is only used by the defineMacro and the return for hasFeature("cx16")? And I think hasFeature("cx16") is only used by that getMaxAtomicWidth() code which is only called on 64 bit.

Wed, Mar 13, 12:38 PM · Restricted Project
craig.topper committed rG84abec2855ad: [X86] Check for 64-bit mode in X86Subtarget::hasCmpxchg16b() (authored by craig.topper).
[X86] Check for 64-bit mode in X86Subtarget::hasCmpxchg16b()
Wed, Mar 13, 11:48 AM
craig.topper created D59308: [X86] Check for 64-bit mode in X86Subtarget::hasCmpxchg16b().
Wed, Mar 13, 10:22 AM · Restricted Project
craig.topper added a comment to D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode..

Most if not all of the test cases in test/CodeGen/X86/atomic128.ll fail with a fatal error if you run it in 32-bit mode with -mattr=+cx16 Looks like the backend is also bad at checking 64 bit mode.

Wed, Mar 13, 10:00 AM · Restricted Project
craig.topper added a comment to D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode..

Isn’t that setMaxAtomicWidth in the x86-64 derived class?

Wed, Mar 13, 8:30 AM · Restricted Project

Tue, Mar 12

craig.topper created D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode..
Tue, Mar 12, 10:52 PM · Restricted Project
craig.topper committed rGd02c9f59ff62: [X86] Remove 'cx16' from 'prescott' and 'yonah' as they are 32-bit only CPUs… (authored by craig.topper).
[X86] Remove 'cx16' from 'prescott' and 'yonah' as they are 32-bit only CPUs…
Tue, Mar 12, 10:15 PM
craig.topper committed rG704c626ea17c: [X86] Add 'yonah' test to predefined-arch-macros.c test. (authored by craig.topper).
[X86] Add 'yonah' test to predefined-arch-macros.c test.
Tue, Mar 12, 10:14 PM
craig.topper committed rG750efba67c52: [X86] Enable printAliasInstr for the Intel assembly printer so that AAM and AAD… (authored by craig.topper).
[X86] Enable printAliasInstr for the Intel assembly printer so that AAM and AAD…
Tue, Mar 12, 5:43 PM
craig.topper committed rG9bae5ba0769e: [X86] Add ImmArg markings to intrinsics. (authored by craig.topper).
[X86] Add ImmArg markings to intrinsics.
Tue, Mar 12, 4:47 PM