- User Since
- Jul 30 2013, 7:58 PM (320 w, 5 d)
I've removed the canonicalization in LowerIntVSETCC_AVX512 that was causing this in r372543. And I've moved it to X86ISelDAGToDAG in r372544. At the time LowerIntVSETCC_AVX512 we were using isel patterns for vptest and this was an attempt reduce the size of the table. We're now using custom isel in X86ISelDAGToDAG so the canonicalization is much cheaper to handle there.
LGTM with those comment fixes.
What if we just do the larger than 32-bit mask? Its not clear that making BZHI just to fold a load is an improvement. You have to materialize an immediate instead so the total uops increased.
Sat, Sep 21
I added some memset tests in r372494 and the RUN line changes here. Can you rebase?
Do we have a similar test for memset that should be updated?
Fri, Sep 20
Remove ImmArg from Mips intrinsics
Thu, Sep 19
Wed, Sep 18
Tue, Sep 17
Mon, Sep 16
What targets does clang enable FTZ/DAZ on? I don't think it does on X86.
Fri, Sep 13
Thu, Sep 12
Remove bad change
Wed, Sep 11
So who wants to click Accept?
Update clang release notes as well.
Tue, Sep 10
X86 looks good to me.
Fix review comments
I believe this test case compiled with avx needs this pass.
For VEX instructions don’t we just use the other input register to break the dependency without adding an instruction?
Mon, Sep 9
LGTM. Will you also be updating nonvolatile_load/nonvolatile_store in include/llvm/Target/TargetSelectionDAG.td. We use those in several places where we change the size of a load.
Add a sentence to the release notes
Sun, Sep 8