Page MenuHomePhabricator

pengfei (Pengfei Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 5:57 PM (40 w, 1 d)

Recent Activity

Mon, Sep 2

pengfei committed rGdea9cad10e02: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps… (authored by pengfei).
[x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps…
Mon, Sep 2, 7:07 PM
pengfei committed rL370691: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps….
[x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps…
Mon, Sep 2, 7:06 PM
pengfei closed D66786: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512.
Mon, Sep 2, 7:05 PM · Restricted Project

Wed, Aug 28

pengfei committed rGcaac097fbf4e: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32 (authored by pengfei).
[x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32
Wed, Aug 28, 11:19 PM
pengfei committed rL370297: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32.
[x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32
Wed, Aug 28, 11:19 PM
pengfei closed D66785: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32.
Wed, Aug 28, 11:19 PM · Restricted Project
pengfei added a comment to D66625: [X86] Print register names in .seh_* directives.

LGTM. But I'd like others to make a decision. Thanks!

Wed, Aug 28, 5:39 AM · Restricted Project

Mon, Aug 26

pengfei abandoned D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Mon, Aug 26, 9:36 PM · Restricted Project
pengfei committed rG564fb58a32a8: [WinEH] Allocate space in funclets stack to save XMM CSRs (authored by pengfei).
[WinEH] Allocate space in funclets stack to save XMM CSRs
Mon, Aug 26, 6:56 PM
pengfei committed rL370005: [WinEH] Allocate space in funclets stack to save XMM CSRs.
[WinEH] Allocate space in funclets stack to save XMM CSRs
Mon, Aug 26, 6:56 PM
pengfei closed D66596: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Mon, Aug 26, 6:56 PM · Restricted Project

Fri, Aug 23

pengfei updated the diff for D66596: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Fix the error in calculating funclet stack pointer.

Fri, Aug 23, 6:01 PM · Restricted Project
pengfei added a comment to D66596: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Thanks for the patient review and valuable suggestions.

Fri, Aug 23, 7:02 AM · Restricted Project
pengfei updated the diff for D66596: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Address review comments.

Fri, Aug 23, 6:38 AM · Restricted Project

Thu, Aug 22

pengfei added inline comments to D66625: [X86] Print register names in .seh_* directives.
Thu, Aug 22, 6:48 PM · Restricted Project
pengfei added a comment to D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
In D63396#1640095, @rnk wrote:

My suggestion for drastically simplifying this is to modify X86RegisterInfo::eliminateFrameIndex to check if it's lowering an XMM CSR slot. In that case, it would call a new method, X86FrameLowering::getSaveXMMFrameIndexRef, which would contain the logic to check if the current block is a funclet prologue or epilogue. If the parent BB of the current instruction is in a funclet, then XMM slots would be resolved relative to RSP using the funclet frame size. If not, it would delegate to the standard getFrameIndexReference logic, yielding the correct register and offset for XMM slots in non-funclet prologues and epilogues. The prologue code that currently inserts savexmm markers would need to call this new helper as well instead of the standard getFrameIndexReference method. Does that plan seem reasonable?

Thu, Aug 22, 8:18 AM · Restricted Project
pengfei created D66596: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Thu, Aug 22, 8:14 AM · Restricted Project

Wed, Aug 21

pengfei committed rG7630e24492c5: [X86] Making X86OptimizeLEAs pass public. NFC (authored by pengfei).
[X86] Making X86OptimizeLEAs pass public. NFC
Wed, Aug 21, 7:29 PM
pengfei committed rL369612: [X86] Making X86OptimizeLEAs pass public. NFC.
[X86] Making X86OptimizeLEAs pass public. NFC
Wed, Aug 21, 7:29 PM
pengfei closed D65933: [X86] Making X86OptimizeLEAs pass public. NFC.
Wed, Aug 21, 7:29 PM · Restricted Project
pengfei updated the diff for D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Update test case to verify XMM registers correctly when MaxCallFrameSize is not 16 bytes aligned.

Wed, Aug 21, 4:55 AM · Restricted Project

Aug 20 2019

pengfei added a reviewer for D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs: rnk.
Aug 20 2019, 6:28 PM · Restricted Project
pengfei updated the diff for D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Add downward alignment for XMM storing in epilogue. This fix the crush when MaxCallFrameSize is not 16 bytes aligned.

Aug 20 2019, 6:19 PM · Restricted Project
pengfei reopened D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Aug 20 2019, 5:37 PM · Restricted Project
pengfei added a comment to D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Aug 20 2019, 5:28 PM · Restricted Project

Aug 11 2019

pengfei committed rGe28cbbd5d49f: [X86] Support -march=tigerlake (authored by pengfei).
[X86] Support -march=tigerlake
Aug 11 2019, 6:32 PM
pengfei committed rL368543: [X86] Support -march=tigerlake.
[X86] Support -march=tigerlake
Aug 11 2019, 6:29 PM
pengfei closed D65840: [X86] Support -march=tigerlake.
Aug 11 2019, 6:29 PM · Restricted Project

Aug 1 2019

pengfei added inline comments to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.
Aug 1 2019, 6:35 PM · Restricted Project
pengfei added inline comments to D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics.
Aug 1 2019, 1:56 AM · Restricted Project

Jul 26 2019

pengfei committed rG9ad565f70ec5: [WinEH] Allocate space in funclets stack to save XMM CSRs (authored by pengfei).
[WinEH] Allocate space in funclets stack to save XMM CSRs
Jul 26 2019, 12:38 AM
pengfei committed rL367088: [WinEH] Allocate space in funclets stack to save XMM CSRs.
[WinEH] Allocate space in funclets stack to save XMM CSRs
Jul 26 2019, 12:34 AM
pengfei closed D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Jul 26 2019, 12:34 AM · Restricted Project

Jul 25 2019

pengfei added a comment to D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Ping.

Jul 25 2019, 7:56 PM · Restricted Project

Jul 16 2019

pengfei added a comment to D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Thanks for the review.

Jul 16 2019, 12:44 AM · Restricted Project
pengfei updated the diff for D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Refine code as David's proposal

Jul 16 2019, 12:40 AM · Restricted Project

Jul 15 2019

pengfei added inline comments to D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Jul 15 2019, 7:20 PM · Restricted Project
pengfei updated the diff for D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

We don't need to consider the upper registers [X,Y,Z]MM16~[X,Y,Z]MM31. So remove the VLX and AVX512 check.

Jul 15 2019, 7:12 PM · Restricted Project

Jul 9 2019

pengfei committed rGa50bbfc47027: [NFC] [X86] Fix scan-build complaining (authored by pengfei).
[NFC] [X86] Fix scan-build complaining
Jul 9 2019, 5:42 AM
pengfei committed rL365473: [NFC] [X86] Fix scan-build complaining.
[NFC] [X86] Fix scan-build complaining
Jul 9 2019, 5:41 AM
pengfei closed D64389: [NFC] [X86] Fix scan-build complaining.
Jul 9 2019, 5:41 AM · Restricted Project, Restricted Project
pengfei created D64389: [NFC] [X86] Fix scan-build complaining.
Jul 9 2019, 12:29 AM · Restricted Project, Restricted Project

Jun 29 2019

pengfei added a comment to D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Thanks for the review

Jun 29 2019, 4:38 AM · Restricted Project
pengfei updated the diff for D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Refine code as Craig's proposal

Jun 29 2019, 4:30 AM · Restricted Project

Jun 20 2019

pengfei added inline comments to D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Jun 20 2019, 2:21 AM · Restricted Project
pengfei updated the diff for D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.

Refine code as Reid's proposal.
Separate the XMM slot caculating so that we can get a consecutive layout in stack.
Also fix an alignment bug due to it affecting this patch.

Jun 20 2019, 1:55 AM · Restricted Project

Jun 17 2019

pengfei updated the summary of D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Jun 17 2019, 1:02 AM · Restricted Project
pengfei created D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs.
Jun 17 2019, 12:47 AM · Restricted Project

Jun 11 2019

pengfei committed rGfbfee60c3263: [X86] [ABI] Fix i386 ABI "__m64" type bug (authored by pengfei).
[X86] [ABI] Fix i386 ABI "__m64" type bug
Jun 11 2019, 6:50 PM
pengfei committed rL363116: [X86] [ABI] Fix i386 ABI "__m64" type bug.
[X86] [ABI] Fix i386 ABI "__m64" type bug
Jun 11 2019, 6:50 PM
pengfei closed D59744: Fix i386 ABI "__m64" type bug.
Jun 11 2019, 6:50 PM · Restricted Project, Restricted Project

Jun 10 2019

pengfei committed rG244062eece92: [X86] Enable intrinsics that convert float and bf16 data to each other (authored by pengfei).
[X86] Enable intrinsics that convert float and bf16 data to each other
Jun 10 2019, 6:17 PM
pengfei committed rL363018: [X86] Enable intrinsics that convert float and bf16 data to each other.
[X86] Enable intrinsics that convert float and bf16 data to each other
Jun 10 2019, 6:16 PM
pengfei closed D62363: [X86] Enable intrinsics that convert float and bf16 data to each other.
Jun 10 2019, 6:16 PM · Restricted Project, Restricted Project

Jun 7 2019

pengfei committed rG30bcda86db6c: [X86] -march=cooperlake (clang) (authored by pengfei).
[X86] -march=cooperlake (clang)
Jun 7 2019, 1:51 AM
pengfei committed rL362781: [X86] -march=cooperlake (clang).
[X86] -march=cooperlake (clang)
Jun 7 2019, 1:51 AM
pengfei closed D62835: [X86] -march=cooperlake (clang).
Jun 7 2019, 1:51 AM · Restricted Project, Restricted Project
pengfei committed rGf8b28931a751: [X86] -march=cooperlake (llvm) (authored by pengfei).
[X86] -march=cooperlake (llvm)
Jun 7 2019, 1:30 AM
pengfei committed rL362776: [X86] -march=cooperlake (llvm).
[X86] -march=cooperlake (llvm)
Jun 7 2019, 1:30 AM
pengfei closed D62836: [X86] -march=cooperlake (llvm).
Jun 7 2019, 1:30 AM · Restricted Project

Jun 6 2019

pengfei committed rG3a29f7c99c2f: [X86] Add ENQCMD instructions (authored by pengfei).
[X86] Add ENQCMD instructions
Jun 6 2019, 1:26 AM
pengfei committed rL362685: [X86] Add ENQCMD instructions.
[X86] Add ENQCMD instructions
Jun 6 2019, 1:26 AM
pengfei closed D62282: [X86] Add ENQCMD intrinsics..
Jun 6 2019, 1:26 AM · Restricted Project, Restricted Project

May 30 2019

pengfei committed rGcc3629d545a8: [X86] Add VP2INTERSECT instructions (authored by pengfei).
[X86] Add VP2INTERSECT instructions
May 30 2019, 11:07 PM
pengfei committed rL362196: [X86] Add VP2INTERSECT instructions.
[X86] Add VP2INTERSECT instructions
May 30 2019, 11:07 PM
pengfei closed D62367: [X86] VP2INTERSECT clang.
May 30 2019, 11:07 PM · Restricted Project, Restricted Project
pengfei committed rG2e67d0c842c5: [X86] Add VP2INTERSECT instructions (authored by pengfei).
[X86] Add VP2INTERSECT instructions
May 30 2019, 7:49 PM
pengfei committed rL362188: [X86] Add VP2INTERSECT instructions.
[X86] Add VP2INTERSECT instructions
May 30 2019, 7:48 PM
pengfei closed D62366: [X86] VP2INTERSECT llvm.
May 30 2019, 7:48 PM · Restricted Project
pengfei reopened D60748: Fix i386 struct and union parameter alignment.

Reverted by https://reviews.llvm.org/rL362186

May 30 2019, 6:54 PM · Restricted Project
pengfei committed rG48387ec18726: Revert "[X86] Fix i386 struct and union parameter alignment" (authored by pengfei).
Revert "[X86] Fix i386 struct and union parameter alignment"
May 30 2019, 6:49 PM
pengfei added a reverting change for rGd61cb749f4ac: [X86] Fix i386 struct and union parameter alignment: rG48387ec18726: Revert "[X86] Fix i386 struct and union parameter alignment".
May 30 2019, 6:48 PM
pengfei committed rL362186: Revert "[X86] Fix i386 struct and union parameter alignment".
Revert "[X86] Fix i386 struct and union parameter alignment"
May 30 2019, 6:48 PM

May 29 2019

pengfei committed rG1f67d9427931: [X86] Add ENQCMD instructions (authored by pengfei).
[X86] Add ENQCMD instructions
May 29 2019, 8:57 PM
pengfei committed rL362053: [X86] Add ENQCMD instructions.
[X86] Add ENQCMD instructions
May 29 2019, 8:57 PM
pengfei closed D62281: [X86] Add ENQCMD instructions..
May 29 2019, 8:57 PM · Restricted Project
pengfei committed rGd61cb749f4ac: [X86] Fix i386 struct and union parameter alignment (authored by pengfei).
[X86] Fix i386 struct and union parameter alignment
May 29 2019, 1:44 AM
pengfei committed rL361934: [X86] Fix i386 struct and union parameter alignment.
[X86] Fix i386 struct and union parameter alignment
May 29 2019, 1:39 AM
pengfei committed rC361934: [X86] Fix i386 struct and union parameter alignment.
[X86] Fix i386 struct and union parameter alignment
May 29 2019, 1:39 AM
pengfei closed D60748: Fix i386 struct and union parameter alignment.
May 29 2019, 1:39 AM · Restricted Project

May 28 2019

pengfei added a comment to rL361912: [X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to.

Hello,

It seems your changeset broke this buildbot . There are other prior failures but it seems your changeset introduced some new failures, listed below.
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt?numbuilds=100
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/27772

Failures are

FAIL: Clang::appletvos-version-min.c
FAIL: Clang::incompatible_sysroot.c
FAIL: Clang::declare_simd_aarch64_warning_advsimd.c
FAIL: Clang::declare_simd_aarch64_warning_sve.c
FAIL: LLVM::arm64-fallback.ll
FAIL: LLVM::irtranslator-volatile-load-pr36018.ll
FAIL: LLVM::irtranslator-block-order.ll
FAIL: LLVM::irtranslator-duplicate-types-param.ll
FAIL: LLVM::regbankselect-unmerge-vec.mir
FAIL: LLVM::regbankselect-default.mir
FAIL: LLVM::arm64-regbankselect.mir

May 28 2019, 8:27 PM
pengfei committed rG72e3f9662b70: Revert "[X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to" (authored by pengfei).
Revert "[X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to"
May 28 2019, 7:48 PM
pengfei committed rL361918: Revert "[X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to".
Revert "[X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to"
May 28 2019, 7:48 PM
pengfei committed rG818c65264341: [X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to avoid… (authored by pengfei).
[X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to avoid…
May 28 2019, 7:19 PM
pengfei committed rL361912: [X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to.
[X86] Use 'llvm_unreachable' instead of nullptr in unreachable code to
May 28 2019, 7:18 PM
pengfei closed D62006: Add "llvm_unreachable" for function RegisterBankInfo::getRegBank.
May 28 2019, 7:18 PM · Restricted Project

May 21 2019

pengfei committed rG6a0d432e9e0f: [X86] [CET] Deal with return-twice function such as vfork, setjmp when CET-IBT… (authored by pengfei).
[X86] [CET] Deal with return-twice function such as vfork, setjmp when CET-IBT…
May 21 2019, 5:53 PM
pengfei committed rL361342: [X86] [CET] Deal with return-twice function such as vfork, setjmp when.
[X86] [CET] Deal with return-twice function such as vfork, setjmp when
May 21 2019, 5:47 PM
pengfei closed D61881: Deal with return-twice function such as vfork, setjmp when CET-IBT enabled.
May 21 2019, 5:47 PM · Restricted Project

May 9 2019

pengfei committed rGc05aad05324c: Bugfix for nullptr check by klocwork (authored by pengfei).
Bugfix for nullptr check by klocwork
May 9 2019, 1:07 AM
pengfei committed rL360317: Bugfix for nullptr check by klocwork.
Bugfix for nullptr check by klocwork
May 9 2019, 1:07 AM
pengfei closed D61715: fix a null pointer deref issue.
May 9 2019, 1:07 AM · Restricted Project

May 6 2019

pengfei committed rGb5d3430d3df9: [NFC] This is a test for the commit access. (authored by pengfei).
[NFC] This is a test for the commit access.
May 6 2019, 1:31 AM
pengfei committed rL360019: [NFC] This is a test for the commit access..
[NFC] This is a test for the commit access.
May 6 2019, 1:31 AM
pengfei closed D61580: [NFC] This is a test for the commit access..
May 6 2019, 1:30 AM · Restricted Project

May 5 2019

pengfei created D61580: [NFC] This is a test for the commit access..
May 5 2019, 7:37 PM · Restricted Project

May 1 2019

pengfei added a comment to D61295: [X86] Remove the redundant suffix in vfpclassp[d,s]'s broadcasting variant.

Hi Craig and Yuanke, Could any of you help to submit it? Thank a lot.

May 1 2019, 7:01 AM · Restricted Project

Apr 29 2019

pengfei created D61295: [X86] Remove the redundant suffix in vfpclassp[d,s]'s broadcasting variant.
Apr 29 2019, 10:45 PM · Restricted Project

Jan 8 2019

pengfei accepted D56391: Limit COFF 'common' emission to <=32 alignment types..

LGTM, thanks Erich.

Jan 8 2019, 6:20 AM

Dec 17 2018

pengfei added a comment to D55642: [X86] Fix assert fails in pass X86AvoidSFBPass.

@nikic Thank you very much for your auditing and suggestions.
The test here was just trimmed from the bug repro and used to verify the fix to the assertion. However it exposed that it may be better if it just optimized inside the BB in some cases. We will reserach it later.

Dec 17 2018, 4:41 AM