Page MenuHomePhabricator

pengfei (Phoebe Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 5:57 PM (184 w, 3 d)

Recent Activity

Yesterday

pengfei updated the diff for D128571: [X86] Support `_Float16` on SSE2 and up.

Address review comments. Thanks @rjmccall !

Sat, Jun 25, 6:14 PM · Restricted Project, Restricted Project

Fri, Jun 24

pengfei added a comment to rG655ba9c8a1d2: Reland "Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on….

Another issue without any custom expand / truncate implementations: https://github.com/llvm/llvm-project/issues/56204

Fri, Jun 24, 9:06 PM · Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

I'll take care next time. Thanks @MaskRay !

Fri, Jun 24, 8:34 PM · Restricted Project, Restricted Project, Restricted Project
pengfei requested review of D128571: [X86] Support `_Float16` on SSE2 and up.
Fri, Jun 24, 8:31 PM · Restricted Project, Restricted Project

Wed, Jun 22

pengfei added inline comments to D128334: [LegalizeTypes][X86] Add SoftPromoteHalfOperand support for STRICT_FP_TO_SINT/STRICT_FP_TO_UINT.
Wed, Jun 22, 5:45 AM · Restricted Project, Restricted Project

Mon, Jun 20

pengfei committed rGedcc68e86f78: [X86] Make sure SF is updated when optimizing for `jg/jge/jl/jle` (authored by pengfei).
[X86] Make sure SF is updated when optimizing for `jg/jge/jl/jle`
Mon, Jun 20, 6:10 PM · Restricted Project, Restricted Project
pengfei closed D128122: [X86] Make sure SF is updated when optimizing for `jg/jge/jl/jle`.
Mon, Jun 20, 6:09 PM · Restricted Project, Restricted Project
pengfei added inline comments to D128216: [X86] Add SimplifyMultipleUseDemandedBitsForTargetNode X86ISD::ANDNP handling.
Mon, Jun 20, 6:05 PM · Restricted Project, Restricted Project

Sat, Jun 18

pengfei updated the diff for D128122: [X86] Make sure SF is updated when optimizing for `jg/jge/jl/jle`.

Address review comments, thanks @craig.topper and @mingmingl!

Sat, Jun 18, 5:52 PM · Restricted Project, Restricted Project
pengfei requested review of D128122: [X86] Make sure SF is updated when optimizing for `jg/jge/jl/jle`.
Sat, Jun 18, 7:49 AM · Restricted Project, Restricted Project

Fri, Jun 17

pengfei requested review of D128114: [X86][FP16] Add constrained FP support for scalar emulation.
Fri, Jun 17, 10:09 PM · Restricted Project, Restricted Project
pengfei updated the diff for D127982: [X86][FP16] Enable vector support for FP16 emulation.

Rebase

Fri, Jun 17, 7:25 AM · Restricted Project, Restricted Project
pengfei added a comment to rG04a3d5f3a119: Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….

Reland again by rG655ba9c8a1d2, thanks!

Fri, Jun 17, 6:37 AM · Restricted Project, Restricted Project, Restricted Project
pengfei committed rG655ba9c8a1d2: Reland "Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on… (authored by pengfei).
Reland "Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on…
Fri, Jun 17, 6:34 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D127982: [X86][FP16] Enable vector support for FP16 emulation.

Rebase.

Fri, Jun 17, 1:01 AM · Restricted Project, Restricted Project

Thu, Jun 16

pengfei added a comment to rG3cd5696a3309: Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….

Reland by rG04a3d5f3a119

Thu, Jun 16, 9:25 PM · Restricted Project, Restricted Project, Restricted Project
pengfei committed rG04a3d5f3a119: Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86… (authored by pengfei).
Reland "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86…
Thu, Jun 16, 9:12 PM · Restricted Project, Restricted Project, Restricted Project
pengfei added inline comments to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
Thu, Jun 16, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
pengfei requested review of D127982: [X86][FP16] Enable vector support for FP16 emulation.
Thu, Jun 16, 9:24 AM · Restricted Project, Restricted Project
pengfei added a comment to rG3cd5696a3309: Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….

Thanks Frederik! The optimized IR is really help. I can reproduce it with llc now. I'll investigate it.

Thu, Jun 16, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to rG3cd5696a3309: Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….

If it failed in JIT compiler, it's possible a problem in JIT runtime too, see https://github.com/llvm/llvm-project/issues/55992

Thu, Jun 16, 7:04 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to D111029: [X86] Prefer 512-bit vectors on Ice Lake Server cpus (PR48336).

I think in general, we would like to prefer 512-bit vector on server. But notice the changes on arguments passing, which is ABI breaking. We need some downstream work before ready for the change. Please hold for a while, thanks!

Thu, Jun 16, 3:30 AM · Restricted Project, Restricted Project

Wed, Jun 15

pengfei added a comment to rG3cd5696a3309: Revert "Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86….

@frgossen , can you please put the reproduce command together? I tried llc < crash.ll, but it passed on my side.

Wed, Jun 15, 5:50 PM · Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to rG6e02e27536b9: Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI".

Fixed by rGe1c5afa

Wed, Jun 15, 8:05 AM · Restricted Project, Restricted Project, Restricted Project
pengfei committed rGe1c5afa47d37: Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86 following the… (authored by pengfei).
Reland "Reland "[X86][RFC] Enable `_Float16` type support on X86 following the…
Wed, Jun 15, 8:00 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to rG6e02e27536b9: Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI".

@bkramer Any reason on reverting this?

There's a test case in the message of the revert. The problem is a llvm.sqrt on <4xf16> not getting promoted anymore, crashing the compiler.

Thanks. I saw the test. I'll investigate it. What's the command to compile it?

You can translate it to LLVM IR and then run llc on it
mlir-translate -mlir-to-llvmir | llc
LLVM ERROR: Cannot select: t102: f16 = fsqrt t17

Wed, Jun 15, 6:12 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to rG6e02e27536b9: Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI".

@bkramer Any reason on reverting this?

There's a test case in the message of the revert. The problem is a llvm.sqrt on <4xf16> not getting promoted anymore, crashing the compiler.

Wed, Jun 15, 6:02 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to rG37455b1f71d3: Revert "Reland "[X86][RFC] Enable `_Float16` type support on X86 following the….

@tjoerg I have identified one issue in MLIR's runtime. See https://github.com/llvm/llvm-project/issues/55992
Not sure if it is the same root cause. Can you take a look?
By the way, what's the command to reproduce it? I don't have any experience on MLIR.

Wed, Jun 15, 5:56 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated subscribers of rG6e02e27536b9: Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI".

@bkramer Any reason on reverting this?

Wed, Jun 15, 5:45 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

pengfei accepted D127787: [TableGen][X86] Add Size field to X86MemOperand class.

LGTM. The summary need to update too.

Tue, Jun 14, 11:29 PM · Restricted Project, Restricted Project
pengfei added a comment to D111029: [X86] Prefer 512-bit vectors on Ice Lake Server cpus (PR48336).

@pengfei Do you have any update on this please?

Tue, Jun 14, 7:14 PM · Restricted Project, Restricted Project
pengfei committed rG6e02e27536b9: Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI" (authored by pengfei).
Reland "[X86][RFC] Enable `_Float16` type support on X86 following the psABI"
Tue, Jun 14, 6:17 PM · Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to D127716: [X86][NFC] Use mnemonic tables in validateInstruction 1/4.

Change the title N in "1/N" to the actual number?

Tue, Jun 14, 9:28 AM · Restricted Project, Restricted Project

Sun, Jun 12

pengfei added a comment to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

This broke the bot here: https://lab.llvm.org/buildbot/#/builders/61/builds/27616

The cmake invocation includes some GPU specific options that you can omit (-DMLIR_ENABLE_CUDA_RUNNER=1 , -DCMAKE_CUDA_COMPILER=/usr/local/cuda/bin/nvcc, -DMLIR_ENABLE_VULKAN_RUNNER=1, -DMLIR_RUN_CUDA_TENSOR_CORE_TESTS=ON), which should leave out:

cmake ../llvm.src/llvm -DLLVM_BUILD_EXAMPLES=ON '-DLLVM_TARGETS_TO_BUILD=host;NVPTX' -DLLVM_ENABLE_PROJECTS=mlir  -DMLIR_INCLUDE_INTEGRATION_TESTS=ON  -DBUILD_SHARED_LIBS=ON -DLLVM_CCACHE_BUILD=ON -DMLIR_ENABLE_BINDINGS_PYTHON=ON  -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON '-DLLVM_LIT_ARGS=-v -vv' -GNinja

You can probably leave out other options too:

cmake ../llvm.src/llvm '-DLLVM_TARGETS_TO_BUILD=host' -DLLVM_ENABLE_PROJECTS=mlir  -DMLIR_INCLUDE_INTEGRATION_TESTS=ON -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON '-DLLVM_LIT_ARGS=-v -vv' -GNinja
Sun, Jun 12, 5:41 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Jun 11

pengfei committed rG2d2da259c872: [X86][RFC] Enable `_Float16` type support on X86 following the psABI (authored by pengfei).
[X86][RFC] Enable `_Float16` type support on X86 following the psABI
Sat, Jun 11, 8:40 PM · Restricted Project, Restricted Project
pengfei closed D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
Sat, Jun 11, 8:40 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 10

pengfei added inline comments to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
Fri, Jun 10, 9:34 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 9

pengfei requested changes to D127409: Fix GCC intrinsics "round_mask" names.

We had a discussion about the builtins between GCC and Clang on D109658 last year. We tried to make sure the same builtins have the same arguments and behavior. There's still a big gap among others.
We don't pursue all the builtins are identical for two reasons:

Thu, Jun 9, 11:37 PM · Restricted Project, Restricted Project, Restricted Project
pengfei added inline comments to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
Thu, Jun 9, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Address Yuanke's comments.

Thu, Jun 9, 9:03 AM · Restricted Project, Restricted Project, Restricted Project
pengfei requested review of D127386: [X86][FP16][CostModel][WIP] Add CostModel for more FP16 instructions.
Thu, Jun 9, 2:43 AM · Restricted Project, Restricted Project

Wed, Jun 8

pengfei added inline comments to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
Wed, Jun 8, 7:15 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Address Yuanke's comments. Thanks!

Wed, Jun 8, 7:15 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 5

pengfei committed rG52818fd97f0f: [Clang][FP16] Add 4 builtins for _Float16 (authored by pengfei).
[Clang][FP16] Add 4 builtins for _Float16
Sun, Jun 5, 6:01 PM · Restricted Project, Restricted Project
pengfei closed D127050: [Clang][FP16] Add 4 builtins for _Float16.
Sun, Jun 5, 6:00 PM · Restricted Project, Restricted Project

Sat, Jun 4

pengfei added inline comments to D127050: [Clang][FP16] Add 4 builtins for _Float16.
Sat, Jun 4, 8:37 PM · Restricted Project, Restricted Project
pengfei added inline comments to D127050: [Clang][FP16] Add 4 builtins for _Float16.
Sat, Jun 4, 7:58 PM · Restricted Project, Restricted Project
pengfei added inline comments to D127050: [Clang][FP16] Add 4 builtins for _Float16.
Sat, Jun 4, 6:46 PM · Restricted Project, Restricted Project
pengfei requested review of D127050: [Clang][FP16] Add 4 builtins for _Float16.
Sat, Jun 4, 6:20 AM · Restricted Project, Restricted Project

Tue, May 31

pengfei committed rGa2ea5b496bcd: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]` (authored by pengfei).
[X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`
Tue, May 31, 6:45 PM · Restricted Project, Restricted Project, Restricted Project
pengfei closed D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
Tue, May 31, 6:45 PM · Restricted Project, Restricted Project, Restricted Project
pengfei retitled D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI from [X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI to [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
Tue, May 31, 6:04 PM · Restricted Project, Restricted Project, Restricted Project

Fri, May 27

pengfei updated the diff for D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Address review comments. Thanks @MaskRay for the thorough review!

Fri, May 27, 11:10 PM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
  1. Revert the change to clang/docs/ClangCommandLineReference.rst
  2. Update missing options
  3. Rebase on D126511
Fri, May 27, 8:51 PM · Restricted Project, Restricted Project, Restricted Project

May 27 2022

pengfei added a comment to D126511: [ARM][AArch64] Change -mharden-sls= to use err_drv_unsupported_option_argument.

This is also fine to me. I'll rebase on it if @nickdesaulniers accept this.

May 27 2022, 3:27 AM · Restricted Project, Restricted Project
pengfei retitled D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]` from [X86] Add support for `-mharden-sls=all` to [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 27 2022, 3:21 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added inline comments to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 27 2022, 3:21 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Address @MaskRay 's comments. Thanks for the review!

May 27 2022, 3:21 AM · Restricted Project, Restricted Project, Restricted Project

May 26 2022

pengfei added inline comments to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
May 26 2022, 8:41 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Address Shengchen's review comments.

May 26 2022, 8:41 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added inline comments to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 26 2022, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Address @nickdesaulniers 's comments. Thanks for the review!

May 26 2022, 5:02 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2022

pengfei added inline comments to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 24 2022, 12:58 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Address @nickdesaulniers 's comments. Thanks for the thorough review and suggestions!

May 24 2022, 12:58 AM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

pengfei added a comment to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

See https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html, documentation for "mharden-sls": For AArch64, the options available on the command line are "retbr", "blr", "none" and "all".
I don't think the options necessarily have to be the same for x86.
But assuming I understand this patch correctly, it seems to me that with this patch -mharden-sls=all would mean fundamentally slightly different things for x86 vs arm and aarch64, which could be confusing to users.
IIUC this patch correctly, this patch implements the equivalent of aarch64/arm's -mharden-sls=retbr (i.e. add a straight-line-speculation mitigation for returns and indirect jumps, but not for indirect function calls).
Therefore, I wonder if it wouldn't be better to name this -mharden-sls=retbr for more consistency across architectures?
Or is the indirect function call case not relevant for x86 (sorry - I'm not up to speed on the details on the x86 side)?

Or does MBB.back().getDesc().isIndirectBranch() also return True for indirect calls, in which case my whole remark here can probably be ignored?

May 23 2022, 4:13 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Replaced isIndirectBranch with isUnconditionalBranch + isReturn.

May 23 2022, 3:58 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added a reviewer for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI: skan.
May 23 2022, 1:36 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2022

pengfei added inline comments to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 21 2022, 9:03 PM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Address Craig's comment.

May 21 2022, 9:03 PM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the summary of D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 21 2022, 9:01 PM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the summary of D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 21 2022, 8:57 PM · Restricted Project, Restricted Project, Restricted Project
pengfei requested review of D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 21 2022, 8:57 PM · Restricted Project, Restricted Project, Restricted Project

May 20 2022

pengfei updated the diff for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Fix a few minor issues. I think it's mature for review now.

May 20 2022, 8:31 AM · Restricted Project, Restricted Project, Restricted Project
pengfei retitled D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI from [X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI to [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
May 20 2022, 8:31 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Adjust libcall lowering according to GCC code generation.

May 20 2022, 12:39 AM · Restricted Project, Restricted Project, Restricted Project

May 18 2022

pengfei planned changes to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.
May 18 2022, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
pengfei retitled D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI from [X86][RFC] Enable `_Float16` type support on X86 following the psABI to [X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI.
May 18 2022, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Replace gnu_f2h_ieee/gnu_h2f_ieee with truncsfhf2/extendhfsf2 to match with GCC.

May 18 2022, 5:38 AM · Restricted Project, Restricted Project, Restricted Project
pengfei updated the diff for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Use 32-bit spill slot for half type. Others still on going.

May 18 2022, 3:47 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2022

pengfei added a comment to D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.

I think another way is to report the issue to GCC. From the perspective of the user, GCC should support both {%k1} {z} and {%k1}{z}. Then we don't need the clange on LLVM.

Yes. It is a good idea.
However, it appears that there is no such white space in the instructions as described in Intel's manuals.
So I don't know which one should be the correct format.
Anyway, not a big issue.
I found this problem when using the fuzzer (i.e. AFL) to build Firefox.

May 17 2022, 8:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.

I think another way is to report the issue to GCC. From the perspective of the user, GCC should support both {%k1} {z} and {%k1}{z}. Then we don't need the clange on LLVM.

May 17 2022, 8:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
pengfei added a comment to D125789: FIX the assembly format of the x86 backend to make both clang and gcc happy.

I guess a lot of lines of tests need to update

$ grep -rn " {z}" llvm/test/CodeGen/X86/ | wc -l
7797
May 17 2022, 8:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
pengfei accepted D125084: [test, x86] Fix spurious x86-target-features.c failure.

LGTM. Thanks!

May 17 2022, 8:00 AM · Restricted Project, Restricted Project
pengfei updated the diff for D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Rebased on the avx512fp16 implementation. Still WIP for optimizations and a fast RA issue.

May 17 2022, 6:21 AM · Restricted Project, Restricted Project, Restricted Project
pengfei added inline comments to D125084: [test, x86] Fix spurious x86-target-features.c failure.
May 17 2022, 6:18 AM · Restricted Project, Restricted Project

May 10 2022

pengfei accepted D125159: [CodeGen] Fix ConvertNodeToLibcall for STRICT_FPOWI.

LGTM.

May 10 2022, 8:20 AM · Restricted Project, Restricted Project

May 9 2022

pengfei accepted D125222: [X86] Replace avx512f integer mul reduction builtins with generic builtin.

LGTM.

May 9 2022, 5:48 AM · Restricted Project, Restricted Project
pengfei added inline comments to D125159: [CodeGen] Fix ConvertNodeToLibcall for STRICT_FPOWI.
May 9 2022, 2:10 AM · Restricted Project, Restricted Project
pengfei added inline comments to D125075: [X86][AMX] Multiple configure for AMX register..
May 9 2022, 1:27 AM · Restricted Project, Restricted Project
pengfei added inline comments to D125159: [CodeGen] Fix ConvertNodeToLibcall for STRICT_FPOWI.
May 9 2022, 1:24 AM · Restricted Project, Restricted Project

May 8 2022

pengfei accepted D125170: [Headers][X86] Replace \operation with \code{.operation}.

LGTM, thanks!

May 8 2022, 2:22 AM · Restricted Project, Restricted Project

May 7 2022

pengfei added a comment to D125170: [Headers][X86] Replace \operation with \code{.operation}.

If people prefer we can alternatively use \code{.unparsed} .. \endcode blocks - I'm unsure if these operation blocks are being used in a particular way downstream

May 7 2022, 6:46 PM · Restricted Project, Restricted Project
pengfei accepted D125164: [X86] Fix some signedness errors in x86 headers.

LGTM, thanks!

May 7 2022, 5:41 PM · Restricted Project, Restricted Project
pengfei added a comment to D125164: [X86] Fix some signedness errors in x86 headers.

These intrinsics are interesting. The descriptions on Intrinsic guide are for immediate variant, but all compilers' implementations are register variant. What's more, the codegen from Clang and GCC don't seem correct according to the description of vpsrlw zmm0, zmm0, xmm1. They should do the same broadcast as ICC. https://godbolt.org/z/dcrqdEs8q

May 7 2022, 8:06 AM · Restricted Project, Restricted Project
pengfei added a comment to D125164: [X86] Fix some signedness errors in x86 headers.

Actually the ia32_tzcnt builtins should stay the way they are - other C/C++ intrinsics return unsigned so we'd still end up with adding explicit casts

May 7 2022, 7:48 AM · Restricted Project, Restricted Project
pengfei added a comment to D125164: [X86] Fix some signedness errors in x86 headers.

What do you want to do about _mm512_maskz_srli_epi16 ? The Intel Intrinsic guide has the same mismatch.

May 7 2022, 7:44 AM · Restricted Project, Restricted Project
pengfei added a comment to D125164: [X86] Fix some signedness errors in x86 headers.

One question: is it better to change the define of builtins than explicit casts?

May 7 2022, 6:01 AM · Restricted Project, Restricted Project
pengfei added inline comments to D125159: [CodeGen] Fix ConvertNodeToLibcall for STRICT_FPOWI.
May 7 2022, 4:35 AM · Restricted Project, Restricted Project
pengfei added inline comments to D125159: [CodeGen] Fix ConvertNodeToLibcall for STRICT_FPOWI.
May 7 2022, 1:47 AM · Restricted Project, Restricted Project

May 4 2022

pengfei added inline comments to D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224.
May 4 2022, 8:05 PM · Restricted Project, Restricted Project