User Details
- User Since
- Dec 12 2018, 5:57 PM (224 w, 3 d)
Yesterday
Thanks @e-kud, LGTM.
Test case changes look good to me.
Thu, Mar 30
Wed, Mar 29
I checked no difference in codegen between /EHa and /EHsc in MSVC. So it should be correct for clang as well.
We should land it ASAP since it fixes a crash case.
LGTM.
Tue, Mar 28
FYI, I just got in touch with @tentzen. He is not working with this now, but he said the revert is just a mistake.
I suggest we reland it as is if no strong objections from other reviewers.
We have customers that looking forward to it as well. I'd like to work with community for the followups.
Mon, Mar 27
Sun, Mar 26
Sat, Mar 25
LGTM.
Fri, Mar 24
LGTM.
Thu, Mar 23
Mon, Mar 20
LGTM.
We had an offline discussion on this. I generally got the idea of the design. Let's land it first to see if there're unconsidered cases.
Tested this with cases in #60914. Both got segmentation fault. I think this should not be a correct fix.
Wed, Mar 15
LGTM.
Tue, Mar 14
LGTM.
Mon, Mar 13
Add test case.
Convert one more uint64_t Align into Align Alignment.
Address review comment.
Sun, Mar 12
Support i886 and i986.
Only make OS override i386.
The negative comparison is not correct.
Address review commnets.
X86 tests change looks good.
Sat, Mar 11
Fix lit failure.
Fix typo & add tests.
LGTM.
Fri, Mar 10
Thu, Mar 9
Do you have plan to support minimumNumber?
Wed, Mar 8
Tue, Mar 7
Mon, Mar 6
Fri, Mar 3
Thanks for the fix, but I may not be qualified to approve.
Mar 2 2023
Mar 1 2023
I'm confused. Isn't the patch identical to D143786?
Feb 28 2023
Feb 27 2023
Feb 25 2023
Is this substituted by D144570?
LGTM.
LGTM.
I don't think there exists such an API. We don't record such information for each instruction.
Feb 22 2023
Looks great!
Feb 20 2023
Should asm volatile ("nop"::"S"(405):); be asm volatile ("nop"::"b"(405):);?