Page MenuHomePhabricator

fhahn (Florian Hahn)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2016, 4:39 AM (301 w, 1 d)

Recent Activity

Today

fhahn added inline comments to D109368: [LV] Don't vectorize if we can prove RT + vector cost >= scalar cost..
Fri, May 27, 6:34 AM · Restricted Project, Restricted Project
fhahn updated the diff for D109368: [LV] Don't vectorize if we can prove RT + vector cost >= scalar cost..

Address latest comments, thanks!

Fri, May 27, 6:31 AM · Restricted Project, Restricted Project
fhahn updated the diff for D75981: [LV] Create RT checks during planning, expose cost functions..

Do not expose getInstructionCost, as the latest version of D109368 can simplify use TTI.

Fri, May 27, 5:41 AM · Restricted Project, Restricted Project
fhahn added inline comments to D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..
Fri, May 27, 5:03 AM · Restricted Project, Restricted Project
fhahn added a comment to D126503: [SCEV] Use fact that B >u 0 for A <u B in applyLoopGuards..

@mkazantsev wrote:
Will it still work if c1 and c2 are checked in the loop?

Fri, May 27, 4:55 AM · Restricted Project, Restricted Project
fhahn updated the diff for D126502: [SCEV] Apply conditions involving constants first in applyLoopGuards..

Update sort order to apply conditions that constraint ranges using max/min (predicates != EQ & != NE).

Fri, May 27, 4:52 AM · Restricted Project, Restricted Project
fhahn accepted D126200: [NFC] Change LoopVectorizationCostModel::useOrderedReductions() to be a const function..

LGTM, thanks!

Fri, May 27, 4:21 AM · Restricted Project, Restricted Project
fhahn requested changes to D126460: [SCEV] Add tests where assumes can be used to improve trip multiple..
Fri, May 27, 3:48 AM · Restricted Project, Restricted Project
fhahn planned changes to D126502: [SCEV] Apply conditions involving constants first in applyLoopGuards..

Thanks for taking a look! Unfortunately this only worked by accident and I missed that there aren't any tests with the conditions in reverse order.

Fri, May 27, 3:23 AM · Restricted Project, Restricted Project
fhahn committed rG786c687810a5: [AArch64] Add support for FMA intrinsics to shouldSinkOperands. (authored by fhahn).
[AArch64] Add support for FMA intrinsics to shouldSinkOperands.
Fri, May 27, 2:37 AM · Restricted Project, Restricted Project
fhahn closed D126234: [AArch64] Add support for FMA intrinsics to shouldSinkOperands..
Fri, May 27, 2:37 AM · Restricted Project, Restricted Project

Yesterday

fhahn requested review of D126503: [SCEV] Use fact that B >u 0 for A <u B in applyLoopGuards..
Thu, May 26, 2:51 PM · Restricted Project, Restricted Project
fhahn requested review of D126502: [SCEV] Apply conditions involving constants first in applyLoopGuards..
Thu, May 26, 2:30 PM · Restricted Project, Restricted Project
fhahn committed rG6af5f5697c85: [SCEV] Collect conditions from assumes same way as for branches. (authored by fhahn).
[SCEV] Collect conditions from assumes same way as for branches.
Thu, May 26, 10:18 AM · Restricted Project, Restricted Project
fhahn committed rG9c66ed9b7317: [SCEV] Add test with loop guarded by assume with an AND condition. (authored by fhahn).
[SCEV] Add test with loop guarded by assume with an AND condition.
Thu, May 26, 8:09 AM · Restricted Project, Restricted Project
fhahn accepted D125898: [ControlHeightReduction] Use logical and.

LGTM as this is needed for correctness.

Thu, May 26, 7:07 AM · Restricted Project, Restricted Project
fhahn added inline comments to D119078: [LAA,LV] Add initial support for pointer-diff memory checks..
Thu, May 26, 6:41 AM · Restricted Project, Restricted Project
fhahn added a comment to D126460: [SCEV] Add tests where assumes can be used to improve trip multiple..

Interesting test cases, thanks for sharing! Could you update the description to use #55645 instead of just 55645. This ensures the commit will get linked on the GitHub issue page.

Thu, May 26, 6:23 AM · Restricted Project, Restricted Project
fhahn updated the diff for D126234: [AArch64] Add support for FMA intrinsics to shouldSinkOperands..

Thanks for taking a look!

Thu, May 26, 2:45 AM · Restricted Project, Restricted Project
fhahn committed rGa9a012086a91: [AArch64] Add additional tests for sinking free shuffles for FMAs. (authored by fhahn).
[AArch64] Add additional tests for sinking free shuffles for FMAs.
Thu, May 26, 2:36 AM · Restricted Project, Restricted Project
fhahn committed rGf96aa493f045: [SimpleLoopUnswitch] Always skip trivial select and set condition. (authored by fhahn).
[SimpleLoopUnswitch] Always skip trivial select and set condition.
Thu, May 26, 1:47 AM · Restricted Project, Restricted Project
fhahn committed rG390c0ac28db3: [LV] Fix indentation in tryToCreateWidenRecipe (NFC). (authored by fhahn).
[LV] Fix indentation in tryToCreateWidenRecipe (NFC).
Thu, May 26, 12:54 AM · Restricted Project, Restricted Project

Wed, May 25

fhahn added reviewers for D126363: [VPlan, VP] 1/4 Introduce new recipes to support predicated vectorization: Ayal, gilr.

We store the the %evl as the related value for VPValue *EVL using State.set(EVL, %evl, Part) and then get required value using State.get(EVL, Part).
In this case we can treat EVL similarly to canonical iv, which is not an invariant.

Ok. If that works then having one global EVL per State defined this way should be fine for us for now.

Wed, May 25, 2:03 PM · Restricted Project, Restricted Project, Restricted Project
fhahn updated the diff for D109368: [LV] Don't vectorize if we can prove RT + vector cost >= scalar cost..

Rebased on top of the other changes in this area (D122126, D119078). Those patches landed a while ago, so I think now would be a good time to move fowrad with this. Ping :)

Wed, May 25, 9:30 AM · Restricted Project, Restricted Project
fhahn updated the diff for D75981: [LV] Create RT checks during planning, expose cost functions..

Rebase after recent changes.

Wed, May 25, 4:13 AM · Restricted Project, Restricted Project
fhahn added inline comments to D125029: [VPlan] Exit earlier when trying to widen with scalar VFs..
Wed, May 25, 3:10 AM · Restricted Project, Restricted Project
fhahn committed rGc6e45ea0743b: [VPlan] Exit earlier when trying to widen with scalar VFs. (authored by fhahn).
[VPlan] Exit earlier when trying to widen with scalar VFs.
Wed, May 25, 3:06 AM · Restricted Project, Restricted Project
fhahn closed D125029: [VPlan] Exit earlier when trying to widen with scalar VFs..
Wed, May 25, 3:06 AM · Restricted Project, Restricted Project
fhahn added inline comments to D123537: [VPlan] Model first exit values using VPLiveOut..
Wed, May 25, 1:33 AM · Restricted Project, Restricted Project
fhahn committed rG1ba42dd04b8d: [VPlan] Use MapVector for LiveOuts for deterministic iteration. (authored by fhahn).
[VPlan] Use MapVector for LiveOuts for deterministic iteration.
Wed, May 25, 1:31 AM · Restricted Project, Restricted Project

Tue, May 24

fhahn accepted D126295: [LoopVectorize] Fix assertion failure in fixReduction when tail-folding.

LGTM, thanks! It would probably be more descriptive to say how the issue is fixed in the commit message, e.g. Skip stores of reduction values before trying to widen or something like that.

Tue, May 24, 7:54 AM · Restricted Project, Restricted Project
fhahn added a comment to D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..

Could you check one more time, please?

Yeah I just checked and this crashes for me with a release + assert build (commit is 96323c9f4c10bef5cb5d527970cabc73eab8aa21)

The assertion is: Assertion failed: (II && "Must be an insertelement instruction."), function vectorizeTree, file SLPVectorizer.cpp, line 8543.

Still unable to reproduce but I'll try to investigate it.

Tue, May 24, 5:09 AM · Restricted Project, Restricted Project
fhahn added a comment to D126236: [CaptureTracking] Increase limit but use it for all visited uses..

is there a number you're seeing which roughly matches performance you were getting with typed pointers?

Tue, May 24, 4:26 AM · Restricted Project, Restricted Project
fhahn added a comment to D125574: [BasicBlockUtils] Do not move loop metadata if outer loop header..

LGTM. Please wait for @fhahn LGTM as well.

Tue, May 24, 4:23 AM · Restricted Project, Restricted Project
fhahn added a comment to D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..

Could you check one more time, please?

Tue, May 24, 4:09 AM · Restricted Project, Restricted Project
fhahn added a comment to D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..

Unfortunately the latest version is still causing crashes when build SPEC2017 on X86. Reproducer below:

Tue, May 24, 1:25 AM · Restricted Project, Restricted Project

Mon, May 23

fhahn updated the diff for D126236: [CaptureTracking] Increase limit but use it for all visited uses..

Update patch to actually use 100 as limit

Mon, May 23, 1:04 PM · Restricted Project, Restricted Project
fhahn requested review of D126236: [CaptureTracking] Increase limit but use it for all visited uses..
Mon, May 23, 1:04 PM · Restricted Project, Restricted Project
fhahn requested review of D126234: [AArch64] Add support for FMA intrinsics to shouldSinkOperands..
Mon, May 23, 12:33 PM · Restricted Project, Restricted Project
fhahn committed rG86617256864e: [AArch64] Add tests with free shuffles for indexed fma variants. (authored by fhahn).
[AArch64] Add tests with free shuffles for indexed fma variants.
Mon, May 23, 12:28 PM · Restricted Project, Restricted Project
fhahn added inline comments to D125574: [BasicBlockUtils] Do not move loop metadata if outer loop header..
Mon, May 23, 3:59 AM · Restricted Project, Restricted Project
fhahn committed rG0cc981e021ed: [AArch64] implement isReassocProfitable, disable for (u|s)mlal. (authored by fhahn).
[AArch64] implement isReassocProfitable, disable for (u|s)mlal.
Mon, May 23, 1:42 AM · Restricted Project, Restricted Project
fhahn closed D125895: [AArch64] implement isReassocProfitable, disable for (u|s)mlal..
Mon, May 23, 1:42 AM · Restricted Project, Restricted Project

Sun, May 22

fhahn requested review of D126173: [VPlan] Use Exiting-block instead of Exit-block terminology (NFC)..
Sun, May 22, 12:34 PM · Restricted Project, Restricted Project
fhahn added inline comments to D125029: [VPlan] Exit earlier when trying to widen with scalar VFs..
Sun, May 22, 12:22 PM · Restricted Project, Restricted Project
fhahn updated the diff for D125029: [VPlan] Exit earlier when trying to widen with scalar VFs..

Move code to optimize truncates before scalar VF check. Test to check this added in 0c000d77ad09665a0debeb.

Sun, May 22, 12:18 PM · Restricted Project, Restricted Project
fhahn committed rG419e49621fb4: [LV] Add check line to test interleaving only with induction cast. (authored by fhahn).
[LV] Add check line to test interleaving only with induction cast.
Sun, May 22, 12:14 PM · Restricted Project, Restricted Project
fhahn committed rG145fe571061b: [LV] Use exiting block instead of latch in addUsersInExitBlock. (authored by fhahn).
[LV] Use exiting block instead of latch in addUsersInExitBlock.
Sun, May 22, 10:28 AM · Restricted Project, Restricted Project
fhahn committed rGc230ab6db8b4: [LV] Re-generate check lines for loop-form.ll test. (authored by fhahn).
[LV] Re-generate check lines for loop-form.ll test.
Sun, May 22, 10:28 AM · Restricted Project, Restricted Project
fhahn added a comment to D123537: [VPlan] Model first exit values using VPLiveOut..

Hi @fhahn. This patch looks be the cause of the failure reported by https://lab.llvm.org/buildbot/#/builders/176/builds/1723. As well as on AArch64 I also see the failure on X86_64 when doing the following cross compile:

./bin/clang++ -target aarch64-linux-gnu --sysroot=/opt/aarch64-sysroot --gcc-toolchain=/opt/aarch64-cross-compiler -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Transforms/Scalar -I/home/pmw/projects/upstream-llvm/llvm-project/llvm/lib/Transforms/Scalar -Iinclude -I/home/pmw/projects/upstream-llvm/llvm-project/llvm/include -mcpu=a64fx -msve-vector-bits=512 -mllvm -treat-scalable-fixed-error-as-warning=false -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG    -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/SimpleLoopUnswitch.cpp.o -MF lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/SimpleLoopUnswitch.cpp.o.d -o SimpleLoopUnswitch.cpp.o -c /home/pmw/projects/upstream-llvm/llvm-project/llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp

The failure disappears after locally reverting this patch.

Sun, May 22, 10:27 AM · Restricted Project, Restricted Project
fhahn committed rG97590baead08: [LV] Widen ptr-inductions with scalar uses for scalable VFs. (authored by fhahn).
[LV] Widen ptr-inductions with scalar uses for scalable VFs.
Sun, May 22, 8:25 AM · Restricted Project, Restricted Project

Sat, May 21

fhahn added a reverting change for rGfc9c59c355cb: [SLP]Do not emit extract elements for insertelements users, replace with…: rGaeb19817d66f: Revert "[SLP]Do not emit extract elements for insertelements users, replace….
Sat, May 21, 1:01 PM · Restricted Project, Restricted Project
fhahn committed rGaeb19817d66f: Revert "[SLP]Do not emit extract elements for insertelements users, replace… (authored by fhahn).
Revert "[SLP]Do not emit extract elements for insertelements users, replace…
Sat, May 21, 1:01 PM · Restricted Project, Restricted Project
fhahn added a reverting change for D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly.: rGaeb19817d66f: Revert "[SLP]Do not emit extract elements for insertelements users, replace….
Sat, May 21, 1:01 PM · Restricted Project, Restricted Project
fhahn added a comment to D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..

It looks like this patch is causing SLPVectorizer to crash with the following IR. This blocks building SPEC on X86, so I'll go ahead and revert this for now to unblock testing.

Sat, May 21, 12:57 PM · Restricted Project, Restricted Project
fhahn added inline comments to D123537: [VPlan] Model first exit values using VPLiveOut..
Sat, May 21, 9:44 AM · Restricted Project, Restricted Project
fhahn committed rG3bebec6592a4: [VPlan] Model first exit values using VPLiveOut. (authored by fhahn).
[VPlan] Model first exit values using VPLiveOut.
Sat, May 21, 8:16 AM · Restricted Project, Restricted Project
fhahn committed rGa84896f27066: [LV] Precommit test for PR55167. (authored by fhahn).
[LV] Precommit test for PR55167.
Sat, May 21, 8:16 AM · Restricted Project, Restricted Project
fhahn closed D123537: [VPlan] Model first exit values using VPLiveOut..
Sat, May 21, 8:15 AM · Restricted Project, Restricted Project

Fri, May 20

fhahn added a comment to D124836: [AArch64] Add support for -fzero-call-used-regs.

Hi @void ,

the zero-call-used-regs.ll test gets failed on llvm-clang-x86_64-expensive-checks-ubuntu builder with the following errors:

...
*** Bad machine code: Illegal physical register for instruction ***
- function:    all_arg
- basic block: %bb.0 entry (0x555be568bb88)
- instruction: $q0 = MOVID 0
- operand 0:   $q0
$q0 is not a FPR64 register.
...
Fri, May 20, 2:11 PM · Restricted Project, Restricted Project, Restricted Project
fhahn added a comment to D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.

Thanks for breaking this up!

Fri, May 20, 2:14 AM · Restricted Project, Restricted Project
fhahn accepted D124910: [SCEV] Use umin_seq for BECount of multi-exit loops.

LGTM, thanks! Might be good to wait another day with committing in case @reames has additional thoughts.

Fri, May 20, 2:09 AM · Restricted Project, Restricted Project
fhahn committed rGcd61d4bd2fcd: [LV] Do not LoopSimplify/LCSSA after generating main vector loop. (authored by fhahn).
[LV] Do not LoopSimplify/LCSSA after generating main vector loop.
Fri, May 20, 1:59 AM · Restricted Project, Restricted Project
fhahn closed D125810: [LV] Do not LoopSimplify/LCSSA after generating main vector loop..
Fri, May 20, 1:59 AM · Restricted Project, Restricted Project
fhahn added inline comments to D123537: [VPlan] Model first exit values using VPLiveOut..
Fri, May 20, 1:43 AM · Restricted Project, Restricted Project
fhahn updated the diff for D123537: [VPlan] Model first exit values using VPLiveOut..

Address latest comments, thanks!

Fri, May 20, 1:43 AM · Restricted Project, Restricted Project

Thu, May 19

fhahn accepted D125377: [AArch64] Order STP Q's by ascending address.

LGTM, I think that should be fine. ordering by ascending address is likely also slightly more readable for our users.

Thu, May 19, 1:11 PM · Restricted Project, Restricted Project
fhahn added a comment to D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold.

Thanks!

Thu, May 19, 1:00 PM · Restricted Project, Restricted Project, Restricted Project
fhahn committed rGc90235f0ef0b: [LV] Drop wrap flags for reductions using VP def-use chain. (authored by fhahn).
[LV] Drop wrap flags for reductions using VP def-use chain.
Thu, May 19, 12:37 PM · Restricted Project, Restricted Project
fhahn added a comment to D125987: [SLP] Account for cost of removing FMA opportunities by horizontal reduction.

I think this loss is not only relevant for horizontal reductions, but can pessimize things in general, right?

Thu, May 19, 9:36 AM · Restricted Project, Restricted Project
fhahn accepted D125983: [DeadArgElim] Use poison instead of undef as placeholder for dead arguments.

LGTM, thanks!

Thu, May 19, 9:08 AM · Restricted Project, Restricted Project, Restricted Project
fhahn committed rG32d6ef36d6c0: [SimpleLoopUnswitch] Skip trivial selects during trivial unswitching. (authored by fhahn).
[SimpleLoopUnswitch] Skip trivial selects during trivial unswitching.
Thu, May 19, 9:02 AM · Restricted Project, Restricted Project
fhahn committed rGdf56fb44f549: [VPlan] Update VPWidenMemoryInstruction to not inherit from VPValue. (authored by fhahn).
[VPlan] Update VPWidenMemoryInstruction to not inherit from VPValue.
Thu, May 19, 8:25 AM · Restricted Project, Restricted Project
fhahn accepted D125887: [CGP] Freeze condition when despeculating ctlz/cttz.

LGTM, thanks!

Thu, May 19, 8:20 AM · Restricted Project, Restricted Project
fhahn added a comment to D124867: [SLP][NFC] Pre-commit test showing vectorization preventing FMA.

Thanks for the updates!

Thu, May 19, 8:15 AM · Restricted Project, Restricted Project

Wed, May 18

fhahn requested review of D125895: [AArch64] implement isReassocProfitable, disable for (u|s)mlal..
Wed, May 18, 8:42 AM · Restricted Project, Restricted Project
fhahn committed rGa74e07590858: [AArch64] Add tests showing reassoc breaks (s|u)ml(a|s)l selection. (authored by fhahn).
[AArch64] Add tests showing reassoc breaks (s|u)ml(a|s)l selection.
Wed, May 18, 8:41 AM · Restricted Project, Restricted Project
fhahn added a comment to D125299: [ValueTracking] Enable -branch-on-poison-as-ub by default.

Sounds good to me in general. I think there are at least 2 known issues with SimplifyCFG & LoopUnroll introducing branches on poison/undef. Linked to https://github.com/llvm/llvm-project/issues/45489. If you know of other issues in that area it might be good to all link them to that issue, so it is easier to keep track of the outstanding issues

ControlHeightReduction and LoopUnroll have been fixed, patches for IndVarSimplify (https://reviews.llvm.org/D124910), JumpThreading (https://reviews.llvm.org/D125869) and CodeGenPrepare (https://reviews.llvm.org/D125887) are pending.

Wed, May 18, 7:39 AM · Restricted Project, Restricted Project
fhahn retitled D123537: [VPlan] Model first exit values using VPLiveOut. from [VPlan] Model first exit values using VPLiveOut to [VPlan] Model first exit values using VPLiveOut..
Wed, May 18, 1:42 AM · Restricted Project, Restricted Project
fhahn retitled D123537: [VPlan] Model first exit values using VPLiveOut. from [VPlan] Model first exit values in VPlan. to [VPlan] Model first exit values using VPLiveOut.
Wed, May 18, 1:42 AM · Restricted Project, Restricted Project
fhahn updated the summary of D123537: [VPlan] Model first exit values using VPLiveOut..
Wed, May 18, 1:41 AM · Restricted Project, Restricted Project
fhahn updated the diff for D123537: [VPlan] Model first exit values using VPLiveOut..

Address latest comments, thanks!

Wed, May 18, 1:41 AM · Restricted Project, Restricted Project
fhahn committed rGfcfb86483b29: [LV] set Header earlier, use variable instead of repeated access (NFC). (authored by fhahn).
[LV] set Header earlier, use variable instead of repeated access (NFC).
Wed, May 18, 1:30 AM · Restricted Project, Restricted Project

Tue, May 17

fhahn added a comment to D125810: [LV] Do not LoopSimplify/LCSSA after generating main vector loop..

IIRC the reason for calling formLCSSARecursively was to make sure we can handle live outs and reductions properly, which we seem to still be able to do (based on LIT test updates).

Tue, May 17, 2:26 PM · Restricted Project, Restricted Project
fhahn added inline comments to D123537: [VPlan] Model first exit values using VPLiveOut..
Tue, May 17, 12:15 PM · Restricted Project, Restricted Project
fhahn updated the diff for D123537: [VPlan] Model first exit values using VPLiveOut..

Address comments, greatly simplify patch. The new version adds VPExitValues for all values used by LCSSA phis. Non-vplan based helper (fixupIVUsers, fixFirstOrderRecurrence, fixReduction) remove VPExitValues for LCSSA phis they handle directly, before fixing the remaining VPExitValues.

Tue, May 17, 12:13 PM · Restricted Project, Restricted Project
fhahn requested review of D125810: [LV] Do not LoopSimplify/LCSSA after generating main vector loop..
Tue, May 17, 9:59 AM · Restricted Project, Restricted Project
fhahn committed rGd92cec4c96eb: [LV] Regenerate check lines for some tests. (authored by fhahn).
[LV] Regenerate check lines for some tests.
Tue, May 17, 9:47 AM · Restricted Project, Restricted Project
fhahn committed rG5b00d13c0071: [LV] Fetch vector loop region once and remember it (NFC). (authored by fhahn).
[LV] Fetch vector loop region once and remember it (NFC).
Tue, May 17, 7:58 AM · Restricted Project, Restricted Project
fhahn committed rGc1a9d14982f8: [VPlan] Move usesScalars/onlyFirstLaneUsed to VPUser. (authored by fhahn).
[VPlan] Move usesScalars/onlyFirstLaneUsed to VPUser.
Tue, May 17, 3:20 AM · Restricted Project, Restricted Project
fhahn closed D124936: [VPlan] Move usesScalars/onlyFirstLaneUsed to VPUser..
Tue, May 17, 3:20 AM · Restricted Project, Restricted Project
fhahn updated the diff for D124936: [VPlan] Move usesScalars/onlyFirstLaneUsed to VPUser..

Address comments & aebase before landing.

Tue, May 17, 3:17 AM · Restricted Project, Restricted Project
fhahn accepted D125275: Force HAVE_LIB_RT to NO when building with Xcode toolchains.

LGTM as workaround to get the bots back to working.

Tue, May 17, 2:55 AM · Restricted Project
fhahn added a comment to D125571: [SLP]Do not vectorize non-profitable alternate nodes..

Just a heads up, we are seeing ~6-7% regressions on some benchmarks with this change. I'll try to narrow down a reproducer.

Tue, May 17, 12:19 AM · Restricted Project, Restricted Project

Mon, May 16

fhahn committed rGb7315ffc3c92: [LAA,LV] Add initial support for pointer-diff memory checks. (authored by fhahn).
[LAA,LV] Add initial support for pointer-diff memory checks.
Mon, May 16, 7:27 AM · Restricted Project, Restricted Project
fhahn closed D119078: [LAA,LV] Add initial support for pointer-diff memory checks..
Mon, May 16, 7:27 AM · Restricted Project, Restricted Project
fhahn updated the diff for D119078: [LAA,LV] Add initial support for pointer-diff memory checks..

Rebased before commit.

Mon, May 16, 4:06 AM · Restricted Project, Restricted Project
fhahn added reviewers for D125574: [BasicBlockUtils] Do not move loop metadata if outer loop header.: Meinersbur, reames.

Thanks for the patch! Makes sense, I added some suggestions with respect to the test.

Mon, May 16, 12:55 AM · Restricted Project, Restricted Project
fhahn added inline comments to D121899: [LoopVectorize] Optimise away the icmp when tail-folding for some low trip counts.
Mon, May 16, 12:43 AM · Restricted Project, Restricted Project
fhahn accepted D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold.

Still LGTM, thanks! The remaining suggestion can be addressed directly before committing the patch.

Mon, May 16, 12:40 AM · Restricted Project, Restricted Project, Restricted Project