- User Since
- Aug 18 2016, 4:39 AM (189 w, 1 d)
Specify that standard conversion rules do not apply to assignments for matrix types.
Use 20 bits in MatrixTypeBitfields for both number of rows and number of columns. This leaves 24 bits for NumTypeBits, while providing a large ranges for number of rows/columns.
Fix wrong formatting of check lines..
Implement conversion for matrix/scalar variants.
Implement conversions for matrix/scalar variants.
Update arithmetic conversion rules after recent discussion on cfe-dev.
Wed, Apr 1
I assume you are referring to code in other passes, right? I think we probably have code assuming both the new behaviour and the old one and we somehow have to consolidate the code base. Probably best to discuss that at the langref change/llvm-Dev?
Avoid inserting calls by pre-computing set of the last memorydefs or phis before a function exit.
Use placeholder type for incomplete matrix index expressions, as suggested by @rjmccall
Rebased after adding constantrange_including_undef to ValueLattice.
I think it would be helpful to describe what goes wrong in the patch description.
Generally, I think this code is a bit convoluted, and I think it would be clearer to rewrite along these lines.
Tue, Mar 31
I've moved the expected raw string literals to variables in rG6120cb42f797. It looks like that was enough to silence the warning at least for the llvm-clang-x86_64-expensive-checks-win (http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/22891). Please let me know if there are any other configurations where this did not fix the warning.
Mon, Mar 30
I've adjusted the defaults after rG05f0e598ab26: per default, markConstantRange & co assume that the constant range does not contain undef (existing behavior) and isConstantRange/getConstantRange allow constant ranges including undef (existing behavior).
Thanks for taking a look @dexonsmith!
Adjust documentation in a few more places, add assertions to make sure operands of binary ops agree on the layout.
Remove unnecessary updates, use DT::dominates in stead of OrderedInstructions, after DT::dominates now uses the BB local numbering recently committed.
Sun, Mar 29
Adjust bb numbers in tests after change to creating BBs first.
Please prefix the commit message with something like [NewGVN]
Sat, Mar 28
We should probably also think about what to do with all the tests that contain branches on undef. Also, bugpoint should probably stop creating branches on undef with this spelled out as is?
Thanks for all the input!
Update test checking VPBB iterator, remove newline from printing.
Fri, Mar 27
Thu, Mar 26
Update according to comments on cfe-dev.