Page MenuHomePhabricator

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (155 w, 6 d)

Recent Activity

Fri, Jul 19

mstorsjo created D65018: [LLD] [COFF] Unbreak sorting of mingw comdat .tls sections after SVN r363457.
Fri, Jul 19, 2:05 PM · Restricted Project

Tue, Jul 16

mstorsjo accepted D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default.

LGTM, although you still have to rebase it past the change to camelBack casing of variables :-)

Tue, Jul 16, 4:23 AM · Restricted Project

Mon, Jul 15

mstorsjo added a comment to D64694: Fix heapapi.h dependency in asan_malloc_win.cc.

Thanks! Seems to build fine for me now.

Mon, Jul 15, 11:52 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D59995: [LV] Exclude loop-invariant inputs from scalar cost computation..

This triggers failed asserts in some cases, reproable with https://martin.st/temp/loadimage-preproc.cpp.xz, with clang++ -target i686-w64-mingw32 -c -O3 loadimage-preproc.cpp. Will post a proper bug report later today, unless someone else beats me to it.

Thanks for reporting the issue, should be fixed in rL366049.

Mon, Jul 15, 11:43 AM · Restricted Project

Sun, Jul 14

mstorsjo added a comment to D59995: [LV] Exclude loop-invariant inputs from scalar cost computation..

This triggers failed asserts in some cases, reproable with https://martin.st/temp/loadimage-preproc.cpp.xz, with clang++ -target i686-w64-mingw32 -c -O3 loadimage-preproc.cpp. Will post a proper bug report later today, unless someone else beats me to it.

Sun, Jul 14, 11:44 PM · Restricted Project

Fri, Jul 12

mstorsjo added a comment to D64694: Fix heapapi.h dependency in asan_malloc_win.cc.

Thanks for the quick action, this is almost perfect! In my env I had to add an explicit stddef.h include (which didn't cause trouble with use of free) in order to get a typedef of size_t.

Fri, Jul 12, 10:35 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

Sorry for not testing out this commit until it hit the tree and not commenting on this before. This one turned out to break MinGW builds for a few different reasons, that I'll comment on inline.

Fri, Jul 12, 1:41 PM · Restricted Project, Restricted Project

Thu, Jul 11

mstorsjo committed rG6bd26db06aae: [COFF] Share the tail in delayimport symbol thunks (authored by mstorsjo).
[COFF] Share the tail in delayimport symbol thunks
Thu, Jul 11, 2:23 PM
mstorsjo committed rL365823: [COFF] Share the tail in delayimport symbol thunks.
[COFF] Share the tail in delayimport symbol thunks
Thu, Jul 11, 2:22 PM
mstorsjo closed D64288: [LLD] [COFF] Share the tail in delayimport symbol thunks.
Thu, Jul 11, 2:22 PM · Restricted Project

Mon, Jul 8

mstorsjo added a comment to D64288: [LLD] [COFF] Share the tail in delayimport symbol thunks.

Any other concerns with the patch, or is it ok as is?

Mon, Jul 8, 11:05 PM · Restricted Project
mstorsjo added inline comments to D64288: [LLD] [COFF] Share the tail in delayimport symbol thunks.
Mon, Jul 8, 8:26 AM · Restricted Project

Sun, Jul 7

mstorsjo committed rG8d9d290d4c07: [ARM] Add support for MSVC stack cookie checking (authored by mstorsjo).
[ARM] Add support for MSVC stack cookie checking
Sun, Jul 7, 11:59 AM
mstorsjo committed rL365283: [ARM] Add support for MSVC stack cookie checking.
[ARM] Add support for MSVC stack cookie checking
Sun, Jul 7, 11:59 AM
mstorsjo closed D64292: [ARM] Add support for MSVC stack cookie checking.
Sun, Jul 7, 11:59 AM · Restricted Project

Sat, Jul 6

mstorsjo added inline comments to D64292: [ARM] Add support for MSVC stack cookie checking.
Sat, Jul 6, 9:52 PM · Restricted Project
mstorsjo created D64292: [ARM] Add support for MSVC stack cookie checking.
Sat, Jul 6, 1:50 PM · Restricted Project
mstorsjo created D64288: [LLD] [COFF] Share the tail in delayimport symbol thunks.
Sat, Jul 6, 12:49 PM · Restricted Project

Mon, Jul 1

mstorsjo requested changes to D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default.
Mon, Jul 1, 2:25 PM · Restricted Project

Fri, Jun 28

mstorsjo committed rG5cbff4317821: [COFF] Fix .rsrc sections with differing permissions (authored by mstorsjo).
[COFF] Fix .rsrc sections with differing permissions
Fri, Jun 28, 10:15 AM
mstorsjo committed rL364660: [COFF] Fix .rsrc sections with differing permissions.
[COFF] Fix .rsrc sections with differing permissions
Fri, Jun 28, 10:15 AM
mstorsjo closed D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions.
Fri, Jun 28, 10:15 AM · Restricted Project

Thu, Jun 27

mstorsjo updated the diff for D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions.

Added the comment Rui requested. I also renamed the obj file from .obj to .o, as it is created with windres, not cvtres.

Thu, Jun 27, 1:56 PM · Restricted Project
mstorsjo added inline comments to D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions.
Thu, Jun 27, 1:55 PM · Restricted Project

Wed, Jun 26

mstorsjo added inline comments to D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions.
Wed, Jun 26, 11:42 PM · Restricted Project
mstorsjo created D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions.
Wed, Jun 26, 12:35 PM · Restricted Project

Tue, Jun 25

mstorsjo added inline comments to D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default.
Tue, Jun 25, 8:48 PM · Restricted Project
mstorsjo added a comment to D63109: lld-link: Reject more than one resource .obj file.

I think all four combinations of {llvm-cvtres,cvtres.exe} x {llvm-link,link.exe} should have the same behavior. What does link.exe say to two windres outputs? What does GNU ld do with two cvtres.exe inputs?

Tue, Jun 25, 2:47 PM · Restricted Project
mstorsjo accepted D63743: [llvm-shlib] Do not use version script when building with MinGW.

LGTM

Tue, Jun 25, 11:32 AM · Restricted Project

Mon, Jun 24

mstorsjo added a reviewer for D63743: [llvm-shlib] Do not use version script when building with MinGW: rnk.

I'd suggest skipping the lld condition, the version script adds no value here.

Mon, Jun 24, 10:21 PM · Restricted Project
mstorsjo added a comment to D63109: lld-link: Reject more than one resource .obj file.

Actually, it turns out that GNU windres does things differently - GNU ld can link two resource object files from GNU windres, and resources from both end up reachable. When faced with two resource files from llvm-cvtres, only resources from the first one ends up accessible. In the converse case, if lld is given a resource object file from GNU windres (even a single one), those resources aren't reachable at all.

Mon, Jun 24, 2:24 PM · Restricted Project
mstorsjo added a comment to D63109: lld-link: Reject more than one resource .obj file.

Sorry for not replying, I'm on vacation.

Mon, Jun 24, 11:44 AM · Restricted Project

Sun, Jun 23

mstorsjo added a comment to D63109: lld-link: Reject more than one resource .obj file.

Actually, I'm leaning towards making this only a warning in MinGW cases. If multiple resource objects are passed and the .rsrc$01 sections are concatenated, is the effect that only the first one actually is read and used, or what does happen?

Sun, Jun 23, 1:01 PM · Restricted Project

Sat, Jun 22

mstorsjo added a comment to D63109: lld-link: Reject more than one resource .obj file.

link.exe's /wholearchive semantics on the other hand mean that it wouldn't load the resource object files from the .lib file at all. Since this scenario is probably still an unlikely corner case, the difference in behavior here seems fine -- and lld-link might have to change to use link.exe's /wholearchive semantics in the future anyways.

Sat, Jun 22, 1:24 PM · Restricted Project

Jun 21 2019

mstorsjo added a comment to D62625: LFTR for multiple exit loops.

Compile time regression. (I build the project it's part of with a 120 second timeout per translation unit, enforced with ulimit -t 120, that's why I noticed.)

If you could provide an IR reproducer, and ideally a hint where to look, I can see what I find. Please file a bug with reproduction instructions and an IR attachment.

Jun 21 2019, 11:49 AM · Restricted Project

Jun 20 2019

mstorsjo added a comment to D62625: LFTR for multiple exit loops.

I just ran into a performance regression due to this commit. With https://martin.st/temp/glew-preproc-i686.c, compiling with clang -target i686-w64-mingw32 -c -O3 glew-preproc-i686.c went from 73 seconds before this commit, to 133 seconds afterwards.

Clarification here. Do you mean this was a compile time regression? Or a runtime regression? (i.e. is your clang here build with a different compiler? Or is this a self host?)

Jun 20 2019, 10:27 PM · Restricted Project
mstorsjo added a comment to D62625: LFTR for multiple exit loops.

I just ran into a performance regression due to this commit. With https://martin.st/temp/glew-preproc-i686.c, compiling with clang -target i686-w64-mingw32 -c -O3 glew-preproc-i686.c went from 73 seconds before this commit, to 133 seconds afterwards.

Jun 20 2019, 2:01 PM · Restricted Project

Jun 16 2019

mstorsjo added a comment to D63109: lld-link: Reject more than one resource .obj file.

FWIW, I ran into one error with this on VLC. In one case, a static library ends up (erroneously) containing a resource object file. This static library is included with the --whole-archive option (indirectly, via lots of libtool magic) when linking a DLL, which also contains a resource object files of its own.

In that case, it's possible to fix the issue by removing the intermediate static library which seems to be pointless at the moment. But extending lld to ignore resource object files when linking with --whole-archive would probably be good.

Jun 16 2019, 12:16 PM · Restricted Project
mstorsjo added a comment to D63109: lld-link: Reject more than one resource .obj file.

FWIW, I ran into one error with this on VLC. In one case, a static library ends up (erroneously) containing a resource object file. This static library is included with the --whole-archive option (indirectly, via lots of libtool magic) when linking a DLL, which also contains a resource object files of its own.

Jun 16 2019, 12:12 PM · Restricted Project

Jun 14 2019

mstorsjo committed rG2de984cd3046: [COFF] Strip section name suffix from mingw comdats (authored by mstorsjo).
[COFF] Strip section name suffix from mingw comdats
Jun 14 2019, 2:02 PM
mstorsjo committed rGc3b1d730d69f: [COFF] Handle .eh_frame$symbol as associative comdat for MinGW (authored by mstorsjo).
[COFF] Handle .eh_frame$symbol as associative comdat for MinGW
Jun 14 2019, 2:02 PM
mstorsjo committed rL363457: [COFF] Strip section name suffix from mingw comdats.
[COFF] Strip section name suffix from mingw comdats
Jun 14 2019, 2:01 PM
mstorsjo closed D63352: [LLD] [COFF] Strip section name suffix from mingw comdats.
Jun 14 2019, 2:01 PM · Restricted Project
mstorsjo committed rL363456: [COFF] Handle .eh_frame$symbol as associative comdat for MinGW.
[COFF] Handle .eh_frame$symbol as associative comdat for MinGW
Jun 14 2019, 2:01 PM
mstorsjo closed D63350: [LLD] [COFF] Handle .eh_frame$symbol as associative comdat for MinGW.
Jun 14 2019, 2:01 PM · Restricted Project
mstorsjo retitled D63352: [LLD] [COFF] Strip section name suffix from mingw comdats from [COFF] Strip section name suffix from mingw comdats to [LLD] [COFF] Strip section name suffix from mingw comdats.
Jun 14 2019, 11:59 AM · Restricted Project
mstorsjo created D63352: [LLD] [COFF] Strip section name suffix from mingw comdats.
Jun 14 2019, 11:58 AM · Restricted Project
mstorsjo created D63350: [LLD] [COFF] Handle .eh_frame$symbol as associative comdat for MinGW.
Jun 14 2019, 11:56 AM · Restricted Project
mstorsjo committed rGff4e0a9f3e4a: [MinGW] Support the --subsystem=val option in joined form (authored by mstorsjo).
[MinGW] Support the --subsystem=val option in joined form
Jun 14 2019, 10:48 AM
mstorsjo committed rGb20fefc89b85: [COFF] Allow setting subsystem versions while inferring the subsystem type… (authored by mstorsjo).
[COFF] Allow setting subsystem versions while inferring the subsystem type…
Jun 14 2019, 10:48 AM
mstorsjo committed rG6f047ae58bab: [MinGW] Support the --{major,minor}-{os,subsystem}-version options (authored by mstorsjo).
[MinGW] Support the --{major,minor}-{os,subsystem}-version options
Jun 14 2019, 10:48 AM
mstorsjo committed rL363433: [MinGW] Support the --subsystem=val option in joined form.
[MinGW] Support the --subsystem=val option in joined form
Jun 14 2019, 10:48 AM
mstorsjo closed D63250: [LLD] [MinGW] Support the --subsystem=val option in joined form.
Jun 14 2019, 10:47 AM · Restricted Project
mstorsjo committed rL363432: [MinGW] Support the --{major,minor}-{os,subsystem}-version options.
[MinGW] Support the --{major,minor}-{os,subsystem}-version options
Jun 14 2019, 10:47 AM
mstorsjo closed D63249: [LLD] [MinGW] Support the --{major,minor}-{os,subsystem}-version options.
Jun 14 2019, 10:47 AM · Restricted Project
mstorsjo committed rL363431: [COFF] Allow setting subsystem versions while inferring the subsystem type….
[COFF] Allow setting subsystem versions while inferring the subsystem type…
Jun 14 2019, 10:47 AM
mstorsjo closed D63248: [LLD] [COFF] Allow setting subsystem versions while inferring the subsystem type implicitly.
Jun 14 2019, 10:47 AM · Restricted Project
mstorsjo added a comment to D62939: Fix a bug w/inbounds invalidation in LFTR (was: Strengthen LFTR's ability to replace IVs).

This caused a regression, where compilation now crashes. See https://bugs.llvm.org/show_bug.cgi?id=42279 for details.

Jun 14 2019, 1:25 AM · Restricted Project

Jun 13 2019

mstorsjo created D63250: [LLD] [MinGW] Support the --subsystem=val option in joined form.
Jun 13 2019, 3:54 AM · Restricted Project
mstorsjo created D63249: [LLD] [MinGW] Support the --{major,minor}-{os,subsystem}-version options.
Jun 13 2019, 3:48 AM · Restricted Project
mstorsjo retitled D63248: [LLD] [COFF] Allow setting subsystem versions while inferring the subsystem type implicitly from [COFF] Allow setting subsystem versions while inferring the subsystem type implicitly to [LLD] [COFF] Allow setting subsystem versions while inferring the subsystem type implicitly.
Jun 13 2019, 3:46 AM · Restricted Project
mstorsjo created D63248: [LLD] [COFF] Allow setting subsystem versions while inferring the subsystem type implicitly.
Jun 13 2019, 3:46 AM · Restricted Project

Jun 11 2019

mstorsjo added a comment to D63109: lld-link: Reject more than one resource .obj file.

The only real way to run into this is if users manually convert .res files to .obj files by running cvtres and then handing the resulting .obj files to lld-link instead, which in practice likely never happens.

Jun 11 2019, 11:23 AM · Restricted Project

Jun 10 2019

mstorsjo committed rGbb12396f9175: [Driver] Look for -m in response files as well (authored by mstorsjo).
[Driver] Look for -m in response files as well
Jun 10 2019, 1:09 PM
mstorsjo committed rL362977: [Driver] Look for -m in response files as well.
[Driver] Look for -m in response files as well
Jun 10 2019, 1:08 PM
mstorsjo closed D63024: [LLD] [Driver] Look for -m in response files as well.
Jun 10 2019, 1:08 PM · Restricted Project
mstorsjo updated the diff for D63024: [LLD] [Driver] Look for -m in response files as well.

Avoid expanding unless no -m option was found.

Jun 10 2019, 5:15 AM · Restricted Project
mstorsjo updated the diff for D63024: [LLD] [Driver] Look for -m in response files as well.

Expand only in isPETarget, expand in the mingw driver as well.

Jun 10 2019, 5:08 AM · Restricted Project
mstorsjo added inline comments to D63024: [LLD] [Driver] Look for -m in response files as well.
Jun 10 2019, 4:56 AM · Restricted Project
mstorsjo updated the diff for D63024: [LLD] [Driver] Look for -m in response files as well.

Localized the extra expansion to the ELF case, use the host platform native quoting style.

Jun 10 2019, 4:17 AM · Restricted Project
mstorsjo added a comment to D63024: [LLD] [Driver] Look for -m in response files as well.

I'm not particularly worried about the performance impact of doubly-expanding response files. If it is proved to be too slow, we need to do something, but until then I wouldn't optimize it.

But at least we can expand response files only for GNU flavor. For COFF and WASM linkers, we don't have to expand them at this stage.

Jun 10 2019, 3:23 AM · Restricted Project
mstorsjo added a comment to D63024: [LLD] [Driver] Look for -m in response files as well.

Do you have to support --rsp-quoting for the use case that you want to support?

Not for my use case, no. But Reid wanted to move all expansion of response files out from the individual linkers here, to avoid reading (and allocating memory for) the (potentially large) response file twice. And in that case, we must handle --rsp-quoting perfectly here.

Each flavor's link() function is a public interface, and each function needs to do what the command would do when the same argument strings are given. That means we need to expand response files when the linker is invoked by lld::{coff,elf,wasm,..}::link().

Jun 10 2019, 2:33 AM · Restricted Project
mstorsjo added a comment to D63024: [LLD] [Driver] Look for -m in response files as well.

Do you have to support --rsp-quoting for the use case that you want to support?

Jun 10 2019, 1:05 AM · Restricted Project

Jun 8 2019

mstorsjo added a comment to D63024: [LLD] [Driver] Look for -m in response files as well.
In D63024#1534763, @rnk wrote:

For links that use response files (i.e. most of them) this effectively leaks a second copy of the entire response file. Every argument needs to be put in the string saver so it can be null terminated. Response files tend to be large enough that I'd prefer it if we didn't do that.

One way we could address this is to try to calculate the flavor twice:

  • First, use the unexpanded arguments to guess the flavor
  • Use the guessed flavor to expand response files: Windows tokenization for lld-link, GNU for everyone else
  • Re-parse the flavor using the expanded arguments, and call the appropriate entry point with those arguments
  • Remove existing rsp expansion code
Jun 8 2019, 11:53 AM · Restricted Project
mstorsjo committed rG6ddd7aa4c301: [ELF] [PPC] Fix a typo from SVN r362721 (authored by mstorsjo).
[ELF] [PPC] Fix a typo from SVN r362721
Jun 8 2019, 11:26 AM
mstorsjo committed rG4962f9464da8: [MinGW] Support the -u/--undefined option. (authored by mstorsjo).
[MinGW] Support the -u/--undefined option.
Jun 8 2019, 11:26 AM
mstorsjo committed rGc02f6bf07f6b: [COFF] Add an lld specific option /includeoptional (authored by mstorsjo).
[COFF] Add an lld specific option /includeoptional
Jun 8 2019, 11:25 AM
mstorsjo committed rL362883: [ELF] [PPC] Fix a typo from SVN r362721.
[ELF] [PPC] Fix a typo from SVN r362721
Jun 8 2019, 11:23 AM
mstorsjo committed rL362882: [MinGW] Support the -u/--undefined option..
[MinGW] Support the -u/--undefined option.
Jun 8 2019, 11:23 AM
mstorsjo closed D62876: [LLD] [MinGW] Support the -u/--undefined option..
Jun 8 2019, 11:23 AM · Restricted Project
mstorsjo committed rL362881: [COFF] Add an lld specific option /includeoptional.
[COFF] Add an lld specific option /includeoptional
Jun 8 2019, 11:23 AM
mstorsjo closed D62976: [LLD] [COFF] Add an lld specific option /includeoptional.
Jun 8 2019, 11:23 AM · Restricted Project

Jun 7 2019

mstorsjo created D63024: [LLD] [Driver] Look for -m in response files as well.
Jun 7 2019, 12:59 PM · Restricted Project
mstorsjo updated the diff for D62976: [LLD] [COFF] Add an lld specific option /includeoptional.

Adjusted to make it work more like how this is implemented in the ELF linker; still failing (and properly so) if there's real undefined references to a symbol that was requested with the new option (-u in GNU ld).

Jun 7 2019, 12:33 PM · Restricted Project
mstorsjo added a comment to D62976: [LLD] [COFF] Add an lld specific option /includeoptional.

I guess that my previous comment addresses the issue?

Jun 7 2019, 4:20 AM · Restricted Project
mstorsjo added a comment to D62981: [DomTreeUpdater] Add all insert before all delete updates to reduce compile time..

I don't know this area so I can't comment on it from that perspective, but it does indeed speed up my case, to even faster than it was before the regression. On my system, it originally took 75 s to compile, 220 s after the regression, and now 62 s with this patch. So looking good in that aspect at least!

Jun 7 2019, 2:03 AM · Restricted Project
mstorsjo added inline comments to D62976: [LLD] [COFF] Add an lld specific option /includeoptional.
Jun 7 2019, 1:42 AM · Restricted Project

Jun 6 2019

mstorsjo accepted D62984: [COFF] Fix /export:foo=bar when bar is a weak alias.

Looks good and thought through. I had a few nits though.

Jun 6 2019, 9:12 PM · Restricted Project
mstorsjo updated the diff for D62876: [LLD] [MinGW] Support the -u/--undefined option..

Mimic the real -u option behavior properly.

Jun 6 2019, 1:05 PM · Restricted Project
mstorsjo created D62976: [LLD] [COFF] Add an lld specific option /includeoptional.
Jun 6 2019, 1:04 PM · Restricted Project

Jun 5 2019

mstorsjo added a comment to D62751: [Utils] Clean another duplicated util method..

This caused a serious compile time regression. https://martin.st/temp/glew-preproc.c used to take 75 s to compile, now it takes 220 s. Repro with clang -target x86_64-w64-mingw32 -c -O3 glew-preproc.c.

Jun 5 2019, 11:47 PM · Restricted Project

Jun 4 2019

mstorsjo created D62876: [LLD] [MinGW] Support the -u/--undefined option..
Jun 4 2019, 1:25 PM · Restricted Project
mstorsjo added a reviewer for D62844: lld/macho application_extension support : ruiu.

Can you add a testcase for this? Also it's appreciated if the uploaded diffs are made with a larger context (diff -U999 or similar) to allow expanding the context here in phabricator.

Jun 4 2019, 12:27 PM · Restricted Project, lld

Jun 1 2019

mstorsjo added a comment to D62435: Add Attribute NoThrow as an Exception Specifier Type.

This change had another breaking effect as well, for the MinGW target. Code that implements a COM interface easily ends up overriding a __declspec(nothrow) function with a method that in most cases (at least in cases that follow the microsoft sample code) lacks the same attribute. For code with -fms-extensions, this is a warning (as all exception spec mismatches are non-fatal there), but MinGW code doesn't necessarily use this option. See https://bugs.llvm.org/show_bug.cgi?id=42100 for full issue report and discussion.

Jun 1 2019, 12:05 PM · Restricted Project, Restricted Project

May 31 2019

mstorsjo added a comment to D62435: Add Attribute NoThrow as an Exception Specifier Type.

This change broke compiling Qt on MinGW, see https://bugs.llvm.org/show_bug.cgi?id=42089. Trivially reproducible by trying to compile a snippet that looks like this:

May 31 2019, 3:06 AM · Restricted Project, Restricted Project

May 30 2019

mstorsjo committed rG0fe645c0866b: [InstCombine] Avoid use after free in DenseMap, when built with GCC (authored by mstorsjo).
[InstCombine] Avoid use after free in DenseMap, when built with GCC
May 30 2019, 1:53 PM
mstorsjo committed rL362150: [InstCombine] Avoid use after free in DenseMap, when built with GCC.
[InstCombine] Avoid use after free in DenseMap, when built with GCC
May 30 2019, 1:53 PM
mstorsjo closed D62624: [InstCombine] Avoid use after free in DenseMap, when built with GCC.
May 30 2019, 1:53 PM · Restricted Project
mstorsjo added reviewers for D62692: llvm-rc: accept /D, /U, /I parameters joined or separate like rc.exe: thakis, zturner, amccarth.

Please add testcases for these changes. You could e.g. change some of the existing tests in test/tools/llvm-rc so that both forms are exercised, or add a new test there that uses that form.

May 30 2019, 12:03 PM · Restricted Project

May 29 2019

mstorsjo added a comment to D62624: [InstCombine] Avoid use after free in DenseMap, when built with GCC.

Testcase and slightly longer description is available at https://bugs.llvm.org/show_bug.cgi?id=42065.

May 29 2019, 2:00 PM · Restricted Project