Page MenuHomePhabricator

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (234 w, 4 d)

Recent Activity

Today

mstorsjo added a comment to D93764: [LoopUnswitch] Implement first version of partial unswitching..

Thanks! I think it looks mostly good now - I'm still seeing some breakage compared to thursday, but I'll have to bisect those errors separately to see where they broke.

Fri, Jan 22, 11:25 AM · Restricted Project
mstorsjo added a comment to D93764: [LoopUnswitch] Implement first version of partial unswitching..

I've got one problem narrowed down to one source file in a project; https://martin.st/temp/dav1d-thread_task-preproc.c, compiled with clang -target x86_64-w64-mingw32 -c -O3 does trigger the issue - I haven't dug in closer to zoom in on exactly what it is though - hopefully you can spot the differences.

One issue with the file was that the patch did not account for atomic loads and would add additional atomic loads. I fixed that in 86991d323133. Please let me know if that fixes your issue. Otherwise I'll revert the patch to investigate further.

Fri, Jan 22, 9:59 AM · Restricted Project
mstorsjo added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Fri, Jan 22, 4:06 AM
mstorsjo added a comment to D93764: [LoopUnswitch] Implement first version of partial unswitching..

I've got one problem narrowed down to one source file in a project; https://martin.st/temp/dav1d-thread_task-preproc.c, compiled with clang -target x86_64-w64-mingw32 -c -O3 does trigger the issue - I haven't dug in closer to zoom in on exactly what it is though - hopefully you can spot the differences.

Fri, Jan 22, 3:55 AM · Restricted Project
mstorsjo added a comment to D67954: [LLDB] [Windows] Initial support for ARM64 register contexts.

Is there a specific reason you've only covered x0..x7 in the test?

Fri, Jan 22, 2:42 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D93764: [LoopUnswitch] Implement first version of partial unswitching..

I'm also seeing lots of hangs/infinite loops in code built after this commit. I don't have anything nicely reduced to dig in on (yet), but it broke a significant amount of my testing setup.

Fri, Jan 22, 12:48 AM · Restricted Project

Wed, Jan 20

mstorsjo added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

@mstorsjo Would you mind giving it a shot on Windows?

Wed, Jan 20, 10:55 PM · Restricted Project

Tue, Jan 19

mstorsjo added inline comments to D94555: [LLD][COFF] Avoid std::vector resizes during type merging.
Tue, Jan 19, 12:46 PM · Restricted Project
mstorsjo added inline comments to D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.
Tue, Jan 19, 8:47 AM · Restricted Project
mstorsjo updated the diff for D91172: [17/N] [libcxx] Implement the read_symlink function for windows.

Made a readlink helper in posix_compat.h.

Tue, Jan 19, 8:29 AM · Restricted Project
mstorsjo updated the summary of D91171: [16/N] [libcxx] Implement the permissions function for windows.
Tue, Jan 19, 8:28 AM · Restricted Project
mstorsjo updated the diff for D91171: [16/N] [libcxx] Implement the permissions function for windows.

Made fchmod and fchmodat helpers in posix_compat.h.

Tue, Jan 19, 8:27 AM · Restricted Project
mstorsjo updated the diff for D91170: [15/N] [libcxx] Implement the canonical function for windows.

Made a new realpath posix-like helper for windows, change explicit char to path::value_type in calling code.

Tue, Jan 19, 8:25 AM · Restricted Project
mstorsjo updated the diff for D91169: [14/N] [libcxx] Implement the current_path function for windows.

Moved to a getcwd helper in posix_compat.h, change existing code to use path::value_type instead of hardcoded char.

Tue, Jan 19, 8:21 AM · Restricted Project
mstorsjo updated the diff for D91143: [11/N] [libcxx] Hook up a number of operation functions to their windows counterparts.

Retrigger CI.

Tue, Jan 19, 8:20 AM · Restricted Project
mstorsjo updated the diff for D91143: [11/N] [libcxx] Hook up a number of operation functions to their windows counterparts.

Rebased, moved helpers to posix_compat.h.

Tue, Jan 19, 8:19 AM · Restricted Project
mstorsjo updated the diff for D91142: [10/N] [libcxx] Implement _FilesystemClock::now() and __last_write_time for windows.

Retrigger CI.

Tue, Jan 19, 8:18 AM · Restricted Project
mstorsjo updated the diff for D91142: [10/N] [libcxx] Implement _FilesystemClock::now() and __last_write_time for windows.

Rebased on top of updated patch (already preapproved, no need for new review).

Tue, Jan 19, 8:18 AM · Restricted Project
mstorsjo updated the diff for D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.

Retrigger CI.

Tue, Jan 19, 7:48 AM · Restricted Project
mstorsjo updated the diff for D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.

Moved posix reimplementations to a separate header.

Tue, Jan 19, 7:47 AM · Restricted Project
mstorsjo added inline comments to D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.
Tue, Jan 19, 6:08 AM · Restricted Project
mstorsjo added a comment to D94921: [libc++] Make LIBCXX_ENABLE_FILESYSTEM fully consistent.

FWIW, +1 from me on this one. I've earlier run into cases where code checks for whether <filesystem> is available and works, where it has accidentally seemed to work as long as the test only used features provided entirely by the header. See e.g. https://codereview.qt-project.org/c/qt/qtbase/+/295469 for such a case.

Tue, Jan 19, 2:30 AM · Restricted Project

Mon, Jan 18

mstorsjo added inline comments to D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.
Mon, Jan 18, 1:35 PM · Restricted Project
mstorsjo added inline comments to D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.
Mon, Jan 18, 11:07 AM · Restricted Project

Sun, Jan 17

mstorsjo added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

This broke building OpenMP for windows; all the new helper functions, like __kmp_hidden_helper_threads_initz_wait, that are added in z_Linux_util.cpp would need to be added similarly to z_Windows_NT_util.cpp. What do you propose doing - revert the patch for now until that's in place?

Sun, Jan 17, 11:09 PM · Restricted Project

Fri, Jan 15

mstorsjo added inline comments to D94824: [MSVC] Disable <fstream> usage of <filesystem>.
Fri, Jan 15, 11:03 PM · Restricted Project
mstorsjo added inline comments to D94824: [MSVC] Disable <fstream> usage of <filesystem>.
Fri, Jan 15, 2:08 PM · Restricted Project
mstorsjo accepted D94817: [MSVC] Don't add -nostdinc++ -isystem to runtimes builds.

LGTM

Fri, Jan 15, 1:11 PM · Restricted Project
mstorsjo added inline comments to D94817: [MSVC] Don't add -nostdinc++ -isystem to runtimes builds.
Fri, Jan 15, 12:48 PM · Restricted Project
mstorsjo accepted D94788: Fix libc++ clang-cl build, swap attribute order.

LGTM fwiw, I just looked into the same yesterday, but I guess @ldionne should ack it too.

Fri, Jan 15, 9:25 AM · Restricted Project
mstorsjo added a comment to D94707: [Flang] Fix compilation on MinGW-w64.

What part of the code in the ifdefs is msvc-specific? On a first glance, it looks like regular win32 code that should work fine on mingw. What's the error that it tries to fix?

D:/dev/llvm-project/flang/runtime/file.cpp:48:57: error: use of undeclared identifier '_S_IREAD'
  int fd{::_open(tempFileName, _O_CREAT | _O_TEMPORARY, _S_IREAD | _S_IWRITE)};
                                                        ^
D:/dev/llvm-project/flang/runtime/file.cpp:48:68: error: use of undeclared identifier '_S_IWRITE'
  int fd{::_open(tempFileName, _O_CREAT | _O_TEMPORARY, _S_IREAD | _S_IWRITE)};

The problem here is just that the right header for the _S_IREAD and _S_IWRITE constants haven't been included. Include sys/stat.h (which exists in both MSVC and mingw environments), i.e. move that include out of the ifdef/else, and this should work for mingw too.

This is the easiest fix I could find.
You are free to make modifications on my patch.

Fri, Jan 15, 5:18 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D94707: [Flang] Fix compilation on MinGW-w64.

What part of the code in the ifdefs is msvc-specific? On a first glance, it looks like regular win32 code that should work fine on mingw. What's the error that it tries to fix?

D:/dev/llvm-project/flang/runtime/file.cpp:48:57: error: use of undeclared identifier '_S_IREAD'
  int fd{::_open(tempFileName, _O_CREAT | _O_TEMPORARY, _S_IREAD | _S_IWRITE)};
                                                        ^
D:/dev/llvm-project/flang/runtime/file.cpp:48:68: error: use of undeclared identifier '_S_IWRITE'
  int fd{::_open(tempFileName, _O_CREAT | _O_TEMPORARY, _S_IREAD | _S_IWRITE)};
Fri, Jan 15, 3:26 AM · Restricted Project, Restricted Project

Thu, Jan 14

mstorsjo added a comment to D94707: [Flang] Fix compilation on MinGW-w64.

What part of the code in the ifdefs is msvc-specific? On a first glance, it looks like regular win32 code that should work fine on mingw. What's the error that it tries to fix?

Thu, Jan 14, 8:50 PM · Restricted Project, Restricted Project
mstorsjo added a reverting change for rGdda60035e9f0: [AArch64] Attempt to sink mul operands: rGdbaa6a1858a4: Revert "[AArch64] Attempt to sink mul operands".
Thu, Jan 14, 7:29 AM
mstorsjo committed rGdbaa6a1858a4: Revert "[AArch64] Attempt to sink mul operands" (authored by mstorsjo).
Revert "[AArch64] Attempt to sink mul operands"
Thu, Jan 14, 7:29 AM
mstorsjo added a reverting change for D91271: [AArch64] Attempt to sink mul operands: rGdbaa6a1858a4: Revert "[AArch64] Attempt to sink mul operands".
Thu, Jan 14, 7:29 AM · Restricted Project

Wed, Jan 13

mstorsjo added a comment to D91271: [AArch64] Attempt to sink mul operands.

This broke compilation of some sources, reproducible like this:

$ cat repro.c 
a;
b(long long c) {
  if (c & 5)
    return c;
}
d(c, e) {
  int f;
  int *g = a, *h = d;
  f = 0;
  for (; f < c; f++)
    g[f] = b((long long)h[f] * e);
}
$ clang -target aarch64-linux-gnu -c repro.c -O2
fatal error: error in backend: Cannot select: t85: v2i32 = AArch64ISD::DUP t15
  t15: i64,ch = CopyFromReg t0, Register:i64 %1
    t14: i64 = Register %1
Wed, Jan 13, 11:47 PM · Restricted Project
mstorsjo updated the diff for D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.

Added clarifying comments in the header, describing why we're providing our own stat implementation, and that the C runtime headers provide possibly conflicting defines that we undef.

Wed, Jan 13, 9:40 AM · Restricted Project
mstorsjo added inline comments to D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.
Wed, Jan 13, 8:50 AM · Restricted Project
mstorsjo added inline comments to D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.
Wed, Jan 13, 8:31 AM · Restricted Project

Tue, Jan 12

mstorsjo committed rG02f1d28ed6b8: [libcxx] Avoid overflows in the windows __libcpp_steady_clock_now() (authored by mstorsjo).
[libcxx] Avoid overflows in the windows __libcpp_steady_clock_now()
Tue, Jan 12, 2:00 PM
mstorsjo committed rGd1fa7afc7aef: [AArch64] [Windows] Properly add :lo12: reloc specifiers when generating… (authored by mstorsjo).
[AArch64] [Windows] Properly add :lo12: reloc specifiers when generating…
Tue, Jan 12, 2:00 PM
mstorsjo closed D93456: [libcxx] Avoid overflows in the windows __libcpp_steady_clock_now().
Tue, Jan 12, 1:59 PM · Restricted Project
mstorsjo closed D94365: [AArch64] [Windows] Properly add :lo12: reloc specifiers when generating assembly.
Tue, Jan 12, 1:59 PM · Restricted Project

Mon, Jan 11

mstorsjo added a comment to D93190: [libc++abi] Simplify scan_eh_tab.

@mstorsjo Perhaps you can test this as well:)

Mon, Jan 11, 12:30 PM · Restricted Project
mstorsjo added a comment to D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm.

Can you please add some more context around the motivation for this change? It seems ... unnecessary as everything is already AAPCS/AAPCS-VFP.

Mon, Jan 11, 11:21 AM · Restricted Project

Sat, Jan 9

mstorsjo requested review of D94365: [AArch64] [Windows] Properly add :lo12: reloc specifiers when generating assembly.
Sat, Jan 9, 2:32 PM · Restricted Project
mstorsjo requested review of D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm.
Sat, Jan 9, 1:56 PM · Restricted Project
mstorsjo added a comment to D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.

I'd like to see a name change to clear up the consumeSeparators confusion, but I won't block on that.

Sat, Jan 9, 1:11 AM · Restricted Project

Fri, Jan 8

mstorsjo updated the diff for D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.

Readd the repo, for CI...

Fri, Jan 8, 1:56 PM · Restricted Project
mstorsjo updated the diff for D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.

Renamed the consumeSeparators method to consumeNSeparators and added a comment pointing out that it consumes exactly that amount of separators. Removed unnecessary braces around single lines. (The consumeSeparator method can be renamed in a separate patch afterwards, I'd avoid doing it here to keep the diff as readable as possible.)

Fri, Jan 8, 1:55 PM · Restricted Project
mstorsjo removed rG LLVM Github Monorepo as the repository for D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.
Fri, Jan 8, 1:52 PM · Restricted Project
mstorsjo committed rGffac9001d987: [compiler-rt] [sanitizer] Silence -Wframe-larger-than= for a few windows… (authored by mstorsjo).
[compiler-rt] [sanitizer] Silence -Wframe-larger-than= for a few windows…
Fri, Jan 8, 12:55 PM
mstorsjo closed D91853: [compiler-rt] [sanitizer] Silence -Wframe-larger-than= for a few windows functions with large stack buffers.
Fri, Jan 8, 12:55 PM · Restricted Project
mstorsjo added inline comments to D91853: [compiler-rt] [sanitizer] Silence -Wframe-larger-than= for a few windows functions with large stack buffers.
Fri, Jan 8, 12:46 PM · Restricted Project
mstorsjo added a comment to D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.

I may be repeating myself, but my biggest remark is that there are no tests. I know there's no libcxx CI on Windows, but still, that will make reviewing easier, looking what are the new test cases and what has been forgotten.

Fri, Jan 8, 8:22 AM · Restricted Project
mstorsjo added a comment to D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.

This one is still unreviewed, and is more of generic libcxx code than windows specific API calls - could @curdeius have a look?

Fri, Jan 8, 4:28 AM · Restricted Project
mstorsjo added a comment to D93967: [SLP]Need shrink the load vector after reordering..

This caused misoptimizations for armv7, where code that previously worked correctly now produce different results. (The code is clean under ubsan, so it shouldn't be relying on anything undefined.)

Fri, Jan 8, 12:35 AM · Restricted Project
mstorsjo committed rG7a91dad9e5fa: [llvm-readobj] [ARMWinEH] Clearly print an invalid case of packed unwind info… (authored by mstorsjo).
[llvm-readobj] [ARMWinEH] Clearly print an invalid case of packed unwind info…
Fri, Jan 8, 12:18 AM
mstorsjo closed D91529: [llvm-readobj] [ARMWinEH] Clearly print an invalid case of packed unwind info as such.
Fri, Jan 8, 12:18 AM · Restricted Project

Thu, Jan 7

mstorsjo added a comment to D93186: [libc++abi] Simplify __gxx_personality_v0.

FWIW, while I've touched this code on the outside, I'm not really familiar with it. But I can at least try out the patch in my setups (dwarf + SEH) and let you know whether it seems to work as intended there.

Thu, Jan 7, 1:31 PM · Restricted Project
mstorsjo updated subscribers of D91529: [llvm-readobj] [ARMWinEH] Clearly print an invalid case of packed unwind info as such.

Ping - as @efriedma doesn't seem to be around much at the moment, could maybe @rnk give this one an ack?

Thu, Jan 7, 12:33 PM · Restricted Project
mstorsjo added a comment to D93186: [libc++abi] Simplify __gxx_personality_v0.

FWIW, while I've touched this code on the outside, I'm not really familiar with it. But I can at least try out the patch in my setups (dwarf + SEH) and let you know whether it seems to work as intended there.

Thu, Jan 7, 12:19 PM · Restricted Project
mstorsjo added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Thu, Jan 7, 4:11 AM
mstorsjo committed rGf4485240a218: [libcxx] Handle backslash as path separator on windows (authored by mstorsjo).
[libcxx] Handle backslash as path separator on windows
Thu, Jan 7, 12:08 AM
mstorsjo committed rG248e3450fb8a: [LLD] [MinGW] Pass the --demangle and --no-demangle options to the COFF linker (authored by mstorsjo).
[LLD] [MinGW] Pass the --demangle and --no-demangle options to the COFF linker
Thu, Jan 7, 12:08 AM
mstorsjo closed D91138: [6/N] [libcxx] Handle backslash as path separator on windows.
Thu, Jan 7, 12:08 AM · Restricted Project
mstorsjo closed D93950: [LLD] [MinGW] Pass the --demangle and --no-demangle options to the COFF linker.
Thu, Jan 7, 12:08 AM · Restricted Project

Mon, Jan 4

mstorsjo committed rG979c38cc74f4: [compiler-rt] [windows] Add UNUSED attributes on variables/functions only used… (authored by mstorsjo).
[compiler-rt] [windows] Add UNUSED attributes on variables/functions only used…
Mon, Jan 4, 11:00 PM
mstorsjo closed D91852: [compiler-rt] [windows] Add UNUSED attributes on variables/functions only used for 64 bit targets.
Mon, Jan 4, 10:59 PM · Restricted Project

Wed, Dec 30

mstorsjo requested review of D93950: [LLD] [MinGW] Pass the --demangle and --no-demangle options to the COFF linker.
Wed, Dec 30, 1:06 PM · Restricted Project

Dec 20 2020

mstorsjo added a comment to D90625: [AggressiveInstCombine] Generalize foldGuardedRotateToFunnelShift to generic funnel shifts.

The original, unreduced testcase seems to work fine now at least - thanks! Can't really comment on the code itself though.

Dec 20 2020, 11:03 AM · Restricted Project

Dec 18 2020

mstorsjo added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

Once again, thank you @mstorsjo and @dmgreen!

Awesome, thanks guys!

I'll let you know tomorrow in the unlikely case if this still caused some other regressions as well (or possibly later, if my nightly build ends up broken for other reasons).

Dec 18 2020, 11:09 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

Once again, thank you @mstorsjo and @dmgreen!

Dec 18 2020, 11:52 AM · Restricted Project, Restricted Project
mstorsjo updated the diff for D91181: [24/N] [libcxx] Make generic_*string return paths with forward slashes on windows.

Rebased, added a comment pointing out suboptimal cases of iterating over the strings twice.

Dec 18 2020, 4:42 AM · Restricted Project
mstorsjo added a comment to D91181: [24/N] [libcxx] Make generic_*string return paths with forward slashes on windows.

LGTM. I'd like just to see a TODO note or a ticket for this double traversal.

Dec 18 2020, 4:39 AM · Restricted Project
mstorsjo added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

@mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, and unfortunately it came back green..
I don't recall if i can reproduce it locally (on vanilla test suite, i'll recheck),
but right now it would seem that you are the only one who can reproduce this :/

Were you able to make any progress on a somewhat more actionable reproducer?

What would be really helpful is a standalone source that can be compiled and run (here by be locally, on linux x86_64)
that produces different result with/without this change.

IIRC I'm only able to reproduce this for aarch64 (and possibly arm) targets unfortunately. I can make a kind of standalone testcase with one single file built from source, linked and executed along with a bigger piece of code (either from source or prebuilt object files), but it'd be for aarch64-linux (or aarch64-darwin if that helps - I haven't tried reproducing it there but I'd presume it behaves the same as I noticed the bug first on aarch64 windows).

Dec 18 2020, 4:11 AM · Restricted Project, Restricted Project
mstorsjo added inline comments to D91181: [24/N] [libcxx] Make generic_*string return paths with forward slashes on windows.
Dec 18 2020, 3:28 AM · Restricted Project
mstorsjo added a comment to D91138: [6/N] [libcxx] Handle backslash as path separator on windows.

No modifications in tests?

Dec 18 2020, 3:24 AM · Restricted Project
mstorsjo updated subscribers of D91181: [24/N] [libcxx] Make generic_*string return paths with forward slashes on windows.

Can you @curdeius have a look at this one?

Dec 18 2020, 1:46 AM · Restricted Project
mstorsjo added a comment to D91178: [22/N] [libcxx] Implement append and operator/ properly for windows.

Ping @amccarth - this requires your follow-up

Dec 18 2020, 1:44 AM · Restricted Project
mstorsjo updated subscribers of D91176: [20/N] [libcxx] Implement parsing of root_name for paths on windows.

Ping, this one is still entirely unreviewed - @curdeius @amccarth?

Dec 18 2020, 1:44 AM · Restricted Project
mstorsjo added a comment to D91171: [16/N] [libcxx] Implement the permissions function for windows.

Ping @amccarth, this one is missing follow-up on the earlier discussion.

Dec 18 2020, 1:41 AM · Restricted Project
mstorsjo updated the diff for D91143: [11/N] [libcxx] Hook up a number of operation functions to their windows counterparts.

Rebased, already formally approved.

Dec 18 2020, 1:39 AM · Restricted Project
mstorsjo updated the diff for D91142: [10/N] [libcxx] Implement _FilesystemClock::now() and __last_write_time for windows.

Rebased, retriggering CI. This one is already formally approved by @amccarth.

Dec 18 2020, 1:36 AM · Restricted Project
mstorsjo updated the diff for D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.

Rebased on top of stylistic changes in earlier patches, retriggering CI

Dec 18 2020, 1:33 AM · Restricted Project
mstorsjo added a comment to D91138: [6/N] [libcxx] Handle backslash as path separator on windows.

Can either @amccarth or @curdeius mark this as formally approved, if there's no other strict blockers for it, to maybe help with getting it looked at?

Dec 18 2020, 1:31 AM · Restricted Project
mstorsjo added a comment to D91141: [9/N] [libcxx] Implement the stat function family on top of native windows APIs.

LGTM as long as the run-time calculation of the default value for set_errno is legit.

Dec 18 2020, 1:30 AM · Restricted Project
mstorsjo committed rG156180727d6c: [libcxx] Fix the preexisting directory_iterator code for windows (authored by mstorsjo).
[libcxx] Fix the preexisting directory_iterator code for windows
Dec 18 2020, 1:26 AM
mstorsjo closed D91140: [8/N] [libcxx] Fix the preexisting directory_iterator code for windows.
Dec 18 2020, 1:26 AM · Restricted Project
mstorsjo committed rGde698ae73444: [libcxx] Convert paths to/from the right narrow code page for narrow strings on… (authored by mstorsjo).
[libcxx] Convert paths to/from the right narrow code page for narrow strings on…
Dec 18 2020, 1:26 AM
mstorsjo closed D91137: [5/N] [libcxx] Convert paths to/from the right narrow code page for narrow strings on windows.
Dec 18 2020, 1:25 AM · Restricted Project
mstorsjo committed rG48c6500b5bfa: [libcxx] Reorder the two u8path functions, to make the following diff more… (authored by mstorsjo).
[libcxx] Reorder the two u8path functions, to make the following diff more…
Dec 18 2020, 1:25 AM
mstorsjo closed D91136: [4/N] [libcxx] Reorder the two u8path functions, to make the following diff more readable. NFC..
Dec 18 2020, 1:25 AM · Restricted Project
mstorsjo committed rGe83e0cac041b: [libcxx] Make filesystem::path::value_type wchar_t on windows (authored by mstorsjo).
[libcxx] Make filesystem::path::value_type wchar_t on windows
Dec 18 2020, 1:25 AM
mstorsjo closed D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows.
Dec 18 2020, 1:25 AM · Restricted Project

Dec 17 2020

mstorsjo added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

@mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, and unfortunately it came back green..
I don't recall if i can reproduce it locally (on vanilla test suite, i'll recheck),
but right now it would seem that you are the only one who can reproduce this :/

Were you able to make any progress on a somewhat more actionable reproducer?

What would be really helpful is a standalone source that can be compiled and run (here by be locally, on linux x86_64)
that produces different result with/without this change.

Dec 17 2020, 2:03 PM · Restricted Project, Restricted Project
mstorsjo requested review of D93456: [libcxx] Avoid overflows in the windows __libcpp_steady_clock_now().
Dec 17 2020, 5:50 AM · Restricted Project
mstorsjo added a comment to D91852: [compiler-rt] [windows] Add UNUSED attributes on variables/functions only used for 64 bit targets.

Ping @amccarth, do you want to follow up on the discussion before I land this?

Dec 17 2020, 4:25 AM · Restricted Project
mstorsjo added a comment to D91853: [compiler-rt] [sanitizer] Silence -Wframe-larger-than= for a few windows functions with large stack buffers.

Ping @amccarth

Dec 17 2020, 4:24 AM · Restricted Project