- User Since
- Jul 25 2016, 12:54 PM (216 w, 3 d)
This broke a few tests for me (generating code that now gives the fail result at runtime).
Wed, Sep 16
@rnk - Can you follow up on the discussion above?
Tue, Sep 15
The file that shows the error can be built from https://martin.st/temp/eval.c, built as clang -target armv7-w64-mingw32 -c -O2 eval.c.
The main difference in code, in the function that show the error in one of the testcases that broke, looks like this:
- movs r1, #9 - cmp r0, #9 - it lt - movlt r1, r0 - bic.w r0, r1, r1, asr #31 + usat r0, #1, r0
Mon, Sep 14
Headsup: This broke a number of tests for me. Looking closer into where it changed things erroneously...
Pushed this one now.
Sun, Sep 13
The commit description talks about making the caching optional, but I don't really see that aspect in the patch - or maybe I'm just not studying it closely enough?
The change itself looks good to me, but the comment in lit.site.cfg.in does look confusing to me as well, so it'd be great to have it reworded.
Sat, Sep 12
Ok, so if I read code correctly, the suffix gets added here: https://github.com/llvm/llvm-project/blob/9c651c231f3144f53e13cd0a1747589e1b2edccd/llvm/cmake/modules/AddLLVM.cmake#L599-L606
LGTM then! Can apply it a bit later.
Fri, Sep 11
This should be ok, I think.
Does the static lib built in this case include any dllexport attributes (that can cause issues if linking it statically into another DLL)?
If the corresponding DLLs built in MSVC mode actually have a version number suffix, should we change the build for MinGW mode to include a number as well? Or is any of the relevant DLLs ever built in MSVC mode at all?
Removed superfluous "sub sp, sp, #0".
This looks good to me! I can push it later.
What's the practical effect of this? I see that a number of libraries already have a lib prefix prepended, like libclang/liblldb - I presume this changes the name of the individual libs (for BUILD_SHARED_LIBS=TRUE configurations)?
Thu, Sep 10
Updated to allow cases where the epilog is missing the SetFP opcode.
Wed, Sep 9
Added a comment about the reference for synthesizing the prologue, fixed the homing area stack adjustment check for RegI=0, RegF=0, CR=1, added a testcase for that case and expanded on the comment for that bit in the code.
Added a comment in the operator== about why the label isn't included in the comparison, changed the last condition into an early return like the other ones.
Conditionally producing the save_r19r20_x opcode depending on offset, added a testcase with a too large offset that isn't canonicalized.
As a concept, this looks sensible to me, similar to how llvm can be configured with a default triple or how clang can have cmake-configurable built-in defaults for linker/stdlib.
Tue, Sep 8
@compnerd - Any followup on this one?
Mon, Sep 7
Thu, Sep 3
Wed, Sep 2
@efriedma Any followup to the discussion above?
Mon, Aug 31
Sun, Aug 30
Added a testcase with a tiny python script that generates def files that export the same symbol a number of times. It generates two 566 KB def files, for testing the case below and above the limit. The successful link case produces a 1 MB DLL and a 8 MB import library.