Page MenuHomePhabricator

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (256 w, 7 h)

Recent Activity

Today

mstorsjo added a comment to D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower.

@lattner Do you want to follow up on this one? StringRef already has a bunch of case insensitive operations, and this patch just fills a gap in the set of those operations.

Mon, Jun 21, 2:32 PM · Restricted Project
mstorsjo updated the diff for D104605: [LLD] [COFF] Fix handling of LTO comdats with nontrivial selection types after 728cc0075e5dfdb454eb.

Use @rnk's suggsestion of isa<BitcodFile>(), simplify the initialization of leaderChunk and leaderSelection.

Mon, Jun 21, 2:23 PM · Restricted Project
mstorsjo added inline comments to D104605: [LLD] [COFF] Fix handling of LTO comdats with nontrivial selection types after 728cc0075e5dfdb454eb.
Mon, Jun 21, 2:09 PM · Restricted Project
mstorsjo added inline comments to D104605: [LLD] [COFF] Fix handling of LTO comdats with nontrivial selection types after 728cc0075e5dfdb454eb.
Mon, Jun 21, 12:53 PM · Restricted Project

Yesterday

mstorsjo requested review of D104605: [LLD] [COFF] Fix handling of LTO comdats with nontrivial selection types after 728cc0075e5dfdb454eb.
Sun, Jun 20, 2:19 PM · Restricted Project

Sat, Jun 19

mstorsjo committed rGe1adf90826a5: [LLD] [COFF] Avoid doing repeated fuzzy symbol lookup for each iteration. NFC. (authored by mstorsjo).
[LLD] [COFF] Avoid doing repeated fuzzy symbol lookup for each iteration. NFC.
Sat, Jun 19, 12:33 PM · Restricted Project
mstorsjo committed rG1c8bb625b716: [LLD] [MinGW] Print errors/warnings in lld-link with a "ld.lld" prefix (authored by mstorsjo).
[LLD] [MinGW] Print errors/warnings in lld-link with a "ld.lld" prefix
Sat, Jun 19, 12:33 PM
mstorsjo closed D104529: [LLD] [COFF] Avoid doing repeated fuzzy symbol lookup for each iteration. NFC..
Sat, Jun 19, 12:33 PM · Restricted Project
mstorsjo closed D104526: [LLD] [MinGW] Print errors/warnings in lld-link with a "ld.lld" prefix.
Sat, Jun 19, 12:32 PM · Restricted Project
mstorsjo requested review of D104589: [llvm-rc] Don't rewrite the arch in the default triple unless necessary.
Sat, Jun 19, 12:05 AM · Restricted Project

Fri, Jun 18

mstorsjo updated the diff for D104532: [LLD] [COFF] Fix up missing stdcall decorations in MinGW mode.

Updated to rerun CI after fixing a test in the base patch

Fri, Jun 18, 11:57 PM · Restricted Project
mstorsjo updated the diff for D104531: [LLD] [MinGW] Allow linking to DLLs directly.

Updated to rerun CI after fixing a test in the base patch

Fri, Jun 18, 11:55 PM · Restricted Project
mstorsjo updated the diff for D104530: [LLD] [COFF] Support linking directly against DLLs in MinGW mode.

Updated missed bits in one testcase.

Fri, Jun 18, 11:42 PM · Restricted Project
mstorsjo updated the diff for D104527: [LLD] [MinGW] Print the lld-link command to stderr if running with -verbose.

Unconditionally printing the command to stderr.

Fri, Jun 18, 12:40 PM · Restricted Project
mstorsjo added a comment to D104526: [LLD] [MinGW] Print errors/warnings in lld-link with a "ld.lld" prefix.

To actually test the effect of this, we'd have to actually do linking
from the test/MinGW subdirectory (which we don't do so far) and
have that link trigger an error.

Do you think it's necessary to make a standalone failing link test
to test the effect of this, or is it good as is?

I think mingw lld can certainly have integration tests. I think it's better to focus on testing at the smallest testable boundary, which is the argument translation layer, but tactical integration testing is also valuable.

I don't think it's strictly necessary in this case, but if you'd like to add one, go for it.

Fri, Jun 18, 12:32 PM · Restricted Project
mstorsjo accepted D104564: [AArch64][X86] Allow 64-bit label differences lower to IMAGE_REL_*_REL32.

Looks ok to me. A PE-COFF image is limited to 32 bits in range anyway, so as long as the target symbol doesn't turn out to be from outside of the image (with mingw automatic dllimport), a 32 bit difference should be enough in all cases.

Fri, Jun 18, 12:21 PM · Restricted Project
mstorsjo requested review of D104532: [LLD] [COFF] Fix up missing stdcall decorations in MinGW mode.
Fri, Jun 18, 6:08 AM · Restricted Project
mstorsjo requested review of D104531: [LLD] [MinGW] Allow linking to DLLs directly.
Fri, Jun 18, 6:07 AM · Restricted Project
mstorsjo requested review of D104530: [LLD] [COFF] Support linking directly against DLLs in MinGW mode.
Fri, Jun 18, 6:06 AM · Restricted Project
mstorsjo requested review of D104529: [LLD] [COFF] Avoid doing repeated fuzzy symbol lookup for each iteration. NFC..
Fri, Jun 18, 6:05 AM · Restricted Project
mstorsjo requested review of D104527: [LLD] [MinGW] Print the lld-link command to stderr if running with -verbose.
Fri, Jun 18, 5:36 AM · Restricted Project
mstorsjo requested review of D104526: [LLD] [MinGW] Print errors/warnings in lld-link with a "ld.lld" prefix.
Fri, Jun 18, 5:36 AM · Restricted Project

Thu, Jun 17

mstorsjo updated the diff for D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower.

Squashed in two changes to two tools that can get rid of their own private helper function if this is hoisted to StringRef.

Thu, Jun 17, 3:17 AM · Restricted Project
mstorsjo committed rGceee35e3e4bf: [LLD] [COFF] Remove a stray duplicate comment. NFC. (authored by mstorsjo).
[LLD] [COFF] Remove a stray duplicate comment. NFC.
Thu, Jun 17, 3:03 AM
mstorsjo committed rG675d52bc46ff: [llvm-dlltool] [test] Add a testcase for all machine option types. NFC. (authored by mstorsjo).
[llvm-dlltool] [test] Add a testcase for all machine option types. NFC.
Thu, Jun 17, 3:03 AM
mstorsjo committed rGca56b33daf67: [llvm-dlltool] Imply the target arch from a tool triple prefix (authored by mstorsjo).
[llvm-dlltool] Imply the target arch from a tool triple prefix
Thu, Jun 17, 3:03 AM
mstorsjo committed rG08be746728d7: [llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj. (authored by mstorsjo).
[llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj.
Thu, Jun 17, 3:03 AM
mstorsjo committed rG4fe3d5248dfa: [llvm-dlltool] [test] Test both short and long forms of options. NFC. (authored by mstorsjo).
[llvm-dlltool] [test] Test both short and long forms of options. NFC.
Thu, Jun 17, 3:03 AM
mstorsjo closed D104212: [llvm-dlltool] Imply the target arch from a tool triple prefix.
Thu, Jun 17, 3:03 AM · Restricted Project
mstorsjo committed rGd7550e5d105f: [libcxx] Fix a case of -Wundef warnings regarding _POSIX_TIMERS (authored by mstorsjo).
[libcxx] Fix a case of -Wundef warnings regarding _POSIX_TIMERS
Thu, Jun 17, 3:03 AM
mstorsjo closed D104215: [llvm-dlltool] [test] Add a testcase for all machine option types. NFC..
Thu, Jun 17, 3:03 AM · Restricted Project
mstorsjo closed D104214: [llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj. NFC..
Thu, Jun 17, 3:03 AM · Restricted Project
mstorsjo closed D104213: [llvm-dlltool] [test] Test both short and long forms of options. NFC..
Thu, Jun 17, 3:02 AM · Restricted Project
mstorsjo closed D104372: [libcxx] Fix a case of -Wundef warnings regarding _POSIX_TIMERS.
Thu, Jun 17, 3:02 AM · Restricted Project

Wed, Jun 16

mstorsjo requested review of D104372: [libcxx] Fix a case of -Wundef warnings regarding _POSIX_TIMERS.
Wed, Jun 16, 5:23 AM · Restricted Project
mstorsjo added a comment to D104328: [libc++] Always build libc++ and libc++abi with -fPIC.

Furthermore, there is apparently basically no downside to building the libraries with position independent code, since modern toolchains are sufficiently clever.

Wed, Jun 16, 12:51 AM · Restricted Project, Restricted Project

Tue, Jun 15

mstorsjo added a comment to D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower.

Oh, I completely missed that. I would recommend using the word case_insensitive here. I don't think stringref has any other case insensitive support, and I don't think this is the obvious place to start. I would start with case insensitive equality comparison. Your client can use that as a primitive that it builds higher level functionality on top of.

Tue, Jun 15, 10:13 PM · Restricted Project
mstorsjo added a comment to D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower.

I was thinking that the closure would take a character, not a stringref. So you could do something like str.consume_back(islower).

Tue, Jun 15, 11:00 AM · Restricted Project
mstorsjo accepted D103140: [libcxx] Fix exception raised during downstream bare-metal libunwind tests.

LGTM

Tue, Jun 15, 4:14 AM · Restricted Project, Restricted Project

Mon, Jun 14

mstorsjo added a comment to D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower.

Can you show a patch which will benefit from this? Otherwise this looks good.

Mon, Jun 14, 11:19 PM · Restricted Project
mstorsjo requested review of D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower.
Mon, Jun 14, 4:47 AM · Restricted Project
mstorsjo requested review of D104215: [llvm-dlltool] [test] Add a testcase for all machine option types. NFC..
Mon, Jun 14, 3:41 AM · Restricted Project
mstorsjo requested review of D104214: [llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj. NFC..
Mon, Jun 14, 3:41 AM · Restricted Project
mstorsjo requested review of D104213: [llvm-dlltool] [test] Test both short and long forms of options. NFC..
Mon, Jun 14, 3:41 AM · Restricted Project
mstorsjo requested review of D104212: [llvm-dlltool] Imply the target arch from a tool triple prefix.
Mon, Jun 14, 3:40 AM · Restricted Project

Fri, Jun 11

mstorsjo added a comment to D101479: [Driver] Support libc++ in MSVC.

Couldn’t this commit have been kept in, and just reverting the one for using it in the fuchsia cmake cache? (I’m not using this particular commit myself, just observing.)

The problem is that there's no way to configure the default libc++ on a per-target basis. We want to use libc++ as a default for all targets that support it, so for example even if you're compiling on Windows but targeting Fuchsia or Linux. Unfortunately, with this change that triggers D103947 when compiling compiler-rt and I don't know how to work around it.

I'd point out that we have the same problem for other defaults, for example if you set lld as the default linker on Darwin, it causes issues because Clang tries to use lld.ld64 which is not yet usable. We still want to use lld for all other targets, but there's no way to specify that in CMake today which is something we may want to address.

Fri, Jun 11, 11:22 AM · Restricted Project
mstorsjo added a comment to D101479: [Driver] Support libc++ in MSVC.

Couldn’t this commit have been kept in, and just reverting the one for using it in the fuchsia cmake cache? (I’m not using this particular commit myself, just observing.)

Fri, Jun 11, 10:21 AM · Restricted Project
mstorsjo updated the diff for D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Updated with CI testing hooked up. Unfortunately, things don't work quite cleanly:

Fri, Jun 11, 3:12 AM · Restricted Project

Thu, Jun 10

mstorsjo added a reverting change for rGd96ea4662980: [AArch64LoadStoreOptimizer] Generate more STPs by renaming registers earlier: rG99653702fdca: Revert "[AArch64LoadStoreOptimizer] Generate more STPs by renaming registers….
Thu, Jun 10, 12:31 AM
mstorsjo added a reverting change for D103597: [AArch64LoadStoreOptimizer] Generate more STPs by renaming registers earlier: rG99653702fdca: Revert "[AArch64LoadStoreOptimizer] Generate more STPs by renaming registers….
Thu, Jun 10, 12:31 AM · Restricted Project
mstorsjo committed rG99653702fdca: Revert "[AArch64LoadStoreOptimizer] Generate more STPs by renaming registers… (authored by mstorsjo).
Revert "[AArch64LoadStoreOptimizer] Generate more STPs by renaming registers…
Thu, Jun 10, 12:31 AM
mstorsjo added a comment to D103597: [AArch64LoadStoreOptimizer] Generate more STPs by renaming registers earlier.

The problem I'm seeing can be reproduced with this source file: https://martin.st/temp/cdf-preproc.c

Thu, Jun 10, 12:29 AM · Restricted Project

Wed, Jun 9

mstorsjo added a comment to D103597: [AArch64LoadStoreOptimizer] Generate more STPs by renaming registers earlier.

FYI I've bisected down a misoptimization to this particular commit

Wed, Jun 9, 11:43 PM · Restricted Project
mstorsjo updated subscribers of D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

I think we can say that _HAS_EXCEPTIONS=0 is an important configuration.

Wed, Jun 9, 2:20 PM · Restricted Project
mstorsjo added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

It's the bare minimum for a configuration to be considered as supported. We already have a Windows bot, but I'm actually not sure whether it's using MinGW or straight Windows. @mstorsjo will know. Maybe it's trivial to add another Windows configuration to test this?

Wed, Jun 9, 2:09 PM · Restricted Project
mstorsjo added a comment to D57119: [libFuzzer][MSVC] Disable exceptions in MSVC headers.

I'm a bit curious about the root causes of this patch - is it for builds with MS STL or libc++, and what were the actual issues it was trying to fix? I'm getting mixed signals from the comments in the discussion thread above.

Wed, Jun 9, 1:33 PM
mstorsjo requested review of D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.
Wed, Jun 9, 1:29 AM · Restricted Project

Tue, Jun 8

mstorsjo added a comment to D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..

Thanks for looping me in; I don't have any objection to this, as far as I can see, the reasoning seems sensible, and the most brittle testcase I have (from what I remember offhand) seems to run fine with this change.

Tue, Jun 8, 4:25 AM · Restricted Project
mstorsjo committed rGb34da6ff9c1d: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms… (authored by mstorsjo).
[clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms…
Tue, Jun 8, 2:15 AM
mstorsjo closed D103837: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64.
Tue, Jun 8, 2:15 AM · Restricted Project

Mon, Jun 7

mstorsjo requested review of D103837: [clang] Apply MS ABI details on __builtin_ms_va_list on non-windows platforms on x86_64.
Mon, Jun 7, 12:50 PM · Restricted Project
mstorsjo committed rG6de45b9e6a2c: [clang] Fix reading long doubles with va_arg on x86_64 mingw (authored by mstorsjo).
[clang] Fix reading long doubles with va_arg on x86_64 mingw
Mon, Jun 7, 12:47 PM
mstorsjo closed D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.
Mon, Jun 7, 12:47 PM · Restricted Project
mstorsjo added inline comments to D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.
Mon, Jun 7, 12:29 PM · Restricted Project
mstorsjo added inline comments to D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.
Mon, Jun 7, 10:26 AM · Restricted Project

Fri, Jun 4

mstorsjo added a comment to D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..

FWIW, this patch also broke building for windows. Weak symbols overall is a tricky area on windows, and I don't think this particular usage (the asan lib having a weak undefined symbol, which the executable may or may not proivide) works with windows DLLs at all.

@mstorsjo Is there a short-term work around?
FYI: I do plan to follow with a late-initialization solution.

Fri, Jun 4, 12:58 PM · Restricted Project, Restricted Project
mstorsjo committed rG72177e9fa536: [mailmap] Add the canonical spelling of my name (authored by mstorsjo).
[mailmap] Add the canonical spelling of my name
Fri, Jun 4, 12:28 PM
mstorsjo added inline comments to D103360: Add a toplevel .mailmap file.
Fri, Jun 4, 11:05 AM · Restricted Project
mstorsjo added a comment to D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..

FWIW, this patch also broke building for windows. Weak symbols overall is a tricky area on windows, and I don't think this particular usage (the asan lib having a weak undefined symbol, which the executable may or may not proivide) works with windows DLLs at all.

Fri, Jun 4, 2:34 AM · Restricted Project, Restricted Project
mstorsjo added inline comments to D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.
Fri, Jun 4, 2:21 AM · Restricted Project
mstorsjo committed rGb0cc7b53a53f: [libcxx] Don't use an undefined '+' in unsigned/octal/hexal print formats (authored by mstorsjo).
[libcxx] Don't use an undefined '+' in unsigned/octal/hexal print formats
Fri, Jun 4, 2:09 AM
mstorsjo closed D103444: [libcxx] Don't use an undefined '+' in unsigned/octal/hexal print formats.
Fri, Jun 4, 2:09 AM · Restricted Project

Thu, Jun 3

mstorsjo committed rG728cc0075e5d: [LLD] [COFF] Fix autoexport from LTO objects with comdat symbols (authored by mstorsjo).
[LLD] [COFF] Fix autoexport from LTO objects with comdat symbols
Thu, Jun 3, 5:15 AM
mstorsjo closed D103012: [LLD] [COFF] Fix autoexport from LTO objects with comdat symbols.
Thu, Jun 3, 5:15 AM · Restricted Project
mstorsjo updated the diff for D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.

Updated the CodeGenCXX/ext-int.cpp testcase.

Thu, Jun 3, 4:26 AM · Restricted Project
mstorsjo updated the diff for D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.

Updated to not require the types to be either isAggregateTypeForABI(Ty) or Ty->isMemberPointerType(), just check the size of the type, added a testcase for __int128 (which I tested against GCC).

Thu, Jun 3, 2:09 AM · Restricted Project
mstorsjo added inline comments to D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.
Thu, Jun 3, 12:54 AM · Restricted Project

Wed, Jun 2

mstorsjo added inline comments to D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.
Wed, Jun 2, 3:10 PM · Restricted Project
mstorsjo added inline comments to D103360: Add a toplevel .mailmap file.
Wed, Jun 2, 5:04 AM · Restricted Project

Tue, Jun 1

mstorsjo added a comment to D103444: [libcxx] Don't use an undefined '+' in unsigned/octal/hexal print formats.

Looks reasonable to me. FWIW, a more invasive rewrite would put the letter-computing code first:

Tue, Jun 1, 1:29 PM · Restricted Project
mstorsjo committed rG936ca1e21a91: WindowsSupport.h: do not depend on private config header (authored by andrewrk).
WindowsSupport.h: do not depend on private config header
Tue, Jun 1, 1:05 PM
mstorsjo closed D103370: WindowsSupport.h: do not depend on private config header.
Tue, Jun 1, 1:05 PM · Restricted Project
mstorsjo added a comment to D103370: WindowsSupport.h: do not depend on private config header.

Thank you for having a look, Adrian! I would appreciate if you or someone else could commit for me since I do not have write access.

Tue, Jun 1, 11:57 AM · Restricted Project
mstorsjo requested review of D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw.
Tue, Jun 1, 5:00 AM · Restricted Project
mstorsjo requested review of D103444: [libcxx] Don't use an undefined '+' in unsigned/octal/hexal print formats.
Tue, Jun 1, 3:24 AM · Restricted Project
mstorsjo accepted D103360: Add a toplevel .mailmap file.

+1, looks great to me now, too.

Tue, Jun 1, 2:11 AM · Restricted Project

Mon, May 31

mstorsjo abandoned D103311: [libcxx] [test] Fix the _supportsVerify check on Windows by using hasCompileFlag.

Went with D103310 after all, thus this one isn't needed.

Mon, May 31, 11:53 PM · Restricted Project
mstorsjo committed rG41d7909368be: [libcxx] [test] Fix the _supportsVerify check on Windows by fixing quoting (authored by mstorsjo).
[libcxx] [test] Fix the _supportsVerify check on Windows by fixing quoting
Mon, May 31, 11:53 PM
mstorsjo closed D103310: [libcxx] [test] Fix the _supportsVerify check on Windows by fixing quoting.
Mon, May 31, 11:52 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D103310: [libcxx] [test] Fix the _supportsVerify check on Windows by fixing quoting.

Rerun CI after fixing the failing testcases that this unlocks.

Mon, May 31, 12:16 PM · Restricted Project, Restricted Project
mstorsjo committed rG23f7f56cecf9: [libcxx] [test] Fix the include_as_c.sh.cpp test in MSVC configurations (authored by mstorsjo).
[libcxx] [test] Fix the include_as_c.sh.cpp test in MSVC configurations
Mon, May 31, 12:14 PM
mstorsjo committed rGbe34d5f74afe: [libcxx] [test] Remove an incorrect TEST_HAS_ALIGNED_ALLOC define from… (authored by mstorsjo).
[libcxx] [test] Remove an incorrect TEST_HAS_ALIGNED_ALLOC define from…
Mon, May 31, 12:14 PM
mstorsjo committed rGc8644ae1e98c: [libcxx] Define LIBCPP_HAS_TIMESPEC_GET for MSVC configurations (authored by mstorsjo).
[libcxx] Define LIBCPP_HAS_TIMESPEC_GET for MSVC configurations
Mon, May 31, 12:14 PM
mstorsjo committed rGb48a256e9c6e: [libcxx] [test] Don't look for the literal spelling __mbstate_t in warnings (authored by mstorsjo).
[libcxx] [test] Don't look for the literal spelling __mbstate_t in warnings
Mon, May 31, 12:13 PM
mstorsjo closed D103400: [libcxx] [test] Fix the include_as_c.sh.cpp test in MSVC configurations.
Mon, May 31, 12:13 PM · Restricted Project
mstorsjo closed D103399: [libcxx] [test] Remove an incorrect TEST_HAS_ALIGNED_ALLOC macro from test_macros.h.
Mon, May 31, 12:13 PM · Restricted Project
mstorsjo closed D103398: [libcxx] Define LIBCPP_HAS_TIMESPEC_GET for MSVC configurations.
Mon, May 31, 12:13 PM · Restricted Project
mstorsjo closed D103309: [libcxx] [test] Don't look for the literal spelling __mbstate_t.
Mon, May 31, 12:13 PM · Restricted Project
mstorsjo updated the diff for D98769: [WIP] [private] [libcxx] Tests for future changes for windows CI configurations.

New run

Mon, May 31, 4:29 AM
mstorsjo requested review of D103400: [libcxx] [test] Fix the include_as_c.sh.cpp test in MSVC configurations.
Mon, May 31, 4:23 AM · Restricted Project