- User Since
- Jul 25 2016, 12:54 PM (99 w, 1 d)
Wed, Jun 13
Fri, Jun 8
FWIW, this change broke building libaom: https://bugs.chromium.org/p/aomedia/issues/detail?id=1945
Thu, Jun 7
Tue, Jun 5
Sounds sensible to me; I've tested the patch in the setup that showed the issue this original patch tried to fix, and it seems to work fine there.
It seems like this started triggering assertions in builds, I was about to file a bug about it, but it seems someone else already beat me to it, in https://bugs.llvm.org/show_bug.cgi?id=37686.
Fri, Jun 1
Tue, May 29
May 17 2018
May 15 2018
Changed String into IntOrString and changed the test to exercise both value types.
May 14 2018
Back to the original form of the check, but using sizeof(BitmapInfoHeader) instead of a separate constant.
Changed to check specifically for the PNG magic header, giving credit where it's due in the commit message :-)
Split the tests into two files.
Actually updated the patch
May 13 2018
Accidentally submitted initally before adding llvm-commits as subscriber, will resubmit.
May 12 2018
Separated the blocks, as requested.
May 11 2018
Simplified the estimate, elaborated the comment a little.
Made the requested adjustments.
May 10 2018
This caused lots of assertion errors in building code with mingw-w64 headers (where snprintf can be a static inline function), see https://bugs.llvm.org/show_bug.cgi?id=37408. I would like to revert this change to unbreak things until this can be fixed.
May 9 2018
Adapted to the review comments; using std::vector<StringRef> + llvm::join to queue up the output, excluding *.c as well, added a reference to the documentation on the matter, simplified the line parsing significantly using @zturner's hints about better StringRef helpers to use.
Reverted in SVN r331858.