- User Since
- Jul 25 2016, 12:54 PM (164 w, 6 d)
Updated the patch to simply remove the now redundant workaround.
@hhb - This is the only change left for builds of lldb on mingw to succeed for me (for x86), but I have a whole bunch of more changes lined up that fix warnings and other issues I've found.
D67887 was committed with the same change.
Just FTR, this was identical to D67857 that I posted a few days ago.
Sat, Sep 21
Fri, Sep 20
Added a comment.
Updated the CUDA test based on the suggestion.
Wed, Sep 18
Sun, Sep 15
Fri, Sep 13
Adapted based on the feedback so far, suggestions on naming and grouping the warning are welcome.
Thu, Sep 12
Wed, Sep 11
Tweaked the syntax for parameter literal names in comments, reinstated a check for config->demangle in the wasm backend.
Tue, Sep 10
Removed use of llvm::Optional in the demangle library, adapted COFF/Symbols.cpp to do a check for "demangled != demangleInput" instead of checking an Optional return value.
Extended the llvm demangle function to take an optional parameter for requesting it to only demangle symbols with a stricter prefix check (only allowing _Z).
Updated to use the already unified llvm demangler frontend function, removing a lot of duplicated code in lld.
It turns out most of this discussion already is moot; the llvm demangle library already has a common unified function, which takes itanium names with 1-4 leading underscores. That makes this patch even simpler, mostly just rip out a lot of duplicated code from lld. This makes things a bit looser (the previous lld frontend to itaniumDemangle required it to start with exactly _Z), but as this is the current behaviour of the common demangle library, that's probably not an issue in practice.
Mon, Sep 9
Renamed the existing functions to clarify that they operate on codeview debug info only.
Reduced the test case further, converted it to use spaces instead of tabs. (A few manual edits had given some parts get mixed indentation in the middle of lines before.) Keeping the symbolizer around in the global config object (without std::unique_ptr, as it's allocated by the arena allocator with make<LLVMSymbolizer>()).
Sun, Sep 8
Sat, Sep 7
Reduced the size of the test case by manually cutting out unneeded parts, similar to some of the ELF tests.