Page MenuHomePhabricator

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (348 w, 4 d)

Recent Activity

Yesterday

mstorsjo committed rGc5383536cb68: [ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST (authored by mstorsjo).
[ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST
Fri, Mar 31, 12:27 AM · Restricted Project, Restricted Project
mstorsjo closed D147212: [ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST.
Fri, Mar 31, 12:27 AM · Restricted Project, Restricted Project

Thu, Mar 30

mstorsjo added a reviewer for D143541: [llvm-lib] Add support for ARM64EC libraries.: efriedma.
Thu, Mar 30, 2:09 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D147212: [ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST.

I'm assuming the load/store ops are getting generated by expanding a PUSH/POP, and not some other transform? (So the offset will actually reliably be 4, in practice?)

Not sure actually - if looking at the output of -print-after-all here, the t2STR_PRE appears as such directly, not as a transformation of something else - I don't directly see where it comes from (other than printf instrumenting the code in Target/ARM to see which reference to t2STR_PRE gets hit).

Skimming the code, it looks like it's coming out of ARMFrameLowering::emitPushInst... which should be safe in that respect.

Thu, Mar 30, 2:08 PM · Restricted Project, Restricted Project
mstorsjo accepted D147059: [asan][test] Fix tests or mark XFAIL for MinGW target.

I'm still not entirely a fan of the brittle test that tries to link in two different ways though, but I guess it can be tolerable if it's only this one test.

Thu, Mar 30, 2:05 PM · Restricted Project, Restricted Project
mstorsjo accepted D147232: [asan][test] Fix `TestCases/alloca_*` ptr-to-long cast on Windows.

LGTM, thanks!

Thu, Mar 30, 2:01 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D147212: [ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST.

Can you stick the testcase into wineh-opcodes.ll?

Thu, Mar 30, 1:55 PM · Restricted Project, Restricted Project
mstorsjo added a reviewer for D145683: [runtimes] Allow passing individual parameters to the default target runtimes/builtins: thieta.
Thu, Mar 30, 1:43 PM · Restricted Project, Restricted Project
mstorsjo requested review of D147212: [ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST.
Thu, Mar 30, 3:36 AM · Restricted Project, Restricted Project
mstorsjo accepted D147059: [asan][test] Fix tests or mark XFAIL for MinGW target.

Overall LGTM, but I think it maybe would be nicer to split out the long->intptr_t changes into a separate patch.

Thu, Mar 30, 1:24 AM · Restricted Project, Restricted Project

Wed, Mar 29

mstorsjo added a comment to D145807: [libcxx] [test] Print the failing commands in Configuration{Compilation,Runtime}Error.

Ping

Wed, Mar 29, 2:35 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D145683: [runtimes] Allow passing individual parameters to the default target runtimes/builtins.

Ping @phosek

Wed, Mar 29, 2:17 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D147057: [compiler-rt][asan][test] Fix lit test config on MinGW.
Wed, Mar 29, 1:01 AM · Restricted Project, Restricted Project
mstorsjo added inline comments to D147059: [asan][test] Fix tests or mark XFAIL for MinGW target.
Wed, Mar 29, 12:35 AM · Restricted Project, Restricted Project

Tue, Mar 28

mstorsjo added inline comments to D146908: [clang][MinGW] Add asan DLL lib before other libs and objects.
Tue, Mar 28, 1:31 PM · Restricted Project, Restricted Project
mstorsjo updated subscribers of D147059: [asan][test] Fix tests or mark XFAIL for MinGW target.
Tue, Mar 28, 1:27 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D147059: [asan][test] Fix tests or mark XFAIL for MinGW target.
Tue, Mar 28, 1:27 PM · Restricted Project, Restricted Project
mstorsjo accepted D147057: [compiler-rt][asan][test] Fix lit test config on MinGW.

Looks reasonable overall I think, nothing to object to from my point of view, just a few minor comments.. The patch is a bit unwieldy with the number of tests marked as unsupported, but I guess it's as good as it will be. If we're only touching tests that use specifically clang_cl_* to build/run, the mass editing probably is ok.

Tue, Mar 28, 1:14 PM · Restricted Project, Restricted Project
mstorsjo accepted D146908: [clang][MinGW] Add asan DLL lib before other libs and objects.

LGTM overall.

Tue, Mar 28, 12:24 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D146908: [clang][MinGW] Add asan DLL lib before other libs and objects.
Tue, Mar 28, 4:33 AM · Restricted Project, Restricted Project
mstorsjo added inline comments to D146908: [clang][MinGW] Add asan DLL lib before other libs and objects.
Tue, Mar 28, 4:26 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D146908: [clang][MinGW] Add asan DLL lib before other libs and objects.

I tested this, and this does fix the repro from the linked issue.

Tue, Mar 28, 3:39 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.

Btw, for issues like these, it would be super useful if there was a CI configuration that builds libcxx/libunwind/libcxxabi from scratch in an environment where there's no preexisting unwinder or C++ library.

Tue, Mar 28, 2:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo added a comment to D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.

Thanks for the revert - I was also just looking into a build issue that seems to be caused by this commit.

Tue, Mar 28, 2:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo committed rGfa3cb517e4a5: [llvm-windres] Fix a test that failed on Windows. NFC. (authored by mstorsjo).
[llvm-windres] Fix a test that failed on Windows. NFC.
Tue, Mar 28, 1:59 AM · Restricted Project, Restricted Project
mstorsjo committed rG0f4c6b120f21: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes (authored by mstorsjo).
[lvm-windres] Try to match GNU windres regarding handling of unescaped quotes
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo committed rGdc41f387e357: [llvm-rc] Remove transitional preprocessing fallback logic (authored by mstorsjo).
[llvm-rc] Remove transitional preprocessing fallback logic
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo committed rG014e5c8d39c1: [llvm-rc] Fix the reference to the option for disabling preprocessing in a… (authored by mstorsjo).
[llvm-rc] Fix the reference to the option for disabling preprocessing in a…
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo committed rG282744a9ce18: [llvm-rc] Look for "clang-<major>" when locating a suitable preprocessor (authored by mstorsjo).
[llvm-rc] Look for "clang-<major>" when locating a suitable preprocessor
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo committed rGd2fa6b694c20: [llvm-rc] Respect the executable specified in the --preprocessor command (authored by mstorsjo).
[llvm-rc] Respect the executable specified in the --preprocessor command
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo closed D146848: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes.
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo closed D146797: [llvm-rc] Remove transitional preprocessing fallback logic.
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo closed D146796: [llvm-rc] Fix the reference to the option for disabling preprocessing in a message.
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo closed D146794: [llvm-rc] Look for "clang-<major>" when locating a suitable preprocessor.
Tue, Mar 28, 1:04 AM · Restricted Project, Restricted Project
mstorsjo closed D146793: [llvm-rc] Respect the executable specified in the --preprocessor command.
Tue, Mar 28, 1:03 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D146848: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes.

Oh, that's unfortunate.
Maybe llvm-windres should generate a warning in such case?

Hmm, maybe... (I'd need to think about it again to sort my thoughts out about it; I had written this patch 6 months ago but never took the time to finish it to have it reviewed.)

Tue, Mar 28, 12:59 AM · Restricted Project, Restricted Project
mstorsjo abandoned D146925: [OpenMP] Fix building the second import library when built in the main llvm build root.

Superseded by the improved version of D146894.

Tue, Mar 28, 12:41 AM · Restricted Project, Restricted Project

Mon, Mar 27

mstorsjo accepted D146894: [OpenMP] Fix an OpenMP Windows build problem .

LGTM, thanks! This is indeed the neatest solution so far!

Mon, Mar 27, 1:41 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D146925: [OpenMP] Fix building the second import library when built in the main llvm build root.

I will be good with this solution, but I think there could be a simpler one in the end. While CMAKE does wants to see a source, that does not have to be a cpp (which is what's causing this need to unnecessarily feed the first step's library to satisfy lib's attempt at def symbols resolution). There are other source types (e.g., a. txt) which will satisfy the source presence requirement but which CMAKE will filter out from the librarian generating the right command line for it.

Mon, Mar 27, 1:30 PM · Restricted Project, Restricted Project

Sun, Mar 26

mstorsjo requested review of D146925: [OpenMP] Fix building the second import library when built in the main llvm build root.
Sun, Mar 26, 2:58 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D144419: Improvements to the OpenMP Windows build.

The source of problem is the attempt to re-use the results of the first build in order to avoid rebuilding the sources the second time to just re-generate the import library. This is being done by feeding the main build's import library as a source to the second one (@301) with CMAKE ending up assuming the library is located where the sources are, hence the reference to projects/openmp/runtime/src/libomp.dll.lib instead of what should be lib/libomp.dll.lib in the LLVM based build.

Sun, Mar 26, 2:53 PM · Restricted Project, Restricted Project

Sat, Mar 25

mstorsjo added a comment to D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode.

Sorry, I didn't have time on the weekdays. But I have time today.

Yes, it looks good.

Sat, Mar 25, 2:36 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D146848: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes.

Oh, that's unfortunate.
Maybe llvm-windres should generate a warning in such case?

Sat, Mar 25, 2:18 PM · Restricted Project, Restricted Project

Fri, Mar 24

mstorsjo requested review of D146848: [lvm-windres] Try to match GNU windres regarding handling of unescaped quotes.
Fri, Mar 24, 2:37 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D146794: [llvm-rc] Look for "clang-<major>" when locating a suitable preprocessor.

Reordered the checks to check for "clang-<major>" before plain "clang", as suggested in the linked discussion.

Fri, Mar 24, 2:16 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D144419: Improvements to the OpenMP Windows build.

Could you describe some more what needs fixing? The Windows build with a MSVC toolset should perhaps use lib.

Fri, Mar 24, 10:39 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D144419: Improvements to the OpenMP Windows build.

Could you describe some more what needs fixing? The Windows build with a MSVC toolset should perhaps use lib.

Fri, Mar 24, 9:45 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D144419: Improvements to the OpenMP Windows build.

Also, as mentioned above, the Windows LLVM release currently can't build OpenMP, so as it currently stands LLVM 17 will not include the OpenMP runtime for Windows.

Fri, Mar 24, 7:21 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D146797: [llvm-rc] Remove transitional preprocessing fallback logic.

LG.

Just a thought: as future work, we should probably have an integration with LLVM_TOOL_LLVM_DRIVER_BUILD?

Fri, Mar 24, 7:14 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D146764: [clang] Make predefined expressions string literals under -fms-extensions.

+mstorsjo is this okay for mingw mode too?

Fri, Mar 24, 7:10 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D144419: Improvements to the OpenMP Windows build.

It seems like this change has broken building OpenMP with MSVC as a toplevel project from the llvm-project/llvm directory. To reproduce, make a build directory as a subdirectory to llvm-project/llvm, and configure it with cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;openmp". When I try to build with ninja, I get the following error:

ninja: error: 'projects/openmp/runtime/src/libomp.dll.lib', needed by 'lib/libomp.lib', missing and no known rule to make it

It seems like some of the subdirectory path prefixes end up applied inconsistently breaking the dependency chain here, making ninja refuse to proceed.

Fri, Mar 24, 6:10 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D146621: [sanitizer][win] Change cmdline check to allow double backslashs.

I did test this patch manually, but I don't have an environment for running the lit test so I may have to ask @mstorsjo to try that. Sorry to bother you :)

Fri, Mar 24, 5:35 AM · Restricted Project, Restricted Project
mstorsjo requested review of D146797: [llvm-rc] Remove transitional preprocessing fallback logic.
Fri, Mar 24, 3:29 AM · Restricted Project, Restricted Project
mstorsjo requested review of D146796: [llvm-rc] Fix the reference to the option for disabling preprocessing in a message.
Fri, Mar 24, 3:28 AM · Restricted Project, Restricted Project
mstorsjo requested review of D146794: [llvm-rc] Look for "clang-<major>" when locating a suitable preprocessor.
Fri, Mar 24, 3:26 AM · Restricted Project, Restricted Project
mstorsjo requested review of D146793: [llvm-rc] Respect the executable specified in the --preprocessor command.
Fri, Mar 24, 3:25 AM · Restricted Project, Restricted Project
mstorsjo committed rG4a5bc791f38a: [CMake] Respect variables for specifying host tools even without… (authored by mstorsjo).
[CMake] Respect variables for specifying host tools even without…
Fri, Mar 24, 1:35 AM · Restricted Project, Restricted Project
mstorsjo closed D146666: [CMake] Respect variables for specifying host tools even without LLVM_USE_HOST_TOOLS set.
Fri, Mar 24, 1:35 AM · Restricted Project, Restricted Project
mstorsjo added inline comments to D145962: [lld] Fill .text section gaps with INT3 only on x86 targets..
Fri, Mar 24, 1:31 AM · Restricted Project, Restricted Project
mstorsjo committed rG09aa3f7bb54b: [LLD] [test] Add a missing REQUIRES: x86 in a new test (authored by mstorsjo).
[LLD] [test] Add a missing REQUIRES: x86 in a new test
Fri, Mar 24, 1:31 AM · Restricted Project
mstorsjo added a comment to D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode.

@fsb4000 Can you have a look at this, does it seem reasonable to you? (As mentioned in the patch description, I'm not a fan of the amount of ifdefs that this adds, but I didn't see a good way of getting away with fewer of them either.

Fri, Mar 24, 1:16 AM · Restricted Project, Restricted Project
mstorsjo added inline comments to D145962: [lld] Fill .text section gaps with INT3 only on x86 targets..
Fri, Mar 24, 12:50 AM · Restricted Project, Restricted Project

Thu, Mar 23

mstorsjo committed rGa5988034a44d: [lld] Fill .text section gaps with INT3 only on x86 targets. (authored by jacek).
[lld] Fill .text section gaps with INT3 only on x86 targets.
Thu, Mar 23, 4:44 AM · Restricted Project
mstorsjo committed rG4fcbf3842007: [llvm-lib] Use COFF archive format in llvm-lib (other archive tools don't use… (authored by jacek).
[llvm-lib] Use COFF archive format in llvm-lib (other archive tools don't use…
Thu, Mar 23, 4:44 AM · Restricted Project, Restricted Project
mstorsjo committed rG257dc54be2d2: [Object][NFC] Don't insert string table into object members vector. (authored by jacek).
[Object][NFC] Don't insert string table into object members vector.
Thu, Mar 23, 4:44 AM · Restricted Project, Restricted Project
mstorsjo committed rG67d828fb2c01: [Object][NFC] Factor out computeHeadersSize. (authored by jacek).
[Object][NFC] Factor out computeHeadersSize.
Thu, Mar 23, 4:44 AM · Restricted Project, Restricted Project
mstorsjo closed D145962: [lld] Fill .text section gaps with INT3 only on x86 targets..
Thu, Mar 23, 4:44 AM · Restricted Project, Restricted Project
mstorsjo closed D143540: [llvm-lib] Use COFF archive format in llvm-lib (other archive tools don't use this format)..
Thu, Mar 23, 4:44 AM · Restricted Project, Restricted Project
mstorsjo closed D143538: [Object][NFC] Don't insert string table into object members vector..
Thu, Mar 23, 4:44 AM · Restricted Project, Restricted Project
mstorsjo closed D143537: [Object][NFC] Factor out computeHeadersSize..
Thu, Mar 23, 4:44 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D146666: [CMake] Respect variables for specifying host tools even without LLVM_USE_HOST_TOOLS set.

I'd need to learn more about the use case (I see you're awaiting a response on the issue), but I'm not a huge fan personally; it seems really weird to not be going through the standard CMake mechanisms for cross-compilation (setting a CMAKE_SYSTEM_NAME), and if you do that then this should work as expected. We should understand why LLVM_USE_HOST_TOOLS isn't being set automatically.

Yeah, in one sense, that’s the correct thing to do. But on the other hand, even if I’m doing a simple native build, if I’m going out of my way to specify the path to these tools, perhaps we should respect it. We already do it somewhat inconsistently - AFAIK the variables do take effect for the tablegen family of tools without checking the LLVM_USE_HOST_TOOLS variables.

The flip side could be that you have a shared configuration for all your builds that just sets that flag in case it's needed, and that shared config is used by both native and cross-compilation. Not sure how realistic that is either, but I can see someone being surprised the other way as well.

Thu, Mar 23, 12:55 AM · Restricted Project, Restricted Project

Wed, Mar 22

mstorsjo added a comment to D146666: [CMake] Respect variables for specifying host tools even without LLVM_USE_HOST_TOOLS set.

I'd need to learn more about the use case (I see you're awaiting a response on the issue), but I'm not a huge fan personally; it seems really weird to not be going through the standard CMake mechanisms for cross-compilation (setting a CMAKE_SYSTEM_NAME), and if you do that then this should work as expected. We should understand why LLVM_USE_HOST_TOOLS isn't being set automatically.

Wed, Mar 22, 4:24 PM · Restricted Project, Restricted Project
mstorsjo requested review of D146666: [CMake] Respect variables for specifying host tools even without LLVM_USE_HOST_TOOLS set.
Wed, Mar 22, 3:56 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D143537: [Object][NFC] Factor out computeHeadersSize..

FYI, most (all?) use of llvm::Optional has been migrated to std::optional these days.

Wed, Mar 22, 10:05 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D145389: [lld][flang] Add exceptions for Flang runtime libraries on MinGW..

Is it worth cherry-picking this to LLVM 16?
It seems low-risk. But iiuc, Flang isn't advertised as being production-ready anyway.

Yeah this is very low risk, so it should be a good fit for backporting to the release. But AFAIK they're trying hard to squeeze out the last bugs to get 16.0.0 out now, and this is kinda low priority, so perhaps it's better to not make more noise about this right now - perhaps it's best to wait until after 16.0.0 to file a backport request?

Wed, Mar 22, 5:41 AM · Restricted Project, Restricted Project, lld, Restricted Project
mstorsjo accepted D146621: [sanitizer][win] Change cmdline check to allow double backslashs.

Maybe adjust the commit message a little,

Wed, Mar 22, 3:45 AM · Restricted Project, Restricted Project

Tue, Mar 21

mstorsjo added a comment to D146490: [Support] On Windows, ensure that UniqueID is really stable.

Fair enough. There are several choices forward: either we mark the issue as "Will Not Fix" or I can try only scoping this patch to only keep the handle for network drives/paths. Any other suggestions?

Tue, Mar 21, 6:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Mar 20

mstorsjo updated the diff for D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode.

Rebased on latest git, to get a cleaner CI run.

Mon, Mar 20, 3:56 AM · Restricted Project, Restricted Project

Sun, Mar 19

mstorsjo requested review of D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode.
Sun, Mar 19, 3:48 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D146352: Split out `llvm-cg-tblgen` from `llvm-tblgen`.

@mstorsjo How about it?

  • llvm-minimal-tblgen -- Build only in the tree.
  • llvm-tblgen includes codegen emitters. It may be exported. It may be used to check-llvm (my patches to test/TableGen would be unneeded)
Sun, Mar 19, 3:34 PM · Restricted Project, Restricted Project

Sat, Mar 18

mstorsjo added inline comments to D146352: Split out `llvm-cg-tblgen` from `llvm-tblgen`.
Sat, Mar 18, 3:22 PM · Restricted Project, Restricted Project

Thu, Mar 16

mstorsjo added a comment to D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI.

I'm not really fond of declaring the MSVC ABI as unstable. If there is no other way, please add this information in the commit message. That way we can find back why it was decided to declare the ABI on a platform as unstable.

Thu, Mar 16, 9:50 AM · Restricted Project, Restricted Project

Wed, Mar 15

mstorsjo added a comment to D146165: docs: add some documentation on Windows SDK search.

Looks reasonable I guess - but I think it would be good to mention the env variables INCLUDE and LIB too, for alternative ways of finding the same things - even if it's not strictly the same as what this new section talks about.

Wed, Mar 15, 1:28 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D98769: [WIP] [private] [libcxx] Tests for future changes for windows CI configurations.
Wed, Mar 15, 4:55 AM · Restricted Project

Tue, Mar 14

mstorsjo accepted D145962: [lld] Fill .text section gaps with INT3 only on x86 targets..

So, MS link.exe fills sections with zero? Is that a specific design choice (i.e. does it fill with 0xcc on x86) or is it simply the case that link.exe doesn't try to fill sections with sentinel instructions at all?

It seems to be a design choice: link.exe does fill with 0xcc on x64. I will add a test case for x64.

Tue, Mar 14, 1:54 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D145208: [COFF] Add MC support for emitting IMAGE_WEAK_EXTERN_ANTI_DEPENDENCY symbols.
Tue, Mar 14, 1:49 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D145208: [COFF] Add MC support for emitting IMAGE_WEAK_EXTERN_ANTI_DEPENDENCY symbols.

Looks reasonable to me, but I don't feel entirely confident about what this does in the common MC layer changes.

Tue, Mar 14, 5:56 AM · Restricted Project, Restricted Project
mstorsjo accepted D145962: [lld] Fill .text section gaps with INT3 only on x86 targets..

Thanks for the patch - I've consiered doing something about this at some time. At the time, I considered filling areas with a more specific pattern, mapping to trapping instructions similar to int3, but since it requires multibyte patterns instead of filling with a single byte, I never got to doing anything about it.

Tue, Mar 14, 3:30 AM · Restricted Project, Restricted Project
mstorsjo added a reviewer for D144651: [Serialization] Place command line defines in the correct file: aaron.ballman.

Adding @aaron.ballman as fallback Clang reviewer here. While I did touch code in the vicinity of this area recently, I'm not familiar enough with the whole area to take on reviewing it at the moment.

Tue, Mar 14, 3:24 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 13

mstorsjo added a comment to D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.

I took a look at what's going wrong here; I diffed the cmake output from a cmake run before and after this change:

@@ -17,12 +17,12 @@
 -- Performing Test LLVM_RUNTIMES_LINKING_WORKS
 -- Performing Test LLVM_RUNTIMES_LINKING_WORKS - Success
 -- Performing Test CXX_SUPPORTS_NOSTDLIBXX_FLAG
--- Performing Test CXX_SUPPORTS_NOSTDLIBXX_FLAG - Failed
+-- Performing Test CXX_SUPPORTS_NOSTDLIBXX_FLAG - Success
 -- Performing Test CXX_SUPPORTS_NOSTDINCXX_FLAG
 -- Performing Test CXX_SUPPORTS_NOSTDINCXX_FLAG - Failed
 -- Using Release VC++ CRT: MD
 -- Performing Test SUPPORTS_BREPRO
--- Performing Test SUPPORTS_BREPRO - Success
+-- Performing Test SUPPORTS_BREPRO - Failed
 -- Looking for os_signpost_interval_begin
 -- Looking for os_signpost_interval_begin - not found
 -- Found Python3: /usr/bin/python3.10 (found version "3.10.6") found components: Interpreter
@@ -33,8 +33,6 @@
 -- Using libc++ testing configuration: /home/martin/code/llvm-project/libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
 -- Performing Test CXX_SUPPORTS_UNWINDLIB_EQ_NONE_FLAG
 -- Performing Test CXX_SUPPORTS_UNWINDLIB_EQ_NONE_FLAG - Failed
--- Performing Test C_SUPPORTS_NODEFAULTLIBS_FLAG
--- Performing Test C_SUPPORTS_NODEFAULTLIBS_FLAG - Failed
 -- Performing Test C_SUPPORTS_COMMENT_LIB_PRAGMA
 -- Performing Test C_SUPPORTS_COMMENT_LIB_PRAGMA - Failed
 -- Performing Test CXX_SUPPORTS_FALIGNED_ALLOCATION_FLAG
@@ -44,71 +42,65 @@
 -- Performing Test CXX_SUPPORTS_FVISIBILITY_EQ_HIDDEN_FLAG
 -- Performing Test CXX_SUPPORTS_FVISIBILITY_EQ_HIDDEN_FLAG - Failed
 -- Performing Test CXX_SUPPORTS_W4_FLAG
--- Performing Test CXX_SUPPORTS_W4_FLAG - Success
+-- Performing Test CXX_SUPPORTS_W4_FLAG - Failed
 -- Performing Test CXX_SUPPORTS_WEXTRA_FLAG
Mon, Mar 13, 1:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Mar 10

mstorsjo requested review of D145807: [libcxx] [test] Print the failing commands in Configuration{Compilation,Runtime}Error.
Fri, Mar 10, 9:13 AM · Restricted Project, Restricted Project
mstorsjo updated the diff for D98769: [WIP] [private] [libcxx] Tests for future changes for windows CI configurations.
Fri, Mar 10, 4:19 AM · Restricted Project
mstorsjo updated the diff for D98769: [WIP] [private] [libcxx] Tests for future changes for windows CI configurations.
Fri, Mar 10, 3:44 AM · Restricted Project
mstorsjo updated the diff for D98769: [WIP] [private] [libcxx] Tests for future changes for windows CI configurations.
Fri, Mar 10, 3:37 AM · Restricted Project

Thu, Mar 9

mstorsjo added inline comments to D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Thu, Mar 9, 1:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo accepted D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.

LGTM

Thu, Mar 9, 1:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo added a comment to D145389: [lld][flang] Add exceptions for Flang runtime libraries on MinGW..

Is it worth cherry-picking this to LLVM 16?
It seems low-risk. But iiuc, Flang isn't advertised as being production-ready anyway.

Thu, Mar 9, 4:32 AM · Restricted Project, Restricted Project, lld, Restricted Project
mstorsjo requested review of D145683: [runtimes] Allow passing individual parameters to the default target runtimes/builtins.
Thu, Mar 9, 3:47 AM · Restricted Project, Restricted Project
mstorsjo committed rG0ea8229bf878: Reapply [lld][flang] Add exceptions for Flang runtime libraries on MinGW. (authored by mmuetzel).
Reapply [lld][flang] Add exceptions for Flang runtime libraries on MinGW.
Thu, Mar 9, 3:20 AM · Restricted Project
mstorsjo added a reverting change for rG04fc67bf08da: [lld][flang] Add exceptions for Flang runtime libraries on MinGW.: rG0dd98e1251a3: Revert "[lld][flang] Add exceptions for Flang runtime libraries on MinGW.".
Thu, Mar 9, 3:19 AM · Restricted Project