mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (99 w, 1 d)

Recent Activity

Wed, Jun 13

mstorsjo accepted D48132: [COFF] Add ARM64 intrinsics: __yield, __wfe, __wfi, __sev, __sevl.

LGTM

Wed, Jun 13, 11:45 AM

Fri, Jun 8

mstorsjo added a comment to rC334208: [X86] Add back builtins for _mm_slli_si128/_mm_srli_si128 and similar….

FWIW, this change broke building libaom: https://bugs.chromium.org/p/aomedia/issues/detail?id=1945

Fri, Jun 8, 12:56 AM

Thu, Jun 7

mstorsjo accepted D47853: [Frontend] Disallow non-MSVC exception models for windows-msvc targets.

LGTM, thanks!

Thu, Jun 7, 1:10 PM
mstorsjo added inline comments to D47853: [Frontend] Disallow non-MSVC exception models for windows-msvc targets.
Thu, Jun 7, 2:00 AM

Tue, Jun 5

mstorsjo accepted D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size.

Sounds sensible to me; I've tested the patch in the setup that showed the issue this original patch tried to fix, and it seems to work fine there.

Tue, Jun 5, 11:40 PM
mstorsjo added a comment to D47631: [ValueTracking] Match select abs pattern when there's an sext involved.

It seems like this started triggering assertions in builds, I was about to file a bug about it, but it seems someone else already beat me to it, in https://bugs.llvm.org/show_bug.cgi?id=37686.

Tue, Jun 5, 1:17 AM

Fri, Jun 1

mstorsjo committed rC333734: [X86] Remove leftover semicolons at end of macros.
[X86] Remove leftover semicolons at end of macros
Fri, Jun 1, 2:45 AM
mstorsjo committed rL333734: [X86] Remove leftover semicolons at end of macros.
[X86] Remove leftover semicolons at end of macros
Fri, Jun 1, 2:45 AM

Tue, May 29

mstorsjo accepted D47476: Support __iso_volatile_load8 etc on aarch64-win32..

LGTM, thanks!

Tue, May 29, 12:53 PM

May 17 2018

mstorsjo added a comment to D47002: [Analysis] Only use _unlocked stdio functions on linux.

Just for info.. Windows has also some kind of unlocked stdio via _nolock functions :)

Yes, I saw that as well :-) However it doesn't seem to be available in the system DLL "msvcrt.dll" which mingw targets by default. (Nowadays one can target the more modern ucrtbase.dll by default as well, and there they'd be available.)

May 17 2018, 1:38 AM
mstorsjo added a comment to D47002: [Analysis] Only use _unlocked stdio functions on linux.

Just for info.. Windows has also some kind of unlocked stdio via _nolock functions :)

May 17 2018, 1:34 AM
mstorsjo committed rL332581: [Analysis] Only use _unlocked stdio functions on linux.
[Analysis] Only use _unlocked stdio functions on linux
May 17 2018, 1:20 AM
mstorsjo closed D47002: [Analysis] Only use _unlocked stdio functions on linux.
May 17 2018, 1:20 AM
mstorsjo added inline comments to D47002: [Analysis] Only use _unlocked stdio functions on linux.
May 17 2018, 12:55 AM
mstorsjo added inline comments to D47002: [Analysis] Only use _unlocked stdio functions on linux.
May 17 2018, 12:46 AM
mstorsjo created D47002: [Analysis] Only use _unlocked stdio functions on linux.
May 17 2018, 12:26 AM

May 15 2018

mstorsjo committed rL332398: [MinGW] Handle the GNU ld option -Map for outputting a linker map.
[MinGW] Handle the GNU ld option -Map for outputting a linker map
May 15 2018, 2:16 PM
mstorsjo committed rLLD332398: [MinGW] Handle the GNU ld option -Map for outputting a linker map.
[MinGW] Handle the GNU ld option -Map for outputting a linker map
May 15 2018, 2:16 PM
mstorsjo closed D46872: [LLD] [MinGW] Handle the GNU ld option -Map for outputting a linker map.
May 15 2018, 2:16 PM
mstorsjo committed rL332386: [llvm-rc] Add support for the optional CLASS statement for dialogs.
[llvm-rc] Add support for the optional CLASS statement for dialogs
May 15 2018, 12:26 PM
mstorsjo closed D46875: [llvm-rc] Add support for the optional CLASS statement for dialogs.
May 15 2018, 12:26 PM
mstorsjo updated the diff for D46875: [llvm-rc] Add support for the optional CLASS statement for dialogs.

Changed String into IntOrString and changed the test to exercise both value types.

May 15 2018, 11:17 AM
mstorsjo added inline comments to D46875: [llvm-rc] Add support for the optional CLASS statement for dialogs.
May 15 2018, 10:15 AM
mstorsjo created D46875: [llvm-rc] Add support for the optional CLASS statement for dialogs.
May 15 2018, 6:20 AM
mstorsjo created D46872: [LLD] [MinGW] Handle the GNU ld option -Map for outputting a linker map.
May 15 2018, 5:07 AM

May 14 2018

mstorsjo committed rL332329: [llvm-rc] Add support for parsing memory flags.
[llvm-rc] Add support for parsing memory flags
May 14 2018, 11:39 PM
mstorsjo closed D46818: [llvm-rc] Add support for parsing memory flags.
May 14 2018, 11:39 PM
mstorsjo committed rL332328: [llvm-rc] Read the Planes/BitCount fields from BITMAPINFOHEADER for icons.
[llvm-rc] Read the Planes/BitCount fields from BITMAPINFOHEADER for icons
May 14 2018, 11:39 PM
mstorsjo closed D46816: [llvm-rc] Read the Planes/BitCount fields from BITMAPINFOHEADER for icons.
May 14 2018, 11:39 PM
mstorsjo committed rLLD332327: [MinGW] Add a LLD specific option -pdb.
[MinGW] Add a LLD specific option -pdb
May 14 2018, 11:38 PM
mstorsjo committed rL332327: [MinGW] Add a LLD specific option -pdb.
[MinGW] Add a LLD specific option -pdb
May 14 2018, 11:38 PM
mstorsjo closed D46796: [LLD] [MinGW] Add a LLD specific option -pdb.
May 14 2018, 11:38 PM
mstorsjo updated the diff for D46816: [llvm-rc] Read the Planes/BitCount fields from BITMAPINFOHEADER for icons.

Back to the original form of the check, but using sizeof(BitmapInfoHeader) instead of a separate constant.

May 14 2018, 2:44 PM
mstorsjo committed rL332298: [ARM] Back up R4 and LR if calling the stack probe function.
[ARM] Back up R4 and LR if calling the stack probe function
May 14 2018, 2:36 PM
mstorsjo closed D46777: [ARM] Back up R4 and LR if calling the stack probe function.
May 14 2018, 2:36 PM
mstorsjo committed rL332297: [llvm-rc] Add missing inputs for tag-icon-cursor.test..
[llvm-rc] Add missing inputs for tag-icon-cursor.test.
May 14 2018, 2:36 PM
mstorsjo closed D46813: [llvm-rc] Add missing inputs for tag-icon-cursor.test..
May 14 2018, 2:36 PM
mstorsjo updated the diff for D46816: [llvm-rc] Read the Planes/BitCount fields from BITMAPINFOHEADER for icons.

Changed to check specifically for the PNG magic header, giving credit where it's due in the commit message :-)

May 14 2018, 2:10 PM
mstorsjo added a comment to D46818: [llvm-rc] Add support for parsing memory flags.

I kinda wish the test was broken up a bit. The stringtable bundle logic is distinctly different than just applying the keywords to other resource types, so that would be a natural place to break this apart.

May 14 2018, 1:58 PM
mstorsjo updated the diff for D46818: [llvm-rc] Add support for parsing memory flags.

Split the tests into two files.

May 14 2018, 1:58 PM
mstorsjo added inline comments to D46816: [llvm-rc] Read the Planes/BitCount fields from BITMAPINFOHEADER for icons.
May 14 2018, 11:51 AM
mstorsjo added a comment to D46777: [ARM] Back up R4 and LR if calling the stack probe function.

Separated the blocks, as requested.

I think you forgot to upload updated patch.

May 14 2018, 1:50 AM
mstorsjo updated the diff for D46777: [ARM] Back up R4 and LR if calling the stack probe function.

Actually updated the patch

May 14 2018, 1:50 AM
mstorsjo created D46818: [llvm-rc] Add support for parsing memory flags.
May 14 2018, 1:12 AM

May 13 2018

mstorsjo created D46816: [llvm-rc] Read the Planes/BitCount fields from BITMAPINFOHEADER for icons.
May 13 2018, 11:59 PM
mstorsjo added inline comments to D46813: [llvm-rc] Add missing inputs for tag-icon-cursor.test..
May 13 2018, 2:04 PM
mstorsjo created D46813: [llvm-rc] Add missing inputs for tag-icon-cursor.test..
May 13 2018, 1:11 PM
mstorsjo abandoned D46812: [llvm-rc] Add missing inputs for tag-icon-cursor.test..

Accidentally submitted initally before adding llvm-commits as subscriber, will resubmit.

May 13 2018, 1:10 PM
mstorsjo updated the summary of D46812: [llvm-rc] Add missing inputs for tag-icon-cursor.test..
May 13 2018, 1:06 PM
mstorsjo created D46812: [llvm-rc] Add missing inputs for tag-icon-cursor.test..
May 13 2018, 1:05 PM

May 12 2018

mstorsjo created D46796: [LLD] [MinGW] Add a LLD specific option -pdb.
May 12 2018, 1:23 PM
mstorsjo updated the diff for D46777: [ARM] Back up R4 and LR if calling the stack probe function.

Separated the blocks, as requested.

May 12 2018, 10:10 AM
mstorsjo added inline comments to D46777: [ARM] Back up R4 and LR if calling the stack probe function.
May 12 2018, 10:09 AM

May 11 2018

mstorsjo updated the diff for D46777: [ARM] Back up R4 and LR if calling the stack probe function.

Simplified the estimate, elaborated the comment a little.

May 11 2018, 11:42 PM
mstorsjo added inline comments to D46777: [ARM] Back up R4 and LR if calling the stack probe function.
May 11 2018, 11:39 PM
mstorsjo created D46777: [ARM] Back up R4 and LR if calling the stack probe function.
May 11 2018, 2:47 PM
mstorsjo added a comment to D46752: [Analysis] Validate the return type of s(n)printf libcalls.

I commited it again, you do not need to revert your revert.

May 11 2018, 12:46 PM
mstorsjo committed rL332114: [MachO] Don't write test files to /tmp, remove them afterwards..
[MachO] Don't write test files to /tmp, remove them afterwards.
May 11 2018, 11:22 AM
mstorsjo committed rLLD332114: [MachO] Don't write test files to /tmp, remove them afterwards..
[MachO] Don't write test files to /tmp, remove them afterwards.
May 11 2018, 11:22 AM
mstorsjo closed D46743: [MachO] Don't write test files to /tmp, remove them afterwards..
May 11 2018, 11:22 AM
mstorsjo committed rL332106: [Analysis] Validate the return type of s(n)printf like libcalls.
[Analysis] Validate the return type of s(n)printf like libcalls
May 11 2018, 9:57 AM
mstorsjo closed D46752: [Analysis] Validate the return type of s(n)printf libcalls.
May 11 2018, 9:57 AM
mstorsjo added a comment to D46752: [Analysis] Validate the return type of s(n)printf libcalls.

LGTM - thanks!
Note (future patches): just glancing at the surrounding cases, it seems like we're missing similar return type checks for other calls.

May 11 2018, 8:50 AM
mstorsjo added inline comments to D46752: [Analysis] Validate the return type of s(n)printf libcalls.
May 11 2018, 8:11 AM
mstorsjo updated the diff for D46752: [Analysis] Validate the return type of s(n)printf libcalls.

Made the requested adjustments.

May 11 2018, 8:10 AM
mstorsjo added inline comments to D46752: [Analysis] Validate the return type of s(n)printf libcalls.
May 11 2018, 8:00 AM
mstorsjo updated the diff for D46752: [Analysis] Validate the return type of s(n)printf libcalls.
May 11 2018, 7:00 AM
mstorsjo added a comment to D46752: [Analysis] Validate the return type of s(n)printf libcalls.

I haven't looked in detail at the failure or discussion in D46285 or https://bugs.llvm.org/show_bug.cgi?id=37408 , so I might be missing something.
Why are we getting this far in the 1st place? Shouldn't we have avoided this problem in TargetLibraryInfoImpl::isValidProtoForLibFunc() by checking that the return type is wrong?

May 11 2018, 6:51 AM
mstorsjo created D46752: [Analysis] Validate the return type of s(n)printf libcalls.
May 11 2018, 5:48 AM
mstorsjo added a comment to D45788: Mitigate relocation overflow [part 1 of 2].

Sorry, but I had to revert this in r332085 "[ELF] - Revert of: r332038, r332054, r332060, r332061, r332062, r332063"

May 11 2018, 1:35 AM
mstorsjo created D46743: [MachO] Don't write test files to /tmp, remove them afterwards..
May 11 2018, 1:14 AM
mstorsjo committed rL332084: Merging r327562:.
Merging r327562:
May 11 2018, 12:02 AM

May 10 2018

mstorsjo committed rL332083: Merging r327561,327567:.
Merging r327561,327567:
May 10 2018, 11:56 PM
mstorsjo committed rL332043: Revert "[InstCombine] snprintf optimizations".
Revert "[InstCombine] snprintf optimizations"
May 10 2018, 2:27 PM
mstorsjo added a comment to D46285: [InstCombine] snprintf optimizations.

This caused lots of assertion errors in building code with mingw-w64 headers (where snprintf can be a static inline function), see https://bugs.llvm.org/show_bug.cgi?id=37408. I would like to revert this change to unbreak things until this can be fixed.

C standard says:
int snprintf(char * restrict s, size_t n, const char * restrict format, ...);

May 10 2018, 2:27 PM
mstorsjo added a comment to D46285: [InstCombine] snprintf optimizations.

This caused lots of assertion errors in building code with mingw-w64 headers (where snprintf can be a static inline function), see https://bugs.llvm.org/show_bug.cgi?id=37408. I would like to revert this change to unbreak things until this can be fixed.

May 10 2018, 11:56 AM

May 9 2018

mstorsjo committed rL331912: [COFF] Fix dangling StringRefs from SVN 331900.
[COFF] Fix dangling StringRefs from SVN 331900
May 9 2018, 12:11 PM
mstorsjo committed rLLD331912: [COFF] Fix dangling StringRefs from SVN 331900.
[COFF] Fix dangling StringRefs from SVN 331900
May 9 2018, 12:11 PM
mstorsjo committed rL331903: [llvm-rc] Handle C preprocessor output.
[llvm-rc] Handle C preprocessor output
May 9 2018, 11:24 AM
mstorsjo closed D46579: [llvm-rc] Handle C preprocessor output.
May 9 2018, 11:24 AM
mstorsjo committed rL331901: [llvm-rc] Allow -1 for control IDs in old style dialogs with 16 bit fields.
[llvm-rc] Allow -1 for control IDs in old style dialogs with 16 bit fields
May 9 2018, 11:24 AM
mstorsjo committed rL331902: [llvm-rc] Add support for the RCDATA resource type.
[llvm-rc] Add support for the RCDATA resource type
May 9 2018, 11:24 AM
mstorsjo closed D46636: [llvm-rc] Add support for the RCDATA resource type.
May 9 2018, 11:24 AM
mstorsjo closed D46506: [llvm-rc] Allow -1 for control IDs in old style dialogs with 16 bit fields .
May 9 2018, 11:24 AM
mstorsjo committed rL331900: [COFF] Allow specifying export forwarding in a def file.
[COFF] Allow specifying export forwarding in a def file
May 9 2018, 11:23 AM
mstorsjo committed rLLD331900: [COFF] Allow specifying export forwarding in a def file.
[COFF] Allow specifying export forwarding in a def file
May 9 2018, 11:23 AM
mstorsjo closed D46244: [LLD] [COFF] Allow specifying export forwarding in a def file.
May 9 2018, 11:23 AM
mstorsjo added a comment to D46244: [LLD] [COFF] Allow specifying export forwarding in a def file.

Ping @ruiu

May 9 2018, 9:34 AM
mstorsjo added inline comments to D46506: [llvm-rc] Allow -1 for control IDs in old style dialogs with 16 bit fields .
May 9 2018, 9:33 AM
mstorsjo created D46636: [llvm-rc] Add support for the RCDATA resource type.
May 9 2018, 4:28 AM
mstorsjo updated the diff for D46579: [llvm-rc] Handle C preprocessor output.

Adapted to the review comments; using std::vector<StringRef> + llvm::join to queue up the output, excluding *.c as well, added a reference to the documentation on the matter, simplified the line parsing significantly using @zturner's hints about better StringRef helpers to use.

May 9 2018, 4:06 AM
mstorsjo added inline comments to D46579: [llvm-rc] Handle C preprocessor output.
May 9 2018, 4:04 AM
mstorsjo closed D46520: [Driver] Use -fuse-line-directives by default in MSVC mode.

Reverted in SVN r331858.

May 9 2018, 2:26 AM
mstorsjo committed rL331860: [COFF] Improve correctness of def parsing for GNU features.
[COFF] Improve correctness of def parsing for GNU features
May 9 2018, 2:25 AM
mstorsjo committed rLLD331860: [COFF] Improve correctness of def parsing for GNU features.
[COFF] Improve correctness of def parsing for GNU features
May 9 2018, 2:25 AM
mstorsjo committed rL331859: [COFF] Improve correctness of def parsing for GNU features.
[COFF] Improve correctness of def parsing for GNU features
May 9 2018, 2:25 AM
mstorsjo closed D46245: [COFF] Improve correctness of def parsing for GNU features.
May 9 2018, 2:25 AM
mstorsjo committed rC331858: Revert "[Driver] Use -fuse-line-directives by default in MSVC mode".
Revert "[Driver] Use -fuse-line-directives by default in MSVC mode"
May 9 2018, 2:14 AM
mstorsjo committed rL331858: Revert "[Driver] Use -fuse-line-directives by default in MSVC mode".
Revert "[Driver] Use -fuse-line-directives by default in MSVC mode"
May 9 2018, 2:14 AM

May 8 2018

mstorsjo added a comment to D46520: [Driver] Use -fuse-line-directives by default in MSVC mode.
In D46520#1092233, @rnk wrote:

Please don't do this, this is actually really problematic, since #line directives lose information about what's a system header. That means the result of -E usually won't compile, since Windows headers are typically full of warnings and default-error warnings.

May 8 2018, 9:20 PM