- User Since
- Jul 25 2016, 12:54 PM (138 w, 3 d)
Looks sensible to me, modulo the option description.
This commit also broke compilation of some files for me, for ARM, where compilation now doesn't finish (files that normally compile within a second now doesn't finish after half an hour. See https://bugs.llvm.org/show_bug.cgi?id=41160 for details and a reproduction sample.
Tue, Mar 19
Aren't all of /implib, /pdband /out output files? In that sense it doesn't matter where they are written in the repro case (and writing them locally instead of somewhere else with an absolute path probably is more convenient?).
Fri, Mar 15
Sounds ok to me
This broke compilation of libcxx for armv7 mingw for me, see https://bugs.llvm.org/show_bug.cgi?id=41081 for details.
Tue, Mar 12
No objection from the mingw perspective. Sanitizers on mingw are only supported by clang+lld, not by gcc/ld.bfd, and then it's built by clang in mingw mode with -fms-extensions, so most msvc specific extensions are available. Additionally, I haven't even yet a full setup for running compiler-rt/libcxx runtime tests, so I'm not sure if there are other things that need to be fixed wrt mingw in the tests.
Wed, Mar 6
Tue, Mar 5
Fri, Mar 1
Changed to do the same thing with a regex.
Factorized the condition to a macro. As sanitizer_common.h is inclued only later, I had to move the include of traceloggingprovider.h out from the standard include block into a later conditional.
Thu, Feb 28
It turns out that the fix for Windows in rL355052 didn't turn out to help either: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/42624/steps/stage%201%20build/logs/stdio
Feb 19 2019
LGTM when rebased on top of D58380.
Changed the condition as requested.
Feb 15 2019
This broke compilation with GCC 5.4 on Ubuntu 16.04:
I tested and it seems good, I can build the whole mingw-w64 runtime again with this applied.
This change broke compiling the mingw-w64 runtime, which uses GCC_ASM_FLAG_OUTPUTS to enable newer forms of inline assembly. See PR40737 for details.
Feb 13 2019
Please add a check for this new option in COFF/COFFObjCopy.cpp for the "Option not supported by llvm-objcopy for COFF" error, to avoid giving the illusion that the option is handled with that backend.
Feb 12 2019
Feb 11 2019
Thanks, looks good to me now. I'll leave someone else to do the overall approval though.
Feb 8 2019
Feb 7 2019
Feb 6 2019
Feb 5 2019
Thanks, this looks much more readable!