- User Since
- Jul 25 2016, 12:54 PM (129 w, 6 d)
Sat, Jan 19
Fri, Jan 18
Updated to test how --only-section combined with --strip-debug behaves - matching GNU objcopy's behaviour.
Applied @jhenderson's suggestions.
Thu, Jan 17
Adding another COFF-knowledgeable reviewer
Applied @jhenderson's suggestions. But I also split the input data into a separate yaml file in Inputs, as I'm going to use the same input for another test.
Fixed @jhenderson's suggestions.
Wed, Jan 16
Tweaked the scope of lambdas in removeSections to avoid use-after-free of stack variables in the implementation of the lambda captures, as pointed out by asan.
Applied @rupprecht's suggestions.
Tue, Jan 15
Using a lambda that takes StringRef, renamed the lambda parameter to match coding conventions. Will commit tomorrow.
Mon, Jan 14
Sat, Jan 12
I came to the conclusion that setting the Characteristics flags is mostly orthogonal to the stripping of the symbols/relocs (the flag discussed before is actually only relevant for whether executables/DLLs are loadable at a different address than the default), so I split out that part of the patch and I might revisit it later, but it's not essential for the functionality of this patch.
Fri, Jan 11
Alternatively, I could just skip setting the characteristics flags altogether in this patch, as I don't think anything actually reads them on object files, and the context here (removing relocations) only is relevant for object files - base relocs on executables/DLLs are untouched. We can always add them later if deemed necessary. WDYT?
Using a ternary operator as suggested.
Added an undefined external to the tests, changed the code comment to use CLI parameter names.
Split testes into two separate files, with one shared yaml source in the Inputs directory.
Did the suggested changes to the test, added the distinction that --discard-all keeps undefined local symbols.
Fixed the --strip-all-gnu typo in the test comment.
Split out the general bugfix, did the suggested changes to the test.