Page MenuHomePhabricator
People mstorsjo

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (147 w, 19 h)

Recent Activity
View All

Today

mstorsjo added inline comments to D62018: [AArch64] Handle ISD::LRINT and ISD::LLRINT.
Tue, May 21, 5:28 AM · Restricted Project
mstorsjo accepted D62175: [llvm-dlltool] Respect NONAME keyword.
Tue, May 21, 2:56 AM · Restricted Project

Yesterday

mstorsjo committed rG4ed18e5ef521: [AArch64] Handle lowering lround on windows, where long is 32 bit (authored by mstorsjo).
[AArch64] Handle lowering lround on windows, where long is 32 bit
Mon, May 20, 12:54 PM
mstorsjo committed rL361192: [AArch64] Handle lowering lround on windows, where long is 32 bit.
[AArch64] Handle lowering lround on windows, where long is 32 bit
Mon, May 20, 12:53 PM
mstorsjo closed D62108: [AArch64] Handle lowering lround on windows, where long is 32 bit.
Mon, May 20, 12:53 PM · Restricted Project

Sun, May 19

mstorsjo created D62108: [AArch64] Handle lowering lround on windows, where long is 32 bit.
Sun, May 19, 12:22 PM · Restricted Project

Sat, May 18

mstorsjo added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

This broke compilation of libtiff for arm, see https://bugs.llvm.org/show_bug.cgi?id=41931 for details.

Sat, May 18, 12:32 PM · Restricted Project

Fri, May 17

mstorsjo committed rG5fab538e2a97: [MinGW] Set the right updated option help for the updated pdb option. NFC (authored by mstorsjo).
[MinGW] Set the right updated option help for the updated pdb option. NFC
Fri, May 17, 9:19 PM
mstorsjo committed rL361093: [MinGW] Set the right updated option help for the updated pdb option. NFC.
[MinGW] Set the right updated option help for the updated pdb option. NFC
Fri, May 17, 9:18 PM
mstorsjo committed rLLD361093: [MinGW] Set the right updated option help for the updated pdb option. NFC.
[MinGW] Set the right updated option help for the updated pdb option. NFC
Fri, May 17, 9:18 PM
mstorsjo requested changes to D62034: compiler-rt/lib/builtins: s/#include <windows.h>/#include <Windows.h>/g to match proper case..

No, I don't think this is a good idea.

Fri, May 17, 11:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo committed rG6ff6a8f656ee: [MinGW] Include --enable-auto-import in the help listing (authored by mstorsjo).
[MinGW] Include --enable-auto-import in the help listing
Fri, May 17, 4:08 AM
mstorsjo committed rG6863dfaa21db: [MinGW] Implement the -v and --version flags for the MinGW driver (authored by mstorsjo).
[MinGW] Implement the -v and --version flags for the MinGW driver
Fri, May 17, 4:07 AM
mstorsjo committed rG9ae0d222dc8f: [MinGW] Implement --help for the MinGW driver (authored by mstorsjo).
[MinGW] Implement --help for the MinGW driver
Fri, May 17, 4:07 AM
mstorsjo committed rG2c52ddf31f54: [MinGW] Allow requesting PDB output without giving a file name (authored by mstorsjo).
[MinGW] Allow requesting PDB output without giving a file name
Fri, May 17, 4:07 AM
mstorsjo committed rLLD361017: [MinGW] Include --enable-auto-import in the help listing.
[MinGW] Include --enable-auto-import in the help listing
Fri, May 17, 4:07 AM
mstorsjo committed rLLD361016: [MinGW] Implement the -v and --version flags for the MinGW driver.
[MinGW] Implement the -v and --version flags for the MinGW driver
Fri, May 17, 4:07 AM
mstorsjo committed rL361017: [MinGW] Include --enable-auto-import in the help listing.
[MinGW] Include --enable-auto-import in the help listing
Fri, May 17, 4:07 AM
mstorsjo closed D62053: [MinGW] Include --enable-auto-import in the help listing.
Fri, May 17, 4:06 AM · Restricted Project
mstorsjo committed rL361016: [MinGW] Implement the -v and --version flags for the MinGW driver.
[MinGW] Implement the -v and --version flags for the MinGW driver
Fri, May 17, 4:06 AM
mstorsjo closed D62030: [LLD] [MinGW] Implement the -v and --version flags for the MinGW driver.
Fri, May 17, 4:06 AM · Restricted Project
mstorsjo committed rL361015: [MinGW] Implement --help for the MinGW driver.
[MinGW] Implement --help for the MinGW driver
Fri, May 17, 4:06 AM
mstorsjo committed rL361014: [MinGW] Allow requesting PDB output without giving a file name.
[MinGW] Allow requesting PDB output without giving a file name
Fri, May 17, 4:06 AM
mstorsjo committed rLLD361015: [MinGW] Implement --help for the MinGW driver.
[MinGW] Implement --help for the MinGW driver
Fri, May 17, 4:06 AM
mstorsjo closed D62029: [LLD] [MinGW] Implement --help for the MinGW driver.
Fri, May 17, 4:06 AM · Restricted Project
mstorsjo committed rLLD361014: [MinGW] Allow requesting PDB output without giving a file name.
[MinGW] Allow requesting PDB output without giving a file name
Fri, May 17, 4:06 AM
mstorsjo closed D62004: [LLD] [MinGW] Allow requesting PDB output without giving a file name.
Fri, May 17, 4:06 AM · Restricted Project

Thu, May 16

mstorsjo added inline comments to D62004: [LLD] [MinGW] Allow requesting PDB output without giving a file name.
Thu, May 16, 11:33 PM · Restricted Project
mstorsjo updated the diff for D62030: [LLD] [MinGW] Implement the -v and --version flags for the MinGW driver.

Added more of the original comment about "compatible with GNU linkers" which also applies for MinGW.

Thu, May 16, 11:30 PM · Restricted Project
mstorsjo created D62053: [MinGW] Include --enable-auto-import in the help listing.
Thu, May 16, 11:30 PM · Restricted Project
mstorsjo added inline comments to D62030: [LLD] [MinGW] Implement the -v and --version flags for the MinGW driver.
Thu, May 16, 11:14 PM · Restricted Project
mstorsjo added a comment to D62034: compiler-rt/lib/builtins: s/#include <windows.h>/#include <Windows.h>/g to match proper case..

Yes, MinGW headers are all lowercase.

Thu, May 16, 11:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo created D62030: [LLD] [MinGW] Implement the -v and --version flags for the MinGW driver.
Thu, May 16, 1:32 PM · Restricted Project
mstorsjo created D62029: [LLD] [MinGW] Implement --help for the MinGW driver.
Thu, May 16, 1:31 PM · Restricted Project
mstorsjo added inline comments to D62004: [LLD] [MinGW] Allow requesting PDB output without giving a file name.
Thu, May 16, 12:25 PM · Restricted Project
mstorsjo added a comment to D62004: [LLD] [MinGW] Allow requesting PDB output without giving a file name.
In D62004#1504666, @ruiu wrote:

I think I'm fine with the --pdb= option, although it looks a bit odd. Does this work both for --pdb= and --pdb ''? I think logically they should be identical.

Thu, May 16, 6:04 AM · Restricted Project
mstorsjo created D62004: [LLD] [MinGW] Allow requesting PDB output without giving a file name.
Thu, May 16, 5:31 AM · Restricted Project

Wed, May 15

mstorsjo committed rUNW360862: [PPC] Fix 32-bit build of libunwind.
[PPC] Fix 32-bit build of libunwind
Wed, May 15, 11:49 PM
mstorsjo committed rUNW360861: [PPC64][libunwind] Fix r2 not properly restored.
[PPC64][libunwind] Fix r2 not properly restored
Wed, May 15, 11:49 PM
mstorsjo committed rG905af40cc6ce: [PPC] Fix 32-bit build of libunwind (authored by mstorsjo).
[PPC] Fix 32-bit build of libunwind
Wed, May 15, 11:49 PM
mstorsjo committed rG44266b9e115a: [PPC64][libunwind] Fix r2 not properly restored (authored by mstorsjo).
[PPC64][libunwind] Fix r2 not properly restored
Wed, May 15, 11:48 PM
mstorsjo committed rL360862: [PPC] Fix 32-bit build of libunwind.
[PPC] Fix 32-bit build of libunwind
Wed, May 15, 11:48 PM
mstorsjo closed D61792: [PPC] Fix 32-bit build of libunwind.
Wed, May 15, 11:48 PM · Restricted Project, Restricted Project
mstorsjo committed rL360861: [PPC64][libunwind] Fix r2 not properly restored.
[PPC64][libunwind] Fix r2 not properly restored
Wed, May 15, 11:48 PM
mstorsjo closed D59694: [PPC64][libunwind] Fix r2 not properly restored.
Wed, May 15, 11:48 PM · Restricted Project, Restricted Project
mstorsjo added reviewers for D61960: [AArch64] only indicate CFI on Windows if we emitted CFI: rnk, mgrang, ssijaric.
Wed, May 15, 1:32 PM · Restricted Project

Tue, May 14

mstorsjo created D61894: [RFC] [AArch64] Add a target feature flag for restoring X18 after foreign function calls.
Tue, May 14, 6:10 AM · Restricted Project
mstorsjo created D61892: [RFC] [AArch64] Back up and restore X18 in the prologue/epilogue for Windows calling convention on non-Windows OSes.
Tue, May 14, 6:04 AM · Restricted Project

Sun, May 12

mstorsjo added a comment to D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration.

This caused a regression when including mingw-w64 headers (in a case where they happen to include redundant/duplicate attribute specifications), triggering asserts. See https://bugs.llvm.org/show_bug.cgi?id=41852 for details.

Sun, May 12, 1:12 PM · Restricted Project

Fri, May 10

mstorsjo added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.
In D59694#1498186, @luporl wrote:

Any update on this?

Fri, May 10, 10:35 AM · Restricted Project, Restricted Project

Wed, May 8

mstorsjo added a comment to D61670: [RFC] [MinGW] Allow opting out from .refptr stubs.
In D61670#1495535, @rnk wrote:

Well, I'm curious what meaning GCC ascribes to a medium code model for COFF. Do they generate code to allow PE images larger than 2GB, or is it more like the ELF small code model, where they assume everything can be reached with RIP relative addressing?

Wed, May 8, 12:14 PM · Restricted Project
mstorsjo added a comment to D61670: [RFC] [MinGW] Allow opting out from .refptr stubs.

Fair enough.

Wed, May 8, 11:45 AM · Restricted Project
mstorsjo updated subscribers of D59742: [llvm-dlltool] Set a proper machine type for weak symbol object files.

(Sorry for the double post due to a typo) @tstellar - This would be nice to have in 8.0.1 as well.

Wed, May 8, 10:52 AM · Restricted Project
mstorsjo added a comment to D59742: [llvm-dlltool] Set a proper machine type for weak symbol object files.

@tstellard - This would be nice to have in 8.0.1 as well.

Wed, May 8, 10:51 AM · Restricted Project
mstorsjo created D61670: [RFC] [MinGW] Allow opting out from .refptr stubs.
Wed, May 8, 2:54 AM · Restricted Project
mstorsjo committed rGe96c98f37d3d: [CMake] Install import libraries (authored by mstorsjo).
[CMake] Install import libraries
Wed, May 8, 1:38 AM
mstorsjo committed rL360230: [CMake] Install import libraries.
[CMake] Install import libraries
Wed, May 8, 1:38 AM
mstorsjo closed D61425: Install import libraries.
Wed, May 8, 1:38 AM · Restricted Project

Tue, May 7

mstorsjo added a comment to D61615: [COFF] Use COFF stubs for extern_weak functions.

Ideally it'd be nice to have this consistent on arm and aarch64 as well, but it's not a blocker (it's not something I'm running into so far).

Tue, May 7, 11:06 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D61425: Install import libraries.
In D61425#1493179, @jschueller wrote:

@mstorsjo Yes, if someone could commit this it would be great

Tue, May 7, 4:03 AM · Restricted Project
mstorsjo added a reviewer for D61425: Install import libraries: rnk.

For reference, this fixes PR41704.

Tue, May 7, 3:33 AM · Restricted Project

Mon, May 6

mstorsjo accepted D61615: [COFF] Use COFF stubs for extern_weak functions.

LGTM, it's nice if this mechanism comes in handy in other cases than the one it was originally made for.

Mon, May 6, 10:57 PM · Restricted Project, Restricted Project
mstorsjo committed rG7037a13679bf: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW (authored by mstorsjo).
[AArch64] Add __builtin_sponentry, for calling setjmp in MinGW
Mon, May 6, 2:17 PM
mstorsjo committed rG5e100de2c7d3: [MinGW] Use SEH by default on AArch64 (authored by mstorsjo).
[MinGW] Use SEH by default on AArch64
Mon, May 6, 2:17 PM
mstorsjo committed rL360082: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW.
[AArch64] Add __builtin_sponentry, for calling setjmp in MinGW
Mon, May 6, 2:17 PM
mstorsjo committed rC360082: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW.
[AArch64] Add __builtin_sponentry, for calling setjmp in MinGW
Mon, May 6, 2:17 PM
mstorsjo committed rG899f3cd5817e: [AArch64] Default to SEH exception handling on MinGW (authored by mstorsjo).
[AArch64] Default to SEH exception handling on MinGW
Mon, May 6, 2:17 PM
mstorsjo closed D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW.
Mon, May 6, 2:17 PM · Restricted Project
mstorsjo committed rC360081: [MinGW] Use SEH by default on AArch64.
[MinGW] Use SEH by default on AArch64
Mon, May 6, 2:17 PM
mstorsjo committed rL360081: [MinGW] Use SEH by default on AArch64.
[MinGW] Use SEH by default on AArch64
Mon, May 6, 2:17 PM
mstorsjo closed D61591: [MinGW] Use SEH by default on AArch64.
Mon, May 6, 2:16 PM · Restricted Project, Restricted Project
mstorsjo committed rL360080: [AArch64] Default to SEH exception handling on MinGW.
[AArch64] Default to SEH exception handling on MinGW
Mon, May 6, 2:16 PM
mstorsjo closed D61590: [AArch64] Default to SEH exception handling on MinGW.
Mon, May 6, 2:16 PM · Restricted Project
mstorsjo created D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW.
Mon, May 6, 6:17 AM · Restricted Project
mstorsjo created D61591: [MinGW] Use SEH by default on AArch64.
Mon, May 6, 6:11 AM · Restricted Project, Restricted Project
mstorsjo created D61590: [AArch64] Default to SEH exception handling on MinGW.
Mon, May 6, 6:09 AM · Restricted Project

Fri, May 3

mstorsjo updated subscribers of D61252: [X86] Run CFIInstrInserter on Windows if Dwarf is used.

@tstellar Can we have this merged into 8.0.1?

Fri, May 3, 3:22 AM · Restricted Project
mstorsjo committed rGb1f391028383: Avoid duplicate function aliases on MinGW after SVN r359835 (authored by mstorsjo).
Avoid duplicate function aliases on MinGW after SVN r359835
Fri, May 3, 12:42 AM
mstorsjo committed rL359865: Avoid duplicate function aliases on MinGW after SVN r359835.
Avoid duplicate function aliases on MinGW after SVN r359835
Fri, May 3, 12:42 AM
mstorsjo committed rCRT359865: Avoid duplicate function aliases on MinGW after SVN r359835.
Avoid duplicate function aliases on MinGW after SVN r359835
Fri, May 3, 12:42 AM

Wed, May 1

mstorsjo accepted D61388: lld-link: Make "duplicate resource" error message a bit more concise.

LGTM

Wed, May 1, 12:47 PM · Restricted Project

Tue, Apr 30

mstorsjo added a comment to D61095: [AArch64][Windows] Compute function length correctly in unwind tables..

@efriedma - what's the status on this one?

Tue, Apr 30, 2:45 PM · Restricted Project

Mon, Apr 29

mstorsjo accepted D61278: Simplify exclusion of nested classes from extern template instantiation, NFC.

LGTM

Mon, Apr 29, 2:13 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D61175: [MinGW] Don't let template instantiation declarations cover nested classes.
Mon, Apr 29, 2:11 PM · Restricted Project
mstorsjo committed rG6da0989cc4c1: [UpdateTestChecks] Allow Lbegin_func without a leading period (authored by mstorsjo).
[UpdateTestChecks] Allow Lbegin_func without a leading period
Mon, Apr 29, 1:29 PM
mstorsjo committed rGc0d138d14788: [X86] Run CFIInstrInserter on Windows if Dwarf is used (authored by mstorsjo).
[X86] Run CFIInstrInserter on Windows if Dwarf is used
Mon, Apr 29, 1:29 PM
mstorsjo committed rL359497: [UpdateTestChecks] Allow Lbegin_func without a leading period.
[UpdateTestChecks] Allow Lbegin_func without a leading period
Mon, Apr 29, 1:29 PM
mstorsjo closed D61254: [UpdateTestChecks] Allow Lbegin_func without a leading period.
Mon, Apr 29, 1:28 PM · Restricted Project
mstorsjo committed rL359496: [X86] Run CFIInstrInserter on Windows if Dwarf is used.
[X86] Run CFIInstrInserter on Windows if Dwarf is used
Mon, Apr 29, 1:28 PM
mstorsjo closed D61252: [X86] Run CFIInstrInserter on Windows if Dwarf is used.
Mon, Apr 29, 1:28 PM · Restricted Project
mstorsjo added inline comments to D61254: [UpdateTestChecks] Allow Lbegin_func without a leading period.
Mon, Apr 29, 12:18 PM · Restricted Project
mstorsjo created D61254: [UpdateTestChecks] Allow Lbegin_func without a leading period.
Mon, Apr 29, 1:33 AM · Restricted Project
mstorsjo created D61252: [X86] Run CFIInstrInserter on Windows if Dwarf is used.
Mon, Apr 29, 1:26 AM · Restricted Project

Fri, Apr 26

mstorsjo committed rG228ccd675484: [MinGW] Always emit local typeinfo (authored by mstorsjo).
[MinGW] Always emit local typeinfo
Fri, Apr 26, 12:31 PM
mstorsjo committed rG9534e9dbe44c: [MinGW] Do dllexport inline methods in template instantiation (authored by mstorsjo).
[MinGW] Do dllexport inline methods in template instantiation
Fri, Apr 26, 12:31 PM
mstorsjo committed rGda93dec33050: [MinGW] Don't let template instantiation declarations cover nested classes (authored by mstorsjo).
[MinGW] Don't let template instantiation declarations cover nested classes
Fri, Apr 26, 12:31 PM
mstorsjo committed rL359345: [MinGW] Always emit local typeinfo.
[MinGW] Always emit local typeinfo
Fri, Apr 26, 12:31 PM
mstorsjo committed rC359345: [MinGW] Always emit local typeinfo.
[MinGW] Always emit local typeinfo
Fri, Apr 26, 12:30 PM
mstorsjo closed D61177: [MinGW] Always emit local typeinfo.
Fri, Apr 26, 12:30 PM · Restricted Project
mstorsjo committed rL359343: [MinGW] Do dllexport inline methods in template instantiation.
[MinGW] Do dllexport inline methods in template instantiation
Fri, Apr 26, 12:30 PM