- User Since
- Jul 25 2016, 12:54 PM (81 w, 6 d)
Sat, Feb 17
Fri, Feb 16
Thu, Feb 15
Factorized the initial part of calculating the section relative offset.
Wed, Feb 14
Mon, Feb 12
Structured the code to easier allow adding a darwin specific version of stack probing without conflicting with the windows specific parts here. Added a "return false" in GlobalISel for windows for alloca, to make sure we invoke the proper codegen for this.
Fri, Feb 9
So with the absolutely minimal performance regression in swifterror.ll and lack of response otherwise, I think I'm ok with giving it the LGTM for aarch64.
Wed, Feb 7
Mon, Feb 5
Yes, this looks like mostly no-op reorderings. I don't remember exactly what part I thought was a potential performance regression in swifterror.ll before - it moves one "mov" instruction (in two places) to before a branch, so potentially executing one instruction more than before. I would say it's most probably ok (and the gains in some of the other register shuffling tests would make it sound like a net gain in any case).
Thu, Feb 1
@hans I'd like to have this in 6.0 as well, to allow building Qt for windows as DLLs.
Wed, Jan 31
Tue, Jan 30
Adjusted the fix by moving the change into ShouldUseExternalRTTIDescriptor - this causes less changes to other tests. @majnemer - do you think this is better or worse than having the fix in isVTableExternal?
@hans And this one also would be good to backport.
@hans This would be good to have backported.
Ping @aemerson - can you give this an ack from a generic aarch64 target perspective - the windows side of it was already ok'd.
Mon, Jan 29
Remove a few accidentally leftover parts of the new testcase.
Sun, Jan 28
Sat, Jan 27
LGTM. I confirmed this with link.exe with the test case from long-section-names.test. I don't remember what I originally tested, that the previous comment was based on - maybe it was just a mixup.
Fri, Jan 26
Don't skip GlobalISel altogether, but just bail out on dllimport function calls.
Thu, Jan 25
Wed, Jan 24
@hans - I think this is a pretty simple/straightforward bugfix that might be worthy of backporting to 6.0.
@peter.smith Would you care to approve this one, when there don't seem to be anybody else interested in it?
Tue, Jan 23
@hans - can we backport this to the 6.0 branch? The usecase it fixes is "compiling Qt for Windows on ARM" (which previously fails when building with -O3). The fix in SVN r323307 probably requires merging SVN r322900 as well, to go without conflicts - it's a trivial testcase touch-up.
Updated the summary/commit message as requested on irc.
Mon, Jan 22
LGTM now, but I'll let @smeenai give it the proper approval.
Sun, Jan 21
Sat, Jan 20
Jan 19 2018
Simplified by using Subtarget->isTargetWindows() instead of Subtaget->getTargetTriple().isOSWindows().
Jan 18 2018
Added a testcase to show that normal globals still are merged.
Changed to explicitly check for the dllexport attribute.