Page MenuHomePhabricator

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (216 w, 3 d)

Recent Activity

Yesterday

mstorsjo added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

This broke a few tests for me (generating code that now gives the fail result at runtime).

Thu, Sep 17, 11:51 PM · Restricted Project, Restricted Project

Wed, Sep 16

mstorsjo added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

@rnk - Can you follow up on the discussion above?

Wed, Sep 16, 10:27 AM · Restricted Project

Tue, Sep 15

mstorsjo committed rGc913f6dce695: [llvm-rc] Lowercase the option definitions. NFC. (authored by mstorsjo).
[llvm-rc] Lowercase the option definitions. NFC.
Tue, Sep 15, 11:35 PM
mstorsjo committed rG74d7356fc63b: [llvm-rc] Update a comment. NFC. (authored by mstorsjo).
[llvm-rc] Update a comment. NFC.
Tue, Sep 15, 11:35 PM
mstorsjo committed rG794467b916e8: [llvm-rc] Allow omitting components from VERSIONINFO versions (authored by mstorsjo).
[llvm-rc] Allow omitting components from VERSIONINFO versions
Tue, Sep 15, 11:35 PM
mstorsjo closed D87570: [llvm-rc] Allow omitting components from VERSIONINFO version numbers.
Tue, Sep 15, 11:34 PM · Restricted Project
mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.
In D87379#2274531, @srj wrote:

It seems we made a small mistake in one of the if conditions, will fix it now. Thanks for letting us know

What commit/review has the fixes? This is affecting Halide as well and we'd like to test the fix.

Tue, Sep 15, 9:16 AM · Restricted Project
mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

Headsup: This broke a number of tests for me. Looking closer into where it changed things erroneously...

It seems we made a small mistake in one of the if conditions, will fix it now. Thanks for letting us know

Tue, Sep 15, 6:24 AM · Restricted Project
mstorsjo accepted D83573: [libunwind] Support for leaf function unwinding..

LGTM

Tue, Sep 15, 3:49 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

The file that shows the error can be built from https://martin.st/temp/eval.c, built as clang -target armv7-w64-mingw32 -c -O2 eval.c.

Tue, Sep 15, 12:56 AM · Restricted Project
mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

The main difference in code, in the function that show the error in one of the testcases that broke, looks like this:

-       movs    r1, #9
-       cmp     r0, #9
-       it      lt
-       movlt   r1, r0
-       bic.w   r0, r1, r1, asr #31
+       usat    r0, #1, r0
Tue, Sep 15, 12:18 AM · Restricted Project

Mon, Sep 14

mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

Headsup: This broke a number of tests for me. Looking closer into where it changed things erroneously...

Mon, Sep 14, 11:50 PM · Restricted Project
mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Pushed this one now.

Mon, Sep 14, 11:32 PM · Restricted Project, lld
mstorsjo committed rGe71cda21d71c: [Windows][Polly] Disable LLVMPolly module for all compilers on Windows (authored by mati865).
[Windows][Polly] Disable LLVMPolly module for all compilers on Windows
Mon, Sep 14, 11:13 PM
mstorsjo committed rG61e0b2b4c5fb: [LLD] Allow configuring default ld.lld backend (authored by mati865).
[LLD] Allow configuring default ld.lld backend
Mon, Sep 14, 11:13 PM
mstorsjo committed rG7b416c5e3683: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info (authored by mstorsjo).
[llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info
Mon, Sep 14, 11:13 PM
mstorsjo closed D87524: [Windows][Polly] Disable LLVMPolly module for all compilers on Windows.
Mon, Sep 14, 11:13 PM · Restricted Project, Restricted Project
mstorsjo closed D87418: [LLD] Allow configuring default ld.lld backend.
Mon, Sep 14, 11:13 PM · Restricted Project, lld
mstorsjo closed D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.
Mon, Sep 14, 11:13 PM · Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

@hans - Does that sound right to you?

Yes, that matches my experience. But I don't know the backstory here. Maybe it would make sense to have version suffixes also on Windows?

Mon, Sep 14, 12:16 PM · Restricted Project
mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Ping @MaskRay

Mon, Sep 14, 12:13 PM · Restricted Project, lld

Sun, Sep 13

mstorsjo added a comment to D86256: [libunwind] Make .eh_frame scanning/caching optional.

The commit description talks about making the caching optional, but I don't really see that aspect in the patch - or maybe I'm just not studying it closely enough?

Sun, Sep 13, 1:41 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D86256: [libunwind] Make .eh_frame scanning/caching optional.

If the unwinder uses dl_iterate_phdr, then entries that are automatically added to DwarfFDECache would become invalid if the module containing the entry were unloaded. (On Apple systems, DwarfFDECache registers dyldUnloadHook to remove unloaded entries.)

AFAICT, this is also a problem for Windows DWARF EH, which relies on scanning an .eh_frame section. e.g. A stale cachedFDE could point into the middle of an FDE/CIE with an arbitrary outcome. Maybe decodeFDE crashes, or maybe it decodes something that looks like a match. I'm not sure if it can be fixed without disabling the caching. If so, then I'd wonder if the caching is worth keeping. (Bare-metal could use .eh_frame_hdr, and I'm not sure whether Apple systems actually need the full __eh_frame scan.)

Sun, Sep 13, 1:36 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D83573: [libunwind] Support for leaf function unwinding..

The change itself looks good to me, but the comment in lit.site.cfg.in does look confusing to me as well, so it'd be great to have it reworded.

Sun, Sep 13, 12:56 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

Cygwin seems to be the only Windows target that adds version to the library names.

Sun, Sep 13, 4:39 AM · Restricted Project

Sat, Sep 12

mstorsjo added a reviewer for D87521: [MinGW][llvm-config] Use unversioned library name: hans.

Ok, so if I read code correctly, the suffix gets added here: https://github.com/llvm/llvm-project/blob/9c651c231f3144f53e13cd0a1747589e1b2edccd/llvm/cmake/modules/AddLLVM.cmake#L599-L606

Sat, Sep 12, 2:47 PM · Restricted Project
mstorsjo requested review of D87570: [llvm-rc] Allow omitting components from VERSIONINFO version numbers.
Sat, Sep 12, 2:27 PM · Restricted Project
mstorsjo committed rG7da941939902: [MinGW][libclang] Allow simultaneous shared and static lib (authored by mati865).
[MinGW][libclang] Allow simultaneous shared and static lib
Sat, Sep 12, 12:06 PM
mstorsjo committed rGbb613044b680: [MinGW][clang-shlib] Build by default on MinGW (authored by mati865).
[MinGW][clang-shlib] Build by default on MinGW
Sat, Sep 12, 12:05 PM
mstorsjo committed rGcc76965b1908: [MinGW] Use lib prefix for libraries (authored by mati865).
[MinGW] Use lib prefix for libraries
Sat, Sep 12, 12:05 PM
mstorsjo closed D87539: [MinGW][libclang] Allow simultaneous shared and static lib.
Sat, Sep 12, 12:05 PM · Restricted Project
mstorsjo closed D87547: [MinGW][clang-shlib] Build by default on MinGW.
Sat, Sep 12, 12:05 PM · Restricted Project
mstorsjo closed D87517: [MinGW] Use lib prefix for libraries.
Sat, Sep 12, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
mstorsjo accepted D87539: [MinGW][libclang] Allow simultaneous shared and static lib.

LGTM then! Can apply it a bit later.

Sat, Sep 12, 7:00 AM · Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

what code appends a version number in dynamic libs when built for other platforms, but decides not to, when targeting windows in general, or mingw specifically?

I have very limited knowledge about what is going on but I think this version script controls it: https://github.com/llvm/llvm-project/blob/9c651c231f3144f53e13cd0a1747589e1b2edccd/llvm/tools/llvm-shlib/CMakeLists.txt#L51

Sat, Sep 12, 6:32 AM · Restricted Project
mstorsjo added a comment to D87539: [MinGW][libclang] Allow simultaneous shared and static lib.

bin/llvm-readobj --coff-directives lib/liblibclang.dll.a | grep -i export shows nothing.

Sat, Sep 12, 6:28 AM · Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.
Sat, Sep 12, 4:31 AM · Restricted Project
mstorsjo added a comment to D87539: [MinGW][libclang] Allow simultaneous shared and static lib.

We had this patch at MSYS2 for years and I'm not aware of any issues with the static library.
I think the library looks fine:

$ nm lib/liblibclang.a | grep __imp_
                 U __imp___acrt_iob_func
                 U __imp___acrt_iob_func
                 U __imp_GetModuleFileNameA
                 U __imp_VirtualQuery
                 U __imp___acrt_iob_func
                 U __imp___acrt_iob_func
                 U __imp___acrt_iob_func
Sat, Sep 12, 3:57 AM · Restricted Project

Fri, Sep 11

mstorsjo accepted D87547: [MinGW][clang-shlib] Build by default on MinGW.

This should be ok, I think.

Fri, Sep 11, 10:54 PM · Restricted Project
mstorsjo added a comment to D87539: [MinGW][libclang] Allow simultaneous shared and static lib.

Does the static lib built in this case include any dllexport attributes (that can cause issues if linking it statically into another DLL)?

Fri, Sep 11, 10:53 PM · Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

If the corresponding DLLs built in MSVC mode actually have a version number suffix, should we change the build for MinGW mode to include a number as well? Or is any of the relevant DLLs ever built in MSVC mode at all?

Fri, Sep 11, 10:50 PM · Restricted Project
mstorsjo updated the diff for D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.

Removed superfluous "sub sp, sp, #0".

Fri, Sep 11, 10:39 PM · Restricted Project
mstorsjo accepted D87517: [MinGW] Use lib prefix for libraries.

This looks good to me! I can push it later.

Fri, Sep 11, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
mstorsjo added inline comments to D87521: [MinGW][llvm-config] Use unversioned library name.
Fri, Sep 11, 12:09 PM · Restricted Project
Herald added a reviewer for D87517: [MinGW] Use lib prefix for libraries: JDevlieghere.

What's the practical effect of this? I see that a number of libraries already have a lib prefix prepended, like libclang/liblldb - I presume this changes the name of the individual libs (for BUILD_SHARED_LIBS=TRUE configurations)?

Fri, Sep 11, 12:06 PM · Restricted Project, Restricted Project, Restricted Project
mstorsjo added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.
In D87448#2266746, @rnk wrote:

Makes sense.

Unwind info for all remaining functions that hasn't gotten it emitted directly is emitted at the end.

Can we make .seh_endproc responsible for emitting the unwind info into .xdata if necessary?

Fri, Sep 11, 2:22 AM · Restricted Project
mstorsjo added a comment to D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.

the length of the synthesized canonical prologue might differ a little from the actual one maybe

Getting the length wrong has caused miscompiles in the past.

Fri, Sep 11, 1:51 AM · Restricted Project
mstorsjo committed rGe6419d320d50: [MC] [Win64EH] Fix builds with expensive checks enabled (authored by mstorsjo).
[MC] [Win64EH] Fix builds with expensive checks enabled
Fri, Sep 11, 1:17 AM
mstorsjo committed rG700fbe591ac0: [MC] [Win64EH] Canonicalize ARM64 unwind opcodes (authored by mstorsjo).
[MC] [Win64EH] Canonicalize ARM64 unwind opcodes
Fri, Sep 11, 12:32 AM
mstorsjo committed rG1308bb99e067: [MC] [Win64EH] Write packed ARM64 epilogues if possible (authored by mstorsjo).
[MC] [Win64EH] Write packed ARM64 epilogues if possible
Fri, Sep 11, 12:32 AM
mstorsjo committed rG46416f08031f: [CodeGen] [WinException] Remove a redundant explicit section switch for aarch64 (authored by mstorsjo).
[CodeGen] [WinException] Remove a redundant explicit section switch for aarch64
Fri, Sep 11, 12:31 AM
mstorsjo closed D87369: [MC] [Win64EH] Write packed ARM64 epilogs if possible.
Fri, Sep 11, 12:31 AM · Restricted Project
mstorsjo closed D87367: [MC] [Win64EH] Canonicalize ARM64 unwind opcodes.
Fri, Sep 11, 12:31 AM · Restricted Project
mstorsjo closed D87447: [CodeGen] [WinException] Remove a redundant explicit section switch for aarch64.
Fri, Sep 11, 12:31 AM · Restricted Project
mstorsjo added inline comments to D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.
Fri, Sep 11, 12:24 AM · Restricted Project

Thu, Sep 10

mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.
In D87418#2266652, @pcc wrote:

How widespread are these build systems that parse help output? (Given that it took until now to discover them, I'd venture "not very".) Maybe it would be better to fix them to explicitly pass -m and/or do something that doesn't rely on parsing help output (e.g. just try the flag and see whether it fails).

Thu, Sep 10, 1:45 PM · Restricted Project, lld
mstorsjo added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 11:50 AM · Restricted Project, lld
mstorsjo added inline comments to D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.
Thu, Sep 10, 5:07 AM · Restricted Project
mstorsjo requested review of D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.
Thu, Sep 10, 5:03 AM · Restricted Project
mstorsjo requested review of D87447: [CodeGen] [WinException] Remove a redundant explicit section switch for aarch64.
Thu, Sep 10, 4:52 AM · Restricted Project
mstorsjo added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 3:38 AM · Restricted Project, lld
mstorsjo committed rG6313f5561945: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed… (authored by mstorsjo).
[llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed…
Thu, Sep 10, 1:42 AM
mstorsjo committed rG8060283ff8b7: [llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues (authored by mstorsjo).
[llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues
Thu, Sep 10, 1:42 AM
mstorsjo closed D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues.
Thu, Sep 10, 1:41 AM · Restricted Project
mstorsjo closed D87363: [llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues.
Thu, Sep 10, 1:41 AM · Restricted Project
mstorsjo added inline comments to D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues.
Thu, Sep 10, 1:13 AM · Restricted Project
mstorsjo added inline comments to D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.
Thu, Sep 10, 1:07 AM · Restricted Project
mstorsjo updated the diff for D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.

Updated to allow cases where the epilog is missing the SetFP opcode.

Thu, Sep 10, 1:04 AM · Restricted Project
mstorsjo added a comment to D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.

Unfortunately, in practice, this isn't ever matched by the code generated by LLVM

Are you planning this as a followup?

Thu, Sep 10, 12:33 AM · Restricted Project

Wed, Sep 9

mstorsjo updated the diff for D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.

Added a comment about the reference for synthesizing the prologue, fixed the homing area stack adjustment check for RegI=0, RegF=0, CR=1, added a testcase for that case and expanded on the comment for that bit in the code.

Wed, Sep 9, 11:53 PM · Restricted Project
mstorsjo added inline comments to D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.
Wed, Sep 9, 11:51 PM · Restricted Project
mstorsjo updated the diff for D87369: [MC] [Win64EH] Write packed ARM64 epilogs if possible.

Added a comment in the operator== about why the label isn't included in the comparison, changed the last condition into an early return like the other ones.

Wed, Sep 9, 11:23 PM · Restricted Project
mstorsjo added inline comments to D87369: [MC] [Win64EH] Write packed ARM64 epilogs if possible.
Wed, Sep 9, 11:05 PM · Restricted Project
mstorsjo updated the diff for D87367: [MC] [Win64EH] Canonicalize ARM64 unwind opcodes.

Conditionally producing the save_r19r20_x opcode depending on offset, added a testcase with a too large offset that isn't canonicalized.

Wed, Sep 9, 11:02 PM · Restricted Project
mstorsjo added inline comments to D87367: [MC] [Win64EH] Canonicalize ARM64 unwind opcodes.
Wed, Sep 9, 11:01 PM · Restricted Project
mstorsjo added a comment to D87363: [llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues.

Also add a missing --strict-whitespace in an existing test that was added explicitly for testing vertical alignment.

Without --match-full-lines, leading and trailing space changes cannot be detected. For // CHECK: a b, you can ensure the spaces between a and b are 2, but you cannot test the indentation.

Wed, Sep 9, 10:33 PM · Restricted Project
mstorsjo added reviewers for D87418: [LLD] Allow configuring default ld.lld backend: MaskRay, amccarth, rnk, mstorsjo.

As a concept, this looks sensible to me, similar to how llvm can be configured with a default triple or how clang can have cmake-configurable built-in defaults for linker/stdlib.

Wed, Sep 9, 9:01 PM · Restricted Project, lld
mstorsjo retitled D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues from [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epiloguus to [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues.
Wed, Sep 9, 5:21 AM · Restricted Project
mstorsjo requested review of D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.
Wed, Sep 9, 4:46 AM · Restricted Project
mstorsjo requested review of D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.
Wed, Sep 9, 4:45 AM · Restricted Project
mstorsjo requested review of D87369: [MC] [Win64EH] Write packed ARM64 epilogs if possible.
Wed, Sep 9, 4:43 AM · Restricted Project
mstorsjo requested review of D87367: [MC] [Win64EH] Canonicalize ARM64 unwind opcodes.
Wed, Sep 9, 4:42 AM · Restricted Project
mstorsjo requested review of D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues.
Wed, Sep 9, 4:39 AM · Restricted Project
mstorsjo requested review of D87363: [llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues.
Wed, Sep 9, 4:38 AM · Restricted Project

Tue, Sep 8

mstorsjo added a comment to D86612: [libunwind] Enable the SEH unwinding codepaths if building in MSVC mode.

It is definitely possible to disable SEH via /EHs- though

Tue, Sep 8, 11:01 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D86612: [libunwind] Enable the SEH unwinding codepaths if building in MSVC mode.

@compnerd - Any followup on this one?

Tue, Sep 8, 1:41 PM · Restricted Project, Restricted Project

Mon, Sep 7

mstorsjo committed rG28b9ace85f68: [clang] Remove a stray semicolon, fixing pedantic GCC warnings. NFC. (authored by mstorsjo).
[clang] Remove a stray semicolon, fixing pedantic GCC warnings. NFC.
Mon, Sep 7, 11:27 PM

Thu, Sep 3

mstorsjo added a comment to D86917: [Asan] Cleanup atomic usage in allocator.

Did you make ChunkHeader bigger on purpose? Can you at least change the
comments, as it’s no longer the same size?

Thu, Sep 3, 11:27 PM · Restricted Project
mstorsjo committed rG13cde6733b5f: [lldb] Remove a stray semicolon, fixing pedantic GCC warnings. NFC. (authored by mstorsjo).
[lldb] Remove a stray semicolon, fixing pedantic GCC warnings. NFC.
Thu, Sep 3, 1:20 AM
mstorsjo committed rGf5e2ea9a4322: [AArch64] Add asm directives for the remaining SEH unwind codes (authored by mstorsjo).
[AArch64] Add asm directives for the remaining SEH unwind codes
Thu, Sep 3, 1:12 AM
mstorsjo closed D86889: [AArch64] Add asm directives for the remaining SEH unwind codes.
Thu, Sep 3, 1:12 AM · Restricted Project

Wed, Sep 2

mstorsjo added a comment to D86889: [AArch64] Add asm directives for the remaining SEH unwind codes.

@efriedma Any followup to the discussion above?

Wed, Sep 2, 1:46 PM · Restricted Project
mstorsjo committed rG4820af2bfc71: [X86] Remove superfluous trailing semicolons, fixing warnings. NFC. (authored by mstorsjo).
[X86] Remove superfluous trailing semicolons, fixing warnings. NFC.
Wed, Sep 2, 1:44 AM

Mon, Aug 31

mstorsjo added a comment to D86889: [AArch64] Add asm directives for the remaining SEH unwind codes.

Adding assembler support for the basic opcodes we left out because the code generator doesn't use them seems fine. We could teach the assembler to optimize certain constructs: for example, turn save_regp_x into save_r19r20_x if the register matches and the offset is in range. Might be more confusing than helpful, though.

Mon, Aug 31, 1:41 PM · Restricted Project
mstorsjo requested review of D86889: [AArch64] Add asm directives for the remaining SEH unwind codes.
Mon, Aug 31, 12:43 PM · Restricted Project
mstorsjo committed rGb16ac94419b7: [ORC] Remove a stray semicolon, silencing warnings. NFC. (authored by mstorsjo).
[ORC] Remove a stray semicolon, silencing warnings. NFC.
Mon, Aug 31, 12:26 PM
mstorsjo committed rGa54919e0c115: [LLD] [COFF] Error out if creating a DLL with too many exported symbols (authored by mstorsjo).
[LLD] [COFF] Error out if creating a DLL with too many exported symbols
Mon, Aug 31, 11:33 AM
mstorsjo closed D86701: [LLD] [COFF] Error out if creating a DLL with too many exported symbols.
Mon, Aug 31, 11:32 AM · Restricted Project

Sun, Aug 30

mstorsjo updated the diff for D86701: [LLD] [COFF] Error out if creating a DLL with too many exported symbols.

Added a testcase with a tiny python script that generates def files that export the same symbol a number of times. It generates two 566 KB def files, for testing the case below and above the limit. The successful link case produces a 1 MB DLL and a 8 MB import library.

Sun, Aug 30, 1:19 PM · Restricted Project

Sat, Aug 29

mstorsjo committed rG5b86d130e2ba: [AArch64] Generate and parse SEH assembly directives (authored by mstorsjo).
[AArch64] Generate and parse SEH assembly directives
Sat, Aug 29, 5:17 AM