Page MenuHomePhabricator

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (192 w, 1 d)

Recent Activity

Today

mstorsjo added a comment to D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.

@labath @aleksandr.urakov Does this version look good to you?

Tue, Mar 31, 4:23 AM · Restricted Project
mstorsjo added reviewers for D77099: Exit unwinding early when at the top of the stack and additional info won't be found.: ldionne, EricWF.

+1 the change looks sensible to me - but I'd leave it to someone else of the runtime projects' maintainers (@mclow.lists @ldionne @EricWF) to approve.

Tue, Mar 31, 2:10 AM · Restricted Project

Yesterday

mstorsjo updated the diff for D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.

Moved the check up to ObjectFilePECOFF.

Mon, Mar 30, 4:17 AM · Restricted Project
mstorsjo added a comment to D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.

Hello! But does the format of an exception directory for aarch64 differ completely from x86-64 one?

Mon, Mar 30, 4:17 AM · Restricted Project

Sat, Mar 28

mstorsjo created D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.
Sat, Mar 28, 4:40 PM · Restricted Project
mstorsjo committed rGe6112a56dde6: [AsmPrinter] Emit .weak directive for weak linkage on COFF for symbols without… (authored by mstorsjo).
[AsmPrinter] Emit .weak directive for weak linkage on COFF for symbols without…
Sat, Mar 28, 10:12 AM
mstorsjo closed D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.
Sat, Mar 28, 10:12 AM · Restricted Project
mstorsjo committed rG8330dcadb841: [llvm-rc] Allow -1 for menu item IDs (authored by mstorsjo).
[llvm-rc] Allow -1 for menu item IDs
Sat, Mar 28, 6:28 AM
mstorsjo closed D76951: [llvm-rc] Allow -1 for menu item IDs.
Sat, Mar 28, 6:27 AM · Restricted Project

Fri, Mar 27

mstorsjo added a comment to D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.

@rnk Does this form of the change look decent to you?

Fri, Mar 27, 3:27 PM · Restricted Project
mstorsjo added a comment to D76951: [llvm-rc] Allow -1 for menu item IDs.

Negative values, especially -1, for unneeded IDs is indeed a very things in Windows resource files, not just for menu items (and submenus) but also for decorative controls on dialogs. So this looks fine to me, though we might eventually have to relax the constraints even more.

Fri, Mar 27, 3:27 PM · Restricted Project
mstorsjo created D76951: [llvm-rc] Allow -1 for menu item IDs.
Fri, Mar 27, 1:10 PM · Restricted Project
mstorsjo accepted D76935: [COFF] Don't treat DWARF sections as GC roots.

Looks good I think. I'm not very familiar with the GC parts of LLD, but the explanations sound sensible to me, and I believe this solution has been vetted by at least two others already (bug reporter and @rnk).

Fri, Mar 27, 10:21 AM · Restricted Project

Thu, Mar 26

mstorsjo updated the diff for D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.

Changed hasLinkOnceDirective into avoidWeakIfComdat and adjusted the condition.

Thu, Mar 26, 5:23 AM · Restricted Project
mstorsjo added a comment to D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.
In D44543#1942495, @rnk wrote:

@rnk - what do you think about the two alternative solutions I commented above?

The second change seems simpler, but maybe we should adjust the linkonce predicate name. As I understand it, both solutions will preserve the behavior of existing linkonce* and weak* linkages if a comdat is present, which it pretty much always is unless the user is using the __attribute__((weak)) extension.

It seems to me like the hasLinkOnceDirective predicate isn't really helping us here. I dug into the history, and I see that back around 2010, it controlled the emission of .linkonce discard. It got moved to section emission in rG76a07580a. Then, later, when we made all the object file sections use the standard, non-suffixed names, we folded that into the .section directive and stopped using the .linkonce directive entirely. So, it seems like maybe the MCAsmInfo feature that we really want here should read something like "avoidWeakIfComdat" or "shouldWeakComdatSymbolsBeExternal" or "isWeakComdatExternal" or something like that. shouldUpgradeWeakComdatToExternal...

Thu, Mar 26, 5:23 AM · Restricted Project

Wed, Mar 25

mstorsjo added a comment to D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.

Or would it be best to extend the generic MCAsmInfo with another function, and change the existing condition into (MAI->hasLinkOnceDirective() && (GV->hasComdat() || !MAI->linkOnceDirectiveRequiresComdat()))? That makes the condition both generic and clearer.

Wed, Mar 25, 10:47 AM · Restricted Project

Mon, Mar 23

mstorsjo added a comment to D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.

Ping @rnk

Mon, Mar 23, 10:23 AM · Restricted Project

Wed, Mar 18

mstorsjo added a comment to D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.

@rnk?

Wed, Mar 18, 12:29 PM · Restricted Project
mstorsjo added a comment to D75068: libclang: Add static build support for Windows .

@thakis?

Wed, Mar 18, 12:29 PM · Restricted Project

Mon, Mar 16

mstorsjo updated the diff for D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.

Rebased the patch, adjusted the condition to another way of expressing roughly the same, added a comment to the common code.

Mon, Mar 16, 5:17 AM · Restricted Project
mstorsjo commandeered D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.
Mon, Mar 16, 4:38 AM · Restricted Project
mstorsjo committed rG042eb0482aa7: [llvm-objdump] Add llvm_unreachable to silence GCC warning. NFC. (authored by mstorsjo).
[llvm-objdump] Add llvm_unreachable to silence GCC warning. NFC.
Mon, Mar 16, 4:38 AM

Sat, Mar 14

mstorsjo committed rG97c7be9028ea: [llvm-dlltool] Add a testcase to show the kind of weak external used for import… (authored by mstorsjo).
[llvm-dlltool] Add a testcase to show the kind of weak external used for import…
Sat, Mar 14, 5:20 AM
mstorsjo abandoned D71711: [COFF] Make the autogenerated .weak.<name>.default symbols static.

Superseded by D75989.

Sat, Mar 14, 1:33 AM · Restricted Project

Fri, Mar 13

mstorsjo committed rG8f540dad6120: [COFF] Assign unique names to autogenerated .weak.<name>.default symbols (authored by mstorsjo).
[COFF] Assign unique names to autogenerated .weak.<name>.default symbols
Fri, Mar 13, 2:02 PM
mstorsjo closed D75989: [COFF] Assign unique names to autogenerated .weak.<name>.default symbols.
Fri, Mar 13, 2:02 PM · Restricted Project
mstorsjo added a comment to D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF.

@rnk - what do you think about the two alternative solutions I commented above?

Fri, Mar 13, 1:29 PM · Restricted Project
mstorsjo updated the diff for D75989: [COFF] Assign unique names to autogenerated .weak.<name>.default symbols.

Fixed a clang-tidy warning.

Fri, Mar 13, 9:06 AM · Restricted Project

Thu, Mar 12

mstorsjo added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

Thanks for reporting this! Since this is the case of the X86::MOV16ri the D75326 will solve this issue.

The alternative is D75974.

The D75974 is commited.

Thu, Mar 12, 1:36 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Wed, Mar 11

mstorsjo added a reviewer for D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF: mstorsjo.

I keep running into this issue in various places, that __attribute__((weak)) doesn't work on COFF in clang.

Wed, Mar 11, 7:24 AM · Restricted Project
mstorsjo created D75989: [COFF] Assign unique names to autogenerated .weak.<name>.default symbols.
Wed, Mar 11, 7:24 AM · Restricted Project

Tue, Mar 10

mstorsjo added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

This broke compiling for mingw, repro.c:

a(short);
b() { a(1); }

clang -target x86_64-w64-mingw32 -c repro.c -g -O2, which gives Assertion !MI.isMoveImmediate() && "Unexpected MoveImm instruction"' failed.`

Tue, Mar 10, 10:19 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Mon, Mar 9

mstorsjo added a comment to D75068: libclang: Add static build support for Windows .

@thakis?

Mon, Mar 9, 12:58 PM · Restricted Project

Thu, Mar 5

mstorsjo added a comment to D75637: Promote nameless lambda used by dl_iterate_phdr to named function..

Got to test this now as well, and it works fine for windows at least. Thanks!

Thu, Mar 5, 12:35 AM · Restricted Project

Wed, Mar 4

mstorsjo accepted D75637: Promote nameless lambda used by dl_iterate_phdr to named function..

LGTM (but I didn't have the possibility to test it right now, but it seems right).

Wed, Mar 4, 2:05 PM · Restricted Project

Tue, Mar 3

mstorsjo added a comment to D75480: Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structureto allow use by a future replacment function..

This broke building for windows, and I would be pretty sure it also broke things for apple platforms as well (as _LIBUNWIND_SUPPORT_DWARF_UNWIND is defined on both of them, at least on certain architectures).

Tue, Mar 3, 11:33 PM · Restricted Project

Feb 25 2020

mstorsjo added a comment to D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

It's true, MSVC doesn't support inline assembly at all on non-i386 platforms.

However, LLVM currently does support MS-style inline assembly on x86-64, if you use the MS-style asm blocks... it just doesn't quite work as expected. (We've seen a few bug reports to this effect, including http://llvm.org/PR44272 - several of which have said the option of MS-style inline assembly on x86-64 is a big bonus.) Handling that here would move it closer to fully working.

Feb 25 2020, 11:51 AM · Restricted Project
mstorsjo committed rGe3add3e5a192: [libcxx] Fix building for windows after 54fa9ecd3088508 (authored by mstorsjo).
[libcxx] Fix building for windows after 54fa9ecd3088508
Feb 25 2020, 11:35 AM
mstorsjo closed D75102: [libcxx] Fix building for windows after 54fa9ecd3088508.
Feb 25 2020, 11:35 AM · Restricted Project
mstorsjo added a comment to D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

What's the plan for 64-bit inline asm?

It should probably be the same, admittedly. To clarify: isParsingInlineAsm will only be true when parsing inline MS-style assembly? If so, I'll rename it to isParsingInlineMSAsm in this patch, and let the handling trigger off of both.

Feb 25 2020, 11:33 AM · Restricted Project
mstorsjo added a comment to D68480: Implementation of C++20's P1135R6 for libcxx.

FWIW, this change broke building for windows. It seemed fairly straightforward to fix though, see D75102.

Feb 25 2020, 12:23 AM · Restricted Project

Feb 24 2020

mstorsjo created D75102: [libcxx] Fix building for windows after 54fa9ecd3088508.
Feb 24 2020, 11:47 PM · Restricted Project
mstorsjo updated subscribers of D74599: llvm-ar: Fix MinGW compilation.

Ping, could someone with better insight in the CMake setup comment on whether this is the right spot to add a thing like this? I guess this would end up included when building the runtimes (both as part of the monorepo, and when building them standalone, if the llvm cmake files are available), but I think that would be fine for now.

Feb 24 2020, 12:29 PM · Restricted Project

Feb 19 2020

mstorsjo committed rG7ff1f55a1219: libclang: Add static build support for Windows (authored by cristian.adam).
libclang: Add static build support for Windows
Feb 19 2020, 2:09 PM
mstorsjo closed D74564: libclang: Add static build support for Windows.
Feb 19 2020, 2:09 PM · Restricted Project
mstorsjo added a comment to D74599: llvm-ar: Fix MinGW compilation.

Does this affect the runtimes as well, if built as part of the monorepo build and/or standalone?

Feb 19 2020, 1:41 PM · Restricted Project
mstorsjo closed D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable.

Committed and backported. Thanks!

Feb 19 2020, 1:31 PM · Restricted Project

Feb 18 2020

mstorsjo committed rGd6fe253653b7: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable (authored by cristian.adam).
llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable
Feb 18 2020, 4:47 AM
mstorsjo updated subscribers of D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable.

Committed in d6fe253653b7e760f94ca21d0a7ebbfeeee28777 (I forgot the Differential Revision: tag, sorry).

Feb 18 2020, 4:47 AM · Restricted Project
mstorsjo added a comment to D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable.

I can try to get it committed soon. What form do you want for the author line, "Cristian Adam <cristian.adam@gmail.com>"?

Feb 18 2020, 2:50 AM · Restricted Project

Feb 17 2020

mstorsjo committed rG0e1da1ef4af2: [LLDB] Fix GCC warnings about extra semicolons. NFC. (authored by mstorsjo).
[LLDB] Fix GCC warnings about extra semicolons. NFC.
Feb 17 2020, 4:17 AM

Feb 14 2020

mstorsjo added a comment to D74599: llvm-ar: Fix MinGW compilation.
you could just as well make it Windows 7 (which is the documented minimum version).

The documented minimum version for CompareStringOrdinal is Vista per https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-comparestringordinal

Are you talking about the documented minimum version of something else?

Feb 14 2020, 12:21 PM · Restricted Project
mstorsjo added a comment to D74599: llvm-ar: Fix MinGW compilation.

I don't use the php based arcanist either, I just upload diffs that I make with git diff -U999.

Feb 14 2020, 4:06 AM · Restricted Project
mstorsjo added reviewers for D74599: llvm-ar: Fix MinGW compilation: rnk, smeenai, beanz.

Looks sensible in general, but you could just as well make it Windows 7 (which is the documented minimum version).

Feb 14 2020, 3:24 AM · Restricted Project

Feb 13 2020

mstorsjo accepted D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable.

LGTM

Feb 13 2020, 9:19 AM · Restricted Project
mstorsjo added a reviewer for D74477: [llvm-ar] Simplify Windows comparePaths NFCI: rnk.
Feb 13 2020, 5:59 AM · Restricted Project
mstorsjo added a comment to D74436: Change clang option -ffp-model=precise to select ffp-contract=on.

FYI this caused failed builds for aarch64 (when building with -fno-signed-zeros), hitting unreachable statements in TargetLowering::getNegatedExpression - see https://bugs.llvm.org/show_bug.cgi?id=44892. I guess that's a bug in the aarch64 backend and not with this change in itself, but it was only uncovered by this change...

Feb 13 2020, 12:59 AM · Restricted Project

Feb 12 2020

mstorsjo added a comment to D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM.

Now someone might argue that the looking up the address of the ldr opcode is wrong, because that is not the actual pc value, and that we should lookup the address of ldr+1. In that case we can point them to the next function (call_noreturn), which ends with a call to a noreturn function. Now if we get a crash in does_not_return(), the address we will get from the backtrace will be one byte after the last opcode of call_noreturn (bl does_not_return()). This means that in the non-windows case, it will not resolve correctly to the call_noreturn even if we apply the usual trick of subtracting 1 from the address to bring it into the range of the calling function.

Hmm... I presume this issue is present now already (and doesn't really change due to normalizing the line tables and ranges on windows, to the same as linux). Not familiar with "the usual trick of subtracting 1 from the address to bring it into the range of the calling function", but wouldn't something like GetOpcodeLoadAddress(pc) - 1 always bring you into the range of the calling function, given a return address?

Lldb uses this when unwinding specifically to deal with the "call as a last instruction" problem, and I'm pretty sure it's not the only tool doing that. This is even described in the DWARF spec (non-normative text):

In most cases the return address is in the same context as the calling address, but that
need not be the case, especially if the producer knows in some way the call never will
return. The context of the ’return address’ might be on a different line, in a different
lexical block, or past the end of the calling subroutine. If a consumer were to assume that
it was in the same context as the calling address, the virtual unwind might fail.

For architectures with constant-length instructions where the return address
immediately follows the call instruction, a simple solution is to subtract the length of an
instruction from the return address to obtain the calling instruction. For architectures
with variable-length instructions (for example, x86), this is not possible. However,
subtracting 1 from the return address, although not guaranteed to provide the exact
calling address, generally will produce an address within the same context as the calling
address, and that usually is sufficient.

Using GetOpcodeLoadAddress(pc) - 1 would work, but this implies that the caller should be passing in "load" addresses, which is in conflict with the premise I have made at the beginning of the paragraph that one should be passing in "code" addresses here. (My attempt at proof by contradiction.)

Feb 12 2020, 5:09 AM · Restricted Project
mstorsjo added a comment to D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM.

I did not send out any emails for this, but I did talk about this with @dblaikie when I was in the US last week. My take from that is that we should start by "fixing" llvm-symbolizer so that it works reasonably in these cases. I'll use this godbolt link to illustrate what I mean.

If we take a look at the deref function in that link, and try to pass the address of the first instruction ldr r0, [r0] to llvm-symbolizer, then we will get something reasonable in the non-windows case, but we will get nothing in the windows case, because the debug info would claim that the function starts halfway into that opcode. Fixing the tool so that it returns the same thing everywhere sounds reasonable, and since it does both line table and debug_info lookups, this will already answer the main questions we have about where this logic should be implemented. Then we can just copy that in lldb.

Feb 12 2020, 4:05 AM · Restricted Project
mstorsjo committed rG7002128ca935: [LLDB] Fix GCC warnings about extra semicolons. NFC. (authored by mstorsjo).
[LLDB] Fix GCC warnings about extra semicolons. NFC.
Feb 12 2020, 3:46 AM
mstorsjo added a comment to D61314: [SCCP] Remove forcedconstant, go to overdefined instead.

The Linux kernel hits the assert in markConstant on arm32 defconfig in net/mac80211/sta_info.o, as reported by Linaro's CI:

Feb 12 2020, 12:52 AM · Restricted Project

Feb 10 2020

mstorsjo committed rGbc8e44218810: [test] Disable the Passes/PluginsTest cases on windows with BUILD_SHARED_LIBS (authored by mstorsjo).
[test] Disable the Passes/PluginsTest cases on windows with BUILD_SHARED_LIBS
Feb 10 2020, 12:55 PM
mstorsjo closed D74042: [test] Disable the Passes/PluginsTest cases on windows.
Feb 10 2020, 12:55 PM · Restricted Project
mstorsjo committed rG6115bd9ba285: [LLDB] Fix GCC warnings about extra semicolons. NFC. (authored by mstorsjo).
[LLDB] Fix GCC warnings about extra semicolons. NFC.
Feb 10 2020, 1:26 AM

Feb 8 2020

mstorsjo added a comment to D73907: [InstCombine] correct operands of shouldChangeType() for casted phi transform.

This causes failed asserts for me. With https://martin.st/temp/substtml-preproc.c, built with clang -target i686-w64-mingw32 -c -O2 substtml-preproc.c, I'm getting this:

Feb 8 2020, 2:09 AM · Restricted Project

Feb 7 2020

mstorsjo updated the diff for D74042: [test] Disable the Passes/PluginsTest cases on windows.

Don't use return() on the file level

Feb 7 2020, 11:37 PM · Restricted Project
mstorsjo added a comment to D74042: [test] Disable the Passes/PluginsTest cases on windows.

Maybe only disable this in shared library builds?

Feb 7 2020, 10:20 PM · Restricted Project

Feb 6 2020

mstorsjo retitled D74042: [test] Disable the Passes/PluginsTest cases on windows from [test] Disable the Passes/PluginsTest cases on windows with BUILD_SHARED_LIBS to [test] Disable the Passes/PluginsTest cases on windows.
Feb 6 2020, 3:55 AM · Restricted Project
mstorsjo updated subscribers of D74084: [LLDB] Fix compilation with GCC 5.

@hans - this could be applied on 10.x (it seems to apply cleanly), to fix PR44791.

Feb 6 2020, 12:38 AM · Restricted Project
mstorsjo committed rG5bbaf543585c: [LLDB] Fix compilation with GCC 5 (authored by mstorsjo).
[LLDB] Fix compilation with GCC 5
Feb 6 2020, 12:21 AM
mstorsjo closed D74084: [LLDB] Fix compilation with GCC 5.
Feb 6 2020, 12:21 AM · Restricted Project

Feb 5 2020

mstorsjo updated the diff for D74042: [test] Disable the Passes/PluginsTest cases on windows.

Simplified the check to if (WIN32)

Feb 5 2020, 11:53 PM · Restricted Project
mstorsjo created D74084: [LLDB] Fix compilation with GCC 5.
Feb 5 2020, 12:34 PM · Restricted Project
mstorsjo closed D74029: [libcxx] Add release notes for the 10.x branch for things I've done.

Committed in https://reviews.llvm.org/rGd5361190993a.

Feb 5 2020, 11:21 AM · Restricted Project
mstorsjo closed D74027: [docs] Add LLVM/LLDB release notes for the 10.x branch for things I've done.

Committed in https://reviews.llvm.org/rG0f99f678febf.

Feb 5 2020, 11:21 AM · Restricted Project
mstorsjo closed D74026: [LLD] Add release notes for MinGW for the 10.x branch.

Committed in https://reviews.llvm.org/rG424babb89ad2.

Feb 5 2020, 11:21 AM · Restricted Project
mstorsjo closed D74028: [clang] Add release notes for the 10.x branch for things I've done.

Committed in https://reviews.llvm.org/rG7e518f3159bd.

Feb 5 2020, 11:21 AM · Restricted Project
mstorsjo committed rGd5361190993a: [libcxx] Add release notes for the 10.x branch for things I've done (authored by mstorsjo).
[libcxx] Add release notes for the 10.x branch for things I've done
Feb 5 2020, 7:26 AM
mstorsjo committed rG7e518f3159bd: [clang] Add release notes for the 10.x branch for things I've done (authored by mstorsjo).
[clang] Add release notes for the 10.x branch for things I've done
Feb 5 2020, 7:26 AM
mstorsjo committed rG0f99f678febf: [docs] Add LLVM/LLDB release notes for the 10.x branch for things I've done (authored by mstorsjo).
[docs] Add LLVM/LLDB release notes for the 10.x branch for things I've done
Feb 5 2020, 7:26 AM
mstorsjo committed rG424babb89ad2: [LLD] Add release notes for MinGW for the 10.x branch (authored by mstorsjo).
[LLD] Add release notes for MinGW for the 10.x branch
Feb 5 2020, 7:25 AM
mstorsjo created D74042: [test] Disable the Passes/PluginsTest cases on windows.
Feb 5 2020, 5:04 AM · Restricted Project
mstorsjo added a reverting change for rGc1c9819ef91a: [CMake] Add missing component dependencies, to fix building for mingw with…: rG2f1ca30f997a: Partially revert c1c9819ef91aab51b5a23fb3027adac5a2f551cc.
Feb 5 2020, 3:33 AM
mstorsjo committed rG2f1ca30f997a: Partially revert c1c9819ef91aab51b5a23fb3027adac5a2f551cc (authored by mstorsjo).
Partially revert c1c9819ef91aab51b5a23fb3027adac5a2f551cc
Feb 5 2020, 3:33 AM
mstorsjo committed rGc1c9819ef91a: [CMake] Add missing component dependencies, to fix building for mingw with… (authored by mstorsjo).
[CMake] Add missing component dependencies, to fix building for mingw with…
Feb 5 2020, 3:15 AM
mstorsjo closed D73840: [CMake] Add missing component dependencies, to fix building for mingw with BUILD_SHARED_LIBS.
Feb 5 2020, 3:15 AM · Restricted Project
mstorsjo added a reviewer for D74029: [libcxx] Add release notes for the 10.x branch for things I've done: rnk.
Feb 5 2020, 2:12 AM · Restricted Project
mstorsjo created D74028: [clang] Add release notes for the 10.x branch for things I've done.
Feb 5 2020, 1:44 AM · Restricted Project
mstorsjo created D74029: [libcxx] Add release notes for the 10.x branch for things I've done.
Feb 5 2020, 1:44 AM · Restricted Project
mstorsjo created D74027: [docs] Add LLVM/LLDB release notes for the 10.x branch for things I've done.
Feb 5 2020, 1:44 AM · Restricted Project
mstorsjo created D74026: [LLD] Add release notes for MinGW for the 10.x branch.
Feb 5 2020, 1:44 AM · Restricted Project

Feb 3 2020

mstorsjo added a comment to D72543: [libcxxabi] Insert padding in __cxa_exception struct for compatibility.

@hans I landed this on master. Let me know if I need to do something for release branch. I will wait a bit to see if it breaks any unexpected users.

I've cherry-picked it to 10.x in 674ec1eb16678b8addc02a4b0534ab383d22fa77, figuring it's better to get it in sooner rather than later. Please let me know if you hear about any problems or if there are follow-ups.

Feb 3 2020, 11:57 PM · Restricted Project
mstorsjo added a comment to D73812: [CMake] Filter libc++abi and libunwind from runtimes build in MSVC.

Thanks!

Feb 3 2020, 11:58 AM · Restricted Project
mstorsjo added a comment to D73839: [LLDB] Add missing declarations for linking to psapi.

I guess this is causing the windows failure on the bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13320

Yeah, I saw that - highly strange. I'll try to see if I can reproduce similar issues with a similar toolchain, and I'll push a revert soon unless I find some great clue.

Feb 3 2020, 4:34 AM · Restricted Project
mstorsjo added a comment to D73839: [LLDB] Add missing declarations for linking to psapi.

I guess this is causing the windows failure on the bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13320

Feb 3 2020, 3:43 AM · Restricted Project
mstorsjo committed rGeb5ee9275d7a: [LLDB] Add missing declarations for linking to psapi (authored by mstorsjo).
[LLDB] Add missing declarations for linking to psapi
Feb 3 2020, 3:04 AM
mstorsjo closed D73839: [LLDB] Add missing declarations for linking to psapi.
Feb 3 2020, 3:04 AM · Restricted Project
mstorsjo committed rGf867c8e81f70: [PM][CGSCC] Add parentheses to avoid a GCC warning. NFC. (authored by mstorsjo).
[PM][CGSCC] Add parentheses to avoid a GCC warning. NFC.
Feb 3 2020, 12:09 AM
mstorsjo committed rG09dc884eb2e4: [libcxxabi] Fix layout of __cxa_exception for win64 (authored by mstorsjo).
[libcxxabi] Fix layout of __cxa_exception for win64
Feb 3 2020, 12:09 AM
mstorsjo committed rG2dc45bf392fa: [OpenMP] Fix GCC warnings. NFC. (authored by mstorsjo).
[OpenMP] Fix GCC warnings. NFC.
Feb 3 2020, 12:08 AM