Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

People melonedo

melonedo (Funan Zeng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2022, 12:40 AM (74 w, 4 d)

Recent Activity
View All

Aug 24 2023

melonedo added a comment to D157510: [RISCV] Implement intrinsics for XCVbitmanip extension in CV32E40P.

From discussions last week, a header file for the C API will be included later as a public interface, which is tracked by https://github.com/openhwgroup/corev-gcc/issues/48 and https://github.com/openhwgroup/corev-llvm-project/issues/74. For LLVM intrisics level, since target-specific builtins can map to target-independent intrisics, I will implement these with LLVM target independent intrinsics.

Aug 24 2023, 4:58 AM · Restricted Project, Restricted Project

Aug 20 2023

melonedo updated the diff for D157510: [RISCV] Implement intrinsics for XCVbitmanip extension in CV32E40P.

Remove CORE-V specific intrisics for cv.ff1/fl1/cnt/ror

Aug 20 2023, 7:25 AM · Restricted Project, Restricted Project

Aug 14 2023

melonedo updated the diff for D157510: [RISCV] Implement intrinsics for XCVbitmanip extension in CV32E40P.

Fix formatting issues

Aug 14 2023, 9:24 PM · Restricted Project, Restricted Project

Aug 13 2023

melonedo added inline comments to D157510: [RISCV] Implement intrinsics for XCVbitmanip extension in CV32E40P.
Aug 13 2023, 8:58 PM · Restricted Project, Restricted Project
melonedo added a comment to D157510: [RISCV] Implement intrinsics for XCVbitmanip extension in CV32E40P.
In D157510#4573494, @craig.topper wrote:

Is there intended to be a header file that wraps the builtins? For other targets, builtins are considered an internal implementation detail and the real interface is the header file. I'm trying to get a C interface approved for Zb* and Zk* standard extenions https://github.com/riscv-non-isa/riscv-c-api-doc/pull/44

Aug 13 2023, 8:39 PM · Restricted Project, Restricted Project
melonedo updated the diff for D157510: [RISCV] Implement intrinsics for XCVbitmanip extension in CV32E40P.
  • Use DefaultAttrsIntrinsic
  • Implement LLVM intrinsics for ctpop/ctlz/cttz/ror/rol/bitreverse
  • Replace pseudo instructions for SDNodeXForm
Aug 13 2023, 8:28 PM · Restricted Project, Restricted Project

Aug 9 2023

melonedo added reviewers for D157510: [RISCV] Implement intrinsics for XCVbitmanip extension in CV32E40P: craig.topper, jrtc27, asb, kito-cheng, reames.
Aug 9 2023, 7:38 AM · Restricted Project, Restricted Project
melonedo requested review of D157510: [RISCV] Implement intrinsics for XCVbitmanip extension in CV32E40P.
Aug 9 2023, 7:36 AM · Restricted Project, Restricted Project

Jul 28 2023

melonedo committed rGafb9c04a5a44: [RISCV] Add support for XCVbi extension in CV32E40P (authored by melonedo).
[RISCV] Add support for XCVbi extension in CV32E40P
Jul 28 2023, 6:55 AM · Restricted Project, Restricted Project
melonedo added a reverting change for rGbf2ad26b4ff8: [RISCV] Add support for XCVbi extension in CV32E40P: rGe4777dc4b9cb: Revert "[RISCV] Add support for XCVbi extension in CV32E40P".
Jul 28 2023, 4:29 AM · Restricted Project, Restricted Project
melonedo committed rGe4777dc4b9cb: Revert "[RISCV] Add support for XCVbi extension in CV32E40P" (authored by melonedo).
Revert "[RISCV] Add support for XCVbi extension in CV32E40P"
Jul 28 2023, 4:29 AM · Restricted Project, Restricted Project
melonedo added a reverting change for D154412: [RISCV] Add support for XCVbi extension in CV32E40P: rGe4777dc4b9cb: Revert "[RISCV] Add support for XCVbi extension in CV32E40P".
Jul 28 2023, 4:29 AM · Restricted Project, Restricted Project
melonedo committed rGbf2ad26b4ff8: [RISCV] Add support for XCVbi extension in CV32E40P (authored by melonedo).
[RISCV] Add support for XCVbi extension in CV32E40P
Jul 28 2023, 2:37 AM · Restricted Project, Restricted Project
melonedo closed D154412: [RISCV] Add support for XCVbi extension in CV32E40P.
Jul 28 2023, 2:37 AM · Restricted Project, Restricted Project
melonedo committed rG3c0604b224e3: [RISCV] Add support for XCVsimd extension in CV32E40P (authored by melonedo).
[RISCV] Add support for XCVsimd extension in CV32E40P
Jul 28 2023, 1:53 AM · Restricted Project, Restricted Project
melonedo closed D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.
Jul 28 2023, 1:52 AM · Restricted Project, Restricted Project

Jul 24 2023

melonedo updated the diff for D154412: [RISCV] Add support for XCVbi extension in CV32E40P.

Amend RISCVUsage.rst

Jul 24 2023, 8:14 PM · Restricted Project, Restricted Project
melonedo updated the diff for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.

Adjust opcode field and rebase to main

Jul 24 2023, 8:06 PM · Restricted Project, Restricted Project
melonedo updated the diff for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.

Edit RISCVUsage.rst

Jul 24 2023, 7:48 PM · Restricted Project, Restricted Project

Jul 21 2023

melonedo updated the diff for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.

Switch cv.and/or/xor to signed according to spec to allow 0xffff-like patterns

Jul 21 2023, 12:18 AM · Restricted Project, Restricted Project

Jul 18 2023

melonedo updated the diff for D154412: [RISCV] Add support for XCVbi extension in CV32E40P.

Add tests for +xcvbi option; add extension to RISCVISAInfo; fix spelling

Jul 18 2023, 1:13 AM · Restricted Project, Restricted Project
melonedo updated the diff for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.

Fix capitalization of FeatureVendorXCVsimd

Jul 18 2023, 12:22 AM · Restricted Project, Restricted Project
melonedo updated the diff for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.

Various corrections based on D155283

Jul 18 2023, 12:16 AM · Restricted Project, Restricted Project

Jul 11 2023

melonedo updated the summary of D154412: [RISCV] Add support for XCVbi extension in CV32E40P.
Jul 11 2023, 2:01 AM · Restricted Project, Restricted Project
melonedo updated the summary of D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.
Jul 11 2023, 2:01 AM · Restricted Project, Restricted Project
melonedo updated the diff for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.

RV->CV; update version; add "CORE-V" to feature description

Jul 11 2023, 1:57 AM · Restricted Project, Restricted Project
melonedo updated the diff for D154412: [RISCV] Add support for XCVbi extension in CV32E40P.

Change version of spec to 1.0.0

Jul 11 2023, 12:55 AM · Restricted Project, Restricted Project

Jul 4 2023

melonedo updated the diff for D154412: [RISCV] Add support for XCVbi extension in CV32E40P.

Adopt suggestions

Jul 4 2023, 7:28 PM · Restricted Project, Restricted Project
melonedo updated the diff for D154412: [RISCV] Add support for XCVbi extension in CV32E40P.

Rename RVInst* to CVInst*

Jul 4 2023, 6:57 PM · Restricted Project, Restricted Project
melonedo updated subscribers of D154412: [RISCV] Add support for XCVbi extension in CV32E40P.
Jul 4 2023, 1:04 AM · Restricted Project, Restricted Project
melonedo updated subscribers of D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.
Jul 4 2023, 1:04 AM · Restricted Project, Restricted Project
melonedo added reviewers for D154412: [RISCV] Add support for XCVbi extension in CV32E40P: jrtc27, craig.topper, asb, kito-cheng, reames.
Jul 4 2023, 12:56 AM · Restricted Project, Restricted Project
melonedo updated the diff for D154412: [RISCV] Add support for XCVbi extension in CV32E40P.

Fix type

Jul 4 2023, 12:53 AM · Restricted Project, Restricted Project
melonedo requested review of D154412: [RISCV] Add support for XCVbi extension in CV32E40P.
Jul 4 2023, 12:51 AM · Restricted Project, Restricted Project
melonedo updated the summary of D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.
Jul 4 2023, 12:49 AM · Restricted Project, Restricted Project

Jul 3 2023

melonedo updated the diff for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.

Update immediate type of cv.avgu/srl/sra/sll

Jul 3 2023, 2:21 AM · Restricted Project, Restricted Project

Jun 25 2023

melonedo updated the diff for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.

Rebase to main

Jun 25 2023, 8:26 AM · Restricted Project, Restricted Project
melonedo added reviewers for D153721: [RISCV] Add support for XCVsimd extension in CV32E40P: jrtc27, craig.topper, asb, kito-cheng, reames.
Jun 25 2023, 8:26 AM · Restricted Project, Restricted Project
melonedo requested review of D153721: [RISCV] Add support for XCVsimd extension in CV32E40P.
Jun 25 2023, 8:26 AM · Restricted Project, Restricted Project

Jun 19 2023

melonedo committed rGc5a412dad5b8: [RISCV] Add support for XCVbitmanip extension in CV32E40P (authored by melonedo).
[RISCV] Add support for XCVbitmanip extension in CV32E40P
Jun 19 2023, 6:16 AM · Restricted Project, Restricted Project
melonedo closed D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.
Jun 19 2023, 6:16 AM · Restricted Project, Restricted Project

Jun 16 2023

melonedo updated the diff for D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.

Reuse RVInstI/R and enable test for disassembler

Jun 16 2023, 11:47 PM · Restricted Project, Restricted Project

Jun 15 2023

melonedo updated the summary of D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.
Jun 15 2023, 11:44 PM · Restricted Project, Restricted Project
melonedo updated the diff for D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.

Add contributor

Jun 15 2023, 11:43 PM · Restricted Project, Restricted Project

Jun 14 2023

melonedo updated the diff for D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.

Switch to one file per vendor

Jun 14 2023, 8:57 AM · Restricted Project, Restricted Project
melonedo updated the diff for D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.

[RISCV] Add support for XCVbitmanip extension in CV32E40P

Jun 14 2023, 7:29 AM · Restricted Project, Restricted Project
melonedo updated the diff for D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.

Remove excessive test header

Jun 14 2023, 7:24 AM · Restricted Project, Restricted Project
melonedo updated the diff for D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.

Fix typo

Jun 14 2023, 7:20 AM · Restricted Project, Restricted Project
melonedo updated the diff for D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.

Add usage, merge tests and ensure 80-char limit

Jun 14 2023, 7:18 AM · Restricted Project, Restricted Project
melonedo added reviewers for D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P: jrtc27, craig.topper, asb, kito-cheng, reames.
Jun 14 2023, 6:48 AM · Restricted Project, Restricted Project
melonedo requested review of D152915: [RISCV] Add support for XCVbitmanip extension in CV32E40P.
Jun 14 2023, 6:46 AM · Restricted Project, Restricted Project

Nov 9 2022

melonedo committed rGf4f6c63f0df7: [RISCV] Add support for static chain (authored by melonedo).
[RISCV] Add support for static chain
Nov 9 2022, 12:11 AM · Restricted Project, Restricted Project
melonedo closed D129106: [RISCV] Add support for static chain.
Nov 9 2022, 12:10 AM · Restricted Project, Restricted Project

Oct 27 2022

melonedo updated the diff for D129106: [RISCV] Add support for static chain.

Specify -filetype=null

Oct 27 2022, 8:11 PM · Restricted Project, Restricted Project
melonedo updated the diff for D129106: [RISCV] Add support for static chain.

Revise comments

Oct 27 2022, 7:29 PM · Restricted Project, Restricted Project
melonedo updated the diff for D129106: [RISCV] Add support for static chain.

Also use opaque pointers in ghccc-nest.ll

Oct 27 2022, 7:21 PM · Restricted Project, Restricted Project
melonedo updated the diff for D129106: [RISCV] Add support for static chain.

Use opaque pointers

Oct 27 2022, 7:19 PM · Restricted Project, Restricted Project
melonedo updated the diff for D129106: [RISCV] Add support for static chain.

Use ptr for opaque pointers

Oct 27 2022, 7:16 PM · Restricted Project, Restricted Project

Sep 7 2022

melonedo updated the diff for D129106: [RISCV] Add support for static chain.

Rebase and upload changes again

Sep 7 2022, 8:59 PM · Restricted Project, Restricted Project

Aug 18 2022

melonedo added a comment to D129106: [RISCV] Add support for static chain.
In D129106#3629936, @luismarques wrote:

I guess this patch should update the other conventions as well? E.g. error out if nest is used with the GHC CC. There's also the FastCC.

Aug 18 2022, 11:26 PM · Restricted Project, Restricted Project
melonedo added a comment to D129106: [RISCV] Add support for static chain.
In D129106#3630316, @jrtc27 wrote:

This doesn’t work with dynamic linking (unless you use the recently-added STO_RISCV_VARIANT_CC) as t2 can be clobbered by the resolver.

Aug 18 2022, 11:22 PM · Restricted Project, Restricted Project
melonedo updated the diff for D129106: [RISCV] Add support for static chain.

Adopt suggestions

Aug 18 2022, 11:19 PM · Restricted Project, Restricted Project

Jul 5 2022

melonedo updated the diff for D129106: [RISCV] Add support for static chain.

Rebase the commit on master.

Jul 5 2022, 1:05 AM · Restricted Project, Restricted Project

Jul 4 2022

melonedo requested review of D129106: [RISCV] Add support for static chain.
Jul 4 2022, 11:42 PM · Restricted Project, Restricted Project