RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since: May 5 2014, 7:26 AM (309 w, 2 d)

Recent Activity
View All

Today

RKSimon added inline comments to D74060: [KnownBits] Move AND, OR and XOR logic into KnownBits.

Wed, Apr 8, 2:08 PM · Restricted Project

RKSimon added a comment to D77354: [DO NOT MERGE] added FileCheck colons that broke things.

@jroelofs Please can you rebase again? I think I've dealt with all the low hanging fruit now, so you will probably have to git blame to find code owners to help fix the remaining issues.

Wed, Apr 8, 10:51 AM · Restricted Project

RKSimon committed rG94121c60d622: [InstCombine] Regenerate phi-preserve-ir-flags.ll test checks to fix issue… (authored by RKSimon).

[InstCombine] Regenerate phi-preserve-ir-flags.ll test checks to fix issue…

Wed, Apr 8, 10:19 AM

RKSimon committed rGc8dfd0008b17: [PowerPC] Regenerate optcmp.ll test checks to fix issue reported on D77354 (authored by RKSimon).

[PowerPC] Regenerate optcmp.ll test checks to fix issue reported on D77354

Wed, Apr 8, 10:19 AM

RKSimon committed rGca5af4b649f4: [PowerPC] Fix fold-rlwinm.mir typos in checks to fix issue reported on D77354 (authored by RKSimon).

[PowerPC] Fix fold-rlwinm.mir typos in checks to fix issue reported on D77354

Wed, Apr 8, 9:46 AM

RKSimon committed rG68c6d7e11c51: [PowerPC] Fix fold-frame-offset-using-rr.mir typos in checks to fix issue… (authored by RKSimon).

[PowerPC] Fix fold-frame-offset-using-rr.mir typos in checks to fix issue…

Wed, Apr 8, 9:46 AM

RKSimon committed rG54502476e7bd: [AMDGPU] Refresh fmin_legacy.ll checks to fix issue reported on D77354 (authored by RKSimon).

[AMDGPU] Refresh fmin_legacy.ll checks to fix issue reported on D77354

Wed, Apr 8, 9:13 AM

RKSimon committed rG5f25d22d3f01: [ARM] Fix thumb1_return_sequence typo in check to fix issue reported on D77354 (authored by RKSimon).

[ARM] Fix thumb1_return_sequence typo in check to fix issue reported on D77354

Wed, Apr 8, 8:08 AM

RKSimon committed rG7b65b1ecd118: [ARM] Fix misched-int-basic-thumb2.mir typo in check to fix issue reported on… (authored by RKSimon).

[ARM] Fix misched-int-basic-thumb2.mir typo in check to fix issue reported on…

Wed, Apr 8, 8:08 AM

RKSimon committed rGc6cd0936be50: [AARCH64][GISEL] arm64-fallback.ll - Refresh remarks to fix issue reported on… (authored by RKSimon).

[AARCH64][GISEL] arm64-fallback.ll - Refresh remarks to fix issue reported on…

Wed, Apr 8, 7:35 AM

RKSimon committed rG898e22908c4f: [MemorySSA] invariant-groups.ll - add missing check to fix issue reported on… (authored by RKSimon).

[MemorySSA] invariant-groups.ll - add missing check to fix issue reported on…

Wed, Apr 8, 7:35 AM

RKSimon committed rG0c2ab6368994: [CodeExtractor] Fix typo in check label to fix issue reported on D77354 (authored by RKSimon).

[CodeExtractor] Fix typo in check label to fix issue reported on D77354

Wed, Apr 8, 7:03 AM

RKSimon committed rG7e62684251ed: [AMDGPU] Regenerate vector-extract-insert test checks to fix issue reported on… (authored by RKSimon).

[AMDGPU] Regenerate vector-extract-insert test checks to fix issue reported on…

Wed, Apr 8, 5:24 AM

RKSimon committed rG98181a1f98e7: [AMDGPU] Regenerate si-annotate-cfg-loop-assert test checks to fix issue… (authored by RKSimon).

[AMDGPU] Regenerate si-annotate-cfg-loop-assert test checks to fix issue…

Wed, Apr 8, 5:24 AM

RKSimon committed rG66c18c729da4: [X86][SSE] Combine PTEST(AND(X,Y),AND(X,Y)) -> PTEST(X,Y) and ANDN equivalents (authored by RKSimon).

[X86][SSE] Combine PTEST(AND(X,Y),AND(X,Y)) -> PTEST(X,Y) and ANDN equivalents

Wed, Apr 8, 4:50 AM

Yesterday

RKSimon committed rG6f46e9af8a0e: [X86][SSE] Add PTEST(AND(X,Y),AND(X,Y)) tests derived from PR42035 examples (authored by RKSimon).

[X86][SSE] Add PTEST(AND(X,Y),AND(X,Y)) tests derived from PR42035 examples

Tue, Apr 7, 10:20 AM

RKSimon updated subscribers of rL231475: [AsmPrinter][TLOF] 32-bit MachO support for replacing GOT equivalents.

Tue, Apr 7, 10:18 AM

RKSimon committed rGe3b60597769f: [X86][SSE] combineX86ShufflesConstants - early out for zeroable vectors… (authored by RKSimon).

[X86][SSE] combineX86ShufflesConstants - early out for zeroable vectors…

Tue, Apr 7, 7:02 AM

RKSimon added inline comments to D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector..

Tue, Apr 7, 3:12 AM · Restricted Project, Restricted Project

Mon, Apr 6

RKSimon added a comment to rGfabe52a7412d: Fix uninitialized variable warning. NFC..

That one is a bit of blur (a lots happened since then.....) but I think it was one of the more obscure buildbots? Maybe one of the clang-ppc64 bots running a funny gcc version?

Mon, Apr 6, 11:57 AM

RKSimon accepted D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

LGTM with the minor addition an extra CHECK-LABEL

Mon, Apr 6, 11:57 AM · Restricted Project

RKSimon added a comment to D77463: [ARM] Remove condition that could never be true.

Thanks for fixing the warning. LGTM but an ARM specialist should accept based on the test case.

Mon, Apr 6, 9:44 AM · Restricted Project

RKSimon added a comment to D77393: [X86] Fix implicit sign conversion warnings in X86 headers..

@craig.topper Any comments? Hopefully we can add extra tests as time goes on (for instance I'm intending to add Wdocumentation test coverage for PR35949).

Mon, Apr 6, 8:38 AM · Restricted Project

RKSimon committed rG9bc5b1a489c6: [X86][SSE] combineVectorSignBitsTruncation - remove minimum vector length… (authored by RKSimon).

[X86][SSE] combineVectorSignBitsTruncation - remove minimum vector length…

Mon, Apr 6, 4:50 AM

RKSimon accepted D51737: DAG: Combine extract_vector_elt of concat_vectors.

LGTM

Mon, Apr 6, 4:17 AM

Sun, Apr 5

RKSimon committed rGa43e23360657: Remove unused function 'isInRange'. NFCI. (authored by RKSimon).

Remove unused function 'isInRange'. NFCI.

Sun, Apr 5, 3:30 PM

RKSimon committed rG4431a29c60e7: [X86][SSE] Combine unary shuffle(HORIZOP,HORIZOP) -> HORIZOP (authored by RKSimon).

[X86][SSE] Combine unary shuffle(HORIZOP,HORIZOP) -> HORIZOP

Sun, Apr 5, 2:58 PM

RKSimon committed rG3079e518589c: [X86][SSE] Generalize shuffle(HORIZOP,HORIZOP) -> HORIZOP combine (authored by RKSimon).

[X86][SSE] Generalize shuffle(HORIZOP,HORIZOP) -> HORIZOP combine

Sun, Apr 5, 4:15 AM

RKSimon committed rGa17de6b91cff: [X86][SSE] truncateVectorWithPACK - upper undef for 128->64 packing (authored by RKSimon).

[X86][SSE] truncateVectorWithPACK - upper undef for 128->64 packing

Sun, Apr 5, 4:15 AM

Sat, Apr 4

RKSimon committed rGbe84d2b5b7e9: [CostModel][X86] Add some insert subvector cost tests for… (authored by RKSimon).

[CostModel][X86] Add some insert subvector cost tests for…

Sat, Apr 4, 2:54 PM

RKSimon committed rG3380d4d75e84: [X86] Cleanup vectorcall test checks (authored by RKSimon).

[X86] Cleanup vectorcall test checks

Sat, Apr 4, 2:54 PM

RKSimon committed rG6a57ba17c032: [CostModel][X86] Add shuffle cost tests for sub-128bit vectors (authored by RKSimon).

[CostModel][X86] Add shuffle cost tests for sub-128bit vectors

Sat, Apr 4, 5:15 AM

RKSimon committed rG87fd686f6fdd: [CostModel][X86] Add insert/extract cost tests for sub-128bit vXi8/vXi16 vectors (authored by RKSimon).

[CostModel][X86] Add insert/extract cost tests for sub-128bit vXi8/vXi16 vectors

Sat, Apr 4, 5:15 AM

RKSimon committed rGe5e719d8854a: [X86][SSE] lowerV8I16Shuffle - lower compaction shuffles using PACKUSDW(PBLENDW… (authored by RKSimon).

[X86][SSE] lowerV8I16Shuffle - lower compaction shuffles using PACKUSDW(PBLENDW…

Sat, Apr 4, 5:15 AM

RKSimon added a comment to D77354: [DO NOT MERGE] added FileCheck colons that broke things.

@jroelofs please can you rebase to see what test are still broken?

Sat, Apr 4, 3:02 AM · Restricted Project

Fri, Apr 3

RKSimon added inline comments to D77301: [TargetLowering] Improve expansion of FSHL/FSHR.

Fri, Apr 3, 2:38 PM · Restricted Project

RKSimon committed rG22257975679d: [YAMLParser] Scanner::setError - ensure we use the StringRef::iterator argument… (authored by RKSimon).

[YAMLParser] Scanner::setError - ensure we use the StringRef::iterator argument…

Fri, Apr 3, 11:21 AM

RKSimon closed D76512: [YAMLParser] Scanner::setError - ensure we use the StringRef::iterator argument (PR45043).

Fri, Apr 3, 11:20 AM · Restricted Project

RKSimon committed rG34a497b7653b: [X86][SSE] lowerShuffleWithPACK - extend to use chained PACKs for larger… (authored by RKSimon).

[X86][SSE] lowerShuffleWithPACK - extend to use chained PACKs for larger…

Fri, Apr 3, 10:47 AM

RKSimon committed rG396b1ee0e0b0: [LoopStrengthReduce] Fix test checks to fix issue reported on D77227 (authored by RKSimon).

[LoopStrengthReduce] Fix test checks to fix issue reported on D77227

Fri, Apr 3, 10:16 AM

RKSimon committed rG30053c842ca4: [AArch64] Fix swap-compare-operands test names to fix issue reported on D77354 (authored by RKSimon).

[AArch64] Fix swap-compare-operands test names to fix issue reported on D77354

Fri, Apr 3, 10:15 AM

RKSimon committed rG6d24dd7ed119: [InstSimplify] Regenerate compares tests to fix issue reported on D77354 (authored by RKSimon).

[InstSimplify] Regenerate compares tests to fix issue reported on D77354

Fri, Apr 3, 9:42 AM

RKSimon committed rG43d2fc7ed74e: [LoopRotate] Cleanup test checks to fix issue reported on D77354 (authored by RKSimon).

[LoopRotate] Cleanup test checks to fix issue reported on D77354

Fri, Apr 3, 9:42 AM

RKSimon committed rG5f47f613de50: [PowerPC] Regenerate f128 test to fix issue reported on D77354 (authored by RKSimon).

[PowerPC] Regenerate f128 test to fix issue reported on D77354

Fri, Apr 3, 9:09 AM

RKSimon committed rG80d4df5be661: [X86] Remove defunct section checks from emulated TLS tests to fix issue… (authored by RKSimon).

[X86] Remove defunct section checks from emulated TLS tests to fix issue…

Fri, Apr 3, 9:08 AM

RKSimon committed rG40fc3de369a3: [X86] Fix weak global label issue reported on D77354 (authored by RKSimon).

[X86] Fix weak global label issue reported on D77354

Fri, Apr 3, 8:36 AM

RKSimon committed rG58c242e7b874: [X86] Fix gisel copy tests to fix issue reported on D77354 (authored by RKSimon).

[X86] Fix gisel copy tests to fix issue reported on D77354

Fri, Apr 3, 8:36 AM

RKSimon committed rGe9511c0206d4: [X86] Fix strong local function/global label issue reported on D77354 (authored by RKSimon).

[X86] Fix strong local function/global label issue reported on D77354

Fri, Apr 3, 8:36 AM

RKSimon committed rGaa8434fa3d1d: [X86] Cleanup emulated TLS test checks. NFC (authored by RKSimon).

[X86] Cleanup emulated TLS test checks. NFC

Fri, Apr 3, 8:36 AM

RKSimon added a reviewer for D77393: [X86] Fix implicit sign conversion warnings in X86 headers.: RKSimon.

Rename test file to x86-header-warnings.c or something similarly specific?

Fri, Apr 3, 7:29 AM · Restricted Project

RKSimon committed rG7521f3c2f068: [X86] Regenerate soft fp legalization test to fix issue reported on D77354 (authored by RKSimon).

[X86] Regenerate soft fp legalization test to fix issue reported on D77354

Fri, Apr 3, 6:59 AM

RKSimon committed rG74f00c66dd36: [X86] Regenerate stack clash test to fix issue reported on D77354 (authored by RKSimon).

[X86] Regenerate stack clash test to fix issue reported on D77354

Fri, Apr 3, 6:59 AM

RKSimon committed rG5e426363ba4b: [X86][AVX] Add tests showing failure to use chained PACKSS/PACKUS for multi… (authored by RKSimon).

[X86][AVX] Add tests showing failure to use chained PACKSS/PACKUS for multi…

Fri, Apr 3, 6:25 AM

RKSimon added reviewers for D72423: [DemandedBits] Improve accuracy of Add propagator: regehr, nikic.

Adding @regehr and @nikic as they might have some thoughts on this

Fri, Apr 3, 5:20 AM · Restricted Project

RKSimon added a comment to D75567: [x86] Enable bypassing 64-bit division on generic x86-64.

Test cases?

Fri, Apr 3, 3:11 AM · Restricted Project

RKSimon added reviewers for D76512: [YAMLParser] Scanner::setError - ensure we use the StringRef::iterator argument (PR45043): spatel, rnk, thomasfinch.

Fri, Apr 3, 3:11 AM · Restricted Project

RKSimon accepted D77300: [X86] Improve combineVectorShiftImm.

LGTM

Fri, Apr 3, 3:11 AM · Restricted Project

Thu, Apr 2

RKSimon accepted D76623: [VectorCombine] try to form a better extractelement.

LGTM

Thu, Apr 2, 2:38 PM · Restricted Project

RKSimon added a comment to D40633: [PCG] Poor shuffle lane tracking (PR35454 ).

@kbelochapka I think we can abandon this now the vector combine pass handles PR35454

Thu, Apr 2, 2:38 PM

RKSimon added inline comments to D77301: [TargetLowering] Improve expansion of FSHL/FSHR.

Thu, Apr 2, 10:50 AM · Restricted Project

RKSimon added inline comments to D77319: [DAGCombine] Remove the getNegatibleCost to avoid the out of sync with getNegatedExpression.

Thu, Apr 2, 10:17 AM · Restricted Project

RKSimon added reviewers for D77319: [DAGCombine] Remove the getNegatibleCost to avoid the out of sync with getNegatedExpression: RKSimon, spatel, efriedma, arsenm.

Thu, Apr 2, 10:17 AM · Restricted Project

RKSimon added inline comments to D77300: [X86] Improve combineVectorShiftImm.

Thu, Apr 2, 9:12 AM · Restricted Project

RKSimon added a comment to D74976: [CostModel][X86] Improve extract/insert element costs (PR43605).

In D74976#1956437, @thakis wrote:

We got a report that this slows down PDF rendering in pdfium rendering of one pdf by 11%, and it slowed down rendering of 6% of pdfs of a test corpus by 2+%.

https://bugs.chromium.org/p/chromium/issues/detail?id=1067111 has repro steps. Could you take a look?

Thu, Apr 2, 8:06 AM · Restricted Project

RKSimon added inline comments to D77300: [X86] Improve combineVectorShiftImm.

Thu, Apr 2, 7:33 AM · Restricted Project

RKSimon committed rGb02c7a81523f: Fix "result of 32-bit shift implicitly converted to 64 bits" MSVC warning. NFCI. (authored by RKSimon).

Fix "result of 32-bit shift implicitly converted to 64 bits" MSVC warning. NFCI.

Thu, Apr 2, 4:19 AM

RKSimon committed rG316e220cf432: [llvm-mca] Cleanup unnecessary includes from headers (authored by RKSimon).

[llvm-mca] Cleanup unnecessary includes from headers

Thu, Apr 2, 4:19 AM

RKSimon closed D77073: [llvm-mca] Cleanup unnecessary includes from headers.

Thu, Apr 2, 4:18 AM · Restricted Project