Page MenuHomePhabricator

RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (276 w, 1 d)

Recent Activity

Today

RKSimon added a comment to D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c.

I created D65110 if we're ok with just using the new PM.

Tue, Aug 20, 2:51 PM
RKSimon accepted D66456: [DAGCombiner][X86] Teach visitCONCAT_VECTORS to combine (concat_vectors (concat_vectors X, Y), undef)) -> (concat_vectors X, Y, undef, undef).

LGTM - cheers

Tue, Aug 20, 2:40 PM · Restricted Project
RKSimon accepted D66489: [X86] Add a DAG combine to transform (i8 (bitcast (v8i1 (extract_subvector (v16i1 X), 0)))) -> (i8 (trunc (i16 (bitcast (v16i1 X))))) on KNL target.

LGTM

Tue, Aug 20, 12:26 PM · Restricted Project
RKSimon committed rG3b9a27b69080: Fix typo in comment. NFCI. (authored by RKSimon).
Fix typo in comment. NFCI.
Tue, Aug 20, 11:02 AM
RKSimon committed rL369419: Fix typo in comment. NFCI..
Fix typo in comment. NFCI.
Tue, Aug 20, 11:02 AM
RKSimon abandoned D64417: [Support] Remove MSVC specific AlignedCharArray implementation.

This was handled in rL367282

Tue, Aug 20, 9:40 AM · Restricted Project
RKSimon accepted D66380: [SDAG] Fold umul_lohi with 0 or 1 multiplicand.

OK, thanks for checking - LGTM

Tue, Aug 20, 9:15 AM · Restricted Project
RKSimon accepted D66469: [X86][BtVer2] Fix latency and throughput of atomic INC/DEC/NEG/NOT..

LGTM

Tue, Aug 20, 7:02 AM · Restricted Project
RKSimon updated the diff for D63141: [DAGCombine] GetNegatedExpression - add FMA\FMAD support.

Updated patch to correctly respect NSZ flags. I've also improved the logic to ensure we negate the most profitable multiplication factor, not just the first one.

Tue, Aug 20, 6:35 AM · Restricted Project
RKSimon committed rGcec028fc14dd: [X86][FMA] Add FMA 'negated expression' combine tests for D63141 (authored by RKSimon).
[X86][FMA] Add FMA 'negated expression' combine tests for D63141
Tue, Aug 20, 6:27 AM
RKSimon committed rL369384: [X86][FMA] Add FMA 'negated expression' combine tests for D63141.
[X86][FMA] Add FMA 'negated expression' combine tests for D63141
Tue, Aug 20, 6:25 AM
RKSimon committed rGed72e0ecf80e: [CMake] Update C4324 MSVC warning comment to explain its still broken at VS2019 (authored by RKSimon).
[CMake] Update C4324 MSVC warning comment to explain its still broken at VS2019
Tue, Aug 20, 4:20 AM
RKSimon committed rL369368: [CMake] Update C4324 MSVC warning comment to explain its still broken at VS2019.
[CMake] Update C4324 MSVC warning comment to explain its still broken at VS2019
Tue, Aug 20, 4:20 AM
RKSimon committed rG6a3dc3e15cb2: [MCA][X86] Add tests for LOCK variants of standard X86 arithmetic ops (authored by RKSimon).
[MCA][X86] Add tests for LOCK variants of standard X86 arithmetic ops
Tue, Aug 20, 4:17 AM
RKSimon committed rL369367: [MCA][X86] Add tests for LOCK variants of standard X86 arithmetic ops.
[MCA][X86] Add tests for LOCK variants of standard X86 arithmetic ops
Tue, Aug 20, 4:12 AM
RKSimon committed rG5a28f0ae6e3a: Fix MSVC "result of 32-bit shift implicitly converted to 64 bits" warning. NFCI. (authored by RKSimon).
Fix MSVC "result of 32-bit shift implicitly converted to 64 bits" warning. NFCI.
Tue, Aug 20, 3:30 AM
RKSimon committed rL369366: Fix MSVC "result of 32-bit shift implicitly converted to 64 bits" warning. NFCI..
Fix MSVC "result of 32-bit shift implicitly converted to 64 bits" warning. NFCI.
Tue, Aug 20, 3:25 AM
RKSimon added inline comments to D66456: [DAGCombiner][X86] Teach visitCONCAT_VECTORS to combine (concat_vectors (concat_vectors X, Y), undef)) -> (concat_vectors X, Y, undef, undef).
Tue, Aug 20, 3:07 AM · Restricted Project
RKSimon accepted D65933: [X86] Making X86OptimizeLEAs pass public. NFC.

LGTM - you just need to clang-format X86OptimizeLEAs.cpp as the addition of "X86" has screwed up indentations.

Tue, Aug 20, 3:07 AM · Restricted Project

Yesterday

RKSimon accepted D66424: [X86][Btver2] Fix latency and throughput of CMPXCHG instructions..

LGTM - thanks!

Mon, Aug 19, 12:58 PM · Restricted Project
RKSimon added inline comments to D66424: [X86][Btver2] Fix latency and throughput of CMPXCHG instructions..
Mon, Aug 19, 10:47 AM · Restricted Project
RKSimon added a comment to D63661: [SLPVectorizer] Operand reordering across multiple instructions..

@vporpo Are you still looking at this please?

Mon, Aug 19, 8:30 AM · Restricted Project
RKSimon added a comment to D62890: [DAGCombiner] Merge consecutive stores of vector elements before types are legalized.

@lkail Are you still looking at this please?

Mon, Aug 19, 8:30 AM · Restricted Project
Herald added a project to D56306: [X86] Create PMULDQ/PMULUDQ even when the type is illegal. Teach type legalization to split it.: Restricted Project.

@craig.topper Is this still relevant?

Mon, Aug 19, 8:03 AM · Restricted Project
RKSimon added a comment to D65931: [AArch64][SVE] Implement abs and neg intrinsics.

Is it worth adding in ISD::ABS support here ?

Mon, Aug 19, 7:56 AM · Restricted Project
RKSimon accepted D66300: [TargetLowering] x s% C == 0 fold: vector divisor with INT_MIN handling.

LGTM with more minor I noticed

Mon, Aug 19, 7:54 AM · Restricted Project
RKSimon added a comment to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

@ABataev Are you still looking at this or should we move to D66416? Now that X86 has enabled integer widening, we could more easily make use of this.

Mon, Aug 19, 7:12 AM · Restricted Project
RKSimon added reviewers for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors.: craig.topper, dtemirbulatov.

@ABataev Are you still looking at this or should we move to D66416? Now that X86 has enabled integer widening, we could more easily make use of this.

Mon, Aug 19, 6:47 AM · Restricted Project
RKSimon accepted D66071: [X86] Teach lowerV4I32Shuffle to only use broadcasts if the mask has more than one undef element. Prioritize shifts over broadcast in lowerV8I16Shuffle..

Are you asking about v8i16 where I switched the shift priority?

Mon, Aug 19, 5:53 AM · Restricted Project
RKSimon added a comment to D66300: [TargetLowering] x s% C == 0 fold: vector divisor with INT_MIN handling.

a couple of minor comments

Mon, Aug 19, 5:45 AM · Restricted Project
RKSimon added inline comments to D65933: [X86] Making X86OptimizeLEAs pass public. NFC.
Mon, Aug 19, 2:57 AM · Restricted Project

Sun, Aug 18

RKSimon committed rG63b3c56fca6d: Fix signed/unsigned comparison warning. NFCI. (authored by RKSimon).
Fix signed/unsigned comparison warning. NFCI.
Sun, Aug 18, 10:26 AM
RKSimon committed rL369213: Fix signed/unsigned comparison warning. NFCI..
Fix signed/unsigned comparison warning. NFCI.
Sun, Aug 18, 10:25 AM
RKSimon committed rGfee2546f3f2e: [X86] isTargetShuffleEquivalent - add BUILD_VECTOR matching (authored by RKSimon).
[X86] isTargetShuffleEquivalent - add BUILD_VECTOR matching
Sun, Aug 18, 10:17 AM
RKSimon committed rL369212: [X86] isTargetShuffleEquivalent - add BUILD_VECTOR matching.
[X86] isTargetShuffleEquivalent - add BUILD_VECTOR matching
Sun, Aug 18, 10:15 AM
RKSimon committed rGa66edd86e27a: [X86] isTargetShuffleEquivalent - early out on illegal shuffle masks. NFCI. (authored by RKSimon).
[X86] isTargetShuffleEquivalent - early out on illegal shuffle masks. NFCI.
Sun, Aug 18, 9:41 AM
RKSimon committed rL369211: [X86] isTargetShuffleEquivalent - early out on illegal shuffle masks. NFCI..
[X86] isTargetShuffleEquivalent - early out on illegal shuffle masks. NFCI.
Sun, Aug 18, 9:36 AM
RKSimon committed rG133e2d7bf83c: [X86][SSE] Improve PACKSS shuffle tests to better match codegen from D61129 (authored by RKSimon).
[X86][SSE] Improve PACKSS shuffle tests to better match codegen from D61129
Sun, Aug 18, 8:39 AM
RKSimon committed rL369209: [X86][SSE] Improve PACKSS shuffle tests to better match codegen from D61129.
[X86][SSE] Improve PACKSS shuffle tests to better match codegen from D61129
Sun, Aug 18, 8:39 AM
RKSimon committed rG000dfdab2dfc: [MC] MCFixup - Fix cppcheck + MSVC analyzer uninitialized member variable… (authored by RKSimon).
[MC] MCFixup - Fix cppcheck + MSVC analyzer uninitialized member variable…
Sun, Aug 18, 6:31 AM
RKSimon committed rL369208: [MC] MCFixup - Fix cppcheck + MSVC analyzer uninitialized member variable….
[MC] MCFixup - Fix cppcheck + MSVC analyzer uninitialized member variable…
Sun, Aug 18, 6:31 AM
RKSimon added inline comments to D66380: [SDAG] Fold umul_lohi with 0 or 1 multiplicand.
Sun, Aug 18, 4:47 AM · Restricted Project

Fri, Aug 16

RKSimon committed rG63b78b678bc2: [X86] resolveTargetShuffleInputs - add DemandedElts variant. NFCI. (authored by RKSimon).
[X86] resolveTargetShuffleInputs - add DemandedElts variant. NFCI.
Fri, Aug 16, 11:18 AM
RKSimon committed rL369136: [X86] resolveTargetShuffleInputs - add DemandedElts variant. NFCI..
[X86] resolveTargetShuffleInputs - add DemandedElts variant. NFCI.
Fri, Aug 16, 11:17 AM
RKSimon committed rG8ff1b7de4dae: [X86] combineExtractWithShuffle - handle extract(truncate(x), 0) (authored by RKSimon).
[X86] combineExtractWithShuffle - handle extract(truncate(x), 0)
Fri, Aug 16, 10:36 AM
RKSimon committed rL369134: [X86] combineExtractWithShuffle - handle extract(truncate(x), 0).
[X86] combineExtractWithShuffle - handle extract(truncate(x), 0)
Fri, Aug 16, 10:35 AM
RKSimon committed rG3a8c6987714c: [X86] Alphabetize pass initialization definitions. NFCI. (authored by RKSimon).
[X86] Alphabetize pass initialization definitions. NFCI.
Fri, Aug 16, 9:43 AM
RKSimon added a comment to D65933: [X86] Making X86OptimizeLEAs pass public. NFC.

please rebase on rL369126

Fri, Aug 16, 9:43 AM · Restricted Project
RKSimon committed rL369126: [X86] Alphabetize pass initialization definitions. NFCI..
[X86] Alphabetize pass initialization definitions. NFCI.
Fri, Aug 16, 9:41 AM
RKSimon added inline comments to D65933: [X86] Making X86OptimizeLEAs pass public. NFC.
Fri, Aug 16, 8:44 AM · Restricted Project
RKSimon added a comment to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….

Please raise a bug if you manage to get a repro

Fri, Aug 16, 7:59 AM
RKSimon committed rG429aa7c1e65b: [X86][SSE] Add shuffled load tests from PR16739 (authored by RKSimon).
[X86][SSE] Add shuffled load tests from PR16739
Fri, Aug 16, 7:53 AM
RKSimon committed rL369116: [X86][SSE] Add shuffled load tests from PR16739.
[X86][SSE] Add shuffled load tests from PR16739
Fri, Aug 16, 7:53 AM
RKSimon committed rG1051f4f9bf8c: Revert rL369112 : [X86][SSE] Add shuffled load tests from PR16739 (authored by RKSimon).
Revert rL369112 : [X86][SSE] Add shuffled load tests from PR16739
Fri, Aug 16, 7:35 AM
RKSimon committed rL369115: Revert rL369112 : [X86][SSE] Add shuffled load tests from PR16739.
Revert rL369112 : [X86][SSE] Add shuffled load tests from PR16739
Fri, Aug 16, 7:31 AM
RKSimon added a reverting change for rL369112: [X86][SSE] Add shuffled load tests from PR16739: rL369115: Revert rL369112 : [X86][SSE] Add shuffled load tests from PR16739.
Fri, Aug 16, 7:31 AM
RKSimon committed rG213edc34922a: [X86][SSE] Add shuffled load tests from PR16739 (authored by RKSimon).
[X86][SSE] Add shuffled load tests from PR16739
Fri, Aug 16, 7:26 AM
RKSimon committed rL369112: [X86][SSE] Add shuffled load tests from PR16739.
[X86][SSE] Add shuffled load tests from PR16739
Fri, Aug 16, 7:25 AM
RKSimon committed rG9da4989c5237: [X86] Remove unused include. NFCI. (authored by RKSimon).
[X86] Remove unused include. NFCI.
Fri, Aug 16, 7:08 AM
RKSimon committed rL369110: [X86] Remove unused include. NFCI..
[X86] Remove unused include. NFCI.
Fri, Aug 16, 7:07 AM
RKSimon accepted D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.

LGTM - do we have constant folding coverage btw?

Fri, Aug 16, 3:36 AM · Restricted Project
RKSimon committed rG59894d466853: [SLPVectorizer] Silence null dereference warning. NFCI. (authored by RKSimon).
[SLPVectorizer] Silence null dereference warning. NFCI.
Fri, Aug 16, 3:28 AM
RKSimon committed rL369094: [SLPVectorizer] Silence null dereference warning. NFCI..
[SLPVectorizer] Silence null dereference warning. NFCI.
Fri, Aug 16, 3:28 AM
RKSimon added a reviewer for D66330: Fix use-after-free in CodeGenPrepare: craig.topper.
Fri, Aug 16, 3:06 AM · Restricted Project

Thu, Aug 15

RKSimon committed rG1c013ca1f28b: [LLVM][Alignment] Fix MSVC potential division by 0 warning (PR42911) (authored by RKSimon).
[LLVM][Alignment] Fix MSVC potential division by 0 warning (PR42911)
Thu, Aug 15, 9:37 AM
RKSimon committed rL369016: [LLVM][Alignment] Fix MSVC potential division by 0 warning (PR42911).
[LLVM][Alignment] Fix MSVC potential division by 0 warning (PR42911)
Thu, Aug 15, 9:33 AM
RKSimon closed D65859: [LLVM][Alignment] Fix MSVC warning.
Thu, Aug 15, 9:33 AM · Restricted Project
RKSimon added a comment to D66052: [DAGCombiner] Add simple folds for SMULFIX/UMULFIX/SMULFIXSAT.

Please can you commit mulfix_combine.ll to trunk with current (trunk) codegen, then rebase this patch so that it shows the diff

Thu, Aug 15, 8:13 AM · Restricted Project
RKSimon accepted D65892: [X86] Improve cost model for subvector extraction of less than 128-bit vectors.

LGTM - I've been trying to think of a general helper function we could create for this as I can only imagine that we're going to need this more....

Thu, Aug 15, 8:03 AM · Restricted Project
RKSimon committed rGd4df81f463e4: Remove SmallBitVector.h include. NFCI. (authored by RKSimon).
Remove SmallBitVector.h include. NFCI.
Thu, Aug 15, 7:43 AM
RKSimon committed rG983e9118a29f: Remove BitVector.h include. NFCI. (authored by RKSimon).
Remove BitVector.h include. NFCI.
Thu, Aug 15, 7:39 AM
RKSimon committed rL369008: Remove SmallBitVector.h include. NFCI..
Remove SmallBitVector.h include. NFCI.
Thu, Aug 15, 7:39 AM
RKSimon committed rL369007: Remove BitVector.h include. NFCI..
Remove BitVector.h include. NFCI.
Thu, Aug 15, 7:39 AM
RKSimon added a comment to D65859: [LLVM][Alignment] Fix MSVC warning.

I'm happy to remove the push/pull if reviewers prefer - its just a personal style preference tbh

Thu, Aug 15, 6:52 AM · Restricted Project
RKSimon added reviewers for D65859: [LLVM][Alignment] Fix MSVC warning: rnk, gbedwell.

Adding some people interested in MSVC builds

Thu, Aug 15, 6:22 AM · Restricted Project
RKSimon updated the diff for D65859: [LLVM][Alignment] Fix MSVC warning.

Disable MSVC divide by zero warnings for the whole of AlignmentTest.cpp

Thu, Aug 15, 6:20 AM · Restricted Project
RKSimon committed rGed804dad1e68: [DAGCombine] MergeConsecutiveStores - fix cppcheck/MSVC extension warning. NFCI. (authored by RKSimon).
[DAGCombine] MergeConsecutiveStores - fix cppcheck/MSVC extension warning. NFCI.
Thu, Aug 15, 6:08 AM
RKSimon committed rL368998: [DAGCombine] MergeConsecutiveStores - fix cppcheck/MSVC extension warning. NFCI..
[DAGCombine] MergeConsecutiveStores - fix cppcheck/MSVC extension warning. NFCI.
Thu, Aug 15, 6:08 AM
RKSimon commandeered D65859: [LLVM][Alignment] Fix MSVC warning.
Thu, Aug 15, 4:46 AM · Restricted Project
RKSimon added a comment to D62432: [SLPVectorizer] Make the scheduler aware of the TreeEntry operands..

@ABataev @dtemirbulatov Any more comments?

Thu, Aug 15, 4:06 AM · Restricted Project
RKSimon accepted D66236: [SDAG][x86] check for relaxed math when matching an FP reduction.

LGTM - cheers

Thu, Aug 15, 2:20 AM · Restricted Project

Wed, Aug 14

RKSimon added inline comments to D66236: [SDAG][x86] check for relaxed math when matching an FP reduction.
Wed, Aug 14, 12:46 PM · Restricted Project
RKSimon added a comment to D66236: [SDAG][x86] check for relaxed math when matching an FP reduction.

Please could you add a couple of partial reduction tests (e.g. 4f32 in 8f32)

Wed, Aug 14, 12:42 PM · Restricted Project
RKSimon committed rG40f88d5f62f9: Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI. (authored by RKSimon).
Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI.
Wed, Aug 14, 10:44 AM
RKSimon committed rL368888: Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI..
Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI.
Wed, Aug 14, 10:43 AM
RKSimon added inline comments to D64700: [SLPVectorizer] [NFC] Avoid repetitive calls to getSameOpcode()..
Wed, Aug 14, 10:13 AM · Restricted Project
RKSimon committed rG4ae5efbe662e: Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI. (authored by RKSimon).
Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI.
Wed, Aug 14, 9:59 AM
RKSimon committed rL368877: Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI..
Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI.
Wed, Aug 14, 9:55 AM
RKSimon committed rG7fce86785693: Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI. (authored by RKSimon).
Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI.
Wed, Aug 14, 9:07 AM
RKSimon committed rL368865: Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI..
Fix cppcheck + MSVC analyzer uninitialized member variable warning. NFCI.
Wed, Aug 14, 9:02 AM
RKSimon added a comment to D65933: [X86] Making X86OptimizeLEAs pass public. NFC.

Not sure we should consider this NFC any more

Wed, Aug 14, 8:36 AM · Restricted Project
RKSimon added a comment to D65859: [LLVM][Alignment] Fix MSVC warning.

This isn't handling all the cases - its probably better to push at the top of the file (before namespace) and similarly pop at the end of the file

Wed, Aug 14, 8:12 AM · Restricted Project
RKSimon accepted D66069: [X86] Use PSADBW for v8i8 addition reductions..

OK, let's just go for v8i8

Wed, Aug 14, 7:39 AM · Restricted Project
RKSimon added inline comments to D64700: [SLPVectorizer] [NFC] Avoid repetitive calls to getSameOpcode()..
Wed, Aug 14, 6:00 AM · Restricted Project
RKSimon accepted D66169: [X86][CostModel] Adjust the costs of ZERO_EXTEND/SIGN_EXTEND with less than 128-bit inputs.

LGTM - I agree the AVX1 256-bit result cases might need further tweaking (especially for extension ratio = 2 as we can cheaply use movx+unpckh), but that can wait for now.

Wed, Aug 14, 5:45 AM · Restricted Project
RKSimon committed rG13447d3664f3: [X86] Add missing regular 512-bit vXi8 extract subvector cost model tests (authored by RKSimon).
[X86] Add missing regular 512-bit vXi8 extract subvector cost model tests
Wed, Aug 14, 5:38 AM
RKSimon committed rL368839: [X86] Add missing regular 512-bit vXi8 extract subvector cost model tests.
[X86] Add missing regular 512-bit vXi8 extract subvector cost model tests
Wed, Aug 14, 5:35 AM
RKSimon committed rG828a89e24471: Fix "not all control paths return a value" MSVC warnings. NFCI. (authored by RKSimon).
Fix "not all control paths return a value" MSVC warnings. NFCI.
Wed, Aug 14, 4:34 AM
RKSimon committed rG3f40bdb55864: Fix "not all control paths return a value" MSVC warning. NFCI. (authored by RKSimon).
Fix "not all control paths return a value" MSVC warning. NFCI.
Wed, Aug 14, 4:30 AM
RKSimon committed rL368831: Fix "not all control paths return a value" MSVC warnings. NFCI..
Fix "not all control paths return a value" MSVC warnings. NFCI.
Wed, Aug 14, 4:30 AM