Page MenuHomePhabricator
People RKSimon

RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (284 w, 3 h)

Recent Activity
View All

Today

RKSimon committed rGef0cb271807d: XCOFFObjectWriter - silence static analyzer dyn_cast<> null dereference warning. (authored by RKSimon).
XCOFFObjectWriter - silence static analyzer dyn_cast<> null dereference warning.
Mon, Oct 14, 9:48 AM
RKSimon committed rGe8877d043936: BitsInit::resolveReferences - silence static analyzer null dereference warning. (authored by RKSimon).
BitsInit::resolveReferences - silence static analyzer null dereference warning.
Mon, Oct 14, 9:48 AM
RKSimon committed rL374789: BitsInit::resolveReferences - silence static analyzer null dereference warning..
BitsInit::resolveReferences - silence static analyzer null dereference warning.
Mon, Oct 14, 9:48 AM
RKSimon committed rL374788: XCOFFObjectWriter - silence static analyzer dyn_cast<> null dereference warning..
XCOFFObjectWriter - silence static analyzer dyn_cast<> null dereference warning.
Mon, Oct 14, 9:48 AM
RKSimon committed rG1385b27e92d9: [CostModel][X86] Add CTLZ scalar costs (authored by RKSimon).
[CostModel][X86] Add CTLZ scalar costs
Mon, Oct 14, 9:38 AM
RKSimon committed rL374786: [CostModel][X86] Add CTLZ scalar costs.
[CostModel][X86] Add CTLZ scalar costs
Mon, Oct 14, 9:29 AM
RKSimon committed rG151bbba75861: [CostModel][X86] Add CTPOP scalar costs (PR43656) (authored by RKSimon).
[CostModel][X86] Add CTPOP scalar costs (PR43656)
Mon, Oct 14, 7:10 AM
RKSimon committed rL374775: [CostModel][X86] Add CTPOP scalar costs (PR43656).
[CostModel][X86] Add CTPOP scalar costs (PR43656)
Mon, Oct 14, 7:10 AM

Yesterday

RKSimon committed rG11495e5acb53: [X86] getTargetShuffleInputs - Control KnownUndef mask element resolution as… (authored by RKSimon).
[X86] getTargetShuffleInputs - Control KnownUndef mask element resolution as…
Sun, Oct 13, 12:36 PM
RKSimon committed rL374732: [X86] getTargetShuffleInputs - Control KnownUndef mask element resolution as….
[X86] getTargetShuffleInputs - Control KnownUndef mask element resolution as…
Sun, Oct 13, 12:36 PM
RKSimon committed rG3efafd6c38a4: [X86] SimplifyMultipleUseDemandedBitsForTargetNode - use getTargetShuffleInputs… (authored by RKSimon).
[X86] SimplifyMultipleUseDemandedBitsForTargetNode - use getTargetShuffleInputs…
Sun, Oct 13, 10:10 AM
RKSimon committed rGe4c58db8bc19: [X86] getTargetShuffleInputs - add KnownUndef/Zero output support (authored by RKSimon).
[X86] getTargetShuffleInputs - add KnownUndef/Zero output support
Sun, Oct 13, 10:10 AM
RKSimon committed rL374724: [X86] getTargetShuffleInputs - add KnownUndef/Zero output support.
[X86] getTargetShuffleInputs - add KnownUndef/Zero output support
Sun, Oct 13, 10:01 AM
RKSimon committed rL374725: [X86] SimplifyMultipleUseDemandedBitsForTargetNode - use getTargetShuffleInputs….
[X86] SimplifyMultipleUseDemandedBitsForTargetNode - use getTargetShuffleInputs…
Sun, Oct 13, 10:01 AM
RKSimon committed rGe84916d8917b: [X86][AVX] Add i686 avx splat tests (authored by RKSimon).
[X86][AVX] Add i686 avx splat tests
Sun, Oct 13, 6:19 AM
RKSimon committed rL374719: [X86][AVX] Add i686 avx splat tests.
[X86][AVX] Add i686 avx splat tests
Sun, Oct 13, 6:19 AM
RKSimon committed rG2c775709f6c2: BlockInCriticalSectionChecker - silence static analyzer dyn_cast null… (authored by RKSimon).
BlockInCriticalSectionChecker - silence static analyzer dyn_cast null…
Sun, Oct 13, 4:35 AM
RKSimon accepted D68550: [X86] Teach X86MCInstLower to swap operands of commutable instructions to enable 2-byte VEX encoding..

LGTM with one minor query.

Sun, Oct 13, 4:35 AM · Restricted Project
RKSimon accepted D68871: [X86][BtVer2] Improved latency and throughput of float/vector loads and stores..

LGTM - thanks for looking into this

Sun, Oct 13, 4:35 AM · Restricted Project
RKSimon committed rG944a051ebbdd: IRTranslator - silence static analyzer null dereference warnings. NFCI. (authored by RKSimon).
IRTranslator - silence static analyzer null dereference warnings. NFCI.
Sun, Oct 13, 4:28 AM
RKSimon committed rL374717: BlockInCriticalSectionChecker - silence static analyzer dyn_cast null….
BlockInCriticalSectionChecker - silence static analyzer dyn_cast null…
Sun, Oct 13, 4:28 AM
RKSimon committed rL374716: IRTranslator - silence static analyzer null dereference warnings. NFCI..
IRTranslator - silence static analyzer null dereference warnings. NFCI.
Sun, Oct 13, 4:28 AM

Sat, Oct 12

RKSimon committed rG671651267039: [X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings (authored by RKSimon).
[X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings
Sat, Oct 12, 11:40 AM
RKSimon committed rL374674: [X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings.
[X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings
Sat, Oct 12, 11:31 AM
RKSimon committed rG5f2543f8dc09: SymbolRecord - consistently use explicit for single operand constructors (authored by RKSimon).
SymbolRecord - consistently use explicit for single operand constructors
Sat, Oct 12, 10:54 AM
RKSimon committed rG936c6b57be16: SymbolRecord - fix uninitialized variable warnings. NFCI. (authored by RKSimon).
SymbolRecord - fix uninitialized variable warnings. NFCI.
Sat, Oct 12, 10:54 AM
RKSimon committed rL374672: SymbolRecord - fix uninitialized variable warnings. NFCI..
SymbolRecord - fix uninitialized variable warnings. NFCI.
Sat, Oct 12, 10:54 AM
RKSimon committed rL374673: SymbolRecord - consistently use explicit for single operand constructors.
SymbolRecord - consistently use explicit for single operand constructors
Sat, Oct 12, 10:54 AM
RKSimon committed rG66417a9f036d: Replace for-loop of SmallVector::push_back with SmallVector::append. NFCI. (authored by RKSimon).
Replace for-loop of SmallVector::push_back with SmallVector::append. NFCI.
Sat, Oct 12, 9:42 AM
RKSimon committed rG37041c7d2266: Fix cppcheck shadow variable name warnings. NFCI. (authored by RKSimon).
Fix cppcheck shadow variable name warnings. NFCI.
Sat, Oct 12, 9:41 AM
RKSimon committed rG6446079add80: [X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. NFCI. (authored by RKSimon).
[X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. NFCI.
Sat, Oct 12, 9:41 AM
RKSimon committed rL374669: Replace for-loop of SmallVector::push_back with SmallVector::append. NFCI..
Replace for-loop of SmallVector::push_back with SmallVector::append. NFCI.
Sat, Oct 12, 9:41 AM
RKSimon committed rL374668: Fix cppcheck shadow variable name warnings. NFCI..
Fix cppcheck shadow variable name warnings. NFCI.
Sat, Oct 12, 9:41 AM
RKSimon committed rL374667: [X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. NFCI..
[X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. NFCI.
Sat, Oct 12, 9:41 AM
RKSimon committed rG9f0885d38d82: [X86][SSE] Avoid unnecessary PMOVZX in v4i8 sum reduction (authored by RKSimon).
[X86][SSE] Avoid unnecessary PMOVZX in v4i8 sum reduction
Sat, Oct 12, 8:19 AM
RKSimon committed rL374658: [X86][SSE] Avoid unnecessary PMOVZX in v4i8 sum reduction.
[X86][SSE] Avoid unnecessary PMOVZX in v4i8 sum reduction
Sat, Oct 12, 8:19 AM
RKSimon planned changes to D66004: [WIP][X86][SSE] SimplifyDemandedVectorEltsForTargetNode - add general shuffle combining support.

WIP - PR27854 and PR43024 need to be finished first.

Sat, Oct 12, 8:19 AM · Restricted Project
RKSimon committed rG1b59a16c0b8b: [CostModel][X86] Improve sum reduction costs. (authored by RKSimon).
[CostModel][X86] Improve sum reduction costs.
Sat, Oct 12, 6:21 AM
RKSimon committed rL374655: [CostModel][X86] Improve sum reduction costs..
[CostModel][X86] Improve sum reduction costs.
Sat, Oct 12, 6:21 AM

Fri, Oct 11

RKSimon committed rGaf6c15f67916: [X86][SSE] Add support for v4i8 add reduction (authored by RKSimon).
[X86][SSE] Add support for v4i8 add reduction
Fri, Oct 11, 10:53 AM
RKSimon committed rL374579: [X86][SSE] Add support for v4i8 add reduction.
[X86][SSE] Add support for v4i8 add reduction
Fri, Oct 11, 10:52 AM
RKSimon committed rG6434eac86086: [X86] isFNEG - add recursion depth limit (authored by RKSimon).
[X86] isFNEG - add recursion depth limit
Fri, Oct 11, 4:41 AM
RKSimon committed rL374534: [X86] isFNEG - add recursion depth limit.
[X86] isFNEG - add recursion depth limit
Fri, Oct 11, 4:38 AM

Thu, Oct 10

RKSimon accepted D68763: [X86] Use packusdw+vpmovuswb to implement v16i32->V16i8 that clamps signed inputs to be between 0 and 255 when zmm registers are disabled on SKX..

LGTM

Thu, Oct 10, 11:22 AM · Restricted Project
RKSimon committed rGf7aee61be208: Fix Wdocumentation warnings. NFCI. (authored by RKSimon).
Fix Wdocumentation warnings. NFCI.
Thu, Oct 10, 8:31 AM
RKSimon committed rL374364: Fix Wdocumentation warnings. NFCI..
Fix Wdocumentation warnings. NFCI.
Thu, Oct 10, 8:23 AM
RKSimon added a comment to D68729: [AMDGPU] Fixed dpp combine of VOP1.

@rampitec This is breaking on EXPENSIVE_CHECKS builds please can you take a look?

Thu, Oct 10, 8:03 AM · Restricted Project
RKSimon added a comment to D68632: [X86] Make memcmp() use PTEST if possible and also enable AVX1.

In general we don't use auto for anything other than casts or iterators - see the llvm coding style guidelines

Thu, Oct 10, 7:35 AM · Restricted Project
RKSimon committed rG6a38474f77bb: [X86] combineFMA - Convert to use isNegatibleForFree/GetNegatedExpression. (authored by RKSimon).
[X86] combineFMA - Convert to use isNegatibleForFree/GetNegatedExpression.
Thu, Oct 10, 7:16 AM
RKSimon committed rGfdc0917b463d: Fix OCaml/core.ml fneg check (try 2) (authored by RKSimon).
Fix OCaml/core.ml fneg check (try 2)
Thu, Oct 10, 7:16 AM
RKSimon committed rL374356: [X86] combineFMA - Convert to use isNegatibleForFree/GetNegatedExpression..
[X86] combineFMA - Convert to use isNegatibleForFree/GetNegatedExpression.
Thu, Oct 10, 7:16 AM
RKSimon committed rL374355: Fix OCaml/core.ml fneg check (try 2).
Fix OCaml/core.ml fneg check (try 2)
Thu, Oct 10, 7:16 AM
RKSimon committed rGf096443a9812: [X86] combineFMADDSUB - Convert to use isNegatibleForFree/GetNegatedExpression. (authored by RKSimon).
[X86] combineFMADDSUB - Convert to use isNegatibleForFree/GetNegatedExpression.
Thu, Oct 10, 6:48 AM
RKSimon committed rL374351: [X86] combineFMADDSUB - Convert to use isNegatibleForFree/GetNegatedExpression..
[X86] combineFMADDSUB - Convert to use isNegatibleForFree/GetNegatedExpression.
Thu, Oct 10, 6:47 AM
RKSimon committed rGfbf8b0bc0def: Fix OCaml/core.ml fneg check (authored by RKSimon).
Fix OCaml/core.ml fneg check
Thu, Oct 10, 6:29 AM
RKSimon committed rG08c2f530ec0b: [DAG][X86] Add isNegatibleForFree/GetNegatedExpression override placeholders. (authored by RKSimon).
[DAG][X86] Add isNegatibleForFree/GetNegatedExpression override placeholders.
Thu, Oct 10, 6:29 AM
RKSimon committed rL374346: Fix OCaml/core.ml fneg check.
Fix OCaml/core.ml fneg check
Thu, Oct 10, 6:29 AM
RKSimon committed rL374345: [DAG][X86] Add isNegatibleForFree/GetNegatedExpression override placeholders..
[DAG][X86] Add isNegatibleForFree/GetNegatedExpression override placeholders.
Thu, Oct 10, 6:29 AM
RKSimon committed rG788ba1511327: Fix -Wparentheses warning. NFCI. (authored by RKSimon).
Fix -Wparentheses warning. NFCI.
Thu, Oct 10, 5:23 AM
RKSimon committed rL374326: Fix -Wparentheses warning. NFCI..
Fix -Wparentheses warning. NFCI.
Thu, Oct 10, 5:23 AM
RKSimon added a comment to D68686: [X86] Model MXCSR for [v]add|sub|mul|div* instructions.
In D68686#1702898, @pengfei wrote:

Separate strict node handling from former patch. This patch only models MXCSR.

Thu, Oct 10, 2:40 AM · Restricted Project

Wed, Oct 9

RKSimon committed rG604b7c22beb4: Fix Wdocumentation unknown parameter warning. NFCI. (authored by RKSimon).
Fix Wdocumentation unknown parameter warning. NFCI.
Wed, Oct 9, 7:30 AM
RKSimon committed rL374171: Fix Wdocumentation unknown parameter warning. NFCI..
Fix Wdocumentation unknown parameter warning. NFCI.
Wed, Oct 9, 7:30 AM
RKSimon committed rGd7ac2553257f: [CostModel][X86] Add tests for insertelement to non-immediate vector element… (authored by RKSimon).
[CostModel][X86] Add tests for insertelement to non-immediate vector element…
Wed, Oct 9, 5:40 AM
RKSimon committed rGa21176ffb1db: [CostModel][X86] Add tests for extractelement from non-immediate vector element… (authored by RKSimon).
[CostModel][X86] Add tests for extractelement from non-immediate vector element…
Wed, Oct 9, 5:35 AM
RKSimon committed rL374161: [CostModel][X86] Add tests for insertelement to non-immediate vector element….
[CostModel][X86] Add tests for insertelement to non-immediate vector element…
Wed, Oct 9, 5:35 AM
RKSimon committed rL374160: [CostModel][X86] Add tests for extractelement from non-immediate vector element….
[CostModel][X86] Add tests for extractelement from non-immediate vector element…
Wed, Oct 9, 5:35 AM
RKSimon added a comment to D68390: [Mips] Emit proper ABI for _mcount calls.

@mbrkusanin This is causing failures on EXPENSIVE_CHECKS builds, please can you take a look?

Wed, Oct 9, 5:22 AM · Restricted Project

Tue, Oct 8

RKSimon added reviewers for D68632: [X86] Make memcmp() use PTEST if possible and also enable AVX1: spatel, RKSimon.
Tue, Oct 8, 2:52 PM · Restricted Project
RKSimon committed rGe746380f6a19: CodeGenPrepare - silence static analyzer dyn_cast<> null dereference warnings. (authored by RKSimon).
CodeGenPrepare - silence static analyzer dyn_cast<> null dereference warnings.
Tue, Oct 8, 10:07 AM
RKSimon committed rL374085: CodeGenPrepare - silence static analyzer dyn_cast<> null dereference warnings..
CodeGenPrepare - silence static analyzer dyn_cast<> null dereference warnings.
Tue, Oct 8, 9:58 AM

Mon, Oct 7

RKSimon committed rG7e38f0c40805: Codegen - silence static analyzer getAs<> null dereference warnings. NFCI. (authored by RKSimon).
Codegen - silence static analyzer getAs<> null dereference warnings. NFCI.
Mon, Oct 7, 10:15 PM
RKSimon committed rL373918: Codegen - silence static analyzer getAs<> null dereference warnings. NFCI..
Codegen - silence static analyzer getAs<> null dereference warnings. NFCI.
Mon, Oct 7, 10:15 PM
RKSimon committed rG9c2e12304388: [X86][SSE] getTargetShuffleInputs - move VT.isSimple/isVector checks inside. (authored by RKSimon).
[X86][SSE] getTargetShuffleInputs - move VT.isSimple/isVector checks inside.
Mon, Oct 7, 10:15 PM
RKSimon committed rL373915: [X86][SSE] getTargetShuffleInputs - move VT.isSimple/isVector checks inside..
[X86][SSE] getTargetShuffleInputs - move VT.isSimple/isVector checks inside.
Mon, Oct 7, 10:14 PM
RKSimon committed rGdc4d908d6ebd: Sema - silence static analyzer getAs<> null dereference warnings. NFCI. (authored by RKSimon).
Sema - silence static analyzer getAs<> null dereference warnings. NFCI.
Mon, Oct 7, 10:14 PM
RKSimon committed rL373911: Sema - silence static analyzer getAs<> null dereference warnings. NFCI..
Sema - silence static analyzer getAs<> null dereference warnings. NFCI.
Mon, Oct 7, 10:14 PM
RKSimon committed rG8dc1700979bc: RewriteModernObjC - silence static analyzer getAs<> null dereference warnings. (authored by RKSimon).
RewriteModernObjC - silence static analyzer getAs<> null dereference warnings.
Mon, Oct 7, 10:14 PM
RKSimon committed rG3459a4c770ba: AST - silence static analyzer getAs<> null dereference warnings. NFCI. (authored by RKSimon).
AST - silence static analyzer getAs<> null dereference warnings. NFCI.
Mon, Oct 7, 10:14 PM
RKSimon committed rL373905: RewriteModernObjC - silence static analyzer getAs<> null dereference warnings..
RewriteModernObjC - silence static analyzer getAs<> null dereference warnings.
Mon, Oct 7, 10:13 PM
RKSimon committed rL373904: AST - silence static analyzer getAs<> null dereference warnings. NFCI..
AST - silence static analyzer getAs<> null dereference warnings. NFCI.
Mon, Oct 7, 10:13 PM
RKSimon requested changes to D46814: [InstCombine] Fold unfolded masked merge pattern with variable mask!.
Mon, Oct 7, 6:11 AM · Restricted Project
RKSimon requested changes to D30471: [SDAG] Relax conditions under stores of loaded values can be merged.
Mon, Oct 7, 6:10 AM · Restricted Project
RKSimon reopened D30471: [SDAG] Relax conditions under stores of loaded values can be merged.
Mon, Oct 7, 6:10 AM · Restricted Project
RKSimon reopened D36130: [SLP] Vectorize jumbled memory loads..
Mon, Oct 7, 6:08 AM · Restricted Project
RKSimon requested changes to D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..
Mon, Oct 7, 6:07 AM · Restricted Project
RKSimon reopened D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..

reopening - phab seems to be a bit broken

Mon, Oct 7, 6:07 AM · Restricted Project
RKSimon requested changes to D67841: [SLP] avoid reduction transform on patterns that the backend can load-combine.
Mon, Oct 7, 2:51 AM · Restricted Project
RKSimon reopened D67841: [SLP] avoid reduction transform on patterns that the backend can load-combine.
Mon, Oct 7, 2:50 AM · Restricted Project

Sun, Oct 6

RKSimon committed rGb4ba3cbda01e: [X86][AVX] Access a scalar float/double as a free extract from a broadcast load… (authored by RKSimon).
[X86][AVX] Access a scalar float/double as a free extract from a broadcast load…
Sun, Oct 6, 2:11 PM
RKSimon committed rL373871: [X86][AVX] Access a scalar float/double as a free extract from a broadcast load….
[X86][AVX] Access a scalar float/double as a free extract from a broadcast load…
Sun, Oct 6, 2:10 PM
RKSimon closed D68544: [X86][AVX] Access a scalar float/double as a free extract from a broadcast load (PR43217).
Sun, Oct 6, 2:10 PM · Restricted Project
RKSimon committed rGd84cd7caa87e: Fix signed/unsigned warning. NFCI (authored by RKSimon).
Fix signed/unsigned warning. NFCI
Sun, Oct 6, 12:53 PM
RKSimon committed rL373870: Fix signed/unsigned warning. NFCI.
Fix signed/unsigned warning. NFCI
Sun, Oct 6, 12:52 PM
RKSimon committed rG739c9f0b7933: [X86][SSE] Remove resolveTargetShuffleInputs and use getTargetShuffleInputs… (authored by RKSimon).
[X86][SSE] Remove resolveTargetShuffleInputs and use getTargetShuffleInputs…
Sun, Oct 6, 12:06 PM
RKSimon committed rG42010dc8108f: [X86][SSE] Don't merge known undef/zero elements into target shuffle masks. (authored by RKSimon).
[X86][SSE] Don't merge known undef/zero elements into target shuffle masks.
Sun, Oct 6, 12:06 PM
RKSimon committed rL373868: [X86][SSE] Remove resolveTargetShuffleInputs and use getTargetShuffleInputs….
[X86][SSE] Remove resolveTargetShuffleInputs and use getTargetShuffleInputs…
Sun, Oct 6, 12:06 PM
RKSimon committed rL373867: [X86][SSE] Don't merge known undef/zero elements into target shuffle masks..
[X86][SSE] Don't merge known undef/zero elements into target shuffle masks.
Sun, Oct 6, 12:06 PM
RKSimon accepted D68428: [X86] Add custom type legalization for v16i64->v16i8 truncate and v8i64->v8i8 truncate when v8i64 isn't legal.

LGTM along with raising a bug about the VPERMI2B regression

Sun, Oct 6, 9:59 AM · Restricted Project
RKSimon committed rG5c876303ecdc: [X86][SSE] resolveTargetShuffleInputs - call getTargetShuffleInputs instead of… (authored by RKSimon).
[X86][SSE] resolveTargetShuffleInputs - call getTargetShuffleInputs instead of…
Sun, Oct 6, 8:42 AM