Page MenuHomePhabricator

RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (419 w, 3 d)

Recent Activity

Today

RKSimon added inline comments to D125987: [SLP] Account for cost of removing FMA opportunities by horizontal reduction.
Thu, May 19, 10:12 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125987: [SLP] Account for cost of removing FMA opportunities by horizontal reduction.

On what target are you seeing this problem?

Thu, May 19, 9:52 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

Probably pull out the frem.ll and frem-libcall.ll tests into their own phab for review first - frem-libcall.ll in particular doesn't show the current problem in trunk (it generates 4 fmodf calls atm).

Thu, May 19, 9:41 AM · Restricted Project, Restricted Project
RKSimon added reviewers for D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls: efriedma, spatel.
Thu, May 19, 9:37 AM · Restricted Project, Restricted Project
RKSimon added a reviewer for D125969: [InstCombine] Prevent the transform of the comparison for all undef elements: spatel.
Thu, May 19, 7:06 AM · Restricted Project, Restricted Project

Yesterday

RKSimon updated the diff for D125836: [DAG] Fold (srl (shl x, c1), c2) -> and(shl/srl(x, c3), m) (WIP).

rebase

Wed, May 18, 12:28 PM · Restricted Project, Restricted Project
RKSimon accepted D125641: [DAGCombiner] Fix bug in MatchBSwapHWordLow..

LGTM - cheers

Wed, May 18, 9:04 AM · Restricted Project, Restricted Project
RKSimon accepted D125220: [InstCombine] (rot X, ?) == 0/-1 --> X == 0/-1.

LGTM - cheers

Wed, May 18, 7:04 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D125604: [FileCheck] Catch missspelled directives..
Wed, May 18, 6:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
RKSimon committed rG4e198377f680: [X86] addcarry.ll - add nounwind to prevent cfi noise on tests (authored by RKSimon).
[X86] addcarry.ll - add nounwind to prevent cfi noise on tests
Wed, May 18, 5:34 AM · Restricted Project, Restricted Project
RKSimon committed rG939affc67d45: [AArch64] neon-vmull-high-p64.ll - fix name/check mismatch identified in D125604 (authored by RKSimon).
[AArch64] neon-vmull-high-p64.ll - fix name/check mismatch identified in D125604
Wed, May 18, 5:24 AM · Restricted Project, Restricted Project
RKSimon committed rG1584b2c74e4c: [AArch64] fp16-v8-instructions.ll - remove some old defunct CHECKS identified… (authored by RKSimon).
[AArch64] fp16-v8-instructions.ll - remove some old defunct CHECKS identified…
Wed, May 18, 4:49 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D125604: [FileCheck] Catch missspelled directives..
Wed, May 18, 4:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
RKSimon committed rGf718664866ab: [DebugInfo][X86] debug-info-template-parameter.ll - fix broken… (authored by RKSimon).
[DebugInfo][X86] debug-info-template-parameter.ll - fix broken…
Wed, May 18, 4:39 AM · Restricted Project, Restricted Project
RKSimon committed rGbf84ab7684a3: [X86] statepoint-vreg-details.ll - fix CHECK-VREG-LABEL typo identified in… (authored by RKSimon).
[X86] statepoint-vreg-details.ll - fix CHECK-VREG-LABEL typo identified in…
Wed, May 18, 4:34 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125604: [FileCheck] Catch missspelled directives..

Thanks @kosarev - CodeGen\X86 should be clean now!

Wed, May 18, 4:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
RKSimon committed rGec3bb17870a4: [X86] lvi-hardening-indirectbr.ll - fix X64-NOT typo identified in D125604 (authored by RKSimon).
[X86] lvi-hardening-indirectbr.ll - fix X64-NOT typo identified in D125604
Wed, May 18, 4:34 AM · Restricted Project, Restricted Project
RKSimon committed rG27942499ec20: [X86] copy-propagation.ll - fix CHECK-NEXT typo identified in D125604 (authored by RKSimon).
[X86] copy-propagation.ll - fix CHECK-NEXT typo identified in D125604
Wed, May 18, 4:34 AM · Restricted Project, Restricted Project
RKSimon committed rG5a0b7e875f16: [X86] coalesce-dead-lanes.mir - fix CHECK-LABEL typo identified in D125604 (authored by RKSimon).
[X86] coalesce-dead-lanes.mir - fix CHECK-LABEL typo identified in D125604
Wed, May 18, 4:34 AM · Restricted Project, Restricted Project
RKSimon committed rG3f7fc0964e82: [X86] Regenerate select-ext.ll test for D125604 (authored by RKSimon).
[X86] Regenerate select-ext.ll test for D125604
Wed, May 18, 4:27 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125750: [InstCombine] fold fake floating point vector extract to shift+trunc..

Testing more float types might be a good idea (bfloat / float / double / x86_fp80 / f128 / ppc_f128), even of they're negative tests - not sure how much the isDesirableIntType check is going to interfere?

Wed, May 18, 3:52 AM · Restricted Project, Restricted Project
RKSimon resigned from D83089: DomTree: Extract (mostly) read-only logic into type-erased base classes.
Wed, May 18, 3:45 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125712: [SLP][X86] Improve reordering to consider alternate instruction bundles.

Do you have many more examples of these patterns? If the addsub<->subadd pattern is the main problem it shouldn't take much to fix it later on in the backend

Wed, May 18, 3:44 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125755: [AggressiveInstcombine] Conditionally fold saturated fptosi to llvm.fptosi.sat.

OK - speaking to @spatel offline there was a concern that AIC was becoming a bit of a dumping ground for combines that didn't really fit anywhere else.

Wed, May 18, 3:40 AM · Restricted Project, Restricted Project
RKSimon accepted D125831: [DOC] Refactor Functions section in LangRef.

LGTM - cheers

Wed, May 18, 3:36 AM · Restricted Project, Restricted Project
RKSimon accepted D111574: [SLP]Improve reductions vectorization..

LGTM

Wed, May 18, 3:35 AM · Restricted Project, Restricted Project
RKSimon accepted D125857: [InstCombine] [NFC] Use a pattern matcher for ExtractElementInst..

LGTM

Wed, May 18, 3:17 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D125861: [M68k][Disassembler] Fix decoding conflict.
Wed, May 18, 1:46 AM · Restricted Project, Restricted Project

Tue, May 17

RKSimon requested review of D125836: [DAG] Fold (srl (shl x, c1), c2) -> and(shl/srl(x, c3), m) (WIP).
Tue, May 17, 2:18 PM · Restricted Project, Restricted Project
RKSimon committed rG320545b57777: [X86] Rename combineCONCAT_VECTORS\INSERT_SUBVECTOR\EXTRACT_SUBVECTOR to match… (authored by RKSimon).
[X86] Rename combineCONCAT_VECTORS\INSERT_SUBVECTOR\EXTRACT_SUBVECTOR to match…
Tue, May 17, 10:38 AM · Restricted Project, Restricted Project
RKSimon committed rGd40b7f0d5aec: [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses (authored by RKSimon).
[DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses
Tue, May 17, 5:40 AM · Restricted Project, Restricted Project
RKSimon closed D125607: [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses.
Tue, May 17, 5:40 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125755: [AggressiveInstcombine] Conditionally fold saturated fptosi to llvm.fptosi.sat.

Are you needing the fp sat intrinsic to be visible in IR (better vectorization?) - otherwise might this be better off in CGP?

Tue, May 17, 4:18 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125607: [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses.

Do you know what makes the AArch64::shouldFoldConstantShiftPairToMask necessary? Is it just something about those tests, or something fundamental to the architecture?

Tue, May 17, 3:51 AM · Restricted Project, Restricted Project
RKSimon committed rGc64f5d44ad3b: [X86] Attempt to fold EFLAGS into X86ISD::ADD/SUB ops (authored by RKSimon).
[X86] Attempt to fold EFLAGS into X86ISD::ADD/SUB ops
Tue, May 17, 3:00 AM · Restricted Project, Restricted Project
RKSimon closed D125642: [X86] Attempt to fold EFLAGS into X86ISD::ADD/SUB ops.
Tue, May 17, 2:59 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125607: [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses.

@foad @dmgreen Any objections to the AMDGPU / ARM changes?

Tue, May 17, 2:37 AM · Restricted Project, Restricted Project

Mon, May 16

RKSimon added a comment to D116072: [X86] GLC: Break false dependency for dest register for several instructions..

Will this make it into 14.x ?

Mon, May 16, 9:58 AM · Restricted Project, Restricted Project
RKSimon committed rG3cc2c7deed5b: [polly] Remove 'using namespace llvm/polly' from ScopGraphPrinter.h header. (authored by RKSimon).
[polly] Remove 'using namespace llvm/polly' from ScopGraphPrinter.h header.
Mon, May 16, 8:19 AM · Restricted Project
RKSimon added inline comments to D125527: [CostModel][X86] getScalarizationOverhead - improve extraction costs for > 128-bit vectors.
Mon, May 16, 8:04 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D123678: [polly] migrate -polly-show to the new pass manager.
Mon, May 16, 7:32 AM · Restricted Project, Restricted Project
RKSimon requested changes to D125220: [InstCombine] (rot X, ?) == 0/-1 --> X == 0/-1.

Not sure if this patch will be abandoned or refactored after D125457

Mon, May 16, 4:11 AM · Restricted Project, Restricted Project
RKSimon accepted D125638: [TargetLowering] Expand the last stage of i16 popcnt using shift+add+and instead of mul+shift..

LGTM

Mon, May 16, 4:06 AM · Restricted Project, Restricted Project
RKSimon committed rGfab5c853ff78: [X86][AVX] Add test showing poor expansion of bit-reversal permutation shuffles (authored by RKSimon).
[X86][AVX] Add test showing poor expansion of bit-reversal permutation shuffles
Mon, May 16, 3:24 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D125641: [DAGCombiner] Fix bug in MatchBSwapHWordLow..
Mon, May 16, 3:01 AM · Restricted Project, Restricted Project
RKSimon requested review of D125642: [X86] Attempt to fold EFLAGS into X86ISD::ADD/SUB ops.
Mon, May 16, 2:48 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D125642: [X86] Attempt to fold EFLAGS into X86ISD::ADD/SUB ops.

Restrict ADC/SBB folds to cases where the second op will be zero.

Mon, May 16, 2:47 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125642: [X86] Attempt to fold EFLAGS into X86ISD::ADD/SUB ops.

I can initially limit this to cases that create SBB $0, %REG patterns if you think it safer?

Mon, May 16, 1:02 AM · Restricted Project, Restricted Project

Sun, May 15

RKSimon requested review of D125642: [X86] Attempt to fold EFLAGS into X86ISD::ADD/SUB ops.
Sun, May 15, 2:10 PM · Restricted Project, Restricted Project
RKSimon committed rGb3077f563d9f: [X86] Move combineAddOrSubToADCOrSBB earlier. NFC. (authored by RKSimon).
[X86] Move combineAddOrSubToADCOrSBB earlier. NFC.
Sun, May 15, 2:07 PM · Restricted Project, Restricted Project
RKSimon committed rG896557e129c2: [X86] Adjust fadd costs to match SoG (authored by RKSimon).
[X86] Adjust fadd costs to match SoG
Sun, May 15, 1:28 PM · Restricted Project, Restricted Project
RKSimon added a comment to D120960: [M68k][Disassembler] Adopt the new variable length decoder.

@0x59616e I'm seeing several "Decoding Conflict" warnings in M68k builds - e.g.:

Decoding Conflict:
                ................................................................0010...001010...
                ................................................................0010...00.010...
                ................................................................0010...00.01....
                ................................................................0010......01....
                ................................................................0010............
                ................................................................................
        MOV32aj 0010___001010___
        MOV32aj_TC 0010___001010___
Sun, May 15, 12:38 PM · Restricted Project, Restricted Project
RKSimon committed rG6bf8133f9f34: [X86] Add test coverage for PR44915 / Issue #44260 (authored by RKSimon).
[X86] Add test coverage for PR44915 / Issue #44260
Sun, May 15, 9:05 AM · Restricted Project, Restricted Project
RKSimon committed rG9b44b0318e7d: [X86] Add checks to illegal-insert.ll (authored by RKSimon).
[X86] Add checks to illegal-insert.ll
Sun, May 15, 8:58 AM · Restricted Project, Restricted Project
RKSimon committed rGfd1f0c51ef7f: [X86] lowerShuffleAsLanePermuteAndSHUFP always succeeds, so just return the… (authored by RKSimon).
[X86] lowerShuffleAsLanePermuteAndSHUFP always succeeds, so just return the…
Sun, May 15, 7:54 AM · Restricted Project, Restricted Project
RKSimon committed rGc0f59be35849: [X86] Pull out repeated isShuffleMaskInputInPlace calls. NFC. (authored by RKSimon).
[X86] Pull out repeated isShuffleMaskInputInPlace calls. NFC.
Sun, May 15, 7:35 AM · Restricted Project, Restricted Project
RKSimon committed rG32162cf291d4: [X86] lowerV4I64Shuffle - try harder to lower to PERMQ(BLENDD(V1,V2)) pattern (authored by RKSimon).
[X86] lowerV4I64Shuffle - try harder to lower to PERMQ(BLENDD(V1,V2)) pattern
Sun, May 15, 6:58 AM · Restricted Project, Restricted Project
RKSimon committed rGdf5ea2b12d48: [X86] Add shuffles showing failure to use PERMUTE(BLEND(X,Y)) (authored by RKSimon).
[X86] Add shuffles showing failure to use PERMUTE(BLEND(X,Y))
Sun, May 15, 6:32 AM · Restricted Project, Restricted Project
RKSimon committed rG019fa346b99c: [X86] Adjust tests for vector widening to use freeze(poison) (authored by RKSimon).
[X86] Adjust tests for vector widening to use freeze(poison)
Sun, May 15, 5:03 AM · Restricted Project, Restricted Project
RKSimon committed rGf66596c94f77: [clang][docs] Add escape code to fix missing '*' in reduction operation list (authored by RKSimon).
[clang][docs] Add escape code to fix missing '*' in reduction operation list
Sun, May 15, 4:32 AM · Restricted Project, Restricted Project

Sat, May 14

RKSimon committed rG6e8ad984469b: [AMDGPU] Fix typo in cttz_zero_undef(x) -> cttz(x) fold test (authored by RKSimon).
[AMDGPU] Fix typo in cttz_zero_undef(x) -> cttz(x) fold test
Sat, May 14, 12:52 PM · Restricted Project, Restricted Project
RKSimon closed D125612: [AMDGPU] Fix typo in cttz_zero_undef(x) -> cttz(x) fold test.
Sat, May 14, 12:52 PM · Restricted Project, Restricted Project
RKSimon committed rGf4eac6e5f66d: [DAG] visitOR - merge isa/cast<ShuffleVectorSDNode> into… (authored by RKSimon).
[DAG] visitOR - merge isa/cast<ShuffleVectorSDNode> into…
Sat, May 14, 12:50 PM · Restricted Project, Restricted Project
RKSimon requested review of D125612: [AMDGPU] Fix typo in cttz_zero_undef(x) -> cttz(x) fold test.
Sat, May 14, 11:25 AM · Restricted Project, Restricted Project
RKSimon committed rG95cdd63b8702: [DAG] visitADDLike - use SelectionDAG::FoldConstantArithmetic directly to match… (authored by RKSimon).
[DAG] visitADDLike - use SelectionDAG::FoldConstantArithmetic directly to match…
Sat, May 14, 10:40 AM · Restricted Project, Restricted Project
RKSimon committed rGbc90bbb75904: [X86] LowerAVG - fix cut+paste typo. NFC. (authored by RKSimon).
[X86] LowerAVG - fix cut+paste typo. NFC.
Sat, May 14, 9:42 AM · Restricted Project, Restricted Project
RKSimon retitled D125607: [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses from [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if x has other uses to [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses.
Sat, May 14, 9:02 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125256: [OpenMP] Add `__CUDA_ARCH__` definition when offloading with OpenMP.

Sorry - my mistake - its a different test failure now!

Sat, May 14, 8:59 AM · Restricted Project, Restricted Project
RKSimon added a comment to D125256: [OpenMP] Add `__CUDA_ARCH__` definition when offloading with OpenMP.

@jhuber6 I think this or one of your other openmp commits has caused the Driver/cuda-openmp-driver.cu test failure here: https://lab.llvm.org/buildbot/#/builders/214/builds/1274/steps/6/logs/stdio

Sat, May 14, 8:40 AM · Restricted Project, Restricted Project
RKSimon added a comment to D122233: [AggressiveInstCombine] Add `shufflevector` instr support to `TruncInstCombine`.

FWIW we might be able to perform something similar inside VectorCombine

Sat, May 14, 7:49 AM · Restricted Project, Restricted Project
RKSimon committed rG9cf17ac04a76: [X86] Add test showing failure to reuse the same PCMPGT comparison for… (authored by RKSimon).
[X86] Add test showing failure to reuse the same PCMPGT comparison for…
Sat, May 14, 7:48 AM · Restricted Project, Restricted Project
RKSimon committed rG8db72d9d0416: [DAG] visitMUL - pull out repeated SDLoc() calls. NFC. (authored by RKSimon).
[DAG] visitMUL - pull out repeated SDLoc() calls. NFC.
Sat, May 14, 6:29 AM · Restricted Project, Restricted Project
RKSimon committed rG8d4d4988e43e: [DAG] Use SelectionDAG::FoldConstantArithmetic directly to match constant… (authored by RKSimon).
[DAG] Use SelectionDAG::FoldConstantArithmetic directly to match constant…
Sat, May 14, 6:19 AM · Restricted Project, Restricted Project
RKSimon requested review of D125607: [DAG] Fold (shl (srl x, c), c) -> and(x, m) even if srl has other uses.
Sat, May 14, 6:12 AM · Restricted Project, Restricted Project
RKSimon committed rGffacaa0beccb: Fix unused function 'operator<<' -Wunused-function warning introduced in D124500 (authored by RKSimon).
Fix unused function 'operator<<' -Wunused-function warning introduced in D124500
Sat, May 14, 5:49 AM · Restricted Project, Restricted Project
RKSimon accepted D125581: [DOC] Improve LangRef description of declare.

LGTM - but maybe commit the define move seperately from the declare addition?

Sat, May 14, 5:29 AM · Restricted Project, Restricted Project
RKSimon committed rG0a1a318f3119: [ARM] Regenerate combine-movc-sub.ll test checks (authored by RKSimon).
[ARM] Regenerate combine-movc-sub.ll test checks
Sat, May 14, 5:27 AM · Restricted Project, Restricted Project
RKSimon committed rG15bc3f81bffa: [X86] rotate-extract-vector.ll - use avx512bw+avx512vl target for more useful… (authored by RKSimon).
[X86] rotate-extract-vector.ll - use avx512bw+avx512vl target for more useful…
Sat, May 14, 4:59 AM · Restricted Project, Restricted Project
RKSimon committed rG92eea11cca0d: [X86] Regenerate pull-binop-through-shift.ll showing stack address math (authored by RKSimon).
[X86] Regenerate pull-binop-through-shift.ll showing stack address math
Sat, May 14, 4:00 AM · Restricted Project, Restricted Project
RKSimon accepted D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..

LGTM

Sat, May 14, 2:40 AM · Restricted Project, Restricted Project
RKSimon added a comment to D124769: [SLP] AdjustExtractsCost - remove redundant subvector extraction code.

I'll come back to this - ideally we'd avoid handling the subvector cost adjustments in SLP and let getScalarizationOverhead deal with it.

I think this is possible, but need to reimplement the whole AdjustExtractsCost, need to use getScalarizationOverhead instead of getVectorInstrCostr.

Sat, May 14, 2:37 AM · Restricted Project, Restricted Project
RKSimon added a reviewer for D125527: [CostModel][X86] getScalarizationOverhead - improve extraction costs for > 128-bit vectors: ABataev.
Sat, May 14, 2:36 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D77804: [DAG] Enable ISD::SRL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits (WIP).
Sat, May 14, 2:22 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D77804: [DAG] Enable ISD::SRL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits (WIP).

Rebased after D124839 to just handle ISD::SRL shifts

Sat, May 14, 2:16 AM · Restricted Project, Restricted Project
RKSimon committed rG1ecc3d86ae3e: [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside… (authored by RKSimon).
[DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside…
Sat, May 14, 1:50 AM · Restricted Project, Restricted Project
RKSimon closed D124839: [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits.
Sat, May 14, 1:50 AM · Restricted Project, Restricted Project

Fri, May 13

RKSimon accepted D125571: [SLP]Do not vectorize non-profitable alternate nodes..

LGTM

Fri, May 13, 11:12 AM · Restricted Project, Restricted Project
RKSimon committed rG345ed58ed513: Fix implicit double -> float truncation warnings. NFCI. (authored by RKSimon).
Fix implicit double -> float truncation warnings. NFCI.
Fri, May 13, 11:07 AM · Restricted Project, Restricted Project
RKSimon committed rG3fc33ced10f2: DAGCombiner.cpp - break if-else chains that always return (style) (authored by RKSimon).
DAGCombiner.cpp - break if-else chains that always return (style)
Fri, May 13, 10:32 AM · Restricted Project, Restricted Project
RKSimon accepted D125459: [FastISel] Fix load folding for registers with fixups.

LGTM

Fri, May 13, 8:55 AM · Restricted Project, Restricted Project
RKSimon committed rG98f82d69bdef: [X86] LowerStore - use is64BitVector() wrapper. NFCI. (authored by RKSimon).
[X86] LowerStore - use is64BitVector() wrapper. NFCI.
Fri, May 13, 7:30 AM · Restricted Project, Restricted Project
RKSimon added a comment to D124980: [Mips] Implement hasDivRemOp().

It matches what we've done on X86 but I don't know if there's any reason MIPS has never added TTI support before? @sdardis might know the background.

Fri, May 13, 7:26 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D107966: [SLP]Do not emit extract elements for insertelements users, replace with shuffles directly..
Fri, May 13, 7:20 AM · Restricted Project, Restricted Project
RKSimon added a comment to D124839: [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits.

@craig.topper @dmgreen Any objections?

Fri, May 13, 6:47 AM · Restricted Project, Restricted Project
RKSimon committed rG5150d653aa04: [SLP][X86] Add common CHECK prefix to sub-128-bit vector tests (authored by RKSimon).
[SLP][X86] Add common CHECK prefix to sub-128-bit vector tests
Fri, May 13, 6:08 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D124284: [SLP]Try partial store vectorization if supported by target..
Fri, May 13, 5:31 AM · Restricted Project, Restricted Project
RKSimon committed rG1b07bd9034bd: [X86] Add tests for vector widening with freeze(undef) (authored by RKSimon).
[X86] Add tests for vector widening with freeze(undef)
Fri, May 13, 4:13 AM · Restricted Project, Restricted Project
RKSimon updated the summary of D124839: [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits.
Fri, May 13, 2:45 AM · Restricted Project, Restricted Project
RKSimon added a comment to D124839: [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits.

Cheers @foad I've tried to clear up the summary

Fri, May 13, 2:45 AM · Restricted Project, Restricted Project
RKSimon retitled D124839: [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits from [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling to [DAG] Enable ISD::SHL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits.
Fri, May 13, 2:44 AM · Restricted Project, Restricted Project