RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (206 w, 6 d)

Recent Activity

Today

RKSimon committed rL330546: [X86] Fix (completely overridden) WriteFHAdd/WritePHAdd classes to allow us to….
[X86] Fix (completely overridden) WriteFHAdd/WritePHAdd classes to allow us to…
Sun, Apr 22, 8:30 AM
RKSimon committed rL330545: [X86][MMX][SSE] Tag missed PHADD/PHSUB instructions with WritePHAdd .
[X86][MMX][SSE] Tag missed PHADD/PHSUB instructions with WritePHAdd
Sun, Apr 22, 8:05 AM
RKSimon committed rL330544: [X86] Remove unnecessary WriteFVarBlend/WriteVarBlend InstRW overrides..
[X86] Remove unnecessary WriteFVarBlend/WriteVarBlend InstRW overrides.
Sun, Apr 22, 7:46 AM
RKSimon created D45929: [X86] Add vector element insertion/extraction scheduler classes.
Sun, Apr 22, 5:51 AM
RKSimon committed rL330542: [X86] Fix WriteMPSAD/WritePSADBW values to allow us to remove unnecessary….
[X86] Fix WriteMPSAD/WritePSADBW values to allow us to remove unnecessary…
Sun, Apr 22, 3:44 AM
RKSimon committed rL330541: [X86][SandyBridge] Remove unnecessary WritePOPCNTLd overrides by fixing load….
[X86][SandyBridge] Remove unnecessary WritePOPCNTLd overrides by fixing load…
Sun, Apr 22, 3:07 AM
RKSimon committed rL330540: [llvm-mca][X86] Add POPCNT resource test.
[llvm-mca][X86] Add POPCNT resource test
Sun, Apr 22, 3:04 AM

Yesterday

RKSimon committed rL330527: [X86] Strip unnecessary prefetch + vector move/load instrw overrides from….
[X86] Strip unnecessary prefetch + vector move/load instrw overrides from…
Sat, Apr 21, 3:03 PM
RKSimon committed rL330525: [X86] Strip unnecessary WriteCvtF2I instrw overrides from scheduler models..
[X86] Strip unnecessary WriteCvtF2I instrw overrides from scheduler models.
Sat, Apr 21, 2:20 PM
RKSimon committed rL330523: [X86] Strip unnecessary broadcast/shuffle256 instrw overrides from scheduler….
[X86] Strip unnecessary broadcast/shuffle256 instrw overrides from scheduler…
Sat, Apr 21, 1:48 PM
RKSimon committed rL330522: [X86][AVX] VPERM2F128/VINSERTF128 should be a shuffle256 schedule like….
[X86][AVX] VPERM2F128/VINSERTF128 should be a shuffle256 schedule like…
Sat, Apr 21, 1:07 PM
RKSimon committed rL330521: [X86] Strip unnecessary vector integer math, shift-imm, extend, shuffle….
[X86] Strip unnecessary vector integer math, shift-imm, extend, shuffle…
Sat, Apr 21, 12:15 PM
RKSimon committed rL330514: [X86][Haswell] Strip unnecessary WriteFAdd/WriteFHAdd instruction instrw….
[X86][Haswell] Strip unnecessary WriteFAdd/WriteFHAdd instruction instrw…
Sat, Apr 21, 9:24 AM
RKSimon committed rL330513: [X86][Broadwell] Remove unnecessary VORPD/VORPS instrw override - missed in….
[X86][Broadwell] Remove unnecessary VORPD/VORPS instrw override - missed in…
Sat, Apr 21, 9:21 AM
RKSimon committed rL330512: [llvm-mca][X86] Add AVX2 resource tests.
[llvm-mca][X86] Add AVX2 resource tests
Sat, Apr 21, 9:16 AM
RKSimon committed rL330510: [X86] Strip unnecessary WriteFRcp/WriteFRsqrt instruction instrw overrides from….
[X86] Strip unnecessary WriteFRcp/WriteFRsqrt instruction instrw overrides from…
Sat, Apr 21, 8:20 AM
RKSimon committed rL330508: [X86] Strip unnecessary WriteFShuffle instruction instrw overrides from….
[X86] Strip unnecessary WriteFShuffle instruction instrw overrides from…
Sat, Apr 21, 8:00 AM
RKSimon committed rL330506: [llvm-mca][X86] Add SSE resource tests to all models.
[llvm-mca][X86] Add SSE resource tests to all models
Sat, Apr 21, 7:22 AM
RKSimon committed rL330505: [X86][SandyBridge] Strip unnecessary MOVQ/CVT instruction instrw overrides..
[X86][SandyBridge] Strip unnecessary MOVQ/CVT instruction instrw overrides.
Sat, Apr 21, 7:07 AM
RKSimon committed rL330503: [X86] Strip unnecessary MMX instruction instrw overrides from scheduler models..
[X86] Strip unnecessary MMX instruction instrw overrides from scheduler models.
Sat, Apr 21, 5:19 AM
RKSimon committed rL330502: [llvm-mca][X86] Add MMX resource tests.
[llvm-mca][X86] Add MMX resource tests
Sat, Apr 21, 4:34 AM
RKSimon committed rL330501: [X86] Strip unnecessary x87 instruction instrw overrides from scheduler models..
[X86] Strip unnecessary x87 instruction instrw overrides from scheduler models.
Sat, Apr 21, 4:30 AM
RKSimon committed rL330499: [llvm-mca][X86] Add X87 resource tests.
[llvm-mca][X86] Add X87 resource tests
Sat, Apr 21, 3:42 AM
RKSimon committed rL330498: [X86][X87] Add missing fldlg2 schedule test.
[X86][X87] Add missing fldlg2 schedule test
Sat, Apr 21, 3:39 AM

Fri, Apr 20

RKSimon committed rL330486: [llvm-mca][X86] Add MMX/SSE/AES/CLMUL resource SandyBridge tests.
[llvm-mca][X86] Add MMX/SSE/AES/CLMUL resource SandyBridge tests
Fri, Apr 20, 3:07 PM
RKSimon committed rL330480: [X86] Add WriteFSign/WriteFLogic scheduler classes.
[X86] Add WriteFSign/WriteFLogic scheduler classes
Fri, Apr 20, 2:20 PM
RKSimon closed D45629: [X86] Add FP logical scheduler class.
Fri, Apr 20, 2:20 PM
RKSimon added a comment to D44785: Lowering x86 adds/addus/subs/subus intrinsics (llvm part).

Does anyone have the IR that llvmpipe is creating?

Fri, Apr 20, 1:04 PM
RKSimon committed rL330439: [CostModel][X86] Add vector element insert/extract cost tests.
[CostModel][X86] Add vector element insert/extract cost tests
Fri, Apr 20, 8:30 AM
RKSimon committed rL330436: [CostModel][X86] Add srem/urem constant cost tests.
[CostModel][X86] Add srem/urem constant cost tests
Fri, Apr 20, 8:04 AM
RKSimon committed rL330435: [CostModel][X86] Add SLM/GLM/BtVer2 compare + division/remainder cost tests.
[CostModel][X86] Add SLM/GLM/BtVer2 compare + division/remainder cost tests
Fri, Apr 20, 7:55 AM
RKSimon committed rL330433: [CostModel][X86] Split off BtVer2 cost checks.
[CostModel][X86] Split off BtVer2 cost checks
Fri, Apr 20, 6:53 AM
RKSimon committed rL330432: [CostModel][X86] Add GoldmontPlus cost tests.
[CostModel][X86] Add GoldmontPlus cost tests
Fri, Apr 20, 6:46 AM
RKSimon committed rL330428: [X86][BtVer2] Cleanup some old FIXMEs from the model. NFCI..
[X86][BtVer2] Cleanup some old FIXMEs from the model. NFCI.
Fri, Apr 20, 6:15 AM
RKSimon committed rL330424: [X86] Tag CLDEMOTE instruction with WriteLoad scheduling class.
[X86] Tag CLDEMOTE instruction with WriteLoad scheduling class
Fri, Apr 20, 5:59 AM

Thu, Apr 19

RKSimon committed rL330371: [llvm-mca][X86] Add prefetch instruction resource tests.
[llvm-mca][X86] Add prefetch instruction resource tests
Thu, Apr 19, 3:17 PM
RKSimon committed rL330366: [llvm-mca][FMA] Add FMA resource tests.
[llvm-mca][FMA] Add FMA resource tests
Thu, Apr 19, 2:38 PM
RKSimon committed rL330352: [llvm-mca][X86] Add resource test for every out-of-order scheduler model.
[llvm-mca][X86] Add resource test for every out-of-order scheduler model
Thu, Apr 19, 11:12 AM
RKSimon committed rL330351: [X86][SLM] Fix typo using SandyBridge resources. .
[X86][SLM] Fix typo using SandyBridge resources.
Thu, Apr 19, 11:05 AM
RKSimon committed rL330347: [X86] Merge some MMX instregex.
[X86] Merge some MMX instregex
Thu, Apr 19, 10:35 AM
RKSimon committed rL330335: [llvm-mca][X86] Add mmx instruction to btver2 resource tests.
[llvm-mca][X86] Add mmx instruction to btver2 resource tests
Thu, Apr 19, 8:13 AM
RKSimon updated the diff for D45629: [X86] Add FP logical scheduler class.

Split off x87 fabs/fchs instructions into WriteFSign class as well

Thu, Apr 19, 8:01 AM
RKSimon committed rL330332: [X86][BtVer2] Remove SSE4A EXTRQ/EXTRQI InstRW overrides..
[X86][BtVer2] Remove SSE4A EXTRQ/EXTRQI InstRW overrides.
Thu, Apr 19, 7:42 AM
RKSimon committed rL330319: [X86][FMA] Remove FMA reg-reg InstRW scheduler overrides..
[X86][FMA] Remove FMA reg-reg InstRW scheduler overrides.
Thu, Apr 19, 4:41 AM
RKSimon committed rL330318: [X86][BtVer2] Remove 128-bit F16C InstRW overrides..
[X86][BtVer2] Remove 128-bit F16C InstRW overrides.
Thu, Apr 19, 4:20 AM
RKSimon added a comment to D45787: [llvm-exegesis] Fix PfmIssueCountersTable creation.

What's the more general plan for regression testing exegesis? It looks like the issue with pfm failing to match counters was a regression introduced by rL329675 due to the trailing commas. It would be nice to be able to have regression tests for this sort of thing, especially as it's under active development so the churn is likely to be quite high along with the risk of introducing regressions. I know it gets complicated due to the libpfm dependency and the fact it's CPU specific, but it should still be a solvable problem.

Thu, Apr 19, 4:14 AM
RKSimon committed rL330317: [llvm-exegesis] Fix PfmIssueCountersTable creation.
[llvm-exegesis] Fix PfmIssueCountersTable creation
Thu, Apr 19, 4:03 AM
RKSimon closed D45787: [llvm-exegesis] Fix PfmIssueCountersTable creation.
Thu, Apr 19, 4:03 AM

Wed, Apr 18

RKSimon added a comment to D45723: [X86] Lowering SAD (sum of absolute differences) intrinsics to native IR (LLVM side).

Don't remove the -fast-isel tests - they should be updated to test the generic codegen instead

Wed, Apr 18, 3:16 PM
RKSimon added a comment to D45721: [X86] Lowering PACK*S (pack with saturation) intrinsics to native IR (LLVM side).

Please can you update the sse2-intrinsics-fast-isel.ll etc. to use the same codegen as the clang builtins tests.

Wed, Apr 18, 3:15 PM
RKSimon created D45787: [llvm-exegesis] Fix PfmIssueCountersTable creation.
Wed, Apr 18, 2:01 PM
RKSimon committed rL330295: [llvm-mca][X86] Add mmx versions of SSSE3 instructions.
[llvm-mca][X86] Add mmx versions of SSSE3 instructions
Wed, Apr 18, 1:51 PM
RKSimon committed rL330263: [llvm-exegesis] Early out if the scheduler models have no extra info..
[llvm-exegesis] Early out if the scheduler models have no extra info.
Wed, Apr 18, 7:51 AM
RKSimon committed rL330260: [llvm-exegesis] Use LLVMTargetMachine pointer everywhere. NFCI..
[llvm-exegesis] Use LLVMTargetMachine pointer everywhere. NFCI.
Wed, Apr 18, 7:26 AM
RKSimon committed rL330258: [llvm-exegesis] Put a newline at the end of each error report..
[llvm-exegesis] Put a newline at the end of each error report.
Wed, Apr 18, 7:03 AM
RKSimon committed rL330255: [llvm-exegesis] Pull out LLVMTargetMachine to simplify debugging. NFCI..
[llvm-exegesis] Pull out LLVMTargetMachine to simplify debugging. NFCI.
Wed, Apr 18, 6:43 AM
RKSimon added a reviewer for D45720: [X86] Lowering PACK*S (pack with saturation) intrinsics to native IR (clang side): RKSimon.
Wed, Apr 18, 2:48 AM

Tue, Apr 17

RKSimon committed rL330179: [X86] Add FP comparison scheduler classes.
[X86] Add FP comparison scheduler classes
Tue, Apr 17, 12:26 AM
RKSimon closed D45656: [X86] Add FP comparison scheduler classes.
Tue, Apr 17, 12:26 AM

Sat, Apr 14

RKSimon created D45656: [X86] Add FP comparison scheduler classes.
Sat, Apr 14, 1:17 PM
RKSimon committed rL330085: [X86][MMX] Set PAVG/PHADD/PMIN/PMAX/PSIGN instructions to use same scheduler….
[X86][MMX] Set PAVG/PHADD/PMIN/PMAX/PSIGN instructions to use same scheduler…
Sat, Apr 14, 6:09 AM
RKSimon added a comment to D45651: [X86] Add DAG combine to turn (trunc (srl (mul ext, ext), 16) into PMULHW/PMULHUW..

This doesn't seem x86 specific - any reason not to include it in dagcombine?

Sat, Apr 14, 4:54 AM
RKSimon added reviewers for D45572: [X86] Replace action Promote with Custom for operation ISD::SINT_TO_FP: spatel, efriedma.
Sat, Apr 14, 4:45 AM
RKSimon added inline comments to D45315: [X86] Improve unsigned saturation downconvert detection..
Sat, Apr 14, 4:43 AM
RKSimon added inline comments to D45263: [SLP] Allow reordering of vectorization trees with reused instructions..
Sat, Apr 14, 4:39 AM

Fri, Apr 13

RKSimon committed rL330056: [CostModel][X86] Add some specific cpu targets to the cost models.
[CostModel][X86] Add some specific cpu targets to the cost models
Fri, Apr 13, 12:33 PM
RKSimon committed rL330054: [CostModel][X86] Split fma arith costs tests from other fp tests.
[CostModel][X86] Split fma arith costs tests from other fp tests
Fri, Apr 13, 12:17 PM
RKSimon committed rL330052: [CostModel][X86] Regenerate latency/codesize cost tests.
[CostModel][X86] Regenerate latency/codesize cost tests
Fri, Apr 13, 12:01 PM
RKSimon committed rL330051: [CostModel][X86] Regenerate cast conversion cost tests.
[CostModel][X86] Regenerate cast conversion cost tests
Fri, Apr 13, 12:01 PM
RKSimon committed rL330050: [CostModel][X86] Regenerate masked intrinsic cost tests.
[CostModel][X86] Regenerate masked intrinsic cost tests
Fri, Apr 13, 11:57 AM
RKSimon created D45629: [X86] Add FP logical scheduler class.
Fri, Apr 13, 10:14 AM
RKSimon accepted D45369: [UpdateTestChecks] Add update_mca_test_checks.py script.

LGTM - thanks Greg!

Fri, Apr 13, 9:51 AM
RKSimon committed rL330035: [X86] Remove remaining itinerary support from instructions and target (PR37093).
[X86] Remove remaining itinerary support from instructions and target (PR37093)
Fri, Apr 13, 8:41 AM
RKSimon committed rL330030: [X86] Generalize X86FixupLEAs to work with TargetSchedModel.
[X86] Generalize X86FixupLEAs to work with TargetSchedModel
Fri, Apr 13, 8:14 AM
RKSimon committed rL330025: Remove comment reference to itineraries. NFCI..
Remove comment reference to itineraries. NFCI.
Fri, Apr 13, 7:46 AM
RKSimon committed rL330023: [X86][AVX512] UNPCKL/H PS and PD should be scheduled with WriteFShuffle not….
[X86][AVX512] UNPCKL/H PS and PD should be scheduled with WriteFShuffle not…
Fri, Apr 13, 7:44 AM
RKSimon committed rL330022: [X86] Remove remaining OpndItins/SizeItins from all instruction defs (PR37093).
[X86] Remove remaining OpndItins/SizeItins from all instruction defs (PR37093)
Fri, Apr 13, 7:40 AM
RKSimon committed rL330021: Remove comment references to itineraries. NFCI..
Remove comment references to itineraries. NFCI.
Fri, Apr 13, 7:37 AM
RKSimon committed rL330019: Remove out of data comment. NFCI..
Remove out of data comment. NFCI.
Fri, Apr 13, 7:27 AM
RKSimon committed rL330013: [X86] Remove OpndItins/SizeItins from all sse instruction defs (PR37093).
[X86] Remove OpndItins/SizeItins from all sse instruction defs (PR37093)
Fri, Apr 13, 5:53 AM

Thu, Apr 12

RKSimon committed rL329970: [X86] Remove unused MoveLoadStoreItins/ShiftOpndItins schedule class wrappers..
[X86] Remove unused MoveLoadStoreItins/ShiftOpndItins schedule class wrappers.
Thu, Apr 12, 4:02 PM
RKSimon committed rL329967: [X86] Remove x86 InstrItinClass entries (PR37093).
[X86] Remove x86 InstrItinClass entries (PR37093)
Thu, Apr 12, 3:48 PM
RKSimon committed rL329953: [X86] Remove InstrItinClass entries from all x86 instruction defs (PR37093).
[X86] Remove InstrItinClass entries from all x86 instruction defs (PR37093)
Thu, Apr 12, 1:50 PM
RKSimon committed rL329945: [X86] Remove InstrItinClass entries from SSE/AVX instructions defs (PR37093).
[X86] Remove InstrItinClass entries from SSE/AVX instructions defs (PR37093)
Thu, Apr 12, 1:02 PM
RKSimon committed rL329940: [X86] Remove explicit SSE/AVX schedule itineraries from defs (PR37093).
[X86] Remove explicit SSE/AVX schedule itineraries from defs (PR37093)
Thu, Apr 12, 12:28 PM
RKSimon committed rL329938: [X86] Remove remaining gpr schedule itineraries (PR37093).
[X86] Remove remaining gpr schedule itineraries (PR37093)
Thu, Apr 12, 11:49 AM
RKSimon committed rL329933: [X86] Remove gpr shift/extension schedule itineraries (PR37093).
[X86] Remove gpr shift/extension schedule itineraries (PR37093)
Thu, Apr 12, 11:29 AM
RKSimon added a comment to D45369: [UpdateTestChecks] Add update_mca_test_checks.py script.

It would be great to use a python3 shebang. These utilities are independent from other (possibly Python 2 specific) Python files

% head -n 1 utils/update_cc_test_checks.py
#!/usr/bin/env python3
Thu, Apr 12, 11:23 AM
RKSimon committed rL329912: [X86] Remove AES/CLMUL/CRC32/LDDQU/MOVNT/POPCNT/SHA schedule itineraries….
[X86] Remove AES/CLMUL/CRC32/LDDQU/MOVNT/POPCNT/SHA schedule itineraries…
Thu, Apr 12, 7:35 AM
RKSimon committed rL329906: [X86] Remove remaining system/special schedule itineraries (PR37093).
[X86] Remove remaining system/special schedule itineraries (PR37093)
Thu, Apr 12, 5:46 AM
RKSimon committed rL329903: [X86] Remove system/control schedule itineraries (PR37093).
[X86] Remove system/control schedule itineraries (PR37093)
Thu, Apr 12, 5:12 AM
RKSimon committed rL329898: [X86] Remove CMOV/SETCC schedule itineraries (PR37093).
[X86] Remove CMOV/SETCC schedule itineraries (PR37093)
Thu, Apr 12, 4:04 AM
RKSimon committed rL329896: [X86] Remove MMX/3DNow schedule itineraries (PR37093).
[X86] Remove MMX/3DNow schedule itineraries (PR37093)
Thu, Apr 12, 3:53 AM
RKSimon committed rL329893: [X86] Remove X87 schedule itineraries (PR37093).
[X86] Remove X87 schedule itineraries (PR37093)
Thu, Apr 12, 3:30 AM

Wed, Apr 11

RKSimon committed rL329862: [X86] Remove unused itinerary argument from FMA3/FMA4/XOP instructions. NFCI..
[X86] Remove unused itinerary argument from FMA3/FMA4/XOP instructions. NFCI.
Wed, Apr 11, 4:27 PM
RKSimon committed rL329860: X86FoldTableEntry - avoid unnecessary std::string creation. NFCI..
X86FoldTableEntry - avoid unnecessary std::string creation. NFCI.
Wed, Apr 11, 4:13 PM
RKSimon committed rL329853: Don't repeatedly evaluate size() in the for loop. NFCI..
Don't repeatedly evaluate size() in the for loop. NFCI.
Wed, Apr 11, 3:27 PM
RKSimon committed rL329837: [X86][Atom] Convert Atom scheduler model to SchedRW (PR32431).
[X86][Atom] Convert Atom scheduler model to SchedRW (PR32431)
Wed, Apr 11, 11:26 AM
RKSimon committed rL329834: [X86] Generalize X86PadShortFunction to work with TargetSchedModel.
[X86] Generalize X86PadShortFunction to work with TargetSchedModel
Wed, Apr 11, 11:10 AM
RKSimon closed D45486: [X86][Atom] Convert Atom scheduler model to SchedRW (PR32431).
Wed, Apr 11, 11:10 AM