Page MenuHomePhabricator
People RKSimon

RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (333 w, 3 d)

Recent Activity
View All

Today

RKSimon added a comment to D87452: [InstCombine] matchRotate - support (uniform) constant rotation amounts (PR46895).

@nikic I've pulled (and fixed) the Local.cpp changes out to D88292 for review first.

Fri, Sep 25, 4:51 AM · Restricted Project
RKSimon requested review of D88292: [InstCombine] collectBitParts - add fshl/fshr handling.
Fri, Sep 25, 4:50 AM · Restricted Project
RKSimon committed rG852447650c75: [InstCombine] Add bswap tests from funnel shift intrinsics (authored by RKSimon).
[InstCombine] Add bswap tests from funnel shift intrinsics
Fri, Sep 25, 4:40 AM
RKSimon updated subscribers of rGe55410f8b260: AArch64/GlobalISel: Add testcase for bug 47619.

@arsenm I'm sorry but I had to revert this to fix EXPENSIVE_CHECKS builds: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/9244

Fri, Sep 25, 3:34 AM
RKSimon added a reverting change for rGe55410f8b260: AArch64/GlobalISel: Add testcase for bug 47619: rG42bfa7c63b85: Revert rGe55410f8b260 : "AArch64/GlobalISel: Add testcase for bug 47619".
Fri, Sep 25, 3:32 AM
RKSimon committed rG42bfa7c63b85: Revert rGe55410f8b260 : "AArch64/GlobalISel: Add testcase for bug 47619" (authored by RKSimon).
Revert rGe55410f8b260 : "AArch64/GlobalISel: Add testcase for bug 47619"
Fri, Sep 25, 3:32 AM
RKSimon updated the diff for D88225: [DAG] Fold vector mul(x,0)/mul(x,1) to a clearing mask.

Ensure the new zero/ones scalar type matches the existing type inside the BUILD_VECTOR.

Fri, Sep 25, 3:26 AM · Restricted Project

Yesterday

RKSimon committed rG81a408808f66: [Scalar] ConstantHoistingPass - iterate with const references. NFCI. (authored by RKSimon).
[Scalar] ConstantHoistingPass - iterate with const references. NFCI.
Thu, Sep 24, 10:41 AM
RKSimon committed rGbdd6af3a58d5: [AArch64] Regenerate dag-numsignbits.ll checks (authored by RKSimon).
[AArch64] Regenerate dag-numsignbits.ll checks
Thu, Sep 24, 10:41 AM
RKSimon requested review of D88225: [DAG] Fold vector mul(x,0)/mul(x,1) to a clearing mask.

reopening for aarch64 review

Thu, Sep 24, 8:31 AM · Restricted Project
RKSimon updated the diff for D88225: [DAG] Fold vector mul(x,0)/mul(x,1) to a clearing mask.

improve grokability

Thu, Sep 24, 8:31 AM · Restricted Project
RKSimon updated the diff for D87930: [DAG] Add BuildVectorSDNode::getRepeatedSequence helper to recognise multi-element splat patterns.

Rebase and improve getRepeatedSequence handling of undefs when matching the sequence

Thu, Sep 24, 8:27 AM · Restricted Project
RKSimon updated the diff for D88225: [DAG] Fold vector mul(x,0)/mul(x,1) to a clearing mask.

Add explicit SmallBitVector::reserve()

Thu, Sep 24, 7:56 AM · Restricted Project
RKSimon committed rG283036394ee6: [X86][SSE] combineVectorTruncation - enable (pre-SSSE3) vXi16->vXi8 truncation. (authored by RKSimon).
[X86][SSE] combineVectorTruncation - enable (pre-SSSE3) vXi16->vXi8 truncation.
Thu, Sep 24, 7:52 AM
RKSimon added a reviewer for D88190: C API: functions to get mask of a ShuffleVector: efriedma.
Thu, Sep 24, 7:16 AM · Restricted Project
RKSimon requested review of D88225: [DAG] Fold vector mul(x,0)/mul(x,1) to a clearing mask.
Thu, Sep 24, 6:16 AM · Restricted Project
RKSimon committed rGa815578c3177: [AArch64] Regenerate dag-combine-mul-shl.ll checks (authored by RKSimon).
[AArch64] Regenerate dag-combine-mul-shl.ll checks
Thu, Sep 24, 5:43 AM

Wed, Sep 23

RKSimon added inline comments to D84287: [SelectionDAG][GISel] Make LegalizeDAG lower FNEG using integer ops..
Wed, Sep 23, 1:18 PM · Restricted Project
RKSimon accepted D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target.

LGTM as well cheers

Wed, Sep 23, 1:17 PM · Restricted Project
RKSimon committed rG91589cf679c7: Add missing namespace closure comments. NFCI. (authored by RKSimon).
Add missing namespace closure comments. NFCI.
Wed, Sep 23, 8:20 AM
RKSimon committed rG474dc33d075a: Add missing namespace closure comment. NFCI. (authored by RKSimon).
Add missing namespace closure comment. NFCI.
Wed, Sep 23, 8:19 AM
RKSimon added inline comments to D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant..
Wed, Sep 23, 6:18 AM · Restricted Project
RKSimon added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Wed, Sep 23, 6:15 AM · Restricted Project
RKSimon added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Wed, Sep 23, 5:52 AM · Restricted Project
RKSimon added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Wed, Sep 23, 4:24 AM · Restricted Project
RKSimon accepted D88072: [X86] Improve demanded bits for X86ISD::BEXTR..

LGTM

Wed, Sep 23, 4:18 AM · Restricted Project
RKSimon accepted D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant..

LGTM with one minor

Wed, Sep 23, 4:17 AM · Restricted Project
RKSimon added inline comments to D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target.
Wed, Sep 23, 2:43 AM · Restricted Project
RKSimon resigned from D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.
Wed, Sep 23, 2:18 AM · Restricted Project, Restricted Project
RKSimon added a reviewer for D84287: [SelectionDAG][GISel] Make LegalizeDAG lower FNEG using integer ops.: spatel.

@arsenm Any more thoughts?

Wed, Sep 23, 2:17 AM · Restricted Project
RKSimon accepted D88132: [SLP] Make HorizontalReduction::getOperationData take an Instruction* instead of a Value*. NFCI.

LGTM

Wed, Sep 23, 2:02 AM · Restricted Project

Tue, Sep 22

RKSimon added a comment to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

some very minor style comments - a general comment would be to try and pre-commit the style/NFC refactor/cleanup changes so the size of this patch is smaller

Tue, Sep 22, 10:58 AM · Restricted Project
RKSimon added inline comments to D88072: [X86] Improve demanded bits for X86ISD::BEXTR..
Tue, Sep 22, 10:32 AM · Restricted Project
RKSimon committed rG4dada8d617d8: [DAG] Remove DAGTypeLegalizer::GenWidenVectorTruncStores (PR42046) (authored by RKSimon).
[DAG] Remove DAGTypeLegalizer::GenWidenVectorTruncStores (PR42046)
Tue, Sep 22, 9:25 AM
RKSimon closed D87708: [DAG] Remove DAGTypeLegalizer::GenWidenVectorTruncStores (PR42046).
Tue, Sep 22, 9:25 AM · Restricted Project
RKSimon added a reviewer for D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant.: RKSimon.

test case?

Tue, Sep 22, 7:48 AM · Restricted Project
RKSimon accepted D87884: [CostModel][X86] add CostModel for SK_Select(v8f64, v8i64, v16f32, v16i32, v32i16, v64i8).

LGTM with one minor

Tue, Sep 22, 7:32 AM · Restricted Project
RKSimon added inline comments to D88072: [X86] Improve demanded bits for X86ISD::BEXTR..
Tue, Sep 22, 7:19 AM · Restricted Project
RKSimon committed rG0793b45660a9: [X86] Add missing namespace closure comments. NFCI. (authored by RKSimon).
[X86] Add missing namespace closure comments. NFCI.
Tue, Sep 22, 7:07 AM
RKSimon committed rGaf712986488f: [X86] Cleanup/add namespace closure comments. NFCI. (authored by RKSimon).
[X86] Cleanup/add namespace closure comments. NFCI.
Tue, Sep 22, 7:07 AM
RKSimon committed rGd682a36ef9da: [SLP] Merge null and dyn_cast<> checks into dyn_cast_or_null<>. NFCI. (authored by RKSimon).
[SLP] Merge null and dyn_cast<> checks into dyn_cast_or_null<>. NFCI.
Tue, Sep 22, 6:02 AM
RKSimon added a reverting change for rGf835779160ec: [APFloat] multiplySignificand - always pass IEEEFloat as const reference. NFCI.: rGa15b42146c61: Revert rGf835779160ec303 "[APFloat] multiplySignificand - always pass IEEEFloat….
Tue, Sep 22, 4:16 AM
RKSimon committed rGa15b42146c61: Revert rGf835779160ec303 "[APFloat] multiplySignificand - always pass IEEEFloat… (authored by RKSimon).
Revert rGf835779160ec303 "[APFloat] multiplySignificand - always pass IEEEFloat…
Tue, Sep 22, 4:16 AM
RKSimon committed rGf835779160ec: [APFloat] multiplySignificand - always pass IEEEFloat as const reference. NFCI. (authored by RKSimon).
[APFloat] multiplySignificand - always pass IEEEFloat as const reference. NFCI.
Tue, Sep 22, 3:32 AM

Mon, Sep 21

RKSimon added a comment to D87912: [X86] Use shuffle to widen truncate of 128-bit and smaller vectors.

Sorry, I haven't had chance to look at this yet

Mon, Sep 21, 1:42 PM · Restricted Project
RKSimon added inline comments to D87806: [ObjCARC][NewPM] Port objc-arc-contract to NPM.
Mon, Sep 21, 10:33 AM · Restricted Project
RKSimon committed rG005f826a0546: [SLP] Use for-range loops across ValueLists. NFCI. (authored by RKSimon).
[SLP] Use for-range loops across ValueLists. NFCI.
Mon, Sep 21, 10:25 AM
RKSimon committed rG6a0ed57a2259: ImplicitNullChecks.cpp - use auto const& iterators in for-range loops to avoid… (authored by RKSimon).
ImplicitNullChecks.cpp - use auto const& iterators in for-range loops to avoid…
Mon, Sep 21, 9:44 AM
RKSimon committed rG3ae07b2a33f5: TargetPassConfig.cpp - use auto const& iterator in for-range loop to avoid… (authored by RKSimon).
TargetPassConfig.cpp - use auto const& iterator in for-range loop to avoid…
Mon, Sep 21, 9:21 AM
RKSimon committed rG3ddecfd22007: SLPVectorizer.cpp - fix include ordering. NFCI. (authored by RKSimon).
SLPVectorizer.cpp - fix include ordering. NFCI.
Mon, Sep 21, 9:21 AM
RKSimon committed rGce294ff8cddf: MachineCSE.cpp - use auto const& iterator in for-range loop to avoid copies. (authored by RKSimon).
MachineCSE.cpp - use auto const& iterator in for-range loop to avoid copies.
Mon, Sep 21, 8:56 AM
RKSimon committed rG604206b61cb9: Fix Wdocumentation unknown parameter warnings. NFCI. (authored by RKSimon).
Fix Wdocumentation unknown parameter warnings. NFCI.
Mon, Sep 21, 8:56 AM
RKSimon committed rG53f1748c131c: ProfileSummary.cpp - use auto const& iterator in for-range loop to avoid copies. (authored by RKSimon).
ProfileSummary.cpp - use auto const& iterator in for-range loop to avoid copies.
Mon, Sep 21, 8:56 AM
RKSimon added a comment to D87884: [CostModel][X86] add CostModel for SK_Select(v8f64, v8i64, v16f32, v16i32, v32i16, v64i8).

@yubing I've added shuffle-select.ll which should have better test coverage - please can you rebase and check?

Mon, Sep 21, 8:20 AM · Restricted Project
RKSimon committed rG18a3ebcd3016: [CostModel][X86] Add some select shuffle costs tests for D87884 (authored by RKSimon).
[CostModel][X86] Add some select shuffle costs tests for D87884
Mon, Sep 21, 8:10 AM
RKSimon committed rG2174efb10480: Update update_analyze_test_checks.py to support API changes from D83004 (authored by RKSimon).
Update update_analyze_test_checks.py to support API changes from D83004
Mon, Sep 21, 8:10 AM
RKSimon committed rG2ef2abdec20e: DWARFEmitter.cpp - use auto const& iterators in for-range loops to avoid copies. (authored by RKSimon).
DWARFEmitter.cpp - use auto const& iterators in for-range loops to avoid copies.
Mon, Sep 21, 7:33 AM
RKSimon committed rG82042a2c9b23: DWARFYAML::emitDebugSections - remove unnecessary cantFail(success) call. NFCI. (authored by RKSimon).
DWARFYAML::emitDebugSections - remove unnecessary cantFail(success) call. NFCI.
Mon, Sep 21, 6:07 AM

Sun, Sep 20

RKSimon committed rG0bfeede669f0: [X86][SSE] Fold EXTEND_VECTOR_INREG(EXTRACT_SUBVECTOR(EXTEND(X),0)) ->… (authored by RKSimon).
[X86][SSE] Fold EXTEND_VECTOR_INREG(EXTRACT_SUBVECTOR(EXTEND(X),0)) ->…
Sun, Sep 20, 11:58 AM
RKSimon committed rGbb0078e5911a: [X86][SSE] Fold SIGN_EXTEND(SIGN_EXTEND_VECTOR_INREG(X)) ->… (authored by RKSimon).
[X86][SSE] Fold SIGN_EXTEND(SIGN_EXTEND_VECTOR_INREG(X)) ->…
Sun, Sep 20, 11:58 AM
RKSimon accepted D87862: [X86] Stop reduceMaskedLoadToScalarLoad/reduceMaskedStoreToScalarStore from creating scalar i64 load/stores in 32-bit mode.

LGTM

Sun, Sep 20, 11:55 AM · Restricted Project
RKSimon added inline comments to rG6bb912336804: DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI..
Sun, Sep 20, 9:46 AM
RKSimon committed rG15c8306056be: [X86][SSE] Fold EXTEND_VECTOR_INREG(EXTEND_VECTOR_INREG(X)) ->… (authored by RKSimon).
[X86][SSE] Fold EXTEND_VECTOR_INREG(EXTEND_VECTOR_INREG(X)) ->…
Sun, Sep 20, 8:35 AM
RKSimon committed rGa0c8793ce691: [X86][SSE] Enable ZERO_EXTEND_VECTOR_INREG shuffle combining on SSE41 targets. (authored by RKSimon).
[X86][SSE] Enable ZERO_EXTEND_VECTOR_INREG shuffle combining on SSE41 targets.
Sun, Sep 20, 8:05 AM
RKSimon committed rG2b634a9d0e14: [X86] Rename getExtendInVec to getEXTEND_VECTOR_INREG. NFCI. (authored by RKSimon).
[X86] Rename getExtendInVec to getEXTEND_VECTOR_INREG. NFCI.
Sun, Sep 20, 7:22 AM
RKSimon committed rG6bb912336804: DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI. (authored by RKSimon).
DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI.
Sun, Sep 20, 7:22 AM
RKSimon accepted D87863: [X86] Make reduceMaskedLoadToScalarLoad/reduceMaskedStoreToScalarStore work for avx512 after type legalization..

LGTM

Sun, Sep 20, 6:27 AM · Restricted Project
RKSimon committed rG91720ee561b2: [X86] combineX86ShufflesRecursively - fix use after move warning. NFCI. (authored by RKSimon).
[X86] combineX86ShufflesRecursively - fix use after move warning. NFCI.
Sun, Sep 20, 6:18 AM
RKSimon committed rGa735d6eae284: JSONCompilationDatabase.cpp - cleanup key parsing error checks. NFCI. (authored by RKSimon).
JSONCompilationDatabase.cpp - cleanup key parsing error checks. NFCI.
Sun, Sep 20, 6:01 AM
RKSimon committed rGe17686ae60fa: [X86] Rename combineExtInVec to combineEXTEND_VECTOR_INREG. NFCI. (authored by RKSimon).
[X86] Rename combineExtInVec to combineEXTEND_VECTOR_INREG. NFCI.
Sun, Sep 20, 4:18 AM
RKSimon requested review of D87708: [DAG] Remove DAGTypeLegalizer::GenWidenVectorTruncStores (PR42046).
Sun, Sep 20, 3:20 AM · Restricted Project
RKSimon updated the diff for D87708: [DAG] Remove DAGTypeLegalizer::GenWidenVectorTruncStores (PR42046).

Replace GenWidenVectorTruncStores with scalarizeVectorStore

Sun, Sep 20, 3:19 AM · Restricted Project

Sat, Sep 19

RKSimon committed rG0c20d753d5fb: InstCombiner.h - remove unnecessary KnownBits forward declaration. NFCI. (authored by RKSimon).
InstCombiner.h - remove unnecessary KnownBits forward declaration. NFCI.
Sat, Sep 19, 5:00 AM
RKSimon added a comment to rG721d57f952ba: [X86] Return from SimplifyDemandedBitsForTargetNode after calculating known….

Nice catch - thanks @craig.topper

Sat, Sep 19, 1:34 AM

Fri, Sep 18

RKSimon planned changes to D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506).

WIP until reductions are no longer experimental

Fri, Sep 18, 2:34 PM · Restricted Project
RKSimon requested review of D87930: [DAG] Add BuildVectorSDNode::getRepeatedSequence helper to recognise multi-element splat patterns.
Fri, Sep 18, 12:23 PM · Restricted Project
RKSimon committed rG4ebd30722af5: [X86][AVX] lowerBuildVectorAsBroadcast - improve BROADCASTM lowering on non-VLX… (authored by RKSimon).
[X86][AVX] lowerBuildVectorAsBroadcast - improve BROADCASTM lowering on non-VLX…
Fri, Sep 18, 11:54 AM
RKSimon committed rGecba9d793e20: [X86][AVX] Add missing non AVX512VL broadcastm test coverage (authored by RKSimon).
[X86][AVX] Add missing non AVX512VL broadcastm test coverage
Fri, Sep 18, 11:12 AM
RKSimon committed rGceadd98c2fd5: [X86][AVX] lowerBuildVectorAsBroadcast - improve i64 BROADCASTM lowering on 32… (authored by RKSimon).
[X86][AVX] lowerBuildVectorAsBroadcast - improve i64 BROADCASTM lowering on 32…
Fri, Sep 18, 9:00 AM
RKSimon committed rG81dce71acfac: [X86][AVX] Add missing i686 broadcastm test coverage (authored by RKSimon).
[X86][AVX] Add missing i686 broadcastm test coverage
Fri, Sep 18, 8:21 AM
RKSimon committed rGd967aaa8fa80: [DAG] BuildVectorSDNode::getSplatValue - pull out repeated getNumOperands()… (authored by RKSimon).
[DAG] BuildVectorSDNode::getSplatValue - pull out repeated getNumOperands()…
Fri, Sep 18, 8:21 AM
RKSimon added a comment to D87884: [CostModel][X86] add CostModel for SK_Select(v8f64, v8i64, v16f32, v16i32, v32i16, v64i8).

Please pre-commit the new tests against trunk and rebase the patch to show the diffs

Fri, Sep 18, 3:05 AM · Restricted Project
RKSimon accepted D45263: [SLP] Allow reordering of vectorization trees with reused instructions..

LGTM again (thanks for rebasing - I didn't notice how old the last patch was!). One minor.

Fri, Sep 18, 2:51 AM · Restricted Project
RKSimon added inline comments to D87883: [X86] Add support for calling SimplifyDemandedBits on the input of PDEP with a constant mask..
Fri, Sep 18, 2:45 AM · Restricted Project
RKSimon added a comment to D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics..

Do we have sufficient backend test coverage for this?

Fri, Sep 18, 2:27 AM · Restricted Project

Thu, Sep 17

RKSimon updated subscribers of rGdd28254063f2: Add missing include.

@aprantl What was failing without this header?

Thu, Sep 17, 11:11 AM
RKSimon committed rG2a56a0ba0864: ModuloSchedule.cpp - remove unnecessary includes. NFCI. (authored by RKSimon).
ModuloSchedule.cpp - remove unnecessary includes. NFCI.
Thu, Sep 17, 8:49 AM
RKSimon planned changes to D87452: [InstCombine] matchRotate - support (uniform) constant rotation amounts (PR46895).
Thu, Sep 17, 7:19 AM · Restricted Project
RKSimon updated the diff for D87452: [InstCombine] matchRotate - support (uniform) constant rotation amounts (PR46895).

Fix the -ve shift amount issue - still looking at better testing of fshl/fshr inside collectBitParts

Thu, Sep 17, 7:19 AM · Restricted Project
RKSimon committed rG85ba2f166336: LiveDebugVariables.cpp - remove unnecessary Compiler.h include. NFCI. (authored by RKSimon).
LiveDebugVariables.cpp - remove unnecessary Compiler.h include. NFCI.
Thu, Sep 17, 7:11 AM
RKSimon committed rG46e59062a0e2: DwarfExpression.cpp - remove unnecessary includes. NFCI. (authored by RKSimon).
DwarfExpression.cpp - remove unnecessary includes. NFCI.
Thu, Sep 17, 7:11 AM
RKSimon committed rGd566771779cd: ValueList.cpp - remove unnecessary includes. NFCI. (authored by RKSimon).
ValueList.cpp - remove unnecessary includes. NFCI.
Thu, Sep 17, 7:11 AM
RKSimon committed rG67ae46c820fa: SafeStackLayout.cpp - remove unnecessary StackLifetime.h include. NFCI. (authored by RKSimon).
SafeStackLayout.cpp - remove unnecessary StackLifetime.h include. NFCI.
Thu, Sep 17, 6:57 AM
RKSimon committed rGf02681211087: InstCombiner.h - remove unnecessary KnownBits.h include. NFCI. (authored by RKSimon).
InstCombiner.h - remove unnecessary KnownBits.h include. NFCI.
Thu, Sep 17, 6:43 AM
RKSimon accepted D87485: [X86] Don't match x87 register inline asm constraints unless the VT is floating point or its a clobber.

LGTM

Thu, Sep 17, 6:37 AM · Restricted Project
RKSimon accepted D45263: [SLP] Allow reordering of vectorization trees with reused instructions..

LGTM - cheers

Thu, Sep 17, 5:54 AM · Restricted Project
RKSimon committed rGaa896a0b3a9d: Remove unnecessary forward declarations. NFCI. (authored by RKSimon).
Remove unnecessary forward declarations. NFCI.
Thu, Sep 17, 5:32 AM
RKSimon committed rGabe0d8551da5: MetadataLoader.cpp - remove unnecessary StringRef include. NFCI. (authored by RKSimon).
MetadataLoader.cpp - remove unnecessary StringRef include. NFCI.
Thu, Sep 17, 5:19 AM
RKSimon committed rGed53ff4cde33: SymbolizableObjectFile.h - remove unnecessary includes. NFCI. (authored by RKSimon).
SymbolizableObjectFile.h - remove unnecessary includes. NFCI.
Thu, Sep 17, 5:19 AM
RKSimon committed rG572e542c5e5f: DwarfStringPool.cpp - remove unnecessary StringRef include. NFCI. (authored by RKSimon).
DwarfStringPool.cpp - remove unnecessary StringRef include. NFCI.
Thu, Sep 17, 4:25 AM