Page MenuHomePhabricator

RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (464 w, 1 d)

Recent Activity

Today

RKSimon committed rGf38aba1866ef: [X86] MatchVectorAllZeroTest - return X86::CondCode instead of constant node. (authored by RKSimon).
[X86] MatchVectorAllZeroTest - return X86::CondCode instead of constant node.
Tue, Mar 28, 7:19 AM · Restricted Project, Restricted Project
RKSimon committed rG3d1068ffe172: [X86] emitFlagsForSetcc - pull out repeated isEquality condcode checks. NFC. (authored by RKSimon).
[X86] emitFlagsForSetcc - pull out repeated isEquality condcode checks. NFC.
Tue, Mar 28, 7:03 AM · Restricted Project, Restricted Project
RKSimon accepted D145221: [X86] Prefer `vpternlog` instead of `blendv` for `vselect` on masks..

LGTM - cheers

Tue, Mar 28, 5:57 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146494: [X86] Combine constant vector inputs for FMA.
Tue, Mar 28, 3:51 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146494: [X86] Combine constant vector inputs for FMA.
Tue, Mar 28, 3:49 AM · Restricted Project, Restricted Project

Yesterday

RKSimon committed rG9b957b12cc12: [X86] select-constant-lea.ll - cleanup test name. NFC. (authored by RKSimon).
[X86] select-constant-lea.ll - cleanup test name. NFC.
Mon, Mar 27, 9:56 AM · Restricted Project, Restricted Project
RKSimon committed rGedc1c8d290ef: [X86] Regenerate avx2-vector-shifts.ll check prefixes (authored by RKSimon).
[X86] Regenerate avx2-vector-shifts.ll check prefixes
Mon, Mar 27, 9:47 AM · Restricted Project, Restricted Project
RKSimon committed rGe62836e31fb9: [X86] Regenerate avx2-shift.ll check prefixes (authored by RKSimon).
[X86] Regenerate avx2-shift.ll check prefixes
Mon, Mar 27, 9:37 AM · Restricted Project, Restricted Project
RKSimon committed rG0f76fb90f855: [X86] Move combineVectorSizedSetCCEquality above MatchVectorAllZeroTest. NFC. (authored by RKSimon).
[X86] Move combineVectorSizedSetCCEquality above MatchVectorAllZeroTest. NFC.
Mon, Mar 27, 8:49 AM · Restricted Project, Restricted Project
RKSimon added a comment to D143032: [InstCombine] Allow splats with poison/undef in llvm::decomposeBitTestICmp.

please can you add alive2 links?

Mon, Mar 27, 8:37 AM · Restricted Project, Restricted Project
RKSimon added a comment to D142218: [MC] Store implicit ops immediately after the TargetInsts table. NFC..

@foad MSVC builds seem to be breaking due to this:
https://lab.llvm.org/buildbot/#/builders/86/builds/53509

LLVMARMAsmParser.lib(ARMAsmParser.cpp.obj) : error LNK2001: unresolved external symbol "class llvm::MCInstrDesc const * const llvm::ARMDescs" (?ARMDescs@llvm@@3QBVMCInstrDesc@1@B)
bin\llc.exe : fatal error LNK1120: 1 unresolved externals
ninja: build stopped: subcommand failed.
Mon, Mar 27, 4:25 AM · Restricted Project, Restricted Project
RKSimon accepted D146787: [X86] Teach computeKnownBitsForTargetNode about MUL_IMM.

LGTM - cheers

Mon, Mar 27, 3:14 AM · Restricted Project, Restricted Project

Sun, Mar 26

RKSimon accepted D146786: [CodeGenPrepare][RISCV] Correct the MathUsed flag for shouldFormOverflowOp.

LGTM

Sun, Mar 26, 7:39 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146905: [IR] Add llvm.tan.* intrinsic.
Sun, Mar 26, 7:38 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146787: [X86] Teach computeKnownBitsForTargetNode about MUL_IMM.
Sun, Mar 26, 7:23 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146900: [docs][LangRef] Added minor update inside the `frem`. Fix : #61653.
Sun, Mar 26, 7:21 AM · Restricted Project, Restricted Project

Fri, Mar 24

RKSimon accepted D146790: [X86][NFC]Remove dead code in X86ISelLowering.cpp.

LGTM - was this by manual inspection or did an analyzer spot it?

Fri, Mar 24, 2:28 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146786: [CodeGenPrepare][RISCV] Correct the MathUsed flag for shouldFormOverflowOp.
Fri, Mar 24, 2:27 AM · Restricted Project, Restricted Project

Thu, Mar 23

RKSimon committed rG30e89166d765: [X86] combineVectorSizedSetCCEquality - update arguments to use individual… (authored by RKSimon).
[X86] combineVectorSizedSetCCEquality - update arguments to use individual…
Thu, Mar 23, 12:37 PM · Restricted Project, Restricted Project
RKSimon committed rGcc8a34b11b0c: [X86] Refactor movmsk(icmp_eq(and(x,c1),0)) -> movmsk(not(shl(x,c2))) fold to… (authored by RKSimon).
[X86] Refactor movmsk(icmp_eq(and(x,c1),0)) -> movmsk(not(shl(x,c2))) fold to…
Thu, Mar 23, 10:50 AM · Restricted Project, Restricted Project
RKSimon committed rGec294d2f8f18: [X86] LowerVectorAllZero - lower to CMP(MOVMSK(NOT(X)),0) instead of CMP(MOVMSK… (authored by RKSimon).
[X86] LowerVectorAllZero - lower to CMP(MOVMSK(NOT(X)),0) instead of CMP(MOVMSK…
Thu, Mar 23, 9:11 AM · Restricted Project, Restricted Project
RKSimon committed rG320969f5058b: [X86] LowerVectorAllZero - add 512-bit support with AVX512 vptestnmd+kortestw… (authored by RKSimon).
[X86] LowerVectorAllZero - add 512-bit support with AVX512 vptestnmd+kortestw…
Thu, Mar 23, 6:37 AM · Restricted Project, Restricted Project
RKSimon committed rG4738c5f0832f: [X86] LowerVectorAllZero - early out for masked v2i64 cases without PTEST. NFC. (authored by RKSimon).
[X86] LowerVectorAllZero - early out for masked v2i64 cases without PTEST. NFC.
Thu, Mar 23, 6:09 AM · Restricted Project, Restricted Project
RKSimon added a reverting change for rG6aa7cc037f2f: [X86] LowerVectorAllZero - add 512-bit support with AVX512 vptestnmd+kortestw…: rG7fef15edd4d3: Revert rG6aa7cc037f2f95c237c1d82c523f8857fa3a10c3 - "[X86] LowerVectorAllZero….
Thu, Mar 23, 5:38 AM · Restricted Project, Restricted Project
RKSimon committed rG7fef15edd4d3: Revert rG6aa7cc037f2f95c237c1d82c523f8857fa3a10c3 - "[X86] LowerVectorAllZero… (authored by RKSimon).
Revert rG6aa7cc037f2f95c237c1d82c523f8857fa3a10c3 - "[X86] LowerVectorAllZero…
Thu, Mar 23, 5:37 AM · Restricted Project, Restricted Project
RKSimon committed rG6aa7cc037f2f: [X86] LowerVectorAllZero - add 512-bit support with AVX512 vptestnmd+kortestw… (authored by RKSimon).
[X86] LowerVectorAllZero - add 512-bit support with AVX512 vptestnmd+kortestw…
Thu, Mar 23, 5:22 AM · Restricted Project, Restricted Project
RKSimon accepted D145299: [InstCombine] Generate better code for std::bit_ceil.

unblocking this - thanks @kazu

Thu, Mar 23, 5:22 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Thu, Mar 23, 4:54 AM · Restricted Project, Restricted Project
RKSimon retitled D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad from [DAG Combine] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad to [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Thu, Mar 23, 4:53 AM · Restricted Project, Restricted Project
RKSimon committed rG4f17d75b24ee: [X86] LowerVectorAllZero - early out if the type size is not pow2. NFC. (authored by RKSimon).
[X86] LowerVectorAllZero - early out if the type size is not pow2. NFC.
Thu, Mar 23, 2:43 AM · Restricted Project, Restricted Project

Wed, Mar 22

RKSimon added inline comments to D146636: Precommit tests for #60690.
Wed, Mar 22, 11:20 AM · Restricted Project, Restricted Project
RKSimon added a comment to D142666: [DAGCombiner] Transform ABS(X) eq/ne 0/IntMin -> X eq/ne 0/IntMIn.

@goldstein.w.n reverse-ping - whats the plan for this patch?

@RKSimon does this show up in any codegen that went throw the middle-end?

Wed, Mar 22, 11:06 AM · Restricted Project, Restricted Project
RKSimon added reviewers for D146637: [InstCombine] Try to recognize bswap pattern when calling funnel shifts: spatel, nikic.
Wed, Mar 22, 10:14 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146637: [InstCombine] Try to recognize bswap pattern when calling funnel shifts.
Wed, Mar 22, 9:52 AM · Restricted Project, Restricted Project
RKSimon accepted D146511: Precommit test for #61120.

LGTM - cheers

Wed, Mar 22, 9:13 AM · Restricted Project, Restricted Project
RKSimon accepted D146512: [TLI] SimplifySetCC - Fold ~X >/< ~Y --> Y >/< X.

LGTM - cheers!

Wed, Mar 22, 9:12 AM · Restricted Project, Restricted Project
RKSimon committed rGada03565261a: [X86] Extend all_of(icmp_eq()) / any_of(icmp_ne()) -> scalar integer fold to… (authored by RKSimon).
[X86] Extend all_of(icmp_eq()) / any_of(icmp_ne()) -> scalar integer fold to…
Wed, Mar 22, 8:56 AM · Restricted Project, Restricted Project
RKSimon added a comment to D146511: Precommit test for #61120.

The <3 x i64> is interesting - but I meant other legal SSE vector types likes <16 x i8> / <8 x i16> / <4 x i32>

Wed, Mar 22, 4:57 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146512: [TLI] SimplifySetCC - Fold ~X >/< ~Y --> Y >/< X.
Wed, Mar 22, 4:55 AM · Restricted Project, Restricted Project
RKSimon added a comment to D142666: [DAGCombiner] Transform ABS(X) eq/ne 0/IntMin -> X eq/ne 0/IntMIn.

@goldstein.w.n reverse-ping - whats the plan for this patch?

Wed, Mar 22, 2:10 AM · Restricted Project, Restricted Project

Tue, Mar 21

RKSimon committed rG651b4054a019: [DAG] visitABS - use FoldConstantArithmetic to perform constant folding. (authored by RKSimon).
[DAG] visitABS - use FoldConstantArithmetic to perform constant folding.
Tue, Mar 21, 10:24 AM · Restricted Project, Restricted Project
RKSimon added a comment to D146512: [TLI] SimplifySetCC - Fold ~X >/< ~Y --> Y >/< X.

What regressions are you seeing for ULE vector cases with this fold? Manual optimization looks OK - https://llvm.godbolt.org/z/n9ezae5En

Tue, Mar 21, 8:23 AM · Restricted Project, Restricted Project
RKSimon added a comment to D146511: Precommit test for #61120.

Please can you add remaining icmp predicates - I think we still need sge/uge/eq/ne?

Tue, Mar 21, 8:17 AM · Restricted Project, Restricted Project
RKSimon committed rG8022ff5f197b: [X86] Add verify-machineinstrs checks to baseptr tests (authored by RKSimon).
[X86] Add verify-machineinstrs checks to baseptr tests
Tue, Mar 21, 6:25 AM · Restricted Project, Restricted Project
RKSimon committed rGa6a788bdfb39: [DAG] foldBinOpIntoSelect - use FoldConstantArithmetic instead of getNode() +… (authored by RKSimon).
[DAG] foldBinOpIntoSelect - use FoldConstantArithmetic instead of getNode() +…
Tue, Mar 21, 6:00 AM · Restricted Project, Restricted Project
RKSimon retitled D146512: [TLI] SimplifySetCC - Fold ~X >/< ~Y --> Y >/< X from [TLI] Fold ~X s>/u< ~Y --> Y s>/u< X to [TLI] SimplifySetCC - Fold ~X s>/u< ~Y --> Y s>/u< X.
Tue, Mar 21, 4:39 AM · Restricted Project, Restricted Project
RKSimon added a comment to D146512: [TLI] SimplifySetCC - Fold ~X >/< ~Y --> Y >/< X.

Thanks for taking a look at this!

Tue, Mar 21, 4:38 AM · Restricted Project, Restricted Project
RKSimon added a comment to D145299: [InstCombine] Generate better code for std::bit_ceil.

please can you add vector test coverage?

Tue, Mar 21, 3:13 AM · Restricted Project, Restricted Project
RKSimon added a comment to D145890: [InstCombine] Generate better code for std::bit_floor from libstdc++.

please can you add vector test coverage?

Tue, Mar 21, 3:13 AM · Restricted Project, Restricted Project
RKSimon accepted D146460: [SelectionDAG] Correctly reduce BV to shuffle with zero on big endian.

LGTM with one very optional minor

Tue, Mar 21, 3:09 AM · Restricted Project, Restricted Project

Mon, Mar 20

RKSimon updated the diff for D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..

address regressions in foldBinOpIntoSelect when handling shift(x, trunc/zext(y)) patterns

Mon, Mar 20, 6:33 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D145299: [InstCombine] Generate better code for std::bit_ceil.
Mon, Mar 20, 6:28 AM · Restricted Project, Restricted Project
RKSimon committed rG2d4042f4b78e: [DAG] visitTRUNCATE - use FoldConstantArithmetic to perform constant folding. (authored by RKSimon).
[DAG] visitTRUNCATE - use FoldConstantArithmetic to perform constant folding.
Mon, Mar 20, 4:14 AM · Restricted Project, Restricted Project
RKSimon committed rGe9a86b7813aa: [DAG] foldBinOpIntoSelect - remove !CanFoldNonConst check. NFC. (authored by RKSimon).
[DAG] foldBinOpIntoSelect - remove !CanFoldNonConst check. NFC.
Mon, Mar 20, 4:14 AM · Restricted Project, Restricted Project

Fri, Mar 17

RKSimon added inline comments to D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..
Fri, Mar 17, 5:02 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..

rebase

Fri, Mar 17, 4:40 AM · Restricted Project, Restricted Project
RKSimon commandeered D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..

(temporarily commandeering to rebase patch) @deadalnix please take this back when you're about

Fri, Mar 17, 4:39 AM · Restricted Project, Restricted Project

Thu, Mar 16

RKSimon committed rGef10f98643c3: [TLI] getMemValueType - break apart if-else chain and use auto with dyn_cast… (authored by RKSimon).
[TLI] getMemValueType - break apart if-else chain and use auto with dyn_cast…
Thu, Mar 16, 7:33 AM · Restricted Project, Restricted Project
RKSimon committed rG9ed434a96edc: [TLI] Bring isZExtFree declarations together. NFC. (authored by RKSimon).
[TLI] Bring isZExtFree declarations together. NFC.
Thu, Mar 16, 7:12 AM · Restricted Project, Restricted Project
RKSimon committed rG6bc0e362d74c: [DAG] TargetLowering::ShrinkDemandedOp - move SmallVTBits iterator inside for… (authored by RKSimon).
[DAG] TargetLowering::ShrinkDemandedOp - move SmallVTBits iterator inside for…
Thu, Mar 16, 5:13 AM · Restricted Project, Restricted Project
RKSimon committed rG7aa7393aab9f: [DAG] TargetLowering::ShrinkDemandedOp - pull out repeated getValueType calls. (authored by RKSimon).
[DAG] TargetLowering::ShrinkDemandedOp - pull out repeated getValueType calls.
Thu, Mar 16, 5:13 AM · Restricted Project, Restricted Project
RKSimon updated subscribers of D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..

Looks like we're very close to finally getting this in - @kazu @goldstein.w.n do you recognize any of the remaining regressions?

Thu, Mar 16, 5:11 AM · Restricted Project, Restricted Project
RKSimon added a comment to D141653: [X86] Improve instruction ordering of constant `srl/shl` with `and` to get better and-masks.

@goldstein.w.n What is happening with this patch? After they leave my "Ready to Review" list I tend to lose track......

Thu, Mar 16, 3:21 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits (WIP).
Thu, Mar 16, 3:20 AM · Restricted Project, Restricted Project

Wed, Mar 15

RKSimon committed rG5be551009864: [X86] lzcnt-cmp.ll - enable CMOV on 32-bit LZCNT tests (authored by RKSimon).
[X86] lzcnt-cmp.ll - enable CMOV on 32-bit LZCNT tests
Wed, Mar 15, 11:15 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits (WIP).

rebase again (and actually update the changed test this time....)

Wed, Mar 15, 11:01 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits (WIP).

rebase

Wed, Mar 15, 10:58 AM · Restricted Project, Restricted Project
RKSimon committed rG28a0d0e85ab5: [DAG] Don't fold zext(logicalshift(zext(x),c)) -> logicalshift(zext(x),c) if… (authored by RKSimon).
[DAG] Don't fold zext(logicalshift(zext(x),c)) -> logicalshift(zext(x),c) if…
Wed, Mar 15, 10:45 AM · Restricted Project, Restricted Project
RKSimon committed rG2281286eb7a1: [X86] Add more thorough testing of the zext(logicalshift(zext(x),c)) ->… (authored by RKSimon).
[X86] Add more thorough testing of the zext(logicalshift(zext(x),c)) ->…
Wed, Mar 15, 10:21 AM · Restricted Project, Restricted Project
RKSimon committed rG4ead58914cc3: [X86] add-and-not.ll - add 32-bit test coverage (authored by RKSimon).
[X86] add-and-not.ll - add 32-bit test coverage
Wed, Mar 15, 8:13 AM · Restricted Project, Restricted Project
RKSimon accepted D146102: [TTI] Add X86 target specific version of getPointersChainCost..

LGTM

Wed, Mar 15, 7:36 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits (WIP).

drop useless vector handling

Wed, Mar 15, 6:47 AM · Restricted Project, Restricted Project
RKSimon committed rGdc20ce7e543d: [DAG] TargetLowering::ShrinkDemandedOp - rename Demanded arg to DemandedBits. (authored by RKSimon).
[DAG] TargetLowering::ShrinkDemandedOp - rename Demanded arg to DemandedBits.
Wed, Mar 15, 6:23 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits (WIP).

rebase

Wed, Mar 15, 5:01 AM · Restricted Project, Restricted Project
RKSimon committed rGc1f81e760445: [DAG] mergeStore - peek through truncates when finding dead store(trunc(load… (authored by RKSimon).
[DAG] mergeStore - peek through truncates when finding dead store(trunc(load…
Wed, Mar 15, 4:54 AM · Restricted Project, Restricted Project
RKSimon accepted D146118: [X86]add assert to confirm not-null ptr in getArithmeticReductionCost.

LGTM - a reduction cost is almost impossible without the type anyhow

Wed, Mar 15, 3:34 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits (WIP).
Wed, Mar 15, 3:13 AM · Restricted Project, Restricted Project
RKSimon requested review of D146121: [DAG] Move lshr narrowing from visitANDLike to SimplifyDemandedBits (WIP).
Wed, Mar 15, 3:10 AM · Restricted Project, Restricted Project
RKSimon committed rG70562607ab38: [DAG] Fold multiple insert_vector_elt of zero values into an AND mask (authored by RKSimon).
[DAG] Fold multiple insert_vector_elt of zero values into an AND mask
Wed, Mar 15, 2:56 AM · Restricted Project, Restricted Project
RKSimon closed D145939: [DAG] Fold multiple insert_vector_elt of zero values into an AND mask.
Wed, Mar 15, 2:56 AM · Restricted Project, Restricted Project

Tue, Mar 14

RKSimon added inline comments to D145221: [X86] Prefer `vpternlog` instead of `blendv` for `vselect` on masks..
Tue, Mar 14, 11:00 AM · Restricted Project, Restricted Project
RKSimon accepted D145908: [X86] Remove unreachable code in X86TargetTransformInfo.cpp.

LGTM - was originally added in D20601 when we had much a weaker cost model

Tue, Mar 14, 9:42 AM · Restricted Project, Restricted Project
RKSimon updated the summary of D142666: [DAGCombiner] Transform ABS(X) eq/ne 0/IntMin -> X eq/ne 0/IntMIn.
Tue, Mar 14, 8:34 AM · Restricted Project, Restricted Project
RKSimon committed rGcb47e254e522: [X86] Add test coverage for D137388 (authored by RKSimon).
[X86] Add test coverage for D137388
Tue, Mar 14, 8:27 AM · Restricted Project, Restricted Project
RKSimon committed rGda570ef1b4f8: [DAG] Match select(icmp(x,y),sub(x,y),sub(y,x)) -> abd(x,y) patterns (authored by RKSimon).
[DAG] Match select(icmp(x,y),sub(x,y),sub(y,x)) -> abd(x,y) patterns
Tue, Mar 14, 8:11 AM · Restricted Project, Restricted Project
RKSimon closed D144789: [DAG] Match select(icmp(x,y),sub(x,y),sub(y,x)) -> abd(x,y) patterns.
Tue, Mar 14, 8:10 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D145939: [DAG] Fold multiple insert_vector_elt of zero values into an AND mask.

rebase + address feedback

Tue, Mar 14, 7:42 AM · Restricted Project, Restricted Project
RKSimon committed rG4bf004e07e2b: [DAG] Fold (bitcast (logicop (bitcast x), (c))) -> (logicop x, (bitcast c)) iff… (authored by RKSimon).
[DAG] Fold (bitcast (logicop (bitcast x), (c))) -> (logicop x, (bitcast c)) iff…
Tue, Mar 14, 7:42 AM · Restricted Project, Restricted Project
RKSimon committed rGf652bfeba583: [X86] Fix typo in vXi64 ABDS/ABDU test cases (authored by RKSimon).
[X86] Fix typo in vXi64 ABDS/ABDU test cases
Tue, Mar 14, 7:42 AM · Restricted Project, Restricted Project
RKSimon closed D146032: [DAG] Fold (bitcast (logicop (bitcast x), (c))) -> (logicop x, (bitcast c)) iff the current logicop type is illegal.
Tue, Mar 14, 7:42 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D146032: [DAG] Fold (bitcast (logicop (bitcast x), (c))) -> (logicop x, (bitcast c)) iff the current logicop type is illegal.

Consistently use logicop

Tue, Mar 14, 4:34 AM · Restricted Project, Restricted Project
RKSimon accepted D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP.

LGTM - cheers

Tue, Mar 14, 4:20 AM · Restricted Project, Restricted Project
RKSimon updated the summary of D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP.
Tue, Mar 14, 4:20 AM · Restricted Project, Restricted Project
RKSimon requested review of D146032: [DAG] Fold (bitcast (logicop (bitcast x), (c))) -> (logicop x, (bitcast c)) iff the current logicop type is illegal.
Tue, Mar 14, 4:03 AM · Restricted Project, Restricted Project

Mon, Mar 13

RKSimon added inline comments to D145650: [X86] Create extra prolog/epilog for stack realignment.
Mon, Mar 13, 2:35 PM · Restricted Project, Restricted Project
RKSimon added inline comments to D110978: [SLP]Improve gathering of the scalars used in the graph..
Mon, Mar 13, 2:27 PM · Restricted Project, Restricted Project
RKSimon added a comment to D144789: [DAG] Match select(icmp(x,y),sub(x,y),sub(y,x)) -> abd(x,y) patterns.

ping - apart from the x86 multiuse cmp issues does anyone have anymore comments?

Mon, Mar 13, 12:08 PM · Restricted Project, Restricted Project
RKSimon added a comment to D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP.

Patch itself LGTM but the summary needs a cleanup - the defm section is irrelevant (and confusing) - just explain that ATOMIC_LOGIC_OP_RM shouldn't be using the *i8 instruction encodings

Mon, Mar 13, 11:48 AM · Restricted Project, Restricted Project
RKSimon accepted D145933: [X86] Add negative test for D145930.

LGTM

Mon, Mar 13, 10:02 AM · Restricted Project, Restricted Project
RKSimon accepted D145863: [X86] Use llvm::Align for passing the alignment.

LGTM - cheers

Mon, Mar 13, 8:16 AM · Restricted Project, Restricted Project