Page MenuHomePhabricator
People RKSimon

RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (371 w, 1 d)

Recent Activity
View All

Today

RKSimon updated the diff for D101074: [X86] Canonicalize SGT/UGT compares with constants to use SGE/UGE to reduce the number of EFLAGs reads. (PR48760).

Add SETLT/SETULT handling

Tue, Jun 15, 7:38 AM · Restricted Project
RKSimon added a comment to D104156: [DAGCombine][X86][ARM] EXTRACT_SUBVECTOR(VECTOR_SHUFFLE(?,?,Mask)) -> VECTOR_SHUFFLE(EXTRACT_SUBVECTOR(?, ?), EXTRACT_SUBVECTOR(?, ?), Mask').
In D104156#2818946, @lebedev.ri wrote:

So i'm not sure the rest can be dealt with by SimplifyMultipleUseDemandedBits().

Tue, Jun 15, 7:03 AM · Restricted Project
RKSimon accepted D103638: [SLP]Improve vectorization of PHI instructions..

LGTM

Tue, Jun 15, 6:58 AM · Restricted Project
RKSimon resigned from D104247: [DAGCombine] reassoc flag shouldn't enable contract.
Tue, Jun 15, 6:43 AM · Restricted Project
RKSimon committed rG941188e96534: [llvm-exegesis] Fix X86LbrCounter destructor to correctly unmap memory and not… (authored by RKSimon).
[llvm-exegesis] Fix X86LbrCounter destructor to correctly unmap memory and not…
Tue, Jun 15, 6:25 AM
RKSimon closed D104201: [llvm-exegesis] Fix X86LbrCounter destructor to correctly unmap memory and not double-close fd (PR50620).
Tue, Jun 15, 6:25 AM · Restricted Project
RKSimon updated the summary of D104201: [llvm-exegesis] Fix X86LbrCounter destructor to correctly unmap memory and not double-close fd (PR50620).
Tue, Jun 15, 6:14 AM · Restricted Project
RKSimon added a comment to D104201: [llvm-exegesis] Fix X86LbrCounter destructor to correctly unmap memory and not double-close fd (PR50620).

Cheers - I've now confirmed that this works locally

Tue, Jun 15, 6:14 AM · Restricted Project
RKSimon accepted D104205: [X86] Schedule-model second (mask) output of GATHER instruction.

LGTM with one (optional) rename minor - cheers

Tue, Jun 15, 1:47 AM · Restricted Project
RKSimon added a comment to D103881: [ValueTypes] Define MVTs for v6i32, v6f32, v7i32, v7f32.
In D103881#2818322, @srj wrote:

Since there is a bug and a repro case, I'd like to ask if this change can be rolled back until a proper fix is in order.

Tue, Jun 15, 1:22 AM · Restricted Project

Yesterday

RKSimon accepted D104250: [TLI] SimplifyDemandedVectorElts(): handle SCALAR_TO_VECTOR(EXTRACT_VECTOR_ELT(?, 0)).

LGTM - cheers

Mon, Jun 14, 1:45 PM · Restricted Project
RKSimon added a comment to D104250: [TLI] SimplifyDemandedVectorElts(): handle SCALAR_TO_VECTOR(EXTRACT_VECTOR_ELT(?, 0)).

Thanks for looking into this!

Mon, Jun 14, 1:21 PM · Restricted Project
RKSimon added inline comments to D104156: [DAGCombine][X86][ARM] EXTRACT_SUBVECTOR(VECTOR_SHUFFLE(?,?,Mask)) -> VECTOR_SHUFFLE(EXTRACT_SUBVECTOR(?, ?), EXTRACT_SUBVECTOR(?, ?), Mask').
Mon, Jun 14, 5:59 AM · Restricted Project
RKSimon added inline comments to D104205: [X86] Schedule-model second (mask) output of GATHER instruction.
Mon, Jun 14, 5:47 AM · Restricted Project
RKSimon accepted D104187: [DAGCombine] reduceBuildVecToShuffle(): sort input vectors by decreasing size.

LGTM - cheers

Mon, Jun 14, 5:44 AM · Restricted Project
RKSimon added reviewers for D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+: pengfei, craig.topper.

This leaves the question - what hardware should we align each of the CK_x86_64_v* targets with?

Mon, Jun 14, 1:12 AM · Restricted Project
RKSimon added a comment to D104205: [X86] Schedule-model second (mask) output of GATHER instruction.

What about the avx512 gather ops - are they OK?

Mon, Jun 14, 12:14 AM · Restricted Project

Sun, Jun 13

RKSimon requested review of D104201: [llvm-exegesis] Fix X86LbrCounter destructor to correctly unmap memory and not double-close fd (PR50620).
Sun, Jun 13, 11:16 AM · Restricted Project
RKSimon committed rG4089e0bbfafd: RawError.h - remove unused <string> include. NFCI. (authored by RKSimon).
RawError.h - remove unused <string> include. NFCI.
Sun, Jun 13, 9:38 AM
RKSimon committed rG9efe89d82ff9: BoundsChecking.cpp - tidy implicit header dependencies. NFCI. (authored by RKSimon).
BoundsChecking.cpp - tidy implicit header dependencies. NFCI.
Sun, Jun 13, 9:09 AM
RKSimon committed rG033e594c594b: DIPrinter.h - tidy implicit header dependencies. NFCI. (authored by RKSimon).
DIPrinter.h - tidy implicit header dependencies. NFCI.
Sun, Jun 13, 9:00 AM
RKSimon committed rGd1b57086d55a: DetailedRecordsBackend.cpp - printSectionHeading - avoid std::string… (authored by RKSimon).
DetailedRecordsBackend.cpp - printSectionHeading - avoid std::string…
Sun, Jun 13, 8:53 AM
RKSimon committed rGa03d09f423a4: DetailedRecordsBackend.cpp - tidy implicit header dependencies. NFCI. (authored by RKSimon).
DetailedRecordsBackend.cpp - tidy implicit header dependencies. NFCI.
Sun, Jun 13, 8:38 AM
RKSimon added reviewers for D104194: Fix misspelled instruction in X86 assembly parser: RKSimon, pengfei.

test case?

Sun, Jun 13, 8:07 AM · Restricted Project
RKSimon added inline comments to D104187: [DAGCombine] reduceBuildVecToShuffle(): sort input vectors by decreasing size.
Sun, Jun 13, 7:41 AM · Restricted Project
RKSimon committed rG3dc727e81b92: ProfiledCallGraph.h - remove unused <string> include. NFCI. (authored by RKSimon).
ProfiledCallGraph.h - remove unused <string> include. NFCI.
Sun, Jun 13, 7:22 AM
RKSimon committed rG2c4ee1e112a2: RegUsageInfoPropagate.cpp - remove unused <string> and <map> includes. NFCI. (authored by RKSimon).
RegUsageInfoPropagate.cpp - remove unused <string> and <map> includes. NFCI.
Sun, Jun 13, 7:21 AM
RKSimon committed rGdbfa3d289bc4: MachOObjectFile.cpp - remove unused <string> include. NFCI. (authored by RKSimon).
MachOObjectFile.cpp - remove unused <string> include. NFCI.
Sun, Jun 13, 7:21 AM
RKSimon committed rG35a12023f392: DWARFDebugFrame.cpp - remove unused <string> include. NFCI. (authored by RKSimon).
DWARFDebugFrame.cpp - remove unused <string> include. NFCI.
Sun, Jun 13, 7:21 AM
RKSimon committed rG56541d137790: GVN.cpp - remove unused <vector> include. NFCI. (authored by RKSimon).
GVN.cpp - remove unused <vector> include. NFCI.
Sun, Jun 13, 6:06 AM
RKSimon committed rGc14fd171fe77: LoopUnrollAndJamPass.cpp - remove unused <vector> include. NFCI. (authored by RKSimon).
LoopUnrollAndJamPass.cpp - remove unused <vector> include. NFCI.
Sun, Jun 13, 6:06 AM
RKSimon committed rG7d7e913e096a: SValExplainer.h - get APSInt values by const reference instead of value. NFCI. (authored by RKSimon).
SValExplainer.h - get APSInt values by const reference instead of value. NFCI.
Sun, Jun 13, 5:06 AM
RKSimon committed rG2477b498f256: ArgumentPromotion.cpp - remove unused <string> include. NFCI. (authored by RKSimon).
ArgumentPromotion.cpp - remove unused <string> include. NFCI.
Sun, Jun 13, 5:04 AM
RKSimon committed rGb013c58e82c6: VPlanSLP.cpp - tidy implicit header dependencies. NFCI. (authored by RKSimon).
VPlanSLP.cpp - tidy implicit header dependencies. NFCI.
Sun, Jun 13, 4:37 AM
RKSimon added a comment to D104187: [DAGCombine] reduceBuildVecToShuffle(): sort input vectors by decreasing size.

A few nits but the premise seems sound - did you encounter real world cases that led you to this?

Sun, Jun 13, 1:46 AM · Restricted Project

Sat, Jun 12

RKSimon added inline comments to D103638: [SLP]Improve vectorization of PHI instructions..
Sat, Jun 12, 3:11 AM · Restricted Project
RKSimon accepted D104178: [X86] Add ISD::FREEZE and ISD::AssertAlign to the list of opcodes that don't guarantee upper 32 bits are zero..

LGTM - does this need to be back ported to 12.x?

Sat, Jun 12, 1:35 AM · Restricted Project

Fri, Jun 11

RKSimon committed rG307cfad0d639: Fix extraneous ')' error. (authored by RKSimon).
Fix extraneous ')' error.
Fri, Jun 11, 6:50 AM
RKSimon committed rG4295c222a8f1: StringExtrasTest.cpp - add missing newline at the end of file. NFCI. (authored by RKSimon).
StringExtrasTest.cpp - add missing newline at the end of file. NFCI.
Fri, Jun 11, 6:35 AM
RKSimon committed rGf7bc9db95aba: Fix Wdocumentation missing parameter warnings. NFCI. (authored by RKSimon).
Fix Wdocumentation missing parameter warnings. NFCI.
Fri, Jun 11, 6:34 AM
RKSimon added a comment to D103888: [ADT] Remove APInt/APSInt toString() std::string variants.
In D103888#2811305, @dblaikie wrote:

Sounds OK.

I wouldn't mind the places that can use op<< to use that - not sure preserving the explicit radix argument is super high value. (I think people would generally assume that's the default)
Possible we could call it to_string, is std::to_string meant to be an ADL extension point, so that other types expose a to_string in their own associated namespace, etc?

Fri, Jun 11, 6:27 AM · Restricted Project, Restricted Project, Restricted Project
RKSimon committed rGcd2e500e555e: [lldb] DumpDataExtractor.cpp - replace APInt::toString() with llvm::toString… (authored by RKSimon).
[lldb] DumpDataExtractor.cpp - replace APInt::toString() with llvm::toString…
Fri, Jun 11, 5:39 AM
RKSimon committed rG0fc4016d913d: APInt.h - add missing <utility> header. (authored by RKSimon).
APInt.h - add missing <utility> header.
Fri, Jun 11, 5:36 AM
RKSimon committed rG61cdaf66fe22: [ADT] Remove APInt/APSInt toString() std::string variants (authored by RKSimon).
[ADT] Remove APInt/APSInt toString() std::string variants
Fri, Jun 11, 5:20 AM
RKSimon closed D103888: [ADT] Remove APInt/APSInt toString() std::string variants.
Fri, Jun 11, 5:20 AM · Restricted Project, Restricted Project, Restricted Project
RKSimon added a comment to D104107: [NFCI][X86] Drop "atom"/"slm" target tuning "features", derive them from CPU string.

I've no objections, but really I'd like to see the isAtom() and isSLM() methods removed entirely - both appear to have been added as perf regression hacks over the years, and then reused where proper feature flags should have been added instead.

Fri, Jun 11, 5:03 AM · Restricted Project
RKSimon committed rG955d88992a55: [ADT] Consistently use StringExtrasTest for the test suite filter. NFCI. (authored by RKSimon).
[ADT] Consistently use StringExtrasTest for the test suite filter. NFCI.
Fri, Jun 11, 4:01 AM
RKSimon committed rG646e970d44d7: [llvm-stress] Fix dead code preventing us generating per-element vector selects (authored by RKSimon).
[llvm-stress] Fix dead code preventing us generating per-element vector selects
Fri, Jun 11, 2:58 AM
RKSimon closed D104022: [llvm-stress] Fix dead code preventing us generating per-element vector selects.
Fri, Jun 11, 2:57 AM · Restricted Project
RKSimon committed rGf0a68bbc967a: SampleProf.h - fix spelling mistake in assert message. NFC. (authored by RKSimon).
SampleProf.h - fix spelling mistake in assert message. NFC.
Fri, Jun 11, 2:25 AM
RKSimon committed rG5e6bfb661e8b: [Analysis] Pass RecurrenceDescriptor as const reference. NFCI. (authored by RKSimon).
[Analysis] Pass RecurrenceDescriptor as const reference. NFCI.
Fri, Jun 11, 2:25 AM
RKSimon committed rGd789ed11ea01: Fix implicit dependency on <string> header. NFCI. (authored by RKSimon).
Fix implicit dependency on <string> header. NFCI.
Fri, Jun 11, 2:25 AM
RKSimon closed D104029: [Analysis] Pass RecurrenceDescriptor as const reference. NFCI..
Fri, Jun 11, 2:24 AM · Restricted Project
RKSimon accepted D103922: [X86FixupLEAs] Sub register usage of LEA dest should block LEA/SUB optimization.

LGTM - cheers

Fri, Jun 11, 1:29 AM · Restricted Project
RKSimon added a comment to D103943: [X86] Add -mgeneral-regs-only support..

I don't know much about target feature inheritance - does this guarantee that the entire sse/avx/avx512 level chain is correctly disabled?

Fri, Jun 11, 1:28 AM · Restricted Project

Thu, Jun 10

RKSimon requested review of D104029: [Analysis] Pass RecurrenceDescriptor as const reference. NFCI..
Thu, Jun 10, 7:13 AM · Restricted Project
RKSimon added reviewers for D104001: [X86] avoid assert with varargs, soft float, and no-implicit-float: pengfei, MaskRay.
Thu, Jun 10, 7:01 AM · Restricted Project
RKSimon added inline comments to D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure.
Thu, Jun 10, 7:00 AM · Restricted Project
RKSimon accepted D103880: [SDAG] Fix pow2 assumption when splitting vectors.

LGTM

Thu, Jun 10, 5:34 AM · Restricted Project
RKSimon accepted D103881: [ValueTypes] Define MVTs for v6i32, v6f32, v7i32, v7f32.

OK, I get where everyone's coming from and I'm not going to block it - it just feels untidy to me. LGTM

Thu, Jun 10, 5:31 AM · Restricted Project
RKSimon added a comment to D103880: [SDAG] Fix pow2 assumption when splitting vectors.
In D103880#2809550, @critson wrote:
In D103880#2807899, @RKSimon wrote:

test case?

I am not sure if I can trigger this without v6 types, as the current non-pow2 types v3 and v5 are not divisible by 2.

Without this change simply adding v6i32 types will cause an assertion failure while compiling: llvm/test/CodeGen/X86/pr44976.ll

Thu, Jun 10, 5:27 AM · Restricted Project
RKSimon requested review of D104022: [llvm-stress] Fix dead code preventing us generating per-element vector selects.
Thu, Jun 10, 4:50 AM · Restricted Project
RKSimon committed rGb01d393fc035: Fix MSVC int64_t -> uint64_t "narrowing conversion" warning. (authored by RKSimon).
Fix MSVC int64_t -> uint64_t "narrowing conversion" warning.
Thu, Jun 10, 3:09 AM
RKSimon committed rG0ce61d47c03d: Add explicit braces to silence warning about ambiguous 'else' inside the… (authored by RKSimon).
Add explicit braces to silence warning about ambiguous 'else' inside the…
Thu, Jun 10, 3:09 AM
RKSimon committed rG4eb47e3cd4c0: [TargetLowering] getABIAlignmentForCallingConv - pass DataLayout by const… (authored by RKSimon).
[TargetLowering] getABIAlignmentForCallingConv - pass DataLayout by const…
Thu, Jun 10, 3:09 AM
RKSimon added a comment to D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure.
In D101819#2809759, @sushmaunnibhavi wrote:

I think the clang-tidy errors in M68kRegisterBankInfo.h come because the buildbot doesn't build with DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="M68k". But when built with DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="M68k" no such errors occur.

Thu, Jun 10, 1:52 AM · Restricted Project

Wed, Jun 9

RKSimon updated the diff for D103888: [ADT] Remove APInt/APSInt toString() std::string variants.

rebase

Wed, Jun 9, 7:34 AM · Restricted Project, Restricted Project, Restricted Project
RKSimon committed rG206a66de5902: Sanitizers.h - remove MathExtras.h include dependency (authored by RKSimon).
Sanitizers.h - remove MathExtras.h include dependency
Wed, Jun 9, 6:38 AM
RKSimon closed D103953: Sanitizers.h - remove MathExtras.h include dependency.
Wed, Jun 9, 6:38 AM · Restricted Project
RKSimon added a comment to D103880: [SDAG] Fix pow2 assumption when splitting vectors.

test case?

Wed, Jun 9, 6:10 AM · Restricted Project
RKSimon added a comment to D101109: [SLP]Improve multinode analysis..

rebase?

Wed, Jun 9, 6:05 AM · Restricted Project
RKSimon committed rG630820bafc68: [X86][SLM] Adjust XMM non-PMULLD throughput costs to half rate. (authored by RKSimon).
[X86][SLM] Adjust XMM non-PMULLD throughput costs to half rate.
Wed, Jun 9, 5:53 AM
RKSimon committed rG8ffeb5c47d94: [X86][SSE] Regenerate slow-pmulld.ll test checks (authored by RKSimon).
[X86][SSE] Regenerate slow-pmulld.ll test checks
Wed, Jun 9, 5:53 AM
RKSimon added reviewers for D103954: [SLP] Incorrect handling of external scalar values: ABataev, anton-afanasyev, RKSimon.
Wed, Jun 9, 4:31 AM · Restricted Project
RKSimon added inline comments to D103953: Sanitizers.h - remove MathExtras.h include dependency.
Wed, Jun 9, 4:04 AM · Restricted Project
RKSimon requested review of D103953: Sanitizers.h - remove MathExtras.h include dependency.
Wed, Jun 9, 4:01 AM · Restricted Project
RKSimon committed rGf3fd36e590f4: JSONNodeDumper.cpp - VisitIntegerLiteral - avoid APSInt::toString std::string… (authored by RKSimon).
JSONNodeDumper.cpp - VisitIntegerLiteral - avoid APSInt::toString std::string…
Wed, Jun 9, 3:10 AM
RKSimon committed rGd806d11b14e1: Interp.h - AddSubMulHelper - avoid APSInt::toString std::string wrapper. NFCI (authored by RKSimon).
Interp.h - AddSubMulHelper - avoid APSInt::toString std::string wrapper. NFCI
Wed, Jun 9, 3:10 AM
RKSimon accepted D103940: [X86] Check destination element type before forming VTRUNCS/VTRUNCUS in combineTruncateWithSat..

LGTM

Wed, Jun 9, 1:18 AM · Restricted Project
RKSimon added inline comments to D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure.
Wed, Jun 9, 1:06 AM · Restricted Project

Tue, Jun 8

RKSimon requested review of D103925: [X86][SSE] Support 64-bit vectorization (WIP).
Tue, Jun 8, 1:34 PM · Restricted Project
RKSimon added inline comments to D103922: [X86FixupLEAs] Sub register usage of LEA dest should block LEA/SUB optimization.
Tue, Jun 8, 1:18 PM · Restricted Project
RKSimon accepted D103458: [SLP]Improve gathering of scalar elements..

LGTM

Tue, Jun 8, 11:41 AM · Restricted Project
RKSimon committed rG52396577a2d8: Use llvm_unreachable for unsupported integer types. (authored by RKSimon).
Use llvm_unreachable for unsupported integer types.
Tue, Jun 8, 10:00 AM
RKSimon committed rG01b77159e30b: PPCISelLowering.cpp - don't dereference a dyn_cast<>. (authored by RKSimon).
PPCISelLowering.cpp - don't dereference a dyn_cast<>.
Tue, Jun 8, 10:00 AM
RKSimon committed rG114e712c344f: InstrEmitter.cpp - don't dereference a dyn_cast<>. (authored by RKSimon).
InstrEmitter.cpp - don't dereference a dyn_cast<>.
Tue, Jun 8, 9:59 AM
RKSimon accepted D103904: [TableGen] Eliminate dead code in ParseForeachDeclaration [NFC].

LGTM - cheers

Tue, Jun 8, 9:24 AM · Restricted Project
RKSimon committed rG61a2d6bfe48c: [DAG] foldShuffleOfConcatUndefs - ensure shuffles of upper (undef) subvector… (authored by RKSimon).
[DAG] foldShuffleOfConcatUndefs - ensure shuffles of upper (undef) subvector…
Tue, Jun 8, 7:52 AM
RKSimon added a comment to D103881: [ValueTypes] Define MVTs for v6i32, v6f32, v7i32, v7f32.
In D103881#2805122, @frasercrmck wrote:

Awfully brave to add new non-pow2 types; I like it. Unfortunate that we've both filed patches to this same file at the same time (D103884). One of us will have a fun time.

Tue, Jun 8, 7:24 AM · Restricted Project
RKSimon requested review of D103888: [ADT] Remove APInt/APSInt toString() std::string variants.
Tue, Jun 8, 5:48 AM · Restricted Project, Restricted Project, Restricted Project
RKSimon committed rG49d3a367c037: [CostModel][X86] Improve AVX1/AVX2 truncation costs (authored by RKSimon).
[CostModel][X86] Improve AVX1/AVX2 truncation costs
Tue, Jun 8, 2:42 AM
RKSimon committed rGf96b5e801d67: OptBisect.cpp - remove unused include. NFCI. (authored by RKSimon).
OptBisect.cpp - remove unused include. NFCI.
Tue, Jun 8, 2:42 AM
RKSimon committed rG596004a94748: MemCpyOptimizer.cpp - hasUndefContentsMSSA - Pass DataLayout by reference. NFCI. (authored by RKSimon).
MemCpyOptimizer.cpp - hasUndefContentsMSSA - Pass DataLayout by reference. NFCI.
Tue, Jun 8, 2:42 AM
RKSimon committed rG4ad59f9a5a95: ValueTrackingTest.cpp - Pass DataLayout by reference. NFCI. (authored by RKSimon).
ValueTrackingTest.cpp - Pass DataLayout by reference. NFCI.
Tue, Jun 8, 2:42 AM
RKSimon committed rG27f3041c88ac: NVPTXTargetLowering::LowerReturn - Pass DataLayout by reference. NFCI. (authored by RKSimon).
NVPTXTargetLowering::LowerReturn - Pass DataLayout by reference. NFCI.
Tue, Jun 8, 2:42 AM
RKSimon updated subscribers of rG937c4cffd024: Fix implicit fall through compiler warning. NFCI..

This appears to change behavior - any chance of test coverage?

Tue, Jun 8, 1:43 AM
RKSimon accepted D103823: [TableGen] Fix ProfileFoldOpInit so that parameters are named consistently [NFC].

If the ordering doesn't matter then LGTM - cheers!

Tue, Jun 8, 1:22 AM · Restricted Project

Mon, Jun 7

RKSimon accepted D103818: [NFC][X86] lowerVECTOR_SHUFFLE(): drop FIXME about widening to i128 (YMM half) element type.

LGTM

Mon, Jun 7, 12:35 PM · Restricted Project
RKSimon added a comment to D103820: [X86] Prefer vpmovq2m over vpternlogd + vpcmpgtq.

@davezarzycki What's going on the way phab is reporting the path in Revision Contents pane? llvm/lib/Target/X86 -> i/llvm/lib/Target/X86 ?!?

Mon, Jun 7, 12:25 PM · Restricted Project
RKSimon updated subscribers of rGf10b9ca9c672: [NFC] Add missing include to LaneBitmask.h to fix modules build.

Thanks @teemperor - I didn't see any buildbots failure for this case - do we have module build coverage?

Mon, Jun 7, 11:52 AM