- User Since
- May 5 2014, 7:26 AM (250 w, 5 d)
FWICT from the discussion on D57888, doesn't that mean the problem is really in the commutation code and we should be fixing that?
The patch has rotted and needs rewriting, but putting in an assert causes hits in these tests:
Failing Tests (16): LLVM :: CodeGen/AMDGPU/copy-illegal-type.ll LLVM :: CodeGen/AMDGPU/cvt_f32_ubyte.ll LLVM :: CodeGen/AMDGPU/flat_atomics_i64.ll LLVM :: CodeGen/AMDGPU/global_atomics_i64.ll LLVM :: CodeGen/AMDGPU/load-constant-i1.ll LLVM :: CodeGen/AMDGPU/load-constant-i16.ll LLVM :: CodeGen/AMDGPU/load-global-i1.ll LLVM :: CodeGen/AMDGPU/load-global-i16.ll LLVM :: CodeGen/AMDGPU/load-local-i1.ll LLVM :: CodeGen/AMDGPU/load-local-i16.ll LLVM :: CodeGen/AMDGPU/max.i16.ll LLVM :: CodeGen/AMDGPU/min.ll LLVM :: CodeGen/AMDGPU/select.f16.ll LLVM :: CodeGen/AMDGPU/selectcc.ll LLVM :: CodeGen/AMDGPU/v_madak_f16.ll LLVM :: CodeGen/X86/vector-intrinsics.ll
If possible please can you use one of these to show a codegen change? I tried the x86 test but didn't find anything.
Thu, Feb 21
Here you're making more use of the domain pass to reduce isel patterns, but in rL354511 you added isel patterns to avoid the load folding pass - what's the difference?
Wed, Feb 20
@deadalnix Please can you rebase this?
Tue, Feb 19
@craig.topper Any comments?
Mon, Feb 18
LGTM once D57825 lands
cheers - I tried that but it had stayed red - I don't know what it is about that bot but it acts up a lot......
LGTM - cheers
@craig.topper This appears to breaking some buildbots:
LGTM - cheers.
Fri, Feb 15
LGTM with one minor
@jkorous This is failing on windows buildbots - do you have a fix or shall I revert?
Thu, Feb 14
Intel targets tend to only accept vector shifts on Port0, while vector logic can use Port0/1/5 - not sure how much of an issue that would be @craig.topper ? Some AMD targets are almost as bad while others (Jaguar) can issue vector immediate shifts to any vector integer pipe.
Wed, Feb 13
Tue, Feb 12
LGTM with a couple of minors
Thanks @sammccall I've been able to repro it now.
Mon, Feb 11
Let's try this again....
I hate Mondays - closing this again as its the wrong patch........
Reopening as it was reverted at rL353699 due to a rather weird regression.....
Sun, Feb 10