RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.
User Since
May 5 2014, 7:26 AM (151 w, 1 d)

Recent Activity

Yesterday

RKSimon committed rL298943: [X86][MMX] Match MMX fp_to_sint conversions from XMM registers.
[X86][MMX] Match MMX fp_to_sint conversions from XMM registers
Tue, Mar 28, 2:44 PM
RKSimon closed D30868: [X86][MMX] Match MMX fp_to_sint conversions from XMM registers by committing rL298943: [X86][MMX] Match MMX fp_to_sint conversions from XMM registers.
Tue, Mar 28, 2:44 PM
RKSimon added inline comments to D30703: [DSE] Merge stores when the later store only writes to memory locations the early store also wrote to..
Tue, Mar 28, 10:45 AM
RKSimon accepted D31403: [SDAG] Deal with deleted node in PromoteIntShiftOp.

No more comments from me - LGTM

Tue, Mar 28, 10:07 AM
RKSimon added a comment to D31249: [DAGCombiner] Add vector demanded elements support to computeKnownBitsForTargetNode.

ping?

Tue, Mar 28, 9:56 AM
RKSimon committed rL298929: [X86][AVX2] Add support for combining v16i16 shuffles to VPBLENDW.
[X86][AVX2] Add support for combining v16i16 shuffles to VPBLENDW
Tue, Mar 28, 9:53 AM
RKSimon added inline comments to D31403: [SDAG] Deal with deleted node in PromoteIntShiftOp.
Tue, Mar 28, 9:49 AM
RKSimon committed rL298925: [X86][SSE] Refactored shuffle BLEND combining to make future 16i16 support….
[X86][SSE] Refactored shuffle BLEND combining to make future 16i16 support…
Tue, Mar 28, 9:02 AM
RKSimon added inline comments to D31403: [SDAG] Deal with deleted node in PromoteIntShiftOp.
Tue, Mar 28, 7:57 AM
RKSimon accepted D31148: [SDAG] Avoid deleted SDNodes PromoteIntBinOp.

LGTM but if you can please strip the *.getNode() from the bool checks - they're not necessary

Tue, Mar 28, 7:56 AM
RKSimon committed rL298917: Fix signed/unsigned comparison warning.
Fix signed/unsigned comparison warning
Tue, Mar 28, 6:52 AM
RKSimon committed rL298914: [X86][SSE] Begin merging vector shuffle to BLEND for lowering and combining..
[X86][SSE] Begin merging vector shuffle to BLEND for lowering and combining.
Tue, Mar 28, 6:18 AM
RKSimon committed rL298911: Wdocumentation fix.
Wdocumentation fix
Tue, Mar 28, 5:41 AM
RKSimon committed rL298910: [X86][SSE] Set second operand to undef instead of first operand in unary….
[X86][SSE] Set second operand to undef instead of first operand in unary…
Tue, Mar 28, 5:29 AM
RKSimon committed rL298909: Strip trailing whitespace.
Strip trailing whitespace
Tue, Mar 28, 4:27 AM

Mon, Mar 27

RKSimon added inline comments to D31403: [SDAG] Deal with deleted node in PromoteIntShiftOp.
Mon, Mar 27, 12:57 PM
RKSimon added a reviewer for D31398: [X86][X86 intrinsics]Folding cmp(sub(a,b),0) into cmp(a,b) optimization: spatel.

Please make sure you always include llvm-commits as a subscriber in future patches.

Mon, Mar 27, 8:58 AM
RKSimon added a comment to D31346: [SDAG] Fix Stale SDNode usage in visitAND.

LGTM @jnspaulsson do you have any comments?

Mon, Mar 27, 8:10 AM

Sun, Mar 26

RKSimon added a comment to D30868: [X86][MMX] Match MMX fp_to_sint conversions from XMM registers.

ping?

Sun, Mar 26, 10:57 AM
RKSimon committed rL298813: Fix signed/unsigned comparison warnings..
Fix signed/unsigned comparison warnings.
Sun, Mar 26, 10:52 AM
RKSimon committed rL298807: Fix signed/unsigned comparison warnings..
Fix signed/unsigned comparison warnings.
Sun, Mar 26, 7:11 AM
RKSimon committed rL298806: [X86][SSE] Add computeKnownBitsForTargetNode support for (V)PSLL/(V)PSRL….
[X86][SSE] Add computeKnownBitsForTargetNode support for (V)PSLL/(V)PSRL…
Sun, Mar 26, 6:30 AM
RKSimon committed rL298805: [X86][AVX512F] Fix reg class for VMOVSSZrr/VMOVSSZrrk and VMOVSDZrr/VMOVSDZrrk.
[X86][AVX512F] Fix reg class for VMOVSSZrr/VMOVSSZrrk and VMOVSDZrr/VMOVSDZrrk
Sun, Mar 26, 6:05 AM
RKSimon closed D31200: [X86][AVX512F] Fix reg class for VMOVSSZrr/VMOVSSZrrk and VMOVSDZrr/VMOVSDZrrk by committing rL298805: [X86][AVX512F] Fix reg class for VMOVSSZrr/VMOVSSZrrk and VMOVSDZrr/VMOVSDZrrk.
Sun, Mar 26, 6:05 AM
RKSimon created D31373: [X86][SSE]] Lower BUILD_VECTOR with repeated ops as BUILD_VECTOR + VECTOR_SHUFFLE.
Sun, Mar 26, 5:58 AM
RKSimon committed rL298804: Fix MSVC signed/unsigned comparison warnings..
Fix MSVC signed/unsigned comparison warnings.
Sun, Mar 26, 4:29 AM
RKSimon committed rL298803: Regenerate test.
Regenerate test
Sun, Mar 26, 3:45 AM
RKSimon committed rL298802: Regenerate test.
Regenerate test
Sun, Mar 26, 3:44 AM
RKSimon committed rL298801: Regenerate tests to remove duplicated checks.
Regenerate tests to remove duplicated checks
Sun, Mar 26, 3:41 AM

Sat, Mar 25

RKSimon committed rL298783: [X86] Pull out repeated ScalarValueSizeInBits code. NFCI..
[X86] Pull out repeated ScalarValueSizeInBits code. NFCI.
Sat, Mar 25, 2:34 PM
RKSimon committed rL298782: [X86][SSE] Combine (VSRLI (VSRAI X, Y), (NumSignBits-1)) -> (VSRLI X….
[X86][SSE] Combine (VSRLI (VSRAI X, Y), (NumSignBits-1)) -> (VSRLI X…
Sat, Mar 25, 1:55 PM
RKSimon committed rL298780: [X86][SSE] Added ComputeNumSignBitsForTargetNode support for (V)PSRAI.
[X86][SSE] Added ComputeNumSignBitsForTargetNode support for (V)PSRAI
Sat, Mar 25, 1:11 PM
RKSimon closed D31347: [X86][SSE] Generalised CMP+AND1 combine to ZERO/ALLBITS+MASK by committing rL298779: [X86][SSE] Generalised CMP+AND1 combine to ZERO/ALLBITS+MASK.
Sat, Mar 25, 1:02 PM
RKSimon committed rL298779: [X86][SSE] Generalised CMP+AND1 combine to ZERO/ALLBITS+MASK.
[X86][SSE] Generalised CMP+AND1 combine to ZERO/ALLBITS+MASK
Sat, Mar 25, 1:02 PM
RKSimon updated the diff for D31311: [DAGCombiner] Add vector demanded elements support to ComputeNumSignBits.

Updated with support for INSERT_VECTOR_ELT which is used by the i686 tests - and BUILD_VECTOR is tested with the x86_64 tests.

Sat, Mar 25, 12:27 PM
RKSimon committed rL298774: [X86][SSE] Add extra computeNumSignBits test case for D31311..
[X86][SSE] Add extra computeNumSignBits test case for D31311.
Sat, Mar 25, 8:56 AM

Fri, Mar 24

RKSimon committed rL298751: Apply clang-format as commented in D31311. NFCI..
Apply clang-format as commented in D31311. NFCI.
Fri, Mar 24, 5:00 PM
RKSimon added inline comments to D31311: [DAGCombiner] Add vector demanded elements support to ComputeNumSignBits.
Fri, Mar 24, 4:53 PM
RKSimon updated the diff for D31347: [X86][SSE] Generalised CMP+AND1 combine to ZERO/ALLBITS+MASK.

Updated based on Sanjay's feedback

Fri, Mar 24, 4:20 PM
RKSimon added inline comments to D31311: [DAGCombiner] Add vector demanded elements support to ComputeNumSignBits.
Fri, Mar 24, 12:07 PM
RKSimon added inline comments to D31346: [SDAG] Fix Stale SDNode usage in visitAND.
Fri, Mar 24, 12:02 PM
RKSimon created D31347: [X86][SSE] Generalised CMP+AND1 combine to ZERO/ALLBITS+MASK.
Fri, Mar 24, 11:44 AM
RKSimon committed rL298716: [X86][SSE] Add ashr + mask test cases..
[X86][SSE] Add ashr + mask test cases.
Fri, Mar 24, 10:38 AM
RKSimon committed rL298712: Fix MSVC 'not all control paths return a value' warning..
Fix MSVC 'not all control paths return a value' warning.
Fri, Mar 24, 10:11 AM
RKSimon committed rL298704: [X86][SSE] Generalised lowerTruncate by PACKSS to work with any 'zero/all bits'….
[X86][SSE] Generalised lowerTruncate by PACKSS to work with any 'zero/all bits'…
Fri, Mar 24, 9:25 AM
RKSimon updated the diff for D31200: [X86][AVX512F] Fix reg class for VMOVSSZrr/VMOVSSZrrk and VMOVSDZrr/VMOVSDZrrk.

Fixed missed patterns

Fri, Mar 24, 6:33 AM
RKSimon added inline comments to D31148: [SDAG] Avoid deleted SDNodes PromoteIntBinOp.
Fri, Mar 24, 4:31 AM

Thu, Mar 23

RKSimon created D31311: [DAGCombiner] Add vector demanded elements support to ComputeNumSignBits.
Thu, Mar 23, 3:04 PM
RKSimon committed rL298616: [X86][SSE] Extract elements from narrower shuffle masks..
[X86][SSE] Extract elements from narrower shuffle masks.
Thu, Mar 23, 9:22 AM
RKSimon committed rL298594: [X86][SSE] Tidyup canWidenShuffleElements. NFCI..
[X86][SSE] Tidyup canWidenShuffleElements. NFCI.
Thu, Mar 23, 6:45 AM
RKSimon accepted D31254: [SDAG] Fix zeroExtend assertion error.

LGTM

Thu, Mar 23, 6:36 AM
RKSimon committed rL298592: [X86][SSE] Add computeNumSignBits test for sitofp of (extended) i64 extracted….
[X86][SSE] Add computeNumSignBits test for sitofp of (extended) i64 extracted…
Thu, Mar 23, 6:30 AM

Wed, Mar 22

RKSimon updated subscribers of D30625: Enable machine code verification with EXPENSIVE_CHECKS..
Wed, Mar 22, 3:38 PM
RKSimon created D31249: [DAGCombiner] Add vector demanded elements support to computeKnownBitsForTargetNode.
Wed, Mar 22, 11:50 AM
RKSimon committed rL298511: [X86][MMX] Add tests for _mm_set*_* intrinsics.
[X86][MMX] Add tests for _mm_set*_* intrinsics
Wed, Mar 22, 8:08 AM
RKSimon added inline comments to D31148: [SDAG] Avoid deleted SDNodes PromoteIntBinOp.
Wed, Mar 22, 7:44 AM
RKSimon added inline comments to D31148: [SDAG] Avoid deleted SDNodes PromoteIntBinOp.
Wed, Mar 22, 7:40 AM
RKSimon committed rL298497: [X86] Add multiply by constant tests (PR28513).
[X86] Add multiply by constant tests (PR28513)
Wed, Mar 22, 5:16 AM
RKSimon committed rL298495: [X86] Remove unnecessary duplicate code (PR30649). NFCI..
[X86] Remove unnecessary duplicate code (PR30649). NFCI.
Wed, Mar 22, 4:36 AM
RKSimon updated subscribers of D30625: Enable machine code verification with EXPENSIVE_CHECKS..

If at all possible I'd prefer to get some triage done on a majority of the bugs first before avoiding the problem in this way - my concern is that XFAIL tagging will be used just to ignore lurking problems that will bite back later on.

Wed, Mar 22, 4:32 AM

Tue, Mar 21

RKSimon created D31200: [X86][AVX512F] Fix reg class for VMOVSSZrr/VMOVSSZrrk and VMOVSDZrr/VMOVSDZrrk.
Tue, Mar 21, 12:21 PM
RKSimon committed rL298381: Fix shufpd test name..
Fix shufpd test name.
Tue, Mar 21, 8:25 AM
RKSimon added inline comments to D30468: Simplify the CFG after loop pass cleanup..
Tue, Mar 21, 6:51 AM
RKSimon committed rL298370: [X86][AVX] Tests showing missing SHUFPD + ZERO lowering.
[X86][AVX] Tests showing missing SHUFPD + ZERO lowering
Tue, Mar 21, 6:43 AM
RKSimon added a comment to D30941: Better testing of schedule model instruction latencies/throughputs.
Tue, Mar 21, 6:36 AM
RKSimon committed rL298364: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305).
[X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305)
Tue, Mar 21, 5:58 AM
RKSimon closed D31155: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305) by committing rL298364: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305).
Tue, Mar 21, 5:58 AM
RKSimon accepted D31156: [x86] use PMOVMSK for vector-sized equality comparisons.

LGTM

Tue, Mar 21, 4:37 AM
RKSimon accepted D31077: Improve DAGTypeLegalizer::PromoteIntRes_TRUNCATE() to handle widening..

LGTM

Tue, Mar 21, 2:42 AM

Mon, Mar 20

RKSimon created D31155: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305).
Mon, Mar 20, 3:51 PM
RKSimon committed rL298286: Fixed include order. NFCI..
Fixed include order. NFCI.
Mon, Mar 20, 11:45 AM
RKSimon added inline comments to D30941: Better testing of schedule model instruction latencies/throughputs.
Mon, Mar 20, 11:31 AM
RKSimon committed rL298253: Use MutableArrayRef for APFloat::convertToInteger.
Use MutableArrayRef for APFloat::convertToInteger
Mon, Mar 20, 7:52 AM
RKSimon added a comment to D29872: Do not legalize large add with addc/adde, introduce addcarry and do it with uaddo/addcarry.

A few minors for you to look at

Mon, Mar 20, 7:32 AM
RKSimon committed rL298249: Strip trailing whitespace.
Strip trailing whitespace
Mon, Mar 20, 7:08 AM
RKSimon committed rL298248: Strip trailing whitespace.
Strip trailing whitespace
Mon, Mar 20, 7:06 AM
RKSimon committed rL298247: Strip trailing whitespace.
Strip trailing whitespace
Mon, Mar 20, 7:06 AM

Sun, Mar 19

RKSimon committed rL298226: Fix constant folding of fp2int to large integers.
Fix constant folding of fp2int to large integers
Sun, Mar 19, 10:02 AM
RKSimon closed D31074: Fix constant folding of fp2int to large integers by committing rL298226: Fix constant folding of fp2int to large integers.
Sun, Mar 19, 10:02 AM
RKSimon committed rL298225: Fix MSVC warning: "switch statement contains 'default' but no 'case' labels"..
Fix MSVC warning: "switch statement contains 'default' but no 'case' labels".
Sun, Mar 19, 9:51 AM

Fri, Mar 17

RKSimon committed rL298108: [SelectionDAG] Add SelectionDAG.computeKnownBits test support for ISD::ABS.
[SelectionDAG] Add SelectionDAG.computeKnownBits test support for ISD::ABS
Fri, Mar 17, 10:58 AM
RKSimon committed rL298103: [X86] Add SelectionDAG.computeKnownBits test showing inability to handle ISD….
[X86] Add SelectionDAG.computeKnownBits test showing inability to handle ISD…
Fri, Mar 17, 10:10 AM
RKSimon added inline comments to D31077: Improve DAGTypeLegalizer::PromoteIntRes_TRUNCATE() to handle widening..
Fri, Mar 17, 9:09 AM
RKSimon added a reviewer for D31077: Improve DAGTypeLegalizer::PromoteIntRes_TRUNCATE() to handle widening.: RKSimon.
Fri, Mar 17, 8:17 AM
RKSimon created D31074: Fix constant folding of fp2int to large integers.
Fri, Mar 17, 5:04 AM
RKSimon added a comment to D31030: [AMDGPU] Fix bug in S_MOVREL check (PR32248).

Looks ok to me, but I just created the original patch to fix the pvs warning.

Fri, Mar 17, 3:06 AM
RKSimon accepted D30317: [X86] Clean up test/CodeGen/X86/2006-03-01-InstrSchedBug.ll.

LGTM

Fri, Mar 17, 2:50 AM

Thu, Mar 16

RKSimon added a comment to D30317: [X86] Clean up test/CodeGen/X86/2006-03-01-InstrSchedBug.ll.
Thu, Mar 16, 4:17 PM
RKSimon committed rL297976: Remove redundant conditions (PR31753). NFCI..
Remove redundant conditions (PR31753). NFCI.
Thu, Mar 16, 1:04 PM
RKSimon added a comment to D30468: Simplify the CFG after loop pass cleanup..

No other comments from me.

Thu, Mar 16, 12:12 PM
RKSimon added inline comments to D31030: [AMDGPU] Fix bug in S_MOVREL check (PR32248).
Thu, Mar 16, 10:57 AM
RKSimon added a comment to D29489: Optimize SETCC + VSEL of incompatible or illegal types.

@Uli: Do the new SystemZ tests and the script update look fine to you?

LGTM.

Thu, Mar 16, 8:26 AM
RKSimon committed rL297957: [X86] Add PR22338 test case.
[X86] Add PR22338 test case
Thu, Mar 16, 8:23 AM
RKSimon added a comment to D30941: Better testing of schedule model instruction latencies/throughputs.

The implementation was moved to target independent area and all Hal's comments were applied. I did not do anything with Throughput: it will be done in the patch.

Do you mean that the throughput will be done in a follow-up patch (or a later revision of this one)? Either is fine with me, although if we're going to add more than latencies we might pick a different name. More later...

Thu, Mar 16, 6:55 AM
RKSimon created D31030: [AMDGPU] Fix bug in S_MOVREL check (PR32248).
Thu, Mar 16, 6:52 AM

Wed, Mar 15

RKSimon committed rL297915: Remove redundant condition (PR32263). NFCI..
Remove redundant condition (PR32263). NFCI.
Wed, Mar 15, 4:39 PM
RKSimon committed rL297906: Removed unnecessary semicolon. NFCI..
Removed unnecessary semicolon. NFCI.
Wed, Mar 15, 4:02 PM
RKSimon committed rL297905: Remove repeated code (PR32250). NFCI..
Remove repeated code (PR32250). NFCI.
Wed, Mar 15, 3:55 PM
RKSimon committed rL297885: [X86][XOP] Add codegen tests for vector integer comparison intrinsics (PR15844).
[X86][XOP] Add codegen tests for vector integer comparison intrinsics (PR15844)
Wed, Mar 15, 2:11 PM
RKSimon committed rL297876: [X86] Add missing BITREVERSE costs for SSE2 vectors and i8/i16/i32/i64 scalars.
[X86] Add missing BITREVERSE costs for SSE2 vectors and i8/i16/i32/i64 scalars
Wed, Mar 15, 12:47 PM