RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (188 w, 1 d)

Recent Activity

Today

RKSimon created D41119: [X86][SSE] MOVMSK only uses the sign bit from each vector element.
Tue, Dec 12, 9:59 AM
RKSimon committed rL320492: [X86] Remove CompleteModel tags from CPU targets until we have better error….
[X86] Remove CompleteModel tags from CPU targets until we have better error…
Tue, Dec 12, 8:13 AM
RKSimon updated subscribers of rL320461: [X86] Use regular expressions more aggressively to reduce the number of….

@craig.topper Sorry but I had to revert this as its causing an ICE on windows builds:

Tue, Dec 12, 3:36 AM
RKSimon committed rL320470: Revert r320461 - causing ICE in windows buildss.
Revert r320461 - causing ICE in windows buildss
Tue, Dec 12, 3:35 AM

Yesterday

RKSimon committed rL320403: [X86] Add LODS schedule tests.
[X86] Add LODS schedule tests
Mon, Dec 11, 10:40 AM
RKSimon committed rL320402: [X86] Add CMP/TEST schedule tests.
[X86] Add CMP/TEST schedule tests
Mon, Dec 11, 10:33 AM
RKSimon committed rL320400: [X86] Add AND/OR/XOR schedule tests.
[X86] Add AND/OR/XOR schedule tests
Mon, Dec 11, 10:24 AM
RKSimon committed rL320397: [X86] Add ADD/SUB schedule tests.
[X86] Add ADD/SUB schedule tests
Mon, Dec 11, 10:14 AM
RKSimon added inline comments to D40067: [X86] Update BTVER2 sched numbers for some AVX instructions (xmm version).
Mon, Dec 11, 10:12 AM
RKSimon committed rL320395: [X86] Add ADC/SBB schedule tests.
[X86] Add ADC/SBB schedule tests
Mon, Dec 11, 9:59 AM
RKSimon committed rL320392: [X86] Add MOVSLQ schedule tests.
[X86] Add MOVSLQ schedule tests
Mon, Dec 11, 9:38 AM
RKSimon added inline comments to D40960: Fix for bug PR35549 - [X86] Repeated schedule comments.
Mon, Dec 11, 9:34 AM
RKSimon added a comment to D41072: [InstCombine] Fix PR35618: Instcombine hangs on single minmax load bitcast..

Isn't that PR35618? Typo in subject line.

Mon, Dec 11, 9:28 AM
RKSimon committed rL320389: Normalize line endings. NFCI..
Normalize line endings. NFCI.
Mon, Dec 11, 9:02 AM
RKSimon committed rL320387: [X86] Add LWP schedule tests.
[X86] Add LWP schedule tests
Mon, Dec 11, 8:48 AM
RKSimon committed rL320386: [X86] Add INT/INTO schedule tests.
[X86] Add INT/INTO schedule tests
Mon, Dec 11, 8:33 AM
RKSimon committed rL320385: [X86] Add IN/OUT schedule tests.
[X86] Add IN/OUT schedule tests
Mon, Dec 11, 8:17 AM
RKSimon committed rL320384: [X86] Add IDIV schedule tests.
[X86] Add IDIV schedule tests
Mon, Dec 11, 8:09 AM
RKSimon committed rL320383: [X86] Add CMPXCHG schedule tests.
[X86] Add CMPXCHG schedule tests
Mon, Dec 11, 8:04 AM
RKSimon committed rL320382: [X86] Add CLZERO schedule test.
[X86] Add CLZERO schedule test
Mon, Dec 11, 7:54 AM
RKSimon committed rL320380: [X86] Add ADCX/ADOX/XADD/XLAT schedule tests.
[X86] Add ADCX/ADOX/XADD/XLAT schedule tests
Mon, Dec 11, 7:42 AM
RKSimon committed rL320376: [X86] Add SETCC/STC/STD/UD2 schedule tests.
[X86] Add SETCC/STC/STD/UD2 schedule tests
Mon, Dec 11, 7:26 AM
RKSimon committed rL320371: [X86] Add SAR/SHL/SHR schedule tests.
[X86] Add SAR/SHL/SHR schedule tests
Mon, Dec 11, 6:57 AM
RKSimon committed rL320370: [X86] Add RCL/RCR schedule tests.
[X86] Add RCL/RCR schedule tests
Mon, Dec 11, 6:47 AM
RKSimon committed rL320361: [X86] Add fsgsbase schedule tests..
[X86] Add fsgsbase schedule tests.
Mon, Dec 11, 5:25 AM
RKSimon committed rL320356: [X86] Regenerate fsgsbase intrinsic tests. NFCI..
[X86] Regenerate fsgsbase intrinsic tests. NFCI.
Mon, Dec 11, 4:23 AM

Sun, Dec 10

RKSimon committed rL320334: [X86] Add ROL/ROR schedule tests.
[X86] Add ROL/ROR schedule tests
Sun, Dec 10, 2:12 PM
RKSimon committed rL320333: [X86] Add DIV/MUL/NEG/NOP/NOT/PAUSE schedule tests.
[X86] Add DIV/MUL/NEG/NOP/NOT/PAUSE schedule tests
Sun, Dec 10, 1:57 PM
RKSimon committed rL320332: [X86] Add DEC/INC schedule tests.
[X86] Add DEC/INC schedule tests
Sun, Dec 10, 1:28 PM
RKSimon committed rL320331: [X86] Add INS/OUTS schedule tests.
[X86] Add INS/OUTS schedule tests
Sun, Dec 10, 1:11 PM
RKSimon committed rL320330: [X86] Add CMPS/MOVS/SCAS/STOS schedule tests.
[X86] Add CMPS/MOVS/SCAS/STOS schedule tests
Sun, Dec 10, 12:59 PM
RKSimon committed rL320329: [X86] Add CMOV schedule tests.
[X86] Add CMOV schedule tests
Sun, Dec 10, 12:47 PM
RKSimon committed rL320328: [X86] Add BT/BTC/BTR/BTS schedule tests.
[X86] Add BT/BTC/BTR/BTS schedule tests
Sun, Dec 10, 12:23 PM
RKSimon committed rL320322: [X86][X87] Fix typo in znver1 FIST/FISTT schedule patterns.
[X86][X87] Fix typo in znver1 FIST/FISTT schedule patterns
Sun, Dec 10, 11:20 AM
RKSimon accepted D41040: [DAGCombiner] protect against an infinite loop between shl <--> mul (PR35579).

OK, let's go with this then. LGTM

Sun, Dec 10, 10:56 AM
RKSimon committed rL320321: [X86][X87] Add missing x87 scheduler tests.
[X86][X87] Add missing x87 scheduler tests
Sun, Dec 10, 10:53 AM
RKSimon added a reviewer for D41040: [DAGCombiner] protect against an infinite loop between shl <--> mul (PR35579): RKSimon.
Sun, Dec 10, 9:09 AM
RKSimon committed rL320308: [X86] Flag BroadWell scheduler model as complete.
[X86] Flag BroadWell scheduler model as complete
Sun, Dec 10, 5:50 AM
RKSimon committed rL320307: Regenerate some AVX2+ scheduling tests that got missed.
Regenerate some AVX2+ scheduling tests that got missed
Sun, Dec 10, 5:42 AM
RKSimon committed rL320306: Strip trailing whitespace. NFCI..
Strip trailing whitespace. NFCI.
Sun, Dec 10, 5:01 AM
RKSimon committed rL320305: Regenerate some scheduling tests that got missed.
Regenerate some scheduling tests that got missed
Sun, Dec 10, 5:00 AM
RKSimon committed rL320304: [X86] Flag ZNVER1 scheduler model as complete.
[X86] Flag ZNVER1 scheduler model as complete
Sun, Dec 10, 4:44 AM
RKSimon committed rL320303: [X86] Flag SLM scheduler model as complete.
[X86] Flag SLM scheduler model as complete
Sun, Dec 10, 4:37 AM
RKSimon committed rL320302: [X86][AVX[ Tag VZEROALL/VZEROUPPER instructions scheduler classes.
[X86][AVX[ Tag VZEROALL/VZEROUPPER instructions scheduler classes
Sun, Dec 10, 4:27 AM
RKSimon committed rL320301: [X86] Tag SSE4A instructions as SSE INTALU scheduler classes.
[X86] Tag SSE4A instructions as SSE INTALU scheduler classes
Sun, Dec 10, 4:08 AM
RKSimon committed rL320300: [X86] Flag BTVER2 scheduler model as complete.
[X86] Flag BTVER2 scheduler model as complete
Sun, Dec 10, 3:52 AM
RKSimon committed rL320299: [X86] Tag ADJSTACK instructions as INTALU scheduler class.
[X86] Tag ADJSTACK instructions as INTALU scheduler class
Sun, Dec 10, 3:34 AM
RKSimon committed rC320297: Fix MSVC 'not all control paths return a value' warning.
Fix MSVC 'not all control paths return a value' warning
Sun, Dec 10, 3:06 AM
RKSimon committed rL320297: Fix MSVC 'not all control paths return a value' warning.
Fix MSVC 'not all control paths return a value' warning
Sun, Dec 10, 3:05 AM
RKSimon committed rL320296: [X86] Tag MORESTACK instructions as ret scheduler class.
[X86] Tag MORESTACK instructions as ret scheduler class
Sun, Dec 10, 2:09 AM

Sat, Dec 9

RKSimon committed rL320276: [X86] Tag PIC setup instruction as jump scheduler class.
[X86] Tag PIC setup instruction as jump scheduler class
Sat, Dec 9, 4:41 PM
RKSimon committed rL320275: [X86] Tag ACQUIRE/RELEASE atomic instructions as microcoded scheduler classes.
[X86] Tag ACQUIRE/RELEASE atomic instructions as microcoded scheduler classes
Sat, Dec 9, 4:31 PM
RKSimon committed rL320274: [X86] Tag TLS instructions as system scheduler classes.
[X86] Tag TLS instructions as system scheduler classes
Sat, Dec 9, 4:13 PM
RKSimon committed rL320273: [X86] Tag ALLOCA/VAARG instructions as system scheduler classes.
[X86] Tag ALLOCA/VAARG instructions as system scheduler classes
Sat, Dec 9, 4:03 PM
RKSimon committed rL320270: [InstCombine] Fix SimplifyDemandedUseBits SHL handling (PR35515).
[InstCombine] Fix SimplifyDemandedUseBits SHL handling (PR35515)
Sat, Dec 9, 3:43 PM
RKSimon committed rL320266: [X86] Tag LOCK/REX64/DATA16/DATA32 instruction prefix scheduler classes.
[X86] Tag LOCK/REX64/DATA16/DATA32 instruction prefix scheduler classes
Sat, Dec 9, 1:27 PM
RKSimon committed rL320265: Strip trailing whitespace. NFCI..
Strip trailing whitespace. NFCI.
Sat, Dec 9, 12:45 PM
RKSimon committed rL320264: [X86] Tag FS/GS BASE R/W instruction scheduler classes.
[X86] Tag FS/GS BASE R/W instruction scheduler classes
Sat, Dec 9, 12:43 PM
RKSimon committed rL320263: [X86] Tag REP/REPNE prefix instructions as microcoded scheduler classes.
[X86] Tag REP/REPNE prefix instructions as microcoded scheduler classes
Sat, Dec 9, 12:17 PM
RKSimon committed rL320262: [X86] Tag missing EH pseudo instruction scheduler classes.
[X86] Tag missing EH pseudo instruction scheduler classes
Sat, Dec 9, 12:04 PM
RKSimon committed rL320261: [X86] Tag frame pointer XORs instruction scheduler classes.
[X86] Tag frame pointer XORs instruction scheduler classes
Sat, Dec 9, 11:57 AM
RKSimon added inline comments to D40960: Fix for bug PR35549 - [X86] Repeated schedule comments.
Sat, Dec 9, 9:37 AM
RKSimon committed rL320257: [X86] Tag segment prefixes as NOP instruction scheduling classes.
[X86] Tag segment prefixes as NOP instruction scheduling classes
Sat, Dec 9, 8:59 AM
RKSimon added inline comments to D38300: [x86] Correct the implementation of isTruncateFree to be more accurate.
Sat, Dec 9, 8:55 AM
RKSimon committed rL320255: [X86][AVX512] Drop a default NoItinerary argument that isn't used any more..
[X86][AVX512] Drop a default NoItinerary argument that isn't used any more.
Sat, Dec 9, 8:21 AM
RKSimon committed rL320254: Fix 'enumeral and non-enumeral type in conditional expression' gcc warning..
Fix 'enumeral and non-enumeral type in conditional expression' gcc warning.
Sat, Dec 9, 8:20 AM
RKSimon committed rL320253: Fix signed/unsigned gcc warning. NFCI..
Fix signed/unsigned gcc warning. NFCI.
Sat, Dec 9, 8:05 AM

Fri, Dec 8

RKSimon committed rL320193: [X86] CMOV pseudo instructions shouldn't need scheduling info as they should be….
[X86] CMOV pseudo instructions shouldn't need scheduling info as they should be…
Fri, Dec 8, 12:43 PM
RKSimon committed rL320192: [X86][X87] Tag x87 load/store instructions scheduler classes.
[X86][X87] Tag x87 load/store instructions scheduler classes
Fri, Dec 8, 12:32 PM
RKSimon committed rL320189: [X86][X87] Tag x87 float compare instructions scheduler classes.
[X86][X87] Tag x87 float compare instructions scheduler classes
Fri, Dec 8, 12:11 PM
RKSimon committed rL320177: [X86][MPX] Tag TSX/HLE/SGX instructions scheduler classes.
[X86][MPX] Tag TSX/HLE/SGX instructions scheduler classes
Fri, Dec 8, 11:27 AM
RKSimon committed rL320173: [X86][MPX] Tag MPX instructions scheduler classes.
[X86][MPX] Tag MPX instructions scheduler classes
Fri, Dec 8, 11:04 AM
RKSimon committed rL320169: [X86] Tag move immediate instructions scheduler classes.
[X86] Tag move immediate instructions scheduler classes
Fri, Dec 8, 10:36 AM
RKSimon committed rL320161: [X86][SHA] Tag SHA instructions scheduler classes.
[X86][SHA] Tag SHA instructions scheduler classes
Fri, Dec 8, 8:39 AM
RKSimon added a comment to D40865: X86 AVX2: Prefer one VPERMV over ShuffleAsRepeatedMaskAndLanePermute.
In D40865#948072, @zvi wrote:

@RKSimon, I'm not too familiar with the MachineCombiner. Are there already any shuffle cases that are handled or was that wishful thinking? :)

Fri, Dec 8, 8:23 AM
RKSimon committed rL320159: [X86] Tag VIA PadLock crypto instructions scheduler classes.
[X86] Tag VIA PadLock crypto instructions scheduler classes
Fri, Dec 8, 8:07 AM
RKSimon committed rL320158: [X86] Tag PKU/INVPCID/RDPID/SMAP/SMX/PTWRITE system instructions scheduler….
[X86] Tag PKU/INVPCID/RDPID/SMAP/SMX/PTWRITE system instructions scheduler…
Fri, Dec 8, 7:49 AM
RKSimon committed rL320156: [X86][AVX512] Tag CLWB instruction to CLFLUSH/PREFETCH scheduler class.
[X86][AVX512] Tag CLWB instruction to CLFLUSH/PREFETCH scheduler class
Fri, Dec 8, 7:19 AM
RKSimon committed rL320154: [X86][AVX512] Tag AVX512_512_SEXT_MASK_* instructions scheduler classes.
[X86][AVX512] Tag AVX512_512_SEXT_MASK_* instructions scheduler classes
Fri, Dec 8, 7:18 AM

Thu, Dec 7

RKSimon committed rL320065: [X86] Replace tabs with spaces. NFCI..
[X86] Replace tabs with spaces. NFCI.
Thu, Dec 7, 9:55 AM
RKSimon committed rL320064: [X86] Tag BMI/BMI2/TBM instructions scheduler classes.
[X86] Tag BMI/BMI2/TBM instructions scheduler classes
Thu, Dec 7, 9:38 AM
RKSimon committed rL320062: [X86][TBM] Add TBM scheduling tests.
[X86][TBM] Add TBM scheduling tests
Thu, Dec 7, 9:23 AM
RKSimon committed rL320055: [X86] Tag SALC instructions scheduler class.
[X86] Tag SALC instructions scheduler class
Thu, Dec 7, 8:07 AM
RKSimon committed rL320054: [X86] Add LAHF/SAHF scheduling test.
[X86] Add LAHF/SAHF scheduling test
Thu, Dec 7, 8:05 AM
RKSimon committed rL320053: [X86][VMX] Tag VMX instructions scheduler classes.
[X86][VMX] Tag VMX instructions scheduler classes
Thu, Dec 7, 7:58 AM
RKSimon committed rL320052: [X86] Add SALC scheduling test.
[X86] Add SALC scheduling test
Thu, Dec 7, 7:47 AM
RKSimon committed rL320051: [X86] Tag LZCNT/TZCNT instructions scheduler classes.
[X86] Tag LZCNT/TZCNT instructions scheduler classes
Thu, Dec 7, 7:24 AM
RKSimon reopened D35014: [X86] Improvement in CodeGen instruction selection for LEAs..

rL319543 was reverted at rL319591 due to asan bot breakage

Thu, Dec 7, 7:19 AM
RKSimon accepted D40021: [X86][Haswell]: Updating the scheduling information for the Haswell subtarget..

LGTM, thanks

Thu, Dec 7, 6:56 AM
RKSimon committed rL320048: [X86][FMA] Regenerate fma schedule tests.
[X86][FMA] Regenerate fma schedule tests
Thu, Dec 7, 6:52 AM
RKSimon committed rL320047: [X86][SVM] Tag SVM instructions scheduler classes.
[X86][SVM] Tag SVM instructions scheduler classes
Thu, Dec 7, 6:36 AM
RKSimon committed rL320045: [X86] Tag RDRAND/RDSEED instruction scheduler classes.
[X86] Tag RDRAND/RDSEED instruction scheduler classes
Thu, Dec 7, 6:19 AM
RKSimon committed rL320044: [X86][X87] X87 math binop pseudo instructions don't need scheduling info.
[X86][X87] X87 math binop pseudo instructions don't need scheduling info
Thu, Dec 7, 6:07 AM
RKSimon committed rL320043: [X86][SSE42] SSE42 string pseudo instructions don't need scheduling info.
[X86][SSE42] SSE42 string pseudo instructions don't need scheduling info
Thu, Dec 7, 5:52 AM
RKSimon committed rL320042: [X86] Regenerate RDTSC codegen tests.
[X86] Regenerate RDTSC codegen tests
Thu, Dec 7, 5:51 AM
RKSimon committed rL320040: [X86][RDSEED] Add rdseed scheduling tests.
[X86][RDSEED] Add rdseed scheduling tests
Thu, Dec 7, 5:47 AM
RKSimon committed rL320039: [X86][RDRAND] Add rdrand scheduling tests.
[X86][RDRAND] Add rdrand scheduling tests
Thu, Dec 7, 5:47 AM
RKSimon added a comment to D40865: X86 AVX2: Prefer one VPERMV over ShuffleAsRepeatedMaskAndLanePermute.

This looks like another case for a scheduler driven shuffle combine, possibly in the MC like D40602, although I'm still not sure if that is late enough to properly account for the increase in register pressure from the shuffle mask load.

Thu, Dec 7, 2:02 AM

Wed, Dec 6

RKSimon committed rL319945: [X86][AVX512] Tag mask reg op instruction scheduler classes.
[X86][AVX512] Tag mask reg op instruction scheduler classes
Wed, Dec 6, 11:36 AM
RKSimon committed rL319921: [X86][SSE] Regenerate vpmovm2*/vpmov*2m avx512 schedule tests.
[X86][SSE] Regenerate vpmovm2*/vpmov*2m avx512 schedule tests
Wed, Dec 6, 10:48 AM