Page MenuHomePhabricator

friss (Frederic Riss)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2014, 1:00 AM (262 w, 6 d)

Recent Activity

Mon, Sep 16

friss added a comment to D67520: Add pretty printing of Clang "bitfield" enums.

This looks like a really useful feature. The code seems fine, but I am wondering if we should really bail out when encountering a zero enumerator. It is not uncommon to use a special enumerator to mean "none of the above". Lldb does that occasionally (eEmulateInstructionOptionNone), and other APIs do that too (PROT_NONE, PROT_READ, PROT_WRITE, PROT_EXEC in mmap(2) for instance). I am guessing this practice is even more common for "class" enums, as those can't be implicitly constructed from integer constants.

I think it would be useful to add one or two tests with enum types where this heuristic does not kick in. Like a type which has a two-bit enumerator which is not covered by previous enumerators, or (if you decide to keep the current behavior) a type with a zero enumerator.

Mon, Sep 16, 8:26 AM

Thu, Sep 12

friss created D67520: Add pretty printing of Clang "bitfield" enums.
Thu, Sep 12, 1:59 PM

Wed, Sep 11

friss accepted D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols.

This LGTM, in principle, but it's weird to add the testing in a skipped test. I trust that it works on your machine, but we won't know if it works on all the tested configurations. Can committing this wait for the perf issue to be fixed? Do you know how much work this is going to be?

Wed, Sep 11, 8:18 AM

Tue, Sep 10

friss added inline comments to D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols.
Tue, Sep 10, 3:33 PM

Fri, Sep 6

friss committed rL371265: Request commit access for friss.
Request commit access for friss
Fri, Sep 6, 3:18 PM

Wed, Sep 4

friss added inline comments to D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols.
Wed, Sep 4, 3:41 PM
friss committed rGcc5b509b9eda: Workaround TestConcurrentMany* flakiness in a more pricipled way (authored by friss).
Workaround TestConcurrentMany* flakiness in a more pricipled way
Wed, Sep 4, 9:14 AM
friss committed rL370916: Workaround TestConcurrentMany* flakiness in a more pricipled way.
Workaround TestConcurrentMany* flakiness in a more pricipled way
Wed, Sep 4, 9:14 AM
friss accepted D66742: Obliterate LLDB_CONFIGURATION_BUILDANDINTEGRATION.

I don't see reason to keep this around.

Wed, Sep 4, 8:17 AM · Restricted Project

Tue, Sep 3

friss added inline comments to D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols.
Tue, Sep 3, 10:53 AM

Fri, Aug 30

friss accepted D67012: [lit] Only set DYLD_LIBRARY_PATH for shared builds.

This looks good to me with one small provision:

Fri, Aug 30, 3:28 PM · Restricted Project, Restricted Project

Mon, Aug 26

friss committed rL369930: TestFunctionStarts.py: add synchronization.
TestFunctionStarts.py: add synchronization
Mon, Aug 26, 10:32 AM
friss committed rG7305397a142a: TestFunctionStarts.py: add synchronization (authored by friss).
TestFunctionStarts.py: add synchronization
Mon, Aug 26, 10:26 AM

Fri, Aug 23

friss added inline comments to D66626: Upstream support for macCatalyst Mach-O binaries..
Fri, Aug 23, 10:54 AM · Restricted Project
friss added inline comments to D66626: Upstream support for macCatalyst Mach-O binaries..
Fri, Aug 23, 10:54 AM · Restricted Project
friss accepted D66626: Upstream support for macCatalyst Mach-O binaries..

This generally looks good. Feel free to address the stylistic bits you find relevant in follow-up patches.

Fri, Aug 23, 10:54 AM · Restricted Project

Thu, Aug 22

friss committed rGf88dfd8309b4: TestAppleSimulatorOSType: Pass the --standalone argument to simctl (authored by friss).
TestAppleSimulatorOSType: Pass the --standalone argument to simctl
Thu, Aug 22, 2:44 PM
friss committed rL369709: TestAppleSimulatorOSType: Pass the --standalone argument to simctl.
TestAppleSimulatorOSType: Pass the --standalone argument to simctl
Thu, Aug 22, 2:43 PM

Aug 8 2019

friss added inline comments to D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata.
Aug 8 2019, 9:32 AM · Restricted Project, Restricted Project
friss added a comment to D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata.

I only have distant notions of what this code does, so this question might be completely off: Is this the code that decides whether we need to rewrite the accesses to a variable to go through the __lldb_args structure? If yes, I was surprised to learn recently that we rewrite accesses to global variables at all. I understand why we do it for locals, but why not access globals through standard codegen? If the issue your addressing is the result of this transformation, do you have any idea why we do the transformation in the first place?

Aug 8 2019, 9:29 AM · Restricted Project, Restricted Project

Jul 25 2019

friss added a comment to D65185: Let tablegen generate property definitions.

When we hit that merge conflict issue 2 days ago (which mismatched a property and its enum), the first thing that came to my mind was that a tablegen approach would have prevented it. For some reason it seemed more natural to me, and it still does.

Jul 25 2019, 1:22 PM · Restricted Project, Restricted Project

Jul 11 2019

friss added a comment to D64546: [lldb] Make TestDeletedExecutable more reliable.

This might mitigate the issue, but timeouts like this are bound to fail in some circumstances (machine load, ...). It's more work, but can we instead have the inferior produce an observable side effect (eg, print some output) and synchronize on this?

Jul 11 2019, 7:23 AM · Restricted Project, Restricted Project

Jun 25 2019

friss added a comment to D63745: [CMake] Check that a certificate for lldb is present at build time..

On second thought, let's check that LLDB_CODESIGN_IDENTITY equals lldb_codesign before doing this check.

This question isn't important but I'm kind of curious: Does it have to be called lldb_codesign? Could you have an arbitrary identity and then sign with that, assuming the cert exists, or does debugserver expect a cert with that name exactly?

Jun 25 2019, 12:17 AM · Restricted Project, Restricted Project

May 28 2019

friss added inline comments to D62472: [CMake] LLDB.framework tools handling.
May 28 2019, 11:04 AM · Restricted Project, Restricted Project

May 22 2019

friss committed rGbb2b52769b40: Actaully lock accesses to OptionValueFileSpecList objects (authored by friss).
Actaully lock accesses to OptionValueFileSpecList objects
May 22 2019, 2:57 PM
friss committed rL361440: Actaully lock accesses to OptionValueFileSpecList objects.
Actaully lock accesses to OptionValueFileSpecList objects
May 22 2019, 2:57 PM
friss committed rLLDB361440: Actaully lock accesses to OptionValueFileSpecList objects.
Actaully lock accesses to OptionValueFileSpecList objects
May 22 2019, 2:57 PM

May 10 2019

friss accepted D61759: Switch to FindSymbolsMatchingRegExAndType() from FindFunctions() in FindLibCppStdFunctionCallableInfo().

This seems obviously better, go for it.

May 10 2019, 4:24 PM · Restricted Project
friss added a comment to D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo().

Do you have a testcase triggering this?

May 10 2019, 4:24 PM

May 1 2019

friss accepted D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

Thanks, indeed this looks better.

May 1 2019, 2:33 PM · Restricted Project
friss added inline comments to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
May 1 2019, 1:59 PM · Restricted Project
friss added inline comments to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
May 1 2019, 1:07 PM · Restricted Project
friss added a comment to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

Correct me if I'm wrong, but the test seems overly complicated still. We are testing that we can get the return value of a type that needs to be passed by reference. Calling simple free function Bounds bounds() should trigger this code path, shouldn't it? I would be interested to know wether we do the right thing when passing such a struct by value in the source code too as Clang doesn't seem to differentiate return values and arguments. Something like:

// This structure has a non-trivial copy constructor so
// it needs to be passed by reference.
struct PassByRef {
  PassByRef() = default;
  PassByRef(const PassByRef &p);
May 1 2019, 10:24 AM · Restricted Project

Apr 30 2019

friss accepted D61266: Skip TestClassTemplateParameterPack.py on all platforms.

LGTM if no one else objects.

Apr 30 2019, 9:51 AM

Apr 29 2019

friss added inline comments to D61266: Skip TestClassTemplateParameterPack.py on all platforms.
Apr 29 2019, 2:35 PM
friss requested changes to D61266: Skip TestClassTemplateParameterPack.py on all platforms.

We shouldn't skip the whole test, just the expressions that worked for bad reasons. Calling functions on local variables should work, it's just creating the templated objects that is completely broken.

Apr 29 2019, 12:46 PM

Apr 26 2019

friss committed rGfad0aa1e3a1c: Pass explicit C++ version to test (authored by friss).
Pass explicit C++ version to test
Apr 26 2019, 2:17 PM
friss committed rLLDB359349: Pass explicit C++ version to test.
Pass explicit C++ version to test
Apr 26 2019, 2:14 PM
friss committed rL359349: Pass explicit C++ version to test.
Pass explicit C++ version to test
Apr 26 2019, 2:14 PM
friss committed rGb6661490b42f: TestZMMRegister: use an integer division as intended (authored by friss).
TestZMMRegister: use an integer division as intended
Apr 26 2019, 1:24 PM
friss committed rL359347: TestZMMRegister: use an integer division as intended.
TestZMMRegister: use an integer division as intended
Apr 26 2019, 1:24 PM
friss committed rLLDB359347: TestZMMRegister: use an integer division as intended.
TestZMMRegister: use an integer division as intended
Apr 26 2019, 1:24 PM

Apr 24 2019

friss committed rG2f4967632158: Skip test introduced in r359140 on windows (authored by friss).
Skip test introduced in r359140 on windows
Apr 24 2019, 2:59 PM
friss committed rL359145: Skip test introduced in r359140 on windows.
Skip test introduced in r359140 on windows
Apr 24 2019, 2:59 PM
friss committed rLLDB359145: Skip test introduced in r359140 on windows.
Skip test introduced in r359140 on windows
Apr 24 2019, 2:59 PM
friss committed rG265df39a80da: Fix infinite recursion when calling C++ template functions (authored by friss).
Fix infinite recursion when calling C++ template functions
Apr 24 2019, 2:03 PM
friss committed rL359140: Fix infinite recursion when calling C++ template functions.
Fix infinite recursion when calling C++ template functions
Apr 24 2019, 2:02 PM
friss committed rLLDB359140: Fix infinite recursion when calling C++ template functions.
Fix infinite recursion when calling C++ template functions
Apr 24 2019, 2:02 PM
friss closed D61044: Fix infinite recursion when calling C++ template functions.
Apr 24 2019, 2:02 PM · Restricted Project

Apr 23 2019

friss created D61044: Fix infinite recursion when calling C++ template functions.
Apr 23 2019, 3:48 PM · Restricted Project
friss committed rGacbf0058e93d: Lock accesses to OptionValueFileSpecList objects (authored by friss).
Lock accesses to OptionValueFileSpecList objects
Apr 23 2019, 1:17 PM
friss committed rL359028: Lock accesses to OptionValueFileSpecList objects.
Lock accesses to OptionValueFileSpecList objects
Apr 23 2019, 1:17 PM
friss committed rLLDB359028: Lock accesses to OptionValueFileSpecList objects.
Lock accesses to OptionValueFileSpecList objects
Apr 23 2019, 1:16 PM
friss closed D60468: Lock accesses to OptionValueFileSpecList objects.
Apr 23 2019, 1:16 PM · Restricted Project
friss added a comment to D60468: Lock accesses to OptionValueFileSpecList objects.

There were no objections to the patch, and it fixes a real crash seen in the field so I'm going to check it in.

Apr 23 2019, 11:40 AM · Restricted Project

Apr 18 2019

friss accepted D60862: [CMake] Allow custom extensions for externalized debug info.

Interesting. Cmake scoping rules are still a mystery to me. So when you `set(FOO ...), it's set only for the current scope and in any functions/macros you call in that scope? Then this seems like an ok solution.

Apr 18 2019, 9:12 AM · Restricted Project
friss requested changes to D60862: [CMake] Allow custom extensions for externalized debug info.

Actually, thinking more about this, how do you use it? LLVM_EXTERNALIZE_DEBUGINFO_EXTENSION is a global but this would be different per target.

Apr 18 2019, 8:14 AM · Restricted Project
friss accepted D60862: [CMake] Allow custom extensions for externalized debug info.

LGTM

Apr 18 2019, 7:44 AM · Restricted Project

Apr 17 2019

friss committed rG8ecb7bbe2bab: [CMake] Remove Apple-specific version logic. (authored by friss).
[CMake] Remove Apple-specific version logic.
Apr 17 2019, 11:22 AM
friss committed rLLDB358604: [CMake] Remove Apple-specific version logic..
[CMake] Remove Apple-specific version logic.
Apr 17 2019, 11:22 AM
friss committed rL358604: [CMake] Remove Apple-specific version logic..
[CMake] Remove Apple-specific version logic.
Apr 17 2019, 11:22 AM

Apr 16 2019

friss committed rGb47d3560938d: [debugserver] Relax the codesigning identity check (authored by friss).
[debugserver] Relax the codesigning identity check
Apr 16 2019, 1:56 PM
friss committed rLLDB358525: [debugserver] Relax the codesigning identity check.
[debugserver] Relax the codesigning identity check
Apr 16 2019, 1:53 PM
friss committed rL358525: [debugserver] Relax the codesigning identity check.
[debugserver] Relax the codesigning identity check
Apr 16 2019, 1:53 PM

Apr 15 2019

friss added inline comments to D60642: [dsymutil] Collect parseable Swift interfaces in the .dSYM bundle..
Apr 15 2019, 9:12 AM · Restricted Project

Apr 10 2019

friss added a comment to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.

You didn't address my comment that "this" needs to treated specially in Obj-C++ too. Other than that this LGTM

Apr 10 2019, 5:04 PM · Restricted Project

Apr 9 2019

friss added inline comments to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.
Apr 9 2019, 12:37 PM · Restricted Project
friss added a comment to D60468: Lock accesses to OptionValueFileSpecList objects.

No opinion on the patch, but what is the reason for having settings that are shared between multiple Debugger instances? My expectation was that the debugger objects are completely independent, and I would be surprised if the value of some setting changed from under me because of something that happened in another debug session.

Apr 9 2019, 11:23 AM · Restricted Project
friss added a comment to D60468: Lock accesses to OptionValueFileSpecList objects.

Almost seems like we can build the mutex into the base class OptionValue as we need general threaded protection for every setting. They any function that gets or sets the value should be able to protect itself using the base mutex

Apr 9 2019, 9:35 AM · Restricted Project
friss created D60468: Lock accesses to OptionValueFileSpecList objects.
Apr 9 2019, 9:13 AM · Restricted Project

Apr 3 2019

friss accepted D60178: [Reproducers] Capture return values of functions returning by ptr/ref.

This seems super mechanical and we discussed it at length offline. LGTM

Apr 3 2019, 2:10 PM · Restricted Project, Restricted Project

Mar 28 2019

friss added inline comments to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.
Mar 28 2019, 2:42 PM · Restricted Project

Mar 26 2019

friss added a comment to D59847: Regression test to ensure that we handling importing of std::vector of enums correctly.

As we're just adding test coverage, could we add a little more?

  • Anonymous enum
  • Enum through a typedef
  • class enum
  • enum declared inside of the function rather than at the top-level
  • nested enum in a record type
  • enum nested in a templated class
  • anything else I haven't thought about...
Mar 26 2019, 5:20 PM · Restricted Project

Mar 8 2019

friss committed rG08ae3e0f0b5d: Actually implement the TestQueues.py workaround (authored by friss).
Actually implement the TestQueues.py workaround
Mar 8 2019, 5:35 PM
friss committed rLLDB355766: Actually implement the TestQueues.py workaround.
Actually implement the TestQueues.py workaround
Mar 8 2019, 5:34 PM
friss committed rL355766: Actually implement the TestQueues.py workaround.
Actually implement the TestQueues.py workaround
Mar 8 2019, 5:33 PM
friss committed rG65e062655ed8: Try to workaround the TestQueues.py flakyness (authored by friss).
Try to workaround the TestQueues.py flakyness
Mar 8 2019, 5:23 PM
friss committed rLLDB355764: Try to workaround the TestQueues.py flakyness.
Try to workaround the TestQueues.py flakyness
Mar 8 2019, 5:23 PM
friss committed rL355764: Try to workaround the TestQueues.py flakyness.
Try to workaround the TestQueues.py flakyness
Mar 8 2019, 5:22 PM
friss committed rG7f3c16c0f317: Add more logging to TestQueues.py (authored by friss).
Add more logging to TestQueues.py
Mar 8 2019, 9:11 AM
friss committed rLLDB355706: Add more logging to TestQueues.py.
Add more logging to TestQueues.py
Mar 8 2019, 9:08 AM
friss committed rL355706: Add more logging to TestQueues.py.
Add more logging to TestQueues.py
Mar 8 2019, 9:08 AM

Mar 7 2019

friss committed rG46fac9c4f270: Add logging to TestQueues.py (authored by friss).
Add logging to TestQueues.py
Mar 7 2019, 2:29 PM
friss committed rL355647: Add logging to TestQueues.py.
Add logging to TestQueues.py
Mar 7 2019, 2:29 PM
friss committed rLLDB355647: Add logging to TestQueues.py.
Add logging to TestQueues.py
Mar 7 2019, 2:29 PM
friss committed rGc525b36b434b: Fix TestAppleSimulatorOSType.py with Xcode 10.2 (authored by friss).
Fix TestAppleSimulatorOSType.py with Xcode 10.2
Mar 7 2019, 2:13 PM
friss committed rLLDB355644: Fix TestAppleSimulatorOSType.py with Xcode 10.2.
Fix TestAppleSimulatorOSType.py with Xcode 10.2
Mar 7 2019, 2:13 PM
friss committed rL355644: Fix TestAppleSimulatorOSType.py with Xcode 10.2.
Fix TestAppleSimulatorOSType.py with Xcode 10.2
Mar 7 2019, 2:13 PM

Mar 6 2019

friss committed rGfcda044d22b8: [debugserver] Fix IsUserReady thread filtering (authored by friss).
[debugserver] Fix IsUserReady thread filtering
Mar 6 2019, 1:56 PM
friss committed rL355555: [debugserver] Fix IsUserReady thread filtering.
[debugserver] Fix IsUserReady thread filtering
Mar 6 2019, 1:55 PM
friss committed rLLDB355555: [debugserver] Fix IsUserReady thread filtering.
[debugserver] Fix IsUserReady thread filtering
Mar 6 2019, 1:55 PM
friss closed D58912: [debugserver] Fix IsUserReady thread filtering.
Mar 6 2019, 1:55 PM · Restricted Project

Mar 4 2019

friss added a comment to D58912: [debugserver] Fix IsUserReady thread filtering.

Will this hide a thread that jumps through a null function pointer? That's the only user process case where a pc of 0 needs to be reported to the developer.

Mar 4 2019, 3:48 PM · Restricted Project
friss created D58912: [debugserver] Fix IsUserReady thread filtering.
Mar 4 2019, 10:23 AM · Restricted Project

Feb 27 2019

friss added a comment to D58534: dsymutil support for DW_OP_convert.

LGTM on the surface. I wouldn't mind someone else (@JDevlieghere ?) taking a look.

Feb 27 2019, 1:56 PM · Restricted Project, debug-info

Feb 26 2019

friss added inline comments to D58534: dsymutil support for DW_OP_convert.
Feb 26 2019, 4:09 PM · Restricted Project, debug-info

Feb 14 2019

friss committed rGb3a4649a6a27: [dotest] Fix compiler version number comparison (authored by friss).
[dotest] Fix compiler version number comparison
Feb 14 2019, 10:51 AM
friss committed rL354047: [dotest] Fix compiler version number comparison.
[dotest] Fix compiler version number comparison
Feb 14 2019, 10:51 AM
friss committed rLLDB354047: [dotest] Fix compiler version number comparison.
[dotest] Fix compiler version number comparison
Feb 14 2019, 10:51 AM
friss closed D58219: [dotest] Fix compiler version number comparison.
Feb 14 2019, 10:51 AM · Restricted Project