Page MenuHomePhabricator

Pierre-vh (Pierre van Houtryve)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2018, 7:49 AM (200 w, 4 d)

Recent Activity

Today

Pierre-vh updated the diff for D135146: [GISel] Add redundant bitcast folding combine.

Rebase

Fri, Oct 7, 1:53 AM · Restricted Project, Restricted Project
Pierre-vh added a comment to D86294: AMDGPU/GlobalISel: Add tablegen operator that looks through copies.

@Petar.Avramovic this could be relevant for https://discourse.llvm.org/t/cleanly-addressing-globalisel-dag-pattern-matching-differences/64817/14, do you think you have time to resume work on this patch & get it landed, or may I take over it?
Thank you

Fri, Oct 7, 1:53 AM · Restricted Project, Restricted Project
Pierre-vh committed rG36c3833783f0: [GISel] Add Trunc/Lshr/BuildVector Folding (authored by Pierre-vh).
[GISel] Add Trunc/Lshr/BuildVector Folding
Fri, Oct 7, 1:44 AM · Restricted Project, Restricted Project
Pierre-vh closed D135148: [GISel] Add Trunc/Lshr/BuildVector Folding.
Fri, Oct 7, 1:44 AM · Restricted Project, Restricted Project
Pierre-vh committed rGa34977c4d010: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec` (authored by Pierre-vh).
[GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`
Fri, Oct 7, 1:37 AM · Restricted Project, Restricted Project
Pierre-vh closed D135147: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`.
Fri, Oct 7, 1:37 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D135430: [llvm-objdump] Support nonzero section addresses in addSymbolizer.
Fri, Oct 7, 1:12 AM · Restricted Project, Restricted Project

Yesterday

Pierre-vh updated the diff for D135147: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`.

Remove legalizer checks, simplify code

Thu, Oct 6, 12:33 AM · Restricted Project, Restricted Project
Pierre-vh added inline comments to D135147: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`.
Thu, Oct 6, 12:03 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D135147: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`.

getDefIgnoringCopies -> getVRegDef

Thu, Oct 6, 12:03 AM · Restricted Project, Restricted Project
Pierre-vh added a reviewer for D135147: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`: aemerson.
Thu, Oct 6, 12:02 AM · Restricted Project, Restricted Project
Pierre-vh retitled D135148: [GISel] Add Trunc/Lshr/BuildVector Folding from [GISel] Add Trunc/Shlr/BuildVector Folding to [GISel] Add Trunc/Lshr/BuildVector Folding.
Thu, Oct 6, 12:00 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D135148: [GISel] Add Trunc/Lshr/BuildVector Folding.

Comment

Thu, Oct 6, 12:00 AM · Restricted Project, Restricted Project

Wed, Oct 5

Pierre-vh committed rG3ec0085c3fd4: [DAG] Update `isKnownNeverNaN` for `FMA/FMAD` (authored by Pierre-vh).
[DAG] Update `isKnownNeverNaN` for `FMA/FMAD`
Wed, Oct 5, 11:53 PM · Restricted Project, Restricted Project
Pierre-vh closed D134854: [DAG] Update `isKnownNeverNaN` for `FMA/FMAD`.
Wed, Oct 5, 11:52 PM · Restricted Project, Restricted Project
Pierre-vh committed rGbb71079e3064: [AMDGPU][GISel] Add missing V2S16 BUILD_VECTOR_TRUNC legalization (authored by Pierre-vh).
[AMDGPU][GISel] Add missing V2S16 BUILD_VECTOR_TRUNC legalization
Wed, Oct 5, 11:49 PM · Restricted Project, Restricted Project
Pierre-vh closed D135149: [AMDGPU][GISel] Add missing V2S16 BUILD_VECTOR_TRUNC legalization.
Wed, Oct 5, 11:49 PM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134854: [DAG] Update `isKnownNeverNaN` for `FMA/FMAD`.

Add fma test

Wed, Oct 5, 8:07 AM · Restricted Project, Restricted Project
Pierre-vh added a comment to D134854: [DAG] Update `isKnownNeverNaN` for `FMA/FMAD`.

I did some tries but I can't get a DAG combine to involve FMA/FMAD in DAGISel that's affected by this change (I tried both on AArch64 and AMDGPU). Any idea of how I can write such a test and what the expected output should be?
The only combine I found involving this function only works if -enable-no-signed-zeros-fp-math is used

Wed, Oct 5, 5:26 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D135149: [AMDGPU][GISel] Add missing V2S16 BUILD_VECTOR_TRUNC legalization.

Comments

Wed, Oct 5, 12:41 AM · Restricted Project, Restricted Project
Pierre-vh retitled D135148: [GISel] Add Trunc/Lshr/BuildVector Folding from [GISel] Handle hi element extract in `matchTruncBuildVectorFold` to [GISel] Add Trunc/Shlr/BuildVector Folding.
Wed, Oct 5, 12:27 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D135148: [GISel] Add Trunc/Lshr/BuildVector Folding.

Address comments

Wed, Oct 5, 12:27 AM · Restricted Project, Restricted Project

Tue, Oct 4

Pierre-vh committed rG75b292cb1414: [AMDGPU][DAG] Fix insert_vector_elt lowering for 8 bit elements (authored by Pierre-vh).
[AMDGPU][DAG] Fix insert_vector_elt lowering for 8 bit elements
Tue, Oct 4, 7:48 AM · Restricted Project, Restricted Project
Pierre-vh closed D135156: [AMDGPU][DAG] Fix insert_vector_elt lowering for 8 bit elements.
Tue, Oct 4, 7:48 AM · Restricted Project, Restricted Project
Pierre-vh committed rGc93104073c8a: [AMDGPU] Always lower SHUFFLE_VECTOR (authored by Pierre-vh).
[AMDGPU] Always lower SHUFFLE_VECTOR
Tue, Oct 4, 7:23 AM · Restricted Project, Restricted Project
Pierre-vh closed D134967: [AMDGPU] Always lower SHUFFLE_VECTOR.
Tue, Oct 4, 7:23 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D135156: [AMDGPU][DAG] Fix insert_vector_elt lowering for 8 bit elements.
Tue, Oct 4, 7:16 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D135149: [AMDGPU][GISel] Add missing V2S16 BUILD_VECTOR_TRUNC legalization.
Tue, Oct 4, 5:09 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.

Needs another quick re-review because of the shuffle/shift combine removal - there's some small regressions I was unable to fix for now but they only affect VI/CI

Tue, Oct 4, 5:00 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.

Rebase

Tue, Oct 4, 5:00 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D135148: [GISel] Add Trunc/Lshr/BuildVector Folding.
Tue, Oct 4, 4:57 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D135147: [GISel] Handle G_TRUNC in `matchExtractVecEltBuildVec`.
Tue, Oct 4, 4:56 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D135146: [GISel] Add redundant bitcast folding combine.
Tue, Oct 4, 4:55 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D135145: [AMDGPU][GISel] Combine G_INSERT_VECTOR_ELT to G_SHUFFLE_VECTOR.
Tue, Oct 4, 4:54 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134967: [AMDGPU] Always lower SHUFFLE_VECTOR.

Rebase on trunk

Tue, Oct 4, 2:19 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134967: [AMDGPU] Always lower SHUFFLE_VECTOR.
Tue, Oct 4, 12:03 AM · Restricted Project, Restricted Project
Pierre-vh abandoned D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Tue, Oct 4, 12:01 AM · Restricted Project, Restricted Project

Mon, Oct 3

Pierre-vh added inline comments to D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Mon, Oct 3, 5:14 AM · Restricted Project, Restricted Project
Pierre-vh added inline comments to D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Mon, Oct 3, 1:08 AM · Restricted Project, Restricted Project
Pierre-vh added inline comments to D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Mon, Oct 3, 12:27 AM · Restricted Project, Restricted Project

Fri, Sep 30

Pierre-vh requested review of D134967: [AMDGPU] Always lower SHUFFLE_VECTOR.
Fri, Sep 30, 7:57 AM · Restricted Project, Restricted Project
Pierre-vh committed rGd8258508d498: [AMDGPU][GISel] Update `isCanonicalized` (authored by Pierre-vh).
[AMDGPU][GISel] Update `isCanonicalized`
Fri, Sep 30, 7:13 AM · Restricted Project, Restricted Project
Pierre-vh closed D134862: [AMDGPU][GISel] Update `isCanonicalized`.
Fri, Sep 30, 7:13 AM · Restricted Project, Restricted Project
Pierre-vh committed rG7388520d1c18: [GISel] Add more cases to isKnownNeverNaN (authored by Pierre-vh).
[GISel] Add more cases to isKnownNeverNaN
Fri, Sep 30, 7:11 AM · Restricted Project, Restricted Project
Pierre-vh closed D134857: [GISel] Add more cases to isKnownNeverNaN.
Fri, Sep 30, 7:11 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134857: [GISel] Add more cases to isKnownNeverNaN.

Rebase

Fri, Sep 30, 7:10 AM · Restricted Project, Restricted Project
Pierre-vh committed rG653beae5a168: [AMDGPU][GISel] Add Identity BUILD_VECTOR Combines (authored by Pierre-vh).
[AMDGPU][GISel] Add Identity BUILD_VECTOR Combines
Fri, Sep 30, 7:07 AM · Restricted Project, Restricted Project
Pierre-vh closed D134953: [AMDGPU][GISel] Add Identity BUILD_VECTOR Combines.
Fri, Sep 30, 7:07 AM · Restricted Project, Restricted Project
Pierre-vh committed rG9a67a6b72af1: [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR (authored by Pierre-vh).
[AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR
Fri, Sep 30, 7:05 AM · Restricted Project, Restricted Project
Pierre-vh closed D134433: [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR.
Fri, Sep 30, 7:05 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134953: [AMDGPU][GISel] Add Identity BUILD_VECTOR Combines.

Move all to Helper

Fri, Sep 30, 6:44 AM · Restricted Project, Restricted Project
Pierre-vh added inline comments to D134953: [AMDGPU][GISel] Add Identity BUILD_VECTOR Combines.
Fri, Sep 30, 6:18 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134953: [AMDGPU][GISel] Add Identity BUILD_VECTOR Combines.

Comment

Fri, Sep 30, 6:18 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134953: [AMDGPU][GISel] Add Identity BUILD_VECTOR Combines.

Comments

Fri, Sep 30, 5:52 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.

Needs re-review of the latest 2 changes because there's a few codegen changes due to the rebase

Fri, Sep 30, 5:39 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.
Fri, Sep 30, 5:35 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.

Rebase, there's a few very small regressions due to the change in FMIN/MAXNUM legalization rules

Fri, Sep 30, 5:35 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134857: [GISel] Add more cases to isKnownNeverNaN.
Fri, Sep 30, 5:34 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134862: [AMDGPU][GISel] Update `isCanonicalized`.

Add BUILD_VECTOR

Fri, Sep 30, 5:33 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134857: [GISel] Add more cases to isKnownNeverNaN.

Rebase

Fri, Sep 30, 5:31 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.

Rebase, pull the trunc combine into D134953 instead

Fri, Sep 30, 5:30 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Fri, Sep 30, 5:30 AM · Restricted Project, Restricted Project
Pierre-vh retitled D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT from [AMDGPU][GISel] Better support for V2S16 G_EXTRACT/INSERT_VECTOR_ELT to [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Fri, Sep 30, 5:30 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D134953: [AMDGPU][GISel] Add Identity BUILD_VECTOR Combines.
Fri, Sep 30, 5:27 AM · Restricted Project, Restricted Project
Pierre-vh retitled D134433: [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR from [AMDGPU][GISel] Enable Matching of V2S16 G_BUILD_VECTOR to [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR.
Fri, Sep 30, 5:21 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134433: [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR.

Remove G_FMIN/MAXNUM legalizer changes.
This now only touches build_vector. I renamed the diff to reflect that.

Fri, Sep 30, 5:21 AM · Restricted Project, Restricted Project
Pierre-vh abandoned D134635: [AMDGPU][GlobalISel] Add Shift/Shufflevector Combine.

Not the right kind of fix + too controversial of a change for a relatively small regression in mad_mix GISel.

Fri, Sep 30, 4:57 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Fri, Sep 30, 3:57 AM · Restricted Project, Restricted Project
Pierre-vh added inline comments to D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Fri, Sep 30, 3:57 AM · Restricted Project, Restricted Project
Pierre-vh planned changes to D134862: [AMDGPU][GISel] Update `isCanonicalized`.

need a few more items

Fri, Sep 30, 3:45 AM · Restricted Project, Restricted Project
Pierre-vh planned changes to D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Fri, Sep 30, 3:44 AM · Restricted Project, Restricted Project
Pierre-vh planned changes to D134433: [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR.
Fri, Sep 30, 3:44 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134862: [AMDGPU][GISel] Update `isCanonicalized`.

Comments

Fri, Sep 30, 12:36 AM · Restricted Project, Restricted Project
Pierre-vh committed rG6886f094e8af: [TableGen] Add `countRendererFns` to `InstructionOperandMatcher` (authored by Pierre-vh).
[TableGen] Add `countRendererFns` to `InstructionOperandMatcher`
Fri, Sep 30, 12:26 AM · Restricted Project, Restricted Project
Pierre-vh closed D134861: [TableGen] Add `countRendererFns` to `InstructionOperandMatcher`.
Fri, Sep 30, 12:26 AM · Restricted Project, Restricted Project

Thu, Sep 29

Pierre-vh added inline comments to D134433: [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR.
Thu, Sep 29, 9:19 AM · Restricted Project, Restricted Project
Pierre-vh added a comment to D134433: [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR.

You don't want (<2 x s16>) but only s16 G_FMAXNUM_IEEEwhen lowering larger vectors, also you remove G_BUILD_VECTOR_TRUNC but use G_BUILD_VECTOR instead.
Can you point me to the test case that requires those changes? (You didn't change legalization rules for other <2 x s16> instructions).
To be more precise what D134354 requires from Legalizer (and pre/post legalizer combiner). Maybe there is simpler way to achieve it.

Thu, Sep 29, 9:13 AM · Restricted Project, Restricted Project
Pierre-vh added inline comments to D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Thu, Sep 29, 8:03 AM · Restricted Project, Restricted Project
Pierre-vh added a comment to D134433: [AMDGPU][GISel] Legalize V2S16 G_BUILD_VECTOR.

@Petar.Avramovic In the latest diffs, I don't change legalization rules from G_EXTRACT/INSERT_VECTOR_ELEMENT anymore, so it doesn't affect this patch
Instead I started D134870 which adds combines to achieve the fma/mad_mix selection in D134354

Thu, Sep 29, 7:57 AM · Restricted Project, Restricted Project
Pierre-vh added inline comments to D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Thu, Sep 29, 7:38 AM · Restricted Project, Restricted Project
Pierre-vh added inline comments to D134862: [AMDGPU][GISel] Update `isCanonicalized`.
Thu, Sep 29, 6:53 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134862: [AMDGPU][GISel] Update `isCanonicalized`.

Add more missing instructions/intrinsics

Thu, Sep 29, 6:53 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D134862: [AMDGPU][GISel] Update `isCanonicalized`.
Thu, Sep 29, 6:13 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134862: [AMDGPU][GISel] Update `isCanonicalized`.

Handle more opcode/intrinsics

Thu, Sep 29, 6:13 AM · Restricted Project, Restricted Project
Pierre-vh added a comment to D134862: [AMDGPU][GISel] Update `isCanonicalized`.

I'm not sure I understand, which intrinsics need to be handled? The ones in INTRINSIC_WO_CHAIN in the DAG version?
And what are the opcodes you're talking about? Things like CVT_F32?

Thu, Sep 29, 5:51 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.

Fix v_mad_mixhi_f16_f16lo_f16lo_f16lo_undeflo_clamp_precvt

Thu, Sep 29, 5:45 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.

Rebase on tree that includes D134870.

Thu, Sep 29, 4:02 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection.
Thu, Sep 29, 3:52 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134862: [AMDGPU][GISel] Update `isCanonicalized`.

Rebase on top of D134857

Thu, Sep 29, 3:50 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134857: [GISel] Add more cases to isKnownNeverNaN.
Thu, Sep 29, 3:49 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134857: [GISel] Add more cases to isKnownNeverNaN.

Rebase on top of D134635

Thu, Sep 29, 3:49 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134635: [AMDGPU][GlobalISel] Add Shift/Shufflevector Combine.

Rebase

Thu, Sep 29, 3:48 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134635: [AMDGPU][GlobalISel] Add Shift/Shufflevector Combine.
Thu, Sep 29, 3:46 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Thu, Sep 29, 3:45 AM · Restricted Project, Restricted Project
Pierre-vh updated the summary of D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Thu, Sep 29, 3:44 AM · Restricted Project, Restricted Project
Pierre-vh requested review of D134870: [AMDGPU][GISel] Combine V2S16 G_EXTRACT/INSERT_VECTOR_ELT.
Thu, Sep 29, 3:41 AM · Restricted Project, Restricted Project
Pierre-vh added a comment to D134862: [AMDGPU][GISel] Update `isCanonicalized`.

LGTM. (I'm not 100% sure about G_FREM but I assume it expands to something that will flush denormals if appropriate?)

Thu, Sep 29, 3:17 AM · Restricted Project, Restricted Project
Pierre-vh added a comment to D134862: [AMDGPU][GISel] Update `isCanonicalized`.

Fixes some regressions introduced in D134857 for fdiv.f16 too.

I don't see any real regressions in D134857, just cases where we optimize the "ieee" cases but not the "flush" cases.

Thu, Sep 29, 2:14 AM · Restricted Project, Restricted Project
Pierre-vh updated the diff for D134862: [AMDGPU][GISel] Update `isCanonicalized`.

Fix unary ops
Also fixes the foldable-fneg test (no longer needs pre/post check lines)

Thu, Sep 29, 2:14 AM · Restricted Project, Restricted Project
Pierre-vh added a comment to D134854: [DAG] Update `isKnownNeverNaN` for `FMA/FMAD`.

Code change looks good. Is it possible to add a test as described in https://reviews.llvm.org/D50804#1202429?

Thu, Sep 29, 1:40 AM · Restricted Project, Restricted Project