- User Since
- Dec 3 2018, 7:49 AM (250 w, 5 d)
Mon, Sep 11
Thu, Sep 7
Wed, Sep 6
Tue, Sep 5
Mon, Sep 4
Thu, Aug 31
Rebase + gentle ping
Tue, Aug 29
(Note that this depends on some other patches so it can't land yet)
Mon, Aug 28
fix small nit
Aug 24 2023
LGTM, don't forget to rebase & rerun tests in case there's more updates needed following MIR patterns landing :)
LGTM but rebase & retest since MIR patterns landed, it should solve a regression we saw during review
Aug 23 2023
Additional context: While refactoring this area for some upcoming diffs (removing the deprecated GICombiner backend), I changed some data members from T& to T and got a lot of errors due to this.
While I usually favor const-correctness as much as possible, it's really never respected here. We always use references or pointers, which means we can always call non-const functions on those even in a const function.
Aug 22 2023
Aug 21 2023
Long term I assume we should just have MIR patterns working for ISel, but as long as we rely on DAG patterns I believe this is a good change (we inevitably need to make some tradeoffs in this case anyway), can we land it or are there still some objections?
Aug 11 2023
Actual fix is D157711
Rebase on regenerated checks
Document the new limitation
Aug 10 2023
Use implicit op idx
Aug 9 2023
@aemerson are you also fine with landing it?
(Note: I'll be away next week for about 10 days so earliest I can pick up bugs is after the 23rd/24th - I don't mind waiting until I'm back to land this if preferred)
Remove useless new testcase
Thanks for the fix! It's good to commit as-is if you want a quick fix, but the version I propose is the best possible user experience.
Note it's all going away in D156315 anyway.
Aug 8 2023
Aug 7 2023
Do you think it's worth running a pass like InstSimplify after the tests to check the instruction does get eliminated?
Maybe with a different CHECK line?
A couple of things to note:
- This is a bit naive, it only works on the Record* and doesn't test for subregs or RC, should it?
- One of the tradeoffs of doing this at the TableGen level is that we don't know about reserved registers. Do they matter in this case? How could we handle them?
Aug 4 2023
Use a singular, simple OperandTable datastructure for both PatFrags & Rules.
Works a lot better and eliminated about 70 lines of code.