Page MenuHomePhabricator

spatel (Sanjay Patel)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2014, 1:24 PM (422 w, 2 d)

Recent Activity

Wed, Jun 22

spatel accepted D126591: [InstCombine] Optimise shift+and+boolean conversion pattern to simple comparison.

LGTM

Wed, Jun 22, 12:12 PM · Restricted Project, Restricted Project
spatel added inline comments to D126591: [InstCombine] Optimise shift+and+boolean conversion pattern to simple comparison.
Wed, Jun 22, 5:20 AM · Restricted Project, Restricted Project

Mon, Jun 20

spatel added a comment to D126591: [InstCombine] Optimise shift+and+boolean conversion pattern to simple comparison.

I added a similar fold here:
0399473de886

Mon, Jun 20, 3:51 AM · Restricted Project, Restricted Project
spatel planned changes to D128123: [SDAG] try to replace subtract-from-constant with xor.
Mon, Jun 20, 3:33 AM · Restricted Project, Restricted Project
spatel abandoned D128080: [SDAG] convert sub from (Pow2-1) constant into xor.

Abandoning - looks like this will need a target hook of some kind along with the more general transform in D128123.

Mon, Jun 20, 3:27 AM · Restricted Project, Restricted Project

Sun, Jun 19

spatel committed rG73202130e52e: [InstCombine] Optimize test for same-sign of values (authored by emgullufsen).
[InstCombine] Optimize test for same-sign of values
Sun, Jun 19, 1:44 PM · Restricted Project, Restricted Project
spatel closed D127903: [InstCombine] Optimize test for same-sign of values.
Sun, Jun 19, 1:44 PM · Restricted Project, Restricted Project
spatel accepted D127903: [InstCombine] Optimize test for same-sign of values.

LGTM

Sun, Jun 19, 1:01 PM · Restricted Project, Restricted Project
spatel accepted D125836: [DAG] Fold (srl (shl x, c1), c2) -> and(shl/srl(x, c3), m).

LGTM - noted a close call in x86 tests, but that can be addressed if we find real regressions.

Sun, Jun 19, 12:21 PM · Restricted Project, Restricted Project
spatel committed rG4022551a154e: [ValueTracking] recognize sub X, (X -nuw Y) as not overflowing (authored by spatel).
[ValueTracking] recognize sub X, (X -nuw Y) as not overflowing
Sun, Jun 19, 12:12 PM · Restricted Project, Restricted Project
spatel committed rGbfb915ec8bd0: [InstCombine] add tests for 'sub nuw' with zext; NFC (authored by spatel).
[InstCombine] add tests for 'sub nuw' with zext; NFC
Sun, Jun 19, 12:12 PM · Restricted Project, Restricted Project
spatel committed rG0399473de886: [InstCombine] add fold for (ShiftC >> X) <u C (authored by spatel).
[InstCombine] add fold for (ShiftC >> X) <u C
Sun, Jun 19, 8:05 AM · Restricted Project, Restricted Project
spatel added a comment to D127903: [InstCombine] Optimize test for same-sign of values.

I committed the tests with baseline results, so we have those in place independently of the code change. I then updated the tests to provide a bit more coverage. Please rebase/update after:
feb4b336acc71

Sun, Jun 19, 7:21 AM · Restricted Project, Restricted Project
spatel committed rGfeb4b336acc7: [InstCombine] add/adjust tests for signbit tests; NFC (authored by spatel).
[InstCombine] add/adjust tests for signbit tests; NFC
Sun, Jun 19, 7:16 AM · Restricted Project, Restricted Project
spatel committed rG4b7d51f129f0: [InstCombine] add baseline tests for signbit cmp folds; NFC (authored by emgullufsen).
[InstCombine] add baseline tests for signbit cmp folds; NFC
Sun, Jun 19, 6:05 AM · Restricted Project, Restricted Project

Sat, Jun 18

spatel added a comment to D128080: [SDAG] convert sub from (Pow2-1) constant into xor.

I put up D128123 as the potential better/final patch, so we can see the current test diffs.

Sat, Jun 18, 8:12 AM · Restricted Project, Restricted Project
spatel requested review of D128123: [SDAG] try to replace subtract-from-constant with xor.
Sat, Jun 18, 8:11 AM · Restricted Project, Restricted Project
spatel added a comment to D127903: [InstCombine] Optimize test for same-sign of values.

Fixed one more incorrect use of capturing in CHECK line.

Sat, Jun 18, 7:16 AM · Restricted Project, Restricted Project
spatel added reviewers for D128080: [SDAG] convert sub from (Pow2-1) constant into xor: arsenm, craig.topper.

I also tracked down where this happens in x86 codegen:
https://github.com/llvm/llvm-project/blob/cd64a427efa0baaf1bb7ae624d4301908afc07f7/llvm/lib/Target/X86/X86InstrCompiler.td#L1535

So this fold and the InstCombine that I copied from are actually over-constrained. We don't need a low-bit-mask constant:
https://alive2.llvm.org/ce/z/OUm6N_

Sat, Jun 18, 7:07 AM · Restricted Project, Restricted Project
spatel added a comment to D128080: [SDAG] convert sub from (Pow2-1) constant into xor.

It doesn't looks like it is helping D127115, but it looks useful on its own.

Sat, Jun 18, 6:18 AM · Restricted Project, Restricted Project

Fri, Jun 17

spatel committed rGf12664386261: [AArch64] add tests for masked subtract; NFC (authored by spatel).
[AArch64] add tests for masked subtract; NFC
Fri, Jun 17, 12:01 PM · Restricted Project, Restricted Project
spatel added inline comments to D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..
Fri, Jun 17, 11:46 AM · Restricted Project, Restricted Project
spatel requested review of D128080: [SDAG] convert sub from (Pow2-1) constant into xor.
Fri, Jun 17, 11:38 AM · Restricted Project, Restricted Project
spatel added a comment to D127903: [InstCombine] Optimize test for same-sign of values.

The uploaded diff is against the previous revision of this patch. Please rebase so it is against (and can be applied cleanly to) the main branch.

Fri, Jun 17, 8:23 AM · Restricted Project, Restricted Project
spatel updated the summary of D127903: [InstCombine] Optimize test for same-sign of values.
Fri, Jun 17, 8:14 AM · Restricted Project, Restricted Project
spatel committed rGbfde8619355a: [InstCombine] convert mask and shift of power-of-2 to cmp+select (authored by spatel).
[InstCombine] convert mask and shift of power-of-2 to cmp+select
Fri, Jun 17, 7:52 AM · Restricted Project, Restricted Project
spatel closed D127801: [InstCombine] convert mask and shift of power-of-2 to cmp+select.
Fri, Jun 17, 7:52 AM · Restricted Project, Restricted Project
spatel added a comment to D127801: [InstCombine] convert mask and shift of power-of-2 to cmp+select.

Thanks - let's give this a try.
It seems like it can help IR analysis, and there are potential wins for codegen too. If we find perf regressions that are not easy to reverse, then we can revert.

Fri, Jun 17, 7:40 AM · Restricted Project, Restricted Project
spatel added a comment to D127854: [InstCombine] Use known bits to determine exact int->fp cast.

rebase

Fri, Jun 17, 7:36 AM · Restricted Project, Restricted Project
spatel accepted D127216: [SimplifyCFG] Try to merge edge block when threading (PR55765).

LGTM

Fri, Jun 17, 7:26 AM · Restricted Project, Restricted Project
spatel added inline comments to D127398: [InstCombine] add vector support for (A >> C) == (B >> C) --> (A^B) u< (1 << C).
Fri, Jun 17, 7:16 AM · Restricted Project, Restricted Project
spatel accepted D127398: [InstCombine] add vector support for (A >> C) == (B >> C) --> (A^B) u< (1 << C).

LGTM - see inline for some possible minor improvements.

Fri, Jun 17, 7:12 AM · Restricted Project, Restricted Project
spatel accepted D125807: [ConstantFolding] Pre-commit tests showing denormal handling during folding.

LGTM

Fri, Jun 17, 6:24 AM · Restricted Project, Restricted Project
spatel added inline comments to D127854: [InstCombine] Use known bits to determine exact int->fp cast.
Fri, Jun 17, 6:21 AM · Restricted Project, Restricted Project
spatel committed rGa5040860412f: [InstCombine] add tests for FP casts; NFC (authored by spatel).
[InstCombine] add tests for FP casts; NFC
Fri, Jun 17, 5:42 AM · Restricted Project, Restricted Project
spatel committed rGaf5e64df728f: [InstCombine] add tests for (pow2 >> X) >u C; NFC (authored by spatel).
[InstCombine] add tests for (pow2 >> X) >u C; NFC
Fri, Jun 17, 5:42 AM · Restricted Project, Restricted Project

Thu, Jun 16

spatel accepted D116952: [ConstantFolding] Respect denormal handling mode attributes when folding instructions.

LGTM - thanks for the thorough tests!
See inline for some minor cleanups.

Thu, Jun 16, 1:35 PM · Restricted Project, Restricted Project
spatel added a comment to D125845: [InstCombine] Canonicalize GEP of GEP by swapping constant-indexed GEP to the back.

I don't know enough to visualize the GEP corner-cases or the interaction with LICM, but I commented on general improvements to the patch.

Thu, Jun 16, 10:45 AM · Restricted Project, Restricted Project
spatel added a reviewer for D127854: [InstCombine] Use known bits to determine exact int->fp cast: efriedma.
Thu, Jun 16, 7:59 AM · Restricted Project, Restricted Project
spatel added inline comments to D127854: [InstCombine] Use known bits to determine exact int->fp cast.
Thu, Jun 16, 7:42 AM · Restricted Project, Restricted Project

Wed, Jun 15

spatel added inline comments to D127903: [InstCombine] Optimize test for same-sign of values.
Wed, Jun 15, 1:52 PM · Restricted Project, Restricted Project
spatel added a comment to D127392: [InstCombine] Combine consecutive loads which are being merged to form a wider load..

https://godbolt.org/z/Ee4cbf1PG
Similar situation can be seen with the unroller as well as in the example below:
https://godbolt.org/z/dWo8n3Yz8

Wed, Jun 15, 12:33 PM · Restricted Project, Restricted Project
spatel added a comment to D127801: [InstCombine] convert mask and shift of power-of-2 to cmp+select.

Actually even if the instruction number are the same, we still prefer shift+and because cmp port is less than shift for most modern CPU I think.

Wed, Jun 15, 10:40 AM · Restricted Project, Restricted Project
spatel added a comment to D127801: [InstCombine] convert mask and shift of power-of-2 to cmp+select.

We need to assume X < BitWidth https://alive2.llvm.org/ce/z/-GjVsu

Wed, Jun 15, 8:18 AM · Restricted Project, Restricted Project

Tue, Jun 14

spatel requested review of D127801: [InstCombine] convert mask and shift of power-of-2 to cmp+select.
Tue, Jun 14, 2:45 PM · Restricted Project, Restricted Project
spatel added inline comments to D127610: [InstCombine] Optimize shift+and+xor conversion pattern to simple comparison.
Tue, Jun 14, 2:10 PM · Restricted Project, Restricted Project
spatel added inline comments to D127460: Rename GCCBuiltin into ClangBuiltin.
Tue, Jun 14, 12:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
spatel committed rG8605b4d8c5cc: [ValueTracking] recognize sub X, (X -nsw Y) as not overflowing (authored by spatel).
[ValueTracking] recognize sub X, (X -nsw Y) as not overflowing
Tue, Jun 14, 11:53 AM · Restricted Project, Restricted Project
spatel closed D127754: [ValueTracking] recognize sub X, (X -nsw Y) as not overflowing.
Tue, Jun 14, 11:53 AM · Restricted Project, Restricted Project
spatel requested review of D127754: [ValueTracking] recognize sub X, (X -nsw Y) as not overflowing.
Tue, Jun 14, 8:41 AM · Restricted Project, Restricted Project
spatel committed rG304cda0b1600: [InstCombine] add tests for sub with extended operands; NFC (authored by spatel).
[InstCombine] add tests for sub with extended operands; NFC
Tue, Jun 14, 8:41 AM · Restricted Project, Restricted Project

Mon, Jun 13

spatel added inline comments to D125774: [IndVars] Fold int->fp->int cast for small PHI node.
Mon, Jun 13, 1:55 PM · Restricted Project, Restricted Project
spatel added inline comments to D127474: [SelectionDAG] fold Op0 - (X * MulC) --> Op0 + (X << log2(-MulC)).
Mon, Jun 13, 8:58 AM · Restricted Project, Restricted Project
spatel accepted D127474: [SelectionDAG] fold Op0 - (X * MulC) --> Op0 + (X << log2(-MulC)).

LGTM - as noted in 21d7c3bcc646f5db73b, this pattern is probably not common because it's not the canonical IR.

Mon, Jun 13, 8:55 AM · Restricted Project, Restricted Project
spatel accepted D127469: [InstCombine] Optimize lshr+shl+and conversion pattern.

LGTM

Mon, Jun 13, 7:23 AM · Restricted Project, Restricted Project
spatel committed rG310adb658c8c: [InstCombine] reorder mask folds for efficiency (authored by spatel).
[InstCombine] reorder mask folds for efficiency
Mon, Jun 13, 6:57 AM · Restricted Project, Restricted Project

Sun, Jun 12

spatel added a reviewer for D127392: [InstCombine] Combine consecutive loads which are being merged to form a wider load.: efriedma.

I'd like to see some form of load combining in IR, but we need to be very careful about how that is implemented.

Sun, Jun 12, 8:47 AM · Restricted Project, Restricted Project

Fri, Jun 10

spatel committed rGe247b0e5c921: [InstCombine] add narrowing transform for low-masked binop with zext operand… (authored by spatel).
[InstCombine] add narrowing transform for low-masked binop with zext operand…
Fri, Jun 10, 9:44 AM · Restricted Project, Restricted Project
spatel committed rG4c3139d7b935: [InstCombine] add test for mask op with constant expression; NFC (authored by spatel).
[InstCombine] add test for mask op with constant expression; NFC
Fri, Jun 10, 9:44 AM · Restricted Project, Restricted Project
spatel added a comment to D127469: [InstCombine] Optimize lshr+shl+and conversion pattern.

I don't like increasing risk by combining what are really 2 independent changes into 1 patch.
Please go back to the earlier revision that only adds the new fold. We can ease the vector restrictions as a second step (I haven't seen any evidence that those cases matter, but it opens up more possibilities to miscompile in ways that are very hard to detect).

Fri, Jun 10, 9:14 AM · Restricted Project, Restricted Project
spatel added a comment to D123408: [InstCombine] Limit folding of cast into PHI.

afa192cfb604

That commit causes breakage for me - one file which used to compile in around a second now hangs (doesn't complete in many minutes at least).

To reproduce, download https://martin.st/temp/remap-preproc.c and try to compile it with clang -target x86_64-w64-mingw32 -w -c -O2 remap-preproc.c.

Fri, Jun 10, 9:04 AM · Restricted Project, Restricted Project
spatel accepted D127493: [NFC][InstCombine] Refactor InstCombinerImpl::foldSelectIntoOp.

Note that we likely have FMF propagation bugs in this code based on discussion/examples in D127275. If you can put a TODO comment on this, that would be helpful. We'll probably need to add more tests with mixed FMF to demonstrate the bugs.

Fri, Jun 10, 8:58 AM · Restricted Project, Restricted Project
spatel accepted D127499: [InstCombine] Don't push operation across loop phi.

Note: I think we should still do the narrowing transform that I suggested in D123408, but that's independent of this fix. That narrowing commit ran into its own infinite loop due to a conflict matching constant expressions, but I can fix that.

Fri, Jun 10, 8:17 AM · Restricted Project, Restricted Project
spatel added a reverting change for rGafa192cfb604: [InstCombine] add narrowing transform for low-masked binop with zext operand: rG6fedc6a2b41e: Revert "[InstCombine] add narrowing transform for low-masked binop with zext….
Fri, Jun 10, 5:25 AM · Restricted Project, Restricted Project
spatel committed rG6fedc6a2b41e: Revert "[InstCombine] add narrowing transform for low-masked binop with zext… (authored by spatel).
Revert "[InstCombine] add narrowing transform for low-masked binop with zext…
Fri, Jun 10, 5:25 AM · Restricted Project, Restricted Project

Thu, Jun 9

spatel added a comment to D123408: [InstCombine] Limit folding of cast into PHI.

Oh nevermind, please ignore above comment, I see what you are saying now! That we can add a transformation which can convert:

Thu, Jun 9, 2:04 PM · Restricted Project, Restricted Project
spatel committed rGafa192cfb604: [InstCombine] add narrowing transform for low-masked binop with zext operand (authored by spatel).
[InstCombine] add narrowing transform for low-masked binop with zext operand
Thu, Jun 9, 2:01 PM · Restricted Project, Restricted Project
spatel committed rG48a606d0c703: [InstCombine] add tests for masked binop narrowing; NFC (authored by spatel).
[InstCombine] add tests for masked binop narrowing; NFC
Thu, Jun 9, 1:57 PM · Restricted Project, Restricted Project
spatel added a comment to D123408: [InstCombine] Limit folding of cast into PHI.

@spatel Could you please provide some feedback about this change to InstCombine.

Thu, Jun 9, 12:14 PM · Restricted Project, Restricted Project
spatel accepted D126617: [InstCombine] Optimize shl+lshr+and conversion pattern.

If I'm seeing it correctly, this will alter D126591 or possibly make it unnecessary. I recommend implementing the symmetric TODO pattern for this patch as the next patch, and then we can see what remains.

Thu, Jun 9, 9:02 AM · Restricted Project, Restricted Project
spatel added a comment to D126638: [CGP] Also freeze ctlz/cttz operand when despeculating.

For what input is that? As far as I can tell, AArch64 never uses despeculation, and ARM uses a libcall legalization where it makes no difference. I'm trying this one:

Thu, Jun 9, 6:08 AM · Restricted Project, Restricted Project

Wed, Jun 8

spatel accepted D126889: [NFC] format InstructionSimplify & lowerCaseFunctionNames.

LGTM

Wed, Jun 8, 12:58 PM · Restricted Project, Restricted Project
spatel accepted D127335: [SelectionDAG] Teach computeKnownBits that a nsw self multiply produce a positive value..

LGTM

Wed, Jun 8, 12:41 PM · Restricted Project, Restricted Project
spatel added inline comments to D127188: [InstCombine] improve fold for icmp-ugt-ashr.
Wed, Jun 8, 11:47 AM · Restricted Project, Restricted Project
spatel accepted D127188: [InstCombine] improve fold for icmp-ugt-ashr.

LGTM - it may be worth looking at the related folds to see if there's some generalization that we missed (see inline comment about the other TODO comment in the test file).

Wed, Jun 8, 11:42 AM · Restricted Project, Restricted Project
spatel added a comment to D126617: [InstCombine] Optimize shl+lshr+and conversion pattern.
  1. Use m_Power2 to match C1
  2. Remove condition Log2(C1) < Log2(C3)+C2
Wed, Jun 8, 11:06 AM · Restricted Project, Restricted Project
spatel added inline comments to D127275: [MVE] Fold fadd(select(..., +0.0)) into a predicated fadd.
Wed, Jun 8, 9:11 AM · Restricted Project, Restricted Project
spatel added inline comments to D127275: [MVE] Fold fadd(select(..., +0.0)) into a predicated fadd.
Wed, Jun 8, 8:53 AM · Restricted Project, Restricted Project
spatel accepted D126638: [CGP] Also freeze ctlz/cttz operand when despeculating.

https://alive2.llvm.org/ce/z/iwd4ba
This is needed for correctness, so LGTM.

Wed, Jun 8, 7:15 AM · Restricted Project, Restricted Project
spatel accepted D126774: [InstCombine] Use +0.0 instead of -0.0 as the FP identity for some folds.

It would be good to refactor foldSelectIntoOp() with a lambda as a preliminary cleanup, so we don't have to duplicate the code.
But this is an improvement even without that, so LGTM.

Wed, Jun 8, 5:27 AM · Restricted Project, Restricted Project
spatel added a comment to D127275: [MVE] Fold fadd(select(..., +0.0)) into a predicated fadd.

If this is inverting the transform from D126774, do we need 'nsz' to avoid miscompiling -0.0?
https://alive2.llvm.org/ce/z/4IMKLM

Wed, Jun 8, 5:06 AM · Restricted Project, Restricted Project

Tue, Jun 7

spatel committed rGcae993d4c87f: [InstCombine] [InstCombine] reduce left-shift-of-right-shifted constant via… (authored by spatel).
[InstCombine] [InstCombine] reduce left-shift-of-right-shifted constant via…
Tue, Jun 7, 3:44 PM · Restricted Project, Restricted Project
spatel committed rG0856a6cb7ad6: [InstCombine] add tests for left-shift-of-right-shifted constant; NFC (authored by spatel).
[InstCombine] add tests for left-shift-of-right-shifted constant; NFC
Tue, Jun 7, 3:44 PM · Restricted Project, Restricted Project
spatel committed rGa4d2c5ecaae9: [InstCombine] reduce code duplication for accessing type; NFC (authored by spatel).
[InstCombine] reduce code duplication for accessing type; NFC
Tue, Jun 7, 3:44 PM · Restricted Project, Restricted Project
spatel added inline comments to D126617: [InstCombine] Optimize shl+lshr+and conversion pattern.
Tue, Jun 7, 1:36 PM · Restricted Project, Restricted Project
spatel added a comment to D127188: [InstCombine] improve fold for icmp-ugt-ashr.

For reference, this was the Alive2 from the original review ( D117365 ):
https://alive2.llvm.org/ce/z/tFAcZt

Tue, Jun 7, 12:17 PM · Restricted Project, Restricted Project
spatel committed rG82040d414b3c: [InstCombine] reduce right-shift-of-left-shifted constant via demanded bits (authored by spatel).
[InstCombine] reduce right-shift-of-left-shifted constant via demanded bits
Tue, Jun 7, 10:30 AM · Restricted Project, Restricted Project
spatel committed rG8956f80e4b57: [InstCombine] add vector tests for shift-shift; NFC (authored by spatel).
[InstCombine] add vector tests for shift-shift; NFC
Tue, Jun 7, 10:30 AM · Restricted Project, Restricted Project
spatel closed D127122: [InstCombine] reduce right-shift-of-left-shifted constant via demanded bits.
Tue, Jun 7, 10:30 AM · Restricted Project, Restricted Project
spatel added a comment to D126190: [InstCombine] Add combine for fcmp sqrt(x),C --> fcmp x,C*C.

This has turned out to be far more complex to do safely than originally thought, given I don't as of yet have a compelling example where this provides a significant benefit I will abandon this for now.

Tue, Jun 7, 8:05 AM · Restricted Project, Restricted Project
spatel added a comment to D126774: [InstCombine] Use +0.0 instead of -0.0 as the FP identity for some folds.
  • Added more pattern matches for MVE targets so we detect splats of +0.0 as well as -0.0.
Tue, Jun 7, 7:49 AM · Restricted Project, Restricted Project
spatel updated the summary of D127122: [InstCombine] reduce right-shift-of-left-shifted constant via demanded bits.
Tue, Jun 7, 7:28 AM · Restricted Project, Restricted Project
spatel updated the diff for D127122: [InstCombine] reduce right-shift-of-left-shifted constant via demanded bits.

Adjusted code to allow non-uniform (non-splat) vector constants on the shifted (inner) constant.

Tue, Jun 7, 7:26 AM · Restricted Project, Restricted Project

Mon, Jun 6

spatel added inline comments to D127122: [InstCombine] reduce right-shift-of-left-shifted constant via demanded bits.
Mon, Jun 6, 12:41 PM · Restricted Project, Restricted Project
spatel added a comment to D126617: [InstCombine] Optimize shl+lshr+and conversion pattern.
  1. the demanded bits fix. I think it is a safe and independent change.
Mon, Jun 6, 8:59 AM · Restricted Project, Restricted Project
spatel updated the summary of D127122: [InstCombine] reduce right-shift-of-left-shifted constant via demanded bits.
Mon, Jun 6, 8:49 AM · Restricted Project, Restricted Project
spatel requested review of D127122: [InstCombine] reduce right-shift-of-left-shifted constant via demanded bits.
Mon, Jun 6, 8:49 AM · Restricted Project, Restricted Project
spatel committed rG4b2681ffa8de: [InstCombine] add/move tests for opposite direction shifts; NFC (authored by spatel).
[InstCombine] add/move tests for opposite direction shifts; NFC
Mon, Jun 6, 8:38 AM · Restricted Project, Restricted Project
spatel added a comment to D124119: [InstCombine] Combine instructions of type or/and where AND masks can be combined..

IIUC, the problem/fix (and it would be good to put something like this in the updated commit message for easier reference):
The previous revision/commit did not check one-use of an intermediate value that this transform re-uses. When that value has another use, an existing transform will try to invert the transform here. By adding one-use checks, we avoid the infinite loops seen with the earlier commit.

Mon, Jun 6, 7:20 AM · Restricted Project, Restricted Project
spatel added a comment to D126889: [NFC] format InstructionSimplify & lowerCaseFunctionNames.

No objection from me, and I do maintain downstream forks. Can you provide a simple one-line command that I can run to make the equivalent changes in my downstream?

Mon, Jun 6, 5:05 AM · Restricted Project, Restricted Project