- User Since
- May 22 2014, 1:24 PM (161 w, 2 d)
Fri, Jun 23
Thu, Jun 22
LGTM. See inline for a nit.
LGTM - although the test file was not updated here in the uploaded patch?
Wed, Jun 21
LGTM. Don't forget to remove the 'TODO' comments from the test file.
Tue, Jun 20
For those following the progress for x86, I enabled the smallest sizes with:
Mon, Jun 19
Ping * 3.
Patch updated (no functional changes):
- Use APInt::isOneValue().
- Change comment about potential zero-latency implementation of pcmpeq - although that does seem possible for some uarch to implement if it wanted to. :)
Here's a test loop:
Sun, Jun 18
Fri, Jun 16
I don't think we even need the cmp:
The code change looks right, but the test is not minimized, and it's also not checking the more complicated case of a phi with >2 incoming values.
Thu, Jun 15
Ping * 3.
Nice! I was wondering if that was missing.
The enhancement looks right, but I'm worried that the existing transform can increase the instruction count if any of the pieces in the pattern have more than one use. Are we missing m_OneUse() in some/all of the matchers?
Adding more potential reviewers.
LGTM. See inline for a possible follow-up and nit.
Functionally, I think this is correct and complete now. See inline for some nits.
Wed, Jun 14
If there are no objections, I would add the regression tests with the current output as a preliminary step, so we document the current behavior.
Tue, Jun 13
The analysis looks right to me - this won't work for non-power-of-2 widths, and there's nothing restricting the possible widths coming into here AFAICT.
Thanks! Do you need someone to commit this for you?
Mon, Jun 12
Sorry for the delay. Can this bug be exposed with an IR transform or a codegen test?
The patch was approved with the requirement to use "getChain()", but IIUC, we can't do that here. Can someone confirm if I understood that correctly?
Sun, Jun 11
A couple of notes for reference:
- There's another potential case for trying harder to recognize a splat mask in PR32007:
Fri, Jun 9
Ping * 2.
Thu, Jun 8
Ping * 2.