Page MenuHomePhabricator

khchen (Zakk Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 23 2013, 8:22 AM (453 w, 2 d)

Recent Activity

Today

khchen accepted D128972: [RISCV][NFC] Simplify condition of IsTU..

LGTM, thanks!

Fri, Jul 1, 7:25 AM · Restricted Project, Restricted Project

Yesterday

khchen added a comment to D111617: [RISCV] Lazily add RVV C intrinsics..

@craig.topper @rogfer01 - do you have other comments?

Thu, Jun 30, 8:55 AM · Restricted Project, Restricted Project, Restricted Project
khchen accepted D111617: [RISCV] Lazily add RVV C intrinsics..

LGTM. Other than that last comments.

Thu, Jun 30, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 20

khchen added a comment to D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null.

Could you please purpose this implement in rvv-intrinsc-doc first?
I think this feature need to have discussion because store to nullptr is UB but we are making it as defined behavior only for these intrinsics.
Personally I like they have consistent behavior and in document side we just make a note for users that vl should not be a null pointer.

Mon, Jun 20, 8:30 AM · Restricted Project, Restricted Project

Wed, Jun 8

khchen added a comment to D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null.

IMO, if I'm an user, I would not expected intrinsic function will generate the condition code to impact the performance, maybe we need to raise a issue in rvv-intrinsic-doc.

Wed, Jun 8, 7:11 AM · Restricted Project, Restricted Project

Tue, Jun 7

khchen added a comment to D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null.

Store to null will be changed to unreachable, so all instructions after vleff intrinsic call will be deleted and it causes runtime errors. If destination to store is null, we won't extract and store the new vl.

Tue, Jun 7, 7:06 PM · Restricted Project, Restricted Project

Wed, Jun 1

khchen added a comment to D125624: [gold] Remove an external dependency to GNU binutils' header file.

IMO, maybe we could keep the DLLVM_BINUTILS_INCDIR option support but default is using the Plugin.h?

Wed, Jun 1, 7:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

khchen added a comment to D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics..

Is there an easy way to update tests? Or we need to add passthru operands manually? I will appreciate it if you can tell me. :-)

Jun 1 2022, 8:09 AM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

khchen requested review of D126750: [RISCV][Clang] Support policy function for all vector segment load..
May 31 2022, 6:29 PM · Restricted Project, Restricted Project
khchen requested review of D126749: [RISCV][Clang] Support policy functions for Vector Mask Instructions..
May 31 2022, 6:28 PM · Restricted Project, Restricted Project
khchen requested review of D126748: [RISCV][Clang] Support policy functions for Vector Reduction Instructions..
May 31 2022, 6:26 PM · Restricted Project, Restricted Project
khchen requested review of D126746: [RISCV][Clang] Support policy functions for Vector Comparison Instructions..
May 31 2022, 6:24 PM · Restricted Project, Restricted Project
khchen requested review of D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress..
May 31 2022, 6:22 PM · Restricted Project, Restricted Project
khchen requested review of D126744: [RISCV][Clang] Support policy functions for vneg, vnot, vncvt, vwcvt, vwcvtu, vfabs and vfneg..
May 31 2022, 6:20 PM · Restricted Project, Restricted Project
khchen requested review of D126743: [RISCV][Clang] Add tests for all supported policy functions. (NFC).
May 31 2022, 6:15 PM · Restricted Project, Restricted Project
khchen requested review of D126742: [RISCV][Clang] Support RVV policy functions..
May 31 2022, 6:12 PM · Restricted Project, Restricted Project
khchen requested review of D126741: [RISCV][Clang] Refactor RISCVVEmitter. (NFC).
May 31 2022, 6:08 PM · Restricted Project, Restricted Project
khchen requested review of D126740: [RISCV][Clang] Refactor and rename rvv intrinsic related stuff. (NFC).
May 31 2022, 6:07 PM · Restricted Project, Restricted Project
khchen committed rG79e3d57f5228: [RISCV][NFC] Rename variables in rvv intrinsics related files. (authored by khchen).
[RISCV][NFC] Rename variables in rvv intrinsics related files.
May 31 2022, 5:44 PM · Restricted Project, Restricted Project
khchen closed D126634: [RISCV][NFC] Rename variables in rvv intrinsics related files..
May 31 2022, 5:43 PM · Restricted Project, Restricted Project

May 30 2022

khchen added a reviewer for D126634: [RISCV][NFC] Rename variables in rvv intrinsics related files.: fakepaper56.
May 30 2022, 1:14 AM · Restricted Project, Restricted Project
khchen requested review of D126634: [RISCV][NFC] Rename variables in rvv intrinsics related files..
May 30 2022, 12:29 AM · Restricted Project, Restricted Project

May 25 2022

khchen added inline comments to D111617: [RISCV] Lazily add RVV C intrinsics..
May 25 2022, 2:32 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2022

khchen accepted D126319: [RISCV] Fix vnsrl/vnsra isel patterns that are dropping VL..

LGTM!

May 24 2022, 5:45 PM · Restricted Project, Restricted Project
khchen abandoned D125546: [RISCV] Use tail agnostic if inserting subvector/element at the end of the vector..

Skimming through the code, is there any value in having a policy arg on slideup? If so, I might suggest adding it to both in an NFC change, and then doing a separate change to show the opt quality improvement.

May 24 2022, 8:55 AM · Restricted Project, Restricted Project

May 19 2022

khchen accepted D126042: [RISCV][NFC] Remove `*=` operator for LMULType.

LGTM, thanks.

May 19 2022, 11:44 PM · Restricted Project, Restricted Project
khchen added a comment to D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t.

I think we have no consensus in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuecomment-817890161, and most people disagree the current naming,
maybe we need to have more followup discussion before landing this patch.

Thanks for your reminding of previous discussion!
Should we put this in next sync-up discussion agenda and settle it down? There are already some large code bases based GCC implementation, we should make it stable before it becomes too hard to change.

May 19 2022, 10:31 PM · Restricted Project, Restricted Project
khchen added a comment to D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h.

please move those tests to test/CodeGen/RISCV/rvv-intrinsics and rename them without rvv- prefix.

May 19 2022, 10:02 PM · Restricted Project, Restricted Project
khchen planned changes to D125546: [RISCV] Use tail agnostic if inserting subvector/element at the end of the vector..
May 19 2022, 7:59 AM · Restricted Project, Restricted Project
khchen added a comment to D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t.

I think we have no consensus in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuecomment-817890161, and most people disagree the current naming,
maybe we need to have more followup discussion before landing this patch.

May 19 2022, 2:47 AM · Restricted Project, Restricted Project

May 18 2022

khchen accepted D125886: [RISCV][NFC] Rename variable in RISCVVEmitter.cpp.

LGTM, thanks!

May 18 2022, 8:12 AM · Restricted Project, Restricted Project

May 15 2022

khchen committed rG1878f240c9ad: [RISCV] Fix incorrect use of tail agnostic vslideup. (authored by khchen).
[RISCV] Fix incorrect use of tail agnostic vslideup.
May 15 2022, 7:06 PM · Restricted Project, Restricted Project
khchen closed D125545: [RISCV] Fix incorrect use of tail agnostic vslideup..
May 15 2022, 7:06 PM · Restricted Project, Restricted Project

May 13 2022

khchen added a comment to D111617: [RISCV] Lazily add RVV C intrinsics..

Do we need to have some tests in clang/test/PCH/ for new #pragma?

May 13 2022, 9:19 AM · Restricted Project, Restricted Project, Restricted Project
khchen accepted D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils..

Thanks Kito. This all LGTM except some warnings need to fix.

May 13 2022, 8:23 AM · Restricted Project, Restricted Project
khchen requested review of D125546: [RISCV] Use tail agnostic if inserting subvector/element at the end of the vector..
May 13 2022, 6:51 AM · Restricted Project, Restricted Project
khchen requested review of D125545: [RISCV] Fix incorrect use of tail agnostic vslideup..
May 13 2022, 6:50 AM · Restricted Project, Restricted Project
khchen closed D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics..
May 13 2022, 2:17 AM · Restricted Project, Restricted Project, Restricted Project
khchen committed rG7dfc56c10746: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics. (authored by khchen).
[RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.
May 13 2022, 2:17 AM · Restricted Project, Restricted Project, Restricted Project

May 11 2022

khchen accepted D125424: [RISCV] Use tail agnostic policy when selecting riscv_fma_vl to instructions.

LGTM, thanks!

May 11 2022, 6:36 PM · Restricted Project, Restricted Project
khchen updated the diff for D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics..

address Craig's comments, thanks!!

May 11 2022, 8:28 AM · Restricted Project, Restricted Project, Restricted Project
khchen added a comment to D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils..

Thanks for refactoring!

May 11 2022, 1:44 AM · Restricted Project, Restricted Project

May 10 2022

khchen requested review of D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics..
May 10 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2022

khchen updated the diff for D124833: [RISCV] Optimize redundant vsetvli for Vector Mask-Register Logical Instructions..

address frasercrmck's comments, thanks!

May 5 2022, 9:54 AM · Restricted Project, Restricted Project
khchen added a comment to D124961: [riscv] Use X0 for destination of VSETVLI instruction if result unused.

I think maybe it's good to have pre-commit test to demonstrate VLS realistic cases could be benefited by this improvement, or at least mention realistic test are coming from VLS vectorization in commit message.

May 5 2022, 7:27 AM · Restricted Project, Restricted Project

May 4 2022

khchen committed rG6c10014f1de6: [RISCV][Clang] add more tests for clang driver. (NFC) (authored by khchen).
[RISCV][Clang] add more tests for clang driver. (NFC)
May 4 2022, 11:58 PM · Restricted Project, Restricted Project
khchen closed D124611: [RISCV][Clang] add more tests for clang driver. (NFC).
May 4 2022, 11:58 PM · Restricted Project, Restricted Project

May 3 2022

khchen updated the diff for D124833: [RISCV] Optimize redundant vsetvli for Vector Mask-Register Logical Instructions..

update comment.

May 3 2022, 2:25 AM · Restricted Project, Restricted Project
khchen requested review of D124833: [RISCV] Optimize redundant vsetvli for Vector Mask-Register Logical Instructions..
May 3 2022, 2:22 AM · Restricted Project, Restricted Project
khchen updated the diff for D124611: [RISCV][Clang] add more tests for clang driver. (NFC).

Add zve64* tests.

May 3 2022, 12:11 AM · Restricted Project, Restricted Project

May 2 2022

khchen added reviewers for D124611: [RISCV][Clang] add more tests for clang driver. (NFC): kito.cheng, eopXD.
May 2 2022, 9:57 PM · Restricted Project, Restricted Project
khchen added inline comments to D124684: [RISCV] Fix incorrect codegen for masked vmsge{u}.vx with mask agnostic..
May 2 2022, 6:58 PM · Restricted Project, Restricted Project
khchen committed rG5807e59a0ab4: [RISCV] Fix incorrect codegen for masked vmsge{u}.vx with mask agnostic. (authored by khchen).
[RISCV] Fix incorrect codegen for masked vmsge{u}.vx with mask agnostic.
May 2 2022, 6:04 PM · Restricted Project, Restricted Project
khchen closed D124684: [RISCV] Fix incorrect codegen for masked vmsge{u}.vx with mask agnostic..
May 2 2022, 6:04 PM · Restricted Project, Restricted Project

Apr 29 2022

khchen requested review of D124684: [RISCV] Fix incorrect codegen for masked vmsge{u}.vx with mask agnostic..
Apr 29 2022, 9:42 AM · Restricted Project, Restricted Project
khchen accepted D124510: [RISCV] Precommit test for D124509.

LGTM. Thanks!

Apr 29 2022, 8:34 AM · Restricted Project, Restricted Project

Apr 28 2022

khchen requested review of D124611: [RISCV][Clang] add more tests for clang driver. (NFC).
Apr 28 2022, 6:30 AM · Restricted Project, Restricted Project
khchen added a comment to D124424: [RISCV] Fix alias printing for vmnot.m.

LGTM too.

Apr 28 2022, 2:38 AM · Restricted Project, Restricted Project

Apr 27 2022

khchen added a comment to D124509: [RISCV] Fix int16 -> __fp16 conversion code gen.

It's seem like all targets need to return false in useFP16ConversionIntrinsics for correctness of int16 -> __fp16 conversion?

Apr 27 2022, 7:50 PM · Restricted Project, Restricted Project

Apr 25 2022

khchen committed rGffe03ff75c26: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup. (authored by khchen).
[RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup.
Apr 25 2022, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
khchen closed D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup..
Apr 25 2022, 9:20 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

khchen added a comment to D124187: [RISCV] Print human-readable VTYPE/SEW operands in MIR.

It's already accepted and committed, but I just want to say thanks, @frasercrmck, I always need to spend time to decode that when I read the value in MIR, that really save my life.

Apr 22 2022, 7:31 PM · Restricted Project, Restricted Project
khchen committed rG3a978b7b88b8: [RISCV][test] Rename prefix and remove unused text (NFC) (authored by khchen).
[RISCV][test] Rename prefix and remove unused text (NFC)
Apr 22 2022, 7:27 PM · Restricted Project, Restricted Project
khchen closed D124179: [RISCV][NFC] Remove unused text in the test..
Apr 22 2022, 7:27 PM · Restricted Project, Restricted Project
khchen updated the diff for D124179: [RISCV][NFC] Remove unused text in the test..

RV32-ZVE32F and RV64-ZVE32F result are identical. Use ZVE32F prefix directly.

Apr 22 2022, 10:17 AM · Restricted Project, Restricted Project
khchen updated the diff for D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup..

update clang tests.

Apr 22 2022, 10:08 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

khchen added a comment to D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup..

The intrinsic interface doesn't care about 0<i<vstart for slidedown. We don't give user control of vstart. Nearly every instruction is undisturbed for 0<i<vstart.

But having said that it probably makes sense to keep the vslideup/down interface the same.

Apr 21 2022, 10:02 PM · Restricted Project, Restricted Project, Restricted Project
khchen updated the summary of D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup..
Apr 21 2022, 10:00 PM · Restricted Project, Restricted Project, Restricted Project
khchen updated the diff for D124179: [RISCV][NFC] Remove unused text in the test..

address @frasercrmck's comment. thanks!

Apr 21 2022, 9:50 PM · Restricted Project, Restricted Project
khchen added inline comments to D124187: [RISCV] Print human-readable VTYPE/SEW operands in MIR.
Apr 21 2022, 8:00 PM · Restricted Project, Restricted Project
khchen requested review of D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup..
Apr 21 2022, 9:57 AM · Restricted Project, Restricted Project, Restricted Project
khchen requested review of D124179: [RISCV][NFC] Remove unused text in the test..
Apr 21 2022, 8:50 AM · Restricted Project, Restricted Project

Apr 20 2022

khchen added a comment to D124062: [RISCV][Clang][NFC] Update vid intrinsic tests..

Were they perhaps passing because i64 [[VL:%.*]] was matching the , i64 0 too? Seems like a flaw in the checks generated by the script, but I can see how the majority of the time the brevity is nice.

Apr 20 2022, 1:39 AM · Restricted Project, Restricted Project
khchen committed rGbd0d126302a8: [RISCV][Clang][NFC] Update vid intrinsic tests. (authored by khchen).
[RISCV][Clang][NFC] Update vid intrinsic tests.
Apr 20 2022, 1:37 AM · Restricted Project, Restricted Project
khchen committed rGe4cd110f1cc2: [NFC] test commit (authored by 0x59616e).
[NFC] test commit
Apr 20 2022, 1:37 AM
khchen committed rGf6bdbb91c285: [NFC] Empty test commit, check commit access (authored by tingwang).
[NFC] Empty test commit, check commit access
Apr 20 2022, 1:37 AM
khchen closed D124062: [RISCV][Clang][NFC] Update vid intrinsic tests..
Apr 20 2022, 1:37 AM · Restricted Project, Restricted Project

Apr 19 2022

khchen requested review of D124062: [RISCV][Clang][NFC] Update vid intrinsic tests..
Apr 19 2022, 8:49 PM · Restricted Project, Restricted Project

Apr 11 2022

khchen accepted D123553: [RISCV] Add a encodeLMUL function to RISCVVType. NFC.

LGTM, thanks!

Apr 11 2022, 9:09 PM · Restricted Project, Restricted Project

Apr 6 2022

khchen added inline comments to D120226: [RISCV] Support mask policy for RVV IR intrinsics..
Apr 6 2022, 7:35 PM · Restricted Project, Restricted Project

Mar 31 2022

khchen added inline comments to D121376: [RISCV][RVV] Introduce roundmode operand to PseudoVAADD instruction.
Mar 31 2022, 2:56 AM · Restricted Project, Restricted Project

Mar 29 2022

khchen committed rGb5783307543d: [RISCV] Use maskedoff to decide mask policy for masked compare and… (authored by khchen).
[RISCV] Use maskedoff to decide mask policy for masked compare and…
Mar 29 2022, 6:22 PM · Restricted Project, Restricted Project
khchen committed rG10b2760da0fd: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR" (authored by khchen).
Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR"
Mar 29 2022, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
khchen added a reverting change for rG10fd2822b77e: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR: rG10b2760da0fd: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR".
Mar 29 2022, 6:22 PM · Restricted Project
khchen closed D122456: [RISCV] Use maskedoff to decide mask policy for masked compare and vmsbf/vmsif/vmsof..
Mar 29 2022, 6:22 PM · Restricted Project, Restricted Project
khchen added a reverting change for D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.: rG10b2760da0fd: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR".
Mar 29 2022, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
khchen closed D122455: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR".
Mar 29 2022, 6:21 PM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2022

khchen added inline comments to D122456: [RISCV] Use maskedoff to decide mask policy for masked compare and vmsbf/vmsif/vmsof..
Mar 27 2022, 6:36 PM · Restricted Project, Restricted Project
khchen updated the diff for D122456: [RISCV] Use maskedoff to decide mask policy for masked compare and vmsbf/vmsif/vmsof..

Fix typo. Thanks!
It's good to update this chagned soon if it does make sense,
because I change the IR interface again...
I believe changing the IR interface frequently is annoying.

Mar 27 2022, 6:36 PM · Restricted Project, Restricted Project

Mar 24 2022

khchen requested review of D122456: [RISCV] Use maskedoff to decide mask policy for masked compare and vmsbf/vmsif/vmsof..
Mar 24 2022, 9:00 PM · Restricted Project, Restricted Project
khchen added a reverting change for rG10fd2822b77e: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR: D122455: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR".
Mar 24 2022, 9:00 PM · Restricted Project
khchen requested review of D122455: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR".
Mar 24 2022, 9:00 PM · Restricted Project, Restricted Project, Restricted Project
khchen added a reverting change for D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.: D122455: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR".
Mar 24 2022, 9:00 PM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

khchen accepted D122290: [RISCV] Remove check and update test file in D121183.

LGTM, thanks!!!

Mar 23 2022, 12:36 AM · Restricted Project, Restricted Project

Mar 22 2022

khchen committed rG23d60ce164db: [RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td. (authored by khchen).
[RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td.
Mar 22 2022, 10:12 AM · Restricted Project
khchen closed D120870: [RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td..
Mar 22 2022, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
khchen committed rG10fd2822b77e: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR (authored by khchen).
[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR
Mar 22 2022, 7:53 AM · Restricted Project
khchen closed D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics..
Mar 22 2022, 7:53 AM · Restricted Project, Restricted Project, Restricted Project
khchen committed rG9ab18cc53537: [RISCV] Add policy operand for masked vid and viota IR intrinsics. (authored by khchen).
[RISCV] Add policy operand for masked vid and viota IR intrinsics.
Mar 22 2022, 2:33 AM · Restricted Project
khchen closed D120227: [RISCV] Add policy operand for masked vid and viota IR intrinsics..
Mar 22 2022, 2:33 AM · Restricted Project, Restricted Project, Restricted Project