User Details
- User Since
- Oct 23 2013, 8:22 AM (518 w, 5 d)
May 23 2023
we don't need this patch because we already handle the empty target-abi module flag now.
I'm not working on RISC-V now and please reference https://reviews.llvm.org/D132843#3770454 to see the follow-up work.
I'm not working on RISC-V now and please reference https://reviews.llvm.org/D132843#3770454 to see the follow-up work.
D135327 fixed this issue.
Dec 29 2022
LGTM. Thanks for clean up code!
Dec 27 2022
LGTM, thanks!!
Dec 26 2022
LGTM, thanks!
Nov 21 2022
Nov 10 2022
Oct 22 2022
Sep 6 2022
Possible solution/results:
- All functions in a.o and b.o using same target features during the first build stage, -march=rv64gc for a.o, -march=rv64g for b.o, and -march option given in LTO CodeGen stage is ignored, it only used for ELF attribute use (this revision).
- All functions in a.o and b.o using same target features during the first build stage, -march=rv64gc for a.o, -march=rv64g for b.o, and deduced arch info from those .o for ELF attribute use (D106347), -march
- All functions in a.o and b.o re-compile with -march=rv64gc_zba and ELF attribute use rv64gc_zba.
Option 1: Require user use right -march option during LTO stage, and might fill wrong/unexpected ELF attribute if give wrong -march or not even not given in LTO stage.
Option 2: Should be more ideal, but D106347 seems no progress for a while.
Option 3: This option will break IFUNC usage.
Aug 4 2022
Aug 2 2022
@nlopes we will update all undef to poison in follow up patches.
Aug 1 2022
oops.. all tests need to updated and include all intrinsic IR tests...
Is there any benefit to switch UndefValue to PoisonValue?
maybe those changed should be in other follow-up patches?
Jul 27 2022
rebase and address @fakepaper56 and @StephenFan's comments, also do some refactoring.
Jul 26 2022
Jul 5 2022
Jul 1 2022
LGTM, thanks!
Jun 30 2022
@craig.topper @rogfer01 - do you have other comments?
LGTM. Other than that last comments.
Jun 20 2022
Could you please purpose this implement in rvv-intrinsc-doc first?
I think this feature need to have discussion because store to nullptr is UB but we are making it as defined behavior only for these intrinsics.
Personally I like they have consistent behavior and in document side we just make a note for users that vl should not be a null pointer.
Jun 8 2022
IMO, if I'm an user, I would not expected intrinsic function will generate the condition code to impact the performance, maybe we need to raise a issue in rvv-intrinsic-doc.
Jun 7 2022
Store to null will be changed to unreachable, so all instructions after vleff intrinsic call will be deleted and it causes runtime errors. If destination to store is null, we won't extract and store the new vl.
Jun 1 2022
IMO, maybe we could keep the DLLVM_BINUTILS_INCDIR option support but default is using the Plugin.h?
May 31 2022
May 30 2022
May 25 2022
May 24 2022
LGTM!
May 19 2022
LGTM, thanks.
please move those tests to test/CodeGen/RISCV/rvv-intrinsics and rename them without rvv- prefix.
I think we have no consensus in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuecomment-817890161, and most people disagree the current naming,
maybe we need to have more followup discussion before landing this patch.
May 18 2022
LGTM, thanks!
May 15 2022
May 13 2022
Do we need to have some tests in clang/test/PCH/ for new #pragma?
Thanks Kito. This all LGTM except some warnings need to fix.
May 11 2022
LGTM, thanks!
address Craig's comments, thanks!!
Thanks for refactoring!
May 10 2022
May 5 2022
address frasercrmck's comments, thanks!
I think maybe it's good to have pre-commit test to demonstrate VLS realistic cases could be benefited by this improvement, or at least mention realistic test are coming from VLS vectorization in commit message.
May 4 2022
May 3 2022
update comment.
Add zve64* tests.
May 2 2022
Apr 29 2022
LGTM. Thanks!
Apr 28 2022
LGTM too.
Apr 27 2022
It's seem like all targets need to return false in useFP16ConversionIntrinsics for correctness of int16 -> __fp16 conversion?