- User Since
- Oct 23 2013, 8:22 AM (453 w, 2 d)
LGTM. Other than that last comments.
Mon, Jun 20
Could you please purpose this implement in rvv-intrinsc-doc first?
I think this feature need to have discussion because store to nullptr is UB but we are making it as defined behavior only for these intrinsics.
Personally I like they have consistent behavior and in document side we just make a note for users that vl should not be a null pointer.
Wed, Jun 8
IMO, if I'm an user, I would not expected intrinsic function will generate the condition code to impact the performance, maybe we need to raise a issue in rvv-intrinsic-doc.
Tue, Jun 7
Store to null will be changed to unreachable, so all instructions after vleff intrinsic call will be deleted and it causes runtime errors. If destination to store is null, we won't extract and store the new vl.
Wed, Jun 1
IMO, maybe we could keep the DLLVM_BINUTILS_INCDIR option support but default is using the Plugin.h?
Jun 1 2022
May 31 2022
May 30 2022
May 25 2022
May 24 2022
May 19 2022
please move those tests to test/CodeGen/RISCV/rvv-intrinsics and rename them without rvv- prefix.
I think we have no consensus in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuecomment-817890161, and most people disagree the current naming,
maybe we need to have more followup discussion before landing this patch.
May 18 2022
May 15 2022
May 13 2022
Do we need to have some tests in clang/test/PCH/ for new #pragma?
Thanks Kito. This all LGTM except some warnings need to fix.
May 11 2022
address Craig's comments, thanks!!
Thanks for refactoring!
May 10 2022
May 5 2022
address frasercrmck's comments, thanks!
I think maybe it's good to have pre-commit test to demonstrate VLS realistic cases could be benefited by this improvement, or at least mention realistic test are coming from VLS vectorization in commit message.
May 4 2022
May 3 2022
Add zve64* tests.
May 2 2022
Apr 29 2022
Apr 28 2022
Apr 27 2022
It's seem like all targets need to return false in useFP16ConversionIntrinsics for correctness of int16 -> __fp16 conversion?
Apr 25 2022
Apr 22 2022
RV32-ZVE32F and RV64-ZVE32F result are identical. Use ZVE32F prefix directly.
update clang tests.
Apr 21 2022
address @frasercrmck's comment. thanks!
Apr 20 2022
Apr 19 2022
Apr 11 2022
Apr 6 2022
Mar 31 2022
Mar 29 2022
Mar 27 2022
Fix typo. Thanks!
It's good to update this chagned soon if it does make sense,
because I change the IR interface again...
I believe changing the IR interface frequently is annoying.
Mar 24 2022
Mar 23 2022