Page MenuHomePhabricator

dpaoliello (Daniel Paoliello)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2020, 4:53 PM (97 w, 6 d)

Recent Activity

Jun 2 2022

dpaoliello added inline comments to D126811: [ARM64EC 10/?] Add support for lowering indirect calls..
Jun 2 2022, 1:45 PM · Restricted Project, Restricted Project
dpaoliello added inline comments to D126811: [ARM64EC 10/?] Add support for lowering indirect calls..
Jun 2 2022, 12:29 PM · Restricted Project, Restricted Project
dpaoliello added inline comments to D126809: [ARM64EC 8/?] Implement ARM64EC "thunk" calling conventions.
Jun 2 2022, 11:50 AM · Restricted Project, Restricted Project
dpaoliello added inline comments to D126809: [ARM64EC 8/?] Implement ARM64EC "thunk" calling conventions.
Jun 2 2022, 11:48 AM · Restricted Project, Restricted Project

Jun 1 2022

dpaoliello added inline comments to D126809: [ARM64EC 8/?] Implement ARM64EC "thunk" calling conventions.
Jun 1 2022, 4:16 PM · Restricted Project, Restricted Project
dpaoliello added inline comments to D126809: [ARM64EC 8/?] Implement ARM64EC "thunk" calling conventions.
Jun 1 2022, 4:11 PM · Restricted Project, Restricted Project
dpaoliello accepted D125415: [ARM64EC 4/?] Add LLVM support for varargs calling convention..
Jun 1 2022, 11:40 AM · Restricted Project, Restricted Project

May 31 2022

dpaoliello added a comment to D125412: [ARM64EC 2/?] Add target triple, and allow targeting it..

Veering slightly offtopic here, but - I'm curious - is it possible to link in regular aarch64 object files in an arm64ec executable (for functions where the calling convention doesn't differ from regular aarch64)? Those object files would only ever be called from arm64ec code (not from x86_64), so I wonder if it would work without all the thunks that are present in arm64ec object files. (In particular, the case I have in mind is cases with handwritten aarch64 assembly.) Would it be possible to mark such functions with a calling convention attribute on the C level, to let the compiler generate code for calling regular aarch64 functions?

May 31 2022, 2:07 PM · Restricted Project, Restricted Project
dpaoliello added a comment to D125412: [ARM64EC 2/?] Add target triple, and allow targeting it..

We could do something like arm64ec-pc-windows-msvc, I guess. That sort of goes against the spirit of target triples: the first part is usually used to describe the instruction set, and the fourth part is usually used to describe alternate ABI/environment/etc. It's not like "arm64ec" makes sense anywhere other than Windows, anyway.

Of course, everything related to triples is a bit fuzzy; if we want to use AArch64SubArch_arm64ec, there isn't really anything stopping us.

May 31 2022, 1:28 PM · Restricted Project, Restricted Project
dpaoliello added inline comments to D125415: [ARM64EC 4/?] Add LLVM support for varargs calling convention..
May 31 2022, 11:06 AM · Restricted Project, Restricted Project
dpaoliello accepted D125417: [ARM64EC 5/?] Fix names of __chkstk and __security_check_cookie..
May 31 2022, 10:54 AM · Restricted Project, Restricted Project
dpaoliello added inline comments to D125415: [ARM64EC 4/?] Add LLVM support for varargs calling convention..
May 31 2022, 10:50 AM · Restricted Project, Restricted Project
dpaoliello added a comment to D125415: [ARM64EC 4/?] Add LLVM support for varargs calling convention..

What about split args (i.e., i128)? It's my understanding that these need to be passed indirect, but LLVM automatically splits them into two i64 args.

May 31 2022, 10:37 AM · Restricted Project, Restricted Project
dpaoliello accepted D125413: [ARM64EC 3/?] Mark reserved registers specific to ARM64EC ABI..

You may also want to use the exiting llvm/test/CodeGen/AArch64/arm64-platform-reg.ll test case.

May 31 2022, 10:28 AM · Restricted Project, Restricted Project

Apr 28 2022

dpaoliello removed a reviewer for D124642: [WIP] Add support for return from an SEH __finally block.: dpaoliello.
Apr 28 2022, 4:08 PM · Restricted Project, Restricted Project, Restricted Project
dpaoliello resigned from D124642: [WIP] Add support for return from an SEH __finally block..
Apr 28 2022, 4:08 PM · Restricted Project, Restricted Project, Restricted Project

Dec 6 2021

dpaoliello added inline comments to D102817: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 2.
Dec 6 2021, 3:46 PM · Restricted Project, Restricted Project

Aug 31 2021

dpaoliello abandoned D108679: Restrict ARM IT Blocks on Windows.

The performance deprecation of certain forms of IT blocks has been reverted.
The performance deprecation notes are being removed from the Arm ARM.
I am expecting that in the near future, code generation for Arm will be adapted to not enable -mrestrict-it by default at all, following what was already done in gcc at https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg00134.html.

As such, I'm not sure if this patch is a good thing to implement.
Maybe the guidelines in Microsoft's document you point to (https://docs.microsoft.com/en-us/cpp/build/overview-of-arm-abi-conventions?view=msvc-160#it-instructions) should be adapted to take into account the above described changes to the ArmARM?

@kristof.beyls Can you please point me to any official documentation or announcement from ARM about this (I've tried looking myself but couldn't see anything)?
I'd be happy to abandon this change and get the Microsoft docs updated if these instructions are no longer deprecated.

I have not found a direct public announcement from Arm about this.
The "performance deprecation for certain forms of IT blocks" notes in the Arm Architecture Reference Manual (ArmARM) should have been all removed from the latest version at https://developer.arm.com/documentation/ddi0487/latest
I've found that a few places were missed and raised a defect against the Arm Architecture Reference Manual to get them all removed.
AFAIK, not having these "performance deprecation" notes in the ArmARM may end up being the only documentation about this.

Aug 31 2021, 2:06 PM · Restricted Project

Aug 30 2021

dpaoliello added a comment to D43002: [CodeView] Emit S_OBJNAME record.

@rnk @aganea Ping... Just wanted to see what was happening with this change, and if there is anything I can do to help get it merged in.

Aug 30 2021, 10:51 AM · Restricted Project, Restricted Project

Aug 26 2021

dpaoliello added a comment to D108679: Restrict ARM IT Blocks on Windows.

This change seems fine to me, but can we add some sort of testcase for it? Do we have an existing testcase that check for the default behaviour when targeting armv8 somewhere?

Aug 26 2021, 6:37 PM · Restricted Project
dpaoliello updated the diff for D108679: Restrict ARM IT Blocks on Windows.

Added tests for Restricting IT blocks for v7 vs v8, optimizing for size and Windows.

Aug 26 2021, 6:36 PM · Restricted Project

Aug 25 2021

dpaoliello added a comment to D108679: Restrict ARM IT Blocks on Windows.

The performance deprecation of certain forms of IT blocks has been reverted.
The performance deprecation notes are being removed from the Arm ARM.
I am expecting that in the near future, code generation for Arm will be adapted to not enable -mrestrict-it by default at all, following what was already done in gcc at https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg00134.html.

As such, I'm not sure if this patch is a good thing to implement.
Maybe the guidelines in Microsoft's document you point to (https://docs.microsoft.com/en-us/cpp/build/overview-of-arm-abi-conventions?view=msvc-160#it-instructions) should be adapted to take into account the above described changes to the ArmARM?

Aug 25 2021, 10:17 AM · Restricted Project

Aug 24 2021

dpaoliello added a reviewer for D108679: Restrict ARM IT Blocks on Windows: samparker.
Aug 24 2021, 6:09 PM · Restricted Project
dpaoliello requested review of D108679: Restrict ARM IT Blocks on Windows.
Aug 24 2021, 6:06 PM · Restricted Project

Aug 20 2021

dpaoliello added a comment to D107784: Fix SEH table addresses for Windows.

@rnk Who can help merge this in?

I might have time to apply, run tests and push it - can you provide the git author line, ie “Real Name <email@address>” to use for the commit?

Aug 20 2021, 11:19 AM · Restricted Project
dpaoliello added a comment to D107784: Fix SEH table addresses for Windows.

@rnk Who can help merge this in?

Aug 20 2021, 10:35 AM · Restricted Project

Aug 16 2021

dpaoliello added a comment to D107784: Fix SEH table addresses for Windows.

@rnk Can you please merge this in?

Aug 16 2021, 10:52 AM · Restricted Project

Aug 11 2021

dpaoliello added a reviewer for D107784: Fix SEH table addresses for Windows: tentzen.
Aug 11 2021, 6:04 PM · Restricted Project
dpaoliello added inline comments to D107784: Fix SEH table addresses for Windows.
Aug 11 2021, 1:12 PM · Restricted Project
dpaoliello added inline comments to D107784: Fix SEH table addresses for Windows.
Aug 11 2021, 12:54 PM · Restricted Project
dpaoliello updated the summary of D107784: Fix SEH table addresses for Windows.
Aug 11 2021, 12:06 PM · Restricted Project
dpaoliello updated the summary of D107784: Fix SEH table addresses for Windows.
Aug 11 2021, 12:06 PM · Restricted Project
dpaoliello added inline comments to D107784: Fix SEH table addresses for Windows.
Aug 11 2021, 12:06 PM · Restricted Project
dpaoliello updated the diff for D107784: Fix SEH table addresses for Windows.

Fix ARM IP2State

Aug 11 2021, 12:03 PM · Restricted Project

Aug 10 2021

dpaoliello added inline comments to D107784: Fix SEH table addresses for Windows.
Aug 10 2021, 1:07 PM · Restricted Project
dpaoliello updated the diff for D107784: Fix SEH table addresses for Windows.

Only avoid +1 for SEH start addresses

Aug 10 2021, 12:55 PM · Restricted Project

Aug 9 2021

dpaoliello updated the diff for D107784: Fix SEH table addresses for Windows.

Fix typo

Aug 9 2021, 4:42 PM · Restricted Project
dpaoliello added reviewers for D107784: Fix SEH table addresses for Windows: asl, efriedma, ssijaric.
Aug 9 2021, 3:04 PM · Restricted Project
dpaoliello requested review of D107784: Fix SEH table addresses for Windows.
Aug 9 2021, 2:57 PM · Restricted Project

Jan 12 2021

dpaoliello added a comment to D94456: Fix unused variable in CoroFrame.cpp when building Release with GCC 10.

@lxfind Can you please merge this in?

Jan 12 2021, 10:22 AM · Restricted Project

Jan 11 2021

dpaoliello requested review of D94456: Fix unused variable in CoroFrame.cpp when building Release with GCC 10.
Jan 11 2021, 2:47 PM · Restricted Project

Sep 25 2020

dpaoliello added a comment to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

@lxfind Do you have commit permissions? If so, could you please merge this in?

hmm I still cannot patch this from master. Can you double check that you don't have a local commit in the tree?

Sep 25 2020, 11:25 AM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Regenerate diff

Sep 25 2020, 11:23 AM · Restricted Project
dpaoliello added a comment to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

@lxfind Do you have commit permissions? If so, could you please merge this in?

Sure! Could you please rebase? Somehow I couldn't apply this patch locally.

Sep 25 2020, 11:02 AM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Rebase to master

Sep 25 2020, 11:02 AM · Restricted Project
dpaoliello added a comment to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

@lxfind Do you have commit permissions? If so, could you please merge this in?

Sep 25 2020, 10:39 AM · Restricted Project

Sep 22 2020

dpaoliello added a comment to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

I believe that this commit has the required approvals: can someone please merge it?

Sep 22 2020, 5:41 PM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Add requested assert

Sep 22 2020, 2:07 PM · Restricted Project
dpaoliello added inline comments to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.
Sep 22 2020, 1:56 PM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Addressed feedback

Sep 22 2020, 1:54 PM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Added all context lines

Sep 22 2020, 11:19 AM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Ran clang-format

Sep 22 2020, 11:16 AM · Restricted Project

Sep 21 2020

dpaoliello added a reviewer for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules: GorNishanov.
Sep 21 2020, 5:12 PM · Restricted Project
dpaoliello requested review of D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.
Sep 21 2020, 5:05 PM · Restricted Project