Page MenuHomePhabricator

dpaoliello (Daniel Paoliello)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2020, 4:53 PM (9 w, 6 d)

Recent Activity

Sep 25 2020

dpaoliello added a comment to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

@lxfind Do you have commit permissions? If so, could you please merge this in?

hmm I still cannot patch this from master. Can you double check that you don't have a local commit in the tree?

Sep 25 2020, 11:25 AM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Regenerate diff

Sep 25 2020, 11:23 AM · Restricted Project
dpaoliello added a comment to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

@lxfind Do you have commit permissions? If so, could you please merge this in?

Sure! Could you please rebase? Somehow I couldn't apply this patch locally.

Sep 25 2020, 11:02 AM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Rebase to master

Sep 25 2020, 11:02 AM · Restricted Project
dpaoliello added a comment to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

@lxfind Do you have commit permissions? If so, could you please merge this in?

Sep 25 2020, 10:39 AM · Restricted Project

Sep 22 2020

dpaoliello added a comment to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

I believe that this commit has the required approvals: can someone please merge it?

Sep 22 2020, 5:41 PM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Add requested assert

Sep 22 2020, 2:07 PM · Restricted Project
dpaoliello added inline comments to D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.
Sep 22 2020, 1:56 PM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Addressed feedback

Sep 22 2020, 1:54 PM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Added all context lines

Sep 22 2020, 11:19 AM · Restricted Project
dpaoliello updated the diff for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.

Ran clang-format

Sep 22 2020, 11:16 AM · Restricted Project

Sep 21 2020

dpaoliello added a reviewer for D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules: GorNishanov.
Sep 21 2020, 5:12 PM · Restricted Project
dpaoliello requested review of D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules.
Sep 21 2020, 5:05 PM · Restricted Project