- User Since
- Oct 15 2014, 9:44 AM (348 w, 1 d)
Tue, May 25
Rewrote a good chunk of the document following reviews, responded inline to some. Thanks all for the comments!
Wed, May 19
Thanks all, now landed! I still need to find some time to rewrite the bits about the mailing lists and mention ours.
May 17 2021
Rebased, split tests by intrinsic rather than by GISel vs SDAG (since GISel is now always built and we don't need the separate test directory)
May 11 2021
Ah sorry, I didn't see you tried that already! I don't think we want to weaken the verifier check, this is probably the only case where it makes sense to take the address. I guess we've meandered through the same decision process, thanks for the patience ;) But it might be worth explaining these decisions in the commit message. Also in the langref paragraph for the bundle, it says the call is always emitted for the bundle.
Which brings another idea: how about emitting the call when lowering the bundle on AArch64 as well? There's not much room for better regalloc or other optimizations in the sequence anyway, right?
May 3 2021
Thanks for the comments! Tweaks inline
- mention public discussions on lists/in sync-up, link to sync-up page
- describe Github workflow as potentially useful for publicly disclosing resolved issues
Apr 27 2021
Thanks all! I'll add Kate to the group and issue tracker.
Apr 26 2021
Apr 20 2021
This sounds nice! One idea, maybe more dangerous, not sure which is better: in setTripleTypeForMachOArchName, we already have a couple setArchName calls, I think that's why arm64e is left alone in the aarch64-cpus.c test. Maybe we can do the setArchName call for every arch there?
Apr 12 2021
Mar 25 2021
Thanks George, and welcome!
Mar 17 2021
Can you (or @ahatanak) explain why/how this needs to be different from aarch64? In particular I don't think I understand why you need to emit the retainARV/claimARV calls this late, that seems like quite a drastic difference in behavior for the bundle.
I read through the discussion in D92808 but it sounds like that predates the x86_64-specific behavior, right? But skimming around the various passes involved I'm not actually sure who emits the retainARV/claimARV calls on aarch64.
Jan 26 2021
Dec 3 2020
Thanks Tim! f77c948d56b
Nov 9 2020
Nov 5 2020
Oct 14 2020
No objection here (but let's leave a few more days, per process)*. Thanks Artur, and thanks @reames for helping get the group going!
Sep 17 2020
Sep 3 2020
Sep 1 2020
Hmm, is there a more general way to disable warnings? I'm not familiar with these parts, so I'll defer to you folks =]
Aug 26 2020
Aug 20 2020
Jul 30 2020
Jul 27 2020
This looks sensible, modulo a couple inline comments
Jun 30 2020
Apr 22 2020
Apr 21 2020
Apr 15 2020
Is it possible to make the (defaulting mcpu to "apple-latest") decision in a library, instead of in llvm-objdump and other individual tools?
Jan 9 2020
Seems reasonable. This is an interesting use of MCID flags, in that llvm itself doesn't need it, but I'm all for better disassembler support!