User Details
User Details
- User Since
- Oct 15 2014, 9:44 AM (275 w, 4 d)
Thu, Jan 9
Thu, Jan 9
[AArch64] Adopt upstream ldraa syntax revert. NFC.
ab committed rG0981651bb89a: Update soft ptrauth pass to match upstream change 05da2fe5216. (authored by ab).
Update soft ptrauth pass to match upstream change 05da2fe5216.
ab committed rG4c743ebd73ba: Merge commit 'refs/am/changes/05da2fe52162c80dfa18aedf70cf73cb11201811_apple/ma… (authored by ab).
Merge commit 'refs/am/changes/05da2fe52162c80dfa18aedf70cf73cb11201811_apple/ma…
ab committed rG3b34e59d28b1: Merge commit 'refs/am/changes/44e5879f0fb7c28b90e8042fde81bba30b4090a3_apple/ma… (authored by ab).
Merge commit 'refs/am/changes/44e5879f0fb7c28b90e8042fde81bba30b4090a3_apple/ma…
Seems reasonable. This is an interesting use of MCID flags, in that llvm itself doesn't need it, but I'm all for better disassembler support!
Thu, Jan 9, 3:24 PM · Restricted Project
Dec 12 2019
Dec 12 2019
GitHub <noreply@github.com> committed rGcea2136d4bfa: Merge pull request #14 from apple/dev/arm64e-upstream (authored by ab).
Merge pull request #14 from apple/dev/arm64e-upstream
ab committed rGe398fa8318cf: Language documentation for the pointer authentication feature. (authored by rjmccall).
Language documentation for the pointer authentication feature.
Implement the __ptrauth type qualifier.
ab committed rG34229b5deadc: Make the CGPointerAuthInfo parameter to the general CGCallee constructor… (authored by rjmccall).
Make the CGPointerAuthInfo parameter to the general CGCallee constructor…
ab committed rGe004081624dd: Add prototype support for software pointer authentication. (authored by rjmccall).
Add prototype support for software pointer authentication.
ab committed rGa8e307fc0a53: Sign the v-table pointer in ObjC exception RTTI. (authored by rjmccall).
Sign the v-table pointer in ObjC exception RTTI.
ab committed rG21d1be074aed: Sign the destructor pointer passed to __cxa_throw. (authored by rjmccall).
Sign the destructor pointer passed to __cxa_throw.
ab committed rG6ac1ad095fb3: Sign function pointers passed to atexit and __cxa_atexit. (authored by rjmccall).
Sign function pointers passed to atexit and __cxa_atexit.
ab committed rG8c976181e393: Pointer authentication support for C++ member function pointers. (authored by rjmccall).
Pointer authentication support for C++ member function pointers.
ab committed rG25e71b4def63: Add IR attributes to functions compiled under pointer authentication. (authored by rjmccall).
Add IR attributes to functions compiled under pointer authentication.
ab committed rGa0183393e32b: Implement pointer authentication for C++ virtual functions, v-tables, and VTTs. (authored by rjmccall).
Implement pointer authentication for C++ virtual functions, v-tables, and VTTs.
ab committed rGc077762f44cc: Record the original declaration for which a v-table slot was created. (authored by rjmccall).
Record the original declaration for which a v-table slot was created.
ab committed rGea400995f8de: Pointer authentication support for ObjC method lists. (authored by rjmccall).
Pointer authentication support for ObjC method lists.
Pointer authentication for blocks.
ab committed rG2c01c3374bbd: IRGen preliminaries for pointer authentication, hopefully NFC. (authored by rjmccall).
IRGen preliminaries for pointer authentication, hopefully NFC.
ab committed rG181e26190566: Implement pointer authentication for function pointers. (authored by rjmccall).
Implement pointer authentication for function pointers.
ab committed rGa9dd959e60c3: Add support for the new pointer authentication builtins. (authored by rjmccall).
Add support for the new pointer authentication builtins.
ab committed rG4ec8ebf0bae7: Add an API for computing an ABI-stable hash of a string. (authored by rjmccall).
Add an API for computing an ABI-stable hash of a string.
Basic ptrauth command-line flags.
[DebugInfo] Add 'ptrauth' qualifier support.
ab committed rGaf247a211494: [Transforms] Add pass for software expansion of ptrauth. (authored by Ahmed Bougacha <ahmed.bougacha@gmail.com>).
[Transforms] Add pass for software expansion of ptrauth.
[AArch64] Support return address authentication.
ab committed rG4fdcd961441e: [AArch64] For arm64e Darwin TLS, sign the access thunk pointer. (authored by ab).
[AArch64] For arm64e Darwin TLS, sign the access thunk pointer.
[AArch64] Lower calls with ptrauth operand bundles.
ab committed rG41c9f473fb3d: [AArch64] Lower "llvm.ptrauth" signed global wrappers. (authored by ab).
[AArch64] Lower "llvm.ptrauth" signed global wrappers.
ab committed rGa90507b2d353: [InstCombine] Combine ptrauth intrinsics into call operand bundles. (authored by ab).
[InstCombine] Combine ptrauth intrinsics into call operand bundles.
[IR] Define "ptrauth" operand bundles.
[AArch64] Support emitting "hardened" jump-tables.
[AArch64] Fold auth + load sequences into LDRA.
[AArch64] Lower auth calls/tail-calls.
[AArch64] Lower llvm.ptrauth.blend intrinsics.
[AArch64] Lower llvm.ptrauth.strip intrinsics.
[AArch64] Lower llvm.ptrauth.auth/resign intrinsics.
[AArch64] Lower llvm.ptrauth.sign intrinsics.
[Docs] Document Pointer Authentication IR additions.
[IR] Define new llvm.ptrauth intrinsics.
ab committed rG13d4276f5472: [AArch64] Support @AUTH symbol variant and MachO reloc. (authored by ab).
[AArch64] Support @AUTH symbol variant and MachO reloc.
ab committed rGd3d83e5c68d0: [AArch64] Add helper functions for mapping PAC keys and instructions. (authored by ab).
[AArch64] Add helper functions for mapping PAC keys and instructions.
ab committed rG700888c06556: [AArch64] Support emitting arm64e MachO in Darwin AsmBackend. (authored by ab).
[AArch64] Support emitting arm64e MachO in Darwin AsmBackend.
[utils] Teach UpdateTestChecks about arm64e.
[Object] Add MachO CPU_SUBTYPE_ARM64E.
[Triple] Add 'arm64e', an AArch64 sub-architecture.
[AArch64] Add 'lightning' CPU.
[AArch64] Add 'vortex' CPU.
[AArch64][v8.3a] Add missing imp-defs on RETA*.
[AArch64][v8.3a] Add LDRA '[xN]!' alias.
Dec 4 2019
Dec 4 2019
Dec 4 2019, 10:39 AM · Restricted Project
Dec 3 2019
Dec 3 2019
ab added inline comments to D70779: AArch64: add support for newer Apple CPUs.
Dec 3 2019, 10:24 AM · Restricted Project
(but either way, LGTM)
Dec 3 2019, 10:24 AM · Restricted Project
Dec 2 2019
Dec 2 2019
ab added inline comments to D70779: AArch64: add support for newer Apple CPUs.
Dec 2 2019, 12:25 PM · Restricted Project
Nov 13 2019
Nov 13 2019
[AArch64][v8.3a] Add missing imp-defs on RETA*.
[AArch64][v8.3a] Add LDRA '[xN]!' alias.
Apr 8 2019
Apr 8 2019
Sorry for the delay; go ahead, the patch looks OK.
Apr 8 2019, 12:21 PM · Restricted Project
Mar 6 2019
Mar 6 2019
ab added a comment to D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library..
Please check the embedded thing (the other comments are minor). Otherwise, LGTM; if you have found this flag to be necessary, this looks like a reasonable way to implement it
ab added a comment to D58636: [BinaryFormat] Update Mach-O ARM64E CPU subtype and dumping.
Hmm, if I may: what do you want to support? I'd expect Apple to upstream their own patches.
Mar 6 2019, 2:52 PM · Restricted Project
Feb 20 2019
Feb 20 2019
ab added a comment to D58306: [AArch64] Change size suffix for FP16FML intrinsics..
Thanks for checking, much appreciated!
[AArch64] Change size suffix for FP16FML intrinsics.
[AArch64] Change size suffix for FP16FML intrinsics.
[AArch64] Change size suffix for FP16FML intrinsics.
Feb 15 2019
Feb 15 2019
ab requested changes to D58232: GlobalISel: Don't materialize immarg arguments to intrinsics.
On second thought, what happens to the tablegen emitter? That needs to be taught about these as well, right? That might not trigger on anything right now though.
ab added inline comments to D53633: [AArch64] Implement FP16FML intrinsics.
Feb 15 2019, 2:11 PM · Restricted Project
Nice!
Feb 14 2019
Feb 14 2019
Feb 14 2019, 4:30 PM · Restricted Project
Dec 19 2018
Dec 19 2018
Looks good, thanks!
Dec 17 2018
Dec 17 2018
ab accepted D55731: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch` is not specified.
LGTM, thanks!
Oct 3 2018
Oct 3 2018
Jul 31 2018
Jul 31 2018
Jul 26 2018
Jul 26 2018
ab added a comment to D49791: [AArch64] - Generate pointer authentication instructions.
A few minor comments inline, and one question: it sounds like this is based on a GCC feature; what's the expected behavior for __builtin_returnaddress ? Shouldn't it xpaci the result?
Jul 19 2018
Jul 19 2018
ab accepted D49524: Avoid generating FGETSIGN for f16.
LGTM. Not the biggest fan of CodeGen/Generic tests, but it gets the job done, I suppose ;) I wouldn't be surprised if it failed on some target that can't even handle half parameters, so you might want to load it instead, put it in x86, or wait and see - your pick.
Jun 28 2018
Jun 28 2018
[CMake] Rename cxx_headers back to cxx-headers.
[CMake] Rename cxx_headers back to cxx-headers.
[CMake] Make bootstrap and compiler-rt depend on cxx-headers.
[CMake] Make bootstrap and compiler-rt depend on cxx-headers.
Jun 27 2018
Jun 27 2018
Jun 13 2018
Jun 13 2018
[ASAN] Re-enable fgets_fputs test for darwin.
[ASAN] Re-enable fgets_fputs test for darwin.
Jun 12 2018
Jun 12 2018
Revert "Fix how LLVMOPTIONALCOMPONENTS is passed to llvm-build"
[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.
[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.
Jun 10 2018
Jun 10 2018
[debuginfo-tests] Always use the system python to invoke llgdb.py.
Jun 8 2018
Jun 8 2018
ab added a comment to D47967: [debuginfo-tests] Always use the system python to invoke llgdb.py..
Precisely: /usr/bin/env is recommended as a cross-platform way to find python. But:
- we're only using lldb on darwin, where we know python (or at least, the xcrun-style shortcut) is in /usr/bin/
- the python interpreter in LLDB comes from /S/L/F, for instance:
May 8 2018
May 8 2018
ab added inline comments to D46310: [AArch64] Disallow vector operand if FPR128 Q register is required..
May 4 2018
May 4 2018
ab added a reviewer for D46396: Optionally simplify basic blocks introduced by AtomicExpandPass: t.p.northover.
ab added a comment to D46042: Cap vector alignment at 16 for all Darwin platforms.
So, this makes sense to me, but on x86, should we also be worried about the fact that the calling convention is based on which features are available? (>128bit ext_vector_types are passed in AVX/AVX-512 registers, if available). Presumably swift is also affected, no?
Jan 4 2018
Jan 4 2018
ab accepted D41723: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injection", and is one of the two halves to Spectre...
Clang/LLVM pieces LGTM. Thanks for doing this, people.
Dec 9 2017
Dec 9 2017
Update another sanitizer test for C++14.
Update another sanitizer test for C++14.
Dec 7 2017
Dec 7 2017
Fix more line endings changed in r320089. NFC.