User Details
- User Since
- Oct 15 2014, 9:44 AM (327 w, 21 h)
Dec 3 2020
Thanks Tim! f77c948d56b
Nov 9 2020
Nov 5 2020
Oct 14 2020
No objection here (but let's leave a few more days, per process)*. Thanks Artur, and thanks @reames for helping get the group going!
Sep 17 2020
Reformat ValidArchs.
Sep 3 2020
Sep 1 2020
Hmm, is there a more general way to disable warnings? I'm not familiar with these parts, so I'll defer to you folks =]
Aug 26 2020
Aug 20 2020
Jul 30 2020
Jul 27 2020
This looks sensible, modulo a couple inline comments
Jun 30 2020
Apr 22 2020
Apr 21 2020
Apr 15 2020
Is it possible to make the (defaulting mcpu to "apple-latest") decision in a library, instead of in llvm-objdump and other individual tools?
Jan 9 2020
Seems reasonable. This is an interesting use of MCID flags, in that llvm itself doesn't need it, but I'm all for better disassembler support!
Dec 12 2019
Dec 4 2019
Dec 3 2019
(but either way, LGTM)
Dec 2 2019
Nov 13 2019
Apr 8 2019
Sorry for the delay; go ahead, the patch looks OK.
Mar 6 2019
Please check the embedded thing (the other comments are minor). Otherwise, LGTM; if you have found this flag to be necessary, this looks like a reasonable way to implement it
Hmm, if I may: what do you want to support? I'd expect Apple to upstream their own patches.
Feb 20 2019
Thanks for checking, much appreciated!
Feb 15 2019
On second thought, what happens to the tablegen emitter? That needs to be taught about these as well, right? That might not trigger on anything right now though.
Nice!
Feb 14 2019
Dec 19 2018
Looks good, thanks!
Dec 17 2018
LGTM, thanks!
Oct 3 2018
Jul 31 2018
Jul 26 2018
A few minor comments inline, and one question: it sounds like this is based on a GCC feature; what's the expected behavior for __builtin_returnaddress ? Shouldn't it xpaci the result?
Jul 19 2018
LGTM. Not the biggest fan of CodeGen/Generic tests, but it gets the job done, I suppose ;) I wouldn't be surprised if it failed on some target that can't even handle half parameters, so you might want to load it instead, put it in x86, or wait and see - your pick.