Page MenuHomePhabricator

efriedma (Eli Friedman)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 10 2016, 1:07 PM (302 w, 2 d)

Recent Activity

Today

efriedma added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Fri, May 27, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
efriedma accepted D126285: [NFC][Thumb1] Use FrameDestroy flag to identify epilog instructions.

LGTM

Fri, May 27, 11:50 AM · Restricted Project, Restricted Project
efriedma added inline comments to D126532: [SVE] Add a DAG combiner fold to visitADD for vscale with truncate.
Fri, May 27, 11:47 AM · Restricted Project, Restricted Project
efriedma added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

Concretely, my preferred solution looks something like:

Fri, May 27, 11:34 AM · Restricted Project, Restricted Project
efriedma added a comment to D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.

ldr+op+swp still isn't atomic. For each point in the code, please try the exercise of "what if my code is interrupted here"?

Fri, May 27, 11:17 AM · Restricted Project, Restricted Project, Restricted Project
efriedma added a comment to D126364: Fix interaction of pragma FENV_ACCESS with other pragmas.

I mean that ActOnPragmaFEnvAccess shouldn't call hasRoundingModeOverride()/setRoundingModeOverride(), and setRoundingMode shouldn't call getAllowFEnvAccess().

Fri, May 27, 11:12 AM · Restricted Project, Restricted Project
efriedma added a comment to D126190: [InstCombine] Add combine for fcmp sqrt(x),C --> fcmp x,C*C.

I think I'd prefer to start with the cases that don't require fast-math flags, then expand the transform as needed to include the cases that do require them.

Fri, May 27, 10:55 AM · Restricted Project, Restricted Project

Yesterday

efriedma added a comment to D126395: Allow build without __c11_atomic_fetch_nand.

The other alternative I considered was to not generate atomic_fetch_nand_* symbols at all if c11_atomic_fetch_nand isn't available

Thu, May 26, 2:16 PM · Restricted Project, Restricted Project
efriedma added a comment to D126494: [clang] avoid assert due to device treated long double as double.

This doesn't make sense to me. If clang and LLVM disagree about the layout of a type, you are going to run into trouble. If you haven't yet, it's a matter of time.

Thu, May 26, 12:48 PM · Restricted Project, Restricted Project
efriedma added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

For the table lookup, is there an algorithm for creating the special constant that is used in the multiply? Or would we just hardcode known constants for common sizes.

Thu, May 26, 11:19 AM · Restricted Project, Restricted Project
efriedma added a comment to D126364: Fix interaction of pragma FENV_ACCESS with other pragmas.

For FENV_ROUND, I think we should try to stick to the standard as closely as possible in Sema; since the standard models FENV_ROUND as a separate state, Sema should also model it as a separate state. If CodeGen decides it needs to modify the FP environment to actually implement the standard's rules, it can change the way it generates code to match. (The example in 7.6.2p5 is just pseudo-code; any internal state changes should be transparent to the user.)

Thu, May 26, 11:07 AM · Restricted Project, Restricted Project
efriedma requested review of D126486: [LoopIdiom] Fix bailout for aliasing in memcpy transform..
Thu, May 26, 9:46 AM · Restricted Project, Restricted Project
efriedma added a comment to D126395: Allow build without __c11_atomic_fetch_nand.

The current version doesn't have the right semantics: if the pointer is lock-free, you have to use a lock-free implementation (e.g. a cmpxchg loop).

Thu, May 26, 9:00 AM · Restricted Project, Restricted Project
efriedma added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

as for the second I'm not sure when it would be profitable to transform back and emit the table

Thu, May 26, 7:13 AM · Restricted Project, Restricted Project

Wed, May 25

efriedma added inline comments to D126421: ADT/ArrayRef: Add makeMutableArrayRef overloads.
Wed, May 25, 1:49 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125649: [ARM SEH 7] [ARM] Adjust the frame pointer when it's needed for SEH unwinding.
Wed, May 25, 12:54 PM · Restricted Project, Restricted Project
efriedma accepted D125647: [ARM SEH 5] [MC] [Win64EH] Check that the SEH unwind opcodes match the actual instructions.

LGTM

Wed, May 25, 12:45 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125646: [ARM SEH 4] [MC] [Win64EH] Optimize the ARM unwind info.
Wed, May 25, 12:43 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info.
Wed, May 25, 12:35 PM · Restricted Project, Restricted Project
efriedma added a comment to D125755: [AggressiveInstcombine] Conditionally fold saturated fptosi to llvm.fptosi.sat.

In summary, the cost of a saturating fptosi vs. plain fptosi+min+max varies so much across targets that that we need two canonical forms: one for targets where saturating fptosi with the given types is cheap, and one for targets where it isn't. I guess that conclusion is fine, but we should state it in a comment in the code, so it's clear why we're cost-modeling this.

Wed, May 25, 11:58 AM · Restricted Project, Restricted Project
efriedma added a comment to D126364: Fix interaction of pragma FENV_ACCESS with other pragmas.

Could you lay out the expected interaction between "STDC FENV_ACCESS", "clang fp exceptions", "float_control", and "fenv_access"? If there's some way to map everything to "#pragma clang fp", please lay that out; if that isn't possible, please explain why.

Wed, May 25, 11:22 AM · Restricted Project, Restricted Project
efriedma added a comment to D126270: [InstCombine] Preserve !nosanitize for newly created instructions..

It might make sense to take a step back, and look again at how ASan works here.

Wed, May 25, 9:05 AM · Restricted Project, Restricted Project

Tue, May 24

efriedma added inline comments to D124697: Distinguish between different forms of "address-taken" MachineBasicBlocks.
Tue, May 24, 12:33 PM · Restricted Project, Restricted Project
efriedma added a comment to D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.
  1. Sets memory barrier
  2. Calls atomic load from memory location
  3. Modifies data
  4. Calls atomic store to memory location
  5. Checks that operation is consistent, if not goes to step 2.

Now if we are on a platform which doesn't support SMP we can use ordinary memory operations instead
of atomic ones, can't we?

Tue, May 24, 9:11 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 23

efriedma added a comment to D112942: target ABI: improve call parameters extensions handling.

How about:
"If an integer argument to a function is not marked signext/zeroext/noext, the kind of extension used is target-specific. Some targets depend for correctness the kind of extension to be explicitly specified."

Mon, May 23, 2:12 PM · Restricted Project, Restricted Project
efriedma added a comment to D125648: [ARM SEH 6] [ARM] Add SEH opcodes in frame lowering.

For scheduling, the AArch64 backend overrides "isSchedulingBoundary()" for SEH instructions.

Mon, May 23, 9:32 AM · Restricted Project, Restricted Project

Sun, May 22

efriedma accepted D126175: [SelectionDAG] Add a freeze to ISD::ABS expansion..

Looking at the test deltas I wonder if it be valid to combine (sext_inreg (freeze (aextload X))) -> (freeze (sextload X)).

Sun, May 22, 2:06 PM · Restricted Project, Restricted Project

Fri, May 20

efriedma accepted D126024: [MSVC, ARM64] Add __readx18 intrinsics.

LGTM

Fri, May 20, 2:50 PM · Restricted Project, Restricted Project
efriedma accepted D126023: [MSVC, ARM64] Add __writex18 intrinsics.

LGTM

Fri, May 20, 2:48 PM · Restricted Project, Restricted Project
efriedma added a comment to D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info.

Did you consider instead of adding .seh_endepilogue_nop, just require writing .seh_nop; .seh_endepilogue? Then we can automatically merge a tailing nop with the "end" opcode.

Fri, May 20, 12:32 PM · Restricted Project, Restricted Project
efriedma added inline comments to D126023: [MSVC, ARM64] Add __writex18 intrinsics.
Fri, May 20, 11:51 AM · Restricted Project, Restricted Project
efriedma added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Fri, May 20, 11:43 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 19

efriedma added a comment to D126023: [MSVC, ARM64] Add __writex18 intrinsics.

uxtw #3 makes me think you're not generating the right code... the zero-extension hopefully doesn't matter, but the shift is significant. Maybe should be generating getelementptr i8?

Thu, May 19, 4:58 PM · Restricted Project, Restricted Project
efriedma added inline comments to D123649: Allow flexible array initialization in C++..
Thu, May 19, 2:27 PM · Restricted Project, Restricted Project
efriedma added a comment to D125755: [AggressiveInstcombine] Conditionally fold saturated fptosi to llvm.fptosi.sat.

So I'm not opposed, but I also don't have a good sense about potential downside of allowing target-specific IR transforms earlier in the optimization pipeline. Clearly, there's demand to do this because we get this kind of request fairly regularly.

Do we know what the downsides presented in the past were? I've heard about an increased need for testing on all targets before, but that has really always been true with datalayout controlled combines. I believe that was more about the core of instcombine though, where more fundamental canonicalizations are happening. This and D113291 I feel are more about higher level irreversible transforms.

Thu, May 19, 12:25 PM · Restricted Project, Restricted Project
efriedma added a comment to D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

This makes the names and conventions here seem very confusing. The function is called WidenVecRes_BinaryCanTrap, but we're dealing with operations that can't actually trap. And it now has two different ways of unrolling an operation, depending on whether we're generating a libcall: the existing codepath uses smaller vectors, and the new one completely unrolls.

Thu, May 19, 12:09 PM · Restricted Project, Restricted Project
efriedma added inline comments to D124728: Allow pointer types for atomicrmw xchg.
Thu, May 19, 10:56 AM · Restricted Project, Restricted Project
efriedma added inline comments to D124728: Allow pointer types for atomicrmw xchg.
Thu, May 19, 8:42 AM · Restricted Project, Restricted Project

Wed, May 18

efriedma added a comment to D125292: [Coroutines] Introduce "coro_readnone" operand bundles (2/3).

I don't think we reached a consensus this is the right approach; please ping the Discourse thread.

Wed, May 18, 4:36 PM · Restricted Project, Restricted Project
efriedma added a comment to D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3).

I don't really understand how this is supposed to interact with D125292; even if you strip the readnone attribute from the call instruction, we'll still treat a call to the intrinsic as readnone.

Wed, May 18, 4:35 PM · Restricted Project, Restricted Project, Restricted Project
efriedma added a comment to D112942: target ABI: improve call parameters extensions handling.

Not sure how much I like the rule about "externally visible functions"... I mean, I guess restricting the checking to external functions avoids triggering on a bunch of cases that would be difficult to handle, but it doesn't really seem self-consistent.

Wed, May 18, 4:16 PM · Restricted Project, Restricted Project
efriedma added a comment to D125639: [NVPTX] Enable AtomicExpandPass for NVPTX.

setMinCmpXchgSizeInBits(32) should fix the i8/i16 testcases, I think.

Wed, May 18, 3:43 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info.
Wed, May 18, 2:54 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Wed, May 18, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
efriedma added a comment to D125755: [AggressiveInstcombine] Conditionally fold saturated fptosi to llvm.fptosi.sat.

There's a continual struggle between pushing towards canonical IR, vs, pushing towards things we think are cheap on some specific target. Normally, the way we've resolved that is by distinguishing "early" vs. "late" optimizations: we try to push towards a canonical form early on to make the code easier to analyze, then we start doing optimizations like vectorization etc. using target-specific heuristics. AggressiveInstCombine doesn't really have anything to do with "early" vs. "late"; if we want something that runs just before vectorization, we should probably add a dedicated pass.

Wed, May 18, 1:15 PM · Restricted Project, Restricted Project
efriedma accepted D125906: [ARM] Add register-mask for tail returns.

Seems to match what other targets do, so I guess it's fine. Not sure what you're planning on doing with this, though...

Wed, May 18, 11:59 AM · Restricted Project, Restricted Project
efriedma accepted D125876: [MC] [Win64EH] Don't produce packed ARM64 unwind info with homed parameters.

LGTM

Wed, May 18, 9:33 AM · Restricted Project, Restricted Project
efriedma accepted D125644: [ARM SEH 2] [llvm-readobj] Improve printing of Windows ARM packed unwind info.

LGTM

Wed, May 18, 9:03 AM · Restricted Project, Restricted Project
efriedma added inline comments to D124728: Allow pointer types for atomicrmw xchg.
Wed, May 18, 8:56 AM · Restricted Project, Restricted Project
efriedma added a comment to D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.

On a target that doesn't support SMP, you don't need memory barriers, sure. (I think we'd want a CMake flag to explicitly assert that you're only going to run the code on chips without SMP.)

Wed, May 18, 8:48 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 17

efriedma accepted D125643: [ARM SEH 1] [llvm-readobj] Fix printing of Windows ARM unwind opcodes, add tests.

LGTM

Tue, May 17, 4:56 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125644: [ARM SEH 2] [llvm-readobj] Improve printing of Windows ARM packed unwind info.
Tue, May 17, 4:55 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info.
Tue, May 17, 4:52 PM · Restricted Project, Restricted Project
efriedma added inline comments to D124697: Distinguish between different forms of "address-taken" MachineBasicBlocks.
Tue, May 17, 4:39 PM · Restricted Project, Restricted Project
efriedma planned changes to D106331: [ScalarEvolution] Try harder to prove overflow in howManyLessThans..

(This currently doesn't apply cleanly.)

Tue, May 17, 12:42 PM · Restricted Project, Restricted Project
efriedma added a comment to D125792: [SCEV] Use nowrap flags to infer that start > start - stride in howManyLessThans.

It isn't enough that AddRec is nowrap; you have to prove that the initial value of the AddRec was produced by a nowrap add.

Tue, May 17, 12:34 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf.
Tue, May 17, 12:27 PM · Restricted Project, Restricted Project, Restricted Project
efriedma added inline comments to D123649: Allow flexible array initialization in C++..
Tue, May 17, 12:22 PM · Restricted Project, Restricted Project
efriedma added a comment to D125774: [InstCombine] fold float trunc into exact itofp for small constants.

Specifically detecting this exact case doesn't really seem very useful... we should be leveraging some sort of range analysis (known bits, CorrelatedValuePropagation, etc.)

Tue, May 17, 11:15 AM · Restricted Project, Restricted Project

Mon, May 16

efriedma added inline comments to D124697: Distinguish between different forms of "address-taken" MachineBasicBlocks.
Mon, May 16, 3:30 PM · Restricted Project, Restricted Project
efriedma committed rGdd20323f51b6: [compiler-rt builtins] Assert that atomic.c can be compiled correctly. (authored by efriedma).
[compiler-rt builtins] Assert that atomic.c can be compiled correctly.
Mon, May 16, 2:41 PM · Restricted Project, Restricted Project
efriedma closed D123080: [compiler-rt builtins] Assert that atomic.c can be compiled correctly..
Mon, May 16, 2:41 PM · Restricted Project, Restricted Project
efriedma added a comment to D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info.

.seh_endprologue_fragment looks fine.

Mon, May 16, 1:52 PM · Restricted Project, Restricted Project
efriedma added a comment to D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info.

It looks like this doesn't include any directive to set the "F" bit in xdata,

That's true. If we'd have unwind info splitting implemented, that bit would be set on the follow-up fragments, implicitly. Maybe there's a usecase for manually creating such unwind data though? I think that one can be added without much troubles later, if there's a concrete demand for it though...

Mon, May 16, 1:41 PM · Restricted Project, Restricted Project
efriedma accepted D125619: [MCWin64EH] Check for matches between epilogs and the prolog on ARM64.

LGTM

Mon, May 16, 12:56 PM · Restricted Project, Restricted Project
efriedma added a comment to D125644: [ARM SEH 2] [llvm-readobj] Improve printing of Windows ARM packed unwind info.

Can you add a testcase that has both a vpush and prologue folding?

Mon, May 16, 12:53 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125648: [ARM SEH 6] [ARM] Add SEH opcodes in frame lowering.
Mon, May 16, 12:40 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125647: [ARM SEH 5] [MC] [Win64EH] Check that the SEH unwind opcodes match the actual instructions.
Mon, May 16, 12:29 PM · Restricted Project, Restricted Project
efriedma added a comment to D125645: [ARM SEH 3] [ARM] [MC] Add support for writing ARM WinEH unwind info.

It looks like this doesn't include any directive to set the "F" bit in xdata, or the "Condition" field in epilogue scopes. Is the omission intentional? (I assume your LLVM patch won't emit sequences that would require either of those, but that might change, and people writing assembly might want them.)

Mon, May 16, 12:24 PM · Restricted Project, Restricted Project
efriedma added a comment to D125644: [ARM SEH 2] [llvm-readobj] Improve printing of Windows ARM packed unwind info.

I assume it's illegal to use prologue/epilogue folding with R==1? Should we try to diagnose this?

Mon, May 16, 12:04 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125643: [ARM SEH 1] [llvm-readobj] Fix printing of Windows ARM unwind opcodes, add tests.
Mon, May 16, 11:50 AM · Restricted Project, Restricted Project
efriedma added inline comments to D125643: [ARM SEH 1] [llvm-readobj] Fix printing of Windows ARM unwind opcodes, add tests.
Mon, May 16, 11:33 AM · Restricted Project, Restricted Project
efriedma added inline comments to D125619: [MCWin64EH] Check for matches between epilogs and the prolog on ARM64.
Mon, May 16, 11:11 AM · Restricted Project, Restricted Project
efriedma accepted D125536: [MC] [MCWin64EH] Try writing an ARM64 "packed epilog" even if the epilog doesn't share opcodes with the prolog.

LGTM

Mon, May 16, 11:08 AM · Restricted Project, Restricted Project
efriedma added a comment to D125649: [ARM SEH 7] [ARM] Adjust the frame pointer when it's needed for SEH unwinding.

Please add a testcase with VFP register spills. (Do we push them before FP? Does getMaxFPOffset need to account for that?)

Mon, May 16, 10:54 AM · Restricted Project, Restricted Project
efriedma added reviewers for D125627: [SCEV] Serialize function calls in function arguments.: mkazantsev, nikic, lebedev.ri.
Mon, May 16, 10:33 AM · Restricted Project, Restricted Project
efriedma added a comment to D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation..

https://github.com/llvm/llvm-project/issues/29472 was never fixed; whatever issues exist with -moutline-atomics also exist with -mno-outline-atomics. (I don't think anyone has run into any practical issues with this, so it hasn't been a priority for anyone.)

Mon, May 16, 8:43 AM · Restricted Project, Restricted Project, Restricted Project

Sun, May 15

efriedma added a comment to D125649: [ARM SEH 7] [ARM] Adjust the frame pointer when it's needed for SEH unwinding.

Can we just rearrange the order we save registers on the stack? I mean, generating an extra push instruction just to satisfy the unwinder is sort of silly, but it seems like the least bad alternative. (And we only need to do it in cases involving dynamic allocation.)

Sun, May 15, 5:00 PM · Restricted Project, Restricted Project
efriedma updated subscribers of D124571: Avoid strict aliasing violation on type punning inside llvm::PointerIntPair.

I think the placement new call needs to be in the operator=, not the constructor, to have any effect.

Sun, May 15, 11:21 AM · Restricted Project, Restricted Project

Fri, May 13

efriedma added inline comments to D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf.
Fri, May 13, 5:09 PM · Restricted Project, Restricted Project, Restricted Project
efriedma updated subscribers of D125557: [APInt] Remove all uses of zextOrSelf, sextOrSelf and truncOrSelf.
Fri, May 13, 5:05 PM · Restricted Project, Restricted Project, Restricted Project
efriedma added inline comments to D125536: [MC] [MCWin64EH] Try writing an ARM64 "packed epilog" even if the epilog doesn't share opcodes with the prolog.
Fri, May 13, 4:34 PM · Restricted Project, Restricted Project
efriedma added inline comments to D124728: Allow pointer types for atomicrmw xchg.
Fri, May 13, 3:59 PM · Restricted Project, Restricted Project
efriedma committed rG96c2a0c9fff2: [GlobalIsel] Fix fallback if stack protector isn't supported. (authored by efriedma).
[GlobalIsel] Fix fallback if stack protector isn't supported.
Fri, May 13, 2:18 PM · Restricted Project, Restricted Project
efriedma closed D125584: [GlobalIsel] Fix fallback if stack protector isn't supported..
Fri, May 13, 2:17 PM · Restricted Project, Restricted Project
efriedma requested review of D125584: [GlobalIsel] Fix fallback if stack protector isn't supported..
Fri, May 13, 1:43 PM · Restricted Project, Restricted Project
efriedma accepted D124038: [clang] Prevent folding of non-const compound expr.

LGTM

Fri, May 13, 12:10 PM · Restricted Project, Restricted Project
efriedma accepted D125521: [Diagnostic] Warn if the size argument of memset is character literal zero.

LGTM

Fri, May 13, 12:00 PM · Restricted Project, Restricted Project
efriedma added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Fri, May 13, 11:02 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 12

efriedma added inline comments to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.
Thu, May 12, 3:58 PM · Restricted Project, Restricted Project
efriedma updated the diff for D125415: [ARM64EC 4/?] Add LLVM support for varargs calling convention..

Fix comments/formatting. Fix generated code for varargs functions with more than 4 fixed arguments.

Thu, May 12, 3:15 PM · Restricted Project, Restricted Project
efriedma updated the diff for D125413: [ARM64EC 3/?] Mark reserved registers specific to ARM64EC ABI..

Fix v15/v16 confusion

Thu, May 12, 2:28 PM · Restricted Project, Restricted Project
efriedma updated the diff for D125411: [ARM64EC 1/?] Add parsing support to llvm-objdump/llvm-readobj..

Update more places that check for IMAGE_FILE_MACHINE_ARM64

Thu, May 12, 2:12 PM · Restricted Project, Restricted Project
efriedma committed rGc5f8b98e4f44: [yaml2obj][COFF] Add missing RISCV constants (authored by efriedma).
[yaml2obj][COFF] Add missing RISCV constants
Thu, May 12, 1:59 PM · Restricted Project, Restricted Project
efriedma added a comment to D124038: [clang] Prevent folding of non-const compound expr.

Updated messed up formatting?

Thu, May 12, 11:19 AM · Restricted Project, Restricted Project
efriedma added a comment to D125412: [ARM64EC 2/?] Add target triple, and allow targeting it..

If we'd want to use this ABI mode for mingw targets too [...], I guess that would have to be another separate target like ...-gnu_arm64ec - using up yet another entry in enum EnvironmentType for it.

Thu, May 12, 10:56 AM · Restricted Project, Restricted Project
efriedma added inline comments to D125413: [ARM64EC 3/?] Mark reserved registers specific to ARM64EC ABI..
Thu, May 12, 10:11 AM · Restricted Project, Restricted Project
efriedma accepted D125462: [llvm-readobj] [COFF] Fix the printout for ARM64 packed homed parameters.

There definitely can't be a gap between the homing area and the stack arguments. Are we sure there's a gap between the homing area and the saved registers, as opposed to putting the saved registers flush against the homing area?

Thu, May 12, 9:49 AM · Restricted Project, Restricted Project
efriedma added inline comments to D125411: [ARM64EC 1/?] Add parsing support to llvm-objdump/llvm-readobj..
Thu, May 12, 9:25 AM · Restricted Project, Restricted Project

Wed, May 11

efriedma added inline comments to D125433: [ARM64][SEH] PR54879: Packed Unwind Info when Homing Int Param Regs.
Wed, May 11, 6:27 PM · Restricted Project, Restricted Project