- User Since
- Aug 19 2013, 3:30 PM (334 w, 4 d)
Tue, Jan 14
Mon, Jan 13
I'm not convinced you really need the FixedLenDecoderEmitter.cpp changes. PPCInstrFormats.td has bits<64> Inst in the I2 class, but PPCDisassembler.cpp has InsnType as being uint32_t . InsnType needs to be able to hold your biggest instruction for the generated code to work correctly. I believe that if you changed:
uint32_t Inst = ...;
in PPCDisassembler::getInstruction(), to:
uint64_t Inst = ...;
then you will no longer need to change FixedLenDecoderEmitter.cpp as you'll be able to use shifts of up to 63.
Fix the remaining small issues
Fri, Jan 10
isInteger -> isIntegerLike and comment on pointers needing to use isIntegerLike
I see you've added me as a reviewer but I haven't worked on MIPS for a few years so I'm not really familiar with the current state of their linkers and binaries. AFAIK @atanasyan is still actively working on MIPS so hopefully he can take a look or bring in a colleague who can.
FWIW, this sounds like a good change and the code looks good to me but I think you should get another LGTM from someone more up to date on MIPS.
Thanks everyone. Landed in a5230ac10b0
Thu, Jan 9
Add a bit about asking someone to commit for you so that we can document
providing the information needed for the Author property
Small changes for review comments
Wed, Jan 8
Tue, Jan 7
Mon, Jan 6
Fri, Jan 3
LGTM too. IIRC, the ability to have multiple trees came after the original implementation so I think we just had a direct conversion.
Dec 18 2019
Update before commit (and because arcanist keeps pulling down the wrong commit message)
I've pushed 7ea2e5195a8 which should address these three issues
Dec 17 2019
I'm just going through the remaining issues from Matt and I don't think there's anything that should block committing this. AFAICT there's only one issue still open and it's the one about reusing the static printIRValueReference() in MachineOperand.cpp causing one function of MIRFormatter to be implemented in that file as well.
Dec 4 2019
Dec 3 2019
LGTM from me.
Nov 18 2019
Nov 15 2019
Nov 14 2019
Nov 13 2019
Thanks for doing this. It should make a lot of things easier to read.
Nov 7 2019
Nov 6 2019
Nov 5 2019
... this this ...