- User Since
- Aug 19 2013, 3:30 PM (192 w, 16 h)
I decided to have a look at code coverage differences before committing this. This patch made no difference to the code coverage. On closer inspection it turns out beginFunction() isn't being executed so no rules with rule predicates can match. I'll take a look at this, maybe something from the rule-predicates patch didn't make it into the final commit.
Sorry for being slow to get back to this one. I've been prioritising the other patches.
Sun, Apr 23
Sat, Apr 22
Fri, Apr 21
Thu, Apr 20
Rebase and fix nits
One thing to mention for this patch is that G_ICMP and G_FCMP are not included due to a difference in operand order between G_ICMP/G_FCMP in GlobalISel and setcc in SelectionDAG (predicate, lhs, rhs vs lhs, rhs, predicate). I can support those in a later patch by adding more information to GINodeEquiv or by changing G_ICMP/G_FCMP. I don't see a particularly strong argument either way on that point but I'm expecting to need to convert the predicate operand too so I'm leaning towards making GINodeEquiv more descriptive.
Wed, Apr 19
Remove placeholder operands since they're no longer needed.
Drop the Optional<> around ComplexRendererFn in favour of nullptr.
Remove the dependency on D31329.
Tablegen-erate the PredicateBitSet definitions.
Tue, Apr 18
SmallVector -> number of new instructions emitted.
Refresh patch. No other changes made (see next comment).
Thu, Apr 13
Forgot to reply to the inline comments
Wed, Apr 12
Thu, Apr 6
Update to account for nits
Add 2-default-operand test case
Check for too many operands
Wed, Apr 5
Tue, Apr 4
Rebase on to trunk
Refresh before commit
Fri, Mar 31
Thu, Mar 30
Rewrote to move the class declaration into the .cpp.
Wed, Mar 29
Tue, Mar 28
Fold away the TrueOrError variables.
That sounds good to me. Can we tack it onto the end of the main patch series though? Some of those patches change <Target>InstructionSelector and I'd like to avoid resolving the conflicts if I don't need to.
My ideal would be version of raw_ostream that allows clang-format style formatting to be switched on and off at will but that doesn't seem to be available and it would require llvm-tblgen to link to (probably old) clang libraries.
Mon, Mar 27
Mar 24 2017
Refresh and ping
Refresh and ping.
No longer selects code for dead intermediates due to r298224
Refresh and ping. This patch is the main bottleneck for a lot of the tablegen work.
Add the test case without accidentally removing the rest of the patch.