My theory as to what the stack trace was talking about (failure to find the tablegen record) seems to be correct as fixing that changed the failure to:

error: Could not find 'AArch64PreLegalizerCombinerHelper'

but that's really strange because it's definitely defined in AArch64Combiner.td which is included from AArch64.td as shown in the commit https://reviews.llvm.org/rL373527 and many other bots were able to find it. Are you able to view the filesystem for http://lab.llvm.org:8011/buildslaves/win-py3-buildbot and confirm that these files are the same as in the commit?

Wed, Oct 2, 4:29 PM · Restricted Project

dsanders committed rG2a964eabaa80: [gicombiner] Fix a nullptr dereference when -combiners is given a name that… (authored by dsanders).

[gicombiner] Fix a nullptr dereference when -combiners is given a name that…

Wed, Oct 2, 4:04 PM

dsanders committed rL373543: [gicombiner] Fix a nullptr dereference when -combiners is given a name that….

[gicombiner] Fix a nullptr dereference when -combiners is given a name that…

Wed, Oct 2, 4:01 PM

dsanders added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

In D68286#1692095, @stella.stamenova wrote:

This broke the windows build: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot. There was already a test broken from earlier today, so you might not have gotten an email.

Wed, Oct 2, 3:11 PM · Restricted Project

dsanders committed rG505d7f310585: [gicombiner] Add the boring boilerplate for the declarative combiner (authored by dsanders).

[gicombiner] Add the boring boilerplate for the declarative combiner

Wed, Oct 2, 2:14 PM

dsanders committed rL373527: [gicombiner] Add the boring boilerplate for the declarative combiner.

[gicombiner] Add the boring boilerplate for the declarative combiner

Wed, Oct 2, 2:13 PM

dsanders closed D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

Wed, Oct 2, 2:13 PM · Restricted Project

dsanders committed rG9ac0cda40a49: Fix inconsistent indentation in TableGen.cpp (authored by dsanders).

Fix inconsistent indentation in TableGen.cpp

Wed, Oct 2, 12:58 PM

dsanders committed rL373516: Fix inconsistent indentation in TableGen.cpp.

Fix inconsistent indentation in TableGen.cpp

Wed, Oct 2, 12:54 PM

dsanders added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

Thanks. I ran into a linking issue a few patches later which required me to move GICombinerEmitter.cpp out of the subdirectory so to avoid churn I'm going to postpone creating that subdirectory until the CodeEmitter patch

Wed, Oct 2, 11:55 AM · Restricted Project

Tue, Oct 1

dsanders created D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.

Tue, Oct 1, 11:50 AM · Restricted Project

dsanders added a reviewer for D68286: [gicombiner] Add the boring boilerplate for the declarative combiner: bogner.

Tue, Oct 1, 11:46 AM · Restricted Project

dsanders created D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

Tue, Oct 1, 11:42 AM · Restricted Project

dsanders accepted D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..

LGTM

Tue, Oct 1, 11:39 AM · Restricted Project

dsanders added a comment to D67968: [TableGen] Introduce a generic automaton (DFA) backend.

In D67968#1689588, @jmolloy wrote:

I've added descriptions to the Transition class which I hadn't realised was missing documentation. PTAL!

Tue, Oct 1, 11:27 AM · Restricted Project

Mon, Sep 30

dsanders committed rGcbe13a1461ef: [globalisel][knownbits] Allow targets to call GISelKnownBits… (authored by dsanders).

[globalisel][knownbits] Allow targets to call GISelKnownBits…

Mon, Sep 30, 1:56 PM

dsanders committed rL373264: [globalisel][knownbits] Allow targets to call GISelKnownBits….

[globalisel][knownbits] Allow targets to call GISelKnownBits…

Mon, Sep 30, 1:54 PM

dsanders closed D67380: [globalisel][knownbits] Allow targets to call GISelKnownBits::computeKnownBitsImpl().

Mon, Sep 30, 1:54 PM · Restricted Project

dsanders added a comment to D67968: [TableGen] Introduce a generic automaton (DFA) backend.

In D67968#1682549, @jmolloy wrote:

Perhaps you might have some thoughts on this patch? It's a step towards slightly easier bundle packing and similar problems for VLIWs.

Mon, Sep 30, 11:08 AM · Restricted Project

Sep 18 2019

dsanders accepted D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses.

LGTM with that change

Sep 18 2019, 1:04 PM · Restricted Project

dsanders added inline comments to D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses.

Sep 18 2019, 12:50 PM · Restricted Project

dsanders committed rG1723364a6848: Fix compile-time regression caused by rL371928 (authored by dsanders).

Fix compile-time regression caused by rL371928

Sep 18 2019, 11:17 AM

dsanders committed rL372243: Fix compile-time regression caused by rL371928.

Fix compile-time regression caused by rL371928

Sep 18 2019, 11:17 AM

dsanders closed D67686: Fix compile-time regression caused by rL371928.

Sep 18 2019, 11:16 AM · Restricted Project

dsanders added a comment to D67686: Fix compile-time regression caused by rL371928.

In D67686#1673591, @jmolloy wrote:

Thankyou Daniel! Looks great!

One question though, how did your out-of-tree backend trigger this case? It only gets enabled with BitWidth > 64 which was totally not supported before, so surely you would have had a broken encoder?

Cheers,

James

Sep 18 2019, 10:49 AM · Restricted Project

Sep 17 2019

dsanders created D67686: Fix compile-time regression caused by rL371928.

Sep 17 2019, 6:00 PM · Restricted Project

Sep 16 2019

dsanders added a comment to rL371928: [CodeEmitter] Support instruction widths > 64 bits.

Thanks for working on this. We've had some hacks for >64 bit instructions that we've wanted to get rid of for ages. I gave it a try and I had to fix a couple issues when it merged with our sources (see the inline comments).

Sep 16 2019, 6:11 PM