Page MenuHomePhabricator

dsanders (Daniel Sanders)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2013, 3:30 PM (313 w, 1 d)

Recent Activity

Today

dsanders updated the diff for D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
  • registerCheck<> order
Tue, Aug 20, 4:47 PM · Restricted Project
dsanders created D66505: Make add_new_check.py's insertion of registerCheck<> more closely match the sort order.
Tue, Aug 20, 4:23 PM · Restricted Project
dsanders committed rGa16bd4f9f25e: [RISCV GlobalISel] Adding initial GlobalISel infrastructure (authored by dsanders).
[RISCV GlobalISel] Adding initial GlobalISel infrastructure
Tue, Aug 20, 3:54 PM
dsanders committed rL369467: [RISCV GlobalISel] Adding initial GlobalISel infrastructure.
[RISCV GlobalISel] Adding initial GlobalISel infrastructure
Tue, Aug 20, 3:52 PM
dsanders closed D65219: [RISCV GlobalISel] Adding initial GlobalISel infrastructure.
Tue, Aug 20, 3:52 PM · Restricted Project
dsanders updated the summary of D65219: [RISCV GlobalISel] Adding initial GlobalISel infrastructure.
Tue, Aug 20, 2:40 PM · Restricted Project

Fri, Aug 16

dsanders accepted D66363: [X86] Use Register/MCRegister in more places in X86.

LGTM

Fri, Aug 16, 1:22 PM · Restricted Project

Thu, Aug 15

dsanders committed rL369041: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Thu, Aug 15, 12:26 PM
dsanders committed rG0c476111317c: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM (authored by dsanders).
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Thu, Aug 15, 12:25 PM
dsanders closed D65962: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.
Thu, Aug 15, 12:24 PM · Restricted Project
dsanders added a comment to D65962: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.

X86 changes look good to me. I'll see about addressing some of the reverts after this goes in.

Thu, Aug 15, 12:24 PM · Restricted Project

Tue, Aug 13

dsanders accepted D66183: [docs] Fix sphinx doc generation errors.

LGTM

Tue, Aug 13, 4:58 PM · Restricted Project
dsanders added inline comments to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Tue, Aug 13, 4:53 PM · Restricted Project

Mon, Aug 12

dsanders accepted D66119: [GlobalISel]: Add KnownBits for G_XOR.

LGTM

Mon, Aug 12, 6:21 PM · Restricted Project
dsanders accepted D65984: [GlobalISel] Make the InstructionSelector instance non-const, allowing state to be maintained..

I can't say I'm keen for it to have any state but collecting the result of expensive per-MF checks seems reasonable. LGTM with a naming nit pick

Mon, Aug 12, 6:07 PM · Restricted Project
dsanders accepted D65777: [GlobalISel][NFC] Factor out common target code from GlobalISelEmitter tests.

LGTM

Mon, Aug 12, 5:58 PM · Restricted Project
dsanders committed rGa58a27513ba9: Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC (authored by dsanders).
Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC
Mon, Aug 12, 5:55 PM
dsanders committed rL368643: Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC.
Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC
Mon, Aug 12, 5:54 PM
dsanders closed D65685: Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC.
Mon, Aug 12, 5:54 PM · Restricted Project
dsanders added inline comments to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Mon, Aug 12, 5:00 PM · Restricted Project
dsanders updated the diff for D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
  • Correct alphabetical list in LLVMTidyModule.cpp and prevent add_new_check.py getting it wrong in future
  • Lookup Register class via ::llvm::Register instead of llvm::Register
  • Removed unnecessary bindings
  • Typo in the docs
  • More tests
Mon, Aug 12, 5:00 PM · Restricted Project
dsanders updated the summary of D65962: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.
Mon, Aug 12, 3:46 PM · Restricted Project
dsanders updated the diff for D65962: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.

Rebase now that AArch64, RISC-V, and WebAssembly portions have landed

Mon, Aug 12, 3:45 PM · Restricted Project
dsanders added a comment to D65962: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.

Thanks Amara, Heejin, and Sam. I'll rebase this patch once the monorepo syncs

Mon, Aug 12, 3:43 PM · Restricted Project
dsanders committed rG3836874dbbf3: [risc-v] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM (authored by dsanders).
[risc-v] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Mon, Aug 12, 3:43 PM
dsanders committed rG05c145d694f2: [webassembly] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM (authored by dsanders).
[webassembly] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Mon, Aug 12, 3:42 PM
dsanders committed rG5ae66e56cf0c: [aarch64] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM (authored by dsanders).
[aarch64] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Mon, Aug 12, 3:42 PM
dsanders committed rL368629: [risc-v] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.
[risc-v] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Mon, Aug 12, 3:42 PM
dsanders committed rL368628: [aarch64] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.
[aarch64] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Mon, Aug 12, 3:42 PM
dsanders added a comment to D65962: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.

WebAssembly changes: r368627 (6aa77e740bf)
AArch64 changes: r368628 (b12454126d1)
RISC-V changes: r368629 (51880816fbc)

Mon, Aug 12, 3:42 PM · Restricted Project
dsanders committed rL368627: [webassembly] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.
[webassembly] Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Mon, Aug 12, 3:39 PM
dsanders updated the diff for D62338: [globalisel][legalizer] Combine G_TRUNC+G_MERGE_VALUES in artifact combiner.

Rebase
Note: The addition of s128 G_LOAD/G_STORE to AArch64's made test_inserts_[123] from test/CodeGen/AArch64/GlobalISel/legalize-inserts.mir unusable so they are only tested in LegalizerArtifactCombinerTest.cpp now

Mon, Aug 12, 2:29 PM · Restricted Project
dsanders accepted D66064: Use Register over unsigned in LateEHPrepare (NFC).

LGTM

Mon, Aug 12, 2:15 PM · Restricted Project

Fri, Aug 9

dsanders updated the diff for D62338: [globalisel][legalizer] Combine G_TRUNC+G_MERGE_VALUES in artifact combiner.

Rebased to master

Fri, Aug 9, 8:01 PM · Restricted Project
dsanders updated the diff for D61290: globalisel][aarch64] Make G_SEXT_INREG legal from all bit sizes to s32/s64.

Rebased to master

Fri, Aug 9, 7:40 PM · Restricted Project
dsanders added inline comments to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Fri, Aug 9, 4:14 PM · Restricted Project
dsanders updated the diff for D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
  • Give in on eliding the llvm:: for using namespace llvm inside a function They don't appear in the DeclContext and I've been unable to find a way to reasonably detect them Fortunately they don't occur in practice
Fri, Aug 9, 4:09 PM · Restricted Project
dsanders committed rG2a190c5dde65: Add missing REQUIRES to r368487 (authored by dsanders).
Add missing REQUIRES to r368487
Fri, Aug 9, 3:16 PM
dsanders committed rL368494: Add missing REQUIRES to r368487.
Add missing REQUIRES to r368487
Fri, Aug 9, 3:16 PM
dsanders committed rG0a317df59f23: Remove leftover MF->dump()'s from r368487 that break release builds (authored by dsanders).
Remove leftover MF->dump()'s from r368487 that break release builds
Fri, Aug 9, 2:38 PM
dsanders committed rL368489: Remove leftover MF->dump()'s from r368487 that break release builds.
Remove leftover MF->dump()'s from r368487 that break release builds
Fri, Aug 9, 2:37 PM
dsanders committed rGe9a57c2b23c2: [globalisel] Add G_SEXT_INREG (authored by dsanders).
[globalisel] Add G_SEXT_INREG
Fri, Aug 9, 2:12 PM
dsanders committed rL368487: [globalisel] Add G_SEXT_INREG.
[globalisel] Add G_SEXT_INREG
Fri, Aug 9, 2:11 PM
dsanders closed D61289: [globalisel] Add G_SEXT_INREG.
Fri, Aug 9, 2:10 PM · Restricted Project
dsanders committed rG1c5542aa9d65: [TableGen] Add "InitValue": Handle operands with set bit values in decoder… (authored by dsanders).
[TableGen] Add "InitValue": Handle operands with set bit values in decoder…
Fri, Aug 9, 10:32 AM
dsanders committed rL368458: [TableGen] Add "InitValue": Handle operands with set bit values in decoder….
[TableGen] Add "InitValue": Handle operands with set bit values in decoder…
Fri, Aug 9, 10:32 AM
dsanders closed D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods.
Fri, Aug 9, 10:32 AM · Restricted Project

Thu, Aug 8

dsanders added inline comments to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Thu, Aug 8, 7:03 PM · Restricted Project
dsanders updated the diff for D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.

Changed diagnostic message and merged the fixit into the original diagnostic
Made the variable names more distinct in the tests
Added a test to cover using namespace llvm in the global namespace
Slight correction to the iteration over the contexts to avoid skipping one
clang-format

Thu, Aug 8, 6:56 PM · Restricted Project
dsanders added inline comments to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Thu, Aug 8, 3:50 PM · Restricted Project
dsanders added a comment to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.

I think patch should be split at least on Clang-tidy check and results of its run on LLVM code. Probably per-target patches is even better solution.

Thu, Aug 8, 11:12 AM · Restricted Project
dsanders created D65962: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.
Thu, Aug 8, 11:10 AM · Restricted Project
dsanders added a child revision for D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM: D65962: Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM.
Thu, Aug 8, 11:10 AM · Restricted Project
dsanders updated the summary of D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Thu, Aug 8, 11:06 AM · Restricted Project
dsanders updated the diff for D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.

UsingDirectiveDecl -> auto
-> `
Split LLVM changes into another patch

Thu, Aug 8, 11:05 AM · Restricted Project
dsanders committed rG5b40eb057225: [globalisel][legalizer] Attempt to write down the minimal legalization rules (authored by dsanders).
[globalisel][legalizer] Attempt to write down the minimal legalization rules
Thu, Aug 8, 10:55 AM
dsanders committed rL368321: [globalisel][legalizer] Attempt to write down the minimal legalization rules.
[globalisel][legalizer] Attempt to write down the minimal legalization rules
Thu, Aug 8, 10:55 AM
dsanders closed D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.
Thu, Aug 8, 10:54 AM · Restricted Project
dsanders added inline comments to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.
Thu, Aug 8, 10:54 AM · Restricted Project

Wed, Aug 7

dsanders updated the diff for D61289: [globalisel] Add G_SEXT_INREG.

Fix the last few nits

Wed, Aug 7, 8:28 PM · Restricted Project
dsanders added a comment to D61289: [globalisel] Add G_SEXT_INREG.

The next update fixes the last couple nits that were left open after the LGTM. I'm planning to commit this tomorrow

Wed, Aug 7, 8:23 PM · Restricted Project
dsanders updated the diff for D65685: Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC.

Renamed Register::get() to Register::id(). The reason for not going with value()
is that it sounds too much like accessing the contents of the register.

Wed, Aug 7, 7:50 PM · Restricted Project
dsanders added inline comments to D63741: [TableGen] Add "InitValue": Handle operands with set bit values in decoder methods.
Wed, Aug 7, 7:36 PM · Restricted Project
dsanders added a comment to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.

Ping. I think we reached a conclusion on this but I lack an LGTM :-)

Wed, Aug 7, 7:06 PM · Restricted Project
dsanders created D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Wed, Aug 7, 6:41 PM · Restricted Project
dsanders accepted D65842: [GISel][NFC]: Make members of CombinerHelper accessible in derived classes.

LGTM

Wed, Aug 7, 6:22 PM · Restricted Project

Tue, Aug 6

dsanders added inline comments to D65698: [GISel]: Add GISelKnownBits analysis .
Tue, Aug 6, 11:37 AM · Restricted Project
dsanders committed rGd9934d4939af: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate… (authored by dsanders).
[globalisel] Allow SrcOp to convert an APInt and render it as an immediate…
Tue, Aug 6, 10:19 AM
dsanders committed rL368063: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate….
[globalisel] Allow SrcOp to convert an APInt and render it as an immediate…
Tue, Aug 6, 10:19 AM
dsanders closed D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).
Tue, Aug 6, 10:19 AM · Restricted Project

Mon, Aug 5

dsanders committed rGde4060816fa0: Fix another MSVC issue after 367965 (authored by dsanders).
Fix another MSVC issue after 367965
Mon, Aug 5, 6:20 PM
dsanders committed rL367967: Fix another MSVC issue after 367965.
Fix another MSVC issue after 367965
Mon, Aug 5, 6:15 PM
dsanders added inline comments to D65678: Register/MCRegister: Add conversion operators to avoid use of implicit convert to unsigned. NFC.
Mon, Aug 5, 5:55 PM · Restricted Project
dsanders committed rG269191eaf97b: Re-commit Register/MCRegister: Add conversion operators to avoid use of… (authored by dsanders).
Re-commit Register/MCRegister: Add conversion operators to avoid use of…
Mon, Aug 5, 5:54 PM
dsanders committed rL367965: Re-commit Register/MCRegister: Add conversion operators to avoid use of….
Re-commit Register/MCRegister: Add conversion operators to avoid use of…
Mon, Aug 5, 5:54 PM
dsanders added a comment to D65678: Register/MCRegister: Add conversion operators to avoid use of implicit convert to unsigned. NFC.

The windows bot for LLDB is still broken after the partial fix for the breakage:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7472

Mon, Aug 5, 2:44 PM · Restricted Project
dsanders committed rGeac86ec25f5c: Revert Register/MCRegister: Add conversion operators to avoid use of implicit… (authored by dsanders).
Revert Register/MCRegister: Add conversion operators to avoid use of implicit…
Mon, Aug 5, 2:35 PM
dsanders committed rL367932: Revert Register/MCRegister: Add conversion operators to avoid use of implicit….
Revert Register/MCRegister: Add conversion operators to avoid use of implicit…
Mon, Aug 5, 2:35 PM
dsanders committed rG5d14efe279b5: Fix MSVC error after r367916 (authored by dsanders).
Fix MSVC error after r367916
Mon, Aug 5, 1:04 PM
dsanders committed rL367920: Fix MSVC error after r367916.
Fix MSVC error after r367916
Mon, Aug 5, 1:04 PM
dsanders committed rGaa15ec3c2317: Register/MCRegister: Add conversion operators to avoid use of implicit convert… (authored by dsanders).
Register/MCRegister: Add conversion operators to avoid use of implicit convert…
Mon, Aug 5, 12:51 PM
dsanders committed rL367916: Register/MCRegister: Add conversion operators to avoid use of implicit convert….
Register/MCRegister: Add conversion operators to avoid use of implicit convert…
Mon, Aug 5, 12:50 PM
dsanders closed D65678: Register/MCRegister: Add conversion operators to avoid use of implicit convert to unsigned. NFC.
Mon, Aug 5, 12:50 PM · Restricted Project
dsanders added inline comments to D61289: [globalisel] Add G_SEXT_INREG.
Mon, Aug 5, 12:09 PM · Restricted Project
dsanders updated the diff for D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).
  • uint64_t -> int64_t
Mon, Aug 5, 12:02 PM · Restricted Project
dsanders added inline comments to D65678: Register/MCRegister: Add conversion operators to avoid use of implicit convert to unsigned. NFC.
Mon, Aug 5, 11:39 AM · Restricted Project
dsanders accepted D65698: [GISel]: Add GISelKnownBits analysis .

LGTM with some nits fixed

Mon, Aug 5, 11:10 AM · Restricted Project
dsanders added inline comments to D65698: [GISel]: Add GISelKnownBits analysis .
Mon, Aug 5, 10:36 AM · Restricted Project

Fri, Aug 2

dsanders updated the summary of D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).
Fri, Aug 2, 9:54 PM · Restricted Project
dsanders added inline comments to D61289: [globalisel] Add G_SEXT_INREG.
Fri, Aug 2, 9:54 PM · Restricted Project
dsanders updated the diff for D61289: [globalisel] Add G_SEXT_INREG.

Rebase and update to match changes in D61321

Fri, Aug 2, 9:54 PM · Restricted Project
dsanders updated the diff for D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true).

Rebase and update to use uint64_t (and ban registers in unsigned)

Fri, Aug 2, 9:49 PM · Restricted Project
dsanders added inline comments to D65685: Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC.
Fri, Aug 2, 8:33 PM · Restricted Project
dsanders committed rG00879c3e87c8: MCRegister/Register: DenseMapInfo should take `const T &` (authored by dsanders).
MCRegister/Register: DenseMapInfo should take `const T &`
Fri, Aug 2, 7:20 PM
dsanders committed rL367744: MCRegister/Register: DenseMapInfo should take `const T &`.
MCRegister/Register: DenseMapInfo should take `const T &`
Fri, Aug 2, 7:20 PM
dsanders created D65685: Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC.
Fri, Aug 2, 5:28 PM · Restricted Project
dsanders added a child revision for D65678: Register/MCRegister: Add conversion operators to avoid use of implicit convert to unsigned. NFC: D65685: Eliminate implicit Register->unsigned conversions in VirtRegMap. NFC.
Fri, Aug 2, 5:28 PM · Restricted Project
dsanders accepted D64845: [GlobalISel] Check LLT size matches memory size for non-truncating stores..

That change LGTM. Do you have a test case for your target?

Fri, Aug 2, 4:06 PM · Restricted Project
dsanders created D65678: Register/MCRegister: Add conversion operators to avoid use of implicit convert to unsigned. NFC.
Fri, Aug 2, 3:02 PM · Restricted Project
dsanders committed rGe7694f34ab6a: Use MCRegister in MCRegisterInfo's interfaces (authored by dsanders).
Use MCRegister in MCRegisterInfo's interfaces
Fri, Aug 2, 1:27 PM