Page MenuHomePhabricator

dsanders (Daniel Sanders)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2013, 3:30 PM (322 w, 5 h)

Recent Activity

Thu, Oct 17

dsanders created D69152: [gicombiner] Add GIMatchTree and use it for the code generation.
Thu, Oct 17, 6:39 PM · Restricted Project
dsanders added a child revision for D69151: [gicombiner] Import tryCombineIndexedLoadStore(): D69152: [gicombiner] Add GIMatchTree and use it for the code generation.
Thu, Oct 17, 6:39 PM · Restricted Project
dsanders created D69151: [gicombiner] Import tryCombineIndexedLoadStore().
Thu, Oct 17, 5:36 PM · Restricted Project
dsanders added a child revision for D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply: D69151: [gicombiner] Import tryCombineIndexedLoadStore().
Thu, Oct 17, 5:36 PM · Restricted Project
dsanders created D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply.
Thu, Oct 17, 3:34 PM · Restricted Project
dsanders added a child revision for D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots: D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply.
Thu, Oct 17, 3:34 PM · Restricted Project
dsanders added inline comments to D68438: [gicombiner] Add the run-time rule disable option.
Thu, Oct 17, 10:23 AM · Restricted Project
dsanders added inline comments to D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.
Thu, Oct 17, 10:04 AM · Restricted Project
dsanders added a child revision for D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input: D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.
Thu, Oct 17, 9:55 AM · Restricted Project
dsanders created D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.
Thu, Oct 17, 9:55 AM · Restricted Project

Wed, Oct 16

dsanders created D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.
Wed, Oct 16, 6:36 PM · Restricted Project
dsanders committed rG6150093e2281: Correct placement of #ifndef NDEBUG in r375067 (authored by dsanders).
Correct placement of #ifndef NDEBUG in r375067
Wed, Oct 16, 6:27 PM
dsanders committed rG149a02042531: Fix unused variable in r375066 (authored by dsanders).
Fix unused variable in r375066
Wed, Oct 16, 6:27 PM
dsanders committed rL375071: Correct placement of #ifndef NDEBUG in r375067.
Correct placement of #ifndef NDEBUG in r375067
Wed, Oct 16, 6:27 PM
dsanders committed rL375070: Fix unused variable in r375066.
Fix unused variable in r375066
Wed, Oct 16, 6:27 PM
dsanders committed rG329e748c8c3b: [gicombiner] Add the run-time rule disable option (authored by dsanders).
[gicombiner] Add the run-time rule disable option
Wed, Oct 16, 5:39 PM
dsanders committed rL375067: [gicombiner] Add the run-time rule disable option.
[gicombiner] Add the run-time rule disable option
Wed, Oct 16, 5:38 PM
dsanders closed D68438: [gicombiner] Add the run-time rule disable option.
Wed, Oct 16, 5:38 PM · Restricted Project
dsanders committed rGec5208fd6566: [gicombiner] Hoist pure C++ combine into the tablegen definition (authored by dsanders).
[gicombiner] Hoist pure C++ combine into the tablegen definition
Wed, Oct 16, 5:01 PM
dsanders committed rL375057: [gicombiner] Hoist pure C++ combine into the tablegen definition.
[gicombiner] Hoist pure C++ combine into the tablegen definition
Wed, Oct 16, 5:01 PM
dsanders closed D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Wed, Oct 16, 5:01 PM · Restricted Project
dsanders updated the diff for D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.

Rename the variable holding the fixup code block

Wed, Oct 16, 3:54 PM · Restricted Project
dsanders added inline comments to D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Wed, Oct 16, 3:36 PM · Restricted Project

Tue, Oct 15

dsanders updated the diff for D68438: [gicombiner] Add the run-time rule disable option.
  • setRuleDisabled wasn't quite right w.r.t disabling by id either
Tue, Oct 15, 4:50 PM · Restricted Project
dsanders added inline comments to D68438: [gicombiner] Add the run-time rule disable option.
Tue, Oct 15, 4:32 PM · Restricted Project
dsanders updated the diff for D68438: [gicombiner] Add the run-time rule disable option.
  • Fix up nits
Tue, Oct 15, 4:32 PM · Restricted Project

Tue, Oct 8

dsanders committed rG4b7cabf1e16f: [tblgen] Add getOperatorAsDef() to Record (authored by dsanders).
[tblgen] Add getOperatorAsDef() to Record
Tue, Oct 8, 11:44 AM
dsanders closed D68424: [tblgen] Add getOperatorAsDef() to Record.
Tue, Oct 8, 11:44 AM · Restricted Project
dsanders committed rL374101: [tblgen] Add getOperatorAsDef() to Record.
[tblgen] Add getOperatorAsDef() to Record
Tue, Oct 8, 11:44 AM

Mon, Oct 7

dsanders accepted D68538: GlobalISel: Partially implement lower for G_INSERT.

LGTM

Mon, Oct 7, 10:44 AM

Thu, Oct 3

dsanders created D68438: [gicombiner] Add the run-time rule disable option.
Thu, Oct 3, 6:02 PM · Restricted Project
dsanders added a child revision for D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition: D68438: [gicombiner] Add the run-time rule disable option.
Thu, Oct 3, 6:02 PM · Restricted Project
dsanders created D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Thu, Oct 3, 2:44 PM · Restricted Project
dsanders added a child revision for D68424: [tblgen] Add getOperatorAsDef() to Record: D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Thu, Oct 3, 2:44 PM · Restricted Project
dsanders created D68424: [tblgen] Add getOperatorAsDef() to Record.
Thu, Oct 3, 2:20 PM · Restricted Project
dsanders added inline comments to D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
Thu, Oct 3, 1:27 PM · Restricted Project
dsanders committed rG18350af15930: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion (authored by dsanders).
[gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion
Thu, Oct 3, 12:14 PM
dsanders committed rL373651: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
[gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion
Thu, Oct 3, 12:13 PM

Wed, Oct 2

dsanders committed rG45f682f47129: [gicombiner] Make rL373551 compatible with older cmakes (authored by dsanders).
[gicombiner] Make rL373551 compatible with older cmakes
Wed, Oct 2, 6:54 PM
dsanders committed rL373555: [gicombiner] Make rL373551 compatible with older cmakes.
[gicombiner] Make rL373551 compatible with older cmakes
Wed, Oct 2, 6:47 PM
dsanders added inline comments to D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
Wed, Oct 2, 6:35 PM · Restricted Project
dsanders committed rGeb27b5de538b: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion (authored by dsanders).
[gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion
Wed, Oct 2, 6:04 PM
dsanders committed rL373551: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
[gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion
Wed, Oct 2, 6:04 PM
dsanders closed D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
Wed, Oct 2, 6:04 PM · Restricted Project
dsanders committed rG603e98948e14: [gicombiner] Fix windows issue where single quotes in the command are passed… (authored by dsanders).
[gicombiner] Fix windows issue where single quotes in the command are passed…
Wed, Oct 2, 4:38 PM
dsanders committed rL373545: [gicombiner] Fix windows issue where single quotes in the command are passed….
[gicombiner] Fix windows issue where single quotes in the command are passed…
Wed, Oct 2, 4:38 PM
dsanders added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

I believe I've found the problem:

error: Could not find 'AArch64PreLegalizerCombinerHelper'

Wed, Oct 2, 4:38 PM · Restricted Project
dsanders added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

My theory as to what the stack trace was talking about (failure to find the tablegen record) seems to be correct as fixing that changed the failure to:

error: Could not find 'AArch64PreLegalizerCombinerHelper'

but that's really strange because it's definitely defined in AArch64Combiner.td which is included from AArch64.td as shown in the commit https://reviews.llvm.org/rL373527 and many other bots were able to find it. Are you able to view the filesystem for http://lab.llvm.org:8011/buildslaves/win-py3-buildbot and confirm that these files are the same as in the commit?

Wed, Oct 2, 4:29 PM · Restricted Project
dsanders committed rG2a964eabaa80: [gicombiner] Fix a nullptr dereference when -combiners is given a name that… (authored by dsanders).
[gicombiner] Fix a nullptr dereference when -combiners is given a name that…
Wed, Oct 2, 4:04 PM
dsanders committed rL373543: [gicombiner] Fix a nullptr dereference when -combiners is given a name that….
[gicombiner] Fix a nullptr dereference when -combiners is given a name that…
Wed, Oct 2, 4:01 PM
dsanders added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

This broke the windows build: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot. There was already a test broken from earlier today, so you might not have gotten an email.

Wed, Oct 2, 3:11 PM · Restricted Project
dsanders committed rG505d7f310585: [gicombiner] Add the boring boilerplate for the declarative combiner (authored by dsanders).
[gicombiner] Add the boring boilerplate for the declarative combiner
Wed, Oct 2, 2:14 PM
dsanders committed rL373527: [gicombiner] Add the boring boilerplate for the declarative combiner.
[gicombiner] Add the boring boilerplate for the declarative combiner
Wed, Oct 2, 2:13 PM
dsanders closed D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.
Wed, Oct 2, 2:13 PM · Restricted Project
dsanders committed rG9ac0cda40a49: Fix inconsistent indentation in TableGen.cpp (authored by dsanders).
Fix inconsistent indentation in TableGen.cpp
Wed, Oct 2, 12:58 PM
dsanders committed rL373516: Fix inconsistent indentation in TableGen.cpp.
Fix inconsistent indentation in TableGen.cpp
Wed, Oct 2, 12:54 PM
dsanders added a comment to D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.

Thanks. I ran into a linking issue a few patches later which required me to move GICombinerEmitter.cpp out of the subdirectory so to avoid churn I'm going to postpone creating that subdirectory until the CodeEmitter patch

Wed, Oct 2, 11:55 AM · Restricted Project

Tue, Oct 1

dsanders created D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
Tue, Oct 1, 11:50 AM · Restricted Project
dsanders added a reviewer for D68286: [gicombiner] Add the boring boilerplate for the declarative combiner: bogner.
Tue, Oct 1, 11:46 AM · Restricted Project
dsanders created D68286: [gicombiner] Add the boring boilerplate for the declarative combiner.
Tue, Oct 1, 11:42 AM · Restricted Project
dsanders accepted D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..

LGTM

Tue, Oct 1, 11:39 AM · Restricted Project
dsanders added a comment to D67968: [TableGen] Introduce a generic automaton (DFA) backend.

I've added descriptions to the Transition class which I hadn't realised was missing documentation. PTAL!

Tue, Oct 1, 11:27 AM · Restricted Project

Mon, Sep 30

dsanders committed rGcbe13a1461ef: [globalisel][knownbits] Allow targets to call GISelKnownBits… (authored by dsanders).
[globalisel][knownbits] Allow targets to call GISelKnownBits…
Mon, Sep 30, 1:56 PM
dsanders committed rL373264: [globalisel][knownbits] Allow targets to call GISelKnownBits….
[globalisel][knownbits] Allow targets to call GISelKnownBits…
Mon, Sep 30, 1:54 PM
dsanders closed D67380: [globalisel][knownbits] Allow targets to call GISelKnownBits::computeKnownBitsImpl().
Mon, Sep 30, 1:54 PM · Restricted Project
dsanders added a comment to D67968: [TableGen] Introduce a generic automaton (DFA) backend.

Perhaps you might have some thoughts on this patch? It's a step towards slightly easier bundle packing and similar problems for VLIWs.

Mon, Sep 30, 11:08 AM · Restricted Project

Sep 18 2019

dsanders accepted D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses.

LGTM with that change

Sep 18 2019, 1:04 PM · Restricted Project
dsanders added inline comments to D66773: [TableGen] Emit OperandType enums for RegisterOperands/RegisterClasses.
Sep 18 2019, 12:50 PM · Restricted Project
dsanders committed rG1723364a6848: Fix compile-time regression caused by rL371928 (authored by dsanders).
Fix compile-time regression caused by rL371928
Sep 18 2019, 11:17 AM
dsanders committed rL372243: Fix compile-time regression caused by rL371928.
Fix compile-time regression caused by rL371928
Sep 18 2019, 11:17 AM
dsanders closed D67686: Fix compile-time regression caused by rL371928.
Sep 18 2019, 11:16 AM · Restricted Project
dsanders added a comment to D67686: Fix compile-time regression caused by rL371928.

Thankyou Daniel! Looks great!

One question though, how did your out-of-tree backend trigger this case? It only gets enabled with BitWidth > 64 which was totally not supported before, so surely you would have had a broken encoder?

Cheers,

James

Sep 18 2019, 10:49 AM · Restricted Project

Sep 17 2019

dsanders created D67686: Fix compile-time regression caused by rL371928.
Sep 17 2019, 6:00 PM · Restricted Project

Sep 16 2019

dsanders added a comment to rL371928: [CodeEmitter] Support instruction widths > 64 bits.

Thanks for working on this. We've had some hacks for >64 bit instructions that we've wanted to get rid of for ages. I gave it a try and I had to fix a couple issues when it merged with our sources (see the inline comments).

Sep 16 2019, 6:11 PM

Sep 9 2019

dsanders created D67380: [globalisel][knownbits] Allow targets to call GISelKnownBits::computeKnownBitsImpl().
Sep 9 2019, 4:31 PM · Restricted Project

Sep 6 2019

dsanders accepted D64953: GlobalISel: Support physical register inputs in patterns.

LGTM

Sep 6 2019, 10:45 AM

Sep 5 2019

dsanders added inline comments to D64953: GlobalISel: Support physical register inputs in patterns.
Sep 5 2019, 5:21 PM
dsanders accepted D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE.

LGTM with the changes Jessica and Quentin mentioned (or the XRay style Error verify() version).

Sep 5 2019, 3:28 PM · Restricted Project
dsanders committed rGe55c4f33ec53: [globalisel][knownbits] Correct a typo that prevented a test working as intended (authored by dsanders).
[globalisel][knownbits] Correct a typo that prevented a test working as intended
Sep 5 2019, 1:29 PM
dsanders committed rGf8032379267b: [globalisel][knownbits] Account for missing type constraints (authored by dsanders).
[globalisel][knownbits] Account for missing type constraints
Sep 5 2019, 1:29 PM
dsanders committed rL371115: [globalisel][knownbits] Correct a typo that prevented a test working as intended.
[globalisel][knownbits] Correct a typo that prevented a test working as intended
Sep 5 2019, 1:29 PM
dsanders committed rL371116: [globalisel][knownbits] Account for missing type constraints.
[globalisel][knownbits] Account for missing type constraints
Sep 5 2019, 1:29 PM

Sep 4 2019

dsanders committed rGb276a9a51e42: [globalisel] Support trivial COPY in GISelKnownBits (authored by dsanders).
[globalisel] Support trivial COPY in GISelKnownBits
Sep 4 2019, 12:02 PM
dsanders committed rL370955: [globalisel] Support trivial COPY in GISelKnownBits.
[globalisel] Support trivial COPY in GISelKnownBits
Sep 4 2019, 11:59 AM
dsanders closed D67131: [globalisel] Support trivial COPY in GISelKnownBits.
Sep 4 2019, 11:59 AM · Restricted Project
dsanders committed rL370949: Request commit access for dsanders.
Request commit access for dsanders
Sep 4 2019, 11:28 AM

Sep 3 2019

dsanders updated the summary of D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE.
Sep 3 2019, 3:52 PM · Restricted Project
dsanders created D67131: [globalisel] Support trivial COPY in GISelKnownBits.
Sep 3 2019, 3:32 PM · Restricted Project

Aug 30 2019

dsanders added inline comments to D64953: GlobalISel: Support physical register inputs in patterns.
Aug 30 2019, 3:19 PM
dsanders committed rG0cdb04c3cfe0: Make add_new_check.py's insertion of registerCheck<> match the sort order (authored by dsanders).
Make add_new_check.py's insertion of registerCheck<> match the sort order
Aug 30 2019, 1:50 PM
dsanders committed rL370527: Make add_new_check.py's insertion of registerCheck<> match the sort order.
Make add_new_check.py's insertion of registerCheck<> match the sort order
Aug 30 2019, 1:46 PM
dsanders closed D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order.
Aug 30 2019, 1:46 PM · Restricted Project, Restricted Project
dsanders committed rG5b4f640499c1: [clang-tidy] Add llvm-prefer-register-over-unsigned to clang-tidy (authored by dsanders).
[clang-tidy] Add llvm-prefer-register-over-unsigned to clang-tidy
Aug 30 2019, 1:05 PM
dsanders added a comment to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.

r370512

Aug 30 2019, 1:01 PM · Restricted Project, Restricted Project
dsanders committed rL370512: [clang-tidy] Add llvm-prefer-register-over-unsigned to clang-tidy.
[clang-tidy] Add llvm-prefer-register-over-unsigned to clang-tidy
Aug 30 2019, 1:01 PM
dsanders closed D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Aug 30 2019, 1:01 PM · Restricted Project, Restricted Project
dsanders added a comment to D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order.

Missed one of the commands from my history that I used to verify it:

./add_new_check.py llvm i
Aug 30 2019, 11:23 AM · Restricted Project, Restricted Project
dsanders updated the diff for D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order.
  • Full stop at end of comment
  • last_line -> prev_line
Aug 30 2019, 11:21 AM · Restricted Project, Restricted Project
dsanders added a comment to D66505: Make add_new_check.py's insertion of registerCheck<> match the sort order.

Mostly LG, if you've verified that this works. A couple of comments below.

Aug 30 2019, 11:19 AM · Restricted Project, Restricted Project

Aug 29 2019

dsanders added inline comments to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.
Aug 29 2019, 8:10 PM · Restricted Project, Restricted Project