Page MenuHomePhabricator

dsanders (Daniel Sanders)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2013, 3:30 PM (334 w, 4 d)

Recent Activity

Tue, Jan 14

dsanders accepted D72726: TableGen/GlobalISel: Don't take reference to temporary values.

LGTM

Tue, Jan 14, 1:38 PM · Restricted Project
dsanders accepted D72725: TableGen/GlobalISel: Don't reconstruct CodeGenRegBank.

LGTM

Tue, Jan 14, 1:38 PM · Restricted Project

Mon, Jan 13

dsanders added a comment to D72574: [PowerPC][Future] Add pld and pstd to future CPU.

I'm not convinced you really need the FixedLenDecoderEmitter.cpp changes. PPCInstrFormats.td has bits<64> Inst in the I2 class, but PPCDisassembler.cpp has InsnType as being uint32_t . InsnType needs to be able to hold your biggest instruction for the generated code to work correctly. I believe that if you changed:

uint32_t Inst = ...;

in PPCDisassembler::getInstruction(), to:

uint64_t Inst = ...;

then you will no longer need to change FixedLenDecoderEmitter.cpp as you'll be able to use shifts of up to 63.

Mon, Jan 13, 4:23 PM · Restricted Project, Restricted Project
dsanders updated the diff for D72636: Cancelling out G_MERGE_VALUES/G_UNMERGE pairs sometimes needs a copy.

Fix the remaining small issues

Mon, Jan 13, 3:35 PM · Restricted Project
dsanders updated the diff for D72636: Cancelling out G_MERGE_VALUES/G_UNMERGE pairs sometimes needs a copy.

+Testcase

Mon, Jan 13, 3:26 PM · Restricted Project
dsanders committed rGa0f4600f4f0e: Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT (authored by dsanders).
Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT
Mon, Jan 13, 12:28 PM
dsanders closed D72309: Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT.
Mon, Jan 13, 12:28 PM · Restricted Project
dsanders created D72636: Cancelling out G_MERGE_VALUES/G_UNMERGE pairs sometimes needs a copy.
Mon, Jan 13, 11:59 AM · Restricted Project

Fri, Jan 10

dsanders updated the diff for D72309: Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT.

isInteger -> isIntegerLike and comment on pointers needing to use isIntegerLike

Fri, Jan 10, 11:37 AM · Restricted Project
dsanders added a comment to D72228: [MIPS][ELF] Use PC-relative relocations in .eh_frame when possible.

I see you've added me as a reviewer but I haven't worked on MIPS for a few years so I'm not really familiar with the current state of their linkers and binaries. AFAIK @atanasyan is still actively working on MIPS so hopefully he can take a look or bring in a colleague who can.
FWIW, this sounds like a good change and the code looks good to me but I think you should get another LGTM from someone more up to date on MIPS.

Fri, Jan 10, 10:50 AM · Restricted Project
dsanders committed rGa5230ac10b0d: Update the attribution policy to use the 'Author' property of a git commit (authored by dsanders).
Update the attribution policy to use the 'Author' property of a git commit
Fri, Jan 10, 10:32 AM
dsanders closed D72468: Update the attribution policy to use the 'Author' property of a git commit.
Fri, Jan 10, 10:32 AM · Restricted Project
dsanders added a comment to D72468: Update the attribution policy to use the 'Author' property of a git commit.

Thanks everyone. Landed in a5230ac10b0

Fri, Jan 10, 10:31 AM · Restricted Project
dsanders updated subscribers of D69836: [MIR] Target specific MIR formating and parsing.
Fri, Jan 10, 10:31 AM · Restricted Project

Thu, Jan 9

dsanders updated the diff for D72468: Update the attribution policy to use the 'Author' property of a git commit.

Add a bit about asking someone to commit for you so that we can document
providing the information needed for the Author property

Thu, Jan 9, 1:32 PM · Restricted Project
dsanders added inline comments to D72468: Update the attribution policy to use the 'Author' property of a git commit.
Thu, Jan 9, 1:32 PM · Restricted Project
dsanders added inline comments to D72468: Update the attribution policy to use the 'Author' property of a git commit.
Thu, Jan 9, 1:13 PM · Restricted Project
dsanders updated the diff for D72468: Update the attribution policy to use the 'Author' property of a git commit.

Small changes for review comments

Thu, Jan 9, 1:13 PM · Restricted Project
dsanders accepted D72464: GlobalISel: Don't assert on MoreElements creating vectors.

LGTM

Thu, Jan 9, 10:52 AM · Restricted Project
dsanders created D72468: Update the attribution policy to use the 'Author' property of a git commit.
Thu, Jan 9, 10:42 AM · Restricted Project

Wed, Jan 8

dsanders committed rGde3d0ee023cb: Revert "Revert "[MIR] Target specific MIR formating and parsing"" (authored by dsanders).
Revert "Revert "[MIR] Target specific MIR formating and parsing""
Wed, Jan 8, 8:06 PM
dsanders added a reverting change for rG71d64f72f934: Revert "[MIR] Target specific MIR formating and parsing": rGde3d0ee023cb: Revert "Revert "[MIR] Target specific MIR formating and parsing"".
Wed, Jan 8, 8:06 PM
dsanders added a comment to D69836: [MIR] Target specific MIR formating and parsing.

Temporarily reverted in 71d64f72f934631aa2f for now.

Wed, Jan 8, 8:05 PM · Restricted Project
dsanders committed rG3ef05d85be8c: [MIR] Target specific MIR formating and parsing (authored by pguo).
[MIR] Target specific MIR formating and parsing
Wed, Jan 8, 6:52 PM
dsanders committed rG5ab6fa7b7011: Revert "[MIR] Target specific MIR formating and parsing" (authored by dsanders).
Revert "[MIR] Target specific MIR formating and parsing"
Wed, Jan 8, 6:52 PM
dsanders added a reverting change for rGbe841f89d001: [MIR] Target specific MIR formating and parsing: rG5ab6fa7b7011: Revert "[MIR] Target specific MIR formating and parsing".
Wed, Jan 8, 6:52 PM
dsanders committed rGbe841f89d001: [MIR] Target specific MIR formating and parsing (authored by pguo).
[MIR] Target specific MIR formating and parsing
Wed, Jan 8, 6:43 PM
dsanders closed D69836: [MIR] Target specific MIR formating and parsing.
Wed, Jan 8, 6:43 PM · Restricted Project

Tue, Jan 7

dsanders committed rG13922f3e9d0c: Fix warnings as errors that occur on sanitizer-x86_64-linux (authored by dsanders).
Fix warnings as errors that occur on sanitizer-x86_64-linux
Tue, Jan 7, 4:03 PM
dsanders committed rG39c05703a6ca: [gicombiner] Correct 64f1bb5cd2c to account for MSVC's %p format (authored by dsanders).
[gicombiner] Correct 64f1bb5cd2c to account for MSVC's %p format
Tue, Jan 7, 12:59 PM
dsanders added a comment to D69152: [gicombiner] Add GIMatchTree and use it for the code generation.

This broke tests on Windows: http://45.33.8.238/win/5239/step_11.txt

Probably the "%p doesn't include 0x on Windows" thing again.

Tue, Jan 7, 11:41 AM · Restricted Project
dsanders committed rG1d94fb211187: [gicombiner] Add GIMatchTree and use it for the code generation (authored by dsanders).
[gicombiner] Add GIMatchTree and use it for the code generation
Tue, Jan 7, 11:13 AM
dsanders closed D69152: [gicombiner] Add GIMatchTree and use it for the code generation.
Tue, Jan 7, 11:13 AM · Restricted Project
dsanders added a comment to D72309: Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT.

Could we invert the boolean flag to be isFloat? I fear that calling it isInteger, will lead the the same problems that I tried to fix in that commit (calling .isInteger() returns false for pointers).

Tue, Jan 7, 10:14 AM · Restricted Project

Mon, Jan 6

dsanders updated the diff for D72309: Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT.

Corrected patch

Mon, Jan 6, 6:42 PM · Restricted Project
dsanders created D72309: Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT.
Mon, Jan 6, 6:24 PM · Restricted Project
dsanders accepted D72273: Make check-llvm run 50% faster on macOS, 18% faster on Windows..

LGTM. Thanks!

Mon, Jan 6, 9:56 AM · Restricted Project

Fri, Jan 3

dsanders reopened D69152: [gicombiner] Add GIMatchTree and use it for the code generation.
Fri, Jan 3, 7:26 PM · Restricted Project
dsanders committed rG5d304d68dd5f: Revert "[gicombiner] Add GIMatchTree and use it for the code generation" (authored by dsanders).
Revert "[gicombiner] Add GIMatchTree and use it for the code generation"
Fri, Jan 3, 6:22 PM
dsanders added a reverting change for rG64f1bb5cd2c6: [gicombiner] Add GIMatchTree and use it for the code generation: rG5d304d68dd5f: Revert "[gicombiner] Add GIMatchTree and use it for the code generation".
Fri, Jan 3, 6:21 PM
dsanders added a reverting change for rG77d4b5f5feff: [gicombiner] Correct 64f1bb5cd2c to account for MSVC's %p format: rG5d304d68dd5f: Revert "[gicombiner] Add GIMatchTree and use it for the code generation".
Fri, Jan 3, 6:21 PM
dsanders committed rG77d4b5f5feff: [gicombiner] Correct 64f1bb5cd2c to account for MSVC's %p format (authored by dsanders).
[gicombiner] Correct 64f1bb5cd2c to account for MSVC's %p format
Fri, Jan 3, 4:58 PM
dsanders created D72191: [gicombiner] Add support for arbitrary C++ predicates.
Fri, Jan 3, 4:57 PM · Restricted Project
dsanders committed rG64f1bb5cd2c6: [gicombiner] Add GIMatchTree and use it for the code generation (authored by dsanders).
[gicombiner] Add GIMatchTree and use it for the code generation
Fri, Jan 3, 4:28 PM
dsanders closed D69152: [gicombiner] Add GIMatchTree and use it for the code generation.
Fri, Jan 3, 4:27 PM · Restricted Project
dsanders added inline comments to D69152: [gicombiner] Add GIMatchTree and use it for the code generation.
Fri, Jan 3, 4:27 PM · Restricted Project
dsanders committed rG1dbc48645776: [globalisel] Fix another mismatch between %d and the RuleID type (authored by dsanders).
[globalisel] Fix another mismatch between %d and the RuleID type
Fri, Jan 3, 1:40 PM
dsanders added a comment to D72009: TableGen: Fix assert on PatFrags with predicate code.

LGTM too. IIRC, the ability to have multiple trees came after the original implementation so I think we just had a direct conversion.

Fri, Jan 3, 1:12 PM · Restricted Project
dsanders added inline comments to D65440: GlobalISel: Add widenScalar for G_UNMERGE_VALUES sources.
Fri, Jan 3, 12:31 PM
dsanders accepted D70300: GlobalISel: Add type argument to getRegBankFromRegClass.

LGTM

Fri, Jan 3, 12:01 PM · Restricted Project

Dec 18 2019

dsanders updated the diff for D69152: [gicombiner] Add GIMatchTree and use it for the code generation.

Rebase

Dec 18 2019, 7:57 AM · Restricted Project
dsanders committed rG3a779b7dfd8e: [globalisel] Small correction to the fixup in 0a0813962d6. The two ID's are not… (authored by dsanders).
[globalisel] Small correction to the fixup in 0a0813962d6. The two ID's are not…
Dec 18 2019, 7:02 AM
dsanders updated the diff for D69152: [gicombiner] Add GIMatchTree and use it for the code generation.

Rebase

Dec 18 2019, 6:47 AM · Restricted Project
dsanders committed rGc3cb089a87b7: [gicombiner] Import tryCombineIndexedLoadStore() (authored by dsanders).
[gicombiner] Import tryCombineIndexedLoadStore()
Dec 18 2019, 6:43 AM
dsanders closed D69151: [gicombiner] Import tryCombineIndexedLoadStore().
Dec 18 2019, 6:43 AM · Restricted Project
dsanders committed rG0a0813962d65: [globalisel] Attempt to fix ARM bots that emit the correct number in the wrong… (authored by dsanders).
[globalisel] Attempt to fix ARM bots that emit the correct number in the wrong…
Dec 18 2019, 6:18 AM
dsanders updated the diff for D69151: [gicombiner] Import tryCombineIndexedLoadStore().

rebase

Dec 18 2019, 4:40 AM · Restricted Project
dsanders committed rG55c57408b0e7: [gicombiner] Add support for arbitrary match data being passed from match to… (authored by dsanders).
[gicombiner] Add support for arbitrary match data being passed from match to…
Dec 18 2019, 4:31 AM
dsanders closed D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply.
Dec 18 2019, 4:31 AM · Restricted Project
dsanders closed D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.

Landed in rG520e3d66e7257c77f1226185504bbe1cb90afcfa (and re-committed in rG7ea2e5195a82bd9370d0b4362512b67c8b2cde80

Dec 18 2019, 4:30 AM · Restricted Project
dsanders updated the diff for D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply.

Update before commit (and because arcanist keeps pulling down the wrong commit message)

Dec 18 2019, 4:24 AM · Restricted Project
dsanders committed rG7ea2e5195a82: Revert "Temporarily Revert "[gicombiner] Add the MatchDag structure and parse… (authored by dsanders).
Revert "Temporarily Revert "[gicombiner] Add the MatchDag structure and parse…
Dec 18 2019, 3:43 AM
dsanders added a reverting change for rGe62e760f2956: Temporarily Revert "[gicombiner] Add the MatchDag structure and parse…: rG7ea2e5195a82: Revert "Temporarily Revert "[gicombiner] Add the MatchDag structure and parse….
Dec 18 2019, 3:42 AM
dsanders added a comment to D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.

I've pushed 7ea2e5195a8 which should address these three issues

Dec 18 2019, 3:42 AM · Restricted Project
dsanders added a comment to D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.

The new test case causes build bot failures (hidden by another failure that was already present):
http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/28934/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Aparse-match-pattern.td

/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/llvm/test/TableGen/GICombinerEmitter/parse-match-pattern.td:212:16: error: CHECK-NEXT: expected string not found in input
// CHECK-NEXT: 0:$<def>, 1:mi0, 2:mi1
               ^
<stdin>:129:16: note: scanning from here
 0:$<def>, 1:mi0, 2:mi1
               ^
<stdin>:130:2: note: possible intended match here
 0:$<def>, 1:mi
 ^
Dec 18 2019, 2:40 AM · Restricted Project

Dec 17 2019

dsanders added inline comments to D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply.
Dec 17 2019, 11:15 AM · Restricted Project
dsanders committed rG520e3d66e725: [gicombiner] Process the MatchDag such that every node is reachable from the… (authored by dsanders).
[gicombiner] Process the MatchDag such that every node is reachable from the…
Dec 17 2019, 9:04 AM
dsanders added inline comments to D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.
Dec 17 2019, 8:38 AM · Restricted Project
dsanders committed rG390c8baa5440: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the… (authored by dsanders).
[gicombiner] Add the MatchDag structure and parse instruction DAG's from the…
Dec 17 2019, 7:28 AM
dsanders closed D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.
Dec 17 2019, 7:28 AM · Restricted Project
dsanders added inline comments to D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.
Dec 17 2019, 7:02 AM · Restricted Project
dsanders added a comment to D69836: [MIR] Target specific MIR formating and parsing.

I'm just going through the remaining issues from Matt and I don't think there's anything that should block committing this. AFAICT there's only one issue still open and it's the one about reusing the static printIRValueReference() in MachineOperand.cpp causing one function of MIRFormatter to be implemented in that file as well.

Dec 17 2019, 4:35 AM · Restricted Project

Dec 4 2019

dsanders committed rG82f3c5d4a66d: [lit] Document the undocumented pre-defined substitutions (authored by dsanders).
[lit] Document the undocumented pre-defined substitutions
Dec 4 2019, 2:29 PM
dsanders added a comment to rG327894859cc4: Fix `sed -e s@FOO@%/S@` and similar when there's @'s in the working directory.
Dec 4 2019, 2:29 PM
dsanders added a comment to rG327894859cc4: Fix `sed -e s@FOO@%/S@` and similar when there's @'s in the working directory.

Could you also update https://llvm.org/docs/CommandGuide/lit.html#pre-defined-substitutions to mention this new extension?

Dec 4 2019, 1:04 PM

Dec 3 2019

dsanders committed rG327894859cc4: Fix `sed -e s@FOO@%/S@` and similar when there's @'s in the working directory (authored by dsanders).
Fix `sed -e s@FOO@%/S@` and similar when there's @'s in the working directory
Dec 3 2019, 3:51 PM
dsanders accepted D69836: [MIR] Target specific MIR formating and parsing.

LGTM from me.

Dec 3 2019, 1:30 PM · Restricted Project

Nov 18 2019

dsanders committed rG17919017878e: [macho] Allow CPUSubtype to contribute to architecture identification (authored by dsanders).
[macho] Allow CPUSubtype to contribute to architecture identification
Nov 18 2019, 1:18 PM
dsanders closed D70345: [macho] Allow CPUSubtype to contribute to architecture identification.
Nov 18 2019, 1:18 PM · Restricted Project
dsanders committed rGc941db5b1acd: [macho] Allow CPUSubtype to be adjusted before writing it to a file (authored by dsanders).
[macho] Allow CPUSubtype to be adjusted before writing it to a file
Nov 18 2019, 1:18 PM
dsanders closed D70344: [macho] Allow CPUSubtype to be adjusted before writing it to a file.
Nov 18 2019, 1:18 PM · Restricted Project

Nov 15 2019

dsanders created D70345: [macho] Allow CPUSubtype to contribute to architecture identification.
Nov 15 2019, 3:16 PM · Restricted Project
dsanders created D70344: [macho] Allow CPUSubtype to be adjusted before writing it to a file.
Nov 15 2019, 2:59 PM · Restricted Project
dsanders added inline comments to D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.
Nov 15 2019, 10:50 AM · Restricted Project

Nov 14 2019

dsanders committed rGb2839c442e26: [globalisel][irtanslator] The IRTranslator should preserve TBAA information (authored by dsanders).
[globalisel][irtanslator] The IRTranslator should preserve TBAA information
Nov 14 2019, 12:16 PM

Nov 13 2019

dsanders added inline comments to D69836: [MIR] Target specific MIR formating and parsing.
Nov 13 2019, 5:26 PM · Restricted Project
dsanders added a comment to D69836: [MIR] Target specific MIR formating and parsing.

Thanks for doing this. It should make a lot of things easier to read.

Nov 13 2019, 11:14 AM · Restricted Project

Nov 7 2019

dsanders committed rG25ee861372f1: [debugify] Move the Debugify pass from tools/opt to lib/Transform/Utils (authored by dsanders).
[debugify] Move the Debugify pass from tools/opt to lib/Transform/Utils
Nov 7 2019, 2:45 PM
dsanders closed D69926: [debugify] Move the Debugify pass from tools/opt to lib/Transform/Utils.
Nov 7 2019, 2:45 PM · Restricted Project

Nov 6 2019

dsanders created D69926: [debugify] Move the Debugify pass from tools/opt to lib/Transform/Utils.
Nov 6 2019, 4:11 PM · Restricted Project

Nov 5 2019

dsanders committed rGe0dd8f36ce49: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode… (authored by dsanders).
[globalisel][docs] Rework GMIR documentation and add an early GenericOpcode…
Nov 5 2019, 3:51 PM
dsanders committed rGad0dfb0a2534: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode… (authored by dsanders).
[globalisel][docs] Rework GMIR documentation and add an early GenericOpcode…
Nov 5 2019, 3:24 PM
dsanders closed D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.
Nov 5 2019, 3:24 PM · Restricted Project
dsanders committed rG7060840bc9cc: [globalisel][docs] Add a section about debugging with the block extractor (authored by dsanders).
[globalisel][docs] Add a section about debugging with the block extractor
Nov 5 2019, 2:56 PM
dsanders closed D69645: [globalisel][docs] Add a section about debugging with the block extractor.
Nov 5 2019, 2:56 PM · Restricted Project
dsanders added a comment to D69734: [globalisel] Rename G_GEP to G_PTR_ADD.

Thanks.

I realized I missed a couple things in this patch this morning:

  • Filenames containing 'gep'
  • Functions named buildGep() and similar I'll fix both of this this before pushing

If you're fixing names of instructions, that buildUndef doesn't match the G_IMPLICIT_DEF name has bothered me. I'm not sure which should be renamed

Nov 5 2019, 12:20 PM · Restricted Project
dsanders committed rGe74c5b96610d: [globalisel] Rename G_GEP to G_PTR_ADD (authored by dsanders).
[globalisel] Rename G_GEP to G_PTR_ADD
Nov 5 2019, 10:38 AM
dsanders closed D69734: [globalisel] Rename G_GEP to G_PTR_ADD.
Nov 5 2019, 10:38 AM · Restricted Project
dsanders added a comment to D69734: [globalisel] Rename G_GEP to G_PTR_ADD.

... this this ...

Nov 5 2019, 10:29 AM · Restricted Project
dsanders added a comment to D69734: [globalisel] Rename G_GEP to G_PTR_ADD.

I realized I missed a couple things in this patch this morning:

  • Filenames containing 'gep'
  • Functions named buildGep() and similar

I'll fix both of this this before pushing

Nov 5 2019, 10:19 AM · Restricted Project