dsanders (Daniel Sanders)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2013, 3:30 PM (217 w, 6 d)

Recent Activity

Fri, Oct 20

dsanders added a comment to D39150: [globalisel][tablegen] Import stores and allow GISel to automatically substitute zero regs like WZR/XZR/$zero..

There's two patches in one here and I'm going to try and extract the stores portion of the patch and commit that separately if I can find a reasonable way to do so without causing regressions. The main purpose of this review is to determine whether we agree it's safe to allow the new GIZeroRegister on GPR32/GPR64/GPR32all/GPR64all. I think it's probably ok, but I don't feel I have sufficient knowledge of AArch64 to make such a sweeping change without someone more familiar with it giving it the go ahead.

Fri, Oct 20, 4:51 PM
dsanders created D39150: [globalisel][tablegen] Import stores and allow GISel to automatically substitute zero regs like WZR/XZR/$zero..
Fri, Oct 20, 4:46 PM
dsanders committed rL316237: [globalisel][tablegen] Fix small spelling nits. NFC.
[globalisel][tablegen] Fix small spelling nits. NFC
Fri, Oct 20, 1:55 PM

Tue, Oct 17

dsanders committed rL316047: [aarch64][globalisel] Register banks and classes should have distinct names..
[aarch64][globalisel] Register banks and classes should have distinct names.
Tue, Oct 17, 5:13 PM

Mon, Oct 16

dsanders committed rL315972: [globalisel][tablegen] Add a GIM_CheckIsSameOperand test where OtherInsnID and….
[globalisel][tablegen] Add a GIM_CheckIsSameOperand test where OtherInsnID and…
Mon, Oct 16, 10:24 PM

Sun, Oct 15

dsanders committed rL315890: [aarch64][globalisel] Fix a crash in selectAddrModeIndexed() caused by….
[aarch64][globalisel] Fix a crash in selectAddrModeIndexed() caused by…
Sun, Oct 15, 10:39 PM
dsanders committed rL315887: Re-commit r315885: [globalisel][tblgen] Add support for iPTR and implement….
Re-commit r315885: [globalisel][tblgen] Add support for iPTR and implement…
Sun, Oct 15, 8:36 PM
dsanders committed rL315886: Revert r315885: [globalisel][tblgen] Add support for iPTR and implement….
Revert r315885: [globalisel][tblgen] Add support for iPTR and implement…
Sun, Oct 15, 7:15 PM
dsanders committed rL315885: [globalisel][tblgen] Add support for iPTR and implement am_unscaled* and….
[globalisel][tblgen] Add support for iPTR and implement am_unscaled* and…
Sun, Oct 15, 6:16 PM
dsanders closed D37458: [globalisel][tblgen] Add support for iPTR and implement am_unscaled* and am_indexed*.
Sun, Oct 15, 6:16 PM
dsanders committed rL315884: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT….
[globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT…
Sun, Oct 15, 5:56 PM
dsanders closed D37457: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT checks by committing rL315884: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT….
Sun, Oct 15, 5:56 PM
dsanders updated the diff for D37457: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT checks.

Refresh before commit

Sun, Oct 15, 5:56 PM
dsanders committed rL315872: [tablegen] Use hasPredCode()/hasImmCode() instead of getPredCode().empty….
[tablegen] Use hasPredCode()/hasImmCode() instead of getPredCode().empty…
Sun, Oct 15, 12:01 PM
dsanders committed rL315869: Re-commit r315863: [globalisel][tablegen] Import ComplexPattern when used as an….
Re-commit r315863: [globalisel][tablegen] Import ComplexPattern when used as an…
Sun, Oct 15, 11:23 AM
dsanders committed rL315866: Revert r315863: [globalisel][tablegen] Import ComplexPattern when used as an….
Revert r315863: [globalisel][tablegen] Import ComplexPattern when used as an…
Sun, Oct 15, 10:51 AM
dsanders committed rL315863: [globalisel][tablegen] Import ComplexPattern when used as an operator.
[globalisel][tablegen] Import ComplexPattern when used as an operator
Sun, Oct 15, 10:03 AM
dsanders closed D37456: [globalisel][tablegen] Import ComplexPattern when used as an operator.
Sun, Oct 15, 10:03 AM

Sat, Oct 14

dsanders committed rL315843: [globalisel][tablegen] Map ld and st to G_LOAD and G_STORE. NFC.
[globalisel][tablegen] Map ld and st to G_LOAD and G_STORE. NFC
Sat, Oct 14, 7:41 PM
dsanders closed D37445: [globalisel][tablegen] Map ld and st to G_LOAD and G_STORE. NFC.
Sat, Oct 14, 7:41 PM
dsanders committed rL315841: [tablegen] Handle common load/store predicates inside tablegen. NFC..
[tablegen] Handle common load/store predicates inside tablegen. NFC.
Sat, Oct 14, 7:07 PM
dsanders closed D37443: [tablegen] Handle common load/store predicates inside tablegen. NFC. by committing rL315841: [tablegen] Handle common load/store predicates inside tablegen. NFC..
Sat, Oct 14, 7:07 PM
dsanders updated the diff for D37443: [tablegen] Handle common load/store predicates inside tablegen. NFC..

Rebase
Check that the pre-packaged predicates are not used with ImmLeaf (by checking in getImmCode()).
Fold IsTruncStore and IsNonTruncStore together.
Fold LoadMemoryVT and StoreMemoryVT together.
Fold LoadScalarMemoryVT and StoreScalarMemoryVT together.
Fold IsUnindexedLoad and IsUnindexedStore together.

Sat, Oct 14, 6:06 PM

Fri, Oct 13

dsanders committed rL315788: [globalisel][tablegen] Fix an unused variable warning caused by a typo….
[globalisel][tablegen] Fix an unused variable warning caused by a typo…
Fri, Oct 13, 6:52 PM
dsanders added inline comments to D36618: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong-code bug this revealed..
Fri, Oct 13, 5:59 PM
dsanders committed rL315783: [globalisel][tablegen] Fix undefined references to dump().
[globalisel][tablegen] Fix undefined references to dump()
Fri, Oct 13, 5:56 PM
dsanders committed rL315780: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong….
[globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong…
Fri, Oct 13, 5:32 PM
dsanders closed D36618: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong-code bug this revealed. by committing rL315780: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong….
Fri, Oct 13, 5:32 PM
dsanders updated the diff for D36618: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong-code bug this revealed..

Fix nits aside from the addPredicate change.

Fri, Oct 13, 4:32 PM
dsanders committed rL315765: [globalisel][tablegen] Fix a use-after free bug that manifests on non-macOS….
[globalisel][tablegen] Fix a use-after free bug that manifests on non-macOS…
Fri, Oct 13, 2:51 PM
dsanders committed rL315761: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based….
[globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based…
Fri, Oct 13, 2:28 PM
dsanders closed D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf..
Fri, Oct 13, 2:28 PM
dsanders added inline comments to D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf..
Fri, Oct 13, 2:26 PM
dsanders added inline comments to D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf..
Fri, Oct 13, 2:11 PM
dsanders committed rL315747: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use….
[aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use…
Fri, Oct 13, 1:42 PM
dsanders closed D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..
Fri, Oct 13, 1:42 PM
dsanders committed rL315733: Revert r315148 [TableGen] Avoid unnecessary std::string creations.
Revert r315148 [TableGen] Avoid unnecessary std::string creations
Fri, Oct 13, 12:00 PM

Thu, Oct 12

dsanders added inline comments to D37458: [globalisel][tblgen] Add support for iPTR and implement am_unscaled* and am_indexed*.
Thu, Oct 12, 2:25 PM
dsanders added inline comments to D37457: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT checks.
Thu, Oct 12, 2:21 PM
dsanders added a comment to D37456: [globalisel][tablegen] Import ComplexPattern when used as an operator.

Looks fine with one comment:
Do you think we need a new opcode in the state machine for that?

We could have reused ComplexRender with an additional parameter and use -1 to mean render all of them.
For the sake of optimization, the current patch is actually better, but in terms of simplicity I wonder.

Feel free to commit as is. That was just my 2c :).

Thu, Oct 12, 2:14 PM
dsanders added inline comments to D37445: [globalisel][tablegen] Map ld and st to G_LOAD and G_STORE. NFC.
Thu, Oct 12, 2:07 PM
dsanders added inline comments to D37443: [tablegen] Handle common load/store predicates inside tablegen. NFC..
Thu, Oct 12, 2:00 PM
dsanders added inline comments to D36618: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong-code bug this revealed..
Thu, Oct 12, 1:47 PM
dsanders added a comment to D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf..

Thanks for the reviews

Thu, Oct 12, 1:41 PM

Tue, Oct 10

dsanders updated the diff for D37458: [globalisel][tblgen] Add support for iPTR and implement am_unscaled* and am_indexed*.

Rebase and ping

Tue, Oct 10, 1:31 PM
dsanders updated the diff for D37457: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT checks.

Rebase and ping

Tue, Oct 10, 1:21 PM
dsanders updated the diff for D37456: [globalisel][tablegen] Import ComplexPattern when used as an operator.

Rebase and ping

Tue, Oct 10, 12:35 PM
dsanders updated the diff for D37445: [globalisel][tablegen] Map ld and st to G_LOAD and G_STORE. NFC.

Rebase and ping

Tue, Oct 10, 12:20 PM
dsanders updated the diff for D37443: [tablegen] Handle common load/store predicates inside tablegen. NFC..

Rebase and ping

Tue, Oct 10, 12:06 PM
dsanders updated the diff for D36618: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong-code bug this revealed..

Rebase and ping

Tue, Oct 10, 11:50 AM
dsanders added a comment to D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..

Rebased to trunk. I'll fix the comments I've received shortly.

This patch now requires r315148 to be reverted. That patch changed
getPredCode() and getImmCode() to return StringRef's but this patch requires
that getPredCode() return a std::string. We could revert just the getPredCode()
portion of that patch if we want but I think it would be weird for the two
functions to require different usage.

I'm just curious, what's the issue with it returning a StringRef?

Tue, Oct 10, 10:51 AM
dsanders updated the diff for D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf..

Rebase and ping

Tue, Oct 10, 10:40 AM
dsanders updated the diff for D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..

'Should the ... be ...?' comments changed to 'Is the ... a ...?'
Clarified that IntImmLeaf is not a replacement for ImmLeaf but rather a
replacement for PatLeaf with immediate predicates that ImmLeaf can't handle.

Tue, Oct 10, 10:08 AM
dsanders updated the diff for D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..

Rebased to trunk. I'll fix the comments I've received shortly.

Tue, Oct 10, 9:58 AM

Mon, Oct 9

dsanders added a comment to D38043: Restore ability for C++ API users to Enable IPRA..

ping

Mon, Oct 9, 11:19 AM
dsanders committed rL315226: [globalisel] Add support for ValueType operands in patterns..
[globalisel] Add support for ValueType operands in patterns.
Mon, Oct 9, 11:16 AM

Sep 20 2017

dsanders added inline comments to D38043: Restore ability for C++ API users to Enable IPRA..
Sep 20 2017, 3:18 AM

Sep 19 2017

dsanders created D38043: Restore ability for C++ API users to Enable IPRA..
Sep 19 2017, 10:05 AM
dsanders committed rL313633: [globalisel] Add a G_BSWAP instruction and support bswap using it..
[globalisel] Add a G_BSWAP instruction and support bswap using it.
Sep 19 2017, 7:27 AM
dsanders committed rL313629: [globalisel] Add support for intrinsic_void.
[globalisel] Add support for intrinsic_void
Sep 19 2017, 6:24 AM
dsanders committed rL313627: [globalisel] Add support for intrinsic_w_chain..
[globalisel] Add support for intrinsic_w_chain.
Sep 19 2017, 5:58 AM

Sep 5 2017

dsanders added inline comments to D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..
Sep 5 2017, 2:50 PM
dsanders added inline comments to D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..
Sep 5 2017, 2:08 AM
dsanders created D37458: [globalisel][tblgen] Add support for iPTR and implement am_unscaled* and am_indexed*.
Sep 5 2017, 1:52 AM
dsanders added a dependent revision for D37457: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT checks: D37458: [globalisel][tblgen] Add support for iPTR and implement am_unscaled* and am_indexed*.
Sep 5 2017, 1:52 AM
dsanders created D37457: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT checks.
Sep 5 2017, 1:42 AM
dsanders added a dependent revision for D37456: [globalisel][tablegen] Import ComplexPattern when used as an operator: D37457: [globalisel][tablegen] Implement unindexed load, non-extending load, and MemVT checks.
Sep 5 2017, 1:42 AM
dsanders created D37456: [globalisel][tablegen] Import ComplexPattern when used as an operator.
Sep 5 2017, 1:24 AM
dsanders added a dependent revision for D37445: [globalisel][tablegen] Map ld and st to G_LOAD and G_STORE. NFC: D37456: [globalisel][tablegen] Import ComplexPattern when used as an operator.
Sep 5 2017, 1:24 AM

Sep 4 2017

dsanders created D37445: [globalisel][tablegen] Map ld and st to G_LOAD and G_STORE. NFC.
Sep 4 2017, 10:31 AM
dsanders created D37443: [tablegen] Handle common load/store predicates inside tablegen. NFC..
Sep 4 2017, 10:19 AM
dsanders added a dependent revision for D36618: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong-code bug this revealed.: D37443: [tablegen] Handle common load/store predicates inside tablegen. NFC..
Sep 4 2017, 10:19 AM
dsanders updated the diff for D36618: [globalisel][tablegen] Simplify named operand/operator lookups and fix a wrong-code bug this revealed..

Rebase

Sep 4 2017, 10:14 AM
dsanders updated the diff for D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf..

Rebase

Sep 4 2017, 9:59 AM
dsanders updated the diff for D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..

Rebase and fix nits

Sep 4 2017, 9:21 AM
dsanders added a comment to D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..

Sorry for the slow reply, I was on holiday last week.

Sep 4 2017, 6:50 AM

Aug 24 2017

dsanders committed rL311684: [globalisel][tablegen] Predicates should start from GIPFP_Invalid+1 not….
[globalisel][tablegen] Predicates should start from GIPFP_Invalid+1 not…
Aug 24 2017, 11:57 AM
dsanders committed rL311645: Re-commit: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.
Re-commit: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm
Aug 24 2017, 2:15 AM

Aug 23 2017

dsanders added a comment to D35332: [GISel]: More flexibility while building I/FCmps with MachineIRBuilder.

Hi Aditya,

Aug 23 2017, 6:41 AM
dsanders added a dependency for D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf.: D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..
Aug 23 2017, 6:36 AM
dsanders added a dependent revision for D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them.: D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf..
Aug 23 2017, 6:36 AM
dsanders updated the diff for D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..

Refresh

Aug 23 2017, 6:35 AM
dsanders committed rL311546: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.
[globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm
Aug 23 2017, 5:16 AM
dsanders closed D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.
Aug 23 2017, 5:15 AM
dsanders added inline comments to D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.
Aug 23 2017, 3:16 AM
dsanders committed rL311542: [globalisel][tablegen] Add tests for FeatureBitsets and ComplexPattern….
[globalisel][tablegen] Add tests for FeatureBitsets and ComplexPattern…
Aug 23 2017, 3:10 AM

Aug 22 2017

dsanders updated the diff for D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.

Fixed the nits and added some additional tests I noticed were missing from test/TableGen/GlobalISelEmitter.td

Aug 22 2017, 9:27 AM

Aug 18 2017

dsanders updated the summary of D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.
Aug 18 2017, 7:34 AM
dsanders added a comment to D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.

This should have a summary.

I'm probably just bikeshedding a bit, but why is this an instruction predicate and not an operand predicate? I understand that you know it always refers to the second operand of the G_CONSTANT, but I think it looks a bit strange e.g. in your test you have a "No predicates" comment on the MIs[0] Operand 1 which looks a bit surprising (I had a bit of an "ooooh, of course, because it's an instruction predicate" moment reading that test).

Aug 18 2017, 7:21 AM

Aug 17 2017

dsanders added a comment to D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them..

ping

Aug 17 2017, 7:43 AM
dsanders added a comment to D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm.

ping

Aug 17 2017, 7:43 AM
dsanders committed rL311084: [globalisel][tablegen] Generate TypeObject table. NFC.
[globalisel][tablegen] Generate TypeObject table. NFC
Aug 17 2017, 6:19 AM
dsanders closed D36085: [globalisel][tablegen] Generate TypeObject table. NFC.
Aug 17 2017, 6:19 AM
dsanders committed rL311076: Re-commit: [globalisel][tablegen] Support zero-instruction emission..
Re-commit: [globalisel][tablegen] Support zero-instruction emission.
Aug 17 2017, 2:27 AM
dsanders closed D36084: [globalisel][tablegen] Support zero-instruction emission. by committing rL311076: Re-commit: [globalisel][tablegen] Support zero-instruction emission..
Aug 17 2017, 2:27 AM

Aug 15 2017

dsanders reopened D36084: [globalisel][tablegen] Support zero-instruction emission..
Aug 15 2017, 8:15 AM
dsanders committed rL310922: Revert r310919 - [globalisel][tablegen] Support zero-instruction emission..
Revert r310919 - [globalisel][tablegen] Support zero-instruction emission.
Aug 15 2017, 8:12 AM
dsanders committed rL310919: Re-commit with some instrumentation: [globalisel][tablegen] Support zero….
Re-commit with some instrumentation: [globalisel][tablegen] Support zero…
Aug 15 2017, 6:53 AM
dsanders closed D36084: [globalisel][tablegen] Support zero-instruction emission. by committing rL310919: Re-commit with some instrumentation: [globalisel][tablegen] Support zero….
Aug 15 2017, 6:53 AM

Aug 11 2017

dsanders reopened D36085: [globalisel][tablegen] Generate TypeObject table. NFC.

This was reverted in order to revert D36084. Investigating the problem with D36084

Aug 11 2017, 12:22 PM