Page MenuHomePhabricator

piotr (Piotr Sobczak)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2018, 6:02 AM (133 w, 1 d)

Recent Activity

Mon, Jun 14

piotr committed rGe0c382a9d5a0: [AMDGPU] Limit runs of fixLdsBranchVmemWARHazard (authored by piotr).
[AMDGPU] Limit runs of fixLdsBranchVmemWARHazard
Mon, Jun 14, 1:31 PM
piotr closed D104219: [AMDGPU] Limit runs of fixLdsBranchVmemWARHazard.
Mon, Jun 14, 1:31 PM · Restricted Project
piotr updated the summary of D104219: [AMDGPU] Limit runs of fixLdsBranchVmemWARHazard.
Mon, Jun 14, 5:07 AM · Restricted Project
piotr added reviewers for D104219: [AMDGPU] Limit runs of fixLdsBranchVmemWARHazard: arsenm, rampitec, foad, bsaleil.
Mon, Jun 14, 5:06 AM · Restricted Project
piotr requested review of D104219: [AMDGPU] Limit runs of fixLdsBranchVmemWARHazard.
Mon, Jun 14, 5:05 AM · Restricted Project

May 12 2021

piotr added a comment to D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts.

Yes, based on Matt's last comment, there is still a potential problem even though my patch significantly reduces the likelihood of it occurring.

May 12 2021, 6:11 AM · Restricted Project
piotr added a comment to D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts.

Assert removed in a4db7025a9762c568c7bc9fdd3c64f4a60e31cfc.

May 12 2021, 5:54 AM · Restricted Project
piotr committed rGa4db7025a976: [AMDGPU] Remove assert (authored by piotr).
[AMDGPU] Remove assert
May 12 2021, 5:54 AM
piotr committed rG68137ef5682f: [AMDGPU] Skip invariant loads when avoiding WAR conflicts (authored by piotr).
[AMDGPU] Skip invariant loads when avoiding WAR conflicts
May 12 2021, 1:58 AM
piotr closed D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts.
May 12 2021, 1:58 AM · Restricted Project
piotr updated the diff for D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts.

Added the assert. The assert seems in order here - no hits in the lit tests or Vulkan CTS. There would have been hits in 194 lit tests if the assert had been placed here without the isInvariant check, which somewhat proves usefulness of the patch.

May 12 2021, 1:22 AM · Restricted Project

May 11 2021

piotr committed rG09fe84abb4ee: [AMDGPU] Move code sinking before structurizer (authored by piotr).
[AMDGPU] Move code sinking before structurizer
May 11 2021, 5:35 AM
piotr closed D101115: [AMDGPU] Move code sinking before structurizer.
May 11 2021, 5:34 AM · Restricted Project

May 10 2021

piotr updated the diff for D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts.

Added mir test.

May 10 2021, 2:08 AM · Restricted Project

May 7 2021

piotr retitled D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts from [AMDGPU] Avoid adding nullptr keys to hash table to [AMDGPU] Skip invariant loads when avoiding WAR conflicts.
May 7 2021, 2:04 PM · Restricted Project
piotr updated the diff for D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts.

Re-purposing patch to not add invariant loads to the map.

May 7 2021, 2:03 PM · Restricted Project

May 5 2021

piotr accepted D101966: [AMDGPU] Fix WQM failure with single block inactive demote.
May 5 2021, 11:47 PM · Restricted Project

Apr 26 2021

piotr added a reviewer for D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts: alex-t.
Apr 26 2021, 2:39 AM · Restricted Project
piotr added inline comments to D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts.
Apr 26 2021, 2:39 AM · Restricted Project

Apr 23 2021

piotr added reviewers for D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts: foad, arsenm, rampitec.
Apr 23 2021, 9:22 AM · Restricted Project
piotr requested review of D101177: [AMDGPU] Skip invariant loads when avoiding WAR conflicts.
Apr 23 2021, 9:21 AM · Restricted Project
piotr added a comment to D101115: [AMDGPU] Move code sinking before structurizer.

I know it is a legacy pass, but I am convinced of its usefulness in our flow - both in real-world content and lit testing (e.g., no_skip_no_successors in skip-if-dead.ll).

I'm not worried about legacy, but whether it's redundant since it should have already run at this point

Some sinking is done as part of other passes, but I do not think this pass is set up to be run at any other point in our pass list.

Apr 23 2021, 8:35 AM · Restricted Project
piotr updated the diff for D101115: [AMDGPU] Move code sinking before structurizer.

Rebased, added comment in test.

Apr 23 2021, 8:34 AM · Restricted Project
piotr committed rG83a3395b30d2: [AMDGPU][NFC] Update auto-gen test (authored by piotr).
[AMDGPU][NFC] Update auto-gen test
Apr 23 2021, 7:35 AM
piotr added inline comments to D101115: [AMDGPU] Move code sinking before structurizer.
Apr 23 2021, 7:15 AM · Restricted Project
piotr added a comment to D101115: [AMDGPU] Move code sinking before structurizer.

I know it is a legacy pass, but I am convinced of its usefulness in our flow - both in real-world content and lit testing (e.g., no_skip_no_successors in skip-if-dead.ll).

I'm not worried about legacy, but whether it's redundant since it should have already run at this point

Apr 23 2021, 5:59 AM · Restricted Project
piotr added a comment to D101115: [AMDGPU] Move code sinking before structurizer.

I know it is a legacy pass, but I am convinced of its usefulness in our flow - both in real-world content and lit testing (e.g., no_skip_no_successors in skip-if-dead.ll).

Apr 23 2021, 1:40 AM · Restricted Project

Apr 22 2021

piotr added reviewers for D101115: [AMDGPU] Move code sinking before structurizer: critson, arsenm, mareko.
Apr 22 2021, 3:28 PM · Restricted Project
piotr updated the diff for D101115: [AMDGPU] Move code sinking before structurizer.

Added test.

Apr 22 2021, 3:26 PM · Restricted Project
piotr requested review of D101115: [AMDGPU] Move code sinking before structurizer.
Apr 22 2021, 3:23 PM · Restricted Project

Mar 23 2021

piotr accepted D99167: [AMDGPU] Use non-compressed exports in a test. NFC..

I suspect the compr version was used in the original shader, which was then shortened to the lit file.

Mar 23 2021, 3:54 AM · Restricted Project

Mar 19 2021

piotr added a comment to D98663: [AMDGPU] Remove cpol, tfe, and swz from MUBUF patterns.

Looks good, thanks.

Mar 19 2021, 4:35 AM · Restricted Project

Mar 17 2021

piotr accepted D98772: [AMDGPU] Avoid unnecessary graph visits during WQM marking.
Mar 17 2021, 6:37 AM · Restricted Project

Mar 15 2021

piotr accepted D98614: [AMDGPU] Fix shortfalls in WQM marking.

LGTM

Mar 15 2021, 5:45 AM · Restricted Project
piotr added inline comments to D98614: [AMDGPU] Fix shortfalls in WQM marking.
Mar 15 2021, 5:38 AM · Restricted Project
piotr accepted D98614: [AMDGPU] Fix shortfalls in WQM marking.
Mar 15 2021, 5:05 AM · Restricted Project
piotr added inline comments to D98614: [AMDGPU] Fix shortfalls in WQM marking.
Mar 15 2021, 3:33 AM · Restricted Project

Mar 12 2021

piotr edited reviewers for D98491: [AMDGPU] Split GCN subtarget features for unaligned access, added: arsenm; removed: arsen.
Mar 12 2021, 4:33 AM · Restricted Project

Mar 3 2021

piotr committed rG4672bac1776e: [AMDGPU] Introduce Strict WQM mode (authored by piotr).
[AMDGPU] Introduce Strict WQM mode
Mar 3 2021, 5:48 AM
piotr closed D96258: [AMDGPU] Introduce Strict WQM mode.
Mar 3 2021, 5:48 AM · Restricted Project
piotr committed rGc3ce7bae800d: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm (authored by piotr).
[AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm
Mar 3 2021, 1:16 AM
piotr closed D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.
Mar 3 2021, 1:16 AM · Restricted Project

Feb 25 2021

piotr updated the diff for D96258: [AMDGPU] Introduce Strict WQM mode.

Fixed newline and added static/const.

Feb 25 2021, 4:11 AM · Restricted Project
piotr added a comment to D97427: [AMDGPU] Do not annotate an else branch if there is a kill.

Alternatively, you could create the set of blocks containing a kill in advance - by looking at function declarations in the module, and if a kill is found then checking its users to find blocks. Whether that would be better depends on how often hasKill() is called, though.

Feb 25 2021, 12:31 AM · Restricted Project

Feb 24 2021

piotr added inline comments to D96258: [AMDGPU] Introduce Strict WQM mode.
Feb 24 2021, 5:48 AM · Restricted Project
piotr updated the summary of D96258: [AMDGPU] Introduce Strict WQM mode.
Feb 24 2021, 5:48 AM · Restricted Project
piotr updated the diff for D96258: [AMDGPU] Introduce Strict WQM mode.

Rebased, changed strictwqm to strict_wqm and updated tests.

Feb 24 2021, 5:44 AM · Restricted Project

Feb 23 2021

piotr updated the diff for D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.

Added missing dot in the intrinsic name.

Feb 23 2021, 1:37 AM · Restricted Project

Feb 22 2021

piotr updated the diff for D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.

Rebased and updated tests.

Feb 22 2021, 6:10 AM · Restricted Project

Feb 19 2021

piotr accepted D95503: [AMDGPU] WQM/WWM: Fix marking of partial definitions.
Feb 19 2021, 2:40 AM · Restricted Project

Feb 17 2021

piotr added a comment to D95503: [AMDGPU] WQM/WWM: Fix marking of partial definitions.

Looks good to me (with two nits inline).

Feb 17 2021, 9:39 AM · Restricted Project
piotr committed rGc72a63b4b06a: [AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32 (authored by piotr).
[AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32
Feb 17 2021, 6:17 AM
piotr closed D96793: [AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32.
Feb 17 2021, 6:17 AM · Restricted Project
piotr committed rG08131c743933: [AMDGPU] Fix a miscompile with S_ADD/S_SUB (authored by piotr).
[AMDGPU] Fix a miscompile with S_ADD/S_SUB
Feb 17 2021, 3:27 AM
piotr closed D86878: [AMDGPU] Fix a miscompile with S_ADD/S_SUB.
Feb 17 2021, 3:26 AM · Restricted Project
piotr updated the diff for D96793: [AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32.

Commoned up the SI and GFX10-WAVE64 checks.

Feb 17 2021, 2:19 AM · Restricted Project

Feb 16 2021

piotr added a comment to D96793: [AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32.

Updated commit message with more details and pasted the original error message.

Feb 16 2021, 9:14 AM · Restricted Project
piotr retitled D96793: [AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32 from [AMDGPU] Fix implicit operand to [AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32.
Feb 16 2021, 9:12 AM · Restricted Project
piotr added reviewers for D96793: [AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32: arsenm, foad, critson.
Feb 16 2021, 8:58 AM · Restricted Project
piotr requested review of D96793: [AMDGPU] Add implicit vcc_lo on S_CBRANCH_VCCNZ in wave32.
Feb 16 2021, 8:57 AM · Restricted Project
piotr updated the diff for D86878: [AMDGPU] Fix a miscompile with S_ADD/S_SUB.

Tests rewritten.

Feb 16 2021, 1:10 AM · Restricted Project

Feb 15 2021

piotr retitled D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm from [AMDGPU] Rename amdgcn_wwm to amdgcn_strictwwm to [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.
Feb 15 2021, 8:13 AM · Restricted Project
piotr updated the diff for D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.

Add the underscore between strict and wwm. Restored the old tests for amdgcn_wwm.

Feb 15 2021, 8:09 AM · Restricted Project
piotr abandoned D96714: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.
Feb 15 2021, 7:59 AM · Restricted Project
piotr requested review of D96714: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.
Feb 15 2021, 7:58 AM · Restricted Project

Feb 11 2021

piotr added a comment to D86878: [AMDGPU] Fix a miscompile with S_ADD/S_SUB.

This is the intended patch, no need to change AMDGPUISelDAGToDAG.cpp in the most recent version. Here, due to the updated check in isBoolSGPR the problematic combines that would strip zext will not happen (see SITargetLowering::performAddCombine/performSubCombine). This is similar to the very first approach I put up for a review.

Feb 11 2021, 6:44 AM · Restricted Project
piotr updated the summary of D86878: [AMDGPU] Fix a miscompile with S_ADD/S_SUB.
Feb 11 2021, 1:12 AM · Restricted Project
piotr updated the diff for D86878: [AMDGPU] Fix a miscompile with S_ADD/S_SUB.

Following the suggesstions of updating isBoolSGPR.

Feb 11 2021, 1:11 AM · Restricted Project

Feb 10 2021

piotr added inline comments to D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.
Feb 10 2021, 12:56 AM · Restricted Project

Feb 9 2021

piotr added inline comments to D96336: [AMDGPU] Save VGPR of whole wave when spilling.
Feb 9 2021, 8:52 AM · Restricted Project
piotr added inline comments to D96258: [AMDGPU] Introduce Strict WQM mode.
Feb 9 2021, 5:47 AM · Restricted Project
piotr added a comment to D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.

Is it worth adding a test to ensure old intrinsic still works?

Feb 9 2021, 5:28 AM · Restricted Project

Feb 8 2021

piotr accepted D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking.
Feb 8 2021, 5:44 AM · Restricted Project
piotr added reviewers for D96258: [AMDGPU] Introduce Strict WQM mode: arsenm, critson.
Feb 8 2021, 4:31 AM · Restricted Project
piotr added reviewers for D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm: arsenm, critson.
Feb 8 2021, 4:31 AM · Restricted Project
piotr added a comment to D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.

See also D96258.

Feb 8 2021, 4:30 AM · Restricted Project
piotr requested review of D96258: [AMDGPU] Introduce Strict WQM mode.
Feb 8 2021, 4:29 AM · Restricted Project
piotr requested review of D96257: [AMDGPU] Rename amdgcn_wwm to amdgcn_strict_wwm.
Feb 8 2021, 4:25 AM · Restricted Project

Jan 27 2021

piotr committed rGfc8e7411218c: [AMDGPU] Avoid an illegal operand in si-shrink-instructions (authored by piotr).
[AMDGPU] Avoid an illegal operand in si-shrink-instructions
Jan 27 2021, 11:50 PM
piotr closed D95527: [AMDGPU] Avoid an illegal operand in si-shrink-instructions.
Jan 27 2021, 11:50 PM · Restricted Project
piotr accepted D95509: [AMDGPU] Mark V_SET_INACTIVE as defining SCC.
Jan 27 2021, 11:27 PM · Restricted Project
piotr accepted D94747: [AMDGPU] Add llvm.amdgcn.wqm.demote intrinsic.
Jan 27 2021, 11:16 PM · Restricted Project
piotr added reviewers for D95527: [AMDGPU] Avoid an illegal operand in si-shrink-instructions: arsenm, rampitec.
Jan 27 2021, 7:24 AM · Restricted Project
piotr requested review of D95527: [AMDGPU] Avoid an illegal operand in si-shrink-instructions.
Jan 27 2021, 7:18 AM · Restricted Project

Jan 25 2021

piotr added a comment to D94747: [AMDGPU] Add llvm.amdgcn.wqm.demote intrinsic.

LGTM with a few nits - feel free to ignore them.

Jan 25 2021, 2:31 AM · Restricted Project

Jan 21 2021

piotr added a comment to D95132: [AMDGPU][GlobalISel] Run SIAddImgInit.

Thanks!

Jan 21 2021, 7:18 AM · Restricted Project
piotr added inline comments to D95132: [AMDGPU][GlobalISel] Run SIAddImgInit.
Jan 21 2021, 7:11 AM · Restricted Project
piotr added a comment to D86878: [AMDGPU] Fix a miscompile with S_ADD/S_SUB.

Sorry for the lack of activity lately - I plan to get back to this patch in the near future.

Jan 21 2021, 1:01 AM · Restricted Project

Jan 20 2021

piotr added inline comments to D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking.
Jan 20 2021, 2:18 AM · Restricted Project

Jan 18 2021

piotr added a comment to D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking.

LGTM with a few more nits (inline).

Jan 18 2021, 5:58 AM · Restricted Project

Jan 15 2021

piotr added inline comments to D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking.
Jan 15 2021, 3:28 AM · Restricted Project
piotr added inline comments to D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking.
Jan 15 2021, 2:21 AM · Restricted Project
piotr added inline comments to D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking.
Jan 15 2021, 2:12 AM · Restricted Project

Dec 16 2020

piotr committed rGc7afb698caf0: [AMDGPU] Avoid calling copyFastMathFlags in wrong context (authored by piotr).
[AMDGPU] Avoid calling copyFastMathFlags in wrong context
Dec 16 2020, 1:24 AM

Nov 18 2020

piotr committed rGb3b9be4ae77e: SpeculativeExecution: Allow speculating more instruction types (authored by piotr).
SpeculativeExecution: Allow speculating more instruction types
Nov 18 2020, 8:01 AM
piotr closed D91688: SpeculativeExecution: Allow speculating more instruction types.
Nov 18 2020, 8:00 AM · Restricted Project
piotr added a comment to D91688: SpeculativeExecution: Allow speculating more instruction types.

I asked myself the same question - this was tried before - see https://reviews.llvm.org/D24544. I do not know any more details.

Nov 18 2020, 6:27 AM · Restricted Project
piotr updated the summary of D91688: SpeculativeExecution: Allow speculating more instruction types.
Nov 18 2020, 6:20 AM · Restricted Project
piotr updated the diff for D91688: SpeculativeExecution: Allow speculating more instruction types.

Added two more instructions: trunc and freeze (thanks @foad).

Nov 18 2020, 6:10 AM · Restricted Project
piotr added inline comments to D91636: [AMDGPU] Fix and extend vccz workarounds.
Nov 18 2020, 1:48 AM · Restricted Project