Page MenuHomePhabricator

jacek (Jacek Caban)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 28 2018, 1:12 PM (127 w, 2 d)

Recent Activity

May 15 2020

jacek added a comment to D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms..

I don't mind dropping the patch, we can mitigate the problem in Wine. My understanding is that we could use "pedantic" logic similar to NSInteger in checkFormatExpr, please let me know if you'd like something like that.

May 15 2020, 1:03 PM · Restricted Project

May 14 2020

jacek added a comment to D79934: [RFC] [LLD] [COFF] Support options for enabling/disabling autoimport and pseudo relocs in .drectve sections.

With the solution for UWP, we don't have a use case .drectve change, so dropping that part sounds reasonable.

May 14 2020, 4:15 AM · Restricted Project

Apr 20 2020

jacek created D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms..
Apr 20 2020, 10:48 AM · Restricted Project

Aug 30 2019

jacek added a comment to D66996: [llvm-dlltool] Handle external and internal names with differing decoration.

Yes, it works with your patch and Wine workaround reverted.

Aug 30 2019, 5:21 AM · Restricted Project

Aug 23 2019

jacek added a comment to D66617: [llvm-dlltool] Make sure to strip decorations from ExtName for renamed exports.

I can confirm that with a simple Wine change, its importlibs work fine.

Aug 23 2019, 9:28 AM · Restricted Project
jacek added a comment to D66617: [llvm-dlltool] Make sure to strip decorations from ExtName for renamed exports.

Oh, I see. FWIW, it shouldn't be too hard to work around the problem in Wine. .def file is generated automatically, so we could just skip aliases for .def file used for importlibs. It seems like it would help a hypethetical Wine MSCV port anyway and it might be better for LLVM to be MSVC compatible in this case. I will experiment with it.

Aug 23 2019, 9:19 AM · Restricted Project
jacek added a comment to D66617: [llvm-dlltool] Make sure to strip decorations from ExtName for renamed exports.

It looks like decoration is killed too aggressively now. If aliasee symbol has no decoration, aliased symbol is stripped. For example:

Aug 23 2019, 7:43 AM · Restricted Project

Aug 6 2019

jacek added a comment to D65728: [LLD] [MinGW] Add an lld specific option for requesting to delay load libraries.

Thanks for doing that!

Aug 6 2019, 8:31 AM · Restricted Project

Dec 5 2018

jacek updated the diff for D55242: [llvm-rc] Support not expressions..
Dec 5 2018, 5:00 AM
jacek added inline comments to D55242: [llvm-rc] Support not expressions..
Dec 5 2018, 5:00 AM
jacek updated the diff for D55242: [llvm-rc] Support not expressions..
Dec 5 2018, 4:50 AM

Dec 4 2018

jacek added a comment to D55242: [llvm-rc] Support not expressions..

Thanks for review.

Dec 4 2018, 8:49 AM

Dec 3 2018

jacek created D55242: [llvm-rc] Support not expressions..
Dec 3 2018, 4:29 PM

Nov 29 2018

jacek updated the diff for D55020: [llvm-rc] Support EXSTYLE statement..
Nov 29 2018, 4:11 AM
jacek updated the diff for D55020: [llvm-rc] Support EXSTYLE statement..

Thanks for reviews, I addressed comments.

Nov 29 2018, 3:42 AM

Nov 28 2018

jacek created D55020: [llvm-rc] Support EXSTYLE statement..
Nov 28 2018, 1:19 PM