Page MenuHomePhabricator

jpienaar (Jacques Pienaar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 6:06 PM (283 w, 1 d)

Recent Activity

Wed, Jan 22

jpienaar committed rG178562fb352d: [mlir] Enable specifying verify on OpInterface (authored by jpienaar).
[mlir] Enable specifying verify on OpInterface
Wed, Jan 22, 4:44 AM
jpienaar closed D73122: [mlir] Enable specifying verify on OpInterface.
Wed, Jan 22, 4:43 AM · Restricted Project
jpienaar updated the diff for D73122: [mlir] Enable specifying verify on OpInterface.

Quoted 'verify', removed spurious newlines.

Wed, Jan 22, 4:43 AM · Restricted Project
jpienaar added a comment to D73122: [mlir] Enable specifying verify on OpInterface.

Updated thanks

Wed, Jan 22, 4:43 AM · Restricted Project

Tue, Jan 21

jpienaar created D73122: [mlir] Enable specifying verify on OpInterface.
Tue, Jan 21, 10:10 AM · Restricted Project

Mon, Jan 20

jpienaar committed rGb70e4efb75bf: [mlir] Generalize broadcastable trait operands (authored by jpienaar).
[mlir] Generalize broadcastable trait operands
Mon, Jan 20, 1:04 PM
jpienaar closed D72559: [mlir] Generalize broadcastable trait operands.
Mon, Jan 20, 1:04 PM · Restricted Project

Sun, Jan 19

jpienaar added inline comments to D72559: [mlir] Generalize broadcastable trait operands.
Sun, Jan 19, 7:54 AM · Restricted Project
jpienaar retitled D72559: [mlir] Generalize broadcastable trait operands from [mlir] Add trait for staging update of broadcastable trait to [mlir] Generalize broadcastable trait operands.
Sun, Jan 19, 7:44 AM · Restricted Project
jpienaar updated the diff for D72559: [mlir] Generalize broadcastable trait operands.

Update summary as I realized the doc was out of date but we had already fixed the bug about element type. Instead generalized broadcastable to variadic operands, rename trait and addressed comments.

Sun, Jan 19, 7:44 AM · Restricted Project

Fri, Jan 17

jpienaar accepted D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM.

Looks good thanks

Fri, Jan 17, 5:23 PM · Restricted Project, Restricted Project

Thu, Jan 16

Herald added a reviewer for D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM: nicolasvasilache.

I think you may have forgotten to upload the changed diff :) In general I think this looks good, I'd like to remove the duplicate functions but beyond that this should be good.

Thu, Jan 16, 7:01 AM · Restricted Project, Restricted Project

Wed, Jan 15

jpienaar committed rGfa26a37d3699: [mlir] Add shaped container component type interface (authored by jpienaar).
[mlir] Add shaped container component type interface
Wed, Jan 15, 1:30 PM
jpienaar closed D72432: [mlir] Add shaped container component type interface.
Wed, Jan 15, 1:30 PM · Restricted Project

Tue, Jan 14

jpienaar accepted D72294: [mlir] Refactor ModuleState into AsmState and expose it to users..

Looks good thanks

Tue, Jan 14, 8:22 AM · Restricted Project
jpienaar accepted D72672: [mlir] NFC: Fix trivial typos.
Tue, Jan 14, 8:22 AM · Restricted Project
jpienaar accepted D72642: [mlir] Enable printing of FuncOp in the generic form..
Tue, Jan 14, 8:22 AM · Restricted Project
jpienaar added a comment to D72697: [mlir] fix broken link to Glossary.

Yes the missing docs are considered static and supposed to be in mlir-www and the links to them work on mlir.llvm.org via relative, but could be made explicit to the website here..

Tue, Jan 14, 8:22 AM · Restricted Project
jpienaar added a comment to D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM.

Nice, seems to match what clang does here too so that's good to keep it in sync

Tue, Jan 14, 8:21 AM · Restricted Project, Restricted Project

Mon, Jan 13

jpienaar added a comment to D72294: [mlir] Refactor ModuleState into AsmState and expose it to users..

Looks good on first walk through

Mon, Jan 13, 8:12 AM · Restricted Project
jpienaar added a comment to D72432: [mlir] Add shaped container component type interface.

Apparently I forgot to hit submit (seeing unsubmitted comments below).

Mon, Jan 13, 8:03 AM · Restricted Project
jpienaar added inline comments to D72559: [mlir] Generalize broadcastable trait operands.
Mon, Jan 13, 7:54 AM · Restricted Project

Sat, Jan 11

jpienaar created D72559: [mlir] Generalize broadcastable trait operands.
Sat, Jan 11, 10:08 AM · Restricted Project
jpienaar updated the diff for D72432: [mlir] Add shaped container component type interface.

Updated docs & switched to function_ref.

Sat, Jan 11, 9:15 AM · Restricted Project

Fri, Jan 10

jpienaar added a comment to D72481: [mlir][EDSC] Refactor dependencies involving EDSCs..

This is mostly a mechanical move or is there anything new to look at, correct?

Fri, Jan 10, 9:43 AM · Restricted Project

Wed, Jan 8

jpienaar created D72432: [mlir] Add shaped container component type interface.
Wed, Jan 8, 7:57 PM · Restricted Project
jpienaar added a reviewer for D72384: [mlir] mlir-cpu-runner test's cblas_interface should export functions on Windows: nicolasvasilache.
Wed, Jan 8, 2:04 PM · Restricted Project
jpienaar accepted D72043: [mlir] Update the CallGraph for nested symbol references, and simplify CallableOpInterface.

LG, thanks

Wed, Jan 8, 1:55 PM · Restricted Project
jpienaar added a comment to D71655: [MachineScheduler] Allow clustering mem ops with complex addresses.

LG for Lanai changes too

Wed, Jan 8, 1:55 PM · Restricted Project
jpienaar accepted D72403: [MLIR] Fix ML IR build on Windows with Visual Studio.

Thanks!

Wed, Jan 8, 10:30 AM · Restricted Project

Mon, Jan 6

jpienaar accepted D72042: [mlir] Update the use-list algorithms in SymbolTable to support nested references..

I don't know this part as well as Mehdi does, but it looks good.

Mon, Jan 6, 1:01 PM · Restricted Project

Fri, Jan 3

jpienaar added a comment to D72094: [mlir][linalg] Lower linalg to affine loops.

This seems to break on GCC 5.5:

Fri, Jan 3, 11:31 AM · Restricted Project
jpienaar accepted D72127: [mlir] Fix indexed_accessor_range to properly forward the derived class..

Could we add a test that this would have hit? (I'm thinking of one just assigning the sliced/drop_front one).

Fri, Jan 3, 8:12 AM · Restricted Project

Thu, Jan 2

jpienaar accepted D72020: [mlir] Rewrite the internal representation of OpResult to be optimized for memory..

Thanks

Thu, Jan 2, 1:27 PM · Restricted Project
jpienaar committed rG8f1caf518f37: [mlir] Only generate default for uncovered cases (authored by jpienaar).
[mlir] Only generate default for uncovered cases
Thu, Jan 2, 12:59 PM
jpienaar committed rGf533fa3af5ef: [mlir] Revert default case that was needed (authored by jpienaar).
[mlir] Revert default case that was needed
Thu, Jan 2, 12:40 PM
jpienaar committed rG98a88c1beec5: [mlir] Add parenthesis to avoid -Wparentheses (authored by jpienaar).
[mlir] Add parenthesis to avoid -Wparentheses
Thu, Jan 2, 12:31 PM
jpienaar committed rG3d83d8259c1b: [mlir] Remove redudant default cases (authored by jpienaar).
[mlir] Remove redudant default cases
Thu, Jan 2, 12:31 PM
jpienaar accepted D72045: Add missing mlir-headers target and add tablegen'd deps to it..

Thanks!

Thu, Jan 2, 10:17 AM · Restricted Project
jpienaar accepted D72020: [mlir] Rewrite the internal representation of OpResult to be optimized for memory..

Looks good in general, thanks

Thu, Jan 2, 10:08 AM · Restricted Project
jpienaar accepted D72065: [mlir] NFC: Fix broken links in docs.

Thanks

Thu, Jan 2, 8:33 AM · Restricted Project

Tue, Dec 31

jpienaar committed rG7544cb8807b2: [mlir][docs] Remove redundant path prefix (authored by jpienaar).
[mlir][docs] Remove redundant path prefix
Tue, Dec 31, 11:08 AM
jpienaar committed rG430bba2a0f39: [mlir] Make code blocks more consistent (authored by jpienaar).
[mlir] Make code blocks more consistent
Tue, Dec 31, 9:58 AM

Mon, Dec 30

jpienaar abandoned D41383: Rename comments to match renamed function name..
Mon, Dec 30, 1:01 PM
jpienaar accepted D71955: [mlir] Refactor operation results to use a single use list for all results of the operation..

Looks good as part of optimizing the size, thanks

Mon, Dec 30, 12:51 PM · Restricted Project
jpienaar accepted D72013: [mlir][Linalg] Delete unused LinalgLibraryOps.td - NFC.
Mon, Dec 30, 12:51 PM · Restricted Project

Fri, Dec 27

jpienaar accepted D71949: [mlir] Merge the successor operand count into BlockOperand..
Fri, Dec 27, 8:36 PM · Restricted Project

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rGb6d54a1ba3f7: Unique trait list during ODS Operator trait construction (authored by jpienaar).
Unique trait list during ODS Operator trait construction
Dec 23 2019, 9:26 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGd7e2cc9bd1d1: Update code block designations (authored by jpienaar).
Update code block designations
Dec 23 2019, 9:25 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGabcf5ff0cc68: Fix line break in LangRef (authored by jpienaar).
Fix line break in LangRef
Dec 23 2019, 9:25 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGa50cb184a0c5: Fix logic on when to emit collective type but separate arg builder (authored by jpienaar).
Fix logic on when to emit collective type but separate arg builder
Dec 23 2019, 9:23 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG41a73ddce892: Add type inference variant for separate params builder generated (authored by jpienaar).
Add type inference variant for separate params builder generated
Dec 23 2019, 9:23 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGacb23ff48d95: Fix build breakage on gcc-5 (authored by jpienaar).
Fix build breakage on gcc-5
Dec 23 2019, 9:21 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG89cef725f4e0: ODS: Generate named accessors for raw attributes (authored by jpienaar).
ODS: Generate named accessors for raw attributes
Dec 23 2019, 9:21 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG70aeb4566e35: Add RegionRange for when need to abstract over different region iteration (authored by jpienaar).
Add RegionRange for when need to abstract over different region iteration
Dec 23 2019, 9:21 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG4add9edd7212: Change inferReturnTypes to return LogicalResult and values (authored by jpienaar).
Change inferReturnTypes to return LogicalResult and values
Dec 23 2019, 9:20 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG398f04aa4910: Generate builder for ops that use InferTypeOpInterface trait in ODS (authored by jpienaar).
Generate builder for ops that use InferTypeOpInterface trait in ODS
Dec 23 2019, 9:20 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG2235333d5878: mlir-tblgen: Dump input records when no generator is set (authored by jpienaar).
mlir-tblgen: Dump input records when no generator is set
Dec 23 2019, 9:18 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG52a74151787a: Fix redundant convert and use NamedAttributeList as value (authored by jpienaar).
Fix redundant convert and use NamedAttributeList as value
Dec 23 2019, 9:18 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGf27ceb726188: Add create method that takes equivalent of OperationState with… (authored by jpienaar).
Add create method that takes equivalent of OperationState with…
Dec 23 2019, 9:17 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG8ec002cbec1a: Fix mismatched-tags warning (authored by jpienaar).
Fix mismatched-tags warning
Dec 23 2019, 9:15 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGb9fa45864dea: Use simpler highlighting textmate syntax (authored by jpienaar).
Use simpler highlighting textmate syntax
Dec 23 2019, 9:15 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGd1c99e10d055: Do not emit aliases when printing local form (authored by jpienaar).
Do not emit aliases when printing local form
Dec 23 2019, 9:14 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGa6fac0aa29a9: Update textmate syntax file (authored by jpienaar).
Update textmate syntax file
Dec 23 2019, 9:14 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGbcfb3d4cd6de: Explicitly initialize isRecursivelyLegal (authored by jpienaar).
Explicitly initialize isRecursivelyLegal
Dec 23 2019, 9:13 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG7af61f6bcd4f: Add compatible query method to infer type interface (authored by jpienaar).
Add compatible query method to infer type interface
Dec 23 2019, 9:13 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG8317bd85e5cc: Add SourceMgrDiagnosticHandler to toy (authored by jpienaar).
Add SourceMgrDiagnosticHandler to toy
Dec 23 2019, 9:10 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG305dafd3b1b0: Add missing include to StringMap in Verifier and DialectConversion. (authored by jpienaar).
Add missing include to StringMap in Verifier and DialectConversion.
Dec 23 2019, 9:10 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGf9462da56957: Slight rewording in toy ch2 to make persistence of name clearer (authored by jpienaar).
Slight rewording in toy ch2 to make persistence of name clearer
Dec 23 2019, 9:10 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGe88dbc8c955a: Update comments in ast.toy (authored by jpienaar).
Update comments in ast.toy
Dec 23 2019, 9:09 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGf16e89f841c1: Fix typos in InferTypeOpInterface. (authored by jpienaar).
Fix typos in InferTypeOpInterface.
Dec 23 2019, 9:08 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG4e85dafeddc1: Fix typos in LangRef and OpDefinitions (authored by jpienaar).
Fix typos in LangRef and OpDefinitions
Dec 23 2019, 9:08 PM
jpienaar committed rG08a2ce8a1407: Standard-to-LLVM conversion: check that operands have LLVM types (authored by Alex Zinenko <zinenko@google.com>).
Standard-to-LLVM conversion: check that operands have LLVM types
Dec 23 2019, 9:07 PM
jpienaar committed rG4dde19f02473: Translation to LLVM: check the validity of module-level Ops (authored by Alex Zinenko <zinenko@google.com>).
Translation to LLVM: check the validity of module-level Ops
Dec 23 2019, 9:07 PM
jpienaar committed rG28d7f9c052c8: Add lowering of constant ops to SPIR-V. (authored by mravishankar).
Add lowering of constant ops to SPIR-V.
Dec 23 2019, 9:07 PM
jpienaar committed rG736f80d0ddd8: Add trait for specified shapes matching (authored by Geoffrey Martin-Noble <gcmn@google.com>).
Add trait for specified shapes matching
Dec 23 2019, 9:07 PM
jpienaar committed rG6b1cc3c6eac0: Add support for canonicalizing callable regions during inlining. (authored by rriddle).
Add support for canonicalizing callable regions during inlining.
Dec 23 2019, 9:07 PM
jpienaar committed rG438dc176b14d: Remove the need to convert operations in regions of operations that have been… (authored by rriddle).
Remove the need to convert operations in regions of operations that have been…
Dec 23 2019, 9:07 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG27e8efedf868: Add DialectType and generate docs for dialect types (authored by jpienaar).
Add DialectType and generate docs for dialect types
Dec 23 2019, 9:05 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG77672c9777a1: Enable emitting dialect summary & description during op generation (authored by jpienaar).
Enable emitting dialect summary & description during op generation
Dec 23 2019, 9:05 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG2b86e27dbd82: Show type even if elementsattr is elided in graph (authored by jpienaar).
Show type even if elementsattr is elided in graph
Dec 23 2019, 9:04 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGf015b020f3dc: Add missing file from cmakelist (authored by jpienaar).
Add missing file from cmakelist
Dec 23 2019, 9:02 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG0b81eb928b38: Enable autogenerating OpInterface method declarations (authored by jpienaar).
Enable autogenerating OpInterface method declarations
Dec 23 2019, 9:02 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGa932f0786c25: Use MaybeAlign when setting alignment (authored by jpienaar).
Use MaybeAlign when setting alignment
Dec 23 2019, 9:01 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGe5a43186d38c: Add InferTypeOpTrait & enable generating its member function definition (authored by jpienaar).
Add InferTypeOpTrait & enable generating its member function definition
Dec 23 2019, 9:01 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGc57f202c8cbb: Switch explicit create methods to match generated build's order (authored by jpienaar).
Switch explicit create methods to match generated build's order
Dec 23 2019, 9:00 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG7385d8789560: Disable failing tests (authored by jpienaar).
Disable failing tests
Dec 23 2019, 8:59 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG19841775d4c1: Make result ops generated output deterministic (authored by jpienaar).
Make result ops generated output deterministic
Dec 23 2019, 8:59 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG3848baec69e3: Emit function name being tested in TestMemRefStrideCalculation (authored by jpienaar).
Emit function name being tested in TestMemRefStrideCalculation
Dec 23 2019, 8:58 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG4a862fbd6337: Use constant's location for reporting errors in parsing of hex constant (authored by jpienaar).
Use constant's location for reporting errors in parsing of hex constant
Dec 23 2019, 8:56 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG59e3b30af053: Add variants of interleave that take separator (authored by jpienaar).
Add variants of interleave that take separator
Dec 23 2019, 8:55 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG5002e98b92bb: Remove unused import and two import forms (authored by jpienaar).
Remove unused import and two import forms
Dec 23 2019, 8:54 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG277b6136ee78: Remove unused variable (authored by jpienaar).
Remove unused variable
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGa23f69a37b33: Remove redundant qualification (authored by jpienaar).
Remove redundant qualification
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGaf27f4c74665: Avoid sign-compare warning (authored by jpienaar).
Avoid sign-compare warning
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG2660623a88d1: Add pass generate per block in a function a GraphViz Dot graph with ops as nodes (authored by jpienaar).
Add pass generate per block in a function a GraphViz Dot graph with ops as nodes
Dec 23 2019, 8:52 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG636bcbade07d: Make isIsolatedAbove robuster to invalid IR (authored by jpienaar).
Make isIsolatedAbove robuster to invalid IR
Dec 23 2019, 8:51 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG06e8101034e7: Add mechanism to dump JIT-compiled objects to files (authored by jpienaar).
Add mechanism to dump JIT-compiled objects to files
Dec 23 2019, 8:50 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGa085700311ce: Make dumping using generic form more robust when IR ill-formed (authored by jpienaar).
Make dumping using generic form more robust when IR ill-formed
Dec 23 2019, 8:50 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG0c7f3f7108de: Split out parsing location into separate functions per instance (authored by jpienaar).
Split out parsing location into separate functions per instance
Dec 23 2019, 8:49 PM