User Details
- User Since
- Aug 20 2014, 6:06 PM (405 w, 2 d)
Yesterday
Thu, May 26
Could you sync post https://github.com/llvm/llvm-project/commit/ad1d60c3befd606d6864b367f939238e50fb0f7e ?
Wed, May 25
A followup will work on plumbing more locations through
tablegen, which should greatly improve what we can do here.
Nice thanks
Nice (which reminds me I need to update the injection in another spot post https://github.com/llvm/llvm-project/commit/999fb7d0450a804f3eb0d16d2853e8667658f39e)
Tue, May 24
Not sure I follow why c-style is requirement? E.g., copyright in Python files is close to // per line
LGTM (and yay for usage of LITERAL ;-))
Mon, May 23
Wed, May 18
LG, thanks
Looks good/we can refine in follow ups, thanks!
Mon, May 16
(first sweep, mostly looks good, just some clarifications)
Sun, May 15
I'll let the argument about the location of this slide as I know you'll follow up ;-)
Good point about potentially expensive operations here, I wonder: why is/was this a canonicalization pattern rather than fold implementation?
Thanks, and yes with Marius 's change for doc includes (couple months back :-)) there isn't really reason to have multiple be generated website side. Being explicit here is better.
Fri, May 13
Thu, May 12
LGTM, could you add a before and after screenshot of a test? (Just for easy visual check)
Tue, May 10
(1) the operands defined by non-constant-like ops come first, followed by (2) block arguments, and these are followed by (3) the operands defined by constant-like ops.
Sat, May 7
I agree on breaking at once, too many breaking changes one after the other is painful (looking at JAX team needing to bump API number for small changes makes me feel bad). Perhaps we could roll https://gist.github.com/jpienaar/9d22b710db6122a9a41e8cd3d824a39e or something like it in here too (also breaking change but orthogonal to this one, but in similar spirit). Ripping off bandaid should result in one larger change but enable less breaking changes post. I do have preference for consistency with ODS and C++ here (it may also result in less breakages but that's not the reason why I prefer it). It puts convenience and usability in the hand of dialect authors. Now the signature can change if one changes the op def, but merely appending optional/default value attribute would not. But I might not be a "pythonic" person :-)
Tue, May 3
(I'm OOO, but randomly checking so my latency will be high)
Fri, Apr 29
Nice, thanks!
Makes sense to have some marker here, its a hole in the type description SGTM
Thu, Apr 28
Apr 28 2022
Apr 27 2022
Nice!
Nice, thanks
Quite a lot of red :-)
Thanks!
Apr 25 2022
(was using the wrong formatter)
Apr 24 2022
Nice, thanks!
Could we add simple smoke test for -d output? (Not golden of course)
Apr 22 2022
Apr 21 2022
Nice, thanks (I need to remove the hard coding on SameElement... there but that's not related here directly)
Conceptually Module had func as default dialect before too but having Builtin know of Func feels weird, so LGTM.
Apr 20 2022
Apr 19 2022
Apr 18 2022
Apr 17 2022
Nice, good point about the change to dump for invalid IR, this seems to provide the functionality of the previous change without needing a flag/API change and producing the prettier output in more cases. Of course the discussion still ongoing but looks like general improvement.
Apr 16 2022
The cost of getting custom format output from generic output dump is rerunning through opt tool, the cost of crash is rerunning program (which can take multiple hours and take a lot of compute resources). I'd much rather it be uniform and safe and avoid needing flag plumbed through.
Apr 15 2022
Thanks
Apr 14 2022
Apr 13 2022
Apr 11 2022
Apr 10 2022
Nice :-)
Apr 9 2022
SG, thanks for the explanation
Apr 8 2022
Apr 7 2022
Thanks! (I was going to start with doc update, but that requires coffee :-))
Apr 6 2022
I might even suggest the error emission from not finding LSP should be logged (flagged in some way) rather than popup given the extension is the combination of LSP & syntax highlighting. And I'm reading these files more than I traverse via LSP assistance, so in fresh client/machine without lsp built the extension is still useful and the missing LSP warning interrupts my flow before I even tried to use any LSP functionality (and I may not need any at all). But that's just a nit.
Apr 5 2022
Nice, thanks that SGTM
Apr 4 2022
Apr 3 2022
Improved Inclusivity to make it beginner-friendly
Apr 1 2022
You should be able to test this with a module with an arith.constant
Mar 31 2022
LG, I'm just not sure how much the optionality/null is getting you here vs extra paths created.
Mar 30 2022
Mar 29 2022
Nice, this was a pain point for folks diff'ing across passes, thanks!