Page MenuHomePhabricator

jpienaar (Jacques Pienaar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 6:06 PM (322 w, 1 d)

Recent Activity

Yesterday

jpienaar accepted D89967: [mlir] Do not start threads in AsyncRuntime.

Thanks

Thu, Oct 22, 8:26 AM · Unknown Object (Project)
jpienaar added a comment to D89292: [mlir] Convert from Async dialect to LLVM coroutines.

This seems to have broken the build https://buildkite.com/mlir/mlir-core/builds/8787#c1ee666b-58ff-4f6e-816e-2ba4996fa2ee

Thu, Oct 22, 7:36 AM · Unknown Object (Project)

Wed, Oct 21

jpienaar added a comment to D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.

An extra failure case for line 1189 would be nice to have.

Yeah, we should also add -verify-diagnostics to Tablegen.

I don't think that works as easily: most error reporting via print fatal error here, this is different from the opt tool where error is returned and propagated up, so we can verify in the driver. I think only think verify brings additionally is to flag unexpected errors, that FileCheck won't. Is there anything else?

Splitting the input file into chunks without having to have as many RUN lines as the file has different checks.

Wed, Oct 21, 7:38 AM · Unknown Object (Project)
jpienaar added a comment to D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.

An extra failure case for line 1189 would be nice to have.

Yeah, we should also add -verify-diagnostics to Tablegen.

Wed, Oct 21, 6:45 AM · Unknown Object (Project)

Tue, Oct 20

jpienaar accepted D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.

Looks good, thanks! An extra failure case for line 1189 would be nice to have.

Tue, Oct 20, 5:38 PM · Unknown Object (Project)
jpienaar accepted D89660: [mlir][SymbolTable] Use Identifier instead of StringRef when looking up symbol name attributes.

Nice, thanks

Tue, Oct 20, 4:31 PM · Unknown Object (Project)
jpienaar added inline comments to D89833: [mlir][shape] Split out structural type conversions for shape dialect..
Tue, Oct 20, 4:30 PM · Unknown Object (Project)

Mon, Oct 19

jpienaar accepted D89103: [mlir][NFC] Move around the code related to PatternRewriting to improve layering.
Mon, Oct 19, 8:57 PM · Unknown Object (Project)
jpienaar added a comment to D89756: Relax the restriction that parsed arguments must match op arguments in ODS..

Could you please update the documentation and description of the change?

Mon, Oct 19, 5:31 PM · Unknown Object (Project)
jpienaar accepted D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

Nice, thanks!

Mon, Oct 19, 2:53 PM · Unknown Object (Project)
jpienaar added inline comments to D89659: [mlir][StorageUniquer] Refactor parametric storage to use sharded dense sets.
Mon, Oct 19, 2:44 PM · Unknown Object (Project)
jpienaar accepted D84580: [mlir] Add a conversion pass between PDL and the PDL Interpreter Dialect.

Looks good - this is little bit of a big review, but I also don't have an idea of how to make it smaller easily. Given the work following on this & verification wrt existing, I feel a little bit more comfortable.

Mon, Oct 19, 12:34 PM · Unknown Object (Project)

Fri, Oct 16

jpienaar accepted D89604: [mlir] Add canonicalization for cond_br that feed into a cond_br on the same condition.

Nice, micro nit: in description add ... as when I initially read it I thought there was requirement for empty block bb1

Fri, Oct 16, 7:35 PM · Unknown Object (Project)
jpienaar added a comment to D89601: Add an mlir natvis file for debugging with Visual Studio.

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Fri, Oct 16, 6:48 PM · Unknown Object (Project)
jpienaar added a comment to D89601: Add an mlir natvis file for debugging with Visual Studio.

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

Fri, Oct 16, 5:24 PM · Unknown Object (Project)
jpienaar added a comment to D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

Nice

Fri, Oct 16, 4:16 PM · Unknown Object (Project)
jpienaar accepted D89593: [mlir] Failure when const matcher fails, added a test to catch.

Woops, I missed this asking for this test. Thanks

Fri, Oct 16, 3:01 PM · Unknown Object (Project)
jpienaar accepted D89522: [mlir] Update SCCP and the Inliner to use SymbolTableCollection for symbol lookups.
Fri, Oct 16, 11:48 AM · Unknown Object (Project)
jpienaar accepted D89504: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..

Thanks!

Fri, Oct 16, 11:46 AM · Unknown Object (Project)

Thu, Oct 15

jpienaar accepted D89505: [mlir] Optimize symbol related checks in SymbolDCE.
Thu, Oct 15, 5:00 PM · Unknown Object (Project)
jpienaar accepted D89512: [mlir] Add a new SymbolUserOpInterface class.
Thu, Oct 15, 4:59 PM · Unknown Object (Project)
jpienaar accepted D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

Looks good thanks!

Thu, Oct 15, 1:18 PM · Unknown Object (Project)
jpienaar added a comment to D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.

Nice - well I think this means I can stop migrating the other OpBuilder usage as these will be migrated again :)

Thu, Oct 15, 8:17 AM · Unknown Object (Project)

Wed, Oct 14

jpienaar committed rG008c0ea6a411: [DDR] Introduce implicit equality check for the source pattern operands with… (authored by rdzhabarov).
[DDR] Introduce implicit equality check for the source pattern operands with…
Wed, Oct 14, 11:05 AM
jpienaar closed D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Wed, Oct 14, 11:05 AM · Unknown Object (Project)
jpienaar committed rGf4ad76deb8a7: [mlir] More changes to avoid args now inserted.NFC (authored by jpienaar).
[mlir] More changes to avoid args now inserted.NFC
Wed, Oct 14, 10:48 AM
jpienaar added inline comments to D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.
Wed, Oct 14, 8:21 AM · Unknown Object (Project)
jpienaar added a comment to D89354: [mlir][ASM] Refactor how attribute/type aliases are specified..

Looks good overall

Wed, Oct 14, 8:17 AM · Unknown Object (Project)

Tue, Oct 13

jpienaar committed rG7271c1bcb960: [DDR] Introduce implicit equality check for the source pattern operands with… (authored by rdzhabarov).
[DDR] Introduce implicit equality check for the source pattern operands with…
Tue, Oct 13, 4:17 PM
jpienaar closed D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Tue, Oct 13, 4:17 PM · Unknown Object (Project)
jpienaar accepted D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Looks good, thanks

Tue, Oct 13, 2:41 PM · Unknown Object (Project)
jpienaar added inline comments to D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.
Tue, Oct 13, 2:34 PM · Unknown Object (Project)

Mon, Oct 12

jpienaar added a comment to D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

I think you may need to rebase this on head, seems like you were working of an old version here.

Mon, Oct 12, 1:33 PM · Unknown Object (Project)
jpienaar added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Nice, thanks

Mon, Oct 12, 1:18 PM · Unknown Object (Project)

Fri, Oct 9

jpienaar added a comment to D89169: [mlir, win] Mark several MLRI tests as unsupported on system-windows.

Thanks

Fri, Oct 9, 5:03 PM · Unknown Object (Project)

Thu, Oct 8

jpienaar accepted D89014: Give attributes C++ namespaces..
Thu, Oct 8, 10:01 AM · Unknown Object (Project)

Wed, Oct 7

jpienaar added inline comments to D84580: [mlir] Add a conversion pass between PDL and the PDL Interpreter Dialect.
Wed, Oct 7, 11:02 AM · Unknown Object (Project)
jpienaar added a comment to D88943: Fix build warning for uint64_t.

The pre-merge differs here - if you want to appease both you'd probably need to use PRIu64 (https://en.cppreference.com/w/c/types/integer) it seems

Wed, Oct 7, 8:57 AM · Unknown Object (Project)

Tue, Oct 6

jpienaar added a comment to D84107: Add indented raw_ostream class.

Also, this seems like something that would go into llvm/Support and not mlir/Support.

Tue, Oct 6, 8:19 AM · Unknown Object (Project)

Mon, Oct 5

jpienaar added inline comments to D88809: [MLIR] Add a foldTrait() mechanism to allow traits to define folding and test it with an Involution trait.
Mon, Oct 5, 10:22 AM · Unknown Object (Project)
jpienaar added inline comments to D88696: [mlir] Split alloc-like op LLVM lowerings into base and separate derived classes..
Mon, Oct 5, 9:40 AM · Unknown Object (Project)

Sat, Oct 3

jpienaar added a reverting change for rGbe185b6a7355: Revert "Add indented raw_ostream class": rG9b851527d533: Add indented raw_ostream class.
Sat, Oct 3, 3:18 PM
jpienaar committed rG9b851527d533: Add indented raw_ostream class (authored by jpienaar).
Add indented raw_ostream class
Sat, Oct 3, 3:18 PM
jpienaar added a reverting change for rG78530ce65375: Add indented raw_ostream class: rGbe185b6a7355: Revert "Add indented raw_ostream class".
Sat, Oct 3, 9:42 AM
jpienaar committed rGbe185b6a7355: Revert "Add indented raw_ostream class" (authored by jpienaar).
Revert "Add indented raw_ostream class"
Sat, Oct 3, 9:42 AM
jpienaar added a reverting change for D84107: Add indented raw_ostream class: rGbe185b6a7355: Revert "Add indented raw_ostream class".
Sat, Oct 3, 9:42 AM · Unknown Object (Project)
jpienaar committed rG78530ce65375: Add indented raw_ostream class (authored by jpienaar).
Add indented raw_ostream class
Sat, Oct 3, 8:54 AM
jpienaar closed D84107: Add indented raw_ostream class.
Sat, Oct 3, 8:54 AM · Unknown Object (Project)
jpienaar updated the diff for D84107: Add indented raw_ostream class.

Addressed typos and used more similar naming to ScopedPrinter

Sat, Oct 3, 8:53 AM · Unknown Object (Project)

Fri, Oct 2

jpienaar added a comment to D88657: [mlir] Add subtensor_insert operation.

This seems to have broken GCC 5 (https://buildkite.com/mlir/mlir-core/builds/8301#e6b6e5a7-85bd-4454-ae2b-da3b6cf84b8a). Could you update? Or should we revert?

Fri, Oct 2, 7:49 AM · Unknown Object (Project)
jpienaar added a comment to D84580: [mlir] Add a conversion pass between PDL and the PDL Interpreter Dialect.

First partial scan (sorry forgot to hit send on this earlier)

Fri, Oct 2, 7:46 AM · Unknown Object (Project)

Wed, Sep 30

jpienaar added a comment to D88530: Remove `Ops` suffix from dialect library names.

I just got tripped up by the opacity of this today in npcomp. Thanks for making it more explicit. May want to give it a bit for others to respond.

Wed, Sep 30, 6:36 AM · Unknown Object (Project)

Tue, Sep 29

jpienaar committed rG4f0e0d92178d: [mlir] Remove more OpBuilder args which are now injected (authored by jpienaar).
[mlir] Remove more OpBuilder args which are now injected
Tue, Sep 29, 4:48 PM
jpienaar accepted D87159: Add GDB prettyprinters for a few more MLIR types..

Thanks for doing this!

Tue, Sep 29, 7:46 AM · Unknown Object (Project)

Mon, Sep 28

jpienaar added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

There is also just returning an error too (it's not just a fatal error or
assert dichotomy here).

Mon, Sep 28, 7:07 PM · Unknown Object (Project)

Sat, Sep 26

jpienaar committed rG584d91925eb1: [mlir] Fix capitalization typo (authored by jpienaar).
[mlir] Fix capitalization typo
Sat, Sep 26, 9:20 AM
jpienaar committed rG57b871f8eca5: [mlir] Updates to generate dialect rather than op docs (authored by jpienaar).
[mlir] Updates to generate dialect rather than op docs
Sat, Sep 26, 9:03 AM
jpienaar committed rG93628ea9d162: [mlir] Fix passes.md's naming & add missing (authored by jpienaar).
[mlir] Fix passes.md's naming & add missing
Sat, Sep 26, 8:48 AM

Wed, Sep 23

jpienaar committed rG501d7e07e31d: [mlir] Remove unneeded OpBuilder params. NFC. (authored by jpienaar).
[mlir] Remove unneeded OpBuilder params. NFC.
Wed, Sep 23, 8:12 AM
jpienaar committed rG80deb1e106a8: [mlir][ods] Custom builder with no params (authored by jpienaar).
[mlir][ods] Custom builder with no params
Wed, Sep 23, 8:12 AM

Sep 22 2020

jpienaar added a comment to D88036: Version 0.5 of the "TableGen Backend Developer's Guide".

Indeed, thanks this is super nice (I missed the ping here but saw the commit on GitHub and pointed folks to it)

Sep 22 2020, 5:03 PM · Unknown Object (Project), Restricted Project
jpienaar committed rG2a6db92ca97d: [mlir][ods] Make OpBuilder and OperationState optional (authored by jpienaar).
[mlir][ods] Make OpBuilder and OperationState optional
Sep 22 2020, 10:04 AM
jpienaar closed D88050: [mlir][ods] Make OpBuilder and OperationState optional.
Sep 22 2020, 10:04 AM · Unknown Object (Project)
jpienaar added inline comments to D87941: [mlir][shape] Start a pass that lowers shape constraints..
Sep 22 2020, 7:28 AM · Unknown Object (Project)
jpienaar accepted D88040: [mlir] NFC: fix trivial typos under include directory.

Thanks, LG with Rahul's comments addressed.

Sep 22 2020, 6:09 AM · Unknown Object (Project)
jpienaar added inline comments to D88091: [MLIR][Standard] Add `atan` to standard dialect.
Sep 22 2020, 6:07 AM · Unknown Object (Project)

Sep 21 2020

jpienaar committed rG3a799deed729: [mlir] Add tutorial index.md pages (authored by jpienaar).
[mlir] Add tutorial index.md pages
Sep 21 2020, 3:51 PM
jpienaar closed D87969: [mlir] Add tutorial index.md pages.
Sep 21 2020, 3:51 PM · Unknown Object (Project)
jpienaar accepted D82628: [MLIR][Shape] Add `shape.size_eq` to the shape dialect.

LG, modulo I think the error discussion on the shape_eq one wasn't updated there or used here. But we can do those as uniform follow up too.

Sep 21 2020, 3:44 PM · Unknown Object (Project)
jpienaar requested review of D88050: [mlir][ods] Make OpBuilder and OperationState optional.
Sep 21 2020, 3:12 PM · Unknown Object (Project)
jpienaar added inline comments to D87926: [MLIR] Fix default builders generated by TableGen to use TypeRange for result types.
Sep 21 2020, 2:08 PM · Unknown Object (Project)
jpienaar accepted D87944: [MLIR][NFC] Adopt use of TypeRange in build() methods..
Sep 21 2020, 10:14 AM · Unknown Object (Project)
jpienaar accepted D87926: [MLIR] Fix default builders generated by TableGen to use TypeRange for result types.

Lets just focus on "Change the default builders to use TypeRange instead of ArrayRef<Type>" part as one change rather than having 2 unrelated changes in one. That part LGTM to, the other I'd prefer a follow up discussion.

Sep 21 2020, 10:13 AM · Unknown Object (Project)

Sep 19 2020

jpienaar requested review of D87969: [mlir] Add tutorial index.md pages.
Sep 19 2020, 10:30 AM · Unknown Object (Project)

Sep 17 2020

jpienaar accepted D87872: [MLIR] Fix build failure due to https://reviews.llvm.org/D87059..
Sep 17 2020, 4:53 PM · Unknown Object (Project)
jpienaar accepted D87871: [mlir][shape] Add `shape.cstr_require %bool`.

Thanks, I am tempted to suggest we add "use this only if more specific form is not available" (e.g., use this for cases not expressible with the others). So that we push to simpler forms.

Sep 17 2020, 4:34 PM · Unknown Object (Project)
jpienaar updated the summary of D87871: [mlir][shape] Add `shape.cstr_require %bool`.
Sep 17 2020, 4:29 PM · Unknown Object (Project)
jpienaar accepted D87059: [MLIR][TableGen] Automatic detection and elimination of redundant methods.

LG, thanks

Sep 17 2020, 1:57 PM · Unknown Object (Project)

Sep 15 2020

jpienaar added a comment to D87059: [MLIR][TableGen] Automatic detection and elimination of redundant methods.

Nice, looks like good reduction

Sep 15 2020, 8:33 AM · Unknown Object (Project)
jpienaar added inline comments to D87696: [mlir][Standard] Canonicalize chains of tensor_cast operations.
Sep 15 2020, 8:08 AM · Unknown Object (Project)

Sep 11 2020

jpienaar added a comment to D87492: [mlir] Fix some edge cases around 0-element TensorFromElementsOp.

The SameOperandsAndResultElementType is redundant with the new

TypesMatchWith and prevented having zero elements.

Sep 11 2020, 6:16 AM · Unknown Object (Project)

Sep 5 2020

jpienaar accepted D87060: [mlir][Toy] Update the tutorial to use tablegen for dialect declarations.
Sep 5 2020, 9:21 AM · Unknown Object (Project)

Sep 4 2020

jpienaar accepted D87131: [mlir] Refactor standalone-translate to use mlirTranslateMain().

Thanks!

Sep 4 2020, 5:59 AM · Unknown Object (Project)
jpienaar accepted D87129: [mlir] Fix includes in mlir-translate.
Sep 4 2020, 5:57 AM · Unknown Object (Project)

Sep 1 2020

jpienaar requested changes to D86935: [MLIR][Shape] Lower `shape_of` to `dynamic_tensor_from_elements`.
Sep 1 2020, 9:32 AM · Unknown Object (Project)

Aug 31 2020

jpienaar accepted D86897: Fix mlir-reduce to explicitly register dialects and disable the global dialect registry by default.
Aug 31 2020, 3:52 PM · Unknown Object (Project)
jpienaar added a comment to D86760: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly format.

Nice, thanks

Aug 31 2020, 11:58 AM · Unknown Object (Project)
jpienaar accepted D86830: [mlir][PDL] Move the formats for PatternOp and RewriteOp to the declarative form..
Aug 31 2020, 11:57 AM · Unknown Object (Project)

Aug 28 2020

jpienaar accepted D86683: Add Location, Region and Block to MLIR Python bindings..

Looks good, thanks

Aug 28 2020, 2:48 PM · Unknown Object (Project)

Aug 27 2020

jpienaar accepted D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..

Thanks!

Aug 27 2020, 8:11 PM · Unknown Object (Project)
jpienaar accepted D86755: Add a global flag to disable the global dialect registry "process wise".
Aug 27 2020, 7:57 PM · Unknown Object (Project)

Aug 26 2020

jpienaar accepted D86606: [MLIR][Shape] Fix typo.

Thanks

Aug 26 2020, 7:35 PM · Unknown Object (Project)

Aug 22 2020

jpienaar updated the summary of D86392: Implement a new kind of Pass: dynamic pass pipeline.
Aug 22 2020, 9:46 AM · Unknown Object (Project)
jpienaar added a comment to D86250: Add initial python bindings for attributes..

Nice

Aug 22 2020, 9:44 AM · Unknown Object (Project)
jpienaar added a comment to D86385: Use the named accessor methods in predicate substitutions..

Nice, thanks. Could you add a test with an optional attr that would have failed here before?

Aug 22 2020, 9:31 AM · Unknown Object (Project)

Aug 20 2020

jpienaar accepted D85591: Refactor Reduction Tree Pass.

Nice thanks, LG with comments addressed

Aug 20 2020, 4:58 PM · Unknown Object (Project)

Aug 18 2020

jpienaar accepted D84783: Create Opt Reduction Pass.

Nice, thanks

Aug 18 2020, 8:20 AM · Unknown Object (Project)
jpienaar accepted D86121: [mlir] Remove the use of "kinds" from Attributes and Types.
Aug 18 2020, 6:28 AM · Unknown Object (Project)

Aug 17 2020

jpienaar added inline comments to D84783: Create Opt Reduction Pass.
Aug 17 2020, 8:42 AM · Unknown Object (Project)

Aug 15 2020

jpienaar accepted D86023: Refactor mlir-opt setup in a new helper function (NFC).

LGTM if towards removing static registration

Aug 15 2020, 12:47 PM · Restricted Project