Page MenuHomePhabricator

jpienaar (Jacques Pienaar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 6:06 PM (405 w, 2 d)

Recent Activity

Yesterday

jpienaar added inline comments to D126545: [mlir][TableGen][NFC] Compact OpBase description.
Fri, May 27, 8:06 AM · Restricted Project, Restricted Project

Thu, May 26

jpienaar added a comment to D126504: Summary: [mlir] Fix the misspellings of CHECK-* directives..

Could you sync post https://github.com/llvm/llvm-project/commit/ad1d60c3befd606d6864b367f939238e50fb0f7e ?

Thu, May 26, 3:17 PM · Restricted Project, Restricted Project

Wed, May 25

jpienaar accepted D125443: [mlir][Tablegen-LSP] Add support for a tracking definitions and references.

A followup will work on plumbing more locations through

tablegen, which should greatly improve what we can do here.

Wed, May 25, 10:49 AM · Restricted Project, Restricted Project
jpienaar accepted D125442: [mlir][Tablegen-LSP] Add support for include file link and hover.
Wed, May 25, 10:46 AM · Restricted Project, Restricted Project
jpienaar accepted D125441: [mlir][Tablegen-LSP] Add support for a compilation database.

Nice thanks

Wed, May 25, 10:44 AM · Restricted Project, Restricted Project
jpienaar accepted D125734: [mlir-vscode] Add support for highlighting pdll and tablegen markdown code blocks.

Nice (which reminds me I need to update the injection in another spot post https://github.com/llvm/llvm-project/commit/999fb7d0450a804f3eb0d16d2853e8667658f39e)

Wed, May 25, 10:00 AM · Restricted Project, Restricted Project
jpienaar added inline comments to D126161: [mlir][LLVM] Add support for Calling Convention in LLVMFuncOp.
Wed, May 25, 6:26 AM · Restricted Project, Restricted Project

Tue, May 24

jpienaar requested review of D126352: [mlir][ods] Add base class for simple types.
Tue, May 24, 9:36 PM · Restricted Project, Restricted Project
jpienaar added a comment to D126315: [mlir][PDLL] Add support for c-style comment.

Not sure I follow why c-style is requirement? E.g., copyright in Python files is close to // per line

Tue, May 24, 12:16 PM · Restricted Project, Restricted Project
jpienaar accepted D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

LGTM (and yay for usage of LITERAL ;-))

Tue, May 24, 11:01 AM · Restricted Project, Restricted Project

Mon, May 23

jpienaar requested review of D126238: [mlir][python] Move results types to keyword-only arg..
Mon, May 23, 1:41 PM · Restricted Project, Restricted Project

Wed, May 18

jpienaar accepted D125852: [mlir][python] Add Python bindings for ml_program dialect..

LG, thanks

Wed, May 18, 4:23 AM · Restricted Project, Restricted Project
jpienaar accepted D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..

Looks good/we can refine in follow ups, thanks!

Wed, May 18, 4:15 AM · Restricted Project, Restricted Project

Mon, May 16

jpienaar added a comment to D124782: [mlir:PDLL] Add proper support for operation result type inference.

(first sweep, mostly looks good, just some clarifications)

Mon, May 16, 9:46 AM · Restricted Project, Restricted Project
jpienaar added a comment to D125051: [mlir] Tighten the verification of SameOperandsAndResultType.

they can get the same behavior by using the SameOperandsAndResultShape and SameOperandsAndResultElementType traits.

Should SameOperandsAndResultShape be renamed CompatibleOperandsAndResultShape?

Yeah, let me do that in a followup.

Mon, May 16, 9:15 AM · Restricted Project, Restricted Project

Sun, May 15

jpienaar accepted D125440: [mlir][Tablegen-LSP] Add support for a basic TableGen language server.

I'll let the argument about the location of this slide as I know you'll follow up ;-)

Sun, May 15, 6:30 PM · Restricted Project, Restricted Project
jpienaar added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Good point about potentially expensive operations here, I wonder: why is/was this a canonicalization pattern rather than fold implementation?

Sun, May 15, 6:00 PM · Restricted Project, Restricted Project
jpienaar accepted D125651: [mlir] Restrict dialect doc gen to a single dialect.

Thanks, and yes with Marius 's change for doc includes (couple months back :-)) there isn't really reason to have multiple be generated website side. Being explicit here is better.

Sun, May 15, 5:43 PM · Restricted Project, Restricted Project

Fri, May 13

jpienaar accepted D125427: [TableGen] Add a new json textmate description for syntax highlighting.

FWIW, there’s a tree-sitter grammar here: https://github.com/Flakebi/tree-sitter-tablegen

Fri, May 13, 7:33 AM · Restricted Project, Restricted Project

Thu, May 12

jpienaar accepted D125458: [mlir] Significantly overhaul the textmate grammar.

LGTM, could you add a before and after screenshot of a test? (Just for easy visual check)

Thu, May 12, 3:09 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..
Thu, May 12, 12:10 PM · Restricted Project, Restricted Project

Tue, May 10

jpienaar added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

(1) the operands defined by non-constant-like ops come first, followed by (2) block arguments, and these are followed by (3) the operands defined by constant-like ops.

Tue, May 10, 8:27 AM · Restricted Project, Restricted Project, Restricted Project

Sat, May 7

jpienaar added a comment to D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.

I agree on breaking at once, too many breaking changes one after the other is painful (looking at JAX team needing to bump API number for small changes makes me feel bad). Perhaps we could roll https://gist.github.com/jpienaar/9d22b710db6122a9a41e8cd3d824a39e or something like it in here too (also breaking change but orthogonal to this one, but in similar spirit). Ripping off bandaid should result in one larger change but enable less breaking changes post. I do have preference for consistency with ODS and C++ here (it may also result in less breakages but that's not the reason why I prefer it). It puts convenience and usability in the hand of dialect authors. Now the signature can change if one changes the op def, but merely appending optional/default value attribute would not. But I might not be a "pythonic" person :-)

Sat, May 7, 12:14 PM · Restricted Project, Restricted Project

Tue, May 3

jpienaar added a comment to D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.

(I'm OOO, but randomly checking so my latency will be high)

Tue, May 3, 7:57 AM · Restricted Project, Restricted Project

Fri, Apr 29

jpienaar accepted D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..

Nice, thanks!

Fri, Apr 29, 11:57 AM · Restricted Project, Restricted Project
jpienaar accepted D124587: [mlir:PDLInterp] Refactor the implementation of result type inferrence.

Makes sense to have some marker here, its a hole in the type description SGTM

Fri, Apr 29, 7:46 AM · Restricted Project, Restricted Project

Thu, Apr 28

jpienaar committed rG9a4472c56cbb: [mlir] Add basic tree-sitter grammar file (authored by jpienaar).
[mlir] Add basic tree-sitter grammar file
Thu, Apr 28, 11:43 AM · Restricted Project, Restricted Project
jpienaar closed D124352: [mlir] Add basic tree-sitter grammar file.
Thu, Apr 28, 11:43 AM · Restricted Project, Restricted Project

Apr 28 2022

jpienaar accepted D124586: [mlir:PDLL] Fix the import of native constraints from ODS.
Apr 28 2022, 5:57 AM · Restricted Project, Restricted Project
jpienaar accepted D124585: [mlir:PDLL] Fix error handling of eof within a string literal.
Apr 28 2022, 5:55 AM · Restricted Project, Restricted Project
jpienaar accepted D124584: [mlir:LSP] Improve conversion between SourceMgr and LSP locations.
Apr 28 2022, 5:54 AM · Restricted Project, Restricted Project
jpienaar accepted D124583: [mlir:PDL] Rework errors for pdl.operations with non-inferrable results.
Apr 28 2022, 5:50 AM · Restricted Project, Restricted Project

Apr 27 2022

jpienaar accepted D124582: [mlir:PDL] Fix a syntax ambiguity in pdl.attribute.
Apr 27 2022, 5:49 PM · Restricted Project, Restricted Project
jpienaar accepted D124580: [mlir:ODS] Support using attributes in AllTypesMatch to automatically add InferTypeOpInterface.

Nice!

Apr 27 2022, 5:44 PM · Restricted Project, Restricted Project
jpienaar accepted D124581: [mlir] Attach InferTypeOpInterface on SameOperandsAndResultType operations when possible.

Nice, thanks

Apr 27 2022, 5:41 PM · Restricted Project, Restricted Project
jpienaar added a comment to D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..

Quite a lot of red :-)

Apr 27 2022, 5:36 PM · Restricted Project, Restricted Project
jpienaar accepted D124002: [mlir][emitc] Disallow !emitc.opaque pointers.

Thanks!

Apr 27 2022, 5:22 PM · Restricted Project, Restricted Project

Apr 25 2022

jpienaar updated the diff for D124352: [mlir] Add basic tree-sitter grammar file.

(was using the wrong formatter)

Apr 25 2022, 8:21 AM · Restricted Project, Restricted Project
jpienaar added inline comments to D124002: [mlir][emitc] Disallow !emitc.opaque pointers.
Apr 25 2022, 7:05 AM · Restricted Project, Restricted Project
jpienaar accepted D123514: [mlir][emitc] Add a cast op.
Apr 25 2022, 7:03 AM · Restricted Project, Restricted Project
jpienaar accepted D124112: [mlir][PDLL-LSP] Add code completion for include file paths.
Apr 25 2022, 6:53 AM · Restricted Project, Restricted Project

Apr 24 2022

jpienaar requested review of D124352: [mlir] Add basic tree-sitter grammar file.
Apr 24 2022, 3:29 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D124112: [mlir][PDLL-LSP] Add code completion for include file paths.
Apr 24 2022, 1:09 PM · Restricted Project, Restricted Project
jpienaar accepted D124076: [mlir][PDLL] Add initial support for a PDLL compilation database.

Nice, thanks!

Apr 24 2022, 1:07 PM · Restricted Project, Restricted Project
jpienaar accepted D124075: [mlir][PDLL] Add support for generating PDL patterns from PDLL at build time.

Could we add simple smoke test for -d output? (Not golden of course)

Apr 24 2022, 11:49 AM · Restricted Project, Restricted Project
jpienaar accepted D124074: [mlir][PDLL] Don't use the result of `Constraint::getDefName()` when uniquing.
Apr 24 2022, 11:42 AM · Restricted Project, Restricted Project
jpienaar added inline comments to D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..
Apr 24 2022, 8:48 AM · Restricted Project, Restricted Project

Apr 22 2022

jpienaar committed rG9bae20b52822: [mlir] Add shape.func (authored by jpienaar).
[mlir] Add shape.func
Apr 22 2022, 11:37 AM · Restricted Project, Restricted Project
jpienaar closed D124055: [mlir] Add shape.func.
Apr 22 2022, 11:37 AM · Restricted Project, Restricted Project

Apr 21 2022

jpienaar accepted D124043: [mlir][tblgen] Generate builders with inferred return types and unwrapped attributes.

Nice, thanks (I need to remove the hard coding on SameElement... there but that's not related here directly)

Apr 21 2022, 4:46 PM · Restricted Project, Restricted Project
jpienaar added a comment to D121279: [MLIR][GPU] Add canonicalizer for gpu.memcpy.

Can you please provide the test case for which incorrect IR is generated?
I will provide the fix. Thanks in advance.

Apr 21 2022, 9:07 AM · Restricted Project, Restricted Project
jpienaar accepted D124146: [mlir] Remove special case parsing/printing of `func` operations.

Conceptually Module had func as default dialect before too but having Builtin know of Func feels weird, so LGTM.

Apr 21 2022, 1:12 AM · Restricted Project, Restricted Project, Restricted Project

Apr 20 2022

jpienaar accepted D124077: [mlir][PDLL] Add document link and hover support to mlir-pdll-lsp-server.
Apr 20 2022, 2:23 PM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

jpienaar requested review of D124055: [mlir] Add shape.func.
Apr 19 2022, 5:36 PM · Restricted Project, Restricted Project

Apr 18 2022

jpienaar committed rGf4085c57ddfc: [mlir] Fix two AttributeParser aborts (authored by jpienaar).
[mlir] Fix two AttributeParser aborts
Apr 18 2022, 9:31 AM · Restricted Project, Restricted Project
jpienaar closed D122240: [mlir] Fix two AttributeParser aborts.
Apr 18 2022, 9:30 AM · Restricted Project, Restricted Project

Apr 17 2022

jpienaar accepted D123503: [mlir][emitc] Add test for invalid type.
Apr 17 2022, 3:54 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D123514: [mlir][emitc] Add a cast op.
Apr 17 2022, 3:04 PM · Restricted Project, Restricted Project
jpienaar accepted D123915: Print custom assembly on pass failure by default.

Nice, good point about the change to dump for invalid IR, this seems to provide the functionality of the previous change without needing a flag/API change and producing the prettier output in more cases. Of course the discussion still ongoing but looks like general improvement.

Apr 17 2022, 3:01 PM · Restricted Project, Restricted Project

Apr 16 2022

jpienaar committed rGbdabe505f417: [mlir][docs] Add missing directory separator (authored by jpienaar).
[mlir][docs] Add missing directory separator
Apr 16 2022, 10:00 PM · Restricted Project, Restricted Project
jpienaar added a comment to D123893: [MLIR] Provide a way to print ops in custom form on pass failure.

The cost of getting custom format output from generic output dump is rerunning through opt tool, the cost of crash is rerunning program (which can take multiple hours and take a lot of compute resources). I'd much rather it be uniform and safe and avoid needing flag plumbed through.

Apr 16 2022, 8:52 AM · Restricted Project, Restricted Project

Apr 15 2022

jpienaar accepted D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC.

Thanks

Apr 15 2022, 12:20 AM · Restricted Project, Restricted Project

Apr 14 2022

jpienaar committed rG35bd41916b10: [mlir] Add assert to fail with more info (NFC) (authored by jpienaar).
[mlir] Add assert to fail with more info (NFC)
Apr 14 2022, 7:54 PM · Restricted Project, Restricted Project

Apr 13 2022

jpienaar committed rG5a236e69f20b: [mlir][pdll] Include string in PDLLServer.h (authored by jpienaar).
[mlir][pdll] Include string in PDLLServer.h
Apr 13 2022, 10:31 AM · Restricted Project, Restricted Project
jpienaar added a comment to D123474: [mlir][pdll] Add extra-dirs for LSP includes..

This is causing failures on the Windows builbot: https://lab.llvm.org/buildbot/#/builders/13/builds/19626/steps/6/logs/stdio
I believe you simply need #include <string> to make MSVC happy.

C:\PROGRA~2\MICROS~3\2019\COMMUN~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe  /nologo /TP -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=1 -DMLIR_ROCM_CONVERSIONS_ENABLED=1 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\mlir-x64-windows-ninja\build\tools\mlir\lib\Tools\mlir-pdll-lsp-server -IC:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\Tools\mlir-pdll-lsp-server -IC:\buildbot\mlir-x64-windows-ninja\build\include -IC:\buildbot\mlir-x64-windows-ninja\llvm-project\llvm\include -IC:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\include -IC:\buildbot\mlir-x64-windows-ninja\build\tools\mlir\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2  /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Fotools\mlir\lib\Tools\mlir-pdll-lsp-server\CMakeFiles\MLIRPdllLspServerLib.dir\PDLLServer.cpp.obj /Fdtools\mlir\lib\Tools\mlir-pdll-lsp-server\CMakeFiles\MLIRPdllLspServerLib.dir\MLIRPdllLspServerLib.pdb /FS -c C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\Tools\mlir-pdll-lsp-server\PDLLServer.cpp
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\Tools\mlir-pdll-lsp-server\PDLLServer.h(32): error C2039: 'string': is not a member of 'std'
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(24): note: see declaration of 'std'
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\Tools\mlir-pdll-lsp-server\PDLLServer.h(32): error C2065: 'string': undeclared identifier
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\Tools\mlir-pdll-lsp-server\PDLLServer.h(32): error C2923: 'std::vector': 'string' is not a valid template type argument for parameter '_Ty'
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\Tools\mlir-pdll-lsp-server\PDLLServer.h(32): note: see declaration of 'string'
Apr 13 2022, 10:27 AM · Restricted Project, Restricted Project
jpienaar committed rGa9d7598ef8ec: [mlir][pdll] Rename extra dir flag (authored by jpienaar).
[mlir][pdll] Rename extra dir flag
Apr 13 2022, 10:00 AM · Restricted Project, Restricted Project
jpienaar committed rGaa9da11f5d23: [mlir][pdll] Add extra-dirs for LSP includes. (authored by jpienaar).
[mlir][pdll] Add extra-dirs for LSP includes.
Apr 13 2022, 9:42 AM · Restricted Project, Restricted Project
jpienaar closed D123474: [mlir][pdll] Add extra-dirs for LSP includes..
Apr 13 2022, 9:41 AM · Restricted Project, Restricted Project

Apr 11 2022

jpienaar added inline comments to D123503: [mlir][emitc] Add test for invalid type.
Apr 11 2022, 8:03 AM · Restricted Project, Restricted Project

Apr 10 2022

jpienaar requested review of D123474: [mlir][pdll] Add extra-dirs for LSP includes..
Apr 10 2022, 3:28 PM · Restricted Project, Restricted Project
jpienaar added a comment to D120203: [mlir] Introduce ml_program dialect..

Nice :-)

Apr 10 2022, 1:27 PM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2022

jpienaar accepted D123258: [mlir:docs] Add proper documentation for defining dialects.
Apr 9 2022, 11:44 AM · Restricted Project, Restricted Project
jpienaar accepted D123183: [mlir-vscode] Fix processing of files not within the workspace.

SG, thanks for the explanation

Apr 9 2022, 11:08 AM · Restricted Project, Restricted Project
jpienaar accepted D123240: [mlir-vscode] Don't emit errors if the user didn't set the server path.
Apr 9 2022, 11:07 AM · Restricted Project, Restricted Project

Apr 8 2022

jpienaar added a comment to D123360: [mlir] Remove the use of FilterTypes for template metaprogramming.

Nice :)

Apr 8 2022, 10:54 AM · Restricted Project, Restricted Project
jpienaar accepted D122430: [mlir][ods] ODS-level Attribute Optimizations.
Apr 8 2022, 10:18 AM · Restricted Project, Restricted Project

Apr 7 2022

jpienaar accepted D123257: [mlir] Split dialect definition constructs out of OpBase into DialectBase.

Thanks! (I was going to start with doc update, but that requires coffee :-))

Apr 7 2022, 6:56 AM · Restricted Project, Restricted Project

Apr 6 2022

jpienaar accepted D123184: [mlir-vscode] Refactor server creation to be lazy.

I might even suggest the error emission from not finding LSP should be logged (flagged in some way) rather than popup given the extension is the combination of LSP & syntax highlighting. And I'm reading these files more than I traverse via LSP assistance, so in fresh client/machine without lsp built the extension is still useful and the missing LSP warning interrupts my flow before I even tried to use any LSP functionality (and I may not need any at all). But that's just a nit.

Apr 6 2022, 8:08 AM · Restricted Project, Restricted Project
jpienaar added inline comments to D123183: [mlir-vscode] Fix processing of files not within the workspace.
Apr 6 2022, 8:02 AM · Restricted Project, Restricted Project

Apr 5 2022

jpienaar accepted D122792: [mlir-vscode] Add better resolution for server file paths.

Nice, thanks that SGTM

Apr 5 2022, 1:10 PM · Restricted Project, Restricted Project

Apr 4 2022

jpienaar added inline comments to D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard.
Apr 4 2022, 11:10 AM · Restricted Project, Restricted Project

Apr 3 2022

jpienaar added inline comments to D122950: Support a const variant for Value/Block/Operation print/dump methods (NFC).
Apr 3 2022, 8:45 AM · Restricted Project, Restricted Project
jpienaar added a comment to D122990: Added new file & improved inclusivity.

Improved Inclusivity to make it beginner-friendly

Apr 3 2022, 5:59 AM · Restricted Project, Restricted Project

Apr 1 2022

jpienaar added a comment to D122770: [mlir] Extern constant via ElementsAttr..

Chose this as my expectation is that extern constant would be used as part of workflow that manages state, but the moment one outputs to textual format you have left that.

I have strong concerns with this: even if there is some external state, the IR should round-trip as much as possible..

Apr 1 2022, 5:45 PM · Restricted Project, Restricted Project
jpienaar accepted D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard.
Apr 1 2022, 5:39 PM · Restricted Project, Restricted Project
jpienaar committed rGad38f409f99d: [mlir] Switch debugString helper to << operator (authored by jpienaar).
[mlir] Switch debugString helper to << operator
Apr 1 2022, 4:34 PM · Restricted Project, Restricted Project
jpienaar added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

You should be able to test this with a module with an arith.constant

Apr 1 2022, 12:20 PM · Restricted Project, Restricted Project

Mar 31 2022

jpienaar added a comment to D122692: [GreedPatternRewriter] Preprocess constants while building worklist when not processing top down.

So there are at least 2 significant changes to behaviour

  1. The folder actually sorts commutative ops, but this doesn't trigger the greedy rewriter to run another iteration because tryToFold might still return failure. If -my-pass only has one pattern commutative(a, b) -> foo but the input IR is commutative(b, a), the pattern doesn't match because the folder will re-order the operands but the rewriter will exit.

Was this kind of awkwardly relying on the fact that we always did 2 iterations (given that we refolded existing constants)?

Mar 31 2022, 7:57 PM · Restricted Project, Restricted Project, Restricted Project
jpienaar accepted D122793: [mlir-vscode] Add better support for multiple workspace folders.

LG, I'm just not sure how much the optionality/null is getting you here vs extra paths created.

Mar 31 2022, 7:16 AM · Restricted Project, Restricted Project
jpienaar accepted D122792: [mlir-vscode] Add better resolution for server file paths.
Mar 31 2022, 7:04 AM · Restricted Project, Restricted Project

Mar 30 2022

jpienaar added inline comments to D122775: [mlir] Rework the implementation of TypeID.
Mar 30 2022, 6:01 PM · Restricted Project, Restricted Project, Restricted Project
jpienaar requested review of D122770: [mlir] Extern constant via ElementsAttr..
Mar 30 2022, 4:22 PM · Restricted Project, Restricted Project

Mar 29 2022

jpienaar accepted D122692: [GreedPatternRewriter] Preprocess constants while building worklist when not processing top down.

Nice, this was a pain point for folks diff'ing across passes, thanks!

Mar 29 2022, 5:01 PM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2022

jpienaar committed rG0217d1178b9f: [mlir] Fix leak in case of failed parse (authored by jpienaar).
[mlir] Fix leak in case of failed parse
Mar 28 2022, 8:04 PM · Restricted Project, Restricted Project
jpienaar closed D122112: [mlir] Fix leak in case of failed parse of Block.
Mar 28 2022, 8:04 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D122240: [mlir] Fix two AttributeParser aborts.
Mar 28 2022, 7:59 PM · Restricted Project, Restricted Project
jpienaar committed rG12ba76c6d161: Eliminate gcc7 compiler warnings (authored by lipracer).
Eliminate gcc7 compiler warnings
Mar 28 2022, 7:56 PM · Restricted Project, Restricted Project
jpienaar closed D122527: Eliminate gcc7 compiler warnings.
Mar 28 2022, 7:55 PM · Restricted Project, Restricted Project
jpienaar committed rG3e9805eb03df: [mlir] Update Vector dialect to prefixed accessors. (authored by jpienaar).
[mlir] Update Vector dialect to prefixed accessors.
Mar 28 2022, 3:45 PM · Restricted Project, Restricted Project
jpienaar committed rGe2485f3c5942: [mlir] Update the Builtin dialect to use prefixed accessors (authored by jpienaar).
[mlir] Update the Builtin dialect to use prefixed accessors
Mar 28 2022, 3:21 PM · Restricted Project, Restricted Project