- User Since
- Aug 20 2014, 6:06 PM (346 w, 3 d)
I like structure too as it captures information about the structure of the values to me. encoding makes me think jpeg or Levensthein distance and the like.
Thu, Apr 8
I think this looks good to go and we can always iterate
Wed, Apr 7
Tue, Apr 6
Fri, Apr 2
Thu, Apr 1
Mon, Mar 29
Fri, Mar 26
Wed, Mar 24
Tue, Mar 23
This seems as expected (capturing what is known in the non-error case when building), I'm surprised no tests needed updating - guessing as we don't have one exercising this builder. Could you perhaps add a small C++ unit test for it?
I'd prefer something like
Mon, Mar 22
Nice, any performance tests you did?
Sun, Mar 21
Looks like a nice cleanup, I see:
Fri, Mar 19
LG to me interface wise modulo some ergonomics and questions others have there. Thanks!
Wed, Mar 17
Tue, Mar 16
Mar 10 2021
I'll probably need to go through these again later, but looks good from check and can be refined later.
Mar 9 2021
Adding Stephan as I'll be OOO
Mar 8 2021
Mar 5 2021
Thanks this will help a lot :)
Mar 4 2021
Added heading and expanded comment
Nice improvement, thanks
Mar 3 2021
It's fine to have these separate for review, but please merge to avoid updating the interface in two consecutive changes where one undos part of the previous
Mar 2 2021
Nice, thanks for the super fast improvement!
Is this something that we want to make a convention, then we'd want to then capture in https://mlir.llvm.org/getting_started/DeveloperGuide/ (I don't believe it is a LLVM convention)
LGTM, I'll leave more to Tres who knows these better
Mar 1 2021
I know River had a better/alternate approach in mind here too
Only access union element that was set for case
Feb 28 2021
Feb 27 2021
Feb 26 2021
Feb 25 2021
Feb 22 2021
So this will avoid that long pause at the end?