Page MenuHomePhabricator

jpienaar (Jacques Pienaar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 6:06 PM (252 w, 6 d)

Recent Activity

Mon, May 27

jpienaar committed rG00a538a230e3: NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl… (authored by jpienaar).
NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl…
Mon, May 27, 10:38 AM
jpienaar committed rL361775: NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl….
NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl…
Mon, May 27, 10:38 AM
jpienaar closed D62467: NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl::ConstIterator..
Mon, May 27, 10:38 AM · Restricted Project
jpienaar accepted D62467: NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl::ConstIterator..

This make the declaration of ConstIterator and Iterator equivalent (line 107), so SGTM.

Mon, May 27, 10:25 AM · Restricted Project

Apr 15 2019

jpienaar accepted D60730: Only use argv[0] as the main executable name if it exists..
Apr 15 2019, 2:07 PM · Restricted Project

Feb 25 2019

jpienaar accepted D58490: [ARM] Be super conservative about atomics.

Change to Lanai seems fine. The model for Lanai execution/usage means atomics aren't important, but treating them conservatively is better. Thanks!

Feb 25 2019, 7:13 AM · Restricted Project

Jul 3 2018

jpienaar committed rL336236: [lanai] Handle atomic load of i8 like regular load..
[lanai] Handle atomic load of i8 like regular load.
Jul 3 2018, 4:02 PM

Jun 1 2018

jpienaar accepted D47626: Remove SETCCE use from Lanai's backend.

Looks good and as discussed the regression will be addressed by using carry.

Jun 1 2018, 7:27 AM

Feb 8 2018

jpienaar committed rL324679: [Lanai] Code model dictates section selection..
[Lanai] Code model dictates section selection.
Feb 8 2018, 3:27 PM

Dec 29 2017

jpienaar updated the diff for D41383: Rename comments to match renamed function name..

Removed some unrelated renames.

Dec 29 2017, 8:35 AM

Dec 19 2017

jpienaar added a comment to D41383: Rename comments to match renamed function name..

Didn't mean to have this send out emails yet, some spurious changes that I want to revert still.

Dec 19 2017, 2:59 AM
jpienaar created D41383: Rename comments to match renamed function name..
Dec 19 2017, 2:56 AM

Dec 18 2017

jpienaar added a comment to D22409: Rename AnalyzeBranch* to analyzeBranch*..

@MatzeB I'll take a swing at updating those later and sending you a review (traveling, so response time variable).

Dec 18 2017, 11:19 PM

Aug 22 2017

jpienaar accepted D36829: [Lanai] Remove dead functions from LanaiRegisterInfo.

Looks good, thanks!

Aug 22 2017, 2:36 PM

Aug 1 2017

jpienaar committed rL309721: [lanai] Add getIntImmCost in LanaiTargetTransformInfo..
[lanai] Add getIntImmCost in LanaiTargetTransformInfo.
Aug 1 2017, 11:41 AM

May 30 2017

jpienaar added a comment to D33696: TargetMachine: Indicate whether machine verifier passes..

Looks good for Lanai changes

May 30 2017, 5:40 PM

May 9 2017

jpienaar committed rL302568: [lanai] Add computeKnownBitsForTargetNode for Lanai..
[lanai] Add computeKnownBitsForTargetNode for Lanai.
May 9 2017, 11:48 AM
jpienaar closed D29605: [lanai] Add computeKnownBitsForTargetNode for Lanai..
May 9 2017, 11:48 AM

May 1 2017

jpienaar added a comment to D29605: [lanai] Add computeKnownBitsForTargetNode for Lanai..

Hmm, this is the sort of thing I'd expect SelectionDAG to "just do"... Do other backends achieve the same end by similar means?

May 1 2017, 12:56 AM
jpienaar retitled D29605: [lanai] Add computeKnownBitsForTargetNode for Lanai. from [lanai] Avoid unnecessary AND'ing for brcond. to [lanai] Add computeKnownBitsForTargetNode for Lanai..
May 1 2017, 12:54 AM
jpienaar updated the diff for D29605: [lanai] Add computeKnownBitsForTargetNode for Lanai..

Add computeKnownBitsForTargetNode for Lanai.

May 1 2017, 12:53 AM

Mar 16 2017

jpienaar committed rL298015: clean Lanai namespace.
clean Lanai namespace
Mar 16 2017, 4:34 PM
jpienaar closed D30955: clean Lanai namespace.
Mar 16 2017, 4:34 PM
jpienaar added a comment to D30955: clean Lanai namespace.

I'll submit it.

Mar 16 2017, 4:22 PM

Mar 14 2017

jpienaar accepted D30955: clean Lanai namespace.

Thanks. Could you run this through clang/tools/clang-format-diff.py before committing?

Mar 14 2017, 8:55 PM

Feb 6 2017

jpienaar created D29605: [lanai] Add computeKnownBitsForTargetNode for Lanai..
Feb 6 2017, 1:47 PM

Jan 24 2017

jpienaar accepted D29043: [Lanai] Rename LanaiInstPrinter library to LanaiAsmPrinter.

Thanks!

Jan 24 2017, 7:56 AM

Dec 15 2016

jpienaar committed rL289832: [lanai] Simplify small section check in LowerGlobalAddress and treat ldata….
[lanai] Simplify small section check in LowerGlobalAddress and treat ldata…
Dec 15 2016, 9:06 AM

Dec 2 2016

jpienaar committed rL288541: [lanai] Custom lowering of SHL_PARTS.
[lanai] Custom lowering of SHL_PARTS
Dec 2 2016, 2:11 PM
jpienaar closed D27232: [lanai] Custom lowering of SHL_PARTS.
Dec 2 2016, 2:11 PM
jpienaar updated the diff for D27232: [lanai] Custom lowering of SHL_PARTS.

Expand test to test lowering of ashldi.

Dec 2 2016, 2:09 PM

Nov 30 2016

jpienaar updated the diff for D27232: [lanai] Custom lowering of SHL_PARTS.

Updated the pseudo code variable names to correspond better with actual variable names used.

Nov 30 2016, 7:49 AM

Nov 29 2016

jpienaar retitled D27232: [lanai] Custom lowering of SHL_PARTS from to [lanai] Custom lowering of SHL_PARTS.
Nov 29 2016, 3:21 PM
jpienaar committed rL288215: [lanai] Manually match 0/-1 with R0/R1..
[lanai] Manually match 0/-1 with R0/R1.
Nov 29 2016, 3:11 PM
jpienaar closed D27171: [lanai] Manually match 0/-1 with R0/R1..
Nov 29 2016, 3:11 PM
jpienaar updated the diff for D27171: [lanai] Manually match 0/-1 with R0/R1..

Updated to test the type before matching R0 and R1.

Nov 29 2016, 11:43 AM

Nov 28 2016

jpienaar retitled D27171: [lanai] Manually match 0/-1 with R0/R1. from to [lanai] Manually match 0/-1 with R0/R1..
Nov 28 2016, 11:38 AM

Oct 7 2016

jpienaar added a comment to D25355: Target: Replace most PatLeaf patterns that match immediates with ImmLeaf patterns. NFCI..

LGTM

Oct 7 2016, 9:41 AM

Sep 20 2016

jpienaar committed rL282045: [NVPTX] Check if callsite is defined when computing argument allignment.
[NVPTX] Check if callsite is defined when computing argument allignment
Sep 20 2016, 7:06 PM
jpienaar closed D9168: [NVPTX] Check if callsite is defined when computing argument allignment.
Sep 20 2016, 7:06 PM
jpienaar accepted D9168: [NVPTX] Check if callsite is defined when computing argument allignment.

Looks good to me, do you need help submitting?

Sep 20 2016, 9:22 AM
jpienaar added a comment to D9168: [NVPTX] Check if callsite is defined when computing argument allignment.

Cool. I didn't know the review system allows having the patch updated like this :) It still reports me as the author and you as a subscriber. I don't think that matters.

Sep 20 2016, 8:35 AM

Sep 19 2016

jpienaar added a comment to D9168: [NVPTX] Check if callsite is defined when computing argument allignment.

Oh, sorry, I didn't see your response before I clicked abandoned. It has been a while, so this patch is pretty stale.

Sep 19 2016, 9:33 AM
jpienaar abandoned D9168: [NVPTX] Check if callsite is defined when computing argument allignment.
Sep 19 2016, 9:31 AM

Aug 23 2016

jpienaar committed rL279517: [lanai] Use const instead of constexpr.
[lanai] Use const instead of constexpr
Aug 23 2016, 7:45 AM

Aug 22 2016

jpienaar committed rL279498: [lanai] Make Lanai backend non-experimental.
[lanai] Make Lanai backend non-experimental
Aug 22 2016, 6:15 PM
jpienaar closed D22530: [lanai] Make Lanai backend non-experimental.
Aug 22 2016, 6:14 PM
jpienaar committed rL279497: [lanai] Exit early in Mem Alu combiner if sentinel reach..
[lanai] Exit early in Mem Alu combiner if sentinel reach.
Aug 22 2016, 6:12 PM

Aug 19 2016

jpienaar updated D22530: [lanai] Make Lanai backend non-experimental.
Aug 19 2016, 9:17 AM

Aug 18 2016

jpienaar committed rL279169: Fix link quotes on AArch64's CompilerWriterInfo section..
Fix link quotes on AArch64's CompilerWriterInfo section.
Aug 18 2016, 3:18 PM
jpienaar closed D23697: Fix link quotes on AArch64's CompilerWriterInfo section. by committing rL279169: Fix link quotes on AArch64's CompilerWriterInfo section..
Aug 18 2016, 3:18 PM
jpienaar closed D23697: Fix link quotes on AArch64's CompilerWriterInfo section..
Aug 18 2016, 3:18 PM
jpienaar retitled D23697: Fix link quotes on AArch64's CompilerWriterInfo section. from to Fix link quotes on AArch64's CompilerWriterInfo section..
Aug 18 2016, 2:36 PM
jpienaar committed rL279149: [lanai] Add ISA document to CompilerWritersInfo.
[lanai] Add ISA document to CompilerWritersInfo
Aug 18 2016, 2:33 PM
jpienaar closed D23693: [lanai] Add ISA document to CompilerWritersInfo by committing rL279149: [lanai] Add ISA document to CompilerWritersInfo.
Aug 18 2016, 2:33 PM
jpienaar updated D23693: [lanai] Add ISA document to CompilerWritersInfo.
Aug 18 2016, 2:31 PM
jpienaar added a comment to D23693: [lanai] Add ISA document to CompilerWritersInfo.

SG, will do cleanup separately.

Aug 18 2016, 2:31 PM
jpienaar retitled D23693: [lanai] Add ISA document to CompilerWritersInfo from to [lanai] Add ISA document to CompilerWritersInfo.
Aug 18 2016, 2:03 PM

Jul 29 2016

jpienaar committed rL277127: [lanai] Update for Target API (TargetRegistry::RegisterMCAsmBackend) change.
[lanai] Update for Target API (TargetRegistry::RegisterMCAsmBackend) change
Jul 29 2016, 1:58 AM

Jul 25 2016

jpienaar added a reviewer for D22530: [lanai] Make Lanai backend non-experimental: rengolin.
Jul 25 2016, 4:16 AM

Jul 19 2016

jpienaar retitled D22530: [lanai] Make Lanai backend non-experimental from to [lanai] Make Lanai backend non-experimental.
Jul 19 2016, 1:53 PM

Jul 15 2016

jpienaar committed rL275636: [lanai] Small cleanup: remove/comment out unused args.
[lanai] Small cleanup: remove/comment out unused args
Jul 15 2016, 3:46 PM
jpienaar committed rL275631: [lanai] Fix build by updating calls to getLoad & getStore..
[lanai] Fix build by updating calls to getLoad & getStore.
Jul 15 2016, 3:26 PM
jpienaar committed rL275564: Rename AnalyzeBranch* to analyzeBranch*..
Rename AnalyzeBranch* to analyzeBranch*.
Jul 15 2016, 7:49 AM
jpienaar closed D22409: Rename AnalyzeBranch* to analyzeBranch*. by committing rL275564: Rename AnalyzeBranch* to analyzeBranch*..
Jul 15 2016, 7:48 AM
jpienaar closed D22409: Rename AnalyzeBranch* to analyzeBranch*..
Jul 15 2016, 7:48 AM
jpienaar retitled D22409: Rename AnalyzeBranch* to analyzeBranch*. from to Rename AnalyzeBranch* to analyzeBranch*..
Jul 15 2016, 7:26 AM

Jul 11 2016

jpienaar committed rL275081: [lanai] Add more tests for assembly of conditional ALU ops.
[lanai] Add more tests for assembly of conditional ALU ops
Jul 11 2016, 11:05 AM

Jul 9 2016

jpienaar committed rL274980: [lanai] Treat .t as optional in assembly parser for RR operands and add….
[lanai] Treat .t as optional in assembly parser for RR operands and add…
Jul 9 2016, 11:33 AM

Jul 8 2016

jpienaar committed rL274945: [lanai] Update test to use peephole-opt and not peephole-opts.
[lanai] Update test to use peephole-opt and not peephole-opts
Jul 8 2016, 3:35 PM
jpienaar accepted D22166: Lanai: Avoid implicit iterator conversions, NFC.

Looks good, thanks.

Jul 8 2016, 3:03 PM

Jul 7 2016

jpienaar committed rL274807: [lanai] Use peephole optimizer to generate more conditional ALU operations..
[lanai] Use peephole optimizer to generate more conditional ALU operations.
Jul 7 2016, 4:43 PM
jpienaar closed D22072: [lanai] Use peephole optimizer to generate more conditional ALU operations..
Jul 7 2016, 4:43 PM
jpienaar updated the diff for D22072: [lanai] Use peephole optimizer to generate more conditional ALU operations..

Comments addressed, thanks.

Jul 7 2016, 1:09 PM

Jul 6 2016

jpienaar retitled D22072: [lanai] Use peephole optimizer to generate more conditional ALU operations. from to [lanai] Use peephole optimizer to generate more conditional ALU operations..
Jul 6 2016, 4:34 PM

Jun 28 2016

jpienaar committed rL274042: [lanai] Update ELF number to correspond to the assigned number..
[lanai] Update ELF number to correspond to the assigned number.
Jun 28 2016, 11:29 AM

Jun 27 2016

jpienaar added a comment to D21726: CodeGen: Use MachineInstr& in TargetInstrInfo, NFC.
In D21726#467239, @ab wrote:
In D21726#467230, @ab wrote:

Also, I see BPF doesn't need any changes; can you confirm?

Looks like Lanai will though; I suppose that can be done separately.

Jun 27 2016, 8:57 AM

May 20 2016

jpienaar committed rL270282: [lanai] Change reloc to use PIC_ by default and cleanup..
[lanai] Change reloc to use PIC_ by default and cleanup.
May 20 2016, 2:48 PM

May 19 2016

jpienaar committed rL270176: [lanai] Use Optional<Reloc> in LanaiTargetMachine..
[lanai] Use Optional<Reloc> in LanaiTargetMachine.
May 19 2016, 8:28 PM

May 18 2016

jpienaar committed rL269986: [lanai] Change the way flag setting instructions are checked..
[lanai] Change the way flag setting instructions are checked.
May 18 2016, 2:37 PM

Apr 25 2016

jpienaar committed rL267496: [lanai] Update handling of structs in arguments to be passed in registers..
[lanai] Update handling of structs in arguments to be passed in registers.
Apr 25 2016, 5:15 PM
jpienaar committed rL267424: [lanai] Expand findClosestSuitableAluInstr check to consider offset register..
[lanai] Expand findClosestSuitableAluInstr check to consider offset register.
Apr 25 2016, 9:47 AM

Apr 20 2016

jpienaar committed rL266898: [lanai] Add subword scheduling itineraries..
[lanai] Add subword scheduling itineraries.
Apr 20 2016, 11:34 AM

Apr 19 2016

jpienaar committed rL266802: [lanai] Add lowering for SETCCE i32..
[lanai] Add lowering for SETCCE i32.
Apr 19 2016, 12:21 PM

Apr 18 2016

jpienaar committed rL266701: [lanai] Set boolean contentss to ZeroOrOneBooleanContent..
[lanai] Set boolean contentss to ZeroOrOneBooleanContent.
Apr 18 2016, 5:32 PM

Apr 14 2016

jpienaar committed rL266349: [lanai] Add custom lowering for SRL_PARTS i32..
[lanai] Add custom lowering for SRL_PARTS i32.
Apr 14 2016, 11:05 AM
jpienaar committed rL266338: [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and….
[lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and…
Apr 14 2016, 9:53 AM
jpienaar closed D18903: [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and getMemOpBaseRegImmOfsWidth..
Apr 14 2016, 9:53 AM
jpienaar added a comment to D18903: [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and getMemOpBaseRegImmOfsWidth..

Updated, thanks

Apr 14 2016, 7:29 AM
jpienaar updated the diff for D18903: [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and getMemOpBaseRegImmOfsWidth..

Updated to address comments.

Apr 14 2016, 7:28 AM

Apr 13 2016

jpienaar added a comment to D18903: [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and getMemOpBaseRegImmOfsWidth..

Friendly ping

Apr 13 2016, 9:06 PM

Apr 11 2016

jpienaar added a comment to D18903: [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and getMemOpBaseRegImmOfsWidth..

@mcrosier: Yes indeed, funny things can happen if these are wrong :). Added a IR test to test some of the different code paths in areMemAccessesTriviallyDisjoint.

Apr 11 2016, 12:42 PM

Apr 10 2016

jpienaar updated the diff for D18903: [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and getMemOpBaseRegImmOfsWidth..

Adding simple test case to verify effect on scheduling DAG due to areMemAccessesTriviallyDisjoint change.

Apr 10 2016, 7:57 PM

Apr 8 2016

jpienaar retitled D18903: [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and getMemOpBaseRegImmOfsWidth. from to [lanai] Add areMemAccessesTriviallyDisjoint, getMemOpBaseRegImmOfs and getMemOpBaseRegImmOfsWidth..
Apr 8 2016, 11:16 AM

Apr 5 2016

jpienaar committed rL265411: [lanai] LanaiSetflagAluCombiner more conservative.
[lanai] LanaiSetflagAluCombiner more conservative
Apr 5 2016, 9:23 AM
jpienaar closed D18746: [lanai] LanaiSetflagAluCombiner more conservative by committing rL265411: [lanai] LanaiSetflagAluCombiner more conservative.
Apr 5 2016, 9:23 AM

Apr 3 2016

jpienaar retitled D18746: [lanai] LanaiSetflagAluCombiner more conservative from to [lanai] LanaiSetflagAluCombiner more conservative.
Apr 3 2016, 9:50 AM

Apr 2 2016

jpienaar committed rL265251: [lanai] Fix for LanaiDelaySlotFiller and LanaiMCInstLower.cpp.
[lanai] Fix for LanaiDelaySlotFiller and LanaiMCInstLower.cpp
Apr 2 2016, 5:54 PM
jpienaar closed D18734: [lanai] Fix for LanaiDelaySlotFiller and LanaiMCInstLower.cpp by committing rL265251: [lanai] Fix for LanaiDelaySlotFiller and LanaiMCInstLower.cpp.
Apr 2 2016, 5:54 PM
jpienaar retitled D18734: [lanai] Fix for LanaiDelaySlotFiller and LanaiMCInstLower.cpp from to [lanai] Fix for LanaiDelaySlotFiller and LanaiMCInstLower.cpp.
Apr 2 2016, 5:53 PM