Page MenuHomePhabricator

jpienaar (Jacques Pienaar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 6:06 PM (449 w, 2 d)

Recent Activity

Wed, Mar 29

jpienaar added inline comments to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Wed, Mar 29, 9:37 PM · Restricted Project, Restricted Project
jpienaar accepted D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.

LG, but please add rationale in both description and comment in code.

Wed, Mar 29, 5:42 PM · Restricted Project, Restricted Project
jpienaar added a comment to D147191: [mlir][tosa] Disable folder for non-int/float/index types in tosa.slice.

It seems like your latest update removed the functional change (it just shows me the formatting change now)

Wed, Mar 29, 5:41 PM · Restricted Project, Restricted Project
jpienaar accepted D147091: [mlir][arith] Add expansion pattern for ext/trunc of bf16.

LG to me, and optionally done via populate, I'm not sure if always good idea vs letting lower level codegen handle it (seems direct). But given not supported on all backends, SGTM.

Wed, Mar 29, 5:35 PM · Restricted Project, Restricted Project
jpienaar added a comment to D147091: [mlir][arith] Add expansion pattern for ext/trunc of bf16.

Nice (sorry forgot to hit submit)

Wed, Mar 29, 3:59 PM · Restricted Project, Restricted Project

Mon, Mar 27

jpienaar committed rG4bdc9d9b2d95: [mlir][tosa] Add TOSA f64 type support for const op (authored by AmosLewis).
[mlir][tosa] Add TOSA f64 type support for const op
Mon, Mar 27, 6:59 PM · Restricted Project, Restricted Project
jpienaar closed D145336: [mlir][tosa] Add TOSA f64 type support for const op.
Mon, Mar 27, 6:59 PM · Restricted Project, Restricted Project

Fri, Mar 24

Herald added a reviewer for D144408: tree-sitter-mlir: contribute a more complete grammar.js: springerm.

I see on the screenshot for unknown dialects it treats everything as unknown (e.g., memref not identified). That's more conservative (only show what you know) but might be worse for highlighting. Do you know if this is intrinsic to tree-sitter or the way the grammar is written? (It was written directly matching our markdown/uses to fix markdown, with explicit structure in mind).

Fri, Mar 24, 7:05 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D144817: Add a GDB/LLDB interface for interactive debugging of MLIR Actions.
Fri, Mar 24, 7:00 PM · Restricted Project, Restricted Project
jpienaar accepted D146677: [mlir] Add support for non-f32 polynomial approximation.
Fri, Mar 24, 6:59 PM · Restricted Project, Restricted Project
jpienaar added a comment to D146526: [mlir][tosa] Improve performance of tosa.transpose constant folding.

Nice speedup! Sorry I missed the review notification

Fri, Mar 24, 6:58 PM · Restricted Project, Restricted Project

Thu, Mar 23

jpienaar updated the diff for D146555: [mlir][bytecode] Allow client to specify an older version of the bytecode to emit.

Fix build

Thu, Mar 23, 10:22 AM · Restricted Project, Restricted Project
jpienaar retitled D146555: [mlir][bytecode] Allow client to specify an older version of the bytecode to emit from [mlir][bytecode] Add version in write config. to [mlir][bytecode] Allow client to specify an older version of the bytecode to emit.
Thu, Mar 23, 10:14 AM · Restricted Project, Restricted Project

Wed, Mar 22

jpienaar added inline comments to D146677: [mlir] Add support for non-f32 polynomial approximation.
Wed, Mar 22, 5:43 PM · Restricted Project, Restricted Project

Tue, Mar 21

jpienaar requested review of D146555: [mlir][bytecode] Allow client to specify an older version of the bytecode to emit.
Tue, Mar 21, 11:36 AM · Restricted Project, Restricted Project
jpienaar committed rG912599638027: Support retrieving the splat value from DenseElementsAttrs in Python (authored by apaszke).
Support retrieving the splat value from DenseElementsAttrs in Python
Tue, Mar 21, 8:44 AM · Restricted Project, Restricted Project
jpienaar closed D146510: Support retrieving the splat value from DenseElementsAttrs in Python.
Tue, Mar 21, 8:43 AM · Restricted Project, Restricted Project
jpienaar accepted D146510: Support retrieving the splat value from DenseElementsAttrs in Python.

Looks good thanks

Tue, Mar 21, 5:33 AM · Restricted Project, Restricted Project

Wed, Mar 15

jpienaar committed rG6d42953f147d: [mlir] Fix scf.for with signless iterations print/parse (authored by jpienaar).
[mlir] Fix scf.for with signless iterations print/parse
Wed, Mar 15, 11:15 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D144820: [mlir] Dialect type/attr bytecode read/write generator..
Wed, Mar 15, 8:39 AM · Restricted Project, Restricted Project
jpienaar updated the diff for D144820: [mlir] Dialect type/attr bytecode read/write generator..

Update to move common helpers to base & document defs/classes more.

Wed, Mar 15, 8:39 AM · Restricted Project, Restricted Project

Mon, Mar 13

jpienaar added a comment to D144545: [mlir][tosa] Canonicalize concatenate->slice sequence.

I don't think you've selected reviewers yet (Nicolas seems unlikely as being selected, perhaps some overly broad Herald rule).

Mon, Mar 13, 6:15 AM · Restricted Project, Restricted Project

Sun, Mar 12

jpienaar added inline comments to D144813: Add an Observer for logging actions application to a stream.
Sun, Mar 12, 3:55 PM · Restricted Project, Restricted Project

Sat, Mar 11

jpienaar committed rG9b8d9447f867: [mlir][core] Fix inline pass default pipeline dump (authored by wpmed92).
[mlir][core] Fix inline pass default pipeline dump
Sat, Mar 11, 9:19 AM · Restricted Project, Restricted Project
jpienaar closed D145066: [mlir][core] Fix inline pass default pipeline dump.
Sat, Mar 11, 9:18 AM · Restricted Project, Restricted Project
jpienaar added a comment to D145523: [MLIR] Add label to print-ir pass.

Remember to clean up commit message

Sat, Mar 11, 7:16 AM · Restricted Project, Restricted Project

Fri, Mar 10

jpienaar added a comment to D145762: Reduce inlining that had larger binary size impact.

~3.4 MB reduction in binary in release mode.

I don’t know how to interpret this without the total binary size, what is the percentage?

Fri, Mar 10, 6:07 AM · Restricted Project, Restricted Project, Restricted Project
jpienaar added a comment to D145250: [mlir][Interfaces] ReifyRankedShapedTypeOpInterface returns OpFoldResults.

Should this be renamed now? E.g., reifyResultShapes now only sometimes reify. (I think folks are also reaching here for something closer to what onnx-mlir and others are doing)

Maybe, depending on what "reification" means. If you interpret it as "building some handle that you can pass around in C++" (Value or Attribute), the name is still correct.

Btw, I am preparing additional changes to this interface that would allow users to reify specific dimensions and populate a FlatAffineValueConstraints (so that the "reification results" of multiple chained ops can be combined and analyzed).

Fri, Mar 10, 4:54 AM · Restricted Project, Restricted Project

Thu, Mar 9

jpienaar requested review of D145762: Reduce inlining that had larger binary size impact.
Thu, Mar 9, 8:37 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

jpienaar committed rG99dee31ef480: Make it possible to create DenseElementsAttrs with arbitrary shaped types in… (authored by apaszke).
Make it possible to create DenseElementsAttrs with arbitrary shaped types in…
Wed, Mar 8, 11:12 AM · Restricted Project, Restricted Project
jpienaar closed D145053: Make it possible to create DenseElementsAttrs with arbitrary shaped types in Python bindings.
Wed, Mar 8, 11:12 AM · Restricted Project, Restricted Project
jpienaar added a comment to D145336: [mlir][tosa] Add TOSA f64 type support for const op.

(which effectively means no not canonical, but one has sections with clear expectations and post "deployment" profile verification there should be none of these for consumers)

Wed, Mar 8, 7:10 AM · Restricted Project, Restricted Project
jpienaar accepted D145336: [mlir][tosa] Add TOSA f64 type support for const op.

Quick question @eric-k256 @AmosLewis,

Will it also fold it to be non-F64 ? i.e. tosa consumers are able to not to witness f64 when tosa is in the canonical form.

Wed, Mar 8, 7:07 AM · Restricted Project, Restricted Project

Tue, Mar 7

jpienaar added a comment to D145250: [mlir][Interfaces] ReifyRankedShapedTypeOpInterface returns OpFoldResults.

Should this be renamed now? E.g., reifyResultShapes now only sometimes reify. (I think folks are also reaching here for something closer to what onnx-mlir and others are doing)

Tue, Mar 7, 4:28 PM · Restricted Project, Restricted Project
jpienaar updated the diff for D144820: [mlir] Dialect type/attr bytecode read/write generator..

Fix format

Tue, Mar 7, 4:22 PM · Restricted Project, Restricted Project
jpienaar added a comment to D145469: Add a message to mlir-opt when reading from stdin to avoid being waiting for nothing.

Could this be done only if detected interactive session? E.g., when piping commands I'd prefer not to see this message (which is probably the majority of times when I use opt).

Tue, Mar 7, 4:20 PM · Restricted Project, Restricted Project
jpienaar added a comment to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

I was wondering (post review) if we should split the reader and writer commit parts, so that we could give a bit of time for bytecode consumers to get updated first (thinking of projects that span multiple repos). I mean, it is unstable at the moment, but wouldn't cause any additional churn.

Tue, Mar 7, 8:04 AM · Restricted Project, Restricted Project
jpienaar added a comment to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

Nice! I'm fine with delaying textual form.

Tue, Mar 7, 6:04 AM · Restricted Project, Restricted Project

Sun, Mar 5

jpienaar added inline comments to D145336: [mlir][tosa] Add TOSA f64 type support for const op.
Sun, Mar 5, 9:05 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".
Sun, Mar 5, 9:02 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D145328: [mlir] Implements IR versioning capability (WIP).
Sun, Mar 5, 8:59 PM · Restricted Project, Restricted Project
jpienaar committed rGbbda411f0e39: [mlir][scf] Relax type requirement on for (authored by jpienaar).
[mlir][scf] Relax type requirement on for
Sun, Mar 5, 7:38 AM · Restricted Project, Restricted Project
jpienaar closed D145288: [mlir][scf] Relax type requirement on for.
Sun, Mar 5, 7:38 AM · Restricted Project, Restricted Project
jpienaar updated the diff for D145288: [mlir][scf] Relax type requirement on for.

Fix formatting

Sun, Mar 5, 6:53 AM · Restricted Project, Restricted Project
jpienaar added a comment to D145288: [mlir][scf] Relax type requirement on for.

Do we need to also update the lowering to LLVM? It may assume type is always index and end up using a different bitwidth.

I checked the final assembly output and saw different outputs as I changed width here. But let me double check the code.

Sun, Mar 5, 6:52 AM · Restricted Project, Restricted Project
jpienaar added a comment to D145288: [mlir][scf] Relax type requirement on for.

Do we need to also update the lowering to LLVM? It may assume type is always index and end up using a different bitwidth.

Sun, Mar 5, 6:41 AM · Restricted Project, Restricted Project
jpienaar retitled D144820: [mlir] Dialect type/attr bytecode read/write generator. from [mlir] Dialect type/attr bytecode bootstrapping tool. to [mlir] Dialect type/attr bytecode read/write generator..
Sun, Mar 5, 6:38 AM · Restricted Project, Restricted Project

Sat, Mar 4

jpienaar updated the diff for D144820: [mlir] Dialect type/attr bytecode read/write generator..

Updated post discussion to immediately use it to replace builtin dialect
reader/writer instead of starting more separate. Also bootstrapping was to
clarify unstable nature, but was called out to be too emphasized.

Sat, Mar 4, 10:02 PM · Restricted Project, Restricted Project

Fri, Mar 3

jpienaar committed rG1a1dc440dae2: [mlir] Update signal failure error message (authored by jpienaar).
[mlir] Update signal failure error message
Fri, Mar 3, 5:07 PM · Restricted Project, Restricted Project
jpienaar closed D145213: [mlir] Update signal failure error message.
Fri, Mar 3, 5:07 PM · Restricted Project, Restricted Project
jpienaar requested review of D145288: [mlir][scf] Relax type requirement on for.
Fri, Mar 3, 4:55 PM · Restricted Project, Restricted Project

Thu, Mar 2

jpienaar requested review of D145213: [mlir] Update signal failure error message.
Thu, Mar 2, 8:25 PM · Restricted Project, Restricted Project

Mar 1 2023

jpienaar accepted D145019: [mlir][math] Add math.cbrt polynomial approximation.

Thanks!

Mar 1 2023, 4:51 PM · Restricted Project, Restricted Project
jpienaar added a comment to D145053: Make it possible to create DenseElementsAttrs with arbitrary shaped types in Python bindings.

Could you add a test to show both usages/avoid regressions?

Mar 1 2023, 8:59 AM · Restricted Project, Restricted Project

Feb 28 2023

jpienaar accepted D144980: [mlir][math] Math expansion for math.tan.

Thanks!

Feb 28 2023, 5:11 PM · Restricted Project, Restricted Project
jpienaar added a comment to D145019: [mlir][math] Add math.cbrt polynomial approximation.

Is there some paper or tool or approximation method that we could cite here?

Feb 28 2023, 5:04 PM · Restricted Project, Restricted Project
jpienaar accepted D144978: Fix SimplifyAllocConst pattern when we have alloc of negative sizes.
Feb 28 2023, 11:29 AM · Restricted Project, Restricted Project
jpienaar added a comment to D144980: [mlir][math] Math expansion for math.tan.

Could we just have it in its own group/approximations pass? (Well and we can populate with patterns from polynomial if needed). Just feels wrong to have this in polynomial

Feb 28 2023, 11:29 AM · Restricted Project, Restricted Project

Feb 27 2023

jpienaar added inline comments to D144808: Change the DebugAction paradigm to delegate the control to the handler.
Feb 27 2023, 9:03 PM · Restricted Project, Restricted Project
jpienaar added inline comments to D144811: Delete ActionManager and replace it with a simple callback on the Context.
Feb 27 2023, 8:53 PM · Restricted Project, Restricted Project
jpienaar accepted D144919: [MLIR] Remove redundant scf.if builder.
Feb 27 2023, 8:49 PM · Restricted Project, Restricted Project, Restricted Project
jpienaar added a comment to D144812: Introduce mlir::tracing::ExecutionContext.

(started a scan but realized I wasn't really reading with any detail ...)

Feb 27 2023, 8:47 PM · Restricted Project, Restricted Project
jpienaar accepted D144886: [MLIR] Add primitive builders for scf.if.

Nit: commit message. The rest looks fine (I forget if we allowed default values in OpBuilder ... )

Feb 27 2023, 10:12 AM · Restricted Project, Restricted Project

Feb 25 2023

jpienaar requested review of D144820: [mlir] Dialect type/attr bytecode read/write generator..
Feb 25 2023, 10:45 PM · Restricted Project, Restricted Project

Feb 24 2023

jpienaar accepted D144615: [MLIR][doc] Clarify `allowUnregisteredDialects()` as "testing option" (NFC).
Feb 24 2023, 11:19 AM · Restricted Project, Restricted Project
jpienaar accepted D144750: [mlir] Define transform dialect expensive checks regardless of asserts..
Feb 24 2023, 11:16 AM · Restricted Project, Restricted Project

Feb 22 2023

jpienaar added a comment to D144408: tree-sitter-mlir: contribute a more complete grammar.js.

When I did the first version I was using this as I wanted to run some analysis tool that uses tree-sitter (that didn't work well) and also to check the language guide a bit using the error checks in tree-sitter generation process. Generation would be really nice, and from maintenance point of view (and we know these may go out of sync, so it would be best effort). Could you perhaps show the before and after of how it affects highlighting? Esp with an unsupported dialect too, to speak to the fuzzing matching part.

Feb 22 2023, 2:49 PM · Restricted Project, Restricted Project

Feb 17 2023

jpienaar added inline comments to D143829: Refactor a MlirOptMainConfig class to hold the configuration of MlirOptMain (NFC).
Feb 17 2023, 5:21 AM · Restricted Project, Restricted Project
jpienaar accepted D143715: [mlir][standalone] Extend sample with custom type.

Nice, thanks

Feb 17 2023, 5:13 AM · Restricted Project, Restricted Project

Feb 14 2023

jpienaar added inline comments to D140806: Change getProcessTriple to return different archs in universal binary.
Feb 14 2023, 9:57 PM · Restricted Project, Restricted Project

Feb 10 2023

jpienaar committed rGa2dcd994a7f8: [mlir][tosa] Add TOSA f64 type support for cast op (authored by AmosLewis).
[mlir][tosa] Add TOSA f64 type support for cast op
Feb 10 2023, 12:13 PM · Restricted Project, Restricted Project
jpienaar closed D142599: [mlir][tosa] Add TOSA f64 type support for cast op.
Feb 10 2023, 12:13 PM · Restricted Project, Restricted Project
jpienaar added a comment to D142599: [mlir][tosa] Add TOSA f64 type support for cast op.

I'll help in a bit

Feb 10 2023, 11:47 AM · Restricted Project, Restricted Project

Feb 9 2023

jpienaar accepted D142531: [llvm][TableGen][Jupyter] Show llvm-tblgen not found error in notebook.
Feb 9 2023, 9:31 AM · Restricted Project, Restricted Project
jpienaar added inline comments to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".
Feb 9 2023, 9:30 AM · Restricted Project, Restricted Project

Feb 7 2023

jpienaar accepted D143190: [mlir][ods] add mechanism for deprecating an `OpBuilder` in ODS.

Nice, thanks

Feb 7 2023, 7:41 AM · Restricted Project, Restricted Project
jpienaar accepted D143497: [mlir] Switch default Fold API to using FoldAdaptors.

Nice, thanks. So this doesn't remove and just flips the default, so folks who haven't yet updated can just set raw explicit for now (and then fixup quickly before option is deprecated).

Feb 7 2023, 7:09 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2023

jpienaar updated subscribers of D143240: [mlir][py] Fix infer return type invocation for variadics.

Sending quick fix.

Feb 6 2023, 5:45 PM · Restricted Project, Restricted Project
jpienaar committed rG1d1a2eb298f2: [mlir][py] Fix unused var (authored by jpienaar).
[mlir][py] Fix unused var
Feb 6 2023, 5:45 PM · Restricted Project, Restricted Project
jpienaar committed rG393aa9c57c1e: [mlir][NFC] Add omitted operations to Transform dialect's doc (authored by sotoshigoto).
[mlir][NFC] Add omitted operations to Transform dialect's doc
Feb 6 2023, 5:10 PM · Restricted Project, Restricted Project
jpienaar closed D143237: [mlir][NFC] Add omitted operations to Transform dialect's doc.
Feb 6 2023, 5:09 PM · Restricted Project, Restricted Project
jpienaar committed rGee308c99ed08: [mlir][py] Fix infer return type invocation for variadics (authored by jpienaar).
[mlir][py] Fix infer return type invocation for variadics
Feb 6 2023, 5:04 PM · Restricted Project, Restricted Project
jpienaar closed D143240: [mlir][py] Fix infer return type invocation for variadics.
Feb 6 2023, 5:04 PM · Restricted Project, Restricted Project
jpienaar accepted D143237: [mlir][NFC] Add omitted operations to Transform dialect's doc.

Thanks!

Feb 6 2023, 4:53 PM · Restricted Project, Restricted Project
jpienaar added a comment to D143312: [mlir][tosa] align the type of padding and pad_const with the spec.

I'm confused, I thought these were going the other way. E.g., there is a mismatch between what the spec calls an attribute and MLIR does, previously we had mostly err'd on treating them the same. But as the spec really requires this before execute/offload rather than representationaly , I thought the conclusion was that these should be operands and one had like a verify for export/runtime pass to flag that the operands are actually constants at that point.

Feb 6 2023, 8:34 AM · Restricted Project, Restricted Project

Feb 2 2023

jpienaar requested review of D143240: [mlir][py] Fix infer return type invocation for variadics.
Feb 2 2023, 7:48 PM · Restricted Project, Restricted Project

Jan 24 2023

jpienaar committed rG94f255c2c4d5: [mlir][tosa] Add RFFT2d operation (authored by lhutton1).
[mlir][tosa] Add RFFT2d operation
Jan 24 2023, 3:42 PM · Restricted Project, Restricted Project
jpienaar closed D142336: [mlir][tosa] Add RFFT2d operation.
Jan 24 2023, 3:42 PM · Restricted Project, Restricted Project
jpienaar added a comment to D142336: [mlir][tosa] Add RFFT2d operation.

Let me know when ready and I'll take a look (I didn't check failure)

Jan 24 2023, 10:06 AM · Restricted Project, Restricted Project

Jan 23 2023

jpienaar accepted D141339: [mlir][tosa] Update tosa.avg_pool2d for bit-exact TOSA behavior.

Nice! Given this is very exact lowering required for numerics the test is fine, else I'd be conserned too much of change test. (when I see such lowering I keep thinking I want a couple of convenience wrappers ...)

Jan 23 2023, 7:10 PM · Restricted Project, Restricted Project
jpienaar accepted D142275: [mlir] support !shape.value_shape when replace WithOp in OutlineShapeComputationPass..

Looks good, as Mehdi mentioned using Fixes #60069 will result in closing the issue upon commit.

Jan 23 2023, 7:04 PM · Restricted Project, Restricted Project
jpienaar added a comment to D142148: [MLIR] Add LocationAttr declarations to ODS.

I'm actually surprised we didn't have this one, thanks, let know if you need help landing.

Jan 23 2023, 5:09 PM · Restricted Project, Restricted Project, Restricted Project
jpienaar accepted D142336: [mlir][tosa] Add RFFT2d operation.

Nice, thanks. Would you need help in landing?

Jan 23 2023, 8:58 AM · Restricted Project, Restricted Project

Jan 21 2023

jpienaar added a comment to D142272: [mlir] Promote the SubElementInterfaces to a core Attribute/Type construct.

Nice graduation (gets us even a step towards introspection ... Well more pieces needed :-)). Have you thought about exposing these C side?

Jan 21 2023, 8:11 AM · Restricted Project, Restricted Project
jpienaar added inline comments to D142275: [mlir] support !shape.value_shape when replace WithOp in OutlineShapeComputationPass..
Jan 21 2023, 4:44 AM · Restricted Project, Restricted Project

Jan 19 2023

jpienaar added a comment to D142049: [MLIR] Add InferTypeOpInterface to scf.if op.

Ah seems I never hit submit yesterday. Same comment as Alex on one and general question on verification part.

Jan 19 2023, 10:38 AM · Restricted Project, Restricted Project

Jan 17 2023

jpienaar accepted D141928: [MLIR] Add return type inference to scf.if builder.

SG, could you add a TODO here documenting this so that we know when we look at it again?

Jan 17 2023, 8:58 AM · Restricted Project, Restricted Project
jpienaar added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..

[not a statement of endorsement of either form]

Jan 17 2023, 8:01 AM · Restricted Project, Restricted Project
jpienaar added a comment to D141928: [MLIR] Add return type inference to scf.if builder.

Could you perhaps expand on that exception or point to where this is assumed? Are these where during a pass an invalid state is created or is this across passes?

Jan 17 2023, 7:53 AM · Restricted Project, Restricted Project

Jan 16 2023

jpienaar added a comment to D126238: [mlir][python] Move results types to keyword-only arg..

The change was originally motivated by avoiding the breakage when result type inference was being introduced. It has landed a while ago, so this change will now create the breakage it sought to avoid.

Jan 16 2023, 6:52 AM · Restricted Project, Restricted Project