- User Since
- Oct 29 2014, 9:58 AM (311 w, 5 d)
Looks fine to me. More ideas inline.
Rebase on D89038.
Fri, Oct 16
Add a vector test case for matchFastFloatClamp.
Test simplifySelectWithFCmp on non-uniform vectors.
Thu, Oct 15
But it would be nice to somehow get the codegen improvements shown in some of the MIPS and X86 tests.
Thanks for testing @gargaroff.
Wed, Oct 14
Makes sense to me. As I understand it the biggest practical effect is that the compiler will start making use of output modifiers in compute shaders.
Reverse ping! If you just don't have time to work on this, I'd be interested in commandeering the "insert_vec_elt(build_vector) -> build_vector" part.
Looks good. Some nits inline.
Tue, Oct 13
Lowercase subtarget feature names.
Mon, Oct 12
Looks good to me if the target maintainers are happy.
Querying the register bank bank for VS_32 doesn't make any sense, and I suspect would assert.
Fri, Oct 9
Thu, Oct 8
Use matchers to handle fixed width vectors.
It might make sense to rebase this on D89038.
Rebase after D89000.
I'll rebase this after D89000 lands, since it touches some of the same code in VOP2Instructions.td and gfx1030_err.s.
Wed, Oct 7
Add some matchers to PatternMatch and use them.
Fix a couple more problems shown up by running the MC tests:
- Update asm/dis special cases for V_MAC_LEGACY_F32 now that it uses the VOP_MAC_F32 profile.
- Fix use of OtherPredicates in VOP2 pseudos.
Tue, Oct 6
Update comments for NoMods patterns.
Is "spill" the right name? They come from TargetLowering::expandUnalignedLoad copying the data to a temporary stack slot, not from the register allocator.
Could you pre-commit the test case?
Mon, Oct 5
LGTM, though I can't help feeling the whole function could be simpler.
This looks like a clear win to me on all the affected test cases except for one slight regression noted inline.
LGTM apart from the nitpick about comments.
@ecnelises did you really mean to add yourself as a "blocking reviewer" rather than a normal reviewer?