Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Zeavee (Sacha Coppey)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 8 2022, 3:54 AM (77 w, 17 h)

Recent Activity

Wed, Sep 6

Zeavee updated the diff for D151107: [IR] Add GraalVM calling conventions.

Add graalcc token for Graal calling convention, rename test files to graalcc.ll, report_fatal_error if Subtarget.isRVE(), test for riscv32 and use minimal -mtriple.

Wed, Sep 6, 6:23 AM · Restricted Project, Restricted Project

Aug 28 2023

Zeavee updated the diff for D151107: [IR] Add GraalVM calling conventions.

Add tests for GraalVM calling conventions

Aug 28 2023, 8:29 AM · Restricted Project, Restricted Project

Aug 22 2023

Zeavee added reviewers for D151107: [IR] Add GraalVM calling conventions: asb, RKSimon, t.p.northover.
Aug 22 2023, 2:03 AM · Restricted Project, Restricted Project

Aug 2 2023

Zeavee added a comment to D151107: [IR] Add GraalVM calling conventions.

Hello, sorry for the ping. Would it be possible to have a review for this patch? I am sadly not sure if I should assign a specific reviewer for this change, so if that is the case, please tell me.

Aug 2 2023, 6:28 AM · Restricted Project, Restricted Project
Zeavee added a comment to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Hello, sorry for the ping, but the revision has been accepted and the requested changes applied. Would it be possible to have it merged in the main branch?

Aug 2 2023, 6:23 AM · Restricted Project, Restricted Project

May 26 2023

Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Rebase patch on main

May 26 2023, 4:13 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Remove duplicate switch in RISCVAsmPrinter::emitInstruction

May 26 2023, 3:59 AM · Restricted Project, Restricted Project

May 22 2023

Zeavee updated the diff for D129848: [RISCV] Add Stackmap/Statepoint/Patchpoint support with targets.

Rebased the patch on main. For context, this patch has been used by the LLVM backend of GraalVM's Native Image project in production for around 4 months with no major issues.

May 22 2023, 1:38 PM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Rebased the patch on main. For context, this patch has been used by the LLVM backend of GraalVM's Native Image project in production for around 4 months with no major issues.

May 22 2023, 11:51 AM · Restricted Project, Restricted Project
Zeavee requested review of D151107: [IR] Add GraalVM calling conventions.
May 22 2023, 7:59 AM · Restricted Project, Restricted Project

Jul 27 2022

Zeavee updated the diff for D129848: [RISCV] Add Stackmap/Statepoint/Patchpoint support with targets.

Remove dubious check in RISCVELFStreamer.cpp.

Jul 27 2022, 7:26 AM · Restricted Project, Restricted Project

Jul 22 2022

Zeavee updated the diff for D129848: [RISCV] Add Stackmap/Statepoint/Patchpoint support with targets.

Update rv64-patchpoint.ll test.

Jul 22 2022, 9:09 AM · Restricted Project, Restricted Project

Jul 21 2022

Zeavee updated the diff for D129848: [RISCV] Add Stackmap/Statepoint/Patchpoint support with targets.

Remove useless test and refactor generateInstSeq by adding generateMCInstSeq to avoid code duplication between PseudoLI and Stackmap.

Jul 21 2022, 4:28 AM · Restricted Project, Restricted Project

Jul 18 2022

Zeavee added a comment to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Why do you have both stackmap.ll and rv64-stackmap.ll? And why does stackmap-frame-setup.ll not have an rv64- prefix like the rest (once that duplication is resolved)?

Jul 18 2022, 11:53 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Fixed spaces issues in tests, added correct prefixes and merged duplicates.

Jul 18 2022, 11:53 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Use 2-bytes NOPs when they are available. Fix tests that used FastISel or an incorrect checks generator.

Jul 18 2022, 10:44 AM · Restricted Project, Restricted Project

Jul 16 2022

Zeavee added inline comments to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Jul 16 2022, 4:01 AM · Restricted Project, Restricted Project
Zeavee added inline comments to D129848: [RISCV] Add Stackmap/Statepoint/Patchpoint support with targets.
Jul 16 2022, 3:46 AM · Restricted Project, Restricted Project

Jul 15 2022

Zeavee updated the diff for D129848: [RISCV] Add Stackmap/Statepoint/Patchpoint support with targets.

Update tests that do not check data directive using update_llc_test_checks.py.

Jul 15 2022, 3:03 PM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Update tests that do not check data directive using update_llc_test_checks.py.

Jul 15 2022, 12:09 PM · Restricted Project, Restricted Project
Zeavee requested review of D129848: [RISCV] Add Stackmap/Statepoint/Patchpoint support with targets.
Jul 15 2022, 5:08 AM · Restricted Project, Restricted Project

Jul 14 2022

Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Remove Opers temporary variable to avoid compilation error in switch.

Jul 14 2022, 11:18 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Use a switch instead of if else for getInstSizeInBytes and remove unused import.

Jul 14 2022, 10:50 AM · Restricted Project, Restricted Project
Zeavee added inline comments to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Jul 14 2022, 10:47 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Add case for STACKMAP, STATEPOINT and PATCHPOINT in getInstSizeInBytes.

Jul 14 2022, 10:34 AM · Restricted Project, Restricted Project
Zeavee added a comment to D108961: [RISCV] MC relaxation for out-of-range conditional branch..
Jul 14 2022, 7:44 AM · Restricted Project, Restricted Project

Jul 13 2022

Herald added a project to D108961: [RISCV] MC relaxation for out-of-range conditional branch.: Restricted Project.

Hello, we are currently trying to implement an LLVM backend on RISC-V for the GraalVM Native Image project and we run into some issues that are solved by this patch. In summary, we produce LLVM bitcode from Java code and feed it to llc. The problem is that we cannot really control the size of the functions and it can cause branches to out of range locations. However, this issue seems stale and controversial. Is there any news to share?

Jul 13 2022, 7:33 AM · Restricted Project, Restricted Project

May 4 2022

Zeavee added inline comments to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
May 4 2022, 4:33 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

I removed the code related to the target resolution, to put it in another patch as suggested. I still took the comments into account and they will be applied in the other patch. I also used emitNops to avoid code duplication when emitting the Nops.

May 4 2022, 4:26 AM · Restricted Project, Restricted Project

Apr 13 2022

Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Added requested changes on error when code is executed on RV32.

Apr 13 2022, 9:07 AM · Restricted Project, Restricted Project
Zeavee added inline comments to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Apr 13 2022, 9:01 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

I replaced assert by report_fatal_error to indeed stop the execution when reaching this point. I did not include any code for when the intrinsics are run on RV32 as accordingly to the LLVM documentation, Stack map is a 64 bits feature. Thus I only implemented it for RV64. Should I do it for RV32 too?

Apr 13 2022, 8:48 AM · Restricted Project, Restricted Project

Apr 12 2022

Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Sorry for the delay, it took me some time to run clang-format. I also added the context as asked. Finally, I added an assert to make sure STACKMAP, PATCHPOINT and STATEPOINT are only used with RV64.

Apr 12 2022, 7:56 AM · Restricted Project, Restricted Project
Zeavee added a comment to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

I looked a bit deeper into a RV32 implementation, but in fact, according to this https://llvm.org/docs/StackMaps.html#stack-map-format, stackmap support is currently only implemented for 64-bit platforms. Thus it might require more work in the architecture independent part of stackmap, which I am not totally familiar with for now and I also imagine it would be better to start with the more common architectures instead of RV32.

Apr 12 2022, 6:13 AM · Restricted Project, Restricted Project

Apr 11 2022

Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Removes unnecessary space on empty line.

Apr 11 2022, 8:44 AM · Restricted Project, Restricted Project
Zeavee added a comment to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Hello! I am happy to help! Since it is my first contribution, I am not yet familiar with everything, so it might be a little bit messy at the start, sorry in advance.

Apr 11 2022, 8:14 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Adds a missing 0 IMM in a JALR instruction.

Apr 11 2022, 7:26 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Removes RISCVMCInstLower.h which was not used.

Apr 11 2022, 6:22 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Apr 11 2022, 6:19 AM · Restricted Project, Restricted Project
Zeavee requested review of D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Apr 11 2022, 4:36 AM · Restricted Project, Restricted Project