Page MenuHomePhabricator

Zeavee (Sacha Coppey)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 8 2022, 3:54 AM (11 w, 18 h)

Recent Activity

May 4 2022

Zeavee added inline comments to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
May 4 2022, 4:33 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

I removed the code related to the target resolution, to put it in another patch as suggested. I still took the comments into account and they will be applied in the other patch. I also used emitNops to avoid code duplication when emitting the Nops.

May 4 2022, 4:26 AM · Restricted Project, Restricted Project

Apr 13 2022

Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Added requested changes on error when code is executed on RV32.

Apr 13 2022, 9:07 AM · Restricted Project, Restricted Project
Zeavee added inline comments to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Apr 13 2022, 9:01 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

I replaced assert by report_fatal_error to indeed stop the execution when reaching this point. I did not include any code for when the intrinsics are run on RV32 as accordingly to the LLVM documentation, Stack map is a 64 bits feature. Thus I only implemented it for RV64. Should I do it for RV32 too?

Apr 13 2022, 8:48 AM · Restricted Project, Restricted Project

Apr 12 2022

Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Sorry for the delay, it took me some time to run clang-format. I also added the context as asked. Finally, I added an assert to make sure STACKMAP, PATCHPOINT and STATEPOINT are only used with RV64.

Apr 12 2022, 7:56 AM · Restricted Project, Restricted Project
Zeavee added a comment to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

I looked a bit deeper into a RV32 implementation, but in fact, according to this https://llvm.org/docs/StackMaps.html#stack-map-format, stackmap support is currently only implemented for 64-bit platforms. Thus it might require more work in the architecture independent part of stackmap, which I am not totally familiar with for now and I also imagine it would be better to start with the more common architectures instead of RV32.

Apr 12 2022, 6:13 AM · Restricted Project, Restricted Project

Apr 11 2022

Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Removes unnecessary space on empty line.

Apr 11 2022, 8:44 AM · Restricted Project, Restricted Project
Zeavee added a comment to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Hello! I am happy to help! Since it is my first contribution, I am not yet familiar with everything, so it might be a little bit messy at the start, sorry in advance.

Apr 11 2022, 8:14 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Adds a missing 0 IMM in a JALR instruction.

Apr 11 2022, 7:26 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Removes RISCVMCInstLower.h which was not used.

Apr 11 2022, 6:22 AM · Restricted Project, Restricted Project
Zeavee updated the diff for D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Apr 11 2022, 6:19 AM · Restricted Project, Restricted Project
Zeavee requested review of D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Apr 11 2022, 4:36 AM · Restricted Project, Restricted Project