Page MenuHomePhabricator

deadalnix (Amaury SECHET)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 13 2015, 12:29 AM (380 w, 1 d)

Recent Activity

Wed, May 18

deadalnix added a comment to D57317: [DAGCombine] Deduplicate addcarry node using commutativity..

@RKSimon It is good to go, the main problem here is that I don't have a test case for it in isolation, and I have been struggling to get the pieces in where this really shines (mostly related to process the DAG topologically).

Wed, May 18, 5:33 AM · Restricted Project, Restricted Project

Sat, May 7

deadalnix requested changes to D125168: Add opaque ptr to the llvm-c.

This is lacking a test. The LLVM C API is typically tested using the echo test (a program that read LLVM IR with the LLVM C API, and the re-emit it, and it can be checked that both are equal).

Sat, May 7, 8:37 AM · Restricted Project, Restricted Project
deadalnix added a comment to D111159: [UnknownProvenance] Introduce UnknownProvenance constant.

Do you need help merging this?

Sat, May 7, 7:40 AM · Restricted Project, Restricted Project
deadalnix added a comment to D124453: const char* for LLVMTargetMachineEmitToFile's argument.

I will land this for you, no problem.

Sat, May 7, 7:26 AM · Restricted Project, Restricted Project
deadalnix added a comment to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.

Ok, this looks like it is good to go then. @RKSimon , if this is good for you, then we shoudl land this.

Sat, May 7, 6:58 AM · Restricted Project, Restricted Project
deadalnix updated the diff for D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.

Fix aix32-cc-abi-vaarg.ll

Sat, May 7, 6:40 AM · Restricted Project, Restricted Project

Fri, May 6

deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Fri, May 6, 5:40 PM · Restricted Project, Restricted Project
deadalnix requested review of D125150: [AArch64] Remove ADDC, ADDE, SUBC, SUBE support, use the CARRY ops instead.
Fri, May 6, 5:30 PM · Restricted Project, Restricted Project
deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Fri, May 6, 5:16 PM · Restricted Project, Restricted Project
deadalnix updated the summary of D17555: [Feedback requested] Implement cold spliting.
Fri, May 6, 6:57 AM · Restricted Project
deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Fri, May 6, 5:44 AM · Restricted Project, Restricted Project

Wed, May 4

deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Wed, May 4, 11:04 AM · Restricted Project, Restricted Project

Mon, May 2

deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Mon, May 2, 12:08 PM · Restricted Project, Restricted Project
deadalnix updated the diff for D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.

Rebase on top of D124756 .

Mon, May 2, 12:06 PM · Restricted Project, Restricted Project
deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Mon, May 2, 3:45 AM · Restricted Project, Restricted Project
deadalnix updated the diff for D124756: Update movmsk-cmp.ll to match improvements made to InstCombine.

Keep the unoptimized test case.

Mon, May 2, 3:45 AM · Restricted Project, Restricted Project
deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Mon, May 2, 3:39 AM · Restricted Project, Restricted Project
deadalnix requested review of D124756: Update movmsk-cmp.ll to match improvements made to InstCombine.
Mon, May 2, 3:38 AM · Restricted Project, Restricted Project
deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Mon, May 2, 3:10 AM · Restricted Project, Restricted Project

Sun, May 1

deadalnix updated the diff for D57317: [DAGCombine] Deduplicate addcarry node using commutativity..

Update for the monorepo

Sun, May 1, 2:11 PM · Restricted Project, Restricted Project
deadalnix added reviewers for D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo: hans, paquette.
Sun, May 1, 1:34 PM · Restricted Project, Restricted Project
deadalnix updated subscribers of D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Sun, May 1, 1:34 PM · Restricted Project, Restricted Project
deadalnix added inline comments to D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Sun, May 1, 1:24 PM · Restricted Project, Restricted Project
deadalnix requested review of D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo.
Sun, May 1, 1:18 PM · Restricted Project, Restricted Project

Sat, Apr 30

deadalnix accepted D91514: Expose CastInst::getCastOpcode in C API.
Sat, Apr 30, 3:02 PM · Restricted Project, Restricted Project
deadalnix updated subscribers of D119431: [C API] Add LLVMWriteThinLTOBitcodeToMemoryBuffer to C API.

Hi @aykevl . I unfortunately am not familiar with thin LTO, so it is very difficult for me to review this. Maybe @mehdi_amini could help? I know he worked on this at some point, and if he cannot, he'll know who can.

Sat, Apr 30, 3:01 PM · Restricted Project, Restricted Project
deadalnix accepted D124453: const char* for LLVMTargetMachineEmitToFile's argument.
Sat, Apr 30, 2:57 PM · Restricted Project, Restricted Project

Jan 1 2022

deadalnix accepted D116482: [LLVM-C] Use NameLen in LLVMGetNamedGlobalAlias.

Thanks.

Jan 1 2022, 2:05 PM · Restricted Project

Oct 15 2021

deadalnix requested changes to D73861: Added DIBasicType scale/picture_string/digits/sign attribute support..
Oct 15 2021, 1:37 PM · Restricted Project, debug-info

Oct 14 2021

deadalnix added a comment to D25261: [C API] Add LLVMConstBinOp function..

Wouldn't LLVMBuildBinOp build a constant if both operand are constant and the operation allows for it? I have not double checked, but I think it does. Considering this, I'm not really sure what this brings to the table.

Oct 14 2021, 1:21 PM
deadalnix accepted D111751: [ptr_provenance] Add llvm-c support..

I think using nullptr would be preferable, but this looks good. Thanks.

Oct 14 2021, 1:17 PM · Restricted Project, Restricted Project
deadalnix added inline comments to D103966: [llvm] Add new DI Flag IsZeroSize for D101237 [[no_unique_address]].
Oct 14 2021, 8:39 AM · Restricted Project
deadalnix added inline comments to D72207: [LLVM-C][bindings/go] Get metadata from a value.
Oct 14 2021, 7:07 AM · Restricted Project
deadalnix added a comment to D89252: [C API] Add getters and setters for NUW, NSW, and Exact.

This is something that I wanted to do for a long but never had time to. Thanks.

Oct 14 2021, 7:01 AM · Restricted Project, Restricted Project
deadalnix accepted D89252: [C API] Add getters and setters for NUW, NSW, and Exact.
Oct 14 2021, 7:00 AM · Restricted Project, Restricted Project
deadalnix added a comment to D91514: Expose CastInst::getCastOpcode in C API.

It would be good to have a test case for this.

Oct 14 2021, 6:58 AM · Restricted Project, Restricted Project
deadalnix requested changes to D111751: [ptr_provenance] Add llvm-c support..
Oct 14 2021, 6:48 AM · Restricted Project, Restricted Project
deadalnix accepted D111159: [UnknownProvenance] Introduce UnknownProvenance constant.
Oct 14 2021, 6:42 AM · Restricted Project, Restricted Project

Oct 13 2021

deadalnix added inline comments to D111159: [UnknownProvenance] Introduce UnknownProvenance constant.
Oct 13 2021, 3:13 AM · Restricted Project, Restricted Project
deadalnix requested changes to D111162: [UnknownProvenance] Add llvm-c support.
Oct 13 2021, 3:11 AM · Restricted Project

Oct 12 2021

deadalnix requested changes to D111159: [UnknownProvenance] Introduce UnknownProvenance constant.
Oct 12 2021, 3:36 PM · Restricted Project, Restricted Project

Dec 9 2019

deadalnix updated the diff for D70921: [DAGCombiner] Add node back in the worklist in topological order in CommitTargetLoweringOpt.

Ping, rebase

Dec 9 2019, 7:00 AM · Restricted Project

Dec 2 2019

deadalnix created D70921: [DAGCombiner] Add node back in the worklist in topological order in CommitTargetLoweringOpt.
Dec 2 2019, 1:15 PM · Restricted Project

Nov 24 2019

deadalnix added a comment to D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles..

That is indeed the step I was missing. Thanks everybody for getting me up to speed.

Nov 24 2019, 9:51 AM · Restricted Project

Nov 23 2019

deadalnix added a comment to D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles..

Alright, this is the first time I have to commit something with the new github process, and I have to admit, I do not know how to do it - or if I can do it at all. Running git llvm push ask me for a username and password, and my old one do not work. What's the next step for me here?

Did you ever pushed anything to github before, to any other repository?
Did you clone https://github.com/llvm/llvm-project/ via HTTPS or SSH? (should be former!)
It is likely asking for your github login and password.

You may *really* want to follow https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line to create credentials with which you can *only* commit, but do nothing else

Nov 23 2019, 4:37 PM · Restricted Project
deadalnix added a comment to D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles..

Alright, this is the first time I have to commit something with the new github process, and I have to admit, I do not know how to do it - or if I can do it at all. Running git llvm push ask me for a username and password, and my old one do not work. What's the next step for me here?

Nov 23 2019, 10:57 AM · Restricted Project

Nov 22 2019

deadalnix updated the diff for D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles..

Address some of the comments

Nov 22 2019, 3:37 PM · Restricted Project

Nov 20 2019

deadalnix added a comment to D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY.

I'm a bit late to the party, but this is nothing short of amazing. Congratulations!

Nov 20 2019, 4:53 PM · Restricted Project

Nov 19 2019

deadalnix added a comment to D70012: [DAGCombiner] Propagate carry flag for 3+ additions.

Also while I'm at it, first sorry for taking so long to review, I missed that patch. Second, if I understand properly, getting node to be processed in the right order actually can collapse arbitrary long addition chains, but it's not clear how to get there, there is a bit of a wack a mole problem that start poping up every time.

Nov 19 2019, 3:55 PM · Restricted Project
deadalnix added a comment to D70012: [DAGCombiner] Propagate carry flag for 3+ additions.

Can you please explain a bit more what this is doing? This seems interesting, but I'm not quite sure the pattern is correct.

Nov 19 2019, 3:46 PM · Restricted Project

Oct 22 2019

deadalnix updated the diff for D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles..

O => Op

Oct 22 2019, 3:27 PM · Restricted Project
deadalnix accepted D62450: [DAGCombine][ARM] x ==/!= c -> (x - c) ==/!= 0 iff '-c' can be folded into the x node..

It's indeed not clear if what you have is the result of the legalizer. In this case just proceed.

Oct 22 2019, 8:28 AM · Restricted Project
deadalnix updated the diff for D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles..

Add a few comments

Oct 22 2019, 4:03 AM · Restricted Project

Oct 10 2019

deadalnix updated the diff for D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles..

Rebase and ping.

Oct 10 2019, 11:22 AM · Restricted Project
deadalnix committed rL374340: [DAGCombine] Match more patterns for half word bswap.
[DAGCombine] Match more patterns for half word bswap
Oct 10 2019, 6:19 AM

Oct 8 2019

deadalnix updated the diff for D68250: [DAGCombine] Match more patterns for half word bswap.

Fix erroneously inverted condition and ensuring previously broken tests are now passing again.

Oct 8 2019, 9:47 AM · Restricted Project
deadalnix committed rL374074: (Re)generate various tests. NFC.
(Re)generate various tests. NFC
Oct 8 2019, 9:23 AM
deadalnix updated the diff for D68232: [DAGCombine] Match a greater range of rotate when not all bits are demanded..

Add test for vector - but nothing changes for them (see rL374043 ) and use isSubsetOf and getAllOnesValue.

Oct 8 2019, 7:10 AM · Restricted Project
deadalnix added inline comments to D68232: [DAGCombine] Match a greater range of rotate when not all bits are demanded..
Oct 8 2019, 6:33 AM · Restricted Project
deadalnix committed rL374043: Add test for rotating truncated vectors. NFC.
Add test for rotating truncated vectors. NFC
Oct 8 2019, 6:14 AM

Oct 7 2019

deadalnix committed rL373908: Regenerate ptr-rotate.ll . NFC.
Regenerate ptr-rotate.ll . NFC
Oct 7 2019, 10:14 PM

Oct 6 2019

deadalnix committed rL373850: [DAGCombine] Match more patterns for half word bswap.
[DAGCombine] Match more patterns for half word bswap
Oct 6 2019, 7:12 AM
deadalnix closed D68250: [DAGCombine] Match more patterns for half word bswap.
Oct 6 2019, 7:12 AM · Restricted Project

Oct 2 2019

deadalnix updated the diff for D68250: [DAGCombine] Match more patterns for half word bswap.

Use isConstOrConstSplat and getAPIntValue

Oct 2 2019, 4:34 AM · Restricted Project

Sep 30 2019

deadalnix created D68250: [DAGCombine] Match more patterns for half word bswap.
Sep 30 2019, 3:54 PM · Restricted Project
deadalnix committed rL373271: Add partial bswap test to the X86 backend. NFC.
Add partial bswap test to the X86 backend. NFC
Sep 30 2019, 3:52 PM
deadalnix committed rL373269: [DAGCombiner] Clang format MatchRotate. NFC.
[DAGCombiner] Clang format MatchRotate. NFC
Sep 30 2019, 2:42 PM
deadalnix updated the diff for D68232: [DAGCombine] Match a greater range of rotate when not all bits are demanded..

Rebase on top of NFC changes

Sep 30 2019, 2:42 PM · Restricted Project
deadalnix committed rL373260: [DAGCombiner] Update MatchRotate so that it returns an SDValue. NFC.
[DAGCombiner] Update MatchRotate so that it returns an SDValue. NFC
Sep 30 2019, 1:46 PM
deadalnix added inline comments to D68232: [DAGCombine] Match a greater range of rotate when not all bits are demanded..
Sep 30 2019, 1:24 PM · Restricted Project
deadalnix created D68232: [DAGCombine] Match a greater range of rotate when not all bits are demanded..
Sep 30 2019, 9:41 AM · Restricted Project
deadalnix committed rL373223: Add tests for rotate with demanded bits. NFC.
Add tests for rotate with demanded bits. NFC
Sep 30 2019, 9:25 AM

Sep 29 2019

deadalnix created D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles..
Sep 29 2019, 11:02 AM · Restricted Project
deadalnix committed rL373171: Add test case peeking through vector concat when combining insert into shuffles..
Add test case peeking through vector concat when combining insert into shuffles.
Sep 29 2019, 10:52 AM

Sep 19 2019

deadalnix committed rL372327: [DAGCombiner] Add node to the worklist in topological order in….
[DAGCombiner] Add node to the worklist in topological order in…
Sep 19 2019, 7:23 AM
deadalnix closed D66661: [DAGCombiner] Add node to the worklist in topological order in scalarizeExtractedVectorLoad.
Sep 19 2019, 7:23 AM · Restricted Project

Sep 3 2019

deadalnix added a comment to D62392: [DAGCombine][ARM] (sub Carry, X) -> (addcarry (sub 0, X), 0, Carry) fold.

Ping ?

Sep 3 2019, 7:04 PM · Restricted Project

Aug 31 2019

deadalnix committed rL370578: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..
[DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate.
Aug 31 2019, 4:39 AM
deadalnix closed D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..
Aug 31 2019, 4:38 AM · Restricted Project
deadalnix added inline comments to D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..
Aug 31 2019, 4:10 AM · Restricted Project

Aug 30 2019

deadalnix added inline comments to D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..
Aug 30 2019, 2:02 PM · Restricted Project
deadalnix added inline comments to D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..
Aug 30 2019, 10:13 AM · Restricted Project
deadalnix updated the diff for D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..

Add tests for the commutative case.
Precommit tests.

Aug 30 2019, 6:55 AM · Restricted Project
deadalnix committed rL370464: [X86] Add tests for rotate matching. NFC.
[X86] Add tests for rotate matching. NFC
Aug 30 2019, 4:37 AM

Aug 29 2019

deadalnix updated the diff for D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..

Tighten the checks before creating the node.

Aug 29 2019, 9:42 AM · Restricted Project
deadalnix updated the diff for D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..
  • Avoid creating the shift node when not stricly required.
  • Add negative tests.
Aug 29 2019, 5:20 AM · Restricted Project
deadalnix added a comment to D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..

I looked at the problem that @spatel ran into. It is not applicable to DAGCombiner, because the DAG is processed only once rather than in a loop as long as it is modified. I wouldn't be possible to change it to work like InstCombine does as there are a ton of A -> B -> A type of tranforms. That being said, it's not a good reason to add more, so it's worth looking into improving this if possible.

Aug 29 2019, 3:45 AM · Restricted Project
deadalnix added a comment to D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..

Pattern look good to me, but i recall having disscussion in https://reviews.llvm.org/D64275#inline-576684
Granted, that is InstCombine, but what happens here if we create instruction but then fail to fold?

Aug 29 2019, 3:40 AM · Restricted Project
deadalnix committed rL370326: [DAGCombiner] (insert_vector_elt (vector_shuffle X, Y), (extract_vector_elt X….
[DAGCombiner] (insert_vector_elt (vector_shuffle X, Y), (extract_vector_elt X…
Aug 29 2019, 3:35 AM
deadalnix closed D66718: [DAGCombiner] (insert_vector_elt (vector_shuffle X, Y), (extract_vector_elt X, N), IdxC) -> (vector_shuffle X, Y).
Aug 29 2019, 3:35 AM · Restricted Project

Aug 28 2019

deadalnix updated the diff for D66718: [DAGCombiner] (insert_vector_elt (vector_shuffle X, Y), (extract_vector_elt X, N), IdxC) -> (vector_shuffle X, Y).

IndexC => ExtrIndex

Aug 28 2019, 9:06 AM · Restricted Project
deadalnix created D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate..
Aug 28 2019, 7:03 AM · Restricted Project
deadalnix committed rL370203: [X86] Add test for rotate combining when add X, X is used instead of shl X, 1..
[X86] Add test for rotate combining when add X, X is used instead of shl X, 1.
Aug 28 2019, 6:54 AM
deadalnix added inline comments to D66718: [DAGCombiner] (insert_vector_elt (vector_shuffle X, Y), (extract_vector_elt X, N), IdxC) -> (vector_shuffle X, Y).
Aug 28 2019, 5:03 AM · Restricted Project
deadalnix committed rL370190: [TargetLowering] Add buildLegalVectorShuffle facility to help build legal….
[TargetLowering] Add buildLegalVectorShuffle facility to help build legal…
Aug 28 2019, 5:01 AM
deadalnix closed D66804: [TargetLowering] Add buildLegalVectorShuffle facility to help build legal shuffles.
Aug 28 2019, 5:00 AM · Restricted Project
deadalnix updated the diff for D66804: [TargetLowering] Add buildLegalVectorShuffle facility to help build legal shuffles.

Upadte the doc comment to make it clear that the Mask argument can be modified.

Aug 28 2019, 4:56 AM · Restricted Project

Aug 27 2019

deadalnix added a comment to D66537: [DAGCombiner] Remove a bunch of redundant AddToWorklist calls..

@nathanchance Thanks for this. Having a test case will help tremendously. Sorry for the inconvenience.

Aug 27 2019, 3:34 PM · Restricted Project
deadalnix updated the diff for D66718: [DAGCombiner] (insert_vector_elt (vector_shuffle X, Y), (extract_vector_elt X, N), IdxC) -> (vector_shuffle X, Y).

Rebase on top of D66804

Aug 27 2019, 8:03 AM · Restricted Project
deadalnix created D66804: [TargetLowering] Add buildLegalVectorShuffle facility to help build legal shuffles.
Aug 27 2019, 7:50 AM · Restricted Project