User Details
- User Since
- Feb 13 2015, 12:29 AM (423 w, 6 d)
Feb 14 2023
Rebase
Feb 7 2023
remove erroneous autogen note.
rebase
Jan 30 2023
One more rebase and upgradign tests:
- Several tests where converted to opaque pointer type.
- rG37bc62ed0a24303aa572155009358b8937ab8b4c
Jan 25 2023
This is looking good. I'm going to accept as it, but it'd be better to wait a little to give the opportunity for someone more familiar with this to shime in.
Jan 24 2023
Rebase on top of the fix for v8i1-masks.ll
Jan 22 2023
Rebase on top of @RKSimon 's element shuffle work.
Jan 19 2023
Rebase, bitreverse.ll is definitively fixed.
Jan 17 2023
If you are not sure, I'm not going to land this right away to give anyone who has concern the opportunity to comment.
rebase on top of D141884
Jan 16 2023
Jan 15 2023
Jan 14 2023
Jan 13 2023
Jan 11 2023
Jan 10 2023
One less regression, two more regressions :P
Jan 9 2023
Rebase on top of D140993 and a recent version of main,
and regenerate tests accordingly.
Specialize the transform, which avoids problems with the transform creating an infinite loop.
Jan 4 2023
Yes, it shouldn't in itself, but throw another transform in the loop, and it may well be.
Ok Let's try to make a list of what we want to see fixed before we proceed.
- AMDGPU: widen-smrd-loads.ll ? It doesn't look so bad, but having someone familiar with that target would help. I'm also not sure about the changes related to stores.
- ARM: Seems like wins accross the board by now.
- Hexagon: autohvx/mulh.ll needs someone to look into it.
- PowerPC: is the change in aix32-cc-abi-vaarg.ll a problem? The regression in store-forward-be64.ll is addressed by D140993
- RISCV: Seems like wins accross the board.
- SystemZ: No meaningful changes.
- Thumb2: mve-vst3.ll is worth looking into.
- X86: bitreverse.ll, dagcombine-select.ll, insert-into-constant-vector.ll, insertelement-var-index.ll, pr53419.ll, v8i1-masks.ll, vector-shuffle-combining.ll looks bad.
rebase
Ok, it turns out I'm an idiot and the correct transformation is already done. Sorry everybody.
Lesson of the day, don't submit patches at 3am. It'll get this sorted out.
Jan 3 2023
@RKSimon Yes, I can do that in January. There is one thing I'm not sure of, where do we put the bar for this to be merged? If we want no regression at all, this is going to be very difficult to get it past the line.
Nov 28 2022
The change that are relatively small all come either better or equivalent. While it's hard to evaluate the giant multiplications ones, this definitively looks like a win.
Nov 5 2022
Rebase and cleanup
rebase
Oct 3 2022
Long awaited rebase
Sep 27 2022
Add a test case for this spercifically in select_const and modify cmov-promotion so that this optimization doesn't kick in.
Sep 26 2022
Precommit trivial changes and rebase
Fix the latest broken test
Update the condition in which we transform select to math as to preserve opportunities to optimize select_cc
Sep 24 2022
@RKSimon I'll try what you suggest tomorrow. I've been sick so things are moving slowly on my end. Apologies.
Sep 9 2022
Sep 7 2022
When select_cc takes precedence
What happens if select -> arithmetic takes priority
Sep 1 2022
Dear PowerPC folks, your help would be greatly appreciated here.
Aug 24 2022
Aug 23 2022
I restored the select_cc creation, but now it generates some select_cc that the powerpc backend doesn't quite know what to do with.
Aug 22 2022
Aug 15 2022
Fix CodeGen/PowerPC/aix32-cc-abi-vaarg.ll
rebase
Aug 10 2022
rebase
Aug 9 2022
Alive is happy with the correctness of the transform, should we land this or are there extra concerns to be addressed?
Aug 8 2022
- Limit the transform to 32bits and 64bits.
- Add 64 bits test cases.
Aug 7 2022
Update comment and use auto
Rebase on top of D131358
Aug 6 2022
Aug 5 2022
Reabse and variosu tweaks.
Could you add the new tests in main, on their own, then rebase that patch in top of this, so we can see what the effect is?
Aug 3 2022
This didn't look like it was getting much traction. Processing things in topological order should provide a good chunk of the value, so we should revisit later.
Jul 29 2022
Fix CodeGen/PowerPC/nofpexcept.ll
Avoid complex combines when we expect to fold into select_cc
Jul 28 2022
Jul 27 2022
Should I proceed with this? This isn't vital, but it is fairly trivial, and seems better to me.
Jul 26 2022
Jul 24 2022
Rebase