Page MenuHomePhabricator

jdoerfert (Johannes Doerfert)
Argonne National Laboratory

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2014, 6:27 AM (439 w, 1 d)

Recent Activity

Wed, Jun 29

jdoerfert added inline comments to D128549: [Libomptarget] Implement a unified kernel entry function.
Wed, Jun 29, 6:58 AM · Restricted Project, Restricted Project

Tue, Jun 28

jdoerfert added a comment to rGd08f34b592ff: [llvm] Don't use Optional::hasValue (NFC).

Where is the discussion and rational for this?

Please see https://reviews.llvm.org/D128131. Thanks!

Tue, Jun 28, 4:13 PM · Restricted Project, Restricted Project
jdoerfert reopened D128131: [ADT] Add has_value, value, value_or to llvm::Optional.

Sounds good. Though it might be worth migrating/normalising uses to op* (rather than value()) and bool testing (where it do any have to be explicit) instead of has_value() when migrating callers.

Tue, Jun 28, 4:11 PM · Restricted Project, Restricted Project
jdoerfert committed rG178674e23a71: [OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests (authored by jdoerfert).
[OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests
Tue, Jun 28, 3:20 PM · Restricted Project, Restricted Project
jdoerfert closed D128685: [OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests.
Tue, Jun 28, 3:19 PM · Restricted Project, Restricted Project
jdoerfert committed rGb0ce93226cee: [UpdateTestChecks] Handle prefix reuse for appended check lines (authored by jdoerfert).
[UpdateTestChecks] Handle prefix reuse for appended check lines
Tue, Jun 28, 3:19 PM · Restricted Project, Restricted Project
jdoerfert closed D128684: [UpdateTestChecks] Handle prefix reuse for appended check lines.
Tue, Jun 28, 3:19 PM · Restricted Project, Restricted Project
jdoerfert added inline comments to rGd08f34b592ff: [llvm] Don't use Optional::hasValue (NFC).
Tue, Jun 28, 3:17 PM · Restricted Project, Restricted Project
jdoerfert raised a concern with rGd08f34b592ff: [llvm] Don't use Optional::hasValue (NFC).

Where is the discussion and rational for this?

Tue, Jun 28, 3:08 PM · Restricted Project, Restricted Project
jdoerfert accepted D124624: [OpenMP] Add variant extension that applies to declarations.

LG. one nit.

Tue, Jun 28, 2:20 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 27

jdoerfert updated the summary of D128684: [UpdateTestChecks] Handle prefix reuse for appended check lines.
Mon, Jun 27, 4:15 PM · Restricted Project, Restricted Project
jdoerfert added a comment to D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests.

I'm not so sure but phab things this is small, so no complaints:

Mon, Jun 27, 4:10 PM · Restricted Project, Restricted Project
jdoerfert requested review of D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests.
Mon, Jun 27, 4:07 PM · Restricted Project, Restricted Project
jdoerfert requested review of D128685: [OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests.
Mon, Jun 27, 4:05 PM · Restricted Project, Restricted Project
jdoerfert requested review of D128684: [UpdateTestChecks] Handle prefix reuse for appended check lines.
Mon, Jun 27, 4:04 PM · Restricted Project, Restricted Project
jdoerfert accepted D122764: [OpenMP][CUDA] Fix the issue that P2P memcpy doesn't work.

LG

Mon, Jun 27, 1:32 PM · Restricted Project, Restricted Project

Fri, Jun 24

jdoerfert accepted D127274: [MemoryBuiltins] Accept any value in getInitialValueOfAllocation() (NFC).

LG

Fri, Jun 24, 5:59 AM · Restricted Project, Restricted Project

Thu, Jun 23

jdoerfert added a comment to D128128: [GlobalOpt] Perform store->dominated load forwarding for stored once globals.

Yeah, the non-constant case needs both nosync and norecurse.

Thu, Jun 23, 6:25 AM · Restricted Project, Restricted Project

Wed, Jun 22

jdoerfert added a comment to D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode.

Do we want JIT -> YES, but specalizing LLVM-IR JIT.
Do we want/need PTX, I do not, but I don't mind having it. Someone will ask for it eventually.

Wed, Jun 22, 12:55 PM · Restricted Project, Restricted Project
jdoerfert added a comment to rG083010312aa4: [Attributor] Ensure to use the proper liveness AA.

The leaks are still there, reverting.

Wed, Jun 22, 12:38 PM · Restricted Project, Restricted Project

Tue, Jun 21

jdoerfert added a comment to D128128: [GlobalOpt] Perform store->dominated load forwarding for stored once globals.

^^^ so much for stored once

Tue, Jun 21, 8:51 PM · Restricted Project, Restricted Project
jdoerfert committed rGb7cc3b10c549: [Attributor][FIX] Avoid empty bin in AAPointerInfo (authored by jdoerfert).
[Attributor][FIX] Avoid empty bin in AAPointerInfo
Tue, Jun 21, 7:31 PM · Restricted Project, Restricted Project
jdoerfert committed rG083010312aa4: [Attributor] Ensure to use the proper liveness AA (authored by jdoerfert).
[Attributor] Ensure to use the proper liveness AA
Tue, Jun 21, 7:31 PM · Restricted Project, Restricted Project
jdoerfert added a comment to D128128: [GlobalOpt] Perform store->dominated load forwarding for stored once globals.

I think I misread it earlier. Constant & !thread_dependent *or* nosync. This makes more sense.

Tue, Jun 21, 3:12 PM · Restricted Project, Restricted Project
jdoerfert added inline comments to D128128: [GlobalOpt] Perform store->dominated load forwarding for stored once globals.
Tue, Jun 21, 1:26 PM · Restricted Project, Restricted Project
jdoerfert accepted D128128: [GlobalOpt] Perform store->dominated load forwarding for stored once globals.

LG, I think :)

Tue, Jun 21, 11:58 AM · Restricted Project, Restricted Project
jdoerfert reopened D128128: [GlobalOpt] Perform store->dominated load forwarding for stored once globals.
Tue, Jun 21, 6:29 AM · Restricted Project, Restricted Project
jdoerfert added a comment to D128128: [GlobalOpt] Perform store->dominated load forwarding for stored once globals.

This breaks in the presence of synchronization.

Tue, Jun 21, 6:28 AM · Restricted Project, Restricted Project

Tue, Jun 14

jdoerfert added a comment to D127399: [OpenMP] Ensure createXXX functions will always call updateToLocation.

LG. I have one question. Is there a contract in place where the InsertionPointGuard is used to reset the IP back to the one at entry and would this change break it?

Tue, Jun 14, 3:27 PM · Restricted Project, Restricted Project
jdoerfert added a comment to D126984: [clang] Add support for optimize function attribute.

FWIW, I think we should have these attributes as spelled here, just w/ proper pass manager integration which then requires an RFC.
That said, I'm not opposed to this as an incremental step, albeit confusing until the PM support is integrated if we allow O1/2/3/fast

Tue, Jun 14, 3:25 PM · Restricted Project, Restricted Project

Mon, Jun 13

jdoerfert updated subscribers of D126984: [clang] Add support for optimize function attribute.
Mon, Jun 13, 2:55 PM · Restricted Project, Restricted Project
jdoerfert added a comment to D126984: [clang] Add support for optimize function attribute.

IIRC in the past there was a strong preference to not have the pass manager support this sort of thing
if you want to support this, there should be an RFC for how the optimization part of this will work as it may require invasive changes to the LLVM pass manager

(if this is purely a clang frontend thing then ignore me)

Mon, Jun 13, 2:45 PM · Restricted Project, Restricted Project
jdoerfert added inline comments to D127432: [Libomptarget] Add support for offloading binaries in libomptarget.
Mon, Jun 13, 7:44 AM · Restricted Project, Restricted Project

Thu, Jun 9

jdoerfert added a reverting change for rGda50dab1ae11: [Attributor] Replace AAValueSimplify with AAPotentialValues: rG6555558a8058: Revert "[Attributor] Replace AAValueSimplify with AAPotentialValues".
Thu, Jun 9, 8:04 AM · Restricted Project, Restricted Project
jdoerfert committed rG6555558a8058: Revert "[Attributor] Replace AAValueSimplify with AAPotentialValues" (authored by jdoerfert).
Revert "[Attributor] Replace AAValueSimplify with AAPotentialValues"
Thu, Jun 9, 8:04 AM · Restricted Project, Restricted Project
jdoerfert committed rGda50dab1ae11: [Attributor] Replace AAValueSimplify with AAPotentialValues (authored by jdoerfert).
[Attributor] Replace AAValueSimplify with AAPotentialValues
Thu, Jun 9, 7:49 AM · Restricted Project, Restricted Project
jdoerfert committed rG94841c713fdd: [Attributor] Try to delete stores and simplify stored values (authored by jdoerfert).
[Attributor] Try to delete stores and simplify stored values
Thu, Jun 9, 7:49 AM · Restricted Project, Restricted Project
jdoerfert committed rGa3273c0c0600: [Attributor] Ensure to use the proper liveness AA (authored by jdoerfert).
[Attributor] Ensure to use the proper liveness AA
Thu, Jun 9, 7:49 AM · Restricted Project, Restricted Project
jdoerfert committed rGae10b8a58240: [Attributor][FIX] Give registered simplification callbacks precedence (authored by jdoerfert).
[Attributor][FIX] Give registered simplification callbacks precedence
Thu, Jun 9, 6:32 AM · Restricted Project, Restricted Project
jdoerfert requested review of D127399: [OpenMP] Ensure createXXX functions will always call updateToLocation.
Thu, Jun 9, 4:55 AM · Restricted Project, Restricted Project
jdoerfert committed rG982053e85e65: [Attributor][NFC] Improve debug code and comments (authored by jdoerfert).
[Attributor][NFC] Improve debug code and comments
Thu, Jun 9, 4:42 AM · Restricted Project, Restricted Project
jdoerfert committed rG393be12b749c: [Attributor] Look at base values for align, nonnull, and deref (authored by jdoerfert).
[Attributor] Look at base values for align, nonnull, and deref
Thu, Jun 9, 4:42 AM · Restricted Project, Restricted Project
jdoerfert committed rG0ece283f0326: [Attributor] Add checks needed as we strengthen value simplify (authored by jdoerfert).
[Attributor] Add checks needed as we strengthen value simplify
Thu, Jun 9, 4:42 AM · Restricted Project, Restricted Project
jdoerfert committed rGcb8adf76f71e: [Attributor] Simplify loads from constant globals (authored by jdoerfert).
[Attributor] Simplify loads from constant globals
Thu, Jun 9, 4:42 AM · Restricted Project, Restricted Project
jdoerfert committed rG14899bc43d24: [Attributor] Generalize interface from ConstantInt to Constant (authored by jdoerfert).
[Attributor] Generalize interface from ConstantInt to Constant
Thu, Jun 9, 3:04 AM · Restricted Project, Restricted Project
jdoerfert committed rG7a07b88f37c0: [Attributor][FIX] Replace call site argument uses, not values (authored by jdoerfert).
[Attributor][FIX] Replace call site argument uses, not values
Thu, Jun 9, 3:04 AM · Restricted Project, Restricted Project
jdoerfert committed rG1df6e171c338: [Attributor] Simplify (integer range) state handling (authored by jdoerfert).
[Attributor] Simplify (integer range) state handling
Thu, Jun 9, 3:04 AM · Restricted Project, Restricted Project
jdoerfert committed rG481b8f31dff4: [Attributor][NFC] Introduce helper struct (authored by jdoerfert).
[Attributor][NFC] Introduce helper struct
Thu, Jun 9, 3:04 AM · Restricted Project, Restricted Project
jdoerfert committed rG4277c1be881b: [Attributor][FIX] Avoid metadata and duplicate replication assertion (authored by jdoerfert).
[Attributor][FIX] Avoid metadata and duplicate replication assertion
Thu, Jun 9, 3:04 AM · Restricted Project, Restricted Project

Tue, Jun 7

jdoerfert accepted D126873: [OpenMP] Fix the build on Windows.

This seems to be uncontroversial. LGTM

Tue, Jun 7, 2:06 AM · Restricted Project, Restricted Project

May 27 2022

jdoerfert accepted D126547: [OpenACC][OpenMP] Document atomic-in-teams extension.
May 27 2022, 8:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 25 2022

jdoerfert added a comment to D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'.

Cool! Can we have that for begin declare variant too :D ?

May 25 2022, 2:33 PM · Restricted Project, Restricted Project

May 20 2022

jdoerfert retitled D126079: [NFC][LLVM] Merge shouldExpandAtomic*InIR into shouldExpandAtomicInstInIR from [NFC][LLVM] Renmae all shouldExpandAtomic*InIR to shouldExpandAtomicInstInIR to [NFC][LLVM] Rename all shouldExpandAtomic*InIR to shouldExpandAtomicInstInIR.
May 20 2022, 11:40 AM · Restricted Project, Restricted Project

May 19 2022

jdoerfert accepted D125937: [NVVM] Update intrinsic defintions to include the `nocallback` attribute.

LGTM

May 19 2022, 8:59 AM · Restricted Project, Restricted Project

May 18 2022

Herald added a project to D109987: [NVVM] Update intrinsic definitions to include more attributes: Restricted Project.
May 18 2022, 12:16 PM · Restricted Project, Restricted Project
jdoerfert added inline comments to D125252: [Libomptarget] Add basic support for dynamic shared memory on AMDGPU.
May 18 2022, 7:04 AM · Restricted Project, Restricted Project

May 16 2022

jdoerfert accepted D125705: [OpenMP] Don't build the offloading driver without a source input.

LG

May 16 2022, 10:20 AM · Restricted Project, Restricted Project
jdoerfert accepted D125698: [Libomptarget] Don't build the device runtime without a new Clang.

Typos in the commit message.
s/new Clang/matching Clang/ ?

May 16 2022, 9:00 AM · Restricted Project, Restricted Project
jdoerfert accepted D125652: [LLVM] Add a check if should cast atomic operations to integer type.

LG

May 16 2022, 7:17 AM · Restricted Project, Restricted Project

May 13 2022

jdoerfert accepted D125333: [OpenMP] Use the new OpenMP device static library when doing LTO.

LG, nice!

May 13 2022, 7:37 AM · Restricted Project, Restricted Project

May 12 2022

jdoerfert accepted D125467: [openmp] Fix strict aliasing issue in cmpxchg routine.

LG

May 12 2022, 6:41 AM · Restricted Project, Restricted Project

May 11 2022

jdoerfert added a comment to D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs.

What I would suggest, if you want to use C/C++ attributes (which makes sense to me), is an attribute that avoids undef or introduces frozen:

I would prefer to avoid this approach for the moment. Such an attribute is highly focused on how the backend works and I'm not convinced that users in general would know when or how to properly use it. I believe all of the functions which need to be marked are known, and so we can keep an internal list of "interesting" functions that need special attention during clang codegen. If we later find that there's a wider need that cannot be handled transparently like this, we can reevaluate what to expose to users via an attribute at that point.

May 11 2022, 11:41 AM · Restricted Project, Restricted Project, Restricted Project
jdoerfert added a comment to D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs.

Please specify the semantics of the new LLVM attribute in LangRef -- though I don't really understand why you need an LLVM-side attribute at all.

+1. I doubt this patch is helpful.

Shuffle attribute has been added as per suggestions/comments from review: D124158

I failed to see where this was suggested.


My suggestion was and still is summarized in: https://reviews.llvm.org/D124158#3486110

@jdoerfert I meant to convey that, As a solution to review comments from D124158, introduced this shuffle attribute to identify __shfl_sync like APIs.

May 11 2022, 8:42 AM · Restricted Project, Restricted Project, Restricted Project
jdoerfert requested changes to D125378: [Attribute] Introduce shuffle attribute to be used for __shfl_sync like cross-lane APIs.

Please specify the semantics of the new LLVM attribute in LangRef -- though I don't really understand why you need an LLVM-side attribute at all.

May 11 2022, 7:26 AM · Restricted Project, Restricted Project, Restricted Project

May 10 2022

jdoerfert accepted D125339: [Libomptarget] Address existing warnings in the device runtime library.

LG

May 10 2022, 2:51 PM · Restricted Project, Restricted Project
jdoerfert accepted D125314: [OpenMP] Don't set device runtime debugging flags if using '-nogpulib'.

LG

May 10 2022, 9:20 AM · Restricted Project, Restricted Project
jdoerfert accepted D125260: [Libomptarget] Allow the device runtime to be compiled for the host.

I think we are lacking a good way to do what I want, let's go ahead with forward declares for now.

May 10 2022, 9:15 AM · Restricted Project, Restricted Project
jdoerfert added a comment to D125260: [Libomptarget] Allow the device runtime to be compiled for the host.

I'm not super happy about the forward decls. Should we augment begin declare tatrget with begin declare variant match(device={kind(nohost)}) instead?

May 10 2022, 7:55 AM · Restricted Project, Restricted Project
jdoerfert added inline comments to D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.
May 10 2022, 7:14 AM · Restricted Project, Restricted Project, Restricted Project
jdoerfert accepted D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.

LG

May 10 2022, 7:14 AM · Restricted Project, Restricted Project, Restricted Project
jdoerfert added a comment to D125314: [OpenMP] Don't set device runtime debugging flags if using '-nogpulib'.

Not actually tested, is it?

May 10 2022, 7:03 AM · Restricted Project, Restricted Project
jdoerfert added a comment to D125165: [Clang] Introduce clang-offload-packager tool to bundle device files.

Conceptually fine with me, @tra?

May 10 2022, 6:29 AM · Restricted Project, Restricted Project

May 6 2022

jdoerfert added a comment to D125009: [ArgPromotion] Use common alignment for loads in caller.

I though this is illegal to use align 4 loads for align 32 arguments.

May 6 2022, 9:08 AM · Restricted Project, Restricted Project
jdoerfert updated the summary of D125009: [ArgPromotion] Use common alignment for loads in caller.
May 6 2022, 9:06 AM · Restricted Project, Restricted Project
jdoerfert added a comment to D123812: [CUDA] Add wrapper code generation for registering CUDA images.

Are there unresolved concerns we should address in this review?

May 6 2022, 8:07 AM · Restricted Project, Restricted Project
jdoerfert accepted D125092: [OpenMP] Add basic support for properly handling static libraries.

Typo(s) in the commit message, otherwise this seems reasonable. LG

May 6 2022, 8:00 AM · Restricted Project, Restricted Project

May 5 2022

jdoerfert added a comment to D107357: [getUnderlyingObject] support ptr_provenance.

I think this is fine, we can argue about the name but it won't matter much. A test would be nice though.

May 5 2022, 9:11 AM · Restricted Project, Restricted Project

May 2 2022

jdoerfert accepted D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses.

always use UIToFP because that is the only case that UpdateVal is a ConstantInt, where we created the constant integer for ++ or -- operation.

May 2 2022, 4:01 PM · Restricted Project, Restricted Project
jdoerfert added a comment to D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute.

I'm thinking noundef is a bit of red herring here. The real problem seems to be arising from the assume call which is inserted, which now introduces the assumption that the lane ID must be 0

The optimizer is creating the llvm.assume call based on the violation of the noundef attribute.

May 2 2022, 10:39 AM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

jdoerfert accepted D124689: [flang] Update Google Doc link for Flang Biweekly Sync call notes.

LG, FWIW, you can commit these right away.

Apr 29 2022, 11:22 AM · Restricted Project, Restricted Project
jdoerfert accepted D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver.

LG

Apr 29 2022, 7:27 AM · Restricted Project, Restricted Project

Apr 27 2022

jdoerfert added a comment to D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute.

The issue you're describing sounds like it's specific to @__shfl_sync. In general, in C++, you aren't allowed to read from an uninitialized variable; see [basic.indet] in the standard. But if your testcase doesn't have undefined behavior, CUDA language rules must somehow allow this particular builtin function to take undef variables as input. (Is this documented somewhere?)

That isn't related to the "convergent" attribute; the transform you're describing doesn't break convergence rules.

Apr 27 2022, 2:50 PM · Restricted Project, Restricted Project, Restricted Project
jdoerfert added inline comments to D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.
Apr 27 2022, 7:25 AM · Restricted Project, Restricted Project, Restricted Project
jdoerfert added a comment to D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute.

For Ex: SimplifyCFG pass removes the branch leading to a BB which has an incoming value that will always trigger undefined behavior. This basically modifies the CFG and combines the basic blocks. This works for CPU execution. But on a GPU, there are intrinsics like "__shfl_sync(unsigned mask, T var, int srcLane, int width=warpSize)", Where the exchange of variable occurs simultaneously for all active threads within the warp. So, here in the cuda/hip kernel, variable var in shuffl_sync may not be initialised, and LLVM IR treats it as undef. Currently all the arguments are tagged with noundef attribute and the above mentioned optimization by SimplifyCFG gets applied and the kernel execution becomes ambiguous. So, the proposed change is to skip adding noundef attribute to arguments when a function has been tagged with convergent attribute.

Apr 27 2022, 7:19 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

jdoerfert accepted D124200: [Libomptarget][remote] Add OpenMP linker flag to the plugin.

LG

Apr 21 2022, 12:44 PM · Restricted Project, Restricted Project

Apr 19 2022

jdoerfert added a comment to D123284: [ArgPromotion][Attributor] Update min-legal-vector-width when do promotion.
Finally, I'd suggest to avoid the undef and UB.

Both argument promotion and lining are legal behavior. I think there's no undef/UB for single pass here.

Apr 19 2022, 7:41 AM · Restricted Project, Restricted Project

Apr 18 2022

jdoerfert added inline comments to D123284: [ArgPromotion][Attributor] Update min-legal-vector-width when do promotion.
Apr 18 2022, 1:20 PM · Restricted Project, Restricted Project

Apr 17 2022

jdoerfert updated the diff for D123446: [OpenMP][FIX] Remove shadow pointer map and introduce consistent locking.

Use set instead of map

Apr 17 2022, 2:38 PM · Restricted Project, Restricted Project
jdoerfert updated the diff for D123446: [OpenMP][FIX] Remove shadow pointer map and introduce consistent locking.

Fix rebase issues, address comments

Apr 17 2022, 1:06 PM · Restricted Project, Restricted Project
jdoerfert added inline comments to D123444: [OpenMP][FIX] Simplify the entry deletion scheme.
Apr 17 2022, 1:03 PM · Restricted Project, Restricted Project
jdoerfert updated the diff for D123444: [OpenMP][FIX] Simplify the entry deletion scheme.

Fix rebase issues

Apr 17 2022, 1:01 PM · Restricted Project, Restricted Project
jdoerfert updated the diff for D123443: [OpenMP][NFCI] Cleanup APIs and improve object encapsulation.

Fix rebase errors, address comments

Apr 17 2022, 12:33 PM · Restricted Project, Restricted Project
jdoerfert updated the diff for D123443: [OpenMP][NFCI] Cleanup APIs and improve object encapsulation.

Address comments

Apr 17 2022, 11:57 AM · Restricted Project, Restricted Project
jdoerfert committed rGe87f10a771f9: [Attributor] CGSCC pass should not recompute results outside the SCC (reapply) (authored by jdoerfert).
[Attributor] CGSCC pass should not recompute results outside the SCC (reapply)
Apr 17 2022, 11:52 AM · Restricted Project, Restricted Project

Apr 15 2022

jdoerfert committed rG81143b69dd83: [Attributor][FIX] Use AttributorConfig in the unit tests too (authored by jdoerfert).
[Attributor][FIX] Use AttributorConfig in the unit tests too
Apr 15 2022, 4:37 PM · Restricted Project, Restricted Project
jdoerfert committed rG3be3b401888a: [Attributor][NFCI] Introduce AttributorConfig to bundle all options (authored by jdoerfert).
[Attributor][NFCI] Introduce AttributorConfig to bundle all options
Apr 15 2022, 4:17 PM · Restricted Project, Restricted Project
jdoerfert accepted D122683: [OpenMP] Use new offloading binary when embedding offloading images.

LG

Apr 15 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
jdoerfert added inline comments to D122683: [OpenMP] Use new offloading binary when embedding offloading images.
Apr 15 2022, 2:53 PM · Restricted Project, Restricted Project, Restricted Project
jdoerfert added a reverting change for rG0d7f81e31315: [Attributor] CGSCC pass should not recompute results outside the SCC: rG39a68cc016ec: Revert "[Attributor] CGSCC pass should not recompute results outside the SCC".
Apr 15 2022, 1:30 PM · Restricted Project, Restricted Project
jdoerfert committed rG39a68cc016ec: Revert "[Attributor] CGSCC pass should not recompute results outside the SCC" (authored by jdoerfert).
Revert "[Attributor] CGSCC pass should not recompute results outside the SCC"
Apr 15 2022, 1:30 PM · Restricted Project, Restricted Project