- User Since
- Jan 30 2014, 6:27 AM (298 w, 4 d)
Sat, Oct 19
Mon, Oct 14
Small nits. Otherwise LGTM.
Also, make sure we have a test with 2 pointer arguments, one freed, one no-free annotated.
Fwiw, I'm OK with this (given that we have my requested changes in upcoming commits).
Sun, Oct 13
Minor updates and fixes
Rerun with fixed script to use argument variable names in body
Handle pointers with address spaces and make sure uses are pointer operands
Non-exact functions fix + more tests
Dropped in favor of D68925.
Sat, Oct 12
Fixes and check line update
Two minor comments from my side.
Fri, Oct 11
Thu, Oct 10
I went through all the tests, added mem2reg/sroa where approriate and modified the source sometimes, mostly to avoid UB. I think the results of the Attributor look good, all problems should have been addressed already.
I stole this and added it into D68819 as well.
Lessons learned by running it on all argument promotion files: D68766
Lessons learned from running *all* argument promotion tests, patches will follow
Include personality, fix versioning based on different args, tested on D68766
Rerun update with newest version of D68819
Thx for the initial feedback, I'll update this soon.
Fix all but 3 tests, unknown what the problem there is
I just run update on all of them and did not fix them yet. Please provide feedback if you have any, I'll update this revision asap.
Wed, Oct 9
Update tests, keep it in ValueSimplify for now
Add no-alias restriction and test
Can you add the test I provided as well?
Tue, Oct 8
Mon, Oct 7
I like this better. I'll review it tomorrow (I hope).