Page MenuHomePhabricator

jdoerfert (Johannes Doerfert)
Argonne National Laboratory

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2014, 6:27 AM (272 w, 1 d)

Recent Activity

Yesterday

jdoerfert added a comment to D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading.

To follow up on my comment why this is NVPTX specific:

Fri, Apr 19, 1:48 PM · Restricted Project
jdoerfert added inline comments to D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading.
Fri, Apr 19, 1:42 PM · Restricted Project
jdoerfert added inline comments to D60905: [OpenMP][LLVM][WIP] Add math functions support to OpenMP.
Fri, Apr 19, 1:34 PM · Restricted Project
jdoerfert added a comment to D59703: Optimize masked.loads and masked.gathers with a single active lane.

I'm not really an expert in InstCombine but it looks good to me. Someone else should probably take a look as well. I added some minor comments though.

Fri, Apr 19, 1:34 PM

Thu, Apr 18

jdoerfert added inline comments to D59918: [Attributor] Pass infrastructure and fixpoint framework.
Thu, Apr 18, 1:21 PM · Restricted Project
jdoerfert updated the diff for D59918: [Attributor] Pass infrastructure and fixpoint framework.

Improved and added various comments & documentation

Thu, Apr 18, 12:43 PM · Restricted Project

Wed, Apr 17

jdoerfert added a comment to D59918: [Attributor] Pass infrastructure and fixpoint framework.

It looks like this is a completely new approach to attribute inference compared to the post-order function atters pass?

Wed, Apr 17, 11:43 PM · Restricted Project
jdoerfert updated the diff for D59918: [Attributor] Pass infrastructure and fixpoint framework.

Initial high-level file comment, more to come!

Wed, Apr 17, 11:24 PM · Restricted Project
jdoerfert added a comment to D59903: [NFC][FnAttrs] Stress tests for attribute deduction.

Addressed most comments, some I replied back to. Let me know if I should change those things as well.

Wed, Apr 17, 8:06 PM · Restricted Project
jdoerfert updated the diff for D59903: [NFC][FnAttrs] Stress tests for attribute deduction.

Changes according to most of Chandler's comments

Wed, Apr 17, 7:51 PM · Restricted Project
jdoerfert added a comment to D60031: Split tailcallelim into tailcallmark and tailcallelim.

I inlined a question. Also, did you run the tests with assertions enabled?

Wed, Apr 17, 2:11 PM · Restricted Project

Tue, Apr 16

jdoerfert added a comment to D59918: [Attributor] Pass infrastructure and fixpoint framework.

I haven't been through the details yet, but I have a few high-level thoughts.

Tue, Apr 16, 6:29 PM · Restricted Project
jdoerfert accepted D60761: [FunctionAttrs] Remove readonly and writeonly assertion.

I hope D60076 doesn't have the same problem ;)

Tue, Apr 16, 5:50 AM · Restricted Project

Mon, Apr 15

jdoerfert added inline comments to D59919: [Attributor] Deduce "returned" argument attribute.
Mon, Apr 15, 10:11 AM · Restricted Project, Restricted Project
jdoerfert added inline comments to D60031: Split tailcallelim into tailcallmark and tailcallelim.
Mon, Apr 15, 10:11 AM · Restricted Project

Fri, Apr 12

jdoerfert added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch..
Fri, Apr 12, 12:06 PM · Restricted Project

Thu, Apr 11

jdoerfert added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

LGTM

Is there a way we can test this?

It is tested in the internal testsuite, don't know when it is going to be committed to trunk

There are two problems:

  1. The internal testsuite did run before this patch, right? So it is unclear what that means.

No, the tests ran with this patch.

Thu, Apr 11, 5:21 PM · Restricted Project
jdoerfert added inline comments to D59918: [Attributor] Pass infrastructure and fixpoint framework.
Thu, Apr 11, 4:24 PM · Restricted Project
jdoerfert added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

LGTM

Is there a way we can test this?

It is tested in the internal testsuite, don't know when it is going to be committed to trunk

Thu, Apr 11, 3:08 PM · Restricted Project
jdoerfert added a comment to D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

LGTM

Thu, Apr 11, 2:24 PM · Restricted Project
jdoerfert added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch..
Thu, Apr 11, 2:18 PM · Restricted Project
jdoerfert added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch..

Some initial comments from my side.

Thu, Apr 11, 1:31 PM · Restricted Project

Sun, Apr 7

jdoerfert requested changes to D60031: Split tailcallelim into tailcallmark and tailcallelim.
Sun, Apr 7, 11:03 PM · Restricted Project

Fri, Apr 5

jdoerfert requested changes to D60031: Split tailcallelim into tailcallmark and tailcallelim.
Fri, Apr 5, 12:20 PM · Restricted Project
jdoerfert added a comment to D60031: Split tailcallelim into tailcallmark and tailcallelim.

I don't have commit access. Would you commit?

I'm running the tests now, will commit if all is good.

Fri, Apr 5, 12:20 PM · Restricted Project
jdoerfert added a comment to D60031: Split tailcallelim into tailcallmark and tailcallelim.

I don't have commit access. Would you commit?

Fri, Apr 5, 9:55 AM · Restricted Project

Wed, Apr 3

jdoerfert accepted D60031: Split tailcallelim into tailcallmark and tailcallelim.

Yes, tailcallmark is not moved after memcpyopt in this patch.
I was going to make another patch for this change.

So this patch only split the pass and there is nothing to be changed in results.

Wed, Apr 3, 10:16 PM · Restricted Project
jdoerfert added a comment to D60031: Split tailcallelim into tailcallmark and tailcallelim.

Yes, the problem is PR41047. Inserting tailcallmark after memcpyopt would solve this problem.

Will you have a plan to make Attributor mark "tail"? If so, I think it is better to leave marking to Attributor.

Wed, Apr 3, 12:29 PM · Restricted Project
jdoerfert added inline comments to D58694: LLVM: Optimization Pass: Function Attribute: Fix error caused by adding incompactible attribute to WriteOnly attribute of pointer argument.
Wed, Apr 3, 12:22 PM · Restricted Project
jdoerfert added inline comments to D58694: LLVM: Optimization Pass: Function Attribute: Fix error caused by adding incompactible attribute to WriteOnly attribute of pointer argument.
Wed, Apr 3, 11:13 AM · Restricted Project
jdoerfert added inline comments to D58694: LLVM: Optimization Pass: Function Attribute: Fix error caused by adding incompactible attribute to WriteOnly attribute of pointer argument.
Wed, Apr 3, 11:10 AM · Restricted Project

Tue, Apr 2

jdoerfert added a comment to D60031: Split tailcallelim into tailcallmark and tailcallelim.

I might have missed some earlier discussion but how does this solve the problem? Also, I assume the problem is still PR41047, correct?

Tue, Apr 2, 3:56 PM · Restricted Project

Mon, Apr 1

jdoerfert added inline comments to D59978: [Attributor] Deduce "no-return" function attribute.
Mon, Apr 1, 11:03 AM · Restricted Project
jdoerfert added a comment to D59534: Enable tail call in MemCpyOptimization.

Maybe Attributor can infer tail call marks too?

@jdoerfert

Mon, Apr 1, 10:58 AM · Restricted Project
jdoerfert added parent revisions for D60078: [FunctionAttrs] Remove old "no-capture" and memory behavior argument deduction: D60077: [Attributor] Deduce memory location function attributes, D59922: [Attributor] Deduce "no-capture" argument attribute.
Mon, Apr 1, 10:52 AM · Restricted Project
jdoerfert added a child revision for D59922: [Attributor] Deduce "no-capture" argument attribute: D60078: [FunctionAttrs] Remove old "no-capture" and memory behavior argument deduction.
Mon, Apr 1, 10:52 AM · Restricted Project, Restricted Project
jdoerfert added a child revision for D60077: [Attributor] Deduce memory location function attributes: D60078: [FunctionAttrs] Remove old "no-capture" and memory behavior argument deduction.
Mon, Apr 1, 10:52 AM · Restricted Project
jdoerfert created D60078: [FunctionAttrs] Remove old "no-capture" and memory behavior argument deduction.
Mon, Apr 1, 10:52 AM · Restricted Project
jdoerfert added a parent revision for D60077: [Attributor] Deduce memory location function attributes: D60076: [Attributor] Deduce memory behavior function attributes.
Mon, Apr 1, 10:50 AM · Restricted Project
jdoerfert added a parent revision for D60076: [Attributor] Deduce memory behavior function attributes: D59980: [Attributor] Deduce memory behavior argument attributes.
Mon, Apr 1, 10:50 AM · Restricted Project, Restricted Project
jdoerfert created D60077: [Attributor] Deduce memory location function attributes.
Mon, Apr 1, 10:50 AM · Restricted Project
jdoerfert added a child revision for D60076: [Attributor] Deduce memory behavior function attributes: D60077: [Attributor] Deduce memory location function attributes.
Mon, Apr 1, 10:50 AM · Restricted Project, Restricted Project
jdoerfert created D60076: [Attributor] Deduce memory behavior function attributes.
Mon, Apr 1, 10:50 AM · Restricted Project, Restricted Project
jdoerfert added a child revision for D59980: [Attributor] Deduce memory behavior argument attributes: D60076: [Attributor] Deduce memory behavior function attributes.
Mon, Apr 1, 10:50 AM · Restricted Project, Restricted Project
jdoerfert updated the diff for D59980: [Attributor] Deduce memory behavior argument attributes.

Rebase

Mon, Apr 1, 10:45 AM · Restricted Project, Restricted Project
jdoerfert added a child revision for D60074: [Attributor] Deduce "no-recurse" function attribute: D60075: [FunctionAttrs] Remove post order "no-recurse" attribute deduction.
Mon, Apr 1, 10:45 AM · Restricted Project
jdoerfert updated the diff for D59922: [Attributor] Deduce "no-capture" argument attribute.

Rebase

Mon, Apr 1, 10:45 AM · Restricted Project, Restricted Project
jdoerfert added a parent revision for D60075: [FunctionAttrs] Remove post order "no-recurse" attribute deduction: D60074: [Attributor] Deduce "no-recurse" function attribute.
Mon, Apr 1, 10:45 AM · Restricted Project
jdoerfert created D60075: [FunctionAttrs] Remove post order "no-recurse" attribute deduction.
Mon, Apr 1, 10:43 AM · Restricted Project
jdoerfert created D60074: [Attributor] Deduce "no-recurse" function attribute.
Mon, Apr 1, 10:41 AM · Restricted Project
jdoerfert added a child revision for D59918: [Attributor] Pass infrastructure and fixpoint framework: D60074: [Attributor] Deduce "no-recurse" function attribute.
Mon, Apr 1, 10:41 AM · Restricted Project
jdoerfert added a parent revision for D60074: [Attributor] Deduce "no-recurse" function attribute: D59918: [Attributor] Pass infrastructure and fixpoint framework.
Mon, Apr 1, 10:41 AM · Restricted Project
jdoerfert updated the diff for D59978: [Attributor] Deduce "no-return" function attribute.

Minor changes

Mon, Apr 1, 9:55 AM · Restricted Project
jdoerfert updated the diff for D59920: [FunctionAttrs] Remove old "returned" argument deduction.

Minor changes

Mon, Apr 1, 9:55 AM · Restricted Project
jdoerfert updated the diff for D59919: [Attributor] Deduce "returned" argument attribute.

Minor changes

Mon, Apr 1, 9:54 AM · Restricted Project, Restricted Project
jdoerfert updated the diff for D59918: [Attributor] Pass infrastructure and fixpoint framework.

Minor changes

Mon, Apr 1, 9:53 AM · Restricted Project
jdoerfert updated the diff for D60012: [Attributor] Introduce bit-encodings for abstract states.

Minor updates

Mon, Apr 1, 9:53 AM · Restricted Project
jdoerfert updated the diff for D59903: [NFC][FnAttrs] Stress tests for attribute deduction.

Improve bug-exposing test cases (see http://llvm.org/PR41328)

Mon, Apr 1, 9:53 AM · Restricted Project
jdoerfert added a child revision for D60072: [Attributor] Deduce "no-capture" attributes for call site arguments: D60073: [Attributor] Enable backwards propagation from callback callees..
Mon, Apr 1, 9:53 AM · Restricted Project
jdoerfert added a parent revision for D60073: [Attributor] Enable backwards propagation from callback callees.: D60072: [Attributor] Deduce "no-capture" attributes for call site arguments.
Mon, Apr 1, 9:53 AM · Restricted Project
jdoerfert created D60073: [Attributor] Enable backwards propagation from callback callees..
Mon, Apr 1, 9:53 AM · Restricted Project
jdoerfert updated the summary of D60072: [Attributor] Deduce "no-capture" attributes for call site arguments.
Mon, Apr 1, 9:45 AM · Restricted Project
jdoerfert added a child revision for D59922: [Attributor] Deduce "no-capture" argument attribute: D60072: [Attributor] Deduce "no-capture" attributes for call site arguments.
Mon, Apr 1, 9:45 AM · Restricted Project, Restricted Project
jdoerfert added a parent revision for D60072: [Attributor] Deduce "no-capture" attributes for call site arguments: D59922: [Attributor] Deduce "no-capture" argument attribute.
Mon, Apr 1, 9:45 AM · Restricted Project
jdoerfert created D60072: [Attributor] Deduce "no-capture" attributes for call site arguments.
Mon, Apr 1, 9:45 AM · Restricted Project
jdoerfert updated the diff for D59980: [Attributor] Deduce memory behavior argument attributes.

Minor adjustments wrt later patches

Mon, Apr 1, 9:36 AM · Restricted Project, Restricted Project
jdoerfert updated the summary of D59980: [Attributor] Deduce memory behavior argument attributes.
Mon, Apr 1, 8:33 AM · Restricted Project, Restricted Project
jdoerfert updated the summary of D59922: [Attributor] Deduce "no-capture" argument attribute.
Mon, Apr 1, 8:28 AM · Restricted Project, Restricted Project
jdoerfert updated the summary of D59978: [Attributor] Deduce "no-return" function attribute.
Mon, Apr 1, 8:28 AM · Restricted Project
jdoerfert updated the summary of D59920: [FunctionAttrs] Remove old "returned" argument deduction.
Mon, Apr 1, 8:11 AM · Restricted Project
jdoerfert added inline comments to D59919: [Attributor] Deduce "returned" argument attribute.
Mon, Apr 1, 8:08 AM · Restricted Project, Restricted Project
jdoerfert updated the summary of D59919: [Attributor] Deduce "returned" argument attribute.
Mon, Apr 1, 8:07 AM · Restricted Project, Restricted Project

Sun, Mar 31

jdoerfert added a comment to D33889: Mark intrinsics as norecurse.

What's the status here? How can we make this go in?

Sun, Mar 31, 7:30 PM

Sat, Mar 30

jdoerfert updated the diff for D60012: [Attributor] Introduce bit-encodings for abstract states.

Simplify the interface & make it impossible to break invariances

Sat, Mar 30, 12:43 PM · Restricted Project
jdoerfert updated the diff for D59903: [NFC][FnAttrs] Stress tests for attribute deduction.

Add bug-exposing test case

Sat, Mar 30, 12:17 PM · Restricted Project

Fri, Mar 29

jdoerfert updated the diff for D59922: [Attributor] Deduce "no-capture" argument attribute.

Closed a side-channel through "integers"

Fri, Mar 29, 11:16 PM · Restricted Project, Restricted Project
jdoerfert updated the diff for D59980: [Attributor] Deduce memory behavior argument attributes.

Minor update

Fri, Mar 29, 9:38 PM · Restricted Project, Restricted Project
jdoerfert updated the diff for D59978: [Attributor] Deduce "no-return" function attribute.

Minor adjustment to prior patches

Fri, Mar 29, 2:49 PM · Restricted Project
jdoerfert added a parent revision for D59978: [Attributor] Deduce "no-return" function attribute: D60012: [Attributor] Introduce bit-encodings for abstract states.
Fri, Mar 29, 2:45 PM · Restricted Project
jdoerfert abandoned D59979: [Attributor][NFC] Add helper functions to deal wit bit-encodings.
Fri, Mar 29, 2:45 PM · Restricted Project
jdoerfert added child revisions for D60012: [Attributor] Introduce bit-encodings for abstract states: D59980: [Attributor] Deduce memory behavior argument attributes, D59922: [Attributor] Deduce "no-capture" argument attribute, D59978: [Attributor] Deduce "no-return" function attribute.
Fri, Mar 29, 2:45 PM · Restricted Project
jdoerfert added a parent revision for D60012: [Attributor] Introduce bit-encodings for abstract states: D59918: [Attributor] Pass infrastructure and fixpoint framework.
Fri, Mar 29, 2:45 PM · Restricted Project
jdoerfert added a parent revision for D59980: [Attributor] Deduce memory behavior argument attributes: D60012: [Attributor] Introduce bit-encodings for abstract states.
Fri, Mar 29, 2:45 PM · Restricted Project, Restricted Project
jdoerfert added a parent revision for D59922: [Attributor] Deduce "no-capture" argument attribute: D60012: [Attributor] Introduce bit-encodings for abstract states.
Fri, Mar 29, 2:45 PM · Restricted Project, Restricted Project
jdoerfert added a child revision for D59918: [Attributor] Pass infrastructure and fixpoint framework: D60012: [Attributor] Introduce bit-encodings for abstract states.
Fri, Mar 29, 2:45 PM · Restricted Project
jdoerfert updated the diff for D59919: [Attributor] Deduce "returned" argument attribute.

Minor updates

Fri, Mar 29, 2:45 PM · Restricted Project, Restricted Project
jdoerfert created D60012: [Attributor] Introduce bit-encodings for abstract states.
Fri, Mar 29, 2:33 PM · Restricted Project
jdoerfert updated the diff for D59918: [Attributor] Pass infrastructure and fixpoint framework.

Introduce later parts and minor fixes

Fri, Mar 29, 2:28 PM · Restricted Project
jdoerfert updated the diff for D59903: [NFC][FnAttrs] Stress tests for attribute deduction.

Add more tests and fix misleading comments

Fri, Mar 29, 12:11 PM · Restricted Project

Thu, Mar 28

jdoerfert added a child revision for D59979: [Attributor][NFC] Add helper functions to deal wit bit-encodings: D59980: [Attributor] Deduce memory behavior argument attributes.
Thu, Mar 28, 11:37 PM · Restricted Project
jdoerfert added a child revision for D59922: [Attributor] Deduce "no-capture" argument attribute: D59980: [Attributor] Deduce memory behavior argument attributes.
Thu, Mar 28, 11:37 PM · Restricted Project, Restricted Project
jdoerfert added parent revisions for D59980: [Attributor] Deduce memory behavior argument attributes: D59922: [Attributor] Deduce "no-capture" argument attribute, D59979: [Attributor][NFC] Add helper functions to deal wit bit-encodings.
Thu, Mar 28, 11:37 PM · Restricted Project, Restricted Project
jdoerfert created D59980: [Attributor] Deduce memory behavior argument attributes.
Thu, Mar 28, 11:37 PM · Restricted Project, Restricted Project
jdoerfert created D59979: [Attributor][NFC] Add helper functions to deal wit bit-encodings.
Thu, Mar 28, 11:35 PM · Restricted Project
jdoerfert added a child revision for D59919: [Attributor] Deduce "returned" argument attribute: D59978: [Attributor] Deduce "no-return" function attribute.
Thu, Mar 28, 8:10 PM · Restricted Project, Restricted Project
jdoerfert added a parent revision for D59978: [Attributor] Deduce "no-return" function attribute: D59919: [Attributor] Deduce "returned" argument attribute.
Thu, Mar 28, 8:10 PM · Restricted Project
jdoerfert added a child revision for D59918: [Attributor] Pass infrastructure and fixpoint framework: D59978: [Attributor] Deduce "no-return" function attribute.
Thu, Mar 28, 8:09 PM · Restricted Project
jdoerfert added a parent revision for D59978: [Attributor] Deduce "no-return" function attribute: D59918: [Attributor] Pass infrastructure and fixpoint framework.
Thu, Mar 28, 8:09 PM · Restricted Project
jdoerfert created D59978: [Attributor] Deduce "no-return" function attribute.
Thu, Mar 28, 8:09 PM · Restricted Project
jdoerfert added inline comments to D59922: [Attributor] Deduce "no-capture" argument attribute.
Thu, Mar 28, 5:07 PM · Restricted Project, Restricted Project