- User Since
- Jan 30 2014, 6:27 AM (290 w, 1 d)
I guess IR test should be affected already and it would be good to have the run time test that breaks with barriers.
We have uses of __SYNCWARP in the library, right? Can we use the function instead and maybe put it in the language dependent part?
Make sure to update the commit message as well.
thx for the explanation. LGTM.
Generally, this seems fine but I was hoping we could say what configuration and test file can be used to reproduce this error.
It seems inconsistent to declare Op0C initially and Op1C late given that both are need 2 times in almost the same fashion.
This is what I wanted but I think I need to see this in action as I'm not a template wizard. (Btw. if you want to clean up the mess I made, feel free!)
Update tests and fix errors
The original code tried to do the modulo computation (as per comment and the looks of it) but the operands of DiffUnitsSCEV = SE->getMinusSCEV(DiffAlign, DiffSCEV) were swapped.
Swapping them should yield the same result as using URem but using URem is better so this is fine.
Wed, Aug 21
Use the call site as a key for the cache
We'll need "nofree" for call site arguments ;)
Thx @efriedma, We'll do it without this change
Tue, Aug 20
Remove accidentally included code
Can you use ` (three backticks) to enclose the code regions for better formatting?
Mon, Aug 19
Fix typo and add baseline tests