Page MenuHomePhabricator

jhenderson (James Henderson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 18 2017, 2:49 AM (126 w, 6 d)

Recent Activity

Today

jhenderson committed rL364307: [llvm-objcopy][llvm-strip] Fix help text typo for --allow-broken-links.
[llvm-objcopy][llvm-strip] Fix help text typo for --allow-broken-links
Tue, Jun 25, 6:27 AM
jhenderson committed rL364306: [docs][llvm-readobj] Improve llvm-readobj documentation.
[docs][llvm-readobj] Improve llvm-readobj documentation
Tue, Jun 25, 6:25 AM
jhenderson committed rG083d94903603: [llvm-objcopy][llvm-strip] Fix help text typo for --allow-broken-links (authored by jhenderson).
[llvm-objcopy][llvm-strip] Fix help text typo for --allow-broken-links
Tue, Jun 25, 6:21 AM
jhenderson committed rGb96d9d8bdada: [docs][llvm-readobj] Improve llvm-readobj documentation (authored by jhenderson).
[docs][llvm-readobj] Improve llvm-readobj documentation
Tue, Jun 25, 6:20 AM
jhenderson closed D63719: [docs][llvm-readobj] Improve llvm-readobj documentation.
Tue, Jun 25, 6:20 AM · Restricted Project
jhenderson added a comment to D63762: [Object/invalid.test] - Convert most of the sub tests to YAML..

FWIW, I think this test is generally testing the behaviour of libObject code, so arguably belongs exactly where it is.

Tue, Jun 25, 5:57 AM
jhenderson updated the diff for D63651: [docs][llvm-symbolizer] Improve llvm-symbolizer documentation.

Add extra notes to explain demangling differences a bit.

Tue, Jun 25, 4:24 AM · Restricted Project
jhenderson updated the diff for D63719: [docs][llvm-readobj] Improve llvm-readobj documentation.

Make two-letter options use double-dashes, make the --all description less fragile to new options, and standardise on "display" instead of "print" for consistency throughout the document.

Tue, Jun 25, 3:57 AM · Restricted Project
jhenderson committed rGecd9348aa176: [docs][llvm-cxxfilt] Write llvm-cxxfilt documentation (authored by jhenderson).
[docs][llvm-cxxfilt] Write llvm-cxxfilt documentation
Tue, Jun 25, 3:38 AM
jhenderson committed rL364287: [docs][llvm-cxxfilt] Write llvm-cxxfilt documentation.
[docs][llvm-cxxfilt] Write llvm-cxxfilt documentation
Tue, Jun 25, 3:38 AM
jhenderson closed D63722: [docs][llvm-cxxfilt] Write llvm-cxxfilt documentation.
Tue, Jun 25, 3:38 AM · Restricted Project
jhenderson added inline comments to D63722: [docs][llvm-cxxfilt] Write llvm-cxxfilt documentation.
Tue, Jun 25, 3:25 AM · Restricted Project
jhenderson added inline comments to D63521: Teach the symbolizer lib symbolize objects directly..
Tue, Jun 25, 1:51 AM · Restricted Project

Yesterday

jhenderson created D63722: [docs][llvm-cxxfilt] Write llvm-cxxfilt documentation.
Mon, Jun 24, 9:21 AM · Restricted Project
jhenderson accepted D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names..

LGTM.

Mon, Jun 24, 8:35 AM · Restricted Project
jhenderson added a comment to D63651: [docs][llvm-symbolizer] Improve llvm-symbolizer documentation.

I wonder why the Mach-O specific commands are unlike that of other utilities ... In any case, these changes look fine.

Mon, Jun 24, 8:10 AM · Restricted Project
jhenderson added inline comments to D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names..
Mon, Jun 24, 8:07 AM · Restricted Project
jhenderson created D63719: [docs][llvm-readobj] Improve llvm-readobj documentation.
Mon, Jun 24, 7:59 AM · Restricted Project
jhenderson added inline comments to D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names..
Mon, Jun 24, 5:38 AM · Restricted Project
jhenderson added inline comments to D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names..
Mon, Jun 24, 5:04 AM · Restricted Project
jhenderson added inline comments to D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names..
Mon, Jun 24, 4:30 AM · Restricted Project
jhenderson committed rG2c5ff946277b: [docs][llvm-nm] Add missing options to documentation (authored by jhenderson).
[docs][llvm-nm] Add missing options to documentation
Mon, Jun 24, 3:55 AM
jhenderson committed rL364176: [docs][llvm-nm] Add missing options to documentation.
[docs][llvm-nm] Add missing options to documentation
Mon, Jun 24, 3:55 AM
jhenderson closed D63655: [docs][llvm-nm] Add missing options to documentation.
Mon, Jun 24, 3:55 AM · Restricted Project
jhenderson added a comment to D63655: [docs][llvm-nm] Add missing options to documentation.

Thanks @MaskRay. I'm going to land this shortly, to reduce the number of in-flight patches I have on the docs, but I'll happily take further feedback for improvements if anybody has any.

Mon, Jun 24, 3:33 AM · Restricted Project
jhenderson added a comment to D63524: [llvm-objdump] Allow --disassemble-functions to take demangled names.

Hi @ychen, would you mind posting a patch to update the docs for this behaviour change? I didn't mention it previously, because rL364019, which added --disassemble-functions to the listed options, was still under review, but it landed before this change did.

Mon, Jun 24, 3:10 AM · Restricted Project
jhenderson added a reviewer for D63651: [docs][llvm-symbolizer] Improve llvm-symbolizer documentation: dblaikie.
Mon, Jun 24, 2:58 AM · Restricted Project
jhenderson committed rG3519d5535a4c: [docs][llvm-nm] Improve symbol code documentation (authored by jhenderson).
[docs][llvm-nm] Improve symbol code documentation
Mon, Jun 24, 2:55 AM
jhenderson committed rL364171: [docs][llvm-nm] Improve symbol code documentation.
[docs][llvm-nm] Improve symbol code documentation
Mon, Jun 24, 2:55 AM
jhenderson closed D63327: [docs][llvm-nm] Improve symbol code documentation.
Mon, Jun 24, 2:55 AM · Restricted Project
jhenderson abandoned D63211: [docs] Fix local docs build.

There seems to be a general consensus to change these docs to RST (see also the discussion in D63292 and on the mailing list). As such, I'm abandoning this revision. I'll make changes in the coming days to switch things over.

Mon, Jun 24, 2:51 AM · Restricted Project
jhenderson added a comment to D63292: [docs] Workaround old recommonmark version on buildbots.

Switching these docs to rst seems (unfortunately) better, abandoning this attempt.

Mon, Jun 24, 2:49 AM · Restricted Project
jhenderson added a comment to D63327: [docs][llvm-nm] Improve symbol code documentation.

Thanks all. I'm going to land this shortly. I'm happy to make further changes if there's any remaining issues.

Mon, Jun 24, 2:46 AM · Restricted Project
jhenderson added inline comments to D63655: [docs][llvm-nm] Add missing options to documentation.
Mon, Jun 24, 1:58 AM · Restricted Project
jhenderson added inline comments to D62718: [llvm-objcopy] Change handling of output file permissions.
Mon, Jun 24, 1:57 AM · Restricted Project

Fri, Jun 21

jhenderson created D63655: [docs][llvm-nm] Add missing options to documentation.
Fri, Jun 21, 9:03 AM · Restricted Project
jhenderson accepted D63647: [llvm-readobj/llvm-readelf] - Eliminate the elf-groups.x86_64 precompiled binary from the inputs..

LGTM.

Fri, Jun 21, 8:04 AM · Restricted Project
jhenderson created D63651: [docs][llvm-symbolizer] Improve llvm-symbolizer documentation.
Fri, Jun 21, 7:58 AM · Restricted Project
jhenderson committed rGf7212dbe2fb4: [docs][llvm-objdump] Fix bad merge of docs (authored by jhenderson).
[docs][llvm-objdump] Fix bad merge of docs
Fri, Jun 21, 7:41 AM
jhenderson committed rL364056: [docs][llvm-objdump] Fix bad merge of docs.
[docs][llvm-objdump] Fix bad merge of docs
Fri, Jun 21, 7:41 AM
jhenderson added a comment to D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names..

I do not think it is a very often case to have duplicated symbol/sections name, so I selected the less intrusive way.

Fri, Jun 21, 6:44 AM · Restricted Project
jhenderson accepted D63641: [llvm-objcopy] - Get rid of dynrel.elf precompiled binary from inputs..

LGTM, with one comment fix.

Fri, Jun 21, 6:44 AM · Restricted Project
jhenderson added inline comments to D63647: [llvm-readobj/llvm-readelf] - Eliminate the elf-groups.x86_64 precompiled binary from the inputs..
Fri, Jun 21, 6:39 AM · Restricted Project
jhenderson accepted D63644: [llvm-readobj] - Inline a few yaml inputs into test cases..

LGTM.

Fri, Jun 21, 6:36 AM · Restricted Project
jhenderson committed rG9485b265e8a8: [binutils] Add response file option to help and docs (authored by jhenderson).
[binutils] Add response file option to help and docs
Fri, Jun 21, 4:47 AM
jhenderson committed rL364036: [binutils] Add response file option to help and docs.
[binutils] Add response file option to help and docs
Fri, Jun 21, 4:46 AM
jhenderson closed D63597: [binutils] Add response file option to help and docs.
Fri, Jun 21, 4:46 AM · Restricted Project
jhenderson committed rGbeb2493fb7ff: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour (authored by jhenderson).
[llvm-dwarfdump] Remove unnecessary explicit -h behaviour
Fri, Jun 21, 4:21 AM
jhenderson committed rL364029: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.
[llvm-dwarfdump] Remove unnecessary explicit -h behaviour
Fri, Jun 21, 4:21 AM
jhenderson closed D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.
Fri, Jun 21, 4:19 AM · Restricted Project
jhenderson updated the diff for D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.

Removed references to llvm-dwarfdump from test/Support/check-default-options.txt.

Fri, Jun 21, 3:51 AM · Restricted Project
jhenderson added a comment to D63606: [docs][llvm-objdump] Improve llvm-objdump documentation.

I got the man pages building from the rst using ninja docs-llvm-man, and a set of man pages were built, including one for llvm-objdump that mirrors the html doc. I don't see any reason why this can't be used: it's built by the sphinx build bot (see http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/32333 for an example build).

Fri, Jun 21, 3:32 AM · Restricted Project
jhenderson committed rGa8ed354b6429: [docs][llvm-objdump] Improve llvm-objdump documentation (authored by jhenderson).
[docs][llvm-objdump] Improve llvm-objdump documentation
Fri, Jun 21, 3:11 AM
jhenderson committed rL364019: [docs][llvm-objdump] Improve llvm-objdump documentation.
[docs][llvm-objdump] Improve llvm-objdump documentation
Fri, Jun 21, 3:09 AM
jhenderson closed D63606: [docs][llvm-objdump] Improve llvm-objdump documentation.
Fri, Jun 21, 3:09 AM · Restricted Project
jhenderson added a comment to D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.

LGTM, but you'll also want to fix llvm/test/Support/check-default-options.txt. It checks your special handling to make sure the default -h support didn't break it.

Thanks, I wasn't aware of that one (and hadn't yet bothered running every lit test for this). Just to be clear, are you recommending that I just delete the bits of that test relating to llvm-dwarfdump, since it will now follow the default process, or do you think there should be something else to replace it? I can replace it with llvm-opt-report, which seems to do something similar to llvm-dwarfdump.

Yes, it can be removed. If you want, you can add it to the ones above that do use the new default -h, but I don't think that's necessary. And yes, if there's another one that does something special, adding it, i.e., s/llvm-dwarfdump/llvm-opt-report/ makes sense.

Fri, Jun 21, 3:06 AM · Restricted Project
jhenderson added a comment to D63606: [docs][llvm-objdump] Improve llvm-objdump documentation.

Do you know how good rst is to generate the man page? If it is less ideal (mdoc is a complex format...), personally I think it is fine to stick with the current manually maintained manpage...

Fri, Jun 21, 3:00 AM · Restricted Project
jhenderson accepted D62718: [llvm-objcopy] Change handling of output file permissions.

LGTM, with the suggested comment changes, but please wait for the other patch, and @MaskRay's agreement.

Fri, Jun 21, 2:11 AM · Restricted Project
jhenderson added a comment to D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol.

@MaskRay, @peter.smith, is it just the PLT that is specially handled? Perhaps we could just special-case that in llvm-objdump? I think there's clear precedence for this for other versions of objdump, so I'm okay with that difference in behaviour.

Fri, Jun 21, 2:08 AM · Restricted Project
jhenderson added a comment to D63596: [yaml2obj/obj2yaml] - Allow having the symbols and sections with duplicated names..

Hmmm... I'm not sure we need any special behaviour at all in the name field of the syntax, and the suggested syntax is not obvious to me. Surely if yaml2obj sees two symbols with the same name, it should just generate two such symbols?

Fri, Jun 21, 2:02 AM · Restricted Project
jhenderson added a comment to D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol.

May I ask you to start a thread on https://lists.llvm.org/pipermail/llvm-dev/2019-June to discuss this?

Fri, Jun 21, 1:41 AM · Restricted Project
jhenderson accepted D63631: [llvm-objdump] Move --start-address >= --stop-address check out of the -d code..
Fri, Jun 21, 1:33 AM · Restricted Project
jhenderson accepted D63583: [Support] Add fs::getUmask() function and change fs::setPermissions.

LGTM. Maybe give it a couple of days before committing for a chance for others to say something.

Fri, Jun 21, 1:25 AM · Restricted Project

Thu, Jun 20

jhenderson created D63606: [docs][llvm-objdump] Improve llvm-objdump documentation.
Thu, Jun 20, 8:41 AM · Restricted Project
jhenderson added a comment to D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.

LGTM, but you'll also want to fix llvm/test/Support/check-default-options.txt. It checks your special handling to make sure the default -h support didn't break it.

Thu, Jun 20, 7:41 AM · Restricted Project
jhenderson added a comment to D63292: [docs] Workaround old recommonmark version on buildbots.

html can be embedded in markdown? That was unexpected and sounds good. Does this work when generating man pages though instead of html?

Thu, Jun 20, 6:47 AM · Restricted Project
jhenderson added a comment to D63597: [binutils] Add response file option to help and docs.

D63565 needs to land first for the llvm-dwarfdump test to work, due to an odd difference in behaviour between -h and --help in llvm-dwarfdump.

Thu, Jun 20, 6:19 AM · Restricted Project
jhenderson added a parent revision for D63597: [binutils] Add response file option to help and docs: D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.
Thu, Jun 20, 6:18 AM · Restricted Project
jhenderson added a child revision for D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour: D63597: [binutils] Add response file option to help and docs.
Thu, Jun 20, 6:18 AM · Restricted Project
jhenderson updated the summary of D63597: [binutils] Add response file option to help and docs.
Thu, Jun 20, 6:17 AM · Restricted Project
jhenderson created D63597: [binutils] Add response file option to help and docs.
Thu, Jun 20, 6:17 AM · Restricted Project
jhenderson accepted D63493: [yaml2obj] - Convert `ELFState<ELFT>::addSymbols` method to `toELFSymbols` helper..

Yes, LGTM.

Thu, Jun 20, 5:44 AM · Restricted Project
jhenderson added reviewers for D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour: hintonda, klimek.
Thu, Jun 20, 4:37 AM · Restricted Project
jhenderson added a reviewer for D63327: [docs][llvm-nm] Improve symbol code documentation: majnemer.

@majnemer, I've added you as it looks like you've worked on the COFF llvm-nm side a fair bit. How do the COFF aspects look?

Thu, Jun 20, 4:32 AM · Restricted Project
jhenderson updated the diff for D63327: [docs][llvm-nm] Improve symbol code documentation.

Reword undefined and weak symbol code text. Also update 'n' text following behaviour change.

Thu, Jun 20, 4:02 AM · Restricted Project
jhenderson added inline comments to D63327: [docs][llvm-nm] Improve symbol code documentation.
Thu, Jun 20, 3:42 AM · Restricted Project
jhenderson added reviewers for D63583: [Support] Add fs::getUmask() function and change fs::setPermissions: aprantl, lhames.

I've added a couple of other reviewers who have made recent changes to the Path files.

Thu, Jun 20, 3:18 AM · Restricted Project
jhenderson added a comment to D62718: [llvm-objcopy] Change handling of output file permissions.

I think this looks pretty good, but I'd like D63583 to land first if possible.

Thu, Jun 20, 3:07 AM · Restricted Project
jhenderson accepted D63588: [llvm-nm] Generalize symbol types 'N' and 'n'.

LGTM too. I'll update the doc patch.

Thu, Jun 20, 2:38 AM · Restricted Project
jhenderson accepted D63521: Teach the symbolizer lib symbolize objects directly..

So I'm happy with this approach, but I'd like somebody else to confirm that they are too.

Thu, Jun 20, 2:20 AM · Restricted Project
jhenderson accepted D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output..

LGTM, with the suggested change, but please wait for the other reviewers to confirm too.

Thu, Jun 20, 2:16 AM · Restricted Project
jhenderson accepted D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol.

Okay, LGTM, but @MaskRay probably should confirm he's happy enough for now (we can improve the STT_SECTION bit later, if we want).

Thu, Jun 20, 2:09 AM · Restricted Project

Wed, Jun 19

jhenderson created D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour.
Wed, Jun 19, 10:00 AM · Restricted Project
jhenderson committed rGe20326ed332c: [test][llvm-dwarfdump] Remove pointless CHECK-NOT lines (authored by jhenderson).
[test][llvm-dwarfdump] Remove pointless CHECK-NOT lines
Wed, Jun 19, 9:29 AM
jhenderson committed rL363833: [test][llvm-dwarfdump] Remove pointless CHECK-NOT lines.
[test][llvm-dwarfdump] Remove pointless CHECK-NOT lines
Wed, Jun 19, 9:28 AM
jhenderson updated the diff for D63327: [docs][llvm-nm] Improve symbol code documentation.

Update text of 's' to specify which sections it applies to more precisely.

Wed, Jun 19, 8:52 AM · Restricted Project
jhenderson added inline comments to D63327: [docs][llvm-nm] Improve symbol code documentation.
Wed, Jun 19, 8:52 AM · Restricted Project
jhenderson added inline comments to D63327: [docs][llvm-nm] Improve symbol code documentation.
Wed, Jun 19, 8:32 AM · Restricted Project
jhenderson added a comment to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Apologies for the delay in coming back to this. It's been a busy few days.

Wed, Jun 19, 7:46 AM · Restricted Project
jhenderson added a comment to D63185: [llvm-objcopy] [WIP] Librarify llvm-objcopy.

You're going to need to account for program headers in your layout code. If you take a look at llvm-objcopy, a lot of the layout work is done based on those, rather than the sections, because sections within segments should move with their segment.

Wed, Jun 19, 4:53 AM · Restricted Project
jhenderson added a reviewer for D63521: Teach the symbolizer lib symbolize objects directly.: pcc.
Wed, Jun 19, 4:37 AM · Restricted Project
jhenderson added inline comments to D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol.
Wed, Jun 19, 4:34 AM · Restricted Project
jhenderson accepted D63239: [llvm-objcopy][NFC] Refactor output target parsing.

LGTM, with one comment fix.

Wed, Jun 19, 4:26 AM · Restricted Project
jhenderson accepted D63524: [llvm-objdump] Allow --disassemble-functions to take demangled names.

Can you persuade git/svn to do a rename of the test rather than a delete and add? That would make the diff easier to see.

Wed, Jun 19, 4:08 AM · Restricted Project
jhenderson added inline comments to D63493: [yaml2obj] - Convert `ELFState<ELFT>::addSymbols` method to `toELFSymbols` helper..
Wed, Jun 19, 4:05 AM · Restricted Project
jhenderson added inline comments to D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output..
Wed, Jun 19, 3:59 AM · Restricted Project
jhenderson added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

Hi @mmpozulp, just wondering if you are going to come back to this some time soon, or if you need any further assistance with this issue?

Wed, Jun 19, 1:50 AM · Restricted Project

Tue, Jun 18

jhenderson added inline comments to D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output..
Tue, Jun 18, 8:41 AM · Restricted Project
jhenderson accepted D63393: [llvm-objdump] Remove unnecessary indentation when dumping ELF data..

LGTM.

Tue, Jun 18, 8:35 AM · Restricted Project
jhenderson accepted D63487: [yaml2obj/obj2yaml] - Make RawContentSection::Info Optional<>.

LGTM.

Tue, Jun 18, 7:11 AM · Restricted Project