Page MenuHomePhabricator

jhenderson (James Henderson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 18 2017, 2:49 AM (284 w, 21 h)

Recent Activity

Today

jhenderson added inline comments to D127864: [llvm-ar] Add object mode option -X for AIX.
Thu, Jun 30, 12:38 AM · Restricted Project, Restricted Project

Yesterday

jhenderson added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Wed, Jun 29, 1:29 AM · Restricted Project, Restricted Project
jhenderson accepted D128688: [llvm-objcopy] Remove support for legacy .zdebug sections.

LGTM!

Wed, Jun 29, 1:18 AM · Restricted Project, Restricted Project
jhenderson accepted D128626: [llvm-ar] Add --output to specify output directory.

LGTM, with one suggestion.

Wed, Jun 29, 1:13 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D128705: [llvm-objdump] Create fake sections for a ELF core file.
Wed, Jun 29, 1:07 AM · Restricted Project, Restricted Project
jhenderson added a comment to D128612: RISC-V big-endian support implementation.

Objcopy aspects look good, thanks.

Wed, Jun 29, 12:49 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
jhenderson added a comment to D126904: [llvm-objdump] Add support for dumping embedded offloading data.

Sorry for the delay - I've had a lot on my plate.

Wed, Jun 29, 12:21 AM · Restricted Project, Restricted Project

Tue, Jun 28

jhenderson added inline comments to D128688: [llvm-objcopy] Remove support for legacy .zdebug sections.
Tue, Jun 28, 2:33 AM · Restricted Project, Restricted Project
jhenderson accepted D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Two nits, otherwise LGTM.

Tue, Jun 28, 1:25 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Tue, Jun 28, 1:21 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D128626: [llvm-ar] Add --output to specify output directory.
Tue, Jun 28, 12:18 AM · Restricted Project, Restricted Project
jhenderson updated subscribers of D128688: [llvm-objcopy] Remove support for legacy .zdebug sections.

@plotfi, you were the one who originally added compression support, including zlib-gnu support. Do you know of a use-case for zlib-gnu support? If not, I think we can drop it, given that GNU has. (Looking back at https://reviews.llvm.org/D49678#1189341 which was a comment I made on the review to add support, @plotfi originally had this marked as deprecated).

Tue, Jun 28, 12:14 AM · Restricted Project, Restricted Project

Mon, Jun 27

jhenderson added inline comments to D128667: [WIP] Add Zstd ELF support.
Mon, Jun 27, 11:48 PM · Restricted Project, Restricted Project, Restricted Project
jhenderson added a comment to D128626: [llvm-ar] Add --output to specify output directory.

I'm uncertain, but should we have a test case where the output directory doesn't exist?

Mon, Jun 27, 2:25 AM · Restricted Project, Restricted Project
jhenderson accepted D127776: [ObjectYAML] Add offloading binary implementations for obj2yaml and yaml2obj.

LGTM.

Mon, Jun 27, 1:25 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D128612: RISC-V big-endian support implementation.
Mon, Jun 27, 1:14 AM · Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project
jhenderson added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Mon, Jun 27, 12:53 AM · Restricted Project, Restricted Project
jhenderson accepted D128055: [llvm-ar] Improve MRI script CREATE command handling.

LGTM, thanks!

Mon, Jun 27, 12:36 AM · Restricted Project, Restricted Project
jhenderson accepted D128067: [llvm-ar] Fix MRI ADDLIB command when used with thin archives.

LGTM!

Mon, Jun 27, 12:35 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D127864: [llvm-ar] Add object mode option -X for AIX.
Mon, Jun 27, 12:34 AM · Restricted Project, Restricted Project

Thu, Jun 23

jhenderson accepted D128493: [llvm-readobj][RISCV] Support dumping PT_RISCV_ATTRIBUTES.

LGTM. Does llvm-objdump need something equivalent? (I don't remember whether we interpret platform-specific program headers in llvm-objdump)

Thu, Jun 23, 11:29 PM · Restricted Project, Restricted Project
jhenderson added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Thu, Jun 23, 11:24 PM · Restricted Project, Restricted Project
jhenderson added inline comments to D128067: [llvm-ar] Fix MRI ADDLIB command when used with thin archives.
Thu, Jun 23, 11:19 PM · Restricted Project, Restricted Project
jhenderson added a comment to D128055: [llvm-ar] Improve MRI script CREATE command handling.

There's a potentially relevant pre-merge failure in mri-create.test on debian (see above), which you should look at before landing this (I suspect it's the missing %errc substitution I highlighted above).

Thu, Jun 23, 11:16 PM · Restricted Project, Restricted Project
jhenderson added inline comments to D127776: [ObjectYAML] Add offloading binary implementations for obj2yaml and yaml2obj.
Thu, Jun 23, 11:11 PM · Restricted Project, Restricted Project
jhenderson added a comment to D124865: [AIX] support read global symbol of big archive.

I feel like this code is missing testing for the non-error cases. In particular, I'd expect to see some sort of test that shows that the archive symbol table can be read successfully. I think you can do that using llvm-nm --print-armap. I'd be surprised if there aren't already equivalent test cases for other formats that do this, so you may be able to copy/modify those to cover big archives too.

There is already has "llvm-nm --print-armap" in the llvm/test/tools/llvm-ar/delete.test , the test case is disable in AIX OS, it enable in AIX in the patch by deleting the "# XFAIL: system-aix"

Thu, Jun 23, 12:55 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Thu, Jun 23, 12:44 AM · Restricted Project, Restricted Project

Wed, Jun 22

jhenderson added a comment to D124865: [AIX] support read global symbol of big archive.

I feel like this code is missing testing for the non-error cases. In particular, I'd expect to see some sort of test that shows that the archive symbol table can be read successfully. I think you can do that using llvm-nm --print-armap. I'd be surprised if there aren't already equivalent test cases for other formats that do this, so you may be able to copy/modify those to cover big archives too.

Wed, Jun 22, 1:16 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D127776: [ObjectYAML] Add offloading binary implementations for obj2yaml and yaml2obj.
Wed, Jun 22, 12:54 AM · Restricted Project, Restricted Project

Tue, Jun 21

jhenderson accepted D128195: [LLD][ELF] Add FORCE_LLD_DIAGNOSTICS_CRASH to force LLD to crash.

LGTM, but you probably want to wait for @peter.smith and/or @MaskRay.

Tue, Jun 21, 5:54 AM · Restricted Project
jhenderson updated subscribers of D127864: [llvm-ar] Add object mode option -X for AIX.

I'm going to leave my review there, but haven't finished the test. Please address my comments and then I'll finish reviewing the test case.

Tue, Jun 21, 1:56 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D128195: [LLD][ELF] Add FORCE_LLD_DIAGNOSTICS_CRASH to force LLD to crash.
Tue, Jun 21, 12:29 AM · Restricted Project
jhenderson added inline comments to D124865: [AIX] support read global symbol of big archive.
Tue, Jun 21, 12:23 AM · Restricted Project, Restricted Project

Mon, Jun 20

jhenderson added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Mon, Jun 20, 1:30 AM · Restricted Project, Restricted Project
jhenderson accepted D128117: [ObjCopy] Fix type mismatch in writeCodeSignatureData().

LGTM, but maybe give @alexander-shaposhnikov a chance to comment (i.e. give it a day or two to land this or until he responds).

Mon, Jun 20, 12:42 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D128055: [llvm-ar] Improve MRI script CREATE command handling.
Mon, Jun 20, 12:37 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D128067: [llvm-ar] Fix MRI ADDLIB command when used with thin archives.
Mon, Jun 20, 12:18 AM · Restricted Project, Restricted Project

Fri, Jun 17

jhenderson added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Fri, Jun 17, 1:42 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D126904: [llvm-objdump] Add support for dumping embedded offloading data.
Fri, Jun 17, 1:10 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D127776: [ObjectYAML] Add offloading binary implementations for obj2yaml and yaml2obj.
Fri, Jun 17, 1:05 AM · Restricted Project, Restricted Project
jhenderson accepted D128030: [llvm-objdump] Default to --mattr=+all for AArch64.

Seems good to me, but might want to give a chance for AArch64 contributors to have a say in the matter.

Fri, Jun 17, 12:37 AM · Restricted Project, Restricted Project

Wed, Jun 15

jhenderson added a comment to D127864: [llvm-ar] Add object mode option -X for AIX.

The pre-merge checks are showing up failures caused by this patch. Please fix them.

Wed, Jun 15, 11:08 PM · Restricted Project, Restricted Project
jhenderson added a comment to D126623: [XCOFF] write the real source file name in C_FILE symbol..

No further comments from me at this time, but I'm not knowledgeable enough about this area to be able to LGTM it.

Wed, Jun 15, 10:35 PM · Restricted Project, Restricted Project
jhenderson accepted D127846: Update FileCheck docs after D95849. NFC.

LGTM.

Wed, Jun 15, 4:41 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D126904: [llvm-objdump] Add support for dumping embedded offloading data.
Wed, Jun 15, 12:58 AM · Restricted Project, Restricted Project
jhenderson added a comment to D127776: [ObjectYAML] Add offloading binary implementations for obj2yaml and yaml2obj.

Have you got any reference material that I can read for the format of offloading binaries? I can't really review that this implementation does the right thing without knowing the format!

Wed, Jun 15, 12:41 AM · Restricted Project, Restricted Project
jhenderson added a comment to D127824: [llvm-objdump] Default to --mcpu=future for PPC64.

Seems reasonable to me, but needs a Power PC person to do the review, I think.

Wed, Jun 15, 12:27 AM · Restricted Project, Restricted Project

Tue, Jun 14

jhenderson added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Thanks for the explanation. If we use -function-sections it also means that we'll generate a unique LLVM_BB_ADDR_MAP per function. In this case, I believe the version data will be repeated for every function. Correct? I think we can live with that for now. It's only one or two bytes per function.

Tue, Jun 14, 1:31 AM · Restricted Project, Restricted Project
jhenderson added a comment to D126904: [llvm-objdump] Add support for dumping embedded offloading data.

Addressing some comments for now. Let me know if this is sufficient for now, or if I should move to address the other main comments, the section identification scheme and using binary blobs.

Tue, Jun 14, 1:26 AM · Restricted Project, Restricted Project

Mon, Jun 13

jhenderson added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

IIUC, your suggestion is to embed the version in the section data. The problem with this approach is that the linker must read and deduplicate the version data when linking the sections (unless if we store the version for each function separately).
Also, if we compile with different compiler versions, the linker must create multiple LLVM_BB_ADDR_MAP sections if multiple versions exist.
For these reasons I am a bit hesitant to add linker dependency to the feature, even though section-name-independence is great to have. I'd be happy to change course if we can avoid involving the linker. Any thoughts?

Mon, Jun 13, 2:46 AM · Restricted Project, Restricted Project
jhenderson added a comment to D126904: [llvm-objdump] Add support for dumping embedded offloading data.

Sorry for the delay - I ended up off sick for a big chunk of last week.

Mon, Jun 13, 2:33 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D126623: [XCOFF] write the real source file name in C_FILE symbol..
Mon, Jun 13, 1:17 AM · Restricted Project, Restricted Project

Tue, Jun 7

jhenderson added a comment to D127135: [Object][Archive] Support a new archive member /<ECSYMBOLS>/.

I think you can drop the content lines from the test cases. But other that that it looks fine.

I tried removing the content lines from the test case, but got the following error somehow. Any idea?

"truncated or malformed archive (offset to next archive member past the end of the archive after member foo-arm64ec.obj)"

Tue, Jun 7, 5:46 AM · Restricted Project, Restricted Project
jhenderson accepted D124607: Add an error message to the default SIGPIPE handler.

Latest updates look good again.

Tue, Jun 7, 5:43 AM · Restricted Project, Restricted Project

Mon, Jun 6

jhenderson added a comment to D126509: [Objcopy][Wasm] Allow selecting known sections by name.

@jhenderson or others, would you like to review this too, or is sbc's review sufficient?

Mon, Jun 6, 4:11 AM · Restricted Project, Restricted Project
jhenderson added a comment to D126904: [llvm-objdump] Add support for dumping embedded offloading data.

Note: you probably need to consider jhenderson as a blocking reviewer for this change, even if folks who usually review offload changes give an approval.

Mon, Jun 6, 3:49 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D124607: Add an error message to the default SIGPIPE handler.
Mon, Jun 6, 3:08 AM · Restricted Project, Restricted Project

May 26 2022

jhenderson added a comment to D126509: [Objcopy][Wasm] Allow selecting known sections by name.

Looks like there's no test case?

May 26 2022, 11:48 PM · Restricted Project, Restricted Project

May 24 2022

jhenderson added a comment to D124607: Add an error message to the default SIGPIPE handler.

Both llvm-symbolizer and llvm-cxxfilt, if called without positional arguments, are run interactively, essentially taking a line of input then writing some output before waiting for more input. This would allow you to force output to be written (by writing to stdin) after the pipe has been closed. Maybe that'll solve the issue, although I'm not sure I understand why the python script doesn't work in its current form: llvm-nm should try to write many bytes of output (> 1 byte), but the pipe is closed after the very first byte is written. Before going and changing the script, I'd like to understand whether this statement is actually true, and if so, why:

That does not appear to be enough. You can either run a tool that runs longer or run llvm-nm with something that produces more output.

May 24 2022, 11:32 PM · Restricted Project, Restricted Project

May 23 2022

jhenderson accepted D126133: [llvm-nm][docs] Document -W and -U.

LGTM!

May 23 2022, 3:56 AM · Restricted Project, Restricted Project

May 19 2022

jhenderson accepted D125658: [ifs] Switch to using OptTable.

All looks good to me!

May 19 2022, 2:16 AM · Restricted Project, Restricted Project

May 17 2022

jhenderson added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Has the spec for this been finalised anywhere? My main conceren is the use of section names to have semantic importance. ELF generally tries to avoid this, hence the use of section types, and it would be a shame to introduce this approach when there are other options. It would be far more preferable to include the version number in the section data somewhere, a bit like how most DWARF sections are encoded. I can think of one other possible way of doing this: change the section type value for version 1 and upwards, and rename the original value to something like SHT_LLVM_BB_ADDR_MAP_V0. Add the version field as the first N bytes (2 or 4 probably) of the new section type. Parsers understanding the old data structure only won't recognise the new section type as a recognised format. This is good because it doesn't mislead people by printing incorrect offsets (in addition to not needing to rely on the section name).

May 17 2022, 1:27 AM · Restricted Project, Restricted Project

May 16 2022

jhenderson added a reviewer for D125658: [ifs] Switch to using OptTable: MaskRay.

I've added @MaskRay as he's done a number of cl::opt -> OptTable transitions in other tools.

May 16 2022, 12:38 AM · Restricted Project, Restricted Project

May 15 2022

jhenderson added reviewers for D125604: [FileCheck] Catch missspelled directives.: jdenny, thopre.
May 15 2022, 11:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jhenderson added a comment to D125604: [FileCheck] Catch missspelled directives..

Code change looks good to me. Are the TODO cases where the test fails if changing them?

May 15 2022, 11:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jhenderson accepted D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

Looks great! But best to wait for @jhenderson

May 15 2022, 11:46 PM · Restricted Project, Restricted Project
jhenderson added a comment to D125204: [RISCV] Use RISCVISAInfo to parse arch string from ELF build attribute..

No more comments from me, but someone with RISCV knowledge should also review.

May 15 2022, 11:28 PM · Restricted Project, Restricted Project

May 13 2022

jhenderson added inline comments to D125204: [RISCV] Use RISCVISAInfo to parse arch string from ELF build attribute..
May 13 2022, 7:27 AM · Restricted Project, Restricted Project
jhenderson added a comment to D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..

Actually, according to the pre-merge checks, one of the tests is failing, and I suspect it might be related to this patch?

May 13 2022, 1:15 AM · Restricted Project, Restricted Project
jhenderson accepted D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64..
May 13 2022, 1:15 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D124865: [AIX] support read global symbol of big archive.
May 13 2022, 1:09 AM · Restricted Project, Restricted Project
jhenderson added a comment to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

LGTM, apart from a typo and a couple of unnecessary steps in the test.

May 13 2022, 12:34 AM · Restricted Project, Restricted Project

May 12 2022

jhenderson added inline comments to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.
May 12 2022, 7:44 AM · Restricted Project, Restricted Project
jhenderson accepted D123949: [AIX] support write operation of big archive..

All looks good to me, but I think it would be worth getting a second pair of eyes on it (@Esme?)

May 12 2022, 6:46 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D124865: [AIX] support read global symbol of big archive.
May 12 2022, 12:52 AM · Restricted Project, Restricted Project
jhenderson added a comment to D123949: [AIX] support write operation of big archive..

Just some nits left from me.

May 12 2022, 12:36 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.
May 12 2022, 12:21 AM · Restricted Project, Restricted Project

May 11 2022

jhenderson added inline comments to D124895: [Object] Fix updating darwin archives.
May 11 2022, 11:47 PM · Restricted Project, Restricted Project
jhenderson added inline comments to D125204: [RISCV] Use RISCVISAInfo to parse arch string from ELF build attribute..
May 11 2022, 11:44 PM · Restricted Project, Restricted Project
jhenderson added a comment to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

Okay, nothing else from me, but @dblaikie or another debuginfo person should review it too.

May 11 2022, 1:13 AM · Restricted Project, Restricted Project, Restricted Project
jhenderson added a comment to D124792: [ifs] Add --strip-size flag.

Three nits, but otherwise LGTM, with the caveat that I'm not a user or regular developer of this tool, so there might be some cases I haven't considered. If there's someone else available to sign off too, that would be good.

May 11 2022, 1:11 AM · Restricted Project, Restricted Project

May 9 2022

jhenderson added a comment to D124895: [Object] Fix updating darwin archives.

Thanks for the updates! Unfortunately, I don't know anything about the specifics of Darwin archives, so I think it's best if one of the other reviewers signs off on the logic of this patch.

May 9 2022, 11:06 PM · Restricted Project, Restricted Project
jhenderson added inline comments to D125204: [RISCV] Use RISCVISAInfo to parse arch string from ELF build attribute..
May 9 2022, 1:28 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D124895: [Object] Fix updating darwin archives.
May 9 2022, 1:21 AM · Restricted Project, Restricted Project
jhenderson added a comment to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

One remaining nit from my point of view, but as noted, I haven't attempted to review the disassembly aspects in depth.

May 9 2022, 12:34 AM · Restricted Project, Restricted Project
jhenderson accepted D123902: [llvm-objcopy][ObjectYAML][mips] Add MIPS specific ELF section indexes.

LGTM, but please rename the test file as indicated, before landing.

May 9 2022, 12:29 AM · Restricted Project, Restricted Project

May 5 2022

jhenderson added inline comments to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
May 5 2022, 11:32 PM · Restricted Project, Restricted Project
jhenderson added inline comments to D124895: [Object] Fix updating darwin archives.
May 5 2022, 11:05 PM · Restricted Project, Restricted Project
jhenderson added inline comments to D124865: [AIX] support read global symbol of big archive.
May 5 2022, 11:00 PM · Restricted Project, Restricted Project
jhenderson added a comment to D124607: Add an error message to the default SIGPIPE handler.

The builds look good, maybe @jhenderson or @t.p.northover, can you land this for me, please? I don't have commit access.

May 5 2022, 10:50 PM · Restricted Project, Restricted Project
jhenderson added inline comments to D123949: [AIX] support write operation of big archive..
May 5 2022, 8:12 AM · Restricted Project, Restricted Project
jhenderson accepted D124607: Add an error message to the default SIGPIPE handler.

LGTM!

May 5 2022, 6:50 AM · Restricted Project, Restricted Project
jhenderson added a comment to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

I don't know the disassembly code well enough to feel comfortable reviewing it or its corresponding testing, without sinking more time into this review than I have available, so someone else better look at those parts at least.

May 5 2022, 6:05 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D124865: [AIX] support read global symbol of big archive.
May 5 2022, 5:00 AM · Restricted Project, Restricted Project
jhenderson added inline comments to D124895: [Object] Fix updating darwin archives.
May 5 2022, 4:50 AM · Restricted Project, Restricted Project
jhenderson added a comment to D124607: Add an error message to the default SIGPIPE handler.

I'm wondering if it would be better to use python to drive this test rather than a somewhat non-trivial shell script? I'm mostly concerned about the potential flakiness of the sleep 2 command, since on an overloaded system, it's possible this won't have the desired effect. If you use python, you could attach a reader to the stdout of the llvm-nm process, that only read a bit of output (e.g. 1 byte) before stopping and closing itself. This in turn should trigger the error on stderr, if I'm following the behaviour right.

May 5 2022, 4:45 AM · Restricted Project, Restricted Project
jhenderson accepted D124940: [AIX] llvm-link support big archive..

LGTM, with @MaskRay's summary change suggestion.

May 5 2022, 4:20 AM · Restricted Project, Restricted Project

May 4 2022

jhenderson added a comment to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

I've run out of time to properly review this today, but some more nits to be getting on with.

May 4 2022, 2:22 AM · Restricted Project, Restricted Project
jhenderson added a comment to D124887: [lld/mac] Support writing zippered dylibs and bundles.

I think otool changes should be split off into a separate patch. They should also be tested and documented in isolation.

May 4 2022, 2:11 AM · Restricted Project, Restricted Project, Restricted Project
jhenderson added inline comments to D124792: [ifs] Add --strip-size flag.
May 4 2022, 1:32 AM · Restricted Project, Restricted Project