Page MenuHomePhabricator

jhenderson (James Henderson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 18 2017, 2:49 AM (156 w, 5 d)

Recent Activity

Today

jhenderson added a comment to D73045: [obj2yaml] - Better indentations in the ELF output..

I'll give this a more thorough look at some point hopefully, but my instinct is the current situation is the worst of the three cases "good padding"/"excessive padding"/"no padding". I think a little bit of code complexity would be okay to improve the excessive padding situation. I'm not sure instinctively whether this is too much however. I'll give it some thought.

Mon, Jan 20, 7:53 AM · Restricted Project
jhenderson accepted D73046: [YAML] - Move yaml::Input and yaml::Ouput classes declarations..

LGTM. I assume that the only changes aside from a literal cut + paste are due to a clang-format run?

Mon, Jan 20, 7:49 AM · Restricted Project
jhenderson accepted D72913: [FileCheck] Make Match unittest more flexible.

LGTM.

Mon, Jan 20, 6:17 AM · Restricted Project
jhenderson accepted D72912: [FileCheck] Clean and improve unit tests.

LGTM. Thanks!

Mon, Jan 20, 5:40 AM · Restricted Project
jhenderson added a comment to D72992: [llvm-objdump] - Add column headers for relocation printing.

Thanks for the patch!

Mon, Jan 20, 3:03 AM · Restricted Project
jhenderson added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Mon, Jan 20, 2:35 AM · Restricted Project
jhenderson added inline comments to D72914: [FileCheck] Strengthen error checks in unit tests.
Mon, Jan 20, 1:57 AM · Restricted Project
jhenderson added inline comments to D72912: [FileCheck] Clean and improve unit tests.
Mon, Jan 20, 1:30 AM · Restricted Project
jhenderson added inline comments to D72913: [FileCheck] Make Match unittest more flexible.
Mon, Jan 20, 1:02 AM · Restricted Project
jhenderson accepted D72128: [llvm-objcopy][ELF] Allow setting SHF_EXCLUDE flag for ELF sections.

Aside from the inline comment, this looks good to me. Might want to get @MaskRay to approve before committing though.

Mon, Jan 20, 12:53 AM · Restricted Project

Fri, Jan 17

jhenderson added a comment to D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing.

Ping!

Fri, Jan 17, 7:36 AM · Restricted Project
jhenderson added a comment to D72157: [test][llvm-dwarfdump] Add extra test case for invalid MD5 form.

Ping?

Fri, Jan 17, 7:36 AM · Restricted Project
jhenderson added a comment to D72155: [DebugInfo] Make incorrect debug line extended opcode length non-fatal.

Ping!

Fri, Jan 17, 7:36 AM · Restricted Project
jhenderson added a comment to D72843: [llvm-readelf][llvm-readobj] - Fix the indentation when printing dynamic tags..

Hence the identation length is increased by 2 because of 2 round brackets printed additionally.

Fri, Jan 17, 5:32 AM · Restricted Project
jhenderson accepted D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.

LGTM!

Fri, Jan 17, 5:32 AM · Restricted Project
jhenderson accepted D72838: [llvm-objdump] - Fix the indentation when printing dynamic tags..

LGTM.

Fri, Jan 17, 5:32 AM · Restricted Project
jhenderson added a comment to D72843: [llvm-readelf][llvm-readobj] - Fix the indentation when printing dynamic tags..

In both cases, I'm struggling to follow why specific numbers are used, e.g. where does the "-1" "-3" etc come from?

Fri, Jan 17, 4:07 AM · Restricted Project

Thu, Jan 16

jhenderson added inline comments to D72838: [llvm-objdump] - Fix the indentation when printing dynamic tags..
Thu, Jan 16, 6:25 AM · Restricted Project
jhenderson updated subscribers of D67847: [Support] make report_fatal_error `abort` instead of `exit`.
Thu, Jan 16, 3:40 AM · Restricted Project, Restricted Project
jhenderson added a comment to D72358: [llvm-objcopy][test] Fix tests when path contains "bar".

Ping:)

Thu, Jan 16, 3:33 AM · Restricted Project
jhenderson added inline comments to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
Thu, Jan 16, 2:54 AM · Restricted Project

Wed, Jan 15

jhenderson accepted D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing..
Wed, Jan 15, 5:35 AM · Restricted Project
jhenderson accepted D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..

LGTM!

Wed, Jan 15, 2:10 AM · Restricted Project
jhenderson added inline comments to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Wed, Jan 15, 1:33 AM · Restricted Project
jhenderson accepted D72718: [llvm-nm] Use `StringRef` over `const std::string &` params.

LGTM.

Wed, Jan 15, 12:55 AM · Restricted Project

Tue, Jan 14

Herald added a reviewer for D65769: llvm-symbolizer: Untag addresses in object files by default.: jhenderson.

Please could you add this new switch to the documentation. I don't really understand what it does just by reading, so I can't do it myself!

Tue, Jan 14, 6:28 AM · Restricted Project
jhenderson accepted D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests..

LGTM.

Tue, Jan 14, 5:35 AM · Restricted Project
jhenderson added inline comments to D71872: [yaml2obj/obj2yaml] - Add support for SHT_RELR sections..
Tue, Jan 14, 4:39 AM · Restricted Project
jhenderson added a comment to D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags..

I think our goal is to make llvm-readobj -d and llvm-readelf -d consistent.

FWIW, I don't see a massive need for this (we don't make, e.g. symbol output consistent), but I don't oppose attempting it as long as llvm-readelf output is consistent with GNU readelf.

Tue, Jan 14, 1:42 AM · Restricted Project
jhenderson added a comment to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.

As mentioned in D52810, GNU nm's behaviour is the same for both a symbol table with only a null symbol and a completely missing symbol table (both print "no symbols"). I think both need testing.

Tue, Jan 14, 1:42 AM · Restricted Project
jhenderson added a comment to D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols.

I've got a fix llvm-nm that I will upload, but funnily enough it doesn't actually solve the wasm issue. The reason is that with ELF we always generate at least one local symbols (the STT_FILE symbols) so no unstripped object will ever report "no symbols". However compiling the empty file on wasm does generate file with a symbol table of size zero.. which mean the fix I'm proposing doesn't actually fix our issue.

FWIW, if you create an ELF object from an assembly file, the STT_FILE symbol will only be created if you have a .file directive.

Tue, Jan 14, 1:33 AM · Restricted Project

Mon, Jan 13

jhenderson committed rG07804f75a6cc: [DebugInfo] Make debug line address size mismatch non-fatal to parsing (authored by jhenderson).
[DebugInfo] Make debug line address size mismatch non-fatal to parsing
Mon, Jan 13, 8:31 AM
jhenderson closed D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.
Mon, Jan 13, 8:31 AM · Restricted Project
jhenderson added a comment to D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.

LGTM. Sorry for the delay.

Mon, Jan 13, 7:16 AM · Restricted Project
jhenderson committed rGb6ffa2fe1250: [DebugInfo][Support] Replace DWARFDataExtractor size function (authored by jhenderson).
[DebugInfo][Support] Replace DWARFDataExtractor size function
Mon, Jan 13, 3:00 AM
jhenderson closed D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.
Mon, Jan 13, 2:59 AM · Restricted Project
jhenderson removed a parent revision for D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function: D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.
Mon, Jan 13, 2:59 AM · Restricted Project
jhenderson removed a child revision for D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing: D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.
Mon, Jan 13, 2:59 AM · Restricted Project
jhenderson updated the summary of D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.
Mon, Jan 13, 2:59 AM · Restricted Project
jhenderson added a comment to D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags..

The benefit I see is that we do not need to care about printing "Operating System specific" or "Processor Specific" text
and doing actions to align columns after that. I.e. code that prints "<unknown:>" is just a bit simpler.
It is not clear how much useful to say that unknown value is "Operating System specific" or "Processor Specific".
(I am OK to copy GNU's behavior here if we decide we want it, though)

Mon, Jan 13, 2:25 AM · Restricted Project
jhenderson added a comment to D60389: FileCheck [9/12]: Add support for matching formats.

No problem with the constness changes.

Mon, Jan 13, 2:21 AM · Restricted Project

Fri, Jan 10

jhenderson added a comment to D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.

Ah, thanks for the context! Yeah, go ahead and commit it without a test case - the new implementation is strictly simpler/more obvious & I don't think the unit test really adds value/is likely to catch any regressions here.

Thanks. I didn't see your comment when I was doing the rebase, but I'll make sure to remove the extra unit test before landing it on Monday.

Fri, Jan 10, 7:46 AM · Restricted Project
jhenderson updated the diff for D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.

Rebased.

Fri, Jan 10, 7:46 AM · Restricted Project
jhenderson updated the diff for D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing.

Rebased + changed to assuming the stated length is always correct. This required some additional test changes to better demonstrate the behaviour difference.

Fri, Jan 10, 7:43 AM · Restricted Project
jhenderson updated the diff for D72157: [test][llvm-dwarfdump] Add extra test case for invalid MD5 form.

Rebase.

Fri, Jan 10, 7:43 AM · Restricted Project
jhenderson updated the diff for D72155: [DebugInfo] Make incorrect debug line extended opcode length non-fatal.

Rebased + changed to assume the stated opcode length is always correct.

Fri, Jan 10, 7:43 AM · Restricted Project
jhenderson updated the diff for D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.

Rebase.

Fri, Jan 10, 7:36 AM · Restricted Project
jhenderson added a comment to D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.

Added unit test case that would trigger the assertion mentioned in the description. I'm not entirely convinced that this test case is worthwhile, since with the change in how size() is calculated, it really is moot (e.g. I wouldn't have needed it if the size() function had always been the way I'm proposing).

Ah, I was more expecting an end-to-end test (with llvm-dwarfdump or similar) when you said in the patch description "The old behaviour could cause an assertion in the debug line parser"

What were the circumstances where this assertion would fail? Was the failure reachable with llvm-dwarfdump, or only via a unit test/non-production API usage?

Fri, Jan 10, 7:24 AM · Restricted Project
jhenderson removed a parent revision for D72159: [DebugInfo][NFC] Remove unused variable/fix variable naming: D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing.
Fri, Jan 10, 7:15 AM · Restricted Project
jhenderson removed a child revision for D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing: D72159: [DebugInfo][NFC] Remove unused variable/fix variable naming.
Fri, Jan 10, 7:15 AM · Restricted Project
jhenderson updated the summary of D72159: [DebugInfo][NFC] Remove unused variable/fix variable naming.
Fri, Jan 10, 7:15 AM · Restricted Project
jhenderson committed rG7e02406f6cf1: [DebugInfo][NFC] Remove unused variable/fix variable naming (authored by jhenderson).
[DebugInfo][NFC] Remove unused variable/fix variable naming
Fri, Jan 10, 7:06 AM
jhenderson committed rG6e3ca962fafb: [DebugInfo] Improve error message text (authored by jhenderson).
[DebugInfo] Improve error message text
Fri, Jan 10, 7:06 AM
jhenderson closed D72159: [DebugInfo][NFC] Remove unused variable/fix variable naming.
Fri, Jan 10, 7:05 AM · Restricted Project
jhenderson closed D72443: [DebugInfo] Improve error message text.
Fri, Jan 10, 7:05 AM · Restricted Project
jhenderson updated the diff for D72443: [DebugInfo] Improve error message text.

Rebase on master and add missed lld test.

Fri, Jan 10, 7:05 AM · Restricted Project
jhenderson added a comment to D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing.

As mentioned in another review - I'm not sure "assume bigger is correct" is a great strategy & not sure there's a lot of value in continuing in the face of a conflict like that. What sort of situations really benefit from such parsing optimism?

Fri, Jan 10, 4:10 AM · Restricted Project
jhenderson added a comment to D72155: [DebugInfo] Make incorrect debug line extended opcode length non-fatal.

Making it easier for consumers to continue and try to do something with slightly bad output. One of the problems with using the unrecoverable errors is that it prevents people even trying to iterate over later tables.

Fri, Jan 10, 3:46 AM · Restricted Project
jhenderson added a comment to D72157: [test][llvm-dwarfdump] Add extra test case for invalid MD5 form.

I guess these error messages could be more precise about what's invalid & why it's invalid. In this case I guess it's invalid because the DW_LNCT_MD5 has a form that contains only one byte, not large enough to encode a whole MD5 sum?

Fri, Jan 10, 2:59 AM · Restricted Project
jhenderson added a comment to D72155: [DebugInfo] Make incorrect debug line extended opcode length non-fatal.

Out of curiosity: what's your broader goal with this work? (it'll help understand what's in-scope and out of scope, and better understand the framing when reviewing changes)

Fri, Jan 10, 2:59 AM · Restricted Project

Thu, Jan 9

jhenderson accepted D72369: DWARFDebugLine.cpp: Format unknown line number standard opcodes.

I'd still really like to see a test that tests the other code path that tries to print DW_LNS_* (see the inline comment). The obvious thing to me to do would be to update the unit test "ParserPrintsStandardOpcodesWhenRequested", but it would require changes to the DwarfGenerator to create a custom prologue. If you don't want to do this, that's okay, as the code path is already untested.

Yes, that is rather out-of-the-way for what this patch is doing. My understanding is that you would be okay with letting this patch land?

Thu, Jan 9, 8:12 AM · Restricted Project
jhenderson added a comment to D72369: DWARFDebugLine.cpp: Format unknown line number standard opcodes.

I'd still really like to see a test that tests the other code path that tries to print DW_LNS_* (see the inline comment). The obvious thing to me to do would be to update the unit test "ParserPrintsStandardOpcodesWhenRequested", but it would require changes to the DwarfGenerator to create a custom prologue. If you don't want to do this, that's okay, as the code path is already untested.

Thu, Jan 9, 7:15 AM · Restricted Project
jhenderson updated the diff for D72443: [DebugInfo] Improve error message text.

Update missed test.

Thu, Jan 9, 5:59 AM · Restricted Project
jhenderson updated the diff for D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.

Address review comment.

Thu, Jan 9, 5:11 AM · Restricted Project
jhenderson added inline comments to D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.
Thu, Jan 9, 5:04 AM · Restricted Project
jhenderson created D72443: [DebugInfo] Improve error message text.
Thu, Jan 9, 4:23 AM · Restricted Project
jhenderson added a comment to D72157: [test][llvm-dwarfdump] Add extra test case for invalid MD5 form.

Early ping - I'd like to get this and the other related reviews in before the release branch is created if possible.

Thu, Jan 9, 2:58 AM · Restricted Project
jhenderson added a comment to D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing.

Early ping - I'd like to get this and the other related reviews in before the release branch is created if possible.

Thu, Jan 9, 2:58 AM · Restricted Project
jhenderson added a comment to D72155: [DebugInfo] Make incorrect debug line extended opcode length non-fatal.

Early ping - I'd like to get this and the other related reviews in before the release branch is created if possible.

Thu, Jan 9, 2:58 AM · Restricted Project
jhenderson added a comment to D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.

Early ping - I'd like to get this and the other related reviews in before the release branch is created if possible.

Thu, Jan 9, 2:55 AM · Restricted Project
jhenderson added a child revision for D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing: D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.
Thu, Jan 9, 2:54 AM · Restricted Project
jhenderson updated the diff for D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.

Added unit test case that would trigger the assertion mentioned in the description. I'm not entirely convinced that this test case is worthwhile, since with the change in how size() is calculated, it really is moot (e.g. I wouldn't have needed it if the size() function had always been the way I'm proposing).

Thu, Jan 9, 2:54 AM · Restricted Project

Wed, Jan 8

jhenderson added a comment to D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin.

Assuming the tests all pass, LGTM, thanks! Do you have commit access yet?

Thanks for the review! All tests passed and I've recently gained commit access and want to try to commit this. If there's nothing else, I will commit this

Wed, Jan 8, 2:34 AM · Restricted Project
jhenderson accepted D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin.

Assuming the tests all pass, LGTM, thanks! Do you have commit access yet?

Wed, Jan 8, 2:24 AM · Restricted Project
jhenderson added inline comments to D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin.
Wed, Jan 8, 1:26 AM · Restricted Project
jhenderson added a comment to D72369: DWARFDebugLine.cpp: Format unknown line number standard opcodes.

I think a better solution is to print something more meaningful. For example, "DW_LNS_unknown_<value>" or something similar. You can see examples of that with the DW_AT_unknown_* printing in debug-abbrev.s. I don't think that will be significantly more complex and will provide more user-friendly output. See also my inline comment about where to put the fix.

Wed, Jan 8, 1:17 AM · Restricted Project
jhenderson added inline comments to D72360: [Test] Make llvm and lld tests pass when $USER matches `bar`.
Wed, Jan 8, 1:08 AM · Restricted Project
jhenderson added inline comments to D72357: Fix llvm-objcopy when directory contains "bar"..
Wed, Jan 8, 12:59 AM · Restricted Project

Tue, Jan 7

jhenderson added inline comments to D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin.
Tue, Jan 7, 8:39 AM · Restricted Project
jhenderson created D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function.
Tue, Jan 7, 8:21 AM · Restricted Project
jhenderson added inline comments to D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin.
Tue, Jan 7, 3:04 AM · Restricted Project
jhenderson added a comment to D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin.

Well, if so, doesn't it duplicates what has been tested in sym.test?

Yes, but sym.test is not a very good test as it tries to test too many different things at once, which means it's hard to actually tell what it's testing or to maintain the test. I'd like to split it up/rewrite it/delete it etc at some point, although it's not high on my priority list. If we keep adding things to that test, it will actually make things worse. By putting this testing in the other test case, we have all our testing for this piece of functionality (i.e. what to do about unknown addresses) in one place, making it easy to find etc.

Tue, Jan 7, 2:55 AM · Restricted Project
jhenderson added a comment to D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin.

Also, I think it would be good to expand invalid-input-address.test to cover this. In fact, you might want to put both your new case and something equivalent to the existing one in sym.test in the same place. That way, we're not lumping multiple different kinds of checks into the same test file.

I'm not quite sure about this so I'd like to confirm my understanding again before updating. Feel free to correct me if I misunderstand this: adding new tests(instead of moving existing ones in sym.test) to invalid-input-address.test that checks for invalid value like the sometext used in sym.test. And the testcases cover command line, ordinary textual file and response file.

Tue, Jan 7, 2:36 AM · Restricted Project
jhenderson committed rG216796f234c7: [DebugInfo] Fix infinite loop caused by reading past debug_line end (authored by jhenderson).
[DebugInfo] Fix infinite loop caused by reading past debug_line end
Tue, Jan 7, 2:27 AM
jhenderson closed D72279: [DebugInfo] Fix infinite loop caused by reading past debug_line end.
Tue, Jan 7, 2:27 AM · Restricted Project
jhenderson added a comment to D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin.

Thanks for the patch! Could you add an additional test case for passing the values via a response file, rather than directly on the command-line, i.e. llvm-symbolizer <some args> @response.txt where response.txt contains "some text", inctwo and "some text2" etc.

Tue, Jan 7, 1:50 AM · Restricted Project

Mon, Jan 6

jhenderson created D72279: [DebugInfo] Fix infinite loop caused by reading past debug_line end.
Mon, Jan 6, 8:44 AM · Restricted Project
jhenderson accepted D60389: FileCheck [9/12]: Add support for matching formats.

LGTM from me on this. I can't think of anything else I'd like addressing, but please wait for @arichardson and anybody else who wants to comment to be happy.

Mon, Jan 6, 5:49 AM · Restricted Project
jhenderson committed rG89b11843254a: [test][DebugInfo][NFC] Rename method for clarity (authored by jhenderson).
[test][DebugInfo][NFC] Rename method for clarity
Mon, Jan 6, 3:31 AM
jhenderson closed D72156: [test][DebugInfo][NFC] Rename method for clarity.
Mon, Jan 6, 3:31 AM · Restricted Project
jhenderson accepted D72186: [FileCheck] Remove FileCheck prefix in API.

LGTM.

Mon, Jan 6, 3:30 AM · Restricted Project
jhenderson committed rGd68904f957ae: [NFC] Fix trivial typos in comments (authored by jhenderson).
[NFC] Fix trivial typos in comments
Mon, Jan 6, 2:54 AM
jhenderson closed D72143: [llvm] NFC: Fix trivial typos in comments.
Mon, Jan 6, 2:54 AM · Restricted Project
jhenderson added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Mon, Jan 6, 2:35 AM · Restricted Project
jhenderson added inline comments to D72128: [llvm-objcopy][ELF] Allow setting SHF_EXCLUDE flag for ELF sections.
Mon, Jan 6, 1:58 AM · Restricted Project
jhenderson accepted D72234: [llvm-readelf] Print EI_ABIVERSION as decimal instead of hexadecimal.

LGTM. I have no idea why this was hex in the first place.

Mon, Jan 6, 1:49 AM · Restricted Project
jhenderson updated subscribers of D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local.
Mon, Jan 6, 1:40 AM · Restricted Project
jhenderson added inline comments to D72186: [FileCheck] Remove FileCheck prefix in API.
Mon, Jan 6, 1:30 AM · Restricted Project
jhenderson accepted D72180: [MC] Add parameter `Address` to MCInstrPrinter::printInstruction.

This change itself looks good to me. If I understand correctly from @rnk's comment, his suggestion is that there should be an option in llvm-objdump to revert to the old behaviour (which as you point it would be to just pass in 0 instead of the current address). This would mean that people used to the offset behaviour can choose to use that still. I think there is some benefit to this too, but I guess that it should actually be a change to D72172.

Mon, Jan 6, 1:12 AM · Restricted Project
jhenderson accepted D72172: [MC] Add parameter `Address` to MCInstPrinter::printInst.

I don't see any problems with this, so LGTM, although with the caveat that I'm not familiar with some of the usage sites, so it might be worth getting others to confirm the value passed in for the address makes sense in some situations (e.g. llvm-mca).

Mon, Jan 6, 1:03 AM · Restricted Project