dblaikie (David Blaikie)
User

Projects

User Details

User Since
Oct 8 2012, 9:19 AM (267 w, 2 d)

Recent Activity

Mon, Nov 20

dblaikie committed rL318720: ASTMatchers{,Macros}.h: Add some extra macros to use for decl/def of matchers.
ASTMatchers{,Macros}.h: Add some extra macros to use for decl/def of matchers
Mon, Nov 20, 5:09 PM
dblaikie committed rL318719: FormatInternal.h: Add missing includes..
FormatInternal.h: Add missing includes.
Mon, Nov 20, 5:09 PM
dblaikie committed rL318718: Make some headers modular by adding missing includes/forward decls..
Make some headers modular by adding missing includes/forward decls.
Mon, Nov 20, 5:09 PM
dblaikie committed rL318715: xray-record-yaml.h: Remove unused file.
xray-record-yaml.h: Remove unused file
Mon, Nov 20, 4:33 PM
dblaikie committed rL318714: llvm-rc/ResourceScriptTokenList.h: Turns this into a .def file to imply that….
llvm-rc/ResourceScriptTokenList.h: Turns this into a .def file to imply that…
Mon, Nov 20, 4:23 PM
dblaikie committed rL318713: XRayRecord.h: Add missing #include.
XRayRecord.h: Add missing #include
Mon, Nov 20, 4:23 PM
dblaikie committed rL318712: YAML/XRay/std::vector: Fix ODR violation by removing local specialization.
YAML/XRay/std::vector: Fix ODR violation by removing local specialization
Mon, Nov 20, 4:23 PM
dblaikie committed rL318703: Add ADL support to range based <algorithm> extensions.
Add ADL support to range based <algorithm> extensions
Mon, Nov 20, 2:13 PM
dblaikie closed D40006: Add ADL support to range based <algorithm> extensions by committing rL318703: Add ADL support to range based <algorithm> extensions.
Mon, Nov 20, 2:13 PM

Thu, Nov 16

dblaikie committed rL318490: Fix a bunch more layering of CodeGen headers that are in Target.
Fix a bunch more layering of CodeGen headers that are in Target
Thu, Nov 16, 5:08 PM
dblaikie committed rL318491: Update for layering fix in LLVM CodeGen<>Target.
Update for layering fix in LLVM CodeGen<>Target
Thu, Nov 16, 5:08 PM
dblaikie committed rL318463: Attempt to fix inscrutible build break....
Attempt to fix inscrutible build break...
Thu, Nov 16, 2:40 PM
dblaikie committed rL318461: llvm-readobj/ARMEHABIPrinter.h: Make this a real/modular header.
llvm-readobj/ARMEHABIPrinter.h: Make this a real/modular header
Thu, Nov 16, 2:30 PM

Wed, Nov 15

dblaikie accepted D40006: Add ADL support to range based <algorithm> extensions.

Let's go with adl_begin/adl_end/adl_swap (feel free to add swap without further review following a similar pattern - though I guess maybe it doesn't need the helper indirection since it doesn't have a return value to worry about). Thanks!

Wed, Nov 15, 7:41 PM
dblaikie added a member for debug-info: dblaikie.
Wed, Nov 15, 10:24 AM
dblaikie committed rL318304: ASTMatchers.h: Fix ODR violations by avoiding internal linkage variables in….
ASTMatchers.h: Fix ODR violations by avoiding internal linkage variables in…
Wed, Nov 15, 8:52 AM

Tue, Nov 14

dblaikie added a comment to D40006: Add ADL support to range based <algorithm> extensions.

I'd be inclined to call these llvm::adl_begin and llvm::adl_end (& perhaps we should have an llvm::adl_swap while we're at it? That being the canonical example of "always use with ADL" sort of library)? But don't mind too much.

Tue, Nov 14, 11:28 AM

Mon, Nov 13

dblaikie added inline comments to D39981: [DebugInfo] Fix potential CU mismatch for SubprogramScopeDIEs..
Mon, Nov 13, 3:27 PM
dblaikie added a comment to rL317647: Target/TargetInstrInfo.h -> CodeGen/TargetInstrInfo.h to match layering.

We should also move TargetCallingConv.h, TargetLowering*.h TargetOpcodes.h, TargetRegisterInfo.h and TargetSubtargetInfo.h. I wonder how we ended up in todays situation...

Mon, Nov 13, 1:44 PM
dblaikie added a reviewer for D39783: Add ADL support to range based <algorithm> extensions: dblaikie.
Mon, Nov 13, 12:34 PM

Thu, Nov 9

dblaikie added inline comments to D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo.
Thu, Nov 9, 1:46 PM · debug-info
dblaikie added inline comments to D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo.
Thu, Nov 9, 12:57 PM · debug-info
dblaikie accepted D39855: [ADT] Rewrite mapped_iterator in terms of iterator_adaptor_base..

Looks good to me - thanks!

Thu, Nov 9, 11:38 AM
dblaikie added inline comments to D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo.
Thu, Nov 9, 11:35 AM · debug-info

Tue, Nov 7

dblaikie committed rL317647: Target/TargetInstrInfo.h -> CodeGen/TargetInstrInfo.h to match layering.
Target/TargetInstrInfo.h -> CodeGen/TargetInstrInfo.h to match layering
Tue, Nov 7, 5:03 PM

Fri, Nov 3

dblaikie committed rL317379: Move TargetFrameLowering.h to CodeGen where it's implemented.
Move TargetFrameLowering.h to CodeGen where it's implemented
Fri, Nov 3, 3:33 PM
dblaikie committed rL317366: GCOV: Move GCOV from IR & Support into ProfileData to fix layering.
GCOV: Move GCOV from IR & Support into ProfileData to fix layering
Fri, Nov 3, 1:58 PM
dblaikie committed rL317365: llvm-objdump: Fix unused-lambda-capture warning by removing unused lambda….
llvm-objdump: Fix unused-lambda-capture warning by removing unused lambda…
Fri, Nov 3, 1:57 PM
dblaikie committed rL317360: Modularize: Include some required headers.
Modularize: Include some required headers
Fri, Nov 3, 1:25 PM

Thu, Nov 2

dblaikie committed rL317279: Modular Codegen: Don't home always_inline functions.
Modular Codegen: Don't home always_inline functions
Thu, Nov 2, 3:29 PM
dblaikie accepted D39384: Add and make use of llvm::for_each.

I still feel like for_each might as well change to range-based-for. Some of these examples are admittedly a bit awkward as range-based-for & I doubt there's going to be a big proliferation of for_each from people who don't know range-for is there, so doesn't seem like there's much harm/risk to having this for the few cases it can be handy for. (:

Thu, Nov 2, 3:04 PM
dblaikie committed rL317274: Modular Codegen: Don't home/modularize static functions in headers.
Modular Codegen: Don't home/modularize static functions in headers
Thu, Nov 2, 2:56 PM

Mon, Oct 30

dblaikie accepted D39428: [Analyzer] As suggested, use value storage for BodyFarm.

Looks good - thanks!

Mon, Oct 30, 11:57 AM

Fri, Oct 27

dblaikie committed rL316803: Add a few missing headers for modularization/IWYU/etc.
Add a few missing headers for modularization/IWYU/etc
Fri, Oct 27, 3:13 PM
dblaikie committed rL316794: StaticAnalyzer: Modularize/fix ODR violations making functions inline but non….
StaticAnalyzer: Modularize/fix ODR violations making functions inline but non…
Fri, Oct 27, 1:41 PM
dblaikie committed rL316793: Sanitizers.h: Modularize/Fix ODR violations by making inline functions non….
Sanitizers.h: Modularize/Fix ODR violations by making inline functions non…
Fri, Oct 27, 1:41 PM
dblaikie committed rL316792: CharInfo.h: Modularize/fix ODR violations by making inline functions in header….
CharInfo.h: Modularize/fix ODR violations by making inline functions in header…
Fri, Oct 27, 1:41 PM
dblaikie committed rL316791: ASTContext.h: Modularize/fix ODR violations by removing 'static' from inline….
ASTContext.h: Modularize/fix ODR violations by removing 'static' from inline…
Fri, Oct 27, 1:41 PM

Thu, Oct 26

dblaikie committed rL316715: InstructionSelectorImpl.h: Modularize/remove ODR violations by using a static….
InstructionSelectorImpl.h: Modularize/remove ODR violations by using a static…
Thu, Oct 26, 4:40 PM
dblaikie committed rL316714: MCCodePadder.h: Include definition of type for use with DenseMap.
MCCodePadder.h: Include definition of type for use with DenseMap
Thu, Oct 26, 4:40 PM
dblaikie committed rL316706: Support/reg*: Roll some non-modular headers into their singular uses.
Support/reg*: Roll some non-modular headers into their singular uses
Thu, Oct 26, 2:33 PM
dblaikie committed rL316696: Support/reg*.h: Make headers include their dependencies.
Support/reg*.h: Make headers include their dependencies
Thu, Oct 26, 1:23 PM

Wed, Oct 25

dblaikie committed rL316604: Hexagon: Fold a single-use textual header into its use.
Hexagon: Fold a single-use textual header into its use
Wed, Oct 25, 12:52 PM
dblaikie accepted D39258: [zorg] Update status reporting of reverse-iteration builder.
Wed, Oct 25, 12:25 PM
dblaikie accepted D39277: [XRay][compiler-rt] Remove more STL dependenices from FDR mode.
Wed, Oct 25, 12:21 PM
dblaikie added a reviewer for D39300: [SectionMemoryManager] Abstract out mmap, munmap, mprotect even more ; NFC: lhames.
Wed, Oct 25, 10:47 AM

Tue, Oct 24

dblaikie committed rL316517: ARMAddressingModes.h: Don't mark header functions as file local.
ARMAddressingModes.h: Don't mark header functions as file local
Tue, Oct 24, 2:30 PM
dblaikie committed rL316516: ValueMapper.h: Don't mark header functions as file local.
ValueMapper.h: Don't mark header functions as file local
Tue, Oct 24, 2:30 PM
dblaikie committed rL316515: Transforms/Utils/Local.h: Don't mark header functions as file local.
Transforms/Utils/Local.h: Don't mark header functions as file local
Tue, Oct 24, 2:30 PM
dblaikie committed rL316514: TargetOpcodes.h: Don't mark header functions as file local.
TargetOpcodes.h: Don't mark header functions as file local
Tue, Oct 24, 2:29 PM
dblaikie committed rL316512: ConvertUTF.h: Don't mark header functions as file local.
ConvertUTF.h: Don't mark header functions as file local
Tue, Oct 24, 2:29 PM
dblaikie committed rL316513: Printable.h: Don't mark header functions as file local.
Printable.h: Don't mark header functions as file local
Tue, Oct 24, 2:29 PM
dblaikie committed rL316511: AtomicOrdering.h: Don't mark header functions as file local.
AtomicOrdering.h: Don't mark header functions as file local
Tue, Oct 24, 2:29 PM
dblaikie committed rL316509: Type.h: Don't mark header functions as file local.
Type.h: Don't mark header functions as file local
Tue, Oct 24, 2:29 PM
dblaikie committed rL316510: LaneBitmask.h: Don't mark header functions as file local.
LaneBitmask.h: Don't mark header functions as file local
Tue, Oct 24, 2:29 PM
dblaikie committed rL316508: HexagonDepTimingClasses.h: Don't mark header functions as file local.
HexagonDepTimingClasses.h: Don't mark header functions as file local
Tue, Oct 24, 2:29 PM
dblaikie committed rL316507: WebassemblyAsmPrinter.h: Include WebAssemblyMachineFunctionInfo for use with….
WebassemblyAsmPrinter.h: Include WebAssemblyMachineFunctionInfo for use with…
Tue, Oct 24, 2:29 PM
dblaikie committed rL316506: X86Operand.h: Include X86MCTargetDesc.h for SSE register enum/names.
X86Operand.h: Include X86MCTargetDesc.h for SSE register enum/names
Tue, Oct 24, 2:29 PM
dblaikie committed rL316505: X86AsmPrinter.h: Add missing header for complete type needed for MCCodeEmitter….
X86AsmPrinter.h: Add missing header for complete type needed for MCCodeEmitter…
Tue, Oct 24, 2:29 PM
dblaikie committed rL316504: RegisterUsageInfo.h: Add missing header for complete type needed for DenseMap….
RegisterUsageInfo.h: Add missing header for complete type needed for DenseMap…
Tue, Oct 24, 2:29 PM
dblaikie committed rL316476: ValueTracking.h Don't mark header functions as file-scope static.
ValueTracking.h Don't mark header functions as file-scope static
Tue, Oct 24, 10:29 AM
dblaikie committed rL316477: BinaryFormat/MachO.h Don't mark header functions as file-scope static.
BinaryFormat/MachO.h Don't mark header functions as file-scope static
Tue, Oct 24, 10:29 AM
dblaikie committed rL316475: MemoryBuiltins.h: Don't mark header functions as file-scope static.
MemoryBuiltins.h: Don't mark header functions as file-scope static
Tue, Oct 24, 10:29 AM
dblaikie committed rL316474: IndirectCallSiteVisitor.h:findIndirectCallSites Don't mark header functions as….
IndirectCallSiteVisitor.h:findIndirectCallSites Don't mark header functions as…
Tue, Oct 24, 10:29 AM
dblaikie committed rL316473: StringExtras.h Don't mark header functions as file-scope static.
StringExtras.h Don't mark header functions as file-scope static
Tue, Oct 24, 10:29 AM
dblaikie committed rL316472: SmallVector.h:capacity_in_bytes Don't mark header functions as file-scope static.
SmallVector.h:capacity_in_bytes Don't mark header functions as file-scope static
Tue, Oct 24, 10:29 AM
dblaikie committed rL316471: DenseMap.h:capacity_in_bytes Don't mark header functions as file-scope static.
DenseMap.h:capacity_in_bytes Don't mark header functions as file-scope static
Tue, Oct 24, 10:29 AM
dblaikie committed rL316470: BitVector.h:capacity_in_bytes Don't mark header functions as file-scope static.
BitVector.h:capacity_in_bytes Don't mark header functions as file-scope static
Tue, Oct 24, 10:29 AM
dblaikie added inline comments to D39111: Extensible LLVM RTTI.
Tue, Oct 24, 9:04 AM

Oct 23 2017

dblaikie added inline comments to D39185: [llvm-dwarfdump] - Fix array out of bounds access crash..
Oct 23 2017, 10:17 AM

Oct 20 2017

dblaikie accepted D38806: DepthFirstIterator.h: Use C++11 features to call a completed method onthe set type, instead of requiring that one exists..

I'll add a unit test.

FWIW, you can get rid of the overload hack, i just can't get it to work in all compilers.

You can now nice create a class that has a ::value of true or false if the method exists,

Oct 20 2017, 12:14 PM
dblaikie added a comment to D38806: DepthFirstIterator.h: Use C++11 features to call a completed method onthe set type, instead of requiring that one exists..

Any chance of a unit test for this?

Oct 20 2017, 11:27 AM
dblaikie added a comment to D39111: Extensible LLVM RTTI.

Interesting idea - yeah, curious to hear how others feel about the tradeoff (non-closed, virtual call).

Oct 20 2017, 10:23 AM
dblaikie added inline comments to D38806: DepthFirstIterator.h: Use C++11 features to call a completed method onthe set type, instead of requiring that one exists..
Oct 20 2017, 10:05 AM

Oct 16 2017

dblaikie retitled D38806: DepthFirstIterator.h: Use C++11 features to call a completed method onthe set type, instead of requiring that one exists. from DepthFirstIterator.h: Use C++11 features to call a completed method on the set type, instead of requiring that one exists. to DepthFirstIterator.h: Use C++11 features to call a completed method onthe set type, instead of requiring that one exists..
Oct 16 2017, 7:03 PM

Oct 10 2017

dblaikie accepted D38767: Make Twine's copy constructor private.
Oct 10 2017, 3:14 PM
dblaikie added inline comments to D38719: [llvm-dwarfdump] Verify compatible TAG for attributes..
Oct 10 2017, 7:33 AM · debug-info
dblaikie added inline comments to D38721: [ELF] - Teach LLD to report line numbers for data symbols..
Oct 10 2017, 7:26 AM

Oct 9 2017

dblaikie added a comment to D38433: Introduce a specialized data structure to be used in a subsequent change.

Looks a fair bit like std::deque - what're the tradeoffs between the two?

Oct 9 2017, 4:27 PM
dblaikie accepted D36993: [llvm-dwarfdump] Print type names in DW_AT_type DIEs.

I still feel like the implementation that handles 'const' by truncating the name of the DWARF TAG itself isn't sufficiently general to be a great way to go, but it's not exactly destructive to other things, etc, so carry on.

Oct 9 2017, 11:30 AM
dblaikie added inline comments to D38409: [dwarfdump] Add -lookup option.
Oct 9 2017, 11:28 AM
dblaikie added inline comments to D38598: [llvm-objdump] Add RAII for xar apis.
Oct 9 2017, 11:18 AM
dblaikie added inline comments to D38119: [XRay][compiler-rt] Use a hand-written circular buffer in BufferQueue.
Oct 9 2017, 11:14 AM
dblaikie added inline comments to D38453: [dwarfdump] Verify that unit type matches root DIE.
Oct 9 2017, 11:07 AM

Sep 28 2017

dblaikie added inline comments to D38282: llvm-dwarfdump: implement --find=<name>.
Sep 28 2017, 11:27 AM
dblaikie added a comment to D38119: [XRay][compiler-rt] Use a hand-written circular buffer in BufferQueue.

Why all the logging & test changes in the latest update? Did they slip in accidentally?

Sep 28 2017, 11:03 AM

Sep 27 2017

dblaikie accepted D14358: DWARF's forward decl of a template should have template parameters..

Looks OK to me - couple of minor questions.

Sep 27 2017, 1:42 PM
dblaikie added a comment to D14358: DWARF's forward decl of a template should have template parameters..

I would prefer to eliminate the <params> from the instance name as well, because our debugger reconstructs a name more to its liking from the parameter children. However, IIUC the name with params is used for deduplication in LTO, so that is probably not such a good idea. :-)

Sep 27 2017, 11:21 AM
dblaikie accepted D38172: [Debug info] Handle endianness when moving debug info for split integer values.

Sounds good, I think.

Sep 27 2017, 11:08 AM
dblaikie added a comment to D38119: [XRay][compiler-rt] Use a hand-written circular buffer in BufferQueue.

Does this class have unit test coverage?

Sep 27 2017, 11:06 AM

Sep 25 2017

dblaikie added inline comments to D37932: [DebugInfo] Correctly coalesce DBG_VALUEs that mix direct and indirect values.
Sep 25 2017, 1:55 PM
dblaikie added inline comments to D38172: [Debug info] Handle endianness when moving debug info for split integer values.
Sep 25 2017, 8:59 AM
dblaikie added a comment to D38237: [dwarfdump] Add support for -debug-loc=OFFSET.

That test case looks really long... - could it be a bit more terse?

Sep 25 2017, 8:46 AM
dblaikie accepted D38240: [dwarfdump] Add support for -debug-line=OFFSET.

Seems good

Sep 25 2017, 8:45 AM

Sep 21 2017

dblaikie added inline comments to D38125: [dwarfdump] Add support for redirecting output to a file.
Sep 21 2017, 5:41 PM
dblaikie accepted D37971: [dwarfdump] Add verbose output for .debug-line section.

Seems good

Sep 21 2017, 7:48 AM

Sep 20 2017

dblaikie accepted D38064: llvm-dwarfdump: implement --recurse-depth=<N>.

Seems reasonable

Sep 20 2017, 10:02 AM
dblaikie added inline comments to D38078: [dsymutil] Don't resolve DIE reference to NULL DIE..
Sep 20 2017, 9:58 AM
dblaikie added inline comments to D37971: [dwarfdump] Add verbose output for .debug-line section.
Sep 20 2017, 9:46 AM
dblaikie added inline comments to D38002: Re-submit r289925 (Update .debug_line section version to match DWARF version).
Sep 20 2017, 9:41 AM