Page MenuHomePhabricator

dblaikie (David Blaikie)
User

Projects

User Details

User Since
Oct 8 2012, 9:19 AM (362 w, 6 d)

Recent Activity

Fri, Sep 20

dblaikie added inline comments to D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef.
Fri, Sep 20, 1:00 PM · Restricted Project, Restricted Project
dblaikie accepted D67797: [Support] Add a DataExtractor constructor that takes ArrayRef<uint8_t>.

Seems fine if we're already doing the same thing in a few places anyway.

Fri, Sep 20, 12:29 PM · Restricted Project

Thu, Sep 19

dblaikie accepted D67778: [Consumed] Narrow Subject for some attributes.

Looks good - thanks!

Thu, Sep 19, 5:42 PM · Restricted Project
dblaikie committed rG1796aad50ca5: llvm-reduce: Follow-up to 372280, now with more-better msan fixing (authored by dblaikie).
llvm-reduce: Follow-up to 372280, now with more-better msan fixing
Thu, Sep 19, 1:04 PM
dblaikie committed rL372349: llvm-reduce: Follow-up to 372280, now with more-better msan fixing.
llvm-reduce: Follow-up to 372280, now with more-better msan fixing
Thu, Sep 19, 1:03 PM
dblaikie added a comment to D67740: [Consumed] Refactor and improve diagnostics.

Looks like this might benefit from being split into independent changes - the work related to templates (I haven't looked closely, but I assume that's fairly indivisible) and the work related to other diagnostics seems fairly separable - and maybe there's other pieces too.

Thu, Sep 19, 12:54 PM · Restricted Project
dblaikie accepted D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs..

"Also, fix the order of if statements so that an explicit return_typestate annotation takes precedence over the default behavior for rvalue refs."

Thu, Sep 19, 12:34 PM · Restricted Project, Restricted Project
dblaikie added a comment to D67563: Debug Info: Add support for named constants.

Swift's let is indeed closer to C's const than to a named constant in Pascal (https://wiki.freepascal.org/Constants). The Swift language spec call them constants, and they are effectively SSA variables (with storage). But (and this is where it differs from Pascal constants) let bindings can also appear inside of composite types (there are let struct and class members) and as function arguments (unless a parameter is explicitly marked as inout, similar to Fortran). I have found that DW_TAG_const is the only mechanism that works for all of these use-cases.

Thu, Sep 19, 8:42 AM · Restricted Project, debug-info
dblaikie added a comment to D67668: [ADT] Add StringMap::insert_or_assign.

Could we have this as a standalone helper function (STLExtras or the like) rather than implementing it in every container?

We only need it in 2 unordered associative containers: DenseMap, and StringMap. Member methods have the advantage that they have better discoverability and can be easily be completed. This method is simple enough now. Placing it in STLExtras does not save much.

Thu, Sep 19, 7:58 AM · Restricted Project
dblaikie added a comment to D67563: Debug Info: Add support for named constants.

Would seem to me (with an obvious C++ bias in my view of the world) that it maps best to i_am_a_constant being a DW_TAG_variable (or function_parameter) with a DW_TAG_const_type that has a base type of "Int" (however that's represented).

But I realize that might not be a good fit for Swift/its debuggers, etc, and certainly tend to leave this up to whatever you folks want to do with your language. Just my 2c :)

It's not elegant in LLDB to peel the constness out of the type and attach it to the variable (the code that takes a DWARF type and returns a Swift type would need to ignore it and the code that builds an lldb_private::Variable needs to look into the DW_AT_type), but certainly doable, and implementation details of one specific debugger shouldn't really affect this decision. The prevalence of let-bindings may cause debug info to blow up a bit with all the extra DW_TAG_const_types, but that's not going to be a showstopper either.

Thu, Sep 19, 7:23 AM · Restricted Project, debug-info

Wed, Sep 18

dblaikie added a comment to D67647: [Consumed] Refactor handleCall to take function argument list. NFC..

I wasn't expecting it to involve all this work - but instead to change "arguments()" to return ArrayRef. Though perhaps you didn't go that route to allow future fixes to the strict aliasing (by having an adapting iterator - or perhaps arguments() already uses such an iterator that doesn't hit the strict aliasing issue?) needing to do even more cleaunp work?

Yeah, arguments() returns an adapting iterator.

Wed, Sep 18, 6:31 PM · Restricted Project, Restricted Project
dblaikie committed rG798fe477e39d: llvm-reduce: Add pass to reduce instructions (authored by dblaikie).
llvm-reduce: Add pass to reduce instructions
Wed, Sep 18, 6:05 PM
dblaikie committed rL372282: llvm-reduce: Add pass to reduce instructions.
llvm-reduce: Add pass to reduce instructions
Wed, Sep 18, 6:05 PM
dblaikie closed D66263: [Bugpoint redesign] Added pass to reduce Instructions.
Wed, Sep 18, 6:05 PM · Restricted Project
dblaikie added a comment to D67647: [Consumed] Refactor handleCall to take function argument list. NFC..

Here's a new version of the patch that uses iterator ranges instead of ArrayRef, to avoid adding new uses of CallExpr::getArgs() in case it has to be removed in the future due to the strict aliasing issue.

Wed, Sep 18, 5:38 PM · Restricted Project, Restricted Project
dblaikie committed rGfa7f168a3712: llvm-reduce: Avoid use-after-free when removing a branch instruction (authored by dblaikie).
llvm-reduce: Avoid use-after-free when removing a branch instruction
Wed, Sep 18, 5:35 PM
dblaikie committed rL372280: llvm-reduce: Avoid use-after-free when removing a branch instruction.
llvm-reduce: Avoid use-after-free when removing a branch instruction
Wed, Sep 18, 5:33 PM
dblaikie committed rG69a923520223: llvm-reduce: Remove inaccurate doxy comment about a return that isn't returned (authored by dblaikie).
llvm-reduce: Remove inaccurate doxy comment about a return that isn't returned
Wed, Sep 18, 3:38 PM
dblaikie committed rL372271: llvm-reduce: Remove inaccurate doxy comment about a return that isn't returned.
llvm-reduce: Remove inaccurate doxy comment about a return that isn't returned
Wed, Sep 18, 3:38 PM
dblaikie added inline comments to rG070598bb529a: llvm-reduce: Add pass to reduce basic blocks.
Wed, Sep 18, 3:38 PM
dblaikie committed rGc4da7eeccde6: llvm-reduce: Fix inconsistencies between int/unsigned usage (standardize on int) (authored by dblaikie).
llvm-reduce: Fix inconsistencies between int/unsigned usage (standardize on int)
Wed, Sep 18, 3:32 PM
dblaikie committed rL372270: llvm-reduce: Fix inconsistencies between int/unsigned usage (standardize on int).
llvm-reduce: Fix inconsistencies between int/unsigned usage (standardize on int)
Wed, Sep 18, 3:31 PM
dblaikie committed rG070598bb529a: llvm-reduce: Add pass to reduce basic blocks (authored by dblaikie).
llvm-reduce: Add pass to reduce basic blocks
Wed, Sep 18, 2:47 PM
dblaikie committed rL372264: llvm-reduce: Add pass to reduce basic blocks.
llvm-reduce: Add pass to reduce basic blocks
Wed, Sep 18, 2:47 PM
dblaikie closed D66320: [Bugpoint redesign] Added pass to reduce Basic Blocks.
Wed, Sep 18, 2:46 PM · Restricted Project
dblaikie added a comment to D67647: [Consumed] Refactor handleCall to take function argument list. NFC..

Ugh, it looks like getArgs() is a massive strict aliasing violation. And it's used in enough different places in Clang that fixing the violation may require extensive refactoring... I've reported the issue as https://bugs.llvm.org/show_bug.cgi?id=43344, but I don't really want to fix it :)

However, I can at least update this patch to avoid using getArgs().

Wed, Sep 18, 12:17 PM · Restricted Project, Restricted Project
dblaikie added a comment to D67668: [ADT] Add StringMap::insert_or_assign.

Could we have this as a standalone helper function (STLExtras or the like) rather than implementing it in every container?

Wed, Sep 18, 12:17 PM · Restricted Project
dblaikie updated subscribers of D67723: [CodeView] Add option to disable inline line tables..

As per the bug - I'm not super inclined towards a function attribute here (& even if it's going to be an inliner rather than debug info generation/backend thing (which I'm more on the fence about - think I'm happy with either direction there, really) - I'd still be inclined towards it living in the DICompileUnit with other debug info things, rather than a function attribute). But happy to hear what other folks (especially the usual debug info cabal - @aprantl @probinson @JDevlieghere etc) think.

Wed, Sep 18, 12:17 PM · Restricted Project, Restricted Project

Tue, Sep 17

dblaikie added inline comments to D53768: Add VerboseOutputStream to CompilerInstance.
Tue, Sep 17, 2:12 PM
dblaikie added inline comments to D67649: [FileCheck] Move private interface to its own header.
Tue, Sep 17, 1:53 PM · Restricted Project
dblaikie added inline comments to D67665: [ADT] Add 2 DenseMap::insert_or_assign overloads.
Tue, Sep 17, 1:52 PM · Restricted Project
dblaikie added inline comments to D67647: [Consumed] Refactor handleCall to take function argument list. NFC..
Tue, Sep 17, 1:44 PM · Restricted Project, Restricted Project

Mon, Sep 16

dblaikie committed rGf27367cd3202: llvm-reduce: Clean out previous test temp/output dir, since it was a dir and… (authored by dblaikie).
llvm-reduce: Clean out previous test temp/output dir, since it was a dir and…
Mon, Sep 16, 5:00 PM
dblaikie committed rL372054: llvm-reduce: Clean out previous test temp/output dir, since it was a dir and….
llvm-reduce: Clean out previous test temp/output dir, since it was a dir and…
Mon, Sep 16, 4:55 PM
dblaikie committed rGa458acb5ba85: llvm-reduce: Remove some string copies (authored by dblaikie).
llvm-reduce: Remove some string copies
Mon, Sep 16, 4:55 PM
dblaikie committed rL372053: llvm-reduce: Remove some string copies.
llvm-reduce: Remove some string copies
Mon, Sep 16, 4:53 PM
dblaikie committed rGcb4aee7318af: llvm-reduce: Make tests shell-independent by passing the interpreter on the… (authored by dblaikie).
llvm-reduce: Make tests shell-independent by passing the interpreter on the…
Mon, Sep 16, 4:43 PM
dblaikie committed rL372049: llvm-reduce: Make tests shell-independent by passing the interpreter on the….
llvm-reduce: Make tests shell-independent by passing the interpreter on the…
Mon, Sep 16, 4:42 PM

Fri, Sep 13

dblaikie committed rG4f3a4a8ca2f1: Bugpoint: Remove some unnecessary c_str conversions on the journey to StringRef (authored by dblaikie).
Bugpoint: Remove some unnecessary c_str conversions on the journey to StringRef
Fri, Sep 13, 5:34 PM
dblaikie committed rL371910: Bugpoint: Remove some unnecessary c_str conversions on the journey to StringRef.
Bugpoint: Remove some unnecessary c_str conversions on the journey to StringRef
Fri, Sep 13, 5:30 PM
dblaikie added a comment to D67563: Debug Info: Add support for named constants.

Out of curiosity does swift have const in the type system like C and C++? (I guess so) - and what would be the difference between a normal (non-let) variable of a const type, versus a let variable of a non-const type?

Swift does not have const in the type system. There are no real pointers in the language; the closest equivalent are probably constant struct members, such as:

struct MyStruct {
  let i_am_a_constant : Int = 42
  var i_am_mutable : String
}
Fri, Sep 13, 4:50 PM · Restricted Project, debug-info
dblaikie added a comment to D67563: Debug Info: Add support for named constants.

Out of curiosity does swift have const in the type system like C and C++? (I guess so) - and what would be the difference between a normal (non-let) variable of a const type, versus a let variable of a non-const type?

Fri, Sep 13, 4:11 PM · Restricted Project, debug-info
dblaikie added a comment to D67563: Debug Info: Add support for named constants.
In D67563#1669828, @vsk wrote:

IIUC @jingham makes the argument here that DW_TAG_constant isn't appropriate for swift's 'let', and instead suggests attaching DW_AT_const_value to the DW_TAG_variable (which lldb seems to already understand). Wdyt of that as an alternative?

Fri, Sep 13, 11:35 AM · Restricted Project, debug-info
dblaikie added a comment to D67563: Debug Info: Add support for named constants.

What's a "true named constant" as opposed to, say, C++ (or C's) "const int X = 3;" (well, I guess const int X could be defined by a runtime expression, - OK, what about "constexpr int X = 3;" then?)

Fri, Sep 13, 11:08 AM · Restricted Project, debug-info

Thu, Sep 12

dblaikie added a comment to D63031: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization.

Some more ping (:

Thu, Sep 12, 4:24 PM · Restricted Project
dblaikie accepted rL371772: Fix llvm-reduce tests so that they don't assume the source code is.

Oh, because copying the file is copying non-writable permissions? Fair enough.

Thu, Sep 12, 2:12 PM
dblaikie committed rG6be90ac788a5: llvm-reduce: For now, mark these tests as requiring a shell (authored by dblaikie).
llvm-reduce: For now, mark these tests as requiring a shell
Thu, Sep 12, 12:52 PM
dblaikie committed rL371764: llvm-reduce: For now, mark these tests as requiring a shell.
llvm-reduce: For now, mark these tests as requiring a shell
Thu, Sep 12, 12:51 PM
dblaikie committed rG890f17c256e6: llvm-reduce: Remove unused plugin support/requirements (authored by dblaikie).
llvm-reduce: Remove unused plugin support/requirements
Thu, Sep 12, 11:55 AM
dblaikie committed rL371755: llvm-reduce: Remove unused plugin support/requirements.
llvm-reduce: Remove unused plugin support/requirements
Thu, Sep 12, 11:54 AM
dblaikie added inline comments to rL368358: Added Delta IR Reduction Tool.
Thu, Sep 12, 11:54 AM

Wed, Sep 11

dblaikie added a comment to D67477: Add dependency from Orc to Passes.

I vaguely recall @lhames had some opinions on this layeering, might have another fix in mind.

Wed, Sep 11, 10:38 PM · Restricted Project
dblaikie added a reviewer for D67477: Add dependency from Orc to Passes: lhames.
Wed, Sep 11, 10:38 PM · Restricted Project
dblaikie committed rG5adb3d2ac0ab: Reapply llvm-reduce: Add pass to reduce parameters"" (authored by dblaikie).
Reapply llvm-reduce: Add pass to reduce parameters""
Wed, Sep 11, 6:22 PM
dblaikie committed rL371700: Reapply llvm-reduce: Add pass to reduce parameters"".
Reapply llvm-reduce: Add pass to reduce parameters""
Wed, Sep 11, 6:22 PM
dblaikie committed rGaaef97a55e48: PR43278: llvm-reduce: Use temporary file names (and ToolOutputFile) rather than… (authored by dblaikie).
PR43278: llvm-reduce: Use temporary file names (and ToolOutputFile) rather than…
Wed, Sep 11, 5:31 PM
dblaikie added a comment to D65026: [Bugpoint redesign] Added pass to reduce Metadata.

Just FYI, that our (IBM's) internal bots are also breaking because the following tests are not cleaning the build/test/Reduce/tmp folder:

LLVM :: Reduce/remove-funcs.ll
LLVM :: Reduce/remove-metadata.ll

And we're forced to sometimes do a clean build.

Wed, Sep 11, 5:31 PM · Restricted Project
dblaikie committed rL371696: PR43278: llvm-reduce: Use temporary file names (and ToolOutputFile) rather than….
PR43278: llvm-reduce: Use temporary file names (and ToolOutputFile) rather than…
Wed, Sep 11, 5:30 PM
dblaikie committed rGffe5466c791e: Add some missing changes to GSYM that was addressing a gcc compilation error… (authored by dblaikie).
Add some missing changes to GSYM that was addressing a gcc compilation error…
Wed, Sep 11, 3:25 PM
dblaikie committed rL371681: Add some missing changes to GSYM that was addressing a gcc compilation error….
Add some missing changes to GSYM that was addressing a gcc compilation error…
Wed, Sep 11, 3:25 PM
dblaikie committed rGd79cc1482276: PR43278: Temporarily disable llvm-reduce tests due to exhausting temp files (authored by dblaikie).
PR43278: Temporarily disable llvm-reduce tests due to exhausting temp files
Wed, Sep 11, 3:19 PM
dblaikie committed rL371679: PR43278: Temporarily disable llvm-reduce tests due to exhausting temp files.
PR43278: Temporarily disable llvm-reduce tests due to exhausting temp files
Wed, Sep 11, 3:19 PM
dblaikie added a comment to D67410: [DWARF] Emit call site parameter info when tuning for lldb.
In D67410#1666891, @vsk wrote:

The DWARFv5 forms were already the default choice when the tuning isn't set to GDB, this change is about allowing TAG_call_site_parameter to be emitted at all when the tuning is set to LLDB.

Wed, Sep 11, 2:02 PM · debug-info, Restricted Project
dblaikie added a comment to D67410: [DWARF] Emit call site parameter info when tuning for lldb.
In D67410#1666856, @vsk wrote:

I'm very curious what the effect of this patch on our green dragon statistics bot will be (http://green.lab.llvm.org/green/view/LLDB/job/clang-3.4-debuginfo-statistics/).

What sort of statistics do we track that would be impacted by this change?

None for now, because debug entry values are gated behind a CC1 flag the bot does not use.

Wed, Sep 11, 1:46 PM · debug-info, Restricted Project
dblaikie added a comment to D67410: [DWARF] Emit call site parameter info when tuning for lldb.

I'm very curious what the effect of this patch on our green dragon statistics bot will be (http://green.lab.llvm.org/green/view/LLDB/job/clang-3.4-debuginfo-statistics/).

Wed, Sep 11, 10:40 AM · debug-info, Restricted Project
dblaikie added a comment to D65026: [Bugpoint redesign] Added pass to reduce Metadata.

The test added in this change has a file leak that causes all possible temp file patterns to be created, at which point it starts failing, see https://bugs.llvm.org/show_bug.cgi?id=43278 (Diego, I tried to cc you, but bugzilla didn't know your email address.) Can you please take a look, and revert if it takes a while to investigate? (remove-funcs seems to have the same problem.)

Wed, Sep 11, 10:37 AM · Restricted Project

Tue, Sep 10

dblaikie committed rG068b36281498: Revert "llvm-reduce: Add pass to reduce parameters" (authored by dblaikie).
Revert "llvm-reduce: Add pass to reduce parameters"
Tue, Sep 10, 5:46 PM
dblaikie committed rL371580: Revert "llvm-reduce: Add pass to reduce parameters".
Revert "llvm-reduce: Add pass to reduce parameters"
Tue, Sep 10, 5:45 PM
dblaikie committed rG6a2603c06338: llvm-reduce: Add pass to reduce parameters (authored by dblaikie).
llvm-reduce: Add pass to reduce parameters
Tue, Sep 10, 4:11 PM
dblaikie committed rL371567: llvm-reduce: Add pass to reduce parameters.
llvm-reduce: Add pass to reduce parameters
Tue, Sep 10, 4:11 PM
dblaikie closed D65479: [Bugpoint redesign] Added pass to reduce parameters.
Tue, Sep 10, 4:11 PM · Restricted Project
dblaikie committed rGaac114ca140f: llvm-reduce: Remove some unused headers/more narrowly include them (authored by dblaikie).
llvm-reduce: Remove some unused headers/more narrowly include them
Tue, Sep 10, 3:33 PM
dblaikie committed rL371564: llvm-reduce: Remove some unused headers/more narrowly include them.
llvm-reduce: Remove some unused headers/more narrowly include them
Tue, Sep 10, 3:30 PM
dblaikie committed rG345fbfd74992: llvm-remove: Remove "using namespace" in header. (authored by dblaikie).
llvm-remove: Remove "using namespace" in header.
Tue, Sep 10, 3:12 PM
dblaikie committed rG477c1df4b9d6: llvm-reduce: Add pass to reduce Metadata (authored by dblaikie).
llvm-reduce: Add pass to reduce Metadata
Tue, Sep 10, 3:12 PM
dblaikie committed rL371563: llvm-remove: Remove "using namespace" in header..
llvm-remove: Remove "using namespace" in header.
Tue, Sep 10, 3:12 PM
dblaikie committed rL371562: llvm-reduce: Add pass to reduce Metadata.
llvm-reduce: Add pass to reduce Metadata
Tue, Sep 10, 3:12 PM
dblaikie closed D65026: [Bugpoint redesign] Added pass to reduce Metadata.
Tue, Sep 10, 3:12 PM · Restricted Project
dblaikie committed rG699bea494c01: llvm-reduce: Simplify testing using -implicit-check-not (authored by dblaikie).
llvm-reduce: Simplify testing using -implicit-check-not
Tue, Sep 10, 1:52 PM
dblaikie committed rL371555: llvm-reduce: Simplify testing using -implicit-check-not.
llvm-reduce: Simplify testing using -implicit-check-not
Tue, Sep 10, 1:51 PM
dblaikie added a comment to D67387: Move LLVM_ENABLE_ABI_BREAKING_CHECKS to its own file.

Might be worth having some more detail in the commit message to explain why -ffunction-sections/-gc-sections isn't sufficient to remove the binary size increase.

Tue, Sep 10, 11:32 AM · Restricted Project

Mon, Sep 9

dblaikie committed rL371482: Try something that's unlikely to make the SSI work... but maybe?.
Try something that's unlikely to make the SSI work... but maybe?
Mon, Sep 9, 6:47 PM
dblaikie committed rL371481: Add missing footer to 2019-10 talk abstracts.
Add missing footer to 2019-10 talk abstracts
Mon, Sep 9, 6:33 PM
dblaikie accepted D67373: Don't emit .gnu_pubnames when tuning for LLDB.

Seems good to me - thanks!

Mon, Sep 9, 4:34 PM · Restricted Project, Restricted Project
dblaikie added a comment to D67373: Don't emit .gnu_pubnames when tuning for LLDB.

Have you got a link to the original thread where this was discussed/I mentioned it? Want to page in some context to double-check if I had any ideas that might've let this simplify things.

Mon, Sep 9, 3:32 PM · Restricted Project, Restricted Project
dblaikie accepted D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614).

Fair enough - thanks!

Mon, Sep 9, 3:11 PM · Restricted Project
dblaikie accepted D67276: [DWARF] Add a unit test for DWARFUnit::getLength()..

Looks good to me - thanks!

Mon, Sep 9, 2:04 PM · Restricted Project, debug-info

Fri, Sep 6

dblaikie added a comment to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

It's just that it seemed weird/hacky to use asm just to stick assembler directives in the middle of the generated code instead of actual assembly, so I generated an assembly version and cleaned it up a bit. I'm happy to go back to the original shorter C++ version if that's not a concern.

Fri, Sep 6, 6:19 PM · Restricted Project
dblaikie added inline comments to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.
Fri, Sep 6, 6:09 PM · Restricted Project
dblaikie added inline comments to D67283: [GCOV] Skip artificial functions from being emitted.
Fri, Sep 6, 6:06 PM · Restricted Project
dblaikie added a comment to D67307: [MemorySSA] Do not create memoryaccesses for debug info intrinsics..

Any chance of test coverage? (not sure how the rest of this analysis is tested (or how we test analyses in general))

Fri, Sep 6, 5:33 PM · Restricted Project
dblaikie added a comment to D66976: Small update to Expected<StringRef>.

Any chance of a test case? This looks like it fixed a bug/difference in behavior.

rL370669 added a test

That doesn't seem to test this patch, though - if I revert this patch no tests fail.

Did you set LLVM_ENABLE_ABI_BREAKING_CHECKS to 1?

Before this patch NameOrErr was not consumed/ignored by consumeError.
If you revert it and run the test from rL370669, you should get a
"Expected<T> must be checked before access or destruction" failture.

Fri, Sep 6, 3:18 PM · Restricted Project
dblaikie added a comment to D67097: [DWARF] Check for format mismatch between CU and Range List Table..

Not sure I understand the snark at the C++ committee, but anyway.

Oh, because of their perennial willingness to change a released standard, with no way to identify revisions. The C++11 of today is not the same as the C++11 of 2011, for example. This is basic revision control, everybody (else) understands this. I mean, if we found a bug in Clang 8.0.0, we wouldn't overwrite the archived 8.0.0 to fix it. But that's effectively what the C++ committee does with its "defect repair."
The DWARF committee has the decency to provide a new version number when the interpretation of some attribute changes.

Fri, Sep 6, 2:22 PM · Restricted Project, debug-info
dblaikie added a comment to D67276: [DWARF] Add a unit test for DWARFUnit::getLength()..

As written, this will work only for little-endian. There are other unittests that are bi-endian that you ought to be able to use for examples; if nothing else, bail out after checking sys::IsLittleEndianHost (but a bi-endian test would be better).

Fri, Sep 6, 1:46 PM · Restricted Project, debug-info
dblaikie added a comment to D63672: Added Delta IR Reduction Tool.

Ok, I have an idea of using --test-arg but it would require the args to be passed before the filename. I'll post a patch.

Actually, I won't because I'm hitting some memory corruption in TestArgs and I don't really have time or motivation to fight it. Please fix your code.

Could you be more specific? I've tried running both tests under valgrind and haven't encountered any reported errors there.

In my case, passing --test-arg to the program caused TestArgs inside TestRunner to contain junk before the actual parameter strings.

Fri, Sep 6, 1:32 PM · Restricted Project

Thu, Sep 5

dblaikie accepted D67251: [Object] remove struct constructor, NFC.

Sounds good to me - thanks!

Thu, Sep 5, 7:17 PM · Restricted Project
dblaikie committed rG707be7ef9c1e: llvm-reduce: Use %python from lit to get the correct/valid python binary for… (authored by dblaikie).
llvm-reduce: Use %python from lit to get the correct/valid python binary for…
Thu, Sep 5, 4:33 PM
dblaikie added inline comments to D63672: Added Delta IR Reduction Tool.
Thu, Sep 5, 4:33 PM · Restricted Project
dblaikie committed rL371143: llvm-reduce: Use %python from lit to get the correct/valid python binary for….
llvm-reduce: Use %python from lit to get the correct/valid python binary for…
Thu, Sep 5, 4:32 PM
dblaikie accepted D67236: [MC] Fix undefined behavior in MCInstPrinter::formatHex.

Seems fairly reasonable to me - test might be able to be cleaned up a bit. Code might be cleaned up a bit (either now or in a follow-up commit)

Thu, Sep 5, 4:30 PM · Restricted Project