dblaikie (David Blaikie)
User

Projects

User Details

User Since
Oct 8 2012, 9:19 AM (289 w, 3 d)

Recent Activity

Today

dblaikie added a comment to D46138: Emit template type and value parameter DIEs for template variables..

I'm sorry if this was discussed earlier... Why are the template parameters attached to the variable, rather than the type?

Thu, Apr 26, 11:40 AM
dblaikie updated subscribers of D46137: Fix an assertion of This DIE should've already been constructed when the " "definition DIE was created in " "getOrCreateSubprogramDIE.

Hi there :)

Thu, Apr 26, 11:30 AM
dblaikie added a comment to D46119: Add a header file for enum IIT_Info, NFC.

The only place you could put it is in include/llvm/Support. I suspect this is why the content was duplicated like this.

Thu, Apr 26, 11:20 AM

Tue, Apr 24

dblaikie added a comment to D46021: [DEBUGINFO] Disable emission of the dwarf sections, but allow directives..

Sorry, I'm a bit confused.

Tue, Apr 24, 10:04 AM
dblaikie committed rL330726: Fix some layering in AggressiveInstCombine (avoiding inclusion of Scalar.h).
Fix some layering in AggressiveInstCombine (avoiding inclusion of Scalar.h)
Tue, Apr 24, 8:44 AM

Mon, Apr 23

dblaikie committed rL330679: Fixup Polly for an LLVM header file change..
Fixup Polly for an LLVM header file change.
Mon, Apr 23, 7:28 PM
dblaikie committed rL330671: Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM.
Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM
Mon, Apr 23, 6:02 PM
dblaikie committed rC330671: Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM.
Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM
Mon, Apr 23, 6:02 PM
dblaikie committed rL330670: Fix build breaks in examples due to moving stuff from Scalar.h to InstCombine.h.
Fix build breaks in examples due to moving stuff from Scalar.h to InstCombine.h
Mon, Apr 23, 6:02 PM
dblaikie committed rL330669: InstCombine: Fix layering by not including Scalar.h in InstCombine.
InstCombine: Fix layering by not including Scalar.h in InstCombine
Mon, Apr 23, 5:54 PM
dblaikie updated subscribers of D45926: Fix DISubprogram while extracting instructions out of function.

You can use attributes to force inlining or non-inlining to create a
particular scenario.

Mon, Apr 23, 3:27 PM
dblaikie added a comment to D45766: [Sema] Add -Wno-self-assign-overloaded.

Is there anything else in the "-w" namespace other than the literal "-w" so
far?

Mon, Apr 23, 3:26 PM
dblaikie updated subscribers of D45766: [Sema] Add -Wno-self-assign-overloaded.

FWIW I don't fundamentalyl object to also having something like -wtest.
Probably needs a better name though (unfortunately the double-negative gets
confusing... - like you want to describe the set of diagnostics that should
not be used in test code, so that as a group might be "-Wnon-test" but then
"-Wno-non-test" is pretty awkward) - probably worth chatting to Richard
Smith about that, I reckon.

Mon, Apr 23, 2:42 PM
dblaikie accepted D45766: [Sema] Add -Wno-self-assign-overloaded.
Mon, Apr 23, 1:15 PM
dblaikie added inline comments to D45766: [Sema] Add -Wno-self-assign-overloaded.
Mon, Apr 23, 1:02 PM
dblaikie edited reviewers for D45537: [CodeGenPrepare] Move Extension Instructions Through Logical And Shift Instructions, added: qcolombet; removed: dblaikie.
Mon, Apr 23, 1:00 PM
dblaikie added a comment to D45537: [CodeGenPrepare] Move Extension Instructions Through Logical And Shift Instructions.

Not really my area of expertise - just skimming the commit history for the file it looks like Quentin did a bunch of nearby work, so perhaps he can help?

Mon, Apr 23, 1:00 PM
dblaikie updated subscribers of D45782: [DEBUGINFO, NVPTX] Allow to disable debug info from command line..

Sounds like sort of "-gno-really-line-tables-only" (I kid, somewhat)

Mon, Apr 23, 11:02 AM

Fri, Apr 20

dblaikie added a comment to D45893: add more "anchors".

I'd say if we can't actually get it totally clean & enable the warning, maybe it's not worth doing all this? & you (& others in your situation) can contribute patches on an as-needed basis?

Fri, Apr 20, 12:39 PM

Thu, Apr 19

dblaikie added a comment to D41357: WIP: Fix Diagnostic layering, moving diagnostics out of Basic.

I've pushed this further - it builds now & has no fallback in libBasic to the old behavior/table.

Thu, Apr 19, 3:17 PM
dblaikie added inline comments to D45556: [DebugInfo] Generate DWARF debug information for labels..
Thu, Apr 19, 3:10 PM
dblaikie updated subscribers of D45792: [ADT] Teach reverse() about filter_iterator ranges.

+1 - I'd rather not have a special case for filter+reverse if we can help
it. If filter can be made bidi so it "just works" without reverse knowing
anything about it, that seems better.

Thu, Apr 19, 2:18 PM

Tue, Apr 17

dblaikie accepted D45711: [WebAssembly] Add an assertion for an invalid CFG.

ANyway, seems OK.

Tue, Apr 17, 12:23 PM
dblaikie updated subscribers of D45711: [WebAssembly] Add an assertion for an invalid CFG.

OK - so would "skipDebugInstructionsForward" ever need the end iterator?
since it should always come across a non-debug instruction (all valid BBs
have at least one non-debug instruction, the terminator - though I guess
you might call this function on an invalid basic block during
construction/intermediate state changes, etc).

Tue, Apr 17, 12:23 PM

Mon, Apr 16

dblaikie added a comment to D45711: [WebAssembly] Add an assertion for an invalid CFG.

No, it was producing the correct answer. As long as Header was not empty, whether that part of the code was Header or MBB didn't affect the result of the code.

Mon, Apr 16, 7:30 PM
dblaikie added a comment to D45711: [WebAssembly] Add an assertion for an invalid CFG.

I don't understand. The other change (D45648) was a bugfix, and MBB and Header are not the same thing, which was the reason I fixed that bug. A bugfix is not supposed to be NFC, right?

Mon, Apr 16, 7:17 PM
dblaikie added a comment to D45711: [WebAssembly] Add an assertion for an invalid CFG.

So does this make the other change NFC (under this assertion)? (ie: if the assertion is true, is "MBB" and "*Header" equivalent/the same thing?)

Mon, Apr 16, 6:20 PM
dblaikie updated subscribers of D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators..

I'm not sure this is a practical direction to pursue - though perhaps
others disagree.

Mon, Apr 16, 11:59 AM
dblaikie added a comment to D45657: [BasicBlock] Add instructionsWithoutDebug methods to skip debug insts..
In D45657#1068834, @vsk wrote:

I like the direction this is going in :).

I think having an API like 'instructions_no_debug' or similar in BasicBlock would make the interface friendlier. For one, it'd signal to readers that skipping debug intrinsics is an established pattern. Also, I think it would be easier to change if, e.g we wanted update all existing users of the API to skip lifetime intrinsics too.

Mon, Apr 16, 9:23 AM
dblaikie committed rL330128: SmallVectorMemoryBuffer: Fix some comments.
SmallVectorMemoryBuffer: Fix some comments
Mon, Apr 16, 7:26 AM

Sun, Apr 15

dblaikie accepted D45661: Rename ObjectMemoryBuffer to SmallVectorMemoryBuffer; NFCI.

Fix up a few comments & then it seems fine.

Sun, Apr 15, 7:53 PM

Fri, Apr 13

dblaikie added a comment to D45628: [LLDB] Support compressed debug info sections (.zdebug*).

Which compilers / platforms generate / support this? Is this an ELF-only feature?

Fri, Apr 13, 2:13 PM · Restricted Project

Thu, Apr 12

dblaikie updated subscribers of D45589: [DWARF] Defer emitting type units until the compile units are done..

But I don't think we start emitting the CU as we are going, right? I
thought it was handled much like the TUs would be by this patch - built...
And then emitted once it was fully built. (Indeed because new attributes
can be added to DIEs, forward references to future DIEs can exist, etc - we
currently have no support for streaming dwarf emission - the entire DIE
tree is built in memory, then emitted)

Thu, Apr 12, 3:20 PM · debug-info
dblaikie added a comment to D45589: [DWARF] Defer emitting type units until the compile units are done..

This would regress memory usage significantly - see r260578 / D17118 for more details. (17% decrease in memory usage when this was implemented)

Thu, Apr 12, 1:45 PM · debug-info
dblaikie added inline comments to D45549: [DWARF v5] improved support for .debug_rnglists/consumer.
Thu, Apr 12, 1:42 PM

Wed, Apr 11

dblaikie accepted D45244: Add missing vtable anchors.

Great - thanks for sticking with it, sorry for my dodgy explanations!

Wed, Apr 11, 3:27 PM
dblaikie added a comment to D45244: Add missing vtable anchors.

I meant that lib/LTO/LLVMBuild.txt should include "ExecutionEngine" in its
required_libraries. I wouldn't expect any changes would be needed to
tools/lto/* or tools/llvm-lto/*.

Wed, Apr 11, 1:48 PM
dblaikie committed rLLD329841: Rename to match an LLVM change.
Rename to match an LLVM change
Wed, Apr 11, 11:53 AM
dblaikie committed rL329841: Rename to match an LLVM change.
Rename to match an LLVM change
Wed, Apr 11, 11:53 AM
dblaikie committed rL329840: Rename *CommandFlags.def to *CommandFlags.inc.
Rename *CommandFlags.def to *CommandFlags.inc
Wed, Apr 11, 11:53 AM
dblaikie added a comment to D45244: Add missing vtable anchors.

That sort of surprises me - if that were the case, there would be no point
having LLVMBuild.txt files in any libraries, I would think?

Wed, Apr 11, 11:42 AM
dblaikie added a comment to D45244: Add missing vtable anchors.

I meant what happens if you remove the changes to tools/lto/LLVMBuild.txt
and tools/llvm-lto/LLVMBuild.txt and /only/ have a change to
lib/LTO/LLVMBuild.txt - is that sufficient to make the build work?

Wed, Apr 11, 10:25 AM
dblaikie updated the diff for D41357: WIP: Fix Diagnostic layering, moving diagnostics out of Basic.

Finish functional prototype - this now does remove the dependency from Basic to the various other libraries.

Wed, Apr 11, 9:58 AM
dblaikie added a comment to D45244: Add missing vtable anchors.

Is it sufficient to put the dependency MCJIT in lib/LTO/LLVMBuild.txt (since that's where the dependency on is) & not in the tools that /use/ the LTO lib (I expect they should pickup the indirect dependency implicitly?)?

Wed, Apr 11, 9:10 AM
dblaikie added a comment to D45024: [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label..

I realize it's non-trivial to keep these all in the same list - but I'd
rather not create a new list only to remove it again later if it can be
helped. What particular issues did you encounter when attempting to use a
single list?

Wed, Apr 11, 8:11 AM

Tue, Apr 10

dblaikie updated subscribers of D45396: [DebugInfo] Create merged locations for instructions other than calls.

0.6% increase to debug_line (assuming you checked & this didn't increase
anything else? Can't see how it could, but just checking - /maybe/ some
inlining/debug_ranges stuff?) seems acceptable to me.

Tue, Apr 10, 7:13 PM
dblaikie added a comment to D45490: [ADT] - Add llvm::make_mapped_range.

Hah, wow - didn't know you could include LLVM headers in godbolt code...
that's super handy :D

Tue, Apr 10, 9:45 AM
dblaikie accepted D45490: [ADT] - Add llvm::make_mapped_range.

Seems fine to me

Tue, Apr 10, 8:05 AM

Mon, Apr 9

dblaikie added a comment to D45244: Add missing vtable anchors.

You'd have to add the ExecutionEngine library as a dependency from the LTO
library - by modifying lib/LTO/LLVMBuild.txt - then it should link, I would
think.

Mon, Apr 9, 5:05 PM
dblaikie added a comment to D45396: [DebugInfo] Create merged locations for instructions other than calls.

Do you have the stats on this change in terms of line table size increase?

Mon, Apr 9, 4:40 PM
dblaikie updated subscribers of D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>.

FWIW - I had some thoughts on this a while back:
https://reviews.llvm.org/D4313

Mon, Apr 9, 4:18 PM · Restricted Project
dblaikie updated subscribers of D45244: Add missing vtable anchors.

Looks like ObjectMemoryBuffer is part of ExecutionEngine, so having libLTO
dependent on ExecutionEngine seems basically correct for the dependencies
that are there already. Whether or not those dependencies should be there
is another question, I guess. (maybe ObjectMemoryBuffer should be moved
somewhere more common, etc - but I wouldn't worry about doing that unless
the LTO dependency breaks things)

Mon, Apr 9, 12:02 PM
dblaikie updated subscribers of D45227: Instead of using std::copy, clear the vector first and add new elements. NFC..

Out of curiosity - what was the motivation for this change? I'd expect that
copy would be faster than repeated push_back (though maybe LLVM can
optimize it to match)

Mon, Apr 9, 11:41 AM

Fri, Apr 6

dblaikie accepted D45082: [RFC][unittests] ADT: silence -Wself-assign diagnostics.

Switch this to a C++ style static_cast and go ahead. Thanks!

Fri, Apr 6, 2:04 PM

Thu, Apr 5

dblaikie updated subscribers of D45344: [SimplifyLibcalls] Fold malloc + memset to calloc even for llvm.memset.

Test case?

Thu, Apr 5, 5:54 PM
dblaikie updated subscribers of D45024: [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label..

Probably best not to create another list on the DISubprogram - you might be
able to generalize the existing list to contain "anything that might be
optimized out"

Thu, Apr 5, 5:38 PM
dblaikie updated subscribers of D45024: [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label..

Rather than adding another list (if/when it comes to that) - we might want
to generalize the existing list to contain any/all local entities.

Thu, Apr 5, 3:40 PM
dblaikie added inline comments to D45307: [DWARF v5][NFC] Refactor the implementation of DebugRnglists .
Thu, Apr 5, 12:40 PM

Tue, Apr 3

dblaikie added a comment to D45122: [DebugInfo] Add a new DI flag to record if a C++ record is a trivial type.

This still doesn't /sound/ right to me - the triviality of a class doesn't
seem like it would correctly allow you to deduce the triviality of specific
special members? Because the the class would only be considered trivial if
all the special members are trivial, probably?

Tue, Apr 3, 11:35 AM
dblaikie committed rL329097: Restrict a test using named file descriptors to using the system shell.
Restrict a test using named file descriptors to using the system shell
Tue, Apr 3, 11:25 AM
dblaikie committed rC329097: Restrict a test using named file descriptors to using the system shell.
Restrict a test using named file descriptors to using the system shell
Tue, Apr 3, 11:25 AM
dblaikie committed rL329096: Disable a test using environment variables that requires a real shell.
Disable a test using environment variables that requires a real shell
Tue, Apr 3, 11:24 AM
dblaikie added a comment to D45122: [DebugInfo] Add a new DI flag to record if a C++ record is a trivial type.

I'm still not sure this description/name matches the examples given in the
other review from Reid.

Tue, Apr 3, 11:05 AM
dblaikie updated subscribers of D45195: Add --check-library-dependency to maintain compatibility with other linkers.

Makes sense to me - I haven't applied/tested the patch against some recent
commits to LLVM I've made that broke gold/binutils ld based builders but
didn't break for me locally (using lld), but assuming it catches those -
yeah, it'd be useful to me & I'd totally turn it on locally & suggest
anyone else using lld with LLVM to do so as well.

Tue, Apr 3, 10:42 AM
dblaikie added a comment to D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks.

iterator or iterator-like thing. One option would be a callback with Error
when the iterator is retrieved - and that's called back for any error (&
the user wouldn't need to differentiate the different kinds of error - the
iterator would stop when it couldn't continue). Or an Iterator-like but
not-actually-iterator API that exposes the Error during iteration (but
that'd probably look a bit awkward & be something like pair<Error,
Optional<T>> or, yes, as suggested - a separate Error type to communicate
"fail and cotninue" separately from "fail and stop"... )

Tue, Apr 3, 8:58 AM
dblaikie added a comment to D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks.

I was picturing the parser being the thing that exposes the iterator - so
it would be an internal detail & wouldn't really warrant an extra Error
type - but I haven't thought about it too hard & maybe that doesn't make
sense?

Tue, Apr 3, 8:44 AM
dblaikie added a comment to D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks.

I'm still a bit undecided about new Error types here - I think exposing an
iterator (or iterator-like thing) rather than special changes to the offset
or an error kind the user checks to see whether to iterate might be better?

Tue, Apr 3, 8:27 AM
dblaikie added a comment to D45082: [RFC][unittests] ADT: silence -Wself-assign diagnostics.

That's fair (re: cast over &*)

Tue, Apr 3, 8:27 AM

Mon, Apr 2

dblaikie added a comment to D45122: [DebugInfo] Add a new DI flag to record if a C++ record is a trivial type.

Does the proposed clang change (using 'isTrivial') match MSVC's behavior in
these cases?

Mon, Apr 2, 3:05 PM
dblaikie updated subscribers of D45122: [DebugInfo] Add a new DI flag to record if a C++ record is a trivial type.

Yeah, +1 for verifying whether or not DIFlagTypePassByValue/Reference is
sufficient for this.

Mon, Apr 2, 8:50 AM

Fri, Mar 30

dblaikie updated subscribers of D45082: [RFC][unittests] ADT: silence -Wself-assign diagnostics.

Comment might need to be reworded, but might not even need a comment - if
we build with the warning on by default anyone who attempts to remove it
will find out...

Fri, Mar 30, 1:30 PM

Thu, Mar 29

dblaikie committed rL328844: Fix some layering in StripNonLineTableDebugInfo, moving its declaration from….
Fix some layering in StripNonLineTableDebugInfo, moving its declaration from…
Thu, Mar 29, 3:45 PM
dblaikie committed rL328842: Remove unused header to fix layering..
Remove unused header to fix layering.
Thu, Mar 29, 3:38 PM
dblaikie committed rL328840: Remove unused headers to fix layering.
Remove unused headers to fix layering
Thu, Mar 29, 3:34 PM
dblaikie committed rL328839: llvm-c: Split Utils out of Scalar.h.
llvm-c: Split Utils out of Scalar.h
Thu, Mar 29, 3:34 PM
dblaikie committed rL328838: Remove some unneeded #includes to fix layering.
Remove some unneeded #includes to fix layering
Thu, Mar 29, 3:34 PM
dblaikie updated subscribers of D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks.

I'd probably guess that the best way to expose this is to use a higher
level construct than a raw offset exposed to the user of the API - some
kind of iterator should be exposed & then if parsing can't continue, it
doesn't continue. Rather than exposing the raw offset to the user & having
them have to handle passing it back in, or detecting when not to do so.

Thu, Mar 29, 10:08 AM
dblaikie accepted D45017: [IR][CodeGen] Remove dependency on EVT from IR/Function.cpp. Move EVT to CodeGen layer..

Fair - the minor 'duplication' seems fine, given it skips the work of mapping the llvm::Type to an EVT, etc...

Thu, Mar 29, 8:37 AM

Wed, Mar 28

dblaikie committed rL328745: Remove some unused includes to fix layering..
Remove some unused includes to fix layering.
Wed, Mar 28, 5:32 PM
dblaikie committed rL328744: Split Disassembler.h in two to fix dependencies.
Split Disassembler.h in two to fix dependencies
Wed, Mar 28, 5:32 PM
dblaikie committed rL328743: Add missing dependency (headers are included from MC, so a link dependency….
Add missing dependency (headers are included from MC, so a link dependency…
Wed, Mar 28, 5:32 PM
dblaikie committed rL328737: Plumb useAA through TargetTransformInfo to remove Transforms->CodeGen header….
Plumb useAA through TargetTransformInfo to remove Transforms->CodeGen header…
Wed, Mar 28, 3:34 PM
dblaikie updated subscribers of D44054: [DWARFv5] Emit file 0 to the line table..

Yeah, before committing to any new asm syntax, worth a conversation on
llvm-dev with the usual crew & hopefully we can rope in some folks from GCC
or whatnot. It might even be worth discussing on dwarf-discuss, even though
it's not technically a dwarf issue. (& if you're feeling up for it - if
we're having conversations about assembly syntax extensions anyway, there's
a couple of others that might be nice - the ability to specify a CU for
line table entries (LLVM can produce multiple line tables with its
integrated assembler, for use with LTO and ThinLTO, but falls back to
producing a single line table when producing textual assembly) - and maybe
one day the address pool stuff we've talked about)

Wed, Mar 28, 11:17 AM · debug-info
dblaikie committed rL328720: Oops - moved slightly too many things from Scalar to Utils. Move….
Oops - moved slightly too many things from Scalar to Utils. Move…
Wed, Mar 28, 11:07 AM
dblaikie committed rC328718: Fix for LLVM header changes.
Fix for LLVM header changes
Wed, Mar 28, 10:48 AM
dblaikie committed rL328718: Fix for LLVM header changes.
Fix for LLVM header changes
Wed, Mar 28, 10:48 AM
dblaikie committed rL328717: Transforms: Introduce Transforms/Utils.h rather than spreading the declarations….
Transforms: Introduce Transforms/Utils.h rather than spreading the declarations…
Wed, Mar 28, 10:47 AM

Mar 27 2018

dblaikie accepted D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address.

Seems good to me

Mar 27 2018, 10:14 AM
dblaikie added inline comments to D44429: [BinaryFormat][RFC] MessagePack reader/writer.
Mar 27 2018, 9:43 AM
dblaikie added a comment to D44826: Add -Wunused-using, a warning that finds unused using declarations..

You mention a missed case in the description - where the target of a using decl is used and that causes the unused-using not to warn about the using decl? That seems like a big limitation. Does that mean the 'used' bit is being tracked in the wrong place, on the target of the using decl instead of on the using decl itself?

Mar 27 2018, 9:40 AM · Restricted Project

Mar 26 2018

dblaikie committed rL328595: Add a build dependency from libMC to libDebugInfoCodeView to match the reality….
Add a build dependency from libMC to libDebugInfoCodeView to match the reality…
Mar 26 2018, 4:51 PM
dblaikie committed rL328594: Fix for header rename in LLVM.
Fix for header rename in LLVM
Mar 26 2018, 4:46 PM
dblaikie committed rLLD328594: Fix for header rename in LLVM.
Fix for header rename in LLVM
Mar 26 2018, 4:46 PM
dblaikie committed rL328593: Move CVDebugRecord from CodeView to Object to fix layering.
Move CVDebugRecord from CodeView to Object to fix layering
Mar 26 2018, 4:39 PM
dblaikie updated subscribers of D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes).

Historically Clang's policy on warnings was, I think, much more
conservative than it seems to be today. There was a strong desire not to
implement off-by-default warnings, and to have warnings with an
exceptionally low false-positive rate - maybe the user-defined operator
detection was either assumed to, or demonstrated to, have a sufficiently
high false positive rate to not meet that high bar.

Mar 26 2018, 3:20 PM
dblaikie added inline comments to D44429: [BinaryFormat][RFC] MessagePack reader/writer.
Mar 26 2018, 3:12 PM
dblaikie committed rL328565: Remove unused file, ExecutionEngine/MCJIT/ObjectBuffer.h.
Remove unused file, ExecutionEngine/MCJIT/ObjectBuffer.h
Mar 26 2018, 11:14 AM
dblaikie committed rL328549: Remove an unneeded (& mislayered) include from Target/TargetLoweringObjectFile….
Remove an unneeded (& mislayered) include from Target/TargetLoweringObjectFile…
Mar 26 2018, 10:02 AM
dblaikie committed rL328548: Remove unneeded (& mislayered) include from TargetMachine.cpp on a CodeGen….
Remove unneeded (& mislayered) include from TargetMachine.cpp on a CodeGen…
Mar 26 2018, 9:55 AM

Mar 23 2018

dblaikie committed rL328399: Remove unused header from EntryExitInstrumenter.
Remove unused header from EntryExitInstrumenter
Mar 23 2018, 5:08 PM