Page MenuHomePhabricator

dblaikie (David Blaikie)
User

Projects

User Details

User Since
Oct 8 2012, 9:19 AM (345 w, 1 d)

Recent Activity

Today

dblaikie added a comment to D62202: Work around a Visual C++ bug.

Technically this violates the LLVM style guide which says "make anonymous namespaces as small as possible, and only use them for class declarations." (preferring static for functions) - https://llvm.org/docs/CodingStandards.html#anonymous-namespaces

Which argues for flagging it somehow.

Tue, May 21, 9:45 AM · Restricted Project
dblaikie added a comment to D62112: [ORC] fix use-after-move. NFC.

Hey @lhames - is this code tested? I guess they're only debug output, so might not be tested. (was the use-after-move likely to be UB (null deref, etc) or just likely to log not what was intended?)

Tue, May 21, 9:03 AM · Restricted Project
dblaikie added a comment to D62114: [Bugpoint] fix another use-after-move. NFC.

Is this code tested? (what happens if you replace this code with "assert(false);" and then run make check?) If not, it'd be good to add some test coverage that this has revealed is missing.

Tue, May 21, 8:55 AM · Restricted Project
dblaikie added a comment to D62202: Work around a Visual C++ bug.

To provide some missing details:
The original source gets a bogus compile-time error with Visual Studio 2017, prior to version 15.8. I have 15.2, so I need this patch to build Clang.
Our current minimum-version requirement (per CheckCompilerVersion.cmake) is Visual Studio 2015 (some specific update), which assumes all Visual Studio 2017 versions are usable. So by that criterion, we need this patch for all Visual Studio 2017 versions to be usable.
Arguably the anonymous-namespace version is the "more modern" tactic anyway, so as a long-term fix this is actually fine anyway.

Tue, May 21, 8:55 AM · Restricted Project
dblaikie added a comment to D62118: [DWARF] hoist nullptr checks. NFC.

Is there a test case for this codepath? Or should it be an assertion instead?

Tue, May 21, 8:33 AM · Restricted Project

Yesterday

dblaikie accepted D62071: [DebugInfo] Handle -main-file-name correctly for asm source..

Cool cool (:

Mon, May 20, 1:44 PM · Restricted Project, debug-info
dblaikie accepted D62074: [DebugInfo] Handle '# line "file"' correctly for asm source..

Seems reasonable :)

Mon, May 20, 1:44 PM · Restricted Project, debug-info

Thu, May 16

dblaikie accepted D62027: Convert PointerUnion to a variadic template..

Nice!

Thu, May 16, 3:41 PM · Restricted Project

Tue, May 14

dblaikie accepted D61880: [IRMover] Improve diagnostic messages for conflicting metadata.

Seems reasonable - thanks!

Tue, May 14, 11:37 AM · Restricted Project

Fri, May 10

dblaikie committed rG7598b71488d8: DebugInfo: Only move types out of type units if they're named or type united (authored by dblaikie).
DebugInfo: Only move types out of type units if they're named or type united
Fri, May 10, 12:14 PM
dblaikie committed rL360458: DebugInfo: Only move types out of type units if they're named or type united.
DebugInfo: Only move types out of type units if they're named or type united
Fri, May 10, 12:13 PM

Thu, May 9

dblaikie committed rG12faa0d44bf7: DebugInfo/DWARF: Minor expression simplification (authored by dblaikie).
DebugInfo/DWARF: Minor expression simplification
Thu, May 9, 2:23 PM
dblaikie committed rL360377: DebugInfo/DWARF: Minor expression simplification.
DebugInfo/DWARF: Minor expression simplification
Thu, May 9, 2:21 PM
dblaikie accepted D61755: llvm-dwarfdump: Add dwo parsing to --statistics..

Looks good - thanks!

Thu, May 9, 2:01 PM · Restricted Project

Tue, May 7

dblaikie added inline comments to D61656: -frewrite-imports: Add support for wildcard rules in umbrella modules with.
Tue, May 7, 2:42 PM · Restricted Project
dblaikie committed rG89e58ddb2868: -frewrite-imports: Add support for wildcard rules in umbrella modules with (authored by dblaikie).
-frewrite-imports: Add support for wildcard rules in umbrella modules with
Tue, May 7, 2:37 PM
dblaikie committed rL360195: -frewrite-imports: Add support for wildcard rules in umbrella modules with.
-frewrite-imports: Add support for wildcard rules in umbrella modules with
Tue, May 7, 2:37 PM
dblaikie committed rC360195: -frewrite-imports: Add support for wildcard rules in umbrella modules with.
-frewrite-imports: Add support for wildcard rules in umbrella modules with
Tue, May 7, 2:36 PM
dblaikie closed D61656: -frewrite-imports: Add support for wildcard rules in umbrella modules with.
Tue, May 7, 2:36 PM · Restricted Project
dblaikie created D61656: -frewrite-imports: Add support for wildcard rules in umbrella modules with.
Tue, May 7, 2:13 PM · Restricted Project
dblaikie updated the diff for D61656: -frewrite-imports: Add support for wildcard rules in umbrella modules with.

Add another FIXME

Tue, May 7, 2:13 PM · Restricted Project

Mon, May 6

dblaikie added inline comments to D49511: [Sema/Attribute] Check for noderef attribute.
Mon, May 6, 12:26 PM · Restricted Project
dblaikie added a comment to D61253: DWARF v5: fix directory index in the line table.

I believe the changes here are correct. What I find unfortunate is that it is not able to test this without including a debug_info info section in the object file. Which is a bit ironic given that the purpose of these changes in DWARF5 was to have a fully-standalone .debug_line section.

The .debug_info is used by llvm-symbolizer to locate the compile unit. Without it llvm-symbolizer doesn't bother reading .debug_line...

Mon, May 6, 11:29 AM · Restricted Project

Fri, May 3

dblaikie committed rG639b3d1b83bf: Remove else-after-return (authored by dblaikie).
Remove else-after-return
Fri, May 3, 11:11 AM
dblaikie committed rL359913: Remove else-after-return.
Remove else-after-return
Fri, May 3, 11:11 AM
dblaikie committed rC359913: Remove else-after-return.
Remove else-after-return
Fri, May 3, 11:11 AM

Thu, May 2

dblaikie added a comment to D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes.

Oh, @rsmith - if there's any better/different testing (if you can figure out how to reduce the test case down further, now that we know the cause - or if you'd like testing for other codepaths I've touched in this patch) I'm all ears. (also naming/API wrangling - my changes were just the minimal sort of "this works" based on what we discussed, but totally happy to do more involved/different things if there's such to be done)

Perhaps we could add a diagnostic scope object of some kind, which would assert (or reorder the diagnostics?) if a diagnostic is produced while producing notes for a different diagnostic. That might help for new code and for places where we're aware -- or suspect -- there is a problem, but we don't know where the existing bugs are and that doesn't help us find them. :(

Thu, May 2, 5:50 PM · Restricted Project
dblaikie committed rG5e328050503c: SemaOverload: Complete candidates before emitting the error, to ensure… (authored by dblaikie).
SemaOverload: Complete candidates before emitting the error, to ensure…
Thu, May 2, 5:44 PM
dblaikie committed rL359854: SemaOverload: Complete candidates before emitting the error, to ensure….
SemaOverload: Complete candidates before emitting the error, to ensure…
Thu, May 2, 5:44 PM
dblaikie committed rC359854: SemaOverload: Complete candidates before emitting the error, to ensure….
SemaOverload: Complete candidates before emitting the error, to ensure…
Thu, May 2, 5:44 PM
dblaikie closed D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes.
Thu, May 2, 5:44 PM · Restricted Project
dblaikie committed rGa558ee810528: Do not warn on switches over enums that do not use [[maybe_unused]] enumerators (authored by dblaikie).
Do not warn on switches over enums that do not use [[maybe_unused]] enumerators
Thu, May 2, 9:31 AM
dblaikie committed rL359800: Do not warn on switches over enums that do not use [[maybe_unused]] enumerators.
Do not warn on switches over enums that do not use [[maybe_unused]] enumerators
Thu, May 2, 9:31 AM
dblaikie committed rC359800: Do not warn on switches over enums that do not use [[maybe_unused]] enumerators.
Do not warn on switches over enums that do not use [[maybe_unused]] enumerators
Thu, May 2, 9:30 AM
dblaikie closed D61444: Do not warn on switches over enums that do not use [[maybe_unused]] enumerators.
Thu, May 2, 9:30 AM · Restricted Project
dblaikie added a comment to D61408: Use primary template parameter names for variable template debug info.

Seems totally reasonable to me & it's what we do for other templates (function and class), it seems.

Might want to check alias templates too?

Thu, May 2, 8:47 AM · Restricted Project, Restricted Project
dblaikie created D61444: Do not warn on switches over enums that do not use [[maybe_unused]] enumerators.
Thu, May 2, 8:37 AM · Restricted Project

Wed, May 1

dblaikie accepted D61408: Use primary template parameter names for variable template debug info.

Seems totally reasonable to me & it's what we do for other templates (function and class), it seems.

Wed, May 1, 4:06 PM · Restricted Project, Restricted Project
dblaikie accepted D60955: [llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final".

Sorry, the title's multiple negatives confuse me a bit.

Wed, May 1, 8:55 AM · Restricted Project

Tue, Apr 30

dblaikie added a comment to D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes.

Oh, @rsmith - if there's any better/different testing (if you can figure out how to reduce the test case down further, now that we know the cause - or if you'd like testing for other codepaths I've touched in this patch) I'm all ears. (also naming/API wrangling - my changes were just the minimal sort of "this works" based on what we discussed, but totally happy to do more involved/different things if there's such to be done)

Tue, Apr 30, 5:47 PM · Restricted Project
dblaikie created D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes.
Tue, Apr 30, 5:46 PM · Restricted Project
dblaikie added a comment to D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used.

Seems like the right thing would be for the DWARF code that wants a rendered type name to pass its own printing policy, rather than changing some relatively global one.

(though also I have my doubts about the whole approach - macro expansion can change the line number as well as the column number, so only suppressing column number would be insufficient - and this also reduces the usability for users (because the file/line/column of an anonymous type is a useful debugging aid). Seems to me like this should be opt-in if it's supported at all - though ideally build systems would use -frewrite-includes rather than full preprocessing, and then macros and lines/columns would be preserved, I think)

Line number is ok because preprocessor also inserts #linemarker, and later on these markers are used to recover the original line number before macro expansion. Column is problematic, as there's nothing like a column marker (if possible at all) so there's no way to see through the column change from macro expansion. We tried -frewrite-includes too, but it has its own issues - without macro expansion, it bloats the file size that needs to send to distcc remote machine significantly.

Tue, Apr 30, 12:32 PM · Restricted Project
dblaikie added a comment to D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used.

Seems like the right thing would be for the DWARF code that wants a rendered type name to pass its own printing policy, rather than changing some relatively global one.

Tue, Apr 30, 9:35 AM · Restricted Project

Mon, Apr 29

dblaikie accepted D59107: [Support] Add error handling to sys::Process::getPageSize()..

Nah, that's all I've got.

Mon, Apr 29, 4:14 PM · Restricted Project

Thu, Apr 25

dblaikie committed rG0c4dbf9ecd32: Assigning to a local object in a return statement prevents copy elision. NFC. (authored by dblaikie).
Assigning to a local object in a return statement prevents copy elision. NFC.
Thu, Apr 25, 1:11 PM
dblaikie committed rL359236: Assigning to a local object in a return statement prevents copy elision. NFC..
Assigning to a local object in a return statement prevents copy elision. NFC.
Thu, Apr 25, 1:11 PM
dblaikie closed D54885: Assigning to a local object in a return statement prevents copy elision. NFC..
Thu, Apr 25, 1:11 PM · Restricted Project
dblaikie committed rGf0d66559ea34: Skip type units/type uniquing when we know we're only emitting the type once… (authored by dblaikie).
Skip type units/type uniquing when we know we're only emitting the type once…
Thu, Apr 25, 1:04 PM
dblaikie committed rL359235: Skip type units/type uniquing when we know we're only emitting the type once….
Skip type units/type uniquing when we know we're only emitting the type once…
Thu, Apr 25, 1:04 PM
dblaikie committed rC359235: Skip type units/type uniquing when we know we're only emitting the type once….
Skip type units/type uniquing when we know we're only emitting the type once…
Thu, Apr 25, 1:04 PM
dblaikie closed D61079: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug).
Thu, Apr 25, 1:04 PM · Restricted Project
dblaikie committed rG538bbe581402: DebugInfo: Fix bitrotted test case (authored by dblaikie).
DebugInfo: Fix bitrotted test case
Thu, Apr 25, 11:14 AM
dblaikie committed rC359217: DebugInfo: Fix bitrotted test case.
DebugInfo: Fix bitrotted test case
Thu, Apr 25, 11:14 AM
dblaikie committed rL359217: DebugInfo: Fix bitrotted test case.
DebugInfo: Fix bitrotted test case
Thu, Apr 25, 11:14 AM

Wed, Apr 24

dblaikie committed rG832c7d9f36bc: DebugInfo: Emit only declarations (not whole definitions) of non-unit user… (authored by dblaikie).
DebugInfo: Emit only declarations (not whole definitions) of non-unit user…
Wed, Apr 24, 11:08 AM
dblaikie committed rL359122: DebugInfo: Emit only declarations (not whole definitions) of non-unit user….
DebugInfo: Emit only declarations (not whole definitions) of non-unit user…
Wed, Apr 24, 11:07 AM
dblaikie created D61079: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug).
Wed, Apr 24, 10:23 AM · Restricted Project

Tue, Apr 23

dblaikie committed rG2f51176223f1: Reapply: "DebugInfo: Emit only one kind of accelerated access/name table"" (authored by dblaikie).
Reapply: "DebugInfo: Emit only one kind of accelerated access/name table""
Tue, Apr 23, 11:59 AM
dblaikie committed rL359026: Reapply: "DebugInfo: Emit only one kind of accelerated access/name table"".
Reapply: "DebugInfo: Emit only one kind of accelerated access/name table""
Tue, Apr 23, 11:58 AM
dblaikie committed rGa2470a465317: Revert "DebugInfo: Emit only one kind of accelerated access/name table" (authored by dblaikie).
Revert "DebugInfo: Emit only one kind of accelerated access/name table"
Tue, Apr 23, 8:02 AM
dblaikie committed rL358997: Revert "DebugInfo: Emit only one kind of accelerated access/name table".
Revert "DebugInfo: Emit only one kind of accelerated access/name table"
Tue, Apr 23, 8:01 AM

Mon, Apr 22

dblaikie added a comment to D60955: [llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final".

This seems to reversing r231221 which devirtualized this. What kind of customization are you envisioning? There aren't many methods here. Are you planning to override the parse method but still fall back to the base class version sometimes?

Mon, Apr 22, 4:03 PM · Restricted Project
dblaikie committed rG68602ab2f353: DebugInfo: Emit only one kind of accelerated access/name table (authored by dblaikie).
DebugInfo: Emit only one kind of accelerated access/name table
Mon, Apr 22, 3:45 PM
dblaikie committed rL358931: DebugInfo: Emit only one kind of accelerated access/name table.
DebugInfo: Emit only one kind of accelerated access/name table
Mon, Apr 22, 3:45 PM
dblaikie added inline comments to D60955: [llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final".
Mon, Apr 22, 12:55 PM · Restricted Project
dblaikie accepted D60965: [llvm-mc] - Properly set the the address align field of the compressed sections..

Soundsn good to me - thanks!

Mon, Apr 22, 12:00 PM · Restricted Project

Apr 19 2019

dblaikie committed rG07489f9ccf4a: Modules: Adopt template parameters for variable templates to set their decl… (authored by dblaikie).
Modules: Adopt template parameters for variable templates to set their decl…
Apr 19 2019, 4:03 PM
dblaikie committed rC358796: Modules: Adopt template parameters for variable templates to set their decl….
Modules: Adopt template parameters for variable templates to set their decl…
Apr 19 2019, 4:02 PM
dblaikie committed rL358796: Modules: Adopt template parameters for variable templates to set their decl….
Modules: Adopt template parameters for variable templates to set their decl…
Apr 19 2019, 4:02 PM
dblaikie committed rGaa3bf6ce721d: Modules: Search for a visible definition of the decl context when computing… (authored by dblaikie).
Modules: Search for a visible definition of the decl context when computing…
Apr 19 2019, 4:01 PM
dblaikie committed rC358795: Modules: Search for a visible definition of the decl context when computing….
Modules: Search for a visible definition of the decl context when computing…
Apr 19 2019, 4:01 PM
dblaikie committed rL358795: Modules: Search for a visible definition of the decl context when computing….
Modules: Search for a visible definition of the decl context when computing…
Apr 19 2019, 4:01 PM
dblaikie closed D60892: Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter.
Apr 19 2019, 4:01 PM · Restricted Project, Restricted Project

Apr 18 2019

dblaikie created D60892: Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter.
Apr 18 2019, 3:46 PM · Restricted Project, Restricted Project
dblaikie accepted D60872: Add new warning knob for unknown attribute namespaces.

Seems pretty good to me - if you'd like to wait for more/other feedback from @rsmith or the like, that's OK too.

Apr 18 2019, 11:39 AM
dblaikie added inline comments to D60872: Add new warning knob for unknown attribute namespaces.
Apr 18 2019, 11:03 AM

Apr 17 2019

dblaikie added a comment to D60470: [DWARF] Change ambiguity resolution from smallest CUOffset to largest (LowPC, CUOffset).

Ah, sorry, that's not the case I was interested in. I meant a case where two object files are linked together - one has debug info, one does not. They both have a comdat function. The non-debug info version is chosen (creating the [0, X) address range in the debug info from the other object).

If the linker makes the comdat function without debug info (assuming the debug info is not in a comdat) prevailing, the one with debug info is discarded while its debug info is kept. This is essentially the same as the --gc-sections case.

The compile unit with 0 DW_AT_low_pc is actually invalid because the addresses are incorrect. It should be ignored if it overlaps with a valid range when constructing aranges. This patch will do so.

If I understand it, this change is to the prioritization/resolution of ambiguities - but similar situations/bugs can arise when there is no ambiguity (because some code has no debug info - so it's not there to create an ambiguity). if I'm understanding/explaining correctly.

Yes, it is related to the resolution of ambiguities. The old rule is to pick the CU with the smallest E.CUOffset; the new rule is to pick the CU with the largest (E.LowPC, E.CUOffset) pair.

Apr 17 2019, 8:24 AM · Restricted Project
dblaikie accepted D60810: [Support] Add LEB128 support to BinaryStreamReader/Writer..

Looks reasonable to me

Apr 17 2019, 8:12 AM · Restricted Project

Apr 16 2019

dblaikie accepted D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf.

Looks ok - thanks!

Apr 16 2019, 12:59 PM · Restricted Project, Restricted Project
dblaikie added a comment to D60470: [DWARF] Change ambiguity resolution from smallest CUOffset to largest (LowPC, CUOffset).

What happens if a program is linked from some objects with debug info and some objects without it?

This revision doesn't change the behavior. For the address ranges with no debug info, the results remain ??:0:0 (unknown).

Apr 16 2019, 12:58 PM · Restricted Project
dblaikie added a comment to D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound.

Might've made sense to separate the NFC renaming from the perfect forwarding change (& the perfect forwarding change could potentially have some matching test coverage?)

I agree, sorry about mashing them in together. That said, I was confident this wouldn't cause any trouble in practice.
What kinds of tests are you thinking about? Checking that llvm::lower_bound works on non-copyable types?

Apr 16 2019, 11:31 AM · Restricted Project

Apr 15 2019

dblaikie accepted D60741: Remove some more unused headers from MachineFunction.h and friends..

Sounds good to me.
How'd you test that the MachineMemOperand.h changes were OK? Looks like it doesn't have an implementation file, so I'm not sure it's included first in any file - which means it's harder to tell if removing headers from it is valid/keeps it standalone (since its inclusion context might be allowing it to get away without including necessary headers)

Apr 15 2019, 5:23 PM · Restricted Project
dblaikie committed rGb068f92d94a5: DebugInfo: Default to standalone debug when tuning for LLDB (authored by dblaikie).
DebugInfo: Default to standalone debug when tuning for LLDB
Apr 15 2019, 5:16 PM
dblaikie committed rC358464: DebugInfo: Default to standalone debug when tuning for LLDB.
DebugInfo: Default to standalone debug when tuning for LLDB
Apr 15 2019, 5:14 PM
dblaikie committed rL358464: DebugInfo: Default to standalone debug when tuning for LLDB.
DebugInfo: Default to standalone debug when tuning for LLDB
Apr 15 2019, 5:14 PM
dblaikie added a comment to D59673: [Clang] Harmonize Split DWARF options with llc.

Sure, I think the naming's a bit weird (but hard to come up with good names for any of this)

Agreed, -split-dwarf-output is pretty clear, but -split-dwarf-file could be both the actual filename or the attribute.

There is test/CodeGen/split-debug-filename.c checking that we emit !DICompileUnit({{.*}}, splitDebugFilename: "foo.dwo" into the IR under some circumstances, but I'm not sure why. It seems to be ignored by llc.

Apr 15 2019, 2:40 PM · Restricted Project
dblaikie added a comment to D60470: [DWARF] Change ambiguity resolution from smallest CUOffset to largest (LowPC, CUOffset).

What happens if a program is linked from some objects with debug info and some objects without it?

Apr 15 2019, 2:36 PM · Restricted Project
dblaikie added inline comments to D60445: Change cast to dyn_cast to be consistent with other casts within same scope..
Apr 15 2019, 2:30 PM · Restricted Project
dblaikie added a comment to D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound.

Might've made sense to separate the NFC renaming from the perfect forwarding change (& the perfect forwarding change could potentially have some matching test coverage?)

Apr 15 2019, 11:14 AM · Restricted Project

Apr 10 2019

dblaikie added a comment to D60470: [DWARF] Change ambiguity resolution from smallest CUOffset to largest (LowPC, CUOffset).

What does addr2line (or any other symbolizers, not that I know of others) do in these cases?

addr2line doesn't use binary search. It iterates all ELF sections, finds the first section containing the address, then iterates DWARF CUs and finds the associated line table. It has the same problem

Apr 10 2019, 2:39 PM · Restricted Project
dblaikie updated subscribers of D59348: [DebugInfo] Combine Trivial and NonTrivial flags.
Apr 10 2019, 2:35 PM · Restricted Project
dblaikie accepted D59347: [DebugInfo] Combine Trivial and NonTrivial flags.

Approved pending the LLVM side changes/discussion.

Apr 10 2019, 2:32 PM · Restricted Project, Restricted Project
dblaikie added a comment to D59673: [Clang] Harmonize Split DWARF options with llc.

Ok, here is an idea. We introduce -split-dwarf-output in Clang instead of -fsplit-dwarf-dwo-name-attr. If given, it overrides the output file name for the Split DWARF file, which we otherwise take from -split-dwarf-file. The option is obviously incompatible with -enable-split-dwarf=single, so we will disallow that. This should be backwards-compatible, and bring the behavior of llc and clang -cc1 closer together. What do you think?

Apr 10 2019, 2:28 PM · Restricted Project
dblaikie accepted D60364: [DWARF] Set discriminator to 0 for DW_LNS_copy.

Should there also be an LLVM test - given that LLVM does emit DW_LNS_copy by the looks of it, and if it's been being incorrectly interpreted/dumped, then that seems to imply there's some missing LLVM test coverage for that case, maybe?

Do you mean a test of lib/MC/MCDwarf.cpp? As I understand it, lib/DebugInfo/DWARF is mostly the reader part and MC the writer part. With my casual reading, MCDwarf.cpp seems to do the correct thing by doing Discriminator = 0;. I haven't looked into that part yet but I can investigate that and add a test if needed in a separate change.

Apr 10 2019, 2:24 PM · Restricted Project
dblaikie added a comment to D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf.

is that to imply that the first block all do not use split DWARF?

The first block do not use split DWARF.

Apr 10 2019, 2:03 PM · Restricted Project, Restricted Project

Apr 9 2019

dblaikie added a comment to D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf.

I'm still not entirely clear on how this is all changing, sorry - in the patch description summary, the first block of examples doesn't mention which of those disables split DWARF (the second block of examples all say "+ split" - is that to imply that the first block all do not use split DWARF?

Apr 9 2019, 2:27 PM · Restricted Project, Restricted Project
dblaikie added a comment to D60364: [DWARF] Set discriminator to 0 for DW_LNS_copy.

Should there also be an LLVM test - given that LLVM does emit DW_LNS_copy by the looks of it, and if it's been being incorrectly interpreted/dumped, then that seems to imply there's some missing LLVM test coverage for that case, maybe?

Apr 9 2019, 2:13 PM · Restricted Project
dblaikie added a comment to D60470: [DWARF] Change ambiguity resolution from smallest CUOffset to largest (LowPC, CUOffset).

What does addr2line (or any other symbolizers, not that I know of others) do in these cases?

Apr 9 2019, 2:13 PM · Restricted Project

Apr 4 2019

dblaikie accepted D60290: NFC: Move API uses of MD5::MD5Result to Optional.

Looks good to me (:

Apr 4 2019, 4:25 PM · Restricted Project

Apr 2 2019

dblaikie added inline comments to D60147: [DWARF] check whether the DIE is valid before querying for information.
Apr 2 2019, 5:27 PM · Restricted Project