dblaikie (David Blaikie)
User

Projects

User Details

User Since
Oct 8 2012, 9:19 AM (319 w, 2 d)

Recent Activity

Sat, Nov 17

dblaikie committed rC347141: Sink BuryPointer from Clang into LLVM for reuse there.
Sink BuryPointer from Clang into LLVM for reuse there
Sat, Nov 17, 10:07 AM
dblaikie committed rL347141: Sink BuryPointer from Clang into LLVM for reuse there.
Sink BuryPointer from Clang into LLVM for reuse there
Sat, Nov 17, 10:07 AM
dblaikie committed rL347140: Move BuryPointer from Clang to LLVM for use in other LLVM tools.
Move BuryPointer from Clang to LLVM for use in other LLVM tools
Sat, Nov 17, 10:06 AM

Fri, Nov 16

dblaikie committed rL347134: llvm-symbolizer: Avoid calling getFromOffset when the index entry is already….
llvm-symbolizer: Avoid calling getFromOffset when the index entry is already…
Fri, Nov 16, 10:02 PM

Thu, Nov 15

dblaikie updated subscribers of D53329: Generate DIFile with main program if source is not available.

So I can see where/how this fails now - the LLVM backend seems to require that if any file has embedded source, they all do. Would you be able to/would you mind adding a debug info verifier check for this? That'd help make this fail sooner. (@scott.linder - perhaps you'd be able to/interested in doing this - looks like you wrote the initial implementation?)

Thu, Nov 15, 1:55 PM · debug-info
dblaikie added inline comments to D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC.
Thu, Nov 15, 1:10 PM · debug-info
dblaikie added inline comments to D54472: Disable invalid isPodLike<> specialization.
Thu, Nov 15, 1:08 PM
dblaikie updated subscribers of D54472: Disable invalid isPodLike<> specialization.
Thu, Nov 15, 1:04 PM
dblaikie accepted D54576: [clang] - Simplify tools::SplitDebugName..

Agreed - looks like this went in untested in r175813 & has never been used.

Thu, Nov 15, 10:56 AM
dblaikie added inline comments to D54472: Disable invalid isPodLike<> specialization.
Thu, Nov 15, 9:51 AM

Wed, Nov 14

dblaikie added inline comments to D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent.
Wed, Nov 14, 9:23 PM
dblaikie committed rL346929: NFC cleanup: Prefer make_unique over reset(new T()).
NFC cleanup: Prefer make_unique over reset(new T())
Wed, Nov 14, 7:08 PM
dblaikie committed rL346928: Fix combining pragma __debug dump & parser_crash with -E.
Fix combining pragma __debug dump & parser_crash with -E
Wed, Nov 14, 7:08 PM
dblaikie committed rL346927: Rewrite-imports on crash: Simplify handling.
Rewrite-imports on crash: Simplify handling
Wed, Nov 14, 7:07 PM
dblaikie committed rC346929: NFC cleanup: Prefer make_unique over reset(new T()).
NFC cleanup: Prefer make_unique over reset(new T())
Wed, Nov 14, 7:07 PM
dblaikie committed rC346928: Fix combining pragma __debug dump & parser_crash with -E.
Fix combining pragma __debug dump & parser_crash with -E
Wed, Nov 14, 7:07 PM
dblaikie committed rC346927: Rewrite-imports on crash: Simplify handling.
Rewrite-imports on crash: Simplify handling
Wed, Nov 14, 7:07 PM
dblaikie committed rC346926: Stmt bits: Make ExprBits relative to StmtBits.
Stmt bits: Make ExprBits relative to StmtBits
Wed, Nov 14, 7:07 PM
dblaikie committed rL346926: Stmt bits: Make ExprBits relative to StmtBits.
Stmt bits: Make ExprBits relative to StmtBits
Wed, Nov 14, 7:07 PM
dblaikie added a comment to D54384: [llvm-objcopy] Add --build-id-link-dir flag.

adding @lhames just as FYI for some stumbling over the Error-as-out-parameter usage.

Wed, Nov 14, 5:52 PM
dblaikie updated subscribers of D54384: [llvm-objcopy] Add --build-id-link-dir flag.
Wed, Nov 14, 5:50 PM
dblaikie added inline comments to D54384: [llvm-objcopy] Add --build-id-link-dir flag.
Wed, Nov 14, 5:50 PM
dblaikie added a comment to D53329: Generate DIFile with main program if source is not available.

Thanks for this - though it looks like the test program hits an assertion failure (for me at least - before it gets to the interesting point.

Wed, Nov 14, 2:59 PM · debug-info
dblaikie accepted D54524: [AST] Pack UnaryOperator.

Looks good - thanks!

Wed, Nov 14, 12:59 PM · Restricted Project
dblaikie accepted D54525: [AST] Pack MemberExpr.

Looks good - thanks!

Wed, Nov 14, 12:58 PM · Restricted Project
dblaikie added inline comments to D54526: [AST] Pack BinaryOperator.
Wed, Nov 14, 12:51 PM · Restricted Project
dblaikie accepted D54526: [AST] Pack BinaryOperator.

Looks good - thanks! just a few things that could be cleaned up.

Wed, Nov 14, 12:49 PM · Restricted Project
dblaikie added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Wed, Nov 14, 12:21 PM · Restricted Project
dblaikie added inline comments to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".
Wed, Nov 14, 11:55 AM · Restricted Project

Tue, Nov 13

dblaikie added inline comments to D54483: [ELF] .gdb_index: use lower_bound to compute relative CU index in an object file.
Tue, Nov 13, 11:25 PM
dblaikie committed rL346833: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.
Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`
Tue, Nov 13, 11:22 PM
dblaikie closed D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.
Tue, Nov 13, 11:22 PM
dblaikie accepted D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.

Looks good - thanks! Do you need me to commit this for you? (Or do you have commit rights & can commit it yourself)

Tue, Nov 13, 9:02 PM
dblaikie added inline comments to D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent.
Tue, Nov 13, 4:46 PM
dblaikie added a comment to D54497: [ELF] --gdb-index: extract entities from .debug_info when .debug_gnu_pubnames is absent.

Is this test case consistent with gold's behavior? (given this subprogram has no source locations here, for instance - does gold still consider such a simplified DIE to be a thing that should be indexed?)

Tue, Nov 13, 3:14 PM
dblaikie added inline comments to D54483: [ELF] .gdb_index: use lower_bound to compute relative CU index in an object file.
Tue, Nov 13, 1:35 PM
dblaikie added inline comments to D54384: [llvm-objcopy] Add --build-id-link-dir flag.
Tue, Nov 13, 12:23 PM
dblaikie added a comment to D54243: DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use..

Settled on renaming the flag for consistency with, say, -fdebug-types-section, to -fdebug-ranges-base-address (though 'debug' is sort of ambiguous (Clang can produce non-DWARF debug info) but this driver (as opposed to clang-cl) is intended for DWARF emission, not PDB emission - and the "debug-ranges" part of the flag names the literal debug_ranges section (like debug-types refers to the debug_types section)).

Tue, Nov 13, 12:15 PM
dblaikie added a comment to D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers.

Settled on renaming the DICompileUnit attribute from debugBaseAddress to rangesBaseAddress (since 'debug' is redundant, and this is really specific to ranges base address specifiers).

Tue, Nov 13, 12:14 PM
dblaikie committed rC346789: DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use..
DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use.
Tue, Nov 13, 12:11 PM
dblaikie committed rL346789: DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use..
DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use.
Tue, Nov 13, 12:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Nov 13, 12:11 PM
dblaikie committed rL346788: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address….
DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address…
Tue, Nov 13, 12:11 PM
dblaikie closed D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers.
Tue, Nov 13, 12:10 PM
dblaikie accepted D54480: [AsmPrinter] Rename a comment of .gdb_index entry.

Sounds good to me. Where possible it's great to quote the specs more than the source code - did you happen across any spec for gnu_pubnames themselves? Or only the gdb-index they're used to create (& that's good too - having consistency of naming between gnu_pubnames and gdb_index certainly helps)

Tue, Nov 13, 11:43 AM
dblaikie accepted D54481: [ELF] Rename NameTypeEntry and its field "Type".

Seems reasonable - the spec https://sourceware.org/gdb//onlinedocs/gdb/Index-Section-Format.html also describes these as "CU index+attributes" values.

Tue, Nov 13, 11:37 AM
dblaikie added inline comments to D54483: [ELF] .gdb_index: use lower_bound to compute relative CU index in an object file.
Tue, Nov 13, 11:35 AM
dblaikie added inline comments to D54361: [ELF] .gdb_index: fix CuOff when a .debug_info section contains more than 1 CU.
Tue, Nov 13, 10:11 AM
dblaikie added a comment to D54361: [ELF] .gdb_index: fix CuOff when a .debug_info section contains more than 1 CU.

(ah, I see I hadn't posted my first feedback earlier (written but unsubmitted) - oops, sorry about that)

Tue, Nov 13, 10:04 AM
dblaikie accepted D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..
Tue, Nov 13, 10:01 AM
dblaikie added a comment to D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)".

Hey @rjmccall - I'm trying to remember, but can't get it quite clear in my head. I seem to recall some discussion about trivial_abi not implying/being strong enough for all the cases that trivial_relocatable sounds like it covers? Do you happen to remember the distinction there (the summary in this patch ("the warranting attribute [[trivially_relocatable]], which is similar in spirit to [[trivial_abi]], in that it lets the programmer communicate back to the compiler that a certain user-defined type should be assumed to have this property even though it would not naturally have the property all else being equal.") doesn't sound like what I remember - but my memory is hazy)?

Tue, Nov 13, 8:30 AM · Restricted Project
dblaikie added a reviewer for D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)": rjmccall.
Tue, Nov 13, 8:27 AM · Restricted Project

Mon, Nov 12

dblaikie added a comment to D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3).

Could you fix the modulemap (might amount to reverting the change Eric made in r342827? or maybe it's more involved than that) & validate that the modules build is working with this change (probably undo Eric's change, validate that you see the breakage that Eric was trying to fix, then apply your change & see if it clears up as well)?

Mon, Nov 12, 3:41 PM
dblaikie added a comment to D54166: [AST] Store the string data in StringLiteral in a trailing array of chars.

@dblaikie Thanks for looking at this patch !

I have a set of patches shrinking the other statements/expressions.
Can I add you to review some of these too ? Most of them consists of just moving
some data. I added rsmith but I think that he is busy with the standard.

Mon, Nov 12, 3:39 PM · Restricted Project
dblaikie accepted D54420: Fix .cfi_restore with register numbers > 64.

Seems pretty reasonable to me!

Mon, Nov 12, 3:32 PM
dblaikie added inline comments to D54327: Adding debug info to support Fortran (part 3).
Mon, Nov 12, 3:27 PM · debug-info
dblaikie added a comment to D54043: Adding debug info to support Fortran (part 1).

Looks like this could use an LLVM CodeGen test too (similar to, or extending/renaming test/DebugInfo/Generic/mainsubprogram.ll)

Mon, Nov 12, 3:13 PM · debug-info
dblaikie accepted D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.

Ah, OK - so it's not so much a problem of the file being read containing interesting 64 bit values, but the way the host architecture works that exposes this bug. Makes sense - thanks for walking me through it!

Mon, Nov 12, 2:34 PM
dblaikie added inline comments to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..
Mon, Nov 12, 2:26 PM
dblaikie accepted D54446: Document how to comment an actual parameter.

Sounds good to me - I'd usually put spaces inside the start/end of the comment (& maybe between the comment & the constant) but that's just me - I'm not fussed about which way it's documented (although - best it's documented whatever way clang-format formats it, so as not to be confusing)

Mon, Nov 12, 2:11 PM
dblaikie added a comment to D54348: Permit multiple .file directives with -g.

Looks like the original functionality was added here in r109651 without any test case... so it's hard to say that because your change causes no regression that it's correct, because there's a lack of test coverage (no test tests for this message about "file number already allocated").

Mon, Nov 12, 11:45 AM · debug-info
dblaikie added a project to D54348: Permit multiple .file directives with -g: debug-info.
Mon, Nov 12, 11:37 AM · debug-info
dblaikie added a comment to D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.

Any chance of a test case?

I hope the following test case starts to pass on mips buildbot:
http://lab.llvm.org:8011/builders/llvm-mips-linux/builds/3739/steps/test-llvm/logs/FAIL%3A%20LLVM%3A%3Adebug_addr.ll

Mon, Nov 12, 11:34 AM
dblaikie added a comment to D54384: [llvm-objcopy] Add --build-id-link-dir flag.

cc'ing blaike as a local debug expert -- I'm not familiar with systems using --build-id

Mon, Nov 12, 11:30 AM
dblaikie added a comment to D54384: [llvm-objcopy] Add --build-id-link-dir flag.

@mcgrathr 's comments are probably more relevant than mine - especially those that, by the sounds of it, remove the need for adding a new iterator (but I only found that after I'd already written some of that - and figured the comments might be useful general feedback/'learnings' anyway :) )

Mon, Nov 12, 11:29 AM
dblaikie added a comment to D54336: [FileCheck] introduce CHECK-COUNT-<num> repetition directive.

FWIW, this looks really good to me. I'd be fine with this going in as-is and any further improvements suggested by David as follow-ups. Feel free to submit with comments addressed.

Mon, Nov 12, 11:02 AM
dblaikie added a comment to D54424: [DWARF] Do not use PRIx32 for printing uint64_t values.

Any chance of a test case?

Mon, Nov 12, 10:59 AM
dblaikie committed rL346691: NFC: DebugInfo: Reduce scope of DebugOffset to simplify code.
NFC: DebugInfo: Reduce scope of DebugOffset to simplify code
Mon, Nov 12, 10:56 AM
dblaikie added inline comments to D54166: [AST] Store the string data in StringLiteral in a trailing array of chars.
Mon, Nov 12, 9:16 AM · Restricted Project

Sun, Nov 11

dblaikie added a comment to D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.

(oh, also, looks like this is intended as a fix for PR39617? Good to mention that in reviews/commits - also, there's no need to file a bug before sending a patch. You can skip the bug & send the patch instead if you like!

Sun, Nov 11, 4:50 PM
dblaikie added a comment to D54377: Correctly instantiate `iterator_adaptor_base` when defining `pointer_iterator`.

Could you add a test case? (probably a static_assert in unittests/ADT/iterator.cpp or something like that)

Sun, Nov 11, 4:49 PM

Fri, Nov 9

dblaikie added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

OK - thanks for that.

Fri, Nov 9, 7:35 PM
dblaikie added a comment to D54361: [ELF] .gdb_index: fix CuOff when a .debug_info section contains more than 1 CU.

I think this would fail at least in the following example:

Fri, Nov 9, 7:28 PM
dblaikie added inline comments to D54336: [FileCheck] introduce CHECK-COUNT-<num> repetition directive.
Fri, Nov 9, 5:48 PM
dblaikie accepted D54350: [DWARFv5] Emit split type units in .debug_info.dwo.

Looks good to me! Seems to come out naturally/unsurprisingly/unlikely to be weird by DwarfFile::emitUnit - whether it's TUs, CUs, in different sections, the same section, interleaved or separate.

Fri, Nov 9, 5:47 PM · debug-info
dblaikie accepted D54282: [DWARFv5] Emit normal type units in .debug_info comdats..

Looks great!

Fri, Nov 9, 10:57 AM · debug-info
dblaikie added inline comments to D54282: [DWARFv5] Emit normal type units in .debug_info comdats..
Fri, Nov 9, 10:38 AM · debug-info

Thu, Nov 8

dblaikie added a comment to D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics".
In D54217#1292323, @vsk wrote:

Why not check in a .o? The numbers won't change, so they can meaningfully be compared.

An object file or assembly seems fine, yeah.

Thu, Nov 8, 5:15 PM
dblaikie added a comment to D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics".
In D54217#1292323, @vsk wrote:

Why not check in a .o? The numbers won't change, so they can meaningfully be compared.

Thu, Nov 8, 5:12 PM
dblaikie added a comment to D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics".

yeah, an easy code search indeed kicked up the tests. I will add one. Sorry about that

No worries - still curious where you were looking for the tests initially, perhaps we can do something to make them more discoverable?

The only thing I could think of that could make it easier is to make a symlink from the tools/llvm-dwarfdump/test which points to ../../test/tools/llvm-dwarfdump

Ah, fair enough - yeah, might just be a hurdle we can live with, then. The tests mostly match the directory hierarchy - but yeah, there are a few quirks.

(another way I find tests: Break something nearby/related (eg: remove one of the existing statistics) & see what tests fail)

Looks like I can piggy back on llvm/test/tools/llvm-dwarfdump/X86/statistics.ll

Does anyone know how to run only this test from command line?

from the build directory I usually run "./bin/llvm-lit -v test/tools/llvm-dwarfdump/X86/statistics.ll" for example (yeah, even though that relative path doesn't exist in the build directory, lit knows to also try resolving it from the source dir, etc)

Thanks! Will be an easy tests to add. One other FileCheck question. Seems like I would want to check that "total function size" and "total inlined function size" exist.
Can I rely on the exact byte sizes from this .ll file on all systems?

Only if the test has a specific triple. Which, by the looks of it, this test could benefit from. @aprantl - would that make sense? This test is only run when the X86 target is enabled anyway, so adding a specific triple wouldn't make it less portable - and would allow for specific statistic values to be tested, which seems like it'd be important for test coverage here (as it stands, byte count parts of this test look like it would still pass even if the statistics were miscomputed/all zero, etc).

Thu, Nov 8, 4:54 PM
dblaikie added inline comments to D54282: [DWARFv5] Emit normal type units in .debug_info comdats..
Thu, Nov 8, 4:28 PM · debug-info
dblaikie committed rC346439: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch….
[Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch…
Thu, Nov 8, 12:50 PM
dblaikie committed rL346439: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch….
[Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch…
Thu, Nov 8, 12:50 PM
dblaikie closed D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too.
Thu, Nov 8, 12:49 PM · Restricted Project
dblaikie added a comment to D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers.

Is this going to be used for anything other than ranges? If not I'd slightly prefer rangesBaseAddress over debugBaseAddress.

Thu, Nov 8, 12:39 PM
dblaikie added a comment to D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics".

yeah, an easy code search indeed kicked up the tests. I will add one. Sorry about that

No worries - still curious where you were looking for the tests initially, perhaps we can do something to make them more discoverable?

The only thing I could think of that could make it easier is to make a symlink from the tools/llvm-dwarfdump/test which points to ../../test/tools/llvm-dwarfdump

Thu, Nov 8, 10:36 AM
dblaikie added a comment to D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics".

yeah, an easy code search indeed kicked up the tests. I will add one. Sorry about that

Thu, Nov 8, 10:18 AM
dblaikie added a comment to D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics".
In D54217#1291170, @vsk wrote:

Looks reasonable to me, but it'd help to check in a .o for a test.

There don't seem to be any tests for any of this. Are there existing tests for stuff that is only in llvm-dwarfdump? If so, please point me to where they are.

Thu, Nov 8, 9:39 AM

Wed, Nov 7

dblaikie added inline comments to D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers.
Wed, Nov 7, 5:25 PM
dblaikie updated the diff for D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers.

Remove unnecessary attributes and add test input description

Wed, Nov 7, 5:24 PM
dblaikie created D54243: DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use..
Wed, Nov 7, 5:11 PM
dblaikie created D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers.
Wed, Nov 7, 5:06 PM
dblaikie committed rL346380: NFC: DebugInfo: Track the origin CU rather than just the base address for range….
NFC: DebugInfo: Track the origin CU rather than just the base address for range…
Wed, Nov 7, 4:38 PM
dblaikie accepted D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too.

While I'm not 100% sure about the actual fix - I'm confident enough that @rsmith can provide any further clarification in post-commit.

Wed, Nov 7, 1:49 PM · Restricted Project
dblaikie added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Thanks! - though on reflection I'm going to invoke @echristo again about the naming. It's unfortunately a bit backwards that the pre-standard flag is -gsplit-dwarf and what we're proposing as the standard flag is -fdwarf-fission, when the DWARF standard doesn't use the word "Fission" at all (only "split DWARF").

Wed, Nov 7, 7:54 AM

Tue, Nov 6

dblaikie added a comment to D53329: Generate DIFile with main program if source is not available.

Sure. Let me provide a little bit more context and what I want to achieve:

. I have a tool, called bcc (https://github.com/iovisor/bcc) which uses clang CompilerInvocation interface and
  MCJIT to generates BPF code and load into kernel
. Several files (the main.c and a few others headers) are clang memory mapped.
. The particular fix here is related to https://reviews.llvm.org/D53261, getting source code into BTF, but
  before that, based on that particular implementation, the source code needs to be in IR.
  What I found is that for the memory mapped /virtual/main.c file, there is one DIFile entry in
  generated IR, the associated 'source' is empty, which actually caused a seg fault later.
 
  Not that this bug itself does not need https://reviews.llvm.org/D53261.

So without this fix, bcc tool will seg fault.
With this fix, bcc tool works properly and all DIFile entry has proper source codes embedded, which
if coupled with IR->BTF or Dwarf->BTF should generate correct BTF debug info.

Tue, Nov 6, 1:05 PM · debug-info
dblaikie updated subscribers of D53354: [WIP][NOT FOR COMMIT][PROTOTYPE] clang-scan-deps: dependency scanning tool rough prototype.
Tue, Nov 6, 10:12 AM
dblaikie added a comment to D53907: [DWARFv5] Read and dump multiple .debug_info sections.

Generally looks good to me - I'll leave it to you & Adrian to hash out any concerns he has.

Tue, Nov 6, 9:47 AM · debug-info

Mon, Nov 5

dblaikie added a comment to D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too.

@dblaikie I have created a test, but unfortunately %clang_cpp in LIT invokes clang --driver-mode=cpp which is not the same as if clang++ is called. I'm trying to construct the following command-line

clang++ -fmodules-ts -fprebuilt-module-path=%t/mods --precompile -c file.cppm -o file.pcm

However, using %clang_cc1 I can't get it to accept --precompile as a valid argument, and using %clang_cpp I get an "unused argument" warning for --precompile and the output file is just a preprocessed output (like -E), which will, of course, cause errors, but not the errors I am wanting to test about.

Mon, Nov 5, 4:39 PM · Restricted Project

Fri, Nov 2

dblaikie updated subscribers of D46061: [DEBUGINFO, NVPTX] Disable emission of ',debug' option if only debug directives are allowed..

Looks like Eric still had some questions here? Or at least hadn't commented
about whether the answers/changes addressed his concerns?

Fri, Nov 2, 7:52 AM