Page MenuHomePhabricator

asb (Alex Bradbury)
RISC-V, WebAssembly

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2013, 5:31 AM (459 w, 3 d)

Recent Activity

Today

asb added inline comments to D126535: [WebAssembly][NFC] Update reftype and table tests to use opaque pointers.
Fri, May 27, 7:44 AM · Restricted Project, Restricted Project
asb added inline comments to D126535: [WebAssembly][NFC] Update reftype and table tests to use opaque pointers.
Fri, May 27, 7:23 AM · Restricted Project, Restricted Project
asb requested review of D126535: [WebAssembly][NFC] Update reftype and table tests to use opaque pointers.
Fri, May 27, 6:17 AM · Restricted Project, Restricted Project

Yesterday

asb accepted D126085: [RISCV] Add a subtarget feature to enable unaligned scalar loads and stores.

Address test check comment.

Anything remaining blocking this? I know I need to file the psABI issue and will do so before pushing. Asking about further review items.

Thu, May 26, 10:17 AM · Restricted Project, Restricted Project
asb added a comment to D126085: [RISCV] Add a subtarget feature to enable unaligned scalar loads and stores.

As just discussed in the sync-up call meeting, let's defer the question of setting / not setting the attribute to an upstream discussion in riscv-elf-psabi-doc on the precise semantics of the tag. Philip kindly volunteered to kick off an issue in that repo.

Thu, May 26, 8:57 AM · Restricted Project, Restricted Project
asb added a comment to D126085: [RISCV] Add a subtarget feature to enable unaligned scalar loads and stores.

This is all that's needed to hook up the appropriate attribute:

diff --git a/llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.cpp b/llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.cpp
index 5f9ed77d07cf..ac0c8113135a 100644
--- a/llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.cpp
+++ b/llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.cpp
@@ -50,6 +50,9 @@ void RISCVTargetStreamer::emitTargetAttributes(const MCSubtargetInfo &STI) {
   else
     emitAttribute(RISCVAttrs::STACK_ALIGN, RISCVAttrs::ALIGN_16);
Thu, May 26, 6:05 AM · Restricted Project, Restricted Project

Wed, May 25

asb added a comment to D126085: [RISCV] Add a subtarget feature to enable unaligned scalar loads and stores.

I don't think it affects this patch (as splitting scalar vs vector features for alignment makes sense regardless of the frontend option), but I had a quick look at the frontend option for this. Looks like on the GCC side it's -mno-strict-align. On Arm/AArch64 it's spelled -munaligned-access and __ARM_FEATURE_UNALIGNED is set. Unless there's some target generic #define that's set that I'm missing, it feels like it would be useful to set a define for the RISC-V case as well (and agree this with the GNU folks).

I agree this is separate. What a target defaults to should not be blocked on what a frontend might chose to override. I'll note that these flags don't appear to influence x86 handling of the corresponding cases, so unless this is handled somewhere generically I missed, this isn't RISCV specific in any way.

Wed, May 25, 1:45 PM · Restricted Project, Restricted Project
asb added a comment to D126085: [RISCV] Add a subtarget feature to enable unaligned scalar loads and stores.

I don't think it affects this patch (as splitting scalar vs vector features for alignment makes sense regardless of the frontend option), but I had a quick look at the frontend option for this. Looks like on the GCC side it's -mno-strict-align. On Arm/AArch64 it's spelled -munaligned-access and __ARM_FEATURE_UNALIGNED is set. Unless there's some target generic #define that's set that I'm missing, it feels like it would be useful to set a define for the RISC-V case as well (and agree this with the GNU folks).

Wed, May 25, 12:49 PM · Restricted Project, Restricted Project
asb added inline comments to D126085: [RISCV] Add a subtarget feature to enable unaligned scalar loads and stores.
Wed, May 25, 7:31 AM · Restricted Project, Restricted Project
asb accepted D126185: [RISCV]Remove solved TODO for combining constant shifts.

LGTM, thanks.

Wed, May 25, 7:20 AM · Restricted Project, Restricted Project

Sat, May 21

asb added a comment to D126079: [NFC][LLVM] Merge shouldExpandAtomic*InIR into shouldExpandAtomicInstInIR.

I did have one patch locally that only keeps the function shouldExpandAtomicInstInIR(Instruction *) and in the body it has something like if (auto *SI = dyn_cast<StoreInst>(I)). In terms of readability, IMO it is same as overload. However, of course it can reduce number of APIs. I can use that method, but it looks like the controversy here is readability.

Without seeing the result of that refactoring I can't say for sure, but I can imagine that could be an improvement over the status quo.

Sat, May 21, 5:58 AM · Restricted Project, Restricted Project

Thu, May 19

asb committed rG2f8c067bef34: [WebAssembly][NFC] Fix errant tabs in test case in last commit (authored by asb).
[WebAssembly][NFC] Fix errant tabs in test case in last commit
Thu, May 19, 2:10 AM · Restricted Project, Restricted Project
asb committed rG4e8b2ac7c019: [WebAssembly] Fix bug where -no-type-check failed to completely disable the… (authored by asb).
[WebAssembly] Fix bug where -no-type-check failed to completely disable the…
Thu, May 19, 2:08 AM · Restricted Project, Restricted Project

Tue, May 17

asb added a comment to D125729: [WebAssembly] Update supported features in the generic CPU configuration.

Thanks, I think CodeGen/WebAssembly/target-features.ll could be updated to add a -mcpu=generic test?

Tue, May 17, 8:32 AM · Restricted Project, Restricted Project
asb added a comment to D125728: [WebAssembly] Update supported features in -mcpu=generic.

Oh, and per recent updates to the LLVM Developer policy I think it would be worth updating the Clang ReleaseNotes.rst to mention this change.

Tue, May 17, 8:30 AM · Restricted Project, Restricted Project
asb added a comment to D125728: [WebAssembly] Update supported features in -mcpu=generic.

Based on the discussion we had, I think this makes sense. It's a bit repetitive, but could you please add a test to clang/test/Driver that checks the list of enabled features for generic (and for completeness, probably bleeding-edge as well). Thanks.

Tue, May 17, 8:28 AM · Restricted Project, Restricted Project
asb added a comment to D92105: [RISCV] Add pre-emit pass to make more instructions compressible.

At the last sync-up call, @reames I believe said he had no further blocking comments (thanks for the review on this Philip). I think we're good to land this Lewis if you're happy with the current code.

Tue, May 17, 8:04 AM · Restricted Project, Restricted Project
asb added a comment to D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t.

Thanks for the patch - can you add test coverage for this please?

Tue, May 17, 8:01 AM · Restricted Project, Restricted Project
asb updated the diff for D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Add a isWebAssemblyTable helper and refactor to use it.

Tue, May 17, 6:51 AM · Restricted Project
asb committed rG8a23df89dadd: [WebAssembly][NFC] Convert IsWasm64 instruction field to 'bit' from string (authored by asb).
[WebAssembly][NFC] Convert IsWasm64 instruction field to 'bit' from string
Tue, May 17, 3:07 AM · Restricted Project, Restricted Project
asb closed D125714: [WebAssembly][NFC] Convert IsWasm64 instruction field to 'bit' from string.
Tue, May 17, 3:07 AM · Restricted Project, Restricted Project
asb committed rG601ed0b60531: [WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string (authored by asb).
[WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string
Tue, May 17, 3:06 AM · Restricted Project, Restricted Project
asb closed D125713: [WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string.
Tue, May 17, 3:06 AM · Restricted Project, Restricted Project
asb added a comment to D125713: [WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string.

The 'true' and 'false' literals are available.

https://llvm.org/docs/TableGen/ProgRef.html#simple-values

@Paul-C-Anagnostopoulos indeed, but they're not usable in KeyCol/ValueCols without some further changes to TableGen Element type mismatch for list: element type 'int' not convertible to 'string

Tue, May 17, 3:00 AM · Restricted Project, Restricted Project

Mon, May 16

asb added a comment to D125713: [WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string.

The 'true' and 'false' literals are available.

https://llvm.org/docs/TableGen/ProgRef.html#simple-values

Mon, May 16, 8:11 PM · Restricted Project, Restricted Project
asb updated the summary of D125714: [WebAssembly][NFC] Convert IsWasm64 instruction field to 'bit' from string.
Mon, May 16, 11:28 AM · Restricted Project, Restricted Project
asb added a reviewer for D125714: [WebAssembly][NFC] Convert IsWasm64 instruction field to 'bit' from string: pmatos.
Mon, May 16, 11:25 AM · Restricted Project, Restricted Project
asb added a reviewer for D125713: [WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string: pmatos.
Mon, May 16, 11:24 AM · Restricted Project, Restricted Project
asb requested review of D125714: [WebAssembly][NFC] Convert IsWasm64 instruction field to 'bit' from string.
Mon, May 16, 11:19 AM · Restricted Project, Restricted Project
asb requested review of D125713: [WebAssembly][NFC] Convert StackBased instruction field to 'bit' from string.
Mon, May 16, 11:17 AM · Restricted Project, Restricted Project
asb committed rG92030635318d: [WebAssembly][TableGen][NFCI] Use getValueAsBit rather than converting TableGen… (authored by asb).
[WebAssembly][TableGen][NFCI] Use getValueAsBit rather than converting TableGen…
Mon, May 16, 10:50 AM · Restricted Project, Restricted Project
asb added a comment to D125514: [WebAssembly] Use CHECK-NEXT for irreducible-cfg.mir.

The script doesn't generate CHECK lines next to each BB but rather generates the whole function together, making it harder to see changes in each BB for me. Also there are comments for CHECK lines, which will be lost if we use the script. So I'm not sure using it will improve readability in this case.

Mon, May 16, 8:30 AM · Restricted Project, Restricted Project
asb updated the diff for D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Added semantic restrictions for C++ specific constructs.

Mon, May 16, 8:15 AM · Restricted Project
asb updated the summary of D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.
Mon, May 16, 8:13 AM · Restricted Project
asb updated the diff for D124162: [clang][Webassembly] Implement builtins for tables.

Rebase and fix missing CHECK lines for table copy.

Mon, May 16, 8:09 AM · Restricted Project

Fri, May 13

asb added a comment to D125514: [WebAssembly] Use CHECK-NEXT for irreducible-cfg.mir.

This change looks fine to me, but have you considered just moving this test over to using update_mir_test_checks.py? It's ever so slightly more verbose, but in my experience reviewing changes that change test output are so much easier as you can just see the git diff of old vs new.

Fri, May 13, 12:34 AM · Restricted Project, Restricted Project

Thu, May 12

asb committed rGcb778e932829: [WebAssembly] Implement ref.is_null MC layer support and codegen (authored by asb).
[WebAssembly] Implement ref.is_null MC layer support and codegen
Thu, May 12, 11:09 PM · Restricted Project, Restricted Project
asb closed D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
Thu, May 12, 11:08 PM · Restricted Project, Restricted Project
asb added a comment to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.

Thanks! I have one more question but don't want to hold this back with nitpicky things. (The review turnaround time due to time zone doesn't help either)

Thu, May 12, 10:58 PM · Restricted Project, Restricted Project
asb added inline comments to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
Thu, May 12, 10:20 PM · Restricted Project, Restricted Project
asb added a comment to D123394: [CodeGen] Late cleanup of redundant address/immediate definitions..

The RISC-V changes for this look good to me.

Thu, May 12, 1:25 AM · Restricted Project, Restricted Project
asb added a comment to D124728: Allow pointer types for atomicrmw xchg.

One thing that's not immediately clear to me is what the the appropriate handling of pointers with a non-default address space should be? I think specifically, atomicrmw of non-integral pointer types may have to be disallowed?

I don't see a particular problem here? I mean, an atomic xchg is perfectly sensible for non-integral pointers; semantically, it doesn't even require examining the pointer bits. I guess it's possible some targets can't implement an atomic pointer xchg, but it's not like we're forcing frontends to use it...

Thu, May 12, 12:47 AM · Restricted Project, Restricted Project
asb requested changes to D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s .

Thanks for working to improve our test coverage! In this particular case, I think it would be better handled by adding an RV64 RUN line to rv32zfhmin-invalid.s (given the contents of the file is identical).

Thu, May 12, 12:33 AM · Restricted Project, Restricted Project

Wed, May 11

asb added a comment to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.

Update based on review comments.

Wed, May 11, 10:58 PM · Restricted Project, Restricted Project
asb updated the diff for D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
Wed, May 11, 10:57 PM · Restricted Project, Restricted Project
asb accepted D124109: [RISCV] Add a DAG combine to pre-promote (i32 (and (srl X, Y), 1)) with Zbs on RV64..

LGTM. Thanks Craig!

Wed, May 11, 7:29 AM · Restricted Project, Restricted Project
asb added a comment to D124728: Allow pointer types for atomicrmw xchg.

One thing that's not immediately clear to me is what the the appropriate handling of pointers with a non-default address space should be? I think specifically, atomicrmw of non-integral pointer types may have to be disallowed?

Wed, May 11, 7:19 AM · Restricted Project, Restricted Project
asb accepted D124639: [RISCV] Override TargetLowering::shouldProduceAndByConstByHoistingConstFromShiftsLHSOfAnd..

LGTM, thanks.

Wed, May 11, 6:28 AM · Restricted Project, Restricted Project
asb added a comment to D125354: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.

Would it be better to change the common CHECK to RV32 in rv32 tests, and RV64 in rv64 tests ?

Wed, May 11, 6:16 AM · Restricted Project, Restricted Project
asb accepted D125354: [RISCV][NFC] Reorganize check prefixes in some tests to reduce redundant lines.

LGTM, thanks for the cleanup. I though update_llc_test_checks struggled with these combinations but it seems not (or at least, not any more).

Wed, May 11, 6:13 AM · Restricted Project, Restricted Project
asb accepted D124693: [RISCV] Fold addiw from (add X, (addiw (lui C1, C2))) into load/store address.

Nice improvement - thanks. Might be worth adding an explicit test case for where an lui+addiw is generated but the addiw can't be converted to an addi.

Wed, May 11, 5:35 AM · Restricted Project, Restricted Project
asb accepted D125344: [RISCV] Move implementation of getVLOpNum and getSEWOpNum from RISCVInsertVSETVLI to RISCVBaseInfo.h. NFC.

This refactoring looks like a good move to me.

Wed, May 11, 5:31 AM · Restricted Project, Restricted Project
asb accepted D125289: [RISCV] Remove some TODOs in tests.

LGTM - thanks for working through to remove these redundant comments (and fixing the missing fld/fsd/flw/fsw alias tests).

Wed, May 11, 5:30 AM · Restricted Project, Restricted Project
asb added a comment to D91719: [RISCV] Add support for using -msave-restore with tailcalls.

The documentation changes to the riscv-toolchain-conventions repository have been merged now, (https://github.com/riscv-non-isa/riscv-toolchain-conventions/pull/10). In addition, there's a pending patch to implement this in GCC (https://gcc.gnu.org/pipermail/gcc-patches/2022-March/592467.html). I think this means there's nothing blocking this except a rebase.

Wed, May 11, 5:26 AM · Restricted Project, Restricted Project
asb added inline comments to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
Wed, May 11, 12:57 AM · Restricted Project, Restricted Project
asb updated the diff for D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.

Address review comments:

  • Move to using update_llc_test_checks.py for ref-null.ll (and therefore fix missing CHECK lines)
  • Add tighter error checking for ref.is_null in the wasm type checker
Wed, May 11, 12:56 AM · Restricted Project, Restricted Project

Tue, May 10

asb retitled D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen from [WebAssembly] Implement ref.is_null intrinstic to [WebAssembly] Implement ref.is_null MC layer support and codegen.
Tue, May 10, 5:23 AM · Restricted Project, Restricted Project
asb added a comment to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.

Commandeered, completed implementation, and updated summary to explain current implementation approach.

Tue, May 10, 5:22 AM · Restricted Project, Restricted Project
asb updated the diff for D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
Tue, May 10, 5:21 AM · Restricted Project, Restricted Project
asb commandeered D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
Tue, May 10, 5:16 AM · Restricted Project, Restricted Project

Apr 26 2022

asb accepted D124428: [RISCV] Add RV64Zbs invalid tests.
Apr 26 2022, 8:29 AM · Restricted Project, Restricted Project
asb added a comment to D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Sounds like you need an RFC thread on the forums describing the underlying WebAssembly feature and your proposed language design for exposing it in C.

Apr 26 2022, 8:05 AM · Restricted Project

Apr 25 2022

asb updated the diff for D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Rebase, and fix+test missed error case (taking the address of table).

Apr 25 2022, 3:59 AM · Restricted Project
asb updated the summary of D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.
Apr 25 2022, 3:00 AM · Restricted Project

Apr 22 2022

asb updated the diff for D124162: [clang][Webassembly] Implement builtins for tables.

Rebase.

Apr 22 2022, 7:28 AM · Restricted Project
asb updated the diff for D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Re-add full context.

Apr 22 2022, 7:28 AM · Restricted Project
asb added inline comments to D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.
Apr 22 2022, 7:20 AM · Restricted Project
asb updated the diff for D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Update to address review comments.

Apr 22 2022, 7:20 AM · Restricted Project

Apr 21 2022

asb added inline comments to D124179: [RISCV][NFC] Remove unused text in the test..
Apr 21 2022, 10:52 AM · Restricted Project, Restricted Project
asb added inline comments to D124162: [clang][Webassembly] Implement builtins for tables.
Apr 21 2022, 10:51 AM · Restricted Project
asb requested review of D124162: [clang][Webassembly] Implement builtins for tables.
Apr 21 2022, 5:45 AM · Restricted Project
asb updated the diff for D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Update to latest version and update summary. As I say there, it would be really helpful to get some feedback at this point.

Apr 21 2022, 5:39 AM · Restricted Project

Apr 20 2022

asb committed rGbea5e88bcf59: [clang][Sema] Fix typo in checkBuiltinArgument helper (authored by asb).
[clang][Sema] Fix typo in checkBuiltinArgument helper
Apr 20 2022, 6:43 AM · Restricted Project, Restricted Project

Apr 14 2022

asb added a comment to D92105: [RISCV] Add pre-emit pass to make more instructions compressible.

@craigblackmore: could you please take a look at compiling complex-2.c from the GCC torture suite with this patch. I'm getting incorrect output for RV32IMAFDC at Oz:

./output_rv32imafdc_ilp32_Oz/complex-2.s:16:7: error: invalid operand for instruction
        addi    fa0, ft0, 0
                ^
./output_rv32imafdc_ilp32_Oz/complex-2.s:18:7: error: invalid operand for instruction
        addi    fa1, ft1, 0
                ^
Apr 14 2022, 5:11 AM · Restricted Project, Restricted Project
asb updated the diff for D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.

Addresses some potential null pointer dereferences.

Apr 14 2022, 2:14 AM · Restricted Project
asb added a comment to D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified.

@MaskRay: Are you happy all your comments are addressed?

Apr 14 2022, 1:37 AM · Restricted Project, Restricted Project
asb added a comment to D122918: [RISCV][CodeGen] Support Zfinx codegen.

@hughperkins: You make good points. It's not immediately obvious what kind of splitting would be better, and at what point the added complexity of trying to have piggy-back zfinx on current F/D patterns hampers readability and maintainability rather than enhance it. If you have time to play around with some options, I'd be really interested in hearing what you come up with.

Apr 14 2022, 1:17 AM · Restricted Project, Restricted Project

Apr 13 2022

asb added inline comments to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.
Apr 13 2022, 8:58 AM · Restricted Project, Restricted Project
asb added a comment to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Sorry for the delay, it took me some time to run clang-format. I also added the context as asked. Finally, I added an assert to make sure STACKMAP, PATCHPOINT and STATEPOINT are only used with RV64.

Apr 13 2022, 8:33 AM · Restricted Project, Restricted Project
asb added a comment to D122918: [RISCV][CodeGen] Support Zfinx codegen.

As a general comment, after thinking about this whilst brushing my teeth, I kind of feel that it might be clearer and simpler for everyone, both F people and Zfinx people, if we decoupled F and Zfinx into two separate files. This way F people don't have to figure out what is Zfinx. They just keep their clean separate F file. and Zfinx people dont have to think about how our bits mangle with F bits. Yes involves a bit of duplication, but if it's clearer/cleaner for everyone, maybe it might be a good approach?

After all, Zfinx is not an extension of F. It's a separate, mutually incompatible extension. And it's a fairly niche extension, I feel.

Apr 13 2022, 8:23 AM · Restricted Project, Restricted Project
asb accepted D123675: [RISCV][NFC] Use addExpr() instead of createExpr().

LGTM, thanks.

Apr 13 2022, 8:13 AM · Restricted Project, Restricted Project

Apr 11 2022

asb added inline comments to D123181: [RISCV] [NFC] Refactor the type promotion of fsl/fsr/becompress/bdecompress/bfp.
Apr 11 2022, 8:27 AM · Restricted Project, Restricted Project
asb added inline comments to D123181: [RISCV] [NFC] Refactor the type promotion of fsl/fsr/becompress/bdecompress/bfp.
Apr 11 2022, 8:22 AM · Restricted Project, Restricted Project
asb added inline comments to D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 11 2022, 8:09 AM · Restricted Project, Restricted Project
asb added a comment to D123515: [RISCV] Support '.option arch' directive.

Thanks for the patch! One quick suggestion from a rapid scan is that it would be good to have test coverage for illegal extension combinations (including for .option arch removing an extension that is a dependency of another enaabled extension).

Apr 11 2022, 8:02 AM · Restricted Project, Restricted Project
asb added a comment to D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets.

Thanks for the contribution! I'm not very familiar with the stackmap/patchpoint/statepoint infrastructure so it may take a bit of time to review this (if anyone else on the CC list has looked at it before, please do dive in!).

Apr 11 2022, 7:56 AM · Restricted Project, Restricted Project
asb updated the summary of D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.
Apr 11 2022, 6:42 AM · Restricted Project
asb requested review of D123510: [clang][WebAssembly] Implement support for table types and appropriate semantic restrictions.
Apr 11 2022, 6:40 AM · Restricted Project

Apr 7 2022

asb accepted D122236: [RISCV] Fix crash for initial section alignment with .option norvc.

This LGTM - thanks!

Apr 7 2022, 2:49 AM · Restricted Project, Restricted Project

Mar 23 2022

asb committed rG61d5fa6b62bb: [WebAssembly] Fix error location for parsed symbol/label operands (authored by asb).
[WebAssembly] Fix error location for parsed symbol/label operands
Mar 23 2022, 1:53 AM · Restricted Project
asb closed D122128: [WebAssembly] Fix error location for parsed symbol/label operands.
Mar 23 2022, 1:53 AM · Restricted Project, Restricted Project
asb committed rG012637514ceb: [WebAssembly] Use location of operand for operand-based type check errors (authored by asb).
[WebAssembly] Use location of operand for operand-based type check errors
Mar 23 2022, 1:52 AM · Restricted Project
asb closed D122127: [WebAssembly] Use location of operand for operand-based type check errors.
Mar 23 2022, 1:52 AM · Restricted Project, Restricted Project

Mar 22 2022

asb committed rGef9cf86eb0de: [WebAssembly][NFC] Delete type checking logic for removed ref.null instruction (authored by asb).
[WebAssembly][NFC] Delete type checking logic for removed ref.null instruction
Mar 22 2022, 9:24 AM · Restricted Project
asb closed D122123: [WebAssembly][NFC] Delete type checking logic for removed ref.null instruction.
Mar 22 2022, 9:24 AM · Restricted Project, Restricted Project
asb committed rG9001168cf8b8: [WebAssembly] Add tests for the Asm type checker (authored by asb).
[WebAssembly] Add tests for the Asm type checker
Mar 22 2022, 9:22 AM · Restricted Project
asb closed D122020: [WebAssembly] Add tests for the Asm type checker.
Mar 22 2022, 9:22 AM · Restricted Project, Restricted Project
asb added inline comments to D122020: [WebAssembly] Add tests for the Asm type checker.
Mar 22 2022, 8:59 AM · Restricted Project, Restricted Project
asb added inline comments to D122215: [WebAssembly] Initial support for reference types in clang.
Mar 22 2022, 3:41 AM · Restricted Project, Restricted Project, Restricted Project
asb committed rG86cc731f4c50: [WebAssembly] Always emit functype directives for defined functions (authored by asb).
[WebAssembly] Always emit functype directives for defined functions
Mar 22 2022, 2:25 AM · Restricted Project