Page MenuHomePhabricator

asb (Alex Bradbury)
Director and Co-founder, lowRISC CIC

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2013, 5:31 AM (319 w, 5 d)

Recent Activity

Tue, Sep 17

asb added a comment to D67423: [RISCV] Rename FPRs and use Register arithmetic.

I'm still personally not fond of the Fx_F/Fx_D convention. The fact that F0_F < F1_F < F0_D < F1_D is highly surprising, especially when F0_32 < F0_64 < F1_32 < F1_64, and not what one would naively assume. I also don't know whether this peculiarity of TableGen is meant to be something that's relied upon. I know it doesn't match the ISA convention of always calling them Fx, but Fx and Dx have precedence in other backends and do not risk this same confusion. Moreover, the spec itself is highly inconsistent in how to refer to single and double precision floating point:

Tue, Sep 17, 5:37 AM · Restricted Project

Wed, Sep 11

asb committed rL371632: Request commit access for asb.
Request commit access for asb
Wed, Sep 11, 8:50 AM

Tue, Sep 10

asb accepted D65950: [RISCV] Add Option for Printing Architectural Register Names.

LGTM, thanks!

Tue, Sep 10, 8:38 AM · Restricted Project

Thu, Aug 29

asb added a comment to D66887: [test-suite][WIP] Add GCC C Torture Suite as External Test Suite.

Thanks for pushing this forwards Sam. For the RISC-V backend we've been using a downstream shell script for this for ages, and I've always felt it would be better if the torture suite could be used from the LLVM test suite. It's been a while since I went over the excluded tests, it's possible it would benefit from further review if all the masked tests really should be masked.

Thu, Aug 29, 3:38 AM · Restricted Project

Tue, Aug 27

asb accepted D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics.

LGTM, thanks!

Tue, Aug 27, 8:33 AM · Restricted Project, Restricted Project
asb added a comment to D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics.

This LGTM, but given how much discussion there has been about MaxPromoteWidth it would be great to get some test coverage for it.

Tue, Aug 27, 6:23 AM · Restricted Project, Restricted Project
asb accepted D66752: [RISCV] Implement RISCVRegisterInfo::getPointerRegClass.

This triggers when building the Linux kernel too. I forgot to submit this patch after getting that working. I also couldn't get a meaningful test case for it that didn't seem like it would be horribly brittle. LGTM, thanks.

Tue, Aug 27, 6:23 AM · Restricted Project

Aug 20 2019

asb committed rG7cb3cd34e8d7: [RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the… (authored by asb).
[RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the…
Aug 20 2019, 5:34 AM
asb committed rL369375: [RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the….
[RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the…
Aug 20 2019, 5:31 AM
asb closed D66419: [RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the FDE location.
Aug 20 2019, 5:31 AM · Restricted Project
asb added inline comments to D66419: [RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the FDE location.
Aug 20 2019, 5:30 AM · Restricted Project

Aug 19 2019

asb updated the diff for D66419: [RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the FDE location.
Aug 19 2019, 8:12 AM · Restricted Project
asb created D66419: [RISCV] Implement getExprForFDESymbol to ensure RISCV_32_PCREL is used for the FDE location.
Aug 19 2019, 8:04 AM · Restricted Project
asb resigned from D63409: [RISCV] Specify various encodings for DWARF exception handling.

Resigning as a reviewer, as the intent of this change is captured in rL366327.

Aug 19 2019, 6:26 AM · Restricted Project
asb committed rG1c1f8f215d89: [RISCV] Don't force absolute FK_Data_X fixups to relocs (authored by asb).
[RISCV] Don't force absolute FK_Data_X fixups to relocs
Aug 19 2019, 6:23 AM
asb committed rL369257: [RISCV] Don't force absolute FK_Data_X fixups to relocs.
[RISCV] Don't force absolute FK_Data_X fixups to relocs
Aug 19 2019, 6:23 AM
asb closed D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.
Aug 19 2019, 6:22 AM · Restricted Project
asb added inline comments to D62592: [RISCV] Add support for RVC HINT instructions.
Aug 19 2019, 5:59 AM · Restricted Project
asb accepted D62592: [RISCV] Add support for RVC HINT instructions.

Looks good to me, thanks! We may later review whether the ability to enable/disable these hints is worth it or not (I know I'd been in favour from the start, but looking at it with fresh eyes I'm not sure it's fully necessary), but this is a useful step forwards.

Aug 19 2019, 5:59 AM · Restricted Project
asb requested changes to D65950: [RISCV] Add Option for Printing Architectural Register Names.

Actually changing my mind. This would be better tested by adopting something like arch-reg-names.s from D66139 (and extending that to handle FP regs), and leaving the inline-asm tests alone (huge increase in test size, which makes them harder to follow). Make that change, and then it looks good to me.

Aug 19 2019, 5:35 AM · Restricted Project
asb accepted D66139: [RISCV] Support llvm-objdump -M no-aliases and -M numeric.

LGTM, but wouldn't it be worth moving arch-reg-names.s to D65950, and also expanding it to handle FP regs?

Aug 19 2019, 5:35 AM · Restricted Project
asb accepted D65950: [RISCV] Add Option for Printing Architectural Register Names.

LGTM, thanks!

Aug 19 2019, 5:30 AM · Restricted Project

Aug 9 2019

asb added a comment to D65959: [RISCV] Implement targetHandlesStackFrameRounding to prevent stack over-allocation.

This causes failures on the GCC torture suite:

Aug 9 2019, 3:20 AM · Restricted Project

Aug 8 2019

asb added inline comments to D65950: [RISCV] Add Option for Printing Architectural Register Names.
Aug 8 2019, 7:01 AM · Restricted Project
asb added a comment to D62007: [RISCV] Minimal stack realignment support.

Also, clang-format seems to prefer to format some of this patch differently - worth running it through again.

Aug 8 2019, 6:48 AM · Restricted Project
asb accepted D62007: [RISCV] Minimal stack realignment support.

Please to submit a follow-on patch for targetHandlesStackFrameRounding

Aug 8 2019, 4:13 AM · Restricted Project
asb added a comment to D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux.

Thanks @asb @lenary for the review!

I understand that, after this change, we will also want to make -march=rv{32,64}gc the default in Linux as well. Otherwise there will be an ABI mismatch with the default -march=rv{32.64}i in a default invocation.

Does this make sense?

Aug 8 2019, 4:07 AM · Restricted Project, Restricted Project

Aug 6 2019

asb requested changes to D65693: [driver][riscv] Support riscv64-linux-gnu multiarch paths.

Many thanks for the patch. Could you please add some tests for this behaviour? I imagine you'll want to add a new directory in test/Driver/Inputs with a Debian tree skeleton. See D63497 for a relevant example.

Aug 6 2019, 7:37 AM · Restricted Project, Restricted Project
asb added a comment to D62007: [RISCV] Minimal stack realignment support.

Address review feedback

  • implement targetHandlesStackFrameRounding to prevent stack being rounded twice.
Aug 6 2019, 7:31 AM · Restricted Project

Aug 1 2019

asb added a comment to D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux.

Thank Roger. While we're doing this, I think it would make sense to default to ilp32d on 32-bit Linux? I know the glibc support etc is less mature than for RV64, but it seems the sensible thing to do.

Aug 1 2019, 11:57 PM · Restricted Project, Restricted Project
asb accepted D57332: [RISCV] Allow parsing of bare symbols with offsets.

Adding explicit LGTM in the Phabrictor UI. Thanks again Lewis!

Aug 1 2019, 5:27 AM · Restricted Project
asb resigned from D65291: [RISCV] Add Custom Parser for Atomic Memory Operands.

Thanks for looking at an alternate approach here James. In light of the better error messages I'm going to go with D65205 at this point, but I'm open to future refactoring or improvements. I haven't spent a lot of time considering it, but my initial reaction on PushParens is I feel it might make the parsing logic harder to follow in return for a fairly minor reduction in repetition. But I could be convinced otherwise...

Aug 1 2019, 5:25 AM · Restricted Project
asb accepted D54296: [RISCV] Lower inline asm constraint A for RISC-V.

Looks good to me - thanks!

Aug 1 2019, 5:11 AM · Restricted Project
asb accepted D65205: [RISCV] Add Custom Parser for Atomic Memory Operands.

Added a nit around a doc comment, but this is looking good - thanks Sam. I agree that the error messages are nicer in this patch vs D65291 for now. However I'm very open to further improvements and refactoring of AsmParser logic in the future in follow-on patches. Only caveat to that is that the asm parser for any backend isn't particularly pretty, and that sometimes a little bit of repetition can be easier to read than an all-singing-all-dancing function that can do anything based on what function args you pass.

Aug 1 2019, 5:10 AM · Restricted Project

Jul 31 2019

asb accepted D65500: [RISCV] Support 'f' Inline Assembly Constraint.

LGTM, thanks!

Jul 31 2019, 2:41 AM · Restricted Project, Restricted Project
asb accepted D64751: [RISCV] Add support for lowering floating point inlineasm clobbers.

Getting sufficient LGTMs is a bit of a judgement call with LLVM. If the change is large and invasive, then typically you'd wait for the OK from the relevant code owner. For something like this, totally find for anyone active in that part of the codebase to approve.

Jul 31 2019, 12:52 AM · Restricted Project

Jul 26 2019

asb accepted D65347: [RISCV] Fix uninitialized variable after call to evaluateConstantImm.

This looks good to me, thanks! Upon review I considered whether evaluateConstantImm should always set VK, but it seems sensible to rely on the caller to initialise it if necessary, as setting VK when evaluateConstantImm failed seems surprising.

Jul 26 2019, 8:44 PM · Restricted Project

Jul 18 2019

asb committed rGe078967adf4f: [RISCV] Hard float ABI support (authored by asb).
[RISCV] Hard float ABI support
Jul 18 2019, 11:37 AM
asb committed rL366480: [RISCV] Hard float ABI support.
[RISCV] Hard float ABI support
Jul 18 2019, 11:33 AM
asb committed rG9b732fe99b69: Revert "[RISCV] Hard float ABI support" r366450 (authored by asb).
Revert "[RISCV] Hard float ABI support" r366450
Jul 18 2019, 9:14 AM
asb committed rL366454: Revert "[RISCV] Hard float ABI support" r366450.
Revert "[RISCV] Hard float ABI support" r366450
Jul 18 2019, 9:14 AM
asb committed rGfc3aa2ab485f: [RISCV] Hard float ABI support (authored by asb).
[RISCV] Hard float ABI support
Jul 18 2019, 8:35 AM
asb committed rL366450: [RISCV] Hard float ABI support.
[RISCV] Hard float ABI support
Jul 18 2019, 8:33 AM
asb closed D60456: [RISCV] Hard float ABI support.
Jul 18 2019, 8:33 AM · Restricted Project, Restricted Project
asb requested changes to D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..

Looking at this in more detail - shouldn't we be making use of the R_RISCV_SET* relocations?

Jul 18 2019, 4:01 AM · Restricted Project
asb committed rGb8d352a08bc6: [RISCV] Reset NoPHIS MachineFunctionProperty in emitSelectPseudo (authored by asb).
[RISCV] Reset NoPHIS MachineFunctionProperty in emitSelectPseudo
Jul 18 2019, 12:55 AM
asb committed rL366412: [RISCV] Reset NoPHIS MachineFunctionProperty in emitSelectPseudo.
[RISCV] Reset NoPHIS MachineFunctionProperty in emitSelectPseudo
Jul 18 2019, 12:52 AM
asb committed rGdad1bebecd87: [RISCV][DebugInfo] Fix dwarf-riscv-relocs.ll test on Windows (authored by asb).
[RISCV][DebugInfo] Fix dwarf-riscv-relocs.ll test on Windows
Jul 18 2019, 12:27 AM
asb committed rL366410: [RISCV][DebugInfo] Fix dwarf-riscv-relocs.ll test on Windows.
[RISCV][DebugInfo] Fix dwarf-riscv-relocs.ll test on Windows
Jul 18 2019, 12:26 AM

Jul 17 2019

asb committed rG44deaf7e54ef: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info (authored by asb).
[DWARF][RISCV] Add support for RISC-V relocations needed for debug info
Jul 17 2019, 10:28 PM
asb committed rL366402: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info.
[DWARF][RISCV] Add support for RISC-V relocations needed for debug info
Jul 17 2019, 10:27 PM
asb closed D62062: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info.
Jul 17 2019, 10:27 PM · Restricted Project
asb committed rG4e8d07fd7db2: [RISCV] Re-land r366331 d RISCV to LLVM_ALL_TARGETS (authored by asb).
[RISCV] Re-land r366331 d RISCV to LLVM_ALL_TARGETS
Jul 17 2019, 9:10 PM
asb committed rL366399: [RISCV] Re-land r366331 d RISCV to LLVM_ALL_TARGETS.
[RISCV] Re-land r366331 d RISCV to LLVM_ALL_TARGETS
Jul 17 2019, 9:10 PM
asb committed rG8aba95d64cf3: [RISCV] Avoid signed integer overflow UB in RISCVMatInt::generateInstSeq (authored by asb).
[RISCV] Avoid signed integer overflow UB in RISCVMatInt::generateInstSeq
Jul 17 2019, 9:04 PM
asb committed rL366398: [RISCV] Avoid signed integer overflow UB in RISCVMatInt::generateInstSeq.
[RISCV] Avoid signed integer overflow UB in RISCVMatInt::generateInstSeq
Jul 17 2019, 9:04 PM
asb committed rGad73a436dc3b: [RISCV] Don't acccess an invalidated iterator in RISCVInstrInfo::removeBranch (authored by asb).
[RISCV] Don't acccess an invalidated iterator in RISCVInstrInfo::removeBranch
Jul 17 2019, 8:25 PM
asb committed rL366397: [RISCV] Don't acccess an invalidated iterator in RISCVInstrInfo::removeBranch.
[RISCV] Don't acccess an invalidated iterator in RISCVInstrInfo::removeBranch
Jul 17 2019, 8:23 PM
asb committed rG544315b41970: [RISCV] Revert r366331 as it exposed some sanitizer failures (authored by asb).
[RISCV] Revert r366331 as it exposed some sanitizer failures
Jul 17 2019, 9:16 AM
asb committed rL366343: [RISCV] Revert r366331 as it exposed some sanitizer failures.
[RISCV] Revert r366331 as it exposed some sanitizer failures
Jul 17 2019, 9:15 AM
asb committed rG80de11ed0216: [RISCV] Add RISCV to LLVM_ALL_TARGETS so it s built by default (authored by asb).
[RISCV] Add RISCV to LLVM_ALL_TARGETS so it s built by default
Jul 17 2019, 7:33 AM
asb committed rL366331: [RISCV] Add RISCV to LLVM_ALL_TARGETS so it s built by default.
[RISCV] Add RISCV to LLVM_ALL_TARGETS so it s built by default
Jul 17 2019, 7:32 AM
asb committed rGc74fded05ff3: [RISCV][NFC] Remove outdated TODO from test/CodeGen/RISCV/dwarf-eh.ll (authored by asb).
[RISCV][NFC] Remove outdated TODO from test/CodeGen/RISCV/dwarf-eh.ll
Jul 17 2019, 7:05 AM
asb committed rL366330: [RISCV][NFC] Remove outdated TODO from test/CodeGen/RISCV/dwarf-eh.ll.
[RISCV][NFC] Remove outdated TODO from test/CodeGen/RISCV/dwarf-eh.ll
Jul 17 2019, 7:04 AM
asb committed rGab009a602e96: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable… (authored by asb).
[AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable…
Jul 17 2019, 7:01 AM
asb committed rL366329: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable….
[AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable…
Jul 17 2019, 7:01 AM
asb closed D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.
Jul 17 2019, 7:01 AM · Restricted Project
asb accepted D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.

LGTM, thanks. I've spent quite a bit of time comparing output vs gcc so I'm pretty confident here now. I committed a slightly different test strategy in the DWARF encoding work I just committed, so will adjust this patch to build on that.

Jul 17 2019, 7:01 AM · Restricted Project
asb committed rGb94c233d0673: [RISCV] Set correct encodings for DWARF exception handling (authored by asb).
[RISCV] Set correct encodings for DWARF exception handling
Jul 17 2019, 6:55 AM
asb committed rL366327: [RISCV] Set correct encodings for DWARF exception handling.
[RISCV] Set correct encodings for DWARF exception handling
Jul 17 2019, 6:55 AM
asb committed rGaa55124eca68: [RISCV][NFC] Add tests that capture current encodings for DWARF EH (authored by asb).
[RISCV][NFC] Add tests that capture current encodings for DWARF EH
Jul 17 2019, 6:50 AM
asb committed rL366326: [RISCV][NFC] Add tests that capture current encodings for DWARF EH.
[RISCV][NFC] Add tests that capture current encodings for DWARF EH
Jul 17 2019, 6:48 AM

Jul 16 2019

asb added a comment to D63409: [RISCV] Specify various encodings for DWARF exception handling.
In D63409#1587117, @asb wrote:

Hi Ed, this is really hard to review without any documentation in the psABI or otherwise. Can you confirm that you've verified this matches gcc/gas? Are you planning to submit document to riscv-elf-psabi-doc to reflect this?

I've opened a pull request on the psABI docs (https://github.com/riscv/riscv-elf-psabi-doc/pull/110). I'm not entirely sure the details here are relevant to the ABI though. As far as I'm aware provided the individual CIE and FDEs are well-formed it shouldn't matter if the encodings differ from those specified in other CIE and FDEs.

On another note, after taking a look at the GCC code for this I'm not convinced the non-PIC values for the encodings match. GCC appears to just encode everything as pc-relative sdata4, whereas the above encodes things as absolute when PIC is not specified.

Jul 16 2019, 5:02 AM · Restricted Project
asb added a comment to D63409: [RISCV] Specify various encodings for DWARF exception handling.

Hi Ed, this is really hard to review without any documentation in the psABI or otherwise. Can you confirm that you've verified this matches gcc/gas? Are you planning to submit document to riscv-elf-psabi-doc to reflect this?

Jul 16 2019, 1:54 AM · Restricted Project
asb accepted D63404: [RISCV] Don't force absolute FK_Data_X fixups to relocs.

Thanks for the clarification Ed. This looks good to me - thanks!

Jul 16 2019, 1:38 AM · Restricted Project
asb added a comment to D55277: [RISCV] Match GNU tools canonical JALR and add aliases.
In D55277#1586961, @asb wrote:
In D55277#1586958, @asb wrote:

Sorry about that, patch incoming.

I got one coming too. Should I wait for yours or just land this one?

Oh great, please land yours then. Mind is written blind as lld doesn't seem to be building after I add it to LLVM_ENABLE_PROJECTS. Will have to wipe my build dir and wait a while.

Would you be able to do a post commit look over: https://github.com/llvm/llvm-project/commit/3e10905c49ffda36d7a90e24be1ab30832fa4afc

??

Thanks

PL

Jul 16 2019, 12:14 AM · Restricted Project

Jul 15 2019

asb added a comment to D55277: [RISCV] Match GNU tools canonical JALR and add aliases.
In D55277#1586958, @asb wrote:

Sorry about that, patch incoming.

I got one coming too. Should I wait for yours or just land this one?

Jul 15 2019, 11:00 PM · Restricted Project
asb added a comment to D55277: [RISCV] Match GNU tools canonical JALR and add aliases.
Jul 15 2019, 10:47 PM · Restricted Project
asb accepted D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

LGTM, thanks! Some minor rebasing is needed for relax-debug-frame.ll. Please go ahead and commit.

Jul 15 2019, 10:16 PM · Restricted Project
asb accepted D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..

LGTM (two minor comments in-line). Pleas go ahead and commit - thanks!

Jul 15 2019, 10:10 PM · Restricted Project
asb committed rG1ffceaa54361: [RISCV] Match GNU tools canonical JALR and add aliases (authored by asb).
[RISCV] Match GNU tools canonical JALR and add aliases
Jul 15 2019, 9:57 PM
asb committed rL366179: [RISCV] Match GNU tools canonical JALR and add aliases.
[RISCV] Match GNU tools canonical JALR and add aliases
Jul 15 2019, 9:56 PM
asb closed D55277: [RISCV] Match GNU tools canonical JALR and add aliases.
Jul 15 2019, 9:56 PM · Restricted Project
asb committed rGbb479ca31195: [RISCV] Avoid overflow when determining number of nops for code align (authored by asb).
[RISCV] Avoid overflow when determining number of nops for code align
Jul 15 2019, 9:42 PM
asb committed rL366176: [RISCV] Avoid overflow when determining number of nops for code align.
[RISCV] Avoid overflow when determining number of nops for code align
Jul 15 2019, 9:40 PM
asb closed D63274: [RISCV] Avoid overflow when determining number of nops for code align.
Jul 15 2019, 9:40 PM · Restricted Project
asb committed rGe9ad0cf6cf79: [RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign() (authored by asb).
[RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign()
Jul 15 2019, 9:39 PM
asb committed rL366175: [RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign().
[RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign()
Jul 15 2019, 9:39 PM
asb closed D63285: [RISCV] Fix a potential issue in shouldInsertFixupForCodeAlign().
Jul 15 2019, 9:39 PM · Restricted Project
asb committed rGef8577ef9871: [RISCV][NFC] Split PseudoCALL pattern out from instruction (authored by asb).
[RISCV][NFC] Split PseudoCALL pattern out from instruction
Jul 15 2019, 8:57 PM
asb committed rL366174: [RISCV][NFC] Split PseudoCALL pattern out from instruction.
[RISCV][NFC] Split PseudoCALL pattern out from instruction
Jul 15 2019, 8:56 PM
asb closed D64012: [RISCV][NFC] Split PseudoCALL pattern out from instruction.
Jul 15 2019, 8:56 PM · Restricted Project
asb committed rGa3c7b27419a5: [RISCV][NFC] Fix HasStedExtA -> HasStdExtA typo in comment (authored by asb).
[RISCV][NFC] Fix HasStedExtA -> HasStdExtA typo in comment
Jul 15 2019, 8:55 PM
asb committed rL366173: [RISCV][NFC] Fix HasStedExtA -> HasStdExtA typo in comment.
[RISCV][NFC] Fix HasStedExtA -> HasStdExtA typo in comment
Jul 15 2019, 8:53 PM
asb closed D64011: [RISCV][NFC] Fix HasStedExtA -> HasStdExtA typo in comment.
Jul 15 2019, 8:53 PM · Restricted Project
asb committed rG4ac0b9be2305: [RISCV] Make RISCVELFObjectWriter::getRelocType check IsPCRel (authored by asb).
[RISCV] Make RISCVELFObjectWriter::getRelocType check IsPCRel
Jul 15 2019, 8:51 PM
asb committed rL366172: [RISCV] Make RISCVELFObjectWriter::getRelocType check IsPCRel.
[RISCV] Make RISCVELFObjectWriter::getRelocType check IsPCRel
Jul 15 2019, 8:47 PM
asb added a comment to D64715: [WIP][RISCV] Use RISCV_32_PCREL reloc for FDE initial location.

Thanks Ed. I came to the same conclusion re the need for emitting R_RISCV_32_PCREL when debuggin some issues over the weekend. I had a different fix though - I'll try to compare vs this and get back to you later today.

Jul 15 2019, 4:53 AM · Restricted Project

Jul 9 2019

asb accepted D64425: [RISCV] Fix ICE in isDesirableToCommuteWithShift.

LGTM, thanks!

Jul 9 2019, 9:19 AM · Restricted Project
asb committed rGe0831dac0c3c: [RISCV] Fix RISCVTTIImpl::getIntImmCost for immediates where getMinSignedBits()… (authored by asb).
[RISCV] Fix RISCVTTIImpl::getIntImmCost for immediates where getMinSignedBits()…
Jul 9 2019, 3:57 AM