Page MenuHomePhabricator

asb (Alex Bradbury)
RISC-V, WebAssembly

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2013, 5:31 AM (503 w, 2 d)

Recent Activity

Today

asb accepted D147183: [RISCV][docs] Document which revision of the specification we implement.

LGTM, though hopefully at least one other person can confirm they're happy with the wording.

Thu, Mar 30, 1:39 PM · Restricted Project, Restricted Project
asb accepted D147261: [RISCV] Add Zicsr and Zifencei to CPUs in RISCVProcessors.td..

LGTM. I also understand that Rocket and SCR-1 support zicsr and zifencei in all standard configurations (and their respective repos seem to confirm this).

Thu, Mar 30, 1:23 PM · Restricted Project, Restricted Project, Restricted Project
asb accepted D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version.

LGTM, thanks (though see minor note about tweaking commit message to clarify the change).

Thu, Mar 30, 1:09 PM · Restricted Project, Restricted Project, Restricted Project
asb committed rGa755e80ed1d2: [RISCV] Add codegen for the experimental zicond extension (authored by asb).
[RISCV] Add codegen for the experimental zicond extension
Thu, Mar 30, 1:06 PM · Restricted Project, Restricted Project
asb closed D147147: [RISCV] Add codegen for the experimental zicond extension.
Thu, Mar 30, 1:06 PM · Restricted Project, Restricted Project
asb committed rG5b0705961841: [RISCV] Slightly weaken expanded seq_cst atomic op to match reference mapping… (authored by asb).
[RISCV] Slightly weaken expanded seq_cst atomic op to match reference mapping…
Thu, Mar 30, 12:49 PM · Restricted Project, Restricted Project
asb closed D146933: [RISCV] Slightly weaken expanded seq_cst atomic op to match reference mapping in in the spec.
Thu, Mar 30, 12:48 PM · Restricted Project, Restricted Project
asb added a comment to D147179: [RISCV] Bump I, F, D, and A extension versions to 20191214 spec version.

I've added a couple of inline comments, but otherwise this seems fine to me. I'd suggest updating the patch description to reference Philip's documentation patch (which was posted soon after this), and also to explain why there are no codegen changes (I think "Either changes to the specification required no codegen changes, or LLVM was written against a newer version of the specification than it claimed" is vague but accurate).

Thu, Mar 30, 6:27 AM · Restricted Project, Restricted Project, Restricted Project
asb added a comment to D147183: [RISCV][docs] Document which revision of the specification we implement.

I think this reflects what we (extensively) discussed and there was broad consensus for, so I'd be happy enough for it to land as-is rather than getting too bogged down over precise terminology. That said, I do think that going into the details of draft vs non-draft specifications and so on might be going into more detail than necessary, and could be confusing. It also seems like RISC-V is rather ignoring (and perhaps choosing to move away from?) the task of centralising all the extensions in a single ISA manual, so again it may make more sense to focus on ratified vs non-ratified as the thing that is easily understandable rather than trying to explain the way extension definitions are confusingly spread across different repositories.

Thu, Mar 30, 6:01 AM · Restricted Project, Restricted Project
asb added a comment to D143248: Emit CFI directives in epilogue and enable CFIFixup pass for RISC-V..

@kito-cheng is this something you might be able to help review?

Thu, Mar 30, 4:49 AM · Restricted Project, Restricted Project
asb added inline comments to D146438: [RISCV][MC] Refine MCInstrAnalysis based on registers used.
Thu, Mar 30, 3:08 AM · Restricted Project, Restricted Project

Yesterday

asb added a comment to D147173: [RISCV] Merge SExtWRemoval and StripWSuffix into a single pass..

LGTM. I'd note that clang-format prefers different formatting for some of the functions here - it's probably worth reformatting while you're doing this merge into a new pass.

Is it just the switch statement I intentionally wrote with the lines compacted?

Wed, Mar 29, 4:16 PM · Restricted Project, Restricted Project
asb accepted D147174: [RISCV] Move allWUsers from RISCVInstrInfo to RISCVOptWInstrs..

LGTM.

Wed, Mar 29, 2:11 PM · Restricted Project, Restricted Project
asb accepted D147173: [RISCV] Merge SExtWRemoval and StripWSuffix into a single pass..

LGTM. I'd note that clang-format prefers different formatting for some of the functions here - it's probably worth reformatting while you're doing this merge into a new pass.

Wed, Mar 29, 2:01 PM · Restricted Project, Restricted Project
asb committed rGf5e63f8fc9f4: [RISCV] Support emulated TLS (authored by vit9696).
[RISCV] Support emulated TLS
Wed, Mar 29, 12:59 PM · Restricted Project, Restricted Project
asb closed D143708: [RISCV] Support emulated TLS.
Wed, Mar 29, 12:58 PM · Restricted Project, Restricted Project
asb accepted D147004: [RISCV] Add helper function for RVV intrinsics in getTgtMemIntrinsic. NFC.

LGTM.

Wed, Mar 29, 9:45 AM · Restricted Project, Restricted Project
asb added a comment to D143708: [RISCV] Support emulated TLS.

Brilliant, thanks everyone. @vit9696 am I right that you don't currently have LLVM commit access - would you like me to go ahead and commit this for you?

Wed, Mar 29, 9:08 AM · Restricted Project, Restricted Project
asb added a comment to D146191: [MachineOutliner] Add IsOutlined to MachineFunction.

Thanks Jessica - in that case, LGTM once it has the MIR test case Jessica requested.

I thought the earlier conclusion was that the RISC-V part wasn’t needed if T-Head moves their pseudo expansion in their downstream.

Wed, Mar 29, 8:45 AM · Restricted Project, Restricted Project
asb added a comment to D146191: [MachineOutliner] Add IsOutlined to MachineFunction.

Thanks Jessica - in that case, LGTM once it has the MIR test case Jessica requested.

Wed, Mar 29, 7:56 AM · Restricted Project, Restricted Project
asb requested review of D147147: [RISCV] Add codegen for the experimental zicond extension.
Wed, Mar 29, 6:24 AM · Restricted Project, Restricted Project
asb committed rGac269d185c38: [RISCV][test] Update CHECK lines in condops related tests in preparation for… (authored by asb).
[RISCV][test] Update CHECK lines in condops related tests in preparation for…
Wed, Mar 29, 6:15 AM · Restricted Project, Restricted Project
asb committed rGd3291c692c0a: [RISCV][MC] Add support for the experimental zicond extension (authored by asb).
[RISCV][MC] Add support for the experimental zicond extension
Wed, Mar 29, 4:18 AM · Restricted Project, Restricted Project, Restricted Project
asb closed D146946: [RISCV][MC] Add support for experimental zicond extension.
Wed, Mar 29, 4:18 AM · Restricted Project, Restricted Project, Restricted Project
asb committed rZORG778038861ae5: [RISCV] Move RISC-V qemu-user based builder to using clang/clang++ (authored by asb).
[RISCV] Move RISC-V qemu-user based builder to using clang/clang++
Wed, Mar 29, 3:59 AM · Restricted Project
asb added a comment to D143708: [RISCV] Support emulated TLS.

No objection. LG once @jrtc27 is happy.

Wed, Mar 29, 2:12 AM · Restricted Project, Restricted Project

Tue, Mar 28

asb accepted D144530: [RISCV] MC layer support for SiFive VCIX vendor extension..

LGTM too.

Tue, Mar 28, 11:09 PM · Restricted Project, Restricted Project
asb added a comment to D146191: [MachineOutliner] Add IsOutlined to MachineFunction.

Do the T-Head specific pseudos being expanded need to expanded as late as the other pseudos? Could you have an earlier expansion pass? I was already nervous about the short forward branch instructions being affected before. I know we determined those cases were ok.

Yes and thanks, I just tried. They can be placed in addPreEmitPass() just like MCP.
Apart from this, do you think it's still worthy marking outlined functions?

Tue, Mar 28, 5:40 AM · Restricted Project, Restricted Project
asb added a comment to D135960: [RISCV] Allow LI with symbol difference as constant.

Could you please update the patch description to say "Fixes #57461" or similar?

I think all the review comments are addressed and I don't have additional feedback - the only open line of discussion I think was about how fixup_riscv_12_i is the only fixup that can never result in a relocation (as pointed out by @jrtc27). That's true, but I also can't see an alternative way of handling it or any real disadvantage of this - it logically _is_ a fixup. Do you see an alternative approach, or was it more that you think it would make sense to adjust the naming so it's clearer it doesn't have a matching relocation?

Rereading this, I wasn't very clear who I was directing my question to - I meant to direct it at @jrtc27 - what do you think?

Tue, Mar 28, 3:20 AM · Restricted Project, Restricted Project

Mon, Mar 27

asb accepted D146997: [RISCV] Rename FeatureExtZc* to FeatureStdExtZc*. NFC.

LGTM

Mon, Mar 27, 1:00 PM · Restricted Project, Restricted Project
asb requested review of D146946: [RISCV][MC] Add support for experimental zicond extension.
Mon, Mar 27, 4:32 AM · Restricted Project, Restricted Project, Restricted Project
asb accepted D146488: [RISCV] Move compressible registers to the beginning of the FP allocation order..

I can't say I've done any real performance analysis, but this seems sensible to me and I didn't spot any obvious regressions from kicking the tires.

Mon, Mar 27, 2:29 AM · Restricted Project, Restricted Project
asb added a comment to D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3.

I've flagged this proposed change on Discourse (more the fact we're looking to change it, rather than the precise register we end up with).

Mon, Mar 27, 2:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
asb added inline comments to D146438: [RISCV][MC] Refine MCInstrAnalysis based on registers used.
Mon, Mar 27, 1:55 AM · Restricted Project, Restricted Project
asb accepted D146437: [RISCV] Remove isCall instruction flag from JAL/JALR.

LGTM.

Mon, Mar 27, 1:52 AM · Restricted Project, Restricted Project
asb accepted D146663: [RISCV] Add .insn support for compressed formats..

LGTM - I just wonder about if we want to gate this on C/Zca as this patch does. Assuming someone reused the 16-bit encoding space, perhaps they want to using .insn to insert some of their instructions. OTOH, perhaps it's not so likely that the instruction formats would be as they want, at which point .insn isn't very useful.

Mon, Mar 27, 1:51 AM · Restricted Project, Restricted Project
asb accepted D146451: [RISCV] Replace RISCV->RISC-V in strings..

Not as compelling as user facing strings or comments that clearly refer to the RISC-V ISA rather than the "RISCV" LLVM backend. But I don't really see a good reason not to be consistent. LGTM.

Mon, Mar 27, 1:38 AM · Restricted Project, Restricted Project, Restricted Project
asb accepted D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC.

LGTM.

Mon, Mar 27, 1:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sun, Mar 26

asb requested review of D146933: [RISCV] Slightly weaken expanded seq_cst atomic op to match reference mapping in in the spec.
Sun, Mar 26, 11:26 PM · Restricted Project, Restricted Project
asb committed rG91c6174ce359: [RISCV] Allow llvm-objdump to disassemble objects with unrecognised versions of… (authored by asb).
[RISCV] Allow llvm-objdump to disassemble objects with unrecognised versions of…
Sun, Mar 26, 8:40 PM · Restricted Project, Restricted Project
asb closed D146114: [RISCV] Allow llvm-objdump to disassemble objects with unrecognised versions of known extensions.
Sun, Mar 26, 8:40 PM · Restricted Project, Restricted Project
asb committed rG062065888f64: [RISCV] Enable tools such as llvm-objdump to process objects with unrecognised… (authored by asb).
[RISCV] Enable tools such as llvm-objdump to process objects with unrecognised…
Sun, Mar 26, 8:34 PM · Restricted Project, Restricted Project
asb closed D146070: [RISCV] Enable tools such as llvm-objdump to process objects with unrecognised base ISA versions.
Sun, Mar 26, 8:34 PM · Restricted Project, Restricted Project
asb committed rG938deaad8ac9: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs (authored by asb).
[clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs
Sun, Mar 26, 8:21 AM · Restricted Project, Restricted Project
asb closed D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs.
Sun, Mar 26, 8:21 AM · Restricted Project, Restricted Project
asb committed rGa742511cbe9a: [clang][RISCV][test] Add test cases for empty structs and the FP calling… (authored by asb).
[clang][RISCV][test] Add test cases for empty structs and the FP calling…
Sun, Mar 26, 8:15 AM · Restricted Project, Restricted Project
asb closed D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions.
Sun, Mar 26, 8:14 AM · Restricted Project, Restricted Project
asb updated the diff for D146114: [RISCV] Allow llvm-objdump to disassemble objects with unrecognised versions of known extensions.

Rebase and address review comments.

Sun, Mar 26, 8:05 AM · Restricted Project, Restricted Project
asb committed rGaf602edf0ecb: [RISCV] Make RISCVISAInfo::toFeatureVector ignore unsupported extensions (authored by asb).
[RISCV] Make RISCVISAInfo::toFeatureVector ignore unsupported extensions
Sun, Mar 26, 7:52 AM · Restricted Project, Restricted Project
asb closed D146113: [RISCV] Make RISCVISAInfo::toFeatureVector ignore unsupported extensions.
Sun, Mar 26, 7:52 AM · Restricted Project, Restricted Project
asb updated the diff for D146070: [RISCV] Enable tools such as llvm-objdump to process objects with unrecognised base ISA versions.

Rebase (to account for removal of string from RISCVExtensionInfo. The following patches have been approved, so just waiting for approval of this to land the series.

Sun, Mar 26, 7:45 AM · Restricted Project, Restricted Project

Fri, Mar 24

asb added a comment to D146835: [RISCV] Enable usubo formation in CodeGenPrepare..

I start writing a comment grumbling that this adds undesirably tight coupling between with the implementation details of TargetLowering::shouldFormOverflowOp, but when I got to the end of it figured it wasn't that bad. If the comment had just said "Allow the transform whenever it would be allowed for UADDO" I might not have commented. LGTM. Though an assert like you suggest probably makes sense.

Fri, Mar 24, 1:37 PM · Restricted Project, Restricted Project
asb added a comment to D123515: [RISCV] Support '.option arch' directive.

First and foremost, thank you for keeping this up to date and iterating upon it while the .option arch proposal was under review in the asm manual. I think we're basically almost there.

Fri, Mar 24, 8:31 AM · Restricted Project, Restricted Project
asb added a comment to D146245: [RISCV] Lower inline asm m with offset to register+imm..

I don't feel comfortable approving this because I played a hand in diagnosing the issue and helping Mikhail with the patch. I do think updating our handling of the 'm' constraint to match GCC's is the right thing to do, and this patch achieves it in the simplest way I'm aware of. The logic around asm operand constraints isn't always easy to follow, so it's possible I'm missing alternative ways of achieving the same goal.

Fri, Mar 24, 6:00 AM · Restricted Project, Restricted Project

Thu, Mar 23

asb committed rGd0e2a42853b1: [RISCV][test] Fix another missed test change from RV64E patch (authored by jobnoorman).
[RISCV][test] Fix another missed test change from RV64E patch
Thu, Mar 23, 6:03 AM · Restricted Project, Restricted Project
asb added a comment to D143570: [RISCV][MC] Add support for RV64E.

Apologies, the commited version of this patch missed the clang/test/Driver/riscv-arch.c change. rGe54cdd058e223bd62840e901b8b462c011d2fae5 committed to fix this.

Thu, Mar 23, 5:51 AM · Restricted Project, Restricted Project, Restricted Project
asb committed rGe54cdd058e22: [RISCV][clang][test] Fix missed test (authored by jobnoorman).
[RISCV][clang][test] Fix missed test
Thu, Mar 23, 5:50 AM · Restricted Project, Restricted Project
asb committed rGc39dd7c1db97: [RISCV][MC] Add support for RV64E (authored by jobnoorman).
[RISCV][MC] Add support for RV64E
Thu, Mar 23, 5:33 AM · Restricted Project, Restricted Project, Restricted Project
asb closed D143570: [RISCV][MC] Add support for RV64E.
Thu, Mar 23, 5:33 AM · Restricted Project, Restricted Project, Restricted Project
asb accepted D143570: [RISCV][MC] Add support for RV64E.

LGTM - thanks. I'll land this for you now since it already got a LGTM from Kito.

Thu, Mar 23, 5:14 AM · Restricted Project, Restricted Project, Restricted Project
asb committed rGda44224d3aa8: [RISCV][test] Fix broken unit test after d25751779ba (authored by asb).
[RISCV][test] Fix broken unit test after d25751779ba
Thu, Mar 23, 4:20 AM · Restricted Project, Restricted Project
asb added a comment to D143570: [RISCV][MC] Add support for RV64E.

I expect you'll need to / want to update the C++ RISCVISAInfo unit tests as they were added after this patch was first proposed.

Thu, Mar 23, 3:46 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 21

asb added a comment to D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3.

In principle I think this is good, but I see two considerations:

  1. Sam was right that there's an ability to change the register after the fact, but 2.5 years have passed since then. We should make a good faith attempt to see if any downstream users are relying on the current ABI (e.g. the original contributors - @zzheng and @apazos).
  2. Now that the issue has been raised in the psABI / toolchain-sig, it would be good if there were consensus on the "platform register" rather than changing this multiple times if some different register is decided.
Tue, Mar 21, 11:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
asb added a comment to D135960: [RISCV] Allow LI with symbol difference as constant.

Could you please update the patch description to say "Fixes #57461" or similar?

I think all the review comments are addressed and I don't have additional feedback - the only open line of discussion I think was about how fixup_riscv_12_i is the only fixup that can never result in a relocation (as pointed out by @jrtc27). That's true, but I also can't see an alternative way of handling it or any real disadvantage of this - it logically _is_ a fixup. Do you see an alternative approach, or was it more that you think it would make sense to adjust the naming so it's clearer it doesn't have a matching relocation?

Tue, Mar 21, 3:26 AM · Restricted Project, Restricted Project

Mon, Mar 20

asb added a comment to D146451: [RISCV] Replace RISCV->RISC-V in strings..

The logic I saw with the pass names is that the backend for the RISC-V architecture is called "RISCV". But I've got no objection to changing.

Mon, Mar 20, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
asb committed rG34f1da3468ab: [RISCV] Make Zfh PseudoQuietFCMP definitions predicated on HasStdExtZfh (authored by asb).
[RISCV] Make Zfh PseudoQuietFCMP definitions predicated on HasStdExtZfh
Mon, Mar 20, 10:07 AM · Restricted Project, Restricted Project
asb closed D146435: [RISCV] Make Zfh PseudoQuietFCMP definitions predicated on HasStdExtZfh.
Mon, Mar 20, 10:07 AM · Restricted Project, Restricted Project
asb requested review of D146435: [RISCV] Make Zfh PseudoQuietFCMP definitions predicated on HasStdExtZfh.
Mon, Mar 20, 9:40 AM · Restricted Project, Restricted Project

Fri, Mar 17

asb accepted D146270: [RISCV] Use LBU for extloadi8..

LGTM.

Fri, Mar 17, 10:18 AM · Restricted Project, Restricted Project
asb added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

This broke -DBUILD_SHARED_LIBS=True builds - I committed rG482d22d05a4a30a4f8594273bd359f7d311c9d4c to fix it.

Fri, Mar 17, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
asb committed rG482d22d05a4a: [clang][test] Fix -DBUILD_SHARED_LIBS build by adding depency on MC from… (authored by asb).
[clang][test] Fix -DBUILD_SHARED_LIBS build by adding depency on MC from…
Fri, Mar 17, 7:46 AM · Restricted Project, Restricted Project

Thu, Mar 16

asb added inline comments to D146054: [RISCV] Add -print-supported-marchs and -march=help support.
Thu, Mar 16, 11:59 AM · Restricted Project, Restricted Project, Restricted Project
asb added a comment to D143248: Emit CFI directives in epilogue and enable CFIFixup pass for RISC-V..

Hi Varun - thanks for filing bug #60698 to help track this issue, and for noticing that there should now be some upstream support for cfi_remember_state and cfi_restore_state.

The first question that comes to my mind is what degree of testing you've done with this?

Hi Alex,
the patch updates over 500 testcases for RISCV(as it adds cfi info the epilogue), which results in a patch of over 30M. Due to which I'm not able to upload.

Thu, Mar 16, 9:55 AM · Restricted Project, Restricted Project
asb added a comment to D144530: [RISCV] MC layer support for SiFive VCIX vendor extension..

I haven't looked through the .td description yet, but left some first comments (all pretty easily addressable and minor).

Thu, Mar 16, 9:00 AM · Restricted Project, Restricted Project
asb committed rG7d10b4745054: [RISCV][MC][NFC] Refactor RISCVAsmPrinter::PrintAsmMemoryOperand to use early… (authored by asb).
[RISCV][MC][NFC] Refactor RISCVAsmPrinter::PrintAsmMemoryOperand to use early…
Thu, Mar 16, 8:05 AM · Restricted Project, Restricted Project
asb accepted D146197: [RISCV] Remove ExtName from RISCVExtensionInfo..

LGTM. I think I can see the potential reasoning for the extension name being in RISCVExtensionInfo in the first place - it makes it more plausible to use it separated from the OrderedExtensionMap. But as you note, in reality we don't have any such uses and I can't really foresee any either.

Thu, Mar 16, 2:00 AM · Restricted Project, Restricted Project

Wed, Mar 15

asb added inline comments to D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs.
Wed, Mar 15, 11:32 AM · Restricted Project, Restricted Project
asb updated the diff for D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs.

Rebase.

Wed, Mar 15, 11:21 AM · Restricted Project, Restricted Project
asb committed rGa7e13d6f1b49: [clang][RISCV][test] Add test coverage for _Float16 ABI lowering (authored by asb).
[clang][RISCV][test] Add test coverage for _Float16 ABI lowering
Wed, Mar 15, 11:01 AM · Restricted Project, Restricted Project
asb closed D145070: [clang][RISCV][test] Add test coverage for _Float16 ABI lowering.
Wed, Mar 15, 11:01 AM · Restricted Project, Restricted Project
asb committed rG8964d7a1d7f3: [clang][RISCV][NFC] Combine RV32/RV64 ABI tests into single files (authored by asb).
[clang][RISCV][NFC] Combine RV32/RV64 ABI tests into single files
Wed, Mar 15, 10:08 AM · Restricted Project, Restricted Project
asb closed D140400: [clang][RISCV][NFC] Combine RV32/RV64 ABI tests into single files.
Wed, Mar 15, 10:07 AM · Restricted Project, Restricted Project
asb committed rG9f40e86dcc7f: [clang][RISCV][NFC][test] Move riscv-abi.cpp and riscv{32,64}-*abi.c tests to… (authored by asb).
[clang][RISCV][NFC][test] Move riscv-abi.cpp and riscv{32,64}-*abi.c tests to…
Wed, Mar 15, 8:45 AM · Restricted Project, Restricted Project
asb closed D134050: [clang][RISCV][NFC][test] Move riscv-abi.cpp and riscv{32,64}-*abi.c tests to use update_cc_test_checks.py.
Wed, Mar 15, 8:45 AM · Restricted Project, Restricted Project
asb accepted D146129: [Target][RISCV] Update SubtargetFeature definition for RV32/RV64 (NFCI)..

LGTM - thanks!

Wed, Mar 15, 7:18 AM · Restricted Project, Restricted Project
asb added a comment to D146129: [Target][RISCV] Update SubtargetFeature definition for RV32/RV64 (NFCI)..

Thanks for making this suggestion.

Wed, Mar 15, 4:58 AM · Restricted Project, Restricted Project

Tue, Mar 14

asb updated the summary of D146114: [RISCV] Allow llvm-objdump to disassemble objects with unrecognised versions of known extensions.
Tue, Mar 14, 11:12 PM · Restricted Project, Restricted Project
asb requested review of D146114: [RISCV] Allow llvm-objdump to disassemble objects with unrecognised versions of known extensions.
Tue, Mar 14, 11:08 PM · Restricted Project, Restricted Project
asb updated the diff for D146113: [RISCV] Make RISCVISAInfo::toFeatureVector ignore unsupported extensions.
Tue, Mar 14, 11:04 PM · Restricted Project, Restricted Project
asb requested review of D146113: [RISCV] Make RISCVISAInfo::toFeatureVector ignore unsupported extensions.
Tue, Mar 14, 11:00 PM · Restricted Project, Restricted Project
asb committed rGf47404b012d6: [clang][docs] Clarify the semantics of -fexceptions (authored by asb).
[clang][docs] Clarify the semantics of -fexceptions
Tue, Mar 14, 12:54 PM · Restricted Project, Restricted Project
asb closed D145564: [clang][docs] Clarify the semantics of -fexceptions.
Tue, Mar 14, 12:54 PM · Restricted Project, Restricted Project
asb accepted D145897: [RISCV] Merge getLoadFP*Imm into a single function..

LGTM. Could you precommit the tests though, as it's a bit confusing to add new tests when I think these pass even without the change.

Tue, Mar 14, 12:51 PM · Restricted Project, Restricted Project
asb accepted D145938: [RISCV] Pass vector argument by stack correctly..
Tue, Mar 14, 12:42 PM · Restricted Project, Restricted Project
asb accepted D145999: [RISCV] Reserve X18 by default for Android.

LGTM.

Tue, Mar 14, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
asb committed rGcb743dd83715: [RISCV] Consistently error for arch strings with trailing _ (authored by asb).
[RISCV] Consistently error for arch strings with trailing _
Tue, Mar 14, 12:13 PM · Restricted Project, Restricted Project
asb closed D145949: [RISCV] Consistently error for arch strings with trailing _.
Tue, Mar 14, 12:13 PM · Restricted Project, Restricted Project
asb added inline comments to D145999: [RISCV] Reserve X18 by default for Android.
Tue, Mar 14, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
asb committed rG084e4138930d: [RISCV] Fix regression due to interaction of MachineOutliner and… (authored by asb).
[RISCV] Fix regression due to interaction of MachineOutliner and…
Tue, Mar 14, 10:56 AM · Restricted Project, Restricted Project
asb closed D146037: [RISCV] Fix regression due to interaction of MachineOutliner and MachineCopyPropagation.
Tue, Mar 14, 10:56 AM · Restricted Project, Restricted Project