Page MenuHomePhabricator

dmgreen (Dave Green)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2016, 8:35 AM (164 w, 5 d)

Recent Activity

Today

dmgreen added a parent revision for D65066: [ARM] Disable MVE fptosi and friends: D65062: [ARM] More MVE compare vector splat combines for AND's.
Mon, Jul 22, 1:17 AM · Restricted Project
dmgreen added a child revision for D65062: [ARM] More MVE compare vector splat combines for AND's: D65066: [ARM] Disable MVE fptosi and friends.
Mon, Jul 22, 1:17 AM · Restricted Project
dmgreen created D65066: [ARM] Disable MVE fptosi and friends.
Mon, Jul 22, 1:17 AM · Restricted Project

Yesterday

dmgreen added a parent revision for D65062: [ARM] More MVE compare vector splat combines for AND's: D65061: [ARM] MVE compare vector splat combine.
Sun, Jul 21, 11:19 AM · Restricted Project
dmgreen added a child revision for D65061: [ARM] MVE compare vector splat combine: D65062: [ARM] More MVE compare vector splat combines for AND's.
Sun, Jul 21, 11:19 AM · Restricted Project
dmgreen created D65062: [ARM] More MVE compare vector splat combines for AND's.
Sun, Jul 21, 11:19 AM · Restricted Project
dmgreen added a parent revision for D65061: [ARM] MVE compare vector splat combine: D65059: [ARM] Better OR's for MVE compares.
Sun, Jul 21, 11:10 AM · Restricted Project
dmgreen added a child revision for D65059: [ARM] Better OR's for MVE compares: D65061: [ARM] MVE compare vector splat combine.
Sun, Jul 21, 11:10 AM · Restricted Project
dmgreen created D65061: [ARM] MVE compare vector splat combine.
Sun, Jul 21, 11:09 AM · Restricted Project
dmgreen added a child revision for D65058: [ARM] Better AND's for MVE compares: D65059: [ARM] Better OR's for MVE compares.
Sun, Jul 21, 10:36 AM · Restricted Project
dmgreen added a parent revision for D65059: [ARM] Better OR's for MVE compares: D65058: [ARM] Better AND's for MVE compares.
Sun, Jul 21, 10:36 AM · Restricted Project
dmgreen created D65059: [ARM] Better OR's for MVE compares.
Sun, Jul 21, 10:36 AM · Restricted Project
dmgreen added a parent revision for D65058: [ARM] Better AND's for MVE compares: D65054: [ARM] MVE floating point compares and selects.
Sun, Jul 21, 10:14 AM · Restricted Project
dmgreen updated the summary of D65058: [ARM] Better AND's for MVE compares.
Sun, Jul 21, 10:14 AM · Restricted Project
dmgreen created D65058: [ARM] Better AND's for MVE compares.
Sun, Jul 21, 10:14 AM · Restricted Project
dmgreen added a child revision for D65054: [ARM] MVE floating point compares and selects: D65058: [ARM] Better AND's for MVE compares.
Sun, Jul 21, 10:14 AM · Restricted Project
dmgreen added a child revision for D65053: [ARM] Basic And/Or/Xor handling for MVE predicates: D65054: [ARM] MVE floating point compares and selects.
Sun, Jul 21, 7:35 AM · Restricted Project
dmgreen added a parent revision for D65054: [ARM] MVE floating point compares and selects: D65053: [ARM] Basic And/Or/Xor handling for MVE predicates.
Sun, Jul 21, 7:35 AM · Restricted Project
dmgreen created D65054: [ARM] MVE floating point compares and selects.
Sun, Jul 21, 7:35 AM · Restricted Project
dmgreen added a parent revision for D65053: [ARM] Basic And/Or/Xor handling for MVE predicates: D65052: [ARM] MVE predicate register support.
Sun, Jul 21, 7:15 AM · Restricted Project
dmgreen added a child revision for D65052: [ARM] MVE predicate register support: D65053: [ARM] Basic And/Or/Xor handling for MVE predicates.
Sun, Jul 21, 7:15 AM · Restricted Project
dmgreen created D65053: [ARM] Basic And/Or/Xor handling for MVE predicates.
Sun, Jul 21, 7:15 AM · Restricted Project
dmgreen added a parent revision for D65052: [ARM] MVE predicate register support: D65051: [ARM] MVE integer compares and selects.
Sun, Jul 21, 7:04 AM · Restricted Project
dmgreen added a child revision for D65051: [ARM] MVE integer compares and selects: D65052: [ARM] MVE predicate register support.
Sun, Jul 21, 7:04 AM · Restricted Project
dmgreen created D65052: [ARM] MVE predicate register support.
Sun, Jul 21, 7:04 AM · Restricted Project
dmgreen added a child revision for D65049: [ARM] Fix for MVE VPT block pass: D65051: [ARM] MVE integer compares and selects.
Sun, Jul 21, 6:53 AM · Restricted Project
dmgreen added a parent revision for D65051: [ARM] MVE integer compares and selects: D65049: [ARM] Fix for MVE VPT block pass.
Sun, Jul 21, 6:53 AM · Restricted Project
dmgreen created D65051: [ARM] MVE integer compares and selects.
Sun, Jul 21, 6:48 AM · Restricted Project
dmgreen created D65049: [ARM] Fix for MVE VPT block pass.
Sun, Jul 21, 6:20 AM · Restricted Project
dmgreen committed rGc38899fc26ee: [ARM] Move MVE VPT block tests into the Thumb2 directory. NFC (authored by dmgreen).
[ARM] Move MVE VPT block tests into the Thumb2 directory. NFC
Sun, Jul 21, 6:11 AM
dmgreen committed rL366655: [ARM] Move MVE VPT block tests into the Thumb2 directory. NFC.
[ARM] Move MVE VPT block tests into the Thumb2 directory. NFC
Sun, Jul 21, 6:11 AM

Thu, Jul 18

dmgreen accepted D64394: [MachineCSE][MachinePRE] Do not hoist common computations into hot BBs.

Thanks. Looks like a nice change to me, other than one minor modification

Thu, Jul 18, 3:42 AM · Restricted Project

Wed, Jul 17

dmgreen added inline comments to D64394: [MachineCSE][MachinePRE] Do not hoist common computations into hot BBs.
Wed, Jul 17, 10:57 AM · Restricted Project

Mon, Jul 15

dmgreen committed rGdc56995c5745: [ARM] MVE vector for 64bit types (authored by dmgreen).
[ARM] MVE vector for 64bit types
Mon, Jul 15, 11:46 AM
dmgreen committed rL366106: [ARM] MVE vector for 64bit types.
[ARM] MVE vector for 64bit types
Mon, Jul 15, 11:43 AM
dmgreen closed D64316: [ARM] MVE vector of 64bit types.
Mon, Jul 15, 11:43 AM · Restricted Project
dmgreen committed rG8e7eee617a09: [ARM] Minor formatting in ARMInstrMVE.td. NFC (authored by dmgreen).
[ARM] Minor formatting in ARMInstrMVE.td. NFC
Mon, Jul 15, 10:31 AM
dmgreen committed rL366089: [ARM] Minor formatting in ARMInstrMVE.td. NFC.
[ARM] Minor formatting in ARMInstrMVE.td. NFC
Mon, Jul 15, 10:31 AM
dmgreen updated the diff for D63840: [ARM] Add support for MVE pre and post inc loads and stores..

The original version wasn't getting alignment correct in some cases. For little endian which instruction we choose has more to do with alignment and offset than type being loaded. I've rewritten parts of this to, at least for LE, get this hopefully more correct. I've tried to add BE too, but not added any tests for that yet. We still have a task to sort out BE properly.

Mon, Jul 15, 6:49 AM · Restricted Project
dmgreen committed rG6e89887642f4: [ARM] MVE Vector Shifts (authored by dmgreen).
[ARM] MVE Vector Shifts
Mon, Jul 15, 4:38 AM
dmgreen committed rL366056: [ARM] MVE Vector Shifts.
[ARM] MVE Vector Shifts
Mon, Jul 15, 4:36 AM
dmgreen closed D64212: [ARM] MVE Vector Shifts.
Mon, Jul 15, 4:36 AM · Restricted Project
dmgreen committed rGf059147a108b: [ARM] Move Shifts after Bits. NFC (authored by dmgreen).
[ARM] Move Shifts after Bits. NFC
Mon, Jul 15, 4:23 AM
dmgreen committed rL366054: [ARM] Move Shifts after Bits. NFC.
[ARM] Move Shifts after Bits. NFC
Mon, Jul 15, 4:21 AM
dmgreen committed rGda750b1688fb: [ARM] Adjust how NEON shifts are lowered (authored by dmgreen).
[ARM] Adjust how NEON shifts are lowered
Mon, Jul 15, 3:48 AM
dmgreen committed rL366051: [ARM] Adjust how NEON shifts are lowered.
[ARM] Adjust how NEON shifts are lowered
Mon, Jul 15, 3:48 AM
dmgreen closed D64426: [ARM] Adjust how NEON shifts are lowered.
Mon, Jul 15, 3:48 AM · Restricted Project
dmgreen updated the diff for D64212: [ARM] MVE Vector Shifts.

Added extra tests

Mon, Jul 15, 2:13 AM · Restricted Project
dmgreen updated the diff for D64426: [ARM] Adjust how NEON shifts are lowered.
Mon, Jul 15, 2:13 AM · Restricted Project

Sun, Jul 14

dmgreen added inline comments to D64394: [MachineCSE][MachinePRE] Do not hoist common computations into hot BBs.
Sun, Jul 14, 5:58 AM · Restricted Project

Sat, Jul 13

dmgreen committed rG458a720ec172: [ARM] Add sign and zero extend patterns for MVE (authored by dmgreen).
[ARM] Add sign and zero extend patterns for MVE
Sat, Jul 13, 8:46 AM
dmgreen committed rL366008: [ARM] Add sign and zero extend patterns for MVE.
[ARM] Add sign and zero extend patterns for MVE
Sat, Jul 13, 8:42 AM
dmgreen closed D64069: [ARM] Add sign and zero extend patterns for MVE.
Sat, Jul 13, 8:42 AM · Restricted Project
dmgreen committed rG07a7ec202144: [ARM] MVE VNEG instruction patterns (authored by dmgreen).
[ARM] MVE VNEG instruction patterns
Sat, Jul 13, 8:27 AM
dmgreen committed rL366006: [ARM] MVE VNEG instruction patterns.
[ARM] MVE VNEG instruction patterns
Sat, Jul 13, 8:26 AM
dmgreen closed D64204: [ARM] MVE VNeg instruction patterns.
Sat, Jul 13, 8:26 AM · Restricted Project
dmgreen committed rG4ce648b5e84c: [ARM] MVE integer abs (authored by dmgreen).
[ARM] MVE integer abs
Sat, Jul 13, 8:00 AM
dmgreen committed rL366005: [ARM] MVE integer abs.
[ARM] MVE integer abs
Sat, Jul 13, 7:59 AM
dmgreen closed D64027: [ARM] MVE integer abs.
Sat, Jul 13, 7:59 AM · Restricted Project
dmgreen committed rG701bf714dbca: [ARM] MVE integer min and max (authored by dmgreen).
[ARM] MVE integer min and max
Sat, Jul 13, 7:49 AM
dmgreen committed rL366004: [ARM] MVE integer min and max.
[ARM] MVE integer min and max
Sat, Jul 13, 7:48 AM
dmgreen closed D64026: [ARM] MVE integer min and max.
Sat, Jul 13, 7:48 AM · Restricted Project
dmgreen committed rGac5bcbeb9f8c: [ARM] MVE VRINT support (authored by dmgreen).
[ARM] MVE VRINT support
Sat, Jul 13, 7:41 AM
dmgreen committed rL366003: [ARM] MVE VRINT support.
[ARM] MVE VRINT support
Sat, Jul 13, 7:39 AM
dmgreen closed D63985: [ARM] MVE VRINT support.
Sat, Jul 13, 7:39 AM · Restricted Project
dmgreen committed rGec8af0db6c97: [ARM] MVE minnm and maxnm instructions (authored by dmgreen).
[ARM] MVE minnm and maxnm instructions
Sat, Jul 13, 7:30 AM
dmgreen committed rL366002: [ARM] MVE minnm and maxnm instructions.
[ARM] MVE minnm and maxnm instructions
Sat, Jul 13, 7:30 AM
dmgreen closed D63870: [ARM] MVE minnm and maxnm instructions.
Sat, Jul 13, 7:30 AM · Restricted Project

Fri, Jul 12

dmgreen added inline comments to D64621: [ARM] Make sure that the constant pool does not keep in the middle of an IT block..
Fri, Jul 12, 9:56 AM · Restricted Project
dmgreen added a comment to D64621: [ARM] Make sure that the constant pool does not keep in the middle of an IT block..

Hello. Can you add some more context? It makes the reviews easier to read.

Fri, Jul 12, 2:35 AM · Restricted Project

Tue, Jul 9

dmgreen accepted D64413: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present.

Other than a couple of test nits, LGTM.

Tue, Jul 9, 11:40 AM · Restricted Project
dmgreen added inline comments to D64413: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present.
Tue, Jul 9, 10:47 AM · Restricted Project
dmgreen added a parent revision for D64212: [ARM] MVE Vector Shifts: D64426: [ARM] Adjust how NEON shifts are lowered.
Tue, Jul 9, 10:35 AM · Restricted Project
dmgreen added a child revision for D64426: [ARM] Adjust how NEON shifts are lowered: D64212: [ARM] MVE Vector Shifts.
Tue, Jul 9, 10:35 AM · Restricted Project
dmgreen updated the diff for D64212: [ARM] MVE Vector Shifts.

Now sits on top of D64426, this just handles the MVE side of things.

Tue, Jul 9, 10:35 AM · Restricted Project
dmgreen retitled D64426: [ARM] Adjust how NEON shifts are lowered from [ARM] Adjust to [ARM] Adjust how NEON shifts are lowered.
Tue, Jul 9, 10:33 AM · Restricted Project
dmgreen created D64426: [ARM] Adjust how NEON shifts are lowered.
Tue, Jul 9, 10:31 AM · Restricted Project
dmgreen added a comment to D63870: [ARM] MVE minnm and maxnm instructions.

That test was added in rL365496, to show MVE codegen where no fp instructions are present. This case would be like that without any fpu, just with more __aeabi_fcmpgt and movne's. I think this at least shows the expansion is happening correctly (plus is sidesteps an issues with these being turned into selects, which are not handled yet).

Tue, Jul 9, 9:05 AM · Restricted Project
dmgreen committed rG781e3aff8c60: [ARM] Add test for MVE and no floats. NFC (authored by dmgreen).
[ARM] Add test for MVE and no floats. NFC
Tue, Jul 9, 7:47 AM
dmgreen committed rL365496: [ARM] Add test for MVE and no floats. NFC.
[ARM] Add test for MVE and no floats. NFC
Tue, Jul 9, 7:43 AM
dmgreen added a comment to D64212: [ARM] MVE Vector Shifts.

Sure, I can do that.

Tue, Jul 9, 7:13 AM · Restricted Project
dmgreen added inline comments to D63870: [ARM] MVE minnm and maxnm instructions.
Tue, Jul 9, 7:13 AM · Restricted Project
dmgreen updated the diff for D63870: [ARM] MVE minnm and maxnm instructions.

Updated tests

Tue, Jul 9, 3:19 AM · Restricted Project
dmgreen added inline comments to D64316: [ARM] MVE vector of 64bit types.
Tue, Jul 9, 3:07 AM · Restricted Project

Mon, Jul 8

dmgreen added a child revision for D64316: [ARM] MVE vector of 64bit types: D64323: [ARM] Sign_Extend_Inreg for MVE i1 types.
Mon, Jul 8, 4:07 AM · Restricted Project
dmgreen added a parent revision for D64323: [ARM] Sign_Extend_Inreg for MVE i1 types: D64316: [ARM] MVE vector of 64bit types.
Mon, Jul 8, 4:07 AM · Restricted Project
dmgreen created D64323: [ARM] Sign_Extend_Inreg for MVE i1 types.
Mon, Jul 8, 4:07 AM · Restricted Project
dmgreen updated the diff for D64316: [ARM] MVE vector of 64bit types.

Updates tests

Mon, Jul 8, 3:32 AM · Restricted Project
dmgreen added a parent revision for D64316: [ARM] MVE vector of 64bit types: D64212: [ARM] MVE Vector Shifts.
Mon, Jul 8, 2:34 AM · Restricted Project
dmgreen added a child revision for D64212: [ARM] MVE Vector Shifts: D64316: [ARM] MVE vector of 64bit types.
Mon, Jul 8, 2:34 AM · Restricted Project
dmgreen created D64316: [ARM] MVE vector of 64bit types.
Mon, Jul 8, 2:33 AM · Restricted Project

Fri, Jul 5

dmgreen committed rG47afdaa4872e: [ARM] MVE patterns for VMVN, VORR and VBIC (authored by dmgreen).
[ARM] MVE patterns for VMVN, VORR and VBIC
Fri, Jul 5, 8:22 AM
dmgreen committed rL365214: [ARM] MVE patterns for VMVN, VORR and VBIC.
[ARM] MVE patterns for VMVN, VORR and VBIC
Fri, Jul 5, 8:21 AM
dmgreen closed D63983: [ARM] MVE patterns for VMVN, VORR and VBIC.
Fri, Jul 5, 8:21 AM · Restricted Project
dmgreen committed rG25cf70509784: [ARM] MVE VMOV immediate handling (authored by dmgreen).
[ARM] MVE VMOV immediate handling
Fri, Jul 5, 3:05 AM
dmgreen committed rL365178: [ARM] MVE VMOV immediate handling.
[ARM] MVE VMOV immediate handling
Fri, Jul 5, 3:05 AM
dmgreen closed D63884: [ARM] MVE VMOV immediate handling.
Fri, Jul 5, 3:05 AM · Restricted Project
dmgreen committed rGbb7e97d783ef: [ARM] MVE fp to int conversions (authored by dmgreen).
[ARM] MVE fp to int conversions
Fri, Jul 5, 2:36 AM
dmgreen committed rL365176: [ARM] MVE fp to int conversions.
[ARM] MVE fp to int conversions
Fri, Jul 5, 2:35 AM
dmgreen closed D63729: [ARM] MVE fp to int conversions.
Fri, Jul 5, 2:35 AM · Restricted Project