Page MenuHomePhabricator

arsenm (Matt Arsenault)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 5 2012, 4:53 PM (538 w, 2 d)

Recent Activity

Today

arsenm added a comment to D142746: AMDGPU: Fold fneg into bitcast of build_vector.

ping

Sat, Apr 1, 3:35 AM · Restricted Project, Restricted Project

Yesterday

arsenm added a comment to D142907: LangRef: Add "dynamic" option to "denormal-fp-math".

ping

Fri, Mar 31, 3:23 PM · Restricted Project, Restricted Project
arsenm added inline comments to D146737: [AMDGPU] Default component broadcast store.
Fri, Mar 31, 3:16 PM · Restricted Project, Restricted Project
arsenm accepted D146031: [AMDGPU] Add MMOs for GFX11 Streamout Instructions.
Fri, Mar 31, 2:58 PM · Restricted Project, Restricted Project
arsenm added inline comments to D146823: [GVN] Avoid replacing uniforms with non-uniforms in propagateEquality.
Fri, Mar 31, 2:35 PM · Restricted Project, Restricted Project
arsenm added inline comments to D147154: [AMDGPU][GlobalISel] Add codegen support for S_INDIRECT_REG_WRITE_MOVREL_B32_V[9|10|11|12].
Fri, Mar 31, 2:28 PM · Restricted Project, Restricted Project
arsenm added inline comments to D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..
Fri, Mar 31, 2:24 PM · Restricted Project, Restricted Project
arsenm added inline comments to D139907: [FuzzMutate] RandomIRBuilder has more source and sink type now..
Fri, Mar 31, 2:08 PM · Restricted Project, Restricted Project
arsenm added inline comments to D147143: Add backend support for new PAL ELF Metadata 3.0.
Fri, Mar 31, 2:03 PM · Restricted Project, Restricted Project
arsenm accepted D139894: [FuzzMutate] introduce vector operations, select and fneg into InstInjectorStrategy.
Fri, Mar 31, 1:57 PM · Restricted Project, Restricted Project
arsenm added a comment to D147168: [WIP] Introduce SIInstrWorklist to process instructions in moveToVALU.

I guess this is one way to do it

Fri, Mar 31, 1:39 PM · Restricted Project, Restricted Project
arsenm added a comment to D147348: [MergedLoadStoreMotion] Merge stores with conflicting value types.

Also test pointers with different address spaces

Fri, Mar 31, 12:33 PM · Restricted Project, Restricted Project
arsenm added inline comments to D144518: Preserve the address space for llvm.used and llvm.compiler.used global variables in GlobalOpt pass..
Fri, Mar 31, 12:07 PM · Restricted Project, Restricted Project
arsenm added a comment to D147245: [AMDGPU] Make amdgcn.s.buffer.load a memory-reading intrinsic.

I had a quick look at some codegen differences this caused in Vulkan shaders compiled by LLPC. The biggest difference was that the DAG nodes for scalar loads now have a chain operand, which has a big effect on DAG scheduling.

Fri, Mar 31, 8:15 AM · Restricted Project, Restricted Project
arsenm added a comment to D147245: [AMDGPU] Make amdgcn.s.buffer.load a memory-reading intrinsic.

Mesa sets "invariant.load" metadata on all "s.buffer.load" call sites. There are no pointers, only descriptors. Is that sufficient to get the readnone behavior?

Fri, Mar 31, 8:15 AM · Restricted Project, Restricted Project
arsenm added a comment to D146762: [Verifier] Ban GEP, load, store of addrspace(8) on AMDGPU.

I wasn't sure if the general IR verifier is the absolute best place, but it already has calling-convention specific checks, which, at least in our case, are target specific.

Fri, Mar 31, 8:10 AM · Restricted Project, Restricted Project
arsenm added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Fri, Mar 31, 7:55 AM · Restricted Project, Restricted Project
arsenm added a comment to D145329: AMDGPU: Always split blocks for si_end_cf.

Yes, what I'm thinking of as a clean story would require changing the register allocator a little.

Fri, Mar 31, 6:30 AM · Restricted Project, Restricted Project
arsenm added a comment to D146762: [Verifier] Ban GEP, load, store of addrspace(8) on AMDGPU.

We don't have any real target specific verifier checks like this now. I do think we need some kind of target IR verifier, but just dropping this in like this is probably not the way to go about it

Fri, Mar 31, 6:24 AM · Restricted Project, Restricted Project
arsenm accepted D147242: [AMDGPU] Don't bother to use OffsetMode to define Real SMEM instructions.
Fri, Mar 31, 6:21 AM · Restricted Project, Restricted Project
arsenm accepted D147158: [AMDGPU] Do not reserve 16-bit registers.
Fri, Mar 31, 6:19 AM · Restricted Project, Restricted Project

Thu, Mar 30

arsenm abandoned D87543: AMDGPU: Always split si_end_cf blocks.

New version at D145329

Thu, Mar 30, 7:13 PM · Restricted Project, Restricted Project
arsenm added a comment to D146955: [Xtensa] Implement volatile load/store..

Missing tests

Thu, Mar 30, 12:00 PM · Restricted Project, Restricted Project
arsenm added inline comments to D146914: Migrate `IIT_Info` into `Intrinsics.td`.
Thu, Mar 30, 11:58 AM · Restricted Project, Restricted Project
arsenm accepted D145937: Replace `IntrinsicEmitter::ComputeFixedEncoding()` and cleanup.
Thu, Mar 30, 11:54 AM · Restricted Project, Restricted Project
arsenm added inline comments to D146915: Implement TypeSig generator in `Intrinsics.td`.
Thu, Mar 30, 11:44 AM · Restricted Project, Restricted Project
arsenm added inline comments to D146914: Migrate `IIT_Info` into `Intrinsics.td`.
Thu, Mar 30, 11:39 AM · Restricted Project, Restricted Project
arsenm added inline comments to D145872: TableGen: Let expressions available to list subscripts and list slices.
Thu, Mar 30, 11:32 AM · Restricted Project, Restricted Project
arsenm accepted D145873: Move definitions of ArgKind from Intrinsics.h to Intrinsics.td.

LGTM. I"m assuming the other diffs somehow make this worthwhile since currently there's only 5 values

Thu, Mar 30, 11:28 AM · Restricted Project, Restricted Project
arsenm accepted D145874: TableGen: Let getAllDerivedDefinitions() numeric order..

LGTM. I would assume this is the ordering anonymous records would get and it shouldn't really matter

Thu, Mar 30, 11:18 AM · Restricted Project, Restricted Project
arsenm added inline comments to D145871: TableGen: Introduce `!range` operator for half-opened interval.
Thu, Mar 30, 11:13 AM · Restricted Project, Restricted Project
arsenm added inline comments to D146906: Generate `MachineValueType.h` (partially) from `ValueTypes.td`.
Thu, Mar 30, 11:10 AM · Restricted Project, Restricted Project
arsenm added a reviewer for D147245: [AMDGPU] Make amdgcn.s.buffer.load a memory-reading intrinsic: mareko.
Thu, Mar 30, 11:00 AM · Restricted Project, Restricted Project
arsenm abandoned D63420: AMDGPU: Fix s.buffer.load being marked as readnone.

Obsoleted by D147245

Thu, Mar 30, 10:59 AM · Restricted Project
arsenm added inline comments to D139894: [FuzzMutate] introduce vector operations, select and fneg into InstInjectorStrategy.
Thu, Mar 30, 10:57 AM · Restricted Project, Restricted Project
arsenm accepted D147167: [TwoAddressInstruction] Improve tests for register killed by instruction.

LGTM. Seems like an error in the kill flag insertion

Thu, Mar 30, 10:52 AM · Restricted Project, Restricted Project
arsenm added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Thu, Mar 30, 10:45 AM · Restricted Project, Restricted Project
arsenm added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Thu, Mar 30, 10:43 AM · Restricted Project, Restricted Project
arsenm added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Thu, Mar 30, 10:39 AM · Restricted Project, Restricted Project
arsenm added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Thu, Mar 30, 10:36 AM · Restricted Project, Restricted Project
arsenm added a comment to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

I think we need to have LiveRangeEdit start doing the same thing. I guess we can start with this in a separate pass for now, and then I can look into merge it into LiveRangeEdit. One of the problems I'm trying to solve is tuple spills increasing liveness for dead lanes

Thu, Mar 30, 10:34 AM · Restricted Project, Restricted Project
arsenm accepted D147127: [TableGen] Enable "Type set is empty for each HW mode" error in non-debug builds.
Thu, Mar 30, 9:47 AM · Restricted Project, Restricted Project
arsenm added inline comments to D144233: [amdgpu] Implement dynamic LDS accesses from non-kernel functions.
Thu, Mar 30, 6:21 AM · Restricted Project, Restricted Project
arsenm added a comment to D147096: AMDGPU: Created a sub-register class for the return address operand in the tail call return instruction.

What will happen to getMinimalPhysRegClass query for SGPR_64 registers?
If this returns the new register class, ccr_sgpr_64, that's not the desired behavior.

getMinimalPhysRegClass should always return the minimal physical register class. I think CCR_SGPR_64
has all the properties of SGPR_64, so we won't have any issue for the (srcReg, RC) pair.

Thu, Mar 30, 5:49 AM · Restricted Project, Restricted Project
arsenm requested changes to D147031: [MachineCopy] Enhance sub register machine copy propagation.
Thu, Mar 30, 4:04 AM · Restricted Project, Restricted Project
arsenm added a comment to D146940: [Analysis] Deprecate (Legacy)DivergenceAnalysis.

I'd also rather just delete it now - especially because there's no reason not to use UA, but I thought deprecation was a mandatory step.

Thu, Mar 30, 3:54 AM · Restricted Project, Restricted Project

Wed, Mar 29

arsenm added inline comments to D147127: [TableGen] Enable "Type set is empty for each HW mode" error in non-debug builds.
Wed, Mar 29, 4:21 AM · Restricted Project, Restricted Project

Tue, Mar 28

arsenm accepted D147096: AMDGPU: Created a sub-register class for the return address operand in the tail call return instruction.

Description is imprecise. It's a subclass, not a subregister class.

Tue, Mar 28, 6:55 PM · Restricted Project, Restricted Project
arsenm updated the diff for D147072: InlineSpiller: Consider copy bundles when looking for snippet copies.
Tue, Mar 28, 3:34 PM · Restricted Project, Restricted Project
arsenm requested review of D147079: InlineSpiller: Consider if all subranges are the same when avoiding redundant spills.
Tue, Mar 28, 1:46 PM · Restricted Project, Restricted Project
arsenm added a comment to D147022: inline global alias.

I thought calls to aliases were generally folded to direct calls at some point, so is there just an ordering issue?

Tue, Mar 28, 11:44 AM · Restricted Project, Restricted Project
arsenm requested review of D147072: InlineSpiller: Consider copy bundles when looking for snippet copies.
Tue, Mar 28, 11:39 AM · Restricted Project, Restricted Project
arsenm accepted D146225: [AMDGPU] Handle memset users in PromoteAlloca.
Tue, Mar 28, 5:28 AM · Restricted Project, Restricted Project

Mon, Mar 27

arsenm accepted D146930: [MCP] Do not try forward non-existent sub-register of a copy.
Mon, Mar 27, 7:49 PM · Restricted Project, Restricted Project
arsenm added inline comments to D145315: AMDGPU: Fix missing MIR serialization for PSInputAddr/PSInputEnable.
Mon, Mar 27, 5:16 PM · Restricted Project, Restricted Project
arsenm added inline comments to D146179: ValueTypes.td: Reorganize ValueType to generate `MachineValueType.h`.
Mon, Mar 27, 9:23 AM · Restricted Project, Restricted Project
arsenm added inline comments to D145586: [AMDGPU] Tweak PromoteAlloca limits.
Mon, Mar 27, 5:34 AM · Restricted Project, Restricted Project
arsenm added inline comments to D146225: [AMDGPU] Handle memset users in PromoteAlloca.
Mon, Mar 27, 5:26 AM · Restricted Project, Restricted Project

Sun, Mar 26

arsenm added a comment to D145315: AMDGPU: Fix missing MIR serialization for PSInputAddr/PSInputEnable.

ping

Sun, Mar 26, 6:40 AM · Restricted Project, Restricted Project
arsenm added a comment to D145252: RegAllocFast: Fix dropping subreg indexes on unassigned subreg defs.

ping

Sun, Mar 26, 6:40 AM · Restricted Project, Restricted Project
arsenm committed rGf5f752ebfdfe: AMDGPU: Convert test to generated checks (authored by arsenm).
AMDGPU: Convert test to generated checks
Sun, Mar 26, 6:35 AM · Restricted Project, Restricted Project
arsenm committed rG051112a3c55a: AMDGPU: Add baseline test for SWDEV-380865 (authored by arsenm).
AMDGPU: Add baseline test for SWDEV-380865
Sun, Mar 26, 6:35 AM · Restricted Project, Restricted Project
arsenm committed rG3b44109b71a1: InstCombine: Introduce new is.fpclass from logic of fcmp (authored by arsenm).
InstCombine: Introduce new is.fpclass from logic of fcmp
Sun, Mar 26, 6:35 AM · Restricted Project, Restricted Project
arsenm closed D146171: InstCombine: Introduce new is.fpclass from logic of fcmp.

3b44109b71a17abb087cfb0ee1a4fd0b7d5096a5

Sun, Mar 26, 6:34 AM · Restricted Project, Restricted Project

Fri, Mar 24

arsenm accepted D141355: [AMDGPUUnifyDivergentExitNodes] Add NewPM support.
Fri, Mar 24, 7:21 PM · Restricted Project, Restricted Project
arsenm requested review of D146859: RegAllocGreedy: Fix detection of lanes read by a bundle.
Fri, Mar 24, 6:40 PM · Restricted Project, Restricted Project
arsenm accepted D146775: [amdgpu] Fix broken error detection in LDS lowering.
Fri, Mar 24, 5:17 PM · Restricted Project, Restricted Project
arsenm added inline comments to D146845: [FPEnv] [WIP] Verify strictfp attribute correctness, first part, 2023 edition.
Fri, Mar 24, 4:37 PM · Restricted Project, Restricted Project
arsenm added inline comments to D146845: [FPEnv] [WIP] Verify strictfp attribute correctness, first part, 2023 edition.
Fri, Mar 24, 4:33 PM · Restricted Project, Restricted Project
arsenm added a comment to D144590: [Clang][OpenMP] Fix shared memory allocation on AMDGPU.

I wanted to follow up on this. Is anything additional needed from me?

Fri, Mar 24, 2:00 PM · Restricted Project, Restricted Project
arsenm added inline comments to D141355: [AMDGPUUnifyDivergentExitNodes] Add NewPM support.
Fri, Mar 24, 1:17 PM · Restricted Project, Restricted Project
arsenm accepted D146720: [AMDGPU][printf] Run AMDGPUPrintfRuntimeBindingPass in -O0.

LGTM with test nit

Fri, Mar 24, 8:44 AM · Restricted Project, Restricted Project
arsenm added inline comments to D146737: [AMDGPU] Default component broadcast store.
Fri, Mar 24, 7:56 AM · Restricted Project, Restricted Project
arsenm accepted D146800: [TableGen][GlobalISel] Support EXTRACT_SUBREGs for ComplexPattern suboperands..
Fri, Mar 24, 5:53 AM · Restricted Project, Restricted Project
arsenm added inline comments to D146720: [AMDGPU][printf] Run AMDGPUPrintfRuntimeBindingPass in -O0.
Fri, Mar 24, 4:36 AM · Restricted Project, Restricted Project

Thu, Mar 23

arsenm added a reviewer for D146701: [AMDGPU] Create Subtarget Features for some of 16 bits atomic fadd instructions: gandhi21299.
Thu, Mar 23, 1:04 PM · Restricted Project, Restricted Project, Restricted Project
arsenm accepted D146720: [AMDGPU][printf] Run AMDGPUPrintfRuntimeBindingPass in -O0.

LGTM, thanks I noticed this when I was fixing printf recently but forgot to fix this part

Thu, Mar 23, 9:48 AM · Restricted Project, Restricted Project

Tue, Mar 21

arsenm added a comment to D145290: [OpenMP] Ensure memory fences are created with barriers for AMDGPUs.

LGTM but Matt's the expert here

Tue, Mar 21, 11:48 AM · Restricted Project, Restricted Project

Mon, Mar 20

arsenm added a comment to D146467: [MachineInstr] make getCalledFunction method of MachineInstr.

It's a sketchy function to begin with, making a lot of assumptions about what a call looks like.

Mon, Mar 20, 4:05 PM · Restricted Project, Restricted Project
arsenm added a comment to D142907: LangRef: Add "dynamic" option to "denormal-fp-math".

ping

Mon, Mar 20, 4:13 AM · Restricted Project, Restricted Project

Sat, Mar 18

arsenm accepted D146353: [AMDGPU] Add release note for ommited barrier waitcnt.
Sat, Mar 18, 10:54 AM · Restricted Project, Restricted Project

Fri, Mar 17

arsenm accepted D146334: [MLIR] Do not hardcode attribute indexes in intrinsic decls.
Fri, Mar 17, 2:55 PM · Restricted Project, Restricted Project
arsenm committed rGc98b2e20c949: LiveRangeEdit: Use Register (authored by arsenm).
LiveRangeEdit: Use Register
Fri, Mar 17, 2:35 PM · Restricted Project, Restricted Project
arsenm added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Fri, Mar 17, 1:48 PM · Restricted Project, Restricted Project
arsenm committed rGce6c36bab549: RegAllocGreedy: Don't use Register reference (authored by arsenm).
RegAllocGreedy: Don't use Register reference
Fri, Mar 17, 12:25 PM · Restricted Project, Restricted Project
arsenm committed rG33260cf2c547: Intrinsics: Make vector reduce intrinsics speculatable (authored by arsenm).
Intrinsics: Make vector reduce intrinsics speculatable
Fri, Mar 17, 12:21 PM · Restricted Project, Restricted Project
arsenm added reviewers for D146119: [llvm-readobj][AMDGPU] Bypass MD verification for PAL: dstuttard, foad, tpr.
Fri, Mar 17, 12:16 PM · Restricted Project, Restricted Project
arsenm added inline comments to D142782: [AMDGPU] Add basic support for extended i8 perm matching.
Fri, Mar 17, 11:24 AM · Restricted Project, Restricted Project
arsenm added a comment to D142782: [AMDGPU] Add basic support for extended i8 perm matching.

Should ByteProvider really be BitProvider?

Fri, Mar 17, 11:21 AM · Restricted Project, Restricted Project
arsenm accepted D146313: [AMDGPU] Simplify SMEM Real instruction definitions. NFC..
Fri, Mar 17, 11:04 AM · Restricted Project, Restricted Project
arsenm added inline comments to D143018: [DAGCombiner][NFC] Factor out ByteProvider.
Fri, Mar 17, 9:46 AM · Restricted Project, Restricted Project
arsenm added a comment to D145586: [AMDGPU] Tweak PromoteAlloca limits.

Unrelated but PromoteAllocaToVectorLimit should really move to a new PM pass parameter

Fri, Mar 17, 9:42 AM · Restricted Project, Restricted Project
arsenm closed D146170: InstCombine: Fold is.fpclass for single infinity to fcmp.

ec2234a21a5dbffcc7b8eb0996e3aba288a4009a

Fri, Mar 17, 8:53 AM · Restricted Project, Restricted Project
arsenm committed rGec2234a21a5d: InstCombine: Fold is.fpclass for single infinity to fcmp (authored by arsenm).
InstCombine: Fold is.fpclass for single infinity to fcmp
Fri, Mar 17, 8:52 AM · Restricted Project, Restricted Project
arsenm committed rG80512789b6de: InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0 (authored by arsenm).
InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0
Fri, Mar 17, 8:43 AM · Restricted Project, Restricted Project
arsenm added a reverting change for rGb5ff7640cd13: InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0: rG2726fd2e8cb7: Revert "InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0".
Fri, Mar 17, 8:43 AM · Restricted Project, Restricted Project
arsenm added a comment to D146142: InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0.
Fri, Mar 17, 8:43 AM · Restricted Project, Restricted Project
arsenm committed rG2726fd2e8cb7: Revert "InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0" (authored by arsenm).
Revert "InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0"
Fri, Mar 17, 8:43 AM · Restricted Project, Restricted Project
arsenm committed rGb5ff7640cd13: InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0 (authored by arsenm).
InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0
Fri, Mar 17, 8:30 AM · Restricted Project, Restricted Project
arsenm committed rG9356ec1516ca: CodeGen: Reorder case handling for is.fpclass legalization (authored by arsenm).
CodeGen: Reorder case handling for is.fpclass legalization
Fri, Mar 17, 8:30 AM · Restricted Project, Restricted Project