Page MenuHomePhabricator
People arsenm

arsenm (Matt Arsenault)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 5 2012, 4:53 PM (371 w, 4 d)

Recent Activity
View All

Today

arsenm added a comment to D65238: AMDGPU/GlobalISel: Select llvm.amdgcn.raw.buffer.store.

ping

Mon, Jan 20, 5:03 AM
arsenm added a comment to D72605: AMDGPU: Directly select 16-bank LDS case of llvm.amdgcn.interp.p1.f16.

ping

Mon, Jan 20, 5:03 AM · Restricted Project
arsenm created D73033: AMDGPU: Cleanup and generate 64-bit div tests.
Mon, Jan 20, 4:54 AM · Restricted Project
arsenm added a comment to D72185: AMDGPU: Partially merge indirect register write handling.

ping

Mon, Jan 20, 4:44 AM · Restricted Project
arsenm added a comment to D72187: AMDGPU: Prepare to use scalar register indexing.

ping

Mon, Jan 20, 4:44 AM · Restricted Project
arsenm added a comment to D64862: AMDGPU/GlobalISel: RegBankSelect interp intrinsics.

ping

Mon, Jan 20, 4:35 AM · Restricted Project
arsenm added a comment to D72601: GlobalISel: Lower G_WRITE_REGISTER.

ping

Mon, Jan 20, 4:35 AM · Restricted Project
arsenm created D73031: GlobalISel: Lower s64->s16 G_FPTRUNC.
Mon, Jan 20, 4:35 AM · Restricted Project
arsenm created D73030: GlobalISel: Assume G_INTRINSIC* are convergent.
Mon, Jan 20, 4:35 AM · Restricted Project
arsenm added a comment to D72604: AMDGPU: Fix missing immarg on llvm.amdgcn.interp.mov.

ping

Mon, Jan 20, 4:35 AM · Restricted Project

Yesterday

arsenm added inline comments to D65440: GlobalISel: Add widenScalar for G_UNMERGE_VALUES sources.
Sun, Jan 19, 5:41 PM
arsenm updated the diff for D73008: AMDGPU: Do binop of select of constant fold in AMDGPUCodeGenPrepare.

Preserve FMF

Sun, Jan 19, 1:51 PM · Restricted Project
arsenm created D73009: AMDGPU: Don't create weird sized integers.
Sun, Jan 19, 1:17 PM · Restricted Project
arsenm created D73008: AMDGPU: Do binop of select of constant fold in AMDGPUCodeGenPrepare.
Sun, Jan 19, 1:15 PM · Restricted Project
arsenm added a comment to D72991: AMDGPU/R600: Emit rodata in text segment.

Needs test

Sun, Jan 19, 6:58 AM · Restricted Project

Sat, Jan 18

arsenm added a comment to D72941: Handle ptrtoint in InferAddressSpace.
In D72941#1828007, @hliao wrote:

inttoptr and ptrtoint should be treated as opaque ones. If needed, they should be handled with target-specific. This pass is definitely not the place to handle them.

In D72941#1827075, @gangche1 wrote:

We see in our IR that has addrspacecast before ptrtoint, which requires this optimization. Therefore suggest to add the handling of ptrtoint.

Sat, Jan 18, 6:53 AM · Restricted Project

Fri, Jan 17

arsenm updated the diff for D72260: AMDGPU/GlobalISel: Add pre-legalize combiner pass.

Formatting

Fri, Jan 17, 6:01 PM · Restricted Project
arsenm added inline comments to D72260: AMDGPU/GlobalISel: Add pre-legalize combiner pass.
Fri, Jan 17, 6:01 PM · Restricted Project
arsenm committed rGdf7900e21824: TableGen/GlobalISel: Don't check exact intrinsic opcode value (authored by arsenm).
TableGen/GlobalISel: Don't check exact intrinsic opcode value
Fri, Jan 17, 5:15 PM
arsenm committed rGa4451d88ee45: Consolidate internal denormal flushing controls (authored by arsenm).
Consolidate internal denormal flushing controls
Fri, Jan 17, 5:15 PM
arsenm committed rG592de0009f64: AMDGPU/GlobalISel: Select llvm.amdgcn.update.dpp (authored by arsenm).
AMDGPU/GlobalISel: Select llvm.amdgcn.update.dpp
Fri, Jan 17, 5:15 PM
arsenm committed rGec9628318d79: AMDGPU/GlobalISel: Select DS append/consume (authored by arsenm).
AMDGPU/GlobalISel: Select DS append/consume
Fri, Jan 17, 5:14 PM
arsenm closed D69878: Consoldiate internal denormal flushing controls.

a4451d88ee456304c26d552749aea6a7f5154bde

Fri, Jan 17, 5:14 PM · Restricted Project
arsenm closed D72918: AMDGPU/GlobalISel: Select DS append/consume.

ec9628318d797bfe036aca314d58665dd93b364f

Fri, Jan 17, 5:14 PM · Restricted Project
arsenm closed D72925: AMDGPU/GlobalISel: Select llvm.amdgcn.update.dpp.

592de0009f6482fbf033ef87d147aab13fcce78c

Fri, Jan 17, 5:14 PM · Restricted Project
arsenm added a comment to rG03a592f18ba5: TableGen/GlobalISel: Fix srcvalue inputs.
In rG03a592f18ba57d52a65e70ad5e1dd709cdcfb71d#885551, @alanphipps wrote:

Hello! Your test specifically looks for "248", which is failing with my downstream embedded ARM compiler (we produce "249"); other similar tests that I've looked at simply ignore this value. Is there a reason why you need to check it specifically?

No, that can be anything.

Fri, Jan 17, 4:55 PM
arsenm updated the diff for D72620: AMDGPU/GlobalISel: Add documentation for RegisterBankInfo.

Fix typos

Fri, Jan 17, 4:08 PM · Restricted Project
arsenm created D72964: AMDGPU: Fix interaction of tfe and d16.
Fri, Jan 17, 3:58 PM · Restricted Project
arsenm requested changes to D72941: Handle ptrtoint in InferAddressSpace.

This is incorrect and assumes the address spaces have equivalent bit representations

Fri, Jan 17, 11:30 AM · Restricted Project
arsenm updated the diff for D72931: AMDGPU: Add a16 feature to gfx10.
Fri, Jan 17, 10:03 AM · Restricted Project
arsenm created D72931: AMDGPU: Add a16 feature to gfx10.
Fri, Jan 17, 9:05 AM · Restricted Project
arsenm committed rG886f9071c638: AMDGPU: Don't assert on a16 images on targets without FeatureR128A16 (authored by arsenm).
AMDGPU: Don't assert on a16 images on targets without FeatureR128A16
Fri, Jan 17, 8:15 AM
arsenm closed D72866: AMDGPU: Don't assert on a16 images on targets without FeatureR128A16.
In D72866#1824983, @rampitec wrote:

I think we need to add FeatureR128A16 to GFX10. ISA spec says it does support it.

Fri, Jan 17, 8:15 AM · Restricted Project
arsenm added inline comments to D71785: [InstCombine][AMDGPU] Trim components of s_buffer_load.
Fri, Jan 17, 8:05 AM · Restricted Project
arsenm created D72927: AMDGPU/GlobalISel: Select llvm.amdgcn.mov.dpp.
Fri, Jan 17, 8:05 AM · Restricted Project
arsenm created D72925: AMDGPU/GlobalISel: Select llvm.amdgcn.update.dpp.
Fri, Jan 17, 7:55 AM · Restricted Project
arsenm created D72922: AMDGPU/GlobalISel: Select wqm, softwqm and wwm intrinsics.
Fri, Jan 17, 6:49 AM · Restricted Project
arsenm created D72918: AMDGPU/GlobalISel: Select DS append/consume.
Fri, Jan 17, 6:11 AM · Restricted Project

Thu, Jan 16

arsenm committed rG117d4f1900c0: AMDGPU: Add register classes to MUBUF load patterns (authored by arsenm).
AMDGPU: Add register classes to MUBUF load patterns
Thu, Jan 16, 7:13 PM
arsenm added inline comments to D69878: Consoldiate internal denormal flushing controls.
Thu, Jan 16, 5:47 PM · Restricted Project
arsenm updated the diff for D69878: Consoldiate internal denormal flushing controls.

Forgot clang parts

Thu, Jan 16, 5:37 PM · Restricted Project
arsenm accepted D72865: [AMDGPU] allow multi-dword flat scratch access since GFX9.
Thu, Jan 16, 5:28 PM · Restricted Project
arsenm committed rG9b549f26fab6: AMDGPU: Update clang test (authored by arsenm).
AMDGPU: Update clang test
Thu, Jan 16, 3:15 PM
arsenm committed rG3ef8cdf6660f: AMDGPU: Do permlane16 vdst_in discard optimization in InstCombine (authored by arsenm).
AMDGPU: Do permlane16 vdst_in discard optimization in InstCombine
Thu, Jan 16, 2:34 PM
arsenm committed rG91e758b7329b: AMDGPU: Move permlane discard vdst_in optimization (authored by arsenm).
AMDGPU: Move permlane discard vdst_in optimization
Thu, Jan 16, 2:34 PM
arsenm closed D72844: AMDGPU: Move permlane discard vdst_in optimization.

91e758b7329b4ff134684e661af93a85c436a460

Thu, Jan 16, 2:34 PM · Restricted Project
arsenm closed D72845: AMDGPU: Do permlane16 vdst_in discard optimization in InstCombine.

3ef8cdf6660fc20baeb09eae5008b741f178b624

Thu, Jan 16, 2:34 PM · Restricted Project
arsenm added a comment to D72865: [AMDGPU] allow multi-dword flat scratch access since GFX9.

This also needs to be reproduce for globalisel

Thu, Jan 16, 12:56 PM · Restricted Project
arsenm created D72866: AMDGPU: Don't assert on a16 images on targets without FeatureR128A16.
Thu, Jan 16, 12:49 PM · Restricted Project
arsenm added inline comments to D72844: AMDGPU: Move permlane discard vdst_in optimization.
Thu, Jan 16, 12:27 PM · Restricted Project
arsenm committed rGf5d98543b89e: AMDGPU: Remove outdated comment (authored by arsenm).
AMDGPU: Remove outdated comment
Thu, Jan 16, 11:59 AM
arsenm closed D72512: GlobalISel: Move extension scalar narrowing to separate function.

be31a7b7eec8ed7c033f3087dd88e8fd685c3ded

Thu, Jan 16, 11:49 AM · Restricted Project
arsenm closed D72609: AMDGPU/GlobalISel: Improve lowering of G_SEXT_INREG.

e12b840abfcde8ec02062fa7600348ad4623d049

Thu, Jan 16, 11:49 AM · Restricted Project
arsenm closed D72608: GlobalISel: Don't ignore requested ext narrowing type.

a66d2817ca9e1dd72674627b18aec80d077910f0

Thu, Jan 16, 11:49 AM · Restricted Project
arsenm committed rG8945b23af590: AMDGPU: Update more tests to use modern buffer intrinsics (authored by arsenm).
AMDGPU: Update more tests to use modern buffer intrinsics
Thu, Jan 16, 11:30 AM
arsenm committed rGe12b840abfcd: AMDGPU/GlobalISel: Improve lowering of G_SEXT_INREG (authored by arsenm).
AMDGPU/GlobalISel: Improve lowering of G_SEXT_INREG
Thu, Jan 16, 11:30 AM
arsenm committed rGbe31a7b7eec8: GlobalISel: Move extension scalar narrowing to separate function (authored by arsenm).
GlobalISel: Move extension scalar narrowing to separate function
Thu, Jan 16, 11:30 AM
arsenm committed rGa66d2817ca9e: GlobalISel: Don't ignore requested ext narrowing type (authored by arsenm).
GlobalISel: Don't ignore requested ext narrowing type
Thu, Jan 16, 11:30 AM
arsenm closed D72603: GlobalISel: Apply target MMO flags to atomics.

d0943537e10e25281164bb27df843e283dc6666c

Thu, Jan 16, 11:01 AM · Restricted Project
arsenm closed D72851: TableGen/GlobalISel: Fix srcvalue inputs.

03a592f18ba57d52a65e70ad5e1dd709cdcfb71d

Thu, Jan 16, 11:01 AM · Restricted Project
arsenm closed D72599: GlobalISel: Preserve load/store metadata in IRTranslator.

0d0fce42b0ea7c7ce18cd0191f95204a0b800b15

Thu, Jan 16, 11:01 AM · Restricted Project
arsenm committed rGde4f88df97cb: AMDGPU: Remove IR section from MIR test (authored by arsenm).
AMDGPU: Remove IR section from MIR test
Thu, Jan 16, 10:52 AM
arsenm committed rGd0943537e10e: GlobalISel: Apply target MMO flags to atomics (authored by arsenm).
GlobalISel: Apply target MMO flags to atomics
Thu, Jan 16, 10:52 AM
arsenm committed rG0d0fce42b0ea: GlobalISel: Preserve load/store metadata in IRTranslator (authored by arsenm).
GlobalISel: Preserve load/store metadata in IRTranslator
Thu, Jan 16, 10:52 AM
arsenm committed rG03a592f18ba5: TableGen/GlobalISel: Fix srcvalue inputs (authored by arsenm).
TableGen/GlobalISel: Fix srcvalue inputs
Thu, Jan 16, 10:51 AM
arsenm committed rG20ca49b646b7: AMDGPU: Update tests to use modern buffer intrinsics (authored by arsenm).
AMDGPU: Update tests to use modern buffer intrinsics
Thu, Jan 16, 10:51 AM
arsenm committed rG86d14ed766eb: TableGen: Remove dead code (authored by arsenm).
TableGen: Remove dead code
Thu, Jan 16, 10:51 AM
arsenm committed rG4ca1ad85b7c8: AMDGPU/GlobalISel: Don't handle legacy buffer intrinsic (authored by arsenm).
AMDGPU/GlobalISel: Don't handle legacy buffer intrinsic
Thu, Jan 16, 8:38 AM
arsenm committed rG9b2f3532c7ff: AMDGPU/GlobalISel: Select DS GWS intrinsics (authored by arsenm).
AMDGPU/GlobalISel: Select DS GWS intrinsics
Thu, Jan 16, 8:29 AM
arsenm closed D72617: AMDGPU/GlobalISel: Select DS GWS intrinsics.

9b2f3532c7ffa664a004714731752733d914e2d4

Thu, Jan 16, 8:28 AM · Restricted Project
arsenm accepted D72853: [GlobalISel] Don't arbitrarily limit a mask to 64 bits.

LGTM. It would be possible to write a test for this, but I doubt any target is going to want to widen beyond 64 bits

Thu, Jan 16, 8:09 AM · Restricted Project
arsenm added a child revision for D72844: AMDGPU: Move permlane discard vdst_in optimization: D72852: AMDGPU/GlobalISel: Select permlane16/permlanex16.
Thu, Jan 16, 7:59 AM · Restricted Project
arsenm added parent revisions for D72852: AMDGPU/GlobalISel: Select permlane16/permlanex16: D72844: AMDGPU: Move permlane discard vdst_in optimization, D72851: TableGen/GlobalISel: Fix srcvalue inputs.
Thu, Jan 16, 7:59 AM · Restricted Project
arsenm added a child revision for D72851: TableGen/GlobalISel: Fix srcvalue inputs: D72852: AMDGPU/GlobalISel: Select permlane16/permlanex16.
Thu, Jan 16, 7:59 AM · Restricted Project
arsenm created D72852: AMDGPU/GlobalISel: Select permlane16/permlanex16.
Thu, Jan 16, 7:59 AM · Restricted Project
arsenm created D72851: TableGen/GlobalISel: Fix srcvalue inputs.
Thu, Jan 16, 7:59 AM · Restricted Project
arsenm accepted D72849: [GlobalISel] Pass MachineOperands into MachineIRBuilder helper methods.
Thu, Jan 16, 7:59 AM · Restricted Project
arsenm accepted D72833: [GlobalISel] Use more MachineIRBuilder helper methods.

LGTM

Thu, Jan 16, 7:21 AM · Restricted Project
arsenm created D72845: AMDGPU: Do permlane16 vdst_in discard optimization in InstCombine.
Thu, Jan 16, 7:11 AM · Restricted Project
arsenm created D72844: AMDGPU: Move permlane discard vdst_in optimization.
Thu, Jan 16, 7:11 AM · Restricted Project
arsenm added inline comments to D72833: [GlobalISel] Use more MachineIRBuilder helper methods.
Thu, Jan 16, 6:33 AM · Restricted Project
arsenm added a reviewer for D72833: [GlobalISel] Use more MachineIRBuilder helper methods: aditya_nandakumar.
Thu, Jan 16, 6:33 AM · Restricted Project
arsenm added inline comments to D72833: [GlobalISel] Use more MachineIRBuilder helper methods.
Thu, Jan 16, 6:32 AM · Restricted Project
arsenm accepted D72833: [GlobalISel] Use more MachineIRBuilder helper methods.
Thu, Jan 16, 5:24 AM · Restricted Project

Wed, Jan 15

arsenm committed rGc378e52cb9d1: Set some fast math attributes in setFunctionAttributes (authored by arsenm).
Set some fast math attributes in setFunctionAttributes
Wed, Jan 15, 7:29 PM
arsenm closed D71258: Set some fast math attributes in setFunctionAttributes.

c378e52cb9d1197bd828008ffdeaf3cebdca1506

Wed, Jan 15, 7:29 PM · Restricted Project
arsenm closed D71256: llc: Don't overwrite frame-pointer attribute.

77eb1b8f63c120f90ba529a5da2d392e165a4bc4

Wed, Jan 15, 5:57 PM · Restricted Project
arsenm committed rG77eb1b8f63c1: llc: Don't overwrite frame-pointer attribute (authored by arsenm).
llc: Don't overwrite frame-pointer attribute
Wed, Jan 15, 5:57 PM
arsenm added inline comments to D72814: [AArch64][GlobalISel] Change G_FCONSTANTs feeding into stores into G_CONSTANTS.
Wed, Jan 15, 5:29 PM · Restricted Project
arsenm closed D71255: llc: Change behavior of -mattr with existing attribute.

67ec8744d7e72b50a5db5038c9643584ce57cb0c

Wed, Jan 15, 5:01 PM · Restricted Project
arsenm committed rG67ec8744d7e7: llc: Change behavior of -mattr with existing attribute (authored by arsenm).
llc: Change behavior of -mattr with existing attribute
Wed, Jan 15, 4:51 PM
arsenm accepted D65966: AMDGPU/SILoadStoreOptimizer: Improve merging of out of order offsets.

LGTM

Wed, Jan 15, 4:25 PM · Restricted Project
arsenm added a comment to D71258: Set some fast math attributes in setFunctionAttributes.
In D71258#1823070, @echristo wrote:

It'd be much nicer to get rid of resetTargetOptions here? Can we do that yet?

Wed, Jan 15, 4:06 PM · Restricted Project
arsenm accepted D72783: Process BUNDLE in tail duplication.
Wed, Jan 15, 3:44 PM · Restricted Project
arsenm added a comment to D71258: Set some fast math attributes in setFunctionAttributes.

ping

Wed, Jan 15, 3:39 PM · Restricted Project
arsenm committed rG711a17afaff2: AMDGPU/GlobalISel: Select exp with patterns (authored by arsenm).
AMDGPU/GlobalISel: Select exp with patterns
Wed, Jan 15, 3:34 PM
arsenm closed D72607: AMDGPU/GlobalISel: Select exp with patterns.

711a17afaff276f816aca5dc4a68fae4e17a2c12

Wed, Jan 15, 3:34 PM · Restricted Project
arsenm committed rGeef92f25ccf1: AMDGPU: Remove custom node for exports (authored by arsenm).
AMDGPU: Remove custom node for exports
Wed, Jan 15, 3:34 PM
arsenm closed D72511: GlobalISel: Handle more cases of G_SEXT narrowing.

25e9938a45e8dfde752a4e93c48ff0184d4784d9

Wed, Jan 15, 3:34 PM · Restricted Project
arsenm committed rG25e9938a45e8: GlobalISel: Handle more cases of G_SEXT narrowing (authored by arsenm).
GlobalISel: Handle more cases of G_SEXT narrowing
Wed, Jan 15, 3:34 PM