People sdesmalen

sdesmalen (Sander de Smalen)
User

Projects

User does not belong to any projects.

User Details

User Since: Oct 21 2016, 1:19 AM (78 w, 3 d)

Recent Activity
View All

Today

sdesmalen added inline comments to D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 8:53 AM

sdesmalen updated the summary of D45954: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:57 AM

sdesmalen updated the summary of D45957: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, scaled)) load instructions..

Mon, Apr 23, 6:57 AM

sdesmalen updated the summary of D45956: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:57 AM

sdesmalen updated the summary of D45952: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:57 AM

sdesmalen updated the summary of D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions..

Mon, Apr 23, 6:57 AM

sdesmalen updated the summary of D45955: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, scaled)) load instructions..

Mon, Apr 23, 6:57 AM

sdesmalen updated the summary of D45953: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, scaled)) load instructions..

Mon, Apr 23, 6:57 AM

sdesmalen updated the summary of D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 6:57 AM

sdesmalen added a dependent revision for D45954: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, unscaled)) load instructions.: D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions..

Mon, Apr 23, 6:53 AM

sdesmalen added a dependent revision for D45957: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, scaled)) load instructions.: D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions..

Mon, Apr 23, 6:53 AM

sdesmalen added a dependent revision for D45953: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, scaled)) load instructions.: D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions..

Mon, Apr 23, 6:53 AM

sdesmalen added dependencies for D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions.: D45952: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, unscaled)) load instructions., D45953: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, scaled)) load instructions., D45956: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, unscaled)) load instructions., D45955: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, scaled)) load instructions., D45954: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, unscaled)) load instructions., D45957: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, scaled)) load instructions..

Mon, Apr 23, 6:53 AM

sdesmalen added a dependent revision for D45955: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, scaled)) load instructions.: D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions..

Mon, Apr 23, 6:53 AM

sdesmalen added a dependent revision for D45956: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, unscaled)) load instructions.: D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions..

Mon, Apr 23, 6:53 AM

sdesmalen added a dependent revision for D45952: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, unscaled)) load instructions.: D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions..

Mon, Apr 23, 6:53 AM

sdesmalen added a dependency for D45957: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, scaled)) load instructions.: D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 6:53 AM

sdesmalen added a dependent revision for D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes.: D45957: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, scaled)) load instructions..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependency for D45956: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, unscaled)) load instructions.: D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependent revision for D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes.: D45956: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependency for D45955: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, scaled)) load instructions.: D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependent revision for D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes.: D45955: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, scaled)) load instructions..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependency for D45954: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, unscaled)) load instructions.: D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependent revision for D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes.: D45954: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependent revision for D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes.: D45953: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, scaled)) load instructions..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependency for D45953: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, scaled)) load instructions.: D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 6:52 AM

sdesmalen added a dependent revision for D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes.: D45952: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:51 AM

sdesmalen added a dependency for D45952: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, unscaled)) load instructions.: D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 6:51 AM

sdesmalen created D45958: [AArch64][SVE] Asm: Negative tests for all LD1 gather (scalar+vector) load instructions..

Mon, Apr 23, 6:51 AM

sdesmalen created D45955: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, scaled)) load instructions..

Mon, Apr 23, 6:51 AM

sdesmalen created D45956: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:51 AM

sdesmalen created D45957: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (packed 32bit elts, scaled)) load instructions..

Mon, Apr 23, 6:51 AM

sdesmalen created D45952: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:51 AM

sdesmalen created D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes..

Mon, Apr 23, 6:51 AM

sdesmalen created D45954: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (64bit elts, unscaled)) load instructions..

Mon, Apr 23, 6:51 AM

sdesmalen created D45953: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, scaled)) load instructions..

Mon, Apr 23, 6:51 AM

sdesmalen created D45946: [AArch64][SVE] Asm: Support for contiguous, first-faulting LDFF1 (scalar+scalar) load instructions..

Mon, Apr 23, 5:41 AM

Fri, Apr 20

sdesmalen added inline comments to D45880: [AArch64][SVE] Enable DiagnosticPredicates for SVE LD1 instructions..

Fri, Apr 20, 8:21 AM

sdesmalen updated the summary of D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate.

Fri, Apr 20, 6:35 AM

sdesmalen updated the summary of D45880: [AArch64][SVE] Enable DiagnosticPredicates for SVE LD1 instructions..

Fri, Apr 20, 6:35 AM

sdesmalen added a dependency for D45880: [AArch64][SVE] Enable DiagnosticPredicates for SVE LD1 instructions.: D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate.

Fri, Apr 20, 6:35 AM

sdesmalen added a dependent revision for D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate: D45880: [AArch64][SVE] Enable DiagnosticPredicates for SVE LD1 instructions..

Fri, Apr 20, 6:34 AM

sdesmalen created D45880: [AArch64][SVE] Enable DiagnosticPredicates for SVE LD1 instructions..

Fri, Apr 20, 6:33 AM

sdesmalen created D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate.

Fri, Apr 20, 6:33 AM

sdesmalen updated the diff for D45681: [AArch64][SVE] Asm: Support for structured ST2, ST3 and ST4 (scalar+imm) store instructions..

Fixed diagnostic message for st4 (immediate needs to be a multiple of 4)

Fri, Apr 20, 3:04 AM

Thu, Apr 19

sdesmalen added inline comments to D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes..

Thu, Apr 19, 6:42 AM

sdesmalen added a comment to D45690: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+scalar) load instructions..

In D45690#1070865, @javed.absar wrote:

Hi Sander.
Its good you mention 'patch [4/4] in a series' in commit message. But could you please also link them up by providing link to previous reviews etc.
Might be easy for tracking later.

Thu, Apr 19, 12:27 AM

sdesmalen updated the summary of D45690: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+scalar) load instructions..

Thu, Apr 19, 12:26 AM

sdesmalen updated the summary of D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes..

Thu, Apr 19, 12:26 AM

sdesmalen updated the summary of D45688: [AArch64][AsmParser] Extend RegOp with integrated 'shift/extend'..

Thu, Apr 19, 12:26 AM

sdesmalen updated the summary of D45687: [AArch64][AsmParser] NFC: Cleanup parsing of scalar registers..

Thu, Apr 19, 12:26 AM

Wed, Apr 18

sdesmalen added a comment to D45687: [AArch64][AsmParser] NFC: Cleanup parsing of scalar registers..

In D45687#1070654, @samparker wrote:

This is a nice cleanup. LGTM with the one inline nit.

Thanks!

Wed, Apr 18, 1:45 AM

Tue, Apr 17

sdesmalen updated the diff for D45690: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+scalar) load instructions..

NFC: Removed unused-attribute from DecodeGPR64commonRegisterClass.

Tue, Apr 17, 7:51 AM

sdesmalen updated the diff for D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes..

Minor clean-up of patch:

Removed template argument from 'printRegWithShiftExtend'
Added unused attribute to DecodeGPR64commonRegisterClass (will be removed in next patch, but avoids breaking buildbot).
Rephrased diagnostic to say 'xzr' instead of 'x31'.

Tue, Apr 17, 7:49 AM

sdesmalen updated the diff for D45690: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+scalar) load instructions..

NFC: Reordered the position of the instructions in the .td file.

Tue, Apr 17, 12:13 AM

sdesmalen updated the diff for D45687: [AArch64][AsmParser] NFC: Cleanup parsing of scalar registers..

Fixed 'typo' where a condition expression tested the wrong variable in tryParseScalarRegister ('RegNum' vs 'Reg').

Tue, Apr 17, 12:09 AM

Mon, Apr 16

sdesmalen added a dependency for D45690: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+scalar) load instructions.: D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes..

Mon, Apr 16, 7:36 AM

sdesmalen added a dependent revision for D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes.: D45690: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+scalar) load instructions..

Mon, Apr 16, 7:36 AM

sdesmalen added a dependency for D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes.: D45688: [AArch64][AsmParser] Extend RegOp with integrated 'shift/extend'..

Mon, Apr 16, 7:36 AM

sdesmalen added a dependent revision for D45688: [AArch64][AsmParser] Extend RegOp with integrated 'shift/extend'.: D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes..

Mon, Apr 16, 7:36 AM

sdesmalen added a dependency for D45688: [AArch64][AsmParser] Extend RegOp with integrated 'shift/extend'.: D45687: [AArch64][AsmParser] NFC: Cleanup parsing of scalar registers..

Mon, Apr 16, 7:35 AM

sdesmalen added a dependent revision for D45687: [AArch64][AsmParser] NFC: Cleanup parsing of scalar registers.: D45688: [AArch64][AsmParser] Extend RegOp with integrated 'shift/extend'..

Mon, Apr 16, 7:35 AM

sdesmalen created D45690: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+scalar) load instructions..

Mon, Apr 16, 7:35 AM

sdesmalen created D45689: [AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes..

Mon, Apr 16, 7:34 AM

sdesmalen created D45688: [AArch64][AsmParser] Extend RegOp with integrated 'shift/extend'..

Mon, Apr 16, 7:34 AM

sdesmalen created D45687: [AArch64][AsmParser] NFC: Cleanup parsing of scalar registers..

Mon, Apr 16, 7:34 AM

sdesmalen created D45684: [AArch64][SVE] Asm: Support for contiguous, non-faulting LDNF1 (scalar+imm) load instructions.

Mon, Apr 16, 5:54 AM

sdesmalen created D45681: [AArch64][SVE] Asm: Support for structured ST2, ST3 and ST4 (scalar+imm) store instructions..

Mon, Apr 16, 3:46 AM

Fri, Apr 13

sdesmalen created D45622: [AArch64][SVE] Asm: Support for structured LD2 (scalar+imm) load instructions..

Fri, Apr 13, 7:06 AM

sdesmalen created D45624: [AArch64][SVE] Asm: Support for structured LD4 (scalar+imm) load instructions..

Fri, Apr 13, 7:06 AM

sdesmalen created D45623: [AArch64][SVE] Asm: Support for structured LD3 (scalar+imm) load instructions..

Fri, Apr 13, 7:06 AM

sdesmalen added a comment to D45618: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+imm) load instructions.

In D45618#1067038, @rengolin wrote:

LGTM, thanks!

Thanks for the quick review!

Fri, Apr 13, 6:40 AM

sdesmalen created D45618: [AArch64][SVE] Asm: Support for contiguous LD1 (scalar+imm) load instructions.

Fri, Apr 13, 4:38 AM

Thu, Apr 12

sdesmalen added inline comments to D45432: [AArch64][SVE] Asm: Support for contiguous ST1 (scalar+imm) store instructions..

Thu, Apr 12, 9:24 AM

sdesmalen updated the diff for D45431: [AArch64][SVE] Asm: Add support for parsing and printing SVE vector lists..

Added assert and whitespace and removed definitions for zsub1..3 from this patch.

Thu, Apr 12, 7:10 AM

sdesmalen added inline comments to D45431: [AArch64][SVE] Asm: Add support for parsing and printing SVE vector lists..

Thu, Apr 12, 7:10 AM

sdesmalen added inline comments to D45429: [AArch64][AsmParser] Make parse function for VectorLists generic to other vector types..

Thu, Apr 12, 4:09 AM

Tue, Apr 10

sdesmalen added inline comments to D45427: [AArch64][AsmParser] Unify code for parsing Neon/SVE vectors..

Tue, Apr 10, 4:22 AM

sdesmalen updated the diff for D45429: [AArch64][AsmParser] Make parse function for VectorLists generic to other vector types..

Rebased to reflect changes in dependent patch D45427 .

Tue, Apr 10, 1:48 AM

sdesmalen added inline comments to D45428: [AArch64][AsmParser] Split index parsing from vector list..

Tue, Apr 10, 1:45 AM

sdesmalen added inline comments to D45427: [AArch64][AsmParser] Unify code for parsing Neon/SVE vectors..

Tue, Apr 10, 1:45 AM

sdesmalen updated the diff for D45427: [AArch64][AsmParser] Unify code for parsing Neon/SVE vectors..

Added a new comment describing what 'parseVectorKind' does.
Put back some of the original comments into 'parseVectorKind'.
Fixed assert in lambda function and updated the capture-list.

Tue, Apr 10, 1:45 AM

Mon, Apr 9

sdesmalen added a dependency for D45432: [AArch64][SVE] Asm: Support for contiguous ST1 (scalar+imm) store instructions.: D45431: [AArch64][SVE] Asm: Add support for parsing and printing SVE vector lists..

Mon, Apr 9, 2:37 AM

sdesmalen added a dependent revision for D45431: [AArch64][SVE] Asm: Add support for parsing and printing SVE vector lists.: D45432: [AArch64][SVE] Asm: Support for contiguous ST1 (scalar+imm) store instructions..

Mon, Apr 9, 2:37 AM

sdesmalen added dependencies for D45431: [AArch64][SVE] Asm: Add support for parsing and printing SVE vector lists.: D45429: [AArch64][AsmParser] Make parse function for VectorLists generic to other vector types., D45430: [AArch64][AsmParser] Unify 'addVectorListOperands' functions..

Mon, Apr 9, 2:37 AM

sdesmalen added a dependent revision for D45429: [AArch64][AsmParser] Make parse function for VectorLists generic to other vector types.: D45431: [AArch64][SVE] Asm: Add support for parsing and printing SVE vector lists..

Mon, Apr 9, 2:37 AM

sdesmalen added a dependent revision for D45430: [AArch64][AsmParser] Unify 'addVectorListOperands' functions.: D45431: [AArch64][SVE] Asm: Add support for parsing and printing SVE vector lists..

Mon, Apr 9, 2:37 AM

sdesmalen added a dependency for D45429: [AArch64][AsmParser] Make parse function for VectorLists generic to other vector types.: D45428: [AArch64][AsmParser] Split index parsing from vector list..

Mon, Apr 9, 2:36 AM

sdesmalen added a dependent revision for D45428: [AArch64][AsmParser] Split index parsing from vector list.: D45429: [AArch64][AsmParser] Make parse function for VectorLists generic to other vector types..

Mon, Apr 9, 2:36 AM

sdesmalen added a dependency for D45428: [AArch64][AsmParser] Split index parsing from vector list.: D45427: [AArch64][AsmParser] Unify code for parsing Neon/SVE vectors..

Mon, Apr 9, 2:35 AM

sdesmalen added a dependent revision for D45427: [AArch64][AsmParser] Unify code for parsing Neon/SVE vectors.: D45428: [AArch64][AsmParser] Split index parsing from vector list..

Mon, Apr 9, 2:35 AM

sdesmalen created D45432: [AArch64][SVE] Asm: Support for contiguous ST1 (scalar+imm) store instructions..

Mon, Apr 9, 2:35 AM

sdesmalen created D45431: [AArch64][SVE] Asm: Add support for parsing and printing SVE vector lists..

Mon, Apr 9, 2:35 AM

sdesmalen created D45430: [AArch64][AsmParser] Unify 'addVectorListOperands' functions..

Mon, Apr 9, 2:34 AM

sdesmalen created D45429: [AArch64][AsmParser] Make parse function for VectorLists generic to other vector types..

Mon, Apr 9, 2:34 AM

sdesmalen created D45428: [AArch64][AsmParser] Split index parsing from vector list..

Mon, Apr 9, 2:34 AM

sdesmalen created D45427: [AArch64][AsmParser] Unify code for parsing Neon/SVE vectors..

Mon, Apr 9, 2:34 AM

Fri, Apr 6

sdesmalen created D45371: [AArch64][SVE] Asm: Add support for unpredicated LSL/LSR (shift by immediate) instructions..

Fri, Apr 6, 7:38 AM

sdesmalen created D45370: [AArch64][SVE] Asm: Add support for SVE INDEX instructions..

Fri, Apr 6, 7:31 AM

Feb 19 2018

sdesmalen added a comment to D43387: [DebugInfo] Removed assert on missing CountVarDIE.

In D43387#1011468, @davide wrote:

@sdesmalen is this the same issue as https://bugs.llvm.org/show_bug.cgi?id=36376 ?

Feb 19 2018, 1:48 AM