Page MenuHomePhabricator

sdesmalen (Sander de Smalen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 21 2016, 1:19 AM (234 w, 4 d)

Recent Activity

Today

sdesmalen added a comment to D100763: [LoopVectorize] Don't create unnecessary vscale intrinsic calls.

Is it worth adding a test to llvm/unittests/IR/IRBuilderTest.cpp for this change?

Tue, Apr 20, 3:58 AM · Restricted Project
sdesmalen accepted D99935: [AArch64] Add instruction costs for FP_TO_UINT and FP_TO_SINT with half types.

LGTM!

Tue, Apr 20, 3:52 AM · Restricted Project
sdesmalen added a comment to D100121: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor..

Thanks for the review @bmahjour and @dmgreen!

Tue, Apr 20, 1:56 AM · Restricted Project
sdesmalen committed rG86729538bdbd: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor. (authored by sdesmalen).
[LV] Let selectVectorizationFactor reason directly on VectorizationFactor.
Tue, Apr 20, 1:55 AM
sdesmalen closed D100121: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor..
Tue, Apr 20, 1:55 AM · Restricted Project
sdesmalen added inline comments to D100745: [AArch64] Add AArch64TTIImpl::getMaskedMemoryOpCost function.
Tue, Apr 20, 1:53 AM · Restricted Project
sdesmalen added inline comments to D100763: [LoopVectorize] Don't create unnecessary vscale intrinsic calls.
Tue, Apr 20, 1:34 AM · Restricted Project
sdesmalen added inline comments to D100486: [COST]Improve cost model for shuffles in SLP..
Tue, Apr 20, 1:21 AM · Restricted Project

Yesterday

sdesmalen accepted D100107: [AArch64][SVE] Combine add and index_vector.

Other than my comment on two missing tests, the patch looks good to me.

Mon, Apr 19, 7:53 AM · Restricted Project
sdesmalen accepted D100485: [AArch64][SVE] Fix crash with icmp+select.

LGTM, thanks @CarolineConcatto

Mon, Apr 19, 1:12 AM · Restricted Project

Fri, Apr 16

sdesmalen updated the diff for D100121: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor..

Changed back to having isMoreProfitable in LV CostModel.

Fri, Apr 16, 12:44 AM · Restricted Project

Thu, Apr 15

sdesmalen added reviewers for D100565: [TTI] NFC: Change getIntImmCost[Inst|Intrin] to return InstructionCost: c-rhodes, ctetreau, paulwalker-arm, samparker.
Thu, Apr 15, 7:34 AM · Restricted Project
sdesmalen added reviewers for D100564: [TTI] NFC: Change getScalingFactorCost to return InstructionCost: david-arm, ctetreau, paulwalker-arm, dmgreen.
Thu, Apr 15, 7:33 AM · Restricted Project
sdesmalen added reviewers for D100563: [TTI] NFC: Change getMemcpyCost to return InstructionCost: david-arm, paulwalker-arm, ctetreau.
Thu, Apr 15, 7:33 AM · Restricted Project
sdesmalen added reviewers for D100562: [TTI] NFC: Change getGEPCost to return InstructionCost: david-arm, ctetreau, paulwalker-arm.
Thu, Apr 15, 7:32 AM · Restricted Project
sdesmalen added reviewers for D100561: [TTI] NFC: Change getAddressComputationCost to return InstructionCost: david-arm, ctetreau, paulwalker-arm.
Thu, Apr 15, 7:32 AM · Restricted Project
sdesmalen requested review of D100565: [TTI] NFC: Change getIntImmCost[Inst|Intrin] to return InstructionCost.
Thu, Apr 15, 7:22 AM · Restricted Project
sdesmalen requested review of D100564: [TTI] NFC: Change getScalingFactorCost to return InstructionCost.
Thu, Apr 15, 7:19 AM · Restricted Project
sdesmalen requested review of D100563: [TTI] NFC: Change getMemcpyCost to return InstructionCost.
Thu, Apr 15, 7:18 AM · Restricted Project
sdesmalen requested review of D100562: [TTI] NFC: Change getGEPCost to return InstructionCost.
Thu, Apr 15, 7:17 AM · Restricted Project
sdesmalen requested review of D100561: [TTI] NFC: Change getAddressComputationCost to return InstructionCost.
Thu, Apr 15, 7:16 AM · Restricted Project
sdesmalen added inline comments to D100486: [COST]Improve cost model for shuffles in SLP..
Thu, Apr 15, 3:46 AM · Restricted Project
sdesmalen added a comment to D100485: [AArch64][SVE] Fix crash with icmp+select.

Thanks for the changes @CarolineConcatto

Thu, Apr 15, 3:18 AM · Restricted Project
sdesmalen added a comment to D100107: [AArch64][SVE] Combine add and index_vector.

Thanks, that looks quite neat. Can you also add a few tests when there is >1 use of the stepvector (e.g. using the stepvector in two adds), so we can test the fold indeed doesn't happen?
One test for each of the instructions should be sufficient.

Thu, Apr 15, 3:07 AM · Restricted Project

Wed, Apr 14

sdesmalen added a comment to D100485: [AArch64][SVE] Fix crash with icmp+select.

Can you also add support for predicates?

Wed, Apr 14, 1:08 PM · Restricted Project
sdesmalen committed rG1af35e77f4b8: [TTI] NFC: Change getVectorInstrCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getVectorInstrCost to return InstructionCost
Wed, Apr 14, 9:35 AM
sdesmalen committed rG4f42d873c202: [TTI] NFC: Change getArithmeticInstrCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getArithmeticInstrCost to return InstructionCost
Wed, Apr 14, 9:35 AM
sdesmalen committed rGd84bd951a8d3: [TTI] NFC: Change getFPOpCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getFPOpCost to return InstructionCost
Wed, Apr 14, 9:35 AM
sdesmalen committed rG174e8f6c5e46: [TTI] NFC: Change getShuffleCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getShuffleCost to return InstructionCost
Wed, Apr 14, 9:34 AM
sdesmalen closed D100315: [TTI] NFC: Change getVectorInstrCost to return InstructionCost.
Wed, Apr 14, 9:34 AM · Restricted Project
sdesmalen closed D100316: [TTI] NFC: Change getFPOpCost to return InstructionCost.
Wed, Apr 14, 9:34 AM · Restricted Project
sdesmalen closed D100317: [TTI] NFC: Change getArithmeticInstrCost to return InstructionCost.
Wed, Apr 14, 9:34 AM · Restricted Project
sdesmalen committed rG14b934f8a6f2: [TTI] NFC: Change getCFInstrCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getCFInstrCost to return InstructionCost
Wed, Apr 14, 9:34 AM
sdesmalen committed rG596f669cfbbf: [TTI] NFC: Change getCallInstrCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getCallInstrCost to return InstructionCost
Wed, Apr 14, 9:34 AM
sdesmalen closed D100314: [TTI] NFC: Change getShuffleCost to return InstructionCost.
Wed, Apr 14, 9:30 AM · Restricted Project
sdesmalen closed D100313: [TTI] NFC: Change getCFInstrCost to return InstructionCost.
Wed, Apr 14, 9:30 AM · Restricted Project
sdesmalen closed D100312: [TTI] NFC: Change getCallInstrCost to return InstructionCost.
Wed, Apr 14, 9:30 AM · Restricted Project
sdesmalen added inline comments to D100317: [TTI] NFC: Change getArithmeticInstrCost to return InstructionCost.
Wed, Apr 14, 8:45 AM · Restricted Project
sdesmalen updated the diff for D100317: [TTI] NFC: Change getArithmeticInstrCost to return InstructionCost.

Removed another case of .getValue()

Wed, Apr 14, 8:44 AM · Restricted Project

Tue, Apr 13

sdesmalen added inline comments to D98509: [LV] Calculate max feasible scalable VF..
Tue, Apr 13, 1:28 PM · Restricted Project
sdesmalen updated the diff for D98509: [LV] Calculate max feasible scalable VF..
  • Addressed nits.
  • s/MaxVectorSize/MaxVectorElementCount/ (because it's not actually a size, but an element count).
Tue, Apr 13, 1:25 PM · Restricted Project
sdesmalen committed rG204aaf879548: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro. (authored by sdesmalen).
[AArch64][SVE] Always use overloaded methods instead of preprocessor macro.
Tue, Apr 13, 1:13 PM
sdesmalen closed D100297: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro..
Tue, Apr 13, 1:13 PM · Restricted Project
sdesmalen added a comment to D100107: [AArch64][SVE] Combine add and index_vector.

What I want know something more is what is the boundary between tablegen pattern match and dag combine? I never figure this out. Just use this case as example, we can implement the feature in both place, but I don't know how to handle commutivity in tablegen (maybe SDNPCommutative? I don't know.) , and their effects on the next step: combine load/store with index_vector.

There isn't a firm rule to follow re tablegen pattern vs manual dag combine, but I think the steer is that when the combine is needed after legalization and it's possible to specify as a pattern, a pattern is preferred. In this case, probably a pattern would be a clean way to implement it. I haven't used SDNPCommutative before, but that looks like it should do the trick.

Tue, Apr 13, 7:28 AM · Restricted Project
sdesmalen added reviewers for D100317: [TTI] NFC: Change getArithmeticInstrCost to return InstructionCost: dmgreen, ctetreau, paulwalker-arm, kmclaughlin.
Tue, Apr 13, 6:48 AM · Restricted Project
sdesmalen added reviewers for D100316: [TTI] NFC: Change getFPOpCost to return InstructionCost: dmgreen, ctetreau, paulwalker-arm, c-rhodes.
Tue, Apr 13, 6:47 AM · Restricted Project
sdesmalen added reviewers for D100315: [TTI] NFC: Change getVectorInstrCost to return InstructionCost: dmgreen, ctetreau, paulwalker-arm, CarolineConcatto.
Tue, Apr 13, 6:44 AM · Restricted Project
sdesmalen added reviewers for D100314: [TTI] NFC: Change getShuffleCost to return InstructionCost: dmgreen, ctetreau, paulwalker-arm, kmclaughlin.
Tue, Apr 13, 6:44 AM · Restricted Project
sdesmalen added reviewers for D100313: [TTI] NFC: Change getCFInstrCost to return InstructionCost: dmgreen, ctetreau, paulwalker-arm, samparker.
Tue, Apr 13, 6:43 AM · Restricted Project
sdesmalen added reviewers for D100312: [TTI] NFC: Change getCallInstrCost to return InstructionCost: dmgreen, ctetreau, paulwalker-arm, c-rhodes.
Tue, Apr 13, 6:42 AM · Restricted Project
sdesmalen accepted D100377: [TTI] NFC: Remove unused 'OptSize' parameter from shouldMaximizeVectorBandwidth.

It's not entirely clear what original intent of this function argument was since the doxygen comment doesn't describe it.
If the argument also isn't used anywhere then it seems sensible to me to remove it, so LGTM.

Tue, Apr 13, 6:35 AM · Restricted Project
sdesmalen committed rG03f47bdcb1a9: [TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost
Tue, Apr 13, 6:23 AM
sdesmalen closed D100205: [TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost.
Tue, Apr 13, 6:22 AM · Restricted Project
sdesmalen committed rGd676b5749d01: [TTI] NFC: Change getMaskedMemoryOpCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getMaskedMemoryOpCost to return InstructionCost
Tue, Apr 13, 6:22 AM
sdesmalen closed D100204: [TTI] NFC: Change getMaskedMemoryOpCost to return InstructionCost.
Tue, Apr 13, 6:22 AM · Restricted Project
sdesmalen committed rGdb134e2428c9: [TTI] NFC: Change getCmpSelInstrCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getCmpSelInstrCost to return InstructionCost
Tue, Apr 13, 6:22 AM
sdesmalen closed D100203: [TTI] NFC: Change getCmpSelInstrCost to return InstructionCost.
Tue, Apr 13, 6:22 AM · Restricted Project
sdesmalen committed rG2285dfb73fc6: [TTI] NFC: Change getMinMaxReductionCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getMinMaxReductionCost to return InstructionCost
Tue, Apr 13, 6:22 AM
sdesmalen closed D100202: [TTI] NFC: Change getMinMaxReductionCost to return InstructionCost.
Tue, Apr 13, 6:22 AM · Restricted Project
sdesmalen committed rGbd86824d9865: [TTI] NFC: Change getArithmeticReductionCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getArithmeticReductionCost to return InstructionCost
Tue, Apr 13, 6:22 AM
sdesmalen closed D100201: [TTI] NFC: Change getArithmeticReductionCost to return InstructionCost.
Tue, Apr 13, 6:21 AM · Restricted Project
sdesmalen committed rGfd1f8a54628a: [TTI] NFC: Change getGatherScatterOpCost to return InstructionCost (authored by sdesmalen).
[TTI] NFC: Change getGatherScatterOpCost to return InstructionCost
Tue, Apr 13, 6:21 AM
sdesmalen closed D100200: [TTI] NFC: Change getGatherScatterOpCost to return InstructionCost.
Tue, Apr 13, 6:21 AM · Restricted Project
sdesmalen committed rG92d8421f4904: [TTI] NFC: Change getCastInstrCost and getExtractWithExtendCost to return… (authored by sdesmalen).
[TTI] NFC: Change getCastInstrCost and getExtractWithExtendCost to return…
Tue, Apr 13, 6:21 AM
sdesmalen closed D100199: [TTI] NFC: Change getCastInstrCost and getExtractWithExtendCost to return InstructionCost.
Tue, Apr 13, 6:21 AM · Restricted Project
sdesmalen committed rGfa936b610fd0: [AArch64][SVE] Fix dup/dupq intrinsics for C++. (authored by sdesmalen).
[AArch64][SVE] Fix dup/dupq intrinsics for C++.
Tue, Apr 13, 2:58 AM
sdesmalen closed D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++..
Tue, Apr 13, 2:58 AM · Restricted Project

Mon, Apr 12

sdesmalen requested review of D100317: [TTI] NFC: Change getArithmeticInstrCost to return InstructionCost.
Mon, Apr 12, 8:47 AM · Restricted Project
sdesmalen requested review of D100316: [TTI] NFC: Change getFPOpCost to return InstructionCost.
Mon, Apr 12, 8:46 AM · Restricted Project
sdesmalen requested review of D100315: [TTI] NFC: Change getVectorInstrCost to return InstructionCost.
Mon, Apr 12, 8:45 AM · Restricted Project
sdesmalen requested review of D100314: [TTI] NFC: Change getShuffleCost to return InstructionCost.
Mon, Apr 12, 8:44 AM · Restricted Project
sdesmalen requested review of D100313: [TTI] NFC: Change getCFInstrCost to return InstructionCost.
Mon, Apr 12, 8:43 AM · Restricted Project
sdesmalen requested review of D100312: [TTI] NFC: Change getCallInstrCost to return InstructionCost.
Mon, Apr 12, 8:41 AM · Restricted Project
sdesmalen added a comment to D100205: [TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost.

Thanks for the review @dmgreen!

Mon, Apr 12, 8:18 AM · Restricted Project
sdesmalen added inline comments to D100121: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor..
Mon, Apr 12, 8:15 AM · Restricted Project
sdesmalen added a comment to D100225: [Clang][AArch64] Coerce integer return values through an undef vector.

After reading the summary/intent of the patch, I thought the same thing as @rjmccall. Simply returning an i32 for the above example and removing the rounding-up seems right to me.

Mon, Apr 12, 6:26 AM · Restricted Project
sdesmalen added reviewers for D100297: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro.: bsmith, paulwalker-arm, c-rhodes.
Mon, Apr 12, 4:12 AM · Restricted Project
sdesmalen requested review of D100297: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro..
Mon, Apr 12, 4:11 AM · Restricted Project
sdesmalen added reviewers for D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++.: bsmith, kmclaughlin, paulwalker-arm.
Mon, Apr 12, 3:40 AM · Restricted Project
sdesmalen requested review of D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++..
Mon, Apr 12, 3:28 AM · Restricted Project
sdesmalen committed rG6bf806b3e2fd: [AArch64] ACLE: Fix issue for mismatching enum types with builtins. (authored by sdesmalen).
[AArch64] ACLE: Fix issue for mismatching enum types with builtins.
Mon, Apr 12, 3:20 AM
sdesmalen closed D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..
Mon, Apr 12, 3:19 AM · Restricted Project
sdesmalen added reviewers for D100205: [TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost: dmgreen, ctetreau, paulwalker-arm, kmclaughlin.
Mon, Apr 12, 1:48 AM · Restricted Project
sdesmalen added inline comments to D100204: [TTI] NFC: Change getMaskedMemoryOpCost to return InstructionCost.
Mon, Apr 12, 1:46 AM · Restricted Project
sdesmalen updated the diff for D100204: [TTI] NFC: Change getMaskedMemoryOpCost to return InstructionCost.

Removed unnecessary .getValue()

Mon, Apr 12, 1:46 AM · Restricted Project
sdesmalen added inline comments to D100203: [TTI] NFC: Change getCmpSelInstrCost to return InstructionCost.
Mon, Apr 12, 1:44 AM · Restricted Project
sdesmalen updated the diff for D100203: [TTI] NFC: Change getCmpSelInstrCost to return InstructionCost.

Addressed review comments.

Mon, Apr 12, 1:44 AM · Restricted Project
sdesmalen abandoned D100207: [TTI] NFC: Change getInterleavedMemoryOpCost to return InstructionCost.
Mon, Apr 12, 1:22 AM · Restricted Project
sdesmalen retitled D100205: [TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost from [TTI] NFC: Change getMemoryOpCost to return InstructionCost to [TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost.
Mon, Apr 12, 1:22 AM · Restricted Project
sdesmalen updated the diff for D100205: [TTI] NFC: Change get[Interleaved]MemoryOpCost to return InstructionCost.

Merged patch with D100207

Mon, Apr 12, 1:21 AM · Restricted Project
sdesmalen updated the summary of D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..
Mon, Apr 12, 12:32 AM · Restricted Project
sdesmalen added a comment to D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..

Thanks for taking time from your weekend to look into this @tambre, much appreciated!

Mon, Apr 12, 12:24 AM · Restricted Project
sdesmalen updated the diff for D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..

Removed forgetBuiltin and the code using it.

Mon, Apr 12, 12:20 AM · Restricted Project

Fri, Apr 9

sdesmalen updated the diff for D100199: [TTI] NFC: Change getCastInstrCost and getExtractWithExtendCost to return InstructionCost.

Revert InstructionCost change for Num variable.

Fri, Apr 9, 9:32 AM · Restricted Project
sdesmalen added inline comments to D100199: [TTI] NFC: Change getCastInstrCost and getExtractWithExtendCost to return InstructionCost.
Fri, Apr 9, 9:31 AM · Restricted Project
sdesmalen accepted D99727: [NFC][LoopVectorize] Remove unnecessary VF.isScalable asserts.

Thanks, LGTM!

Fri, Apr 9, 8:22 AM · Restricted Project
sdesmalen added reviewers for D100201: [TTI] NFC: Change getArithmeticReductionCost to return InstructionCost: ctetreau, paulwalker-arm, c-rhodes, dmgreen.
Fri, Apr 9, 8:21 AM · Restricted Project
sdesmalen added reviewers for D100200: [TTI] NFC: Change getGatherScatterOpCost to return InstructionCost: ctetreau, paulwalker-arm, david-arm, dmgreen.
Fri, Apr 9, 8:21 AM · Restricted Project
sdesmalen added reviewers for D100199: [TTI] NFC: Change getCastInstrCost and getExtractWithExtendCost to return InstructionCost: ctetreau, paulwalker-arm, david-arm, dmgreen.
Fri, Apr 9, 8:20 AM · Restricted Project
sdesmalen requested review of D100207: [TTI] NFC: Change getInterleavedMemoryOpCost to return InstructionCost.
Fri, Apr 9, 8:15 AM · Restricted Project