Page MenuHomePhabricator

sdesmalen (Sander de Smalen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 21 2016, 1:19 AM (335 w, 2 d)

Recent Activity

Fri, Mar 24

sdesmalen committed rGc0d28d58fafe: [AArch64][SME] SelectSMETileSlice should also match to 'reg+0' when slice is… (authored by sdesmalen).
[AArch64][SME] SelectSMETileSlice should also match to 'reg+0' when slice is…
Fri, Mar 24, 7:39 AM · Restricted Project, Restricted Project
sdesmalen accepted D146806: [LoongArch] Add Scalar link component.
Fri, Mar 24, 6:35 AM · Restricted Project, Restricted Project
sdesmalen accepted D146128: [SVE][LoopVectorize] Add option to disable tail-folding for reverse loops.
Fri, Mar 24, 6:33 AM · Restricted Project, Restricted Project
sdesmalen accepted D146199: [LoopVectorize] Don't tail-fold for scalable VFs when there is no scalar tail.

Thanks @david-arm, LGTM.

Fri, Mar 24, 6:28 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D146128: [SVE][LoopVectorize] Add option to disable tail-folding for reverse loops.
Fri, Mar 24, 5:26 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D146600: [LoongArch] Enable LoopDataPrefetch pass.

Hi I'm getting build failures with this patch due to a linker error where it says:

ld.lld: error: undefined symbol: llvm::createLoopDataPrefetchPass()
>>> referenced by LoongArchTargetMachine.cpp
>>>               lib/Target/LoongArch/CMakeFiles/LLVMLoongArchCodeGen.dir/LoongArchTargetMachine.cpp.o:((anonymous namespace)::LoongArchPassConfig::addIRPasses())
collect2: error: ld returned 1 exit status`
Fri, Mar 24, 2:15 AM · Restricted Project, Restricted Project

Thu, Mar 23

sdesmalen added inline comments to D146199: [LoopVectorize] Don't tail-fold for scalable VFs when there is no scalar tail.
Thu, Mar 23, 9:27 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D145583: [AArch64][SME] Fix an infinite loop in DAGCombine related to adding -force-streaming-compatible-sve flag..
Thu, Mar 23, 7:27 AM · Restricted Project, Restricted Project

Wed, Mar 22

sdesmalen accepted D146311: [AArch64] Add asm aliases for MOV, LDR, STR with predicate-as-counter.
Wed, Mar 22, 3:37 AM · Restricted Project, Restricted Project

Tue, Mar 21

sdesmalen added inline comments to D145583: [AArch64][SME] Fix an infinite loop in DAGCombine related to adding -force-streaming-compatible-sve flag..
Tue, Mar 21, 6:52 AM · Restricted Project, Restricted Project

Mon, Mar 20

sdesmalen added inline comments to D146311: [AArch64] Add asm aliases for MOV, LDR, STR with predicate-as-counter.
Mon, Mar 20, 4:50 AM · Restricted Project, Restricted Project

Fri, Mar 17

sdesmalen requested changes to D146311: [AArch64] Add asm aliases for MOV, LDR, STR with predicate-as-counter.

Sorry for the quick turn-around here, but I just realise that we probably want to guard these aliases with HasSVE2p1_or_HasSME2, because without those features the concept of a predicate-as-counter does not exist. I see that we haven't done this for pfalse either.

Fri, Mar 17, 11:00 AM · Restricted Project, Restricted Project
sdesmalen accepted D146311: [AArch64] Add asm aliases for MOV, LDR, STR with predicate-as-counter.
Fri, Mar 17, 10:55 AM · Restricted Project, Restricted Project

Thu, Mar 16

sdesmalen added inline comments to D146199: [LoopVectorize] Don't tail-fold for scalable VFs when there is no scalar tail.
Thu, Mar 16, 10:16 AM · Restricted Project, Restricted Project
sdesmalen accepted D146217: [ValueTracking] Support vscale in computeConstantRange().

In this case all comparisons just fold to true (but could also fold to any other value).

What is the reason that the IR doesn't explicitly return poison in that case? (i.e. ret i1 poison)

No particular reason, this just hasn't been implemented. (Would need a special case for empty ranges in simplifyICmpWithConstant.)

Fair enough, I was mostly wondering if there was a fundamental reason for it or if my understanding of poison was lacking here :) Thanks for clarifying!

Thu, Mar 16, 8:16 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D146217: [ValueTracking] Support vscale in computeConstantRange().

In this case all comparisons just fold to true (but could also fold to any other value).

What is the reason that the IR doesn't explicitly return poison in that case? (i.e. ret i1 poison)

Thu, Mar 16, 7:45 AM · Restricted Project, Restricted Project
sdesmalen abandoned D145497: [AArch64] Allocate emergency spillslot when using fixed-length SVE..

Abandoning since the alternative fix has now landed (D146056)

Thu, Mar 16, 7:02 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D146217: [ValueTracking] Support vscale in computeConstantRange().
Thu, Mar 16, 5:13 AM · Restricted Project, Restricted Project

Wed, Mar 15

sdesmalen accepted D146146: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings..

It gives me great joy to see this code removed :)

Wed, Mar 15, 9:38 AM · Restricted Project, Restricted Project
sdesmalen committed rG93b89bee471f: [AArch64][SVE] Fix the indexed addressing mode when FI = 0. (authored by sdesmalen).
[AArch64][SVE] Fix the indexed addressing mode when FI = 0.
Wed, Mar 15, 6:40 AM · Restricted Project, Restricted Project
sdesmalen closed D146056: [AArch64][SVE] Fix the indexed addressing mode when FI = 0..
Wed, Mar 15, 6:40 AM · Restricted Project, Restricted Project

Tue, Mar 14

sdesmalen requested review of D146056: [AArch64][SVE] Fix the indexed addressing mode when FI = 0..
Tue, Mar 14, 8:28 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D144225: [InstCombine] Add constant combines for `(urem/srem (shl X, Y), (shl X, Z))`.
Tue, Mar 14, 2:23 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D143014: Add constant combines for `(urem/srem (mul X, Y), (mul X, Z))`.

I'm happy to look at one of the other patches. Can you land this patch in the meantime?

Tue, Mar 14, 2:18 AM · Restricted Project, Restricted Project

Fri, Mar 10

sdesmalen accepted D145507: [LV][VPlan] Fix printing TripCount liveins. NFC.

Nice improvement.

Fri, Mar 10, 8:24 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D145703: [SPIR-V] Add Machine Value Type for SPIR-V builtins.
Fri, Mar 10, 8:15 AM · Restricted Project, Restricted Project
sdesmalen committed rG9548af05d293: [AArch64] NFC: Merge addTypeForStreamingSVE and addTypeForFixedLengthSVE (authored by sdesmalen).
[AArch64] NFC: Merge addTypeForStreamingSVE and addTypeForFixedLengthSVE
Fri, Mar 10, 7:10 AM · Restricted Project, Restricted Project
sdesmalen accepted D143014: Add constant combines for `(urem/srem (mul X, Y), (mul X, Z))`.
Fri, Mar 10, 5:36 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D145583: [AArch64][SME] Fix an infinite loop in DAGCombine related to adding -force-streaming-compatible-sve flag..
Fri, Mar 10, 3:58 AM · Restricted Project, Restricted Project

Thu, Mar 9

sdesmalen accepted D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Thanks for the changes @hassnaa-arm, I'm satisfied with the patch now so removing my 'requesting changes'.
Unless @dmgreen has more comments on the tests, I'm happy for this patch to land.

Thu, Mar 9, 6:14 AM · Restricted Project, Restricted Project

Tue, Mar 7

sdesmalen added inline comments to D145497: [AArch64] Allocate emergency spillslot when using fixed-length SVE..
Tue, Mar 7, 7:46 AM · Restricted Project, Restricted Project
sdesmalen updated the diff for D145497: [AArch64] Allocate emergency spillslot when using fixed-length SVE..

Added missing CHECK lines

Tue, Mar 7, 7:45 AM · Restricted Project, Restricted Project
sdesmalen committed rG07158c54add9: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t. (authored by sdesmalen).
[Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.
Tue, Mar 7, 6:44 AM · Restricted Project, Restricted Project
sdesmalen closed D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t..
Tue, Mar 7, 6:44 AM · Restricted Project, Restricted Project
sdesmalen requested review of D145497: [AArch64] Allocate emergency spillslot when using fixed-length SVE..
Tue, Mar 7, 5:42 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..

Thanks for all the changes @hassnaa-arm, I've just left some final minor comments.

Tue, Mar 7, 3:10 AM · Restricted Project, Restricted Project
sdesmalen accepted D145472: [LV][AArch64] Resolve test failure due use of unordered container.
Tue, Mar 7, 1:21 AM · Restricted Project, Restricted Project

Mon, Mar 6

sdesmalen updated the diff for D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t..
  • Added assert to check that NumVectors=1 for svcount_t.
Mon, Mar 6, 7:43 AM · Restricted Project, Restricted Project

Thu, Mar 2

sdesmalen added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Thu, Mar 2, 7:34 AM · Restricted Project, Restricted Project
sdesmalen updated the summary of D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t..
Thu, Mar 2, 6:55 AM · Restricted Project, Restricted Project
sdesmalen committed rG948ed21f1251: [AArch64] NFC: Add missing CHECK lines for sme-aarch64-svcount.ll test (authored by sdesmalen).
[AArch64] NFC: Add missing CHECK lines for sme-aarch64-svcount.ll test
Thu, Mar 2, 4:42 AM · Restricted Project, Restricted Project
sdesmalen committed rG170e7a0ec2e6: [AArch64][SME2] Add CodeGen support for target("aarch64.svcount"). (authored by sdesmalen).
[AArch64][SME2] Add CodeGen support for target("aarch64.svcount").
Thu, Mar 2, 4:10 AM · Restricted Project, Restricted Project
sdesmalen closed D136862: [AArch64][SME2] Add CodeGen support for target("aarch64.svcount")..
Thu, Mar 2, 4:09 AM · Restricted Project, Restricted Project
sdesmalen accepted D144472: [InstCombine][debuginfo] Update valueCoversEntireFragment for fixed size fragment and scalable value..

Seems fine to me, but please give @aprantl a chance to have another look at it as well before you land it.

Thu, Mar 2, 1:11 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D145113: [SelectionDAG][AArch64] Constant fold in SelectionDAG::getVScale if VScaleMin==VScaleMax..

Did you also try to see if there is additional value doing this transform at the LLVM IR layer? (I don't know if that could unlock other optimisations since ConstantFolding kicks in earlier)

I think it’s already in InstSimplify.

Thu, Mar 2, 12:58 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D145113: [SelectionDAG][AArch64] Constant fold in SelectionDAG::getVScale if VScaleMin==VScaleMax..

Did you also try to see if there is additional value doing this transform at the LLVM IR layer? (I don't know if that could unlock other optimisations since ConstantFolding kicks in earlier)

Thu, Mar 2, 12:41 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D145113: [SelectionDAG][AArch64] Constant fold in SelectionDAG::getVScale if VScaleMin==VScaleMax..
Thu, Mar 2, 12:31 AM · Restricted Project, Restricted Project

Wed, Mar 1

sdesmalen abandoned D143642: [SCEV] Fix SCEV analysis for scalable target types..

This was addressed by D144624

Wed, Mar 1, 7:33 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D142109: [LoopVectorize] Remove runtime check and scalar tail loop when tail-folding..
Wed, Mar 1, 7:25 AM · Restricted Project, Restricted Project
sdesmalen requested review of D145068: [LV] NFC: Split logic to use lane mask for control flow from addCanonicalIVRecipes..
Wed, Mar 1, 7:20 AM · Restricted Project, Restricted Project
sdesmalen committed rGc41b41eb11b4: [LoopVectorize] Use overflow-check analysis to improve tail-folding. (authored by sdesmalen).
[LoopVectorize] Use overflow-check analysis to improve tail-folding.
Wed, Mar 1, 6:18 AM · Restricted Project, Restricted Project
sdesmalen closed D142894: [LoopVectorize] Use overflow-check analysis to improve tail-folding..
Wed, Mar 1, 6:18 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D142109: [LoopVectorize] Remove runtime check and scalar tail loop when tail-folding..

Thanks for reviewing! I've addressed final comments before committing

Wed, Mar 1, 1:02 AM · Restricted Project, Restricted Project
sdesmalen committed rGfe1b51ffee69: [LoopVectorize] Remove runtime check and scalar tail loop when tail-folding. (authored by sdesmalen).
[LoopVectorize] Remove runtime check and scalar tail loop when tail-folding.
Wed, Mar 1, 1:02 AM · Restricted Project, Restricted Project
sdesmalen committed rGde111ae70a5a: NFC: Use generate_test_checks script for LV tests which seem to have been auto… (authored by sdesmalen).
NFC: Use generate_test_checks script for LV tests which seem to have been auto…
Wed, Mar 1, 1:02 AM · Restricted Project, Restricted Project
sdesmalen closed D142109: [LoopVectorize] Remove runtime check and scalar tail loop when tail-folding..
Wed, Mar 1, 1:02 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type..

Thanks for the reviews! I've addressed the nits before committing the patch.

Wed, Mar 1, 12:19 AM · Restricted Project, Restricted Project
sdesmalen committed rG0d94b636048c: [IR] Add LLVM IR support for target("aarch64.svcount") type. (authored by sdesmalen).
[IR] Add LLVM IR support for target("aarch64.svcount") type.
Wed, Mar 1, 12:18 AM · Restricted Project, Restricted Project
sdesmalen closed D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type..
Wed, Mar 1, 12:18 AM · Restricted Project, Restricted Project

Tue, Feb 28

sdesmalen added inline comments to D136862: [AArch64][SME2] Add CodeGen support for target("aarch64.svcount")..
Tue, Feb 28, 9:47 AM · Restricted Project, Restricted Project
sdesmalen updated the diff for D136862: [AArch64][SME2] Add CodeGen support for target("aarch64.svcount")..
  • Use PromoteToType for svcount_t -> nxv16i1
  • PNR -> PPR in one of the patterns
  • Added tests for select
Tue, Feb 28, 9:47 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Tue, Feb 28, 5:46 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D143014: Add constant combines for `(urem/srem (mul X, Y), (mul X, Z))`.
Tue, Feb 28, 3:46 AM · Restricted Project, Restricted Project

Feb 23 2023

sdesmalen updated the diff for D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type..
  • Removed unused interfaces.
  • Rebased after moving out change in foldSelectInstWithICmp.
Feb 23 2023, 8:33 AM · Restricted Project, Restricted Project
sdesmalen accepted D144624: [SCEV] Make scalable size representation more explicit.

Seems like a sensible refactoring to me and also removes the need for D143642.

Feb 23 2023, 8:26 AM · Restricted Project, Restricted Project
sdesmalen committed rG68b56e3a7470: [InstCombine] NFC: Add implied condition to block in foldSelectInstWithICmp (authored by sdesmalen).
[InstCombine] NFC: Add implied condition to block in foldSelectInstWithICmp
Feb 23 2023, 8:11 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type..
Feb 23 2023, 7:36 AM · Restricted Project, Restricted Project
sdesmalen updated the diff for D142894: [LoopVectorize] Use overflow-check analysis to improve tail-folding..

Rebased to use getMaxVScale function introduced in rG9449deda12c4

Feb 23 2023, 7:20 AM · Restricted Project, Restricted Project
sdesmalen committed rG9449deda12c4: [LV] NFC: Move logic to query maximum vscale to its own function. (authored by sdesmalen).
[LV] NFC: Move logic to query maximum vscale to its own function.
Feb 23 2023, 7:15 AM · Restricted Project, Restricted Project
sdesmalen accepted D144566: [PatternMatch] Don't require DataLayout for m_VScale().

I agree this is a sensible change to make, LGTM!

Feb 23 2023, 2:38 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 23 2023, 1:57 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D144472: [InstCombine][debuginfo] Update valueCoversEntireFragment for fixed size fragment and scalable value..
Feb 23 2023, 1:01 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D143422: [LV] Update logic for calculating register usage due to invariants.

Thanks for making the changes. I've just left a few more comments on the test.

Feb 23 2023, 12:43 AM · Restricted Project, Restricted Project

Feb 22 2023

sdesmalen added inline comments to D143422: [LV] Update logic for calculating register usage due to invariants.
Feb 22 2023, 9:36 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D142894: [LoopVectorize] Use overflow-check analysis to improve tail-folding..
Feb 22 2023, 9:27 AM · Restricted Project, Restricted Project
sdesmalen updated the diff for D142894: [LoopVectorize] Use overflow-check analysis to improve tail-folding..
  • IVUpdateCannotOverflow -> IVUpdateMayOverflow
  • Added 'IVUpdateMayOverflow' as operand to getPreferredTailFoldingStyle.
  • Runtime check is no longer emitted when tail-folding when we know the check evaluates to false.
Feb 22 2023, 9:27 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type..

@jcranmer-intel thanks for your review, I think I've addressed both your comments now.

Feb 22 2023, 2:35 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D143422: [LV] Update logic for calculating register usage due to invariants.
Feb 22 2023, 12:55 AM · Restricted Project, Restricted Project

Feb 21 2023

sdesmalen added a comment to D136862: [AArch64][SME2] Add CodeGen support for target("aarch64.svcount")..

Thanks for the review @paulwalker-arm, I think I've addressed most of your comments, with the exception of giving predicate-as-counter its own register class, as that one probably makes more sense to pull out into a separate patch.

Feb 21 2023, 9:17 AM · Restricted Project, Restricted Project
sdesmalen updated the diff for D136862: [AArch64][SME2] Add CodeGen support for target("aarch64.svcount")..
  • Added EVT::isScalableVT() and refactored code to use it
  • Use BITCAST instead of REINTERPRET_CAST
  • Custom lower load/store of svcount to use nxv16i1
  • Simplified lowering code in LowerSELECT
  • Replaced the blanket bailout in visitLOAD/visitSTORE in DAGCombiner with more specific bailouts
Feb 21 2023, 9:17 AM · Restricted Project, Restricted Project
sdesmalen updated the diff for D143642: [SCEV] Fix SCEV analysis for scalable target types..

Refactored to use Type::isScalableTy()

Feb 21 2023, 9:08 AM · Restricted Project, Restricted Project
sdesmalen updated the diff for D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type..
  • Added description of the svcount type to AArch64SME.rst
  • Use isIntOrIntVectorTy() in foldSelectInstWithICmp
  • Added Type::isScalableTy() convenience function.
Feb 21 2023, 9:06 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D144472: [InstCombine][debuginfo] Update valueCoversEntireFragment for fixed size fragment and scalable value..
Feb 21 2023, 4:17 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D143422: [LV] Update logic for calculating register usage due to invariants.
Feb 21 2023, 1:58 AM · Restricted Project, Restricted Project

Feb 20 2023

sdesmalen added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 20 2023, 8:46 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 20 2023, 4:52 AM · Restricted Project, Restricted Project
sdesmalen committed rGd515ecca6834: [IR] Add new intrinsics interleave and deinterleave vectors (authored by CarolineConcatto).
[IR] Add new intrinsics interleave and deinterleave vectors
Feb 20 2023, 4:44 AM · Restricted Project, Restricted Project
sdesmalen closed D141924: [IR] Add new intrinsics interleave and deinterleave vectors.
Feb 20 2023, 4:44 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D143283: [AArch64][SVE]: custom lower AVGFloor/AVGCeil..
Feb 20 2023, 3:41 AM · Restricted Project, Restricted Project
sdesmalen added a comment to D143014: Add constant combines for `(urem/srem (mul X, Y), (mul X, Z))`.

Thanks for simplifying this patch a bit!

Feb 20 2023, 2:46 AM · Restricted Project, Restricted Project

Feb 16 2023

sdesmalen added inline comments to D143014: Add constant combines for `(urem/srem (mul X, Y), (mul X, Z))`.
Feb 16 2023, 9:21 AM · Restricted Project, Restricted Project
sdesmalen requested changes to D143014: Add constant combines for `(urem/srem (mul X, Y), (mul X, Z))`.

Hi @goldstein.w.n, I'm still going through the patch but already found that some code paths are currently untested. I am requesting changes to avoid you from landing it.
In general my preference would be to limit the cases your code handles, rather than adding more tests for more possible combinations of shifts/muls. That makes the code-changes easier to review and helps identify the test-coverage for the different code-paths you've added.

Feb 16 2023, 8:31 AM · Restricted Project, Restricted Project

Feb 15 2023

sdesmalen accepted D143765: [SVE] Add intrinsics for floating-point operations that explicitly undefine the result for inactive lanes..
Feb 15 2023, 2:12 PM · Restricted Project, Restricted Project
sdesmalen accepted D143957: [LV] Move invalid cost remark code to separate function (NFC)..
Feb 15 2023, 2:07 PM · Restricted Project, Restricted Project
sdesmalen accepted D142542: [InstSimplify] Simplify icmp between Shl instructions of the same value.
Feb 15 2023, 7:12 AM · Restricted Project, Restricted Project
sdesmalen updated the diff for D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type..

Split out SROA changes into rG462227f1150f as suggested, and rebased this patch.

Feb 15 2023, 1:06 AM · Restricted Project, Restricted Project
sdesmalen committed rG462227f1150f: [SROA] NFC: Look at TypeStoreSize scalable property, rather than at type… (authored by sdesmalen).
[SROA] NFC: Look at TypeStoreSize scalable property, rather than at type…
Feb 15 2023, 1:02 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D142542: [InstSimplify] Simplify icmp between Shl instructions of the same value.
Feb 15 2023, 12:55 AM · Restricted Project, Restricted Project

Feb 14 2023

sdesmalen added inline comments to D142542: [InstSimplify] Simplify icmp between Shl instructions of the same value.
Feb 14 2023, 7:58 AM · Restricted Project, Restricted Project
sdesmalen added inline comments to D136861: [IR] Add LLVM IR support for target("aarch64.svcount") type..
Feb 14 2023, 6:57 AM · Restricted Project, Restricted Project