Page MenuHomePhabricator

lebedev.ri (Roman Lebedev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2012, 6:35 AM (422 w, 5 d)

Recent Activity

Yesterday

lebedev.ri added a reviewer for D92001: [ubsan] Fix crash on __builtin_assume_aligned: aaron.ballman.
Wed, Dec 2, 9:52 AM · Restricted Project, Restricted Project
lebedev.ri added inline comments to D92001: [ubsan] Fix crash on __builtin_assume_aligned.
Wed, Dec 2, 9:51 AM · Restricted Project, Restricted Project
lebedev.ri added a comment to D90328: Eliminates dead store of an exisiting value.

Terminology check: the store being eliminated isn't so much dead,
it's that the stored value is identical to the currently-stored value,
i.e. the store is effectively a no-op.

Wed, Dec 2, 7:28 AM · Restricted Project

Tue, Dec 1

lebedev.ri added a comment to D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

This should be simpler.
Just change DeadInstsTy (without defining it) to use weakWH instead of Instruction*, and update the code that needs updating to skip over nulled weakWH's.

Tue, Dec 1, 10:24 PM · Restricted Project
lebedev.ri committed rGd7fec38f0536: [DAGCombiner][NFC] Replace duplicate implementation flipBoolean with DAG. (authored by laytonio).
[DAGCombiner][NFC] Replace duplicate implementation flipBoolean with DAG.
Tue, Dec 1, 11:23 AM
lebedev.ri closed D92246: [DAGCombiner][NFC] Replace duplicate implementation flipBoolean with DAG.getLogicalNOT.
Tue, Dec 1, 11:23 AM · Restricted Project
lebedev.ri committed rGae7ec47fc655: [NFC][clang-tidy] Port rename_check.py to Python3 (authored by lebedev.ri).
[NFC][clang-tidy] Port rename_check.py to Python3
Tue, Dec 1, 9:11 AM
lebedev.ri updated the diff for D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check.

@aaron.ballman @aqjune thank you for taking a look!

Tue, Dec 1, 9:09 AM · Restricted Project, Restricted Project, Restricted Project
lebedev.ri committed rGfd679107d670: [InstCombine] Optimize away the unnecessary multi-use sign-extend (authored by Bhramar.vatsa).
[InstCombine] Optimize away the unnecessary multi-use sign-extend
Tue, Dec 1, 5:54 AM
lebedev.ri committed rG94ead0190ff1: [InstCombine] Improve vector undef handling for sext(ashr(shl(trunc()))) fold, 2 (authored by lebedev.ri).
[InstCombine] Improve vector undef handling for sext(ashr(shl(trunc()))) fold, 2
Tue, Dec 1, 5:54 AM
lebedev.ri closed D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend.
Tue, Dec 1, 5:54 AM · Restricted Project
lebedev.ri added a reverting change for rGaa1aa135097e: [InstCombine] Improve vector undef handling for sext(ashr(shl(trunc()))) fold: rG52533b52b868: Revert "[InstCombine] Improve vector undef handling for sext(ashr(shl(trunc….
Tue, Dec 1, 4:48 AM
lebedev.ri committed rG52533b52b868: Revert "[InstCombine] Improve vector undef handling for sext(ashr(shl(trunc… (authored by lebedev.ri).
Revert "[InstCombine] Improve vector undef handling for sext(ashr(shl(trunc…
Tue, Dec 1, 4:48 AM
lebedev.ri committed rG55c06a307034: [NFC][InstCombine] sext.ll: @test9: avoid only differently-cased names for… (authored by lebedev.ri).
[NFC][InstCombine] sext.ll: @test9: avoid only differently-cased names for…
Tue, Dec 1, 4:34 AM
lebedev.ri committed rGaa1aa135097e: [InstCombine] Improve vector undef handling for sext(ashr(shl(trunc()))) fold (authored by lebedev.ri).
[InstCombine] Improve vector undef handling for sext(ashr(shl(trunc()))) fold
Tue, Dec 1, 4:16 AM
lebedev.ri committed rG075faa8d40b1: [NFC][InstCombine] Improve vector undef test coverage for sext(ashr(shl(trunc… (authored by lebedev.ri).
[NFC][InstCombine] Improve vector undef test coverage for sext(ashr(shl(trunc…
Tue, Dec 1, 4:16 AM
lebedev.ri committed rG8e29e20e0d84: [InstCombine] Evaluate new shift amount for sext(ashr(shl(trunc()))) fold in… (authored by lebedev.ri).
[InstCombine] Evaluate new shift amount for sext(ashr(shl(trunc()))) fold in…
Tue, Dec 1, 4:16 AM
lebedev.ri committed rG799626b1117c: [NFC][InstCombine] Add PR48343 miscompiled testcase (authored by lebedev.ri).
[NFC][InstCombine] Add PR48343 miscompiled testcase
Tue, Dec 1, 4:16 AM
lebedev.ri committed rG0e11f3ade5ea: [NFC][InstCombine] Autogenerate sext.ll test checklines (authored by lebedev.ri).
[NFC][InstCombine] Autogenerate sext.ll test checklines
Tue, Dec 1, 4:16 AM
lebedev.ri committed rG15f8060f6f23: [SimplifyCFG] FoldBranchToCommonDest: don't require that cmp of br is last… (authored by lebedev.ri).
[SimplifyCFG] FoldBranchToCommonDest: don't require that cmp of br is last…
Tue, Dec 1, 4:15 AM
lebedev.ri committed rGb52029224c18: [NFC][SimplifyCFG] fold-branch-to-common-dest: add tests with cond of br not… (authored by lebedev.ri).
[NFC][SimplifyCFG] fold-branch-to-common-dest: add tests with cond of br not…
Tue, Dec 1, 4:15 AM
lebedev.ri added inline comments to D90349: [DAGCombiner] Improve shift by select of constant.
Tue, Dec 1, 1:07 AM · Restricted Project
lebedev.ri added a comment to D92367: [SCEV] Fix incorrect exit count calculated in error scope.

This is missing a test.
Please refer to llvm-project/llvm/test/Analysis/ScalarEvolution/pr48225.ll for inspiration.

Tue, Dec 1, 12:48 AM · Restricted Project

Mon, Nov 30

lebedev.ri added a comment to D84108: [SimplifyCFG][LoopRotate] SimplifyCFG: disable common instruction hoisting by default, enable late in pipeline.

Just a heads up: we are seeing a notable 3.5% regression caused by this change for ARM64 with LTO for CINT2006/473.astar.

I had a first look and it seems like there's some bad interactions with the LTO pipeline. The problem in this case is the following: we now rotate a loop just before the vectorizer which requires duplicating a function call in the preheader when compiling the individual files. But this then stops inlining during LTO. I'll look into whether we should avoid rotating such loops in the 'prepare-for-lto' stage.

Mon, Nov 30, 5:27 AM · Restricted Project
lebedev.ri committed rG317ca3ecf824: [NFC][clang-tidy] Do link FrontendOpenMP into concurrency module after all (authored by lebedev.ri).
[NFC][clang-tidy] Do link FrontendOpenMP into concurrency module after all
Mon, Nov 30, 2:34 AM
lebedev.ri committed rGcac5be495ed8: [clang-tidy] implement concurrency-mt-unsafe (authored by segoon).
[clang-tidy] implement concurrency-mt-unsafe
Mon, Nov 30, 1:28 AM
lebedev.ri committed rG8da7efbb0d5e: [clang-tidy] add concurrency module (authored by segoon).
[clang-tidy] add concurrency module
Mon, Nov 30, 1:28 AM
lebedev.ri committed rGb0e9b7c59fc4: [NFC][SimplifyCFG] Add STATISTIC() to the FoldValueComparisonIntoPredecessors()… (authored by lebedev.ri).
[NFC][SimplifyCFG] Add STATISTIC() to the FoldValueComparisonIntoPredecessors()…
Mon, Nov 30, 1:28 AM
lebedev.ri closed D90944: [clang-tidy] implement concurrency-mt-unsafe.
Mon, Nov 30, 1:28 AM · Restricted Project, Restricted Project
lebedev.ri closed D91656: [clang-tidy] add concurrency module.
Mon, Nov 30, 1:28 AM · Restricted Project, Restricted Project

Sun, Nov 29

lebedev.ri accepted D92247: [IR][LoopRotate] avoid leaving phi with no operands (PR48296).

This only matters for unreachable blocks,
so i think i agree that the assertion should be relaxed,
but this is a reasonable cleanup regardless.

Sun, Nov 29, 8:06 AM · Restricted Project

Fri, Nov 27

lebedev.ri accepted D92246: [DAGCombiner][NFC] Replace duplicate implementation flipBoolean with DAG.getLogicalNOT.

LGTM i guess, unless others have concerns.

Fri, Nov 27, 2:32 PM · Restricted Project
lebedev.ri added inline comments to D92247: [IR][LoopRotate] avoid leaving phi with no operands (PR48296).
Fri, Nov 27, 2:30 PM · Restricted Project
lebedev.ri added a comment to D92246: [DAGCombiner][NFC] Replace duplicate implementation flipBoolean with DAG.getLogicalNOT.

I'm not sure I understand the concern here. If its just the requirement to specify a VT, maybe we should add an overload of getLogicalNOT that doesn't require one? (and maybe getNOT while we're at it) It seems reusing the VT of whatever you're flipping is probably what you want most of the time anyway.

Fri, Nov 27, 1:43 PM · Restricted Project
lebedev.ri added a comment to D92247: [IR][LoopRotate] avoid leaving phi with no operands (PR48296).

I think the bug is downstream - removePredecessor()'s default for KeepOneInputPHIs is false,
so someone explicitly asked for this behaviour.

Fri, Nov 27, 1:31 PM · Restricted Project
lebedev.ri added a comment to D92246: [DAGCombiner][NFC] Replace duplicate implementation flipBoolean with DAG.getLogicalNOT.

I'm not really sure whether getting rid of flipBoolean() is a win.
I think i would instead suggest to refactor it to use getLogicalNOT() internally.

Fri, Nov 27, 1:11 PM · Restricted Project
lebedev.ri added a comment to D92237: [SCEVExpander] NFCI: Change Cost type in costAndCollectOperands from int -> unsigned..

I don't like this.
I intentionally made this change from unsigned to signed back in D67318,
and then followed the same pattern when re-writing isHighCostExpansionHelper(),
because using signed is that much more easy to catch budget overrun
as opposed to basically ensuring that each subtraction doesn't cause an overflow.

Fri, Nov 27, 10:19 AM · Restricted Project
lebedev.ri added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

Which LLVM IR intrinsics are affected by this?

Fri, Nov 27, 3:16 AM · Restricted Project
lebedev.ri accepted D92183: [DAG] Legalize umin(x,y) -> sub(x,usubsat(x,y)) and umax(x,y) -> add(x,usubsat(y,x)) iff usubsat is legal.

LGTM

Fri, Nov 27, 2:18 AM · Restricted Project
lebedev.ri committed rGb33fbbaa34f0: Reland [SimplifyCFG] FoldBranchToCommonDest: lift use-restriction on bonus… (authored by lebedev.ri).
Reland [SimplifyCFG] FoldBranchToCommonDest: lift use-restriction on bonus…
Fri, Nov 27, 1:48 AM
lebedev.ri committed rG40188063296f: [NFC][SimplifyCFG] FoldBranchToCommonDest: add one more test with PHI (authored by lebedev.ri).
[NFC][SimplifyCFG] FoldBranchToCommonDest: add one more test with PHI
Fri, Nov 27, 1:48 AM

Thu, Nov 26

lebedev.ri added a comment to D91711: SCEV add function to see if SCEVUnknown is null.

+1, i'm also uncomfortable with both the direction and approach.

Thu, Nov 26, 10:31 PM · Restricted Project
lebedev.ri accepted D90944: [clang-tidy] implement concurrency-mt-unsafe.

Please upload all patches with full context (-U9999)
I'm guessing you'll need help committing this, in which case please specify Author <e@ma.il> to be used for git commit --author="<>"

Thu, Nov 26, 10:25 PM · Restricted Project, Restricted Project
lebedev.ri added a comment to D91656: [clang-tidy] add concurrency module.
  • fix sort order
Thu, Nov 26, 10:18 PM · Restricted Project, Restricted Project
lebedev.ri retitled D92139: [PowerPC] Add `hasSideEffects=0` for PLXVP and PSTXVP instructions definition from Add `hasSideEffects=0` for PLXVP and PSTXVP instructions definition to [PowerPC] Add `hasSideEffects=0` for PLXVP and PSTXVP instructions definition .
Thu, Nov 26, 1:11 PM · Restricted Project
lebedev.ri added a reverting change for rG2245fb8aaa1c: [SimplifyCFG] FoldBranchToCommonDest: lift use-restriction on bonus instructions: rGf3abd54958ab: Revert "[SimplifyCFG] FoldBranchToCommonDest: lift use-restriction on bonus….
Thu, Nov 26, 12:15 PM
lebedev.ri committed rGf3abd54958ab: Revert "[SimplifyCFG] FoldBranchToCommonDest: lift use-restriction on bonus… (authored by lebedev.ri).
Revert "[SimplifyCFG] FoldBranchToCommonDest: lift use-restriction on bonus…
Thu, Nov 26, 12:14 PM
lebedev.ri committed rG394b4fdb4154: [NFC][SimplifyCFG] Add test coverage for FoldBranchToCommonDest xform with live… (authored by lebedev.ri).
[NFC][SimplifyCFG] Add test coverage for FoldBranchToCommonDest xform with live…
Thu, Nov 26, 11:52 AM
lebedev.ri committed rG2245fb8aaa1c: [SimplifyCFG] FoldBranchToCommonDest: lift use-restriction on bonus instructions (authored by lebedev.ri).
[SimplifyCFG] FoldBranchToCommonDest: lift use-restriction on bonus instructions
Thu, Nov 26, 11:52 AM
lebedev.ri committed rG65db7d38e050: [NFC][SimplifyCFG] Add statistic to `FoldBranchToCommonDest()` fold (authored by lebedev.ri).
[NFC][SimplifyCFG] Add statistic to `FoldBranchToCommonDest()` fold
Thu, Nov 26, 11:52 AM
lebedev.ri added a comment to D90944: [clang-tidy] implement concurrency-mt-unsafe.
  • move static vectors out of namespace

Nice.

Thu, Nov 26, 9:04 AM · Restricted Project, Restricted Project
lebedev.ri added a comment to D51650: Implement target_clones multiversioning.

Fix @rsmith s comments, rebase on the big CPUDispatch refactor.

Thu, Nov 26, 8:36 AM
lebedev.ri added a comment to D90944: [clang-tidy] implement concurrency-mt-unsafe.

Looks good to me, but i'm still uneasy about doing the checking in inverted sense.

Thu, Nov 26, 1:58 AM · Restricted Project, Restricted Project
lebedev.ri added a comment to D91656: [clang-tidy] add concurrency module.

Not really, i think this should be landed together with it's dependee, which is not ready yet.

Thu, Nov 26, 1:55 AM · Restricted Project, Restricted Project

Wed, Nov 25

lebedev.ri committed rGba74fa244f4c: [AMDGPU] Actually fully update opt-pipeline.ll test to account for -loop-idiom… (authored by lebedev.ri).
[AMDGPU] Actually fully update opt-pipeline.ll test to account for -loop-idiom…
Wed, Nov 25, 8:40 AM
lebedev.ri accepted D92102: [DAG] Legalize abs(x) -> umin(x,sub(0,x)) iff umin/sub are legal.

Looks good to me. (https://alive2.llvm.org/ce/z/q2hB9w)

Wed, Nov 25, 8:28 AM · Restricted Project
lebedev.ri committed rGa8d74517dcff: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop… (authored by lebedev.ri).
[PassManager] Run Induction Variable Simplification pass *after* Recognize loop…
Wed, Nov 25, 8:21 AM
lebedev.ri closed D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before.
Wed, Nov 25, 8:20 AM · Restricted Project
lebedev.ri added a comment to D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before.

I ran some more benchmarks, and they look good. Lets give this a try and if someone finds an issue we can always adjust it.

LGTM

Wed, Nov 25, 8:15 AM · Restricted Project
lebedev.ri accepted D92095: [DAG] Legalize abs(x) -> smax(x,sub(0,x)) iff smax/sub are legal.

Actually, never mind. The current expansion is identically undef-unsafe, iff ISD::ABS is ever undef-producing/inducing:
https://alive2.llvm.org/ce/z/eJwDHC
https://alive2.llvm.org/ce/z/z6fGbG

Wed, Nov 25, 6:00 AM · Restricted Project
lebedev.ri added a comment to D92095: [DAG] Legalize abs(x) -> smax(x,sub(0,x)) iff smax/sub are legal.

Remind me, for ISD::ABS, what happens for INT_MIN input?
https://alive2.llvm.org/ce/z/_KMTWi
https://alive2.llvm.org/ce/z/p8CnZa

Wed, Nov 25, 5:45 AM · Restricted Project
lebedev.ri retitled D92041: [clangd] Add hover info for `this` expr from Add hover info for `this` expr to [clangd] Add hover info for `this` expr.
Wed, Nov 25, 12:14 AM · Restricted Project, Restricted Project
lebedev.ri updated the diff for D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before.

I have certainly seen places where we have managed to recognize a loop as a memcpy/memset, but not remove the remaining now empty loop. Here is some more fuel for your fire if you need it: https://godbolt.org/z/eW4rsY

Wed, Nov 25, 12:08 AM · Restricted Project
lebedev.ri committed rG0bf3d4bc3121: [NFC][ARM][PhaseOrdering] Add one more test for D91800: LoopIdiom should be… (authored by lebedev.ri).
[NFC][ARM][PhaseOrdering] Add one more test for D91800: LoopIdiom should be…
Wed, Nov 25, 12:03 AM

Mon, Nov 23

lebedev.ri added a comment to D75072: [SCEV] Record NI types in add exprs.

This needs a rebase.

Mon, Nov 23, 10:23 PM · Restricted Project, Restricted Project
lebedev.ri retitled D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs from clang-tidy: detect narrowing conversions involving typedefs to [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs.
Mon, Nov 23, 10:29 AM · Restricted Project
lebedev.ri edited reviewers for D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs, added: aaron.ballman, njames93; removed: gchatelet, courbet.

Whoa, that's a fun bug :)

Mon, Nov 23, 10:28 AM · Restricted Project
lebedev.ri added inline comments to D91968: llvm/ADT/StringExtras.h hexDigitValue - Init of integer buffer.
Mon, Nov 23, 8:38 AM · Restricted Project
lebedev.ri accepted D91656: [clang-tidy] add concurrency module.

LGTM

Mon, Nov 23, 4:10 AM · Restricted Project, Restricted Project

Sun, Nov 22

lebedev.ri added a comment to D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check.

Ping.
If there's no pushback within next 24h i will commit this and wait for post-commit review (if any).
Thanks.

Sun, Nov 22, 10:41 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Nov 21

lebedev.ri added a comment to D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes.

The associated comment suggested that GCC keeps this extension enabled in C90/C++03 standard-conforming mode, but it actually does not, so rather than adding a check for C++ language version, this change simply removes the check for C language version.

Sat, Nov 21, 9:32 AM · Restricted Project

Fri, Nov 20

lebedev.ri added a comment to D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before.

Do we have phase ordering tests for various memset/memcpy loops?

We clearly do not.

Fri, Nov 20, 9:02 AM · Restricted Project

Thu, Nov 19

lebedev.ri added a reviewer for D91525: [LoopLoadElim] Make sure all loops are in simplify form. PR48150: aeubanks.

(this is new-pm-specific)

Thu, Nov 19, 11:31 PM · Restricted Project
lebedev.ri added reviewers for D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before: MaskRay, dmgreen, sanwou01.

(adding some more people potentially-relevant people)

Thu, Nov 19, 2:06 PM · Restricted Project
lebedev.ri added a comment to D91786: [GVN] Strengthen the updating of dominated users.

As of D90231 i'm personally still unconvinced that it is the LLVM code that needs fixing and not the particular code that is using __builtin_constant_p().

Thu, Nov 19, 2:01 PM · Restricted Project
lebedev.ri added a reviewer for D91786: [GVN] Strengthen the updating of dominated users: fhahn.
Thu, Nov 19, 2:00 PM · Restricted Project
lebedev.ri added a comment to D91038: [LoopIdiom] Introduce 'left-shift until bittest' idiom.

(This is in a need of a bit of rebase once i'm ready to post the final patch to actually rewrite the loop into countable.)

Thu, Nov 19, 1:56 PM · Restricted Project
lebedev.ri committed rGa91e96702a3b: [InstCombine] Fold `and(shl(zext(x), width(SIGNMASK) - width(%x)), SIGNMASK)`… (authored by lebedev.ri).
[InstCombine] Fold `and(shl(zext(x), width(SIGNMASK) - width(%x)), SIGNMASK)`…
Thu, Nov 19, 1:32 PM
lebedev.ri committed rGbcd469a9912b: [NFC][InstCombine] Add test coverage for `and (sext %x), SIGNMASK`-like pattern (authored by lebedev.ri).
[NFC][InstCombine] Add test coverage for `and (sext %x), SIGNMASK`-like pattern
Thu, Nov 19, 1:32 PM
lebedev.ri updated the summary of D91038: [LoopIdiom] Introduce 'left-shift until bittest' idiom.
Thu, Nov 19, 10:21 AM · Restricted Project
lebedev.ri retitled D91803: [lld] Use -1 as tombstone value for discarded code ranges from Use -1 as tombstone value for discarded code ranges to [lld] Use -1 as tombstone value for discarded code ranges.
Thu, Nov 19, 9:31 AM · Restricted Project
lebedev.ri updated the diff for D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before.

Fix one more pipeline structure test.

Thu, Nov 19, 9:06 AM · Restricted Project
lebedev.ri updated the summary of D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before.
Thu, Nov 19, 9:01 AM · Restricted Project
lebedev.ri retitled D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before from [PassManager] Run nduction Variable Simplification pass *after* Recognize loop idioms pass, not before to [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before.
Thu, Nov 19, 8:52 AM · Restricted Project
lebedev.ri added reviewers for D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before: craig.topper, reames.
Thu, Nov 19, 8:50 AM · Restricted Project
lebedev.ri requested review of D91800: [PassManager] Run Induction Variable Simplification pass *after* Recognize loop idioms pass, not before.
Thu, Nov 19, 8:48 AM · Restricted Project
lebedev.ri committed rG908e26d511ce: [NFC][PhaseOrdering] Add a test showing the need to run IndVars after LoopIdiom (authored by lebedev.ri).
[NFC][PhaseOrdering] Add a test showing the need to run IndVars after LoopIdiom
Thu, Nov 19, 8:44 AM

Wed, Nov 18

lebedev.ri added a comment to D91574: [libc++] Simplify how we pick the typeinfo comparison.

This seems to have broken no-op rebuild w/ existing build dir:

CMake Error at /repositories/llvm-project/libcxx/CMakeLists.txt:187 (message):
  Value '' is not a valid value for
Wed, Nov 18, 10:33 PM · Restricted Project
lebedev.ri committed rG7bf89c2174f0: [NFC][Reassociate] Delay checking isLoadCombineCandidate() until after… (authored by lebedev.ri).
[NFC][Reassociate] Delay checking isLoadCombineCandidate() until after…
Wed, Nov 18, 12:58 PM
lebedev.ri updated the diff for D91726: [LoopIdiom] 'left-shift until bittest' idiom: support canonical sign bit mask.

Do recurrence analysis afterwards, not when matching backedge condition.

Wed, Nov 18, 11:18 AM · Restricted Project
lebedev.ri updated the diff for D91725: [LoopIdiom] 'left-shift until bittest' idiom: support constant bit mask.

Do recurrence analysis afterwards, not when matching backedge condition.

Wed, Nov 18, 11:18 AM · Restricted Project
lebedev.ri updated the diff for D91038: [LoopIdiom] Introduce 'left-shift until bittest' idiom.

Do recurrence analysis afterwards, not when matching backedge condition.

Wed, Nov 18, 11:18 AM · Restricted Project
lebedev.ri updated the diff for D91038: [LoopIdiom] Introduce 'left-shift until bittest' idiom.

Rebase, NFC.

Wed, Nov 18, 10:28 AM · Restricted Project
lebedev.ri requested review of D91726: [LoopIdiom] 'left-shift until bittest' idiom: support canonical sign bit mask.
Wed, Nov 18, 10:28 AM · Restricted Project
lebedev.ri requested review of D91725: [LoopIdiom] 'left-shift until bittest' idiom: support constant bit mask.
Wed, Nov 18, 10:28 AM · Restricted Project
lebedev.ri committed rG8b9e6dc50146: [NFC][LoopIdiom] Left-shift-until-bittest: revisit test coverage (authored by lebedev.ri).
[NFC][LoopIdiom] Left-shift-until-bittest: revisit test coverage
Wed, Nov 18, 10:23 AM
lebedev.ri added a reviewer for D91677: Avoid simplification of library functions when callee has an implementation: gchatelet.

And by mark them, you could also use -fno-builtin=???, see D68028.

Wed, Nov 18, 9:55 AM · Restricted Project
lebedev.ri requested changes to D91677: Avoid simplification of library functions when callee has an implementation.
Wed, Nov 18, 9:07 AM · Restricted Project
lebedev.ri added inline comments to rG34ff90ad5d7d: [Reassociate] Don't convert add-like-or's into add's if they appear to be part….
Wed, Nov 18, 8:11 AM
lebedev.ri committed rG34ff90ad5d7d: [Reassociate] Don't convert add-like-or's into add's if they appear to be part… (authored by lebedev.ri).
[Reassociate] Don't convert add-like-or's into add's if they appear to be part…
Wed, Nov 18, 6:55 AM