Page MenuHomePhabricator

lebedev.ri (Roman Lebedev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2012, 6:35 AM (350 w, 5 d)

Recent Activity

Today

lebedev.ri added a comment to D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).

@xbolva00, @spatel, @efriedma thank you for the review!

Thu, Jul 18, 3:20 PM · Restricted Project
lebedev.ri added inline comments to D62100: [DAGCombine][X86][AMDGPU][AArch64] (srl (shl x, c1), c2) with c1 != c2 handling.
Thu, Jul 18, 8:57 AM · Restricted Project
lebedev.ri updated the diff for D63963: [Codegen][SelectionDAG] X u% C == 0 fold: non-splat vector improvements.

Address review notes.
While turnVectorIntoSplatVector() change is not NFC, i don't believe that issue can be triggered through it's only user.

Thu, Jul 18, 5:18 AM · Restricted Project
lebedev.ri added inline comments to D63963: [Codegen][SelectionDAG] X u% C == 0 fold: non-splat vector improvements.
Thu, Jul 18, 4:10 AM · Restricted Project
lebedev.ri added inline comments to D64910: [IPRA][ARM] Disable no-CSR optimisation for ARM.
Thu, Jul 18, 3:25 AM · Restricted Project

Yesterday

lebedev.ri added a reviewer for D64819: [UpdateTestChecks][Bug41532] Add handle of basic block names.: RKSimon.
Wed, Jul 17, 11:07 PM · Restricted Project
lebedev.ri added a comment to D64889: [OPENMP] getDSA(): handle loop control variables.

Needs a test

Wed, Jul 17, 3:22 PM · Restricted Project, Restricted Project
lebedev.ri added a comment to D62871: [Codegen] (X & (C l>>/<< Y)) ==/!= 0 --> ((X <</l>> Y) & C) ==/!= 0 fold.

ping

Wed, Jul 17, 3:15 PM · Restricted Project
lebedev.ri added a comment to D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).

With InstSimplify, we're using a potentially expensive/recursive analysis (similar to ValueTracking), and we know that's where InstCombine spends a lot of time.

Wed, Jul 17, 3:13 PM · Restricted Project
lebedev.ri added a comment to D64695: [clang-format] Added new style rule: SortNetBSDIncludes.

Is there sufficient test coverage as to what happens if SortPriority is not set?

If SortPriority is not set, the Includes will be grouped without sorting,

Wed, Jul 17, 10:33 AM · Restricted Project
lebedev.ri added a comment to D64695: [clang-format] Added new style rule: SortNetBSDIncludes.

Is there sufficient test coverage as to what happens if SortPriority is not set?

Wed, Jul 17, 7:56 AM · Restricted Project

Tue, Jul 16

lebedev.ri added inline comments to D64819: [UpdateTestChecks][Bug41532] Add handle of basic block names..
Tue, Jul 16, 2:20 PM · Restricted Project
lebedev.ri added inline comments to D64819: [UpdateTestChecks][Bug41532] Add handle of basic block names..
Tue, Jul 16, 1:57 PM · Restricted Project
lebedev.ri added reviewers for D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops: JonasToth, gribozavr.

Thanks.
Are there any tests missing for volatile, atomics?
I'm not really current on clang-tidy state of affairs, so i'm gonna leave most of the review for others..

Tue, Jul 16, 11:32 AM · Restricted Project, Restricted Project
lebedev.ri added inline comments to D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.
Tue, Jul 16, 10:22 AM · Restricted Project
lebedev.ri added a comment to D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).

To follow-up on inline comment - right now (llvm master vs llvm master with this patchset; rawspeed develop with no patches ontop) this fold happens once:

$ /repositories/llvm-test-suite/utils/compare.py -m instcombine.MasksDroped /builddirs/llvm-project/build-llvm-test-suite-{old,new}/results.json
/repositories/llvm-test-suite/utils/compare.py:109: FutureWarning: Sorting because non-concatenation axis is not aligned. A future version
of pandas will change to not sort by default.
Tue, Jul 16, 10:05 AM · Restricted Project
lebedev.ri added a comment to D62392: [DAGCombine][ARM] (sub Carry, X) -> (addcarry (sub 0, X), 0, Carry) fold.

Maybe it is worth adding some platform dependent check to actually make sure turning the carry into a scalar is expensive? Or is it a reasonable assumption to make that it expensive on all plateforms?

I honestly don't know the answers to these questions, carry nodes are not my strong side,
If you want (given your recent carry patches), you can totally take this patch over.

Tue, Jul 16, 9:44 AM · Restricted Project
lebedev.ri added inline comments to D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).
Tue, Jul 16, 8:42 AM · Restricted Project
lebedev.ri added a comment to D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).

@spatel any comments?

Tue, Jul 16, 6:35 AM · Restricted Project
lebedev.ri added a comment to D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).

Up.
I'm perfectly happy to do trivial follow-up patches in post-commit review mode,
but i feel like the base patch/the approach might be good to be reviewed..

Tue, Jul 16, 4:45 AM · Restricted Project
lebedev.ri resigned from D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0.

(i'm not touching fp folds)

Tue, Jul 16, 4:41 AM · Restricted Project

Mon, Jul 15

lebedev.ri retitled D64705: [WebAssembly] Add missing utility methods for exnref type from Add missing utility methods for exnref type to [WASM] Add missing utility methods for exnref type.
Mon, Jul 15, 2:54 PM · Restricted Project
lebedev.ri retitled D64748: [CTU] Refactor threshold checking from Refactor threshold checking to [CTU] Refactor threshold checking.
Mon, Jul 15, 9:17 AM · Restricted Project
lebedev.ri added a comment to D64695: [clang-format] Added new style rule: SortNetBSDIncludes.

I am not quite sure why this change is required to sort the headers for NetBSD, you can set the priorities via IncludeStyle.IncludeCategories. Is that not sufficient?

It can be done by setting priorities in IncludeCategories, but here we have nearly 40+ cases and categories to hardcode due to complex interdependencies between their headers. So, I have added this style reducing the cases using regex. And if this is fully parameterised any OS related project can add their own header priorities.

Mon, Jul 15, 9:17 AM · Restricted Project
lebedev.ri requested changes to D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.

Thanks for working on this!
You want to use clang/Analysis/Analyses/ExprMutationAnalyzer.h.
See also: D51870

Mon, Jul 15, 6:34 AM · Restricted Project, Restricted Project
lebedev.ri updated subscribers of D64677: [SemaTemplate] Fix uncorrected typos after pack expansion.
Mon, Jul 15, 2:46 AM · Restricted Project

Sun, Jul 14

lebedev.ri added a comment to D64708: [ValueTracking] Look through constant Int2Ptr/Ptr2Int expressions.

Looks good to me.

Sun, Jul 14, 11:48 AM · Restricted Project
lebedev.ri added inline comments to D37215: [ValueTracking] improve reverse assumption inference.
Sun, Jul 14, 8:46 AM · Restricted Project
lebedev.ri updated the diff for D63963: [Codegen][SelectionDAG] X u% C == 0 fold: non-splat vector improvements.

Thanks for taking a look!
Rebased, addressed review notes.

Sun, Jul 14, 8:18 AM · Restricted Project
lebedev.ri updated the diff for D64038: [IR][PatternMatch] Introduce m_NegatedPower2() matcher.

Rebased, added INT_MIN test.

Sun, Jul 14, 6:36 AM · Restricted Project
lebedev.ri updated the diff for D64037: [IR][PatternMatch] introduce m_Unless() matcher.

Rebased, NFC.

Sun, Jul 14, 6:36 AM · Restricted Project
lebedev.ri added a comment to D64038: [IR][PatternMatch] Introduce m_NegatedPower2() matcher.

reverse ping?

Sun, Jul 14, 6:02 AM · Restricted Project

Sat, Jul 13

lebedev.ri resigned from D64656: Ensure placeholder instruction for cleanup is created.

My understanding of the issue is that clang emits incorrect IR. Without my fix and when disabling the assertion mentioned in the commit message by commenting it out, llvm-lit gives the following output when executed against the minimal test case in the current version of the commit:

+ /home/maestro/llvm/llvm-project/build/bin/clang -cc1 -internal-isystem /home/maestro/llvm/llvm-project/build/lib/clang/9.0.0/include -nostdsysteminc -emit-obj --std=c++17 -fcxx-exceptions -fexceptions /home/maestro/llvm/llvm-project/clang/test/CodeGenCXX/pr40771-ctad-with-lambda-copy-capture.cpp
Instruction referencing instruction not embedded in a basic block!
  %cleanup.isactive = alloca i1, align 1
  store i1 true, i1* %cleanup.isactive, align 1
in function __cxx_global_var_init.1
fatal error: error in backend: Broken function found, compilation aborted!

This is what makes me assume that the IR output is incorrect.

Aha, this i didn't see before, thank you.
Then i agree the clang fix is needed.

Sat, Jul 13, 8:38 AM · Restricted Project
lebedev.ri added a comment to D64656: Ensure placeholder instruction for cleanup is created.

Hm, i have a question about this fix.
As it can be seen the C++17 code is successfully codegened by clang to LLVM IR, and the actual failure is in LLVM middle-end optimization pass:
https://godbolt.org/z/P3RB23

  1. Please file a bug about that pass crash, include that link. It most definitively should not crash.

As i can now see, there is one in https://bugs.llvm.org/show_bug.cgi?id=40771

Sat, Jul 13, 7:53 AM · Restricted Project
lebedev.ri added a comment to D64656: Ensure placeholder instruction for cleanup is created.

Hm, i have a question about this fix.
As it can be seen the C++17 code is successfully codegened by clang to LLVM IR, and the actual failure is in LLVM middle-end optimization pass:
https://godbolt.org/z/P3RB23

  1. Please file a bug about that pass crash, include that link. It most definitively should not crash.
  2. Is this fix just workarounding that crash, or is the clang producing incorrect IR without this fix, miscompiling it?
Sat, Jul 13, 7:22 AM · Restricted Project
lebedev.ri requested changes to D64656: Ensure placeholder instruction for cleanup is created.

Sorry, i still don't like the test.
You want to check the produced IR.

Sat, Jul 13, 5:32 AM · Restricted Project

Fri, Jul 12

lebedev.ri retitled D64687: [clang] Revert "Remove __VERSION__" from Revert "Remove __VERSION__" to [clang] Revert "Remove __VERSION__".
Fri, Jul 12, 11:08 PM · Restricted Project
lebedev.ri added inline comments to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..
Fri, Jul 12, 11:07 PM · Restricted Project
lebedev.ri added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

This certainly needs more tests: macros, -x C, ???

Fri, Jul 12, 3:18 PM · Restricted Project
lebedev.ri added inline comments to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..
Fri, Jul 12, 3:06 PM · Restricted Project
lebedev.ri added inline comments to D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).
Fri, Jul 12, 2:29 PM · Restricted Project
lebedev.ri added inline comments to D64517: [InstCombine] Dropping redundant masking before left-shift [2/5] (PR42563).
Fri, Jul 12, 2:29 PM · Restricted Project
lebedev.ri added inline comments to D64656: Ensure placeholder instruction for cleanup is created.
Fri, Jul 12, 2:16 PM · Restricted Project
lebedev.ri added inline comments to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).
Fri, Jul 12, 1:35 PM · Restricted Project
lebedev.ri added a comment to D64656: Ensure placeholder instruction for cleanup is created.

Test?

Fri, Jul 12, 12:29 PM · Restricted Project
lebedev.ri added a comment to D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Test?

Fri, Jul 12, 9:51 AM · Restricted Project
Herald added a project to D56563: [clang-tidy] add options documentation to readability-identifier-naming checker: Restricted Project.

Is this doc supposed to be autogenerated somehow?
I believe MacroDefinitionCase (D21020) is missing from it, maybe others.

Fri, Jul 12, 6:35 AM · Restricted Project, Restricted Project
lebedev.ri added a comment to D64534: Remove OMP spec versioning.

How does this play with -fopenmp-version= clang switches;
This doesn't remove any public api, only makes all of it available "unconditionall", correct?

AFAICT, yes.

Ok.

Fri, Jul 12, 4:25 AM · Restricted Project, Restricted Project
lebedev.ri added a comment to D64534: Remove OMP spec versioning.

How does this play with -fopenmp-version= clang switches;
This doesn't remove any public api, only makes all of it available "unconditionall", correct?

Fri, Jul 12, 3:46 AM · Restricted Project, Restricted Project

Thu, Jul 11

lebedev.ri added a comment to D64607: [clang-tidy] Fix crash on end location inside macro.

Test?

Thu, Jul 11, 11:03 PM · Restricted Project, Restricted Project
lebedev.ri added inline comments to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..
Thu, Jul 11, 4:14 PM · Restricted Project
lebedev.ri added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Nice, thanks for looking into this.
I think this is good, @RKSimon ?

Thu, Jul 11, 3:58 PM · Restricted Project
lebedev.ri added a comment to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..

Hm, not that ugly; this is still correct?

Thu, Jul 11, 2:44 PM · Restricted Project
lebedev.ri added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

I'm not confident that will do the right thing. (i expect this to have some false-negatives, iff it is allowed to specify -check-prefix= more than once)
I see two paths:

  1. split the runline by whitespace, and check every element that starts with -check-prefix= that it does not contain ,. Will not have false-positives and no false-negatives, but kinda ugly.
  2. Revert to the previous diff, complain if there are any -check-prefix= IFF we had more than a single prefix; the warning will need to be changed - it will have false-positives - so it is more of a stylistic guideline.
Thu, Jul 11, 2:08 PM · Restricted Project
lebedev.ri added inline comments to D63097: [cmake] Don't add Support/Testing library if tests are not included.
Thu, Jul 11, 1:59 PM · Restricted Project
lebedev.ri added a comment to D64592: [OpenMP] Fix declare target link implementation.

Description lacking.
Why is that bad?
How does this play wrt reproducibility of the output?
Normally value names in IR are completely discarded in Release build mode, why do they matter here?

Thu, Jul 11, 1:54 PM · Restricted Project
lebedev.ri added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Thank you, i have stumbled into this a few times :)

Thu, Jul 11, 1:47 PM · Restricted Project
lebedev.ri added inline comments to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..
Thu, Jul 11, 1:17 PM · Restricted Project
lebedev.ri accepted D64572: [UpdateTestChecks] Emit warning when invalid test paths.

(didn't see i'm on the review list here)

Thu, Jul 11, 12:34 PM · Restricted Project
lebedev.ri accepted D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

Sorry for so may triparounds :(
Please re-re-precommit the tests first.
I guess this will work, with 2 nits addressed :)

Thu, Jul 11, 12:34 PM · Restricted Project
lebedev.ri added inline comments to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..
Thu, Jul 11, 11:51 AM · Restricted Project
lebedev.ri added inline comments to D64388: Explicitly define __STDC_FORMAT_MACROS for PRIu64.
Thu, Jul 11, 11:12 AM · Restricted Project, Restricted Project
lebedev.ri added inline comments to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..
Thu, Jul 11, 11:12 AM · Restricted Project
lebedev.ri added a comment to D64572: [UpdateTestChecks] Emit warning when invalid test paths.

I personally think hard error may be worse.

Thu, Jul 11, 9:51 AM · Restricted Project
lebedev.ri added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

Ugly, yeah, but powerful instsimplify is nice ^^

I feel pretty strongly that this is the not the right tradeoff to make here.

Unless there's some specific evidence that we benefit from having this in instsimplify,
reducing code duplication is imho much more valuable than making sure that
one out of thousands of ad-hoc folds runs in a few more cases than it otherwise would...

Feel free to bring this up as RFC on llvm-dev.

Thu, Jul 11, 9:48 AM · Restricted Project
lebedev.ri updated subscribers of D63488: [docs] Phabricator, not the lists is the main entry point for new patches.

So, i did submit the RFC in https://lists.llvm.org/pipermail/llvm-dev/2019-June/133162.html
There were 6 replies from 5 people, summary:

So no one opposed this, everyone liked it.
The point about lists being subscribed, and being ready to reply to
mail-only comments i did not change, i believe that is all already stated.

Thu, Jul 11, 8:36 AM · Restricted Project
lebedev.ri added inline comments to D64568: [NFC] Update header files to inclue language tags like -*- C++ -*-.
Thu, Jul 11, 8:10 AM · Restricted Project
lebedev.ri added a comment to D64568: [NFC] Update header files to inclue language tags like -*- C++ -*-.

The beginning of the first line, even in this diff, is inconsistent, too.

Thu, Jul 11, 8:02 AM · Restricted Project
lebedev.ri accepted D58875: [X86] Merge negated ISD::SUB nodes into X86ISD::SUB equivalent (PR40483) (WIP).

Looks fine to me too.

Thu, Jul 11, 7:59 AM · Restricted Project
lebedev.ri added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

It'd be really great to have at just least one positive non-splat-vector test for instsimplify and instcombine for each predicate (i.e. 4 more tests?)

Thu, Jul 11, 7:11 AM · Restricted Project
lebedev.ri added inline comments to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).
Thu, Jul 11, 6:26 AM · Restricted Project
lebedev.ri added inline comments to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).
Thu, Jul 11, 6:23 AM · Restricted Project
lebedev.ri added inline comments to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).
Thu, Jul 11, 5:57 AM · Restricted Project
lebedev.ri added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

Ugly, yeah, but powerful instsimplify is nice ^^

I feel pretty strongly that this is the not the right tradeoff to make here. Unless there's some specific evidence that we benefit from having this in instsimplify, reducing code duplication is imho much more valuable than making sure that one out of thousands of ad-hoc folds runs in a few more cases than it otherwise would...

Thu, Jul 11, 5:54 AM · Restricted Project
lebedev.ri requested changes to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

Nice, pretty much there!

Thu, Jul 11, 5:54 AM · Restricted Project
lebedev.ri added inline comments to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).
Thu, Jul 11, 5:25 AM · Restricted Project
lebedev.ri added a comment to D64551: [X86] EltsFromConsecutiveLoads - support common source loads.

Is that what if (LD->getChain() != Base->getChain()) return false; does?

Yes, chains will handle these kinds of dependencies

Great to know! No other comments from me.

Thu, Jul 11, 5:24 AM · Restricted Project
lebedev.ri added a comment to D64551: [X86] EltsFromConsecutiveLoads - support common source loads.

Does this need to do anything to ensure that there are no interferences, in the sense of non-known-noalias writes?

That's what areNonVolatileConsecutiveLoads handles no?

Thu, Jul 11, 4:39 AM · Restricted Project
lebedev.ri added a comment to D64553: [LoopUtils] Extend the scope of getLoopEstimatedTripCount.

May be good to have a test.

Thu, Jul 11, 3:35 AM · Restricted Project
lebedev.ri added a comment to D64551: [X86] EltsFromConsecutiveLoads - support common source loads.

Does this need to do anything to ensure that there are no interferences, in the sense of non-known-noalias writes?

Thu, Jul 11, 3:33 AM · Restricted Project
lebedev.ri accepted D42047: [PatternMatch] Implement matching code for LibFunc.

Use NoBuiltin

Thu, Jul 11, 12:28 AM · Restricted Project
lebedev.ri requested changes to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..

(just marking as reviewed)

Thu, Jul 11, 12:28 AM · Restricted Project

Wed, Jul 10

lebedev.ri added a comment to D64057: Add NetBSD LSan support.

I've landed this version as it is good enough to land LLVM-9.

Unfortunately many tests fail as they seem to be tuned for Linux/Darwin.

Please see:

https://reviews.llvm.org/D64057#1565937

@vitalybuka how to address these problems?

Wed, Jul 10, 11:58 PM · Restricted Project
lebedev.ri added inline comments to D42047: [PatternMatch] Implement matching code for LibFunc.
Wed, Jul 10, 11:56 PM · Restricted Project
lebedev.ri added a comment to D64275: [InstCombine] Generalize InstCombiner::foldAndOrOfICmpsOfAndWithPow2()..

I think this looks ok, but i'd like to see more test coverage :)

Wed, Jul 10, 11:48 PM · Restricted Project
lebedev.ri added a comment to D64543: [Docs] Add standardized header links to analyzer doc.

I like this!

Wed, Jul 10, 11:01 PM · Restricted Project, Restricted Project
lebedev.ri requested changes to D48222: Check Sched Class tables at generation time - 2.

(removing from my review queue)

Wed, Jul 10, 3:33 PM
lebedev.ri added reviewers for D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO": vsk, eugenis.
Wed, Jul 10, 3:33 PM · Restricted Project, Restricted Project, Restricted Project
lebedev.ri requested changes to D47637: Check Sched Class tables at generation time.

(removing from my review queue)

Wed, Jul 10, 3:33 PM
lebedev.ri requested changes to D51553: [DAGCombiner][x86] add transform/hook to load a scalar directly for use in a vector binop.

(just removing from review queue)

Wed, Jul 10, 3:33 PM · Restricted Project
lebedev.ri requested changes to D47735: [DAGCombiner] Create rotates more aggressively.

After thinking about it, i think it may make sense to have this after all.
I left some comments.

Wed, Jul 10, 3:33 PM · Restricted Project
lebedev.ri requested changes to D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180).
Wed, Jul 10, 2:57 PM · Restricted Project
lebedev.ri resigned from D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static.

Sorry, it does not appear that i'm being useful in this review.

Wed, Jul 10, 2:57 PM · Restricted Project, Restricted Project, Restricted Project
lebedev.ri accepted D61653: [ConstantRange] Add makeAllowedNoWrapRegion().

I'm sorry.
I was initially hoping someone else would comment on the semantics (@sanjoy ?),
but then this has completely fallen off my radar.

Wed, Jul 10, 2:57 PM · Restricted Project
lebedev.ri requested changes to D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced..
Wed, Jul 10, 2:45 PM · Restricted Project, Restricted Project
lebedev.ri resigned from D54141: [clang-tidy] add deduplication support for run-clang-tidy.py.
Wed, Jul 10, 2:42 PM · Restricted Project, Restricted Project
lebedev.ri requested changes to D42047: [PatternMatch] Implement matching code for LibFunc.

(no new comments - still looks ok other than lack of at least one negative test - just marking as reviewed)

Wed, Jul 10, 2:38 PM · Restricted Project
lebedev.ri added a comment to D64468: Replace three "strip & accumulate" implementations with a single one.

Not really familiar with this code, not sure i can review this, too.
If you state that you've run test-suite with this (and/or check-all of stage-2 clang), i could stamp though i guess.

Wed, Jul 10, 2:36 PM · Restricted Project
lebedev.ri added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

May be script should generate documentation during build, so files .rst files are not needed?

I'd personally weakly advise against that, to be honest;
that would not be inherently bad though, i think.

Wed, Jul 10, 2:33 PM · Restricted Project
lebedev.ri accepted D64531: [NFC] Adjust "invalid.ll.bc" tests to check for AttrKind #255 not #63.

I have no context here, but this roughly matches what had previously happened to these lines, so should be fine i guess?

Wed, Jul 10, 2:26 PM · Restricted Project