Page MenuHomePhabricator

simoll (Simon Moll)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2017, 12:28 AM (228 w, 6 d)

Recent Activity

Fri, Jun 11

simoll added a comment to D103898: [VP] Vector predicated vector splice intrinsic.

This patch needs to implement VPIntrinsic::getDeclarationForParams.

Fri, Jun 11, 12:21 AM · Restricted Project, Unknown Object (Project)
simoll requested changes to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

This needs to be rebased onto recent upstream.
In order to pass all unittest then, this patch needs an implementation in VPIntrinsic::getDeclarationForParams.

Fri, Jun 11, 12:20 AM · Unknown Object (Project), Restricted Project

Thu, Jun 10

simoll accepted D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Sure. I will commit this.

Thu, Jun 10, 11:18 PM · Unknown Object (Project), Restricted Project
simoll updated the diff for D93470: [VP] Binary floating-point intrinsics..

Make clang-format happy

Thu, Jun 10, 4:53 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D93470: [VP] Binary floating-point intrinsics..

Removed unused HasRoundingMode, etc functions.
Cleanup.

Thu, Jun 10, 3:09 AM · Restricted Project, Unknown Object (Project)

Wed, Jun 9

simoll abandoned D78630: [LV] Clamp the Unroll Factor to at least 1.
Wed, Jun 9, 2:51 AM · Restricted Project
simoll added inline comments to D93470: [VP] Binary floating-point intrinsics..
Wed, Jun 9, 1:09 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D103898: [VP] Vector predicated vector splice intrinsic.

As discussed on the call, maybe rename llvm.experimental.vp.vector.splice to llvm.experimental.vp.splice.. the "vector" is implied

Wed, Jun 9, 12:58 AM · Restricted Project, Unknown Object (Project)

Tue, Jun 8

simoll committed rG0f9d299122f1: [VP] getDeclarationForParams (authored by simoll).
[VP] getDeclarationForParams
Tue, Jun 8, 5:43 AM
simoll closed D102686: [VP] getDeclarationForParams.
Tue, Jun 8, 5:42 AM · Restricted Project, Unknown Object (Project)
simoll committed rG2b626aba448a: [VE][NFC] IRBuilder<> -> IRBuilderBase (authored by simoll).
[VE][NFC] IRBuilder<> -> IRBuilderBase
Tue, Jun 8, 4:57 AM
simoll committed rZORG99821277c29d: [VE] disable cmake caches until resolved (authored by simoll).
[VE] disable cmake caches until resolved
Tue, Jun 8, 2:15 AM

Mon, Jun 7

simoll added inline comments to D93470: [VP] Binary floating-point intrinsics..
Mon, Jun 7, 5:40 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D93470: [VP] Binary floating-point intrinsics..

Any input for this patch? Happy for people to step up for a LGTM ;-)

Mon, Jun 7, 12:10 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D102686: [VP] getDeclarationForParams.

Are we ok with this one?

Mon, Jun 7, 12:09 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I am ready to LGTM this. Any blockers?

Mon, Jun 7, 12:08 AM · Unknown Object (Project), Restricted Project

Thu, May 27

simoll added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I had a thought about alignment. Do we have a plan on how to deal with unaligned accesses?

Not yet

Thu, May 27, 5:05 AM · Unknown Object (Project), Restricted Project
simoll accepted D103027: [VP][SelectionDAG] Add a target-configurable EVL operand type.
Thu, May 27, 5:00 AM · Restricted Project
simoll added a comment to D103224: [VP] Make getMaskParamPos/getVectorLengthParamPos return unsigned. Lowercase function names..

+1 for folding variables into ifs while you're at it.

Thu, May 27, 4:59 AM · Restricted Project

Tue, May 25

simoll added a comment to D103027: [VP][SelectionDAG] Add a target-configurable EVL operand type.

Apart from the nit, this looks good to me. @rogfer01 ?

Tue, May 25, 4:15 AM · Restricted Project

Wed, May 19

simoll committed rG66963bf3819d: [VP] make getFunctionalOpcode return an Optional (authored by simoll).
[VP] make getFunctionalOpcode return an Optional
Wed, May 19, 8:09 AM
simoll closed D102778: [VP] make getFunctionalOpcode return an Optional.
Wed, May 19, 8:09 AM · Restricted Project, Unknown Object (Project)
simoll requested review of D102778: [VP] make getFunctionalOpcode return an Optional.
Wed, May 19, 7:45 AM · Restricted Project, Unknown Object (Project)
simoll added inline comments to D102686: [VP] getDeclarationForParams.
Wed, May 19, 6:44 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D102686: [VP] getDeclarationForParams.
  • Simplified w/o ShortTypeVec
Wed, May 19, 6:26 AM · Restricted Project, Unknown Object (Project)

Tue, May 18

simoll retitled D102686: [VP] getDeclarationForParams from [VP] getDeclarationForParam to [VP] getDeclarationForParams.
Tue, May 18, 5:48 AM · Restricted Project, Unknown Object (Project)
simoll requested review of D102686: [VP] getDeclarationForParams.
Tue, May 18, 5:48 AM · Restricted Project, Unknown Object (Project)

May 12 2021

simoll added inline comments to D93470: [VP] Binary floating-point intrinsics..
May 12 2021, 1:18 AM · Restricted Project, Unknown Object (Project)

May 11 2021

simoll added a comment to D57504: RFC: Prototype & Roadmap for vector predication in LLVM.

FYI. There is a biweekly syncup call on VP (Tue, 3pm CET, next: 2021-05-11)

May 11 2021, 8:05 AM · Restricted Project
simoll added a comment to D93470: [VP] Binary floating-point intrinsics..

With D93534 out of the way, we should have cleared all hurdles for this one. Where do we stand, comments, LGTMs?

May 11 2021, 7:53 AM · Restricted Project, Unknown Object (Project)
simoll committed rGb159987054e1: [VP] Improve the VP intrinsic unittests (authored by simoll).
[VP] Improve the VP intrinsic unittests
May 11 2021, 2:45 AM
simoll closed D93534: [VP] Improve the VP intrinsic unittests.
May 11 2021, 2:45 AM · Restricted Project, Unknown Object (Project)

May 4 2021

simoll added a reverting change for rG02c5ba867987: Revert "[VP,Integer,#2] ExpandVectorPredication pass": rG1db4dbba24dd: Recommit "[VP,Integer,#2] ExpandVectorPredication pass".
May 4 2021, 2:48 AM
simoll committed rG1db4dbba24dd: Recommit "[VP,Integer,#2] ExpandVectorPredication pass" (authored by simoll).
Recommit "[VP,Integer,#2] ExpandVectorPredication pass"
May 4 2021, 2:48 AM

May 3 2021

simoll added a comment to D93534: [VP] Improve the VP intrinsic unittests.

Everything else here looks good to me (though I'm not officially a reviewer so take that with some amount of salt)

May 3 2021, 6:24 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D78203: [VP,Integer,#2] ExpandVectorPredication pass.

Since it's already late on Friday I took the liberty to revert the commit so the bots can recover and you can investigate the failure at your own pace. Let me know if I can help with the fix!

May 3 2021, 12:24 AM · Restricted Project, Unknown Object (Project)

Apr 30 2021

simoll committed rG7a8664561116: [VE] VP intrinsics are legal (authored by simoll).
[VE] VP intrinsics are legal
Apr 30 2021, 6:48 AM
simoll committed rG43bc584dc05e: [VP,Integer,#2] ExpandVectorPredication pass (authored by simoll).
[VP,Integer,#2] ExpandVectorPredication pass
Apr 30 2021, 6:48 AM
simoll closed D78203: [VP,Integer,#2] ExpandVectorPredication pass.
Apr 30 2021, 6:48 AM · Restricted Project, Unknown Object (Project)

Apr 26 2021

simoll updated the diff for D93470: [VP] Binary floating-point intrinsics..
  • Fixed LangRef copy pasta bugs.
  • Formatting in VPIntrinsics.def
  • NFC
Apr 26 2021, 8:01 AM · Restricted Project, Unknown Object (Project)

Apr 23 2021

simoll added a comment to D78203: [VP,Integer,#2] ExpandVectorPredication pass.

I understand this is a legacy pass manager. Would it make sense to adapt it to the New PM as well?

Apr 23 2021, 2:56 AM · Restricted Project, Unknown Object (Project)

Apr 21 2021

simoll accepted D100941: Implementation for `TargetTransformInfo::hasActiveVectorLength()`.
Apr 21 2021, 4:51 AM · Restricted Project, Unknown Object (Project)
simoll added reviewers for D93534: [VP] Improve the VP intrinsic unittests: vkmr, rogfer01.
Apr 21 2021, 1:00 AM · Restricted Project, Unknown Object (Project)

Apr 20 2021

simoll added a comment to D93470: [VP] Binary floating-point intrinsics..

The unit test changes in this patch depend on the cleanup work done in D93534 . Please have a look at that one too!

Apr 20 2021, 1:13 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D78203: [VP,Integer,#2] ExpandVectorPredication pass.
Apr 20 2021, 1:09 AM · Restricted Project, Unknown Object (Project)

Apr 19 2021

simoll updated the diff for D78203: [VP,Integer,#2] ExpandVectorPredication pass.
  • NFC
  • worked through reviewers' comments (thx!)
  • rebased
Apr 19 2021, 7:05 AM · Restricted Project, Unknown Object (Project)
simoll added inline comments to D78203: [VP,Integer,#2] ExpandVectorPredication pass.
Apr 19 2021, 2:21 AM · Restricted Project, Unknown Object (Project)
simoll added inline comments to D93470: [VP] Binary floating-point intrinsics..
Apr 19 2021, 1:23 AM · Restricted Project, Unknown Object (Project)
simoll added inline comments to D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).
Apr 19 2021, 1:19 AM · Unknown Object (Project), Restricted Project

Apr 16 2021

simoll added inline comments to D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).
Apr 16 2021, 2:45 AM · Unknown Object (Project), Restricted Project
simoll committed rGfda078bffbc7: [docs] Add vector predication call (authored by simoll).
[docs] Add vector predication call
Apr 16 2021, 1:50 AM
simoll closed D100474: [docs] Add vector predication call.
Apr 16 2021, 1:50 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D100474: [docs] Add vector predication call.

Thanks. I am not too excited to moderate an open Discord server. Better invite people individually / on the call.

Apr 16 2021, 1:49 AM · Restricted Project, Unknown Object (Project)

Apr 14 2021

simoll requested review of D100474: [docs] Add vector predication call.
Apr 14 2021, 5:41 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

This LGTM on a conceptual level from the standpoint of SX-Aurora.
I guess @fhahn would be the right person to weigh in on the VPlan changes.
When it comes to the actual patches for this RFC, it'd help to upstream the VectorBuilder class. It allows you to emit VP code without having to juggle with VP intrinsics.

Apr 14 2021, 2:46 AM · Unknown Object (Project), Restricted Project

Apr 13 2021

simoll committed rZORGa43b7ccb965f: [ve] fix cmake cache param (authored by simoll).
[ve] fix cmake cache param
Apr 13 2021, 1:43 AM

Apr 8 2021

simoll added a comment to D88905: [Clang] Allow "ext_vector_type" applied to Booleans.

ping

Apr 8 2021, 12:59 AM · Restricted Project

Apr 6 2021

simoll committed rZORGbb01a62f2ff4: [VE] use local cache (authored by simoll).
[VE] use local cache
Apr 6 2021, 8:45 AM

Mar 30 2021

simoll updated the diff for D78203: [VP,Integer,#2] ExpandVectorPredication pass.

NFC

  • Addressed super nit
  • Formatting
  • Rebased
Mar 30 2021, 7:38 AM · Restricted Project, Unknown Object (Project)

Mar 29 2021

simoll added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Can we split this up into a patch with only the intrinsics and a second patch with SelectionDAG?

Mar 29 2021, 10:04 AM · Unknown Object (Project), Restricted Project
simoll added inline comments to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
Mar 29 2021, 7:53 AM · Unknown Object (Project), Restricted Project
simoll added a project to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter.: Unknown Object (Project).
Mar 29 2021, 6:05 AM · Unknown Object (Project), Restricted Project
simoll added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Thanks Hussain for this patch!
For now I have a couple of minor comments, I will take a deeper look later.
Also, I don't quite understand yet how VP handles (or plans to handle) specifying alignment parameter. Does it need VPBuilder (not to be confused with VPlan VPBuilder!) for that? Would it make sense to add the Alignment parameter to VP load/store/scatter/gather intrinsics (much like their masked counterparts) for now, unless there is already a way to specify that?

We should use the align(N) attribute on pointers to convey the alignment. That's what we do in the LLVM for SX-Aurora stack (https://github.com/sx-aurora-dev/llvm-project/blob/683f41073689262a8a493cce7caba13bbccea56c/llvm/test/CodeGen/VE/Packed/vp_load_packed.ll#L80) . I'd say that the alignment parameter in the pre-existing masked.load/store simply predates that attribute.
And yes, setting alignment is something that the VPBuilder or what's-it-called-after-bikeshedding would take care of for you.

Mar 29 2021, 5:01 AM · Unknown Object (Project), Restricted Project

Mar 4 2021

simoll added inline comments to D78203: [VP,Integer,#2] ExpandVectorPredication pass.
Mar 4 2021, 7:03 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D78203: [VP,Integer,#2] ExpandVectorPredication pass.

Modernize tests, replace undef -> poison

Mar 4 2021, 5:49 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D88905: [Clang] Allow "ext_vector_type" applied to Booleans.

ping

Mar 4 2021, 3:00 AM · Restricted Project
simoll updated the diff for D78203: [VP,Integer,#2] ExpandVectorPredication pass.

Addressed @ctetreau 's comments. Thx!

Mar 4 2021, 2:40 AM · Restricted Project, Unknown Object (Project)

Mar 3 2021

simoll committed rZORGc51ad2f0cdc0: [VE] hpce-aurora2 worker replaces nec-arrproto41 (authored by simoll).
[VE] hpce-aurora2 worker replaces nec-arrproto41
Mar 3 2021, 8:42 AM

Feb 24 2021

simoll committed rG542d9c21541d: [libomptarget] Load images in order of registration (authored by manorom).
[libomptarget] Load images in order of registration
Feb 24 2021, 9:16 AM
simoll closed D95530: [libomptarget] Load images in order of registration.
Feb 24 2021, 9:15 AM · Restricted Project

Jan 28 2021

simoll added inline comments to D95530: [libomptarget] Load images in order of registration.
Jan 28 2021, 12:33 AM · Restricted Project

Jan 19 2021

simoll committed rZORGb31e3537f304: clang-ve-ninja: Build and use the LLVM dylib (authored by simoll).
clang-ve-ninja: Build and use the LLVM dylib
Jan 19 2021, 3:02 AM

Jan 12 2021

simoll accepted D94490: [VE] Update VELIntrinsic tests.
Jan 12 2021, 6:02 AM · Unknown Object (Project), Restricted Project
simoll updated the diff for D93755: [VE][isel] Map EVT vectors to vector registers..

NFC. Usage of Optional. Rebased onto committed D93709 .

Jan 12 2021, 4:40 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D93755: [VE][isel] Map EVT vectors to vector registers..

This is one of those patches that has the potential to linger on without review for 1Y+ .. let me know if there is anything i can do to get this reviewed, as it really helps with bringing good vector architecture (long SIMD) support to LLVM. Thanks.

Can I interest you in moving to GlobalISel instead of trying to teach the DAG about new types :)

Jan 12 2021, 1:49 AM · Restricted Project, Unknown Object (Project)

Jan 11 2021

simoll accepted D94298: [VE] Support intrinsic to isnert/extract_subreg of v512i1.

Title typo: 'isntert'

Jan 11 2021, 12:36 AM · Unknown Object (Project), Restricted Project
simoll accepted D94300: [VE] Support additional VMRGW and VMV intrinsic instructions.
Jan 11 2021, 12:35 AM · Unknown Object (Project), Restricted Project

Jan 8 2021

simoll committed rG611d3c63f32d: [VP] ISD helper functions [VE] isel for vp_add, vp_and (authored by simoll).
[VP] ISD helper functions [VE] isel for vp_add, vp_and
Jan 8 2021, 5:30 AM
simoll closed D93766: [VP] ISD helper functions [VE] isel for vp_add, vp_and.
Jan 8 2021, 5:30 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project
simoll accepted D94296: [VE] Support pack_f32p and pack_f32a intrinsic instructions.
Jan 8 2021, 5:01 AM · Unknown Object (Project), Restricted Project
simoll updated the diff for D93766: [VP] ISD helper functions [VE] isel for vp_add, vp_and.

NFC. Rebased. Use variable name Opcode instead of OC.

Jan 8 2021, 4:58 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project
simoll accepted D94291: [VE][NFC] Clean ISel patterns for LSV and LVS.
Jan 8 2021, 4:13 AM · Unknown Object (Project), Restricted Project
simoll added a comment to D93766: [VP] ISD helper functions [VE] isel for vp_add, vp_and.

LGTM. Had to double-check that things were #undef...fed at the end of the header.

Jan 8 2021, 3:00 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project
simoll added a comment to D93534: [VP] Improve the VP intrinsic unittests.

Can we accept this patch? In the end, it is a strict improvement over the existing one.. and it is "just" a unittest..

Jan 8 2021, 2:56 AM · Restricted Project, Unknown Object (Project)
simoll added a comment to D93755: [VE][isel] Map EVT vectors to vector registers..

This is one of those patches that has the potential to linger on without review for 1Y+ .. let me know if there is anything i can do to get this reviewed, as it really helps with bringing good vector architecture (long SIMD) support to LLVM. Thanks.

Jan 8 2021, 2:53 AM · Restricted Project, Unknown Object (Project)
simoll added reviewers for D93766: [VP] ISD helper functions [VE] isel for vp_add, vp_and: craig.topper, frasercrmck.

We want somebody that has reviewed VP patches before to review the VP bits of this (getters, really). @kaz7 takes care of the VE parts. Thanks!

Jan 8 2021, 2:50 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project
simoll committed rGeeba70a463c7: [VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT (authored by simoll).
[VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT
Jan 8 2021, 2:48 AM
simoll closed D93759: [VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT.
Jan 8 2021, 2:48 AM · Restricted Project, Unknown Object (Project)
simoll committed rGd1b606f897be: [VE] Extract & insert vector element isel (authored by simoll).
[VE] Extract & insert vector element isel
Jan 8 2021, 2:47 AM
simoll closed D93687: [VE] Extract & insert vector element isel.
Jan 8 2021, 2:47 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D93759: [VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT.

This now depends on D93687 - the build_vector lowering causes introduces more instances of insert_vector_elt.

Jan 8 2021, 1:31 AM · Restricted Project, Unknown Object (Project)
simoll accepted D94279: [VE] Add SVOB intrinsic instruction.
Jan 8 2021, 1:01 AM · Unknown Object (Project), Restricted Project
simoll updated the summary of D93687: [VE] Extract & insert vector element isel.
Jan 8 2021, 12:53 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D93687: [VE] Extract & insert vector element isel.
  • Rebased onto main.
  • insert_vector_elt tests trigger vbrd code path because lowering of build_vector to insert_vector_elt is gone (D93759).
Jan 8 2021, 12:53 AM · Restricted Project, Unknown Object (Project)

Jan 5 2021

simoll updated the diff for D93759: [VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT.

|& -> 2>&1 |

Jan 5 2021, 7:04 AM · Restricted Project, Unknown Object (Project)
simoll added inline comments to D93759: [VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT.
Jan 5 2021, 6:09 AM · Restricted Project, Unknown Object (Project)
simoll added inline comments to D93687: [VE] Extract & insert vector element isel.
Jan 5 2021, 5:46 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D93687: [VE] Extract & insert vector element isel.

getSimpleValueType()

Jan 5 2021, 5:45 AM · Restricted Project, Restricted Project
simoll updated the diff for D93687: [VE] Extract & insert vector element isel.

NFC

  • Hopefully attached signext to all args in tests this time
  • Adressed comments
Jan 5 2021, 5:40 AM · Restricted Project, Restricted Project
simoll added a comment to D94076: [VE] Change clang to support SjLj Lowering.

You might want to fix the typo in the title before committing this.

Jan 5 2021, 4:51 AM · Restricted Project, Restricted Project, Restricted Project