Page MenuHomePhabricator

simoll (Simon Moll)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2017, 12:28 AM (155 w, 5 d)

Recent Activity

Thu, Jan 16

simoll planned changes to D71338: [VE,#1] Scalar code generation.
Thu, Jan 16, 8:38 AM · Unknown Object (Project), Restricted Project
simoll committed rG773ae62ff85d: [VE] i64 arguments, return values and constants (authored by kaz7).
[VE] i64 arguments, return values and constants
Thu, Jan 16, 1:13 AM
simoll closed D72776: [VE] i64 arguments, return values and constants.
Thu, Jan 16, 1:12 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D72776: [VE] i64 arguments, return values and constants.

Thanks for reviewing!

Thu, Jan 16, 12:54 AM · Restricted Project, Unknown Object (Project)

Wed, Jan 15

simoll added a child revision for D71338: [VE,#1] Scalar code generation: D72776: [VE] i64 arguments, return values and constants.
Wed, Jan 15, 9:05 AM · Unknown Object (Project), Restricted Project
simoll added a parent revision for D72776: [VE] i64 arguments, return values and constants: D71338: [VE,#1] Scalar code generation.
Wed, Jan 15, 9:05 AM · Restricted Project, Unknown Object (Project)
simoll created D72776: [VE] i64 arguments, return values and constants.
Wed, Jan 15, 9:05 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D71338: [VE,#1] Scalar code generation.
Wed, Jan 15, 5:43 AM · Unknown Object (Project), Restricted Project
simoll committed rG064859bde79c: [VE] Minimal codegen for empty functions (authored by kaz7).
[VE] Minimal codegen for empty functions
Wed, Jan 15, 1:05 AM
simoll closed D72598: [VE] Minimal codegen for empty functions.
Wed, Jan 15, 1:05 AM · Restricted Project, Unknown Object (Project)

Tue, Jan 14

simoll updated the diff for D72598: [VE] Minimal codegen for empty functions.
  • Rebased
  • isInt<32>(MO.getImm())
Tue, Jan 14, 8:22 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D72598: [VE] Minimal codegen for empty functions.

We use LO32, HI32 here to always represent immediates in the numerical domain of LLVM immediates (signed int64_t).
The advantage of this is that we can check whether any immediates are representable as signed 32bit literals when emitting assembly.
When using LLVM's Lo_32/Hi_32 along with other sources of immediates it is not possible to tell in the asm printer whether 0x00000000FFFFFFFF should be -1 or is in fact too large for signed 32bit integer literals.

Tue, Jan 14, 7:15 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D72598: [VE] Minimal codegen for empty functions.
  • Argument additions to BuildMI on separate lines everywhere.
  • Fixed LO32/HI32 immediate truncation.
  • Stripped unused reg pressure set from VERegisterInfo.
  • Capitalized comments.
Tue, Jan 14, 4:02 AM · Restricted Project, Unknown Object (Project)

Mon, Jan 13

simoll added a comment to D72598: [VE] Minimal codegen for empty functions.

added a meaningful header description

Mon, Jan 13, 6:26 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D72598: [VE] Minimal codegen for empty functions.

Addressed arsenm's comments.

Mon, Jan 13, 6:26 AM · Restricted Project, Unknown Object (Project)
simoll added inline comments to D72467: Remove "mask" operand from shufflevector..
Mon, Jan 13, 6:26 AM · Restricted Project, Restricted Project
simoll added a child revision for D71338: [VE,#1] Scalar code generation: D72598: [VE] Minimal codegen for empty functions.
Mon, Jan 13, 5:20 AM · Unknown Object (Project), Restricted Project
simoll added a parent revision for D72598: [VE] Minimal codegen for empty functions: D71338: [VE,#1] Scalar code generation.
Mon, Jan 13, 5:20 AM · Restricted Project, Unknown Object (Project)
simoll updated the diff for D72598: [VE] Minimal codegen for empty functions.

Stripped custom VEMachineFunction

Mon, Jan 13, 5:11 AM · Restricted Project, Unknown Object (Project)
simoll created D72598: [VE] Minimal codegen for empty functions.
Mon, Jan 13, 5:01 AM · Restricted Project, Unknown Object (Project)

Thu, Jan 9

simoll added a reviewer for D72467: Remove "mask" operand from shufflevector.: simoll.
Thu, Jan 9, 10:42 AM · Restricted Project, Restricted Project
simoll committed rG356b33516c2e: [NFC,format] Sort switch cases alphabetically (authored by simoll).
[NFC,format] Sort switch cases alphabetically
Thu, Jan 9, 9:46 AM
simoll closed D72452: [NFC,format] Sort switch cases alphabetically.
Thu, Jan 9, 9:46 AM · Restricted Project
simoll created D72452: [NFC,format] Sort switch cases alphabetically.
Thu, Jan 9, 7:05 AM · Restricted Project
simoll updated the diff for D71337: [VE,#0] 64bit data for SjLj.
  • Rebased
  • NFC (getArch() == .. -- > isVE()).
  • Dug through layers of cosmetic commits to find potential reviewers for the SjLjEHPreparePass.
Thu, Jan 9, 5:50 AM · Unknown Object (Project), Restricted Project
simoll planned changes to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
  • Clarify documentation on preserved lanes
  • explicit vlen arg is either negative or (new requirement) less-equal-than the number of lanes of the operation.
Thu, Jan 9, 5:02 AM · Restricted Project
simoll planned changes to D57504: RFC: Prototype & Roadmap for vector predication in LLVM.
  • Add pivot/threshold argument to llvm.vp.select and remove llvm.vp.compose
  • Clarify documentation on preserved lanes
  • explicit vlen arg is either negative or (new requirement) less-equal-than the number of lanes of the operation.
Thu, Jan 9, 5:01 AM · Restricted Project
simoll updated the diff for D71338: [VE,#1] Scalar code generation.

Rebased

Thu, Jan 9, 4:45 AM · Unknown Object (Project), Restricted Project
simoll added a comment to D69103: Backend for NEC SX-Aurora.
Thu, Jan 9, 3:31 AM · Unknown Object (Project), Restricted Project
simoll committed rG00c6e98409f9: [VE] Target stub for NEC SX-Aurora (authored by kaz7).
[VE] Target stub for NEC SX-Aurora
Thu, Jan 9, 2:20 AM
simoll closed D69103: Backend for NEC SX-Aurora.
Thu, Jan 9, 2:20 AM · Unknown Object (Project), Restricted Project
simoll updated the diff for D69103: Backend for NEC SX-Aurora.

Rebased

Thu, Jan 9, 1:02 AM · Unknown Object (Project), Restricted Project

Wed, Jan 8

simoll committed rZORG66f206567090: [VE] Staging buildbot (authored by simoll).
[VE] Staging buildbot
Wed, Jan 8, 4:44 AM
simoll closed D71417: [VE] Staging buildbot.
Wed, Jan 8, 4:44 AM · Unknown Object (Project)

Tue, Jan 7

simoll updated the diff for D71417: [VE] Staging buildbot.

NFC. Stripped cosmetics

Tue, Jan 7, 3:51 AM · Unknown Object (Project)
simoll updated subscribers of D71636: [AArch64][SVE][WIP] Add support for vscale constants (?).
define i32 @vscale() {
  ret i32 ptrtoint (<vscale x 1 x i8>* getelementptr (<vscale x 1 x
i8>, <vscale x 1 x i8>* null, i64 1) to i32)
}
Tue, Jan 7, 1:50 AM · Restricted Project
simoll added a comment to D69103: Backend for NEC SX-Aurora.

Thanks for the review. This patch has been simmering for a while. I'll wait until Thursday to commit this to allow others to chime in.

Tue, Jan 7, 1:13 AM · Unknown Object (Project), Restricted Project
simoll planned changes to D71417: [VE] Staging buildbot.

Thank you for the review. I'll update without the unrelated change.

Tue, Jan 7, 1:04 AM · Unknown Object (Project)

Dec 13 2019

simoll added a project to D69103: Backend for NEC SX-Aurora: Unknown Object (Project).

The child patches show the next steps and attach a staging buildbot for the VE target as requested.
Please let us know how to proceed from here.

Dec 13 2019, 12:53 AM · Unknown Object (Project), Restricted Project
simoll retitled D71417: [VE] Staging buildbot from [VE] buildbot registration to [VE] Staging buildbot.
Dec 13 2019, 12:50 AM · Unknown Object (Project)

Dec 12 2019

simoll added a comment to D69103: Backend for NEC SX-Aurora.

The buildbot is setup. This is the llvm-zorg patch to add it.

Dec 12 2019, 6:08 AM · Unknown Object (Project), Restricted Project
simoll added a parent revision for D71417: [VE] Staging buildbot: D69103: Backend for NEC SX-Aurora.
Dec 12 2019, 6:06 AM · Unknown Object (Project)
simoll added a child revision for D69103: Backend for NEC SX-Aurora: D71417: [VE] Staging buildbot.
Dec 12 2019, 6:06 AM · Unknown Object (Project), Restricted Project
simoll created D71417: [VE] Staging buildbot.
Dec 12 2019, 6:06 AM · Unknown Object (Project)

Dec 11 2019

simoll added inline comments to D69103: Backend for NEC SX-Aurora.
Dec 11 2019, 7:59 AM · Unknown Object (Project), Restricted Project
simoll added a project to D71341: [VE,#4] Target vector intrinsics: Unknown Object (Project).
Dec 11 2019, 5:50 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll added a project to D71340: [VE,#3] Runtime libraries: Unknown Object (Project).
Dec 11 2019, 5:50 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll added a project to D71337: [VE,#0] 64bit data for SjLj: Unknown Object (Project).
Dec 11 2019, 5:50 AM · Unknown Object (Project), Restricted Project
simoll added a project to D71338: [VE,#1] Scalar code generation: Unknown Object (Project).
Dec 11 2019, 5:50 AM · Unknown Object (Project), Restricted Project
simoll updated the diff for D71339: [VE,#2] Clang toolchain for SX-Aurora.

Trimmed to Clang changes only

Dec 11 2019, 5:50 AM · Unknown Object (Project), Restricted Project, Restricted Project
simoll added a project to D71339: [VE,#2] Clang toolchain for SX-Aurora: Unknown Object (Project).
Dec 11 2019, 5:50 AM · Unknown Object (Project), Restricted Project, Restricted Project
simoll updated the diff for D71338: [VE,#1] Scalar code generation.
  • Stripped SjLj-prep changes from diff.
Dec 11 2019, 5:40 AM · Unknown Object (Project), Restricted Project
simoll updated the diff for D71337: [VE,#0] 64bit data for SjLj.

Trimmed down to SjLj changes only.

Dec 11 2019, 5:34 AM · Unknown Object (Project), Restricted Project
simoll updated the diff for D71340: [VE,#3] Runtime libraries.

Trimmed down to library changes only.

Dec 11 2019, 5:31 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll added a comment to D71337: [VE,#0] 64bit data for SjLj.

To clarify: this patch is not intended to be committed as-is but gives an overview of the required changes. It's the a patch of a series for the VE backend and includes all the earlier patches.

Dec 11 2019, 4:37 AM · Unknown Object (Project), Restricted Project
simoll added a comment to D71339: [VE,#2] Clang toolchain for SX-Aurora.

To clarify: this patch is not intended to be committed as-is but gives an overview of the required changes. It's the a patch of a series for the VE backend and includes all the earlier patches.

Dec 11 2019, 4:37 AM · Unknown Object (Project), Restricted Project, Restricted Project
simoll added a comment to D71340: [VE,#3] Runtime libraries.

To clarify: this patch is not intended to be committed as-is but gives an overview of the required changes. It's the a patch of a series for the VE backend and includes all the earlier patches.

Dec 11 2019, 4:37 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll added a comment to D71338: [VE,#1] Scalar code generation.

To clarify: this patch is not intended to be committed as-is but gives an overview of the required changes. It's the a patch of a series for the VE backend and includes all the earlier patches.

Dec 11 2019, 4:30 AM · Unknown Object (Project), Restricted Project
simoll added a comment to D71341: [VE,#4] Target vector intrinsics.

As a general rule, I think it would be preferable for patches such as this one to be split up further, especially when they touch common code. For example, why does a patch by the name "Target vector intrinsics" contain a change to SjLjEHPrepare?

Dec 11 2019, 4:30 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll added a comment to D69103: Backend for NEC SX-Aurora.

We've sliced up the backend into 5 different patches. The first three patches leave you with functional scalar code generation for the VE target:

  1. VE,#0 64bit data for SjLj - is a preparatory patch for exception handling.
  2. VE,#1 Scalar code generation - full scalar code generation.
  3. VE,#2 Clang toolchain for SX-Aurora - makes the VE target available in Clang.
  4. VE,#3 Runtime libraries - basic adaptations of the libcxx, libcxxabi,libunwind, compiler-rt, openmp runtime libraries.
  5. VE,#4 Target vector intrinsics - Target-specific vector intrinsics.
Dec 11 2019, 3:32 AM · Unknown Object (Project), Restricted Project
simoll added child revisions for D69103: Backend for NEC SX-Aurora: D71337: [VE,#0] 64bit data for SjLj, D71338: [VE,#1] Scalar code generation, D71339: [VE,#2] Clang toolchain for SX-Aurora, D71340: [VE,#3] Runtime libraries, D71341: [VE,#4] Target vector intrinsics.
Dec 11 2019, 3:15 AM · Unknown Object (Project), Restricted Project
simoll added a parent revision for D71338: [VE,#1] Scalar code generation: D69103: Backend for NEC SX-Aurora.
Dec 11 2019, 3:15 AM · Unknown Object (Project), Restricted Project
simoll added a parent revision for D71337: [VE,#0] 64bit data for SjLj: D69103: Backend for NEC SX-Aurora.
Dec 11 2019, 3:15 AM · Unknown Object (Project), Restricted Project
simoll added a parent revision for D71339: [VE,#2] Clang toolchain for SX-Aurora: D69103: Backend for NEC SX-Aurora.
Dec 11 2019, 3:15 AM · Unknown Object (Project), Restricted Project, Restricted Project
simoll added a parent revision for D71340: [VE,#3] Runtime libraries: D69103: Backend for NEC SX-Aurora.
Dec 11 2019, 3:15 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll added a parent revision for D71341: [VE,#4] Target vector intrinsics: D69103: Backend for NEC SX-Aurora.
Dec 11 2019, 3:15 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll created D71341: [VE,#4] Target vector intrinsics.
Dec 11 2019, 3:13 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll created D71340: [VE,#3] Runtime libraries.
Dec 11 2019, 3:13 AM · Unknown Object (Project), Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
simoll created D71339: [VE,#2] Clang toolchain for SX-Aurora.
Dec 11 2019, 3:06 AM · Unknown Object (Project), Restricted Project, Restricted Project
simoll created D71338: [VE,#1] Scalar code generation.
Dec 11 2019, 3:04 AM · Unknown Object (Project), Restricted Project
simoll created D71337: [VE,#0] 64bit data for SjLj.
Dec 11 2019, 3:03 AM · Unknown Object (Project), Restricted Project
simoll updated the diff for D69103: Backend for NEC SX-Aurora.
  • removed vector types from DataLayout
Dec 11 2019, 2:56 AM · Unknown Object (Project), Restricted Project

Dec 9 2019

simoll added inline comments to D57504: RFC: Prototype & Roadmap for vector predication in LLVM.
Dec 9 2019, 12:52 AM · Restricted Project

Dec 3 2019

simoll added inline comments to D57504: RFC: Prototype & Roadmap for vector predication in LLVM.
Dec 3 2019, 4:23 AM · Restricted Project

Nov 25 2019

simoll added a comment to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.

Moved the discussion to the RFC.

Nov 25 2019, 2:42 AM · Restricted Project
simoll added a comment to D57504: RFC: Prototype & Roadmap for vector predication in LLVM.

Moving the discussion from the integer patch alley to the main RFC as this is about the general design of VP intrinsics.. it's about having a passthru operand (as in llvm.masked.load) and whether %evl should be a parameter of the intrinsics or modelled differently.

Nov 25 2019, 2:42 AM · Restricted Project

Nov 22 2019

simoll added a comment to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.

ping?

Nov 22 2019, 4:07 AM · Restricted Project

Nov 18 2019

simoll added inline comments to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 18 2019, 10:59 AM · Restricted Project
simoll added inline comments to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 18 2019, 9:29 AM · Restricted Project

Nov 15 2019

simoll added a comment to D70261: [strictfp] Add token support for FP constraints.

I like the notion of having those values expressed directly as LLVM IR tokens

+1
I also like the (optional) operand bundles (see llvm-dev reply).

Nov 15 2019, 7:24 AM · Restricted Project
simoll added inline comments to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 15 2019, 7:15 AM · Restricted Project
simoll added inline comments to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 15 2019, 3:03 AM · Restricted Project
simoll updated the diff for D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
  • ElementCount getStaticVectorLength()
  • unit test for canIgnoreVectorLength on scalable examples.
Nov 15 2019, 2:59 AM · Restricted Project

Nov 14 2019

simoll updated the diff for D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.

Thanks for your feedback!

Nov 14 2019, 7:12 AM · Restricted Project
simoll planned changes to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
  • Adding scalable type example declarations
  • reformatting langref for character limit.
Nov 14 2019, 7:03 AM · Restricted Project
simoll updated the diff for D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.

LangRef rewording: explicit vlen is a signed integer.

Nov 14 2019, 2:13 AM · Restricted Project
simoll planned changes to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.

+1 from me! Thanks for doing this!

Nov 14 2019, 1:29 AM · Restricted Project

Nov 13 2019

simoll added inline comments to D69798: Implement inlining of strictfp functions.
Nov 13 2019, 9:32 AM · Restricted Project
simoll updated the diff for D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.

VPInstruction.def -> VPIntrinsics.def -.-

Nov 13 2019, 9:07 AM · Restricted Project
simoll updated the diff for D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.

Finally fixed the IR/VPIntrinsics.def header line.

Nov 13 2019, 9:06 AM · Restricted Project
simoll planned changes to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 13 2019, 9:04 AM · Restricted Project
simoll updated the diff for D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
  • Cleanup, addressed nitpicks
  • Give up if static vector length is excessive (safe default, pass -1 to enable all lanes in those cases, should they ever occur..).
Nov 13 2019, 1:55 AM · Restricted Project
simoll added inline comments to D69281: [FPEnv] Constrained FCmp intrinsics.
Nov 13 2019, 1:46 AM · Restricted Project
simoll planned changes to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.

Thanks for the comments so far :)

Nov 13 2019, 12:33 AM · Restricted Project

Nov 12 2019

simoll added inline comments to D69281: [FPEnv] Constrained FCmp intrinsics.
Nov 12 2019, 9:04 AM · Restricted Project
simoll updated the diff for D57504: RFC: Prototype & Roadmap for vector predication in LLVM.
  • VPIntrinsics.def file.
  • Pass vlen i32 -1 to enable all lanes with scalable vector types.
  • Various NFC fixes.
Nov 12 2019, 6:53 AM · Restricted Project
simoll updated the diff for D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
  • VPIntrinsics.def macro file
  • NFC cleanup
Nov 12 2019, 6:46 AM · Restricted Project

Nov 11 2019

simoll planned changes to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 11 2019, 10:59 AM · Restricted Project
simoll added inline comments to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 11 2019, 4:43 AM · Restricted Project

Nov 7 2019

simoll added a child revision for D57504: RFC: Prototype & Roadmap for vector predication in LLVM: D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 7 2019, 12:40 AM · Restricted Project