rogfer01 (Roger Ferrer Ibanez)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2016, 6:42 AM (123 w, 4 d)

Recent Activity

Wed, Sep 12

rogfer01 committed rL342060: [RISCV] Explicitly set an empty --sysroot in the test.
[RISCV] Explicitly set an empty --sysroot in the test
Wed, Sep 12, 8:56 AM
rogfer01 committed rC342060: [RISCV] Explicitly set an empty --sysroot in the test.
[RISCV] Explicitly set an empty --sysroot in the test
Wed, Sep 12, 8:56 AM
rogfer01 closed D51972: [RISCV] Explicitly set an empty --sysroot in the test.
Wed, Sep 12, 8:56 AM
rogfer01 added a comment to rL341547: Fix the -print-multi-directory flag to print the selected multilib..

The updated testcase does not fail locally anymore.

Wed, Sep 12, 8:35 AM
rogfer01 added a comment to D51972: [RISCV] Explicitly set an empty --sysroot in the test.

Thanks I will do it shortly.

Wed, Sep 12, 8:29 AM
rogfer01 added a comment to D51972: [RISCV] Explicitly set an empty --sysroot in the test.

I can commit it.

Wed, Sep 12, 8:23 AM
rogfer01 added a comment to D51972: [RISCV] Explicitly set an empty --sysroot in the test.

Thanks for the review!

Wed, Sep 12, 7:53 AM
rogfer01 created D51972: [RISCV] Explicitly set an empty --sysroot in the test.
Wed, Sep 12, 3:28 AM
rogfer01 added a comment to rL341547: Fix the -print-multi-directory flag to print the selected multilib..

on a second thought, "InstalledDir" only appears with -v, and is still too fragile (e.g if installed dir name also contains checked strings)

Wed, Sep 12, 2:37 AM

Mon, Sep 10

rogfer01 added a comment to D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf.

Sure, I didn't mean to do that broader change here. Apologies if it read that way.

Mon, Sep 10, 10:47 AM
rogfer01 added a comment to D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf.

Thanks for reopening this @kristina.

Mon, Sep 10, 9:45 AM
rogfer01 added inline comments to rL341547: Fix the -print-multi-directory flag to print the selected multilib..
Mon, Sep 10, 7:28 AM
rogfer01 added inline comments to rL341655: Differential Revision: https://reviews.llvm.org/D50246.
Mon, Sep 10, 6:35 AM

Thu, Sep 6

rogfer01 accepted D51733: [RISCV][MC] Use a custom ParserMethod for the bare_symbol operand type.

Oh this is great! Scales much better than my earlier hack. Thanks a lot @asb !

Thu, Sep 6, 10:46 PM

Mon, Sep 3

rogfer01 added a comment to D50634: [RISCV] Add support for local PIC addressing.

If I'm understanding correctly, the problem here is that the lui has to have the address of the auipc as a parameter.

Mon, Sep 3, 3:55 AM

Wed, Aug 29

rogfer01 added inline comments to D50634: [RISCV] Add support for local PIC addressing.
Wed, Aug 29, 9:06 AM

Mon, Aug 27

rogfer01 committed rL340722: [RISCV] atomic_store_nn have a different layout to regular store.
[RISCV] atomic_store_nn have a different layout to regular store
Mon, Aug 27, 12:09 AM
rogfer01 closed D51217: [RISCV] atomic_store_nn have a different layout to regular store.
Mon, Aug 27, 12:09 AM

Sun, Aug 26

rogfer01 updated the diff for D51217: [RISCV] atomic_store_nn have a different layout to regular store.

ChangeLog:

  • Align syntax
Sun, Aug 26, 11:22 PM
rogfer01 added a comment to D51217: [RISCV] atomic_store_nn have a different layout to regular store.

Thanks for the prompt review @asb!

Sun, Aug 26, 11:18 PM

Fri, Aug 24

rogfer01 added inline comments to D51217: [RISCV] atomic_store_nn have a different layout to regular store.
Fri, Aug 24, 7:39 AM
rogfer01 created D51217: [RISCV] atomic_store_nn have a different layout to regular store.
Fri, Aug 24, 7:24 AM

Aug 17 2018

rogfer01 committed rL340024: [RISCV] Remove unused function.
[RISCV] Remove unused function
Aug 17 2018, 6:41 AM
rogfer01 closed D50836: [RISCV] Remove unused function.
Aug 17 2018, 6:41 AM

Aug 16 2018

rogfer01 added a comment to D50836: [RISCV] Remove unused function.

Thanks for the review @asb

Aug 16 2018, 6:48 AM
rogfer01 added a dependency for D50634: [RISCV] Add support for local PIC addressing: D50836: [RISCV] Remove unused function.
Aug 16 2018, 2:33 AM
rogfer01 added a dependent revision for D50836: [RISCV] Remove unused function: D50634: [RISCV] Add support for local PIC addressing.
Aug 16 2018, 2:33 AM
rogfer01 created D50836: [RISCV] Remove unused function.
Aug 16 2018, 2:33 AM
rogfer01 added inline comments to D50634: [RISCV] Add support for local PIC addressing.
Aug 16 2018, 1:36 AM

Aug 14 2018

rogfer01 added inline comments to D50634: [RISCV] Add support for local PIC addressing.
Aug 14 2018, 5:59 AM
rogfer01 updated the diff for D50634: [RISCV] Add support for local PIC addressing.

ChangeLog

  • Add test for ConstantPools
Aug 14 2018, 5:52 AM
rogfer01 added a comment to D50496: [RISCV] Implment pseudo instructions for load/store from a symbol address..

Thanks for the update @kito-cheng . Some more comments inline as the change is propagating a mistake of mine I introduced in rL339314 (fixed in rL339654).

Aug 14 2018, 1:43 AM
rogfer01 committed rL339654: [RISCV] Fix incorrect use of MCInstBuilder.
[RISCV] Fix incorrect use of MCInstBuilder
Aug 14 2018, 1:31 AM

Aug 13 2018

rogfer01 added inline comments to D50634: [RISCV] Add support for local PIC addressing.
Aug 13 2018, 6:49 AM
rogfer01 retitled D50634: [RISCV] Add support for local PIC addressing from [RISCV] Add support for local PIC accessing to [RISCV] Add support for local PIC addressing.
Aug 13 2018, 6:46 AM
rogfer01 created D50634: [RISCV] Add support for local PIC addressing.
Aug 13 2018, 6:46 AM

Aug 9 2018

rogfer01 added a comment to D50496: [RISCV] Implment pseudo instructions for load/store from a symbol address..

Hi, thanks a lot for the patch. A few comments inline.

Aug 9 2018, 3:57 AM
rogfer01 committed rL339314: [RISCV] Add "lla" pseudo-instruction to assembler.
[RISCV] Add "lla" pseudo-instruction to assembler
Aug 9 2018, 12:08 AM
rogfer01 closed D49661: [RISCV] Add "lla" pseudo-instruction to assembler.
Aug 9 2018, 12:08 AM

Aug 8 2018

rogfer01 added a comment to D49661: [RISCV] Add "lla" pseudo-instruction to assembler.

Thanks for the review @asb . I will commit soon.

Aug 8 2018, 8:29 AM

Aug 3 2018

rogfer01 added inline comments to rC338837: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 5:48 AM
rogfer01 added inline comments to rC338837: clang-format: [JS] don't break comments before any '{'.
Aug 3 2018, 5:47 AM
rogfer01 updated the diff for D49661: [RISCV] Add "lla" pseudo-instruction to assembler.

Thanks @asb for the review!

Aug 3 2018, 12:55 AM

Jul 30 2018

rogfer01 abandoned D49905: [RISCV] Fix test after new support of "interrupt" attribute landed.

Fixed in rL338341

Jul 30 2018, 11:06 PM

Jul 27 2018

rogfer01 created D49905: [RISCV] Fix test after new support of "interrupt" attribute landed.
Jul 27 2018, 12:03 AM

Jul 26 2018

rogfer01 updated the diff for D49661: [RISCV] Add "lla" pseudo-instruction to assembler.

Thanks a lot for the review @asb !

Jul 26 2018, 11:52 PM

Jul 23 2018

rogfer01 created D49661: [RISCV] Add "lla" pseudo-instruction to assembler.
Jul 23 2018, 3:46 AM

Jul 2 2018

rogfer01 accepted D48846: [ARM] Fix PR37382: Don't optimize mul.with.overflow on thumbv6m..

Ah, I didn't notice it was exactly the same. You're right no need to add it again.

Jul 2 2018, 12:50 PM
rogfer01 added a comment to D48846: [ARM] Fix PR37382: Don't optimize mul.with.overflow on thumbv6m..

Thanks a lot for the patch @pftbest!

Jul 2 2018, 12:45 PM
rogfer01 added a comment to D40922: [ARM] Optimize {s|u}mul.with.overflow..

Thanks @alexcrichton . I cannot login to bugzilla yet (I'd reply there instead, hope I can soon). Looks like {S,U}MUL_LOHI are expanded in Thumb1 so a stop-gap approach could be not implementing this optimisation in that subtarget.

Jul 2 2018, 2:39 AM

Jun 27 2018

rogfer01 added a comment to D48357: [RISCV] Remove duplicated logic when determining the target ABI.

Ping?

Jun 27 2018, 9:00 PM
rogfer01 added a comment to D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand.

@rjmccall because we do not want to impact the clients of ABIArgInfo I thought of two possible approaches

Jun 27 2018, 6:42 AM
rogfer01 updated the diff for D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand.

ChangeLog:

  • Use a ConstantDataArray instead of a struct of types.
  • Use LLVM_IS_TRIVIALLY_COPYABLE
Jun 27 2018, 6:19 AM
rogfer01 added a dependency for D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand: D48643: Define LLVM_IS_TRIVIALLY_COPYABLE.
Jun 27 2018, 6:12 AM
rogfer01 added a dependent revision for D48643: Define LLVM_IS_TRIVIALLY_COPYABLE: D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand.
Jun 27 2018, 6:12 AM
rogfer01 created D48643: Define LLVM_IS_TRIVIALLY_COPYABLE.
Jun 27 2018, 6:12 AM

Jun 26 2018

rogfer01 added inline comments to D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand.
Jun 26 2018, 2:03 PM
rogfer01 added inline comments to D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand.
Jun 26 2018, 2:38 AM
rogfer01 created D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand.
Jun 26 2018, 2:37 AM

Jun 22 2018

rogfer01 added a comment to D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes.

Thanks for the review @efriedma

Jun 22 2018, 12:42 AM

Jun 20 2018

rogfer01 added inline comments to D48357: [RISCV] Remove duplicated logic when determining the target ABI.
Jun 20 2018, 3:56 AM
rogfer01 created D48357: [RISCV] Remove duplicated logic when determining the target ABI.
Jun 20 2018, 3:54 AM
rogfer01 added a comment to D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes.

Ping?

Jun 20 2018, 12:20 AM

Jun 18 2018

rogfer01 added 1 commit(s) for D47926: [RISCV] Add tests for overflow intrinsics: rL335023: [RISCV] Add tests for overflow intrinsics.
Jun 18 2018, 11:53 PM
rogfer01 added an edge to rL335023: [RISCV] Add tests for overflow intrinsics: D47926: [RISCV] Add tests for overflow intrinsics.
Jun 18 2018, 11:53 PM
rogfer01 closed D47926: [RISCV] Add tests for overflow intrinsics.

Oops, I forgot to add the Differential URL in the commit.

Jun 18 2018, 11:52 PM
rogfer01 committed rL335023: [RISCV] Add tests for overflow intrinsics.
[RISCV] Add tests for overflow intrinsics
Jun 18 2018, 11:50 PM
rogfer01 updated the diff for D47926: [RISCV] Add tests for overflow intrinsics.

Thanks for the review @asb !

Jun 18 2018, 11:48 PM

Jun 7 2018

rogfer01 added a dependent revision for D47926: [RISCV] Add tests for overflow intrinsics: D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes.
Jun 7 2018, 10:36 PM
rogfer01 added a dependency for D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes: D47926: [RISCV] Add tests for overflow intrinsics.
Jun 7 2018, 10:36 PM
rogfer01 created D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes.
Jun 7 2018, 10:34 PM
rogfer01 created D47926: [RISCV] Add tests for overflow intrinsics.
Jun 7 2018, 10:28 PM

Jun 5 2018

rogfer01 added inline comments to D47730: [SelectionDAG]Reduce masked data movement chains and memory access widths pt3.
Jun 5 2018, 1:11 PM · Restricted Project
rogfer01 added inline comments to D46749: [SelectionDAG]Reduce masked data movement chains and memory access widths.
Jun 5 2018, 1:05 PM

May 26 2018

rogfer01 accepted D47387: [ARM] Enable SETCCCARRY lowering for Thumb1..

Thanks @efriedma looks good to me.

May 26 2018, 3:08 AM

May 14 2018

Herald added a reviewer for D44975: Change DEBUG() macro to LLVM_DEBUG(): javed.absar.
May 14 2018, 8:27 AM

Apr 26 2018

rogfer01 edited reviewers for D46110: [IR] Do not assume that function pointers are aligned, added: efriedma; removed: eli.friedman.
Apr 26 2018, 2:44 AM

Apr 25 2018

rogfer01 added inline comments to D44781: [IR] Add function pointer alignment to DataLayout.
Apr 25 2018, 7:45 AM
rogfer01 added a reviewer for D44781: [IR] Add function pointer alignment to DataLayout: efriedma.
Apr 25 2018, 7:45 AM

Apr 23 2018

rogfer01 added a reviewer for D45965: [Targets] Implement getConstraintRegister for ARM and AArch64: thopre.
Apr 23 2018, 8:15 AM

Apr 17 2018

rogfer01 added a reviewer for D31139: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed with EHABI: keith.walker.arm.
Apr 17 2018, 1:51 PM

Apr 15 2018

rogfer01 added a comment to D45647: Limit the MaxSteps used in hasPredessorHelper.

Hi Tom,

Apr 15 2018, 10:26 PM

Apr 12 2018

rogfer01 added a comment to D45255: [CodeGen] Add an option to suppress output of llvm.ident.

There is a flag -fno-ident that has the same effect in GCC https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fno-ident although it involves also ignoring the #ident.

Apr 12 2018, 7:12 AM

Mar 1 2018

rogfer01 accepted D43572: [Sema] Improve test coverage of narrowing conversion diagnostics.

Looks good to me. Thanks!

Mar 1 2018, 5:31 AM

Feb 20 2018

rogfer01 accepted D43289: [vim] Recognize more FileCheck comments.

LGTM now. Thanks!

Feb 20 2018, 9:16 AM

Feb 19 2018

rogfer01 accepted D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

Thanks a lot Marten.

Feb 19 2018, 3:48 AM
rogfer01 added inline comments to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.
Feb 19 2018, 1:27 AM

Feb 16 2018

rogfer01 accepted D42545: [Sema] Classify conversions from enum to float as narrowing.

Looks good to me now. Wait a couple of days before submitting it just in case the other reviewers have more comments.

Feb 16 2018, 9:04 AM
rogfer01 added a comment to D34515: [ARM] Materialise some boolean values to avoid a branch.

Let's see how this one goes :)

Feb 16 2018, 1:28 AM
rogfer01 committed rL325323: [ARM] Materialise some boolean values to avoid a branch.
[ARM] Materialise some boolean values to avoid a branch
Feb 16 2018, 1:26 AM
rogfer01 closed D34515: [ARM] Materialise some boolean values to avoid a branch.
Feb 16 2018, 1:26 AM
rogfer01 updated the diff for D34515: [ARM] Materialise some boolean values to avoid a branch.

ChangeLog:

  • Rebase with ToT
Feb 16 2018, 12:55 AM

Feb 15 2018

rogfer01 added inline comments to D34515: [ARM] Materialise some boolean values to avoid a branch.
Feb 15 2018, 5:47 AM

Feb 14 2018

rogfer01 added inline comments to D43304: [DebugInfo] Accept enumeration types without underlying inetger type present in debug info metadata.
Feb 14 2018, 11:07 AM
rogfer01 added reviewers for D43289: [vim] Recognize more FileCheck comments: chandlerc, compnerd.
Feb 14 2018, 6:49 AM
rogfer01 added a comment to D43289: [vim] Recognize more FileCheck comments.

Can you coalesce them in a single regular expression, like /;\s*CHECK-(NEXT|NOT|DAG|SAME|LABEL): (not sure if this is the right syntax but I hope you got the idea.

Feb 14 2018, 6:26 AM
rogfer01 added a reviewer for D43282: [LegalizeDAG] Fix legalization of SETCC: efriedma.
Feb 14 2018, 4:02 AM

Feb 9 2018

rogfer01 accepted D42969: [Sema] Fix decltype of static data members.

This LGTM. Thanks for fixing this.

Feb 9 2018, 10:07 AM

Feb 7 2018

rogfer01 added a comment to D34515: [ARM] Materialise some boolean values to avoid a branch.

Ping :-)

Feb 7 2018, 2:04 PM

Feb 6 2018

rogfer01 added a comment to D42545: [Sema] Classify conversions from enum to float as narrowing.

I understand you're fixing the narrowing check from "unscoped enum/integer type" → float.

Feb 6 2018, 4:04 AM