rogfer01 (Roger Ferrer Ibanez)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2016, 6:42 AM (110 w, 5 d)

Recent Activity

Fri, Jun 22

rogfer01 added a comment to D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes.

Thanks for the review @efriedma

Fri, Jun 22, 12:42 AM

Wed, Jun 20

rogfer01 added inline comments to D48357: [RISCV] Remove duplicated logic when determining the target ABI.
Wed, Jun 20, 3:56 AM
rogfer01 created D48357: [RISCV] Remove duplicated logic when determining the target ABI.
Wed, Jun 20, 3:54 AM
rogfer01 added a comment to D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes.

Ping?

Wed, Jun 20, 12:20 AM

Mon, Jun 18

rogfer01 added 1 commit(s) for D47926: [RISCV] Add tests for overflow intrinsics: rL335023: [RISCV] Add tests for overflow intrinsics.
Mon, Jun 18, 11:53 PM
rogfer01 added an edge to rL335023: [RISCV] Add tests for overflow intrinsics: D47926: [RISCV] Add tests for overflow intrinsics.
Mon, Jun 18, 11:53 PM
rogfer01 closed D47926: [RISCV] Add tests for overflow intrinsics.

Oops, I forgot to add the Differential URL in the commit.

Mon, Jun 18, 11:52 PM
rogfer01 committed rL335023: [RISCV] Add tests for overflow intrinsics.
[RISCV] Add tests for overflow intrinsics
Mon, Jun 18, 11:50 PM
rogfer01 updated the diff for D47926: [RISCV] Add tests for overflow intrinsics.

Thanks for the review @asb !

Mon, Jun 18, 11:48 PM

Thu, Jun 7

rogfer01 added a dependent revision for D47926: [RISCV] Add tests for overflow intrinsics: D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes.
Thu, Jun 7, 10:36 PM
rogfer01 added a dependency for D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes: D47926: [RISCV] Add tests for overflow intrinsics.
Thu, Jun 7, 10:36 PM
rogfer01 created D47927: [RISCV] Custom lower ISD::{U,S}{ADD,SUB}O nodes.
Thu, Jun 7, 10:34 PM
rogfer01 created D47926: [RISCV] Add tests for overflow intrinsics.
Thu, Jun 7, 10:28 PM

Tue, Jun 5

rogfer01 added inline comments to D47730: [SelectionDAG]Reduce masked data movement chains and memory access widths pt3.
Tue, Jun 5, 1:11 PM · Restricted Project
rogfer01 added inline comments to D46749: [SelectionDAG]Reduce masked data movement chains and memory access widths.
Tue, Jun 5, 1:05 PM

Sat, May 26

rogfer01 accepted D47387: [ARM] Enable SETCCCARRY lowering for Thumb1..

Thanks @efriedma looks good to me.

Sat, May 26, 3:08 AM

May 14 2018

Herald added a reviewer for D44975: Change DEBUG() macro to LLVM_DEBUG(): javed.absar.
May 14 2018, 8:27 AM

Apr 26 2018

rogfer01 edited reviewers for D46110: [IR] Do not assume that function pointers are aligned, added: efriedma; removed: eli.friedman.
Apr 26 2018, 2:44 AM

Apr 25 2018

rogfer01 added inline comments to D44781: [IR] Add function pointer alignment to DataLayout.
Apr 25 2018, 7:45 AM
rogfer01 added a reviewer for D44781: [IR] Add function pointer alignment to DataLayout: efriedma.
Apr 25 2018, 7:45 AM

Apr 23 2018

rogfer01 added a reviewer for D45965: [Targets] Implement getConstraintRegister for ARM and AArch64: thopre.
Apr 23 2018, 8:15 AM

Apr 17 2018

rogfer01 added a reviewer for D31139: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed with EHABI: keith.walker.arm.
Apr 17 2018, 1:51 PM

Apr 15 2018

rogfer01 added a comment to D45647: Limit the MaxSteps used in hasPredessorHelper.

Hi Tom,

Apr 15 2018, 10:26 PM

Apr 12 2018

rogfer01 added a comment to D45255: [CodeGen] Add an option to suppress output of llvm.ident.

There is a flag -fno-ident that has the same effect in GCC https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fno-ident although it involves also ignoring the #ident.

Apr 12 2018, 7:12 AM

Mar 1 2018

rogfer01 accepted D43572: [Sema] Improve test coverage of narrowing conversion diagnostics.

Looks good to me. Thanks!

Mar 1 2018, 5:31 AM

Feb 20 2018

rogfer01 accepted D43289: [vim] Recognize more FileCheck comments.

LGTM now. Thanks!

Feb 20 2018, 9:16 AM

Feb 19 2018

rogfer01 accepted D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.

Thanks a lot Marten.

Feb 19 2018, 3:48 AM
rogfer01 added inline comments to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.
Feb 19 2018, 1:27 AM

Feb 16 2018

rogfer01 accepted D42545: [Sema] Classify conversions from enum to float as narrowing.

Looks good to me now. Wait a couple of days before submitting it just in case the other reviewers have more comments.

Feb 16 2018, 9:04 AM
rogfer01 added a comment to D34515: [ARM] Materialise some boolean values to avoid a branch.

Let's see how this one goes :)

Feb 16 2018, 1:28 AM
rogfer01 committed rL325323: [ARM] Materialise some boolean values to avoid a branch.
[ARM] Materialise some boolean values to avoid a branch
Feb 16 2018, 1:26 AM
rogfer01 closed D34515: [ARM] Materialise some boolean values to avoid a branch.
Feb 16 2018, 1:26 AM
rogfer01 updated the diff for D34515: [ARM] Materialise some boolean values to avoid a branch.

ChangeLog:

  • Rebase with ToT
Feb 16 2018, 12:55 AM

Feb 15 2018

rogfer01 added inline comments to D34515: [ARM] Materialise some boolean values to avoid a branch.
Feb 15 2018, 5:47 AM

Feb 14 2018

rogfer01 added inline comments to D43304: [DebugInfo] Accept enumeration types without underlying inetger type present in debug info metadata.
Feb 14 2018, 11:07 AM
rogfer01 added reviewers for D43289: [vim] Recognize more FileCheck comments: chandlerc, compnerd.
Feb 14 2018, 6:49 AM
rogfer01 added a comment to D43289: [vim] Recognize more FileCheck comments.

Can you coalesce them in a single regular expression, like /;\s*CHECK-(NEXT|NOT|DAG|SAME|LABEL): (not sure if this is the right syntax but I hope you got the idea.

Feb 14 2018, 6:26 AM
rogfer01 added a reviewer for D43282: [LegalizeDAG] Fix legalization of SETCC: efriedma.
Feb 14 2018, 4:02 AM

Feb 9 2018

rogfer01 accepted D42969: [Sema] Fix decltype of static data members.

This LGTM. Thanks for fixing this.

Feb 9 2018, 10:07 AM

Feb 7 2018

rogfer01 added a comment to D34515: [ARM] Materialise some boolean values to avoid a branch.

Ping :-)

Feb 7 2018, 2:04 PM

Feb 6 2018

rogfer01 added a comment to D42545: [Sema] Classify conversions from enum to float as narrowing.

I understand you're fixing the narrowing check from "unscoped enum/integer type" → float.

Feb 6 2018, 4:04 AM

Jan 31 2018

rogfer01 added a comment to D34515: [ARM] Materialise some boolean values to avoid a branch.

@efriedma @samparker any further comments on this change? We can add more clz-like tricks in later changes if needed.

Jan 31 2018, 11:52 AM
rogfer01 committed rL323857: [ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR..
[ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR.
Jan 31 2018, 1:26 AM
rogfer01 closed D42051: [ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR..
Jan 31 2018, 1:25 AM
rogfer01 added a comment to D42051: [ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR..

Thank you very much @efriedma !

Jan 31 2018, 1:25 AM

Jan 29 2018

rogfer01 added a comment to D42051: [ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR..

Ping :-)

Jan 29 2018, 1:34 PM
rogfer01 added inline comments to D42574: [ARM] Lower lower saturate to 0 and lower saturate to -1 using bit-operations.
Jan 29 2018, 1:55 AM

Jan 24 2018

rogfer01 updated the diff for D34515: [ARM] Materialise some boolean values to avoid a branch.

ChangeLog:

  • Remove whitespace and unused variables in LowerADDSUBCARRY
Jan 24 2018, 9:30 AM
rogfer01 updated the diff for D34515: [ARM] Materialise some boolean values to avoid a branch.

ChangeLog:

  • Change ConvertBooleanCarryToCarryFlag to use ARMISD::SUBC x, 1 instead of ARMISD::ADDC x, ~0, this way a single combiner in PerformAddcSubcCombine is enough.
  • Do not use ISD::SUBCARRY if the third operand is a zero. While the generic combiner can lower this to ISD::USUBO it may not have a chance to run before we lower that ISD::SUBCARRY.
Jan 24 2018, 8:29 AM

Jan 22 2018

rogfer01 added inline comments to D34515: [ARM] Materialise some boolean values to avoid a branch.
Jan 22 2018, 10:33 AM
rogfer01 updated the diff for D42051: [ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR..

Update patch based on the review comments.

Jan 22 2018, 6:57 AM

Jan 18 2018

rogfer01 accepted D42175: [AArch64][GlobalISel] Add isel support for global values in the large code model.

Hi @aemerson thanks a lot for the prompt fix.

Jan 18 2018, 10:52 AM
rogfer01 updated the diff for D42051: [ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR..

Hi @efriedma gluing the nodes is too disruptive so I am exploring one of the alternatives you suggested. What do you think, does this look workable?

Jan 18 2018, 8:40 AM

Jan 16 2018

rogfer01 added a comment to D42051: [ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR..

Hi @efriedma thanks a lot for the suggestions and the testcase. I already considered gluing though it impacts scheduling and the change will be noisy for tests but I'll look into your other suggestions too.

Jan 16 2018, 3:54 AM

Jan 15 2018

rogfer01 added a comment to D34515: [ARM] Materialise some boolean values to avoid a branch.

Ping. Modulo the bugs we may find with ADDCARRY / SUBCARRY further thoughts on this?

Jan 15 2018, 12:30 AM
rogfer01 created D42051: [ARM] Allow the scheduler to clone a node with glue to avoid a copy CPSR ↔ GPR..
Jan 15 2018, 12:25 AM

Jan 12 2018

rogfer01 accepted D38378: [ARM] Optimize {s,u}{add,sub}.with.overflow..

LGTM. Wait a couple of days before commiting just in case @efriedma has further comments.

Jan 12 2018, 3:50 AM

Jan 10 2018

rogfer01 accepted D40922: [ARM] Optimize {s|u}mul.with.overflow..

LGTM. Please wait a couple of days before submitting just in case @efriedma has further comments.

Jan 10 2018, 10:48 AM
rogfer01 added inline comments to D41775: [ARM] Add codegen for SMMULR, SMMLAR and SMMLSR.
Jan 10 2018, 12:58 AM

Dec 15 2017

rogfer01 added a comment to D41122: Tests for D34515.

Thanks @efriedma !

Dec 15 2017, 1:26 AM
rogfer01 committed rL320795: [ARM] Add tests for D34515.
[ARM] Add tests for D34515
Dec 15 2017, 1:25 AM
rogfer01 closed D41122: Tests for D34515.
Dec 15 2017, 1:25 AM

Dec 14 2017

rogfer01 updated the diff for D34515: [ARM] Materialise some boolean values to avoid a branch.

ChangeLog

  • New tests in D41122 are now updated in this change to show the change in codegen
Dec 14 2017, 9:29 AM
rogfer01 added a dependent revision for D41122: Tests for D34515: D34515: [ARM] Materialise some boolean values to avoid a branch.
Dec 14 2017, 9:28 AM
rogfer01 added a dependency for D34515: [ARM] Materialise some boolean values to avoid a branch: D41122: Tests for D34515.
Dec 14 2017, 9:28 AM
rogfer01 removed a dependent revision for D34515: [ARM] Materialise some boolean values to avoid a branch: D41122: Tests for D34515.
Dec 14 2017, 9:28 AM
rogfer01 removed a dependency for D41122: Tests for D34515: D34515: [ARM] Materialise some boolean values to avoid a branch.
Dec 14 2017, 9:28 AM
rogfer01 updated the diff for D41122: Tests for D34515.

ChangeLog:

  • New tests before D34515 is applied showing current codegen (and not after like I did the last time)
Dec 14 2017, 9:27 AM

Dec 13 2017

rogfer01 added inline comments to D41179: [Sema] Diagnose template specializations with C linkage.
Dec 13 2017, 11:34 AM
rogfer01 added inline comments to D41179: [Sema] Diagnose template specializations with C linkage.
Dec 13 2017, 8:32 AM
rogfer01 committed rL320567: [DAG] Promote ADDCARRY / SUBCARRY.
[DAG] Promote ADDCARRY / SUBCARRY
Dec 13 2017, 2:46 AM
rogfer01 closed D38942: [DAG] Promote ADDCARRY / SUBCARRY.
Dec 13 2017, 2:46 AM
rogfer01 added a comment to D41122: Tests for D34515.

Oh, that makes a lot of sense. I'll do. Sorry for the misunderstanding.

Dec 13 2017, 1:46 AM
rogfer01 added inline comments to D35635: [ARM] Optimize {s,u}{add,sub}.with.overflow.
Dec 13 2017, 12:28 AM

Dec 12 2017

rogfer01 updated the diff for D34515: [ARM] Materialise some boolean values to avoid a branch.

ChangeLog:

  • I forgot to update the Thumb counterpart of long-setcc.ll in the last update
Dec 12 2017, 10:34 AM
rogfer01 updated the diff for D34515: [ARM] Materialise some boolean values to avoid a branch.

ChangeLog

  • Split tests in D41122
  • Improve test long-setcc.ll
Dec 12 2017, 10:27 AM
rogfer01 added a dependency for D41122: Tests for D34515: D34515: [ARM] Materialise some boolean values to avoid a branch.
Dec 12 2017, 10:26 AM
rogfer01 added a dependent revision for D34515: [ARM] Materialise some boolean values to avoid a branch: D41122: Tests for D34515.
Dec 12 2017, 10:26 AM
rogfer01 created D41122: Tests for D34515.
Dec 12 2017, 10:25 AM
rogfer01 added inline comments to D38942: [DAG] Promote ADDCARRY / SUBCARRY.
Dec 12 2017, 1:43 AM
rogfer01 updated the diff for D38942: [DAG] Promote ADDCARRY / SUBCARRY.

ChangeLog

  • Sign extend operands as we will want to use the higher bits (they could be rubbish in the previous diff). Add a comment.
Dec 12 2017, 1:41 AM

Dec 11 2017

rogfer01 added a comment to D38942: [DAG] Promote ADDCARRY / SUBCARRY.

We want to do here is to calculate the ADDCARRY / SUBCARRY with a wider type and then use that result to compute the carry/borrow. I think that by sign extension of the operands, the carry/borrow of wider operation should exactly be the same as in a narrower type:

Dec 11 2017, 10:15 AM
rogfer01 committed rCXX320363: [libcxx] Define istream_iterator equality comparison operators out-of-line.
[libcxx] Define istream_iterator equality comparison operators out-of-line
Dec 11 2017, 6:01 AM
rogfer01 committed rL320363: [libcxx] Define istream_iterator equality comparison operators out-of-line.
[libcxx] Define istream_iterator equality comparison operators out-of-line
Dec 11 2017, 5:55 AM
rogfer01 closed D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line by committing rL320363: [libcxx] Define istream_iterator equality comparison operators out-of-line.
Dec 11 2017, 5:55 AM
rogfer01 committed rL320355: [ARM] Use ADDCARRY / SUBCARRY.
[ARM] Use ADDCARRY / SUBCARRY
Dec 11 2017, 4:14 AM
rogfer01 closed D35192: [ARM] Use ADDCARRY / SUBCARRY by committing rL320355: [ARM] Use ADDCARRY / SUBCARRY.
Dec 11 2017, 4:14 AM
rogfer01 added a comment to D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line.

Hi @miyuki I can commit it.

Dec 11 2017, 2:29 AM
rogfer01 added inline comments to D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!).
Dec 11 2017, 1:43 AM · Restricted Project, Restricted Project

Dec 8 2017

rogfer01 added inline comments to D40922: [ARM] Optimize {s|u}mul.with.overflow..
Dec 8 2017, 10:35 AM
rogfer01 added inline comments to D35635: [ARM] Optimize {s,u}{add,sub}.with.overflow.
Dec 8 2017, 12:44 AM

Dec 7 2017

rogfer01 added a comment to D38942: [DAG] Promote ADDCARRY / SUBCARRY.

The generic combiner DAGCombiner::visitTRUNCATE does this

Dec 7 2017, 11:06 AM
rogfer01 requested review of D35192: [ARM] Use ADDCARRY / SUBCARRY.
Dec 7 2017, 10:41 AM
rogfer01 updated the diff for D35192: [ARM] Use ADDCARRY / SUBCARRY.
  • Fix combiner with addcarry that causes PR35103
  • Add regression test
Dec 7 2017, 10:40 AM
rogfer01 added inline comments to D35635: [ARM] Optimize {s,u}{add,sub}.with.overflow.
Dec 7 2017, 6:23 AM
rogfer01 committed rC320017: Ignore pointers to incomplete types when diagnosing misaligned addresses.
Ignore pointers to incomplete types when diagnosing misaligned addresses
Dec 7 2017, 1:24 AM
rogfer01 committed rL320017: Ignore pointers to incomplete types when diagnosing misaligned addresses.
Ignore pointers to incomplete types when diagnosing misaligned addresses
Dec 7 2017, 1:24 AM
rogfer01 closed D40895: Ignore pointers to incomplete types when diagnosing misaligned addresses by committing rL320017: Ignore pointers to incomplete types when diagnosing misaligned addresses.
Dec 7 2017, 1:24 AM
rogfer01 added a comment to D38378: [ARM] Optimize {s,u}{add,sub}.with.overflow..

This looks sensible to me. Extend the comment in that --E; above at line 2732. If @efriedma or @rengolin do not have further comments I believe this is ready to land.

Dec 7 2017, 1:00 AM

Dec 6 2017

rogfer01 added a comment to D35192: [ARM] Use ADDCARRY / SUBCARRY.

We believe there is a problem here as the generic combiner presumes we're going to use the first result (0) but actually the code is using the second (1)

Dec 6 2017, 10:41 AM