The updated testcase does not fail locally anymore.

Thanks I will do it shortly.

I can commit it.

Thanks for the review!

on a second thought, "InstalledDir" only appears with -v, and is still too fragile (e.g if installed dir name also contains checked strings)

Sure, I didn't mean to do that broader change here. Apologies if it read that way.

Thanks for reopening this @kristina.

Oh this is great! Scales much better than my earlier hack. Thanks a lot @asb !

If I'm understanding correctly, the problem here is that the lui has to have the address of the auipc as a parameter.

ChangeLog:

• Align syntax

Thanks for the prompt review @asb!

Thanks for the review @asb

ChangeLog

• Add test for ConstantPools

Thanks for the update @kito-cheng . Some more comments inline as the change is propagating a mistake of mine I introduced in rL339314 (fixed in rL339654).

Hi, thanks a lot for the patch. A few comments inline.

Thanks for the review @asb . I will commit soon.

Thanks @asb for the review!

Fixed in rL338341

Thanks a lot for the review @asb !

Ah, I didn't notice it was exactly the same. You're right no need to add it again.

Thanks a lot for the patch @pftbest!

Thanks @alexcrichton . I cannot login to bugzilla yet (I'd reply there instead, hope I can soon). Looks like {S,U}MUL_LOHI are expanded in Thumb1 so a stop-gap approach could be not implementing this optimisation in that subtarget.

Ping?

@rjmccall because we do not want to impact the clients of ABIArgInfo I thought of two possible approaches

ChangeLog:

• Use a ConstantDataArray instead of a struct of types.
• Use LLVM_IS_TRIVIALLY_COPYABLE

Thanks for the review @efriedma

Ping?

Oops, I forgot to add the Differential URL in the commit.

Thanks for the review @asb !

Thanks @efriedma looks good to me.

Hi Tom,

There is a flag -fno-ident that has the same effect in GCC https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fno-ident although it involves also ignoring the #ident.

Looks good to me. Thanks!

LGTM now. Thanks!

Thanks a lot Marten.

Looks good to me now. Wait a couple of days before submitting it just in case the other reviewers have more comments.

Let's see how this one goes :)

ChangeLog:

• Rebase with ToT

Can you coalesce them in a single regular expression, like /;\s*CHECK-(NEXT|NOT|DAG|SAME|LABEL): (not sure if this is the right syntax but I hope you got the idea.

This LGTM. Thanks for fixing this.

Ping :-)

I understand you're fixing the narrowing check from "unscoped enum/integer type" → float.